)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b47ea643013e667dbe99ab95c0a33b137f1c4577","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6732bf4b_0b7f83b4","updated":"2021-11-09 14:07:48.000000000","message":"The patch of fenix have been merged.\nhttps://review.opendev.org/c/x/fenix/+/816974\n\nFor sol-kubernetes job, we need to create an admin endpoint for keystone.","commit_id":"cf1c23d1ff9c9e614d32bc2208306ce07826a214"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3a685674f4884289fe8664275514f322235f65a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b7187cfc_665b43fd","updated":"2021-11-10 00:08:14.000000000","message":"Thanks for your patch,working fine in local env.","commit_id":"9bb258a69eb615f5342b66d37c155dee797d86af"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"09c45065e9e18064c8555a9f2a73b78c5c2d1fa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bd00f32b_1844771e","updated":"2021-11-15 19:17:21.000000000","message":"Just an information. I\u0027ve found the error is caused because a unresolved reference `types_typedecorator` was introduced in [1] in sqlalchemy. It\u0027s not a failure in tacker, but sqlalchemy itself. I don\u0027t have been understand the expected behavior of `:ref:` yet, but I can pass the test if I remove all refs `types_typedecorator` in `sqlalchemy/lib/sqlalchemy/sql/type_api.py`.\n\n[1] commit 605d0d905855684bfe4409532af98f336ae38f82                                                                                         \nAuthor: Mike Bayer \u003cmike_mp@zzzcomputing.com\u003e                                                                                           \nDate:   Sat Oct 23 20:36:41 2021 -0400","commit_id":"dab351394c20faa520b75351f8239166abbfee15"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"dbe153709f1ebe9f2753fde5aafa0711551cc34b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c1c08f99_1a93d48e","updated":"2021-11-15 08:52:51.000000000","message":"Sorry for the delay, LGTM.","commit_id":"dab351394c20faa520b75351f8239166abbfee15"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"bb2a7bc63240d6535360c3572dcc2af43006ae04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a6df4453_9a2feed4","updated":"2021-11-10 05:06:43.000000000","message":"Thanks for your comments, could you confirm my fixes?","commit_id":"dab351394c20faa520b75351f8239166abbfee15"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3889e51ccc96bfb0494f4494b7bfe9225b705df9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f3db9e63_6f915d5d","updated":"2021-11-11 18:17:49.000000000","message":"lgtm, it was long pending cleanup from devstack side but let\u0027s merge this to unblock the tacker gate.","commit_id":"dab351394c20faa520b75351f8239166abbfee15"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"357fcdc6984e70c784874183ab162ac9662c4832","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aa1ad2b2_1d2380ca","updated":"2021-11-12 05:14:19.000000000","message":"ping\n\nToshiaki-san,\nCould you review this patch to pass Tacker CI, ASAP?","commit_id":"dab351394c20faa520b75351f8239166abbfee15"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"de769301cd86ced58aa9952c3ab9124889ab1a31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f14eb15a_0b7162d4","updated":"2021-11-10 04:55:08.000000000","message":"recheck","commit_id":"dab351394c20faa520b75351f8239166abbfee15"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8fa9c2a3aae80c7fdb7c56e2464fc29870dea1ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fdadb9b2_b5ee1a89","updated":"2021-11-15 09:47:28.000000000","message":"recheck","commit_id":"dab351394c20faa520b75351f8239166abbfee15"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ea7368fe8fc05e9e8531915d57e509532b09d573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bacc42da_3dd00eb9","updated":"2021-11-16 06:43:11.000000000","message":"I excluded \"SQLAlchemy 1.4.27\" from requirements on PS6 no longer matches \"openstack/requirements\" and results in an error.\n\nThis error of tox-docs job seems to be problem between SQLAlchemy and Sphinx, so I think following resolutions:\n1. Error point is db/types.py. Therefore this error can fix by db/types.py sphinx-apidoc.\n   And I posted the patch [1] and test is passed.\n   [1] https://review.opendev.org/c/openstack/tacker/+/817953\n2. Exclude \"SQLAlchemy 1.4.27\" from openstack/requrements.\n\nSince the gate of many patches is stopped, first of all, I think that 1. should be implemented as a workaround in tacker.","commit_id":"22a75aebb4eebd4e17dd49e1968ef9e5d4fddf02"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d0c685063a6057cac1f07e79dfd7688051f51514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a11fdcfe_5d2d6e2c","in_reply_to":"bacc42da_3dd00eb9","updated":"2021-11-16 08:05:53.000000000","message":"I understand specifying the version excluded does not work for conflicting with global requirements as we expected. In my opinion, second option is still considerable although other projects are not suffered with the problem. It might be why it\u0027s only happened in tacker is because other projects don\u0027t depend on `tacker.db.types.Json.process_bind_param`.\n\nFirst options might be easy to fix it locally for tacker. I\u0027ll check your another update anyway. Thanks.","commit_id":"22a75aebb4eebd4e17dd49e1968ef9e5d4fddf02"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"bd410bf018a947d631d8f89cba657de64f5d79c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cf778d88_0f72898e","updated":"2021-11-18 00:35:15.000000000","message":"umm.. another new problem is occurring..\n```\n+ lib/neutron_plugins/services/qos:configure_qos:20 :   configure_qos_core_plugin\n+ lib/neutron_plugins/services/qos:configure_qos_core_plugin:9 :   configure_qos_ml2\n/opt/stack/devstack/lib/neutron_plugins/services/qos: line 9: configure_qos_ml2: command not found\n```\n\nThis error seems to occur since devstack patch [1] was merged on Nov 14. \n[1] Rehome functions to enable Neutron\u0027s QoS service\n    https://review.opendev.org/c/openstack/devstack/+/815686\n\nIt\u0027s clearly a devstack bug, but it doesn\u0027t seem to have a corresponding patch yet.\nIt is commented in [1] as follows:\n```\nconfigure_qos_ml2 function was missed so neutron\u0027s devstack plugin is still required...\n```\nSo, we need to wait for the fixing bug.","commit_id":"450eb11bb6a6f762bf05ce457416aa9b54b4bb76"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"47a95c45e5e8eb9bc1b67b3ccbfb7a56ec103055","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"693a4d27_b5ff8021","in_reply_to":"01f04961_b9fc0f4d","updated":"2021-11-18 17:34:13.000000000","message":"yeah,I am on this and will the devstack patch after gater result.","commit_id":"450eb11bb6a6f762bf05ce457416aa9b54b4bb76"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"813d9291d845584f16e6820418a0abce2ecf141f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"01f04961_b9fc0f4d","in_reply_to":"cf778d88_0f72898e","updated":"2021-11-18 10:09:36.000000000","message":"devstack patch that fixes this issue was posted a little while ago!\nhttps://review.opendev.org/c/openstack/devstack/+/818355\n\nI will continue to watch the progress.","commit_id":"450eb11bb6a6f762bf05ce457416aa9b54b4bb76"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5f5bee3eb9000e8788841b0dd007fd527880b1fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f677571c_2b032f30","updated":"2021-11-18 21:07:51.000000000","message":"recheck","commit_id":"ee74fe02c77a2083446f75594cf591cf5984adcb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"47a95c45e5e8eb9bc1b67b3ccbfb7a56ec103055","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"167a6283_2e71e3eb","updated":"2021-11-18 17:34:13.000000000","message":"recheck depends-on updated","commit_id":"ee74fe02c77a2083446f75594cf591cf5984adcb"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9f8f7cfd6d47ab6308c6b1dbef5ce23477d3bc74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"04940315_6c702e50","updated":"2021-11-19 01:16:18.000000000","message":"umm.. The devstack patch seems to work fine.\nHowever, another new error is occurring in \"Setup default VIM resources\" phase..\n```\nInstalling collected packages: python-tackerclient\nSuccessfully installed python-tackerclient-1.8.0\nWARNING: Running pip as the \u0027root\u0027 user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv\nSet up target openstack vim resources ...\n\n\nThe request you have made requires authentication. (HTTP 401) (Request-ID: req-b79dbc94-4dda-4db5-b4e8-dd19e5c90bd7)\nError on exit\n```","commit_id":"ee74fe02c77a2083446f75594cf591cf5984adcb"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8ef549ed55c0bec69f7b234405b0d9f35d10b2e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ee938352_bb6a22b4","updated":"2021-11-19 02:23:23.000000000","message":"Depends-On patch (https://review.opendev.org/c/openstack/devstack/+/818355) was merged.\nSo I removed it from commit message.","commit_id":"eb9f659de62234b3b0506ecdcd1d5123f1ff5a36"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b196ba79bbcfc5a3df7d5985dfffabd7eecf9af0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bd779822_f87061bb","updated":"2021-11-19 10:01:35.000000000","message":"I\u0027m testing to resolve the following error on another patch.\n```\nThe request you have made requires authentication. (HTTP 401) (Request-ID: req-b79dbc94-4dda-4db5-b4e8-dd19e5c90bd7)\n```\nhttps://review.opendev.org/c/openstack/tacker/+/818500\n\nPlease let me know if you know anything!","commit_id":"eb9f659de62234b3b0506ecdcd1d5123f1ff5a36"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"019227244c3eace90710b0dbda2488ea1689e729","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a2ecb549_800bd3e2","updated":"2021-11-22 14:41:58.000000000","message":"Many thanks!","commit_id":"975cce621e732deb2ea5daf86a6281aecbb955bc"}],"devstack/lib/tacker":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2ce261c0e806ee46584ebe08bc2a14f1706f2f35","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            \"$TACKER_PROTOCOL://$TACKER_HOST:$TACKER_PORT/\" \\"},{"line_number":142,"context_line":"            \"$TACKER_PROTOCOL://$TACKER_HOST:$TACKER_PORT/\""},{"line_number":143,"context_line":"    fi"},{"line_number":144,"context_line":"    # Create admin and internal endpoints for keystone. Tacker currently uses"},{"line_number":145,"context_line":"    # the admin endpoint to interact with keystone, but devstack stopped"},{"line_number":146,"context_line":"    # creating one in https://review.opendev.org/c/openstack/devstack/+/777345"},{"line_number":147,"context_line":"    KEYSTONE_SERVICE\u003d$(get_or_create_service \"keystone\" \\"},{"line_number":148,"context_line":"        \"identity\" \"Keystone Identity Service\")"},{"line_number":149,"context_line":"    get_or_create_endpoint $KEYSTONE_SERVICE \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5a73121d_d82bd170","line":146,"range":{"start_line":144,"start_character":0,"end_line":146,"end_character":78},"updated":"2021-11-10 02:17:27.000000000","message":"I think it\u0027s enough to explain in commit message and no need to put here because it\u0027s not so helpful for future maintenance actually.","commit_id":"9bb258a69eb615f5342b66d37c155dee797d86af"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"bb2a7bc63240d6535360c3572dcc2af43006ae04","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            \"$TACKER_PROTOCOL://$TACKER_HOST:$TACKER_PORT/\" \\"},{"line_number":142,"context_line":"            \"$TACKER_PROTOCOL://$TACKER_HOST:$TACKER_PORT/\""},{"line_number":143,"context_line":"    fi"},{"line_number":144,"context_line":"    # Create admin and internal endpoints for keystone. Tacker currently uses"},{"line_number":145,"context_line":"    # the admin endpoint to interact with keystone, but devstack stopped"},{"line_number":146,"context_line":"    # creating one in https://review.opendev.org/c/openstack/devstack/+/777345"},{"line_number":147,"context_line":"    KEYSTONE_SERVICE\u003d$(get_or_create_service \"keystone\" \\"},{"line_number":148,"context_line":"        \"identity\" \"Keystone Identity Service\")"},{"line_number":149,"context_line":"    get_or_create_endpoint $KEYSTONE_SERVICE \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"2ca57907_8b8ae34b","line":146,"range":{"start_line":144,"start_character":0,"end_line":146,"end_character":78},"in_reply_to":"5a73121d_d82bd170","updated":"2021-11-10 05:06:43.000000000","message":"I wrote the comment that I referred to the blazar patch.\nhttps://review.opendev.org/c/openstack/blazar/+/816627/4/devstack/plugin.sh#138\n\nAs you suggested, I think it is unnecessary, so I deleted it in PS4.","commit_id":"9bb258a69eb615f5342b66d37c155dee797d86af"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2ce261c0e806ee46584ebe08bc2a14f1706f2f35","unresolved":true,"context_lines":[{"line_number":144,"context_line":"    # Create admin and internal endpoints for keystone. Tacker currently uses"},{"line_number":145,"context_line":"    # the admin endpoint to interact with keystone, but devstack stopped"},{"line_number":146,"context_line":"    # creating one in https://review.opendev.org/c/openstack/devstack/+/777345"},{"line_number":147,"context_line":"    KEYSTONE_SERVICE\u003d$(get_or_create_service \"keystone\" \\"},{"line_number":148,"context_line":"        \"identity\" \"Keystone Identity Service\")"},{"line_number":149,"context_line":"    get_or_create_endpoint $KEYSTONE_SERVICE \\"},{"line_number":150,"context_line":"        \"$REGION_NAME\" \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf83e4ec_32d816c0","line":147,"updated":"2021-11-10 02:17:27.000000000","message":"It\u0027s just a bit strange to setup keystone\u0027s service here in `create_tacker_accounts()` for me. Why don\u0027t you make a dedicated function for the task called from `devstack/plugin.sh`?","commit_id":"9bb258a69eb615f5342b66d37c155dee797d86af"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"bb2a7bc63240d6535360c3572dcc2af43006ae04","unresolved":true,"context_lines":[{"line_number":144,"context_line":"    # Create admin and internal endpoints for keystone. Tacker currently uses"},{"line_number":145,"context_line":"    # the admin endpoint to interact with keystone, but devstack stopped"},{"line_number":146,"context_line":"    # creating one in https://review.opendev.org/c/openstack/devstack/+/777345"},{"line_number":147,"context_line":"    KEYSTONE_SERVICE\u003d$(get_or_create_service \"keystone\" \\"},{"line_number":148,"context_line":"        \"identity\" \"Keystone Identity Service\")"},{"line_number":149,"context_line":"    get_or_create_endpoint $KEYSTONE_SERVICE \\"},{"line_number":150,"context_line":"        \"$REGION_NAME\" \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"d05c1af6_ecaf1464","line":147,"in_reply_to":"bf83e4ec_32d816c0","updated":"2021-11-10 05:06:43.000000000","message":"The blazar patch I referred to was also created in `create_blazar_accounts`, so I coded in the same way.\nhttps://review.opendev.org/c/openstack/blazar/+/816627/4/devstack/plugin.sh#143\n\nHowever, I think your comment is correct, so I created a function called `create_keystone _endpoint` and moved the process to the function in PS4.","commit_id":"9bb258a69eb615f5342b66d37c155dee797d86af"}]}
