)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"eb10b23884bf6f8690d95c69d79ed0b219e98cb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"75c3fb04_f530e341","updated":"2021-12-23 08:57:55.000000000","message":"Please let me recheck for the latest gate tests.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"44c794e0c284d45386007f69396ca4fdd6d29ed2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"35abdebf_c397bf1f","updated":"2021-12-27 02:12:03.000000000","message":"Thank you for your work.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"dd0f3595344a0823f58ae95456e30c61da2c7cc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"43dca6ef_346a6d68","updated":"2021-12-23 09:53:45.000000000","message":"Thank you for your work. Please kindly confirm my comments. (I will check other codes later.)","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"6391fb56c20a6039bacc87d16e2432e01bce3fa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27269c23_01254afd","updated":"2021-12-23 08:58:00.000000000","message":"recheck","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df708cdb_d9feb9ea","updated":"2021-12-27 06:55:27.000000000","message":"To Masaki UENO and Hiroo Kitamura:\n   Thank you for your comments. I fixed them in PS3. Please kindly check them again.","commit_id":"b497e0b103eed9ffd216a4c9ac8acc2bbbbf59da"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"f940308fee799e3237aca5207820c0ecad636947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"64b7c76c_5a5892a3","updated":"2022-01-05 01:05:22.000000000","message":"Thank you for your rework.","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ea2449b4b7c933178bab0de45cba5795f7fb7875","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c02345d2_636d1bc7","updated":"2022-01-04 01:51:57.000000000","message":"Thank you for your work. I have additional comments.","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c515409b48b9277f56647ad2567d37fd64e3a71e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e7f57236_8321599d","updated":"2021-12-27 08:05:24.000000000","message":"To Hiroo Kitamura:\n   I have fixed your comments in PS4. Please kindly check them again.","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"65aad3d02a45bdb90baa7c97a8b1954c02201f2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4f4fa61f_90db3c2f","updated":"2022-01-18 02:05:55.000000000","message":"LGTM","commit_id":"028286fd83bdc0613268073c96a3f603d1f98187"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"32955b0eae55d0932c20fce8793ed6b16bf03c6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fdbe0c7c_104dff87","updated":"2022-01-18 02:57:53.000000000","message":"LGTM, thanks for your patch.","commit_id":"028286fd83bdc0613268073c96a3f603d1f98187"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d8435cdb7b4cd1ccad18d1b18af3aad0495e251d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"71391326_d6cc5ada","updated":"2022-01-17 07:08:47.000000000","message":"To Hiroo Kitamura:\nThank you for your comments.\nI have fixed them in PS5. Please kindly check them again.","commit_id":"028286fd83bdc0613268073c96a3f603d1f98187"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cf0d656a7e1b7fc841145a8b618899601503081f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"937e389c_6a01fcb7","updated":"2022-02-21 03:09:05.000000000","message":"I resolved the conflict and changed the newline character of the new added file in PS 6.","commit_id":"78033174cf837680553c4b339c58f9bd1235e15b"}],"tacker/tests/etc/samples/etsi/nfv/functional7/Definitions/helloworld3_df_simple.yaml":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ea2449b4b7c933178bab0de45cba5795f7fb7875","unresolved":true,"context_lines":[{"line_number":401,"context_line":"        targets: [ internalVL3 ]"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    - policy_antiaffinity_vdu1:"},{"line_number":404,"context_line":"        type: tosca.policies.nfv.AffinityRule"},{"line_number":405,"context_line":"        targets: [ VDU1 ]"},{"line_number":406,"context_line":"        properties:"},{"line_number":407,"context_line":"          scope: zone"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2d17cc43_f3e63057","line":404,"updated":"2022-01-04 01:51:57.000000000","message":"This change isn\u0027t really necessary, but at this time, in my understanding, we can\u0027t realize the AntiAffinityRule for VDU1 in zuul test.\nI think it\u0027s better to add that in NOTE.","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d8435cdb7b4cd1ccad18d1b18af3aad0495e251d","unresolved":true,"context_lines":[{"line_number":401,"context_line":"        targets: [ internalVL3 ]"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    - policy_antiaffinity_vdu1:"},{"line_number":404,"context_line":"        type: tosca.policies.nfv.AffinityRule"},{"line_number":405,"context_line":"        targets: [ VDU1 ]"},{"line_number":406,"context_line":"        properties:"},{"line_number":407,"context_line":"          scope: zone"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d3dc66df_2a2e0be0","line":404,"in_reply_to":"2d17cc43_f3e63057","updated":"2022-01-17 07:08:47.000000000","message":"I have added NOTE in PS 5.","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4d4845b3fd6990c5820e40e1f7600b5d24ca8675","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        targets: [ internalVL3 ]"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    - policy_antiaffinity_vdu1:"},{"line_number":404,"context_line":"        type: tosca.policies.nfv.AffinityRule"},{"line_number":405,"context_line":"        targets: [ VDU1 ]"},{"line_number":406,"context_line":"        properties:"},{"line_number":407,"context_line":"          scope: zone"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e834aefa_2d7e7901","line":404,"in_reply_to":"d3dc66df_2a2e0be0","updated":"2022-01-18 00:28:23.000000000","message":"Done","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"}],"tacker/tests/functional/sol_separated_nfvo/vnflcm/fake_grant.py":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"dd0f3595344a0823f58ae95456e30c61da2c7cc8","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_serialization import jsonutils"},{"line_number":17,"context_line":"from oslo_utils import uuidutils"},{"line_number":18,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Grant:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f073c434_6e752a15","line":18,"updated":"2021-12-23 09:53:45.000000000","message":"Please add blank line between L17 and L18 to explicitly show that `tacker.tests` is a local module.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"f940308fee799e3237aca5207820c0ecad636947","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_serialization import jsonutils"},{"line_number":17,"context_line":"from oslo_utils import uuidutils"},{"line_number":18,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Grant:"}],"source_content_type":"text/x-python","patch_set":2,"id":"64e0c848_dae658d3","line":18,"in_reply_to":"3210d6cf_b00105f7","updated":"2022-01-05 01:05:22.000000000","message":"Done","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from oslo_serialization import jsonutils"},{"line_number":17,"context_line":"from oslo_utils import uuidutils"},{"line_number":18,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Grant:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3210d6cf_b00105f7","line":18,"in_reply_to":"f073c434_6e752a15","updated":"2021-12-27 06:55:27.000000000","message":"I have added blank line in PS3.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"44c794e0c284d45386007f69396ca4fdd6d29ed2","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                if placement_constraint["},{"line_number":81,"context_line":"                        \u0027affinityOrAntiAffinity\u0027] \u003d\u003d \u0027AFFINITY\u0027:"},{"line_number":82,"context_line":"                    zone_id_dict[placement_constraint["},{"line_number":83,"context_line":"                        \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":84,"context_line":"                else:"},{"line_number":85,"context_line":"                    try:"},{"line_number":86,"context_line":"                        zone_id_dict[placement_constraint["}],"source_content_type":"text/x-python","patch_set":2,"id":"f6c11f75_257fc87f","line":83,"range":{"start_line":83,"start_character":60,"end_line":83,"end_character":68},"updated":"2021-12-27 02:12:03.000000000","message":"I think it is an implementation constraint of this \"fake_grant\" that always uses the first element of zones.\nIt\u0027s better to add that in NOTE.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8d5168f1712f17767429bb880e033e24d9d9bd63","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                if placement_constraint["},{"line_number":81,"context_line":"                        \u0027affinityOrAntiAffinity\u0027] \u003d\u003d \u0027AFFINITY\u0027:"},{"line_number":82,"context_line":"                    zone_id_dict[placement_constraint["},{"line_number":83,"context_line":"                        \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":84,"context_line":"                else:"},{"line_number":85,"context_line":"                    try:"},{"line_number":86,"context_line":"                        zone_id_dict[placement_constraint["}],"source_content_type":"text/x-python","patch_set":2,"id":"65f75b2b_1a565592","line":83,"range":{"start_line":83,"start_character":60,"end_line":83,"end_character":68},"in_reply_to":"959a1214_1d2fe65d","updated":"2021-12-27 07:33:27.000000000","message":"Done","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                if placement_constraint["},{"line_number":81,"context_line":"                        \u0027affinityOrAntiAffinity\u0027] \u003d\u003d \u0027AFFINITY\u0027:"},{"line_number":82,"context_line":"                    zone_id_dict[placement_constraint["},{"line_number":83,"context_line":"                        \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":84,"context_line":"                else:"},{"line_number":85,"context_line":"                    try:"},{"line_number":86,"context_line":"                        zone_id_dict[placement_constraint["}],"source_content_type":"text/x-python","patch_set":2,"id":"959a1214_1d2fe65d","line":83,"range":{"start_line":83,"start_character":60,"end_line":83,"end_character":68},"in_reply_to":"f6c11f75_257fc87f","updated":"2021-12-27 06:55:27.000000000","message":"I have added NOTE in PS3.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"44c794e0c284d45386007f69396ca4fdd6d29ed2","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":87,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":88,"context_line":"                            index][\u0027id\u0027]"},{"line_number":89,"context_line":"                    except IndexError:"},{"line_number":90,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return zone_id_dict"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9125a9b2_d5e6ed09","line":91,"range":{"start_line":89,"start_character":20,"end_line":91,"end_character":78},"updated":"2021-12-27 02:12:03.000000000","message":"I think this branch will be in the below case, is that correct?\n  (the number of resources to allocate) \u003e (the number of zones)\nIf it is correct, I think this process is inappropriate.\nBecause, even though \"ANTI-AFFINITY\" is specified, multiple resources can be assigned to a single zone.\nThis is the behavior of \"SOFT-ANTI-AFFINITY\".\nIMO, it\u0027s the correct behavior to fail the allocation in this case.\nWhat do you think?","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":87,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":88,"context_line":"                            index][\u0027id\u0027]"},{"line_number":89,"context_line":"                    except IndexError:"},{"line_number":90,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return zone_id_dict"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9174dea5_54de3d1e","line":91,"range":{"start_line":89,"start_character":20,"end_line":91,"end_character":78},"in_reply_to":"9125a9b2_d5e6ed09","updated":"2021-12-27 06:55:27.000000000","message":"Yes. Your think is correct. \nIn fact, we set up a matching number of AZs during the local test, and this processing is for the zuul test. Since zuul only generated one AZ and couldn\u0027t meet the test conditions, we added this processing, otherwise the FT using the following VNF Package may fail. \nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/etc/samples/etsi/nfv/functional7/Definitions/helloworld3_df_simple.yaml#L403-L413\n\nOr, can you tell me how to set up multiple AZs for zuul? Then we no longer need the exception handling.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8d5168f1712f17767429bb880e033e24d9d9bd63","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":87,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":88,"context_line":"                            index][\u0027id\u0027]"},{"line_number":89,"context_line":"                    except IndexError:"},{"line_number":90,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return zone_id_dict"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a20183fa_95e942f8","line":91,"range":{"start_line":89,"start_character":20,"end_line":91,"end_character":78},"in_reply_to":"9174dea5_54de3d1e","updated":"2021-12-27 07:33:27.000000000","message":"I understood your intent of the process.\n\n\u003e Or, can you tell me how to set up multiple AZs for zuul? Then we no longer need the exception handling.\n\nUnfortunately, I also don\u0027t know a good way to achieve multiple AZs for zuul.\nBut as an alternative, both VDU1 and VDU2 now have AntiAffinityRules, but what about making a fix to apply AntiAffinityRule to only VDU2?\nOf course this isn\u0027t ideal test, but I think it\u0027s better than the current unintended AZ placement test.\nWhat do you think?","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c515409b48b9277f56647ad2567d37fd64e3a71e","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":87,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":88,"context_line":"                            index][\u0027id\u0027]"},{"line_number":89,"context_line":"                    except IndexError:"},{"line_number":90,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return zone_id_dict"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a5bd26a0_3f9c91bf","line":91,"range":{"start_line":89,"start_character":20,"end_line":91,"end_character":78},"in_reply_to":"a20183fa_95e942f8","updated":"2021-12-27 08:05:24.000000000","message":"Your comment is useful. I have fixed it in PS4.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ea2449b4b7c933178bab0de45cba5795f7fb7875","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":87,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":88,"context_line":"                            index][\u0027id\u0027]"},{"line_number":89,"context_line":"                    except IndexError:"},{"line_number":90,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return zone_id_dict"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae92ac5_93795cb3","line":91,"range":{"start_line":89,"start_character":20,"end_line":91,"end_character":78},"in_reply_to":"a5bd26a0_3f9c91bf","updated":"2022-01-04 01:51:57.000000000","message":"I have confirmed that VDU1 of functional7 has been modified from AntiAffinityRule to AffinityRule.\nI have additional comments, but I will make new comments in each part, and I will change the status of this comment as resolved.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"dd0f3595344a0823f58ae95456e30c61da2c7cc8","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                vdu_list.append(add_resource[\u0027vduId\u0027])"},{"line_number":146,"context_line":"        return vdu_list"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @staticmethod"},{"line_number":149,"context_line":"    def _make_vim_assets(add_resources, image_id_dict, flavour_id_dict):"},{"line_number":150,"context_line":"        # set m1.tiny\u003d\"1\" for flavour_id"},{"line_number":151,"context_line":"        vim_assets \u003d {}"},{"line_number":152,"context_line":"        vim_assets[\u0027computeResourceFlavours\u0027] \u003d []"},{"line_number":153,"context_line":"        vim_assets[\u0027softwareImages\u0027] \u003d []"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        vdu_list \u003d Grant.get_vdu_list(add_resources)"},{"line_number":156,"context_line":"        for vdu in vdu_list:"},{"line_number":157,"context_line":"            if flavour_id_dict.get(vdu):"},{"line_number":158,"context_line":"                flavour_dict \u003d {"},{"line_number":159,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":160,"context_line":"                    \"vnfdVirtualComputeDescId\": vdu,"},{"line_number":161,"context_line":"                    \"vimFlavourId\": flavour_id_dict[vdu]"},{"line_number":162,"context_line":"                }"},{"line_number":163,"context_line":"                vim_assets[\u0027computeResourceFlavours\u0027].append(flavour_dict)"},{"line_number":164,"context_line":"            if image_id_dict.get(vdu):"},{"line_number":165,"context_line":"                image_dict \u003d {"},{"line_number":166,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":167,"context_line":"                    \"vnfdSoftwareImageId\": vdu,"},{"line_number":168,"context_line":"                    \"vimSoftwareImageId\": image_id_dict[vdu]"},{"line_number":169,"context_line":"                }"},{"line_number":170,"context_line":"                vim_assets[\u0027softwareImages\u0027].append(image_dict)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        return vim_assets"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @staticmethod"},{"line_number":175,"context_line":"    def _make_response_template(request_body):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2b3bedc9_fa158b12","line":172,"range":{"start_line":148,"start_character":0,"end_line":172,"end_character":25},"updated":"2021-12-23 09:53:45.000000000","message":"Please consider declaring dict structure when you initialize the dict itself.\n\nHere are sample of refactoring;\n\n- Only declare dict structure when initialization:\n```\n    @staticmethod\n    def _make_vim_assets(add_resources, image_id_dict, flavour_id_dict):\n        # set m1.tiny\u003d\"1\" for flavour_id\n        vim_assets \u003d {\n            \u0027computeResourceFlavours\u0027: [],\n            `softwareImages`: []\n        }\n        ....\n```\n\n- Use comprehension for generating list of dict:\n```\n    @staticmethod\n    def _make_vim_assets(add_resources, image_id_dict, flavour_id_dict):\n        # set m1.tiny\u003d\"1\" for flavour_id\n        vdu_list \u003d Grant.get_vdu_list(add_resources)\n\n        vim_assets \u003d {\n            \u0027computeResourceFlavours\u0027: [\n                Grant._generate_flavour(vdu, flavour_id_dict)\n                    for vdu in vdu_list if flavour_id_dict.get(vdu)],\n            \u0027softwareImages\u0027: [\n                Grant._generate_image(vdu, image_id_dict)\n                    for vdu in vdu_list if image_id_dict.get(vdu)]\n        }\n\n        return vim_assets\n\n    @staticmethod\n    def _generate_flavour(vdu, flavour_id_dict):\n        if flavour_id_dict.get(vdu):\n            return {\n                \"vimConnectionId\": uuidsentinel.vim_connection_id,\n                \"vnfdVirtualComputeDescId\": vdu,\n                \"vimFlavourId\": flavour_id_dict[vdu]\n            }\n        return None\n\n    @staticmethod\n    def _generate_image(vdu, image_id_dict):\n        if image_id_dict.get(vdu):\n            return {\n                \"vimConnectionId\": uuidsentinel.vim_connection_id,\n                \"vnfdSoftwareImageId\": vdu,\n                \"vimSoftwareImageId\": image_id_dict[vdu]\n            }\n        return None\n```","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"a63d592f9ec94599ce9e4b113ac1f762733a0eed","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                vdu_list.append(add_resource[\u0027vduId\u0027])"},{"line_number":146,"context_line":"        return vdu_list"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @staticmethod"},{"line_number":149,"context_line":"    def _make_vim_assets(add_resources, image_id_dict, flavour_id_dict):"},{"line_number":150,"context_line":"        # set m1.tiny\u003d\"1\" for flavour_id"},{"line_number":151,"context_line":"        vim_assets \u003d {}"},{"line_number":152,"context_line":"        vim_assets[\u0027computeResourceFlavours\u0027] \u003d []"},{"line_number":153,"context_line":"        vim_assets[\u0027softwareImages\u0027] \u003d []"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        vdu_list \u003d Grant.get_vdu_list(add_resources)"},{"line_number":156,"context_line":"        for vdu in vdu_list:"},{"line_number":157,"context_line":"            if flavour_id_dict.get(vdu):"},{"line_number":158,"context_line":"                flavour_dict \u003d {"},{"line_number":159,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":160,"context_line":"                    \"vnfdVirtualComputeDescId\": vdu,"},{"line_number":161,"context_line":"                    \"vimFlavourId\": flavour_id_dict[vdu]"},{"line_number":162,"context_line":"                }"},{"line_number":163,"context_line":"                vim_assets[\u0027computeResourceFlavours\u0027].append(flavour_dict)"},{"line_number":164,"context_line":"            if image_id_dict.get(vdu):"},{"line_number":165,"context_line":"                image_dict \u003d {"},{"line_number":166,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":167,"context_line":"                    \"vnfdSoftwareImageId\": vdu,"},{"line_number":168,"context_line":"                    \"vimSoftwareImageId\": image_id_dict[vdu]"},{"line_number":169,"context_line":"                }"},{"line_number":170,"context_line":"                vim_assets[\u0027softwareImages\u0027].append(image_dict)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        return vim_assets"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @staticmethod"},{"line_number":175,"context_line":"    def _make_response_template(request_body):"}],"source_content_type":"text/x-python","patch_set":2,"id":"786ba034_7a4e94d5","line":172,"range":{"start_line":148,"start_character":0,"end_line":172,"end_character":25},"in_reply_to":"2b3bedc9_fa158b12","updated":"2021-12-24 01:31:04.000000000","message":"Sorry, let me correct `_make_vim_assets` of the 2nd sample as follows:\n\n```\n    @staticmethod\n    def _make_vim_assets(add_resources, image_id_dict, flavour_id_dict):\n        # set m1.tiny\u003d\"1\" for flavour_id\n        vdu_list \u003d Grant.get_vdu_list(add_resources)\n        flavors \u003d [Grant._generate_flavour(vdu, flavour_id_dict)\n                    for vdu in vdu_list if flavour_id_dict.get(vdu)]    \n        images \u003d [Grant._generate_image(vdu, image_id_dict)\n                    for vdu in vdu_list if image_id_dict.get(vdu)]\n\n        vim_assets \u003d {\n            \u0027computeResourceFlavours\u0027: flavors,\n            \u0027softwareImages\u0027: images,\n        }\n\n        return vim_assets\n```","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"f940308fee799e3237aca5207820c0ecad636947","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                vdu_list.append(add_resource[\u0027vduId\u0027])"},{"line_number":146,"context_line":"        return vdu_list"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @staticmethod"},{"line_number":149,"context_line":"    def _make_vim_assets(add_resources, image_id_dict, flavour_id_dict):"},{"line_number":150,"context_line":"        # set m1.tiny\u003d\"1\" for flavour_id"},{"line_number":151,"context_line":"        vim_assets \u003d {}"},{"line_number":152,"context_line":"        vim_assets[\u0027computeResourceFlavours\u0027] \u003d []"},{"line_number":153,"context_line":"        vim_assets[\u0027softwareImages\u0027] \u003d []"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        vdu_list \u003d Grant.get_vdu_list(add_resources)"},{"line_number":156,"context_line":"        for vdu in vdu_list:"},{"line_number":157,"context_line":"            if flavour_id_dict.get(vdu):"},{"line_number":158,"context_line":"                flavour_dict \u003d {"},{"line_number":159,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":160,"context_line":"                    \"vnfdVirtualComputeDescId\": vdu,"},{"line_number":161,"context_line":"                    \"vimFlavourId\": flavour_id_dict[vdu]"},{"line_number":162,"context_line":"                }"},{"line_number":163,"context_line":"                vim_assets[\u0027computeResourceFlavours\u0027].append(flavour_dict)"},{"line_number":164,"context_line":"            if image_id_dict.get(vdu):"},{"line_number":165,"context_line":"                image_dict \u003d {"},{"line_number":166,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":167,"context_line":"                    \"vnfdSoftwareImageId\": vdu,"},{"line_number":168,"context_line":"                    \"vimSoftwareImageId\": image_id_dict[vdu]"},{"line_number":169,"context_line":"                }"},{"line_number":170,"context_line":"                vim_assets[\u0027softwareImages\u0027].append(image_dict)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        return vim_assets"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @staticmethod"},{"line_number":175,"context_line":"    def _make_response_template(request_body):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7225811f_881b515b","line":172,"range":{"start_line":148,"start_character":0,"end_line":172,"end_character":25},"in_reply_to":"4b5f36cb_d56d1031","updated":"2022-01-05 01:05:22.000000000","message":"Done","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                vdu_list.append(add_resource[\u0027vduId\u0027])"},{"line_number":146,"context_line":"        return vdu_list"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    @staticmethod"},{"line_number":149,"context_line":"    def _make_vim_assets(add_resources, image_id_dict, flavour_id_dict):"},{"line_number":150,"context_line":"        # set m1.tiny\u003d\"1\" for flavour_id"},{"line_number":151,"context_line":"        vim_assets \u003d {}"},{"line_number":152,"context_line":"        vim_assets[\u0027computeResourceFlavours\u0027] \u003d []"},{"line_number":153,"context_line":"        vim_assets[\u0027softwareImages\u0027] \u003d []"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        vdu_list \u003d Grant.get_vdu_list(add_resources)"},{"line_number":156,"context_line":"        for vdu in vdu_list:"},{"line_number":157,"context_line":"            if flavour_id_dict.get(vdu):"},{"line_number":158,"context_line":"                flavour_dict \u003d {"},{"line_number":159,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":160,"context_line":"                    \"vnfdVirtualComputeDescId\": vdu,"},{"line_number":161,"context_line":"                    \"vimFlavourId\": flavour_id_dict[vdu]"},{"line_number":162,"context_line":"                }"},{"line_number":163,"context_line":"                vim_assets[\u0027computeResourceFlavours\u0027].append(flavour_dict)"},{"line_number":164,"context_line":"            if image_id_dict.get(vdu):"},{"line_number":165,"context_line":"                image_dict \u003d {"},{"line_number":166,"context_line":"                    \"vimConnectionId\": uuidsentinel.vim_connection_id,"},{"line_number":167,"context_line":"                    \"vnfdSoftwareImageId\": vdu,"},{"line_number":168,"context_line":"                    \"vimSoftwareImageId\": image_id_dict[vdu]"},{"line_number":169,"context_line":"                }"},{"line_number":170,"context_line":"                vim_assets[\u0027softwareImages\u0027].append(image_dict)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        return vim_assets"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @staticmethod"},{"line_number":175,"context_line":"    def _make_response_template(request_body):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b5f36cb_d56d1031","line":172,"range":{"start_line":148,"start_character":0,"end_line":172,"end_character":25},"in_reply_to":"786ba034_7a4e94d5","updated":"2021-12-27 06:55:27.000000000","message":"I have fixed them in PS3.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"10060603095b6726f651766693a1e17bb4c1fcd0","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":212,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":213,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":214,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":215,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":216,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"],"},{"line_number":217,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":218,"context_line":"            else:"},{"line_number":219,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":220,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"])"},{"line_number":221,"context_line":"            res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":222,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":223,"context_line":"                image_id_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b5f7b907_84d30417","line":220,"range":{"start_line":214,"start_character":0,"end_line":220,"end_character":63},"updated":"2021-12-27 02:25:37.000000000","message":"Is it possible to eliminate the if branch by refactoring as follows?\n---\n         res[\"addResources\"] \u003d Grant._make_add_resources(\n             request_body[\u0027addResources\u0027], res[\"zones\"],\n             request_body.get(\u0027placementConstraints\u0027))","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8d5168f1712f17767429bb880e033e24d9d9bd63","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":212,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":213,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":214,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":215,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":216,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"],"},{"line_number":217,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":218,"context_line":"            else:"},{"line_number":219,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":220,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"])"},{"line_number":221,"context_line":"            res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":222,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":223,"context_line":"                image_id_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"30172989_4dda16a1","line":220,"range":{"start_line":214,"start_character":0,"end_line":220,"end_character":63},"in_reply_to":"5dfd3850_1084d119","updated":"2021-12-27 07:33:27.000000000","message":"Done","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":212,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":213,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":214,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":215,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":216,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"],"},{"line_number":217,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":218,"context_line":"            else:"},{"line_number":219,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":220,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"])"},{"line_number":221,"context_line":"            res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":222,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":223,"context_line":"                image_id_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5dfd3850_1084d119","line":220,"range":{"start_line":214,"start_character":0,"end_line":220,"end_character":63},"in_reply_to":"b5f7b907_84d30417","updated":"2021-12-27 06:55:27.000000000","message":"I have fixed it in PS3.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"10060603095b6726f651766693a1e17bb4c1fcd0","unresolved":true,"context_lines":[{"line_number":234,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":235,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":236,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":237,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":238,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":239,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"],"},{"line_number":240,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":241,"context_line":"            else:"},{"line_number":242,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":243,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"])"},{"line_number":244,"context_line":"            res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":245,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":246,"context_line":"                image_id_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3498cf3c_a978a774","line":243,"range":{"start_line":237,"start_character":12,"end_line":243,"end_character":63},"updated":"2021-12-27 02:25:37.000000000","message":"ditto","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":234,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":235,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":236,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":237,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":238,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":239,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"],"},{"line_number":240,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":241,"context_line":"            else:"},{"line_number":242,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":243,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"])"},{"line_number":244,"context_line":"            res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":245,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":246,"context_line":"                image_id_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6bdcfccc_3464e156","line":243,"range":{"start_line":237,"start_character":12,"end_line":243,"end_character":63},"in_reply_to":"3498cf3c_a978a774","updated":"2021-12-27 06:55:27.000000000","message":"ditto","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8d5168f1712f17767429bb880e033e24d9d9bd63","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":235,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":236,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":237,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":238,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":239,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"],"},{"line_number":240,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":241,"context_line":"            else:"},{"line_number":242,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":243,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"])"},{"line_number":244,"context_line":"            res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":245,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":246,"context_line":"                image_id_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"28296b8f_74a53cb8","line":243,"range":{"start_line":237,"start_character":12,"end_line":243,"end_character":63},"in_reply_to":"6bdcfccc_3464e156","updated":"2021-12-27 07:33:27.000000000","message":"Done","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"10060603095b6726f651766693a1e17bb4c1fcd0","unresolved":true,"context_lines":[{"line_number":249,"context_line":"            res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":250,"context_line":"                request_body[\u0027removeResources\u0027])"},{"line_number":251,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":252,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":253,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":254,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"],"},{"line_number":255,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":256,"context_line":"            else:"},{"line_number":257,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":258,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"])"},{"line_number":259,"context_line":"        return res"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"da098c53_6182f5db","line":258,"range":{"start_line":252,"start_character":12,"end_line":258,"end_character":66},"updated":"2021-12-27 02:25:37.000000000","message":"ditto(Same with \"_make_add_resources\")","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8d5168f1712f17767429bb880e033e24d9d9bd63","unresolved":true,"context_lines":[{"line_number":249,"context_line":"            res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":250,"context_line":"                request_body[\u0027removeResources\u0027])"},{"line_number":251,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":252,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":253,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":254,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"],"},{"line_number":255,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":256,"context_line":"            else:"},{"line_number":257,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":258,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"])"},{"line_number":259,"context_line":"        return res"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffa6a471_0a58e70c","line":258,"range":{"start_line":252,"start_character":12,"end_line":258,"end_character":66},"in_reply_to":"0f99d247_1733b41c","updated":"2021-12-27 07:33:27.000000000","message":"Isn\u0027t \"_make_update_resources()\" correct for the function to call, not \"_make_add_resources()\"?","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ea2449b4b7c933178bab0de45cba5795f7fb7875","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":250,"context_line":"                request_body[\u0027removeResources\u0027])"},{"line_number":251,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":252,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":253,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":254,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"],"},{"line_number":255,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":256,"context_line":"            else:"},{"line_number":257,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":258,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"])"},{"line_number":259,"context_line":"        return res"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"875e330c_9d733aab","line":258,"range":{"start_line":252,"start_character":12,"end_line":258,"end_character":66},"in_reply_to":"4f235f97_1ec659a0","updated":"2022-01-04 01:51:57.000000000","message":"Done","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":249,"context_line":"            res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":250,"context_line":"                request_body[\u0027removeResources\u0027])"},{"line_number":251,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":252,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":253,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":254,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"],"},{"line_number":255,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":256,"context_line":"            else:"},{"line_number":257,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":258,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"])"},{"line_number":259,"context_line":"        return res"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"0f99d247_1733b41c","line":258,"range":{"start_line":252,"start_character":12,"end_line":258,"end_character":66},"in_reply_to":"da098c53_6182f5db","updated":"2021-12-27 06:55:27.000000000","message":"ditto","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c515409b48b9277f56647ad2567d37fd64e3a71e","unresolved":true,"context_lines":[{"line_number":249,"context_line":"            res[\"removeResources\"] \u003d Grant._make_remove_resources("},{"line_number":250,"context_line":"                request_body[\u0027removeResources\u0027])"},{"line_number":251,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":252,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":253,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":254,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"],"},{"line_number":255,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":256,"context_line":"            else:"},{"line_number":257,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":258,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"])"},{"line_number":259,"context_line":"        return res"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"4f235f97_1ec659a0","line":258,"range":{"start_line":252,"start_character":12,"end_line":258,"end_character":66},"in_reply_to":"ffa6a471_0a58e70c","updated":"2021-12-27 08:05:24.000000000","message":"Sorry, I made a mistake. I fixed it in PS4.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"10060603095b6726f651766693a1e17bb4c1fcd0","unresolved":true,"context_lines":[{"line_number":266,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":267,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":268,"context_line":"            res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":269,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":270,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":271,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"],"},{"line_number":272,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":273,"context_line":"            else:"},{"line_number":274,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":275,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"])"},{"line_number":276,"context_line":"            res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":277,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":278,"context_line":"                image_id_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6fd1d1c5_75baf59d","line":275,"range":{"start_line":269,"start_character":12,"end_line":275,"end_character":63},"updated":"2021-12-27 02:25:37.000000000","message":"ditto","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8d5168f1712f17767429bb880e033e24d9d9bd63","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":267,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":268,"context_line":"            res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":269,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":270,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":271,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"],"},{"line_number":272,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":273,"context_line":"            else:"},{"line_number":274,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":275,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"])"},{"line_number":276,"context_line":"            res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":277,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":278,"context_line":"                image_id_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff7f00eb_b3621195","line":275,"range":{"start_line":269,"start_character":12,"end_line":275,"end_character":63},"in_reply_to":"1a714454_d9ed1c0a","updated":"2021-12-27 07:33:27.000000000","message":"Done","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":266,"context_line":"        res \u003d Grant._make_response_template(request_body)"},{"line_number":267,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":268,"context_line":"            res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":269,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":270,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":271,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"],"},{"line_number":272,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":273,"context_line":"            else:"},{"line_number":274,"context_line":"                res[\"addResources\"] \u003d Grant._make_add_resources("},{"line_number":275,"context_line":"                    request_body[\u0027addResources\u0027], res[\"zones\"])"},{"line_number":276,"context_line":"            res[\"vimAssets\"] \u003d Grant._make_vim_assets("},{"line_number":277,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":278,"context_line":"                image_id_dict,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a714454_d9ed1c0a","line":275,"range":{"start_line":269,"start_character":12,"end_line":275,"end_character":63},"in_reply_to":"6fd1d1c5_75baf59d","updated":"2021-12-27 06:55:27.000000000","message":"ditto","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"10060603095b6726f651766693a1e17bb4c1fcd0","unresolved":true,"context_lines":[{"line_number":302,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":303,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":304,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":305,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":306,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":307,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"],"},{"line_number":308,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":309,"context_line":"            else:"},{"line_number":310,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":311,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"])"},{"line_number":312,"context_line":"        res[\"additionalParams\"] \u003d Grant.ADDITIONAL_PARAMS"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        return res"}],"source_content_type":"text/x-python","patch_set":2,"id":"f1c693dd_23dde1b6","line":311,"range":{"start_line":305,"start_character":12,"end_line":311,"end_character":66},"updated":"2021-12-27 02:25:37.000000000","message":"ditto(Same with \"_make_add_resources\")","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ea2449b4b7c933178bab0de45cba5795f7fb7875","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":303,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":304,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":305,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":306,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":307,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"],"},{"line_number":308,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":309,"context_line":"            else:"},{"line_number":310,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":311,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"])"},{"line_number":312,"context_line":"        res[\"additionalParams\"] \u003d Grant.ADDITIONAL_PARAMS"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        return res"}],"source_content_type":"text/x-python","patch_set":2,"id":"3c7bbdde_4090edb0","line":311,"range":{"start_line":305,"start_character":12,"end_line":311,"end_character":66},"in_reply_to":"944ced3f_843fb2e6","updated":"2022-01-04 01:51:57.000000000","message":"Done","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c515409b48b9277f56647ad2567d37fd64e3a71e","unresolved":true,"context_lines":[{"line_number":302,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":303,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":304,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":305,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":306,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":307,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"],"},{"line_number":308,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":309,"context_line":"            else:"},{"line_number":310,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":311,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"])"},{"line_number":312,"context_line":"        res[\"additionalParams\"] \u003d Grant.ADDITIONAL_PARAMS"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        return res"}],"source_content_type":"text/x-python","patch_set":2,"id":"944ced3f_843fb2e6","line":311,"range":{"start_line":305,"start_character":12,"end_line":311,"end_character":66},"in_reply_to":"acb81d17_dcdc3657","updated":"2021-12-27 08:05:24.000000000","message":"ditto","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":302,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":303,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":304,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":305,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":306,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":307,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"],"},{"line_number":308,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":309,"context_line":"            else:"},{"line_number":310,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":311,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"])"},{"line_number":312,"context_line":"        res[\"additionalParams\"] \u003d Grant.ADDITIONAL_PARAMS"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        return res"}],"source_content_type":"text/x-python","patch_set":2,"id":"f6aef876_023bb25d","line":311,"range":{"start_line":305,"start_character":12,"end_line":311,"end_character":66},"in_reply_to":"f1c693dd_23dde1b6","updated":"2021-12-27 06:55:27.000000000","message":"ditto","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8d5168f1712f17767429bb880e033e24d9d9bd63","unresolved":true,"context_lines":[{"line_number":302,"context_line":"        res[\"vimConnections\"] \u003d Grant._make_vim_connection_info(tenant_id)"},{"line_number":303,"context_line":"        res[\"zones\"] \u003d Grant._make_zones(zone_name_list)"},{"line_number":304,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":305,"context_line":"            if \u0027placementConstraints\u0027 in request_body.keys():"},{"line_number":306,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":307,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"],"},{"line_number":308,"context_line":"                    request_body[\u0027placementConstraints\u0027])"},{"line_number":309,"context_line":"            else:"},{"line_number":310,"context_line":"                res[\"updateResources\"] \u003d Grant._make_update_resources("},{"line_number":311,"context_line":"                    request_body[\u0027updateResources\u0027], res[\"zones\"])"},{"line_number":312,"context_line":"        res[\"additionalParams\"] \u003d Grant.ADDITIONAL_PARAMS"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        return res"}],"source_content_type":"text/x-python","patch_set":2,"id":"acb81d17_dcdc3657","line":311,"range":{"start_line":305,"start_character":12,"end_line":311,"end_character":66},"in_reply_to":"f6aef876_023bb25d","updated":"2021-12-27 07:33:27.000000000","message":"Isn\u0027t \"_make_update_resources()\" correct for the function to call, not \"_make_add_resources()\"?","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"dd0f3595344a0823f58ae95456e30c61da2c7cc8","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                sample_name))"},{"line_number":324,"context_line":"        yaml_file \u003d os.path.join(csar_package_path,"},{"line_number":325,"context_line":"                                 \"Definitions/helloworld3_df_simple.yaml\")"},{"line_number":326,"context_line":"        with open(yaml_file, \u0027r\u0027) as f:"},{"line_number":327,"context_line":"            config_content \u003d yaml.safe_load(f.read())"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        nodes \u003d (config_content"}],"source_content_type":"text/x-python","patch_set":2,"id":"2fbe22bd_b47baac3","line":326,"updated":"2021-12-23 09:53:45.000000000","message":"Specify encoding for `open()`.\n\n```\n        with open(yaml_file, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:\n```","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                sample_name))"},{"line_number":324,"context_line":"        yaml_file \u003d os.path.join(csar_package_path,"},{"line_number":325,"context_line":"                                 \"Definitions/helloworld3_df_simple.yaml\")"},{"line_number":326,"context_line":"        with open(yaml_file, \u0027r\u0027) as f:"},{"line_number":327,"context_line":"            config_content \u003d yaml.safe_load(f.read())"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        nodes \u003d (config_content"}],"source_content_type":"text/x-python","patch_set":2,"id":"4138cd89_313d026c","line":326,"in_reply_to":"2fbe22bd_b47baac3","updated":"2021-12-27 06:55:27.000000000","message":"I have added `encoding` in PS3.","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"f940308fee799e3237aca5207820c0ecad636947","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                sample_name))"},{"line_number":324,"context_line":"        yaml_file \u003d os.path.join(csar_package_path,"},{"line_number":325,"context_line":"                                 \"Definitions/helloworld3_df_simple.yaml\")"},{"line_number":326,"context_line":"        with open(yaml_file, \u0027r\u0027) as f:"},{"line_number":327,"context_line":"            config_content \u003d yaml.safe_load(f.read())"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        nodes \u003d (config_content"}],"source_content_type":"text/x-python","patch_set":2,"id":"36ba9a30_eb5f0ad8","line":326,"in_reply_to":"4138cd89_313d026c","updated":"2022-01-05 01:05:22.000000000","message":"Done","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"dd0f3595344a0823f58ae95456e30c61da2c7cc8","unresolved":true,"context_lines":[{"line_number":350,"context_line":"                sample_name))"},{"line_number":351,"context_line":"        yaml_file \u003d os.path.join(csar_package_path,"},{"line_number":352,"context_line":"                                 \"Definitions/helloworld3_df_simple.yaml\")"},{"line_number":353,"context_line":"        with open(yaml_file, \u0027r\u0027) as f:"},{"line_number":354,"context_line":"            config_content \u003d yaml.safe_load(f.read())"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        nodes \u003d (config_content"}],"source_content_type":"text/x-python","patch_set":2,"id":"05d7ed99_be96f7d9","line":353,"updated":"2021-12-23 09:53:45.000000000","message":"ditto","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5ae735148e1a8cb56b549a06c4032369641c25ef","unresolved":true,"context_lines":[{"line_number":350,"context_line":"                sample_name))"},{"line_number":351,"context_line":"        yaml_file \u003d os.path.join(csar_package_path,"},{"line_number":352,"context_line":"                                 \"Definitions/helloworld3_df_simple.yaml\")"},{"line_number":353,"context_line":"        with open(yaml_file, \u0027r\u0027) as f:"},{"line_number":354,"context_line":"            config_content \u003d yaml.safe_load(f.read())"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        nodes \u003d (config_content"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ca46b84_2befc457","line":353,"in_reply_to":"05d7ed99_be96f7d9","updated":"2021-12-27 06:55:27.000000000","message":"ditto","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"f940308fee799e3237aca5207820c0ecad636947","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                sample_name))"},{"line_number":351,"context_line":"        yaml_file \u003d os.path.join(csar_package_path,"},{"line_number":352,"context_line":"                                 \"Definitions/helloworld3_df_simple.yaml\")"},{"line_number":353,"context_line":"        with open(yaml_file, \u0027r\u0027) as f:"},{"line_number":354,"context_line":"            config_content \u003d yaml.safe_load(f.read())"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        nodes \u003d (config_content"}],"source_content_type":"text/x-python","patch_set":2,"id":"e173f3dc_f4271d25","line":353,"in_reply_to":"6ca46b84_2befc457","updated":"2022-01-05 01:05:22.000000000","message":"Done","commit_id":"addd5d7777d980d3001379336b7bcd68363032ec"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ea2449b4b7c933178bab0de45cba5795f7fb7875","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":92,"context_line":"                            index][\u0027id\u0027]"},{"line_number":93,"context_line":"                    except IndexError:"},{"line_number":94,"context_line":"                        # For zuul test, because it only have one"},{"line_number":95,"context_line":"                        # Availability Zone, to pass this test,"},{"line_number":96,"context_line":"                        # it sets same Availability Zone."},{"line_number":97,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":98,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        return zone_id_dict"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e6dfda6b_46bce8e9","line":98,"range":{"start_line":94,"start_character":24,"end_line":98,"end_character":78},"updated":"2022-01-04 01:51:57.000000000","message":"I don\u0027t think the latest patchset tests will go into this processing branch, so I think this comment is inappropriate now.\nCould you fix that?","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"65aad3d02a45bdb90baa7c97a8b1954c02201f2b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":92,"context_line":"                            index][\u0027id\u0027]"},{"line_number":93,"context_line":"                    except IndexError:"},{"line_number":94,"context_line":"                        # For zuul test, because it only have one"},{"line_number":95,"context_line":"                        # Availability Zone, to pass this test,"},{"line_number":96,"context_line":"                        # it sets same Availability Zone."},{"line_number":97,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":98,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        return zone_id_dict"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"a733096f_933bc309","line":98,"range":{"start_line":94,"start_character":24,"end_line":98,"end_character":78},"in_reply_to":"59805f42_ab4e73d3","updated":"2022-01-18 02:05:55.000000000","message":"Thanks for your answer. I see.","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4d4845b3fd6990c5820e40e1f7600b5d24ca8675","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":92,"context_line":"                            index][\u0027id\u0027]"},{"line_number":93,"context_line":"                    except IndexError:"},{"line_number":94,"context_line":"                        # For zuul test, because it only have one"},{"line_number":95,"context_line":"                        # Availability Zone, to pass this test,"},{"line_number":96,"context_line":"                        # it sets same Availability Zone."},{"line_number":97,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":98,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        return zone_id_dict"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"af806797_e2393a98","line":98,"range":{"start_line":94,"start_character":24,"end_line":98,"end_character":78},"in_reply_to":"7591f309_2d0eac19","updated":"2022-01-18 00:28:23.000000000","message":"Let me confirm.\nIn \"test_inst_scale_term\" using the \"functional7\" vnf-package, so I think that this log output branch will be entered, is it correct?\nIf so, in which log can I check it?","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b7af5cce8de1e88ecf7f4b381ad0e14bfa00a7e1","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":92,"context_line":"                            index][\u0027id\u0027]"},{"line_number":93,"context_line":"                    except IndexError:"},{"line_number":94,"context_line":"                        # For zuul test, because it only have one"},{"line_number":95,"context_line":"                        # Availability Zone, to pass this test,"},{"line_number":96,"context_line":"                        # it sets same Availability Zone."},{"line_number":97,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":98,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        return zone_id_dict"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"59805f42_ab4e73d3","line":98,"range":{"start_line":94,"start_character":24,"end_line":98,"end_character":78},"in_reply_to":"af806797_e2393a98","updated":"2022-01-18 01:16:06.000000000","message":"No, the current test data does not enter this branch.\nDuring instantiate, both VDU1 and VDU2 with anti-affinity rules only generate one virtual machine, and there is no situation where the number of AZs is less than the number of virtual machines.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/etc/samples/etsi/nfv/functional7/Definitions/helloworld3_df_simple.yaml#L403-L413\nThere is also no `placementConstraints` in the grant_req of scale, so it will not enter this branch.\nhttps://5763b70c5d24e5a7fb4f-d32e9684574055628f247373c3e6dda1.ssl.cf2.rackcdn.com/821643/5/check/tacker-functional-devstack-multinode-sol-separated-nfvo/60b1948/controller-tacker/logs/screen-tacker-conductor.txt","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d8435cdb7b4cd1ccad18d1b18af3aad0495e251d","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":92,"context_line":"                            index][\u0027id\u0027]"},{"line_number":93,"context_line":"                    except IndexError:"},{"line_number":94,"context_line":"                        # For zuul test, because it only have one"},{"line_number":95,"context_line":"                        # Availability Zone, to pass this test,"},{"line_number":96,"context_line":"                        # it sets same Availability Zone."},{"line_number":97,"context_line":"                        zone_id_dict[placement_constraint["},{"line_number":98,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones[0][\u0027id\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        return zone_id_dict"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7591f309_2d0eac19","line":98,"range":{"start_line":94,"start_character":24,"end_line":98,"end_character":78},"in_reply_to":"e6dfda6b_46bce8e9","updated":"2022-01-17 07:08:47.000000000","message":"I removed this comment, and fixed it to raise \u0027error\u0027 in PS 5.","commit_id":"0df0a31b841ff76765cf494e1f2ea062738509ea"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"127ba956065275fe4262c1206608969e585752c8","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":92,"context_line":"                            index][\u0027id\u0027]"},{"line_number":93,"context_line":"                    except IndexError:"},{"line_number":94,"context_line":"                        print("},{"line_number":95,"context_line":"                            \"The number of \u0027Availability Zone\u0027\""},{"line_number":96,"context_line":"                            \"cannot support current case.\")"},{"line_number":97,"context_line":"                        raise IndexError"}],"source_content_type":"text/x-python","patch_set":6,"id":"0b5898d1_c87eb0e9","line":94,"updated":"2022-02-22 05:22:59.000000000","message":"Just a question.\nWhy did you change this message from log output to standard output?","commit_id":"78033174cf837680553c4b339c58f9bd1235e15b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"73a599d8afa771f96120f5196a1dc8ff60063e6c","unresolved":true,"context_lines":[{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":92,"context_line":"                            index][\u0027id\u0027]"},{"line_number":93,"context_line":"                    except IndexError:"},{"line_number":94,"context_line":"                        print("},{"line_number":95,"context_line":"                            \"The number of \u0027Availability Zone\u0027\""},{"line_number":96,"context_line":"                            \"cannot support current case.\")"},{"line_number":97,"context_line":"                        raise IndexError"}],"source_content_type":"text/x-python","patch_set":6,"id":"db484b9a_7d227dc7","line":94,"in_reply_to":"0b5898d1_c87eb0e9","updated":"2022-02-22 06:15:22.000000000","message":"In the actual FT test, the log cannot be output using LOG. So changed to print. And refer to the existing FT code.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py#L58","commit_id":"78033174cf837680553c4b339c58f9bd1235e15b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"35afaedc7effefd0c16c828f264f6aa355cc4455","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                            \u0027resource\u0027][index][\u0027resourceId\u0027]] \u003d zones["},{"line_number":92,"context_line":"                            index][\u0027id\u0027]"},{"line_number":93,"context_line":"                    except IndexError:"},{"line_number":94,"context_line":"                        print("},{"line_number":95,"context_line":"                            \"The number of \u0027Availability Zone\u0027\""},{"line_number":96,"context_line":"                            \"cannot support current case.\")"},{"line_number":97,"context_line":"                        raise IndexError"}],"source_content_type":"text/x-python","patch_set":6,"id":"f2705fb2_02eafdbd","line":94,"in_reply_to":"db484b9a_7d227dc7","updated":"2022-02-22 06:52:54.000000000","message":"Thanks for your answer, I see.","commit_id":"78033174cf837680553c4b339c58f9bd1235e15b"}]}