)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Partial Implement: blueprint multi-tenant-policy"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tacker/+/812261"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I20491eb294e5653bcdc2864885f55d04b21696a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"b9e1db06_ff335c83","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":66},"updated":"2022-02-02 01:50:05.000000000","message":"This patch have been already merged.\nCould you rebase and delete this line?","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Partial Implement: blueprint multi-tenant-policy"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: https://review.opendev.org/c/openstack/tacker/+/812261"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I20491eb294e5653bcdc2864885f55d04b21696a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"2159ba25_5b15746a","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":66},"in_reply_to":"b9e1db06_ff335c83","updated":"2022-02-02 02:54:49.000000000","message":"Done","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":true,"context_lines":[{"line_number":16,"context_line":"patch adds member role (non administrator user) to newly"},{"line_number":17,"context_line":"created users."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Genrates OpenStack VIM config files using helper script and"},{"line_number":20,"context_line":"register VIMs to respective tenants. Additionally copies newly"},{"line_number":21,"context_line":"generated VIM config files to \"tacker/tacker/tests/etc/samples\""},{"line_number":22,"context_line":"folder as these are require in functional test cases."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"35e1efbe_4aabaf8d","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":8},"updated":"2022-02-02 08:35:05.000000000","message":"typo: Generates\nSorry, I missed it.","commit_id":"fe6586d3fa62aa82c69bd8b4dd2bc274c0f7944c"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"20796c8c2013936c31824f7554df037e6126d7e8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"patch adds member role (non administrator user) to newly"},{"line_number":17,"context_line":"created users."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Genrates OpenStack VIM config files using helper script and"},{"line_number":20,"context_line":"register VIMs to respective tenants. Additionally copies newly"},{"line_number":21,"context_line":"generated VIM config files to \"tacker/tacker/tests/etc/samples\""},{"line_number":22,"context_line":"folder as these are require in functional test cases."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"d7de7d9b_dcb2d82d","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":8},"in_reply_to":"35e1efbe_4aabaf8d","updated":"2022-02-02 17:58:39.000000000","message":"Done","commit_id":"fe6586d3fa62aa82c69bd8b4dd2bc274c0f7944c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c5288bbd5031a6e30b9c294d3c410ad2eb39101f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"patch adds member role (non administrator user) to newly"},{"line_number":17,"context_line":"created users."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Genrates OpenStack VIM config files using helper script and"},{"line_number":20,"context_line":"register VIMs to respective tenants. Additionally copies newly"},{"line_number":21,"context_line":"generated VIM config files to \"tacker/tacker/tests/etc/samples\""},{"line_number":22,"context_line":"folder as these are require in functional test cases."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"3a681f8b_d1c4d1a4","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":8},"in_reply_to":"d7de7d9b_dcb2d82d","updated":"2022-02-18 06:08:02.000000000","message":"I\u0027ve confirmed.","commit_id":"fe6586d3fa62aa82c69bd8b4dd2bc274c0f7944c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"3237b5e4_1135b38c","updated":"2022-02-02 01:50:05.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"87c1d139_f9548cc3","updated":"2022-02-02 02:54:49.000000000","message":"Thank you Ueha san for your review comments.\nIncorporated desired changes in Patchset #18.\n\nRegarding comment \"vim configuration file creation by gen_vim_config.sh\", please find my replies and would be glad to hear your opinion.\n\nThanks!!","commit_id":"74e3db063ce411c4cc5f2632168c5d3056e94a4f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f841b76002fa03a5c2352789409076f762d6d32b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"969b67f5_ba092b44","updated":"2022-02-02 04:46:50.000000000","message":"Thanks for your rework and answer, please kindly check my comments.","commit_id":"74e3db063ce411c4cc5f2632168c5d3056e94a4f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"324def39_daf97738","updated":"2022-02-02 08:35:05.000000000","message":"Thanks for your rework! but I missed the misspelling in commit message..\nExcept for that, it is LGTM.","commit_id":"fe6586d3fa62aa82c69bd8b4dd2bc274c0f7944c"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b86c152afef51fcbb73e0c4daa283a46193230eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b6e1295e_6e0a9434","updated":"2022-02-14 05:47:46.000000000","message":"ping","commit_id":"7e5d38bf96ff7cd2be12e277087446f10bfd5470"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"7eaa54bbade34e2b83cd3898bc73f0d0f924b87f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"43804679_77d31548","updated":"2022-02-02 15:01:40.000000000","message":"recheck","commit_id":"7e5d38bf96ff7cd2be12e277087446f10bfd5470"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bacb0d56fdd2e17905f5b5caedbf2db3e885be70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"aed1a1a1_c78f2270","updated":"2022-02-16 14:41:20.000000000","message":"I can see projects/users are created in pre.yaml phase\nhttps://zuul.opendev.org/t/openstack/build/f6b28d3d19024c8aa9f2eed7eeee2f14/console","commit_id":"c072254201a05e03aa8e1e34105c28c15d81ca5d"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"88ad45b5c1fdf23ed7acb124a759f6b12307658a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"cb5e5f1f_5c2660a0","updated":"2022-02-16 14:01:05.000000000","message":"Thanks Ogawa san and Ghanshyam san, as suggested I have removed shell script and added OpenStack project and user creation CLIs in Ansible playbook. ","commit_id":"c072254201a05e03aa8e1e34105c28c15d81ca5d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c5288bbd5031a6e30b9c294d3c410ad2eb39101f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"c186931c_4ed81dac","updated":"2022-02-18 06:08:02.000000000","message":"LGTM.","commit_id":"724e679e93a7a061c69850229c886a01bdd809a1"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"18120e8fae95421c6bbe13b81c0f9ba923c0b989","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"bb5ce80f_1c9f5d93","updated":"2022-02-18 06:06:04.000000000","message":"Manpreet san, Mann san,\nThank you for the update. It works fine and LGTM!","commit_id":"724e679e93a7a061c69850229c886a01bdd809a1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b1cbcfafdf01a0fd5f966d698539eee0207eb2e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"480d624e_48c8b0e4","updated":"2022-02-18 05:11:30.000000000","message":"ping","commit_id":"724e679e93a7a061c69850229c886a01bdd809a1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"250519412ff3052aa81ce3461cdbcf3bf0beb193","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"55baaa2b_271fb3f5","updated":"2022-02-18 01:58:27.000000000","message":"recheck","commit_id":"724e679e93a7a061c69850229c886a01bdd809a1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"208e78e8da1e0d23f87b208a1736741482b646c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"5f9ec033_5d2e8b4b","updated":"2022-02-17 16:21:17.000000000","message":"recheck","commit_id":"724e679e93a7a061c69850229c886a01bdd809a1"}],"roles/setup-multi-tenant-vim/tasks/main.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[{"line_number":6,"context_line":"       dest\u003d{{ zuul_work_dir }}/tools/create_project_and_user_for_multi_tenant.sh"},{"line_number":7,"context_line":"       mode\u003d0755"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  - name: Copy first tenant vim file"},{"line_number":10,"context_line":"    copy:"},{"line_number":11,"context_line":"       remote_src\u003dTrue"},{"line_number":12,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-tenant1-vim.yaml"},{"line_number":13,"context_line":"       dest\u003d{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant1-vim.yaml"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  - name: Copy second tenant vim file"},{"line_number":16,"context_line":"    copy:"},{"line_number":17,"context_line":"       remote_src\u003dTrue"},{"line_number":18,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-tenant2-vim.yaml"},{"line_number":19,"context_line":"       dest\u003d{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant2-vim.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  - name: Get stackenv from devstack environment"},{"line_number":22,"context_line":"    slurp:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"65887084_8bff5e99","line":19,"range":{"start_line":9,"start_character":0,"end_line":19,"end_character":79},"updated":"2022-02-02 01:50:05.000000000","message":"vim configuration will created by using gen_vim_config.sh below.\nSo, I think this task can be deleted.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"7528f3a7d9d4ee08e433d960640dda9ecc4d30a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"       dest\u003d{{ zuul_work_dir }}/tools/create_project_and_user_for_multi_tenant.sh"},{"line_number":7,"context_line":"       mode\u003d0755"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  - name: Copy first tenant vim file"},{"line_number":10,"context_line":"    copy:"},{"line_number":11,"context_line":"       remote_src\u003dTrue"},{"line_number":12,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-tenant1-vim.yaml"},{"line_number":13,"context_line":"       dest\u003d{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant1-vim.yaml"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  - name: Copy second tenant vim file"},{"line_number":16,"context_line":"    copy:"},{"line_number":17,"context_line":"       remote_src\u003dTrue"},{"line_number":18,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-tenant2-vim.yaml"},{"line_number":19,"context_line":"       dest\u003d{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant2-vim.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  - name: Get stackenv from devstack environment"},{"line_number":22,"context_line":"    slurp:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"8eece345_aac72059","line":19,"range":{"start_line":9,"start_character":0,"end_line":19,"end_character":79},"in_reply_to":"475f0b49_a2b6235d","updated":"2022-02-02 06:57:58.000000000","message":"Thank you so much Ueha san for your suggestion. \n\nIn Patchset #20, the following changes are done to incorporate review comments, \n  1. Remove VIM config files.\n  2. In Ansible playbook removed explicit code for VIM file (i.e. copy command and copy auth uri to VIM config files).\n  3. Cleanup, additionally removed explicit coping of tools/create_project_and_user_for_multi_tenant.sh to Zuul directory.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":true,"context_lines":[{"line_number":6,"context_line":"       dest\u003d{{ zuul_work_dir }}/tools/create_project_and_user_for_multi_tenant.sh"},{"line_number":7,"context_line":"       mode\u003d0755"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  - name: Copy first tenant vim file"},{"line_number":10,"context_line":"    copy:"},{"line_number":11,"context_line":"       remote_src\u003dTrue"},{"line_number":12,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-tenant1-vim.yaml"},{"line_number":13,"context_line":"       dest\u003d{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant1-vim.yaml"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  - name: Copy second tenant vim file"},{"line_number":16,"context_line":"    copy:"},{"line_number":17,"context_line":"       remote_src\u003dTrue"},{"line_number":18,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-tenant2-vim.yaml"},{"line_number":19,"context_line":"       dest\u003d{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant2-vim.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  - name: Get stackenv from devstack environment"},{"line_number":22,"context_line":"    slurp:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"f0e069ae_e2837b93","line":19,"range":{"start_line":9,"start_character":0,"end_line":19,"end_character":79},"in_reply_to":"65887084_8bff5e99","updated":"2022-02-02 02:54:49.000000000","message":"The VIM configuration files are used in functional test cases, in BaseTackerTest class VIM conf files are loaded to obtain authentication details. Please refer [1].\nIMO the file path refer in [1] is tacker/tacker/tests/etc/samples. Please let me know whether my understanding is correct.\n\n[1] https://github.com/openstack/tacker/blob/master/tacker/tests/functional/base.py#L107","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"       dest\u003d{{ zuul_work_dir }}/tools/create_project_and_user_for_multi_tenant.sh"},{"line_number":7,"context_line":"       mode\u003d0755"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  - name: Copy first tenant vim file"},{"line_number":10,"context_line":"    copy:"},{"line_number":11,"context_line":"       remote_src\u003dTrue"},{"line_number":12,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-tenant1-vim.yaml"},{"line_number":13,"context_line":"       dest\u003d{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant1-vim.yaml"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  - name: Copy second tenant vim file"},{"line_number":16,"context_line":"    copy:"},{"line_number":17,"context_line":"       remote_src\u003dTrue"},{"line_number":18,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-tenant2-vim.yaml"},{"line_number":19,"context_line":"       dest\u003d{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant2-vim.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  - name: Get stackenv from devstack environment"},{"line_number":22,"context_line":"    slurp:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"e2766edc_4245bf57","line":19,"range":{"start_line":9,"start_character":0,"end_line":19,"end_character":79},"in_reply_to":"8eece345_aac72059","updated":"2022-02-02 08:35:05.000000000","message":"Thanks a lot, I think it becomes better!","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f841b76002fa03a5c2352789409076f762d6d32b","unresolved":true,"context_lines":[{"line_number":6,"context_line":"       dest\u003d{{ zuul_work_dir }}/tools/create_project_and_user_for_multi_tenant.sh"},{"line_number":7,"context_line":"       mode\u003d0755"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  - name: Copy first tenant vim file"},{"line_number":10,"context_line":"    copy:"},{"line_number":11,"context_line":"       remote_src\u003dTrue"},{"line_number":12,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-tenant1-vim.yaml"},{"line_number":13,"context_line":"       dest\u003d{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant1-vim.yaml"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"  - name: Copy second tenant vim file"},{"line_number":16,"context_line":"    copy:"},{"line_number":17,"context_line":"       remote_src\u003dTrue"},{"line_number":18,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-tenant2-vim.yaml"},{"line_number":19,"context_line":"       dest\u003d{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant2-vim.yaml"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  - name: Get stackenv from devstack environment"},{"line_number":22,"context_line":"    slurp:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"475f0b49_a2b6235d","line":19,"range":{"start_line":9,"start_character":0,"end_line":19,"end_character":79},"in_reply_to":"f0e069ae_e2837b93","updated":"2022-02-02 04:46:50.000000000","message":"It is used in FT code.. I understood.\nHowever, will the following tasks generate same config files under the `/tmp` folder, right?\n* Generate OpenStack VIM config for first tenant\n* Generate OpenStack VIM config for second tenant\n\nIf so, how about changing to copy the generated config files under the `tacker/tacker/tests/etc/samples`?","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                | regex_replace(\u0027^.*KEYSTONE_SERVICE_URI\u003d([^ ]+).*$\u0027, \u0027\\\\1\u0027)"},{"line_number":33,"context_line":"                }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  - name: Replace auth uri in tenant vim files"},{"line_number":36,"context_line":"    replace:"},{"line_number":37,"context_line":"      path: \"{{ item }}\""},{"line_number":38,"context_line":"      regexp: \"http://127.0.0.1/identity\""},{"line_number":39,"context_line":"      replace: \"{{ auth_uri }}\""},{"line_number":40,"context_line":"    with_items:"},{"line_number":41,"context_line":"      - \"{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant1-vim.yaml\""},{"line_number":42,"context_line":"      - \"{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant2-vim.yaml\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  - name: Replace the devstack path in the create_project_and_user_for_multi_tenant.sh"},{"line_number":45,"context_line":"    replace:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"e0f5cce8_0215f385","line":42,"range":{"start_line":35,"start_character":0,"end_line":42,"end_character":77},"updated":"2022-02-02 01:50:05.000000000","message":"ditto.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                | regex_replace(\u0027^.*KEYSTONE_SERVICE_URI\u003d([^ ]+).*$\u0027, \u0027\\\\1\u0027)"},{"line_number":33,"context_line":"                }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  - name: Replace auth uri in tenant vim files"},{"line_number":36,"context_line":"    replace:"},{"line_number":37,"context_line":"      path: \"{{ item }}\""},{"line_number":38,"context_line":"      regexp: \"http://127.0.0.1/identity\""},{"line_number":39,"context_line":"      replace: \"{{ auth_uri }}\""},{"line_number":40,"context_line":"    with_items:"},{"line_number":41,"context_line":"      - \"{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant1-vim.yaml\""},{"line_number":42,"context_line":"      - \"{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant2-vim.yaml\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  - name: Replace the devstack path in the create_project_and_user_for_multi_tenant.sh"},{"line_number":45,"context_line":"    replace:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"f4715ffa_95f80ef6","line":42,"range":{"start_line":35,"start_character":0,"end_line":42,"end_character":77},"in_reply_to":"e0f5cce8_0215f385","updated":"2022-02-02 02:54:49.000000000","message":"Reason same as above.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                | regex_replace(\u0027^.*KEYSTONE_SERVICE_URI\u003d([^ ]+).*$\u0027, \u0027\\\\1\u0027)"},{"line_number":33,"context_line":"                }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  - name: Replace auth uri in tenant vim files"},{"line_number":36,"context_line":"    replace:"},{"line_number":37,"context_line":"      path: \"{{ item }}\""},{"line_number":38,"context_line":"      regexp: \"http://127.0.0.1/identity\""},{"line_number":39,"context_line":"      replace: \"{{ auth_uri }}\""},{"line_number":40,"context_line":"    with_items:"},{"line_number":41,"context_line":"      - \"{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant1-vim.yaml\""},{"line_number":42,"context_line":"      - \"{{ zuul_work_dir }}/tacker/tests/etc/samples/local-tenant2-vim.yaml\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  - name: Replace the devstack path in the create_project_and_user_for_multi_tenant.sh"},{"line_number":45,"context_line":"    replace:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"05fe1996_b5f1b415","line":42,"range":{"start_line":35,"start_character":0,"end_line":42,"end_character":77},"in_reply_to":"f4715ffa_95f80ef6","updated":"2022-02-02 08:35:05.000000000","message":"Ack","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"}],"tacker/tests/etc/samples/local-tenant1-vim.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"5812b84e_2baf323e","updated":"2022-02-02 01:50:05.000000000","message":"vim configuration will created by using gen_vim_config.sh in roles/setup-multi-tenant-vim/tasks/main.yaml.\nSo, I think this file can be deleted.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"600889be_2c76c1f2","in_reply_to":"5812b84e_2baf323e","updated":"2022-02-02 02:54:49.000000000","message":"The VIM configuration files are used in functional test cases, in BaseTackerTest class VIM conf files are loaded to obtain authentication details. Please refer [1].\nIMO the file path refer in [1] is tacker/tacker/tests/etc/samples. Please let me know whether my understanding is correct.\n\n[1] https://github.com/openstack/tacker/blob/master/tacker/tests/functional/base.py#L107","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"55803694_5c78f0b2","in_reply_to":"600889be_2c76c1f2","updated":"2022-02-02 08:35:05.000000000","message":"Ack","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"}],"tacker/tests/etc/samples/local-tenant2-vim.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"1b5304ae_5bd015f9","updated":"2022-02-02 01:50:05.000000000","message":"same comment as local-tennt1-vim.yaml","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"29e85b61_c73fbda9","in_reply_to":"1b5304ae_5bd015f9","updated":"2022-02-02 02:54:49.000000000","message":"The VIM configuration files are used in functional test cases, in BaseTackerTest class VIM conf files are loaded to obtain authentication details. Please refer [1].\nIMO the file path refer in [1] is tacker/tacker/tests/etc/samples. Please let me know whether my understanding is correct.\n\n[1] https://github.com/openstack/tacker/blob/master/tacker/tests/functional/base.py#L107","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d9fd2265_8c3c37d3","in_reply_to":"29e85b61_c73fbda9","updated":"2022-02-02 08:35:05.000000000","message":"Ack","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"}],"tools/create_project_and_user_for_multi_tenant.sh":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[{"line_number":22,"context_line":"##########################################"},{"line_number":23,"context_line":"function create_os_project() {"},{"line_number":24,"context_line":"    openstack project create --domain $PROJECT_DOMAIN \\"},{"line_number":25,"context_line":"\t    --description \u0027Test multi tenant policy\u0027 \\"},{"line_number":26,"context_line":"\t    $PROJECT_NAME"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":"###########################################"}],"source_content_type":"text/x-sh","patch_set":17,"id":"1062363e_ff7378ef","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":1},"updated":"2022-02-02 01:50:05.000000000","message":"Why don\u0027t you use space instead of tab?","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":false,"context_lines":[{"line_number":22,"context_line":"##########################################"},{"line_number":23,"context_line":"function create_os_project() {"},{"line_number":24,"context_line":"    openstack project create --domain $PROJECT_DOMAIN \\"},{"line_number":25,"context_line":"\t    --description \u0027Test multi tenant policy\u0027 \\"},{"line_number":26,"context_line":"\t    $PROJECT_NAME"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":"###########################################"}],"source_content_type":"text/x-sh","patch_set":17,"id":"40bc73fa_f14031dc","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":1},"in_reply_to":"1062363e_ff7378ef","updated":"2022-02-02 02:54:49.000000000","message":"Done","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"7528f3a7d9d4ee08e433d960640dda9ecc4d30a0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"##########################################"},{"line_number":23,"context_line":"function create_os_project() {"},{"line_number":24,"context_line":"    openstack project create --domain $PROJECT_DOMAIN \\"},{"line_number":25,"context_line":"\t    --description \u0027Test multi tenant policy\u0027 \\"},{"line_number":26,"context_line":"\t    $PROJECT_NAME"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":"###########################################"}],"source_content_type":"text/x-sh","patch_set":17,"id":"8182af01_c7875fdc","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":1},"in_reply_to":"3f6eb5a6_0b53084d","updated":"2022-02-02 06:57:58.000000000","message":"Done\nSorry for the inconvenience, that was wrongly indented.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f841b76002fa03a5c2352789409076f762d6d32b","unresolved":true,"context_lines":[{"line_number":22,"context_line":"##########################################"},{"line_number":23,"context_line":"function create_os_project() {"},{"line_number":24,"context_line":"    openstack project create --domain $PROJECT_DOMAIN \\"},{"line_number":25,"context_line":"\t    --description \u0027Test multi tenant policy\u0027 \\"},{"line_number":26,"context_line":"\t    $PROJECT_NAME"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":"###########################################"}],"source_content_type":"text/x-sh","patch_set":17,"id":"3f6eb5a6_0b53084d","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":1},"in_reply_to":"40bc73fa_f14031dc","updated":"2022-02-02 04:46:50.000000000","message":"I\u0027ve confirmed. but why did you change the indent to three space characters?","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"##########################################"},{"line_number":23,"context_line":"function create_os_project() {"},{"line_number":24,"context_line":"    openstack project create --domain $PROJECT_DOMAIN \\"},{"line_number":25,"context_line":"\t    --description \u0027Test multi tenant policy\u0027 \\"},{"line_number":26,"context_line":"\t    $PROJECT_NAME"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":"###########################################"}],"source_content_type":"text/x-sh","patch_set":17,"id":"c27a5d2e_3867bc96","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":1},"in_reply_to":"8182af01_c7875fdc","updated":"2022-02-02 08:35:05.000000000","message":"I\u0027ve confirmed.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[{"line_number":23,"context_line":"function create_os_project() {"},{"line_number":24,"context_line":"    openstack project create --domain $PROJECT_DOMAIN \\"},{"line_number":25,"context_line":"\t    --description \u0027Test multi tenant policy\u0027 \\"},{"line_number":26,"context_line":"\t    $PROJECT_NAME"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":"###########################################"},{"line_number":29,"context_line":"# Create new OpenStack user and assign role"}],"source_content_type":"text/x-sh","patch_set":17,"id":"20408962_8ec9eab4","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":1},"updated":"2022-02-02 01:50:05.000000000","message":"ditto","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":false,"context_lines":[{"line_number":23,"context_line":"function create_os_project() {"},{"line_number":24,"context_line":"    openstack project create --domain $PROJECT_DOMAIN \\"},{"line_number":25,"context_line":"\t    --description \u0027Test multi tenant policy\u0027 \\"},{"line_number":26,"context_line":"\t    $PROJECT_NAME"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":"###########################################"},{"line_number":29,"context_line":"# Create new OpenStack user and assign role"}],"source_content_type":"text/x-sh","patch_set":17,"id":"38fba316_3bf2efa0","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":1},"in_reply_to":"20408962_8ec9eab4","updated":"2022-02-02 02:54:49.000000000","message":"Done","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f841b76002fa03a5c2352789409076f762d6d32b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"function create_os_project() {"},{"line_number":24,"context_line":"    openstack project create --domain $PROJECT_DOMAIN \\"},{"line_number":25,"context_line":"\t    --description \u0027Test multi tenant policy\u0027 \\"},{"line_number":26,"context_line":"\t    $PROJECT_NAME"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":"###########################################"},{"line_number":29,"context_line":"# Create new OpenStack user and assign role"}],"source_content_type":"text/x-sh","patch_set":17,"id":"cdd14ad1_ef96985e","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":1},"in_reply_to":"38fba316_3bf2efa0","updated":"2022-02-02 04:46:50.000000000","message":"ditto.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"7528f3a7d9d4ee08e433d960640dda9ecc4d30a0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"function create_os_project() {"},{"line_number":24,"context_line":"    openstack project create --domain $PROJECT_DOMAIN \\"},{"line_number":25,"context_line":"\t    --description \u0027Test multi tenant policy\u0027 \\"},{"line_number":26,"context_line":"\t    $PROJECT_NAME"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":"###########################################"},{"line_number":29,"context_line":"# Create new OpenStack user and assign role"}],"source_content_type":"text/x-sh","patch_set":17,"id":"da77c0a0_5c3e01f9","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":1},"in_reply_to":"cdd14ad1_ef96985e","updated":"2022-02-02 06:57:58.000000000","message":"Done","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"function create_os_project() {"},{"line_number":24,"context_line":"    openstack project create --domain $PROJECT_DOMAIN \\"},{"line_number":25,"context_line":"\t    --description \u0027Test multi tenant policy\u0027 \\"},{"line_number":26,"context_line":"\t    $PROJECT_NAME"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":"###########################################"},{"line_number":29,"context_line":"# Create new OpenStack user and assign role"}],"source_content_type":"text/x-sh","patch_set":17,"id":"de870930_fe5b87c6","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":1},"in_reply_to":"da77c0a0_5c3e01f9","updated":"2022-02-02 08:35:05.000000000","message":"I\u0027ve confirmed.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[{"line_number":70,"context_line":"DEVSTACK_PATH\u003d/opt/stack/devstack"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"if [ -z \"$*\" ]; then"},{"line_number":73,"context_line":"\techo \"Missing mandatory arguments.\""},{"line_number":74,"context_line":"        usage"},{"line_number":75,"context_line":"\texit 1"},{"line_number":76,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":17,"id":"4964fd7d_d9028e79","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":1},"updated":"2022-02-02 01:50:05.000000000","message":"ditto","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":false,"context_lines":[{"line_number":70,"context_line":"DEVSTACK_PATH\u003d/opt/stack/devstack"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"if [ -z \"$*\" ]; then"},{"line_number":73,"context_line":"\techo \"Missing mandatory arguments.\""},{"line_number":74,"context_line":"        usage"},{"line_number":75,"context_line":"\texit 1"},{"line_number":76,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ef00f961_f322cdc1","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":1},"in_reply_to":"4964fd7d_d9028e79","updated":"2022-02-02 02:54:49.000000000","message":"Done","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"DEVSTACK_PATH\u003d/opt/stack/devstack"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"if [ -z \"$*\" ]; then"},{"line_number":73,"context_line":"\techo \"Missing mandatory arguments.\""},{"line_number":74,"context_line":"        usage"},{"line_number":75,"context_line":"\texit 1"},{"line_number":76,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ec3d217a_a0283430","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":1},"in_reply_to":"ef00f961_f322cdc1","updated":"2022-02-02 08:35:05.000000000","message":"I\u0027ve confirmed.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[{"line_number":72,"context_line":"if [ -z \"$*\" ]; then"},{"line_number":73,"context_line":"\techo \"Missing mandatory arguments.\""},{"line_number":74,"context_line":"        usage"},{"line_number":75,"context_line":"\texit 1"},{"line_number":76,"context_line":"fi"},{"line_number":77,"context_line":"if [ \"$OPTIND\" \u003d 1 ]; then"},{"line_number":78,"context_line":"    while getopts p:d:u:o:s:r:h OPT; do"}],"source_content_type":"text/x-sh","patch_set":17,"id":"1ebbc4d2_6e315183","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":1},"updated":"2022-02-02 01:50:05.000000000","message":"ditto","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"if [ -z \"$*\" ]; then"},{"line_number":73,"context_line":"\techo \"Missing mandatory arguments.\""},{"line_number":74,"context_line":"        usage"},{"line_number":75,"context_line":"\texit 1"},{"line_number":76,"context_line":"fi"},{"line_number":77,"context_line":"if [ \"$OPTIND\" \u003d 1 ]; then"},{"line_number":78,"context_line":"    while getopts p:d:u:o:s:r:h OPT; do"}],"source_content_type":"text/x-sh","patch_set":17,"id":"9a573ffa_17514519","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":1},"in_reply_to":"15d08b24_9a47b978","updated":"2022-02-02 08:35:05.000000000","message":"I\u0027ve confirmed.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":false,"context_lines":[{"line_number":72,"context_line":"if [ -z \"$*\" ]; then"},{"line_number":73,"context_line":"\techo \"Missing mandatory arguments.\""},{"line_number":74,"context_line":"        usage"},{"line_number":75,"context_line":"\texit 1"},{"line_number":76,"context_line":"fi"},{"line_number":77,"context_line":"if [ \"$OPTIND\" \u003d 1 ]; then"},{"line_number":78,"context_line":"    while getopts p:d:u:o:s:r:h OPT; do"}],"source_content_type":"text/x-sh","patch_set":17,"id":"15d08b24_9a47b978","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":1},"in_reply_to":"1ebbc4d2_6e315183","updated":"2022-02-02 02:54:49.000000000","message":"Done","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            PROJECT_NAME\u003d$OPTARG"},{"line_number":82,"context_line":"            ;;"},{"line_number":83,"context_line":"        d)"},{"line_number":84,"context_line":"\t    PROJECT_DOMAIN\u003d$OPTARG"},{"line_number":85,"context_line":"            ;;"},{"line_number":86,"context_line":"        u)"},{"line_number":87,"context_line":"            USER_NAME\u003d$OPTARG"}],"source_content_type":"text/x-sh","patch_set":17,"id":"ee061ce9_a2740e85","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":1},"updated":"2022-02-02 01:50:05.000000000","message":"ditto","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            PROJECT_NAME\u003d$OPTARG"},{"line_number":82,"context_line":"            ;;"},{"line_number":83,"context_line":"        d)"},{"line_number":84,"context_line":"\t    PROJECT_DOMAIN\u003d$OPTARG"},{"line_number":85,"context_line":"            ;;"},{"line_number":86,"context_line":"        u)"},{"line_number":87,"context_line":"            USER_NAME\u003d$OPTARG"}],"source_content_type":"text/x-sh","patch_set":17,"id":"4134dae7_0f483c3a","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":1},"in_reply_to":"0dd9f474_6290686a","updated":"2022-02-02 08:35:05.000000000","message":"I\u0027ve confirmed.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            PROJECT_NAME\u003d$OPTARG"},{"line_number":82,"context_line":"            ;;"},{"line_number":83,"context_line":"        d)"},{"line_number":84,"context_line":"\t    PROJECT_DOMAIN\u003d$OPTARG"},{"line_number":85,"context_line":"            ;;"},{"line_number":86,"context_line":"        u)"},{"line_number":87,"context_line":"            USER_NAME\u003d$OPTARG"}],"source_content_type":"text/x-sh","patch_set":17,"id":"0dd9f474_6290686a","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":1},"in_reply_to":"ee061ce9_a2740e85","updated":"2022-02-02 02:54:49.000000000","message":"Done","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e909196b1cad8b2f3fbfd34eccf9d387462701f0","unresolved":true,"context_lines":[{"line_number":101,"context_line":"            ;;"},{"line_number":102,"context_line":"        \\?)"},{"line_number":103,"context_line":"            echo \"Try to enter the h option.\" 1\u003e\u00262"},{"line_number":104,"context_line":"\t    exit 1"},{"line_number":105,"context_line":"            ;;"},{"line_number":106,"context_line":"        esac"},{"line_number":107,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":17,"id":"884f9a39_f137bc88","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":1},"updated":"2022-02-02 01:50:05.000000000","message":"ditto","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15362a93543f6d3fa23b7d0018855f29af68bc19","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            ;;"},{"line_number":102,"context_line":"        \\?)"},{"line_number":103,"context_line":"            echo \"Try to enter the h option.\" 1\u003e\u00262"},{"line_number":104,"context_line":"\t    exit 1"},{"line_number":105,"context_line":"            ;;"},{"line_number":106,"context_line":"        esac"},{"line_number":107,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":17,"id":"8ff28793_3928ca68","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":1},"in_reply_to":"884f9a39_f137bc88","updated":"2022-02-02 02:54:49.000000000","message":"Done","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54a2765e3d7e2e8a8b1de38af6bc20aa55de8f5e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            ;;"},{"line_number":102,"context_line":"        \\?)"},{"line_number":103,"context_line":"            echo \"Try to enter the h option.\" 1\u003e\u00262"},{"line_number":104,"context_line":"\t    exit 1"},{"line_number":105,"context_line":"            ;;"},{"line_number":106,"context_line":"        esac"},{"line_number":107,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":17,"id":"c2a7635d_2167fc0d","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":1},"in_reply_to":"8ff28793_3928ca68","updated":"2022-02-02 08:35:05.000000000","message":"I\u0027ve confirmed.","commit_id":"33b6c90b23d13db7f806d1185132d8f0afaf8b46"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"928f86f3f95fc6bef4236cd17a3357eae1cc7afb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3d7dd268_89ec9d57","line":1,"updated":"2022-02-02 18:27:59.000000000","message":"Could I confirm that this script is expected to be run from command line? I\u0027m not sure why you put it under `tools/` and has shebang. If the answer is yes, why don\u0027t you add a doc for explaining this script?","commit_id":"7e5d38bf96ff7cd2be12e277087446f10bfd5470"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d8b99f0d524a7355995e0460db76b0f8de63bbdc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":21,"id":"d0f6ce72_71fca65b","line":1,"in_reply_to":"1845f076_a0c6cdf2","updated":"2022-02-03 02:20:56.000000000","message":"\u003e As most of the Tacker Ansible playbooks execute scripts under `tools/` so was added there.\nThe reason why we run VIM registration from scripts under `tools/` is that we cannot do the task from a playbook because we don\u0027t know why.　So, it\u0027s just a temporary solution actually. Only two scripts `test-setup-*.sh` are called from playbooks. In addition, I\u0027ve tried to remove such scripts in [1] as you may know.\n\n\u003e if we think of adding this script for general purpose then could you please suggest an appropriate folder\nIn Tacker and other projects, scripts run from CLI, tox or devstack are put under `tools/`, but not from playbooks currently.\n\nAnyway, in my opinion, your script looks as a helper mainly for the playbooks and not so helpful as a CLI command because it\u0027s just a shortcut of one or two openstack commands. So, it\u0027s enough to run each command from the playbooks directly. If you think the script must be helpful for users, please add documentation. Appropriate doc location for CLI command is `docs/source/reference` and [2] is an example for.\n\nThanks.\n\n[1] https://review.opendev.org/c/openstack/tacker/+/814366\n[2] https://review.opendev.org/c/openstack/tacker/+/812261","commit_id":"7e5d38bf96ff7cd2be12e277087446f10bfd5470"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"9375d50c53a3d2ea7d3d5f4074433e42f4a21cfe","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":21,"id":"1845f076_a0c6cdf2","line":1,"in_reply_to":"3d7dd268_89ec9d57","updated":"2022-02-03 01:26:37.000000000","message":"The sole purpose of this script was to execute OpenStack CLI for project and user creation with default options. As most of the Tacker Ansible playbooks execute scripts under `tools/` so was added there. As pointed out regarding \u0027shebang\u0027 I agree with removing it as it\u0027s added under the `tools/` folder. \nBut on the other hand, if we think of adding this script for general purpose then could you please suggest an appropriate folder to add and doc location for the explanation.  \nPlease share your opinion.","commit_id":"7e5d38bf96ff7cd2be12e277087446f10bfd5470"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a48dbd2741805926b338c157008aa8fab012cebe","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":21,"id":"d09504ee_b7daed64","line":1,"in_reply_to":"9e24998d_17639903","updated":"2022-02-15 03:54:37.000000000","message":"I think Ogawa San suggesting to create users directly in ansible role instead of creating this separate script and I agree on that.\n\nin ansible role, you can create like below (I have not run it but please modify in case of any syntex error or so):\n https://review.opendev.org/c/openstack/tacker/+/824948/21/roles/setup-multi-tenant-vim/tasks/main.yaml#8\n\nIt create the project/users/assign role with the devstack-admin creds whihc is created in devstack side[1]\n\n - name: Create the first OpenStack project, user, and assign role.\n   shell: |\n     openstack --os-cloud devstack-admin project create --domain\\\n     {{ os_domain_tenant1 }}\\\n     --description \u0027First project to Test multi tenant policy\u0027 \\\n     {{ os_project_tenant1 }}\n     openstack --os-cloud devstack-admin user create --domain\\\n     {{ os_domain_tenant1 }}\\\n     -- password {{ os_password_tenant1 }} {{ os_username_tenant1 }}\n     openstack --os-cloud devstack-admin role add --project\\\n     {{ os_project_tenant1 }}\\\n     --user {{ os_username_tenant1 }} {{ os_member_role }}\n\n - name: Create the second OpenStack project, user, and assign role.\n   shell: |\n     openstack --os-cloud devstack-admin project create --domain\\\n     {{ os_domain_tenant2 }}\\\n     --description \u0027First project to Test multi tenant policy\u0027 \\\n     {{ os_project_tenant2 }}\n     openstack --os-cloud devstack-admin user create --domain\\\n     {{ os_domain_tenant2 }}\\\n     -- password {{ os_password_tenant2 }} {{ os_username_tenant2 }}\n     openstack --os-cloud devstack-admin role add --project\\\n     {{ os_project_tenant2 }}\\\n     --user {{ os_username_tenant2 }} {{ os_member_role }}\n\n\n[1] https://github.com/openstack/devstack/blob/62d6ffa6b3278023d1e385bd50810e0d091e0bc3/functions-common#L99","commit_id":"7e5d38bf96ff7cd2be12e277087446f10bfd5470"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"88ad45b5c1fdf23ed7acb124a759f6b12307658a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":21,"id":"5317e176_16c7910e","line":1,"in_reply_to":"d09504ee_b7daed64","updated":"2022-02-16 14:01:05.000000000","message":"Thank you so much for the suggestion, I have incorporated the above changes in the Ansible book, please refer to Patchset 24, and it is working perfectly.","commit_id":"7e5d38bf96ff7cd2be12e277087446f10bfd5470"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"e340b0783bd25ab8f242140cbd249a49f5e4582e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":21,"id":"9e24998d_17639903","line":1,"in_reply_to":"d0f6ce72_71fca65b","updated":"2022-02-08 07:17:07.000000000","message":"Thank you Ogawa san for your insight and detailed explanation.\n\nI totally agree the script `tools/create_project_and_user_for_multi_tenant.sh` is a helper script for playbook and might not be helpful for users.\nThis script helps in executing OpenStack CLIs (project and user creation) in one bash session and improves playbook readability. \nTo execute OpenStack CLIs (project and user creation) as a task in the playbook, the CLIs fail with a lack of authentication. Although I am looking for a solution [1].\n\nIn case no appropriate solution is found, could you please suggest a location for this script.\n\nPlease share your opinion.\n\nThanks!!\n[1] https://review.opendev.org/c/openstack/tacker/+/827602","commit_id":"7e5d38bf96ff7cd2be12e277087446f10bfd5470"}]}