)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"40f77b0ce059e28966faaa38874ee476d795adb5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Support specifying namespace for deploying CNF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements that in the instantiate operation"},{"line_number":10,"context_line":"of ESTI NFV-SOL003 VNF Lifecycle Management 2.6.1, users"},{"line_number":11,"context_line":"can specify the target namespace in InstantiateVnfRequest"},{"line_number":12,"context_line":"to deploy CNF on Kubernetes VIM."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"aa0cec00_60873a0d","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":7},"updated":"2022-01-20 02:56:23.000000000","message":"typo: ETSI","commit_id":"c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0d314c779303ccbb8d2bbee55c58de11f124b97a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support specifying namespace for deploying CNF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements that in the instantiate operation"},{"line_number":10,"context_line":"of ESTI NFV-SOL003 VNF Lifecycle Management 2.6.1, users"},{"line_number":11,"context_line":"can specify the target namespace in InstantiateVnfRequest"},{"line_number":12,"context_line":"to deploy CNF on Kubernetes VIM."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"eaf9d7f3_78f916ae","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":7},"in_reply_to":"70c89f83_557fb3da","updated":"2022-01-26 08:11:40.000000000","message":"I\u0027ve confirmed.","commit_id":"c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c067f3ad808d6fb789a288868eae34a452a12931","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Support specifying namespace for deploying CNF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements that in the instantiate operation"},{"line_number":10,"context_line":"of ESTI NFV-SOL003 VNF Lifecycle Management 2.6.1, users"},{"line_number":11,"context_line":"can specify the target namespace in InstantiateVnfRequest"},{"line_number":12,"context_line":"to deploy CNF on Kubernetes VIM."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"70c89f83_557fb3da","line":10,"range":{"start_line":10,"start_character":3,"end_line":10,"end_character":7},"in_reply_to":"aa0cec00_60873a0d","updated":"2022-01-21 01:30:03.000000000","message":"Thanks for your comment, I fixed it.","commit_id":"c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"40f77b0ce059e28966faaa38874ee476d795adb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83ab74f6_e2dcea67","updated":"2022-01-20 02:56:23.000000000","message":"Thanks for your patch, please kindly check my comments.","commit_id":"c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"06876675945de52dc7d419a9f71cc80f759c6401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b5a2b1ff_233317e3","updated":"2022-02-07 23:57:49.000000000","message":"Sorry for my late reply.\nThank you for the patch.\nPlease kindly find my comments.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0d314c779303ccbb8d2bbee55c58de11f124b97a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"85256dc3_a45b1b8e","updated":"2022-01-26 08:11:40.000000000","message":"Thanks for your rework, please kindly find additional comment.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"114df6765d4fb69d376d8a038b5df76fe93ee28d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bcc4d839_3c2e7a69","updated":"2022-01-20 12:27:21.000000000","message":"recheck","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"982b895cd386078dfbe43ac8d50351cd75c203dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c9d33196_d563c13e","updated":"2022-01-20 14:54:25.000000000","message":"recheck","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"05c33cfa39318c587c681e967ab6a703761ac9f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"86a2175f_e098b678","updated":"2022-02-15 10:45:18.000000000","message":"Thank you for re-work.\n\nPlease kindly find my additional comments.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"ad2a2e854b848643804349fee2996e46a5e979ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"466231b7_f9c8d459","updated":"2022-02-15 08:39:28.000000000","message":"Thank you for your patch, and sorry for the late confirmation.\nI commented just a little bit, could you please confirm them?","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3446e959708a946384c88db75a79debb0dcdf5a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e533a397_2e29a03c","updated":"2022-02-14 04:59:58.000000000","message":"recheck","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"613f94534e028243fdaf8f0db5b3f7e6a6b599f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b717d0d2_bfe0f2cd","updated":"2022-02-16 03:30:32.000000000","message":"LGTM","commit_id":"cfe29c6f35cc806ddb751337660799ae9bf8d0b4"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"62cf8c4cf896ca87006cd5ef366f99942697b901","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3a2c13fa_ea4a55bd","updated":"2022-02-16 07:33:20.000000000","message":"recheck","commit_id":"cfe29c6f35cc806ddb751337660799ae9bf8d0b4"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1a0674e46da22174400230dcb1b6642f5e1c9c85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ca1d4e15_9b395b90","updated":"2022-02-16 04:33:22.000000000","message":"recheck","commit_id":"cfe29c6f35cc806ddb751337660799ae9bf8d0b4"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"6500fd9d30a93519ed90e05e24e22cc14faa9b04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"91688fda_21c2fa09","updated":"2022-02-22 07:55:11.000000000","message":"Thank you for the fix.\nI have confirm it with Patchset 11.","commit_id":"3ba15b0dc73ff387b2369c5d7e26c01f40a9ccae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"38e20e4d192ef22d07dc117a53d545609225011b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"861f325b_a79a7c26","updated":"2022-03-01 06:25:17.000000000","message":"recheck","commit_id":"ba09a485a38c555d7730eb5d47efdcd76265474e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"afbc76b519aa96a353023e29acaea200b34522ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"53d2cacb_b32e2999","updated":"2022-03-02 10:06:03.000000000","message":"Merge conflict occur because my patch [1] was merged earlier, I will resolve it and change code of retrieve namespace in `_helm_scale()` function in PS14.\n\n[1] https://review.opendev.org/c/openstack/tacker/+/826012","commit_id":"c1ea2169586cde7d2da0a395e4e2dd61f9f3e819"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4536e92a1a077eb73dc425f3ec4c9fde0b9406a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"11aecdec_b49145a1","updated":"2022-03-03 08:44:59.000000000","message":"recheck","commit_id":"d4233537326738993834d496f2effb7eab5150bb"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"fe56902ae4806ef0de2720d3d90cb080f664efb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b12efd99_452bc2ec","updated":"2022-03-03 05:47:17.000000000","message":"recheck","commit_id":"d4233537326738993834d496f2effb7eab5150bb"}],"tacker/common/exceptions.py":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"ad2a2e854b848643804349fee2996e46a5e979ad","unresolved":true,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"class NamespaceIsNotUnique(TackerException):"},{"line_number":437,"context_line":"    message \u003d _(\u0027There are multiple namespaces in the manifest files. \u0027"},{"line_number":438,"context_line":"                \u0027Only one namespace can be used in one VNF.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"d6acb0ae_c3639aa8","line":437,"range":{"start_line":437,"start_character":54,"end_line":437,"end_character":68},"updated":"2022-02-15 08:39:28.000000000","message":"Why don\u0027t we use \"Kubernetes object files\" or \"manifest file for Kubernetes\" instead of \"manifest files\" because it seems to be confusing \"VNF package manifest file\".","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"6500fd9d30a93519ed90e05e24e22cc14faa9b04","unresolved":false,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"class NamespaceIsNotUnique(TackerException):"},{"line_number":437,"context_line":"    message \u003d _(\u0027There are multiple namespaces in the manifest files. \u0027"},{"line_number":438,"context_line":"                \u0027Only one namespace can be used in one VNF.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b1e55064_f973b3c3","line":437,"range":{"start_line":437,"start_character":54,"end_line":437,"end_character":68},"in_reply_to":"b6bb333c_93827370","updated":"2022-02-22 07:55:11.000000000","message":"I have confirmed it.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"960e3207c48645ae863eb8449dcf17b1392005a8","unresolved":true,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"class NamespaceIsNotUnique(TackerException):"},{"line_number":437,"context_line":"    message \u003d _(\u0027There are multiple namespaces in the manifest files. \u0027"},{"line_number":438,"context_line":"                \u0027Only one namespace can be used in one VNF.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b6bb333c_93827370","line":437,"range":{"start_line":437,"start_character":54,"end_line":437,"end_character":68},"in_reply_to":"d6acb0ae_c3639aa8","updated":"2022-02-16 01:56:22.000000000","message":"I fixed this in patch 9.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"}],"tacker/tests/functional/sol_kubernetes/vnflcm/test_kubernetes_multi_ns.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0f0b4d0ba13629c817c43644645d6600ff140c2d","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self._test_cnf_scale(vnf_instance, \"vdu1_aspect\", number_of_steps\u003d1)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        before_vnfc_rscs \u003d self._get_vnfc_resource_info(vnf_instance)"},{"line_number":67,"context_line":"        deployment_target_vnfc \u003d None"},{"line_number":68,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":69,"context_line":"            if vnfc_rsc[\u0027vduId\u0027] \u003d\u003d \u0027VDU1\u0027:"},{"line_number":70,"context_line":"                deployment_target_vnfc \u003d vnfc_rsc"},{"line_number":71,"context_line":"        vnfc_instance_id \u003d [deployment_target_vnfc[\u0027id\u0027]]"},{"line_number":72,"context_line":"        # heal"},{"line_number":73,"context_line":"        after_vnfc_rscs \u003d self._test_heal(vnf_instance, vnfc_instance_id)"},{"line_number":74,"context_line":"        for vnfc_rsc in after_vnfc_rscs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ca971fb8_8f813cd2","line":71,"range":{"start_line":67,"start_character":0,"end_line":71,"end_character":57},"updated":"2022-02-10 12:09:04.000000000","message":"nits. \n\nPlease consider to use list comprehension. \nl.71 will raise an error in any case if \u0027VDU1\u0027 can\u0027t be found.\n\n```\ndeployment_targete_vnfc \u003d [vnfc_rsc for vnfc_rsc in before_vnfc_rscs if vnfc_rsc[\u0027vduId\u0027] \u003d\u003d \u0027VDU1\u0027][0]\nvnfc_instance_id \u003d [deployment_target_vnfc[\u0027id\u0027]]\n```","commit_id":"400ef054ea86af9869dc4f32262e30744a72087f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"05c33cfa39318c587c681e967ab6a703761ac9f9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self._test_cnf_scale(vnf_instance, \"vdu1_aspect\", number_of_steps\u003d1)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        before_vnfc_rscs \u003d self._get_vnfc_resource_info(vnf_instance)"},{"line_number":67,"context_line":"        deployment_target_vnfc \u003d None"},{"line_number":68,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":69,"context_line":"            if vnfc_rsc[\u0027vduId\u0027] \u003d\u003d \u0027VDU1\u0027:"},{"line_number":70,"context_line":"                deployment_target_vnfc \u003d vnfc_rsc"},{"line_number":71,"context_line":"        vnfc_instance_id \u003d [deployment_target_vnfc[\u0027id\u0027]]"},{"line_number":72,"context_line":"        # heal"},{"line_number":73,"context_line":"        after_vnfc_rscs \u003d self._test_heal(vnf_instance, vnfc_instance_id)"},{"line_number":74,"context_line":"        for vnfc_rsc in after_vnfc_rscs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"05e1da41_c0679564","line":71,"range":{"start_line":67,"start_character":0,"end_line":71,"end_character":57},"in_reply_to":"07a7b2c0_d5f5cc66","updated":"2022-02-15 10:45:18.000000000","message":"Ack","commit_id":"400ef054ea86af9869dc4f32262e30744a72087f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3446e959708a946384c88db75a79debb0dcdf5a7","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self._test_cnf_scale(vnf_instance, \"vdu1_aspect\", number_of_steps\u003d1)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        before_vnfc_rscs \u003d self._get_vnfc_resource_info(vnf_instance)"},{"line_number":67,"context_line":"        deployment_target_vnfc \u003d None"},{"line_number":68,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":69,"context_line":"            if vnfc_rsc[\u0027vduId\u0027] \u003d\u003d \u0027VDU1\u0027:"},{"line_number":70,"context_line":"                deployment_target_vnfc \u003d vnfc_rsc"},{"line_number":71,"context_line":"        vnfc_instance_id \u003d [deployment_target_vnfc[\u0027id\u0027]]"},{"line_number":72,"context_line":"        # heal"},{"line_number":73,"context_line":"        after_vnfc_rscs \u003d self._test_heal(vnf_instance, vnfc_instance_id)"},{"line_number":74,"context_line":"        for vnfc_rsc in after_vnfc_rscs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"07a7b2c0_d5f5cc66","line":71,"range":{"start_line":67,"start_character":0,"end_line":71,"end_character":57},"in_reply_to":"ca971fb8_8f813cd2","updated":"2022-02-14 04:59:58.000000000","message":"I fixed this in patch 8.","commit_id":"400ef054ea86af9869dc4f32262e30744a72087f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0f0b4d0ba13629c817c43644645d6600ff140c2d","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        self._test_cnf_scale(vnf_instance, \"vdu1_aspect\", number_of_steps\u003d1)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        before_vnfc_rscs \u003d self._get_vnfc_resource_info(vnf_instance)"},{"line_number":99,"context_line":"        deployment_target_vnfc \u003d None"},{"line_number":100,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":101,"context_line":"            if vnfc_rsc[\u0027vduId\u0027] \u003d\u003d \u0027VDU1\u0027:"},{"line_number":102,"context_line":"                deployment_target_vnfc \u003d vnfc_rsc"},{"line_number":103,"context_line":"        vnfc_instance_id \u003d [deployment_target_vnfc[\u0027id\u0027]]"},{"line_number":104,"context_line":"        # heal"},{"line_number":105,"context_line":"        after_vnfc_rscs \u003d self._test_heal(vnf_instance, vnfc_instance_id)"},{"line_number":106,"context_line":"        for vnfc_rsc in after_vnfc_rscs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"87a43542_471cbe9f","line":103,"range":{"start_line":99,"start_character":0,"end_line":103,"end_character":57},"updated":"2022-02-10 12:09:04.000000000","message":"ditto","commit_id":"400ef054ea86af9869dc4f32262e30744a72087f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"05c33cfa39318c587c681e967ab6a703761ac9f9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self._test_cnf_scale(vnf_instance, \"vdu1_aspect\", number_of_steps\u003d1)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        before_vnfc_rscs \u003d self._get_vnfc_resource_info(vnf_instance)"},{"line_number":99,"context_line":"        deployment_target_vnfc \u003d None"},{"line_number":100,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":101,"context_line":"            if vnfc_rsc[\u0027vduId\u0027] \u003d\u003d \u0027VDU1\u0027:"},{"line_number":102,"context_line":"                deployment_target_vnfc \u003d vnfc_rsc"},{"line_number":103,"context_line":"        vnfc_instance_id \u003d [deployment_target_vnfc[\u0027id\u0027]]"},{"line_number":104,"context_line":"        # heal"},{"line_number":105,"context_line":"        after_vnfc_rscs \u003d self._test_heal(vnf_instance, vnfc_instance_id)"},{"line_number":106,"context_line":"        for vnfc_rsc in after_vnfc_rscs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d6a13fe_43dde7f6","line":103,"range":{"start_line":99,"start_character":0,"end_line":103,"end_character":57},"in_reply_to":"3eead285_0fc279d8","updated":"2022-02-15 10:45:18.000000000","message":"Ack","commit_id":"400ef054ea86af9869dc4f32262e30744a72087f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3446e959708a946384c88db75a79debb0dcdf5a7","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        self._test_cnf_scale(vnf_instance, \"vdu1_aspect\", number_of_steps\u003d1)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        before_vnfc_rscs \u003d self._get_vnfc_resource_info(vnf_instance)"},{"line_number":99,"context_line":"        deployment_target_vnfc \u003d None"},{"line_number":100,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":101,"context_line":"            if vnfc_rsc[\u0027vduId\u0027] \u003d\u003d \u0027VDU1\u0027:"},{"line_number":102,"context_line":"                deployment_target_vnfc \u003d vnfc_rsc"},{"line_number":103,"context_line":"        vnfc_instance_id \u003d [deployment_target_vnfc[\u0027id\u0027]]"},{"line_number":104,"context_line":"        # heal"},{"line_number":105,"context_line":"        after_vnfc_rscs \u003d self._test_heal(vnf_instance, vnfc_instance_id)"},{"line_number":106,"context_line":"        for vnfc_rsc in after_vnfc_rscs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3eead285_0fc279d8","line":103,"range":{"start_line":99,"start_character":0,"end_line":103,"end_character":57},"in_reply_to":"87a43542_471cbe9f","updated":"2022-02-14 04:59:58.000000000","message":"I fixed this in patch 8.","commit_id":"400ef054ea86af9869dc4f32262e30744a72087f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0f0b4d0ba13629c817c43644645d6600ff140c2d","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        self._test_cnf_scale(vnf_instance, \"vdu2_aspect\", number_of_steps\u003d1)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        before_vnfc_rscs \u003d self._get_vnfc_resource_info(vnf_instance)"},{"line_number":130,"context_line":"        deployment_target_vnfc \u003d None"},{"line_number":131,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":132,"context_line":"            if vnfc_rsc[\u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027:"},{"line_number":133,"context_line":"                deployment_target_vnfc \u003d vnfc_rsc"},{"line_number":134,"context_line":"        vnfc_instance_id \u003d [deployment_target_vnfc[\u0027id\u0027]]"},{"line_number":135,"context_line":"        # heal"},{"line_number":136,"context_line":"        after_vnfc_rscs \u003d self._test_heal(vnf_instance, vnfc_instance_id)"},{"line_number":137,"context_line":"        for vnfc_rsc in after_vnfc_rscs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"92169bfb_712796e2","line":134,"range":{"start_line":130,"start_character":0,"end_line":134,"end_character":57},"updated":"2022-02-10 12:09:04.000000000","message":"ditto","commit_id":"400ef054ea86af9869dc4f32262e30744a72087f"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3446e959708a946384c88db75a79debb0dcdf5a7","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        self._test_cnf_scale(vnf_instance, \"vdu2_aspect\", number_of_steps\u003d1)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        before_vnfc_rscs \u003d self._get_vnfc_resource_info(vnf_instance)"},{"line_number":130,"context_line":"        deployment_target_vnfc \u003d None"},{"line_number":131,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":132,"context_line":"            if vnfc_rsc[\u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027:"},{"line_number":133,"context_line":"                deployment_target_vnfc \u003d vnfc_rsc"},{"line_number":134,"context_line":"        vnfc_instance_id \u003d [deployment_target_vnfc[\u0027id\u0027]]"},{"line_number":135,"context_line":"        # heal"},{"line_number":136,"context_line":"        after_vnfc_rscs \u003d self._test_heal(vnf_instance, vnfc_instance_id)"},{"line_number":137,"context_line":"        for vnfc_rsc in after_vnfc_rscs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"cafa5355_d8c28f02","line":134,"range":{"start_line":130,"start_character":0,"end_line":134,"end_character":57},"in_reply_to":"92169bfb_712796e2","updated":"2022-02-14 04:59:58.000000000","message":"I fixed this in patch 8.","commit_id":"400ef054ea86af9869dc4f32262e30744a72087f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"05c33cfa39318c587c681e967ab6a703761ac9f9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self._test_cnf_scale(vnf_instance, \"vdu2_aspect\", number_of_steps\u003d1)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        before_vnfc_rscs \u003d self._get_vnfc_resource_info(vnf_instance)"},{"line_number":130,"context_line":"        deployment_target_vnfc \u003d None"},{"line_number":131,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":132,"context_line":"            if vnfc_rsc[\u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027:"},{"line_number":133,"context_line":"                deployment_target_vnfc \u003d vnfc_rsc"},{"line_number":134,"context_line":"        vnfc_instance_id \u003d [deployment_target_vnfc[\u0027id\u0027]]"},{"line_number":135,"context_line":"        # heal"},{"line_number":136,"context_line":"        after_vnfc_rscs \u003d self._test_heal(vnf_instance, vnfc_instance_id)"},{"line_number":137,"context_line":"        for vnfc_rsc in after_vnfc_rscs:"}],"source_content_type":"text/x-python","patch_set":6,"id":"e8f34e36_34e24832","line":134,"range":{"start_line":130,"start_character":0,"end_line":134,"end_character":57},"in_reply_to":"cafa5355_d8c28f02","updated":"2022-02-15 10:45:18.000000000","message":"Ack","commit_id":"400ef054ea86af9869dc4f32262e30744a72087f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"05c33cfa39318c587c681e967ab6a703761ac9f9","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    def test_multi_tenant_k8s_additional_params(self):"},{"line_number":52,"context_line":"        vnf_instance_name \u003d \"multi_tenant_k8s_additional_params\""},{"line_number":53,"context_line":"        vnf_instance_description \u003d \"multi tenant k8s additional params\""},{"line_number":54,"context_line":"        files \u003d [\"Files/kubernetes/deployment_has_namespace.yaml\","},{"line_number":55,"context_line":"                 \"Files/kubernetes/namespace01.yaml\"]"},{"line_number":56,"context_line":"        additional_param \u003d {"},{"line_number":57,"context_line":"            \"lcm-kubernetes-def-files\": files,"},{"line_number":58,"context_line":"            \"namespace\": \"multi-namespace01\"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"91f4c55d_6ad494e9","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":53},"updated":"2022-02-15 10:45:18.000000000","message":"Is this order correct?\nI just imagined ``namespace01`` is deployed before ``deployment_has_namespace`` is deployed.\nIf I\u0027m wrong, please ignore it.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"960e3207c48645ae863eb8449dcf17b1392005a8","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    def test_multi_tenant_k8s_additional_params(self):"},{"line_number":52,"context_line":"        vnf_instance_name \u003d \"multi_tenant_k8s_additional_params\""},{"line_number":53,"context_line":"        vnf_instance_description \u003d \"multi tenant k8s additional params\""},{"line_number":54,"context_line":"        files \u003d [\"Files/kubernetes/deployment_has_namespace.yaml\","},{"line_number":55,"context_line":"                 \"Files/kubernetes/namespace01.yaml\"]"},{"line_number":56,"context_line":"        additional_param \u003d {"},{"line_number":57,"context_line":"            \"lcm-kubernetes-def-files\": files,"},{"line_number":58,"context_line":"            \"namespace\": \"multi-namespace01\"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"c9d21b8d_32ea8e9b","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":53},"in_reply_to":"6cfd713d_c24a0d97","updated":"2022-02-16 01:56:22.000000000","message":"Before deploying resources, they will be sorted according to the kind of resources, so the manifest file order does not matter.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"4afd4b99877e3fded2a12d5bd101273662c97509","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    def test_multi_tenant_k8s_additional_params(self):"},{"line_number":52,"context_line":"        vnf_instance_name \u003d \"multi_tenant_k8s_additional_params\""},{"line_number":53,"context_line":"        vnf_instance_description \u003d \"multi tenant k8s additional params\""},{"line_number":54,"context_line":"        files \u003d [\"Files/kubernetes/deployment_has_namespace.yaml\","},{"line_number":55,"context_line":"                 \"Files/kubernetes/namespace01.yaml\"]"},{"line_number":56,"context_line":"        additional_param \u003d {"},{"line_number":57,"context_line":"            \"lcm-kubernetes-def-files\": files,"},{"line_number":58,"context_line":"            \"namespace\": \"multi-namespace01\"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"6cfd713d_c24a0d97","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":53},"in_reply_to":"91f4c55d_6ad494e9","updated":"2022-02-15 10:48:34.000000000","message":"The patch passed Zuul, so I think it\u0027s not a problem but I just want to confirm it.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"c7d5ff459a3f3598530e317d6aaaf09caf6f855e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    def test_multi_tenant_k8s_additional_params(self):"},{"line_number":52,"context_line":"        vnf_instance_name \u003d \"multi_tenant_k8s_additional_params\""},{"line_number":53,"context_line":"        vnf_instance_description \u003d \"multi tenant k8s additional params\""},{"line_number":54,"context_line":"        files \u003d [\"Files/kubernetes/deployment_has_namespace.yaml\","},{"line_number":55,"context_line":"                 \"Files/kubernetes/namespace01.yaml\"]"},{"line_number":56,"context_line":"        additional_param \u003d {"},{"line_number":57,"context_line":"            \"lcm-kubernetes-def-files\": files,"},{"line_number":58,"context_line":"            \"namespace\": \"multi-namespace01\"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"32c543c6_bffd5aa2","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":53},"in_reply_to":"9d96c613_538aff3f","updated":"2022-02-16 03:32:03.000000000","message":"Done","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"613f94534e028243fdaf8f0db5b3f7e6a6b599f9","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    def test_multi_tenant_k8s_additional_params(self):"},{"line_number":52,"context_line":"        vnf_instance_name \u003d \"multi_tenant_k8s_additional_params\""},{"line_number":53,"context_line":"        vnf_instance_description \u003d \"multi tenant k8s additional params\""},{"line_number":54,"context_line":"        files \u003d [\"Files/kubernetes/deployment_has_namespace.yaml\","},{"line_number":55,"context_line":"                 \"Files/kubernetes/namespace01.yaml\"]"},{"line_number":56,"context_line":"        additional_param \u003d {"},{"line_number":57,"context_line":"            \"lcm-kubernetes-def-files\": files,"},{"line_number":58,"context_line":"            \"namespace\": \"multi-namespace01\"}"}],"source_content_type":"text/x-python","patch_set":8,"id":"9d96c613_538aff3f","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":53},"in_reply_to":"c9d21b8d_32ea8e9b","updated":"2022-02-16 03:30:32.000000000","message":"I got it, thanks.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"05c33cfa39318c587c681e967ab6a703761ac9f9","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    def test_multi_tenant_k8s_manifest(self):"},{"line_number":84,"context_line":"        vnf_instance_name \u003d \"multi_tenant_k8s_manifest\""},{"line_number":85,"context_line":"        vnf_instance_description \u003d \"multi tenant k8s manifest\""},{"line_number":86,"context_line":"        files \u003d [\"Files/kubernetes/deployment_has_namespace.yaml\","},{"line_number":87,"context_line":"                 \"Files/kubernetes/namespace02.yaml\"]"},{"line_number":88,"context_line":"        additional_param \u003d {\"lcm-kubernetes-def-files\": files}"},{"line_number":89,"context_line":"        # instantiate"},{"line_number":90,"context_line":"        vnf_instance \u003d self._create_and_instantiate_vnf_instance("}],"source_content_type":"text/x-python","patch_set":8,"id":"eb3d5460_8b83e120","line":87,"range":{"start_line":86,"start_character":2,"end_line":87,"end_character":53},"updated":"2022-02-15 10:45:18.000000000","message":"ditto","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"613f94534e028243fdaf8f0db5b3f7e6a6b599f9","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    def test_multi_tenant_k8s_manifest(self):"},{"line_number":84,"context_line":"        vnf_instance_name \u003d \"multi_tenant_k8s_manifest\""},{"line_number":85,"context_line":"        vnf_instance_description \u003d \"multi tenant k8s manifest\""},{"line_number":86,"context_line":"        files \u003d [\"Files/kubernetes/deployment_has_namespace.yaml\","},{"line_number":87,"context_line":"                 \"Files/kubernetes/namespace02.yaml\"]"},{"line_number":88,"context_line":"        additional_param \u003d {\"lcm-kubernetes-def-files\": files}"},{"line_number":89,"context_line":"        # instantiate"},{"line_number":90,"context_line":"        vnf_instance \u003d self._create_and_instantiate_vnf_instance("}],"source_content_type":"text/x-python","patch_set":8,"id":"5c808fb2_4193bf9e","line":87,"range":{"start_line":86,"start_character":2,"end_line":87,"end_character":53},"in_reply_to":"5b46cf1a_d69a67bd","updated":"2022-02-16 03:30:32.000000000","message":"I got it, thanks.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"c7d5ff459a3f3598530e317d6aaaf09caf6f855e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def test_multi_tenant_k8s_manifest(self):"},{"line_number":84,"context_line":"        vnf_instance_name \u003d \"multi_tenant_k8s_manifest\""},{"line_number":85,"context_line":"        vnf_instance_description \u003d \"multi tenant k8s manifest\""},{"line_number":86,"context_line":"        files \u003d [\"Files/kubernetes/deployment_has_namespace.yaml\","},{"line_number":87,"context_line":"                 \"Files/kubernetes/namespace02.yaml\"]"},{"line_number":88,"context_line":"        additional_param \u003d {\"lcm-kubernetes-def-files\": files}"},{"line_number":89,"context_line":"        # instantiate"},{"line_number":90,"context_line":"        vnf_instance \u003d self._create_and_instantiate_vnf_instance("}],"source_content_type":"text/x-python","patch_set":8,"id":"543933eb_e9b2d845","line":87,"range":{"start_line":86,"start_character":2,"end_line":87,"end_character":53},"in_reply_to":"5c808fb2_4193bf9e","updated":"2022-02-16 03:32:03.000000000","message":"Done","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"960e3207c48645ae863eb8449dcf17b1392005a8","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    def test_multi_tenant_k8s_manifest(self):"},{"line_number":84,"context_line":"        vnf_instance_name \u003d \"multi_tenant_k8s_manifest\""},{"line_number":85,"context_line":"        vnf_instance_description \u003d \"multi tenant k8s manifest\""},{"line_number":86,"context_line":"        files \u003d [\"Files/kubernetes/deployment_has_namespace.yaml\","},{"line_number":87,"context_line":"                 \"Files/kubernetes/namespace02.yaml\"]"},{"line_number":88,"context_line":"        additional_param \u003d {\"lcm-kubernetes-def-files\": files}"},{"line_number":89,"context_line":"        # instantiate"},{"line_number":90,"context_line":"        vnf_instance \u003d self._create_and_instantiate_vnf_instance("}],"source_content_type":"text/x-python","patch_set":8,"id":"5b46cf1a_d69a67bd","line":87,"range":{"start_line":86,"start_character":2,"end_line":87,"end_character":53},"in_reply_to":"eb3d5460_8b83e120","updated":"2022-02-16 01:56:22.000000000","message":"The sorting function has been implemented before, and the namespace will be deployed first, and then the deployment will be deployed.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"}],"tacker/tests/unit/vnfm/infra_drivers/kubernetes/test_kubernetes_driver_helm.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"06876675945de52dc7d419a9f71cc80f759c6401","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain\r"},{"line_number":3,"context_line":"#    a copy of the License at\r"},{"line_number":4,"context_line":"#\r"}],"source_content_type":"text/x-python","patch_set":5,"id":"3e28f33b_718c54ce","side":"PARENT","line":1,"updated":"2022-02-07 23:57:49.000000000","message":"Just a question.\nWhat is the cause of this huge diff?\nThe contents look almost the same.","commit_id":"35aaba1aab955fce577edd3b0faf060e62a65a87"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"05c33cfa39318c587c681e967ab6a703761ac9f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain\r"},{"line_number":3,"context_line":"#    a copy of the License at\r"},{"line_number":4,"context_line":"#\r"}],"source_content_type":"text/x-python","patch_set":5,"id":"163079a0_49def151","side":"PARENT","line":1,"in_reply_to":"1ef062a5_a392223d","updated":"2022-02-15 10:45:18.000000000","message":"Ack","commit_id":"35aaba1aab955fce577edd3b0faf060e62a65a87"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0ef9daeae756fc0bfe1b7b255bd49457eaefff13","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain\r"},{"line_number":3,"context_line":"#    a copy of the License at\r"},{"line_number":4,"context_line":"#\r"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ef062a5_a392223d","side":"PARENT","line":1,"in_reply_to":"3e28f33b_718c54ce","updated":"2022-02-10 06:07:34.000000000","message":"It should be caused by the inconsistency between the newline characters CRLF and LF, which has been solved by relying on another patch.","commit_id":"35aaba1aab955fce577edd3b0faf060e62a65a87"}],"tacker/tests/unit/vnfm/infra_drivers/kubernetes/test_utils.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"06876675945de52dc7d419a9f71cc80f759c6401","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from tacker.common import exceptions"},{"line_number":14,"context_line":"from tacker import objects"},{"line_number":15,"context_line":"from tacker.tests.unit import base"},{"line_number":16,"context_line":"from tacker.tests.unit.vnfm.infra_drivers.openstack.fixture_data import \\"},{"line_number":17,"context_line":"    fixture_data_utils as fd_utils"},{"line_number":18,"context_line":"from tacker.vnfm.infra_drivers.kubernetes import utils as k8s_utils"},{"line_number":19,"context_line":"from unittest import mock"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c5592fdb_f6c4068a","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":34},"updated":"2022-02-07 23:57:49.000000000","message":"nits.\n```\nfrom tacker.tests.unit.vnfm.infra_drivers.openstack.fixture_data import (\n    fixture_data_utils as fd_utils\n)\n```","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0f0b4d0ba13629c817c43644645d6600ff140c2d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from tacker.common import exceptions"},{"line_number":14,"context_line":"from tacker import objects"},{"line_number":15,"context_line":"from tacker.tests.unit import base"},{"line_number":16,"context_line":"from tacker.tests.unit.vnfm.infra_drivers.openstack.fixture_data import \\"},{"line_number":17,"context_line":"    fixture_data_utils as fd_utils"},{"line_number":18,"context_line":"from tacker.vnfm.infra_drivers.kubernetes import utils as k8s_utils"},{"line_number":19,"context_line":"from unittest import mock"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ac3f54f3_b18121ce","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":34},"in_reply_to":"b2fe2e39_070c2e02","updated":"2022-02-10 12:09:04.000000000","message":"Ack","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0ef9daeae756fc0bfe1b7b255bd49457eaefff13","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from tacker.common import exceptions"},{"line_number":14,"context_line":"from tacker import objects"},{"line_number":15,"context_line":"from tacker.tests.unit import base"},{"line_number":16,"context_line":"from tacker.tests.unit.vnfm.infra_drivers.openstack.fixture_data import \\"},{"line_number":17,"context_line":"    fixture_data_utils as fd_utils"},{"line_number":18,"context_line":"from tacker.vnfm.infra_drivers.kubernetes import utils as k8s_utils"},{"line_number":19,"context_line":"from unittest import mock"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b2fe2e39_070c2e02","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":34},"in_reply_to":"c5592fdb_f6c4068a","updated":"2022-02-10 06:07:34.000000000","message":"I fixed this in patch 6.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"}],"tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"40f77b0ce059e28966faaa38874ee476d795adb5","unresolved":true,"context_lines":[{"line_number":1587,"context_line":"                         .get(\u0027namespace\u0027, \u0027\u0027))"},{"line_number":1588,"context_line":"            if not namespace:"},{"line_number":1589,"context_line":"                namespace \u003d \u0027default\u0027"},{"line_number":1590,"context_line":"            vnf_instance.vnf_metadata[\u0027namespace\u0027] \u003d namespace"},{"line_number":1591,"context_line":"            vnf_instance.save()"},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":"            return {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9c17491a_7c18e229","line":1590,"range":{"start_line":1590,"start_character":12,"end_line":1590,"end_character":62},"updated":"2022-01-20 02:56:23.000000000","message":"The current failure in sol_kubernetes job seems because of access error to `vnf_instance.vnf_metadata`.\n\nI think that the same check as [1] is necessary here like below.\nhttps://review.opendev.org/c/openstack/tacker/+/825047/3/tacker/vnfm/infra_drivers/kubernetes/utils.py#64\n```\n    if not vnf_instance.vnf_metadata:\n        vnf_instance.vnf_metadata \u003d {}\n```","commit_id":"c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0d314c779303ccbb8d2bbee55c58de11f124b97a","unresolved":false,"context_lines":[{"line_number":1587,"context_line":"                         .get(\u0027namespace\u0027, \u0027\u0027))"},{"line_number":1588,"context_line":"            if not namespace:"},{"line_number":1589,"context_line":"                namespace \u003d \u0027default\u0027"},{"line_number":1590,"context_line":"            vnf_instance.vnf_metadata[\u0027namespace\u0027] \u003d namespace"},{"line_number":1591,"context_line":"            vnf_instance.save()"},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":"            return {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"85f51829_1b2576b6","line":1590,"range":{"start_line":1590,"start_character":12,"end_line":1590,"end_character":62},"in_reply_to":"99f07f2b_82a7e2a5","updated":"2022-01-26 08:11:40.000000000","message":"I\u0027ve confirmed.","commit_id":"c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c067f3ad808d6fb789a288868eae34a452a12931","unresolved":true,"context_lines":[{"line_number":1587,"context_line":"                         .get(\u0027namespace\u0027, \u0027\u0027))"},{"line_number":1588,"context_line":"            if not namespace:"},{"line_number":1589,"context_line":"                namespace \u003d \u0027default\u0027"},{"line_number":1590,"context_line":"            vnf_instance.vnf_metadata[\u0027namespace\u0027] \u003d namespace"},{"line_number":1591,"context_line":"            vnf_instance.save()"},{"line_number":1592,"context_line":""},{"line_number":1593,"context_line":"            return {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"99f07f2b_82a7e2a5","line":1590,"range":{"start_line":1590,"start_character":12,"end_line":1590,"end_character":62},"in_reply_to":"9c17491a_7c18e229","updated":"2022-01-21 01:30:03.000000000","message":"Thanks for your comment, I fixed it.","commit_id":"c1b9ef64f518d42bb42ed818f993ca0efcb0f8f9"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"06876675945de52dc7d419a9f71cc80f759c6401","unresolved":true,"context_lines":[{"line_number":1560,"context_line":"        vnf_resource.vnf_instance_id \u003d vnf_instance.id"},{"line_number":1561,"context_line":"        metadata \u003d file_content_dict.get(\u0027metadata\u0027, {})"},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        chk_namespaces.append("},{"line_number":1564,"context_line":"            {\u0027namespace\u0027: metadata.get(\u0027namespace\u0027, \u0027\u0027),"},{"line_number":1565,"context_line":"             \u0027kind\u0027: file_content_dict.get(\u0027kind\u0027, \u0027\u0027)})"},{"line_number":1566,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5ae363db_f41a1ab6","line":1563,"updated":"2022-02-07 23:57:49.000000000","message":"Please consider to move this part (i.e., ``chk_namespaces`` creation) to ``pre_instantiation_vnf`` [1] since the main role of this function is to create ``vnf_resource``. Creating both vnf_resources and chk_namespaces at ``_create_vnf_resource`` is confusing.\n\nAs this is not a refactoring patch, you can just move it to ``pre_instantiation_vnf`` so that we can do refactoring later.\n\nIf you agree, you can remove ``chk_namepsaces`` from the arguments.\n\n```\n    def _create_vnf_resource(self, context, vnf_instance, file_content_dict):\n```\n\n[1] https://review.opendev.org/c/openstack/tacker/+/825047/5/tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py#1650","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0ef9daeae756fc0bfe1b7b255bd49457eaefff13","unresolved":true,"context_lines":[{"line_number":1560,"context_line":"        vnf_resource.vnf_instance_id \u003d vnf_instance.id"},{"line_number":1561,"context_line":"        metadata \u003d file_content_dict.get(\u0027metadata\u0027, {})"},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        chk_namespaces.append("},{"line_number":1564,"context_line":"            {\u0027namespace\u0027: metadata.get(\u0027namespace\u0027, \u0027\u0027),"},{"line_number":1565,"context_line":"             \u0027kind\u0027: file_content_dict.get(\u0027kind\u0027, \u0027\u0027)})"},{"line_number":1566,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7fbd1bc9_358e2c27","line":1563,"in_reply_to":"5ae363db_f41a1ab6","updated":"2022-02-10 06:07:34.000000000","message":"I moved this part into ``pre_instantiation_vnf``.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0f0b4d0ba13629c817c43644645d6600ff140c2d","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"        vnf_resource.vnf_instance_id \u003d vnf_instance.id"},{"line_number":1561,"context_line":"        metadata \u003d file_content_dict.get(\u0027metadata\u0027, {})"},{"line_number":1562,"context_line":""},{"line_number":1563,"context_line":"        chk_namespaces.append("},{"line_number":1564,"context_line":"            {\u0027namespace\u0027: metadata.get(\u0027namespace\u0027, \u0027\u0027),"},{"line_number":1565,"context_line":"             \u0027kind\u0027: file_content_dict.get(\u0027kind\u0027, \u0027\u0027)})"},{"line_number":1566,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c152865d_f4228863","line":1563,"in_reply_to":"7fbd1bc9_358e2c27","updated":"2022-02-10 12:09:04.000000000","message":"Ack","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0d314c779303ccbb8d2bbee55c58de11f124b97a","unresolved":true,"context_lines":[{"line_number":1564,"context_line":"            {\u0027namespace\u0027: metadata.get(\u0027namespace\u0027, \u0027\u0027),"},{"line_number":1565,"context_line":"             \u0027kind\u0027: file_content_dict.get(\u0027kind\u0027, \u0027\u0027)})"},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"        vnf_resource.resource_name \u003d metadata.get(\u0027name\u0027, \u0027 \u0027)"},{"line_number":1568,"context_line":"        vnf_resource.resource_type \u003d \u0027,\u0027.join(["},{"line_number":1569,"context_line":"            file_content_dict.get(\u0027apiVersion\u0027, \u0027\u0027),"},{"line_number":1570,"context_line":"            file_content_dict.get(\u0027kind\u0027, \u0027\u0027)])"}],"source_content_type":"text/x-python","patch_set":5,"id":"caa49b0c_8e378ba9","line":1567,"range":{"start_line":1567,"start_character":59,"end_line":1567,"end_character":60},"updated":"2022-01-26 08:11:40.000000000","message":"Just a question, why is this space character?","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"294dc1fc4cf4907a30b3688b2a3ad8aa5afe37ce","unresolved":true,"context_lines":[{"line_number":1564,"context_line":"            {\u0027namespace\u0027: metadata.get(\u0027namespace\u0027, \u0027\u0027),"},{"line_number":1565,"context_line":"             \u0027kind\u0027: file_content_dict.get(\u0027kind\u0027, \u0027\u0027)})"},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"        vnf_resource.resource_name \u003d metadata.get(\u0027name\u0027, \u0027 \u0027)"},{"line_number":1568,"context_line":"        vnf_resource.resource_type \u003d \u0027,\u0027.join(["},{"line_number":1569,"context_line":"            file_content_dict.get(\u0027apiVersion\u0027, \u0027\u0027),"},{"line_number":1570,"context_line":"            file_content_dict.get(\u0027kind\u0027, \u0027\u0027)])"}],"source_content_type":"text/x-python","patch_set":5,"id":"d84a3c0a_d4e4dc92","line":1567,"range":{"start_line":1567,"start_character":59,"end_line":1567,"end_character":60},"in_reply_to":"442e730f_5ae71ac3","updated":"2022-02-07 07:38:33.000000000","message":"In the first place, the absence of metadata.name is in an illegal state, and in that case the subsequent processing will not work, right?\n\nIs it possible that metadata.name does not exist?","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"38e6b8a15e8e0fd09387b4fe6cd3895abc8d7c7a","unresolved":true,"context_lines":[{"line_number":1564,"context_line":"            {\u0027namespace\u0027: metadata.get(\u0027namespace\u0027, \u0027\u0027),"},{"line_number":1565,"context_line":"             \u0027kind\u0027: file_content_dict.get(\u0027kind\u0027, \u0027\u0027)})"},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"        vnf_resource.resource_name \u003d metadata.get(\u0027name\u0027, \u0027 \u0027)"},{"line_number":1568,"context_line":"        vnf_resource.resource_type \u003d \u0027,\u0027.join(["},{"line_number":1569,"context_line":"            file_content_dict.get(\u0027apiVersion\u0027, \u0027\u0027),"},{"line_number":1570,"context_line":"            file_content_dict.get(\u0027kind\u0027, \u0027\u0027)])"}],"source_content_type":"text/x-python","patch_set":5,"id":"442e730f_5ae71ac3","line":1567,"range":{"start_line":1567,"start_character":59,"end_line":1567,"end_character":60},"in_reply_to":"caa49b0c_8e378ba9","updated":"2022-01-27 05:01:23.000000000","message":"If no value is assigned here, when there is no `metadata.name` field in yaml, an error will be thrown when calling `vnf_resource.resource_name`, such as https://review.opendev.org/c/openstack/tacker/+/825047/5/tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py#1066\nthe line throws the error `NotImplementedError: Cannot load \u0027resource_name\u0027 in the base class`.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0ef9daeae756fc0bfe1b7b255bd49457eaefff13","unresolved":true,"context_lines":[{"line_number":1564,"context_line":"            {\u0027namespace\u0027: metadata.get(\u0027namespace\u0027, \u0027\u0027),"},{"line_number":1565,"context_line":"             \u0027kind\u0027: file_content_dict.get(\u0027kind\u0027, \u0027\u0027)})"},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"        vnf_resource.resource_name \u003d metadata.get(\u0027name\u0027, \u0027 \u0027)"},{"line_number":1568,"context_line":"        vnf_resource.resource_type \u003d \u0027,\u0027.join(["},{"line_number":1569,"context_line":"            file_content_dict.get(\u0027apiVersion\u0027, \u0027\u0027),"},{"line_number":1570,"context_line":"            file_content_dict.get(\u0027kind\u0027, \u0027\u0027)])"}],"source_content_type":"text/x-python","patch_set":5,"id":"e4dd0abd_1c59a9e9","line":1567,"range":{"start_line":1567,"start_character":59,"end_line":1567,"end_character":60},"in_reply_to":"d84a3c0a_d4e4dc92","updated":"2022-02-10 06:07:34.000000000","message":"Some resources (such as SubjectAccessReview) can be created without ``metadata.name``.\nSo ``metadata.name`` may also not exist.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1912a505c2a1d00c3dd065064ec9abdaf29a9a6f","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"            {\u0027namespace\u0027: metadata.get(\u0027namespace\u0027, \u0027\u0027),"},{"line_number":1565,"context_line":"             \u0027kind\u0027: file_content_dict.get(\u0027kind\u0027, \u0027\u0027)})"},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":"        vnf_resource.resource_name \u003d metadata.get(\u0027name\u0027, \u0027 \u0027)"},{"line_number":1568,"context_line":"        vnf_resource.resource_type \u003d \u0027,\u0027.join(["},{"line_number":1569,"context_line":"            file_content_dict.get(\u0027apiVersion\u0027, \u0027\u0027),"},{"line_number":1570,"context_line":"            file_content_dict.get(\u0027kind\u0027, \u0027\u0027)])"}],"source_content_type":"text/x-python","patch_set":5,"id":"cce0f253_c70f9209","line":1567,"range":{"start_line":1567,"start_character":59,"end_line":1567,"end_character":60},"in_reply_to":"e4dd0abd_1c59a9e9","updated":"2022-02-24 04:11:32.000000000","message":"I understood, thank you.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"06876675945de52dc7d419a9f71cc80f759c6401","unresolved":true,"context_lines":[{"line_number":1649,"context_line":"                for file_content_dict in file_content_dict_list:"},{"line_number":1650,"context_line":"                    vnf_resource \u003d self._create_vnf_resource("},{"line_number":1651,"context_line":"                        context, vnf_instance, file_content_dict,"},{"line_number":1652,"context_line":"                        chk_namespaces)"},{"line_number":1653,"context_line":"                    vnf_resources_temp.append(vnf_resource)"},{"line_number":1654,"context_line":"                vnf_resources[target_k8s_index] \u003d vnf_resources_temp"},{"line_number":1655,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"769e130c_043f15c0","line":1652,"updated":"2022-02-07 23:57:49.000000000","message":"if you agree with the comment at l.1563, please remove ``chk_namespaces`` from the arguments and move the codes to create chk_namespaces to here.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0f0b4d0ba13629c817c43644645d6600ff140c2d","unresolved":false,"context_lines":[{"line_number":1649,"context_line":"                for file_content_dict in file_content_dict_list:"},{"line_number":1650,"context_line":"                    vnf_resource \u003d self._create_vnf_resource("},{"line_number":1651,"context_line":"                        context, vnf_instance, file_content_dict,"},{"line_number":1652,"context_line":"                        chk_namespaces)"},{"line_number":1653,"context_line":"                    vnf_resources_temp.append(vnf_resource)"},{"line_number":1654,"context_line":"                vnf_resources[target_k8s_index] \u003d vnf_resources_temp"},{"line_number":1655,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7b0d25ee_7c6c1b1d","line":1652,"in_reply_to":"39db0015_0ae5a27c","updated":"2022-02-10 12:09:04.000000000","message":"Ack","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0ef9daeae756fc0bfe1b7b255bd49457eaefff13","unresolved":true,"context_lines":[{"line_number":1649,"context_line":"                for file_content_dict in file_content_dict_list:"},{"line_number":1650,"context_line":"                    vnf_resource \u003d self._create_vnf_resource("},{"line_number":1651,"context_line":"                        context, vnf_instance, file_content_dict,"},{"line_number":1652,"context_line":"                        chk_namespaces)"},{"line_number":1653,"context_line":"                    vnf_resources_temp.append(vnf_resource)"},{"line_number":1654,"context_line":"                vnf_resources[target_k8s_index] \u003d vnf_resources_temp"},{"line_number":1655,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"39db0015_0ae5a27c","line":1652,"in_reply_to":"769e130c_043f15c0","updated":"2022-02-10 06:07:34.000000000","message":"I removed ``chk_namespaces``.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"06876675945de52dc7d419a9f71cc80f759c6401","unresolved":true,"context_lines":[{"line_number":1716,"context_line":"                    mf_content_dicts \u003d list(yaml.safe_load_all(mf_content))"},{"line_number":1717,"context_line":"                    for mf_content_dict in mf_content_dicts:"},{"line_number":1718,"context_line":"                        vnf_resource \u003d self._create_vnf_resource("},{"line_number":1719,"context_line":"                            context, vnf_instance, mf_content_dict, [])"},{"line_number":1720,"context_line":"                        vnf_resources.append(vnf_resource)"},{"line_number":1721,"context_line":"            helmclient.close_session()"},{"line_number":1722,"context_line":"        # save the vnf resources in the db"}],"source_content_type":"text/x-python","patch_set":5,"id":"66e5b81c_5ec2f390","line":1719,"range":{"start_line":1719,"start_character":67,"end_line":1719,"end_character":70},"updated":"2022-02-07 23:57:49.000000000","message":"if you agree with the comment at l.1563, please remove ``chk_namespaces`` (i.e., []) from the arguments","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0f0b4d0ba13629c817c43644645d6600ff140c2d","unresolved":false,"context_lines":[{"line_number":1716,"context_line":"                    mf_content_dicts \u003d list(yaml.safe_load_all(mf_content))"},{"line_number":1717,"context_line":"                    for mf_content_dict in mf_content_dicts:"},{"line_number":1718,"context_line":"                        vnf_resource \u003d self._create_vnf_resource("},{"line_number":1719,"context_line":"                            context, vnf_instance, mf_content_dict, [])"},{"line_number":1720,"context_line":"                        vnf_resources.append(vnf_resource)"},{"line_number":1721,"context_line":"            helmclient.close_session()"},{"line_number":1722,"context_line":"        # save the vnf resources in the db"}],"source_content_type":"text/x-python","patch_set":5,"id":"feec0d6b_c99ddd77","line":1719,"range":{"start_line":1719,"start_character":67,"end_line":1719,"end_character":70},"in_reply_to":"1665ea98_be2c4ea1","updated":"2022-02-10 12:09:04.000000000","message":"Ack","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0ef9daeae756fc0bfe1b7b255bd49457eaefff13","unresolved":true,"context_lines":[{"line_number":1716,"context_line":"                    mf_content_dicts \u003d list(yaml.safe_load_all(mf_content))"},{"line_number":1717,"context_line":"                    for mf_content_dict in mf_content_dicts:"},{"line_number":1718,"context_line":"                        vnf_resource \u003d self._create_vnf_resource("},{"line_number":1719,"context_line":"                            context, vnf_instance, mf_content_dict, [])"},{"line_number":1720,"context_line":"                        vnf_resources.append(vnf_resource)"},{"line_number":1721,"context_line":"            helmclient.close_session()"},{"line_number":1722,"context_line":"        # save the vnf resources in the db"}],"source_content_type":"text/x-python","patch_set":5,"id":"1665ea98_be2c4ea1","line":1719,"range":{"start_line":1719,"start_character":67,"end_line":1719,"end_character":70},"in_reply_to":"66e5b81c_5ec2f390","updated":"2022-02-10 06:07:34.000000000","message":"I removed ``[]``.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"ad2a2e854b848643804349fee2996e46a5e979ad","unresolved":true,"context_lines":[{"line_number":2364,"context_line":"            for vnf_resource in vnf_resources:"},{"line_number":2365,"context_line":"                # For CNF operations, Kubernetes resource information is"},{"line_number":2366,"context_line":"                # stored in vnfc_resource as follows:"},{"line_number":2367,"context_line":"                #   - resource_name : \"namespace,name\""},{"line_number":2368,"context_line":"                #   - resource_type : \"api_version,kind\""},{"line_number":2369,"context_line":"                rsc_name \u003d vnf_resource.resource_name"},{"line_number":2370,"context_line":"                for vdu_id, vdu_def in vdu_defs.items():"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a550013_8c8a2bd2","line":2367,"range":{"start_line":2367,"start_character":39,"end_line":2367,"end_character":48},"updated":"2022-02-15 08:39:28.000000000","message":"I think it is better to remove this description as well because the namespace in vnf_resource.resource_name is deleted.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"960e3207c48645ae863eb8449dcf17b1392005a8","unresolved":true,"context_lines":[{"line_number":2364,"context_line":"            for vnf_resource in vnf_resources:"},{"line_number":2365,"context_line":"                # For CNF operations, Kubernetes resource information is"},{"line_number":2366,"context_line":"                # stored in vnfc_resource as follows:"},{"line_number":2367,"context_line":"                #   - resource_name : \"namespace,name\""},{"line_number":2368,"context_line":"                #   - resource_type : \"api_version,kind\""},{"line_number":2369,"context_line":"                rsc_name \u003d vnf_resource.resource_name"},{"line_number":2370,"context_line":"                for vdu_id, vdu_def in vdu_defs.items():"}],"source_content_type":"text/x-python","patch_set":8,"id":"a1aa0d7d_79a1d6e8","line":2367,"range":{"start_line":2367,"start_character":39,"end_line":2367,"end_character":48},"in_reply_to":"3a550013_8c8a2bd2","updated":"2022-02-16 01:56:22.000000000","message":"I removed ``namespace``.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"6500fd9d30a93519ed90e05e24e22cc14faa9b04","unresolved":false,"context_lines":[{"line_number":2364,"context_line":"            for vnf_resource in vnf_resources:"},{"line_number":2365,"context_line":"                # For CNF operations, Kubernetes resource information is"},{"line_number":2366,"context_line":"                # stored in vnfc_resource as follows:"},{"line_number":2367,"context_line":"                #   - resource_name : \"namespace,name\""},{"line_number":2368,"context_line":"                #   - resource_type : \"api_version,kind\""},{"line_number":2369,"context_line":"                rsc_name \u003d vnf_resource.resource_name"},{"line_number":2370,"context_line":"                for vdu_id, vdu_def in vdu_defs.items():"}],"source_content_type":"text/x-python","patch_set":8,"id":"ec199f1a_6b10a557","line":2367,"range":{"start_line":2367,"start_character":39,"end_line":2367,"end_character":48},"in_reply_to":"a1aa0d7d_79a1d6e8","updated":"2022-02-22 07:55:11.000000000","message":"I have confirmed it.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"}],"tacker/vnfm/infra_drivers/kubernetes/utils.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"06876675945de52dc7d419a9f71cc80f759c6401","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def check_and_save_namespace("},{"line_number":51,"context_line":"        context, instantiate_vnf_req, chk_namespaces, vnf_instance):"},{"line_number":52,"context_line":"    namespace \u003d \u0027\u0027"},{"line_number":53,"context_line":"    if instantiate_vnf_req.additional_params:"},{"line_number":54,"context_line":"        namespace \u003d instantiate_vnf_req.additional_params.get(\u0027namespace\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2f24f47c_c915f864","line":51,"updated":"2022-02-07 23:57:49.000000000","message":"Is ``context`` necessary?\nLooks unused","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0ef9daeae756fc0bfe1b7b255bd49457eaefff13","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def check_and_save_namespace("},{"line_number":51,"context_line":"        context, instantiate_vnf_req, chk_namespaces, vnf_instance):"},{"line_number":52,"context_line":"    namespace \u003d \u0027\u0027"},{"line_number":53,"context_line":"    if instantiate_vnf_req.additional_params:"},{"line_number":54,"context_line":"        namespace \u003d instantiate_vnf_req.additional_params.get(\u0027namespace\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"779d11d0_8f214145","line":51,"in_reply_to":"2f24f47c_c915f864","updated":"2022-02-10 06:07:34.000000000","message":"I fixed this in patch 6.","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0f0b4d0ba13629c817c43644645d6600ff140c2d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def check_and_save_namespace("},{"line_number":51,"context_line":"        context, instantiate_vnf_req, chk_namespaces, vnf_instance):"},{"line_number":52,"context_line":"    namespace \u003d \u0027\u0027"},{"line_number":53,"context_line":"    if instantiate_vnf_req.additional_params:"},{"line_number":54,"context_line":"        namespace \u003d instantiate_vnf_req.additional_params.get(\u0027namespace\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ef7d9dd_8e4dc34d","line":51,"in_reply_to":"779d11d0_8f214145","updated":"2022-02-10 12:09:04.000000000","message":"Ack","commit_id":"d00faf3701bc2a7501b850150ca5b88b74b914c7"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"ad2a2e854b848643804349fee2996e46a5e979ad","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    if len(namespaces) \u003e 1:"},{"line_number":78,"context_line":"        LOG.error(f\u0027Multiple namespaces found： {namespaces}\u0027)"},{"line_number":79,"context_line":"        raise exceptions.NamespaceIsNotUnique()"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    if namespaces:"}],"source_content_type":"text/x-python","patch_set":8,"id":"276b6364_1debb4a7","line":78,"range":{"start_line":78,"start_character":45,"end_line":78,"end_character":46},"updated":"2022-02-15 08:39:28.000000000","message":"\":\" is not a half-width character.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"960e3207c48645ae863eb8449dcf17b1392005a8","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    if len(namespaces) \u003e 1:"},{"line_number":78,"context_line":"        LOG.error(f\u0027Multiple namespaces found： {namespaces}\u0027)"},{"line_number":79,"context_line":"        raise exceptions.NamespaceIsNotUnique()"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    if namespaces:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bd40fdb7_3d7f871a","line":78,"range":{"start_line":78,"start_character":45,"end_line":78,"end_character":46},"in_reply_to":"276b6364_1debb4a7","updated":"2022-02-16 01:56:22.000000000","message":"I changed it to half-width.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"6500fd9d30a93519ed90e05e24e22cc14faa9b04","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    if len(namespaces) \u003e 1:"},{"line_number":78,"context_line":"        LOG.error(f\u0027Multiple namespaces found： {namespaces}\u0027)"},{"line_number":79,"context_line":"        raise exceptions.NamespaceIsNotUnique()"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    if namespaces:"}],"source_content_type":"text/x-python","patch_set":8,"id":"8cb9a95a_6dbfc6b3","line":78,"range":{"start_line":78,"start_character":45,"end_line":78,"end_character":46},"in_reply_to":"bd40fdb7_3d7f871a","updated":"2022-02-22 07:55:11.000000000","message":"I have confirmed it.","commit_id":"4ccfa310b6e195f695e61b1007189daea8aaece0"}]}