)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a3bd835349f8daaa6cba58b2212b598ccd45e287","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayumu Ueha \u003cueha.ayumu@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-25 05:19:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tuning stack_retries of k8s FT in Zuul"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to the performance of the zuul environment, it may take a long time"},{"line_number":10,"context_line":"to remove the kubernetes resource and an error may occur."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"41455d36_6913bf28","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2022-01-26 17:49:29.000000000","message":"Can I confirm the meaning of \"tuning\" because this update looks simply changing timeout values configurable in `.zuul.yaml` and not so different before?","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a23b2df477602658ea013c454fa0f3b8c20538d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayumu Ueha \u003cueha.ayumu@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-25 05:19:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Tuning stack_retries of k8s FT in Zuul"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to the performance of the zuul environment, it may take a long time"},{"line_number":10,"context_line":"to remove the kubernetes resource and an error may occur."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c4fb2efe_3f846297","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"41455d36_6913bf28","updated":"2022-01-27 03:03:32.000000000","message":"The goal of this patch was to gradually increase the value of `stack_retries` so that it would not fail.\nIf you set it too high, the test to transition to `FAILED_TEMP` would take longer, so I had to adjust the nonfailing value to find it.\n\nFrom the results, I just increased it so changed the commit message.","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b8324451a3c7e46ede0f3b076966fd76c8c2ffa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"04761641_ceeb4989","updated":"2022-01-21 08:17:25.000000000","message":"recheck","commit_id":"9e0d7834c27186768f46ab6ee7ddc8af1feaa3c2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f1b438bc6fbee11d7fe8532f3cf2063d756477ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f0ddac5_c0fe6ff7","updated":"2022-01-21 14:50:14.000000000","message":"recheck","commit_id":"9e0d7834c27186768f46ab6ee7ddc8af1feaa3c2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"da60a63a51985de2247cea3f1ef47aaff0f36ac5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"761ea45f_e03a4bcc","updated":"2022-01-21 11:47:07.000000000","message":"recheck","commit_id":"9e0d7834c27186768f46ab6ee7ddc8af1feaa3c2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"63701f5ad93c02e229f3239cac4b5015a5f6aca7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"09f2607c_adfbb593","updated":"2022-01-21 05:38:36.000000000","message":"recheck\n\nCheck several times to see if the tuned values are appropriate.","commit_id":"9e0d7834c27186768f46ab6ee7ddc8af1feaa3c2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4f65fcabcb7fe6eec5112396b818325d6eff99cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"032c447b_6e8d6d05","updated":"2022-01-25 00:25:44.000000000","message":"recheck","commit_id":"c75752bf2e32e52b5f0287ff9442a4127769fa6c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7bdf0ef3bb15b1b736a9b4551acc072bc95a4803","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1830aba3_1a3aba9d","updated":"2022-01-24 21:04:15.000000000","message":"recheck","commit_id":"c75752bf2e32e52b5f0287ff9442a4127769fa6c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"018bd76c6505af56b0da16bd2a0613d4cdea9a78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"774a1abb_e09a4ac0","updated":"2022-01-24 11:33:34.000000000","message":"recheck","commit_id":"c75752bf2e32e52b5f0287ff9442a4127769fa6c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b29cc748ccb49a093b310702a9d3ebafa8c2658d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8088100b_f72fe9c9","updated":"2022-01-24 08:53:36.000000000","message":"recheck","commit_id":"c75752bf2e32e52b5f0287ff9442a4127769fa6c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"dd137965911edb18f431f6cd6d4b0f15ee87cae5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8f3a4296_d79d340e","updated":"2022-01-24 13:46:18.000000000","message":"recheck","commit_id":"c75752bf2e32e52b5f0287ff9442a4127769fa6c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ca426f6425968cbeb51bd81070f4b77174a87261","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"95dbf54e_d733d31d","updated":"2022-01-25 02:46:02.000000000","message":"recheck","commit_id":"c75752bf2e32e52b5f0287ff9442a4127769fa6c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3811634880037db63952c5dec8cc094336625fa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"02c1957b_5016e908","updated":"2022-01-25 07:29:21.000000000","message":"I tuned stack_retries default value 100 to 120, and changed the value of timeout in sol-kubernetes job to value calculated from Tacker config.\nThere seems to be no problem after recheck several times. \n\nPlease kindly review it. Thank you.","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a3bd835349f8daaa6cba58b2212b598ccd45e287","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7a2b6984_67f30b31","updated":"2022-01-26 17:49:29.000000000","message":"Thanks for the fix. I understand the purpose of the change, but still not sure about the change itself a little.","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a23b2df477602658ea013c454fa0f3b8c20538d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e8af8833_8813d05c","updated":"2022-01-27 03:03:32.000000000","message":"Thanks for your comments, please confirm my answers and changes.","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ae1c79746dbaa67646dc8c16fb7884f1ca6f1d3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3fbe34ee_1342905b","updated":"2022-01-26 14:53:56.000000000","message":"recheck","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5a9738efcfa04babfa0b54bb30788ca69596cfad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e4dcd6eb_706bb405","updated":"2022-01-26 08:53:16.000000000","message":"recheck","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"71b8a17d031667fb8e531cd56d7e4d10be781777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0fc8d37a_02774361","updated":"2022-01-26 12:48:17.000000000","message":"recheck\n\nThe last test was zuul-1, but it\u0027s not a failure of the sol-kubernetes job.","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d303a642d84a15333dc788fe458c50c33099d57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"86123818_05bf1be6","updated":"2022-01-26 06:45:31.000000000","message":"recheck\n\nTo increase the number of attempts, I will do additional rechecks until reviewed.","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a9994d0c5a4cafe2b90068de3d4f0c9b12f80175","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fc2f036b_87971c50","in_reply_to":"02c1957b_5016e908","updated":"2022-01-25 07:59:53.000000000","message":"Sorry, It is correct that I changed the value used at the sol-kubernetes job rather than changing the default value.\n\nx: I tuned stack_retries default value 100 to 120\no: I tuned stack_retries value used in sol-kubernetes job from 100 to 120","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a07e4670b2ab417f874e74fcc822eb1674aeb289","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4165bedb_70ee2a64","updated":"2022-01-31 07:09:36.000000000","message":"recheck","commit_id":"3181caa714ec36d777f8a19f2fec4cb3f78c36a2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f6c15eeea830399cbad79e3e3c4a7fe6bb2b6ecf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4f872d2b_80fc12c3","updated":"2022-01-27 06:17:53.000000000","message":"recheck","commit_id":"3181caa714ec36d777f8a19f2fec4cb3f78c36a2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"11b2863918dab3eab9fa07cfc01f555c73d5a3b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b006e1c5_2e562001","updated":"2022-02-15 09:39:47.000000000","message":"As time has passed, I will rebase and check.\n\nSince sol-kubernetes errors have recently become a common occurrence, please kindly review to merge this patch if there is no problem.","commit_id":"4fe3a93e0b503e355ef3e1d742b448bb524a3e69"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"874af3adb5598293a2724fb71db09f49e54a35b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fa2a89b6_98a37ec0","updated":"2022-02-25 09:43:12.000000000","message":"ping\n\nIf you have any comments, I will answer or correct them, so please kindly review this patch.\nI expect that this patch will be merged so that there will be no re-checking due to the sol-kubernetes Job error.","commit_id":"24e207e7729967092c4625a5d440a3d575cd2b32"}],"tacker/tests/functional/sol_kubernetes/vnflcm/base.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a3bd835349f8daaa6cba58b2212b598ccd45e287","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        cls.base_vnf_package_url \u003d \"/vnfpkgm/v1/vnf_packages\""},{"line_number":47,"context_line":"        cls.base_vnf_instances_url \u003d \"/vnflcm/v1/vnf_instances\""},{"line_number":48,"context_line":"        cls.base_vnf_lcm_op_occs_url \u003d \"/vnflcm/v1/vnf_lcm_op_occs\""},{"line_number":49,"context_line":"        # [NOTE] culculate timeout from configuration."},{"line_number":50,"context_line":"        #        Add processing time per retry (1 sec) as a margin."},{"line_number":51,"context_line":"        margin \u003d CONF.kubernetes_vim.stack_retries"},{"line_number":52,"context_line":"        timeout \u003d (CONF.kubernetes_vim.stack_retries *"},{"line_number":53,"context_line":"                   CONF.kubernetes_vim.stack_retry_wait +"}],"source_content_type":"text/x-python","patch_set":8,"id":"b4025bff_6f3836f8","line":50,"range":{"start_line":49,"start_character":10,"end_line":50,"end_character":67},"updated":"2022-01-26 17:49:29.000000000","message":"Please elaborate a little bit more the thinking of the calculation.","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a23b2df477602658ea013c454fa0f3b8c20538d","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        cls.base_vnf_package_url \u003d \"/vnfpkgm/v1/vnf_packages\""},{"line_number":47,"context_line":"        cls.base_vnf_instances_url \u003d \"/vnflcm/v1/vnf_instances\""},{"line_number":48,"context_line":"        cls.base_vnf_lcm_op_occs_url \u003d \"/vnflcm/v1/vnf_lcm_op_occs\""},{"line_number":49,"context_line":"        # [NOTE] culculate timeout from configuration."},{"line_number":50,"context_line":"        #        Add processing time per retry (1 sec) as a margin."},{"line_number":51,"context_line":"        margin \u003d CONF.kubernetes_vim.stack_retries"},{"line_number":52,"context_line":"        timeout \u003d (CONF.kubernetes_vim.stack_retries *"},{"line_number":53,"context_line":"                   CONF.kubernetes_vim.stack_retry_wait +"}],"source_content_type":"text/x-python","patch_set":8,"id":"fc073f75_9456dc75","line":50,"range":{"start_line":49,"start_character":10,"end_line":50,"end_character":67},"in_reply_to":"b4025bff_6f3836f8","updated":"2022-01-27 03:03:32.000000000","message":"In addition to the time spent sleeping on each retry, the actual code executes an API to see if a resource has been created or deleted.\n[e.g. delete_wait retry loop]\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py#L1060-L1092\n\nIn addition to the `stack_retries * stack_retry_wait` time (as total sleep time), the timeout value configured in FT must take this time into account.\n\nI changed the sentence of NOTE.","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a3bd835349f8daaa6cba58b2212b598ccd45e287","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        # [NOTE] culculate timeout from configuration."},{"line_number":50,"context_line":"        #        Add processing time per retry (1 sec) as a margin."},{"line_number":51,"context_line":"        margin \u003d CONF.kubernetes_vim.stack_retries"},{"line_number":52,"context_line":"        timeout \u003d (CONF.kubernetes_vim.stack_retries *"},{"line_number":53,"context_line":"                   CONF.kubernetes_vim.stack_retry_wait +"},{"line_number":54,"context_line":"                   margin)"},{"line_number":55,"context_line":"        cls.lcm_timeout \u003d {"},{"line_number":56,"context_line":"            \"instantiate\": timeout,"},{"line_number":57,"context_line":"            \"terminate\": timeout,"}],"source_content_type":"text/x-python","patch_set":8,"id":"313de6ce_1583eb4a","line":54,"range":{"start_line":52,"start_character":18,"end_line":54,"end_character":26},"updated":"2022-01-26 17:49:29.000000000","message":"It\u0027s same as `margin * (CONF.kubernetes_vim.stack_retry_wait + 1)` and better to be simple although I\u0027m not sure the meaning.","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8a23b2df477602658ea013c454fa0f3b8c20538d","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        # [NOTE] culculate timeout from configuration."},{"line_number":50,"context_line":"        #        Add processing time per retry (1 sec) as a margin."},{"line_number":51,"context_line":"        margin \u003d CONF.kubernetes_vim.stack_retries"},{"line_number":52,"context_line":"        timeout \u003d (CONF.kubernetes_vim.stack_retries *"},{"line_number":53,"context_line":"                   CONF.kubernetes_vim.stack_retry_wait +"},{"line_number":54,"context_line":"                   margin)"},{"line_number":55,"context_line":"        cls.lcm_timeout \u003d {"},{"line_number":56,"context_line":"            \"instantiate\": timeout,"},{"line_number":57,"context_line":"            \"terminate\": timeout,"}],"source_content_type":"text/x-python","patch_set":8,"id":"d1dbf02c_c98691a0","line":54,"range":{"start_line":52,"start_character":18,"end_line":54,"end_character":26},"in_reply_to":"313de6ce_1583eb4a","updated":"2022-01-27 03:03:32.000000000","message":"I thought the variable margin was unnecessary.\nChange to simply add 1 second to `stack_retry_wait`.\n\nHow about this?","commit_id":"2ec515304275503ebee42274445b199b362bf2e6"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"948ad99318a889943f165fc871218c5e3f627b65","unresolved":true,"context_lines":[{"line_number":196,"context_line":"            timeout\u003dNone):"},{"line_number":197,"context_line":"        show_url \u003d os.path.join(self.base_vnf_instances_url, id)"},{"line_number":198,"context_line":"        start_time \u003d int(time.time())"},{"line_number":199,"context_line":"        if not timeout:"},{"line_number":200,"context_line":"            timeout \u003d self.lcm_timeout[\u0027instantiate\u0027]"},{"line_number":201,"context_line":"        while True:"},{"line_number":202,"context_line":"            _, body \u003d self.tacker_client.do_request(show_url, \"GET\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"c0c18167_8d2f3a53","line":199,"updated":"2022-03-02 06:14:59.000000000","message":"Should it be \"if timeout is None\" ?\n\nif timeout\u003d\u003d0, timeout will be set as default. Is it behavior you expect?","commit_id":"24e207e7729967092c4625a5d440a3d575cd2b32"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"ae4201ca0b0cd022226063f379f9edd156e8ee9f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            timeout\u003dNone):"},{"line_number":197,"context_line":"        show_url \u003d os.path.join(self.base_vnf_instances_url, id)"},{"line_number":198,"context_line":"        start_time \u003d int(time.time())"},{"line_number":199,"context_line":"        if not timeout:"},{"line_number":200,"context_line":"            timeout \u003d self.lcm_timeout[\u0027instantiate\u0027]"},{"line_number":201,"context_line":"        while True:"},{"line_number":202,"context_line":"            _, body \u003d self.tacker_client.do_request(show_url, \"GET\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"fe93f2d8_a352adbf","line":199,"in_reply_to":"7be3b734_d75a27c3","updated":"2022-03-02 17:46:31.000000000","message":"Thanks!","commit_id":"24e207e7729967092c4625a5d440a3d575cd2b32"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"125cd5375891eebc1f66380bd0358c8e41c0d33c","unresolved":true,"context_lines":[{"line_number":196,"context_line":"            timeout\u003dNone):"},{"line_number":197,"context_line":"        show_url \u003d os.path.join(self.base_vnf_instances_url, id)"},{"line_number":198,"context_line":"        start_time \u003d int(time.time())"},{"line_number":199,"context_line":"        if not timeout:"},{"line_number":200,"context_line":"            timeout \u003d self.lcm_timeout[\u0027instantiate\u0027]"},{"line_number":201,"context_line":"        while True:"},{"line_number":202,"context_line":"            _, body \u003d self.tacker_client.do_request(show_url, \"GET\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"7be3b734_d75a27c3","line":199,"in_reply_to":"c0c18167_8d2f3a53","updated":"2022-03-02 06:40:57.000000000","message":"Thanks for your suggestion!\nCurrently, there is no plan to be called with timeout\u003d0, but I think you are right.\nI corrected it in PS12.","commit_id":"24e207e7729967092c4625a5d440a3d575cd2b32"}]}