)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"26f8153a53196dcb50c174cde3fbce8d70b3cb9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8b5abdb3_426bc33c","updated":"2022-02-08 11:27:38.000000000","message":"Thank you for your patch. I have a few comments, could you please confirm them?","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"396d1545abbf0118635c82536afdd9a4e57cfa78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"367b3b74_56459f22","updated":"2022-02-08 12:48:51.000000000","message":"Horie san, thanks for your review, please kindly check my fixes.","commit_id":"c80fc4b2656ce043bc9bb396ba41679971375611"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"dcdf2e5c8b90008c0dba200f94a4b04ddacf398c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd1df909_43ea221a","updated":"2022-02-10 05:07:54.000000000","message":"Thank you for your response.","commit_id":"c80fc4b2656ce043bc9bb396ba41679971375611"}],"releasenotes/notes/support-helmchart-scale-with-helmcli-4595b262801b24a7.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a0a41f21c07b618fb359eec94c751a52baef34d0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Change scale operation of CNF that is instantiated with Helm chart to"},{"line_number":5,"context_line":"    perform using Helm cli by specifying replica count parameters for each"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b6e06903_c4582d94","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2022-02-21 10:29:57.000000000","message":"It looks `upgrade` is more appropriate for this changing of scale op.","commit_id":"c80fc4b2656ce043bc9bb396ba41679971375611"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1f6f3511cdebf230ec7149b94aa9ccadb88e8a40","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Change scale operation of CNF that is instantiated with Helm chart to"},{"line_number":5,"context_line":"    perform using Helm cli by specifying replica count parameters for each"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d86956b4_b186e6bc","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"in_reply_to":"b6e06903_c4582d94","updated":"2022-02-21 23:42:25.000000000","message":"Thanks for your suggestion.\nI changed to `upgrade` in PS3.","commit_id":"c80fc4b2656ce043bc9bb396ba41679971375611"}],"tacker/tests/unit/vnfm/infra_drivers/kubernetes/test_kubernetes_driver_helm.py":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"26f8153a53196dcb50c174cde3fbce8d70b3cb9a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"87afcc6a_0305c1e7","line":1,"updated":"2022-02-08 11:27:38.000000000","message":"It looks as if all the source code has been changed.\nThis is probably because the line feed code has been changed from CRLF to LF. So I think it is better to mention in the commit message that the line feed code has been changed.","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7115aac198bb7c6cabdf50e12ae28abf54211ad4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"7490a4af_1eacabee","line":1,"in_reply_to":"4c793913_adece91a","updated":"2022-02-10 06:48:10.000000000","message":"Oops, sorry..\n\u003e By the way, there is no mention of a link for [1], but it is below, right?\n\u003e   * https://review.opendev.org/c/openstack/tacker/+/828291\n\nYes, right.","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"396d1545abbf0118635c82536afdd9a4e57cfa78","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1ef363c_e180f189","line":1,"in_reply_to":"87afcc6a_0305c1e7","updated":"2022-02-08 12:48:51.000000000","message":"Thanks for your pointing it out.\nOther files also had CRLF line breaks. I have posted a patch [1] to replace it with LF along with other files.\nThis patch changes patch [1] to its parent.","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"dcdf2e5c8b90008c0dba200f94a4b04ddacf398c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"4c793913_adece91a","line":1,"in_reply_to":"a1ef363c_e180f189","updated":"2022-02-10 05:07:54.000000000","message":"I understand.\nBy the way, there is no mention of a link for [1], but it is below, right?\n- https://review.opendev.org/c/openstack/tacker/+/828291","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"}],"tacker/vnfm/infra_drivers/kubernetes/helm/helm_client.py":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"26f8153a53196dcb50c174cde3fbce8d70b3cb9a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"6aff8e03_c3dda5d1","line":1,"updated":"2022-02-08 11:27:38.000000000","message":"It looks as if all the source code has been changed.\nThis is probably because the line feed code has been changed from CRLF to LF. So I think it is better to mention in the commit message that the line feed code has been changed.","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"396d1545abbf0118635c82536afdd9a4e57cfa78","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"bcdf61da_5336b60c","line":1,"in_reply_to":"6aff8e03_c3dda5d1","updated":"2022-02-08 12:48:51.000000000","message":"same comment as test_kubernetes_driver_helm.py.","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"dcdf2e5c8b90008c0dba200f94a4b04ddacf398c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"21969b6e_c64e275b","line":1,"in_reply_to":"bcdf61da_5336b60c","updated":"2022-02-10 05:07:54.000000000","message":"ditto","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"26f8153a53196dcb50c174cde3fbce8d70b3cb9a","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        mf_content \u003d \u0027\u0027.join(result)"},{"line_number":151,"context_line":"        return mf_content"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def get_values(self, release_name, namespace):"},{"line_number":154,"context_line":"        # execute helm get values command"},{"line_number":155,"context_line":"        ssh_command \u003d f\"helm get values {release_name} --all --output json\""},{"line_number":156,"context_line":"        if namespace:"}],"source_content_type":"text/x-python","patch_set":1,"id":"81973b9b_e7fa289e","line":153,"updated":"2022-02-08 11:27:38.000000000","message":"This function does not seem to be used for anything other than the \"get_value\" function. Is it assumed that this function will be used by itself in the future?","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"dcdf2e5c8b90008c0dba200f94a4b04ddacf398c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        mf_content \u003d \u0027\u0027.join(result)"},{"line_number":151,"context_line":"        return mf_content"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def get_values(self, release_name, namespace):"},{"line_number":154,"context_line":"        # execute helm get values command"},{"line_number":155,"context_line":"        ssh_command \u003d f\"helm get values {release_name} --all --output json\""},{"line_number":156,"context_line":"        if namespace:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b0e695eb_541c858e","line":153,"in_reply_to":"488f5fc8_1416d5be","updated":"2022-02-10 05:07:54.000000000","message":"I understand. I have confirmed it.","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"396d1545abbf0118635c82536afdd9a4e57cfa78","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        mf_content \u003d \u0027\u0027.join(result)"},{"line_number":151,"context_line":"        return mf_content"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def get_values(self, release_name, namespace):"},{"line_number":154,"context_line":"        # execute helm get values command"},{"line_number":155,"context_line":"        ssh_command \u003d f\"helm get values {release_name} --all --output json\""},{"line_number":156,"context_line":"        if namespace:"}],"source_content_type":"text/x-python","patch_set":1,"id":"488f5fc8_1416d5be","line":153,"in_reply_to":"81973b9b_e7fa289e","updated":"2022-02-08 12:48:51.000000000","message":"I changed this method name to \"_get_values\" because it is currently used only within HelmClient for now.","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"26f8153a53196dcb50c174cde3fbce8d70b3cb9a","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        return values"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_value(self, release_name, namespace, value):"},{"line_number":164,"context_line":"        values \u003d self.get_values(release_name, namespace)"},{"line_number":165,"context_line":"        res \u003d values"},{"line_number":166,"context_line":"        # get specified value (loop for nested value: e.g. \"foo.bar\")"},{"line_number":167,"context_line":"        for val in value.split(VALUE_SPLIT_CHARACTER):"},{"line_number":168,"context_line":"            if isinstance(res, dict):"}],"source_content_type":"text/x-python","patch_set":1,"id":"027679be_01fb64e6","line":165,"range":{"start_line":164,"start_character":0,"end_line":165,"end_character":20},"updated":"2022-02-08 11:27:38.000000000","message":"I don\u0027t think the variable \"values\" is used anywhere in this function, but if so, wouldn\u0027t it be better to assign the return value of the \"get_values\" function directly to the variable \"res\"?","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"396d1545abbf0118635c82536afdd9a4e57cfa78","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        return values"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_value(self, release_name, namespace, value):"},{"line_number":164,"context_line":"        values \u003d self.get_values(release_name, namespace)"},{"line_number":165,"context_line":"        res \u003d values"},{"line_number":166,"context_line":"        # get specified value (loop for nested value: e.g. \"foo.bar\")"},{"line_number":167,"context_line":"        for val in value.split(VALUE_SPLIT_CHARACTER):"},{"line_number":168,"context_line":"            if isinstance(res, dict):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5810799f_30c8a8af","line":165,"range":{"start_line":164,"start_character":0,"end_line":165,"end_character":20},"in_reply_to":"027679be_01fb64e6","updated":"2022-02-08 12:48:51.000000000","message":"Thanks for your suggestion.\nI changed to assign the return value of the \"get_values\" function directly to the variable \"res\" in PS2.","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"dcdf2e5c8b90008c0dba200f94a4b04ddacf398c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        return values"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_value(self, release_name, namespace, value):"},{"line_number":164,"context_line":"        values \u003d self.get_values(release_name, namespace)"},{"line_number":165,"context_line":"        res \u003d values"},{"line_number":166,"context_line":"        # get specified value (loop for nested value: e.g. \"foo.bar\")"},{"line_number":167,"context_line":"        for val in value.split(VALUE_SPLIT_CHARACTER):"},{"line_number":168,"context_line":"            if isinstance(res, dict):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8d2da144_fea79501","line":165,"range":{"start_line":164,"start_character":0,"end_line":165,"end_character":20},"in_reply_to":"5810799f_30c8a8af","updated":"2022-02-10 05:07:54.000000000","message":"I have confirmed it.","commit_id":"1fd935d94b304061586f817e72b43ea2e248fa2e"}]}