)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"a390abee17e2077c1464412e61b1ff8d47aafc1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d11b8a1d_5256631c","updated":"2022-02-08 08:16:31.000000000","message":"Thank you for your work. Would you please check my comments.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fcd1d8c4_104444dd","updated":"2022-02-04 10:16:37.000000000","message":"Thanks for your work. I have some comments, so could you check that?","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"026632b3_efe3acf2","updated":"2022-02-22 07:39:01.000000000","message":"To Hirro Kitamura, Shun Higuchi, Hirofumi Noguchi:\nThank you for your comments. I fixed them in PS4.\nPlease kindly check them again.","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9651dff6b1bf75dfeb1bf0c59326784aa844a1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eb8fbb2c_f798225c","updated":"2022-02-26 13:51:02.000000000","message":"To Hiroo Kitamura, Hirofumi Noguchi:\nThank you for your comments. I fixed them in PS5.\nPlease kindly check them again.","commit_id":"5749546c0f9bed1d11c347066364dcf27514efd0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4439a3910b9e67a2b1366023fe2c6681a2a63e59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"867cd457_1044dd3c","updated":"2022-02-26 13:56:58.000000000","message":"Sorry, I missed a modification, so I uploaded again.","commit_id":"1498c8b7b08a4d4880e9c58749b0e992cbb8b531"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"394005168842a606fcf55a5c1ae1ca5e204fbefc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"56722577_56be7af6","updated":"2022-03-02 04:30:07.000000000","message":"Sorry for the late comment. There is an error message in Tacker log on the Zuul that I would like to comment on.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6ad4d5bb_b82ca895","updated":"2022-03-02 08:37:42.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b9b2e05e2b257b146c5a450a70f8d69a236574a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"df2de27a_2182d73e","updated":"2022-03-03 00:59:46.000000000","message":"To Naoaki Horie:\nThank you for your comment. I fixed it in PS8.\nPlease kindly check it again.","commit_id":"8568dc7ad843ef180785d0c00dbafb36567c8943"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"182a2ac23e777d673f927f1cd4b697aaef841c65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9e9611a9_d4b7e0f0","updated":"2022-03-07 04:27:13.000000000","message":"I have more comments to send but I will do after this patch resolve conflict.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b9a1e159897578a66ce441301e3d8412e8959764","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"656ef3d3_96fef3e2","updated":"2022-03-07 02:14:13.000000000","message":"Sorry for comments again and again, but I send comments whenever I noticed.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e47e28f4_b5e7af37","updated":"2022-03-04 15:08:26.000000000","message":"Thanks for your rework.\nI will set CR+1 until there is no objection with the discussion of other comments.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3d9b8f36_c9febfce","updated":"2022-03-04 09:10:19.000000000","message":"To Ayumu Ueha, Ai Hamano:\nThank you for your comments. I fixed them in PS9.\nPlease kindly check them again.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"49984ade_72f7aa0f","updated":"2022-03-07 06:18:34.000000000","message":"To Itsuro Oda:\nThank you for your comments. I fixed them in PS10.\nPlease kindly check them again.","commit_id":"8ee0d93baafd03d705f8927d74789916b9b8f84b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1cb2ef2611178e0676dcc581e99ee1b6b72d4063","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"65851f88_d6a7f87b","updated":"2022-03-08 04:46:12.000000000","message":"To Ai Hamano, Itsuro Oda:\nThank you for your comments. I fixed them in PS12.\nPlease kindly check them again.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7f3baa45c89f653a72675a45080b9f590cb135f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4e729352_d256448e","updated":"2022-03-09 07:34:53.000000000","message":"To Itsuro Oda:\nThank you for your comments. I fixed them in PS13.\nPlease kindly check them again.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a9c47b79efdc3cb1fd10819a599f10a75c9b8c38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b177a7cb_ea743d49","updated":"2022-03-10 10:18:25.000000000","message":"To Itsuro Oda, Yasufumi Ogawa:\nThank you for your comments. I fixed them in PS15.\nPlease kindly check them again.","commit_id":"cd51aa471a72e6b240ccaea66b8e16f57bcdc19d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"02f7b66c3dba3ca37f1b226a07cf64388d957c0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d6ff8527_201e90ea","updated":"2022-03-11 02:50:36.000000000","message":"To Itsuro Oda, Yasufumi Ogawa:\nThank you for your explanation. I fixed this part in PS17.\nPlease kindly check it again.","commit_id":"38924bed98cac547f2bdeec0ef919752464169da"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"79144d99110607c90f745b39157d1d8e97d0ffa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"37c96601_738578b9","updated":"2022-03-11 06:35:04.000000000","message":"I`m sorry for the late comment, please kindly find my comments.","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"fde2a69e36770f022b398f11bb90b43b5439eae0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"b06231aa_4cf8ec1f","updated":"2022-03-11 07:43:50.000000000","message":"To Naoaki Horie:\nThank you for your comments. I fixed them in PS20.\nPlease kindly check them again.","commit_id":"8e5e297f316eef8d1d933c20723cfe31ec67dfea"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"36b087c5732f4cbaf19f199955e73d647f3af9a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"04e42206_1049b25b","updated":"2022-03-14 00:14:00.000000000","message":"Thank you for the fix. And I am sorry, but I would like to make an additional comment.","commit_id":"2e17968e65c26cd58489ab1489599459acae4024"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ddfd5c04bb15e41c45c8992c0b3f683a6c88c29a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"5e2aac20_d0981896","updated":"2022-03-14 00:34:21.000000000","message":"To Naoaki Horie:\nThank you for your comment. I fixed it in PS22.\nPlease kindly check it again.","commit_id":"2e17968e65c26cd58489ab1489599459acae4024"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"70ca4e71_594c5cf0","updated":"2022-03-16 01:17:28.000000000","message":"To Hiroo Kitamura, Hirofumi Noguchi:\nThank you for your comments, I fixed these comments in PS24.\nPlease kindly check them again.","commit_id":"f96946740a69f886fdb26818a36d93c6d71b6299"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bd855b08feff7a841e9bb15f171b521264af6d29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"4368928c_e34f0e89","updated":"2022-03-17 04:39:13.000000000","message":"To Ai Hamano:\nThank you for your comment, I fixed it in Ps26.\nPlease kindly check it again.","commit_id":"645e94b60289e56d4ed06239af26fc865d9b1e18"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fb85f7151b6bf1f1c97649e7277cf462dc59d2be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"a8df6045_b41ce6cb","updated":"2022-03-17 07:16:17.000000000","message":"LGTM","commit_id":"78dbba65c755b4d63a8a3a5614b7fff6bb5f1b0d"}],"tacker/sol_refactored/api/schemas/vnflcm_v2.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b5cb8c4c544d339f316230526beeb517199a8538","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":78,"context_line":"}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# SOL003 5.5.2.11a"},{"line_number":81,"context_line":"ChangeCurrentVnfPkgRequest_V200 \u003d {"},{"line_number":82,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":83,"context_line":"    \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"097209de_0af42af3","line":80,"updated":"2022-03-03 07:15:38.000000000","message":"Please add the following comment.\n-----\n# SOL002 5.5.2.11a\n-----\n\n[FYI: HealVnfRequest_V200] https://review.opendev.org/c/openstack/tacker/+/827189/15/tacker/sol_refactored/api/schemas/vnflcm_v2.py#96","commit_id":"8568dc7ad843ef180785d0c00dbafb36567c8943"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":78,"context_line":"}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# SOL003 5.5.2.11a"},{"line_number":81,"context_line":"ChangeCurrentVnfPkgRequest_V200 \u003d {"},{"line_number":82,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":83,"context_line":"    \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa2182a5_03756b6c","line":80,"in_reply_to":"097209de_0af42af3","updated":"2022-03-04 09:10:19.000000000","message":"I added this comment in PS9.","commit_id":"8568dc7ad843ef180785d0c00dbafb36567c8943"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d8453e99aa812d3c68496a9803a00e7ea4b24194","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":78,"context_line":"}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# SOL003 5.5.2.11a"},{"line_number":81,"context_line":"ChangeCurrentVnfPkgRequest_V200 \u003d {"},{"line_number":82,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":83,"context_line":"    \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"7b11e4f9_136d03dd","line":80,"in_reply_to":"fa2182a5_03756b6c","updated":"2022-03-07 06:32:56.000000000","message":"Done","commit_id":"8568dc7ad843ef180785d0c00dbafb36567c8943"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b5cb8c4c544d339f316230526beeb517199a8538","unresolved":true,"context_lines":[{"line_number":88,"context_line":"        \u0027extManagedVirtualLinks\u0027: {"},{"line_number":89,"context_line":"            \u0027type\u0027: \u0027array\u0027,"},{"line_number":90,"context_line":"            \u0027items\u0027: common_types.ExtManagedVirtualLinkData},"},{"line_number":91,"context_line":"        \u0027vimConnectionInfo\u0027: {"},{"line_number":92,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":93,"context_line":"            \u0027patternProperties\u0027: {"},{"line_number":94,"context_line":"                \u0027^.*$\u0027: common_types.VimConnectionInfo"}],"source_content_type":"text/x-python","patch_set":8,"id":"7146a88b_d1ae02bf","line":91,"updated":"2022-03-03 07:15:38.000000000","message":"Please add the following comment.\n-----\n# NOTE: \u0027vimConnectionInfo\u0027 field supports only NFV-SOL 003\n-----\n\n[FYI: HealVnfRequest_V200] https://review.opendev.org/c/openstack/tacker/+/827189/15/tacker/sol_refactored/api/schemas/vnflcm_v2.py#103","commit_id":"8568dc7ad843ef180785d0c00dbafb36567c8943"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":88,"context_line":"        \u0027extManagedVirtualLinks\u0027: {"},{"line_number":89,"context_line":"            \u0027type\u0027: \u0027array\u0027,"},{"line_number":90,"context_line":"            \u0027items\u0027: common_types.ExtManagedVirtualLinkData},"},{"line_number":91,"context_line":"        \u0027vimConnectionInfo\u0027: {"},{"line_number":92,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":93,"context_line":"            \u0027patternProperties\u0027: {"},{"line_number":94,"context_line":"                \u0027^.*$\u0027: common_types.VimConnectionInfo"}],"source_content_type":"text/x-python","patch_set":8,"id":"db9cdad2_b6c30b89","line":91,"in_reply_to":"7146a88b_d1ae02bf","updated":"2022-03-04 09:10:19.000000000","message":"I added this comment in PS9.","commit_id":"8568dc7ad843ef180785d0c00dbafb36567c8943"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d8453e99aa812d3c68496a9803a00e7ea4b24194","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        \u0027extManagedVirtualLinks\u0027: {"},{"line_number":89,"context_line":"            \u0027type\u0027: \u0027array\u0027,"},{"line_number":90,"context_line":"            \u0027items\u0027: common_types.ExtManagedVirtualLinkData},"},{"line_number":91,"context_line":"        \u0027vimConnectionInfo\u0027: {"},{"line_number":92,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":93,"context_line":"            \u0027patternProperties\u0027: {"},{"line_number":94,"context_line":"                \u0027^.*$\u0027: common_types.VimConnectionInfo"}],"source_content_type":"text/x-python","patch_set":8,"id":"1fb120c3_86256370","line":91,"in_reply_to":"db9cdad2_b6c30b89","updated":"2022-03-07 06:32:56.000000000","message":"Done","commit_id":"8568dc7ad843ef180785d0c00dbafb36567c8943"}],"tacker/sol_refactored/common/cinder_utils.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"de53650a_aa6e6511","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"f753800f_6a4839aa","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"4b4ad256_04dc8ab4","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"4b4ad256_04dc8ab4","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"de53650a_aa6e6511","updated":"2022-03-04 09:10:19.000000000","message":"I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"}],"tacker/sol_refactored/common/common_script_utils.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":89,"context_line":"            parent \u003d parent[item]"},{"line_number":90,"context_line":"        parent[param[-1]] \u003d None"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # TODO(oda-g): enhance to handle list"},{"line_number":93,"context_line":"    # NOTE: List is not considered here and only \u0027fixed_ips\u0027 is treated as"},{"line_number":94,"context_line":"    # list in userdata_default.py at the moment."},{"line_number":95,"context_line":"    # Note that if handling list is enhanced, userdata_default.py is"}],"source_content_type":"text/x-python","patch_set":3,"id":"b23884b2_704b98e0","line":92,"updated":"2022-02-04 10:16:37.000000000","message":"The name on TODO doesn\u0027t seem to be your name(YiFeng).","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            parent \u003d parent[item]"},{"line_number":90,"context_line":"        parent[param[-1]] \u003d None"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # TODO(oda-g): enhance to handle list"},{"line_number":93,"context_line":"    # NOTE: List is not considered here and only \u0027fixed_ips\u0027 is treated as"},{"line_number":94,"context_line":"    # list in userdata_default.py at the moment."},{"line_number":95,"context_line":"    # Note that if handling list is enhanced, userdata_default.py is"}],"source_content_type":"text/x-python","patch_set":3,"id":"ccfee1ea_b4564f46","line":92,"in_reply_to":"b0f5d0d8_0c48b275","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":89,"context_line":"            parent \u003d parent[item]"},{"line_number":90,"context_line":"        parent[param[-1]] \u003d None"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    # TODO(oda-g): enhance to handle list"},{"line_number":93,"context_line":"    # NOTE: List is not considered here and only \u0027fixed_ips\u0027 is treated as"},{"line_number":94,"context_line":"    # list in userdata_default.py at the moment."},{"line_number":95,"context_line":"    # Note that if handling list is enhanced, userdata_default.py is"}],"source_content_type":"text/x-python","patch_set":3,"id":"b0f5d0d8_0c48b275","line":92,"in_reply_to":"b23884b2_704b98e0","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"c5859cac_23b70efd","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"eac61e3e_1343e181","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"c5859cac_23b70efd","updated":"2022-03-04 09:10:19.000000000","message":"I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"57ac3a7c_6096aee6","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"eac61e3e_1343e181","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d5794af8d6d0d769aa9d64bfd19d0ba530a0b215","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_vdu_info(grant, inst, vnfd):"},{"line_number":26,"context_line":"    volume_name \u003d \u0027\u0027"},{"line_number":27,"context_line":"    volume_size \u003d \u0027\u0027"},{"line_number":28,"context_line":"    flavour_id \u003d inst.get(\u0027instantiatedVnfInfo\u0027).get(\u0027flavourId\u0027)"},{"line_number":29,"context_line":"    vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":30,"context_line":"    storage_nodes \u003d vnfd.get_storage_nodes(flavour_id)"},{"line_number":31,"context_line":"    vdu_info_dict \u003d {}"}],"source_content_type":"text/x-python","patch_set":14,"id":"23a3d7f7_3111e47e","line":28,"range":{"start_line":27,"start_character":20,"end_line":28,"end_character":65},"updated":"2022-03-10 07:23:46.000000000","message":"It can be an AttributeError for accessing None.","commit_id":"cd51aa471a72e6b240ccaea66b8e16f57bcdc19d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"02f7b66c3dba3ca37f1b226a07cf64388d957c0b","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_vdu_info(grant, inst, vnfd):"},{"line_number":26,"context_line":"    volume_name \u003d \u0027\u0027"},{"line_number":27,"context_line":"    volume_size \u003d \u0027\u0027"},{"line_number":28,"context_line":"    flavour_id \u003d inst.get(\u0027instantiatedVnfInfo\u0027).get(\u0027flavourId\u0027)"},{"line_number":29,"context_line":"    vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":30,"context_line":"    storage_nodes \u003d vnfd.get_storage_nodes(flavour_id)"},{"line_number":31,"context_line":"    vdu_info_dict \u003d {}"}],"source_content_type":"text/x-python","patch_set":14,"id":"16a134b9_14cad2c1","line":28,"range":{"start_line":27,"start_character":20,"end_line":28,"end_character":65},"in_reply_to":"147571bb_e968d0e0","updated":"2022-03-11 02:50:36.000000000","message":"I fixed it in PS17","commit_id":"cd51aa471a72e6b240ccaea66b8e16f57bcdc19d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a9c47b79efdc3cb1fd10819a599f10a75c9b8c38","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_vdu_info(grant, inst, vnfd):"},{"line_number":26,"context_line":"    volume_name \u003d \u0027\u0027"},{"line_number":27,"context_line":"    volume_size \u003d \u0027\u0027"},{"line_number":28,"context_line":"    flavour_id \u003d inst.get(\u0027instantiatedVnfInfo\u0027).get(\u0027flavourId\u0027)"},{"line_number":29,"context_line":"    vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":30,"context_line":"    storage_nodes \u003d vnfd.get_storage_nodes(flavour_id)"},{"line_number":31,"context_line":"    vdu_info_dict \u003d {}"}],"source_content_type":"text/x-python","patch_set":14,"id":"5b933e97_c0a2d5de","line":28,"range":{"start_line":27,"start_character":20,"end_line":28,"end_character":65},"in_reply_to":"23a3d7f7_3111e47e","updated":"2022-03-10 10:18:25.000000000","message":"No. In this method, the `inst` is a dict, not a object.\nThis method is called by coordinate_vnf script, when passing inst to coordinate_vnf, it has been converted to a dict.","commit_id":"cd51aa471a72e6b240ccaea66b8e16f57bcdc19d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"3661ae884efbdb924663721085641c11755339e8","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_vdu_info(grant, inst, vnfd):"},{"line_number":26,"context_line":"    volume_name \u003d \u0027\u0027"},{"line_number":27,"context_line":"    volume_size \u003d \u0027\u0027"},{"line_number":28,"context_line":"    flavour_id \u003d inst.get(\u0027instantiatedVnfInfo\u0027).get(\u0027flavourId\u0027)"},{"line_number":29,"context_line":"    vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":30,"context_line":"    storage_nodes \u003d vnfd.get_storage_nodes(flavour_id)"},{"line_number":31,"context_line":"    vdu_info_dict \u003d {}"}],"source_content_type":"text/x-python","patch_set":14,"id":"147571bb_e968d0e0","line":28,"range":{"start_line":27,"start_character":20,"end_line":28,"end_character":65},"in_reply_to":"5b933e97_c0a2d5de","updated":"2022-03-10 22:43:14.000000000","message":"Ogawa-san mean if \u0027instantiatedVnfInfo\u0027 exists certainly, inst[\u0027instantiatedVnfInfo\u0027] is clearer, otherwise inst.get(\u0027instantiatedVnfInfo\u0027, {}) is correct.","commit_id":"cd51aa471a72e6b240ccaea66b8e16f57bcdc19d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d5794af8d6d0d769aa9d64bfd19d0ba530a0b215","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        image \u003d get_param_image(name, flavour_id, vnfd, grant)"},{"line_number":35,"context_line":"        vdu_storage_names \u003d vnfd.get_vdu_storages(node)"},{"line_number":36,"context_line":"        for vdu_storage_name in vdu_storage_names:"},{"line_number":37,"context_line":"            if storage_nodes[vdu_storage_name].get("},{"line_number":38,"context_line":"                    \u0027properties\u0027).get(\u0027sw_image_data\u0027):"},{"line_number":39,"context_line":"                image \u003d get_param_image(vdu_storage_name, flavour_id, vnfd,"},{"line_number":40,"context_line":"                                        grant)"},{"line_number":41,"context_line":"                volume_name \u003d vdu_storage_name"}],"source_content_type":"text/x-python","patch_set":14,"id":"ed30b986_c7b4d69e","line":38,"range":{"start_line":37,"start_character":12,"end_line":38,"end_character":55},"updated":"2022-03-10 07:23:46.000000000","message":"ditto","commit_id":"cd51aa471a72e6b240ccaea66b8e16f57bcdc19d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a9c47b79efdc3cb1fd10819a599f10a75c9b8c38","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        image \u003d get_param_image(name, flavour_id, vnfd, grant)"},{"line_number":35,"context_line":"        vdu_storage_names \u003d vnfd.get_vdu_storages(node)"},{"line_number":36,"context_line":"        for vdu_storage_name in vdu_storage_names:"},{"line_number":37,"context_line":"            if storage_nodes[vdu_storage_name].get("},{"line_number":38,"context_line":"                    \u0027properties\u0027).get(\u0027sw_image_data\u0027):"},{"line_number":39,"context_line":"                image \u003d get_param_image(vdu_storage_name, flavour_id, vnfd,"},{"line_number":40,"context_line":"                                        grant)"},{"line_number":41,"context_line":"                volume_name \u003d vdu_storage_name"}],"source_content_type":"text/x-python","patch_set":14,"id":"cd69e911_532813c8","line":38,"range":{"start_line":37,"start_character":12,"end_line":38,"end_character":55},"in_reply_to":"ed30b986_c7b4d69e","updated":"2022-03-10 10:18:25.000000000","message":"ditto","commit_id":"cd51aa471a72e6b240ccaea66b8e16f57bcdc19d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d5794af8d6d0d769aa9d64bfd19d0ba530a0b215","unresolved":true,"context_lines":[{"line_number":44,"context_line":"                    \u0027virtual_block_storage_data\u0027, \u0027\u0027).get("},{"line_number":45,"context_line":"                    \u0027size_of_storage\u0027, \u0027\u0027"},{"line_number":46,"context_line":"                )"},{"line_number":47,"context_line":"                volume_size \u003d volume_size.rstrip(\u0027 GB\u0027)"},{"line_number":48,"context_line":"                break"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        vdu_info_dict[name] \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"a233704b_3c2b824b","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":55},"updated":"2022-03-10 07:23:46.000000000","message":"It might be vulnerable for a malformatted value. Why don\u0027t you check the retrieved value is a number?","commit_id":"cd51aa471a72e6b240ccaea66b8e16f57bcdc19d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a9c47b79efdc3cb1fd10819a599f10a75c9b8c38","unresolved":true,"context_lines":[{"line_number":44,"context_line":"                    \u0027virtual_block_storage_data\u0027, \u0027\u0027).get("},{"line_number":45,"context_line":"                    \u0027size_of_storage\u0027, \u0027\u0027"},{"line_number":46,"context_line":"                )"},{"line_number":47,"context_line":"                volume_size \u003d volume_size.rstrip(\u0027 GB\u0027)"},{"line_number":48,"context_line":"                break"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        vdu_info_dict[name] \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"dc3c6238_9f811311","line":47,"range":{"start_line":47,"start_character":16,"end_line":47,"end_character":55},"in_reply_to":"a233704b_3c2b824b","updated":"2022-03-10 10:18:25.000000000","message":"I added a check to this value in PS15.","commit_id":"cd51aa471a72e6b240ccaea66b8e16f57bcdc19d"}],"tacker/sol_refactored/common/exceptions.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class NotSupportUpgradeType(SolHttpError404):"},{"line_number":118,"context_line":"    message \u003d _(\"not support upgrade_type\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class VnfInstanceIsInstantiated(SolHttpError409):"}],"source_content_type":"text/x-python","patch_set":3,"id":"14597233_29a6a2e6","line":118,"updated":"2022-02-04 10:16:37.000000000","message":"It\u0027s better to output the specified upgrade_type.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class NotSupportUpgradeType(SolHttpError404):"},{"line_number":118,"context_line":"    message \u003d _(\"not support upgrade_type\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class VnfInstanceIsInstantiated(SolHttpError409):"}],"source_content_type":"text/x-python","patch_set":3,"id":"60fc6250_a6f5a497","line":118,"in_reply_to":"14597233_29a6a2e6","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class NotSupportUpgradeType(SolHttpError404):"},{"line_number":118,"context_line":"    message \u003d _(\"not support upgrade_type\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class VnfInstanceIsInstantiated(SolHttpError409):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fde176b3_057474f5","line":118,"in_reply_to":"60fc6250_a6f5a497","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":258,"context_line":"    message \u003d _(\u0027CoordinateVNF execution failed.\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class VMRunningFailed(SolHttpError422):"},{"line_number":262,"context_line":"    message \u003d _(\"VM is running incorrectly. Reason: \u0027%(error_info)\u0027\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"215594ce_72681158","line":261,"updated":"2022-02-04 10:16:37.000000000","message":"I think \"VmRunningFailed\" is better.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":258,"context_line":"    message \u003d _(\u0027CoordinateVNF execution failed.\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class VMRunningFailed(SolHttpError422):"},{"line_number":262,"context_line":"    message \u003d _(\"VM is running incorrectly. Reason: \u0027%(error_info)\u0027\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ea49bb56_66b8139e","line":261,"in_reply_to":"215594ce_72681158","updated":"2022-02-22 07:39:01.000000000","message":"I changed it to \"VmRunningFailed\" in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    message \u003d _(\u0027CoordinateVNF execution failed.\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"class VMRunningFailed(SolHttpError422):"},{"line_number":262,"context_line":"    message \u003d _(\"VM is running incorrectly. Reason: \u0027%(error_info)\u0027\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"5e46741f_e0868b26","line":261,"in_reply_to":"ea49bb56_66b8139e","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c217d58f5e9809735e172baaf4b38313b6147e2d","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    message \u003d _(\"VnfInstance %(inst_id)s not found.\")"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class NotSupportUpgradeType(SolHttpError404):"},{"line_number":118,"context_line":"    message \u003d _(\"not support upgrade_type %(upgrade_type)s\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a4a5fcb_8ff032fa","line":117,"range":{"start_line":117,"start_character":28,"end_line":117,"end_character":43},"updated":"2022-02-25 02:27:17.000000000","message":"I think \"SolHttpError400\" is better than \"SolHttpError404\".\nBecause it\u0027s not a URI error, it\u0027s a body error.","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9651dff6b1bf75dfeb1bf0c59326784aa844a1d","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    message \u003d _(\"VnfInstance %(inst_id)s not found.\")"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class NotSupportUpgradeType(SolHttpError404):"},{"line_number":118,"context_line":"    message \u003d _(\"not support upgrade_type %(upgrade_type)s\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa2cf0de_a6d6a6d6","line":117,"range":{"start_line":117,"start_character":28,"end_line":117,"end_character":43},"in_reply_to":"9a4a5fcb_8ff032fa","updated":"2022-02-26 13:51:02.000000000","message":"I fixed it in PS5.","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fea414f720138e91b0f120174db675304ab81738","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    message \u003d _(\"VnfInstance %(inst_id)s not found.\")"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class NotSupportUpgradeType(SolHttpError404):"},{"line_number":118,"context_line":"    message \u003d _(\"not support upgrade_type %(upgrade_type)s\")"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"691a1968_fdb1913b","line":117,"range":{"start_line":117,"start_character":28,"end_line":117,"end_character":43},"in_reply_to":"fa2cf0de_a6d6a6d6","updated":"2022-02-28 09:05:30.000000000","message":"Done","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"}],"tacker/sol_refactored/common/vnfd_utils.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":21,"context_line":"import zipfile"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"import yaml"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tacker.sol_refactored.common import exceptions as sol_ex"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fe8b2f52_cef642dd","line":24,"updated":"2022-02-04 10:16:37.000000000","message":"I don\u0027t think this fix is necessary.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import zipfile"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"import yaml"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tacker.sol_refactored.common import exceptions as sol_ex"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"70fd3f08_b898668b","line":24,"in_reply_to":"d8f7618d_50a9a881","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"import zipfile"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"import yaml"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from tacker.sol_refactored.common import exceptions as sol_ex"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d8f7618d_50a9a881","line":24,"in_reply_to":"fe8b2f52_cef642dd","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it because `yaml` module is not a module of the standard library, but a third-party library.\nhttps://docs.python.org/3.8/library/index.html","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"a390abee17e2077c1464412e61b1ff8d47aafc1f","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return res"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_vdu_info(self, grant, inst):"},{"line_number":164,"context_line":"        flavour_id \u003d inst.instantiatedVnfInfo.flavourId"},{"line_number":165,"context_line":"        vdu_nodes \u003d self.get_vdu_nodes(flavour_id)"},{"line_number":166,"context_line":"        storage_nodes \u003d self.get_storage_nodes(flavour_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"33b2e25b_fceb01e0","line":163,"updated":"2022-02-08 08:16:31.000000000","message":"IMO. Vnfd class\u0027s functions should not require grant and vnfInstance as input parameter. I think it is better for software design that Vnfd class only support the process related to reading vnfd not check runtime parameter such as grant and vnfInstance.\nThis comment is related to other comments in this file.\n\nPlease let me know your opinion.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9651dff6b1bf75dfeb1bf0c59326784aa844a1d","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return res"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_vdu_info(self, grant, inst):"},{"line_number":164,"context_line":"        flavour_id \u003d inst.instantiatedVnfInfo.flavourId"},{"line_number":165,"context_line":"        vdu_nodes \u003d self.get_vdu_nodes(flavour_id)"},{"line_number":166,"context_line":"        storage_nodes \u003d self.get_storage_nodes(flavour_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4ecfd57f_f367cec6","line":163,"in_reply_to":"008a0697_286d88a0","updated":"2022-02-26 13:51:02.000000000","message":"I changed these codes in PS5.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return res"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_vdu_info(self, grant, inst):"},{"line_number":164,"context_line":"        flavour_id \u003d inst.instantiatedVnfInfo.flavourId"},{"line_number":165,"context_line":"        vdu_nodes \u003d self.get_vdu_nodes(flavour_id)"},{"line_number":166,"context_line":"        storage_nodes \u003d self.get_storage_nodes(flavour_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"70742f2f_8677b41b","line":163,"in_reply_to":"33b2e25b_fceb01e0","updated":"2022-02-22 07:39:01.000000000","message":"I think you\u0027re right. However, I am not sure which file to put these methods in at present, it seems that they are not very suitable. Do you have any ideas?","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2b54f1acc86e44dca7c9066155b3aa8d670490a3","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return res"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_vdu_info(self, grant, inst):"},{"line_number":164,"context_line":"        flavour_id \u003d inst.instantiatedVnfInfo.flavourId"},{"line_number":165,"context_line":"        vdu_nodes \u003d self.get_vdu_nodes(flavour_id)"},{"line_number":166,"context_line":"        storage_nodes \u003d self.get_storage_nodes(flavour_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"08287935_f1421417","line":163,"in_reply_to":"4ecfd57f_f367cec6","updated":"2022-03-03 04:14:33.000000000","message":"Thank you for fixing it.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"0a9ad5bd4710f8080c598b3f64c4d4b7aed15c01","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return res"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_vdu_info(self, grant, inst):"},{"line_number":164,"context_line":"        flavour_id \u003d inst.instantiatedVnfInfo.flavourId"},{"line_number":165,"context_line":"        vdu_nodes \u003d self.get_vdu_nodes(flavour_id)"},{"line_number":166,"context_line":"        storage_nodes \u003d self.get_storage_nodes(flavour_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"008a0697_286d88a0","line":163,"in_reply_to":"70742f2f_8677b41b","updated":"2022-02-25 02:29:24.000000000","message":"How about moving these functions to openstack.py, which currently calls get_vdu_info.\n\nI think it is better that adding new function (e.g. def _get_vdu_info) to Openstack class, and def change_vnfpkg and def change_vnfpkg_rollback call it.\n\nNew function should be implemented on the basis of current get_vdu_info, and it calls vnfd_utils only to obtain definition such as vdu_nodes.\n\nI would appreciate it if you could consider it.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"a390abee17e2077c1464412e61b1ff8d47aafc1f","unresolved":true,"context_lines":[{"line_number":197,"context_line":"                }"},{"line_number":198,"context_line":"        return vdu_info_dict"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_param_flavor(self, vdu_name, flavour_id, grant):"},{"line_number":201,"context_line":"        # try to get from grant"},{"line_number":202,"context_line":"        if grant.obj_attr_is_set(\u0027vimAssets\u0027):"},{"line_number":203,"context_line":"            assets \u003d grant.vimAssets"},{"line_number":204,"context_line":"            if assets.obj_attr_is_set(\u0027computeResourceFlavours\u0027):"},{"line_number":205,"context_line":"                flavours \u003d assets.computeResourceFlavours"},{"line_number":206,"context_line":"                for flavour in flavours:"},{"line_number":207,"context_line":"                    if flavour.vnfdVirtualComputeDescId \u003d\u003d vdu_name:"},{"line_number":208,"context_line":"                        return flavour.vimFlavourId"},{"line_number":209,"context_line":"        # if specified in VNFD, use it"},{"line_number":210,"context_line":"        # NOTE: if not found. parameter is set to None."},{"line_number":211,"context_line":"        #       may be error when stack create"}],"source_content_type":"text/x-python","patch_set":3,"id":"aee11f27_25c19221","line":208,"range":{"start_line":200,"start_character":1,"end_line":208,"end_character":51},"updated":"2022-02-08 08:16:31.000000000","message":"IMO. Vnfd class should include only functions involved in reading VNFD.\n\nI think #L200 to #L208 should be implemented outside Vnfd class because they are not related to VNFD.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2b54f1acc86e44dca7c9066155b3aa8d670490a3","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                }"},{"line_number":198,"context_line":"        return vdu_info_dict"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_param_flavor(self, vdu_name, flavour_id, grant):"},{"line_number":201,"context_line":"        # try to get from grant"},{"line_number":202,"context_line":"        if grant.obj_attr_is_set(\u0027vimAssets\u0027):"},{"line_number":203,"context_line":"            assets \u003d grant.vimAssets"},{"line_number":204,"context_line":"            if assets.obj_attr_is_set(\u0027computeResourceFlavours\u0027):"},{"line_number":205,"context_line":"                flavours \u003d assets.computeResourceFlavours"},{"line_number":206,"context_line":"                for flavour in flavours:"},{"line_number":207,"context_line":"                    if flavour.vnfdVirtualComputeDescId \u003d\u003d vdu_name:"},{"line_number":208,"context_line":"                        return flavour.vimFlavourId"},{"line_number":209,"context_line":"        # if specified in VNFD, use it"},{"line_number":210,"context_line":"        # NOTE: if not found. parameter is set to None."},{"line_number":211,"context_line":"        #       may be error when stack create"}],"source_content_type":"text/x-python","patch_set":3,"id":"3e2a285b_172d0583","line":208,"range":{"start_line":200,"start_character":1,"end_line":208,"end_character":51},"in_reply_to":"0c239a96_76fac412","updated":"2022-03-03 04:14:33.000000000","message":"ditto.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"0a9ad5bd4710f8080c598b3f64c4d4b7aed15c01","unresolved":true,"context_lines":[{"line_number":197,"context_line":"                }"},{"line_number":198,"context_line":"        return vdu_info_dict"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_param_flavor(self, vdu_name, flavour_id, grant):"},{"line_number":201,"context_line":"        # try to get from grant"},{"line_number":202,"context_line":"        if grant.obj_attr_is_set(\u0027vimAssets\u0027):"},{"line_number":203,"context_line":"            assets \u003d grant.vimAssets"},{"line_number":204,"context_line":"            if assets.obj_attr_is_set(\u0027computeResourceFlavours\u0027):"},{"line_number":205,"context_line":"                flavours \u003d assets.computeResourceFlavours"},{"line_number":206,"context_line":"                for flavour in flavours:"},{"line_number":207,"context_line":"                    if flavour.vnfdVirtualComputeDescId \u003d\u003d vdu_name:"},{"line_number":208,"context_line":"                        return flavour.vimFlavourId"},{"line_number":209,"context_line":"        # if specified in VNFD, use it"},{"line_number":210,"context_line":"        # NOTE: if not found. parameter is set to None."},{"line_number":211,"context_line":"        #       may be error when stack create"}],"source_content_type":"text/x-python","patch_set":3,"id":"ebe3e4f8_e40ff4d7","line":208,"range":{"start_line":200,"start_character":1,"end_line":208,"end_character":51},"in_reply_to":"5cbd26df_a7b3e2a2","updated":"2022-02-25 02:29:24.000000000","message":"ditto.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":197,"context_line":"                }"},{"line_number":198,"context_line":"        return vdu_info_dict"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_param_flavor(self, vdu_name, flavour_id, grant):"},{"line_number":201,"context_line":"        # try to get from grant"},{"line_number":202,"context_line":"        if grant.obj_attr_is_set(\u0027vimAssets\u0027):"},{"line_number":203,"context_line":"            assets \u003d grant.vimAssets"},{"line_number":204,"context_line":"            if assets.obj_attr_is_set(\u0027computeResourceFlavours\u0027):"},{"line_number":205,"context_line":"                flavours \u003d assets.computeResourceFlavours"},{"line_number":206,"context_line":"                for flavour in flavours:"},{"line_number":207,"context_line":"                    if flavour.vnfdVirtualComputeDescId \u003d\u003d vdu_name:"},{"line_number":208,"context_line":"                        return flavour.vimFlavourId"},{"line_number":209,"context_line":"        # if specified in VNFD, use it"},{"line_number":210,"context_line":"        # NOTE: if not found. parameter is set to None."},{"line_number":211,"context_line":"        #       may be error when stack create"}],"source_content_type":"text/x-python","patch_set":3,"id":"5cbd26df_a7b3e2a2","line":208,"range":{"start_line":200,"start_character":1,"end_line":208,"end_character":51},"in_reply_to":"aee11f27_25c19221","updated":"2022-02-22 07:39:01.000000000","message":"I think you\u0027re right. However, I am not sure which file to put these methods in at present, it seems that they are not very suitable. Do you have any ideas?","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9651dff6b1bf75dfeb1bf0c59326784aa844a1d","unresolved":true,"context_lines":[{"line_number":197,"context_line":"                }"},{"line_number":198,"context_line":"        return vdu_info_dict"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_param_flavor(self, vdu_name, flavour_id, grant):"},{"line_number":201,"context_line":"        # try to get from grant"},{"line_number":202,"context_line":"        if grant.obj_attr_is_set(\u0027vimAssets\u0027):"},{"line_number":203,"context_line":"            assets \u003d grant.vimAssets"},{"line_number":204,"context_line":"            if assets.obj_attr_is_set(\u0027computeResourceFlavours\u0027):"},{"line_number":205,"context_line":"                flavours \u003d assets.computeResourceFlavours"},{"line_number":206,"context_line":"                for flavour in flavours:"},{"line_number":207,"context_line":"                    if flavour.vnfdVirtualComputeDescId \u003d\u003d vdu_name:"},{"line_number":208,"context_line":"                        return flavour.vimFlavourId"},{"line_number":209,"context_line":"        # if specified in VNFD, use it"},{"line_number":210,"context_line":"        # NOTE: if not found. parameter is set to None."},{"line_number":211,"context_line":"        #       may be error when stack create"}],"source_content_type":"text/x-python","patch_set":3,"id":"0c239a96_76fac412","line":208,"range":{"start_line":200,"start_character":1,"end_line":208,"end_character":51},"in_reply_to":"ebe3e4f8_e40ff4d7","updated":"2022-02-26 13:51:02.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"a390abee17e2077c1464412e61b1ff8d47aafc1f","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        #       may be error when stack create"},{"line_number":212,"context_line":"        return self.get_compute_flavor(flavour_id, vdu_name)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def get_param_image(self, vdu_name, flavour_id, grant):"},{"line_number":215,"context_line":"        # try to get from grant"},{"line_number":216,"context_line":"        if grant.obj_attr_is_set(\u0027vimAssets\u0027):"},{"line_number":217,"context_line":"            assets \u003d grant.vimAssets"},{"line_number":218,"context_line":"            if assets.obj_attr_is_set(\u0027softwareImages\u0027):"},{"line_number":219,"context_line":"                images \u003d assets.softwareImages"},{"line_number":220,"context_line":"                for image in images:"},{"line_number":221,"context_line":"                    if image.vnfdSoftwareImageId \u003d\u003d vdu_name:"},{"line_number":222,"context_line":"                        return image.vimSoftwareImageId"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        # if specified in VNFD, use it"},{"line_number":225,"context_line":"        # NOTE: if not found. parameter is set to None."}],"source_content_type":"text/x-python","patch_set":3,"id":"a0bd37ba_8f03fb95","line":222,"range":{"start_line":214,"start_character":0,"end_line":222,"end_character":55},"updated":"2022-02-08 08:16:31.000000000","message":"ditto.\nIt is better these are implemented outside Vnfd class.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2b54f1acc86e44dca7c9066155b3aa8d670490a3","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        #       may be error when stack create"},{"line_number":212,"context_line":"        return self.get_compute_flavor(flavour_id, vdu_name)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def get_param_image(self, vdu_name, flavour_id, grant):"},{"line_number":215,"context_line":"        # try to get from grant"},{"line_number":216,"context_line":"        if grant.obj_attr_is_set(\u0027vimAssets\u0027):"},{"line_number":217,"context_line":"            assets \u003d grant.vimAssets"},{"line_number":218,"context_line":"            if assets.obj_attr_is_set(\u0027softwareImages\u0027):"},{"line_number":219,"context_line":"                images \u003d assets.softwareImages"},{"line_number":220,"context_line":"                for image in images:"},{"line_number":221,"context_line":"                    if image.vnfdSoftwareImageId \u003d\u003d vdu_name:"},{"line_number":222,"context_line":"                        return image.vimSoftwareImageId"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        # if specified in VNFD, use it"},{"line_number":225,"context_line":"        # NOTE: if not found. parameter is set to None."}],"source_content_type":"text/x-python","patch_set":3,"id":"4d2b07de_46dbf101","line":222,"range":{"start_line":214,"start_character":0,"end_line":222,"end_character":55},"in_reply_to":"0f024593_9386fcb3","updated":"2022-03-03 04:14:33.000000000","message":"ditto.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"0a9ad5bd4710f8080c598b3f64c4d4b7aed15c01","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        #       may be error when stack create"},{"line_number":212,"context_line":"        return self.get_compute_flavor(flavour_id, vdu_name)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def get_param_image(self, vdu_name, flavour_id, grant):"},{"line_number":215,"context_line":"        # try to get from grant"},{"line_number":216,"context_line":"        if grant.obj_attr_is_set(\u0027vimAssets\u0027):"},{"line_number":217,"context_line":"            assets \u003d grant.vimAssets"},{"line_number":218,"context_line":"            if assets.obj_attr_is_set(\u0027softwareImages\u0027):"},{"line_number":219,"context_line":"                images \u003d assets.softwareImages"},{"line_number":220,"context_line":"                for image in images:"},{"line_number":221,"context_line":"                    if image.vnfdSoftwareImageId \u003d\u003d vdu_name:"},{"line_number":222,"context_line":"                        return image.vimSoftwareImageId"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        # if specified in VNFD, use it"},{"line_number":225,"context_line":"        # NOTE: if not found. parameter is set to None."}],"source_content_type":"text/x-python","patch_set":3,"id":"8d20ae5d_c66d7300","line":222,"range":{"start_line":214,"start_character":0,"end_line":222,"end_character":55},"in_reply_to":"52bb3bf6_a7651d7e","updated":"2022-02-25 02:29:24.000000000","message":"ditto.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9651dff6b1bf75dfeb1bf0c59326784aa844a1d","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        #       may be error when stack create"},{"line_number":212,"context_line":"        return self.get_compute_flavor(flavour_id, vdu_name)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def get_param_image(self, vdu_name, flavour_id, grant):"},{"line_number":215,"context_line":"        # try to get from grant"},{"line_number":216,"context_line":"        if grant.obj_attr_is_set(\u0027vimAssets\u0027):"},{"line_number":217,"context_line":"            assets \u003d grant.vimAssets"},{"line_number":218,"context_line":"            if assets.obj_attr_is_set(\u0027softwareImages\u0027):"},{"line_number":219,"context_line":"                images \u003d assets.softwareImages"},{"line_number":220,"context_line":"                for image in images:"},{"line_number":221,"context_line":"                    if image.vnfdSoftwareImageId \u003d\u003d vdu_name:"},{"line_number":222,"context_line":"                        return image.vimSoftwareImageId"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        # if specified in VNFD, use it"},{"line_number":225,"context_line":"        # NOTE: if not found. parameter is set to None."}],"source_content_type":"text/x-python","patch_set":3,"id":"0f024593_9386fcb3","line":222,"range":{"start_line":214,"start_character":0,"end_line":222,"end_character":55},"in_reply_to":"8d20ae5d_c66d7300","updated":"2022-02-26 13:51:02.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":211,"context_line":"        #       may be error when stack create"},{"line_number":212,"context_line":"        return self.get_compute_flavor(flavour_id, vdu_name)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def get_param_image(self, vdu_name, flavour_id, grant):"},{"line_number":215,"context_line":"        # try to get from grant"},{"line_number":216,"context_line":"        if grant.obj_attr_is_set(\u0027vimAssets\u0027):"},{"line_number":217,"context_line":"            assets \u003d grant.vimAssets"},{"line_number":218,"context_line":"            if assets.obj_attr_is_set(\u0027softwareImages\u0027):"},{"line_number":219,"context_line":"                images \u003d assets.softwareImages"},{"line_number":220,"context_line":"                for image in images:"},{"line_number":221,"context_line":"                    if image.vnfdSoftwareImageId \u003d\u003d vdu_name:"},{"line_number":222,"context_line":"                        return image.vimSoftwareImageId"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        # if specified in VNFD, use it"},{"line_number":225,"context_line":"        # NOTE: if not found. parameter is set to None."}],"source_content_type":"text/x-python","patch_set":3,"id":"52bb3bf6_a7651d7e","line":222,"range":{"start_line":214,"start_character":0,"end_line":222,"end_character":55},"in_reply_to":"a0bd37ba_8f03fb95","updated":"2022-02-22 07:39:01.000000000","message":"I think you\u0027re right. However, I am not sure which file to put these methods in at present, it seems that they are not very suitable. Do you have any ideas?","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"}],"tacker/sol_refactored/conductor/conductor_v2.py":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"a390abee17e2077c1464412e61b1ff8d47aafc1f","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            vnfd \u003d self.nfvo_client.get_vnfd(context, inst.vnfdId)"},{"line_number":212,"context_line":"            if lcmocc.operation \u003d\u003d fields.LcmOperationType.CHANGE_VNFPKG:"},{"line_number":213,"context_line":"                inst_lcmocc \u003d lcmocc_utils.get_inst_lcmocc(context, inst)"},{"line_number":214,"context_line":"                grant_req, grant \u003d self.vnflcm_driver.grant("},{"line_number":215,"context_line":"                    context, inst_lcmocc, inst, vnfd)"},{"line_number":216,"context_line":"            else:"},{"line_number":217,"context_line":"                grant_req, grant \u003d lcmocc_utils.get_grant_req_and_grant("},{"line_number":218,"context_line":"                    context, lcmocc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"74b95b8e_e2f8e797","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":53},"updated":"2022-02-08 08:16:31.000000000","message":"According to \"SOL003 v3.3.1 5.3.11 Flow of rolling back a VNF lifecycle management operation\", rollback operation does not exchange grant.\nIs there a problem with using \"lcmocc_utils.get_grant_req_and_grant\" like other operation?","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"0a9ad5bd4710f8080c598b3f64c4d4b7aed15c01","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            vnfd \u003d self.nfvo_client.get_vnfd(context, inst.vnfdId)"},{"line_number":212,"context_line":"            if lcmocc.operation \u003d\u003d fields.LcmOperationType.CHANGE_VNFPKG:"},{"line_number":213,"context_line":"                inst_lcmocc \u003d lcmocc_utils.get_inst_lcmocc(context, inst)"},{"line_number":214,"context_line":"                grant_req, grant \u003d self.vnflcm_driver.grant("},{"line_number":215,"context_line":"                    context, inst_lcmocc, inst, vnfd)"},{"line_number":216,"context_line":"            else:"},{"line_number":217,"context_line":"                grant_req, grant \u003d lcmocc_utils.get_grant_req_and_grant("},{"line_number":218,"context_line":"                    context, lcmocc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"52d7e6d6_15d074e9","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":53},"in_reply_to":"1dffeffc_c4c6ee07","updated":"2022-02-25 02:29:24.000000000","message":"I understood the reason why it does not use \"lcmocc_utils.get_grant_req_and_grant\". However, I think you can obtain the required information from the VNF instance in the Database because it will not be updated until the operation get completed.\nSince grant request to NFVO in rollback operation violates NFV SOL standard, I think this implementation should be modified.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9651dff6b1bf75dfeb1bf0c59326784aa844a1d","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            vnfd \u003d self.nfvo_client.get_vnfd(context, inst.vnfdId)"},{"line_number":212,"context_line":"            if lcmocc.operation \u003d\u003d fields.LcmOperationType.CHANGE_VNFPKG:"},{"line_number":213,"context_line":"                inst_lcmocc \u003d lcmocc_utils.get_inst_lcmocc(context, inst)"},{"line_number":214,"context_line":"                grant_req, grant \u003d self.vnflcm_driver.grant("},{"line_number":215,"context_line":"                    context, inst_lcmocc, inst, vnfd)"},{"line_number":216,"context_line":"            else:"},{"line_number":217,"context_line":"                grant_req, grant \u003d lcmocc_utils.get_grant_req_and_grant("},{"line_number":218,"context_line":"                    context, lcmocc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"977fe666_7f5c92d4","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":53},"in_reply_to":"52d7e6d6_15d074e9","updated":"2022-02-26 13:51:02.000000000","message":"I think you\u0027re right. We can get the information from vnf instance, so I set grant_req  and grant to init object with nothing information in it.\nSince there are still grant_req and grant deletion processing, so I still retain the original grant_req and grant acquisition processing.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            vnfd \u003d self.nfvo_client.get_vnfd(context, inst.vnfdId)"},{"line_number":212,"context_line":"            if lcmocc.operation \u003d\u003d fields.LcmOperationType.CHANGE_VNFPKG:"},{"line_number":213,"context_line":"                inst_lcmocc \u003d lcmocc_utils.get_inst_lcmocc(context, inst)"},{"line_number":214,"context_line":"                grant_req, grant \u003d self.vnflcm_driver.grant("},{"line_number":215,"context_line":"                    context, inst_lcmocc, inst, vnfd)"},{"line_number":216,"context_line":"            else:"},{"line_number":217,"context_line":"                grant_req, grant \u003d lcmocc_utils.get_grant_req_and_grant("},{"line_number":218,"context_line":"                    context, lcmocc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1dffeffc_c4c6ee07","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":53},"in_reply_to":"74b95b8e_e2f8e797","updated":"2022-02-22 07:39:01.000000000","message":"Since the rollback operation of change_vnfpkg is to reuse vnfd during instantiate, grant and grant_request during instantiate are also required. If the lcmocc_utils.get_grant_req_and_grant method is used to obtain the grant and grant_request of the change_vnfpkg, it is based on the content generated by the new vnfd, and it cannot be guaranteed that it can be rollbacked correctly.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2b54f1acc86e44dca7c9066155b3aa8d670490a3","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            vnfd \u003d self.nfvo_client.get_vnfd(context, inst.vnfdId)"},{"line_number":212,"context_line":"            if lcmocc.operation \u003d\u003d fields.LcmOperationType.CHANGE_VNFPKG:"},{"line_number":213,"context_line":"                inst_lcmocc \u003d lcmocc_utils.get_inst_lcmocc(context, inst)"},{"line_number":214,"context_line":"                grant_req, grant \u003d self.vnflcm_driver.grant("},{"line_number":215,"context_line":"                    context, inst_lcmocc, inst, vnfd)"},{"line_number":216,"context_line":"            else:"},{"line_number":217,"context_line":"                grant_req, grant \u003d lcmocc_utils.get_grant_req_and_grant("},{"line_number":218,"context_line":"                    context, lcmocc)"}],"source_content_type":"text/x-python","patch_set":3,"id":"48382c81_16038a49","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":53},"in_reply_to":"977fe666_7f5c92d4","updated":"2022-03-03 04:14:33.000000000","message":"Thank you for fixing it.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":true,"context_lines":[{"line_number":270,"context_line":"                lcmocc.update(context)"},{"line_number":271,"context_line":"                # NOTE: Basically inst is not changed. But there is a case"},{"line_number":272,"context_line":"                # that VIM resources may be changed while rollback. Only"},{"line_number":273,"context_line":"                # change_ext_conn_rollback at the moment."},{"line_number":274,"context_line":"                if lcmocc.operation in ["},{"line_number":275,"context_line":"                    fields.LcmOperationType.CHANGE_EXT_CONN,"},{"line_number":276,"context_line":"                        fields.LcmOperationType.CHANGE_VNFPKG]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"84a97e5f_08ffde94","line":273,"updated":"2022-03-08 01:30:42.000000000","message":"change this comment line. \"Only change_ext_conn_rollback and change_vnfpkg at the moment.\"","commit_id":"8ee0d93baafd03d705f8927d74789916b9b8f84b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"78686a7a070c537afed114d44b3cf8adf08a0e43","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                lcmocc.update(context)"},{"line_number":271,"context_line":"                # NOTE: Basically inst is not changed. But there is a case"},{"line_number":272,"context_line":"                # that VIM resources may be changed while rollback. Only"},{"line_number":273,"context_line":"                # change_ext_conn_rollback at the moment."},{"line_number":274,"context_line":"                if lcmocc.operation in ["},{"line_number":275,"context_line":"                    fields.LcmOperationType.CHANGE_EXT_CONN,"},{"line_number":276,"context_line":"                        fields.LcmOperationType.CHANGE_VNFPKG]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fcf15eb5_7b694915","line":273,"in_reply_to":"0ef57048_2c70118e","updated":"2022-03-08 23:25:16.000000000","message":"Done","commit_id":"8ee0d93baafd03d705f8927d74789916b9b8f84b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1cb2ef2611178e0676dcc581e99ee1b6b72d4063","unresolved":true,"context_lines":[{"line_number":270,"context_line":"                lcmocc.update(context)"},{"line_number":271,"context_line":"                # NOTE: Basically inst is not changed. But there is a case"},{"line_number":272,"context_line":"                # that VIM resources may be changed while rollback. Only"},{"line_number":273,"context_line":"                # change_ext_conn_rollback at the moment."},{"line_number":274,"context_line":"                if lcmocc.operation in ["},{"line_number":275,"context_line":"                    fields.LcmOperationType.CHANGE_EXT_CONN,"},{"line_number":276,"context_line":"                        fields.LcmOperationType.CHANGE_VNFPKG]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"0ef57048_2c70118e","line":273,"in_reply_to":"84a97e5f_08ffde94","updated":"2022-03-08 04:46:12.000000000","message":"I fixed it in PS12","commit_id":"8ee0d93baafd03d705f8927d74789916b9b8f84b"}],"tacker/sol_refactored/conductor/vnflcm_driver_v2.py":[{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"ccfac071370e7cd7f50088122d9ab6e20f57ea58","unresolved":true,"context_lines":[{"line_number":613,"context_line":"    def change_vnfpkg_grant(self, grant_req, req, inst, vnfd):"},{"line_number":614,"context_line":"        inst_info \u003d inst.instantiatedVnfInfo"},{"line_number":615,"context_line":"        grant_req.flavourId \u003d inst_info.flavourId"},{"line_number":616,"context_line":"        target_vdu_list \u003d ["},{"line_number":617,"context_line":"            vdu_param.get("},{"line_number":618,"context_line":"                \u0027vduId\u0027) for vdu_param in req.additionalParams.get("},{"line_number":619,"context_line":"                \u0027vdu_params\u0027)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7db21d09_69bb287f","line":616,"range":{"start_line":616,"start_character":8,"end_line":616,"end_character":23},"updated":"2022-02-08 01:07:45.000000000","message":"I think \"target_vdu_ids\" is better.\nWhat do you think?","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":613,"context_line":"    def change_vnfpkg_grant(self, grant_req, req, inst, vnfd):"},{"line_number":614,"context_line":"        inst_info \u003d inst.instantiatedVnfInfo"},{"line_number":615,"context_line":"        grant_req.flavourId \u003d inst_info.flavourId"},{"line_number":616,"context_line":"        target_vdu_list \u003d ["},{"line_number":617,"context_line":"            vdu_param.get("},{"line_number":618,"context_line":"                \u0027vduId\u0027) for vdu_param in req.additionalParams.get("},{"line_number":619,"context_line":"                \u0027vdu_params\u0027)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da02eb4c_b9aa33ac","line":616,"range":{"start_line":616,"start_character":8,"end_line":616,"end_character":23},"in_reply_to":"7db21d09_69bb287f","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"760d9c2764bc348962c2589a7fe090c5ba4de327","unresolved":false,"context_lines":[{"line_number":613,"context_line":"    def change_vnfpkg_grant(self, grant_req, req, inst, vnfd):"},{"line_number":614,"context_line":"        inst_info \u003d inst.instantiatedVnfInfo"},{"line_number":615,"context_line":"        grant_req.flavourId \u003d inst_info.flavourId"},{"line_number":616,"context_line":"        target_vdu_list \u003d ["},{"line_number":617,"context_line":"            vdu_param.get("},{"line_number":618,"context_line":"                \u0027vduId\u0027) for vdu_param in req.additionalParams.get("},{"line_number":619,"context_line":"                \u0027vdu_params\u0027)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"336ceb33_714afc78","line":616,"range":{"start_line":616,"start_character":8,"end_line":616,"end_character":23},"in_reply_to":"da02eb4c_b9aa33ac","updated":"2022-02-25 08:55:50.000000000","message":"Done.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":662,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":663,"context_line":"        else:"},{"line_number":664,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":665,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support update type\u0027)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def change_vnfpkg_process("},{"line_number":668,"context_line":"            self, context, lcmocc, inst, grant_req, grant, vnfd):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1e9decae_f74555db","line":665,"updated":"2022-02-04 10:16:37.000000000","message":"I think it\u0027s better to use NotSupportUpgradeType.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":662,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":663,"context_line":"        else:"},{"line_number":664,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":665,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support update type\u0027)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def change_vnfpkg_process("},{"line_number":668,"context_line":"            self, context, lcmocc, inst, grant_req, grant, vnfd):"}],"source_content_type":"text/x-python","patch_set":3,"id":"67f18e06_4d6fd965","line":665,"in_reply_to":"1e9decae_f74555db","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":662,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":663,"context_line":"        else:"},{"line_number":664,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":665,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support update type\u0027)"},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"    def change_vnfpkg_process("},{"line_number":668,"context_line":"            self, context, lcmocc, inst, grant_req, grant, vnfd):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7e6cd1ca_63988881","line":665,"in_reply_to":"67f18e06_4d6fd965","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c217d58f5e9809735e172baaf4b38313b6147e2d","unresolved":true,"context_lines":[{"line_number":742,"context_line":"                            nodes[inst_vnc.vduId])"},{"line_number":743,"context_line":"                        for vdu_storage_name in vdu_storage_names:"},{"line_number":744,"context_line":"                            res_def \u003d objects.ResourceDefinitionV1("},{"line_number":745,"context_line":"                                id\u003df\"{vdu_storage_name}-{vdu_res_id}\","},{"line_number":746,"context_line":"                                type\u003d\u0027STORAGE\u0027,"},{"line_number":747,"context_line":"                                resourceTemplateId\u003dvdu_storage_name)"},{"line_number":748,"context_line":"                            add_reses.append(res_def)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a7220c80_ac088c95","line":745,"range":{"start_line":745,"start_character":35,"end_line":745,"end_character":69},"updated":"2022-02-25 02:27:17.000000000","message":"In this file, character string operations by \"f-strings\" and \".format\" are mixed.\nI think it\u0027s better to modify this to \".format\" or refactor other parts to \"f-strings\".","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fea414f720138e91b0f120174db675304ab81738","unresolved":false,"context_lines":[{"line_number":742,"context_line":"                            nodes[inst_vnc.vduId])"},{"line_number":743,"context_line":"                        for vdu_storage_name in vdu_storage_names:"},{"line_number":744,"context_line":"                            res_def \u003d objects.ResourceDefinitionV1("},{"line_number":745,"context_line":"                                id\u003df\"{vdu_storage_name}-{vdu_res_id}\","},{"line_number":746,"context_line":"                                type\u003d\u0027STORAGE\u0027,"},{"line_number":747,"context_line":"                                resourceTemplateId\u003dvdu_storage_name)"},{"line_number":748,"context_line":"                            add_reses.append(res_def)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2d147fc1_f6dc0fbb","line":745,"range":{"start_line":745,"start_character":35,"end_line":745,"end_character":69},"in_reply_to":"254b8497_1268a3aa","updated":"2022-02-28 09:05:30.000000000","message":"Done","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9651dff6b1bf75dfeb1bf0c59326784aa844a1d","unresolved":true,"context_lines":[{"line_number":742,"context_line":"                            nodes[inst_vnc.vduId])"},{"line_number":743,"context_line":"                        for vdu_storage_name in vdu_storage_names:"},{"line_number":744,"context_line":"                            res_def \u003d objects.ResourceDefinitionV1("},{"line_number":745,"context_line":"                                id\u003df\"{vdu_storage_name}-{vdu_res_id}\","},{"line_number":746,"context_line":"                                type\u003d\u0027STORAGE\u0027,"},{"line_number":747,"context_line":"                                resourceTemplateId\u003dvdu_storage_name)"},{"line_number":748,"context_line":"                            add_reses.append(res_def)"}],"source_content_type":"text/x-python","patch_set":4,"id":"254b8497_1268a3aa","line":745,"range":{"start_line":745,"start_character":35,"end_line":745,"end_character":69},"in_reply_to":"a7220c80_ac088c95","updated":"2022-02-26 13:51:02.000000000","message":"I fixed it in PS5.","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":768,"context_line":"            if remove_resources:"},{"line_number":769,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":770,"context_line":"        else:"},{"line_number":771,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":772,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":773,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"77077720_ac95fd71","line":771,"range":{"start_line":771,"start_character":65,"end_line":771,"end_character":77},"updated":"2022-03-02 08:37:42.000000000","message":"It\u0027s not clear when the \"next\" is, so how about to change it to like \"future release\" or \"Zed release\"?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":768,"context_line":"            if remove_resources:"},{"line_number":769,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":770,"context_line":"        else:"},{"line_number":771,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":772,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":773,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fc20b944_2c91d75d","line":771,"range":{"start_line":771,"start_character":65,"end_line":771,"end_character":77},"in_reply_to":"77077720_ac95fd71","updated":"2022-03-04 09:10:19.000000000","message":"I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":768,"context_line":"            if remove_resources:"},{"line_number":769,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":770,"context_line":"        else:"},{"line_number":771,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":772,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":773,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ce3503e5_9204446d","line":771,"range":{"start_line":771,"start_character":65,"end_line":771,"end_character":77},"in_reply_to":"fc20b944_2c91d75d","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b7474f80c27078dcbc9ffa7472ac35b8dee794d0","unresolved":true,"context_lines":[{"line_number":957,"context_line":"    def change_vnfpkg_grant(self, grant_req, req, inst, vnfd):"},{"line_number":958,"context_line":"        inst_info \u003d inst.instantiatedVnfInfo"},{"line_number":959,"context_line":"        grant_req.flavourId \u003d inst_info.flavourId"},{"line_number":960,"context_line":"        target_vdu_ids \u003d ["},{"line_number":961,"context_line":"            vdu_param.get("},{"line_number":962,"context_line":"                \u0027vduId\u0027) for vdu_param in req.additionalParams.get("},{"line_number":963,"context_line":"                \u0027vdu_params\u0027)]"}],"source_content_type":"text/x-python","patch_set":9,"id":"20c6068c_795cf2bf","line":960,"updated":"2022-03-06 23:39:22.000000000","message":"It is better:\n---\n    target_vdu_ids \u003d [\n        vdu_param.get(\u0027vduId\u0027)\n        for vdu_param in req.additionalParams.get(\u0027vdu_pramas\u0027)\n    ]","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":957,"context_line":"    def change_vnfpkg_grant(self, grant_req, req, inst, vnfd):"},{"line_number":958,"context_line":"        inst_info \u003d inst.instantiatedVnfInfo"},{"line_number":959,"context_line":"        grant_req.flavourId \u003d inst_info.flavourId"},{"line_number":960,"context_line":"        target_vdu_ids \u003d ["},{"line_number":961,"context_line":"            vdu_param.get("},{"line_number":962,"context_line":"                \u0027vduId\u0027) for vdu_param in req.additionalParams.get("},{"line_number":963,"context_line":"                \u0027vdu_params\u0027)]"}],"source_content_type":"text/x-python","patch_set":9,"id":"7d9137c8_3d91cdc3","line":960,"in_reply_to":"20c6068c_795cf2bf","updated":"2022-03-07 06:18:34.000000000","message":"I fixed it in PS10.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":false,"context_lines":[{"line_number":957,"context_line":"    def change_vnfpkg_grant(self, grant_req, req, inst, vnfd):"},{"line_number":958,"context_line":"        inst_info \u003d inst.instantiatedVnfInfo"},{"line_number":959,"context_line":"        grant_req.flavourId \u003d inst_info.flavourId"},{"line_number":960,"context_line":"        target_vdu_ids \u003d ["},{"line_number":961,"context_line":"            vdu_param.get("},{"line_number":962,"context_line":"                \u0027vduId\u0027) for vdu_param in req.additionalParams.get("},{"line_number":963,"context_line":"                \u0027vdu_params\u0027)]"}],"source_content_type":"text/x-python","patch_set":9,"id":"162530e1_00db6da1","line":960,"in_reply_to":"7d9137c8_3d91cdc3","updated":"2022-03-08 01:30:42.000000000","message":"Done","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b9a1e159897578a66ce441301e3d8412e8959764","unresolved":true,"context_lines":[{"line_number":960,"context_line":"        target_vdu_ids \u003d ["},{"line_number":961,"context_line":"            vdu_param.get("},{"line_number":962,"context_line":"                \u0027vduId\u0027) for vdu_param in req.additionalParams.get("},{"line_number":963,"context_line":"                \u0027vdu_params\u0027)]"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"        if req.additionalParams.get(\u0027upgrade_type\u0027) \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":966,"context_line":"            update_reses \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"2a460426_b663eb12","line":963,"updated":"2022-03-07 02:14:13.000000000","message":"get(\u0027vdu_params\u0027) needs default. get(\u0027vdu_params\u0027, []) is correct.\nif \u0027vdu_params\u0027 is mandatory, check it beforehand and use addirionalParams[\u0027vdu_params\u0027].","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":960,"context_line":"        target_vdu_ids \u003d ["},{"line_number":961,"context_line":"            vdu_param.get("},{"line_number":962,"context_line":"                \u0027vduId\u0027) for vdu_param in req.additionalParams.get("},{"line_number":963,"context_line":"                \u0027vdu_params\u0027)]"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"        if req.additionalParams.get(\u0027upgrade_type\u0027) \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":966,"context_line":"            update_reses \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"de66621c_bbd39370","line":963,"in_reply_to":"2a460426_b663eb12","updated":"2022-03-07 06:18:34.000000000","message":"I fixed it in PS10.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":false,"context_lines":[{"line_number":960,"context_line":"        target_vdu_ids \u003d ["},{"line_number":961,"context_line":"            vdu_param.get("},{"line_number":962,"context_line":"                \u0027vduId\u0027) for vdu_param in req.additionalParams.get("},{"line_number":963,"context_line":"                \u0027vdu_params\u0027)]"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"        if req.additionalParams.get(\u0027upgrade_type\u0027) \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":966,"context_line":"            update_reses \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"8b1a81ee_17db295d","line":963,"in_reply_to":"de66621c_bbd39370","updated":"2022-03-08 01:30:42.000000000","message":"Done","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b7474f80c27078dcbc9ffa7472ac35b8dee794d0","unresolved":true,"context_lines":[{"line_number":965,"context_line":"        if req.additionalParams.get(\u0027upgrade_type\u0027) \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":966,"context_line":"            update_reses \u003d []"},{"line_number":967,"context_line":"            add_reses \u003d []"},{"line_number":968,"context_line":"            remove_resources \u003d []"},{"line_number":969,"context_line":"            if inst_info.obj_attr_is_set(\u0027vnfcResourceInfo\u0027):"},{"line_number":970,"context_line":"                for inst_vnc in inst_info.vnfcResourceInfo:"},{"line_number":971,"context_line":"                    if inst_vnc.vduId in target_vdu_ids:"}],"source_content_type":"text/x-python","patch_set":9,"id":"570733f9_5b8531c5","line":968,"updated":"2022-03-06 23:39:22.000000000","message":"why not remove_reses?","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":965,"context_line":"        if req.additionalParams.get(\u0027upgrade_type\u0027) \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":966,"context_line":"            update_reses \u003d []"},{"line_number":967,"context_line":"            add_reses \u003d []"},{"line_number":968,"context_line":"            remove_resources \u003d []"},{"line_number":969,"context_line":"            if inst_info.obj_attr_is_set(\u0027vnfcResourceInfo\u0027):"},{"line_number":970,"context_line":"                for inst_vnc in inst_info.vnfcResourceInfo:"},{"line_number":971,"context_line":"                    if inst_vnc.vduId in target_vdu_ids:"}],"source_content_type":"text/x-python","patch_set":9,"id":"b2aec641_fdb78a01","line":968,"in_reply_to":"570733f9_5b8531c5","updated":"2022-03-07 06:18:34.000000000","message":"I fixed it in PS10.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":false,"context_lines":[{"line_number":965,"context_line":"        if req.additionalParams.get(\u0027upgrade_type\u0027) \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":966,"context_line":"            update_reses \u003d []"},{"line_number":967,"context_line":"            add_reses \u003d []"},{"line_number":968,"context_line":"            remove_resources \u003d []"},{"line_number":969,"context_line":"            if inst_info.obj_attr_is_set(\u0027vnfcResourceInfo\u0027):"},{"line_number":970,"context_line":"                for inst_vnc in inst_info.vnfcResourceInfo:"},{"line_number":971,"context_line":"                    if inst_vnc.vduId in target_vdu_ids:"}],"source_content_type":"text/x-python","patch_set":9,"id":"d50a3041_d523d6cb","line":968,"in_reply_to":"b2aec641_fdb78a01","updated":"2022-03-08 01:30:42.000000000","message":"Done","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b7474f80c27078dcbc9ffa7472ac35b8dee794d0","unresolved":true,"context_lines":[{"line_number":981,"context_line":"                        for vdu_storage_name in vdu_storage_names:"},{"line_number":982,"context_line":"                            res_def \u003d objects.ResourceDefinitionV1("},{"line_number":983,"context_line":"                                id\u003d\"{}-{}\".format("},{"line_number":984,"context_line":"                                    vdu_storage_name, vdu_res_id),"},{"line_number":985,"context_line":"                                type\u003d\u0027STORAGE\u0027,"},{"line_number":986,"context_line":"                                resourceTemplateId\u003dvdu_storage_name)"},{"line_number":987,"context_line":"                            add_reses.append(res_def)"}],"source_content_type":"text/x-python","patch_set":9,"id":"66ae7e34_b8dccee3","line":984,"updated":"2022-03-06 23:39:22.000000000","message":"use _make_combination_id","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":981,"context_line":"                        for vdu_storage_name in vdu_storage_names:"},{"line_number":982,"context_line":"                            res_def \u003d objects.ResourceDefinitionV1("},{"line_number":983,"context_line":"                                id\u003d\"{}-{}\".format("},{"line_number":984,"context_line":"                                    vdu_storage_name, vdu_res_id),"},{"line_number":985,"context_line":"                                type\u003d\u0027STORAGE\u0027,"},{"line_number":986,"context_line":"                                resourceTemplateId\u003dvdu_storage_name)"},{"line_number":987,"context_line":"                            add_reses.append(res_def)"}],"source_content_type":"text/x-python","patch_set":9,"id":"6c249726_42fa5c02","line":984,"in_reply_to":"66ae7e34_b8dccee3","updated":"2022-03-07 06:18:34.000000000","message":"I fixed it in PS10.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":false,"context_lines":[{"line_number":981,"context_line":"                        for vdu_storage_name in vdu_storage_names:"},{"line_number":982,"context_line":"                            res_def \u003d objects.ResourceDefinitionV1("},{"line_number":983,"context_line":"                                id\u003d\"{}-{}\".format("},{"line_number":984,"context_line":"                                    vdu_storage_name, vdu_res_id),"},{"line_number":985,"context_line":"                                type\u003d\u0027STORAGE\u0027,"},{"line_number":986,"context_line":"                                resourceTemplateId\u003dvdu_storage_name)"},{"line_number":987,"context_line":"                            add_reses.append(res_def)"}],"source_content_type":"text/x-python","patch_set":9,"id":"642bf896_75c91597","line":984,"in_reply_to":"6c249726_42fa5c02","updated":"2022-03-08 01:30:42.000000000","message":"Done","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b7474f80c27078dcbc9ffa7472ac35b8dee794d0","unresolved":true,"context_lines":[{"line_number":1007,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":1008,"context_line":"        else:"},{"line_number":1009,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in Zed release."},{"line_number":1010,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":1011,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def change_vnfpkg_process("}],"source_content_type":"text/x-python","patch_set":9,"id":"59d136bc_bf8921e7","line":1010,"updated":"2022-03-06 23:39:22.000000000","message":"It is not necessary since it was checked in controller already.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1cb2ef2611178e0676dcc581e99ee1b6b72d4063","unresolved":true,"context_lines":[{"line_number":1007,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":1008,"context_line":"        else:"},{"line_number":1009,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in Zed release."},{"line_number":1010,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":1011,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def change_vnfpkg_process("}],"source_content_type":"text/x-python","patch_set":9,"id":"d58c26c1_98308609","line":1010,"in_reply_to":"458de775_21e765f2","updated":"2022-03-08 04:46:12.000000000","message":"I fixed it in PS12","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":1007,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":1008,"context_line":"        else:"},{"line_number":1009,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in Zed release."},{"line_number":1010,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":1011,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def change_vnfpkg_process("}],"source_content_type":"text/x-python","patch_set":9,"id":"845336fb_18b814d4","line":1010,"in_reply_to":"59d136bc_bf8921e7","updated":"2022-03-07 06:18:34.000000000","message":"I know the check has been done in the controller. This is just to reserve a place for the update_type of bule-green.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":true,"context_lines":[{"line_number":1007,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":1008,"context_line":"        else:"},{"line_number":1009,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in Zed release."},{"line_number":1010,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":1011,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def change_vnfpkg_process("}],"source_content_type":"text/x-python","patch_set":9,"id":"458de775_21e765f2","line":1010,"in_reply_to":"845336fb_18b814d4","updated":"2022-03-08 01:30:42.000000000","message":"it is better:\n---\n# not reach here at the moment\npass\n---","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"78686a7a070c537afed114d44b3cf8adf08a0e43","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"                grant_req.removeResources \u003d remove_resources"},{"line_number":1008,"context_line":"        else:"},{"line_number":1009,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in Zed release."},{"line_number":1010,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":1011,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def change_vnfpkg_process("}],"source_content_type":"text/x-python","patch_set":9,"id":"2963a931_24f59e2d","line":1010,"in_reply_to":"d58c26c1_98308609","updated":"2022-03-08 23:25:16.000000000","message":"Done","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b7474f80c27078dcbc9ffa7472ac35b8dee794d0","unresolved":true,"context_lines":[{"line_number":1045,"context_line":"        if vim_info.vimType \u003d\u003d \u0027ETSINFV.OPENSTACK_KEYSTONE.V_3\u0027:"},{"line_number":1046,"context_line":"            driver.change_vnfpkg_rollback("},{"line_number":1047,"context_line":"                req, inst, grant_req, grant, vnfd, lcmocc)"},{"line_number":1048,"context_line":"            inst.update(context)"},{"line_number":1049,"context_line":"        else:"},{"line_number":1050,"context_line":"            # only support openstack at the moment"},{"line_number":1051,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"47ff3e6b_ea1288c5","line":1048,"updated":"2022-03-06 23:39:22.000000000","message":"Don\u0027t save here. Do in conductor_v2.py.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"        if vim_info.vimType \u003d\u003d \u0027ETSINFV.OPENSTACK_KEYSTONE.V_3\u0027:"},{"line_number":1046,"context_line":"            driver.change_vnfpkg_rollback("},{"line_number":1047,"context_line":"                req, inst, grant_req, grant, vnfd, lcmocc)"},{"line_number":1048,"context_line":"            inst.update(context)"},{"line_number":1049,"context_line":"        else:"},{"line_number":1050,"context_line":"            # only support openstack at the moment"},{"line_number":1051,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"f9bcb2c6_d7a11c55","line":1048,"in_reply_to":"18755f10_b7a79000","updated":"2022-03-08 01:30:42.000000000","message":"Done","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":1045,"context_line":"        if vim_info.vimType \u003d\u003d \u0027ETSINFV.OPENSTACK_KEYSTONE.V_3\u0027:"},{"line_number":1046,"context_line":"            driver.change_vnfpkg_rollback("},{"line_number":1047,"context_line":"                req, inst, grant_req, grant, vnfd, lcmocc)"},{"line_number":1048,"context_line":"            inst.update(context)"},{"line_number":1049,"context_line":"        else:"},{"line_number":1050,"context_line":"            # only support openstack at the moment"},{"line_number":1051,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"18755f10_b7a79000","line":1048,"in_reply_to":"47ff3e6b_ea1288c5","updated":"2022-03-07 06:18:34.000000000","message":"I fixed it in PS10.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"}],"tacker/sol_refactored/controller/vnflcm_v2.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c217d58f5e9809735e172baaf4b38313b6147e2d","unresolved":true,"context_lines":[{"line_number":336,"context_line":"            context, vnfd_id)"},{"line_number":337,"context_line":"        if pkg_info.operationalState !\u003d \"ENABLED\":"},{"line_number":338,"context_line":"            raise sol_ex.VnfdIdNotEnabled(vnfd_id\u003dvnfd_id)"},{"line_number":339,"context_line":"        if body.get(\u0027additionalParams\u0027, {}).get("},{"line_number":340,"context_line":"                \u0027upgrade_type\u0027, \u0027\u0027) !\u003d \u0027RollingUpdate\u0027:"},{"line_number":341,"context_line":"            raise sol_ex.NotSupportUpgradeType(upgrade_type\u003dbody.get("},{"line_number":342,"context_line":"                \u0027additionalParams\u0027, {}).get(\u0027upgrade_type\u0027, \u0027\u0027))"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        lcmocc \u003d self._new_lcmocc(id, v2fields.LcmOperationType.CHANGE_VNFPKG,"},{"line_number":345,"context_line":"                                  body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b48a64b2_2701946b","line":342,"range":{"start_line":339,"start_character":8,"end_line":342,"end_character":64},"updated":"2022-02-25 02:27:17.000000000","message":"Since the same information is obtained twice, it\u0027s better to define the variables as follows.\n---\nupgrade_type \u003d body.get(\u0027additionalParams\u0027, {}).get(\u0027upgrade_type\u0027, \u0027\u0027)","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fea414f720138e91b0f120174db675304ab81738","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            context, vnfd_id)"},{"line_number":337,"context_line":"        if pkg_info.operationalState !\u003d \"ENABLED\":"},{"line_number":338,"context_line":"            raise sol_ex.VnfdIdNotEnabled(vnfd_id\u003dvnfd_id)"},{"line_number":339,"context_line":"        if body.get(\u0027additionalParams\u0027, {}).get("},{"line_number":340,"context_line":"                \u0027upgrade_type\u0027, \u0027\u0027) !\u003d \u0027RollingUpdate\u0027:"},{"line_number":341,"context_line":"            raise sol_ex.NotSupportUpgradeType(upgrade_type\u003dbody.get("},{"line_number":342,"context_line":"                \u0027additionalParams\u0027, {}).get(\u0027upgrade_type\u0027, \u0027\u0027))"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        lcmocc \u003d self._new_lcmocc(id, v2fields.LcmOperationType.CHANGE_VNFPKG,"},{"line_number":345,"context_line":"                                  body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4a2aae6e_48e409de","line":342,"range":{"start_line":339,"start_character":8,"end_line":342,"end_character":64},"in_reply_to":"3c237e38_b1f89bd4","updated":"2022-02-28 09:05:30.000000000","message":"Done","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9651dff6b1bf75dfeb1bf0c59326784aa844a1d","unresolved":true,"context_lines":[{"line_number":336,"context_line":"            context, vnfd_id)"},{"line_number":337,"context_line":"        if pkg_info.operationalState !\u003d \"ENABLED\":"},{"line_number":338,"context_line":"            raise sol_ex.VnfdIdNotEnabled(vnfd_id\u003dvnfd_id)"},{"line_number":339,"context_line":"        if body.get(\u0027additionalParams\u0027, {}).get("},{"line_number":340,"context_line":"                \u0027upgrade_type\u0027, \u0027\u0027) !\u003d \u0027RollingUpdate\u0027:"},{"line_number":341,"context_line":"            raise sol_ex.NotSupportUpgradeType(upgrade_type\u003dbody.get("},{"line_number":342,"context_line":"                \u0027additionalParams\u0027, {}).get(\u0027upgrade_type\u0027, \u0027\u0027))"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        lcmocc \u003d self._new_lcmocc(id, v2fields.LcmOperationType.CHANGE_VNFPKG,"},{"line_number":345,"context_line":"                                  body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3c237e38_b1f89bd4","line":342,"range":{"start_line":339,"start_character":8,"end_line":342,"end_character":64},"in_reply_to":"b48a64b2_2701946b","updated":"2022-02-26 13:51:02.000000000","message":"I fixed it in PS5.","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b7474f80c27078dcbc9ffa7472ac35b8dee794d0","unresolved":true,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        upgrade_type \u003d body.get(\u0027additionalParams\u0027, {}).get(\u0027upgrade_type\u0027, \u0027\u0027)"},{"line_number":400,"context_line":"        if upgrade_type !\u003d \u0027RollingUpdate\u0027:"},{"line_number":401,"context_line":"            raise sol_ex.NotSupportUpgradeType(upgrade_type\u003dupgrade_type)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        lcmocc \u003d self._new_lcmocc(id, v2fields.LcmOperationType.CHANGE_VNFPKG,"},{"line_number":404,"context_line":"                                  body)"}],"source_content_type":"text/x-python","patch_set":9,"id":"89d181fc_7160cbe0","line":401,"updated":"2022-03-06 23:39:22.000000000","message":"It is strange that NotSupportUpgradeType is raised when additionalParams does not exist.\nAnd it assumes additionalParams must exist (vnflcm_driver_v2.py too). It is better to check explicitly.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"78686a7a070c537afed114d44b3cf8adf08a0e43","unresolved":true,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        upgrade_type \u003d body.get(\u0027additionalParams\u0027, {}).get(\u0027upgrade_type\u0027, \u0027\u0027)"},{"line_number":400,"context_line":"        if upgrade_type !\u003d \u0027RollingUpdate\u0027:"},{"line_number":401,"context_line":"            raise sol_ex.NotSupportUpgradeType(upgrade_type\u003dupgrade_type)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        lcmocc \u003d self._new_lcmocc(id, v2fields.LcmOperationType.CHANGE_VNFPKG,"},{"line_number":404,"context_line":"                                  body)"}],"source_content_type":"text/x-python","patch_set":9,"id":"93bdba7e_af4477d4","line":401,"in_reply_to":"45579d63_40f23554","updated":"2022-03-08 23:25:16.000000000","message":"There are many required attributes in addtitionalParams by the spec. It should be check here so that the conductor processes safely. (ex. not raise dict key error etc.)","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        upgrade_type \u003d body.get(\u0027additionalParams\u0027, {}).get(\u0027upgrade_type\u0027, \u0027\u0027)"},{"line_number":400,"context_line":"        if upgrade_type !\u003d \u0027RollingUpdate\u0027:"},{"line_number":401,"context_line":"            raise sol_ex.NotSupportUpgradeType(upgrade_type\u003dupgrade_type)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        lcmocc \u003d self._new_lcmocc(id, v2fields.LcmOperationType.CHANGE_VNFPKG,"},{"line_number":404,"context_line":"                                  body)"}],"source_content_type":"text/x-python","patch_set":9,"id":"45579d63_40f23554","line":401,"in_reply_to":"89d181fc_7160cbe0","updated":"2022-03-07 06:18:34.000000000","message":"I added additionalParams check in PS10.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7f3baa45c89f653a72675a45080b9f590cb135f9","unresolved":true,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        upgrade_type \u003d body.get(\u0027additionalParams\u0027, {}).get(\u0027upgrade_type\u0027, \u0027\u0027)"},{"line_number":400,"context_line":"        if upgrade_type !\u003d \u0027RollingUpdate\u0027:"},{"line_number":401,"context_line":"            raise sol_ex.NotSupportUpgradeType(upgrade_type\u003dupgrade_type)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        lcmocc \u003d self._new_lcmocc(id, v2fields.LcmOperationType.CHANGE_VNFPKG,"},{"line_number":404,"context_line":"                                  body)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c7009926_46ac14b8","line":401,"in_reply_to":"93bdba7e_af4477d4","updated":"2022-03-09 07:34:53.000000000","message":"I added other check in PS13.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"}],"tacker/sol_refactored/infra_drivers/openstack/heat_utils.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":124,"context_line":"            none_is_done\u003dTrue)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def get_stack_resource(self, stack_name):"},{"line_number":127,"context_line":"        path \u003d f\"stacks/{stack_name}\""},{"line_number":128,"context_line":"        resp, body \u003d self.client.do_request(path, \"GET\","},{"line_number":129,"context_line":"                                            expected_status\u003d[200, 404])"},{"line_number":130,"context_line":"        if resp.status_code \u003d\u003d 404:"}],"source_content_type":"text/x-python","patch_set":3,"id":"37608412_6e40d672","line":127,"updated":"2022-02-04 10:16:37.000000000","message":"If you use f-strings, you would be better to refactor other parts of this file to ensure code consistency.\n(e.g.) get_parameters()","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":124,"context_line":"            none_is_done\u003dTrue)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def get_stack_resource(self, stack_name):"},{"line_number":127,"context_line":"        path \u003d f\"stacks/{stack_name}\""},{"line_number":128,"context_line":"        resp, body \u003d self.client.do_request(path, \"GET\","},{"line_number":129,"context_line":"                                            expected_status\u003d[200, 404])"},{"line_number":130,"context_line":"        if resp.status_code \u003d\u003d 404:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff933273_5874a95a","line":127,"in_reply_to":"37608412_6e40d672","updated":"2022-02-22 07:39:01.000000000","message":"I fixed all of them in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            none_is_done\u003dTrue)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def get_stack_resource(self, stack_name):"},{"line_number":127,"context_line":"        path \u003d f\"stacks/{stack_name}\""},{"line_number":128,"context_line":"        resp, body \u003d self.client.do_request(path, \"GET\","},{"line_number":129,"context_line":"                                            expected_status\u003d[200, 404])"},{"line_number":130,"context_line":"        if resp.status_code \u003d\u003d 404:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed77f7f7_bca2ec65","line":127,"in_reply_to":"ff933273_5874a95a","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":197,"context_line":"    for link in heat_res.get(\u0027links\u0027, []):"},{"line_number":198,"context_line":"        if \u0027nested\u0027 in link[\u0027rel\u0027]:"},{"line_number":199,"context_line":"            items \u003d link[\u0027href\u0027].split(\u0027/\u0027)"},{"line_number":200,"context_line":"            stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":201,"context_line":"        else:"},{"line_number":202,"context_line":"            if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027:"},{"line_number":203,"context_line":"                items \u003d link[\u0027href\u0027].split(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"8285ff23_cf30eee0","line":200,"updated":"2022-03-02 08:37:42.000000000","message":"Don\u0027t you need break or return after this line?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    for link in heat_res.get(\u0027links\u0027, []):"},{"line_number":198,"context_line":"        if \u0027nested\u0027 in link[\u0027rel\u0027]:"},{"line_number":199,"context_line":"            items \u003d link[\u0027href\u0027].split(\u0027/\u0027)"},{"line_number":200,"context_line":"            stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":201,"context_line":"        else:"},{"line_number":202,"context_line":"            if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027:"},{"line_number":203,"context_line":"                items \u003d link[\u0027href\u0027].split(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1788c4f0_e6f890ee","line":200,"in_reply_to":"2e8be61e_b2cc71f9","updated":"2022-03-04 15:08:26.000000000","message":"Ack","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":197,"context_line":"    for link in heat_res.get(\u0027links\u0027, []):"},{"line_number":198,"context_line":"        if \u0027nested\u0027 in link[\u0027rel\u0027]:"},{"line_number":199,"context_line":"            items \u003d link[\u0027href\u0027].split(\u0027/\u0027)"},{"line_number":200,"context_line":"            stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":201,"context_line":"        else:"},{"line_number":202,"context_line":"            if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027:"},{"line_number":203,"context_line":"                items \u003d link[\u0027href\u0027].split(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"2e8be61e_b2cc71f9","line":200,"in_reply_to":"8285ff23_cf30eee0","updated":"2022-03-04 09:10:19.000000000","message":"I added break in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":201,"context_line":"        else:"},{"line_number":202,"context_line":"            if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027:"},{"line_number":203,"context_line":"                items \u003d link[\u0027href\u0027].split(\u0027/\u0027)"},{"line_number":204,"context_line":"                stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":205,"context_line":"    return stack_id"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"26e0c6a1_cf14bedb","line":204,"updated":"2022-03-02 08:37:42.000000000","message":"ditto.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":201,"context_line":"        else:"},{"line_number":202,"context_line":"            if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027:"},{"line_number":203,"context_line":"                items \u003d link[\u0027href\u0027].split(\u0027/\u0027)"},{"line_number":204,"context_line":"                stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":205,"context_line":"    return stack_id"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"2f6409ec_ea4924f7","line":204,"in_reply_to":"26e0c6a1_cf14bedb","updated":"2022-03-04 09:10:19.000000000","message":"This process cannot directly return stack_id. There was a bit of a problem with the writing at the time. This process returns the result of the link when \u0027nested\u0027 exists in link[\u0027rel\u0027]. But since `nested` appears after `stack`, the previous results can be overwritten by traversal. So stack_id is returned after the traversal is over. But such handling is not rigorous, so I modified it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        else:"},{"line_number":202,"context_line":"            if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027:"},{"line_number":203,"context_line":"                items \u003d link[\u0027href\u0027].split(\u0027/\u0027)"},{"line_number":204,"context_line":"                stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":205,"context_line":"    return stack_id"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"2728a93e_1edc8df9","line":204,"in_reply_to":"2f6409ec_ea4924f7","updated":"2022-03-04 15:08:26.000000000","message":"Thank you for your re-consideration and explanation. I understood.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"78686a7a070c537afed114d44b3cf8adf08a0e43","unresolved":true,"context_lines":[{"line_number":140,"context_line":"                                            expected_status\u003d[200, 404])"},{"line_number":141,"context_line":"        if resp.status_code \u003d\u003d 404:"},{"line_number":142,"context_line":"            return resp, None"},{"line_number":143,"context_line":"        return resp, body[\u0027resource\u0027]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def get_resource_list(self, stack_id):"},{"line_number":146,"context_line":"        path \u003d f\"stacks/{stack_id}/resources\""}],"source_content_type":"text/x-python","patch_set":12,"id":"f0b69ca2_cffa106a","line":143,"updated":"2022-03-08 23:25:16.000000000","message":"It seems it is not necessary to return resp. \n---\nif resp.status_code \u003d\u003d 404:\n    return None\nreturn body[\u0027resource\u0027]\n---\nCaller can know whether the resource exists or not by checking return value(None or not).","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"77dd0d72276d303a18e9d8d27e93c078ad701eee","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                                            expected_status\u003d[200, 404])"},{"line_number":141,"context_line":"        if resp.status_code \u003d\u003d 404:"},{"line_number":142,"context_line":"            return resp, None"},{"line_number":143,"context_line":"        return resp, body[\u0027resource\u0027]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def get_resource_list(self, stack_id):"},{"line_number":146,"context_line":"        path \u003d f\"stacks/{stack_id}/resources\""}],"source_content_type":"text/x-python","patch_set":12,"id":"e3c8aa3c_e8d1e2c8","line":143,"in_reply_to":"124a0322_d4d2747c","updated":"2022-03-09 23:51:20.000000000","message":"Done","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7f3baa45c89f653a72675a45080b9f590cb135f9","unresolved":true,"context_lines":[{"line_number":140,"context_line":"                                            expected_status\u003d[200, 404])"},{"line_number":141,"context_line":"        if resp.status_code \u003d\u003d 404:"},{"line_number":142,"context_line":"            return resp, None"},{"line_number":143,"context_line":"        return resp, body[\u0027resource\u0027]"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def get_resource_list(self, stack_id):"},{"line_number":146,"context_line":"        path \u003d f\"stacks/{stack_id}/resources\""}],"source_content_type":"text/x-python","patch_set":12,"id":"124a0322_d4d2747c","line":143,"in_reply_to":"f0b69ca2_cffa106a","updated":"2022-03-09 07:34:53.000000000","message":"I fixed it in PS13.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"78686a7a070c537afed114d44b3cf8adf08a0e43","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027nested\u0027][0]"},{"line_number":212,"context_line":"    else:"},{"line_number":213,"context_line":"        items \u003d [link[\u0027href\u0027].split(\u0027/\u0027) for link in heat_res.get("},{"line_number":214,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027][0]"},{"line_number":215,"context_line":"    stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":216,"context_line":"    return stack_id"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"274048c1_a2414678","line":214,"updated":"2022-03-08 23:25:16.000000000","message":"L209-L214 it is better;\n---\n    key \u003d \u0027nested\u0027 if \u0027nested\u0027 in links_key else \u0027stack\u0027\n    items \u003d [link[\u0027href\u0027].split(\u0027/\u0027)\n             for link in heat_res.get(\u0027links\u0027, [])\n             if link[\u0027rel\u0027] \u003d\u003d key][0]\n---","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"77dd0d72276d303a18e9d8d27e93c078ad701eee","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027nested\u0027][0]"},{"line_number":212,"context_line":"    else:"},{"line_number":213,"context_line":"        items \u003d [link[\u0027href\u0027].split(\u0027/\u0027) for link in heat_res.get("},{"line_number":214,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027][0]"},{"line_number":215,"context_line":"    stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":216,"context_line":"    return stack_id"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ed636261_55653599","line":214,"in_reply_to":"26516e28_435415b1","updated":"2022-03-09 23:51:20.000000000","message":"Done","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7f3baa45c89f653a72675a45080b9f590cb135f9","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027nested\u0027][0]"},{"line_number":212,"context_line":"    else:"},{"line_number":213,"context_line":"        items \u003d [link[\u0027href\u0027].split(\u0027/\u0027) for link in heat_res.get("},{"line_number":214,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027][0]"},{"line_number":215,"context_line":"    stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":216,"context_line":"    return stack_id"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"26516e28_435415b1","line":214,"in_reply_to":"274048c1_a2414678","updated":"2022-03-09 07:34:53.000000000","message":"I fixed it in PS13.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"78686a7a070c537afed114d44b3cf8adf08a0e43","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        items \u003d [link[\u0027href\u0027].split(\u0027/\u0027) for link in heat_res.get("},{"line_number":214,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027][0]"},{"line_number":215,"context_line":"    stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":216,"context_line":"    return stack_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"def get_parent_resource(heat_res, heat_reses):"}],"source_content_type":"text/x-python","patch_set":12,"id":"6c435492_c90cb2ec","line":216,"updated":"2022-03-08 23:25:16.000000000","message":"question:\nwhy add handling \u0027nested\u0027 ?\nIt seems meaning of this method is changed.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7f3baa45c89f653a72675a45080b9f590cb135f9","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        items \u003d [link[\u0027href\u0027].split(\u0027/\u0027) for link in heat_res.get("},{"line_number":214,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027][0]"},{"line_number":215,"context_line":"    stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":216,"context_line":"    return stack_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"def get_parent_resource(heat_res, heat_reses):"}],"source_content_type":"text/x-python","patch_set":12,"id":"8702c885_144347b9","line":216,"in_reply_to":"6c435492_c90cb2ec","updated":"2022-03-09 07:34:53.000000000","message":"When vdu created by \u0027OS::Heat::AutoScalingGroup\u0027, its parent_res is a random name resource created by heat. For example:\nVDU1\u0027s info:\n```\n{\n\t\t\"updated_time\": \"2022-03-03T15:10:48Z\",\n\t\t\"creation_time\": \"2022-03-03T15:10:48Z\",\n\t\t\"logical_resource_id\": \"VDU1\",\n\t\t\"resource_name\": \"VDU1\",\n\t\t\"physical_resource_id\": \"afb49646-52d4-4293-8637-521612ee8632\",\n\t\t\"resource_status\": \"CREATE_COMPLETE\",\n\t\t\"resource_status_reason\": \"state changed\",\n\t\t\"resource_type\": \"OS::Nova::Server\",\n\t\t\"links\": [{\n\t\t\t\"href\": \"http://192.168.2.100/heat-api/v1/b7457dcef9374c2fa72e22c452bb04e9/stacks/vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx-obc7tsr3jxwz-ubv4s3k7ceiv/ca851934-38d2-4b48-aa95-01f6ebae8ebd/resources/VDU1\",\n\t\t\t\"rel\": \"self\"\n\t\t}, {\n\t\t\t\"href\": \"http://192.168.2.100/heat-api/v1/b7457dcef9374c2fa72e22c452bb04e9/stacks/vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx-obc7tsr3jxwz-ubv4s3k7ceiv/ca851934-38d2-4b48-aa95-01f6ebae8ebd\",\n\t\t\t\"rel\": \"stack\"\n\t\t}],\n\t\t\"required_by\": [],\n\t\t\"parent_resource\": \"obc7tsr3jxwz\"\n\t}\n```\nwe can see its parent resource its `obc7tsr3jxwz`.\nit self link is `http://192.168.2.100/heat-api/v1/b7457dcef9374c2fa72e22c452bb04e9/stacks/vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx-obc7tsr3jxwz-ubv4s3k7ceiv/ca851934-38d2-4b48-aa95-01f6ebae8ebd/resources/VDU1`. \n\nIf we want to get its detail information, we should use \u0027{stack_name}/{stack_id}/resources/VDU1.\nSo the {stack_name}/{stack_id} \u003d `vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx-obc7tsr3jxwz-ubv4s3k7ceiv/ca851934-38d2-4b48-aa95-01f6ebae8ebd`\n\nLet we see `obc7tsr3jxwz` resource info.\n {\n\t\t\"updated_time\": \"2022-03-03T15:15:02Z\",\n\t\t\"creation_time\": \"2022-03-03T15:10:46Z\",\n\t\t\"logical_resource_id\": \"obc7tsr3jxwz\",\n\t\t\"resource_name\": \"obc7tsr3jxwz\",\n\t\t\"physical_resource_id\": \"ca851934-38d2-4b48-aa95-01f6ebae8ebd\",\n\t\t\"resource_status\": \"UPDATE_COMPLETE\",\n\t\t\"resource_status_reason\": \"state changed\",\n\t\t\"resource_type\": \"VDU1.yaml\",\n\t\t\"links\": [{\n\t\t\t\"href\": \"http://192.168.2.100/heat-api/v1/b7457dcef9374c2fa72e22c452bb04e9/stacks/vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx/68d2e3f1-f766-42ef-bfea-c6332301aceb/resources/obc7tsr3jxwz\",\n\t\t\t\"rel\": \"self\"\n\t\t}, {\n\t\t\t\"href\": \"http://192.168.2.100/heat-api/v1/b7457dcef9374c2fa72e22c452bb04e9/stacks/vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx/68d2e3f1-f766-42ef-bfea-c6332301aceb\",\n\t\t\t\"rel\": \"stack\"\n\t\t}, {\n\t\t\t\"href\": \"http://192.168.2.100/heat-api/v1/b7457dcef9374c2fa72e22c452bb04e9/stacks/vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx-obc7tsr3jxwz-ubv4s3k7ceiv/ca851934-38d2-4b48-aa95-01f6ebae8ebd\",\n\t\t\t\"rel\": \"nested\"\n\t\t}],\n\t\t\"required_by\": [],\n\t\t\"parent_resource\": \"VDU1_scale_group\"\n\t}\nwe can see its \u0027stack\u0027 link is \"http://192.168.2.100/heat-api/v1/b7457dcef9374c2fa72e22c452bb04e9/stacks/vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx/68d2e3f1-f766-42ef-bfea-c6332301aceb\".\nIf we use stack link, the {stack_name}/{stack_id} is `vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx/68d2e3f1-f766-42ef-bfea-c6332301aceb`.\nIt does not match the VDU1\u0027s parent info.\nAnd the \u0027nested\u0027 link is \"http://192.168.2.100/heat-api/v1/b7457dcef9374c2fa72e22c452bb04e9/stacks/vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx-obc7tsr3jxwz-ubv4s3k7ceiv/ca851934-38d2-4b48-aa95-01f6ebae8ebd\".\nthe {stack_name}/{stack_id} is `vnf-80965b8e-ad41-43aa-b84e-2cb3c888c5f1-VDU1_scale_group-3n6jk6icudcx-obc7tsr3jxwz-ubv4s3k7ceiv/ca851934-38d2-4b48-aa95-01f6ebae8ebd`.\nIt match the VDU1\u0027s parent info.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"3661ae884efbdb924663721085641c11755339e8","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        items \u003d [link[\u0027href\u0027].split(\u0027/\u0027) for link in heat_res.get("},{"line_number":214,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027][0]"},{"line_number":215,"context_line":"    stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":216,"context_line":"    return stack_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"def get_parent_resource(heat_res, heat_reses):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9074b8c1_263434fa","line":216,"in_reply_to":"843df46c_a3775d12","updated":"2022-03-10 22:43:14.000000000","message":"I see.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"77dd0d72276d303a18e9d8d27e93c078ad701eee","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        items \u003d [link[\u0027href\u0027].split(\u0027/\u0027) for link in heat_res.get("},{"line_number":214,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027][0]"},{"line_number":215,"context_line":"    stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":216,"context_line":"    return stack_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"def get_parent_resource(heat_res, heat_reses):"}],"source_content_type":"text/x-python","patch_set":12,"id":"d330a524_683b19ed","line":216,"in_reply_to":"8702c885_144347b9","updated":"2022-03-09 23:51:20.000000000","message":"originaly stack_id get by get_resource_stack_id is used for the target to mark_unhealthy when heal. Please check your change not affect this.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a9c47b79efdc3cb1fd10819a599f10a75c9b8c38","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        items \u003d [link[\u0027href\u0027].split(\u0027/\u0027) for link in heat_res.get("},{"line_number":214,"context_line":"            \u0027links\u0027, []) if link[\u0027rel\u0027] \u003d\u003d \u0027stack\u0027][0]"},{"line_number":215,"context_line":"    stack_id \u003d f\"{items[-2]}/{items[-1]}\""},{"line_number":216,"context_line":"    return stack_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"def get_parent_resource(heat_res, heat_reses):"}],"source_content_type":"text/x-python","patch_set":12,"id":"843df46c_a3775d12","line":216,"in_reply_to":"d330a524_683b19ed","updated":"2022-03-10 10:18:25.000000000","message":"You\u0027re right. The parent_stack_id doesn\u0027t match my operation, so I added a method to handling my code. and reverted the method back in PS15","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"}],"tacker/sol_refactored/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":20,"context_line":"import pickle"},{"line_number":21,"context_line":"import subprocess"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from dateutil import parser"},{"line_number":24,"context_line":"import eventlet"},{"line_number":25,"context_line":"from oslo_log import log as logging"},{"line_number":26,"context_line":"from oslo_utils import uuidutils"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fac8cf27_4b5b8246","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":15},"updated":"2022-02-04 10:16:37.000000000","message":"These imports should be moved up to the above import block.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import pickle"},{"line_number":21,"context_line":"import subprocess"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from dateutil import parser"},{"line_number":24,"context_line":"import eventlet"},{"line_number":25,"context_line":"from oslo_log import log as logging"},{"line_number":26,"context_line":"from oslo_utils import uuidutils"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1906680a_3be74f79","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":15},"in_reply_to":"69631308_f3a1253f","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":20,"context_line":"import pickle"},{"line_number":21,"context_line":"import subprocess"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from dateutil import parser"},{"line_number":24,"context_line":"import eventlet"},{"line_number":25,"context_line":"from oslo_log import log as logging"},{"line_number":26,"context_line":"from oslo_utils import uuidutils"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"69631308_f3a1253f","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":15},"in_reply_to":"fac8cf27_4b5b8246","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it because `dateutil` and `eventlet` module is not a module of the standard library, but a third-party library.\nhttps://docs.python.org/3.8/library/index.html","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":436,"context_line":"                heat_client, stack_name, operation\u003d\u0027change_vnfpkg_rollback\u0027)"},{"line_number":437,"context_line":"        else:"},{"line_number":438,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":439,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support update type\u0027)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def _make_hot(self, req, inst, grant_req, grant, vnfd):"},{"line_number":442,"context_line":"        if grant_req.operation \u003d\u003d v2fields.LcmOperationType.INSTANTIATE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"f6a9aa89_d238085b","line":439,"updated":"2022-02-04 10:16:37.000000000","message":"I think it\u0027s better to use NotSupportUpgradeType.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                heat_client, stack_name, operation\u003d\u0027change_vnfpkg_rollback\u0027)"},{"line_number":437,"context_line":"        else:"},{"line_number":438,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":439,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support update type\u0027)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def _make_hot(self, req, inst, grant_req, grant, vnfd):"},{"line_number":442,"context_line":"        if grant_req.operation \u003d\u003d v2fields.LcmOperationType.INSTANTIATE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f9618a4_b99b0aff","line":439,"in_reply_to":"d757fe0e_a2d5d509","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":436,"context_line":"                heat_client, stack_name, operation\u003d\u0027change_vnfpkg_rollback\u0027)"},{"line_number":437,"context_line":"        else:"},{"line_number":438,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":439,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support update type\u0027)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def _make_hot(self, req, inst, grant_req, grant, vnfd):"},{"line_number":442,"context_line":"        if grant_req.operation \u003d\u003d v2fields.LcmOperationType.INSTANTIATE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d757fe0e_a2d5d509","line":439,"in_reply_to":"f6a9aa89_d238085b","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"ccfac071370e7cd7f50088122d9ab6e20f57ea58","unresolved":true,"context_lines":[{"line_number":679,"context_line":"                \u0027ip_address\u0027)"},{"line_number":680,"context_line":"        return ssh_ip"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    def _get_target_storage_id(self, volume_name, storage_info,"},{"line_number":683,"context_line":"                               vnfc_storage_ids):"},{"line_number":684,"context_line":"        target_storage_id \u003d \"\""},{"line_number":685,"context_line":"        if storage_info and vnfc_storage_ids:"}],"source_content_type":"text/x-python","patch_set":3,"id":"12875029_6f1e6ce7","line":682,"updated":"2022-02-08 01:07:45.000000000","message":"This looks like an unused method.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":679,"context_line":"                \u0027ip_address\u0027)"},{"line_number":680,"context_line":"        return ssh_ip"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    def _get_target_storage_id(self, volume_name, storage_info,"},{"line_number":683,"context_line":"                               vnfc_storage_ids):"},{"line_number":684,"context_line":"        target_storage_id \u003d \"\""},{"line_number":685,"context_line":"        if storage_info and vnfc_storage_ids:"}],"source_content_type":"text/x-python","patch_set":3,"id":"77139884_36c010b8","line":682,"in_reply_to":"12875029_6f1e6ce7","updated":"2022-02-22 07:39:01.000000000","message":"I deleted it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"760d9c2764bc348962c2589a7fe090c5ba4de327","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                \u0027ip_address\u0027)"},{"line_number":680,"context_line":"        return ssh_ip"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    def _get_target_storage_id(self, volume_name, storage_info,"},{"line_number":683,"context_line":"                               vnfc_storage_ids):"},{"line_number":684,"context_line":"        target_storage_id \u003d \"\""},{"line_number":685,"context_line":"        if storage_info and vnfc_storage_ids:"}],"source_content_type":"text/x-python","patch_set":3,"id":"12354961_8ab4e0f2","line":682,"in_reply_to":"77139884_36c010b8","updated":"2022-02-25 08:55:50.000000000","message":"Done.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"ccfac071370e7cd7f50088122d9ab6e20f57ea58","unresolved":true,"context_lines":[{"line_number":1333,"context_line":"            raise ex"},{"line_number":1334,"context_line":"        raise sol_ex.StackOperationFailed"},{"line_number":1335,"context_line":""},{"line_number":1336,"context_line":"    def _get_entier_stack_fields(self, heat_client, stack_id,"},{"line_number":1337,"context_line":"                                 group_vdu_ids, vdu_infos):"},{"line_number":1338,"context_line":"        parameter \u003d json.loads(heat_client.get_parameters(stack_id)[\u0027nfv\u0027])"},{"line_number":1339,"context_line":"        for group_vdu_id in group_vdu_ids:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ab5a846b_bece4869","line":1336,"range":{"start_line":1336,"start_character":13,"end_line":1336,"end_character":19},"updated":"2022-02-08 01:07:45.000000000","message":"typo: entire","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"760d9c2764bc348962c2589a7fe090c5ba4de327","unresolved":false,"context_lines":[{"line_number":1333,"context_line":"            raise ex"},{"line_number":1334,"context_line":"        raise sol_ex.StackOperationFailed"},{"line_number":1335,"context_line":""},{"line_number":1336,"context_line":"    def _get_entier_stack_fields(self, heat_client, stack_id,"},{"line_number":1337,"context_line":"                                 group_vdu_ids, vdu_infos):"},{"line_number":1338,"context_line":"        parameter \u003d json.loads(heat_client.get_parameters(stack_id)[\u0027nfv\u0027])"},{"line_number":1339,"context_line":"        for group_vdu_id in group_vdu_ids:"}],"source_content_type":"text/x-python","patch_set":3,"id":"2fc36682_52504ad3","line":1336,"range":{"start_line":1336,"start_character":13,"end_line":1336,"end_character":19},"in_reply_to":"8e759db4_6b40cb7c","updated":"2022-02-25 08:55:50.000000000","message":"Done.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":1333,"context_line":"            raise ex"},{"line_number":1334,"context_line":"        raise sol_ex.StackOperationFailed"},{"line_number":1335,"context_line":""},{"line_number":1336,"context_line":"    def _get_entier_stack_fields(self, heat_client, stack_id,"},{"line_number":1337,"context_line":"                                 group_vdu_ids, vdu_infos):"},{"line_number":1338,"context_line":"        parameter \u003d json.loads(heat_client.get_parameters(stack_id)[\u0027nfv\u0027])"},{"line_number":1339,"context_line":"        for group_vdu_id in group_vdu_ids:"}],"source_content_type":"text/x-python","patch_set":3,"id":"8e759db4_6b40cb7c","line":1336,"range":{"start_line":1336,"start_character":13,"end_line":1336,"end_character":19},"in_reply_to":"ab5a846b_bece4869","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6fddd4817d21ad052905c91ab2a0255ee9bcbf95","unresolved":true,"context_lines":[{"line_number":218,"context_line":"                else:"},{"line_number":219,"context_line":"                    vdu_image_id_flag \u003d False"},{"line_number":220,"context_line":"                # handle VM under `OS::Heat::AutoScalingGroup`"},{"line_number":221,"context_line":"                if resp.status_code \u003d\u003d 404:"},{"line_number":222,"context_line":"                    heat_reses \u003d heat_client.get_resources(stack_name)"},{"line_number":223,"context_line":"                    group_stack_id \u003d heat_utils.get_group_stack_id("},{"line_number":224,"context_line":"                        heat_reses, vdu_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a7118dba_fbde88c8","line":221,"range":{"start_line":221,"start_character":39,"end_line":221,"end_character":42},"updated":"2022-02-25 09:23:56.000000000","message":"It seems a little strange to branch with the error response code 404 in normal processing, so I think it\u0027s better to supplement it with comments.","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fea414f720138e91b0f120174db675304ab81738","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                else:"},{"line_number":219,"context_line":"                    vdu_image_id_flag \u003d False"},{"line_number":220,"context_line":"                # handle VM under `OS::Heat::AutoScalingGroup`"},{"line_number":221,"context_line":"                if resp.status_code \u003d\u003d 404:"},{"line_number":222,"context_line":"                    heat_reses \u003d heat_client.get_resources(stack_name)"},{"line_number":223,"context_line":"                    group_stack_id \u003d heat_utils.get_group_stack_id("},{"line_number":224,"context_line":"                        heat_reses, vdu_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"723e776d_6f95a452","line":221,"range":{"start_line":221,"start_character":39,"end_line":221,"end_character":42},"in_reply_to":"2a6efdc9_3d2ac98d","updated":"2022-02-28 09:05:30.000000000","message":"Done","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9651dff6b1bf75dfeb1bf0c59326784aa844a1d","unresolved":true,"context_lines":[{"line_number":218,"context_line":"                else:"},{"line_number":219,"context_line":"                    vdu_image_id_flag \u003d False"},{"line_number":220,"context_line":"                # handle VM under `OS::Heat::AutoScalingGroup`"},{"line_number":221,"context_line":"                if resp.status_code \u003d\u003d 404:"},{"line_number":222,"context_line":"                    heat_reses \u003d heat_client.get_resources(stack_name)"},{"line_number":223,"context_line":"                    group_stack_id \u003d heat_utils.get_group_stack_id("},{"line_number":224,"context_line":"                        heat_reses, vdu_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2a6efdc9_3d2ac98d","line":221,"range":{"start_line":221,"start_character":39,"end_line":221,"end_character":42},"in_reply_to":"a7118dba_fbde88c8","updated":"2022-02-26 13:51:02.000000000","message":"I added comments before this coed in PS5.","commit_id":"64e7c8ba66cb964b25455422517f8ebbf385b32e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":333,"context_line":"                heat_client, stack_name)"},{"line_number":334,"context_line":"            inst.vnfdId \u003d req.vnfdId"},{"line_number":335,"context_line":"        else:"},{"line_number":336,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":337,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":338,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"74cf7387_f17bcf16","line":336,"range":{"start_line":336,"start_character":65,"end_line":336,"end_character":77},"updated":"2022-03-02 08:37:42.000000000","message":"It\u0027s not clear when the \"next\" is, so how about to change it to like \"future release\" or \"Zed release\"?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":333,"context_line":"                heat_client, stack_name)"},{"line_number":334,"context_line":"            inst.vnfdId \u003d req.vnfdId"},{"line_number":335,"context_line":"        else:"},{"line_number":336,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":337,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":338,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dd5dbcc6_c4171b0a","line":336,"range":{"start_line":336,"start_character":65,"end_line":336,"end_character":77},"in_reply_to":"74cf7387_f17bcf16","updated":"2022-03-04 09:10:19.000000000","message":"I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                heat_client, stack_name)"},{"line_number":334,"context_line":"            inst.vnfdId \u003d req.vnfdId"},{"line_number":335,"context_line":"        else:"},{"line_number":336,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":337,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":338,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"012f1efe_c1523b0b","line":336,"range":{"start_line":336,"start_character":65,"end_line":336,"end_character":77},"in_reply_to":"dd5dbcc6_c4171b0a","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":362,"context_line":"                    vdu_image_id_flag \u003d False"},{"line_number":363,"context_line":"                if lcmocc_vnf.metadata.get("},{"line_number":364,"context_line":"                        \u0027current_vnfd_id\u0027) is not inst.vnfdId:"},{"line_number":365,"context_line":"                    if lcmocc_vnf.metadata.get("},{"line_number":366,"context_line":"                            \u0027parent_resource_name\u0027) !\u003d stack_name:"},{"line_number":367,"context_line":"                        if not templates.get(lcmocc_vnf.vduId):"},{"line_number":368,"context_line":"                            templates[lcmocc_vnf.vduId] \u003d {}"},{"line_number":369,"context_line":"                            heat_reses \u003d heat_client.get_resources(stack_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"af615f8f_593da9f1","line":366,"range":{"start_line":365,"start_character":23,"end_line":366,"end_character":51},"updated":"2022-03-02 08:37:42.000000000","message":"It is gotten several times after this, so why don\u0027t you use it in a variable?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                    vdu_image_id_flag \u003d False"},{"line_number":363,"context_line":"                if lcmocc_vnf.metadata.get("},{"line_number":364,"context_line":"                        \u0027current_vnfd_id\u0027) is not inst.vnfdId:"},{"line_number":365,"context_line":"                    if lcmocc_vnf.metadata.get("},{"line_number":366,"context_line":"                            \u0027parent_resource_name\u0027) !\u003d stack_name:"},{"line_number":367,"context_line":"                        if not templates.get(lcmocc_vnf.vduId):"},{"line_number":368,"context_line":"                            templates[lcmocc_vnf.vduId] \u003d {}"},{"line_number":369,"context_line":"                            heat_reses \u003d heat_client.get_resources(stack_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"afc5ef88_dc433bb0","line":366,"range":{"start_line":365,"start_character":23,"end_line":366,"end_character":51},"in_reply_to":"33464131_6b040df8","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":362,"context_line":"                    vdu_image_id_flag \u003d False"},{"line_number":363,"context_line":"                if lcmocc_vnf.metadata.get("},{"line_number":364,"context_line":"                        \u0027current_vnfd_id\u0027) is not inst.vnfdId:"},{"line_number":365,"context_line":"                    if lcmocc_vnf.metadata.get("},{"line_number":366,"context_line":"                            \u0027parent_resource_name\u0027) !\u003d stack_name:"},{"line_number":367,"context_line":"                        if not templates.get(lcmocc_vnf.vduId):"},{"line_number":368,"context_line":"                            templates[lcmocc_vnf.vduId] \u003d {}"},{"line_number":369,"context_line":"                            heat_reses \u003d heat_client.get_resources(stack_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"33464131_6b040df8","line":366,"range":{"start_line":365,"start_character":23,"end_line":366,"end_character":51},"in_reply_to":"af615f8f_593da9f1","updated":"2022-03-04 09:10:19.000000000","message":"Yes. It is a good idea. I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":389,"context_line":"                        self._get_new_res_info(lcmocc_vnf.metadata.get("},{"line_number":390,"context_line":"                            \u0027parent_resource_name\u0027),"},{"line_number":391,"context_line":"                            new_res_ids[lcmocc_vnf.vduId],"},{"line_number":392,"context_line":"                            lcmocc_vnf.metadata.get(\u0027parent_stack_id\u0027),"},{"line_number":393,"context_line":"                            vdu_infos[lcmocc_vnf.vduId],"},{"line_number":394,"context_line":"                            lcmocc_vnf.vduId, heat_client)"},{"line_number":395,"context_line":"                        vdu_param \u003d [vdu_param for vdu_param in"}],"source_content_type":"text/x-python","patch_set":7,"id":"3cfcb35d_f4b0778d","line":392,"range":{"start_line":392,"start_character":28,"end_line":392,"end_character":70},"updated":"2022-03-02 08:37:42.000000000","message":"It is gotten several times after this, so why don\u0027t you use it in a variable?\nI think it would be good to get it after L364, what do you think?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":389,"context_line":"                        self._get_new_res_info(lcmocc_vnf.metadata.get("},{"line_number":390,"context_line":"                            \u0027parent_resource_name\u0027),"},{"line_number":391,"context_line":"                            new_res_ids[lcmocc_vnf.vduId],"},{"line_number":392,"context_line":"                            lcmocc_vnf.metadata.get(\u0027parent_stack_id\u0027),"},{"line_number":393,"context_line":"                            vdu_infos[lcmocc_vnf.vduId],"},{"line_number":394,"context_line":"                            lcmocc_vnf.vduId, heat_client)"},{"line_number":395,"context_line":"                        vdu_param \u003d [vdu_param for vdu_param in"}],"source_content_type":"text/x-python","patch_set":7,"id":"d27eab72_69c4eff9","line":392,"range":{"start_line":392,"start_character":28,"end_line":392,"end_character":70},"in_reply_to":"3cfcb35d_f4b0778d","updated":"2022-03-04 09:10:19.000000000","message":"Yes. It is a good idea. I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                        self._get_new_res_info(lcmocc_vnf.metadata.get("},{"line_number":390,"context_line":"                            \u0027parent_resource_name\u0027),"},{"line_number":391,"context_line":"                            new_res_ids[lcmocc_vnf.vduId],"},{"line_number":392,"context_line":"                            lcmocc_vnf.metadata.get(\u0027parent_stack_id\u0027),"},{"line_number":393,"context_line":"                            vdu_infos[lcmocc_vnf.vduId],"},{"line_number":394,"context_line":"                            lcmocc_vnf.vduId, heat_client)"},{"line_number":395,"context_line":"                        vdu_param \u003d [vdu_param for vdu_param in"}],"source_content_type":"text/x-python","patch_set":7,"id":"9743ef5b_b616b0bd","line":392,"range":{"start_line":392,"start_character":28,"end_line":392,"end_character":70},"in_reply_to":"d27eab72_69c4eff9","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":441,"context_line":"                req, new_res_ids, inst, vnfd,"},{"line_number":442,"context_line":"                heat_client, stack_name, operation\u003d\u0027change_vnfpkg_rollback\u0027)"},{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":445,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":446,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"89b6efcb_d72eef84","line":444,"range":{"start_line":444,"start_character":65,"end_line":444,"end_character":77},"updated":"2022-03-02 08:37:42.000000000","message":"It\u0027s not clear when the \"next\" is, so how about to change it to like \"future release\" or \"Zed release\"?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                req, new_res_ids, inst, vnfd,"},{"line_number":442,"context_line":"                heat_client, stack_name, operation\u003d\u0027change_vnfpkg_rollback\u0027)"},{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":445,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":446,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"06e89426_d51672ca","line":444,"range":{"start_line":444,"start_character":65,"end_line":444,"end_character":77},"in_reply_to":"7b33759a_7f2ee36c","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":441,"context_line":"                req, new_res_ids, inst, vnfd,"},{"line_number":442,"context_line":"                heat_client, stack_name, operation\u003d\u0027change_vnfpkg_rollback\u0027)"},{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            # TODO(YiFeng): Blue-Green type will be supported in next version."},{"line_number":445,"context_line":"            raise sol_ex.NotSupportUpgradeType("},{"line_number":446,"context_line":"                upgrade_type\u003dreq.additionalParams.get(\u0027upgrade_type\u0027))"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7b33759a_7f2ee36c","line":444,"range":{"start_line":444,"start_character":65,"end_line":444,"end_character":77},"in_reply_to":"89b6efcb_d72eef84","updated":"2022-03-04 09:10:19.000000000","message":"I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"98b7b402f9b86798357f167ef1967b15bbf06ba7","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                vdu_id \u003d vdu_param.get(\u0027vduId\u0027)"},{"line_number":310,"context_line":"                new_res_ids[vdu_id] \u003d []"},{"line_number":311,"context_line":"                resp, _ \u003d heat_client.get_resource_info("},{"line_number":312,"context_line":"                    stack_name, stack_id, vdu_param.get(\u0027vduId\u0027))"},{"line_number":313,"context_line":"                if uuidutils.is_uuid_like("},{"line_number":314,"context_line":"                        vdu_infos[vdu_param.get(\u0027vduId\u0027)][\u0027image\u0027]):"},{"line_number":315,"context_line":"                    vdu_image_id_flag \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"dd4ca3ea_c4377966","line":312,"updated":"2022-03-06 23:52:49.000000000","message":"use vdu_id instead of vdu_param.get(\u0027vduId\u0027)","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                vdu_id \u003d vdu_param.get(\u0027vduId\u0027)"},{"line_number":310,"context_line":"                new_res_ids[vdu_id] \u003d []"},{"line_number":311,"context_line":"                resp, _ \u003d heat_client.get_resource_info("},{"line_number":312,"context_line":"                    stack_name, stack_id, vdu_param.get(\u0027vduId\u0027))"},{"line_number":313,"context_line":"                if uuidutils.is_uuid_like("},{"line_number":314,"context_line":"                        vdu_infos[vdu_param.get(\u0027vduId\u0027)][\u0027image\u0027]):"},{"line_number":315,"context_line":"                    vdu_image_id_flag \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"de727d6a_d5da310c","line":312,"in_reply_to":"ac9ffca1_af6039e5","updated":"2022-03-08 01:30:42.000000000","message":"Done","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                vdu_id \u003d vdu_param.get(\u0027vduId\u0027)"},{"line_number":310,"context_line":"                new_res_ids[vdu_id] \u003d []"},{"line_number":311,"context_line":"                resp, _ \u003d heat_client.get_resource_info("},{"line_number":312,"context_line":"                    stack_name, stack_id, vdu_param.get(\u0027vduId\u0027))"},{"line_number":313,"context_line":"                if uuidutils.is_uuid_like("},{"line_number":314,"context_line":"                        vdu_infos[vdu_param.get(\u0027vduId\u0027)][\u0027image\u0027]):"},{"line_number":315,"context_line":"                    vdu_image_id_flag \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"ac9ffca1_af6039e5","line":312,"in_reply_to":"dd4ca3ea_c4377966","updated":"2022-03-07 06:18:34.000000000","message":"I fixed it in PS10.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"98b7b402f9b86798357f167ef1967b15bbf06ba7","unresolved":true,"context_lines":[{"line_number":311,"context_line":"                resp, _ \u003d heat_client.get_resource_info("},{"line_number":312,"context_line":"                    stack_name, stack_id, vdu_param.get(\u0027vduId\u0027))"},{"line_number":313,"context_line":"                if uuidutils.is_uuid_like("},{"line_number":314,"context_line":"                        vdu_infos[vdu_param.get(\u0027vduId\u0027)][\u0027image\u0027]):"},{"line_number":315,"context_line":"                    vdu_image_id_flag \u003d True"},{"line_number":316,"context_line":"                else:"},{"line_number":317,"context_line":"                    vdu_image_id_flag \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"4b0dc22e_3e0ff98a","line":314,"updated":"2022-03-06 23:52:49.000000000","message":"ditto","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":311,"context_line":"                resp, _ \u003d heat_client.get_resource_info("},{"line_number":312,"context_line":"                    stack_name, stack_id, vdu_param.get(\u0027vduId\u0027))"},{"line_number":313,"context_line":"                if uuidutils.is_uuid_like("},{"line_number":314,"context_line":"                        vdu_infos[vdu_param.get(\u0027vduId\u0027)][\u0027image\u0027]):"},{"line_number":315,"context_line":"                    vdu_image_id_flag \u003d True"},{"line_number":316,"context_line":"                else:"},{"line_number":317,"context_line":"                    vdu_image_id_flag \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"e66e5b0d_7b11963a","line":314,"in_reply_to":"4b0dc22e_3e0ff98a","updated":"2022-03-07 06:18:34.000000000","message":"ditto","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                resp, _ \u003d heat_client.get_resource_info("},{"line_number":312,"context_line":"                    stack_name, stack_id, vdu_param.get(\u0027vduId\u0027))"},{"line_number":313,"context_line":"                if uuidutils.is_uuid_like("},{"line_number":314,"context_line":"                        vdu_infos[vdu_param.get(\u0027vduId\u0027)][\u0027image\u0027]):"},{"line_number":315,"context_line":"                    vdu_image_id_flag \u003d True"},{"line_number":316,"context_line":"                else:"},{"line_number":317,"context_line":"                    vdu_image_id_flag \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"f4978717_23bf4d1b","line":314,"in_reply_to":"e66e5b0d_7b11963a","updated":"2022-03-08 01:30:42.000000000","message":"Done","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"acece912037c64bc2642a92f3a0e6f304d6ee69f","unresolved":true,"context_lines":[{"line_number":420,"context_line":"            fields \u003d self._get_entire_stack_fields("},{"line_number":421,"context_line":"                heat_client, stack_id, group_vdu_ids, vdu_infos)"},{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"}],"source_content_type":"text/x-python","patch_set":9,"id":"aec45336_833df276","line":423,"updated":"2022-03-07 02:01:11.000000000","message":"\"wait\u003dTrue\" is not necessary since it is default. (it is better to be same as others)","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1cb2ef2611178e0676dcc581e99ee1b6b72d4063","unresolved":true,"context_lines":[{"line_number":420,"context_line":"            fields \u003d self._get_entire_stack_fields("},{"line_number":421,"context_line":"                heat_client, stack_id, group_vdu_ids, vdu_infos)"},{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5562dbd2_6d0ab539","line":423,"in_reply_to":"14b82133_f8cfbe87","updated":"2022-03-08 04:46:12.000000000","message":"I fixed it in PS12","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"78686a7a070c537afed114d44b3cf8adf08a0e43","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            fields \u003d self._get_entire_stack_fields("},{"line_number":421,"context_line":"                heat_client, stack_id, group_vdu_ids, vdu_infos)"},{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"}],"source_content_type":"text/x-python","patch_set":9,"id":"4dbcbc04_859410d5","line":423,"in_reply_to":"5562dbd2_6d0ab539","updated":"2022-03-08 23:25:16.000000000","message":"Done","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":420,"context_line":"            fields \u003d self._get_entire_stack_fields("},{"line_number":421,"context_line":"                heat_client, stack_id, group_vdu_ids, vdu_infos)"},{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ec0ad7b1_4e6e0f48","line":423,"in_reply_to":"aec45336_833df276","updated":"2022-03-07 06:18:34.000000000","message":"I fixed it in PS10.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":true,"context_lines":[{"line_number":420,"context_line":"            fields \u003d self._get_entire_stack_fields("},{"line_number":421,"context_line":"                heat_client, stack_id, group_vdu_ids, vdu_infos)"},{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"}],"source_content_type":"text/x-python","patch_set":9,"id":"14b82133_f8cfbe87","line":423,"in_reply_to":"ec0ad7b1_4e6e0f48","updated":"2022-03-08 01:30:42.000000000","message":"not fixed yet.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"acece912037c64bc2642a92f3a0e6f304d6ee69f","unresolved":true,"context_lines":[{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"10034fb7_fe1333ec","line":425,"updated":"2022-03-07 02:01:11.000000000","message":"It is meaningless. inst will not be saved.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3998b389ffa8eee9e82d1074426683ddf612d79a","unresolved":true,"context_lines":[{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"53bdc1bf_1816787c","line":425,"in_reply_to":"10034fb7_fe1333ec","updated":"2022-03-07 06:18:34.000000000","message":"This is not to update vnf_instance, but to update the resouceChanges in Vnflcm_op_occ, which needs to be obtained from vnf_instance, so it is processed here. When rolling back, you need to obtain the information to be rolledback from the resourceChanges of vnflcm_op_occ.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d107974b3d50e501292865c1e14c7a6184de86c7","unresolved":true,"context_lines":[{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"f4d39dac_8dc208c2","line":425,"in_reply_to":"2142ec06_c73caf88","updated":"2022-03-10 00:07:23.000000000","message":"I understand there is a disagreement about rollback design.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1cb2ef2611178e0676dcc581e99ee1b6b72d4063","unresolved":true,"context_lines":[{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dded1658_9dca7c8b","line":425,"in_reply_to":"320feaeb_a7d338d7","updated":"2022-03-08 04:46:12.000000000","message":"I need to know what resource has been modified by change_vnfpkg but it has not been successful. When I rollback, I can roll back the resource to the previous vnfd settings. During rollback, only the data of vnflcm_op_occ is known, so it is only known from resourceChanges which VDUs were updated by change_vnfpkg but the update failed, so that they will be rolled back.\nIf I can\u0027t use the resourceChanges to store failed VDUs information, do you have any better suggestion? I can change my code in next PS.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7b4b3a07fcdfc358df335b97b9431820860a3af8","unresolved":true,"context_lines":[{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"320feaeb_a7d338d7","line":425,"in_reply_to":"53bdc1bf_1816787c","updated":"2022-03-08 01:30:42.000000000","message":"resoureChanges in Vnflcm_op_occ is set when the process success.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"78686a7a070c537afed114d44b3cf8adf08a0e43","unresolved":true,"context_lines":[{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"f646db78_46d56018","line":425,"in_reply_to":"dded1658_9dca7c8b","updated":"2022-03-08 23:25:16.000000000","message":"About rollback, I think it is enough to do stack update with original template and original parameters simply. original template can be get from original vnfd. I think values for original parameters can be get from existing VnfInstance object (from DB). Note that contents of VnfInstance object (from DB) are before change_vnfpkg starting.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7f3baa45c89f653a72675a45080b9f590cb135f9","unresolved":true,"context_lines":[{"line_number":422,"context_line":"            try:"},{"line_number":423,"context_line":"                heat_client.update_stack(stack_id, fields, wait\u003dTrue)"},{"line_number":424,"context_line":"            except sol_ex.StackOperationFailed:"},{"line_number":425,"context_line":"                self._handle_exception("},{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"2142ec06_c73caf88","line":425,"in_reply_to":"f646db78_46d56018","updated":"2022-03-09 07:34:53.000000000","message":"The rollingupdate upgrade_type should update VDU one by one. And the rollback operation also should rollback one by one. Currently, the code is satisfactory by design.\nIf it must be modified, I need to re-test, which is a waste of time and may not catch up with the release on Friday. If you really want to modify it, we can discuss the modification plan in the next version.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"182a2ac23e777d673f927f1cd4b697aaef841c65","unresolved":true,"context_lines":[{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"},{"line_number":429,"context_line":"            self._update_vnf_instantiated_info("},{"line_number":430,"context_line":"                req, new_res_ids, inst, vnfd,"},{"line_number":431,"context_line":"                heat_client, stack_name)"},{"line_number":432,"context_line":"            inst.vnfdId \u003d req.vnfdId"}],"source_content_type":"text/x-python","patch_set":9,"id":"b0adb1f5_d8ba2597","line":429,"updated":"2022-03-07 04:27:13.000000000","message":"why not use _make_instatiated_vnf_info ?\nshould use _make_instantiated_vnf_info. even if there is a reason, should modify _make_instantiated_vnf_info. note that there are some treatments for other APIs (ex. heal).","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"77dd0d72276d303a18e9d8d27e93c078ad701eee","unresolved":true,"context_lines":[{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"},{"line_number":429,"context_line":"            self._update_vnf_instantiated_info("},{"line_number":430,"context_line":"                req, new_res_ids, inst, vnfd,"},{"line_number":431,"context_line":"                heat_client, stack_name)"},{"line_number":432,"context_line":"            inst.vnfdId \u003d req.vnfdId"}],"source_content_type":"text/x-python","patch_set":9,"id":"bff53482_1c8e4a0a","line":429,"in_reply_to":"a5b17186_bedc7412","updated":"2022-03-09 23:51:20.000000000","message":"_make_instantiated_vnf_info is the method that it makes instantiatedVnfInfo from current heat resources. It does not matter what was updated. (unchanged part is unchanged)\nOriginally it is enough to call _make_instantiated_vnf_info at last of each API by design. I mean it should be no problem to call _make_instantiated_vnf_info.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7f3baa45c89f653a72675a45080b9f590cb135f9","unresolved":true,"context_lines":[{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"},{"line_number":429,"context_line":"            self._update_vnf_instantiated_info("},{"line_number":430,"context_line":"                req, new_res_ids, inst, vnfd,"},{"line_number":431,"context_line":"                heat_client, stack_name)"},{"line_number":432,"context_line":"            inst.vnfdId \u003d req.vnfdId"}],"source_content_type":"text/x-python","patch_set":9,"id":"a5b17186_bedc7412","line":429,"in_reply_to":"b0adb1f5_d8ba2597","updated":"2022-03-09 07:34:53.000000000","message":"rollingupdate does not change any network info, I only modify the updated vdu information and storage information, I don\u0027t think it is necessary to regenerate instantiated_info. This doesn\u0027t match my original SS design, and when I started the design, the method hadn\u0027t been uploaded to the master branch, so I didn\u0027t refer to it. If I changed it to _make_instantiated_vnf_info, I need time to unblock and test whether this part of the code matches my operation again, which will take extra time. If necessary, I can refactor it together the next time I add the blue-green update method.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a9c47b79efdc3cb1fd10819a599f10a75c9b8c38","unresolved":true,"context_lines":[{"line_number":426,"context_line":"                    res, new_res_ids, vdu_infos,"},{"line_number":427,"context_line":"                    vdu_id, heat_client, req, inst, vnfd,"},{"line_number":428,"context_line":"                    stack_name)"},{"line_number":429,"context_line":"            self._update_vnf_instantiated_info("},{"line_number":430,"context_line":"                req, new_res_ids, inst, vnfd,"},{"line_number":431,"context_line":"                heat_client, stack_name)"},{"line_number":432,"context_line":"            inst.vnfdId \u003d req.vnfdId"}],"source_content_type":"text/x-python","patch_set":9,"id":"16bc6e77_83476030","line":429,"in_reply_to":"bff53482_1c8e4a0a","updated":"2022-03-10 10:18:25.000000000","message":"I know that `_make_instantiated_vnf_info` can handle the action of change_vnfpkg, but I am not sure if it can handle the data I want when I rollback. It will take a long time to reconsider the design, so I will not fix this part in this patch. And it doesn\u0027t affect other APIs currently. I think I\u0027ll refactor this part together in the next update for blue-green.","commit_id":"f04e7ef9256c3faeed63af1b83f4fc3dc266dce1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"78686a7a070c537afed114d44b3cf8adf08a0e43","unresolved":true,"context_lines":[{"line_number":1343,"context_line":"            metadata[\u0027parent_stack_id\u0027] \u003d ("},{"line_number":1344,"context_line":"                heat_utils.get_resource_stack_id(parent_res))"},{"line_number":1345,"context_line":"            metadata[\u0027parent_resource_name\u0027] \u003d parent_res[\u0027resource_name\u0027]"},{"line_number":1346,"context_line":"        else:"},{"line_number":1347,"context_line":"            metadata[\u0027parent_stack_id\u0027] \u003d ("},{"line_number":1348,"context_line":"                heat_utils.get_resource_stack_id(server_res))"},{"line_number":1349,"context_line":"            metadata[\u0027parent_resource_name\u0027] \u003d metadata["}],"source_content_type":"text/x-python","patch_set":12,"id":"52c2c630_8ca1511c","line":1346,"updated":"2022-03-08 23:25:16.000000000","message":"question:\nwhy add this else clause ?\nPreviously it is intended that it can be checked that a VM is created by AutoScalingGroup or not by \u0027parent_stack_id\u0027 existence.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a9c47b79efdc3cb1fd10819a599f10a75c9b8c38","unresolved":true,"context_lines":[{"line_number":1343,"context_line":"            metadata[\u0027parent_stack_id\u0027] \u003d ("},{"line_number":1344,"context_line":"                heat_utils.get_resource_stack_id(parent_res))"},{"line_number":1345,"context_line":"            metadata[\u0027parent_resource_name\u0027] \u003d parent_res[\u0027resource_name\u0027]"},{"line_number":1346,"context_line":"        else:"},{"line_number":1347,"context_line":"            metadata[\u0027parent_stack_id\u0027] \u003d ("},{"line_number":1348,"context_line":"                heat_utils.get_resource_stack_id(server_res))"},{"line_number":1349,"context_line":"            metadata[\u0027parent_resource_name\u0027] \u003d metadata["}],"source_content_type":"text/x-python","patch_set":12,"id":"48774c22_f49dc8ac","line":1346,"in_reply_to":"2eec1a71_95fe14ab","updated":"2022-03-10 10:18:25.000000000","message":"I have used `stack_id` instead. I deleted `else` in PS 15.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"77dd0d72276d303a18e9d8d27e93c078ad701eee","unresolved":true,"context_lines":[{"line_number":1343,"context_line":"            metadata[\u0027parent_stack_id\u0027] \u003d ("},{"line_number":1344,"context_line":"                heat_utils.get_resource_stack_id(parent_res))"},{"line_number":1345,"context_line":"            metadata[\u0027parent_resource_name\u0027] \u003d parent_res[\u0027resource_name\u0027]"},{"line_number":1346,"context_line":"        else:"},{"line_number":1347,"context_line":"            metadata[\u0027parent_stack_id\u0027] \u003d ("},{"line_number":1348,"context_line":"                heat_utils.get_resource_stack_id(server_res))"},{"line_number":1349,"context_line":"            metadata[\u0027parent_resource_name\u0027] \u003d metadata["}],"source_content_type":"text/x-python","patch_set":12,"id":"2eec1a71_95fe14ab","line":1346,"in_reply_to":"2f93e6f0_90a15d06","updated":"2022-03-09 23:51:20.000000000","message":"can\u0027t be used matadata[\u0027stack_id\u0027] instead ?\n\nOriginally existence of \u0027parent_stack_id\u0027 means VM is created by AutoScalingGroup. Your change break this assumption.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"3661ae884efbdb924663721085641c11755339e8","unresolved":false,"context_lines":[{"line_number":1343,"context_line":"            metadata[\u0027parent_stack_id\u0027] \u003d ("},{"line_number":1344,"context_line":"                heat_utils.get_resource_stack_id(parent_res))"},{"line_number":1345,"context_line":"            metadata[\u0027parent_resource_name\u0027] \u003d parent_res[\u0027resource_name\u0027]"},{"line_number":1346,"context_line":"        else:"},{"line_number":1347,"context_line":"            metadata[\u0027parent_stack_id\u0027] \u003d ("},{"line_number":1348,"context_line":"                heat_utils.get_resource_stack_id(server_res))"},{"line_number":1349,"context_line":"            metadata[\u0027parent_resource_name\u0027] \u003d metadata["}],"source_content_type":"text/x-python","patch_set":12,"id":"f851d7b8_a1b1df3b","line":1346,"in_reply_to":"48774c22_f49dc8ac","updated":"2022-03-10 22:43:14.000000000","message":"I see.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7f3baa45c89f653a72675a45080b9f590cb135f9","unresolved":true,"context_lines":[{"line_number":1343,"context_line":"            metadata[\u0027parent_stack_id\u0027] \u003d ("},{"line_number":1344,"context_line":"                heat_utils.get_resource_stack_id(parent_res))"},{"line_number":1345,"context_line":"            metadata[\u0027parent_resource_name\u0027] \u003d parent_res[\u0027resource_name\u0027]"},{"line_number":1346,"context_line":"        else:"},{"line_number":1347,"context_line":"            metadata[\u0027parent_stack_id\u0027] \u003d ("},{"line_number":1348,"context_line":"                heat_utils.get_resource_stack_id(server_res))"},{"line_number":1349,"context_line":"            metadata[\u0027parent_resource_name\u0027] \u003d metadata["}],"source_content_type":"text/x-python","patch_set":12,"id":"2f93e6f0_90a15d06","line":1346,"in_reply_to":"52c2c630_8ca1511c","updated":"2022-03-09 07:34:53.000000000","message":"If a VM is not created by AutoScalingGroup. It does not have parent_resource.\nIts parent is this stack itself. When update info, in my design, I should know its parent_stack_id, so I can know which vdu I should update.","commit_id":"7a6d4f13ee766888cb527073ae0196d26e9d091a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"469579e29ed2e55377352bb71a3c4fb53a0c1292","unresolved":true,"context_lines":[{"line_number":306,"context_line":"            vdu_infos \u003d self._get_vdu_info(vnfd, grant, inst)"},{"line_number":307,"context_line":"            new_res_ids \u003d {}"},{"line_number":308,"context_line":"            for vdu_param in req.additionalParams.get(\u0027vdu_params\u0027):"},{"line_number":309,"context_line":"                vdu_id \u003d vdu_param.get(\u0027vduId\u0027)"},{"line_number":310,"context_line":"                new_res_ids[vdu_id] \u003d []"},{"line_number":311,"context_line":"                body \u003d heat_client.get_resource_info("},{"line_number":312,"context_line":"                    f\"{stack_name}/{stack_id}\", vdu_id)"}],"source_content_type":"text/x-python","patch_set":22,"id":"17bf9596_3a42e06c","line":309,"range":{"start_line":309,"start_character":40,"end_line":309,"end_character":45},"updated":"2022-03-14 10:15:05.000000000","message":"Based on the Spec, I think \"vdu_id\" is correct.\n---\nhttps://specs.openstack.org/openstack/tacker-specs/specs/yoga/upgrade-vnf-package.html","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":306,"context_line":"            vdu_infos \u003d self._get_vdu_info(vnfd, grant, inst)"},{"line_number":307,"context_line":"            new_res_ids \u003d {}"},{"line_number":308,"context_line":"            for vdu_param in req.additionalParams.get(\u0027vdu_params\u0027):"},{"line_number":309,"context_line":"                vdu_id \u003d vdu_param.get(\u0027vduId\u0027)"},{"line_number":310,"context_line":"                new_res_ids[vdu_id] \u003d []"},{"line_number":311,"context_line":"                body \u003d heat_client.get_resource_info("},{"line_number":312,"context_line":"                    f\"{stack_name}/{stack_id}\", vdu_id)"}],"source_content_type":"text/x-python","patch_set":22,"id":"88781369_4b12599a","line":309,"range":{"start_line":309,"start_character":40,"end_line":309,"end_character":45},"in_reply_to":"17bf9596_3a42e06c","updated":"2022-03-16 01:17:28.000000000","message":"I fixed it in PS24.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ec0aa5b01a00bb834e677d90b8e1013ebc2ef7d0","unresolved":false,"context_lines":[{"line_number":306,"context_line":"            vdu_infos \u003d self._get_vdu_info(vnfd, grant, inst)"},{"line_number":307,"context_line":"            new_res_ids \u003d {}"},{"line_number":308,"context_line":"            for vdu_param in req.additionalParams.get(\u0027vdu_params\u0027):"},{"line_number":309,"context_line":"                vdu_id \u003d vdu_param.get(\u0027vduId\u0027)"},{"line_number":310,"context_line":"                new_res_ids[vdu_id] \u003d []"},{"line_number":311,"context_line":"                body \u003d heat_client.get_resource_info("},{"line_number":312,"context_line":"                    f\"{stack_name}/{stack_id}\", vdu_id)"}],"source_content_type":"text/x-python","patch_set":22,"id":"bcede808_a9bba4ef","line":309,"range":{"start_line":309,"start_character":40,"end_line":309,"end_character":45},"in_reply_to":"88781369_4b12599a","updated":"2022-03-16 07:42:47.000000000","message":"Done","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"9d482d2e7369a65048b9398fa791bc07be14e453","unresolved":true,"context_lines":[{"line_number":941,"context_line":"                new_res_info \u003d new_res_info[0]"},{"line_number":942,"context_line":"                vnfc_res.id \u003d new_res_info.get(\u0027vdu_id\u0027)"},{"line_number":943,"context_line":"                vnfc_res.computeResource.resourceId \u003d new_res_info.get("},{"line_number":944,"context_line":"                    \u0027vdu_id\u0027)"},{"line_number":945,"context_line":"                if operation \u003d\u003d \u0027change_vnfpkg\u0027:"},{"line_number":946,"context_line":"                    vnfc_res.metadata[\u0027current_vnfd_id\u0027] \u003d req.vnfdId"},{"line_number":947,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":22,"id":"fc58e566_ac491e8c","line":944,"updated":"2022-03-15 00:53:13.000000000","message":"vnfinstance.instantiatedvnfinfo.vnfcinfo.vnfcresourceid also needs to be updated.\nWould you please add the processing?\n\nThe following may be helpful.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/infra_drivers/openstack/openstack.py#L919\n\nWithout updating this parameter, heal operation will fail because heal operation checks the whether vnfinstance.instantiatedvnfinfo.vnfcinfo.vnfcresourceid is exists in vnfinstance.instantiatedvnfinfo.vnfcResourceInfo.id.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"465fa23228bcb3d0fefd0962d383f53f2ecce120","unresolved":false,"context_lines":[{"line_number":941,"context_line":"                new_res_info \u003d new_res_info[0]"},{"line_number":942,"context_line":"                vnfc_res.id \u003d new_res_info.get(\u0027vdu_id\u0027)"},{"line_number":943,"context_line":"                vnfc_res.computeResource.resourceId \u003d new_res_info.get("},{"line_number":944,"context_line":"                    \u0027vdu_id\u0027)"},{"line_number":945,"context_line":"                if operation \u003d\u003d \u0027change_vnfpkg\u0027:"},{"line_number":946,"context_line":"                    vnfc_res.metadata[\u0027current_vnfd_id\u0027] \u003d req.vnfdId"},{"line_number":947,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":22,"id":"e3ed2582_74806528","line":944,"in_reply_to":"6700cb36_9bfdf783","updated":"2022-03-16 08:36:22.000000000","message":"Thank you for fixing it.\nI confirmed that the heal operation error was resolved.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":941,"context_line":"                new_res_info \u003d new_res_info[0]"},{"line_number":942,"context_line":"                vnfc_res.id \u003d new_res_info.get(\u0027vdu_id\u0027)"},{"line_number":943,"context_line":"                vnfc_res.computeResource.resourceId \u003d new_res_info.get("},{"line_number":944,"context_line":"                    \u0027vdu_id\u0027)"},{"line_number":945,"context_line":"                if operation \u003d\u003d \u0027change_vnfpkg\u0027:"},{"line_number":946,"context_line":"                    vnfc_res.metadata[\u0027current_vnfd_id\u0027] \u003d req.vnfdId"},{"line_number":947,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":22,"id":"6700cb36_9bfdf783","line":944,"in_reply_to":"fc58e566_ac491e8c","updated":"2022-03-16 01:17:28.000000000","message":"I added the processing in PS24.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"}],"tacker/sol_refactored/nfvo/local_nfvo.py":[{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"ccfac071370e7cd7f50088122d9ab6e20f57ea58","unresolved":true,"context_lines":[{"line_number":225,"context_line":"            if \u0027file\u0027 in sw_data:"},{"line_number":226,"context_line":"                vim_info \u003d self._get_vim_info(context, grant_req)"},{"line_number":227,"context_line":"                if vim_info is None:"},{"line_number":228,"context_line":"                    msg \u003d \"No vimConnectionInfo to create glanceimage\""},{"line_number":229,"context_line":"                    LOG.exception(msg)"},{"line_number":230,"context_line":"                    raise sol_ex.LocalNfvoGrantFailed(sol_detail\u003dmsg)"},{"line_number":231,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9923abee_779d0696","line":228,"range":{"start_line":228,"start_character":30,"end_line":228,"end_character":47},"updated":"2022-02-08 01:07:45.000000000","message":"I think \"VimConnectionInfo\" is better in the message.","commit_id":"39d55e7bc53ea71c7f02c54bc7a828c7edc84634"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"ccfac071370e7cd7f50088122d9ab6e20f57ea58","unresolved":true,"context_lines":[{"line_number":225,"context_line":"            if \u0027file\u0027 in sw_data:"},{"line_number":226,"context_line":"                vim_info \u003d self._get_vim_info(context, grant_req)"},{"line_number":227,"context_line":"                if vim_info is None:"},{"line_number":228,"context_line":"                    msg \u003d \"No vimConnectionInfo to create glanceimage\""},{"line_number":229,"context_line":"                    LOG.exception(msg)"},{"line_number":230,"context_line":"                    raise sol_ex.LocalNfvoGrantFailed(sol_detail\u003dmsg)"},{"line_number":231,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"29a93775_fd2aa920","line":228,"range":{"start_line":228,"start_character":58,"end_line":228,"end_character":69},"updated":"2022-02-08 01:07:45.000000000","message":"typo: glance image ?","commit_id":"39d55e7bc53ea71c7f02c54bc7a828c7edc84634"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"760d9c2764bc348962c2589a7fe090c5ba4de327","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            if \u0027file\u0027 in sw_data:"},{"line_number":226,"context_line":"                vim_info \u003d self._get_vim_info(context, grant_req)"},{"line_number":227,"context_line":"                if vim_info is None:"},{"line_number":228,"context_line":"                    msg \u003d \"No vimConnectionInfo to create glanceimage\""},{"line_number":229,"context_line":"                    LOG.exception(msg)"},{"line_number":230,"context_line":"                    raise sol_ex.LocalNfvoGrantFailed(sol_detail\u003dmsg)"},{"line_number":231,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5bfb296d_b613a00c","line":228,"range":{"start_line":228,"start_character":58,"end_line":228,"end_character":69},"in_reply_to":"120d5487_616af39f","updated":"2022-02-25 08:55:50.000000000","message":"Done.","commit_id":"39d55e7bc53ea71c7f02c54bc7a828c7edc84634"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":225,"context_line":"            if \u0027file\u0027 in sw_data:"},{"line_number":226,"context_line":"                vim_info \u003d self._get_vim_info(context, grant_req)"},{"line_number":227,"context_line":"                if vim_info is None:"},{"line_number":228,"context_line":"                    msg \u003d \"No vimConnectionInfo to create glanceimage\""},{"line_number":229,"context_line":"                    LOG.exception(msg)"},{"line_number":230,"context_line":"                    raise sol_ex.LocalNfvoGrantFailed(sol_detail\u003dmsg)"},{"line_number":231,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"120d5487_616af39f","line":228,"range":{"start_line":228,"start_character":58,"end_line":228,"end_character":69},"in_reply_to":"29a93775_fd2aa920","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"39d55e7bc53ea71c7f02c54bc7a828c7edc84634"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":225,"context_line":"            if \u0027file\u0027 in sw_data:"},{"line_number":226,"context_line":"                vim_info \u003d self._get_vim_info(context, grant_req)"},{"line_number":227,"context_line":"                if vim_info is None:"},{"line_number":228,"context_line":"                    msg \u003d \"No vimConnectionInfo to create glanceimage\""},{"line_number":229,"context_line":"                    LOG.exception(msg)"},{"line_number":230,"context_line":"                    raise sol_ex.LocalNfvoGrantFailed(sol_detail\u003dmsg)"},{"line_number":231,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bca66e91_09efb60c","line":228,"range":{"start_line":228,"start_character":30,"end_line":228,"end_character":47},"in_reply_to":"9923abee_779d0696","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"39d55e7bc53ea71c7f02c54bc7a828c7edc84634"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"760d9c2764bc348962c2589a7fe090c5ba4de327","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            if \u0027file\u0027 in sw_data:"},{"line_number":226,"context_line":"                vim_info \u003d self._get_vim_info(context, grant_req)"},{"line_number":227,"context_line":"                if vim_info is None:"},{"line_number":228,"context_line":"                    msg \u003d \"No vimConnectionInfo to create glanceimage\""},{"line_number":229,"context_line":"                    LOG.exception(msg)"},{"line_number":230,"context_line":"                    raise sol_ex.LocalNfvoGrantFailed(sol_detail\u003dmsg)"},{"line_number":231,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"e2dd7e0a_6ecb5330","line":228,"range":{"start_line":228,"start_character":30,"end_line":228,"end_character":47},"in_reply_to":"bca66e91_09efb60c","updated":"2022-02-25 08:55:50.000000000","message":"Done.","commit_id":"39d55e7bc53ea71c7f02c54bc7a828c7edc84634"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f90da2ac294106437ef75fba0792defb8067d692","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        vnfd \u003d self.get_vnfd(context, grant_req.vnfdId)"},{"line_number":223,"context_line":"        sw_image_data \u003d vnfd.get_sw_image_data(grant_req.flavourId)"},{"line_number":224,"context_line":"        vim_sw_images \u003d []"},{"line_number":225,"context_line":"        for res_id, sw_data in sw_image_data.items():"},{"line_number":226,"context_line":"            if \u0027file\u0027 in sw_data:"},{"line_number":227,"context_line":"                vim_info \u003d self._get_vim_info(context, grant_req)"},{"line_number":228,"context_line":"                if vim_info is None:"}],"source_content_type":"text/x-python","patch_set":23,"id":"6e97522e_fd2511d5","line":225,"updated":"2022-03-15 08:10:51.000000000","message":"When we performed the same operation as the \"test_change_vnfpkg_from_volume_to_volume\" in \"tacker/tests/functional/sol_v2/test_change_vnfpkg.py\" locally, we found an event that seems to be a bug.\nGlance-image of \"VirtualStorage-VDU1-image\" is generated after change_vnfpkg even though only \"VDU2\" is specified in additionalParams -\u003e vdu_params -\u003e vduId on the request body of change_vnfpkg.\nIMO, the cause is that this process scans all \"sw_image_data\" contained in VNFD, including vduId that is not specified.\nCould you check it?","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ec0aa5b01a00bb834e677d90b8e1013ebc2ef7d0","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        vnfd \u003d self.get_vnfd(context, grant_req.vnfdId)"},{"line_number":223,"context_line":"        sw_image_data \u003d vnfd.get_sw_image_data(grant_req.flavourId)"},{"line_number":224,"context_line":"        vim_sw_images \u003d []"},{"line_number":225,"context_line":"        for res_id, sw_data in sw_image_data.items():"},{"line_number":226,"context_line":"            if \u0027file\u0027 in sw_data:"},{"line_number":227,"context_line":"                vim_info \u003d self._get_vim_info(context, grant_req)"},{"line_number":228,"context_line":"                if vim_info is None:"}],"source_content_type":"text/x-python","patch_set":23,"id":"07c90492_d5b333cf","line":225,"in_reply_to":"14cd64e3_702ed784","updated":"2022-03-16 07:42:47.000000000","message":"Done","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        vnfd \u003d self.get_vnfd(context, grant_req.vnfdId)"},{"line_number":223,"context_line":"        sw_image_data \u003d vnfd.get_sw_image_data(grant_req.flavourId)"},{"line_number":224,"context_line":"        vim_sw_images \u003d []"},{"line_number":225,"context_line":"        for res_id, sw_data in sw_image_data.items():"},{"line_number":226,"context_line":"            if \u0027file\u0027 in sw_data:"},{"line_number":227,"context_line":"                vim_info \u003d self._get_vim_info(context, grant_req)"},{"line_number":228,"context_line":"                if vim_info is None:"}],"source_content_type":"text/x-python","patch_set":23,"id":"14cd64e3_702ed784","line":225,"in_reply_to":"6e97522e_fd2511d5","updated":"2022-03-16 01:17:28.000000000","message":"I added this filter in PS24.","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"}],"tacker/sol_refactored/objects/v2/change_current_vnf_pkg_request.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d8453e99aa812d3c68496a9803a00e7ea4b24194","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        # NOTE: \u0027extVirtualLinks\u0027 is not supported. It can be specified but"},{"line_number":32,"context_line":"        # make no effect at all."},{"line_number":33,"context_line":"        \u0027extVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        # NOTE: \u0027extManagedVirtualLinks\u0027 is not supported."}],"source_content_type":"text/x-python","patch_set":10,"id":"e56f47a5_00d0500f","line":32,"updated":"2022-03-07 06:32:56.000000000","message":"As with the others, it is better to start a new line as follows.\n-----\n        # NOTE: \u0027extVirtualLinks\u0027 is not supported.\n        # It can be specified but make no effect at all.\n-----","commit_id":"8ee0d93baafd03d705f8927d74789916b9b8f84b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a3aafaabfd8b2a35a0237b770239a27daee829ba","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        # NOTE: \u0027extVirtualLinks\u0027 is not supported. It can be specified but"},{"line_number":32,"context_line":"        # make no effect at all."},{"line_number":33,"context_line":"        \u0027extVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        # NOTE: \u0027extManagedVirtualLinks\u0027 is not supported."}],"source_content_type":"text/x-python","patch_set":10,"id":"860e7ebd_0039e6e7","line":32,"in_reply_to":"617c2f95_70e5d286","updated":"2022-03-08 06:17:00.000000000","message":"Done","commit_id":"8ee0d93baafd03d705f8927d74789916b9b8f84b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1cb2ef2611178e0676dcc581e99ee1b6b72d4063","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        # NOTE: \u0027extVirtualLinks\u0027 is not supported. It can be specified but"},{"line_number":32,"context_line":"        # make no effect at all."},{"line_number":33,"context_line":"        \u0027extVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        # NOTE: \u0027extManagedVirtualLinks\u0027 is not supported."}],"source_content_type":"text/x-python","patch_set":10,"id":"617c2f95_70e5d286","line":32,"in_reply_to":"e56f47a5_00d0500f","updated":"2022-03-08 04:46:12.000000000","message":"I fixed it in PS12.","commit_id":"8ee0d93baafd03d705f8927d74789916b9b8f84b"}],"tacker/sol_refactored/test-tools/cli.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":126,"context_line":"    print(\"  inst inst {id} body(path of content)\")"},{"line_number":127,"context_line":"    print(\"  inst term {id} body(path of content)\")"},{"line_number":128,"context_line":"    print(\"  inst scale {id} body(path of content)\")"},{"line_number":129,"context_line":"    print(\"  subsc create body(path of content)\")"},{"line_number":130,"context_line":"    print(\"  subsc list [body(path of content)]\")"},{"line_number":131,"context_line":"    print(\"  subsc show {id}\")"},{"line_number":132,"context_line":"    print(\"  subsc delete {id}\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3298f7cc_b46c0e08","line":129,"updated":"2022-02-04 10:16:37.000000000","message":"You need to add a definition for change_vnfpkg.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":true,"context_lines":[{"line_number":126,"context_line":"    print(\"  inst inst {id} body(path of content)\")"},{"line_number":127,"context_line":"    print(\"  inst term {id} body(path of content)\")"},{"line_number":128,"context_line":"    print(\"  inst scale {id} body(path of content)\")"},{"line_number":129,"context_line":"    print(\"  subsc create body(path of content)\")"},{"line_number":130,"context_line":"    print(\"  subsc list [body(path of content)]\")"},{"line_number":131,"context_line":"    print(\"  subsc show {id}\")"},{"line_number":132,"context_line":"    print(\"  subsc delete {id}\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"49e0607c_47377e75","line":129,"in_reply_to":"1dd9577a_0de54a93","updated":"2022-02-25 00:57:54.000000000","message":"You would be better to modify \"change_vnfpkg\" instead of \"change vnfpkg\".","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":126,"context_line":"    print(\"  inst inst {id} body(path of content)\")"},{"line_number":127,"context_line":"    print(\"  inst term {id} body(path of content)\")"},{"line_number":128,"context_line":"    print(\"  inst scale {id} body(path of content)\")"},{"line_number":129,"context_line":"    print(\"  subsc create body(path of content)\")"},{"line_number":130,"context_line":"    print(\"  subsc list [body(path of content)]\")"},{"line_number":131,"context_line":"    print(\"  subsc show {id}\")"},{"line_number":132,"context_line":"    print(\"  subsc delete {id}\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1dd9577a_0de54a93","line":129,"in_reply_to":"3298f7cc_b46c0e08","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9651dff6b1bf75dfeb1bf0c59326784aa844a1d","unresolved":true,"context_lines":[{"line_number":126,"context_line":"    print(\"  inst inst {id} body(path of content)\")"},{"line_number":127,"context_line":"    print(\"  inst term {id} body(path of content)\")"},{"line_number":128,"context_line":"    print(\"  inst scale {id} body(path of content)\")"},{"line_number":129,"context_line":"    print(\"  subsc create body(path of content)\")"},{"line_number":130,"context_line":"    print(\"  subsc list [body(path of content)]\")"},{"line_number":131,"context_line":"    print(\"  subsc show {id}\")"},{"line_number":132,"context_line":"    print(\"  subsc delete {id}\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"537d7b41_47ef83b7","line":129,"in_reply_to":"49e0607c_47377e75","updated":"2022-02-26 13:51:02.000000000","message":"I fixed it in PS5.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fea414f720138e91b0f120174db675304ab81738","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    print(\"  inst inst {id} body(path of content)\")"},{"line_number":127,"context_line":"    print(\"  inst term {id} body(path of content)\")"},{"line_number":128,"context_line":"    print(\"  inst scale {id} body(path of content)\")"},{"line_number":129,"context_line":"    print(\"  subsc create body(path of content)\")"},{"line_number":130,"context_line":"    print(\"  subsc list [body(path of content)]\")"},{"line_number":131,"context_line":"    print(\"  subsc show {id}\")"},{"line_number":132,"context_line":"    print(\"  subsc delete {id}\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"3063d079_88710afa","line":129,"in_reply_to":"537d7b41_47ef83b7","updated":"2022-02-28 09:05:30.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":198,"context_line":"        if len(sys.argv) !\u003d 5:"},{"line_number":199,"context_line":"            usage()"},{"line_number":200,"context_line":"        client.scale(sys.argv[3], get_body(sys.argv[4]))"},{"line_number":201,"context_line":"    elif action \u003d\u003d \"retry\":"},{"line_number":202,"context_line":"        if len(sys.argv) !\u003d 4:"},{"line_number":203,"context_line":"            usage()"},{"line_number":204,"context_line":"        client.retry(sys.argv[3])"}],"source_content_type":"text/x-python","patch_set":3,"id":"a7a87cca_f71811cf","line":201,"updated":"2022-02-04 10:16:37.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        if len(sys.argv) !\u003d 5:"},{"line_number":199,"context_line":"            usage()"},{"line_number":200,"context_line":"        client.scale(sys.argv[3], get_body(sys.argv[4]))"},{"line_number":201,"context_line":"    elif action \u003d\u003d \"retry\":"},{"line_number":202,"context_line":"        if len(sys.argv) !\u003d 4:"},{"line_number":203,"context_line":"            usage()"},{"line_number":204,"context_line":"        client.retry(sys.argv[3])"}],"source_content_type":"text/x-python","patch_set":3,"id":"cce6ff27_3ad91b92","line":201,"in_reply_to":"4fb23f70_605a07e8","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":198,"context_line":"        if len(sys.argv) !\u003d 5:"},{"line_number":199,"context_line":"            usage()"},{"line_number":200,"context_line":"        client.scale(sys.argv[3], get_body(sys.argv[4]))"},{"line_number":201,"context_line":"    elif action \u003d\u003d \"retry\":"},{"line_number":202,"context_line":"        if len(sys.argv) !\u003d 4:"},{"line_number":203,"context_line":"            usage()"},{"line_number":204,"context_line":"        client.retry(sys.argv[3])"}],"source_content_type":"text/x-python","patch_set":3,"id":"4fb23f70_605a07e8","line":201,"in_reply_to":"a7a87cca_f71811cf","updated":"2022-02-22 07:39:01.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"}],"tacker/tests/functional/sol_v2/base_v2.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                                                 service_type\u003d\u0027compute\u0027)"},{"line_number":72,"context_line":"        cls.heat_client \u003d heat_utils.HeatClient(vim_info)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        cls.cinder_client \u003d cinder_utils.CinderClient(vim_info)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @classmethod"},{"line_number":77,"context_line":"    def get_vim_info(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"f5357728_4de10d2d","line":74,"updated":"2022-02-04 10:16:37.000000000","message":"Is it possible to modify the following like neutron/glance/nova?\n```\n         cls.cinder_client \u003d http_client.HttpClient (auth,\n                                                     service_type \u003d\u0027block-storage\u0027)\n```","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                                 service_type\u003d\u0027compute\u0027)"},{"line_number":72,"context_line":"        cls.heat_client \u003d heat_utils.HeatClient(vim_info)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        cls.cinder_client \u003d cinder_utils.CinderClient(vim_info)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @classmethod"},{"line_number":77,"context_line":"    def get_vim_info(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"76fffcb0_e1f2bdb2","line":74,"in_reply_to":"cfc8037d_90f507cd","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                                                 service_type\u003d\u0027compute\u0027)"},{"line_number":72,"context_line":"        cls.heat_client \u003d heat_utils.HeatClient(vim_info)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        cls.cinder_client \u003d cinder_utils.CinderClient(vim_info)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @classmethod"},{"line_number":77,"context_line":"    def get_vim_info(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"cfc8037d_90f507cd","line":74,"in_reply_to":"f5357728_4de10d2d","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"}],"tacker/tests/functional/sol_v2/paramgen.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d7e99bcd873d7c4b116b5fb43a8e7ebb0f862afa","unresolved":true,"context_lines":[{"line_number":866,"context_line":"                            \"ipOverEthernet\": {"},{"line_number":867,"context_line":"                                \"ipAddresses\": [{"},{"line_number":868,"context_line":"                                    \"type\": \"IPV4\","},{"line_number":869,"context_line":"                                    \"fixedAddresses\": [\"10.10.0.101\"]}]}}]}"},{"line_number":870,"context_line":"                }"},{"line_number":871,"context_line":"            }"},{"line_number":872,"context_line":"        ],"}],"source_content_type":"text/x-python","patch_set":22,"id":"523a73dd_5824b60a","line":869,"updated":"2022-03-14 04:59:13.000000000","message":"When I checked the operation in the local environment, the fixed IP address setting for \"VDU2_CP1\" was not working properly.\nI think this is because the definition for setting a fixed IP address is missing in the following BaseHOT.\n---\nhttps://review.opendev.org/c/openstack/tacker/+/826249/22/tacker/tests/functional/sol_v2/samples/test_instantiate_vnf_with_old_image_or_volume/contents/BaseHOT/simple/base_hot_top.yaml#49\n\nCould you refer to the existing VNF Package below?\n---\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2/samples/basic_lcms_max/contents/BaseHOT/simple/sample1.yaml#L69","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ec0aa5b01a00bb834e677d90b8e1013ebc2ef7d0","unresolved":false,"context_lines":[{"line_number":866,"context_line":"                            \"ipOverEthernet\": {"},{"line_number":867,"context_line":"                                \"ipAddresses\": [{"},{"line_number":868,"context_line":"                                    \"type\": \"IPV4\","},{"line_number":869,"context_line":"                                    \"fixedAddresses\": [\"10.10.0.101\"]}]}}]}"},{"line_number":870,"context_line":"                }"},{"line_number":871,"context_line":"            }"},{"line_number":872,"context_line":"        ],"}],"source_content_type":"text/x-python","patch_set":22,"id":"f85bef38_3eb1ecfa","line":869,"in_reply_to":"011372b6_ccf4733d","updated":"2022-03-16 07:42:47.000000000","message":"Done","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":866,"context_line":"                            \"ipOverEthernet\": {"},{"line_number":867,"context_line":"                                \"ipAddresses\": [{"},{"line_number":868,"context_line":"                                    \"type\": \"IPV4\","},{"line_number":869,"context_line":"                                    \"fixedAddresses\": [\"10.10.0.101\"]}]}}]}"},{"line_number":870,"context_line":"                }"},{"line_number":871,"context_line":"            }"},{"line_number":872,"context_line":"        ],"}],"source_content_type":"text/x-python","patch_set":22,"id":"011372b6_ccf4733d","line":869,"in_reply_to":"523a73dd_5824b60a","updated":"2022-03-16 01:17:28.000000000","message":"I fixed it in PS24.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_image/contents/BaseHOT/simple/base_hot_top.yaml":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2013-05-23"},{"line_number":2,"context_line":"description: \u0027Simple Base HOT for Sample VNF\u0027"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"parameters:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"24bfd3d3_3321291a","line":1,"updated":"2022-02-04 10:16:37.000000000","message":"The newly added VNF Packages do not have \"pkggen.py\" supported by the existing sample1/sample2.\nDo you have any plans to add it?\n---\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2/samples/sample1/pkggen.py\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2/samples/sample2/pkggen.py","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2013-05-23"},{"line_number":2,"context_line":"description: \u0027Simple Base HOT for Sample VNF\u0027"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"parameters:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"56fbba3f_efef6d36","line":1,"in_reply_to":"144ef9d5_ef0a9346","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"heat_template_version: 2013-05-23"},{"line_number":2,"context_line":"description: \u0027Simple Base HOT for Sample VNF\u0027"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"parameters:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"144ef9d5_ef0a9346","line":1,"in_reply_to":"24bfd3d3_3321291a","updated":"2022-02-22 07:39:01.000000000","message":"I added it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"79144d99110607c90f745b39157d1d8e97d0ffa2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"cd877245_f32bddaf","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"updated":"2022-03-11 06:35:04.000000000","message":"I think you need to set up the following to be able to scale.\n```\ndesired_capacity: { get_param: [ nfv, VDU, VDU1, desired_capacity ] }\n```\nPlease refer to [1]\n\n[1] https://github.com/openstack/tacker/blob/master/tacker/tests/functional/sol_v2/samples/basic_lcms_min/contents/BaseHOT/simple/sample2.yaml#L14","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"36b087c5732f4cbaf19f199955e73d647f3af9a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"aecd7e26_0acd014e","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"add017b3_af568369","updated":"2022-03-14 00:14:00.000000000","message":"I have confirmed it.","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"fde2a69e36770f022b398f11bb90b43b5439eae0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"add017b3_af568369","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"cd877245_f32bddaf","updated":"2022-03-11 07:43:50.000000000","message":"I fixed it in PS20.","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_image/contents/BaseHOT/volume/base_hot_top.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"79144d99110607c90f745b39157d1d8e97d0ffa2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5328c5ba_069b995f","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"updated":"2022-03-11 06:35:04.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"fde2a69e36770f022b398f11bb90b43b5439eae0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"557e3908_a217d22b","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"5328c5ba_069b995f","updated":"2022-03-11 07:43:50.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"36b087c5732f4cbaf19f199955e73d647f3af9a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"59a627b7_4ae9b3c1","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"557e3908_a217d22b","updated":"2022-03-14 00:14:00.000000000","message":"I have confirmed it.","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_image/contents/BaseHOT/volume/nested/base_hot_nested_VDU1.yaml":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2963dc7c4f3a5de2d1248130fb4f52ccf58d16aa","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    properties:"},{"line_number":26,"context_line":"      network: { get_param: net1 }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VirtualStorage-VDU1:"},{"line_number":29,"context_line":"    type: OS::Cinder::Volume"},{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      image: { get_param: image }"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ad21d0a5_01eb08b6","line":28,"updated":"2022-03-15 02:30:19.000000000","message":"NITS.`VDU1-VirtualStorage` is better for consistency with other sample.\n\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2/samples/basic_lcms_max/contents/BaseHOT/simple/sample1.yaml#L51","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2963dc7c4f3a5de2d1248130fb4f52ccf58d16aa","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    properties:"},{"line_number":26,"context_line":"      network: { get_param: net1 }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VirtualStorage-VDU1:"},{"line_number":29,"context_line":"    type: OS::Cinder::Volume"},{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      image: { get_param: image }"},{"line_number":32,"context_line":"      size: 4"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7458bcdc_4879fc61","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":13},"updated":"2022-03-15 02:30:19.000000000","message":"For heal operation, type: OS::Cinder::VolumeType needs to be specified as below.\n\n```\n   type: OS::Cinder::VolumeType\n    properties:\n      name: VDU1-multi\n      metadata: { multiattach: \"\u003cis\u003e True\" }\n```\n\nIf these are not exist, update stack in heal operation will fail.\nSince this patch does not include such a test scenario, they are not necessary. However, I think adding these parameters to BaseHOT is better for consistency with other samples and future expansion.\nWould you please add them in BaseHOT?\n\nFollowing existing sample will be helpful.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2/samples/basic_lcms_max/contents/BaseHOT/simple/sample1.yaml#L61","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"465fa23228bcb3d0fefd0962d383f53f2ecce120","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    properties:"},{"line_number":26,"context_line":"      network: { get_param: net1 }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VirtualStorage-VDU1:"},{"line_number":29,"context_line":"    type: OS::Cinder::Volume"},{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      image: { get_param: image }"},{"line_number":32,"context_line":"      size: 4"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"aba75f05_e200261b","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":13},"in_reply_to":"466094f9_8c364323","updated":"2022-03-16 08:36:22.000000000","message":"Done","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    properties:"},{"line_number":26,"context_line":"      network: { get_param: net1 }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VirtualStorage-VDU1:"},{"line_number":29,"context_line":"    type: OS::Cinder::Volume"},{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      image: { get_param: image }"},{"line_number":32,"context_line":"      size: 4"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"466094f9_8c364323","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":13},"in_reply_to":"7458bcdc_4879fc61","updated":"2022-03-16 01:17:28.000000000","message":"I added this resources to vnfpackage in PS24.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"832214af0bc9607ae7eb2161dc5344242d657367","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  multi:"},{"line_number":35,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      name: VDU1-multi"},{"line_number":38,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"a137ad51_4e817326","line":37,"updated":"2022-03-17 02:52:06.000000000","message":"If the VolumeType name is not set as follows, the scale operation will fail.\n-----\n     name: { get_resource: VDU1_CP1 }\n-----\n\nSince this patch does not include such a test scenario, they are not necessary. However, I think adding these parameters to BaseHOT is better for consistency with other samples and future expansion.\nWould you please add it to BaseHOT if possible? (I don\u0027t think there is any problem even if it is left as it is.)","commit_id":"645e94b60289e56d4ed06239af26fc865d9b1e18"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fb85f7151b6bf1f1c97649e7277cf462dc59d2be","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  multi:"},{"line_number":35,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      name: VDU1-multi"},{"line_number":38,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"d71e08c1_5b673171","line":37,"in_reply_to":"91d5994f_ae1a1270","updated":"2022-03-17 07:16:17.000000000","message":"Done","commit_id":"645e94b60289e56d4ed06239af26fc865d9b1e18"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bd855b08feff7a841e9bb15f171b521264af6d29","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  multi:"},{"line_number":35,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      name: VDU1-multi"},{"line_number":38,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"91d5994f_ae1a1270","line":37,"in_reply_to":"a137ad51_4e817326","updated":"2022-03-17 04:39:13.000000000","message":"I fixed it in PS26.","commit_id":"645e94b60289e56d4ed06239af26fc865d9b1e18"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_image/contents/Definitions/etsi_nfv_sol001_common_types.yaml":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  template_name: etsi_nfv_sol001_common_types"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b20651d1_479c1abc","line":1,"updated":"2022-02-04 10:16:37.000000000","message":"I think that multiple ETSI VNFD definition files(etsi_nfv_sol001_common_types.yaml/etsi_nfv_sol001_vnfd_types.yaml), including this file, will be placed in exactly the same way.\nI don\u0027t think this is desirable for two reasons:\n* Patch size increases\n* Tacker repository size increases when merged\nIs it possible to commonize these like V1-FT package?\n---\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/etc/samples/etsi/nfv/common","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  template_name: etsi_nfv_sol001_common_types"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f38d5db_0dd9e375","line":1,"in_reply_to":"8bbbfe4b_bb436128","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  template_name: etsi_nfv_sol001_common_types"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8bbbfe4b_bb436128","line":1,"in_reply_to":"b20651d1_479c1abc","updated":"2022-02-22 07:39:01.000000000","message":"I moved them into common files in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_image/contents/Scripts/coordinate_new_vnf.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a1d79a1_c046ec4e","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?\nAnd could you change year to 2022?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"c3529e96_35312b18","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"in_reply_to":"09a631e1_865db2b3","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"09a631e1_865db2b3","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"in_reply_to":"3a1d79a1_c046ec4e","updated":"2022-03-04 09:10:19.000000000","message":"I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_image/pkggen.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"4441388a_ddf353c5","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"faef4493_50617f00","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"4441388a_ddf353c5","updated":"2022-03-04 09:10:19.000000000","message":"I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"f2dd19fe_b35a1f8c","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"faef4493_50617f00","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3c29ae26_5ef3a0c0","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"updated":"2022-03-02 08:37:42.000000000","message":"What is this comment? Could you delete it if it is not needed.\nAnd I think sampleX folder will rename in the patch below.\nhttps://review.opendev.org/c/openstack/tacker/+/826819","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ea15c5a_175a5b9f","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"in_reply_to":"3c29ae26_5ef3a0c0","updated":"2022-03-04 09:10:19.000000000","message":"I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"f149ab00_52cac4b3","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"in_reply_to":"3ea15c5a_175a5b9f","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_volume/contents/BaseHOT/simple/base_hot_top.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"79144d99110607c90f745b39157d1d8e97d0ffa2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3d1878b7_254e52b5","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"updated":"2022-03-11 06:35:04.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"fde2a69e36770f022b398f11bb90b43b5439eae0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"e6592184_de4adfec","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"3d1878b7_254e52b5","updated":"2022-03-11 07:43:50.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"36b087c5732f4cbaf19f199955e73d647f3af9a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"a6f77b2e_7cad16f0","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"e6592184_de4adfec","updated":"2022-03-14 00:14:00.000000000","message":"I have confirmed it.","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2963dc7c4f3a5de2d1248130fb4f52ccf58d16aa","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: [ nfv, CP, VDU2_CP1, network ]  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  VirtualStorage-VDU2:"},{"line_number":52,"context_line":"    type: OS::Cinder::Volume"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      image: { get_param: [ nfv, VDU, VirtualStorage-VDU2, vcImageId ] }"},{"line_number":55,"context_line":"      size: 4"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs: {}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"91bec039_f86ce48b","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":13},"updated":"2022-03-15 02:30:19.000000000","message":"ditto.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: [ nfv, CP, VDU2_CP1, network ]  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  VirtualStorage-VDU2:"},{"line_number":52,"context_line":"    type: OS::Cinder::Volume"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      image: { get_param: [ nfv, VDU, VirtualStorage-VDU2, vcImageId ] }"},{"line_number":55,"context_line":"      size: 4"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs: {}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"e679b044_ea8972db","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":13},"in_reply_to":"91bec039_f86ce48b","updated":"2022-03-16 01:17:28.000000000","message":"ditto","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"465fa23228bcb3d0fefd0962d383f53f2ecce120","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: [ nfv, CP, VDU2_CP1, network ]  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  VirtualStorage-VDU2:"},{"line_number":52,"context_line":"    type: OS::Cinder::Volume"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      image: { get_param: [ nfv, VDU, VirtualStorage-VDU2, vcImageId ] }"},{"line_number":55,"context_line":"      size: 4"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs: {}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"517bfb8d_f405e0aa","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":13},"in_reply_to":"e679b044_ea8972db","updated":"2022-03-16 08:36:22.000000000","message":"Done","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_volume/contents/BaseHOT/volume/base_hot_top.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"79144d99110607c90f745b39157d1d8e97d0ffa2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"91f803b4_10fddc0b","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"updated":"2022-03-11 06:35:04.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"fde2a69e36770f022b398f11bb90b43b5439eae0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"f29d16fd_1e6c3c03","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"91f803b4_10fddc0b","updated":"2022-03-11 07:43:50.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"36b087c5732f4cbaf19f199955e73d647f3af9a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"e9b68a07_aebbef07","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"f29d16fd_1e6c3c03","updated":"2022-03-14 00:14:00.000000000","message":"I have confirmed it.","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2963dc7c4f3a5de2d1248130fb4f52ccf58d16aa","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: [ nfv, CP, VDU2_CP1, network ]  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  VirtualStorage-VDU2:"},{"line_number":52,"context_line":"    type: OS::Cinder::Volume"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      image: { get_param: [ nfv, VDU, VirtualStorage-VDU2, vcImageId ] }"},{"line_number":55,"context_line":"      size: 4"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs: {}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"f0f8836f_8151607a","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":13},"updated":"2022-03-15 02:30:19.000000000","message":"ditto.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"465fa23228bcb3d0fefd0962d383f53f2ecce120","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: [ nfv, CP, VDU2_CP1, network ]  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  VirtualStorage-VDU2:"},{"line_number":52,"context_line":"    type: OS::Cinder::Volume"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      image: { get_param: [ nfv, VDU, VirtualStorage-VDU2, vcImageId ] }"},{"line_number":55,"context_line":"      size: 4"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs: {}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"0eb77feb_3b4d2497","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":13},"in_reply_to":"c7eeec31_df813a8a","updated":"2022-03-16 08:36:22.000000000","message":"Done","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: [ nfv, CP, VDU2_CP1, network ]  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  VirtualStorage-VDU2:"},{"line_number":52,"context_line":"    type: OS::Cinder::Volume"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      image: { get_param: [ nfv, VDU, VirtualStorage-VDU2, vcImageId ] }"},{"line_number":55,"context_line":"      size: 4"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs: {}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"c7eeec31_df813a8a","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":13},"in_reply_to":"f0f8836f_8151607a","updated":"2022-03-16 01:17:28.000000000","message":"ditto","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_volume/contents/BaseHOT/volume/nested/base_hot_nested_VDU1.yaml":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2963dc7c4f3a5de2d1248130fb4f52ccf58d16aa","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    properties:"},{"line_number":26,"context_line":"      network: { get_param: net1 }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VirtualStorage-VDU1:"},{"line_number":29,"context_line":"    type: OS::Cinder::Volume"},{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      image: { get_param: image }"},{"line_number":32,"context_line":"      size: 4"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"46c432db_58ea3023","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":13},"updated":"2022-03-15 02:30:19.000000000","message":"ditto.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"465fa23228bcb3d0fefd0962d383f53f2ecce120","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    properties:"},{"line_number":26,"context_line":"      network: { get_param: net1 }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VirtualStorage-VDU1:"},{"line_number":29,"context_line":"    type: OS::Cinder::Volume"},{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      image: { get_param: image }"},{"line_number":32,"context_line":"      size: 4"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"670f537e_c536331a","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":13},"in_reply_to":"43ed71ba_9fa1f26d","updated":"2022-03-16 08:36:22.000000000","message":"Done","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    properties:"},{"line_number":26,"context_line":"      network: { get_param: net1 }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VirtualStorage-VDU1:"},{"line_number":29,"context_line":"    type: OS::Cinder::Volume"},{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      image: { get_param: image }"},{"line_number":32,"context_line":"      size: 4"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"43ed71ba_9fa1f26d","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":13},"in_reply_to":"46c432db_58ea3023","updated":"2022-03-16 01:17:28.000000000","message":"ditto","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"832214af0bc9607ae7eb2161dc5344242d657367","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  multi:"},{"line_number":35,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      name: VDU1-multi"},{"line_number":38,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"f40e4bff_f763f1ae","line":37,"updated":"2022-03-17 02:52:06.000000000","message":"ditto","commit_id":"645e94b60289e56d4ed06239af26fc865d9b1e18"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fb85f7151b6bf1f1c97649e7277cf462dc59d2be","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  multi:"},{"line_number":35,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      name: VDU1-multi"},{"line_number":38,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"a7922aca_441ae144","line":37,"in_reply_to":"1ea689ff_38a2a9b6","updated":"2022-03-17 07:16:17.000000000","message":"Done","commit_id":"645e94b60289e56d4ed06239af26fc865d9b1e18"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bd855b08feff7a841e9bb15f171b521264af6d29","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  multi:"},{"line_number":35,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      name: VDU1-multi"},{"line_number":38,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"1ea689ff_38a2a9b6","line":37,"in_reply_to":"f40e4bff_f763f1ae","updated":"2022-03-17 04:39:13.000000000","message":"I fixed it in PS26.","commit_id":"645e94b60289e56d4ed06239af26fc865d9b1e18"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_volume/contents/Scripts/coordinate_new_vnf.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"a8759924_5737d2da","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?\nAnd could you change year to 2022?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"20961fe9_a17c6faf","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"in_reply_to":"a63c6a01_e6c878fa","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"a63c6a01_e6c878fa","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"in_reply_to":"a8759924_5737d2da","updated":"2022-03-04 09:10:19.000000000","message":"I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_volume/contents/Scripts/error_coordinate_new_vnf.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"65e1c499_1712c8ed","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?\nAnd could you change year to 2022?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"76828a8a_067581c3","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"in_reply_to":"65e1c499_1712c8ed","updated":"2022-03-04 09:10:19.000000000","message":"ditto","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"8f4a718b_93c5602b","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"in_reply_to":"76828a8a_067581c3","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_volume/pkggen.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"3852dbf5_3935b23b","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"61e91422_f2731e10","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"3852dbf5_3935b23b","updated":"2022-03-04 09:10:19.000000000","message":"ditto","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"35121c27_61f86441","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"61e91422_f2731e10","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"8c637f67_3de74c0a","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"updated":"2022-03-02 08:37:42.000000000","message":"What is this comment? Could you delete it if it is not needed.\nAnd I think sampleX folder will rename in the patch below.\nhttps://review.opendev.org/c/openstack/tacker/+/826819","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfab3e51_56e4a169","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"in_reply_to":"826964cd_588de1f6","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"826964cd_588de1f6","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"in_reply_to":"8c637f67_3de74c0a","updated":"2022-03-04 09:10:19.000000000","message":"I deleted it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_update_failed/contents/BaseHOT/simple/base_hot_top.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"79144d99110607c90f745b39157d1d8e97d0ffa2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1c48a64a_0424937a","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"updated":"2022-03-11 06:35:04.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"fde2a69e36770f022b398f11bb90b43b5439eae0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"e6a2c08b_b1405dad","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"1c48a64a_0424937a","updated":"2022-03-11 07:43:50.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"36b087c5732f4cbaf19f199955e73d647f3af9a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"a315733a_f6902c43","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"e6a2c08b_b1405dad","updated":"2022-03-14 00:14:00.000000000","message":"I have confirmed it.","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_update_failed/contents/Scripts/coordinate_new_vnf.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f1e87f0_72f8fb56","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?\nAnd could you change year to 2022?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"f670e958_03e499ba","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"in_reply_to":"5f1e87f0_72f8fb56","updated":"2022-03-04 09:10:19.000000000","message":"ditto","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"6f65b25a_709cb25d","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"in_reply_to":"f670e958_03e499ba","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"}],"tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_update_failed/pkggen.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"8f099752_5ca9f9f5","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"facdf6af_8c154e2c","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"56cb0a7e_dd637c97","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"56cb0a7e_dd637c97","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"8f099752_5ca9f9f5","updated":"2022-03-04 09:10:19.000000000","message":"ditto","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"4859115e_16ec4bc5","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"updated":"2022-03-02 08:37:42.000000000","message":"What is this comment? Could you delete it if it is not needed.\nAnd I think sampleX folder will rename in the patch below.\nhttps://review.opendev.org/c/openstack/tacker/+/826819","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ecea50b0_ec89a5bd","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"in_reply_to":"4859115e_16ec4bc5","updated":"2022-03-04 09:10:19.000000000","message":"ditto","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"cf3d1816_59ac94e4","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"in_reply_to":"ecea50b0_ec89a5bd","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"}],"tacker/tests/functional/sol_v2/samples/test_instantiate_vnf_with_old_image_or_volume/contents/BaseHOT/simple/base_hot_top.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"79144d99110607c90f745b39157d1d8e97d0ffa2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"57486d15_403ff937","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"updated":"2022-03-11 06:35:04.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"fde2a69e36770f022b398f11bb90b43b5439eae0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"d3a9217d_47bde8a3","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"57486d15_403ff937","updated":"2022-03-11 07:43:50.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"36b087c5732f4cbaf19f199955e73d647f3af9a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"0e566d64_2ab38ea8","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"d3a9217d_47bde8a3","updated":"2022-03-14 00:14:00.000000000","message":"I have confirmed it.","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"}],"tacker/tests/functional/sol_v2/samples/test_instantiate_vnf_with_old_image_or_volume/contents/BaseHOT/volume/base_hot_top.yaml":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"79144d99110607c90f745b39157d1d8e97d0ffa2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"c1de8201_7fe866b0","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"updated":"2022-03-11 06:35:04.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"36b087c5732f4cbaf19f199955e73d647f3af9a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"887b2e2f_2fc02d3c","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"2762cb04_f94f79ee","updated":"2022-03-14 00:14:00.000000000","message":"I have confirmed it.","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"fde2a69e36770f022b398f11bb90b43b5439eae0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"},{"line_number":13,"context_line":"      max_size: 3"},{"line_number":14,"context_line":"      desired_capacity: 2"},{"line_number":15,"context_line":"      resource:"},{"line_number":16,"context_line":"        type: base_hot_nested_VDU1.yaml"},{"line_number":17,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"2762cb04_f94f79ee","line":14,"range":{"start_line":14,"start_character":24,"end_line":14,"end_character":25},"in_reply_to":"c1de8201_7fe866b0","updated":"2022-03-11 07:43:50.000000000","message":"ditto","commit_id":"16020c1b337ca66752e068a9e6453b0cf5fdafb9"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2963dc7c4f3a5de2d1248130fb4f52ccf58d16aa","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: [ nfv, CP, VDU2_CP1, network ]  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  VirtualStorage-VDU2:"},{"line_number":52,"context_line":"    type: OS::Cinder::Volume"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      image: { get_param: [ nfv, VDU, VirtualStorage-VDU2, vcImageId ] }"},{"line_number":55,"context_line":"      size: 4"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs: {}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"e5b0b1c9_4e0b92f3","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":13},"updated":"2022-03-15 02:30:19.000000000","message":"ditto.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"465fa23228bcb3d0fefd0962d383f53f2ecce120","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: [ nfv, CP, VDU2_CP1, network ]  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  VirtualStorage-VDU2:"},{"line_number":52,"context_line":"    type: OS::Cinder::Volume"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      image: { get_param: [ nfv, VDU, VirtualStorage-VDU2, vcImageId ] }"},{"line_number":55,"context_line":"      size: 4"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs: {}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"554d8caa_3f8a55af","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":13},"in_reply_to":"1c72d345_3e39e282","updated":"2022-03-16 08:36:22.000000000","message":"Done","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: [ nfv, CP, VDU2_CP1, network ]  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  VirtualStorage-VDU2:"},{"line_number":52,"context_line":"    type: OS::Cinder::Volume"},{"line_number":53,"context_line":"    properties:"},{"line_number":54,"context_line":"      image: { get_param: [ nfv, VDU, VirtualStorage-VDU2, vcImageId ] }"},{"line_number":55,"context_line":"      size: 4"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"outputs: {}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1c72d345_3e39e282","line":55,"range":{"start_line":51,"start_character":0,"end_line":55,"end_character":13},"in_reply_to":"e5b0b1c9_4e0b92f3","updated":"2022-03-16 01:17:28.000000000","message":"ditto","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"}],"tacker/tests/functional/sol_v2/samples/test_instantiate_vnf_with_old_image_or_volume/contents/BaseHOT/volume/nested/base_hot_nested_VDU1.yaml":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"2963dc7c4f3a5de2d1248130fb4f52ccf58d16aa","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    properties:"},{"line_number":26,"context_line":"      network: { get_param: net1 }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VirtualStorage-VDU1:"},{"line_number":29,"context_line":"    type: OS::Cinder::Volume"},{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      image: { get_param: image }"},{"line_number":32,"context_line":"      size: 4"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"513b5b06_1e7b3683","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":13},"updated":"2022-03-15 02:30:19.000000000","message":"ditto.","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"465fa23228bcb3d0fefd0962d383f53f2ecce120","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    properties:"},{"line_number":26,"context_line":"      network: { get_param: net1 }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VirtualStorage-VDU1:"},{"line_number":29,"context_line":"    type: OS::Cinder::Volume"},{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      image: { get_param: image }"},{"line_number":32,"context_line":"      size: 4"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"02509418_7b530e47","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":13},"in_reply_to":"449b1ce0_dfc75e79","updated":"2022-03-16 08:36:22.000000000","message":"Done","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    properties:"},{"line_number":26,"context_line":"      network: { get_param: net1 }"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  VirtualStorage-VDU1:"},{"line_number":29,"context_line":"    type: OS::Cinder::Volume"},{"line_number":30,"context_line":"    properties:"},{"line_number":31,"context_line":"      image: { get_param: image }"},{"line_number":32,"context_line":"      size: 4"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"449b1ce0_dfc75e79","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":13},"in_reply_to":"513b5b06_1e7b3683","updated":"2022-03-16 01:17:28.000000000","message":"ditto","commit_id":"ab55063bcb1acb6ad9455df364756d2d38e3b3c6"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"832214af0bc9607ae7eb2161dc5344242d657367","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  multi:"},{"line_number":35,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      name: VDU1-multi"},{"line_number":38,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"ad70752b_245b1d81","line":37,"updated":"2022-03-17 02:52:06.000000000","message":"ditto","commit_id":"645e94b60289e56d4ed06239af26fc865d9b1e18"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fb85f7151b6bf1f1c97649e7277cf462dc59d2be","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  multi:"},{"line_number":35,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      name: VDU1-multi"},{"line_number":38,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"8829d30b_015cc59c","line":37,"in_reply_to":"7fc2bd6a_20d2d8f7","updated":"2022-03-17 07:16:17.000000000","message":"Done","commit_id":"645e94b60289e56d4ed06239af26fc865d9b1e18"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bd855b08feff7a841e9bb15f171b521264af6d29","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  multi:"},{"line_number":35,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      name: VDU1-multi"},{"line_number":38,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7fc2bd6a_20d2d8f7","line":37,"in_reply_to":"ad70752b_245b1d81","updated":"2022-03-17 04:39:13.000000000","message":"I fixed it in PS26.","commit_id":"645e94b60289e56d4ed06239af26fc865d9b1e18"}],"tacker/tests/functional/sol_v2/samples/test_instantiate_vnf_with_old_image_or_volume/contents/Scripts/coordinate_old_vnf.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"1cca65a8_9b0e42ac","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?\nAnd could you change year to 2022?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"d41602b0_2173ad45","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"1cca65a8_9b0e42ac","updated":"2022-03-04 09:10:19.000000000","message":"ditto","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"6bc42bdb_77295094","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"d41602b0_2173ad45","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"}],"tacker/tests/functional/sol_v2/samples/test_instantiate_vnf_with_old_image_or_volume/pkggen.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"b6c387de_5d9402ad","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?\nAnd could you change year to 2022?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"9c324f04_67be7809","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"in_reply_to":"4d8274c9_ebe49765","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"4d8274c9_ebe49765","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":63},"in_reply_to":"b6c387de_5d9402ad","updated":"2022-03-04 09:10:19.000000000","message":"ditto","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a3dc83e1_41ea84fd","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"updated":"2022-03-02 08:37:42.000000000","message":"What is this comment? Could you delete it if it is not needed.\nAnd I think sampleX folder will rename in the patch below.\nhttps://review.opendev.org/c/openstack/tacker/+/826819","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"087e89d4_fddc0e86","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"in_reply_to":"42dcb0a8_f247ec1f","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":28,"context_line":"tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"42dcb0a8_f247ec1f","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":48},"in_reply_to":"a3dc83e1_41ea84fd","updated":"2022-03-04 09:10:19.000000000","message":"ditto","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"36b087c5732f4cbaf19f199955e73d647f3af9a3","unresolved":true,"context_lines":[{"line_number":38,"context_line":"shutil.rmtree(tmp_dir)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"create_req \u003d paramgen.change_vnfpkg_create(vnfd_id)"},{"line_number":41,"context_line":"terminate_req \u003d paramgen.sample1_terminate()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"net_ids \u003d utils.get_network_ids([\u0027net0\u0027])"},{"line_number":44,"context_line":"subnet_ids \u003d utils.get_subnet_ids([\u0027subnet0\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"e938ac26_c8480eb0","line":41,"range":{"start_line":41,"start_character":25,"end_line":41,"end_character":42},"updated":"2022-03-14 00:14:00.000000000","message":"This parameter is not defined, because delete it in the patch [1].\n\n[1] https://review.opendev.org/c/openstack/tacker/+/829156/14/tacker/tests/functional/sol_v2/paramgen.py#b171","commit_id":"2e17968e65c26cd58489ab1489599459acae4024"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ddfd5c04bb15e41c45c8992c0b3f683a6c88c29a","unresolved":true,"context_lines":[{"line_number":38,"context_line":"shutil.rmtree(tmp_dir)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"create_req \u003d paramgen.change_vnfpkg_create(vnfd_id)"},{"line_number":41,"context_line":"terminate_req \u003d paramgen.sample1_terminate()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"net_ids \u003d utils.get_network_ids([\u0027net0\u0027])"},{"line_number":44,"context_line":"subnet_ids \u003d utils.get_subnet_ids([\u0027subnet0\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a6987f7_cb392de1","line":41,"range":{"start_line":41,"start_character":25,"end_line":41,"end_character":42},"in_reply_to":"e938ac26_c8480eb0","updated":"2022-03-14 00:34:21.000000000","message":"I fixed it in PS22","commit_id":"2e17968e65c26cd58489ab1489599459acae4024"}],"tacker/tests/functional/sol_v2/test_change_vnfpkg.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":120,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":121,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":122,"context_line":"        # TODO(oda-g): check body"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_2)"},{"line_number":125,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnfpkg_req)"}],"source_content_type":"text/x-python","patch_set":3,"id":"642207ff_6a0cfbbb","line":122,"updated":"2022-02-04 10:16:37.000000000","message":"The name on TODO doesn\u0027t seem to be your name(YiFeng).\nIn addition, is this TODO going to be fixed with this patch, that is, is this patch still WIP?","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":120,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":121,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":122,"context_line":"        # TODO(oda-g): check body"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_2)"},{"line_number":125,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnfpkg_req)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3c96921c_3fc5366c","line":122,"in_reply_to":"2531c5f6_8a78ab30","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":120,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":121,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":122,"context_line":"        # TODO(oda-g): check body"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_2)"},{"line_number":125,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnfpkg_req)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2531c5f6_8a78ab30","line":122,"in_reply_to":"642207ff_6a0cfbbb","updated":"2022-02-22 07:39:01.000000000","message":"I deleted it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            \u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027] if obj["},{"line_number":212,"context_line":"            \u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027][0]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        # TODO(oda-g): check body"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_3)"},{"line_number":217,"context_line":"        del change_vnfpkg_req[\u0027additionalParams\u0027][\u0027vdu_params\u0027][0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed353895_4d31808b","line":214,"updated":"2022-02-04 10:16:37.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            \u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027] if obj["},{"line_number":212,"context_line":"            \u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027][0]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        # TODO(oda-g): check body"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_3)"},{"line_number":217,"context_line":"        del change_vnfpkg_req[\u0027additionalParams\u0027][\u0027vdu_params\u0027][0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"df86c93d_10368942","line":214,"in_reply_to":"159b9626_fe9a9683","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":211,"context_line":"            \u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027] if obj["},{"line_number":212,"context_line":"            \u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027][0]"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        # TODO(oda-g): check body"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_3)"},{"line_number":217,"context_line":"        del change_vnfpkg_req[\u0027additionalParams\u0027][\u0027vdu_params\u0027][0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"159b9626_fe9a9683","line":214,"in_reply_to":"ed353895_4d31808b","updated":"2022-02-22 07:39:01.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":313,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":314,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":315,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":316,"context_line":"        # TODO(oda-g): check body"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_2)"},{"line_number":319,"context_line":"        del change_vnfpkg_req[\u0027additionalParams\u0027][\u0027vdu_params\u0027][0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"0f67d1a9_128b6180","line":316,"updated":"2022-02-04 10:16:37.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":313,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":314,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":315,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":316,"context_line":"        # TODO(oda-g): check body"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_2)"},{"line_number":319,"context_line":"        del change_vnfpkg_req[\u0027additionalParams\u0027][\u0027vdu_params\u0027][0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce873bcf_00a64f5d","line":316,"in_reply_to":"0f67d1a9_128b6180","updated":"2022-02-22 07:39:01.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":314,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":315,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":316,"context_line":"        # TODO(oda-g): check body"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_2)"},{"line_number":319,"context_line":"        del change_vnfpkg_req[\u0027additionalParams\u0027][\u0027vdu_params\u0027][0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"11f3501f_2a39f372","line":316,"in_reply_to":"ce873bcf_00a64f5d","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":415,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":416,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":417,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":418,"context_line":"        # TODO(oda-g): check body"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_3)"},{"line_number":421,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnfpkg_req)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b851d0c_81272cba","line":418,"updated":"2022-02-04 10:16:37.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":416,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":417,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":418,"context_line":"        # TODO(oda-g): check body"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_3)"},{"line_number":421,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnfpkg_req)"}],"source_content_type":"text/x-python","patch_set":3,"id":"afe452ed_02ca4f36","line":418,"in_reply_to":"0ca9cd96_71eae4dc","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":415,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":416,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":417,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":418,"context_line":"        # TODO(oda-g): check body"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_3)"},{"line_number":421,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnfpkg_req)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0ca9cd96_71eae4dc","line":418,"in_reply_to":"1b851d0c_81272cba","updated":"2022-02-22 07:39:01.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":505,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":506,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":507,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":508,"context_line":"        # TODO(oda-g): check body"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_4)"},{"line_number":511,"context_line":"        del change_vnfpkg_req[\u0027additionalParams\u0027][\u0027vdu_params\u0027][1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"34cd4b8e_16c3ba1d","line":508,"updated":"2022-02-04 10:16:37.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":505,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":506,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":507,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":508,"context_line":"        # TODO(oda-g): check body"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_4)"},{"line_number":511,"context_line":"        del change_vnfpkg_req[\u0027additionalParams\u0027][\u0027vdu_params\u0027][1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"e375d36c_0044747c","line":508,"in_reply_to":"34cd4b8e_16c3ba1d","updated":"2022-02-22 07:39:01.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":506,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":507,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":508,"context_line":"        # TODO(oda-g): check body"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_4)"},{"line_number":511,"context_line":"        del change_vnfpkg_req[\u0027additionalParams\u0027][\u0027vdu_params\u0027][1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3e366b53_95b1e94f","line":508,"in_reply_to":"e375d36c_0044747c","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":601,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":602,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":603,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":604,"context_line":"        # TODO(oda-g): check body"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_3)"},{"line_number":607,"context_line":"        change_vnfpkg_req[\u0027additionalParams\u0027]["}],"source_content_type":"text/x-python","patch_set":3,"id":"a82cc53f_398f4128","line":604,"updated":"2022-02-04 10:16:37.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":601,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":602,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":603,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":604,"context_line":"        # TODO(oda-g): check body"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_3)"},{"line_number":607,"context_line":"        change_vnfpkg_req[\u0027additionalParams\u0027]["}],"source_content_type":"text/x-python","patch_set":3,"id":"e5a52948_42cc715e","line":604,"in_reply_to":"a82cc53f_398f4128","updated":"2022-02-22 07:39:01.000000000","message":"ditto","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        self.assertEqual(200, resp_1.status_code)"},{"line_number":602,"context_line":"        self.check_resp_headers_in_get(resp_1)"},{"line_number":603,"context_line":"        self.check_resp_body(body_1, expected_inst_attrs)"},{"line_number":604,"context_line":"        # TODO(oda-g): check body"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        change_vnfpkg_req \u003d paramgen.change_vnfpkg(self.vnfd_id_3)"},{"line_number":607,"context_line":"        change_vnfpkg_req[\u0027additionalParams\u0027]["}],"source_content_type":"text/x-python","patch_set":3,"id":"04f1be25_d0dd5868","line":604,"in_reply_to":"e5a52948_42cc715e","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9d805761c782e3e76e563a0fe2638dcda14fe220","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"e6e42acb_c83b6dad","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"updated":"2022-03-02 08:37:42.000000000","message":"Your company is not NTT. Do you want to change it?","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b91a32feab675cc4a6633a64fdb9752ba344e6e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"af108adb_91b6e8cb","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"6b0b29b5_98a7b007","updated":"2022-03-04 15:08:26.000000000","message":"I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"6b0b29b5_98a7b007","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"e6e42acb_c83b6dad","updated":"2022-03-04 09:10:19.000000000","message":"I fixed it in PS9.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"394005168842a606fcf55a5c1ae1ca5e204fbefc","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    def tearDownClass(cls):"},{"line_number":61,"context_line":"        super(ChangeVnfPkgVnfLcmTest, cls).tearDownClass()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_1)"},{"line_number":64,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_2)"},{"line_number":65,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"},{"line_number":66,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_4)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a2e235a8_cab11782","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":45},"updated":"2022-03-02 04:30:07.000000000","message":"It seems that the delete of this VNF package failed. The VNF package status seems to be `IN_USE`, even though it removed the VNF Instance.I think this VNF Package should also be removed.\n\nRefer to log [1]. And, the following is an excerpt from the tacker log.\n```\nMar 02 02:28:34.125355 ubuntu-focal-rax-iad-0028663893 tacker-server[57539]: 2022-03-02 02:28:34.124 ERROR tacker.wsgi [req-b92f7750-54f3-490c-8eb8-e51a78835fe6 nfv_user nfv] HTTP exception thrown: VNF Package 551a00ac-e4de-492e-9a0b-afb14fb17c81 cannot be deleted as it\u0027s operational state is DISABLED and usage state is IN_USE.: webob.exc.HTTPConflict: VNF Package 551a00ac-e4de-492e-9a0b-afb14fb17c81 cannot be deleted as it\u0027s operational state is DISABLED and usage state is IN_USE.\n```\n\n[1] https://3326722d6e5508fe6bd5-fbdc3ec6aea3f3de76b6d1e5522e06ad.ssl.cf5.rackcdn.com/826249/7/check/tacker-functional-devstack-multinode-sol-v2/7979537/controller-tacker/logs/screen-tacker.txt","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a3aafaabfd8b2a35a0237b770239a27daee829ba","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    def tearDownClass(cls):"},{"line_number":61,"context_line":"        super(ChangeVnfPkgVnfLcmTest, cls).tearDownClass()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_1)"},{"line_number":64,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_2)"},{"line_number":65,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"},{"line_number":66,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_4)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ae162900_1ad17c20","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":45},"in_reply_to":"7c5fb082_ffad3f99","updated":"2022-03-08 06:17:00.000000000","message":"Thank you for fixing. I\u0027ve confirmed.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b9b2e05e2b257b146c5a450a70f8d69a236574a0","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    def tearDownClass(cls):"},{"line_number":61,"context_line":"        super(ChangeVnfPkgVnfLcmTest, cls).tearDownClass()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_1)"},{"line_number":64,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_2)"},{"line_number":65,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"},{"line_number":66,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_4)"}],"source_content_type":"text/x-python","patch_set":7,"id":"c350fcf2_8f1d439d","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":45},"in_reply_to":"a2e235a8_cab11782","updated":"2022-03-03 00:59:46.000000000","message":"Is such that. I also found this problem in the FT test of CNFRollingUpdate, and fixed it. Since the state update content of the VNF package is not written in the spec, the update is not considered.\nIn addition, I also found a problem in the test. In v1, one vnfdid can create multiple vnfinstances, so when setting the status of the package to `NOT_IN_USE`, it is necessary to first determine whether the vnfdid is still used by other vnfinstances , but there is no such judgment in the v2 code. When terminate or modify, the original package state is directly set to `NOT_IN_USE`. I think this is wrong. Do you agree with this point of view? I also made the correction in PS8.\nhttps://review.opendev.org/c/openstack/tacker/+/826249/7..8/tacker/sol_refactored/nfvo/local_nfvo.py#294","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7f3baa45c89f653a72675a45080b9f590cb135f9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    def tearDownClass(cls):"},{"line_number":61,"context_line":"        super(ChangeVnfPkgVnfLcmTest, cls).tearDownClass()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_1)"},{"line_number":64,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_2)"},{"line_number":65,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"},{"line_number":66,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_4)"}],"source_content_type":"text/x-python","patch_set":7,"id":"492b8b3a_dffbfe38","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":45},"in_reply_to":"ae162900_1ad17c20","updated":"2022-03-09 07:34:53.000000000","message":"Done","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"bd205b88b4a649a97c51297ac4ebaf8efa40c599","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    def tearDownClass(cls):"},{"line_number":61,"context_line":"        super(ChangeVnfPkgVnfLcmTest, cls).tearDownClass()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_1)"},{"line_number":64,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_2)"},{"line_number":65,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"},{"line_number":66,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_4)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a0861b0a_0bc981d3","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":45},"in_reply_to":"ae162900_1ad17c20","updated":"2022-03-09 01:47:17.000000000","message":"The following patch has been merged, so please rebase.\nhttps://review.opendev.org/c/openstack/tacker/+/832188","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1cb2ef2611178e0676dcc581e99ee1b6b72d4063","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    def tearDownClass(cls):"},{"line_number":61,"context_line":"        super(ChangeVnfPkgVnfLcmTest, cls).tearDownClass()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_1)"},{"line_number":64,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_2)"},{"line_number":65,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"},{"line_number":66,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_4)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7c5fb082_ffad3f99","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":45},"in_reply_to":"b772573d_3edabaae","updated":"2022-03-08 04:46:12.000000000","message":"OK, I deleted these changes in PS12.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d905b94135ae5fea1890150a34b8d5167f572826","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    def tearDownClass(cls):"},{"line_number":61,"context_line":"        super(ChangeVnfPkgVnfLcmTest, cls).tearDownClass()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_1)"},{"line_number":64,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_2)"},{"line_number":65,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"},{"line_number":66,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_4)"}],"source_content_type":"text/x-python","patch_set":7,"id":"b772573d_3edabaae","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":45},"in_reply_to":"c350fcf2_8f1d439d","updated":"2022-03-07 05:05:53.000000000","message":"Thank you for pointing out the following.\n-----\nIn addition, I also found a problem in the test. In v1, one vnfdid can create multiple vnfinstances, so when setting the status of the package to `NOT_IN_USE`, it is necessary to first determine whether the vnfdid is still used by other vnfinstances When terminate or modify, the original package state is directly set to `NOT_IN_USE`. I think this is wrong.\n-----\n\nI agree with your opinion.\nIt seems better to fix this with another patch, so I created a bug report.\nhttps://bugs.launchpad.net/tacker/+bug/1963858\n\nWould you please use the patch fixed in this bug report without fixing it in this patch?\nWe will handle this bug report on our side.","commit_id":"f338cec4dc23d18e04186bd8db8bb1e17089b205"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"84e81bfcb62de65ec5f4db7cb8773b3b36e07773","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        subnet_ids \u003d self.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027])"},{"line_number":281,"context_line":"        instantiate_req \u003d paramgen.change_vnfpkg_instantiate("},{"line_number":282,"context_line":"            net_ids, subnet_ids, self.auth_url)"},{"line_number":283,"context_line":"        instantiate_req[\u0027flavourId\u0027] \u003d \u0027volume\u0027"},{"line_number":284,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":285,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":286,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":23,"id":"e39edc99_80ff39b6","line":283,"updated":"2022-03-15 04:54:10.000000000","message":"I think that rewriting the request-body generated by \"paramgen.py\" should be avoided because it makes the outlook worse.\nHow about adding a default argument to the \"paramgen.py\" function as shown below?\n```\ndef change_vnfpkg_instantiate (net_ids, subnet_ids, auth_url, flavor_id \u003d\u0027simple\u0027):\n```","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ec0aa5b01a00bb834e677d90b8e1013ebc2ef7d0","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        subnet_ids \u003d self.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027])"},{"line_number":281,"context_line":"        instantiate_req \u003d paramgen.change_vnfpkg_instantiate("},{"line_number":282,"context_line":"            net_ids, subnet_ids, self.auth_url)"},{"line_number":283,"context_line":"        instantiate_req[\u0027flavourId\u0027] \u003d \u0027volume\u0027"},{"line_number":284,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":285,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":286,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":23,"id":"41847c3d_3a096c30","line":283,"in_reply_to":"e192fc3e_f12cd2e2","updated":"2022-03-16 07:42:47.000000000","message":"Done","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":280,"context_line":"        subnet_ids \u003d self.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027])"},{"line_number":281,"context_line":"        instantiate_req \u003d paramgen.change_vnfpkg_instantiate("},{"line_number":282,"context_line":"            net_ids, subnet_ids, self.auth_url)"},{"line_number":283,"context_line":"        instantiate_req[\u0027flavourId\u0027] \u003d \u0027volume\u0027"},{"line_number":284,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":285,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":286,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":23,"id":"e192fc3e_f12cd2e2","line":283,"in_reply_to":"e39edc99_80ff39b6","updated":"2022-03-16 01:17:28.000000000","message":"I fixed it in PS24.","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"84e81bfcb62de65ec5f4db7cb8773b3b36e07773","unresolved":true,"context_lines":[{"line_number":382,"context_line":"        subnet_ids \u003d self.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027])"},{"line_number":383,"context_line":"        instantiate_req \u003d paramgen.change_vnfpkg_instantiate("},{"line_number":384,"context_line":"            net_ids, subnet_ids, self.auth_url)"},{"line_number":385,"context_line":"        instantiate_req[\u0027flavourId\u0027] \u003d \u0027volume\u0027"},{"line_number":386,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":387,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":388,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5c9b6a3a_34a3716c","line":385,"updated":"2022-03-15 04:54:10.000000000","message":"ditto","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":382,"context_line":"        subnet_ids \u003d self.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027])"},{"line_number":383,"context_line":"        instantiate_req \u003d paramgen.change_vnfpkg_instantiate("},{"line_number":384,"context_line":"            net_ids, subnet_ids, self.auth_url)"},{"line_number":385,"context_line":"        instantiate_req[\u0027flavourId\u0027] \u003d \u0027volume\u0027"},{"line_number":386,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":387,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":388,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":23,"id":"d6a4fffa_88b3460f","line":385,"in_reply_to":"5c9b6a3a_34a3716c","updated":"2022-03-16 01:17:28.000000000","message":"ditto","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ec0aa5b01a00bb834e677d90b8e1013ebc2ef7d0","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        subnet_ids \u003d self.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027])"},{"line_number":383,"context_line":"        instantiate_req \u003d paramgen.change_vnfpkg_instantiate("},{"line_number":384,"context_line":"            net_ids, subnet_ids, self.auth_url)"},{"line_number":385,"context_line":"        instantiate_req[\u0027flavourId\u0027] \u003d \u0027volume\u0027"},{"line_number":386,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":387,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":388,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":23,"id":"e64c0740_e728288d","line":385,"in_reply_to":"d6a4fffa_88b3460f","updated":"2022-03-16 07:42:47.000000000","message":"Done","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"84e81bfcb62de65ec5f4db7cb8773b3b36e07773","unresolved":true,"context_lines":[{"line_number":570,"context_line":"        subnet_ids \u003d self.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027])"},{"line_number":571,"context_line":"        instantiate_req \u003d paramgen.change_vnfpkg_instantiate("},{"line_number":572,"context_line":"            net_ids, subnet_ids, self.auth_url)"},{"line_number":573,"context_line":"        instantiate_req[\u0027flavourId\u0027] \u003d \u0027volume\u0027"},{"line_number":574,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":575,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":576,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5ff1b887_dbc38c69","line":573,"updated":"2022-03-15 04:54:10.000000000","message":"ditto","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"6eedb88adfc707555b6b4d84a6d461691d923275","unresolved":true,"context_lines":[{"line_number":570,"context_line":"        subnet_ids \u003d self.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027])"},{"line_number":571,"context_line":"        instantiate_req \u003d paramgen.change_vnfpkg_instantiate("},{"line_number":572,"context_line":"            net_ids, subnet_ids, self.auth_url)"},{"line_number":573,"context_line":"        instantiate_req[\u0027flavourId\u0027] \u003d \u0027volume\u0027"},{"line_number":574,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":575,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":576,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":23,"id":"6badca32_07ad0db5","line":573,"in_reply_to":"5ff1b887_dbc38c69","updated":"2022-03-16 01:17:28.000000000","message":"ditto","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ec0aa5b01a00bb834e677d90b8e1013ebc2ef7d0","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        subnet_ids \u003d self.get_subnet_ids([\u0027subnet0\u0027, \u0027subnet1\u0027])"},{"line_number":571,"context_line":"        instantiate_req \u003d paramgen.change_vnfpkg_instantiate("},{"line_number":572,"context_line":"            net_ids, subnet_ids, self.auth_url)"},{"line_number":573,"context_line":"        instantiate_req[\u0027flavourId\u0027] \u003d \u0027volume\u0027"},{"line_number":574,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":575,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":576,"context_line":"        self.check_resp_headers_in_operation_task(resp)"}],"source_content_type":"text/x-python","patch_set":23,"id":"41d441d5_4e72f1be","line":573,"in_reply_to":"6badca32_07ad0db5","updated":"2022-03-16 07:42:47.000000000","message":"Done","commit_id":"dad0674f10f8f86fd5814ec84f052a16e29a8d92"}],"tacker/tests/unit/sol_refactored/conductor/test_vnflcm_driver_v2.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b5cb8c4c544d339f316230526beeb517199a8538","unresolved":true,"context_lines":[{"line_number":1411,"context_line":"        inst_info \u003d objects.VnfInstanceV2_InstantiatedVnfInfo.from_dict("},{"line_number":1412,"context_line":"            _inst_info_example)"},{"line_number":1413,"context_line":"        inst.instantiatedVnfInfo \u003d inst_info"},{"line_number":1414,"context_line":"        req \u003d objects.ChangeCurrentVnfPkgRequest.from_dict("},{"line_number":1415,"context_line":"            _change_vnfpkg_example)"},{"line_number":1416,"context_line":"        lcmocc \u003d objects.VnfLcmOpOccV2("},{"line_number":1417,"context_line":"            # required fields"}],"source_content_type":"text/x-python","patch_set":8,"id":"3e27d048_9aa333c0","line":1414,"updated":"2022-03-03 07:15:38.000000000","message":"Would you please add a comment to the ChangeCurrentVnfPkgRequest for those that are described as unsupported in the Spec?\n[Spec] https://specs.openstack.org/openstack/tacker-specs/specs/yoga/upgrade-vnf-package.html\n[ChangeCurrentVnfPkgRequest] https://opendev.org/openstack/tacker/src/branch/stable/xena/tacker/sol_refactored/objects/v2/change_current_vnf_pkg_request.py#L29-L40\n\n[FYI: HealVnfRequest]\nhttps://review.opendev.org/c/openstack/tacker/+/827189/15/tacker/sol_refactored/objects/v2/heal_vnf_request.py#33","commit_id":"8568dc7ad843ef180785d0c00dbafb36567c8943"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"44d4bc9b7a796d9fa9bdc3fa998421dd803f1cd7","unresolved":true,"context_lines":[{"line_number":1411,"context_line":"        inst_info \u003d objects.VnfInstanceV2_InstantiatedVnfInfo.from_dict("},{"line_number":1412,"context_line":"            _inst_info_example)"},{"line_number":1413,"context_line":"        inst.instantiatedVnfInfo \u003d inst_info"},{"line_number":1414,"context_line":"        req \u003d objects.ChangeCurrentVnfPkgRequest.from_dict("},{"line_number":1415,"context_line":"            _change_vnfpkg_example)"},{"line_number":1416,"context_line":"        lcmocc \u003d objects.VnfLcmOpOccV2("},{"line_number":1417,"context_line":"            # required fields"}],"source_content_type":"text/x-python","patch_set":8,"id":"719b9512_a2be51b8","line":1414,"in_reply_to":"3e27d048_9aa333c0","updated":"2022-03-04 09:10:19.000000000","message":"I added comments in PS9.","commit_id":"8568dc7ad843ef180785d0c00dbafb36567c8943"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a3aafaabfd8b2a35a0237b770239a27daee829ba","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"        inst_info \u003d objects.VnfInstanceV2_InstantiatedVnfInfo.from_dict("},{"line_number":1412,"context_line":"            _inst_info_example)"},{"line_number":1413,"context_line":"        inst.instantiatedVnfInfo \u003d inst_info"},{"line_number":1414,"context_line":"        req \u003d objects.ChangeCurrentVnfPkgRequest.from_dict("},{"line_number":1415,"context_line":"            _change_vnfpkg_example)"},{"line_number":1416,"context_line":"        lcmocc \u003d objects.VnfLcmOpOccV2("},{"line_number":1417,"context_line":"            # required fields"}],"source_content_type":"text/x-python","patch_set":8,"id":"e7195837_6888b337","line":1414,"in_reply_to":"719b9512_a2be51b8","updated":"2022-03-08 06:17:00.000000000","message":"Done","commit_id":"8568dc7ad843ef180785d0c00dbafb36567c8943"}],"tacker/tests/unit/sol_refactored/controller/test_vnflcm_v2.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc3b21dd506db6840da0e04b05fb65981f8a2fc8","unresolved":true,"context_lines":[{"line_number":171,"context_line":"            self.controller.instantiate, request\u003dself.request, id\u003dinst_id,"},{"line_number":172,"context_line":"            body\u003dbody)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_change_vnfpkg(self):"},{"line_number":175,"context_line":"        vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":176,"context_line":"        inst_id, _ \u003d self._create_inst_and_lcmocc(\u0027NOT_INSTANTIATED\u0027,"},{"line_number":177,"context_line":"            fields.LcmOperationStateType.COMPLETED)"}],"source_content_type":"text/x-python","patch_set":3,"id":"350afc47_0df5494b","line":174,"updated":"2022-02-04 10:16:37.000000000","message":"Could you add a test for \"test_change_vnfpkg_not_instantiated\"?","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0749d0ba5d775ba072827b1d73509ce4b81c1a8d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            self.controller.instantiate, request\u003dself.request, id\u003dinst_id,"},{"line_number":172,"context_line":"            body\u003dbody)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_change_vnfpkg(self):"},{"line_number":175,"context_line":"        vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":176,"context_line":"        inst_id, _ \u003d self._create_inst_and_lcmocc(\u0027NOT_INSTANTIATED\u0027,"},{"line_number":177,"context_line":"            fields.LcmOperationStateType.COMPLETED)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce92bddf_beedda29","line":174,"in_reply_to":"27d2202e_664b0ed1","updated":"2022-02-25 00:57:54.000000000","message":"Done","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3d0cfa57172a49b10d7818c29feb128757fba93b","unresolved":true,"context_lines":[{"line_number":171,"context_line":"            self.controller.instantiate, request\u003dself.request, id\u003dinst_id,"},{"line_number":172,"context_line":"            body\u003dbody)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_change_vnfpkg(self):"},{"line_number":175,"context_line":"        vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":176,"context_line":"        inst_id, _ \u003d self._create_inst_and_lcmocc(\u0027NOT_INSTANTIATED\u0027,"},{"line_number":177,"context_line":"            fields.LcmOperationStateType.COMPLETED)"}],"source_content_type":"text/x-python","patch_set":3,"id":"27d2202e_664b0ed1","line":174,"in_reply_to":"350afc47_0df5494b","updated":"2022-02-22 07:39:01.000000000","message":"I fixed it in PS4.","commit_id":"d9bf5724bf077d5df1485b8bfd115092cef901f2"}]}