)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"42028fcd303a58caf28b4e6ec20dfa2782acc3e9","unresolved":true,"context_lines":[{"line_number":17,"context_line":"* Change base class functions in BaseVnfLcmTest to pass different"},{"line_number":18,"context_line":"  openstack clients as arguments. And move common code in"},{"line_number":19,"context_line":"  BaseVnfLcmTest into functions."},{"line_number":20,"context_line":"* Customise functions to set fake http server as per tenant in"},{"line_number":21,"context_line":"  class BaseVnfLcmTest."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implement: blueprint multi-tenant-policy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3b33d475_63e1f26d","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":11},"updated":"2022-02-07 08:41:11.000000000","message":"typo: Customize","commit_id":"3d4ad9b451cd54d161f0b90915bac5fbddd26270"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"4c75d93fdd3abfe95c7f0edfae84ef4edb991a04","unresolved":false,"context_lines":[{"line_number":17,"context_line":"* Change base class functions in BaseVnfLcmTest to pass different"},{"line_number":18,"context_line":"  openstack clients as arguments. And move common code in"},{"line_number":19,"context_line":"  BaseVnfLcmTest into functions."},{"line_number":20,"context_line":"* Customise functions to set fake http server as per tenant in"},{"line_number":21,"context_line":"  class BaseVnfLcmTest."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implement: blueprint multi-tenant-policy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"b377d00b_844015ff","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":11},"in_reply_to":"3b33d475_63e1f26d","updated":"2022-02-08 05:42:11.000000000","message":"Done","commit_id":"3d4ad9b451cd54d161f0b90915bac5fbddd26270"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b5146611640d5b6d0db51716488f836323ecdbc0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"* Change base class functions in BaseVnfLcmTest to pass different"},{"line_number":18,"context_line":"  openstack clients as arguments. And move common code in"},{"line_number":19,"context_line":"  BaseVnfLcmTest into functions."},{"line_number":20,"context_line":"* Customise functions to set fake http server as per tenant in"},{"line_number":21,"context_line":"  class BaseVnfLcmTest."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Implement: blueprint multi-tenant-policy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"cd2a9729_5cf762aa","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":11},"in_reply_to":"b377d00b_844015ff","updated":"2022-02-08 06:23:23.000000000","message":"I\u0027ve confirmed.","commit_id":"3d4ad9b451cd54d161f0b90915bac5fbddd26270"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"42028fcd303a58caf28b4e6ec20dfa2782acc3e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e74e22dc_9da8ffc2","updated":"2022-02-07 08:41:11.000000000","message":"Thanks for your patch, please kindly find review comments.","commit_id":"3d4ad9b451cd54d161f0b90915bac5fbddd26270"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2b9f62db0c87d9b4b14c17b269aef80ea9022c34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bcdc149a_455ebeba","updated":"2022-02-14 01:53:01.000000000","message":"Any update for the name of vim config file?","commit_id":"ddc21b614809a8762f6763964651d2336e80bb3c"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"4c75d93fdd3abfe95c7f0edfae84ef4edb991a04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cbbe6c9d_fb525f77","updated":"2022-02-08 05:42:11.000000000","message":"Thanks for your comments, please find rework in Patchset 10.","commit_id":"ddc21b614809a8762f6763964651d2336e80bb3c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b5146611640d5b6d0db51716488f836323ecdbc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0671dec4_0b9cf761","updated":"2022-02-08 06:23:23.000000000","message":"Thanks for your rework, LGTM.","commit_id":"ddc21b614809a8762f6763964651d2336e80bb3c"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"20cb605c54f3b63074c2cec808a15f20740b0b9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"11b9b8ab_df697327","in_reply_to":"089ee8c8_5891e5d5","updated":"2022-02-17 07:17:45.000000000","message":"Do you mean we don\u0027t need to hurry to merge this update?","commit_id":"ddc21b614809a8762f6763964651d2336e80bb3c"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"df811e2efd4b35422ae7593e3158a910922865a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"24a446f7_3931222b","in_reply_to":"11b9b8ab_df697327","updated":"2022-02-17 08:06:39.000000000","message":"Hi Ogawa san,\n\nSorry for the confusion.\n\nThis patch refractors SOL functional testing framework, so it could be re-use while creating functional test cases for multi-tenant policy. Therefore it\u0027s of utmost importance to merge this patch in the Y release.\n\nIn the previous comment I was trying to convey that for the existing VIM config file i.e. `local-vim.yaml`, I would require some time to analyze naming convention and its impact on the existing FT and share results in the upcoming cycle. \n\nNote: Regarding the vim config file naming convention, for multi tenant FT I have used naming conventions as `local-tenant1-vim.yaml` and `local-tenant2-vim.yaml`.\nPlease refer to [1].\n\n[1] https://review.opendev.org/c/openstack/tacker/+/823965","commit_id":"ddc21b614809a8762f6763964651d2336e80bb3c"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"302fc33ad2391fc59f11c06e9bb95b2247dc9c52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"089ee8c8_5891e5d5","in_reply_to":"bcdc149a_455ebeba","updated":"2022-02-14 05:43:36.000000000","message":"Sorry!! Ogawa san, I haven\u0027t started the investigation regarding the \"vim config\" file change impact in the existing functional test cases, would target in the upcoming cycle.","commit_id":"ddc21b614809a8762f6763964651d2336e80bb3c"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"55083cd7b8145503cabc67f376d9ee25bd564cea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6f8f2eab_18a00054","updated":"2022-02-18 07:02:58.000000000","message":"Understand, thanks.","commit_id":"73c00dfa60d87b2b0c3fec30f3537179af8d56c1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"8d637e22e1bbc4f17df67b4788e528fd13e087a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"68f96a86_9047d0b0","updated":"2022-02-18 06:41:55.000000000","message":"ping","commit_id":"73c00dfa60d87b2b0c3fec30f3537179af8d56c1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"60e5aeead98e7ccd63882d3cb5ce229ffc00a511","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2e7c5e07_695bb2cf","updated":"2022-02-14 10:37:59.000000000","message":"recheck","commit_id":"73c00dfa60d87b2b0c3fec30f3537179af8d56c1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"105d37e114d7cce7cd7bd4b63b82eaf3f7081a29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e33daf18_e60471f9","updated":"2022-02-14 08:06:40.000000000","message":"recheck","commit_id":"73c00dfa60d87b2b0c3fec30f3537179af8d56c1"}],"tacker/tests/functional/base.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"42028fcd303a58caf28b4e6ec20dfa2782acc3e9","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        cls.cinder_client \u003d cls.cinderclient()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def get_credentials(cls, vim_conf_file\u003d\u0027local-vim.yaml\u0027):"},{"line_number":107,"context_line":"        vim_params \u003d yaml.safe_load(read_file(vim_conf_file))"},{"line_number":108,"context_line":"        vim_params[\u0027auth_url\u0027] +\u003d \u0027/v3\u0027"},{"line_number":109,"context_line":"        return vim_params"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f29b8c7_042b2cea","line":106,"range":{"start_line":106,"start_character":43,"end_line":106,"end_character":59},"updated":"2022-02-07 08:41:11.000000000","message":"The same file name was given to the arguments of the other methods, so how about defining them as constant if possible?","commit_id":"3d4ad9b451cd54d161f0b90915bac5fbddd26270"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"4c75d93fdd3abfe95c7f0edfae84ef4edb991a04","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        cls.cinder_client \u003d cls.cinderclient()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def get_credentials(cls, vim_conf_file\u003d\u0027local-vim.yaml\u0027):"},{"line_number":107,"context_line":"        vim_params \u003d yaml.safe_load(read_file(vim_conf_file))"},{"line_number":108,"context_line":"        vim_params[\u0027auth_url\u0027] +\u003d \u0027/v3\u0027"},{"line_number":109,"context_line":"        return vim_params"}],"source_content_type":"text/x-python","patch_set":8,"id":"686af95f_daee6b99","line":106,"range":{"start_line":106,"start_character":43,"end_line":106,"end_character":59},"in_reply_to":"1f29b8c7_042b2cea","updated":"2022-02-08 05:42:11.000000000","message":"Thanks for your suggestion, \nI have defined the default value \"None\" for vim_conf_file in all methods and only fill in the method which loads the config file.","commit_id":"3d4ad9b451cd54d161f0b90915bac5fbddd26270"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b5146611640d5b6d0db51716488f836323ecdbc0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        cls.cinder_client \u003d cls.cinderclient()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def get_credentials(cls, vim_conf_file\u003d\u0027local-vim.yaml\u0027):"},{"line_number":107,"context_line":"        vim_params \u003d yaml.safe_load(read_file(vim_conf_file))"},{"line_number":108,"context_line":"        vim_params[\u0027auth_url\u0027] +\u003d \u0027/v3\u0027"},{"line_number":109,"context_line":"        return vim_params"}],"source_content_type":"text/x-python","patch_set":8,"id":"4bbecb8b_abc39906","line":106,"range":{"start_line":106,"start_character":43,"end_line":106,"end_character":59},"in_reply_to":"686af95f_daee6b99","updated":"2022-02-08 06:23:23.000000000","message":"Thanks for updating! I\u0027ve confirmed.","commit_id":"3d4ad9b451cd54d161f0b90915bac5fbddd26270"}]}