)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4589f81711e22c6bc3027ee33e3373d3176ccb8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b694437d_d5e17d44","updated":"2022-02-02 07:28:08.000000000","message":"This patch is still WIP, but I will add the concerned parties to the reviewer in advance.","commit_id":"1decad5e3e95680b29ca309453615c9296a70811"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8d8c3267_2c1a225d","updated":"2022-02-08 10:31:33.000000000","message":"Thanks for your work. I have some comments, so could you check that?","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"baf3b0879a718d0f2cffbe8309236d9964da1ace","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e6e53f3a_4b31a299","updated":"2022-02-15 07:32:59.000000000","message":"Thank you for the patch.\nPlease kindly find my comments.","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"db829a8f4e97c9c4391dffdb2c155479a2a91a11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c742614d_6e2b5766","updated":"2022-02-15 00:46:35.000000000","message":"recheck","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"93507b5ff709def723b624cd30d226e2a008be40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0e9ca62d_c9a57717","updated":"2022-02-24 07:15:11.000000000","message":"Thank you for re-work.\nLGTM.","commit_id":"ca49fb9df6ac52d6b9682b3d9763f4e33b24d751"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7005433ec8181bc01d276a23f8f892aa119d8bc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"af365248_f4f0665a","updated":"2022-02-28 08:59:30.000000000","message":"LGTM. I will add +1 after zuul:+1.","commit_id":"621ad795b5db51ebebf97b87e242fbbec7a46dc8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"85e1fc8c57351aeacda76e425573b1237e1dbad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"023badae_7267e289","updated":"2022-02-28 09:35:02.000000000","message":"recheck","commit_id":"621ad795b5db51ebebf97b87e242fbbec7a46dc8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b1f1cda6cad548f2e8cdd7321ad6a34dc6fdf578","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2c8c060e_cac84038","updated":"2022-03-01 13:05:42.000000000","message":"recheck","commit_id":"4fa93d9ade9d031ba07ae9060221d6dce2fd58a7"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7cc92e921c3ce1c0c568f01e2c15f54fd1ecbe51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"20771b47_c4a552df","updated":"2022-03-02 05:14:19.000000000","message":"recheck","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"68b52aacf70c8cf4b4f1c1a8e7260517b463f21f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"4d59a7c2_5e1573a1","updated":"2022-03-04 13:45:47.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"3869daa336495c6b2304271f770bf2af614932ea"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"ceee3f2c_573539a1","updated":"2022-03-07 05:14:48.000000000","message":"recheck","commit_id":"7007ce56328c5c99552f3cefd3f797cd66d99621"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2cfd120e0c4a1a5745f8a043f1c6833f597b2a2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"f157efcb_6a789162","updated":"2022-03-08 08:56:10.000000000","message":"LGTM","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"39426039ccfca151d5bc5aef70457d0c6c5efc3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"d7423328_2297595c","updated":"2022-03-09 08:43:15.000000000","message":"Thanks for your rework, LGTM.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4dd72de284eeabc46591cea53a026e9ca0717f3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"6d022e72_6ffbdc9b","updated":"2022-03-10 06:12:34.000000000","message":"Ping","commit_id":"55a16877c82c3b98b2feea40fd39ee60e458164d"}],"tacker/tests/functional/sol_v2/base_v2.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":30,"context_line":"from tacker.sol_refactored import objects"},{"line_number":31,"context_line":"from tacker.tests.functional.sol_v2 import utils"},{"line_number":32,"context_line":"from tacker.tests import utils as base_utils"},{"line_number":33,"context_line":"from tacker import version"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from tacker.tests.functional.common.fake_server import FakeServerManager"},{"line_number":36,"context_line":"FAKE_SERVER_MANAGER \u003d FakeServerManager.get_instance()"},{"line_number":37,"context_line":"MOCK_NOTIFY_CALLBACK_URL \u003d \u0027/notification/callback\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"452dbf63_d618399f","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":54},"updated":"2022-02-08 10:31:33.000000000","message":"It\u0027s better to remove the blank line of L34 and add a blank line between the current L35 and L36.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from tacker.sol_refactored import objects"},{"line_number":31,"context_line":"from tacker.tests.functional.sol_v2 import utils"},{"line_number":32,"context_line":"from tacker.tests import utils as base_utils"},{"line_number":33,"context_line":"from tacker import version"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from tacker.tests.functional.common.fake_server import FakeServerManager"},{"line_number":36,"context_line":"FAKE_SERVER_MANAGER \u003d FakeServerManager.get_instance()"},{"line_number":37,"context_line":"MOCK_NOTIFY_CALLBACK_URL \u003d \u0027/notification/callback\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"d890f76f_94a48520","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":54},"in_reply_to":"3edb519d_5a7fe084","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":30,"context_line":"from tacker.sol_refactored import objects"},{"line_number":31,"context_line":"from tacker.tests.functional.sol_v2 import utils"},{"line_number":32,"context_line":"from tacker.tests import utils as base_utils"},{"line_number":33,"context_line":"from tacker import version"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from tacker.tests.functional.common.fake_server import FakeServerManager"},{"line_number":36,"context_line":"FAKE_SERVER_MANAGER \u003d FakeServerManager.get_instance()"},{"line_number":37,"context_line":"MOCK_NOTIFY_CALLBACK_URL \u003d \u0027/notification/callback\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3edb519d_5a7fe084","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":54},"in_reply_to":"452dbf63_d618399f","updated":"2022-02-09 08:22:30.000000000","message":"I fixed in the patchset 7.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":361,"context_line":"            _, body \u003d self.tacker_client.do_request("},{"line_number":362,"context_line":"                path, \"GET\", expected_status\u003d[200], version\u003d\"2.0.0\")"},{"line_number":363,"context_line":"            state \u003d body[\u0027operationState\u0027]"},{"line_number":364,"context_line":"            if state \u003d\u003d \u0027ROLLED_BACK\u0027:"},{"line_number":365,"context_line":"                return"},{"line_number":366,"context_line":"            if state in [\u0027ROLLING_BACK\u0027]:"},{"line_number":367,"context_line":"                continue"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"86a9c194_c87e40cf","line":366,"range":{"start_line":364,"start_character":12,"end_line":366,"end_character":41},"updated":"2022-02-08 10:31:33.000000000","message":"Considering the case where \"operationState\" transitions to \"FAILED_TEMP\" again, I think you can detect unexpected transitions quickly, but what do you think?","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":363,"context_line":"            state \u003d body[\u0027operationState\u0027]"},{"line_number":364,"context_line":"            if state \u003d\u003d \u0027ROLLED_BACK\u0027:"},{"line_number":365,"context_line":"                return"},{"line_number":366,"context_line":"            if state in [\u0027ROLLING_BACK\u0027]:"},{"line_number":367,"context_line":"                continue"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"5d0980b3_e08875f4","line":366,"range":{"start_line":366,"start_character":12,"end_line":366,"end_character":41},"updated":"2022-02-08 10:31:33.000000000","message":"I think the below is better.\n```\nelif state \u003d\u003d \u0027ROLLING_BACK\u0027:\n```","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            state \u003d body[\u0027operationState\u0027]"},{"line_number":364,"context_line":"            if state \u003d\u003d \u0027ROLLED_BACK\u0027:"},{"line_number":365,"context_line":"                return"},{"line_number":366,"context_line":"            if state in [\u0027ROLLING_BACK\u0027]:"},{"line_number":367,"context_line":"                continue"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"c1df7137_7509ee1e","line":366,"range":{"start_line":366,"start_character":12,"end_line":366,"end_character":41},"in_reply_to":"2fc4f7f8_1a67a6e5","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            _, body \u003d self.tacker_client.do_request("},{"line_number":362,"context_line":"                path, \"GET\", expected_status\u003d[200], version\u003d\"2.0.0\")"},{"line_number":363,"context_line":"            state \u003d body[\u0027operationState\u0027]"},{"line_number":364,"context_line":"            if state \u003d\u003d \u0027ROLLED_BACK\u0027:"},{"line_number":365,"context_line":"                return"},{"line_number":366,"context_line":"            if state in [\u0027ROLLING_BACK\u0027]:"},{"line_number":367,"context_line":"                continue"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"e6439190_5c97356a","line":366,"range":{"start_line":364,"start_character":12,"end_line":366,"end_character":41},"in_reply_to":"4d098a5b_4947b31c","updated":"2022-02-15 09:55:29.000000000","message":"I thought it had the advantage of being able to detect FAILED_TEMP before timeout, but it\u0027s trivial, so it\u0027s no need to fix.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":363,"context_line":"            state \u003d body[\u0027operationState\u0027]"},{"line_number":364,"context_line":"            if state \u003d\u003d \u0027ROLLED_BACK\u0027:"},{"line_number":365,"context_line":"                return"},{"line_number":366,"context_line":"            if state in [\u0027ROLLING_BACK\u0027]:"},{"line_number":367,"context_line":"                continue"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"2fc4f7f8_1a67a6e5","line":366,"range":{"start_line":366,"start_character":12,"end_line":366,"end_character":41},"in_reply_to":"5d0980b3_e08875f4","updated":"2022-02-09 08:22:30.000000000","message":"If I modify like that, there will be a pylint warning as follows:\n\nUnnecessary \"elif\" after \"return\" (366:12) [no-else-return]","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":361,"context_line":"            _, body \u003d self.tacker_client.do_request("},{"line_number":362,"context_line":"                path, \"GET\", expected_status\u003d[200], version\u003d\"2.0.0\")"},{"line_number":363,"context_line":"            state \u003d body[\u0027operationState\u0027]"},{"line_number":364,"context_line":"            if state \u003d\u003d \u0027ROLLED_BACK\u0027:"},{"line_number":365,"context_line":"                return"},{"line_number":366,"context_line":"            if state in [\u0027ROLLING_BACK\u0027]:"},{"line_number":367,"context_line":"                continue"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"4d098a5b_4947b31c","line":366,"range":{"start_line":364,"start_character":12,"end_line":366,"end_character":41},"in_reply_to":"86a9c194_c87e40cf","updated":"2022-02-09 08:22:30.000000000","message":"FAILED_TEMP will cause a exception in L369. I don\u0027t think need to add a condition of \"FAILED_TEMP\" specially. What do you think?","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":391,"context_line":"        return self.tacker_client.do_request("},{"line_number":392,"context_line":"            path, \"GET\", version\u003d\"2.0.0\")"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def rollback_lcm(self, lcmocc_id):"},{"line_number":395,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}/rollback\""},{"line_number":396,"context_line":"        return self.tacker_client.do_request("},{"line_number":397,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"72cc2a58_71f3066c","line":394,"range":{"start_line":394,"start_character":8,"end_line":394,"end_character":20},"updated":"2022-02-08 10:31:33.000000000","message":"I think \"rollback_lcmocc\" is better.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":391,"context_line":"        return self.tacker_client.do_request("},{"line_number":392,"context_line":"            path, \"GET\", version\u003d\"2.0.0\")"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def rollback_lcm(self, lcmocc_id):"},{"line_number":395,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}/rollback\""},{"line_number":396,"context_line":"        return self.tacker_client.do_request("},{"line_number":397,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"8cc7f5e3_3d6b0110","line":394,"range":{"start_line":394,"start_character":8,"end_line":394,"end_character":20},"in_reply_to":"72cc2a58_71f3066c","updated":"2022-02-09 08:22:30.000000000","message":"I fixed in the patchset 7.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        return self.tacker_client.do_request("},{"line_number":392,"context_line":"            path, \"GET\", version\u003d\"2.0.0\")"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def rollback_lcm(self, lcmocc_id):"},{"line_number":395,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}/rollback\""},{"line_number":396,"context_line":"        return self.tacker_client.do_request("},{"line_number":397,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"18778204_b09ef9c6","line":394,"range":{"start_line":394,"start_character":8,"end_line":394,"end_character":20},"in_reply_to":"8cc7f5e3_3d6b0110","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        return self.tacker_client.do_request("},{"line_number":397,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def retry_lcm(self, lcmocc_id):"},{"line_number":400,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}/retry\""},{"line_number":401,"context_line":"        return self.tacker_client.do_request("},{"line_number":402,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"f32b7246_8c7d92c3","line":399,"range":{"start_line":399,"start_character":8,"end_line":399,"end_character":17},"updated":"2022-02-08 10:31:33.000000000","message":"ditto","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        return self.tacker_client.do_request("},{"line_number":397,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def retry_lcm(self, lcmocc_id):"},{"line_number":400,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}/retry\""},{"line_number":401,"context_line":"        return self.tacker_client.do_request("},{"line_number":402,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"ed99d4bc_a5be4387","line":399,"range":{"start_line":399,"start_character":8,"end_line":399,"end_character":17},"in_reply_to":"53a5ac30_83ef90b1","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        return self.tacker_client.do_request("},{"line_number":397,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def retry_lcm(self, lcmocc_id):"},{"line_number":400,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}/retry\""},{"line_number":401,"context_line":"        return self.tacker_client.do_request("},{"line_number":402,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"53a5ac30_83ef90b1","line":399,"range":{"start_line":399,"start_character":8,"end_line":399,"end_character":17},"in_reply_to":"f32b7246_8c7d92c3","updated":"2022-02-09 08:22:30.000000000","message":"I fixed in the patchset 7.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":401,"context_line":"        return self.tacker_client.do_request("},{"line_number":402,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def fail_lcm(self, lcmocc_id):"},{"line_number":405,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}/fail\""},{"line_number":406,"context_line":"        return self.tacker_client.do_request("},{"line_number":407,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"38d17544_df385c45","line":404,"range":{"start_line":404,"start_character":8,"end_line":404,"end_character":16},"updated":"2022-02-08 10:31:33.000000000","message":"ditto","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":401,"context_line":"        return self.tacker_client.do_request("},{"line_number":402,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def fail_lcm(self, lcmocc_id):"},{"line_number":405,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}/fail\""},{"line_number":406,"context_line":"        return self.tacker_client.do_request("},{"line_number":407,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"4e9ba6c2_737fab4e","line":404,"range":{"start_line":404,"start_character":8,"end_line":404,"end_character":16},"in_reply_to":"38d17544_df385c45","updated":"2022-02-09 08:22:30.000000000","message":"I fixed in the patchset 7.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        return self.tacker_client.do_request("},{"line_number":402,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def fail_lcm(self, lcmocc_id):"},{"line_number":405,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}/fail\""},{"line_number":406,"context_line":"        return self.tacker_client.do_request("},{"line_number":407,"context_line":"            path, \"POST\", version\u003d\"2.0.0\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"2c8983ea_d9abe056","line":404,"range":{"start_line":404,"start_character":8,"end_line":404,"end_character":16},"in_reply_to":"4e9ba6c2_737fab4e","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"baf3b0879a718d0f2cffbe8309236d9964da1ace","unresolved":true,"context_lines":[{"line_number":76,"context_line":"                                                 service_type\u003d\u0027compute\u0027)"},{"line_number":77,"context_line":"        cls.heat_client \u003d heat_utils.HeatClient(vim_info)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setUp(self):"},{"line_number":80,"context_line":"        super().setUp()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        callback_url \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":10,"id":"a41ac5da_6e5612a5","line":79,"updated":"2022-02-15 07:32:59.000000000","message":"nits.\n\nPlease consider to place a member method after class methods.\n\nlike the following.\n\n```\n@classmethod\ndef tearDownClass(cls):\n    ...\n\n@classmethod\ndef get_vim_info(cls):\n    ...\n\ndef setUp(self):\n    ...\n```","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"49e23b6ccc015658e9f39708819bbfb5fcf44a20","unresolved":true,"context_lines":[{"line_number":76,"context_line":"                                                 service_type\u003d\u0027compute\u0027)"},{"line_number":77,"context_line":"        cls.heat_client \u003d heat_utils.HeatClient(vim_info)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setUp(self):"},{"line_number":80,"context_line":"        super().setUp()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        callback_url \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":10,"id":"c774aa5f_84b9a5d1","line":79,"in_reply_to":"a41ac5da_6e5612a5","updated":"2022-02-18 05:29:02.000000000","message":"I fixed it in patch set 11.","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"93507b5ff709def723b624cd30d226e2a008be40","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                                 service_type\u003d\u0027compute\u0027)"},{"line_number":77,"context_line":"        cls.heat_client \u003d heat_utils.HeatClient(vim_info)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setUp(self):"},{"line_number":80,"context_line":"        super().setUp()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        callback_url \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":10,"id":"b55c819f_abe5689d","line":79,"in_reply_to":"c774aa5f_84b9a5d1","updated":"2022-02-24 07:15:11.000000000","message":"Ack","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"baf3b0879a718d0f2cffbe8309236d9964da1ace","unresolved":true,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def check_lcmocc_failed(self, lcmocc_id):"},{"line_number":372,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}\""},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        _, body \u003d self.tacker_client.do_request("}],"source_content_type":"text/x-python","patch_set":10,"id":"1add38bb_2c238b96","line":371,"updated":"2022-02-15 07:32:59.000000000","message":"I wonder if this is the right place to define this method. Maybe  ``tacker/tests/functional/sol_v2/test_vnflcm_basic.py`` is. You can call ``show_lcmocc`` there and check the response body (setting ``expected_status`` is not required as tests will fail if a response is not 200).\n\nThis is just an example.\n```\ndef assert_op_state_equal(self, lcmocc_id, state):\n    _, body \u003d self.show_lcmocc(lcmocc_id)\n    body[\u0027operationState\u0027] \u003d\u003d state:\n        return \n    raise Exception(f\"Operation failed. state: {state}\")\n```\nOr you can directly write the content of the above method into your tests.\n\nThis method is only used by ``test_fail_instantiate`` currently and is specific to check if `operationState` is a specific state, i.e., FAILED. Adding this kind of method will make a bloated base class.\n\nBasically, I think we need to be cautious about extending a base class and should only add methods for a general-purpose rather than a specific purpose. We can define a method as an external module or a member method of a child class first and then move to a base class after the method becomes general in the future.\n\nCould you tell me your opinion?","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"49e23b6ccc015658e9f39708819bbfb5fcf44a20","unresolved":true,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def check_lcmocc_failed(self, lcmocc_id):"},{"line_number":372,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}\""},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        _, body \u003d self.tacker_client.do_request("}],"source_content_type":"text/x-python","patch_set":10,"id":"4d118f64_a77fcdbd","line":371,"in_reply_to":"1add38bb_2c238b96","updated":"2022-02-18 05:29:02.000000000","message":"I agreed. I deleted check_lcmocc_failed method and write the check in the test case directly.\nI have fixed in the patch set 11.","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"93507b5ff709def723b624cd30d226e2a008be40","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            raise Exception(f\"Operation failed. state: {state}\")"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def check_lcmocc_failed(self, lcmocc_id):"},{"line_number":372,"context_line":"        path \u003d f\"/vnflcm/v2/vnf_lcm_op_occs/{lcmocc_id}\""},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        _, body \u003d self.tacker_client.do_request("}],"source_content_type":"text/x-python","patch_set":10,"id":"53f9b1a7_9914f960","line":371,"in_reply_to":"4d118f64_a77fcdbd","updated":"2022-02-24 07:15:11.000000000","message":"Ack","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"}],"tacker/tests/functional/sol_v2/paramgen.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":157,"context_line":"    }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def sample1_create(vnfd_id):"},{"line_number":161,"context_line":"    # All attributes are set."},{"line_number":162,"context_line":"    # NOTE: All of the following cardinality attributes are set."},{"line_number":163,"context_line":"    # In addition, 0..N or 1..N attributes are set to 2 or more."}],"source_content_type":"text/x-python","patch_set":6,"id":"a9f2f993_328e65f2","line":160,"range":{"start_line":160,"start_character":4,"end_line":160,"end_character":18},"updated":"2022-02-08 10:31:33.000000000","message":"For consistency, I think this function, which is the wrapper function of \"create_vnf_max\", is not needed.\nBecause \"scaleout_max\" is called directly.\nIf you fix this, you will also need to fix \"tacker/tests/functional/sol_v2/test_vnflcm_basic.py\", but I don\u0027t think you need to treat sample1 and sample2 specially.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def sample1_create(vnfd_id):"},{"line_number":161,"context_line":"    # All attributes are set."},{"line_number":162,"context_line":"    # NOTE: All of the following cardinality attributes are set."},{"line_number":163,"context_line":"    # In addition, 0..N or 1..N attributes are set to 2 or more."}],"source_content_type":"text/x-python","patch_set":6,"id":"badf8111_26928781","line":160,"range":{"start_line":160,"start_character":4,"end_line":160,"end_character":18},"in_reply_to":"9f453d4c_ee4c2cc0","updated":"2022-02-15 09:55:29.000000000","message":"I could check it on the below patch.\n---\nhttps://review.opendev.org/c/openstack/tacker/+/829156/1/tacker/tests/functional/sol_v2/paramgen.py","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":157,"context_line":"    }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def sample1_create(vnfd_id):"},{"line_number":161,"context_line":"    # All attributes are set."},{"line_number":162,"context_line":"    # NOTE: All of the following cardinality attributes are set."},{"line_number":163,"context_line":"    # In addition, 0..N or 1..N attributes are set to 2 or more."}],"source_content_type":"text/x-python","patch_set":6,"id":"9f453d4c_ee4c2cc0","line":160,"range":{"start_line":160,"start_character":4,"end_line":160,"end_character":18},"in_reply_to":"a9f2f993_328e65f2","updated":"2022-02-09 08:22:30.000000000","message":"I agree, but sample1,sample2 was not the target in this patch. I will delete sample1_create method, and will rename test_sample1() in other patch.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":535,"context_line":"    }"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"def scaleout_max():"},{"line_number":539,"context_line":"    # All attributes are set."},{"line_number":540,"context_line":"    # NOTE: All of the following cardinality attributes are set."},{"line_number":541,"context_line":"    # In addition, 0..N or 1..N attributes are set to 2 or more."}],"source_content_type":"text/x-python","patch_set":6,"id":"9e36a967_a0464684","line":538,"updated":"2022-02-08 10:31:33.000000000","message":"For consistency, \"scaleout_vnf_max\" is better.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":535,"context_line":"    }"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"def scaleout_max():"},{"line_number":539,"context_line":"    # All attributes are set."},{"line_number":540,"context_line":"    # NOTE: All of the following cardinality attributes are set."},{"line_number":541,"context_line":"    # In addition, 0..N or 1..N attributes are set to 2 or more."}],"source_content_type":"text/x-python","patch_set":6,"id":"d1a322ec_7efc2735","line":538,"in_reply_to":"9e36a967_a0464684","updated":"2022-02-09 08:22:30.000000000","message":"I fixed in the patchset 7.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":535,"context_line":"    }"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"def scaleout_max():"},{"line_number":539,"context_line":"    # All attributes are set."},{"line_number":540,"context_line":"    # NOTE: All of the following cardinality attributes are set."},{"line_number":541,"context_line":"    # In addition, 0..N or 1..N attributes are set to 2 or more."}],"source_content_type":"text/x-python","patch_set":6,"id":"fe37b546_ded636ec","line":538,"in_reply_to":"d1a322ec_7efc2735","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":201,"context_line":"    #  - 1..N (2 or more)"},{"line_number":202,"context_line":"    return {"},{"line_number":203,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":204,"context_line":"        \"vnfInstanceName\": \"sample1\","},{"line_number":205,"context_line":"        \"vnfInstanceDescription\": \"test sample1\","},{"line_number":206,"context_line":"        \"metadata\": {\"dummy-key\": \"dummy-val\"}"},{"line_number":207,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f022478_9f9edf6a","line":204,"updated":"2022-03-02 05:50:54.000000000","message":"I think that \"sample\" is better because it is used for other than sample1.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":201,"context_line":"    #  - 1..N (2 or more)"},{"line_number":202,"context_line":"    return {"},{"line_number":203,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":204,"context_line":"        \"vnfInstanceName\": \"sample1\","},{"line_number":205,"context_line":"        \"vnfInstanceDescription\": \"test sample1\","},{"line_number":206,"context_line":"        \"metadata\": {\"dummy-key\": \"dummy-val\"}"},{"line_number":207,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":16,"id":"70a25cd6_f8438955","line":204,"in_reply_to":"3f022478_9f9edf6a","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 18","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    #  - 1..N (2 or more)"},{"line_number":202,"context_line":"    return {"},{"line_number":203,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":204,"context_line":"        \"vnfInstanceName\": \"sample1\","},{"line_number":205,"context_line":"        \"vnfInstanceDescription\": \"test sample1\","},{"line_number":206,"context_line":"        \"metadata\": {\"dummy-key\": \"dummy-val\"}"},{"line_number":207,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f211e8f_65f99daf","line":204,"in_reply_to":"70a25cd6_f8438955","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":202,"context_line":"    return {"},{"line_number":203,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":204,"context_line":"        \"vnfInstanceName\": \"sample1\","},{"line_number":205,"context_line":"        \"vnfInstanceDescription\": \"test sample1\","},{"line_number":206,"context_line":"        \"metadata\": {\"dummy-key\": \"dummy-val\"}"},{"line_number":207,"context_line":"    }"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba17734d_cd5cb241","line":205,"updated":"2022-03-02 05:50:54.000000000","message":"I think that \"test sample\" is better because it is used for other than sample1.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":202,"context_line":"    return {"},{"line_number":203,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":204,"context_line":"        \"vnfInstanceName\": \"sample1\","},{"line_number":205,"context_line":"        \"vnfInstanceDescription\": \"test sample1\","},{"line_number":206,"context_line":"        \"metadata\": {\"dummy-key\": \"dummy-val\"}"},{"line_number":207,"context_line":"    }"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"d1292ffa_1d2d6313","line":205,"in_reply_to":"ba17734d_cd5cb241","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 18","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":202,"context_line":"    return {"},{"line_number":203,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":204,"context_line":"        \"vnfInstanceName\": \"sample1\","},{"line_number":205,"context_line":"        \"vnfInstanceDescription\": \"test sample1\","},{"line_number":206,"context_line":"        \"metadata\": {\"dummy-key\": \"dummy-val\"}"},{"line_number":207,"context_line":"    }"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ad241bf2_1f060553","line":205,"in_reply_to":"d1292ffa_1d2d6313","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"}],"tacker/tests/functional/sol_v2/samples/common/Definitions/etsi_nfv_sol001_common_types.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a2a156173689040e0dba851cd93fbb8e63c60288","unresolved":true,"context_lines":[{"line_number":8,"context_line":"data_types:"},{"line_number":9,"context_line":"  tosca.datatypes.nfv.L2AddressData:"},{"line_number":10,"context_line":"    derived_from: tosca.datatypes.Root"},{"line_number":11,"context_line":"    description: Describes the information on the MAC addresses to be assigned to a connection point. "},{"line_number":12,"context_line":"    properties:"},{"line_number":13,"context_line":"      mac_address_assignment:"},{"line_number":14,"context_line":"        type: boolean"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"db1f2775_46a745e0","line":11,"range":{"start_line":11,"start_character":101,"end_line":11,"end_character":102},"updated":"2022-03-01 01:59:25.000000000","message":"A lot of unnecessary space has been added to this file.\nPlease do not modify this file and just move it.","commit_id":"621ad795b5db51ebebf97b87e242fbbec7a46dc8"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":false,"context_lines":[{"line_number":8,"context_line":"data_types:"},{"line_number":9,"context_line":"  tosca.datatypes.nfv.L2AddressData:"},{"line_number":10,"context_line":"    derived_from: tosca.datatypes.Root"},{"line_number":11,"context_line":"    description: Describes the information on the MAC addresses to be assigned to a connection point. "},{"line_number":12,"context_line":"    properties:"},{"line_number":13,"context_line":"      mac_address_assignment:"},{"line_number":14,"context_line":"        type: boolean"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"8cc6990b_0546ca68","line":11,"range":{"start_line":11,"start_character":101,"end_line":11,"end_character":102},"in_reply_to":"b801f5b1_c99158db","updated":"2022-03-02 05:50:54.000000000","message":"Done","commit_id":"621ad795b5db51ebebf97b87e242fbbec7a46dc8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"96984adfc37584028ff99d786f9418726dc8b141","unresolved":true,"context_lines":[{"line_number":8,"context_line":"data_types:"},{"line_number":9,"context_line":"  tosca.datatypes.nfv.L2AddressData:"},{"line_number":10,"context_line":"    derived_from: tosca.datatypes.Root"},{"line_number":11,"context_line":"    description: Describes the information on the MAC addresses to be assigned to a connection point. "},{"line_number":12,"context_line":"    properties:"},{"line_number":13,"context_line":"      mac_address_assignment:"},{"line_number":14,"context_line":"        type: boolean"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b801f5b1_c99158db","line":11,"range":{"start_line":11,"start_character":101,"end_line":11,"end_character":102},"in_reply_to":"db1f2775_46a745e0","updated":"2022-03-02 00:25:15.000000000","message":"I fixed it in the patchset 15.","commit_id":"621ad795b5db51ebebf97b87e242fbbec7a46dc8"}],"tacker/tests/functional/sol_v2/samples/common/Definitions/etsi_nfv_sol001_vnfd_types.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"a2a156173689040e0dba851cd93fbb8e63c60288","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"imports:"},{"line_number":9,"context_line":"  - ./etsi_nfv_sol001_common_types.yaml"},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"data_types:"},{"line_number":12,"context_line":"  tosca.datatypes.nfv.VirtualNetworkInterfaceRequirements:"},{"line_number":13,"context_line":"    derived_from: tosca.datatypes.Root"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b1049081_3efd7b1f","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2022-03-01 01:59:25.000000000","message":"A lot of unnecessary space has been added to this file.\nPlease do not modify this file and just move it","commit_id":"621ad795b5db51ebebf97b87e242fbbec7a46dc8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"96984adfc37584028ff99d786f9418726dc8b141","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"imports:"},{"line_number":9,"context_line":"  - ./etsi_nfv_sol001_common_types.yaml"},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"data_types:"},{"line_number":12,"context_line":"  tosca.datatypes.nfv.VirtualNetworkInterfaceRequirements:"},{"line_number":13,"context_line":"    derived_from: tosca.datatypes.Root"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d03a474f_ce51e1f3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"in_reply_to":"b1049081_3efd7b1f","updated":"2022-03-02 00:25:15.000000000","message":"I fixed it in the patchset 15.","commit_id":"621ad795b5db51ebebf97b87e242fbbec7a46dc8"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"imports:"},{"line_number":9,"context_line":"  - ./etsi_nfv_sol001_common_types.yaml"},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"data_types:"},{"line_number":12,"context_line":"  tosca.datatypes.nfv.VirtualNetworkInterfaceRequirements:"},{"line_number":13,"context_line":"    derived_from: tosca.datatypes.Root"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"70e260fd_5d910779","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"in_reply_to":"d03a474f_ce51e1f3","updated":"2022-03-02 05:50:54.000000000","message":"Done","commit_id":"621ad795b5db51ebebf97b87e242fbbec7a46dc8"}],"tacker/tests/functional/sol_v2/samples/error_network/contents/Definitions/etsi_nfv_sol001_common_types.yaml":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0419c2d4cbf7f27e0d787dbe6568360a0a301bb6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  template_name: etsi_nfv_sol001_common_types"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"d27e3b02_afc183a2","line":1,"updated":"2022-02-09 05:36:40.000000000","message":"As I have already commented the below patch, is it possible to commonize these like V1-FT package?\n---\nhttps://review.opendev.org/c/openstack/tacker/+/826249/3/tacker/tests/functional/sol_v2/samples/test_change_vnf_pkg_with_new_image/contents/Definitions/etsi_nfv_sol001_common_types.yaml#1","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  template_name: etsi_nfv_sol001_common_types"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7c715130_d32b78dd","line":1,"in_reply_to":"6a7b645b_2980e643","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":"description: ETSI NFV SOL 001 common types definitions version 2.6.1"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  template_name: etsi_nfv_sol001_common_types"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6a7b645b_2980e643","line":1,"in_reply_to":"d27e3b02_afc183a2","updated":"2022-02-09 08:22:30.000000000","message":"I fixed it in patch set 8","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"}],"tacker/tests/functional/sol_v2/samples/scale_ng/contents/Scripts/sample_script.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"261e5369d0088a9c8e674e06f9ca5ba50497680f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":20,"id":"f098cc70_528a50ab","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"updated":"2022-03-09 09:40:08.000000000","message":"Let me confirm the name of corp is correct here and other python files?","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4dd72de284eeabc46591cea53a026e9ca0717f3e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":20,"id":"0c388e83_7f466dcb","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"in_reply_to":"70990622_055e9314","updated":"2022-03-10 06:12:34.000000000","message":"Please confirm it ASAP. Cause I needed to feedback the modification to the other 2 patchs.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7c2c3ee13e99c8aac39a929e6b64f3aa326d3289","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":20,"id":"70990622_055e9314","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":22},"in_reply_to":"f098cc70_528a50ab","updated":"2022-03-10 01:50:50.000000000","message":"Please check it.\nIt was copied from sample1.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"}],"tacker/tests/functional/sol_v2/samples/scale_ng/contents/UserData/userdata.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"261e5369d0088a9c8e674e06f9ca5ba50497680f","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        if \u0027nfv\u0027 in req.get(\u0027additionalParams\u0027, {}):"},{"line_number":110,"context_line":"            nfv_dict \u003d inst_utils.json_merge_patch(nfv_dict,"},{"line_number":111,"context_line":"                    req[\u0027additionalParams\u0027][\u0027nfv\u0027])"},{"line_number":112,"context_line":"        if \u0027nfv\u0027 in grant.get(\u0027additionalParams\u0027, {}):"},{"line_number":113,"context_line":"            nfv_dict \u003d inst_utils.json_merge_patch(nfv_dict,"},{"line_number":114,"context_line":"                    grant[\u0027additionalParams\u0027][\u0027nfv\u0027])"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"f7afe067_e074517c","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":10},"updated":"2022-03-09 09:40:08.000000000","message":"elif?","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4dd72de284eeabc46591cea53a026e9ca0717f3e","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        if \u0027nfv\u0027 in req.get(\u0027additionalParams\u0027, {}):"},{"line_number":110,"context_line":"            nfv_dict \u003d inst_utils.json_merge_patch(nfv_dict,"},{"line_number":111,"context_line":"                    req[\u0027additionalParams\u0027][\u0027nfv\u0027])"},{"line_number":112,"context_line":"        if \u0027nfv\u0027 in grant.get(\u0027additionalParams\u0027, {}):"},{"line_number":113,"context_line":"            nfv_dict \u003d inst_utils.json_merge_patch(nfv_dict,"},{"line_number":114,"context_line":"                    grant[\u0027additionalParams\u0027][\u0027nfv\u0027])"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"440f1b0d_7311ed09","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":10},"in_reply_to":"ccc56477_43fc9d7f","updated":"2022-03-10 06:12:34.000000000","message":"Please confirm it ASAP. Cause I needed to feedback the modification to the other 2 patchs.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7c2c3ee13e99c8aac39a929e6b64f3aa326d3289","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        if \u0027nfv\u0027 in req.get(\u0027additionalParams\u0027, {}):"},{"line_number":110,"context_line":"            nfv_dict \u003d inst_utils.json_merge_patch(nfv_dict,"},{"line_number":111,"context_line":"                    req[\u0027additionalParams\u0027][\u0027nfv\u0027])"},{"line_number":112,"context_line":"        if \u0027nfv\u0027 in grant.get(\u0027additionalParams\u0027, {}):"},{"line_number":113,"context_line":"            nfv_dict \u003d inst_utils.json_merge_patch(nfv_dict,"},{"line_number":114,"context_line":"                    grant[\u0027additionalParams\u0027][\u0027nfv\u0027])"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ccc56477_43fc9d7f","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":10},"in_reply_to":"f7afe067_e074517c","updated":"2022-03-10 01:50:50.000000000","message":"It was copied from sample1. I think the grant value(L113) is preferentially. So it can\u0027t be changed to elif.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"}],"tacker/tests/functional/sol_v2/test_vnflcm_basic.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":269,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # check creation of Heat-stack"},{"line_number":272,"context_line":"        stack_name \u003d \"vnf-{}\".format(inst_id)"},{"line_number":273,"context_line":"        stack_status, _ \u003d self.heat_client.get_status(stack_name)"},{"line_number":274,"context_line":"        self.assertEqual(\"CREATE_COMPLETE\", stack_status)"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c7bf830b_228f295a","line":272,"updated":"2022-02-08 10:31:33.000000000","message":"For consistency, could you refactor to the following using f-string, like L1142?\n```\nstack_name \u003d f\u0027vnf-{inst_id}\u0027\n```","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # check creation of Heat-stack"},{"line_number":272,"context_line":"        stack_name \u003d \"vnf-{}\".format(inst_id)"},{"line_number":273,"context_line":"        stack_status, _ \u003d self.heat_client.get_status(stack_name)"},{"line_number":274,"context_line":"        self.assertEqual(\"CREATE_COMPLETE\", stack_status)"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c9628e5c_3bfd9419","line":272,"in_reply_to":"6cd52473_9999391a","updated":"2022-02-15 09:55:29.000000000","message":"I could check it on the below patch.\n---\nhttps://review.opendev.org/c/openstack/tacker/+/829156/1/tacker/tests/functional/sol_v2/paramgen.py","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":269,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # check creation of Heat-stack"},{"line_number":272,"context_line":"        stack_name \u003d \"vnf-{}\".format(inst_id)"},{"line_number":273,"context_line":"        stack_status, _ \u003d self.heat_client.get_status(stack_name)"},{"line_number":274,"context_line":"        self.assertEqual(\"CREATE_COMPLETE\", stack_status)"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"6cd52473_9999391a","line":272,"in_reply_to":"c7bf830b_228f295a","updated":"2022-02-09 08:22:30.000000000","message":"test_sample1() and test_sample2 will be updated in other patch. I will fix it in other patch.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":518,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        # check creation of Heat-stack"},{"line_number":521,"context_line":"        stack_name \u003d \"vnf-{}\".format(inst_id)"},{"line_number":522,"context_line":"        stack_status, _ \u003d self.heat_client.get_status(stack_name)"},{"line_number":523,"context_line":"        self.assertEqual(\"CREATE_COMPLETE\", stack_status)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"4310c48c_a712e490","line":521,"updated":"2022-02-08 10:31:33.000000000","message":"For consistency, could you refactor to the following using f-string, like L1142?\n```\nstack_name \u003d f\u0027vnf-{inst_id}\u0027\n```","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":518,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        # check creation of Heat-stack"},{"line_number":521,"context_line":"        stack_name \u003d \"vnf-{}\".format(inst_id)"},{"line_number":522,"context_line":"        stack_status, _ \u003d self.heat_client.get_status(stack_name)"},{"line_number":523,"context_line":"        self.assertEqual(\"CREATE_COMPLETE\", stack_status)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8131484b_e3b0464b","line":521,"in_reply_to":"4310c48c_a712e490","updated":"2022-02-09 08:22:30.000000000","message":"test_sample1() and test_sample2 will be updated in other patch. I will fix it in other patch.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        # check creation of Heat-stack"},{"line_number":521,"context_line":"        stack_name \u003d \"vnf-{}\".format(inst_id)"},{"line_number":522,"context_line":"        stack_status, _ \u003d self.heat_client.get_status(stack_name)"},{"line_number":523,"context_line":"        self.assertEqual(\"CREATE_COMPLETE\", stack_status)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c44b3398_60261bb9","line":521,"in_reply_to":"8131484b_e3b0464b","updated":"2022-02-15 09:55:29.000000000","message":"I could check it on the below patch.\n---\nhttps://review.opendev.org/c/openstack/tacker/+/829156/1/tacker/tests/functional/sol_v2/paramgen.py","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":591,"context_line":"          - 3. Create VNF instance"},{"line_number":592,"context_line":"          - 4. Instantiate VNF"},{"line_number":593,"context_line":"          - 5. Show VNF instance"},{"line_number":594,"context_line":"          - 6. Scale out operation"},{"line_number":595,"context_line":"          - 7. Show VNF instance"},{"line_number":596,"context_line":"          - 8. Retry operation"},{"line_number":597,"context_line":"          - 9. Rollback scaleout operation"}],"source_content_type":"text/x-python","patch_set":6,"id":"d9441d08_f61d81c2","line":594,"range":{"start_line":594,"start_character":15,"end_line":594,"end_character":34},"updated":"2022-02-08 10:31:33.000000000","message":"It\u0027s better to add \"(will fail)\".","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":591,"context_line":"          - 3. Create VNF instance"},{"line_number":592,"context_line":"          - 4. Instantiate VNF"},{"line_number":593,"context_line":"          - 5. Show VNF instance"},{"line_number":594,"context_line":"          - 6. Scale out operation"},{"line_number":595,"context_line":"          - 7. Show VNF instance"},{"line_number":596,"context_line":"          - 8. Retry operation"},{"line_number":597,"context_line":"          - 9. Rollback scaleout operation"}],"source_content_type":"text/x-python","patch_set":6,"id":"df989323_ba192855","line":594,"range":{"start_line":594,"start_character":15,"end_line":594,"end_character":34},"in_reply_to":"c1dc892c_9369916c","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":591,"context_line":"          - 3. Create VNF instance"},{"line_number":592,"context_line":"          - 4. Instantiate VNF"},{"line_number":593,"context_line":"          - 5. Show VNF instance"},{"line_number":594,"context_line":"          - 6. Scale out operation"},{"line_number":595,"context_line":"          - 7. Show VNF instance"},{"line_number":596,"context_line":"          - 8. Retry operation"},{"line_number":597,"context_line":"          - 9. Rollback scaleout operation"}],"source_content_type":"text/x-python","patch_set":6,"id":"c1dc892c_9369916c","line":594,"range":{"start_line":594,"start_character":15,"end_line":594,"end_character":34},"in_reply_to":"d9441d08_f61d81c2","updated":"2022-02-09 08:22:30.000000000","message":"I fixed it in patchset 7.\nFor consistency, I also modified other comment contents.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":654,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_3)[\u0027usageState\u0027]"},{"line_number":655,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        # 3. Create a new VNF instance resource"},{"line_number":658,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":659,"context_line":"            \u0027id\u0027,"},{"line_number":660,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":6,"id":"63638559_371d8fcf","line":657,"updated":"2022-02-08 10:31:33.000000000","message":"Unless you have a specific reason, it\u0027s better to be the same as \"Create VNF instance\" of L591.\nThe same applies to other places.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_3)[\u0027usageState\u0027]"},{"line_number":655,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        # 3. Create a new VNF instance resource"},{"line_number":658,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":659,"context_line":"            \u0027id\u0027,"},{"line_number":660,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":6,"id":"b3d51fdd_df06fd9f","line":657,"in_reply_to":"129514a8_9d4959cf","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":654,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_3)[\u0027usageState\u0027]"},{"line_number":655,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        # 3. Create a new VNF instance resource"},{"line_number":658,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":659,"context_line":"            \u0027id\u0027,"},{"line_number":660,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":6,"id":"129514a8_9d4959cf","line":657,"in_reply_to":"63638559_371d8fcf","updated":"2022-02-09 08:22:30.000000000","message":"I fixed it in patchset 7.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":718,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":719,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        # 6. Scale out operation（will fail）"},{"line_number":722,"context_line":"        scaleout_req \u003d paramgen.scaleout_max()"},{"line_number":723,"context_line":"        resp, body \u003d self.scale_vnf_instance(inst_id, scaleout_req)"},{"line_number":724,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":6,"id":"cd275419_f176072d","line":721,"updated":"2022-02-08 10:31:33.000000000","message":"It\u0027s better to use half-width character, not full-width character.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":718,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":719,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        # 6. Scale out operation（will fail）"},{"line_number":722,"context_line":"        scaleout_req \u003d paramgen.scaleout_max()"},{"line_number":723,"context_line":"        resp, body \u003d self.scale_vnf_instance(inst_id, scaleout_req)"},{"line_number":724,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":6,"id":"025e9e68_d068ee36","line":721,"in_reply_to":"83a07a9f_23653a46","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":718,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":719,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        # 6. Scale out operation（will fail）"},{"line_number":722,"context_line":"        scaleout_req \u003d paramgen.scaleout_max()"},{"line_number":723,"context_line":"        resp, body \u003d self.scale_vnf_instance(inst_id, scaleout_req)"},{"line_number":724,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":6,"id":"83a07a9f_23653a46","line":721,"in_reply_to":"cd275419_f176072d","updated":"2022-02-09 08:22:30.000000000","message":"I fixed it in patchset 7.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":747,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":748,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        # 9. Rollback scaleout operation"},{"line_number":751,"context_line":"        resp, body \u003d self.rollback_lcm(lcmocc_id)"},{"line_number":752,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":753,"context_line":"        self.check_resp_headers_in_delete(resp)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ec06d30f_283c098c","line":750,"updated":"2022-02-08 10:31:33.000000000","message":"Nit: \"scale out\" is better.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":748,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        # 9. Rollback scaleout operation"},{"line_number":751,"context_line":"        resp, body \u003d self.rollback_lcm(lcmocc_id)"},{"line_number":752,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":753,"context_line":"        self.check_resp_headers_in_delete(resp)"}],"source_content_type":"text/x-python","patch_set":6,"id":"e36ae810_5299a6b6","line":750,"in_reply_to":"c4f246d9_987afd33","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":747,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":748,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        # 9. Rollback scaleout operation"},{"line_number":751,"context_line":"        resp, body \u003d self.rollback_lcm(lcmocc_id)"},{"line_number":752,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":753,"context_line":"        self.check_resp_headers_in_delete(resp)"}],"source_content_type":"text/x-python","patch_set":6,"id":"c4f246d9_987afd33","line":750,"in_reply_to":"ec06d30f_283c098c","updated":"2022-02-09 08:22:30.000000000","message":"I fixed it in patchset 7.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        # 15. Show subscription"},{"line_number":828,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":829,"context_line":"        # uncomment when BUG \"https://bugs.launchpad.net/tacker/+bug/1959168\""},{"line_number":830,"context_line":"        # fixed"},{"line_number":831,"context_line":"        # self.assertEqual(404, resp.status_code)"},{"line_number":832,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d6c3e9cb_b3f2fa3f","line":829,"updated":"2022-02-08 10:31:33.000000000","message":"I think the patch will be merged soon, but at this point it\u0027s better to include TODO.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        # 15. Show subscription"},{"line_number":828,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":829,"context_line":"        # uncomment when BUG \"https://bugs.launchpad.net/tacker/+bug/1959168\""},{"line_number":830,"context_line":"        # fixed"},{"line_number":831,"context_line":"        # self.assertEqual(404, resp.status_code)"},{"line_number":832,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"db293d6b_42071bfe","line":829,"in_reply_to":"d6c3e9cb_b3f2fa3f","updated":"2022-02-09 08:22:30.000000000","message":"I fixed it in patchset 7.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        # 15. Show subscription"},{"line_number":828,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":829,"context_line":"        # uncomment when BUG \"https://bugs.launchpad.net/tacker/+bug/1959168\""},{"line_number":830,"context_line":"        # fixed"},{"line_number":831,"context_line":"        # self.assertEqual(404, resp.status_code)"},{"line_number":832,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5b44db06_70aacb62","line":829,"in_reply_to":"db293d6b_42071bfe","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"01cc8d446c918683e7a49563c514038ea6a0703f","unresolved":true,"context_lines":[{"line_number":907,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":908,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        # 4. Instantiate a VNF instance"},{"line_number":911,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_min()"},{"line_number":912,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":913,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":6,"id":"a862cfe7_61038cfd","line":910,"updated":"2022-02-08 10:31:33.000000000","message":"It\u0027s better to add \"(will fail)\".","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"41756521f4d75c9b945756b734a06eb4cd30319e","unresolved":true,"context_lines":[{"line_number":907,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":908,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        # 4. Instantiate a VNF instance"},{"line_number":911,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_min()"},{"line_number":912,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":913,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":6,"id":"c38deadc_8ca6ad40","line":910,"in_reply_to":"a862cfe7_61038cfd","updated":"2022-02-09 08:22:30.000000000","message":"I fixed it in patchset 7.","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da1078dace91182b266b9b5dbacd2a20ff46cbf","unresolved":false,"context_lines":[{"line_number":907,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":908,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        # 4. Instantiate a VNF instance"},{"line_number":911,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_min()"},{"line_number":912,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":913,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":6,"id":"470a04a2_c02cfb16","line":910,"in_reply_to":"c38deadc_8ca6ad40","updated":"2022-02-15 09:55:29.000000000","message":"Done","commit_id":"653be100c7bb1f59f1419923f83e92cdfe4de944"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"baf3b0879a718d0f2cffbe8309236d9964da1ace","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        # no image contained"},{"line_number":46,"context_line":"        cls.vnf_pkg_2, cls.vnfd_id_2 \u003d cls.create_vnf_package(sample2_path)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        scale_ng_path \u003d os.path.join(cur_dir, \"samples/scale_ng\")"},{"line_number":49,"context_line":"        cls.vnf_pkg_3, cls.vnfd_id_3 \u003d cls.create_vnf_package("},{"line_number":50,"context_line":"            scale_ng_path, image_path\u003dimage_path)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"a25b7e62_d51bb02d","line":48,"updated":"2022-02-15 07:32:59.000000000","message":"What does \"ng\" stand for?","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"49e23b6ccc015658e9f39708819bbfb5fcf44a20","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        # no image contained"},{"line_number":46,"context_line":"        cls.vnf_pkg_2, cls.vnfd_id_2 \u003d cls.create_vnf_package(sample2_path)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        scale_ng_path \u003d os.path.join(cur_dir, \"samples/scale_ng\")"},{"line_number":49,"context_line":"        cls.vnf_pkg_3, cls.vnfd_id_3 \u003d cls.create_vnf_package("},{"line_number":50,"context_line":"            scale_ng_path, image_path\u003dimage_path)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"b31b930e_728aec5c","line":48,"in_reply_to":"a25b7e62_d51bb02d","updated":"2022-02-18 05:29:02.000000000","message":"It means fail. Scale operation will fail when using this vnf package.\nI added comment to explain it in the patch set 11.","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"93507b5ff709def723b624cd30d226e2a008be40","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        # no image contained"},{"line_number":46,"context_line":"        cls.vnf_pkg_2, cls.vnfd_id_2 \u003d cls.create_vnf_package(sample2_path)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        scale_ng_path \u003d os.path.join(cur_dir, \"samples/scale_ng\")"},{"line_number":49,"context_line":"        cls.vnf_pkg_3, cls.vnfd_id_3 \u003d cls.create_vnf_package("},{"line_number":50,"context_line":"            scale_ng_path, image_path\u003dimage_path)"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1c6b0511_924904f1","line":48,"in_reply_to":"b31b930e_728aec5c","updated":"2022-02-24 07:15:11.000000000","message":"good! thanks.","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"baf3b0879a718d0f2cffbe8309236d9964da1ace","unresolved":true,"context_lines":[{"line_number":571,"context_line":"        # check usageState of VNF Package"},{"line_number":572,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_2)[\u0027usageState\u0027]"},{"line_number":573,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":576,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"a01f6cfb_c0e5ffa5","line":574,"updated":"2022-02-15 07:32:59.000000000","message":"Isn\u0027t it possible to define these tests in a different file or a different class?\n\nThe filename is ``test_vnflcm_basic``. This is not a basic test, but error handling. In SOL003 these operations are grouped as ``VNF LCM operation occurrences`` and given a different endpoint ``{apiRoot}/vnflcm/{apiMajorVersion}/vnf_lcm_op_occs`` from the basic operations like instantiation/termination. \n\nIMO, we should keep a test class small as possible for future extensibility. If we allow us to implement several different test scenarios into a single class, the test class gets bigger and bigger.","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"49e23b6ccc015658e9f39708819bbfb5fcf44a20","unresolved":true,"context_lines":[{"line_number":571,"context_line":"        # check usageState of VNF Package"},{"line_number":572,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_2)[\u0027usageState\u0027]"},{"line_number":573,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":576,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fae8391d_8f261359","line":574,"in_reply_to":"a01f6cfb_c0e5ffa5","updated":"2022-02-18 05:29:02.000000000","message":"I added VnfLcmErrorHandlingTest class to test the error handling.\nI fixed it in the patch set 11.","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"93507b5ff709def723b624cd30d226e2a008be40","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        # check usageState of VNF Package"},{"line_number":572,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_2)[\u0027usageState\u0027]"},{"line_number":573,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":576,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":577,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"57f7c286_64e6f451","line":574,"in_reply_to":"fae8391d_8f261359","updated":"2022-02-24 07:15:11.000000000","message":"I confirmed it. Thank you.","commit_id":"d191671242253253df8fce1295cd867a0b625ebc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"261e5369d0088a9c8e674e06f9ca5ba50497680f","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        # 0. Pre-setting"},{"line_number":120,"context_line":"        callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":121,"context_line":"                                    self._testMethodName)"},{"line_number":122,"context_line":"        callback_uri \u003d (f\u0027http://localhost:\u0027"},{"line_number":123,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":124,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"8d4f4bd2_0fa14937","line":122,"range":{"start_line":122,"start_character":24,"end_line":122,"end_character":25},"updated":"2022-03-09 09:40:08.000000000","message":"nit: it\u0027s useless.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4dd72de284eeabc46591cea53a026e9ca0717f3e","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        # 0. Pre-setting"},{"line_number":120,"context_line":"        callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":121,"context_line":"                                    self._testMethodName)"},{"line_number":122,"context_line":"        callback_uri \u003d (f\u0027http://localhost:\u0027"},{"line_number":123,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":124,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"57d46beb_667e3524","line":122,"range":{"start_line":122,"start_character":24,"end_line":122,"end_character":25},"in_reply_to":"0da4bb31_f863d1b7","updated":"2022-03-10 06:12:34.000000000","message":"Please confirm it ASAP. Cause I needed to feedback the modification to the other 2 patchs.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7c2c3ee13e99c8aac39a929e6b64f3aa326d3289","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        # 0. Pre-setting"},{"line_number":120,"context_line":"        callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":121,"context_line":"                                    self._testMethodName)"},{"line_number":122,"context_line":"        callback_uri \u003d (f\u0027http://localhost:\u0027"},{"line_number":123,"context_line":"                        f\u0027{base_v2.FAKE_SERVER_MANAGER.SERVER_PORT}\u0027"},{"line_number":124,"context_line":"                        f\u0027{callback_url}\u0027)"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"0da4bb31_f863d1b7","line":122,"range":{"start_line":122,"start_character":24,"end_line":122,"end_character":25},"in_reply_to":"8d4f4bd2_0fa14937","updated":"2022-03-10 01:50:50.000000000","message":"I deleted \"f\".","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"}],"tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        # 3. Create VNF instance"},{"line_number":144,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":145,"context_line":"            \u0027id\u0027,"},{"line_number":146,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"},{"line_number":147,"context_line":"            # \u0027vnfInstanceDescription\u0027, # omitted"},{"line_number":148,"context_line":"            \u0027vnfdId\u0027,"},{"line_number":149,"context_line":"            \u0027vnfProvider\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"8485c0bb_09b83f4d","line":146,"updated":"2022-03-02 05:50:54.000000000","message":"It is set to lcmocc in the case of this test, so I think it is better not to omit it.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        # 3. Create VNF instance"},{"line_number":144,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":145,"context_line":"            \u0027id\u0027,"},{"line_number":146,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"},{"line_number":147,"context_line":"            # \u0027vnfInstanceDescription\u0027, # omitted"},{"line_number":148,"context_line":"            \u0027vnfdId\u0027,"},{"line_number":149,"context_line":"            \u0027vnfProvider\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ab79605b_7fb39c0b","line":146,"in_reply_to":"8485c0bb_09b83f4d","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        # 3. Create VNF instance"},{"line_number":144,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":145,"context_line":"            \u0027id\u0027,"},{"line_number":146,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"},{"line_number":147,"context_line":"            # \u0027vnfInstanceDescription\u0027, # omitted"},{"line_number":148,"context_line":"            \u0027vnfdId\u0027,"},{"line_number":149,"context_line":"            \u0027vnfProvider\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1661cffa_3d69e86a","line":146,"in_reply_to":"8485c0bb_09b83f4d","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":145,"context_line":"            \u0027id\u0027,"},{"line_number":146,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"},{"line_number":147,"context_line":"            # \u0027vnfInstanceDescription\u0027, # omitted"},{"line_number":148,"context_line":"            \u0027vnfdId\u0027,"},{"line_number":149,"context_line":"            \u0027vnfProvider\u0027,"},{"line_number":150,"context_line":"            \u0027vnfProductName\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"e6bbbbd3_45dd241c","line":147,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":145,"context_line":"            \u0027id\u0027,"},{"line_number":146,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"},{"line_number":147,"context_line":"            # \u0027vnfInstanceDescription\u0027, # omitted"},{"line_number":148,"context_line":"            \u0027vnfdId\u0027,"},{"line_number":149,"context_line":"            \u0027vnfProvider\u0027,"},{"line_number":150,"context_line":"            \u0027vnfProductName\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"84843e8e_6e743140","line":147,"in_reply_to":"e6bbbbd3_45dd241c","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":144,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":145,"context_line":"            \u0027id\u0027,"},{"line_number":146,"context_line":"            # \u0027vnfInstanceName\u0027, # omitted"},{"line_number":147,"context_line":"            # \u0027vnfInstanceDescription\u0027, # omitted"},{"line_number":148,"context_line":"            \u0027vnfdId\u0027,"},{"line_number":149,"context_line":"            \u0027vnfProvider\u0027,"},{"line_number":150,"context_line":"            \u0027vnfProductName\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"f5108e87_a731bb1e","line":147,"in_reply_to":"e6bbbbd3_45dd241c","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            # \u0027vimConnectionInfo\u0027, # omitted"},{"line_number":155,"context_line":"            \u0027instantiationState\u0027,"},{"line_number":156,"context_line":"            # \u0027instantiatedVnfInfo\u0027, # omitted"},{"line_number":157,"context_line":"            # \u0027metadata\u0027, # omitted"},{"line_number":158,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":159,"context_line":"            \u0027_links\u0027"},{"line_number":160,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"7c1fe02b_709cb9bc","line":157,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            # \u0027vimConnectionInfo\u0027, # omitted"},{"line_number":155,"context_line":"            \u0027instantiationState\u0027,"},{"line_number":156,"context_line":"            # \u0027instantiatedVnfInfo\u0027, # omitted"},{"line_number":157,"context_line":"            # \u0027metadata\u0027, # omitted"},{"line_number":158,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":159,"context_line":"            \u0027_links\u0027"},{"line_number":160,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"c81e6fff_42cfa8ca","line":157,"in_reply_to":"7c1fe02b_709cb9bc","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            # \u0027vimConnectionInfo\u0027, # omitted"},{"line_number":155,"context_line":"            \u0027instantiationState\u0027,"},{"line_number":156,"context_line":"            # \u0027instantiatedVnfInfo\u0027, # omitted"},{"line_number":157,"context_line":"            # \u0027metadata\u0027, # omitted"},{"line_number":158,"context_line":"            # \u0027extensions\u0027, # omitted"},{"line_number":159,"context_line":"            \u0027_links\u0027"},{"line_number":160,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"7989522a_4b5ca4dc","line":157,"in_reply_to":"7c1fe02b_709cb9bc","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # check instantiationState of VNF"},{"line_number":173,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":174,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":175,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":176,"context_line":"                         body.get(\u0027instantiationState\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a235c72_bf102eed","line":173,"updated":"2022-03-02 05:50:54.000000000","message":"I don\u0027t think this is necessary for the purpose of confirming that the instantiationState is NOT_INSTANTIATED.\n\"VnfInstance.instantiationState\" can be confirmed by the response of create.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # check instantiationState of VNF"},{"line_number":173,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":174,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":175,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":176,"context_line":"                         body.get(\u0027instantiationState\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"13c47a90_3c3686f2","line":173,"in_reply_to":"5a235c72_bf102eed","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # check instantiationState of VNF"},{"line_number":173,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":174,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":175,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":176,"context_line":"                         body.get(\u0027instantiationState\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"667720b9_c91c6cc7","line":173,"in_reply_to":"5a235c72_bf102eed","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # check instantiationState of VNF"},{"line_number":173,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":174,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":175,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":176,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1ce59a45_7ce8212f","line":174,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # check instantiationState of VNF"},{"line_number":173,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":174,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":175,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":176,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"480b49c0_8d3c330a","line":174,"in_reply_to":"1ce59a45_7ce8212f","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        # check instantiationState of VNF"},{"line_number":173,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":174,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":175,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":176,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ecd73f11_0b13727d","line":174,"in_reply_to":"1ce59a45_7ce8212f","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":176,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # 4. Instantiate VNF"},{"line_number":179,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":180,"context_line":"            net_ids, subnet_ids, port_ids, self.auth_url)"},{"line_number":181,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"}],"source_content_type":"text/x-python","patch_set":16,"id":"eeba5442_9da8ef0f","line":178,"updated":"2022-03-02 05:50:54.000000000","message":"Is it unnecessary to check VnfPackageInfo.usageState?","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":176,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # 4. Instantiate VNF"},{"line_number":179,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":180,"context_line":"            net_ids, subnet_ids, port_ids, self.auth_url)"},{"line_number":181,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"}],"source_content_type":"text/x-python","patch_set":16,"id":"4d833b7d_c0058657","line":178,"in_reply_to":"eeba5442_9da8ef0f","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":176,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # 4. Instantiate VNF"},{"line_number":179,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":180,"context_line":"            net_ids, subnet_ids, port_ids, self.auth_url)"},{"line_number":181,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"}],"source_content_type":"text/x-python","patch_set":16,"id":"6ea957be_011b9716","line":178,"in_reply_to":"eeba5442_9da8ef0f","updated":"2022-03-04 08:44:25.000000000","message":"I added it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # 5. Show VNF instance"},{"line_number":189,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":190,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":191,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":192,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"cf03616f_202848de","line":189,"updated":"2022-03-02 05:50:54.000000000","message":"In this test case, the following is also added.\n  - extentions\n  - vnfConfigurableProperties","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # 5. Show VNF instance"},{"line_number":189,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":190,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":191,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":192,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"1047cd98_679fca51","line":189,"in_reply_to":"cf03616f_202848de","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # 5. Show VNF instance"},{"line_number":189,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":190,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":191,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":192,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ef3a416_d0d7834b","line":189,"in_reply_to":"cf03616f_202848de","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # 7. Show VNF instance"},{"line_number":220,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":221,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":222,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":223,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"64d168d8_71d98fca","line":220,"updated":"2022-03-02 05:50:54.000000000","message":"How about using the additional_inst_attrs used in 5 again?","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # 7. Show VNF instance"},{"line_number":220,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":221,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":222,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":223,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"0a9a37a5_0f5d66a3","line":220,"in_reply_to":"64d168d8_71d98fca","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        # 7. Show VNF instance"},{"line_number":220,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":221,"context_line":"            \u0027vimConnectionInfo\u0027,"},{"line_number":222,"context_line":"            \u0027instantiatedVnfInfo\u0027"},{"line_number":223,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"d2143bcc_319fd0c5","line":220,"in_reply_to":"64d168d8_71d98fca","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":247,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":248,"context_line":"            \u0027startTime\u0027,"},{"line_number":249,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":250,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":251,"context_line":"            \u0027operation\u0027,"},{"line_number":252,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":253,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"8658434a_b097e33d","line":250,"updated":"2022-03-02 05:50:54.000000000","message":"It is set to lcmocc in the case of this test, so I think it is better not to omit it.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":248,"context_line":"            \u0027startTime\u0027,"},{"line_number":249,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":250,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":251,"context_line":"            \u0027operation\u0027,"},{"line_number":252,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":253,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"b1c7d15f_75a48f02","line":250,"in_reply_to":"8658434a_b097e33d","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":247,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":248,"context_line":"            \u0027startTime\u0027,"},{"line_number":249,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":250,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":251,"context_line":"            \u0027operation\u0027,"},{"line_number":252,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":253,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"71c05a74_c92eb48b","line":250,"in_reply_to":"8658434a_b097e33d","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":250,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":251,"context_line":"            \u0027operation\u0027,"},{"line_number":252,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":253,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":254,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":255,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":256,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"eb802ace_ec90484e","line":253,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":251,"context_line":"            \u0027operation\u0027,"},{"line_number":252,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":253,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":254,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":255,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":256,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"7e9181f7_9fc32d06","line":253,"in_reply_to":"eb802ace_ec90484e","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":250,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":251,"context_line":"            \u0027operation\u0027,"},{"line_number":252,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":253,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":254,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":255,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":256,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"80691856_2435f9b2","line":253,"in_reply_to":"eb802ace_ec90484e","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":253,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":254,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":255,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":256,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":257,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":258,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":259,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"c91c561c_24bd9781","line":256,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":254,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":255,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":256,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":257,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":258,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":259,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"1604c6c6_c6a100a3","line":256,"in_reply_to":"c91c561c_24bd9781","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":253,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":254,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":255,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":256,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":257,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":258,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":259,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"492f7e55_5dcf1337","line":256,"in_reply_to":"c91c561c_24bd9781","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":310,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":311,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # 15. Show subscription"},{"line_number":314,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":315,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3cc2dec2_e6e9f66d","line":313,"updated":"2022-03-02 05:50:54.000000000","message":"Is it unnecessary to check the response header?","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":311,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # 15. Show subscription"},{"line_number":314,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":315,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"f3d9ace3_ae3eaed7","line":313,"in_reply_to":"30eef1f2_07ec025c","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":310,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":311,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # 15. Show subscription"},{"line_number":314,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":315,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"30eef1f2_07ec025c","line":313,"in_reply_to":"3cc2dec2_e6e9f66d","updated":"2022-03-04 08:44:25.000000000","message":"I added it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":386,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        # check instantiationState of VNF"},{"line_number":389,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":390,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":391,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":392,"context_line":"                         body.get(\u0027instantiationState\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"5706cc25_10b687d7","line":389,"updated":"2022-03-02 05:50:54.000000000","message":"I don\u0027t think this is necessary for the purpose of confirming that the instantiationState is NOT_INSTANTIATED.\n\"VnfInstance.instantiationState\" can be confirmed by the response of create.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        # check instantiationState of VNF"},{"line_number":389,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":390,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":391,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":392,"context_line":"                         body.get(\u0027instantiationState\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"0fadd468_299a0934","line":389,"in_reply_to":"5706cc25_10b687d7","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":386,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        # check instantiationState of VNF"},{"line_number":389,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":390,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":391,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":392,"context_line":"                         body.get(\u0027instantiationState\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"c4833704_50fe2dcf","line":389,"in_reply_to":"5706cc25_10b687d7","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        # check instantiationState of VNF"},{"line_number":389,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":390,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":391,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":392,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7f5f069c_863e1104","line":390,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        # check instantiationState of VNF"},{"line_number":389,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":390,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":391,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":392,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7bca38c9_fb2436ca","line":390,"in_reply_to":"7f5f069c_863e1104","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        # check instantiationState of VNF"},{"line_number":389,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":390,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":391,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":392,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1cf9e408_232a0af2","line":390,"in_reply_to":"7f5f069c_863e1104","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":391,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":392,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        # 4. Instantiate VNF(will fail)"},{"line_number":395,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_min()"},{"line_number":396,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":397,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":16,"id":"e2c502e3_d46403d3","line":394,"updated":"2022-03-02 05:50:54.000000000","message":"Is it unnecessary to check VnfPackageInfo.usageState?","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":392,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        # 4. Instantiate VNF(will fail)"},{"line_number":395,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_min()"},{"line_number":396,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":397,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3688a198_06c5a86c","line":394,"in_reply_to":"e2c502e3_d46403d3","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":391,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":392,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        # 4. Instantiate VNF(will fail)"},{"line_number":395,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_min()"},{"line_number":396,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":397,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":16,"id":"e5c32daa_18272f93","line":394,"in_reply_to":"e2c502e3_d46403d3","updated":"2022-03-04 08:44:25.000000000","message":"I added it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":424,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":425,"context_line":"            \u0027startTime\u0027,"},{"line_number":426,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":427,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":428,"context_line":"            \u0027operation\u0027,"},{"line_number":429,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":430,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"27b2e20e_3e622c0e","line":427,"updated":"2022-03-02 05:50:54.000000000","message":"It is set to lcmocc in the case of this test, so I think it is better not to omit it.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":425,"context_line":"            \u0027startTime\u0027,"},{"line_number":426,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":427,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":428,"context_line":"            \u0027operation\u0027,"},{"line_number":429,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":430,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"daf5c233_1cf033df","line":427,"in_reply_to":"27b2e20e_3e622c0e","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":424,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":425,"context_line":"            \u0027startTime\u0027,"},{"line_number":426,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":427,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":428,"context_line":"            \u0027operation\u0027,"},{"line_number":429,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":430,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"9570842a_04f82655","line":427,"in_reply_to":"27b2e20e_3e622c0e","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":427,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":428,"context_line":"            \u0027operation\u0027,"},{"line_number":429,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":430,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":431,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":432,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":433,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"9c3e8e8e_b6d512e9","line":430,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":427,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":428,"context_line":"            \u0027operation\u0027,"},{"line_number":429,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":430,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":431,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":432,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":433,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"807127ce_f9b72153","line":430,"in_reply_to":"9c3e8e8e_b6d512e9","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":427,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":428,"context_line":"            \u0027operation\u0027,"},{"line_number":429,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":430,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":431,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":432,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":433,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"e2bd865b_0176509e","line":430,"in_reply_to":"9c3e8e8e_b6d512e9","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":431,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":432,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":433,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":434,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":435,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":436,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"f7b5ad88_78f9b660","line":433,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":431,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":432,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":433,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":434,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":435,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":436,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"af29d697_3e78bdab","line":433,"in_reply_to":"f7b5ad88_78f9b660","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":431,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":432,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":433,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":434,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":435,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":436,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"24ae7e2c_aad1a7f1","line":433,"in_reply_to":"f7b5ad88_78f9b660","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":536,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        # check instantiationState of VNF"},{"line_number":539,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":540,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":541,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":542,"context_line":"                         body.get(\u0027instantiationState\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"18a6eabe_f0f2e473","line":539,"updated":"2022-03-02 05:50:54.000000000","message":"I don\u0027t think this is necessary for the purpose of confirming that the instantiationState is NOT_INSTANTIATED.\n\"VnfInstance.instantiationState\" can be confirmed by the response of create.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        # check instantiationState of VNF"},{"line_number":539,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":540,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":541,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":542,"context_line":"                         body.get(\u0027instantiationState\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"d8a7b642_21f3a044","line":539,"in_reply_to":"18a6eabe_f0f2e473","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":536,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        # check instantiationState of VNF"},{"line_number":539,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":540,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":541,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":542,"context_line":"                         body.get(\u0027instantiationState\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"ccfce441_d46ea572","line":539,"in_reply_to":"18a6eabe_f0f2e473","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        # check instantiationState of VNF"},{"line_number":539,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":540,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":541,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":542,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7ff79f45_df8d5674","line":540,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        # check instantiationState of VNF"},{"line_number":539,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":540,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":541,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":542,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1fb6ca58_712fe980","line":540,"in_reply_to":"7ff79f45_df8d5674","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        # check instantiationState of VNF"},{"line_number":539,"context_line":"        resp, body \u003d self.show_vnf_instance(inst_id)"},{"line_number":540,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":541,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":542,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":543,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"81f16b36_741633bd","line":540,"in_reply_to":"7ff79f45_df8d5674","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":541,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":542,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # 4. Instantiate VNF(will fail)"},{"line_number":545,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_min()"},{"line_number":546,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":547,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":16,"id":"53b8d553_f6427cf4","line":544,"updated":"2022-03-02 05:50:54.000000000","message":"Is it unnecessary to check VnfPackageInfo.usageState?","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":542,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # 4. Instantiate VNF(will fail)"},{"line_number":545,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_min()"},{"line_number":546,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":547,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":16,"id":"b17a7ad0_5513517d","line":544,"in_reply_to":"53b8d553_f6427cf4","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":541,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":542,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # 4. Instantiate VNF(will fail)"},{"line_number":545,"context_line":"        instantiate_req \u003d paramgen.instantiate_vnf_min()"},{"line_number":546,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":547,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5f8ad3fd_4b3faa34","line":544,"in_reply_to":"53b8d553_f6427cf4","updated":"2022-03-04 08:44:25.000000000","message":"I addd it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":561,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        # 6. Fail instantiation operation"},{"line_number":564,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":565,"context_line":"            \u0027id\u0027,"},{"line_number":566,"context_line":"            \u0027operationState\u0027,"},{"line_number":567,"context_line":"            \u0027stateEnteredTime\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"67feb2e3_2f832824","line":564,"updated":"2022-03-02 05:50:54.000000000","message":"\"expected_attrs\" is better because these are attributes of lcmocc.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        # 6. Fail instantiation operation"},{"line_number":564,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":565,"context_line":"            \u0027id\u0027,"},{"line_number":566,"context_line":"            \u0027operationState\u0027,"},{"line_number":567,"context_line":"            \u0027stateEnteredTime\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fd2d801d_3fea8958","line":564,"in_reply_to":"67feb2e3_2f832824","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":561,"context_line":"                         body.get(\u0027instantiationState\u0027))"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"        # 6. Fail instantiation operation"},{"line_number":564,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":565,"context_line":"            \u0027id\u0027,"},{"line_number":566,"context_line":"            \u0027operationState\u0027,"},{"line_number":567,"context_line":"            \u0027stateEnteredTime\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"b95b7765_eb50d3ce","line":564,"in_reply_to":"67feb2e3_2f832824","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":567,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":568,"context_line":"            \u0027startTime\u0027,"},{"line_number":569,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":570,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":571,"context_line":"            \u0027operation\u0027,"},{"line_number":572,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":573,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"f7ead40c_5c29b2e1","line":570,"updated":"2022-03-02 05:50:54.000000000","message":"It is set to lcmocc in the case of this test, so I think it is better not to omit it.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":567,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":568,"context_line":"            \u0027startTime\u0027,"},{"line_number":569,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":570,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":571,"context_line":"            \u0027operation\u0027,"},{"line_number":572,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":573,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"6dd347d5_dca6cc2c","line":570,"in_reply_to":"f7ead40c_5c29b2e1","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":567,"context_line":"            \u0027stateEnteredTime\u0027,"},{"line_number":568,"context_line":"            \u0027startTime\u0027,"},{"line_number":569,"context_line":"            \u0027vnfInstanceId\u0027,"},{"line_number":570,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":571,"context_line":"            \u0027operation\u0027,"},{"line_number":572,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":573,"context_line":"            # \u0027operationParams\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"f70d55d1_0812abb5","line":570,"in_reply_to":"f7ead40c_5c29b2e1","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":570,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":571,"context_line":"            \u0027operation\u0027,"},{"line_number":572,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":573,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":574,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":575,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":576,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"7352bc5e_6381465f","line":573,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":571,"context_line":"            \u0027operation\u0027,"},{"line_number":572,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":573,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":574,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":575,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":576,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"8808b95f_a87b7870","line":573,"in_reply_to":"7352bc5e_6381465f","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":570,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":571,"context_line":"            \u0027operation\u0027,"},{"line_number":572,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":573,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":574,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":575,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":576,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"a20674e5_8925e6fd","line":573,"in_reply_to":"7352bc5e_6381465f","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":573,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":574,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":575,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":576,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":577,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":578,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":579,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"be0a138c_5643a9da","line":576,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":573,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":574,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":575,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":576,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":577,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":578,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":579,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"dca64eb2_69bdeec6","line":576,"in_reply_to":"be0a138c_5643a9da","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":573,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":574,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":575,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":576,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":577,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":578,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":579,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":16,"id":"ad058291_64a5c4fc","line":576,"in_reply_to":"be0a138c_5643a9da","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":585,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":586,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":587,"context_line":"        self.check_resp_body(body, expected_inst_attrs)"},{"line_number":588,"context_line":"        resp, body \u003d self.show_lcmocc(lcmocc_id)"},{"line_number":589,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":590,"context_line":"        self.assertEqual(\u0027FAILED\u0027, body[\u0027operationState\u0027])"},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1b33daa1_be03e8ab","line":588,"updated":"2022-03-02 05:50:54.000000000","message":"I don\u0027t think this is necessary for the purpose of confirming that the operationState is FAILED.\n\"VnfLcmOpOcc.operationState\" can be confirmed by the response of fail.","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":585,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":586,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":587,"context_line":"        self.check_resp_body(body, expected_inst_attrs)"},{"line_number":588,"context_line":"        resp, body \u003d self.show_lcmocc(lcmocc_id)"},{"line_number":589,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":590,"context_line":"        self.assertEqual(\u0027FAILED\u0027, body[\u0027operationState\u0027])"},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"8fd5a907_857ff535","line":588,"in_reply_to":"1b33daa1_be03e8ab","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":585,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":586,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":587,"context_line":"        self.check_resp_body(body, expected_inst_attrs)"},{"line_number":588,"context_line":"        resp, body \u003d self.show_lcmocc(lcmocc_id)"},{"line_number":589,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":590,"context_line":"        self.assertEqual(\u0027FAILED\u0027, body[\u0027operationState\u0027])"},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"56584845_473b4504","line":588,"in_reply_to":"1b33daa1_be03e8ab","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":586,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":587,"context_line":"        self.check_resp_body(body, expected_inst_attrs)"},{"line_number":588,"context_line":"        resp, body \u003d self.show_lcmocc(lcmocc_id)"},{"line_number":589,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":590,"context_line":"        self.assertEqual(\u0027FAILED\u0027, body[\u0027operationState\u0027])"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        # 7. Show VNF LCM operation occurrence"}],"source_content_type":"text/x-python","patch_set":16,"id":"23fb3476_f61d4e51","line":589,"updated":"2022-03-02 05:50:54.000000000","message":"ditto","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":587,"context_line":"        self.check_resp_body(body, expected_inst_attrs)"},{"line_number":588,"context_line":"        resp, body \u003d self.show_lcmocc(lcmocc_id)"},{"line_number":589,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":590,"context_line":"        self.assertEqual(\u0027FAILED\u0027, body[\u0027operationState\u0027])"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        # 7. Show VNF LCM operation occurrence"}],"source_content_type":"text/x-python","patch_set":16,"id":"523297de_ff07070c","line":589,"in_reply_to":"23fb3476_f61d4e51","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":586,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":587,"context_line":"        self.check_resp_body(body, expected_inst_attrs)"},{"line_number":588,"context_line":"        resp, body \u003d self.show_lcmocc(lcmocc_id)"},{"line_number":589,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":590,"context_line":"        self.assertEqual(\u0027FAILED\u0027, body[\u0027operationState\u0027])"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        # 7. Show VNF LCM operation occurrence"}],"source_content_type":"text/x-python","patch_set":16,"id":"14a851bf_f57d5eb6","line":589,"in_reply_to":"23fb3476_f61d4e51","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"40d3cf7046e4e2cad37e682dba37357d6f09c5bf","unresolved":true,"context_lines":[{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        # 7. Show VNF LCM operation occurrence"},{"line_number":593,"context_line":"        # NOTE: omitted values are not supported at that time"},{"line_number":594,"context_line":"        expected_attrs \u003d ["},{"line_number":595,"context_line":"            \u0027id\u0027,"},{"line_number":596,"context_line":"            \u0027operationState\u0027,"},{"line_number":597,"context_line":"            \u0027stateEnteredTime\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"750c6943_e949d840","line":594,"updated":"2022-03-02 05:50:54.000000000","message":"How about using the expected_attrs used in 6 again?","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bc14d81f76f856a7ff4c08ea8cc5fedbd2d1d921","unresolved":true,"context_lines":[{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        # 7. Show VNF LCM operation occurrence"},{"line_number":593,"context_line":"        # NOTE: omitted values are not supported at that time"},{"line_number":594,"context_line":"        expected_attrs \u003d ["},{"line_number":595,"context_line":"            \u0027id\u0027,"},{"line_number":596,"context_line":"            \u0027operationState\u0027,"},{"line_number":597,"context_line":"            \u0027stateEnteredTime\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"c3dd661b_694d912e","line":594,"in_reply_to":"750c6943_e949d840","updated":"2022-03-04 08:44:25.000000000","message":"I fixed it in the patchset 17","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"799e366c0bfc426889fc0d27d992bcec381ed737","unresolved":false,"context_lines":[{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        # 7. Show VNF LCM operation occurrence"},{"line_number":593,"context_line":"        # NOTE: omitted values are not supported at that time"},{"line_number":594,"context_line":"        expected_attrs \u003d ["},{"line_number":595,"context_line":"            \u0027id\u0027,"},{"line_number":596,"context_line":"            \u0027operationState\u0027,"},{"line_number":597,"context_line":"            \u0027stateEnteredTime\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"bab1015a_699294a5","line":594,"in_reply_to":"c3dd661b_694d912e","updated":"2022-03-07 05:14:48.000000000","message":"Done","commit_id":"bc42d59820efa94939e1d25709e70f9bb5a52f2d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"68b52aacf70c8cf4b4f1c1a8e7260517b463f21f","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        super(VnfLcmErrorHandlingTest, self).setUp()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":62,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        * About attributes:"},{"line_number":65,"context_line":"          All of the following cardinality attributes are set."}],"source_content_type":"text/x-python","patch_set":18,"id":"ab8f15f7_f4ad3d8a","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":75},"updated":"2022-03-04 13:45:47.000000000","message":"Could you change the docstring to match the purpose of the test?","commit_id":"3869daa336495c6b2304271f770bf2af614932ea"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"39426039ccfca151d5bc5aef70457d0c6c5efc3e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        super(VnfLcmErrorHandlingTest, self).setUp()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":62,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        * About attributes:"},{"line_number":65,"context_line":"          All of the following cardinality attributes are set."}],"source_content_type":"text/x-python","patch_set":18,"id":"ac3c4747_860d2729","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":75},"in_reply_to":"897971dc_16140377","updated":"2022-03-09 08:43:15.000000000","message":"I\u0027ve confirmed.","commit_id":"3869daa336495c6b2304271f770bf2af614932ea"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b9535e275a0fe5fdc418b77db41143d6b8c0a5d2","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        super(VnfLcmErrorHandlingTest, self).setUp()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":62,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        * About attributes:"},{"line_number":65,"context_line":"          All of the following cardinality attributes are set."}],"source_content_type":"text/x-python","patch_set":18,"id":"897971dc_16140377","line":62,"range":{"start_line":62,"start_character":11,"end_line":62,"end_character":75},"in_reply_to":"ab8f15f7_f4ad3d8a","updated":"2022-03-08 00:28:50.000000000","message":"I fixed it in the patchset 19.","commit_id":"3869daa336495c6b2304271f770bf2af614932ea"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"68b52aacf70c8cf4b4f1c1a8e7260517b463f21f","unresolved":true,"context_lines":[{"line_number":337,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def test_rollback_instantiate(self):"},{"line_number":340,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        * About attributes:"},{"line_number":343,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":18,"id":"a9d20827_2dd10704","line":340,"range":{"start_line":340,"start_character":11,"end_line":340,"end_character":75},"updated":"2022-03-04 13:45:47.000000000","message":"Could you change the docstring to match the purpose of the test?","commit_id":"3869daa336495c6b2304271f770bf2af614932ea"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"39426039ccfca151d5bc5aef70457d0c6c5efc3e","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def test_rollback_instantiate(self):"},{"line_number":340,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        * About attributes:"},{"line_number":343,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":18,"id":"9a16e063_cea6b5e9","line":340,"range":{"start_line":340,"start_character":11,"end_line":340,"end_character":75},"in_reply_to":"8b0be8a2_8cd61126","updated":"2022-03-09 08:43:15.000000000","message":"I\u0027ve confirmed.","commit_id":"3869daa336495c6b2304271f770bf2af614932ea"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b9535e275a0fe5fdc418b77db41143d6b8c0a5d2","unresolved":true,"context_lines":[{"line_number":337,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def test_rollback_instantiate(self):"},{"line_number":340,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        * About attributes:"},{"line_number":343,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":18,"id":"8b0be8a2_8cd61126","line":340,"range":{"start_line":340,"start_character":11,"end_line":340,"end_character":75},"in_reply_to":"a9d20827_2dd10704","updated":"2022-03-08 00:28:50.000000000","message":"I fixed it in the patchset 19.","commit_id":"3869daa336495c6b2304271f770bf2af614932ea"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"68b52aacf70c8cf4b4f1c1a8e7260517b463f21f","unresolved":true,"context_lines":[{"line_number":510,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def test_fail_instantiate(self):"},{"line_number":513,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        * About attributes:"},{"line_number":516,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":18,"id":"de078b8d_eb4e3787","line":513,"range":{"start_line":513,"start_character":11,"end_line":513,"end_character":75},"updated":"2022-03-04 13:45:47.000000000","message":"Could you change the docstring to match the purpose of the test?","commit_id":"3869daa336495c6b2304271f770bf2af614932ea"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"39426039ccfca151d5bc5aef70457d0c6c5efc3e","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def test_fail_instantiate(self):"},{"line_number":513,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        * About attributes:"},{"line_number":516,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":18,"id":"1b15c9d0_b2363a4a","line":513,"range":{"start_line":513,"start_character":11,"end_line":513,"end_character":75},"in_reply_to":"72712e37_2c524936","updated":"2022-03-09 08:43:15.000000000","message":"I\u0027ve confirmed.","commit_id":"3869daa336495c6b2304271f770bf2af614932ea"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b9535e275a0fe5fdc418b77db41143d6b8c0a5d2","unresolved":true,"context_lines":[{"line_number":510,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def test_fail_instantiate(self):"},{"line_number":513,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        * About attributes:"},{"line_number":516,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":18,"id":"72712e37_2c524936","line":513,"range":{"start_line":513,"start_character":11,"end_line":513,"end_character":75},"in_reply_to":"de078b8d_eb4e3787","updated":"2022-03-08 00:28:50.000000000","message":"I fixed it in the patchset 19.","commit_id":"3869daa336495c6b2304271f770bf2af614932ea"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"261e5369d0088a9c8e674e06f9ca5ba50497680f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":20,"id":"4dcefaa9_5cad6576","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-03-09 09:40:08.000000000","message":"It must be \"2022\", correct?","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4dd72de284eeabc46591cea53a026e9ca0717f3e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":20,"id":"32f45bdd_8680a6fc","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"220f44c0_340638ca","updated":"2022-03-10 06:12:34.000000000","message":"Please confirm it ASAP. Cause I needed to feedback the modification to the other 2 patchs.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7c2c3ee13e99c8aac39a929e6b64f3aa326d3289","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":20,"id":"220f44c0_340638ca","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"4dcefaa9_5cad6576","updated":"2022-03-10 01:50:50.000000000","message":"Yes. I changed it to 2022.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"261e5369d0088a9c8e674e06f9ca5ba50497680f","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        \"\"\"Test retry and rollback scale out operations"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        * About attributes:"},{"line_number":65,"context_line":"          All of the following cardinality attributes are set."},{"line_number":66,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":67,"context_line":"          - 0..1 (1)"},{"line_number":68,"context_line":"          - 0..N (2 or more)"},{"line_number":69,"context_line":"          - 1"},{"line_number":70,"context_line":"          - 1..N (2 or more)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        * About LCM operations:"},{"line_number":73,"context_line":"          This test includes the following operations."},{"line_number":74,"context_line":"          - 0. Pre-setting"}],"source_content_type":"text/x-python","patch_set":20,"id":"eead142b_d4a1f2bc","line":71,"range":{"start_line":65,"start_character":10,"end_line":71,"end_character":0},"updated":"2022-03-09 09:40:08.000000000","message":"* It might be confusing. Can you elaborate it a little bit more?\n* For L.69, it\u0027s useless because it\u0027s apparent and no need to explain.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4dd72de284eeabc46591cea53a026e9ca0717f3e","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        \"\"\"Test retry and rollback scale out operations"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        * About attributes:"},{"line_number":65,"context_line":"          All of the following cardinality attributes are set."},{"line_number":66,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":67,"context_line":"          - 0..1 (1)"},{"line_number":68,"context_line":"          - 0..N (2 or more)"},{"line_number":69,"context_line":"          - 1"},{"line_number":70,"context_line":"          - 1..N (2 or more)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        * About LCM operations:"},{"line_number":73,"context_line":"          This test includes the following operations."},{"line_number":74,"context_line":"          - 0. Pre-setting"}],"source_content_type":"text/x-python","patch_set":20,"id":"b4f57047_bdc9acca","line":71,"range":{"start_line":65,"start_character":10,"end_line":71,"end_character":0},"in_reply_to":"73a7cec2_95a6e83d","updated":"2022-03-10 06:12:34.000000000","message":"Please confirm it ASAP. Cause I needed to feedback the modification to the other 2 patchs.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7c2c3ee13e99c8aac39a929e6b64f3aa326d3289","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        \"\"\"Test retry and rollback scale out operations"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        * About attributes:"},{"line_number":65,"context_line":"          All of the following cardinality attributes are set."},{"line_number":66,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":67,"context_line":"          - 0..1 (1)"},{"line_number":68,"context_line":"          - 0..N (2 or more)"},{"line_number":69,"context_line":"          - 1"},{"line_number":70,"context_line":"          - 1..N (2 or more)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        * About LCM operations:"},{"line_number":73,"context_line":"          This test includes the following operations."},{"line_number":74,"context_line":"          - 0. Pre-setting"}],"source_content_type":"text/x-python","patch_set":20,"id":"73a7cec2_95a6e83d","line":71,"range":{"start_line":65,"start_character":10,"end_line":71,"end_character":0},"in_reply_to":"eead142b_d4a1f2bc","updated":"2022-03-10 01:50:50.000000000","message":"It was copied from test_vnflcm_basic.py.\nI added 0..1 (1)\u0027s explanation.\nDeleted L69.","commit_id":"3815fb3ba82bb9b22c16eb6d7262382370ad50ba"}]}