)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"4b10171d61e301bfdb71c2f70fe774a57f516bd4","unresolved":true,"context_lines":[{"line_number":9,"context_line":"vnfm_db.py has the following problems."},{"line_number":10,"context_line":"(i) ``_update_vnf_scaling`` and ``_update_vnf_rollback`` save these two"},{"line_number":11,"context_line":"unrelated objects: vnf_instance and vnf_lcm_op_occ. These objects are"},{"line_number":12,"context_line":"not updated in these functions, but vnflcm_driver. Thus, saving these"},{"line_number":13,"context_line":"objects should be done in vnflcm_driver."},{"line_number":14,"context_line":"(ii) ``_update_vnf_rollback_status_err``, ``_update_vnf_rollback_pre``"},{"line_number":15,"context_line":"and ``_update_vnf_rollback`` has a redundant else block."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"19675c3e_2757abb6","line":12,"range":{"start_line":12,"start_character":36,"end_line":12,"end_character":49},"updated":"2022-02-08 05:49:45.000000000","message":"Please reframe it as \"but in vnflcm_driver\".","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"3b2ce2447745b39142eb3fae52082e8c592ee4b1","unresolved":true,"context_lines":[{"line_number":9,"context_line":"vnfm_db.py has the following problems."},{"line_number":10,"context_line":"(i) ``_update_vnf_scaling`` and ``_update_vnf_rollback`` save these two"},{"line_number":11,"context_line":"unrelated objects: vnf_instance and vnf_lcm_op_occ. These objects are"},{"line_number":12,"context_line":"not updated in these functions, but vnflcm_driver. Thus, saving these"},{"line_number":13,"context_line":"objects should be done in vnflcm_driver."},{"line_number":14,"context_line":"(ii) ``_update_vnf_rollback_status_err``, ``_update_vnf_rollback_pre``"},{"line_number":15,"context_line":"and ``_update_vnf_rollback`` has a redundant else block."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4adb8d83_b17d8082","line":12,"range":{"start_line":12,"start_character":36,"end_line":12,"end_character":49},"in_reply_to":"19675c3e_2757abb6","updated":"2022-02-08 07:58:15.000000000","message":"I\u0027ll fix it in PS2","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"10924ab84cf44ed853462ecde07965b42c922730","unresolved":false,"context_lines":[{"line_number":9,"context_line":"vnfm_db.py has the following problems."},{"line_number":10,"context_line":"(i) ``_update_vnf_scaling`` and ``_update_vnf_rollback`` save these two"},{"line_number":11,"context_line":"unrelated objects: vnf_instance and vnf_lcm_op_occ. These objects are"},{"line_number":12,"context_line":"not updated in these functions, but vnflcm_driver. Thus, saving these"},{"line_number":13,"context_line":"objects should be done in vnflcm_driver."},{"line_number":14,"context_line":"(ii) ``_update_vnf_rollback_status_err``, ``_update_vnf_rollback_pre``"},{"line_number":15,"context_line":"and ``_update_vnf_rollback`` has a redundant else block."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"220478d7_bb154f4f","line":12,"range":{"start_line":12,"start_character":36,"end_line":12,"end_character":49},"in_reply_to":"4adb8d83_b17d8082","updated":"2022-02-15 13:59:34.000000000","message":"Ack","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"645387bc757987c382af0e69fb270bf4253db787","unresolved":true,"context_lines":[{"line_number":12,"context_line":"not updated in these functions, but vnflcm_driver. Thus, saving these"},{"line_number":13,"context_line":"objects should be done in vnflcm_driver."},{"line_number":14,"context_line":"(ii) ``_update_vnf_rollback_status_err``, ``_update_vnf_rollback_pre``"},{"line_number":15,"context_line":"and ``_update_vnf_rollback`` has a redundant else block."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch solves these problems as follows."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8ef55059_834c0acd","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":32},"updated":"2022-02-07 09:40:05.000000000","message":"nit: have","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"3b2ce2447745b39142eb3fae52082e8c592ee4b1","unresolved":true,"context_lines":[{"line_number":12,"context_line":"not updated in these functions, but vnflcm_driver. Thus, saving these"},{"line_number":13,"context_line":"objects should be done in vnflcm_driver."},{"line_number":14,"context_line":"(ii) ``_update_vnf_rollback_status_err``, ``_update_vnf_rollback_pre``"},{"line_number":15,"context_line":"and ``_update_vnf_rollback`` has a redundant else block."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch solves these problems as follows."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fb5744f0_eb9e26c6","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":32},"in_reply_to":"8ef55059_834c0acd","updated":"2022-02-08 07:58:15.000000000","message":"I\u0027ll fix it in PS2","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5adcf898b24ca72f1ad0209e425cc5962ee2ec53","unresolved":false,"context_lines":[{"line_number":12,"context_line":"not updated in these functions, but vnflcm_driver. Thus, saving these"},{"line_number":13,"context_line":"objects should be done in vnflcm_driver."},{"line_number":14,"context_line":"(ii) ``_update_vnf_rollback_status_err``, ``_update_vnf_rollback_pre``"},{"line_number":15,"context_line":"and ``_update_vnf_rollback`` has a redundant else block."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch solves these problems as follows."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6addf81e_227c3a68","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":32},"in_reply_to":"fb5744f0_eb9e26c6","updated":"2022-02-08 13:46:33.000000000","message":"I\u0027ve confirmed.","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"645387bc757987c382af0e69fb270bf4253db787","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f29a625a_dc629e1c","updated":"2022-02-07 09:40:05.000000000","message":"Thanks for your patch, almost LGTM but I have tiny comment and question. Please kindly find it.","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"4b10171d61e301bfdb71c2f70fe774a57f516bd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b0a52e1_b5cc30e1","updated":"2022-02-08 05:49:45.000000000","message":"Thanks for your patch, please find a nit comment.","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"43c391915b4f45af1aaf31783db67bf66bd1f3d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ad6f5be_e58f92fd","updated":"2022-02-15 07:49:00.000000000","message":"LGTM.","commit_id":"141a1f464d504039d9ac97497119e0a2cb1d8bb8"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"3b2ce2447745b39142eb3fae52082e8c592ee4b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d706eab9_331fc59a","updated":"2022-02-08 07:58:15.000000000","message":"Thank you for your comments.\n\nPlease kindly find my replies.","commit_id":"141a1f464d504039d9ac97497119e0a2cb1d8bb8"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"10924ab84cf44ed853462ecde07965b42c922730","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc71b527_cebebcf6","updated":"2022-02-15 13:59:34.000000000","message":"Thanks for rework. LGTM!","commit_id":"141a1f464d504039d9ac97497119e0a2cb1d8bb8"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"645387bc757987c382af0e69fb270bf4253db787","unresolved":true,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        if vnf_instance.instantiated_vnf_info and\\"},{"line_number":390,"context_line":"                vnf_instance.instantiated_vnf_info.instance_id !\u003d instance_id:"},{"line_number":391,"context_line":"            # TODO(h-asahina): don\u0027t overwrite instance_id with stack_id"},{"line_number":392,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id \u003d instance_id"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if vnf_dict[\u0027attributes\u0027].get(\u0027scaling_group_names\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"74d86ef2_76788de3","line":391,"range":{"start_line":391,"start_character":12,"end_line":391,"end_character":72},"updated":"2022-02-07 09:40:05.000000000","message":"Could you explain more about this comment?\nWhat is the intent of adding comments in this patch?","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"4917e50a867591232488427d6bd0f57324eb9fa9","unresolved":true,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        if vnf_instance.instantiated_vnf_info and\\"},{"line_number":390,"context_line":"                vnf_instance.instantiated_vnf_info.instance_id !\u003d instance_id:"},{"line_number":391,"context_line":"            # TODO(h-asahina): don\u0027t overwrite instance_id with stack_id"},{"line_number":392,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id \u003d instance_id"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if vnf_dict[\u0027attributes\u0027].get(\u0027scaling_group_names\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"feb71b29_10dfbcb7","line":391,"range":{"start_line":391,"start_character":12,"end_line":391,"end_character":72},"in_reply_to":"148678ff_6168d981","updated":"2022-02-14 03:32:37.000000000","message":"\u003e it is a comment added regardless of the content of this patch.\n\nYes\n\n\u003e So we may need to revisit Kubernetes InfraDriver\u0027s process before changing to ``stack_id``. But, this value doesn\u0027t seem to be in use at the moment, so we may not have to worry about it..\n\nI agree.\n\nI\u0027ll submit another patch to change this name as this patch is not an appropriate place to change the name ``instance_id`` to ``stack_id``.  There are many places using this name and changing this name will involve DB migration. Such changes should be separated from this patch.","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"3b2ce2447745b39142eb3fae52082e8c592ee4b1","unresolved":true,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        if vnf_instance.instantiated_vnf_info and\\"},{"line_number":390,"context_line":"                vnf_instance.instantiated_vnf_info.instance_id !\u003d instance_id:"},{"line_number":391,"context_line":"            # TODO(h-asahina): don\u0027t overwrite instance_id with stack_id"},{"line_number":392,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id \u003d instance_id"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if vnf_dict[\u0027attributes\u0027].get(\u0027scaling_group_names\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a92a8559_64b2c7fc","line":391,"range":{"start_line":391,"start_character":12,"end_line":391,"end_character":72},"in_reply_to":"74d86ef2_76788de3","updated":"2022-02-08 07:58:15.000000000","message":"I just tried to point out the name ``instance_id`` is confusing because it\u0027s actually ``stack_id``. The role of this attribute is not clear. When an InstantiatedVnfInfo is created, ``vnf_instance_id`` is ``vnf_instance.id`` [1]. However, it will be overwritten by ``stack_id`` here. \n\nAlso, this value is not defined in SOL003 [2]. Thus, I thought at least the name should be clear.\n\nI think an easy way to do that is to rename ``instance_id`` to ``stack_id``. So, I\u0027ll change the message in PS2. Please give me your advice if you have any ideas.\n\n[1] https://github.com/openstack/tacker/blob/master/tacker/conductor/conductor_server.py#L1042\n[2] https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/003/03.05.01_60/gs_NFV-SOL003v030501p.pdf#page\u003d164","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5adcf898b24ca72f1ad0209e425cc5962ee2ec53","unresolved":true,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        if vnf_instance.instantiated_vnf_info and\\"},{"line_number":390,"context_line":"                vnf_instance.instantiated_vnf_info.instance_id !\u003d instance_id:"},{"line_number":391,"context_line":"            # TODO(h-asahina): don\u0027t overwrite instance_id with stack_id"},{"line_number":392,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id \u003d instance_id"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if vnf_dict[\u0027attributes\u0027].get(\u0027scaling_group_names\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"148678ff_6168d981","line":391,"range":{"start_line":391,"start_character":12,"end_line":391,"end_character":72},"in_reply_to":"a92a8559_64b2c7fc","updated":"2022-02-08 13:46:33.000000000","message":"\u003e I just tried to point out the name ``instance_id`` is confusing because it\u0027s actually ``stack_id``. \nSo it is a comment added regardless of the content of this patch. I got it.\n\n\u003e Also, this value is not defined in SOL003 [2]. Thus, I thought at least the name should be clear.\nI agree.\n\nHowever, the Kubernetes InfraDriver includes the Kubernetes Object\u0027s namespace/name/apiVersion/kind in ``instance_id`` as the return value of instantiate_vnf() [1].\nSo we may need to revisit Kubernetes InfraDriver\u0027s process before changing to ``stack_id``.\nBut, this value doesn\u0027t seem to be in use at the moment, so we may not have to worry about it..\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py#L1760-L1765","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"43c391915b4f45af1aaf31783db67bf66bd1f3d8","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        if vnf_instance.instantiated_vnf_info and\\"},{"line_number":390,"context_line":"                vnf_instance.instantiated_vnf_info.instance_id !\u003d instance_id:"},{"line_number":391,"context_line":"            # TODO(h-asahina): don\u0027t overwrite instance_id with stack_id"},{"line_number":392,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id \u003d instance_id"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if vnf_dict[\u0027attributes\u0027].get(\u0027scaling_group_names\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4331b6d3_e72f393b","line":391,"range":{"start_line":391,"start_character":12,"end_line":391,"end_character":72},"in_reply_to":"feb71b29_10dfbcb7","updated":"2022-02-15 07:49:00.000000000","message":"I understood, thank you.","commit_id":"0c18eb9d6d9aa9ad48e43cafd5989ba4234b6a9f"}]}