)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"489ca3bf3377423a49aa9fd4ec828cb218282c28","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor v1 conductor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following points in the conductor server reduce the readability"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"(i) The variable name `current_status` in ``_change_vnf_status`` is"},{"line_number":12,"context_line":"confusing. It is a condition indicating the state to which is allowed to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ac86b6d2_61ad295d","line":9,"range":{"start_line":9,"start_character":66,"end_line":9,"end_character":67},"updated":"2022-02-09 17:07:23.000000000","message":"Could you add to end the line with a period?\nThere is another line (not include first line) without a period at the end, so could you add it too?","commit_id":"9e47e6581e01c1efbfd734cc44ab19052a6237f3"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"a19bf882002a7b21e7bcbcb9245a25f2db1721b8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor v1 conductor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following points in the conductor server reduce the readability"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"(i) The variable name `current_status` in ``_change_vnf_status`` is"},{"line_number":12,"context_line":"confusing. It is a condition indicating the state to which is allowed to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fec73e69_0f800bfb","line":9,"range":{"start_line":9,"start_character":66,"end_line":9,"end_character":67},"in_reply_to":"ac86b6d2_61ad295d","updated":"2022-02-10 12:06:11.000000000","message":"I fixed it.","commit_id":"9e47e6581e01c1efbfd734cc44ab19052a6237f3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3839ceda7bb18f1ab6394892727becd9a0a7b6f1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor v1 conductor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following points in the conductor server reduce the readability"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"(i) The variable name `current_status` in ``_change_vnf_status`` is"},{"line_number":12,"context_line":"confusing. It is a condition indicating the state to which is allowed to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d8fd36db_90a5128f","line":9,"range":{"start_line":9,"start_character":66,"end_line":9,"end_character":67},"in_reply_to":"fec73e69_0f800bfb","updated":"2022-02-15 14:20:52.000000000","message":"I\u0027ve confirmed.","commit_id":"9e47e6581e01c1efbfd734cc44ab19052a6237f3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3839ceda7bb18f1ab6394892727becd9a0a7b6f1","unresolved":true,"context_lines":[{"line_number":13,"context_line":"transition to the next state."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is"},{"line_number":16,"context_line":"confusing. This is just a ``VnfLcmOpOcc``"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"(iii) ``_get_vnf_notify`` is redundant and returns not notify but"},{"line_number":19,"context_line":"``VnfLcmOpOcc``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6a2f2899_cc502e12","line":16,"range":{"start_line":16,"start_character":40,"end_line":16,"end_character":41},"updated":"2022-02-15 14:20:52.000000000","message":"nit: How about you add a period here too?","commit_id":"bf001b70fa5057ea5d905e4d021c1923a050d957"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"f5957330f206281e699b215cb2da652ec6c54e08","unresolved":true,"context_lines":[{"line_number":13,"context_line":"transition to the next state."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is"},{"line_number":16,"context_line":"confusing. This is just a ``VnfLcmOpOcc``"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"(iii) ``_get_vnf_notify`` is redundant and returns not notify but"},{"line_number":19,"context_line":"``VnfLcmOpOcc``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"be8a51a9_ddef631e","line":16,"range":{"start_line":16,"start_character":40,"end_line":16,"end_character":41},"in_reply_to":"6a2f2899_cc502e12","updated":"2022-02-16 03:27:57.000000000","message":"I fixed it in PS5","commit_id":"bf001b70fa5057ea5d905e4d021c1923a050d957"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3da4a6082e16f4e84576e4b820f4776e050543aa","unresolved":false,"context_lines":[{"line_number":13,"context_line":"transition to the next state."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is"},{"line_number":16,"context_line":"confusing. This is just a ``VnfLcmOpOcc``"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"(iii) ``_get_vnf_notify`` is redundant and returns not notify but"},{"line_number":19,"context_line":"``VnfLcmOpOcc``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"522efbf5_fba98294","line":16,"range":{"start_line":16,"start_character":40,"end_line":16,"end_character":41},"in_reply_to":"be8a51a9_ddef631e","updated":"2022-02-16 07:20:28.000000000","message":"I\u0027ve confirmed.","commit_id":"bf001b70fa5057ea5d905e4d021c1923a050d957"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3839ceda7bb18f1ab6394892727becd9a0a7b6f1","unresolved":true,"context_lines":[{"line_number":16,"context_line":"confusing. This is just a ``VnfLcmOpOcc``"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"(iii) ``_get_vnf_notify`` is redundant and returns not notify but"},{"line_number":19,"context_line":"``VnfLcmOpOcc``"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"(iv) ``operation`` and ``operation_state`` in"},{"line_number":22,"context_line":"``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6776cf0e_ac489d37","line":19,"range":{"start_line":19,"start_character":14,"end_line":19,"end_character":15},"updated":"2022-02-15 14:20:52.000000000","message":"ditto.","commit_id":"bf001b70fa5057ea5d905e4d021c1923a050d957"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"f5957330f206281e699b215cb2da652ec6c54e08","unresolved":true,"context_lines":[{"line_number":16,"context_line":"confusing. This is just a ``VnfLcmOpOcc``"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"(iii) ``_get_vnf_notify`` is redundant and returns not notify but"},{"line_number":19,"context_line":"``VnfLcmOpOcc``"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"(iv) ``operation`` and ``operation_state`` in"},{"line_number":22,"context_line":"``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a5b2cd52_582dcd7b","line":19,"range":{"start_line":19,"start_character":14,"end_line":19,"end_character":15},"in_reply_to":"6776cf0e_ac489d37","updated":"2022-02-16 03:27:57.000000000","message":"I fixed it in PS5","commit_id":"bf001b70fa5057ea5d905e4d021c1923a050d957"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3da4a6082e16f4e84576e4b820f4776e050543aa","unresolved":false,"context_lines":[{"line_number":16,"context_line":"confusing. This is just a ``VnfLcmOpOcc``"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"(iii) ``_get_vnf_notify`` is redundant and returns not notify but"},{"line_number":19,"context_line":"``VnfLcmOpOcc``"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"(iv) ``operation`` and ``operation_state`` in"},{"line_number":22,"context_line":"``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"83b84421_418a5f41","line":19,"range":{"start_line":19,"start_character":14,"end_line":19,"end_character":15},"in_reply_to":"a5b2cd52_582dcd7b","updated":"2022-02-16 07:20:28.000000000","message":"I\u0027ve confirmed.","commit_id":"bf001b70fa5057ea5d905e4d021c1923a050d957"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3da4a6082e16f4e84576e4b820f4776e050543aa","unresolved":true,"context_lines":[{"line_number":33,"context_line":"(iii) Removed ``_get_vnf_notify`` and moved its contents to"},{"line_number":34,"context_line":"``_send_lcm_op_occ_notification``"},{"line_number":35,"context_line":"(iv)  Removed the default values"},{"line_number":36,"context_line":"(v)   Moved the contents to ``vnflcm_dirver``"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Change-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"40972063_098bedfd","line":36,"range":{"start_line":36,"start_character":30,"end_line":36,"end_character":43},"updated":"2022-02-16 07:20:28.000000000","message":"Sorry to bother you again, but I missed the typo.\n\ntypo: vnflcm_driver","commit_id":"d96bd43503e1fc5d37c96f2384e9666b608a80f5"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0d4bf9b7019b95740dbb53e0dde6d00b0e52b9b9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"(iii) Removed ``_get_vnf_notify`` and moved its contents to"},{"line_number":34,"context_line":"``_send_lcm_op_occ_notification``"},{"line_number":35,"context_line":"(iv)  Removed the default values"},{"line_number":36,"context_line":"(v)   Moved the contents to ``vnflcm_dirver``"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Change-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3e4c7468_38d14e69","line":36,"range":{"start_line":36,"start_character":30,"end_line":36,"end_character":43},"in_reply_to":"0ed3aa8b_7858cb32","updated":"2022-03-03 21:03:59.000000000","message":"I\u0027ve confirmed.","commit_id":"d96bd43503e1fc5d37c96f2384e9666b608a80f5"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"c9d15a1aa41426b7ecfa93a9ca5244c1e702fa2d","unresolved":true,"context_lines":[{"line_number":33,"context_line":"(iii) Removed ``_get_vnf_notify`` and moved its contents to"},{"line_number":34,"context_line":"``_send_lcm_op_occ_notification``"},{"line_number":35,"context_line":"(iv)  Removed the default values"},{"line_number":36,"context_line":"(v)   Moved the contents to ``vnflcm_dirver``"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Change-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0ed3aa8b_7858cb32","line":36,"range":{"start_line":36,"start_character":30,"end_line":36,"end_character":43},"in_reply_to":"40972063_098bedfd","updated":"2022-02-17 03:07:11.000000000","message":"Thank you for your comment.\nIt\u0027s my fault. Sorry.","commit_id":"d96bd43503e1fc5d37c96f2384e9666b608a80f5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"489ca3bf3377423a49aa9fd4ec828cb218282c28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f6b41533_9d762379","updated":"2022-02-09 17:07:23.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"9e47e6581e01c1efbfd734cc44ab19052a6237f3"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"a19bf882002a7b21e7bcbcb9245a25f2db1721b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d9049d2d_dd25fb5b","updated":"2022-02-10 12:06:11.000000000","message":"Thank you for the review.","commit_id":"bf001b70fa5057ea5d905e4d021c1923a050d957"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"c3508c559da8aeeadcfd93af238eece317206896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"75b326b3_7444dd8d","updated":"2022-02-14 00:59:45.000000000","message":"recheck","commit_id":"bf001b70fa5057ea5d905e4d021c1923a050d957"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"f5957330f206281e699b215cb2da652ec6c54e08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"185625f1_29cc4f27","updated":"2022-02-16 03:27:57.000000000","message":"Thank you for the review","commit_id":"d96bd43503e1fc5d37c96f2384e9666b608a80f5"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"6a281f1fd0f0e39a592effa1125a7b754286d690","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d39a8b1e_8071eb94","updated":"2022-02-21 03:13:57.000000000","message":"Rebased onto https://review.opendev.org/c/openstack/tacker/+/827831/7","commit_id":"d07cffbc8abb9420a451b2ad828f86d8339098d3"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"275807fe5b4beae11ec86001a4cbca55ace45318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4323131b_77ea12b1","updated":"2022-02-24 06:47:35.000000000","message":"Thank you for your review.\n\nPlease kindly find my replies.","commit_id":"1caa9f568847841e19896a676dfe65b4ce71e22d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"5cbc5c61f84fb62bb53799ab6d3e3f463e6413b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"839026dd_c2f7ed52","updated":"2022-03-02 10:27:14.000000000","message":"Rebased onto master","commit_id":"05d6710327122eb3eb7211cdbaf29dd3aa1645f5"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"3482fb6f7bdcd9bd309602e94ef4a0e89c4869b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d4cc1947_f569a4d8","updated":"2022-03-03 11:24:53.000000000","message":"recheck","commit_id":"4f565a406087ca82073c7156f9ad2859f82698a5"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a5cf8e3300653cfef0dbc97f354fd6901efd11cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8459874c_e2e105d2","updated":"2022-03-03 14:48:20.000000000","message":"thanks for the update.","commit_id":"4f565a406087ca82073c7156f9ad2859f82698a5"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"489ca3bf3377423a49aa9fd4ec828cb218282c28","unresolved":true,"context_lines":[{"line_number":1668,"context_line":"            error \u003d (\"Can not find requested vnf instance: %s\" %"},{"line_number":1669,"context_line":"                     vnf_instance_id)"},{"line_number":1670,"context_line":"            raise exceptions.NotificationProcessingError(error\u003derror)"},{"line_number":1671,"context_line":"        except Exception:"},{"line_number":1672,"context_line":"            error \u003d (\"Failed to update operation state of vnf instance %s\" %"},{"line_number":1673,"context_line":"                     vnf_instance_id)"},{"line_number":1674,"context_line":"            raise exceptions.NotificationProcessingError(error\u003derror)"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":"        # send notification"},{"line_number":1677,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"571253d8_882c8dfe","line":1674,"range":{"start_line":1671,"start_character":0,"end_line":1674,"end_character":69},"updated":"2022-02-09 17:07:23.000000000","message":"Since you have already caught Exception in the block above (L1667), isn\u0027t it unnecessary here?","commit_id":"9e47e6581e01c1efbfd734cc44ab19052a6237f3"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"a19bf882002a7b21e7bcbcb9245a25f2db1721b8","unresolved":true,"context_lines":[{"line_number":1668,"context_line":"            error \u003d (\"Can not find requested vnf instance: %s\" %"},{"line_number":1669,"context_line":"                     vnf_instance_id)"},{"line_number":1670,"context_line":"            raise exceptions.NotificationProcessingError(error\u003derror)"},{"line_number":1671,"context_line":"        except Exception:"},{"line_number":1672,"context_line":"            error \u003d (\"Failed to update operation state of vnf instance %s\" %"},{"line_number":1673,"context_line":"                     vnf_instance_id)"},{"line_number":1674,"context_line":"            raise exceptions.NotificationProcessingError(error\u003derror)"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":"        # send notification"},{"line_number":1677,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f22c59c4_9f38890a","line":1674,"range":{"start_line":1671,"start_character":0,"end_line":1674,"end_character":69},"in_reply_to":"571253d8_882c8dfe","updated":"2022-02-10 12:06:11.000000000","message":"I removed Exception at L1667 as it looks inappropriate. an Exception can occur for a reason other than \"Can not find requested vnf instance\".","commit_id":"9e47e6581e01c1efbfd734cc44ab19052a6237f3"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"f5957330f206281e699b215cb2da652ec6c54e08","unresolved":true,"context_lines":[{"line_number":1668,"context_line":"            error \u003d (\"Can not find requested vnf instance: %s\" %"},{"line_number":1669,"context_line":"                     vnf_instance_id)"},{"line_number":1670,"context_line":"            raise exceptions.NotificationProcessingError(error\u003derror)"},{"line_number":1671,"context_line":"        except Exception:"},{"line_number":1672,"context_line":"            error \u003d (\"Failed to update operation state of vnf instance %s\" %"},{"line_number":1673,"context_line":"                     vnf_instance_id)"},{"line_number":1674,"context_line":"            raise exceptions.NotificationProcessingError(error\u003derror)"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":"        # send notification"},{"line_number":1677,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2860ac9_55cbd176","line":1674,"range":{"start_line":1671,"start_character":0,"end_line":1674,"end_character":69},"in_reply_to":"5c58ecb4_5d14cc21","updated":"2022-02-16 03:27:57.000000000","message":"I added logging here in PS4.\n\nAlso, I renamed ``error`` to ``error_msg`` as it implicitly overwrites an argument value ``error``. Even though the argument value ``error`` is not used when an error occurs, it\u0027s not good implementation.","commit_id":"9e47e6581e01c1efbfd734cc44ab19052a6237f3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3da4a6082e16f4e84576e4b820f4776e050543aa","unresolved":false,"context_lines":[{"line_number":1668,"context_line":"            error \u003d (\"Can not find requested vnf instance: %s\" %"},{"line_number":1669,"context_line":"                     vnf_instance_id)"},{"line_number":1670,"context_line":"            raise exceptions.NotificationProcessingError(error\u003derror)"},{"line_number":1671,"context_line":"        except Exception:"},{"line_number":1672,"context_line":"            error \u003d (\"Failed to update operation state of vnf instance %s\" %"},{"line_number":1673,"context_line":"                     vnf_instance_id)"},{"line_number":1674,"context_line":"            raise exceptions.NotificationProcessingError(error\u003derror)"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":"        # send notification"},{"line_number":1677,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"844e4726_08bcfc35","line":1674,"range":{"start_line":1671,"start_character":0,"end_line":1674,"end_character":69},"in_reply_to":"a2860ac9_55cbd176","updated":"2022-02-16 07:20:28.000000000","message":"I\u0027ve confirmed.","commit_id":"9e47e6581e01c1efbfd734cc44ab19052a6237f3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3839ceda7bb18f1ab6394892727becd9a0a7b6f1","unresolved":true,"context_lines":[{"line_number":1668,"context_line":"            error \u003d (\"Can not find requested vnf instance: %s\" %"},{"line_number":1669,"context_line":"                     vnf_instance_id)"},{"line_number":1670,"context_line":"            raise exceptions.NotificationProcessingError(error\u003derror)"},{"line_number":1671,"context_line":"        except Exception:"},{"line_number":1672,"context_line":"            error \u003d (\"Failed to update operation state of vnf instance %s\" %"},{"line_number":1673,"context_line":"                     vnf_instance_id)"},{"line_number":1674,"context_line":"            raise exceptions.NotificationProcessingError(error\u003derror)"},{"line_number":1675,"context_line":""},{"line_number":1676,"context_line":"        # send notification"},{"line_number":1677,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5c58ecb4_5d14cc21","line":1674,"range":{"start_line":1671,"start_character":0,"end_line":1674,"end_character":69},"in_reply_to":"f22c59c4_9f38890a","updated":"2022-02-15 14:20:52.000000000","message":"Do you know exactly what kind of exception occurs?\nIf not, how about logging the error details?","commit_id":"9e47e6581e01c1efbfd734cc44ab19052a6237f3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8d31e4dc4d73221e594d5878791280d2765059f","unresolved":true,"context_lines":[{"line_number":536,"context_line":"                csar_utils.extract_csar_zip_file(zip_path, csar_path)"},{"line_number":537,"context_line":"            except (store_exceptions.GlanceStoreException) as e:"},{"line_number":538,"context_line":"                exc_msg \u003d encodeutils.exception_to_unicode(e)"},{"line_number":539,"context_line":"                msg \u003d (_(\"Exception raised from glance store can be \""},{"line_number":540,"context_line":"                        \"unrecoverable if it is not related to connection\""},{"line_number":541,"context_line":"                        \" error. Error: %s.\") % exc_msg)"},{"line_number":542,"context_line":"                raise exceptions.FailedToGetVnfdData(error\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ab5d940a_e9ca5c0a","side":"PARENT","line":539,"range":{"start_line":539,"start_character":23,"end_line":539,"end_character":24},"updated":"2022-02-21 18:11:45.000000000","message":"I\u0027d just like to confirm why you remove i18n?","commit_id":"7b45bd1987d37daed2bc19dd96faed42212b1d31"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"275807fe5b4beae11ec86001a4cbca55ace45318","unresolved":true,"context_lines":[{"line_number":536,"context_line":"                csar_utils.extract_csar_zip_file(zip_path, csar_path)"},{"line_number":537,"context_line":"            except (store_exceptions.GlanceStoreException) as e:"},{"line_number":538,"context_line":"                exc_msg \u003d encodeutils.exception_to_unicode(e)"},{"line_number":539,"context_line":"                msg \u003d (_(\"Exception raised from glance store can be \""},{"line_number":540,"context_line":"                        \"unrecoverable if it is not related to connection\""},{"line_number":541,"context_line":"                        \" error. Error: %s.\") % exc_msg)"},{"line_number":542,"context_line":"                raise exceptions.FailedToGetVnfdData(error\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"f226ece5_90f38714","side":"PARENT","line":539,"range":{"start_line":539,"start_character":23,"end_line":539,"end_character":24},"in_reply_to":"ab5d940a_e9ca5c0a","updated":"2022-02-24 06:47:35.000000000","message":"This is because FailedToGetVnfdData uses i18n in itself.\n\n[1] https://github.com/openstack/tacker/blob/67c32c596da8bf437e481d688ebdac670417823b/tacker/common/exceptions.py#L351","commit_id":"7b45bd1987d37daed2bc19dd96faed42212b1d31"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8d31e4dc4d73221e594d5878791280d2765059f","unresolved":true,"context_lines":[{"line_number":536,"context_line":"                csar_utils.extract_csar_zip_file(zip_path, csar_path)"},{"line_number":537,"context_line":"            except (store_exceptions.GlanceStoreException) as e:"},{"line_number":538,"context_line":"                exc_msg \u003d encodeutils.exception_to_unicode(e)"},{"line_number":539,"context_line":"                msg \u003d (\"Exception raised from glance store can be \""},{"line_number":540,"context_line":"                       \"unrecoverable if it is not related to connection\""},{"line_number":541,"context_line":"                       \" error. Error: %s.\" % exc_msg)"},{"line_number":542,"context_line":"                raise exceptions.FailedToGetVnfdData(error\u003dmsg)"},{"line_number":543,"context_line":"        try:"},{"line_number":544,"context_line":"            return self._read_vnfd_files(csar_path)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa2fee63_8b6b4734","line":541,"range":{"start_line":539,"start_character":23,"end_line":541,"end_character":54},"updated":"2022-02-21 18:11:45.000000000","message":"nit: I\u0027d ask you to make it shorter because no need to be so long.","commit_id":"d07cffbc8abb9420a451b2ad828f86d8339098d3"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"275807fe5b4beae11ec86001a4cbca55ace45318","unresolved":true,"context_lines":[{"line_number":536,"context_line":"                csar_utils.extract_csar_zip_file(zip_path, csar_path)"},{"line_number":537,"context_line":"            except (store_exceptions.GlanceStoreException) as e:"},{"line_number":538,"context_line":"                exc_msg \u003d encodeutils.exception_to_unicode(e)"},{"line_number":539,"context_line":"                msg \u003d (\"Exception raised from glance store can be \""},{"line_number":540,"context_line":"                       \"unrecoverable if it is not related to connection\""},{"line_number":541,"context_line":"                       \" error. Error: %s.\" % exc_msg)"},{"line_number":542,"context_line":"                raise exceptions.FailedToGetVnfdData(error\u003dmsg)"},{"line_number":543,"context_line":"        try:"},{"line_number":544,"context_line":"            return self._read_vnfd_files(csar_path)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3913065b_01a167b6","line":541,"range":{"start_line":539,"start_character":23,"end_line":541,"end_character":54},"in_reply_to":"fa2fee63_8b6b4734","updated":"2022-02-24 06:47:35.000000000","message":"I\u0027ll fix it in PS10","commit_id":"d07cffbc8abb9420a451b2ad828f86d8339098d3"}]}