)]}'
{"id":"openstack%2Ftacker~827837","triplet_id":"openstack%2Ftacker~master~I02fff0538a2926e23d1f19c29ea05de8c6a17ab5","project":"openstack/tacker","branch":"master","topic":"refactoring","attention_set":{},"removed_from_attention_set":{"31857":{"account":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"last_update":"2022-03-03 21:03:59.000000000","reason":"Ayumu Ueha replied on the change"},"25701":{"account":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"last_update":"2022-03-03 14:48:20.000000000","reason":"Yasufumi Ogawa replied on the change"},"32102":{"account":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"last_update":"2022-03-03 21:28:33.000000000","reason":"Change was submitted"},"17255":{"account":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"last_update":"2022-03-03 21:28:33.000000000","reason":"Change was submitted"},"33455":{"account":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"last_update":"2022-03-03 21:28:33.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I02fff0538a2926e23d1f19c29ea05de8c6a17ab5","subject":"Refactor v1 conductor","status":"MERGED","created":"2022-02-04 11:06:24.000000000","updated":"2022-03-03 21:30:23.000000000","submitted":"2022-03-03 21:28:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":30,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"827837-refactoring","meta_rev_id":"e05aaed0d4f3713a2c115e56b5b832669ea80d49","_number":827837,"virtual_id_number":827837,"owner":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-03-03 21:28:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"all":[{"value":2,"date":"2022-03-03 21:03:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},{"value":2,"date":"2022-03-03 14:48:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"all":[{"value":1,"date":"2022-03-03 21:03:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"}],"reviewers":{"REVIEWER":[{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-04 13:41:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-07 05:19:06.000000000","updated_by":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"reviewer":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"state":"REVIEWER"},{"updated":"2022-02-07 05:19:06.000000000","updated_by":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"reviewer":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"state":"REVIEWER"},{"updated":"2022-02-07 05:19:06.000000000","updated_by":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"reviewer":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"state":"REVIEWER"},{"updated":"2022-02-07 05:19:06.000000000","updated_by":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"}],"messages":[{"id":"6f4860470c323c4bbbffbd93f899cf2dedb6ca1d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-04 11:06:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"723610ab473f9ee5aae3490786928067ca2d63f5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-04 11:10:40.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"6004702d88497db4c75b74b46ef6ed3f82a1f648","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-04 13:41:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c01b656604d14f399ecae3f4a08e7392 : SUCCESS in 8m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cb366b215d54412895ec7779f5583489 : SUCCESS in 16m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/aa41af7bf0b4466ca4d56be50cacbfa0 : SUCCESS in 6m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/80fe6bf725e342ecb1659d7ebd0aa344 : SUCCESS in 16m 28s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8d538fcb46af44058df01c41b1e1c028 : SUCCESS in 16m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/972ac2c137c24e938e502240975247cb : SUCCESS in 7m 33s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/63f0f64d07de4763a84a555d7a75a2a0 : SUCCESS in 1h 48m 00s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/dea556a640e4459f8ae435abaed6f9d2 : SUCCESS in 2h 10m 06s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/ba3daa4c4540445f9846554fad1c60ba : SUCCESS in 1h 11m 06s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/33354bff44a94426b7db82e9575038a6 : SUCCESS in 1h 41m 03s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/3aab991c72bf4a9d927ab05e3877cfb4 : SUCCESS in 1h 47m 47s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/048a33ce2c3f49e89be44617ca56ce19 : SUCCESS in 1h 06m 36s","accounts_in_message":[],"_revision_number":2},{"id":"489ca3bf3377423a49aa9fd4ec828cb218282c28","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2022-02-09 17:07:23.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ac9df0f7aefeafe5982ce00203403d76fed7d489","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-10 12:02:49.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a19bf882002a7b21e7bcbcb9245a25f2db1721b8","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-10 12:06:11.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"1065f43281789fe32e5eaab5671ae8e63d856ee5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-10 16:42:06.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/60d0900c48994511b0982b23ec51ed99 : SUCCESS in 8m 22s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2d63bdafcc12461f89ac53a32d658e06 : SUCCESS in 15m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3aafb788a39e4412a64ed68618df25e3 : SUCCESS in 5m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/085fee7b39124ecaa4c19a6359d0655e : SUCCESS in 15m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/404655d29fe543a9b04155d7289a70a2 : SUCCESS in 15m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/607392894829492d9a520cf0d23fc44e : SUCCESS in 7m 08s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/bc5472da8ecf41eeb401f6cb814acfb5 : SUCCESS in 1h 35m 10s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/76eeac34d50943639c7c7347cf7c2de0 : SUCCESS in 2h 09m 08s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/87a4a2bff3ac4efbb8e45c62698c1fd1 : FAILURE in 1h 19m 36s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/af6b98e26ea8482f8a83202321070390 : SUCCESS in 1h 33m 29s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/51670334c6f64277a452e9085888d689 : SUCCESS in 1h 56m 34s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/1ff8e7b60a984857a688c2ba1e36fa73 : SUCCESS in 52m 58s","accounts_in_message":[],"_revision_number":3},{"id":"c3508c559da8aeeadcfd93af238eece317206896","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-14 00:59:45.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"ccf7763e955838a31a2eb8146b92dd47050bd220","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-14 03:09:27.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/edd2cd8d9692423fa06ec83e9ba0b8e0 : SUCCESS in 8m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/83f354ca4f664a9e8f13c95eebd6da86 : SUCCESS in 15m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/acedf79611cd4098bb1c7f8c168b3f43 : SUCCESS in 5m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5d77d657f50248f4bf4827c13a9ecb26 : SUCCESS in 15m 49s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f27a645bfb934be0bf883b3b12cc29c8 : SUCCESS in 15m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/25843c7544814f219e3d73cf3bd2c1ad : SUCCESS in 6m 04s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/59a65d158d1946bb90ad8bd9f1ebd761 : SUCCESS in 1h 46m 47s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/fc338c214f90482e97c0925ffc01618d : SUCCESS in 2h 04m 23s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/12739655541245f1b94d282d4b7a0080 : SUCCESS in 1h 05m 08s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/67a8a6878310403bb11fb72169473c93 : SUCCESS in 1h 38m 55s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/1aa0e5cf2a384f10b9324941210d91d3 : SUCCESS in 1h 28m 16s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/de4f0073c3af42daa4511674a5d5e602 : SUCCESS in 1h 00m 03s","accounts_in_message":[],"_revision_number":3},{"id":"3839ceda7bb18f1ab6394892727becd9a0a7b6f1","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2022-02-15 14:20:52.000000000","message":"Patch Set 3: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"7240709e2369fb4ec00a6435900aa0b3411a5dfe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-16 03:15:39.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"deb71b51179a4e8569bc38a4807e5afe6455acb6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-16 03:18:26.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"f5957330f206281e699b215cb2da652ec6c54e08","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-16 03:27:57.000000000","message":"Patch Set 5:\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"68c19b256284f4d9de2b8ab1533a818dce9f5fc4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-16 05:32:52.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a4550fba3a2642459f0de6e3dc557ed8 : SUCCESS in 8m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/be6fe18a5ce64d14b2a1fdfc479f5669 : SUCCESS in 16m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/586f5f9ee65a4cc888518b9ddf75c3ea : SUCCESS in 5m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a089b99acafb48bdab516cdc385c99fb : SUCCESS in 15m 33s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2c1d604183864297bd718cee0098a0b8 : SUCCESS in 16m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4b751d42e0a84562af73fa47b335a1be : SUCCESS in 7m 21s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/dff00c264b0248f5a34162be4ae58a03 : SUCCESS in 1h 47m 02s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/9d7fec178766482cb48cb956f075cb36 : SUCCESS in 2h 08m 15s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/c695685e51da4395b1696912f7be01b0 : SUCCESS in 1h 07m 59s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/8270c19e4bd34c4a82e96a7395322039 : SUCCESS in 1h 40m 25s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/5e774c12c841487eb4ed307245e7ae72 : SUCCESS in 1h 47m 57s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/12f73da4b146414db40381f509f03524 : SUCCESS in 1h 00m 59s","accounts_in_message":[],"_revision_number":5},{"id":"3da4a6082e16f4e84576e4b820f4776e050543aa","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2022-02-16 07:20:28.000000000","message":"Patch Set 5: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"ce6702d65136a0f48c05540b6fa1798c9ab2983d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-17 03:04:39.000000000","message":"Patch Set 6: Commit message was updated.","accounts_in_message":[],"_revision_number":6},{"id":"c9d15a1aa41426b7ecfa93a9ca5244c1e702fa2d","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-17 03:07:11.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"83d0bde7b42454015f9cd9f0d4558df4a78a5ab5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-17 05:46:29.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/848b31239d5b4c019fa0236ea426b374 : SUCCESS in 8m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8e1cf5a105a9442c9c9c68127241c802 : SUCCESS in 15m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/884b13244de3452cbd32c571ff3dc65d : SUCCESS in 5m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/161daa79f9be4413be292d3564ee7600 : SUCCESS in 16m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8b5c61d7fd464248898c1a2343c2499e : SUCCESS in 15m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2bf35707948e49ad8a86b9095776cc02 : SUCCESS in 6m 45s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/dfa9c721f190419cbfd7fa0c372b5be3 : SUCCESS in 1h 50m 45s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/278f88827a53469a9ec2f3e3081608eb : SUCCESS in 2h 34m 39s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/843d827418104461ae77976123168e03 : SUCCESS in 1h 13m 19s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/551eea9d93c54a5b8ccfe1a7a1e3c681 : SUCCESS in 1h 52m 36s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/cf70038f37e34a27aea7250a4aebb24f : SUCCESS in 2h 19m 50s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/a191a93922194f6aa80d1a88ac924326 : SUCCESS in 1h 05m 05s","accounts_in_message":[],"_revision_number":6},{"id":"2122dbd34482a4d653d91028b31d033fd8578400","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-21 02:24:29.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.","accounts_in_message":[],"_revision_number":7},{"id":"d55c666c9a080978ed388da71e4e8ae033a9a5d0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-21 03:05:07.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.","accounts_in_message":[],"_revision_number":8},{"id":"0d6c17c34a3b895dc71241b68e403275c233b6d3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-21 03:12:46.000000000","message":"Uploaded patch set 9: Patch Set 8 was rebased.","accounts_in_message":[],"_revision_number":9},{"id":"6a281f1fd0f0e39a592effa1125a7b754286d690","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-21 03:13:57.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"42763f58b2cce62c64bf8fceca41ef1675c86d86","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-21 05:32:22.000000000","message":"Patch Set 9: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8e24a44c35774d9896c19ef6140b988e : SUCCESS in 8m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/87a4fe8e5dc54145a50c56401f078884 : SUCCESS in 14m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8756a80c65784217afd198125fbdcc26 : SUCCESS in 5m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e0204a17a17841fcab0e4560b4a26d11 : SUCCESS in 14m 54s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9551fa34b0fe4bddaba680f7bbc012d2 : SUCCESS in 15m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d2b8711199164a48a6b11a1bab2a0584 : SUCCESS in 6m 33s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/fc9ef5ea76e0479e89a7ab892adab944 : SUCCESS in 1h 39m 08s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/7b800ceb278c4e708d5dfae0d2fa34f8 : SUCCESS in 2h 18m 12s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/58e9048e061a4a5fb62e133d8a55ea78 : SUCCESS in 1h 15m 40s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/6f249270fd9a4aeab1a917bf42e44e07 : SUCCESS in 1h 46m 19s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/3674895604974c70857431d1ba074287 : SUCCESS in 1h 43m 06s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/bf233720dab94a619fbf3433c4662505 : SUCCESS in 1h 00m 38s","accounts_in_message":[],"_revision_number":9},{"id":"e8d31e4dc4d73221e594d5878791280d2765059f","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2022-02-21 18:11:45.000000000","message":"Patch Set 9: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":9},{"id":"8b2fda49358b53b92b18471e151e5da5404fd472","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-24 06:45:17.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"275807fe5b4beae11ec86001a4cbca55ace45318","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-02-24 06:47:35.000000000","message":"Patch Set 10:\n\n(3 comments)","accounts_in_message":[],"_revision_number":10},{"id":"afef90adaab4256ee0727947f142b64511288ef1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-24 09:11:38.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/44ecf72f7bfa4138b86087b371de28e2 : SUCCESS in 8m 51s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b3873f71919c4f16b7f4f25beea15d16 : SUCCESS in 16m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7e478d892a714dc2b55e1f47c0b5c20a : SUCCESS in 5m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/edb2ec651ff147ef8176588cec110b25 : SUCCESS in 15m 25s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b3e9b611f11b4221a2e9fc5cd5465487 : SUCCESS in 16m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5d1e4fd55d5542ecacf7a841034cf90b : SUCCESS in 6m 27s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/ade472d3ebd84998873a4c81051df6e0 : SUCCESS in 1h 52m 58s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/dbd3187577ba45639e707a77c33a1a3b : SUCCESS in 2h 18m 36s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/ef1818b0dfb74ef9b9d51aae4a68aa6c : SUCCESS in 1h 04m 44s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/26963d94760945688a1fbe99fc68a24f : SUCCESS in 1h 31m 17s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/836b6ab04e3540b883700a39e4fb5836 : SUCCESS in 1h 50m 09s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/d69a42b533f143ee9224ed9109064062 : SUCCESS in 52m 01s","accounts_in_message":[],"_revision_number":10},{"id":"36150c3b54f346c74acf79b372d20eaed6396f9f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-03-02 10:26:04.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"5cbc5c61f84fb62bb53799ab6d3e3f463e6413b1","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-03-02 10:27:14.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"2066ddedc03116c46c5e25b01cc57f5c69e1dda6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-03-02 10:35:39.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"7c94517a8a4da10db63ad1ac12a1ab930189cfe7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-03-02 10:45:28.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"7777d6fdf6b8a27de15d9dfbed0a8efeb7b2e9e3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-03-02 13:12:25.000000000","message":"Patch Set 13: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6383863e82a2460083adeb3a3a53ccfe : FAILURE in 9m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1923b97066fe4e7e87de3ae3223cf351 : SUCCESS in 16m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b9d2f32f18ee4222aaa5f90f22e24759 : SUCCESS in 7m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/21dd3459930a43928dac2162285d6a74 : SUCCESS in 16m 07s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a7bd664d15cf45d39adeb778c060cc21 : SUCCESS in 15m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6c581cdb23974f85acd07a8e26977c02 : SUCCESS in 8m 50s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/a12ab71c30eb43aba8d0ce1fcc1bc14c : SUCCESS in 1h 59m 31s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/95ec78db81e9419aa48ed0fdc68b13a6 : SUCCESS in 2h 15m 07s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/9fe0be644aae4739816f29d156c778ce : SUCCESS in 1h 19m 50s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/2e4ce07ddf0746c098867620b04a7c92 : SUCCESS in 1h 46m 32s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/53a05d44343f4669828de86691489022 : SUCCESS in 1h 40m 15s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/dc99b42aebf24bd7ad666dd950354120 : SUCCESS in 1h 04m 24s","accounts_in_message":[],"_revision_number":13},{"id":"3482fb6f7bdcd9bd309602e94ef4a0e89c4869b0","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2022-03-03 11:24:53.000000000","message":"Patch Set 13:\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"7adbd077b65dcf34ae09e33b833a5f138303b0e8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-03-03 14:05:20.000000000","message":"Patch Set 13: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/155ebddecd3246f0bf0c83cef555b415 : SUCCESS in 9m 22s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/16ac5c752fd44061b369736f1ae17c11 : SUCCESS in 15m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/48cd92dfc66a4dce94f7860e67106ac9 : SUCCESS in 8m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cd9929b6b69546edb8a570fca94ad7b2 : SUCCESS in 15m 34s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9ffb630fe11b4e98bf08903dfbb67595 : SUCCESS in 15m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ed7e6a9e234444d5914b1ba865249c1c : SUCCESS in 8m 15s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/e9d6d049770b44fdad33e7f30eddd602 : SUCCESS in 1h 35m 27s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/bd5840fc90574b0d80a6eb7ab662e311 : SUCCESS in 2h 28m 13s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/3b130c8f6fcd42b7ab73768fe0a50163 : SUCCESS in 1h 22m 20s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/11939bd8193c45d1ac643e24ace32b7a : SUCCESS in 1h 49m 25s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/7aad6e94e19a497b87d9d605fce0ebb1 : SUCCESS in 1h 59m 42s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/095c13b4c6bc4cc9bf744c1820a87af2 : SUCCESS in 1h 13m 49s","accounts_in_message":[],"_revision_number":13},{"id":"a5cf8e3300653cfef0dbc97f354fd6901efd11cd","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2022-03-03 14:48:20.000000000","message":"Patch Set 13: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"0d4bf9b7019b95740dbb53e0dde6d00b0e52b9b9","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2022-03-03 21:03:59.000000000","message":"Patch Set 13: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"d819140a677f4ca63f40cb28774341f1faee8b6c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-03-03 21:04:25.000000000","message":"Patch Set 13: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":13},{"id":"a3d5800f8fea284690cc6b756c272e3b5b39230c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-03-03 21:28:33.000000000","message":"Patch Set 13: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3625fc61c83a43a29700074656dc5189 : SUCCESS in 15m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5e4c5d39bf5f44fa817c5d31a904e9a1 : SUCCESS in 7m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/009c31be8c4247bd9deaa96c6e1525a8 : SUCCESS in 16m 15s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7a0bf4b03e574d929c4c32f30431925f : SUCCESS in 16m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b5e49bf87a08469a8f4aceba939c8b29 : SUCCESS in 9m 37s","accounts_in_message":[],"_revision_number":13},{"id":"c229cf6d276814e0641cded7aa038917ca927b2a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-03-03 21:28:33.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":13},{"id":"e05aaed0d4f3713a2c115e56b5b832669ea80d49","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-03-03 21:30:23.000000000","message":"Patch Set 13:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6579bc52bacd44d0bb7724485be76ac5 : SUCCESS in 1m 24s","accounts_in_message":[],"_revision_number":13}],"current_revision_number":13,"current_revision":"4f565a406087ca82073c7156f9ad2859f82698a5","revisions":{"c75875b5eaee1cfa799f780f3eb170c22f52c6d3":{"kind":"REWORK","_number":1,"created":"2022-02-04 11:06:24.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/1"}}},"commit":{"parents":[{"commit":"4c2b95f48973941e2f2f42ee89a2a218057a9246","subject":"Refactor constants in conductor","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/4c2b95f48973941e2f2f42ee89a2a218057a9246"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:56:50.000000000","tz":540},"subject":"Refactor conductor","message":"Refactor conductor\n\nThe conductor server has problems.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``\n\n(iii) ``_get_vnf_notify`` is reudndant and returns not notfy but\n``VnfLcmOpOcc``\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_dirver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c75875b5eaee1cfa799f780f3eb170c22f52c6d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c75875b5eaee1cfa799f780f3eb170c22f52c6d3"}]},"branch":"refs/heads/master"},"9e47e6581e01c1efbfd734cc44ab19052a6237f3":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-02-04 11:10:40.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/2"}}},"commit":{"parents":[{"commit":"4c2b95f48973941e2f2f42ee89a2a218057a9246","subject":"Refactor constants in conductor","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/4c2b95f48973941e2f2f42ee89a2a218057a9246"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 11:16:22.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_dirver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/9e47e6581e01c1efbfd734cc44ab19052a6237f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/9e47e6581e01c1efbfd734cc44ab19052a6237f3"}]},"branch":"refs/heads/master"},"bf001b70fa5057ea5d905e4d021c1923a050d957":{"kind":"REWORK","_number":3,"created":"2022-02-10 12:02:49.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/3"}}},"commit":{"parents":[{"commit":"4c2b95f48973941e2f2f42ee89a2a218057a9246","subject":"Refactor constants in conductor","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/4c2b95f48973941e2f2f42ee89a2a218057a9246"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-10 12:02:17.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_dirver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/bf001b70fa5057ea5d905e4d021c1923a050d957"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/bf001b70fa5057ea5d905e4d021c1923a050d957"}]},"branch":"refs/heads/master"},"503c7acf6429f90117c31df56c0f4e8e58e10ad8":{"kind":"REWORK","_number":4,"created":"2022-02-16 03:15:39.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/4"}}},"commit":{"parents":[{"commit":"4c2b95f48973941e2f2f42ee89a2a218057a9246","subject":"Refactor constants in conductor","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/4c2b95f48973941e2f2f42ee89a2a218057a9246"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-16 03:14:38.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_dirver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/503c7acf6429f90117c31df56c0f4e8e58e10ad8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/503c7acf6429f90117c31df56c0f4e8e58e10ad8"}]},"branch":"refs/heads/master"},"d96bd43503e1fc5d37c96f2384e9666b608a80f5":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2022-02-16 03:18:26.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/5"}}},"commit":{"parents":[{"commit":"4c2b95f48973941e2f2f42ee89a2a218057a9246","subject":"Refactor constants in conductor","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/4c2b95f48973941e2f2f42ee89a2a218057a9246"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-16 03:16:42.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``.\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``.\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them.\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``.\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_dirver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/d96bd43503e1fc5d37c96f2384e9666b608a80f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/d96bd43503e1fc5d37c96f2384e9666b608a80f5"}]},"branch":"refs/heads/master"},"2abc87d9ea6fb55464ccf265d6122bfd0b0618b4":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2022-02-17 03:04:39.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/6"}}},"commit":{"parents":[{"commit":"4c2b95f48973941e2f2f42ee89a2a218057a9246","subject":"Refactor constants in conductor","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/4c2b95f48973941e2f2f42ee89a2a218057a9246"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-17 03:04:39.000000000","tz":0},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``.\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``.\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them.\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``.\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_driver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/2abc87d9ea6fb55464ccf265d6122bfd0b0618b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/2abc87d9ea6fb55464ccf265d6122bfd0b0618b4"}]},"branch":"refs/heads/master","description":"Edit commit message"},"979c77c80eb9f72e0a0f917488141cc7507c7eb2":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2022-02-21 02:24:29.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/7"}}},"commit":{"parents":[{"commit":"cce962a06823b8c78b98bb4527e237192e8aa7cb","subject":"Refactor constants in conductor","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/cce962a06823b8c78b98bb4527e237192e8aa7cb"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-21 02:11:09.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``.\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``.\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them.\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``.\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_driver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/979c77c80eb9f72e0a0f917488141cc7507c7eb2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/979c77c80eb9f72e0a0f917488141cc7507c7eb2"}]},"branch":"refs/heads/master"},"49025523f61a1a8969c3053912b887faab0a5542":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2022-02-21 03:05:07.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/8"}}},"commit":{"parents":[{"commit":"8680840694595df17e74339390447e71a86a346a","subject":"Refactor constants in conductor","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/8680840694595df17e74339390447e71a86a346a"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-21 03:04:13.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``.\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``.\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them.\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``.\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_driver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/49025523f61a1a8969c3053912b887faab0a5542"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/49025523f61a1a8969c3053912b887faab0a5542"}]},"branch":"refs/heads/master"},"d07cffbc8abb9420a451b2ad828f86d8339098d3":{"kind":"TRIVIAL_REBASE","_number":9,"created":"2022-02-21 03:12:46.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/9"}}},"commit":{"parents":[{"commit":"7b45bd1987d37daed2bc19dd96faed42212b1d31","subject":"Refactor constants in conductor","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/7b45bd1987d37daed2bc19dd96faed42212b1d31"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-21 03:11:53.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``.\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``.\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them.\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``.\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_driver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/d07cffbc8abb9420a451b2ad828f86d8339098d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/d07cffbc8abb9420a451b2ad828f86d8339098d3"}]},"branch":"refs/heads/master"},"1caa9f568847841e19896a676dfe65b4ce71e22d":{"kind":"REWORK","_number":10,"created":"2022-02-24 06:45:17.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/10"}}},"commit":{"parents":[{"commit":"7b45bd1987d37daed2bc19dd96faed42212b1d31","subject":"Refactor constants in conductor","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/7b45bd1987d37daed2bc19dd96faed42212b1d31"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-24 06:45:06.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``.\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``.\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them.\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``.\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_driver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/1caa9f568847841e19896a676dfe65b4ce71e22d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/1caa9f568847841e19896a676dfe65b4ce71e22d"}]},"branch":"refs/heads/master"},"05d6710327122eb3eb7211cdbaf29dd3aa1645f5":{"kind":"REWORK","_number":11,"created":"2022-03-02 10:26:04.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/11"}}},"commit":{"parents":[{"commit":"a5759f7d47cb3cf8c5803dd2e562e621cde951da","subject":"Merge \"Add doc of CIR/PV/kubespray\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/a5759f7d47cb3cf8c5803dd2e562e621cde951da"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-03-02 10:25:06.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``.\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``.\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them.\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``.\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_driver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/05d6710327122eb3eb7211cdbaf29dd3aa1645f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/05d6710327122eb3eb7211cdbaf29dd3aa1645f5"}]},"branch":"refs/heads/master"},"9e5cd24877c6c163ae58b82d3a8c58b960e32db1":{"kind":"REWORK","_number":12,"created":"2022-03-02 10:35:39.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/12","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/12","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/12"}}},"commit":{"parents":[{"commit":"a5759f7d47cb3cf8c5803dd2e562e621cde951da","subject":"Merge \"Add doc of CIR/PV/kubespray\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/a5759f7d47cb3cf8c5803dd2e562e621cde951da"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-03-02 10:35:29.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``.\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``.\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them.\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``.\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_driver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/9e5cd24877c6c163ae58b82d3a8c58b960e32db1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/9e5cd24877c6c163ae58b82d3a8c58b960e32db1"}]},"branch":"refs/heads/master"},"4f565a406087ca82073c7156f9ad2859f82698a5":{"kind":"REWORK","_number":13,"created":"2022-03-02 10:45:28.000000000","uploader":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"ref":"refs/changes/37/827837/13","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/37/827837/13","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/37/827837/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/37/827837/13"}}},"commit":{"parents":[{"commit":"a5759f7d47cb3cf8c5803dd2e562e621cde951da","subject":"Merge \"Add doc of CIR/PV/kubespray\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/a5759f7d47cb3cf8c5803dd2e562e621cde951da"}]}],"author":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-02-04 10:35:15.000000000","tz":540},"committer":{"name":"Hiromu Asahina","email":"hiromu.asahina.az@hco.ntt.co.jp","date":"2022-03-02 10:45:14.000000000","tz":540},"subject":"Refactor v1 conductor","message":"Refactor v1 conductor\n\nThe following points in the conductor server reduce the readability.\n\n(i) The variable name `current_status` in ``_change_vnf_status`` is\nconfusing. It is a condition indicating the state to which is allowed to\ntransition to the next state.\n\n(ii) The variable name `vnf_notif` in `_send_lcm_op_occ_notification` is\nconfusing. This is just a ``VnfLcmOpOcc``.\n\n(iii) ``_get_vnf_notify`` is redundant and returns not notify but\n``VnfLcmOpOcc``.\n\n(iv) ``operation`` and ``operation_state`` in\n``_send_lcm_op_occ_notification`` has default value, but it\u0027s better to\nexplicitly specify them.\n\n(v) The nested if statement at ll. 1991-1996 strongly depends on\n``vnflcm_driver``. Thus, the process here should be done by\n``vnflcm_driver``.\n\nThis patch solves these problems as follow.\n\n(i)   Renamed ``current_status`` to ``state_conditions``\n(ii)  Renamed ``vnf_notif`` to ``vnf_lcm_op_occ``\n(iii) Removed ``_get_vnf_notify`` and moved its contents to\n``_send_lcm_op_occ_notification``\n(iv)  Removed the default values\n(v)   Moved the contents to ``vnflcm_driver``\n\nChange-Id: I02fff0538a2926e23d1f19c29ea05de8c6a17ab5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/4f565a406087ca82073c7156f9ad2859f82698a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/4f565a406087ca82073c7156f9ad2859f82698a5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}