)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"89c5c0de2662fcef89bb3d191a00d1c2db5b3bce","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace line break from CRLF to LF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some files have CRLF line breaks."},{"line_number":10,"context_line":"This patch replaces line breaks to LF."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0b23a0da2cb9fda88da9ef59540e5f55570cdc57"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"16a884e2_c56bdd57","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":10},"updated":"2022-02-09 18:20:20.000000000","message":"I think we should correct all the lines with CRLF at once identically. Do you mean \"Some files\" is that there are still remained CRLF lines, or all lines are collected in this change? In my opinion, we shouldn\u0027t do such a fix partially, but do all the lines.","commit_id":"6fae5566030c61f5b2339b97e543c2ad4f3762d2"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"74f753e95def0f5a9e17e8af0d6806f9714e9da1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace line break from CRLF to LF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some files have CRLF line breaks."},{"line_number":10,"context_line":"This patch replaces line breaks to LF."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0b23a0da2cb9fda88da9ef59540e5f55570cdc57"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ecc601d_70c9a672","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":10},"in_reply_to":"03cf8668_2656ddee","updated":"2022-02-14 08:11:44.000000000","message":"It\u0027s simply coverage of the task. It\u0027s helpful to tell reviewers if you fixed all the files has CRLF.","commit_id":"6fae5566030c61f5b2339b97e543c2ad4f3762d2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"fb9f1c22ef3d95cb8e1bb11fbb515c5172eb32d9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace line break from CRLF to LF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some files have CRLF line breaks."},{"line_number":10,"context_line":"This patch replaces line breaks to LF."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0b23a0da2cb9fda88da9ef59540e5f55570cdc57"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"03cf8668_2656ddee","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":10},"in_reply_to":"16a884e2_c56bdd57","updated":"2022-02-09 20:48:52.000000000","message":"Thanks for your comment.\n\nAfter pointing out from Manpreet-san, I have changed CRLF to LF for all files under the \u0027tacker/\u0027 folder in PS2.\nWare there files that haven\u0027t changed yet?\n\nOr is it a comment saying that the commit message should be changed? If so, could you tell me how to change it?\nDo I need to explicitly write \"all files\" and the following line like below?\n```\nThis patch replaces line breaks to LF for all files.\n```","commit_id":"6fae5566030c61f5b2339b97e543c2ad4f3762d2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"093a5d4edc67fc6a53de7c6d7e8bfacc6596d8f1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace line break from CRLF to LF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some files have CRLF line breaks."},{"line_number":10,"context_line":"This patch replaces line breaks to LF."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0b23a0da2cb9fda88da9ef59540e5f55570cdc57"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ee7a44e0_6ca0de0c","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":10},"in_reply_to":"5ecc601d_70c9a672","updated":"2022-02-15 00:43:26.000000000","message":"Thanks for your answer.\nI wrote to Commit message clearly that all the files are target.","commit_id":"6fae5566030c61f5b2339b97e543c2ad4f3762d2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"846ef80cccf4ba70888c6df1b7a324e4fa0c6ef0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace line break from CRLF to LF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some files have CRLF line breaks."},{"line_number":10,"context_line":"This patch replaces line breaks to LF."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0b23a0da2cb9fda88da9ef59540e5f55570cdc57"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e2538565_edf0626a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":10},"in_reply_to":"ea088669_8258c668","updated":"2022-02-21 23:39:44.000000000","message":"Thanks for your suggestion!\nIt would be helpful if you could point it out like that.","commit_id":"6fae5566030c61f5b2339b97e543c2ad4f3762d2"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"94d8d6584b6be15647327010252c06055eca0073","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace line break from CRLF to LF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some files have CRLF line breaks."},{"line_number":10,"context_line":"This patch replaces line breaks to LF."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0b23a0da2cb9fda88da9ef59540e5f55570cdc57"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ea088669_8258c668","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":10},"in_reply_to":"ee7a44e0_6ca0de0c","updated":"2022-02-21 18:22:41.000000000","message":"I don\u0027t want to say silly things but it can be explained simply as \"This patch replaces all lines of CRLF to LF.\"","commit_id":"6fae5566030c61f5b2339b97e543c2ad4f3762d2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"15e95d09b56f873439eccba209aaf581ce852a3c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8493b135_18129c31","updated":"2022-02-09 01:24:31.000000000","message":"Thanks for your patch.\nI was trying to grep files in tacker which uses CRLF for a line break.\nCommand:\nstack@dldt-project_003:~/tacker$ grep -rIl -m 1 $\u0027\\r\u0027\nsamples/mgmt_driver/kubespray/kubespray_vnf_package/Definitions/sample_kubernetes_types.yaml\nsamples/mgmt_driver/kubespray/kubespray_vnf_package/Definitions/sample_kubernetes_top.vnfd.yaml\ntacker/tests/unit/vnfm/infra_drivers/kubernetes/test_kubernetes_driver_helm.py\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/test_tosca_parser_failure.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/tosca_params_error.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/tosca_generate_hot_from_tosca_with_substitution_mappings_error.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/tosca_vnfd.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/tosca_generate_hot_from_tosca_with_scaling_invalid_inst_req.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/tosca_generate_hot_from_tosca_parser_error.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/hot/scaling/worker_instance.hot.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/hot/scaling/hot_generate_hot_from_tosca_with_scaling.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/hot/hot_generate_hot_from_tosca.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/tosca_generate_hot_from_tosca_with_scaling.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/tosca_generate_hot_from_tosca_translator_error.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/etsi_nfv_sol001_common_types.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/tosca_generate_hot_from_tosca.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/etsi_nfv_sol001_vnfd_types.yaml\ntacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/tosca_generate_hot_from_tosca_with_params_error.yaml\ntacker/vnfm/infra_drivers/kubernetes/helm/helm_client.py\ntacker/db/migration/alembic_migrations/versions/8a7ca803e0d0_add_vnfc_info_to_instantiated_vnf_info.py\n\nExcept below files rest are taken care in patch:\nsamples/mgmt_driver/kubespray/kubespray_vnf_package/Definitions/sample_kubernetes_types.yaml\nsamples/mgmt_driver/kubespray/kubespray_vnf_package/Definitions/sample_kubernetes_top.vnfd.yaml\n\nPlease let me know whether these were left intentionally.\n","commit_id":"7ab6f6bd46d51f5c37c71e1eca30c442d6c72d2c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e5e4a9af8ce995ea6d71dc6d84897614e7f3c16f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61cd309f_2ef16062","updated":"2022-02-08 14:26:57.000000000","message":"recheck","commit_id":"7ab6f6bd46d51f5c37c71e1eca30c442d6c72d2c"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5b81d109a2246aa8f817847fb4b0302a062aec21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"12948f7a_d4fe0664","in_reply_to":"4911e5e6_a2457690","updated":"2022-02-15 00:24:48.000000000","message":"I have verified.","commit_id":"7ab6f6bd46d51f5c37c71e1eca30c442d6c72d2c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e7294eba9b3e80c951a5d4ccfbc475f8737e8db6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4911e5e6_a2457690","in_reply_to":"8493b135_18129c31","updated":"2022-02-09 16:09:30.000000000","message":"Thanks for pointing out.\nSince I was greping only under the `tacker/tacker/` folder, so I missed it.\nI changed from CRLF to LF for all files under `tacker/` folder in PS2.","commit_id":"7ab6f6bd46d51f5c37c71e1eca30c442d6c72d2c"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5b81d109a2246aa8f817847fb4b0302a062aec21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b258335f_2939b338","updated":"2022-02-15 00:24:48.000000000","message":"Thanks for rework. LGTM!!","commit_id":"fbd91001727e03c4d1435ffb7e04c10dc531f41f"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"94d8d6584b6be15647327010252c06055eca0073","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b1a70e2f_6bd83e79","updated":"2022-02-21 18:22:41.000000000","message":"Let\u0027s me ask you to revise the commit message a little bit more to explain all of CRLF lines are fixed by your update.","commit_id":"6c052cac53e2c0c783f314dd5d11fe3207e93590"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5180265b07b48d77b1181dd819047635635d253a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"06b80929_a92f679d","updated":"2022-02-19 16:01:40.000000000","message":"recheck","commit_id":"6c052cac53e2c0c783f314dd5d11fe3207e93590"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ceb205751d335e9b88bffe60ff8ac3eeb8f7eb60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7680cb42_58049c22","updated":"2022-02-18 08:15:45.000000000","message":"recheck","commit_id":"6c052cac53e2c0c783f314dd5d11fe3207e93590"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"adfe97464fe1c3b53d9af89cbc8cc0f172e1cbb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"03124d06_3907eec0","updated":"2022-02-25 09:36:12.000000000","message":"ping\n\nTakahashi san, please kindly review this patch.","commit_id":"445a9458037092ba262b6a4636423db1b509f59d"}]}