)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"fb2b33c98062766fddb1e2b7d3d459ba32a70f7a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     navum \u003cnavum.gupta@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-05-20 12:53:29 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] `storageResourceIds` of the scaled out VDU is populated incorrect"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will fixes after scaling out a VDU, its value"},{"line_number":10,"context_line":"\".instantiatedVnfInfo.vnfcResourceInfo[].storageResourceIds\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"e5e0994b_d10d7494","line":7,"updated":"2022-06-01 06:39:53.000000000","message":"It\u0027s overed the 50 characters without [WIP].","commit_id":"0692c45f3755419a45d468fdfd1812f44df0ebbe"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"57270f7df6a95b5e40f39afdd4ad69e6010c9a70","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     navum \u003cnavum.gupta@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-05-20 12:53:29 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] `storageResourceIds` of the scaled out VDU is populated incorrect"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will fixes after scaling out a VDU, its value"},{"line_number":10,"context_line":"\".instantiatedVnfInfo.vnfcResourceInfo[].storageResourceIds\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"4af5c5c2_a75e13da","line":7,"in_reply_to":"e5e0994b_d10d7494","updated":"2022-07-04 05:58:46.000000000","message":"Fixed.","commit_id":"0692c45f3755419a45d468fdfd1812f44df0ebbe"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5370d1fb39a31ba4d055300090e328791bbe21ec","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Pooja Singla \u003cpooja.singla@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-12 18:47:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Incorrect `storageResourceIds` of scaled out VDU"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will fixes after scaling out a VDU, its value"},{"line_number":10,"context_line":"\".instantiatedVnfInfo.vnfcResourceInfo[].storageResourceIds\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"cd926bbd_97f44ead","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"updated":"2022-07-13 11:45:10.000000000","message":"Could you please change the commit title as the description of the fix/improvement proposed by the patch for example, \"Fix \u0027storageResourceIds\u0027 after SCALE-OUT\".","commit_id":"74355362a1b55474bfcd41292961a696b5348bd8"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"65ccd392ea1788c9c3c8ba1661a2e4b5ea160d38","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pooja Singla \u003cpooja.singla@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-12 18:47:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Incorrect `storageResourceIds` of scaled out VDU"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will fixes after scaling out a VDU, its value"},{"line_number":10,"context_line":"\".instantiatedVnfInfo.vnfcResourceInfo[].storageResourceIds\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ccf0afb8_df5f0d81","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"in_reply_to":"cd926bbd_97f44ead","updated":"2022-07-13 12:09:31.000000000","message":"Done","commit_id":"74355362a1b55474bfcd41292961a696b5348bd8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"476a50d3ba1da7b03ccf5324ff9496f5f3a4abd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"17130352_6fbec3bf","updated":"2022-05-23 04:23:40.000000000","message":"recheck","commit_id":"0692c45f3755419a45d468fdfd1812f44df0ebbe"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"e048aacb2bac1ac5f813581efd3772d4ed4bed39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1895bbf9_14c50fa1","updated":"2022-06-16 09:44:20.000000000","message":"recheck","commit_id":"2598b57c587b0ed74711559dbf19038a2cea0dc3"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"5370d1fb39a31ba4d055300090e328791bbe21ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2376b6c6_050b672a","updated":"2022-07-13 11:45:10.000000000","message":"Thanks for your patch. Please find review comment.","commit_id":"74355362a1b55474bfcd41292961a696b5348bd8"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"d64b8782f27a7e18406fc77dc42b40c984a31c4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"fdbe65be_f7d584b4","updated":"2022-07-27 09:54:14.000000000","message":"recheck","commit_id":"e69dc1dec6b45fad9c5155e7705b53621b212c8b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"336871f50b7cc72f6fcd2771a554d575808ee7c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e4812aa1_46b8225c","updated":"2022-08-10 08:21:58.000000000","message":"Thanks for your patch, LGTM.","commit_id":"b8c1f9daa21366efa20739a7969e0bf4aa7731f8"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"6b0d0bd8fc9b0794a62a665eec36bfcaa8915a6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ca5caded_95c1be2e","updated":"2022-08-09 08:10:22.000000000","message":"recheck","commit_id":"b8c1f9daa21366efa20739a7969e0bf4aa7731f8"}],"tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py":[{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"fb2b33c98062766fddb1e2b7d3d459ba32a70f7a","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        request_body \u003d (fake_vnflcm.VnfInstances"},{"line_number":187,"context_line":"                        .make_reverse_scale_request_body(\u0027SCALE_IN\u0027))"},{"line_number":188,"context_line":"        resp, _ \u003d self._scale_vnf_instance(vnf_instance_id, request_body)"},{"line_number":189,"context_line":"        self.assertEqual(vnf_instance.get(\u0027instantiatedVnfInfo\u0027)"},{"line_number":190,"context_line":"            [\u0027vnfcResourceInfo\u0027][0][\u0027storageResourceIds\u0027][0],"},{"line_number":191,"context_line":"            vnf_instance.get(\u0027instantiatedVnfInfo\u0027)"},{"line_number":192,"context_line":"            [\u0027virtualStorageResourceInfo\u0027][0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"e4443a8c_31af8f36","line":189,"updated":"2022-06-01 06:39:53.000000000","message":"I think it\u0027s better to check with Scale out.\nAlso, I think it would be better to compare all storageResourceIds and Id of virtualStorageResourceInfo after Scale Out.","commit_id":"0692c45f3755419a45d468fdfd1812f44df0ebbe"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"57270f7df6a95b5e40f39afdd4ad69e6010c9a70","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        request_body \u003d (fake_vnflcm.VnfInstances"},{"line_number":187,"context_line":"                        .make_reverse_scale_request_body(\u0027SCALE_IN\u0027))"},{"line_number":188,"context_line":"        resp, _ \u003d self._scale_vnf_instance(vnf_instance_id, request_body)"},{"line_number":189,"context_line":"        self.assertEqual(vnf_instance.get(\u0027instantiatedVnfInfo\u0027)"},{"line_number":190,"context_line":"            [\u0027vnfcResourceInfo\u0027][0][\u0027storageResourceIds\u0027][0],"},{"line_number":191,"context_line":"            vnf_instance.get(\u0027instantiatedVnfInfo\u0027)"},{"line_number":192,"context_line":"            [\u0027virtualStorageResourceInfo\u0027][0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"5be2a607_2c4e62a0","line":189,"in_reply_to":"e4443a8c_31af8f36","updated":"2022-07-04 05:58:46.000000000","message":"I think it\u0027s better to check with Scale out\n\u003e\u003e Fixed\n\nAlso, I think it would be better to compare all storageResourceIds and Id of virtualStorageResourceInfo after Scale Out.\n\u003e\u003e In test package there is only one storageResourceIds and virtualStorageResourceInfo.","commit_id":"0692c45f3755419a45d468fdfd1812f44df0ebbe"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b021cd13f3fb91e2ef1f266ccce306af0aa81367","unresolved":true,"context_lines":[{"line_number":179,"context_line":"            pre_stack_resource_list, post_stack_resource_list,"},{"line_number":180,"context_line":"            scale_type\u003d\u0027SCALE_OUT\u0027, expected_stack_status\u003d\u0027CREATE_COMPLETE\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        self.assertEqual(vnf_instance.get(\u0027instantiatedVnfInfo\u0027)"},{"line_number":183,"context_line":"            [\u0027vnfcResourceInfo\u0027][0][\u0027storageResourceIds\u0027][0],"},{"line_number":184,"context_line":"            vnf_instance.get(\u0027instantiatedVnfInfo\u0027)"},{"line_number":185,"context_line":"            [\u0027virtualStorageResourceInfo\u0027][0][\u0027id\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        # Scale-in vnf instance"},{"line_number":188,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9508d32f_838c844e","line":185,"range":{"start_line":182,"start_character":0,"end_line":185,"end_character":52},"updated":"2022-07-22 08:03:33.000000000","message":"I think we don\u0027t need to confirm it in FT because it\u0027s enough just do in UT. What do you think?","commit_id":"bf3afb4382b7d78b99e184a3ab667ef9c91702ce"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"6b0d0bd8fc9b0794a62a665eec36bfcaa8915a6f","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            pre_stack_resource_list, post_stack_resource_list,"},{"line_number":180,"context_line":"            scale_type\u003d\u0027SCALE_OUT\u0027, expected_stack_status\u003d\u0027CREATE_COMPLETE\u0027)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        self.assertEqual(vnf_instance.get(\u0027instantiatedVnfInfo\u0027)"},{"line_number":183,"context_line":"            [\u0027vnfcResourceInfo\u0027][0][\u0027storageResourceIds\u0027][0],"},{"line_number":184,"context_line":"            vnf_instance.get(\u0027instantiatedVnfInfo\u0027)"},{"line_number":185,"context_line":"            [\u0027virtualStorageResourceInfo\u0027][0][\u0027id\u0027])"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        # Scale-in vnf instance"},{"line_number":188,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"24021bfb_630cda70","line":185,"range":{"start_line":182,"start_character":0,"end_line":185,"end_character":52},"in_reply_to":"9508d32f_838c844e","updated":"2022-08-09 08:10:22.000000000","message":"Removed.","commit_id":"bf3afb4382b7d78b99e184a3ab667ef9c91702ce"}],"tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b021cd13f3fb91e2ef1f266ccce306af0aa81367","unresolved":true,"context_lines":[{"line_number":3587,"context_line":"        self.assertNotEqual(uuidsentinel.storage_id,"},{"line_number":3588,"context_line":"            vnf_instance.instantiated_vnf_info."},{"line_number":3589,"context_line":"            virtual_storage_resource_info[0].id)"},{"line_number":3590,"context_line":"        self.assertEqual(uuidsentinel.storage_id, [v_s_resource_info.id][0])"}],"source_content_type":"text/x-python","patch_set":14,"id":"a3855063_e25f241b","line":3590,"updated":"2022-07-22 08:03:33.000000000","message":"Why the brackets around `v_s_resource.info.id` are required?","commit_id":"bf3afb4382b7d78b99e184a3ab667ef9c91702ce"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"6b0d0bd8fc9b0794a62a665eec36bfcaa8915a6f","unresolved":false,"context_lines":[{"line_number":3587,"context_line":"        self.assertNotEqual(uuidsentinel.storage_id,"},{"line_number":3588,"context_line":"            vnf_instance.instantiated_vnf_info."},{"line_number":3589,"context_line":"            virtual_storage_resource_info[0].id)"},{"line_number":3590,"context_line":"        self.assertEqual(uuidsentinel.storage_id, [v_s_resource_info.id][0])"}],"source_content_type":"text/x-python","patch_set":14,"id":"243955a3_9a10251a","line":3590,"in_reply_to":"a3855063_e25f241b","updated":"2022-08-09 08:10:22.000000000","message":"fixed.","commit_id":"bf3afb4382b7d78b99e184a3ab667ef9c91702ce"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"fb2b33c98062766fddb1e2b7d3d459ba32a70f7a","unresolved":true,"context_lines":[{"line_number":1909,"context_line":"                                        if vnfc_rsc.id \u003d\u003d vnfc_id:"},{"line_number":1910,"context_line":"                                            vnfc_rsc.storage_resource_ids.\\"},{"line_number":1911,"context_line":"                                                append("},{"line_number":1912,"context_line":"                                                    virtual_storage_resource_info.id) # noqa"},{"line_number":1913,"context_line":"                                            break"},{"line_number":1914,"context_line":"                inst_vnf_info.vnfc_resource_info.extend(vnfc_rscs)"},{"line_number":1915,"context_line":"        if scale_vnf_request.type \u003d\u003d \u0027SCALE_IN\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"da7795f1_c607e7aa","line":1912,"updated":"2022-06-01 06:39:53.000000000","message":"Could you raise the nest by leaving \"if vnfc_id\" early?\nIf we can avoid noqa, we should avoid it.","commit_id":"0692c45f3755419a45d468fdfd1812f44df0ebbe"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"57270f7df6a95b5e40f39afdd4ad69e6010c9a70","unresolved":false,"context_lines":[{"line_number":1909,"context_line":"                                        if vnfc_rsc.id \u003d\u003d vnfc_id:"},{"line_number":1910,"context_line":"                                            vnfc_rsc.storage_resource_ids.\\"},{"line_number":1911,"context_line":"                                                append("},{"line_number":1912,"context_line":"                                                    virtual_storage_resource_info.id) # noqa"},{"line_number":1913,"context_line":"                                            break"},{"line_number":1914,"context_line":"                inst_vnf_info.vnfc_resource_info.extend(vnfc_rscs)"},{"line_number":1915,"context_line":"        if scale_vnf_request.type \u003d\u003d \u0027SCALE_IN\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7d393020_4ab83abc","line":1912,"in_reply_to":"da7795f1_c607e7aa","updated":"2022-07-04 05:58:46.000000000","message":"Removed noqa.","commit_id":"0692c45f3755419a45d468fdfd1812f44df0ebbe"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"366c173dc128a236913f3d1bd65369cfa52e072b","unresolved":true,"context_lines":[{"line_number":1905,"context_line":"                                vnfc_id \u003d storage_dict.\\"},{"line_number":1906,"context_line":"                                    get(rsc.physical_resource_id)"},{"line_number":1907,"context_line":"                                if vnfc_id:"},{"line_number":1908,"context_line":"                                    virt_storage_resource_id \u003d \\"},{"line_number":1909,"context_line":"                                        virtual_storage_resource_info.id"},{"line_number":1910,"context_line":"                                    for vnfc_rsc in vnfc_rscs:"},{"line_number":1911,"context_line":"                                        if vnfc_rsc.id \u003d\u003d vnfc_id:"}],"source_content_type":"text/x-python","patch_set":11,"id":"4a86427f_0e3abe57","line":1908,"updated":"2022-07-11 09:45:45.000000000","message":"Thank you modification.\nThe conversion of variables may not be good.\nHow about the following code?\n\n```\nif not vnfc_id:\n  continue\nfor vnfc_rsc in vnfc_rscs:\n  if vnfc_rsc.id \u003d\u003d vnfc_id:\n    vnfc_rsc.storage_resource_ids.append(\n        virtual_storage_resource_info.id)\n    break\n```","commit_id":"e2ab233bb64d79c677c10889a43c2514cbbf91ab"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"ae04af032455402a51af58fc83cc7e0e7d6d63de","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"                                vnfc_id \u003d storage_dict.\\"},{"line_number":1906,"context_line":"                                    get(rsc.physical_resource_id)"},{"line_number":1907,"context_line":"                                if vnfc_id:"},{"line_number":1908,"context_line":"                                    virt_storage_resource_id \u003d \\"},{"line_number":1909,"context_line":"                                        virtual_storage_resource_info.id"},{"line_number":1910,"context_line":"                                    for vnfc_rsc in vnfc_rscs:"},{"line_number":1911,"context_line":"                                        if vnfc_rsc.id \u003d\u003d vnfc_id:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3837122a_2d7df2b9","line":1908,"in_reply_to":"4a86427f_0e3abe57","updated":"2022-07-13 04:52:44.000000000","message":"Fixed.","commit_id":"e2ab233bb64d79c677c10889a43c2514cbbf91ab"}]}