)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add scale/modify functional tests of v2 APIs to the"},{"line_number":10,"context_line":"following test cases:"},{"line_number":11,"context_line":"* Test basic lcms for v2 api Max pattern."},{"line_number":12,"context_line":"* Test basic lcms for v2 api Min pattern."},{"line_number":13,"context_line":"* Test rollback update VNF for v2 api."},{"line_number":14,"context_line":"* Test update and scale out\u0027s before/after for v2 api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"4a8becf5_3afdc34c","line":11,"updated":"2022-03-04 11:38:02.000000000","message":"nits.\n\nJust my opinion, but I can\u0027t feel Max is an intuitive word. Something like full/complete might be easy to understand. As I said, it\u0027s just my personal feeling and you wrote the note at the test case to explain it, so please ignore it if the other members say it\u0027s not a problem.","commit_id":"507d20f33cc8b436642445f265bbaa2bb943b0e3"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add scale/modify functional tests of v2 APIs to the"},{"line_number":10,"context_line":"following test cases:"},{"line_number":11,"context_line":"* Test basic lcms for v2 api Max pattern."},{"line_number":12,"context_line":"* Test basic lcms for v2 api Min pattern."},{"line_number":13,"context_line":"* Test rollback update VNF for v2 api."},{"line_number":14,"context_line":"* Test update and scale out\u0027s before/after for v2 api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ce862c92_c706bd84","line":11,"in_reply_to":"2d49b7b3_a4de2028","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"507d20f33cc8b436642445f265bbaa2bb943b0e3"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"75a3961e07732d7c0dd4d731beda52fa701e3ba8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add scale/modify functional tests of v2 APIs to the"},{"line_number":10,"context_line":"following test cases:"},{"line_number":11,"context_line":"* Test basic lcms for v2 api Max pattern."},{"line_number":12,"context_line":"* Test basic lcms for v2 api Min pattern."},{"line_number":13,"context_line":"* Test rollback update VNF for v2 api."},{"line_number":14,"context_line":"* Test update and scale out\u0027s before/after for v2 api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c469a816_8f494127","line":11,"in_reply_to":"42b47665_fcf9d54c","updated":"2022-03-07 07:54:20.000000000","message":"IMO, it\u0027s okay as it is.\nWhen considering the antonyms as a set, I think that it will be as follows, but I feel that \"empty\" and \"incomplete\" cannot properly express the current \"min\" pattern.\n* max/min\n* full/empty\n* complete/incomplete\nPlease let me know the opinions of other people.","commit_id":"507d20f33cc8b436642445f265bbaa2bb943b0e3"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"36b78a5f2d5c4b009c780bb826aab4d00f1558b8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add scale/modify functional tests of v2 APIs to the"},{"line_number":10,"context_line":"following test cases:"},{"line_number":11,"context_line":"* Test basic lcms for v2 api Max pattern."},{"line_number":12,"context_line":"* Test basic lcms for v2 api Min pattern."},{"line_number":13,"context_line":"* Test rollback update VNF for v2 api."},{"line_number":14,"context_line":"* Test update and scale out\u0027s before/after for v2 api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"42b47665_fcf9d54c","line":11,"in_reply_to":"4a8becf5_3afdc34c","updated":"2022-03-07 04:06:20.000000000","message":"To yasufum, ueha and Hiroo Kitamura\nCould you tell me your opinion?\nI know it\u0027s not a critical problem.","commit_id":"507d20f33cc8b436642445f265bbaa2bb943b0e3"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add scale/modify functional tests of v2 APIs to the"},{"line_number":10,"context_line":"following test cases:"},{"line_number":11,"context_line":"* Test basic lcms for v2 api Max pattern."},{"line_number":12,"context_line":"* Test basic lcms for v2 api Min pattern."},{"line_number":13,"context_line":"* Test rollback update VNF for v2 api."},{"line_number":14,"context_line":"* Test update and scale out\u0027s before/after for v2 api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"2d49b7b3_a4de2028","line":11,"in_reply_to":"92d19df2_a516e17f","updated":"2022-03-08 10:26:54.000000000","message":"OK, so I kept max/min.","commit_id":"507d20f33cc8b436642445f265bbaa2bb943b0e3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1513517cdaa0f4db2510a9ea960b46e3df73922b","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add scale/modify functional tests of v2 APIs to the"},{"line_number":10,"context_line":"following test cases:"},{"line_number":11,"context_line":"* Test basic lcms for v2 api Max pattern."},{"line_number":12,"context_line":"* Test basic lcms for v2 api Min pattern."},{"line_number":13,"context_line":"* Test rollback update VNF for v2 api."},{"line_number":14,"context_line":"* Test update and scale out\u0027s before/after for v2 api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"92d19df2_a516e17f","line":11,"in_reply_to":"c469a816_8f494127","updated":"2022-03-07 08:36:43.000000000","message":"It may be just that I am not used to English, but IMO, there is no discomfort in min/max.\nIf it is changed to max, it will be had to change other file names and variable names as well.\nIf there is no other objection, I think it is better to leave it as it is.","commit_id":"507d20f33cc8b436642445f265bbaa2bb943b0e3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"345f17dda5008638de0c61fcb78907092d0f5dba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f425b85_fe81250e","updated":"2022-02-16 00:51:12.000000000","message":"recheck","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d63462ef_4f4a35ad","updated":"2022-03-04 11:38:02.000000000","message":"Thank you for the patch\n\nPlease kindly find my comments.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54eefaee59c75b1cb25f50b127f191aac06f7087","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3747c2c7_0a57c12e","updated":"2022-03-04 13:47:16.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"809fee992f5da2d557ad53d7d57e97fade9d2d0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bf11c48d_751d1a6a","updated":"2022-03-10 06:14:20.000000000","message":"I will set WF-1 once because this patch requires horizontal deployment and feedback from fixing for the parent patch [1] comments.\n\n[1] FT of instantiate/scale\u0027s ErrorHandling\n    https://review.opendev.org/c/openstack/tacker/+/826819/20","commit_id":"c42f9ff5a4e5c8a7a37913548e17457f76974be3"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9028b3b1_d34b8d3d","updated":"2022-03-09 10:31:39.000000000","message":"Thank you for re-work!","commit_id":"c42f9ff5a4e5c8a7a37913548e17457f76974be3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"626d6e26b69fad0ec7147ddc996eaa55827112c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3d759cc2_8968d979","updated":"2022-03-09 16:17:40.000000000","message":"recheck","commit_id":"c42f9ff5a4e5c8a7a37913548e17457f76974be3"}],"tacker/sol_refactored/conductor/vnflcm_driver_v2.py":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"e6b14ec392565e39e5dd50fe7c677a4a83ca8f23","unresolved":true,"context_lines":[{"line_number":102,"context_line":"            \u0027operation\u0027: operation,"},{"line_number":103,"context_line":"            \u0027request\u0027: req.to_dict(),"},{"line_number":104,"context_line":"            \u0027vnf_instance\u0027: inst.to_dict(),"},{"line_number":105,"context_line":"            \u0027grant_request\u0027: (grant_req.to_dict()"},{"line_number":106,"context_line":"                              if grant_req is not None else None),"},{"line_number":107,"context_line":"            \u0027grant_response\u0027: (grant.to_dict()"},{"line_number":108,"context_line":"                               if grant is not None else None),"},{"line_number":109,"context_line":"            \u0027tmp_csar_dir\u0027: tmp_csar_dir"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"        # script is relative path to Definitions/xxx.yaml"}],"source_content_type":"text/x-python","patch_set":12,"id":"64dea622_b5590906","line":108,"range":{"start_line":105,"start_character":0,"end_line":108,"end_character":63},"updated":"2022-03-09 05:28:17.000000000","message":"Thank you for fixing existing bug.\nhttps://bugs.launchpad.net/tacker/+bug/1962564\n\nWould you please add \"Closes-bug: #1962564\" in the commit message?","commit_id":"3fd1647e9781dccc43416ae286faa69ab4bb3d6a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ba218f172809b69417e652ed0b7de9c44d6cb0f8","unresolved":true,"context_lines":[{"line_number":102,"context_line":"            \u0027operation\u0027: operation,"},{"line_number":103,"context_line":"            \u0027request\u0027: req.to_dict(),"},{"line_number":104,"context_line":"            \u0027vnf_instance\u0027: inst.to_dict(),"},{"line_number":105,"context_line":"            \u0027grant_request\u0027: (grant_req.to_dict()"},{"line_number":106,"context_line":"                              if grant_req is not None else None),"},{"line_number":107,"context_line":"            \u0027grant_response\u0027: (grant.to_dict()"},{"line_number":108,"context_line":"                               if grant is not None else None),"},{"line_number":109,"context_line":"            \u0027tmp_csar_dir\u0027: tmp_csar_dir"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"        # script is relative path to Definitions/xxx.yaml"}],"source_content_type":"text/x-python","patch_set":12,"id":"2ecd4317_0e5f7714","line":108,"range":{"start_line":105,"start_character":0,"end_line":108,"end_character":63},"in_reply_to":"64dea622_b5590906","updated":"2022-03-09 08:49:38.000000000","message":"I have added it in the commit message.","commit_id":"3fd1647e9781dccc43416ae286faa69ab4bb3d6a"}],"tacker/tests/functional/sol_v2/samples/sample1/pkggen.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9755f2b92f4e8dfcda390d8ea814cfde343d724c","unresolved":true,"context_lines":[{"line_number":61,"context_line":"instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":62,"context_line":"    net_ids, subnet_ids, port_ids, \"http://localhost/identity/v3\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":65,"context_line":"    f.write(json.dumps(create_req, indent\u003d2))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"with open(\"terminate_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a7f5771f_209ed936","line":64,"range":{"start_line":64,"start_character":29,"end_line":64,"end_character":45},"updated":"2022-02-16 09:14:55.000000000","message":"Just a question.\nWill there be any problems if you don\u0027t fix this?","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b7cb9472cced3c73b5047cf7f80a0e1eb2530dac","unresolved":false,"context_lines":[{"line_number":61,"context_line":"instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":62,"context_line":"    net_ids, subnet_ids, port_ids, \"http://localhost/identity/v3\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":65,"context_line":"    f.write(json.dumps(create_req, indent\u003d2))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"with open(\"terminate_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1521e28e_33da1869","line":64,"range":{"start_line":64,"start_character":29,"end_line":64,"end_character":45},"in_reply_to":"98251e2f_423b5a4c","updated":"2022-02-18 09:27:41.000000000","message":"Okay, I see.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7bb370bf8cbf6cf69d7212dc91009344186325b5","unresolved":true,"context_lines":[{"line_number":61,"context_line":"instantiate_req \u003d paramgen.instantiate_vnf_max("},{"line_number":62,"context_line":"    net_ids, subnet_ids, port_ids, \"http://localhost/identity/v3\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"with open(\"create_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":65,"context_line":"    f.write(json.dumps(create_req, indent\u003d2))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"with open(\"terminate_req\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":1,"id":"98251e2f_423b5a4c","line":64,"range":{"start_line":64,"start_character":29,"end_line":64,"end_character":45},"in_reply_to":"a7f5771f_209ed936","updated":"2022-02-18 06:33:06.000000000","message":"If not, there\u0027s a pylint warning as follows. \n\nUsing open without explicitly specifying an encoding (41:5) [unspecified-encoding] ","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"}],"tacker/tests/functional/sol_v2/samples/update_change_ng/contents/Definitions/v2_sample2_df_simple.yaml":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"317e4f949b7bea0e3dea9e47655eb6825caa3c91","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            implementation: sample-script"},{"line_number":49,"context_line":"          terminate_end:"},{"line_number":50,"context_line":"            implementation: sample-script"},{"line_number":51,"context_line":"          change_external_connectivity_start:"},{"line_number":52,"context_line":"            implementation: sample-script"},{"line_number":53,"context_line":"          modify_information_start:"},{"line_number":54,"context_line":"            implementation: sample-script"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c2fc2986_c9b899ba","line":51,"updated":"2022-02-22 10:05:45.000000000","message":"IMO, the fewer VNF packages for FT, the better.\nThis \"update_change_ng\" package is almost the same as \"basic_lcms_min\" as shown below, and I think there is a possibility that it can be commonized.\n```\ndiff -r basic_lcms_min update_change_ng\ndiff -r basic_lcms_min/contents/Definitions/v2_sample2_df_simple.yaml update_change_ng/contents/Definitions/v2_sample2_df_simple.yaml\n50a51,54\n\u003e           change_external_connectivity_start:\n\u003e             implementation: sample-script\n\u003e           modify_information_start:\n\u003e             implementation: sample-script\ndiff -r basic_lcms_min/pkggen.py update_change_ng/pkggen.py\n39a40\n\u003e update_seq \u003d paramgen.update_vnf_min()\n54a56,58\n\u003e\n\u003e with open(\"update_seq\", \"w\", encoding\u003d\u0027utf-8\u0027) as f:\n\u003e     f.write(json.dumps(update_seq, indent\u003d2))\n```\nThe following abandoned patch is shown as a sample implementation.\nUsing this method, you can use a single VNF package to control whether an error occurs depending on whether the file is generated or not.\nCould you check it?\n* https://review.opendev.org/c/openstack/tacker/+/816300/6/tacker/tests/functional/sol_v2/samples/sample_error/contents/Scripts/sample_script.py\n* https://review.opendev.org/c/openstack/tacker/+/816300/6/tacker/tests/functional/sol_v2/test_vnflcm_basic.py#160","commit_id":"7b1380a4220bd22e64f1cefbb30c21c75986e55b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6cd26633e19c3526c6ee0533cb9e4c64e0d2cd64","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            implementation: sample-script"},{"line_number":49,"context_line":"          terminate_end:"},{"line_number":50,"context_line":"            implementation: sample-script"},{"line_number":51,"context_line":"          change_external_connectivity_start:"},{"line_number":52,"context_line":"            implementation: sample-script"},{"line_number":53,"context_line":"          modify_information_start:"},{"line_number":54,"context_line":"            implementation: sample-script"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1da6c5d8_f9391949","line":51,"in_reply_to":"934cec21_12ef710e","updated":"2022-03-09 01:07:18.000000000","message":"Done","commit_id":"7b1380a4220bd22e64f1cefbb30c21c75986e55b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"8a5799b416ac083a822b5002924a893d07553dc7","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            implementation: sample-script"},{"line_number":49,"context_line":"          terminate_end:"},{"line_number":50,"context_line":"            implementation: sample-script"},{"line_number":51,"context_line":"          change_external_connectivity_start:"},{"line_number":52,"context_line":"            implementation: sample-script"},{"line_number":53,"context_line":"          modify_information_start:"},{"line_number":54,"context_line":"            implementation: sample-script"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"934cec21_12ef710e","line":51,"in_reply_to":"c2fc2986_c9b899ba","updated":"2022-03-03 00:45:58.000000000","message":"I fixed it in the patchset8.","commit_id":"7b1380a4220bd22e64f1cefbb30c21c75986e55b"}],"tacker/tests/functional/sol_v2/test_vnflcm_basic.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9755f2b92f4e8dfcda390d8ea814cfde343d724c","unresolved":true,"context_lines":[{"line_number":192,"context_line":"          - 5. Create VNF instance"},{"line_number":193,"context_line":"          - 6. Instantiate VNF"},{"line_number":194,"context_line":"          - 7. Show VNF instance"},{"line_number":195,"context_line":"          - 8. List VNF instance"},{"line_number":196,"context_line":"          - 9. Show VNF LCM operation occurrence"},{"line_number":197,"context_line":"          - 10. List VNF LCM operation occurrence with attribute-based"},{"line_number":198,"context_line":"                filtering"}],"source_content_type":"text/x-python","patch_set":1,"id":"59c7ee5a_00ceb475","line":195,"updated":"2022-02-16 09:14:55.000000000","message":"\"with attribute-based filtering\" seems to be missing.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7a6d81cab33787abf509e771e420209ab5aeb57","unresolved":true,"context_lines":[{"line_number":192,"context_line":"          - 5. Create VNF instance"},{"line_number":193,"context_line":"          - 6. Instantiate VNF"},{"line_number":194,"context_line":"          - 7. Show VNF instance"},{"line_number":195,"context_line":"          - 8. List VNF instance"},{"line_number":196,"context_line":"          - 9. Show VNF LCM operation occurrence"},{"line_number":197,"context_line":"          - 10. List VNF LCM operation occurrence with attribute-based"},{"line_number":198,"context_line":"                filtering"}],"source_content_type":"text/x-python","patch_set":1,"id":"ab76439b_ad4f7c13","line":195,"in_reply_to":"59c7ee5a_00ceb475","updated":"2022-02-21 05:46:04.000000000","message":"I fixed it in the patchset 2.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":false,"context_lines":[{"line_number":192,"context_line":"          - 5. Create VNF instance"},{"line_number":193,"context_line":"          - 6. Instantiate VNF"},{"line_number":194,"context_line":"          - 7. Show VNF instance"},{"line_number":195,"context_line":"          - 8. List VNF instance"},{"line_number":196,"context_line":"          - 9. Show VNF LCM operation occurrence"},{"line_number":197,"context_line":"          - 10. List VNF LCM operation occurrence with attribute-based"},{"line_number":198,"context_line":"                filtering"}],"source_content_type":"text/x-python","patch_set":1,"id":"5744efb6_cb04d668","line":195,"in_reply_to":"ab76439b_ad4f7c13","updated":"2022-02-21 07:10:43.000000000","message":"Done","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9755f2b92f4e8dfcda390d8ea814cfde343d724c","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        vdu2_details \u003d self.get_server_details(\u0027VDU2\u0027)"},{"line_number":347,"context_line":"        vdu1_az \u003d vdu1_details.get(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":348,"context_line":"        vdu2_az \u003d vdu2_details.get(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":349,"context_line":"        self.assertEqual(vdu1_az, vdu2_az)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":352,"context_line":"            \u0027vimConnectionInfo\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"adb7413e_61ddc9a7","line":349,"updated":"2022-02-16 09:14:55.000000000","message":"Is there a possibility that it will be deployed in an availability zone other than \u0027nova\u0027?","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b7cb9472cced3c73b5047cf7f80a0e1eb2530dac","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        vdu2_details \u003d self.get_server_details(\u0027VDU2\u0027)"},{"line_number":347,"context_line":"        vdu1_az \u003d vdu1_details.get(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":348,"context_line":"        vdu2_az \u003d vdu2_details.get(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":349,"context_line":"        self.assertEqual(vdu1_az, vdu2_az)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":352,"context_line":"            \u0027vimConnectionInfo\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f2b0d1d3_bcc253cb","line":349,"in_reply_to":"0fcea105_f9331556","updated":"2022-02-18 09:27:41.000000000","message":"Assuming a zuul environment, I think it is better to leave this check, but is there any inconvenience when testing in your local environment?","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7bb370bf8cbf6cf69d7212dc91009344186325b5","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        vdu2_details \u003d self.get_server_details(\u0027VDU2\u0027)"},{"line_number":347,"context_line":"        vdu1_az \u003d vdu1_details.get(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":348,"context_line":"        vdu2_az \u003d vdu2_details.get(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":349,"context_line":"        self.assertEqual(vdu1_az, vdu2_az)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":352,"context_line":"            \u0027vimConnectionInfo\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0fcea105_f9331556","line":349,"in_reply_to":"adb7413e_61ddc9a7","updated":"2022-02-18 06:33:06.000000000","message":"In Zuul environment, there\u0027s no chance. But in other environment, it is possible.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7a6d81cab33787abf509e771e420209ab5aeb57","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        vdu2_details \u003d self.get_server_details(\u0027VDU2\u0027)"},{"line_number":347,"context_line":"        vdu1_az \u003d vdu1_details.get(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":348,"context_line":"        vdu2_az \u003d vdu2_details.get(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":349,"context_line":"        self.assertEqual(vdu1_az, vdu2_az)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":352,"context_line":"            \u0027vimConnectionInfo\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa8bf3f7_a4531f73","line":349,"in_reply_to":"f2b0d1d3_bcc253cb","updated":"2022-02-21 05:46:04.000000000","message":"There isn\u0027t any inconvenience in my local environment.\nI reverted it in the patchset 2.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        vdu2_details \u003d self.get_server_details(\u0027VDU2\u0027)"},{"line_number":347,"context_line":"        vdu1_az \u003d vdu1_details.get(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":348,"context_line":"        vdu2_az \u003d vdu2_details.get(\u0027OS-EXT-AZ:availability_zone\u0027)"},{"line_number":349,"context_line":"        self.assertEqual(vdu1_az, vdu2_az)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        additional_inst_attrs \u003d ["},{"line_number":352,"context_line":"            \u0027vimConnectionInfo\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bad16250_341d3810","line":349,"in_reply_to":"fa8bf3f7_a4531f73","updated":"2022-02-21 07:10:43.000000000","message":"Done","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9755f2b92f4e8dfcda390d8ea814cfde343d724c","unresolved":true,"context_lines":[{"line_number":432,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":433,"context_line":"            \u0027operation\u0027,"},{"line_number":434,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":435,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":436,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":437,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":438,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":1,"id":"52fe2ae2_5ca2705e","line":435,"updated":"2022-02-16 09:14:55.000000000","message":"Why is this fix needed?","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"7bb370bf8cbf6cf69d7212dc91009344186325b5","unresolved":true,"context_lines":[{"line_number":432,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":433,"context_line":"            \u0027operation\u0027,"},{"line_number":434,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":435,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":436,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":437,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":438,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":1,"id":"69bb2ad3_3c492ec7","line":435,"in_reply_to":"52fe2ae2_5ca2705e","updated":"2022-02-18 06:33:06.000000000","message":"According to the implentment, the operationParams field must be set.\nBut according to the SOL003, the operationParams field is optional.\nI don\u0027t know which should I follow to?\nPlease consider.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b7cb9472cced3c73b5047cf7f80a0e1eb2530dac","unresolved":true,"context_lines":[{"line_number":432,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":433,"context_line":"            \u0027operation\u0027,"},{"line_number":434,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":435,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":436,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":437,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":438,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f52dcc3_84933e8d","line":435,"in_reply_to":"69bb2ad3_3c492ec7","updated":"2022-02-18 09:27:41.000000000","message":"IMO, this test is a max case test, so it\u0027s better to check anything that has a value set in SOL003, whether optional or not.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":false,"context_lines":[{"line_number":432,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":433,"context_line":"            \u0027operation\u0027,"},{"line_number":434,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":435,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":436,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":437,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":438,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":1,"id":"e958f9f0_b0806000","line":435,"in_reply_to":"78a961d0_513232ab","updated":"2022-02-21 07:10:43.000000000","message":"Done","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7a6d81cab33787abf509e771e420209ab5aeb57","unresolved":true,"context_lines":[{"line_number":432,"context_line":"            # \u0027grantId\u0027, # omitted"},{"line_number":433,"context_line":"            \u0027operation\u0027,"},{"line_number":434,"context_line":"            \u0027isAutomaticInvocation\u0027,"},{"line_number":435,"context_line":"            # \u0027operationParams\u0027, # omitted"},{"line_number":436,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":437,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":438,"context_line":"            # \u0027error\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":1,"id":"78a961d0_513232ab","line":435,"in_reply_to":"7f52dcc3_84933e8d","updated":"2022-02-21 05:46:04.000000000","message":"OK, I reverted it in the patchset2.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9755f2b92f4e8dfcda390d8ea814cfde343d724c","unresolved":true,"context_lines":[{"line_number":436,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":437,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":438,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":439,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":440,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":441,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"},{"line_number":442,"context_line":"            # \u0027modificationsTriggeredByVnfPkgChange\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":1,"id":"0244bbe8_90f0e773","line":439,"updated":"2022-02-16 09:14:55.000000000","message":"ditto","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7a6d81cab33787abf509e771e420209ab5aeb57","unresolved":true,"context_lines":[{"line_number":436,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":437,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":438,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":439,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":440,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":441,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"},{"line_number":442,"context_line":"            # \u0027modificationsTriggeredByVnfPkgChange\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":1,"id":"7dc94f7e_f1928108","line":439,"in_reply_to":"0244bbe8_90f0e773","updated":"2022-02-21 05:46:04.000000000","message":"I fixed it in the patchset 2.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            \u0027isCancelPending\u0027,"},{"line_number":437,"context_line":"            # \u0027cancelMode\u0027, # omitted"},{"line_number":438,"context_line":"            # \u0027error\u0027, # omitted"},{"line_number":439,"context_line":"            # \u0027resourceChanges\u0027, # omitted"},{"line_number":440,"context_line":"            # \u0027changedInfo\u0027, # omitted"},{"line_number":441,"context_line":"            # \u0027changedExtConnectivity\u0027, # omitted"},{"line_number":442,"context_line":"            # \u0027modificationsTriggeredByVnfPkgChange\u0027, # omitted"}],"source_content_type":"text/x-python","patch_set":1,"id":"25906be7_727d297e","line":439,"in_reply_to":"7dc94f7e_f1928108","updated":"2022-02-21 07:10:43.000000000","message":"Done","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9755f2b92f4e8dfcda390d8ea814cfde343d724c","unresolved":true,"context_lines":[{"line_number":529,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":530,"context_line":"        count_after_scaleout \u003d len(nest_stack_list)"},{"line_number":531,"context_line":"        # check nested stack was created"},{"line_number":532,"context_line":"        self.assertTrue(count_after_scaleout \u003e count_after_inst)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        # 13. Scale in operation"},{"line_number":535,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":1,"id":"8d48b1a9_1b66dc1a","line":532,"updated":"2022-02-16 09:14:55.000000000","message":"Is it possible to make an assertion in anticipation of how many numbers will increase?","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":true,"context_lines":[{"line_number":529,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":530,"context_line":"        count_after_scaleout \u003d len(nest_stack_list)"},{"line_number":531,"context_line":"        # check nested stack was created"},{"line_number":532,"context_line":"        self.assertTrue(count_after_scaleout \u003e count_after_inst)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        # 13. Scale in operation"},{"line_number":535,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dffff545_442b688f","line":532,"in_reply_to":"08f086e8_8d0dfd9e","updated":"2022-02-21 07:10:43.000000000","message":"The expected number of increasing stacks is 9, but could you tell me how to calculate this number?\nIn addition, it\u0027s difficult for reviewers to understand this right away, could you add that in the comments?","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7a6d81cab33787abf509e771e420209ab5aeb57","unresolved":true,"context_lines":[{"line_number":529,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":530,"context_line":"        count_after_scaleout \u003d len(nest_stack_list)"},{"line_number":531,"context_line":"        # check nested stack was created"},{"line_number":532,"context_line":"        self.assertTrue(count_after_scaleout \u003e count_after_inst)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        # 13. Scale in operation"},{"line_number":535,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":1,"id":"08f086e8_8d0dfd9e","line":532,"in_reply_to":"8d48b1a9_1b66dc1a","updated":"2022-02-21 05:46:04.000000000","message":"I fixed it in the patchset 2.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"317e4f949b7bea0e3dea9e47655eb6825caa3c91","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":530,"context_line":"        count_after_scaleout \u003d len(nest_stack_list)"},{"line_number":531,"context_line":"        # check nested stack was created"},{"line_number":532,"context_line":"        self.assertTrue(count_after_scaleout \u003e count_after_inst)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        # 13. Scale in operation"},{"line_number":535,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":1,"id":"c7f2956b_adaab407","line":532,"in_reply_to":"a18dd96a_a9d19734","updated":"2022-02-22 10:05:45.000000000","message":"Done","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d084969ca10dc2c74128fa6fcf25659cba2a361c","unresolved":true,"context_lines":[{"line_number":529,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":530,"context_line":"        count_after_scaleout \u003d len(nest_stack_list)"},{"line_number":531,"context_line":"        # check nested stack was created"},{"line_number":532,"context_line":"        self.assertTrue(count_after_scaleout \u003e count_after_inst)"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"        # 13. Scale in operation"},{"line_number":535,"context_line":"        scalein_req \u003d paramgen.scalein_vnf_max()"}],"source_content_type":"text/x-python","patch_set":1,"id":"a18dd96a_a9d19734","line":532,"in_reply_to":"dffff545_442b688f","updated":"2022-02-22 01:14:52.000000000","message":"9 was the sum of 1 VM, 1 Volume, 1 VolumeType, 5 CPs,1 stack(VDU1.yaml).\nI Also added it in the comment in the patchset 3.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9755f2b92f4e8dfcda390d8ea814cfde343d724c","unresolved":true,"context_lines":[{"line_number":568,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":569,"context_line":"        count_after_scalein \u003d len(nest_stack_list)"},{"line_number":570,"context_line":"        # check nested stack was deleted"},{"line_number":571,"context_line":"        self.assertTrue(count_after_scalein \u003c count_after_scaleout)"},{"line_number":572,"context_line":"        # check nested stack was deleted"},{"line_number":573,"context_line":"        self.assertTrue(count_after_scalein \u003d\u003d count_after_inst)"},{"line_number":574,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6a29e845_cf242a48","line":571,"updated":"2022-02-16 09:14:55.000000000","message":"Isn\u0027t it unnecessary because it is included in L573?","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7a6d81cab33787abf509e771e420209ab5aeb57","unresolved":true,"context_lines":[{"line_number":568,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":569,"context_line":"        count_after_scalein \u003d len(nest_stack_list)"},{"line_number":570,"context_line":"        # check nested stack was deleted"},{"line_number":571,"context_line":"        self.assertTrue(count_after_scalein \u003c count_after_scaleout)"},{"line_number":572,"context_line":"        # check nested stack was deleted"},{"line_number":573,"context_line":"        self.assertTrue(count_after_scalein \u003d\u003d count_after_inst)"},{"line_number":574,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7732e60a_061d788e","line":571,"in_reply_to":"6a29e845_cf242a48","updated":"2022-02-21 05:46:04.000000000","message":"I fixed it in the patchset 2.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":569,"context_line":"        count_after_scalein \u003d len(nest_stack_list)"},{"line_number":570,"context_line":"        # check nested stack was deleted"},{"line_number":571,"context_line":"        self.assertTrue(count_after_scalein \u003c count_after_scaleout)"},{"line_number":572,"context_line":"        # check nested stack was deleted"},{"line_number":573,"context_line":"        self.assertTrue(count_after_scalein \u003d\u003d count_after_inst)"},{"line_number":574,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"58796243_64e2556b","line":571,"in_reply_to":"7732e60a_061d788e","updated":"2022-02-21 07:10:43.000000000","message":"Done","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9755f2b92f4e8dfcda390d8ea814cfde343d724c","unresolved":true,"context_lines":[{"line_number":570,"context_line":"        # check nested stack was deleted"},{"line_number":571,"context_line":"        self.assertTrue(count_after_scalein \u003c count_after_scaleout)"},{"line_number":572,"context_line":"        # check nested stack was deleted"},{"line_number":573,"context_line":"        self.assertTrue(count_after_scalein \u003d\u003d count_after_inst)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        # 15. Terminate a VNF instance"},{"line_number":576,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_max()"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7cfddf0_41241eab","line":573,"updated":"2022-02-16 09:14:55.000000000","message":"Is it possible to make an assertion in anticipation of how many numbers will decrease?","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d084969ca10dc2c74128fa6fcf25659cba2a361c","unresolved":true,"context_lines":[{"line_number":570,"context_line":"        # check nested stack was deleted"},{"line_number":571,"context_line":"        self.assertTrue(count_after_scalein \u003c count_after_scaleout)"},{"line_number":572,"context_line":"        # check nested stack was deleted"},{"line_number":573,"context_line":"        self.assertTrue(count_after_scalein \u003d\u003d count_after_inst)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        # 15. Terminate a VNF instance"},{"line_number":576,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_max()"}],"source_content_type":"text/x-python","patch_set":1,"id":"a0c67acc_077ea41d","line":573,"in_reply_to":"0b807867_897f9bf3","updated":"2022-02-22 01:14:52.000000000","message":"I fixed it in the patchset 3.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"317e4f949b7bea0e3dea9e47655eb6825caa3c91","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        # check nested stack was deleted"},{"line_number":571,"context_line":"        self.assertTrue(count_after_scalein \u003c count_after_scaleout)"},{"line_number":572,"context_line":"        # check nested stack was deleted"},{"line_number":573,"context_line":"        self.assertTrue(count_after_scalein \u003d\u003d count_after_inst)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        # 15. Terminate a VNF instance"},{"line_number":576,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_max()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a9069fd_a87e1b9f","line":573,"in_reply_to":"a0c67acc_077ea41d","updated":"2022-02-22 10:05:45.000000000","message":"Done","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":true,"context_lines":[{"line_number":570,"context_line":"        # check nested stack was deleted"},{"line_number":571,"context_line":"        self.assertTrue(count_after_scalein \u003c count_after_scaleout)"},{"line_number":572,"context_line":"        # check nested stack was deleted"},{"line_number":573,"context_line":"        self.assertTrue(count_after_scalein \u003d\u003d count_after_inst)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        # 15. Terminate a VNF instance"},{"line_number":576,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_max()"}],"source_content_type":"text/x-python","patch_set":1,"id":"0b807867_897f9bf3","line":573,"in_reply_to":"a6e3d197_e8d9fb3f","updated":"2022-02-21 07:10:43.000000000","message":"ditto","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7a6d81cab33787abf509e771e420209ab5aeb57","unresolved":true,"context_lines":[{"line_number":570,"context_line":"        # check nested stack was deleted"},{"line_number":571,"context_line":"        self.assertTrue(count_after_scalein \u003c count_after_scaleout)"},{"line_number":572,"context_line":"        # check nested stack was deleted"},{"line_number":573,"context_line":"        self.assertTrue(count_after_scalein \u003d\u003d count_after_inst)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        # 15. Terminate a VNF instance"},{"line_number":576,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_max()"}],"source_content_type":"text/x-python","patch_set":1,"id":"a6e3d197_e8d9fb3f","line":573,"in_reply_to":"f7cfddf0_41241eab","updated":"2022-02-21 05:46:04.000000000","message":"I fixed it in the patchset 2.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9755f2b92f4e8dfcda390d8ea814cfde343d724c","unresolved":true,"context_lines":[{"line_number":748,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":749,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":750,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":751,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # 7. Show VNF instance"},{"line_number":754,"context_line":"        additional_inst_attrs \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3d1381a3_58a8a1c9","line":751,"updated":"2022-02-16 09:14:55.000000000","message":"Even in this test case, it is better to confirm the increase in stack.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":true,"context_lines":[{"line_number":748,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":749,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":750,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":751,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # 7. Show VNF instance"},{"line_number":754,"context_line":"        additional_inst_attrs \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"f919ba09_14a02e70","line":751,"in_reply_to":"0ad4e96a_946b5807","updated":"2022-02-21 07:10:43.000000000","message":"ditto","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7a6d81cab33787abf509e771e420209ab5aeb57","unresolved":true,"context_lines":[{"line_number":748,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":749,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":750,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":751,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # 7. Show VNF instance"},{"line_number":754,"context_line":"        additional_inst_attrs \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"0ad4e96a_946b5807","line":751,"in_reply_to":"3d1381a3_58a8a1c9","updated":"2022-02-21 05:46:04.000000000","message":"I fixed it in the patchset 2.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d084969ca10dc2c74128fa6fcf25659cba2a361c","unresolved":true,"context_lines":[{"line_number":748,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":749,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":750,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":751,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # 7. Show VNF instance"},{"line_number":754,"context_line":"        additional_inst_attrs \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"fb237bd7_68bae42b","line":751,"in_reply_to":"f919ba09_14a02e70","updated":"2022-02-22 01:14:52.000000000","message":"I fixed it in the patchset 3.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"317e4f949b7bea0e3dea9e47655eb6825caa3c91","unresolved":false,"context_lines":[{"line_number":748,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":749,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":750,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":751,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # 7. Show VNF instance"},{"line_number":754,"context_line":"        additional_inst_attrs \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"c45840e4_db9bf9fb","line":751,"in_reply_to":"fb237bd7_68bae42b","updated":"2022-02-22 10:05:45.000000000","message":"Done","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9755f2b92f4e8dfcda390d8ea814cfde343d724c","unresolved":true,"context_lines":[{"line_number":767,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":768,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":769,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":770,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        # 9. Terminate a VNF instance"},{"line_number":773,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":1,"id":"90528dfd_e622c0c5","line":770,"updated":"2022-02-16 09:14:55.000000000","message":"Even in this test case, it is better to confirm the decrease in stack.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":true,"context_lines":[{"line_number":767,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":768,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":769,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":770,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        # 9. Terminate a VNF instance"},{"line_number":773,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9e55cc92_72cd2ea7","line":770,"in_reply_to":"1e85f6cb_a8bc9969","updated":"2022-02-21 07:10:43.000000000","message":"ditto","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"317e4f949b7bea0e3dea9e47655eb6825caa3c91","unresolved":false,"context_lines":[{"line_number":767,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":768,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":769,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":770,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        # 9. Terminate a VNF instance"},{"line_number":773,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":1,"id":"05a39794_a4f81645","line":770,"in_reply_to":"34ad819f_b4c05bd3","updated":"2022-02-22 10:05:45.000000000","message":"Done","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f7a6d81cab33787abf509e771e420209ab5aeb57","unresolved":true,"context_lines":[{"line_number":767,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":768,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":769,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":770,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        # 9. Terminate a VNF instance"},{"line_number":773,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e85f6cb_a8bc9969","line":770,"in_reply_to":"90528dfd_e622c0c5","updated":"2022-02-21 05:46:04.000000000","message":"I fixed it in the patchset 2.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d084969ca10dc2c74128fa6fcf25659cba2a361c","unresolved":true,"context_lines":[{"line_number":767,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":768,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":769,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":770,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        # 9. Terminate a VNF instance"},{"line_number":773,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":1,"id":"34ad819f_b4c05bd3","line":770,"in_reply_to":"9e55cc92_72cd2ea7","updated":"2022-02-22 01:14:52.000000000","message":"I fixed it in the patchset 3.","commit_id":"6112109fc92f87a2595f85d86e10ee3fcea4e36d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":38,"context_line":"        image_path \u003d os.path.abspath(os.path.join(image_dir, image_file))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        sample1_path \u003d os.path.join(cur_dir, \"samples/sample1\")"},{"line_number":41,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":42,"context_line":"            sample1_path, image_path\u003dimage_path)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"39257dd0_3d05438c","line":40,"range":{"start_line":40,"start_character":54,"end_line":40,"end_character":61},"updated":"2022-02-21 07:10:43.000000000","message":"Just as you changed the test case name from \"test_sample1\" to \"test_basic_lcms_max\", you would better to change the directories under this samples from \"sample1\" to \"basic_lcms_max\".","commit_id":"e40ed44da6650360ac868a7dcbeeab313d34eb6e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d084969ca10dc2c74128fa6fcf25659cba2a361c","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":38,"context_line":"        image_path \u003d os.path.abspath(os.path.join(image_dir, image_file))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        sample1_path \u003d os.path.join(cur_dir, \"samples/sample1\")"},{"line_number":41,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":42,"context_line":"            sample1_path, image_path\u003dimage_path)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"62cb4e8f_010696bb","line":40,"range":{"start_line":40,"start_character":54,"end_line":40,"end_character":61},"in_reply_to":"39257dd0_3d05438c","updated":"2022-02-22 01:14:52.000000000","message":"I fixed it in the patchset 3.","commit_id":"e40ed44da6650360ac868a7dcbeeab313d34eb6e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"317e4f949b7bea0e3dea9e47655eb6825caa3c91","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":38,"context_line":"        image_path \u003d os.path.abspath(os.path.join(image_dir, image_file))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        sample1_path \u003d os.path.join(cur_dir, \"samples/sample1\")"},{"line_number":41,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":42,"context_line":"            sample1_path, image_path\u003dimage_path)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0b8fd12b_e840db2b","line":40,"range":{"start_line":40,"start_character":54,"end_line":40,"end_character":61},"in_reply_to":"62cb4e8f_010696bb","updated":"2022-02-22 10:05:45.000000000","message":"Done","commit_id":"e40ed44da6650360ac868a7dcbeeab313d34eb6e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bcc51143f32b98fe3b7fce6b093b811ca614601","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":42,"context_line":"            sample1_path, image_path\u003dimage_path)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        sample2_path \u003d os.path.join(cur_dir, \"samples/sample2\")"},{"line_number":45,"context_line":"        # no image contained"},{"line_number":46,"context_line":"        cls.vnf_pkg_2, cls.vnfd_id_2 \u003d cls.create_vnf_package(sample2_path)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f40c0065_4b35556f","line":44,"range":{"start_line":44,"start_character":54,"end_line":44,"end_character":61},"updated":"2022-02-21 07:10:43.000000000","message":"ditto","commit_id":"e40ed44da6650360ac868a7dcbeeab313d34eb6e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"317e4f949b7bea0e3dea9e47655eb6825caa3c91","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":42,"context_line":"            sample1_path, image_path\u003dimage_path)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        sample2_path \u003d os.path.join(cur_dir, \"samples/sample2\")"},{"line_number":45,"context_line":"        # no image contained"},{"line_number":46,"context_line":"        cls.vnf_pkg_2, cls.vnfd_id_2 \u003d cls.create_vnf_package(sample2_path)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"53850dcd_f9f260c7","line":44,"range":{"start_line":44,"start_character":54,"end_line":44,"end_character":61},"in_reply_to":"0f884d9c_e624d1e5","updated":"2022-02-22 10:05:45.000000000","message":"Done","commit_id":"e40ed44da6650360ac868a7dcbeeab313d34eb6e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d084969ca10dc2c74128fa6fcf25659cba2a361c","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        cls.vnf_pkg_1, cls.vnfd_id_1 \u003d cls.create_vnf_package("},{"line_number":42,"context_line":"            sample1_path, image_path\u003dimage_path)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        sample2_path \u003d os.path.join(cur_dir, \"samples/sample2\")"},{"line_number":45,"context_line":"        # no image contained"},{"line_number":46,"context_line":"        cls.vnf_pkg_2, cls.vnfd_id_2 \u003d cls.create_vnf_package(sample2_path)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0f884d9c_e624d1e5","line":44,"range":{"start_line":44,"start_character":54,"end_line":44,"end_character":61},"in_reply_to":"f40c0065_4b35556f","updated":"2022-02-22 01:14:52.000000000","message":"I fixed it in the patchset 3.","commit_id":"e40ed44da6650360ac868a7dcbeeab313d34eb6e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"317e4f949b7bea0e3dea9e47655eb6825caa3c91","unresolved":true,"context_lines":[{"line_number":1139,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        # check vnfd id"},{"line_number":1142,"context_line":"        self.assertEqual(self.vnfd_id_3, body[\u0027vnfdId\u0027])"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        # check vnfc info"},{"line_number":1145,"context_line":"        vnfc_info \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5371131e_fc2b2e3f","line":1142,"updated":"2022-02-22 10:05:45.000000000","message":"In update, I think it\u0027s important to check whether the specified attribute can be updated without omission.\nCould you add assertions other than \"vnfdId\"?","commit_id":"7b1380a4220bd22e64f1cefbb30c21c75986e55b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":1139,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        # check vnfd id"},{"line_number":1142,"context_line":"        self.assertEqual(self.vnfd_id_3, body[\u0027vnfdId\u0027])"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        # check vnfc info"},{"line_number":1145,"context_line":"        vnfc_info \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"d852b2cf_23abdd72","line":1142,"in_reply_to":"5371131e_fc2b2e3f","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"7b1380a4220bd22e64f1cefbb30c21c75986e55b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ba218f172809b69417e652ed0b7de9c44d6cb0f8","unresolved":true,"context_lines":[{"line_number":1139,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        # check vnfd id"},{"line_number":1142,"context_line":"        self.assertEqual(self.vnfd_id_3, body[\u0027vnfdId\u0027])"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        # check vnfc info"},{"line_number":1145,"context_line":"        vnfc_info \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"b338bb45_dd63cc32","line":1142,"in_reply_to":"8c5a707e_7548c50a","updated":"2022-03-09 08:49:38.000000000","message":"I fixed it.","commit_id":"7b1380a4220bd22e64f1cefbb30c21c75986e55b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6cd26633e19c3526c6ee0533cb9e4c64e0d2cd64","unresolved":true,"context_lines":[{"line_number":1139,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        # check vnfd id"},{"line_number":1142,"context_line":"        self.assertEqual(self.vnfd_id_3, body[\u0027vnfdId\u0027])"},{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"        # check vnfc info"},{"line_number":1145,"context_line":"        vnfc_info \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"8c5a707e_7548c50a","line":1142,"in_reply_to":"d852b2cf_23abdd72","updated":"2022-03-09 01:07:18.000000000","message":"I think there is no need to distinguish between \"vnfdId\" and other attributes, you can just write as follows.\n\n```\n        # check the attributes after update VNF\n        self.assertEqual(self.vnfd_id_3, body[\u0027vnfdId\u0027])\n        self.assertEqual(\u0027new name\u0027, body[\u0027vnfInstanceName\u0027])\n        ...snip...\n```\nIn addition, can you add assertions for \"vnfConfigurableProperties\" and \"vimConnectionInfo\"?","commit_id":"7b1380a4220bd22e64f1cefbb30c21c75986e55b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(VnfLcmTest, self).setUp()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_api_versions(self):"},{"line_number":68,"context_line":"        \"\"\"Test version operations"}],"source_content_type":"text/x-python","patch_set":8,"id":"982652bd_3af4ebd8","line":65,"updated":"2022-03-04 11:38:02.000000000","message":"Maybe it\u0027s time to go Python3 style ``super()``.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(VnfLcmTest, self).setUp()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_api_versions(self):"},{"line_number":68,"context_line":"        \"\"\"Test version operations"}],"source_content_type":"text/x-python","patch_set":8,"id":"fb9ce2ad_1121fbd1","line":65,"in_reply_to":"982652bd_3af4ebd8","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cls.delete_vnf_package(cls.vnf_pkg_3)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(VnfLcmTest, self).setUp()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_api_versions(self):"},{"line_number":68,"context_line":"        \"\"\"Test version operations"}],"source_content_type":"text/x-python","patch_set":8,"id":"6858e82d_27a25261","line":65,"in_reply_to":"fb9ce2ad_1121fbd1","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":277,"context_line":"            self.check_resp_body(sbsc, expected_attrs)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # 5. Create VNF instance"},{"line_number":280,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"},{"line_number":281,"context_line":"        # because they are commented out in etsi_nfv_sol001."},{"line_number":282,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":283,"context_line":"            \u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"57bc3027_532370e3","line":280,"updated":"2022-03-04 11:38:02.000000000","message":"Could you please add the reference for SOL003?\n\nThis model may change in the future. Specifying the version and table helps other developers to see the validity of these values and where this these values came from.\n\n```\n# ETSI NFV SOL003 v3.3.1 5.5.2.2 Type: VnfInstance\n```","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"be9e6745e8c1dbd2ada3e913981d18ac4dba15dc","unresolved":true,"context_lines":[{"line_number":277,"context_line":"            self.check_resp_body(sbsc, expected_attrs)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # 5. Create VNF instance"},{"line_number":280,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"},{"line_number":281,"context_line":"        # because they are commented out in etsi_nfv_sol001."},{"line_number":282,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":283,"context_line":"            \u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7037b106_801f52ae","line":280,"in_reply_to":"57bc3027_532370e3","updated":"2022-03-07 05:40:45.000000000","message":"Sorry. Please remove `Type:`.\n```\n# ETSI NFV SOL003 v3.3.1 5.5.2.2 VnfInstance\n```","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":277,"context_line":"            self.check_resp_body(sbsc, expected_attrs)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # 5. Create VNF instance"},{"line_number":280,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"},{"line_number":281,"context_line":"        # because they are commented out in etsi_nfv_sol001."},{"line_number":282,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":283,"context_line":"            \u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"a8ea133a_923ef633","line":280,"in_reply_to":"7037b106_801f52ae","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            self.check_resp_body(sbsc, expected_attrs)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        # 5. Create VNF instance"},{"line_number":280,"context_line":"        # NOTE: extensions and vnfConfigurableProperties are omitted"},{"line_number":281,"context_line":"        # because they are commented out in etsi_nfv_sol001."},{"line_number":282,"context_line":"        expected_inst_attrs \u003d ["},{"line_number":283,"context_line":"            \u0027id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"b3cecfae_49e98687","line":280,"in_reply_to":"a8ea133a_923ef633","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":361,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        # check vnfState of VNF"},{"line_number":364,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":365,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        # 8. List VNF instance with attribute-based filtering"}],"source_content_type":"text/x-python","patch_set":8,"id":"9c5d36d1_5a0a3d40","line":364,"updated":"2022-03-04 11:38:02.000000000","message":"Maybe ``get`` is not necessary as it will cause an error when the key doesn\u0027t exist.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        # check vnfState of VNF"},{"line_number":364,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":365,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        # 8. List VNF instance with attribute-based filtering"}],"source_content_type":"text/x-python","patch_set":8,"id":"9c295a13_85fc09ab","line":364,"in_reply_to":"946e3864_7ad9e5fa","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":361,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        # check vnfState of VNF"},{"line_number":364,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":365,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        # 8. List VNF instance with attribute-based filtering"}],"source_content_type":"text/x-python","patch_set":8,"id":"946e3864_7ad9e5fa","line":364,"in_reply_to":"9c5d36d1_5a0a3d40","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":375,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":376,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":377,"context_line":"        for inst in body:"},{"line_number":378,"context_line":"            self.assertIsNotNone(inst.get(\u0027vnfInstanceName\u0027))"},{"line_number":379,"context_line":"            self.assertIsNotNone(inst.get(\u0027vnfInstanceDescription\u0027))"},{"line_number":380,"context_line":"            self.assertIsNotNone(inst.get(\u0027vimConnectionInfo\u0027))"},{"line_number":381,"context_line":"            self.assertIsNotNone(inst.get(\u0027instantiatedVnfInfo\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"3c9a9a10_4e67d79e","line":378,"updated":"2022-03-04 11:38:02.000000000","message":"How about using assertIn? It might be shorter in most cases.\n```\n            self.assertIn(\u0027operationParams\u0027, lcmocc)\n```\n\nIf I\u0027m right, please replace ``assertIsNotNone(d.get(\u0027key\u0027))`` with ``assertIn(\u0027key\u0027, d).","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":375,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":376,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":377,"context_line":"        for inst in body:"},{"line_number":378,"context_line":"            self.assertIsNotNone(inst.get(\u0027vnfInstanceName\u0027))"},{"line_number":379,"context_line":"            self.assertIsNotNone(inst.get(\u0027vnfInstanceDescription\u0027))"},{"line_number":380,"context_line":"            self.assertIsNotNone(inst.get(\u0027vimConnectionInfo\u0027))"},{"line_number":381,"context_line":"            self.assertIsNotNone(inst.get(\u0027instantiatedVnfInfo\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"3e52c425_1eed53be","line":378,"in_reply_to":"3c9a9a10_4e67d79e","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":376,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":377,"context_line":"        for inst in body:"},{"line_number":378,"context_line":"            self.assertIsNotNone(inst.get(\u0027vnfInstanceName\u0027))"},{"line_number":379,"context_line":"            self.assertIsNotNone(inst.get(\u0027vnfInstanceDescription\u0027))"},{"line_number":380,"context_line":"            self.assertIsNotNone(inst.get(\u0027vimConnectionInfo\u0027))"},{"line_number":381,"context_line":"            self.assertIsNotNone(inst.get(\u0027instantiatedVnfInfo\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"b2c7e639_ff70db07","line":378,"in_reply_to":"3e52c425_1eed53be","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":420,"context_line":"            self.assertIsNone(inst.get(\u0027metadata\u0027))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        # 9. Show VNF LCM operation occurrence"},{"line_number":423,"context_line":"        # NOTE: omitted values are not supported at that time"},{"line_number":424,"context_line":"        expected_attrs \u003d ["},{"line_number":425,"context_line":"            \u0027id\u0027,"},{"line_number":426,"context_line":"            \u0027operationState\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa21805b_7d007ec0","line":423,"updated":"2022-03-04 11:38:02.000000000","message":"Could you please add the reference for SOL003?\n\nThis model may change in the future. Specifying the version and table helps other developers to see the validity of these values and where this these values came from.\n\n```\n# ETSI NFV SOL003 v3.3.1 5.5.2.13 Type: VnfLcmOpOcc\n```","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            self.assertIsNone(inst.get(\u0027metadata\u0027))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        # 9. Show VNF LCM operation occurrence"},{"line_number":423,"context_line":"        # NOTE: omitted values are not supported at that time"},{"line_number":424,"context_line":"        expected_attrs \u003d ["},{"line_number":425,"context_line":"            \u0027id\u0027,"},{"line_number":426,"context_line":"            \u0027operationState\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"8f82f1b3_2dc89bb0","line":423,"in_reply_to":"4ba415c3_e0ecd499","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":420,"context_line":"            self.assertIsNone(inst.get(\u0027metadata\u0027))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        # 9. Show VNF LCM operation occurrence"},{"line_number":423,"context_line":"        # NOTE: omitted values are not supported at that time"},{"line_number":424,"context_line":"        expected_attrs \u003d ["},{"line_number":425,"context_line":"            \u0027id\u0027,"},{"line_number":426,"context_line":"            \u0027operationState\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"4ba415c3_e0ecd499","line":423,"in_reply_to":"81d64b79_cb699757","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"be9e6745e8c1dbd2ada3e913981d18ac4dba15dc","unresolved":true,"context_lines":[{"line_number":420,"context_line":"            self.assertIsNone(inst.get(\u0027metadata\u0027))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        # 9. Show VNF LCM operation occurrence"},{"line_number":423,"context_line":"        # NOTE: omitted values are not supported at that time"},{"line_number":424,"context_line":"        expected_attrs \u003d ["},{"line_number":425,"context_line":"            \u0027id\u0027,"},{"line_number":426,"context_line":"            \u0027operationState\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"81d64b79_cb699757","line":423,"in_reply_to":"fa21805b_7d007ec0","updated":"2022-03-07 05:40:45.000000000","message":"Sorry, please remove `Type:`\n\n```\n# ETSI NFV SOL003 v3.3.1 5.5.2.13 VnfLcmOpOcc\n```","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":477,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":478,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":479,"context_line":"        for lcmocc in body:"},{"line_number":480,"context_line":"            self.assertIsNone(lcmocc.get(\u0027operationParams\u0027))"},{"line_number":481,"context_line":"            self.assertIsNotNone(lcmocc.get(\u0027resourceChanges\u0027))"},{"line_number":482,"context_line":"        # * exclude_default"},{"line_number":483,"context_line":"        #   -\u003e check the attribute omitted in \"exclude_default\" is not set."}],"source_content_type":"text/x-python","patch_set":8,"id":"6bd07aed_fb23cd04","line":480,"updated":"2022-03-04 11:38:02.000000000","message":"How about this?\n```\nself.assertNotIn(\u0027operationParams\u0027, lcmocc)\n```\n\nPlease replace the similar parts if the above example works.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":477,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":478,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":479,"context_line":"        for lcmocc in body:"},{"line_number":480,"context_line":"            self.assertIsNone(lcmocc.get(\u0027operationParams\u0027))"},{"line_number":481,"context_line":"            self.assertIsNotNone(lcmocc.get(\u0027resourceChanges\u0027))"},{"line_number":482,"context_line":"        # * exclude_default"},{"line_number":483,"context_line":"        #   -\u003e check the attribute omitted in \"exclude_default\" is not set."}],"source_content_type":"text/x-python","patch_set":8,"id":"bf940a02_f74c9a64","line":480,"in_reply_to":"6bd07aed_fb23cd04","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":477,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":478,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":479,"context_line":"        for lcmocc in body:"},{"line_number":480,"context_line":"            self.assertIsNone(lcmocc.get(\u0027operationParams\u0027))"},{"line_number":481,"context_line":"            self.assertIsNotNone(lcmocc.get(\u0027resourceChanges\u0027))"},{"line_number":482,"context_line":"        # * exclude_default"},{"line_number":483,"context_line":"        #   -\u003e check the attribute omitted in \"exclude_default\" is not set."}],"source_content_type":"text/x-python","patch_set":8,"id":"49d83152_b0c96fa1","line":480,"in_reply_to":"bf940a02_f74c9a64","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"36b78a5f2d5c4b009c780bb826aab4d00f1558b8","unresolved":true,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        # 11. Scale out operation"},{"line_number":494,"context_line":"        # get nested stack count before scale out"},{"line_number":495,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":496,"context_line":"        count_before_scaleout \u003d len(nest_stack_list)"},{"line_number":497,"context_line":"        scaleout_req \u003d paramgen.scaleout_vnf_max()"},{"line_number":498,"context_line":"        resp, body \u003d self.scale_vnf_instance(inst_id, scaleout_req)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bc5f9d92_c29c9027","line":495,"updated":"2022-03-07 04:06:20.000000000","message":"nested_stack_list or nested_stacks?\n\nI think plural is preferable in Python :)","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        # 11. Scale out operation"},{"line_number":494,"context_line":"        # get nested stack count before scale out"},{"line_number":495,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":496,"context_line":"        count_before_scaleout \u003d len(nest_stack_list)"},{"line_number":497,"context_line":"        scaleout_req \u003d paramgen.scaleout_vnf_max()"},{"line_number":498,"context_line":"        resp, body \u003d self.scale_vnf_instance(inst_id, scaleout_req)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bd3e5109_24d87aae","line":495,"in_reply_to":"61320183_801a61e1","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"        # 11. Scale out operation"},{"line_number":494,"context_line":"        # get nested stack count before scale out"},{"line_number":495,"context_line":"        nest_stack_list \u003d self.heat_client.get_resources(stack_name)"},{"line_number":496,"context_line":"        count_before_scaleout \u003d len(nest_stack_list)"},{"line_number":497,"context_line":"        scaleout_req \u003d paramgen.scaleout_vnf_max()"},{"line_number":498,"context_line":"        resp, body \u003d self.scale_vnf_instance(inst_id, scaleout_req)"}],"source_content_type":"text/x-python","patch_set":8,"id":"61320183_801a61e1","line":495,"in_reply_to":"bc5f9d92_c29c9027","updated":"2022-03-08 10:26:54.000000000","message":"I changed it to nested_stacks.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        # check vnfState of VNF"},{"line_number":516,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":517,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        # check scaleStatus"},{"line_number":520,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"0085809d_e3462a5c","line":517,"updated":"2022-03-04 11:38:02.000000000","message":"Maybe ``get`` is not necessary as it will cause an error when the key doesn\u0027t exist.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        # check vnfState of VNF"},{"line_number":516,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":517,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        # check scaleStatus"},{"line_number":520,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"11e42cd1_6e793cff","line":517,"in_reply_to":"0085809d_e3462a5c","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        # check vnfState of VNF"},{"line_number":516,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":517,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        # check scaleStatus"},{"line_number":520,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"a601aa6f_e7513280","line":517,"in_reply_to":"11e42cd1_6e793cff","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        # check scaleStatus"},{"line_number":520,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"},{"line_number":521,"context_line":"        self.assertTrue(len(scale_status) \u003e 0)"},{"line_number":522,"context_line":"        for status in scale_status:"},{"line_number":523,"context_line":"            self.assertIsNotNone(status.get(\u0027aspectId\u0027))"},{"line_number":524,"context_line":"            self.assertIsNotNone(status.get(\u0027scaleLevel\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"17d6e170_b1dbc402","line":521,"updated":"2022-03-04 11:38:02.000000000","message":"Why don\u0027t you use assertGreater [1]?\n\n[1] https://docs.python.org/ja/3/library/unittest.html?highlight\u003dassert#unittest.TestCase.assertGreater","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        # check scaleStatus"},{"line_number":520,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"},{"line_number":521,"context_line":"        self.assertTrue(len(scale_status) \u003e 0)"},{"line_number":522,"context_line":"        for status in scale_status:"},{"line_number":523,"context_line":"            self.assertIsNotNone(status.get(\u0027aspectId\u0027))"},{"line_number":524,"context_line":"            self.assertIsNotNone(status.get(\u0027scaleLevel\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"6d402b0c_260bec15","line":521,"in_reply_to":"17d6e170_b1dbc402","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        # check scaleStatus"},{"line_number":520,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"},{"line_number":521,"context_line":"        self.assertTrue(len(scale_status) \u003e 0)"},{"line_number":522,"context_line":"        for status in scale_status:"},{"line_number":523,"context_line":"            self.assertIsNotNone(status.get(\u0027aspectId\u0027))"},{"line_number":524,"context_line":"            self.assertIsNotNone(status.get(\u0027scaleLevel\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"95418dab_995aec79","line":521,"in_reply_to":"6d402b0c_260bec15","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        # check vnfState of VNF"},{"line_number":557,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":558,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # check scaleStatus"},{"line_number":561,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"ca1f0eef_374e1081","line":558,"updated":"2022-03-04 11:38:02.000000000","message":"Maybe ``get`` is not necessary as it will cause an error when the key doesn\u0027t exist.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        # check vnfState of VNF"},{"line_number":557,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":558,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # check scaleStatus"},{"line_number":561,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9e885274_4b44a9a9","line":558,"in_reply_to":"96fab200_fc12d3b1","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        # check vnfState of VNF"},{"line_number":557,"context_line":"        self.assertEqual(fields.VnfOperationalStateType.STARTED,"},{"line_number":558,"context_line":"                         body[\u0027instantiatedVnfInfo\u0027].get(\u0027vnfState\u0027))"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # check scaleStatus"},{"line_number":561,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"96fab200_fc12d3b1","line":558,"in_reply_to":"ca1f0eef_374e1081","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # check scaleStatus"},{"line_number":561,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"},{"line_number":562,"context_line":"        self.assertTrue(len(scale_status) \u003e 0)"},{"line_number":563,"context_line":"        for status in scale_status:"},{"line_number":564,"context_line":"            self.assertIsNotNone(status.get(\u0027aspectId\u0027))"},{"line_number":565,"context_line":"            self.assertIsNotNone(status.get(\u0027scaleLevel\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"fb28f842_0b04b288","line":562,"updated":"2022-03-04 11:38:02.000000000","message":"Why don\u0027t you use assertGreater [1]?\n\n[1] https://docs.python.org/ja/3/library/unittest.html?highlight\u003dassert#unittest.TestCase.assertGreater","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # check scaleStatus"},{"line_number":561,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"},{"line_number":562,"context_line":"        self.assertTrue(len(scale_status) \u003e 0)"},{"line_number":563,"context_line":"        for status in scale_status:"},{"line_number":564,"context_line":"            self.assertIsNotNone(status.get(\u0027aspectId\u0027))"},{"line_number":565,"context_line":"            self.assertIsNotNone(status.get(\u0027scaleLevel\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5ed97ebc_bcef0b6d","line":562,"in_reply_to":"a42e4a0d_86c9c049","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"        # check scaleStatus"},{"line_number":561,"context_line":"        scale_status \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027scaleStatus\u0027]"},{"line_number":562,"context_line":"        self.assertTrue(len(scale_status) \u003e 0)"},{"line_number":563,"context_line":"        for status in scale_status:"},{"line_number":564,"context_line":"            self.assertIsNotNone(status.get(\u0027aspectId\u0027))"},{"line_number":565,"context_line":"            self.assertIsNotNone(status.get(\u0027scaleLevel\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"a42e4a0d_86c9c049","line":562,"in_reply_to":"fb28f842_0b04b288","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":575,"context_line":"        # 1 stack(VDU1.yaml)"},{"line_number":576,"context_line":"        self.assertEqual(9, count_after_scaleout - count_after_scalein)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        # check usageState of VNF Package 1"},{"line_number":579,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_1)[\u0027usageState\u0027]"},{"line_number":580,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        # check usageState of VNF Package 3"},{"line_number":583,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_3)[\u0027usageState\u0027]"},{"line_number":584,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"        # check vnfd id"},{"line_number":587,"context_line":"        self.assertEqual(self.vnfd_id_1, body[\u0027vnfdId\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"c51a6617_966c0da1","line":584,"range":{"start_line":578,"start_character":0,"end_line":584,"end_character":51},"updated":"2022-03-04 11:38:02.000000000","message":"Could you please add the note here? At first I can\u0027t understand why the usageStates of these package are checked here. Isn\u0027t it a part of the succeeding steps?  i.e., 15. Update VNF -","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        # 1 stack(VDU1.yaml)"},{"line_number":576,"context_line":"        self.assertEqual(9, count_after_scaleout - count_after_scalein)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        # check usageState of VNF Package 1"},{"line_number":579,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_1)[\u0027usageState\u0027]"},{"line_number":580,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        # check usageState of VNF Package 3"},{"line_number":583,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_3)[\u0027usageState\u0027]"},{"line_number":584,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"        # check vnfd id"},{"line_number":587,"context_line":"        self.assertEqual(self.vnfd_id_1, body[\u0027vnfdId\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"7fe841a1_a51d08a0","line":584,"range":{"start_line":578,"start_character":0,"end_line":584,"end_character":51},"in_reply_to":"3bdb3ac3_653d57ad","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":575,"context_line":"        # 1 stack(VDU1.yaml)"},{"line_number":576,"context_line":"        self.assertEqual(9, count_after_scaleout - count_after_scalein)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        # check usageState of VNF Package 1"},{"line_number":579,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_1)[\u0027usageState\u0027]"},{"line_number":580,"context_line":"        self.assertEqual(\u0027IN_USE\u0027, usage_state)"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        # check usageState of VNF Package 3"},{"line_number":583,"context_line":"        usage_state \u003d self.get_vnf_package(self.vnf_pkg_3)[\u0027usageState\u0027]"},{"line_number":584,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"        # check vnfd id"},{"line_number":587,"context_line":"        self.assertEqual(self.vnfd_id_1, body[\u0027vnfdId\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"3bdb3ac3_653d57ad","line":584,"range":{"start_line":578,"start_character":0,"end_line":584,"end_character":51},"in_reply_to":"c51a6617_966c0da1","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"677e81853fb754e85123b7ba9e22cd116a4c2c01","unresolved":true,"context_lines":[{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        # check vnfc info"},{"line_number":590,"context_line":"        vnfc_info \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027]"},{"line_number":591,"context_line":"        self.assertTrue(len(vnfc_info) \u003e 1)"},{"line_number":592,"context_line":"        vnfc_ids \u003d []"},{"line_number":593,"context_line":"        for vnfc in vnfc_info:"},{"line_number":594,"context_line":"            self.assertIsNotNone(vnfc.get(\u0027id\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"a80e0210_98e1e1d3","line":591,"updated":"2022-03-04 11:38:02.000000000","message":"Why don\u0027t you use assertGreater [1]?\n\n[1] https://docs.python.org/ja/3/library/unittest.html?highlight\u003dassert#unittest.TestCase.assertGreater","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        # check vnfc info"},{"line_number":590,"context_line":"        vnfc_info \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027]"},{"line_number":591,"context_line":"        self.assertTrue(len(vnfc_info) \u003e 1)"},{"line_number":592,"context_line":"        vnfc_ids \u003d []"},{"line_number":593,"context_line":"        for vnfc in vnfc_info:"},{"line_number":594,"context_line":"            self.assertIsNotNone(vnfc.get(\u0027id\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"c48284ee_3284550b","line":591,"in_reply_to":"a80e0210_98e1e1d3","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        # check vnfc info"},{"line_number":590,"context_line":"        vnfc_info \u003d body[\u0027instantiatedVnfInfo\u0027][\u0027vnfcInfo\u0027]"},{"line_number":591,"context_line":"        self.assertTrue(len(vnfc_info) \u003e 1)"},{"line_number":592,"context_line":"        vnfc_ids \u003d []"},{"line_number":593,"context_line":"        for vnfc in vnfc_info:"},{"line_number":594,"context_line":"            self.assertIsNotNone(vnfc.get(\u0027id\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"b032d96e_b65875a6","line":591,"in_reply_to":"c48284ee_3284550b","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"89e1d0cbe8b0ff288a2f05edbb33dc9903eecc97","unresolved":true,"context_lines":[{"line_number":899,"context_line":"        count_after_scalein \u003d len(nest_stack_list)"},{"line_number":900,"context_line":"        # check nested stack was deleted"},{"line_number":901,"context_line":"        # 3 was the sum of 1 VM, 1 CP, 1 stack(VDU1.yaml)"},{"line_number":902,"context_line":"        self.assertTrue(3, count_after_scaleout - count_after_scalein)"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"        # 11. Terminate a VNF instance"},{"line_number":905,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":8,"id":"851f2678_9211e7cb","line":902,"updated":"2022-03-04 12:05:56.000000000","message":"```\nself.assertEqual(3, count_after_scaleout - count_after_scalein)\n```","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"85d025c4f7e0e3b398d4d67d1a6755184fc29c7d","unresolved":false,"context_lines":[{"line_number":899,"context_line":"        count_after_scalein \u003d len(nest_stack_list)"},{"line_number":900,"context_line":"        # check nested stack was deleted"},{"line_number":901,"context_line":"        # 3 was the sum of 1 VM, 1 CP, 1 stack(VDU1.yaml)"},{"line_number":902,"context_line":"        self.assertTrue(3, count_after_scaleout - count_after_scalein)"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"        # 11. Terminate a VNF instance"},{"line_number":905,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":8,"id":"19e92e54_c3421ee4","line":902,"in_reply_to":"351e2f02_515da8de","updated":"2022-03-09 10:31:39.000000000","message":"Ack","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":899,"context_line":"        count_after_scalein \u003d len(nest_stack_list)"},{"line_number":900,"context_line":"        # check nested stack was deleted"},{"line_number":901,"context_line":"        # 3 was the sum of 1 VM, 1 CP, 1 stack(VDU1.yaml)"},{"line_number":902,"context_line":"        self.assertTrue(3, count_after_scaleout - count_after_scalein)"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"        # 11. Terminate a VNF instance"},{"line_number":905,"context_line":"        terminate_req \u003d paramgen.terminate_vnf_min()"}],"source_content_type":"text/x-python","patch_set":8,"id":"351e2f02_515da8de","line":902,"in_reply_to":"851f2678_9211e7cb","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54eefaee59c75b1cb25f50b127f191aac06f7087","unresolved":true,"context_lines":[{"line_number":951,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"    def test_update_scale_lcm(self):"},{"line_number":954,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"        * About attributes:"},{"line_number":957,"context_line":"          All of the following cardinality attributes are set."}],"source_content_type":"text/x-python","patch_set":8,"id":"501a939b_76b7e2d6","line":954,"range":{"start_line":954,"start_character":11,"end_line":954,"end_character":54},"updated":"2022-03-04 13:47:16.000000000","message":"Could you change the docstring to match the purpose of the test?","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":951,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"    def test_update_scale_lcm(self):"},{"line_number":954,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"        * About attributes:"},{"line_number":957,"context_line":"          All of the following cardinality attributes are set."}],"source_content_type":"text/x-python","patch_set":8,"id":"a49c0daa_0dd2095c","line":954,"range":{"start_line":954,"start_character":11,"end_line":954,"end_character":54},"in_reply_to":"501a939b_76b7e2d6","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"673b021481972272016a56352e78536f01605a1b","unresolved":false,"context_lines":[{"line_number":951,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"    def test_update_scale_lcm(self):"},{"line_number":954,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"        * About attributes:"},{"line_number":957,"context_line":"          All of the following cardinality attributes are set."}],"source_content_type":"text/x-python","patch_set":8,"id":"30155db8_b9bb366a","line":954,"range":{"start_line":954,"start_character":11,"end_line":954,"end_character":54},"in_reply_to":"a49c0daa_0dd2095c","updated":"2022-03-10 04:14:04.000000000","message":"I\u0027ve confirmed.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"}],"tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"54eefaee59c75b1cb25f50b127f191aac06f7087","unresolved":true,"context_lines":[{"line_number":649,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def test_rollback_update(self):"},{"line_number":652,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"        * About attributes:"},{"line_number":655,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":8,"id":"41ec46d0_f0bdcab4","line":652,"range":{"start_line":652,"start_character":11,"end_line":652,"end_character":75},"updated":"2022-03-04 13:47:16.000000000","message":"Could you change the docstring to match the purpose of the test?","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"477ffe215ec9bc892b4f6b9564b9253501044a51","unresolved":true,"context_lines":[{"line_number":649,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def test_rollback_update(self):"},{"line_number":652,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"        * About attributes:"},{"line_number":655,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":8,"id":"877c8a67_3553f304","line":652,"range":{"start_line":652,"start_character":11,"end_line":652,"end_character":75},"in_reply_to":"41ec46d0_f0bdcab4","updated":"2022-03-08 10:26:54.000000000","message":"I fixed it in the patchset10.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"673b021481972272016a56352e78536f01605a1b","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def test_rollback_update(self):"},{"line_number":652,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"        * About attributes:"},{"line_number":655,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":8,"id":"ebb42338_d6e3e479","line":652,"range":{"start_line":652,"start_character":11,"end_line":652,"end_character":75},"in_reply_to":"877c8a67_3553f304","updated":"2022-03-10 04:14:04.000000000","message":"I\u0027ve confirmed.","commit_id":"bd5b4b70cdd6d5cd15f2a0739290a15bbdec117d"}]}