)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"374a44cf075e7690c6e18517d6394ea2839d405e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"766b3ddf_55cfdc9d","updated":"2022-03-04 13:06:41.000000000","message":"Could you follow the guideline of Commit message.\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n```\n* The first line should be limited to 50 characters and should not end with a period.\n* Subsequent lines should be wrapped at 72 characters.\n```","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0a33a245640cb7aeac5f0c860db81d12cb2c8e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"246ea7d6_5aca44d5","in_reply_to":"24484622_bf279dec","updated":"2022-03-08 12:25:37.000000000","message":"I\u0027ve confirmed.","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b1b7db838d8b3258f806fc4135853e524e409e13","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"24484622_bf279dec","in_reply_to":"766b3ddf_55cfdc9d","updated":"2022-03-07 01:06:52.000000000","message":"Has fixed.","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"374a44cf075e7690c6e18517d6394ea2839d405e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for subscribe a notification with OAuth 2.0 authorization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes `bug 1962423`_, modify the back-end send notifications authentication"},{"line_number":10,"context_line":"processing logic and change the property \u0027subscription_authentication\u0027 to"},{"line_number":11,"context_line":"\u0027authentication\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"275e057a_5ef132e0","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":20},"updated":"2022-03-04 13:06:41.000000000","message":"Could you add the following before the `Change-Id` line?\n\u003e Closes-Bug: #1962423\n\nAnd how about starting with `This patch modifies the ...`?","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b1b7db838d8b3258f806fc4135853e524e409e13","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for subscribe a notification with OAuth 2.0 authorization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes `bug 1962423`_, modify the back-end send notifications authentication"},{"line_number":10,"context_line":"processing logic and change the property \u0027subscription_authentication\u0027 to"},{"line_number":11,"context_line":"\u0027authentication\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"cd601399_067cf4ca","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":20},"in_reply_to":"275e057a_5ef132e0","updated":"2022-03-07 01:06:52.000000000","message":"Has fixed.","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0a33a245640cb7aeac5f0c860db81d12cb2c8e6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for subscribe a notification with OAuth 2.0 authorization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes `bug 1962423`_, modify the back-end send notifications authentication"},{"line_number":10,"context_line":"processing logic and change the property \u0027subscription_authentication\u0027 to"},{"line_number":11,"context_line":"\u0027authentication\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b211ddc3_84b0fda0","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":20},"in_reply_to":"cd601399_067cf4ca","updated":"2022-03-08 12:25:37.000000000","message":"I\u0027ve confirmed.","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b3f9ba64c25418515ad52d8dc0a30530a7836327","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63854766_11b509b9","updated":"2022-03-03 10:41:07.000000000","message":"Thank you for the patch.\n\nPlease kindly find my comments.","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"249819fd0339f078ae4e2ebcd7d7244a6e228c43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"997b45a5_23608db2","updated":"2022-03-03 08:52:48.000000000","message":"recheck","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f2c37059eab2878187b059354cae14e3658a4543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"923d68c5_4d0c47b0","in_reply_to":"63854766_11b509b9","updated":"2022-03-04 05:09:43.000000000","message":"All comments have been fixed.","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f2c37059eab2878187b059354cae14e3658a4543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"19582f88_eb62f248","updated":"2022-03-04 05:09:43.000000000","message":"All comments are fixed. Please review again.","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"374a44cf075e7690c6e18517d6394ea2839d405e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3a01dc51_298862c7","updated":"2022-03-04 13:06:41.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b1b7db838d8b3258f806fc4135853e524e409e13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a36e6bd9_f09e61c4","in_reply_to":"3a01dc51_298862c7","updated":"2022-03-07 01:06:52.000000000","message":"All comments has been fixed.","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"02a9d031ea72f4bede33244c430ecf79877e7fa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e3d633b2_2cd0b220","updated":"2022-03-07 08:39:33.000000000","message":"Added a comment, please confirm again.","commit_id":"f01d2ae66c0dfc2e2d0ddfd74265e205a4578c4e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b1b7db838d8b3258f806fc4135853e524e409e13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5799aef8_8481160c","updated":"2022-03-07 01:06:52.000000000","message":"All comments has been fixed, please review again.","commit_id":"f01d2ae66c0dfc2e2d0ddfd74265e205a4578c4e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"80f10fb04b644759b3a0f587cea133fcf669ae77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"74aff788_5b564049","updated":"2022-03-07 01:28:16.000000000","message":"Thank you for re-work.","commit_id":"f01d2ae66c0dfc2e2d0ddfd74265e205a4578c4e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"dca8877a4c1ca9732aed7d31e662eb78da8a7662","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1537bd62_0a8e33c4","updated":"2022-03-08 03:24:05.000000000","message":"Thank you for re-work.\n\nAlmost LGTM.\nPlease find my reply.","commit_id":"233dffd850253a9b82658b6face74069fd403281"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"14e94607dac68872a06c0561354f6f74aa0a0a3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ffbeed39_3b677510","in_reply_to":"1537bd62_0a8e33c4","updated":"2022-03-08 07:11:34.000000000","message":"Has added the comment.","commit_id":"233dffd850253a9b82658b6face74069fd403281"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"14e94607dac68872a06c0561354f6f74aa0a0a3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d4039abf_394080c3","updated":"2022-03-08 07:11:34.000000000","message":"Has added a comment, please review again.","commit_id":"8412af6db39d8423031f8160ef10560b48cccc28"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"a80a1a71f93c719f6578d96ff4bec05b598267af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9e0fb6f4_5145fd17","updated":"2022-03-08 07:37:03.000000000","message":"LGTM","commit_id":"8412af6db39d8423031f8160ef10560b48cccc28"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0a33a245640cb7aeac5f0c860db81d12cb2c8e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3b742a57_561a0adc","updated":"2022-03-08 12:25:37.000000000","message":"Thanks for your rework, LGTM.","commit_id":"8412af6db39d8423031f8160ef10560b48cccc28"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b3f9ba64c25418515ad52d8dc0a30530a7836327","unresolved":true,"context_lines":[{"line_number":2252,"context_line":"            if (\u0027authentication\u0027 not in vnf_lcm_subscription or"},{"line_number":2253,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2254,"context_line":"                return"},{"line_number":2255,"context_line":"        else:"},{"line_number":2256,"context_line":"            if (not hasattr(vnf_lcm_subscription, \u0027authentication\u0027) or"},{"line_number":2257,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2258,"context_line":"                return"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"        subscription_authentication \u003d decode("},{"line_number":2261,"context_line":"            vnf_lcm_subscription.authentication)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0bb38f68_4aaccd3d","line":2258,"range":{"start_line":2255,"start_character":0,"end_line":2258,"end_character":22},"updated":"2022-03-03 10:41:07.000000000","message":"What is the reason of allowing non-LccnSubscriptionRequest object?","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f2c37059eab2878187b059354cae14e3658a4543","unresolved":true,"context_lines":[{"line_number":2252,"context_line":"            if (\u0027authentication\u0027 not in vnf_lcm_subscription or"},{"line_number":2253,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2254,"context_line":"                return"},{"line_number":2255,"context_line":"        else:"},{"line_number":2256,"context_line":"            if (not hasattr(vnf_lcm_subscription, \u0027authentication\u0027) or"},{"line_number":2257,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2258,"context_line":"                return"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"        subscription_authentication \u003d decode("},{"line_number":2261,"context_line":"            vnf_lcm_subscription.authentication)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c3a8c82e_0e913f7c","line":2258,"range":{"start_line":2255,"start_character":0,"end_line":2258,"end_character":22},"in_reply_to":"0bb38f68_4aaccd3d","updated":"2022-03-04 05:09:43.000000000","message":"The method \"__set_auth_subscription\" is called in two places.\nIf the method \"test_notification\" calls it, the input parameter is LccnSubscriptionRequest, which is entered from a user command.\nIf the method \"send_notification\" calls it, the input parameter is LccnSubscription, which is taken from the database.","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"02a9d031ea72f4bede33244c430ecf79877e7fa1","unresolved":true,"context_lines":[{"line_number":2252,"context_line":"            if (\u0027authentication\u0027 not in vnf_lcm_subscription or"},{"line_number":2253,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2254,"context_line":"                return"},{"line_number":2255,"context_line":"        else:"},{"line_number":2256,"context_line":"            if (not hasattr(vnf_lcm_subscription, \u0027authentication\u0027) or"},{"line_number":2257,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2258,"context_line":"                return"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"        subscription_authentication \u003d decode("},{"line_number":2261,"context_line":"            vnf_lcm_subscription.authentication)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a9a78566_6368573b","line":2258,"range":{"start_line":2255,"start_character":0,"end_line":2258,"end_character":22},"in_reply_to":"3b9bc25f_ef8fd2ea","updated":"2022-03-07 08:39:33.000000000","message":"The method \u0027test_notification\u0027 is not a test code,it is called when an user regists a subscription for a notification.\nWhen subscribing to notifications, this function is used to ensure that notifications can be sent normally.The registing subscription can only succeed if the test_notification method returns the correct results.\nDo I need to add the TODO comment?","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"dca8877a4c1ca9732aed7d31e662eb78da8a7662","unresolved":true,"context_lines":[{"line_number":2252,"context_line":"            if (\u0027authentication\u0027 not in vnf_lcm_subscription or"},{"line_number":2253,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2254,"context_line":"                return"},{"line_number":2255,"context_line":"        else:"},{"line_number":2256,"context_line":"            if (not hasattr(vnf_lcm_subscription, \u0027authentication\u0027) or"},{"line_number":2257,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2258,"context_line":"                return"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"        subscription_authentication \u003d decode("},{"line_number":2261,"context_line":"            vnf_lcm_subscription.authentication)"}],"source_content_type":"text/x-python","patch_set":4,"id":"aef85d98_66ab025e","line":2258,"range":{"start_line":2255,"start_character":0,"end_line":2258,"end_character":22},"in_reply_to":"a9a78566_6368573b","updated":"2022-03-08 03:24:05.000000000","message":"Sorry, I misunderstood.\n\nAnother problem is that else block will accept any ``vnf_lcm_subscription`` objects which have the ``authentication`` attribute.\nIdeally, only LccnSubscription or LccnSubscriptionRequest should be accepted*1, but I suppose ``vnf_lcm_subscription`` passed from \"send_notification\" is not a LccnSubscription class. Am I correct? c.f., [1]. If so, please add TODO comment like: \"Only LccnSubscription or LccnSubscriptionRequest should be accepted.\"\n\n\\*1\n```\n        if not isinstance(vnf_lcm_subscription, LccnSubscriptionRequest) and not isinstance(vnf_lcm_subscription, LccnSubscription):\n            # raise Exception\n\n        if (\u0027authentication\u0027 not in vnf_lcm_subscription or\n                not vnf_lcm_subscription.authentication):\n            return\n```\n\n[1] https://github.com/openstack/tacker/blob/master/tacker/objects/vnf_lcm_subscriptions.py#L104-L158","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"14e94607dac68872a06c0561354f6f74aa0a0a3c","unresolved":true,"context_lines":[{"line_number":2252,"context_line":"            if (\u0027authentication\u0027 not in vnf_lcm_subscription or"},{"line_number":2253,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2254,"context_line":"                return"},{"line_number":2255,"context_line":"        else:"},{"line_number":2256,"context_line":"            if (not hasattr(vnf_lcm_subscription, \u0027authentication\u0027) or"},{"line_number":2257,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2258,"context_line":"                return"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"        subscription_authentication \u003d decode("},{"line_number":2261,"context_line":"            vnf_lcm_subscription.authentication)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da77385b_a94641a2","line":2258,"range":{"start_line":2255,"start_character":0,"end_line":2258,"end_character":22},"in_reply_to":"aef85d98_66ab025e","updated":"2022-03-08 07:11:34.000000000","message":"Sorry, the previous comment was incorrect.Through actual environmental testing, it was found that the type of vnf_lcm_subscription was sqlalchemy.engine.row.LegacyRow, not LcnSubscription.\n\nConsidering that the type of the mock object passed in from the existing unit test code is DummyLcmSubscription, the processing logic is not added. Only added the TODO comment.\n\n# TODO(YiFeng) The type of vnf_lcm_subscription should be\n#  LegacyRow or LccnSubscriptionRequest,\n#  else should raise an exception","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"80f10fb04b644759b3a0f587cea133fcf669ae77","unresolved":true,"context_lines":[{"line_number":2252,"context_line":"            if (\u0027authentication\u0027 not in vnf_lcm_subscription or"},{"line_number":2253,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2254,"context_line":"                return"},{"line_number":2255,"context_line":"        else:"},{"line_number":2256,"context_line":"            if (not hasattr(vnf_lcm_subscription, \u0027authentication\u0027) or"},{"line_number":2257,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2258,"context_line":"                return"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"        subscription_authentication \u003d decode("},{"line_number":2261,"context_line":"            vnf_lcm_subscription.authentication)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3b9bc25f_ef8fd2ea","line":2258,"range":{"start_line":2255,"start_character":0,"end_line":2258,"end_character":22},"in_reply_to":"c3a8c82e_0e913f7c","updated":"2022-03-07 01:28:16.000000000","message":"I understand. Adding logic that depends on test codes is not a good thing, so we should fix it later. Please add a TODO comment.\n```\nTODO: Fix test cases depending on this else block\n```","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"a80a1a71f93c719f6578d96ff4bec05b598267af","unresolved":false,"context_lines":[{"line_number":2252,"context_line":"            if (\u0027authentication\u0027 not in vnf_lcm_subscription or"},{"line_number":2253,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2254,"context_line":"                return"},{"line_number":2255,"context_line":"        else:"},{"line_number":2256,"context_line":"            if (not hasattr(vnf_lcm_subscription, \u0027authentication\u0027) or"},{"line_number":2257,"context_line":"                    not vnf_lcm_subscription.authentication):"},{"line_number":2258,"context_line":"                return"},{"line_number":2259,"context_line":""},{"line_number":2260,"context_line":"        subscription_authentication \u003d decode("},{"line_number":2261,"context_line":"            vnf_lcm_subscription.authentication)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e021f056_988d83b9","line":2258,"range":{"start_line":2255,"start_character":0,"end_line":2258,"end_character":22},"in_reply_to":"da77385b_a94641a2","updated":"2022-03-08 07:37:03.000000000","message":"Good! thanks.\n\nFrankly, using LegacyRow directly is not a good habit, but we can fix it in the future.","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b3f9ba64c25418515ad52d8dc0a30530a7836327","unresolved":true,"context_lines":[{"line_number":2266,"context_line":"        if not authentication:"},{"line_number":2267,"context_line":"            return"},{"line_number":2268,"context_line":""},{"line_number":2269,"context_line":"        auth_params \u003d {}"},{"line_number":2270,"context_line":"        auth_type \u003d None"},{"line_number":2271,"context_line":"        if \u0027params_basic\u0027 in authentication:"},{"line_number":2272,"context_line":"            auth_params \u003d authentication.get(\u0027params_basic\u0027)"},{"line_number":2273,"context_line":"            auth_type \u003d \u0027BASIC\u0027"},{"line_number":2274,"context_line":"        elif \u0027params_oauth2_client_credentials\u0027 in authentication:"},{"line_number":2275,"context_line":"            auth_params \u003d authentication.get("},{"line_number":2276,"context_line":"                \u0027params_oauth2_client_credentials\u0027)"},{"line_number":2277,"context_line":"            auth_type \u003d \u0027OAUTH2_CLIENT_CREDENTIALS\u0027"},{"line_number":2278,"context_line":""},{"line_number":2279,"context_line":"        auth.auth_manager.set_auth_client("},{"line_number":2280,"context_line":"            id\u003ddecode(vnf_lcm_subscription.id),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9baef66a_c63651a3","line":2277,"range":{"start_line":2269,"start_character":0,"end_line":2277,"end_character":51},"updated":"2022-03-03 10:41:07.000000000","message":"Could you please fix here quickly?\nAccording to SOL013 [1] it should be\n```\n        if \u0027BASIC\u0027 in authentication[\u0027auth_type\u0027]:\n            auth_type \u003d \u0027BASIC\u0027\n            auth_params \u003d authentication[\u0027param_basic\u0027]\n        elif \u0027OAUTH2_CLIENT_CREDENTIALS\u0027 in authentication[\u0027auth_type\u0027]:\n            auth_type \u003d \u0027OAUTH2_CLIENT_CREDENTIALS\u0027\n            auth_params \u003d authentication[\u0027params_oauth2_client_credentials\u0027]\n        else:\n            error \u003d \u0027Unknown auth_type %s\u0027 % authentication[\u0027auth_type\u0027]\n            raise exceptions.TackerException(error)  # please replace TackerException with an appropriate exception  \n```\n\nIf the existing codes raise errors, please leave these lines and add a ``TODO`` comment.\n\n[1] https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/013/03.03.01_60/gs_NFV-SOL013v030301p.pdf#page\u003d32","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f2c37059eab2878187b059354cae14e3658a4543","unresolved":true,"context_lines":[{"line_number":2266,"context_line":"        if not authentication:"},{"line_number":2267,"context_line":"            return"},{"line_number":2268,"context_line":""},{"line_number":2269,"context_line":"        auth_params \u003d {}"},{"line_number":2270,"context_line":"        auth_type \u003d None"},{"line_number":2271,"context_line":"        if \u0027params_basic\u0027 in authentication:"},{"line_number":2272,"context_line":"            auth_params \u003d authentication.get(\u0027params_basic\u0027)"},{"line_number":2273,"context_line":"            auth_type \u003d \u0027BASIC\u0027"},{"line_number":2274,"context_line":"        elif \u0027params_oauth2_client_credentials\u0027 in authentication:"},{"line_number":2275,"context_line":"            auth_params \u003d authentication.get("},{"line_number":2276,"context_line":"                \u0027params_oauth2_client_credentials\u0027)"},{"line_number":2277,"context_line":"            auth_type \u003d \u0027OAUTH2_CLIENT_CREDENTIALS\u0027"},{"line_number":2278,"context_line":""},{"line_number":2279,"context_line":"        auth.auth_manager.set_auth_client("},{"line_number":2280,"context_line":"            id\u003ddecode(vnf_lcm_subscription.id),"}],"source_content_type":"text/x-python","patch_set":4,"id":"e2c09306_edb1093e","line":2277,"range":{"start_line":2269,"start_character":0,"end_line":2277,"end_character":51},"in_reply_to":"9baef66a_c63651a3","updated":"2022-03-04 05:09:43.000000000","message":"The code block is the existing logic and has been modified with reference to the above comments.","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"80f10fb04b644759b3a0f587cea133fcf669ae77","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"        if not authentication:"},{"line_number":2267,"context_line":"            return"},{"line_number":2268,"context_line":""},{"line_number":2269,"context_line":"        auth_params \u003d {}"},{"line_number":2270,"context_line":"        auth_type \u003d None"},{"line_number":2271,"context_line":"        if \u0027params_basic\u0027 in authentication:"},{"line_number":2272,"context_line":"            auth_params \u003d authentication.get(\u0027params_basic\u0027)"},{"line_number":2273,"context_line":"            auth_type \u003d \u0027BASIC\u0027"},{"line_number":2274,"context_line":"        elif \u0027params_oauth2_client_credentials\u0027 in authentication:"},{"line_number":2275,"context_line":"            auth_params \u003d authentication.get("},{"line_number":2276,"context_line":"                \u0027params_oauth2_client_credentials\u0027)"},{"line_number":2277,"context_line":"            auth_type \u003d \u0027OAUTH2_CLIENT_CREDENTIALS\u0027"},{"line_number":2278,"context_line":""},{"line_number":2279,"context_line":"        auth.auth_manager.set_auth_client("},{"line_number":2280,"context_line":"            id\u003ddecode(vnf_lcm_subscription.id),"}],"source_content_type":"text/x-python","patch_set":4,"id":"e870b516_fa4e324c","line":2277,"range":{"start_line":2269,"start_character":0,"end_line":2277,"end_character":51},"in_reply_to":"e2c09306_edb1093e","updated":"2022-03-07 01:28:16.000000000","message":"Ack","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"}],"tacker/objects/vnf_lcm_subscriptions.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b3f9ba64c25418515ad52d8dc0a30530a7836327","unresolved":true,"context_lines":[{"line_number":482,"context_line":"    fields \u003d {"},{"line_number":483,"context_line":"        \u0027id\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":484,"context_line":"        \u0027callback_uri\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":485,"context_line":"        \u0027authentication\u0027:"},{"line_number":486,"context_line":"            fields.StringField(nullable\u003dTrue),"},{"line_number":487,"context_line":"        \u0027filter\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":488,"context_line":"        \u0027tenant_id\u0027: fields.StringField(nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"903abc01_9713f5f0","line":485,"updated":"2022-03-03 10:41:07.000000000","message":"Please add a comment ``TODO: define SubscriptionAuthentication object`` here.\nIt\u0027s not urgent and the existing code basically assumes that this field is not an object, so we can leave it, but we should modify it in the future.","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"80f10fb04b644759b3a0f587cea133fcf669ae77","unresolved":false,"context_lines":[{"line_number":482,"context_line":"    fields \u003d {"},{"line_number":483,"context_line":"        \u0027id\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":484,"context_line":"        \u0027callback_uri\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":485,"context_line":"        \u0027authentication\u0027:"},{"line_number":486,"context_line":"            fields.StringField(nullable\u003dTrue),"},{"line_number":487,"context_line":"        \u0027filter\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":488,"context_line":"        \u0027tenant_id\u0027: fields.StringField(nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c1a0999f_b43490e5","line":485,"in_reply_to":"0ed8ccf0_2276ce12","updated":"2022-03-07 01:28:16.000000000","message":"Ack","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f2c37059eab2878187b059354cae14e3658a4543","unresolved":true,"context_lines":[{"line_number":482,"context_line":"    fields \u003d {"},{"line_number":483,"context_line":"        \u0027id\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":484,"context_line":"        \u0027callback_uri\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":485,"context_line":"        \u0027authentication\u0027:"},{"line_number":486,"context_line":"            fields.StringField(nullable\u003dTrue),"},{"line_number":487,"context_line":"        \u0027filter\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":488,"context_line":"        \u0027tenant_id\u0027: fields.StringField(nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ed8ccf0_2276ce12","line":485,"in_reply_to":"903abc01_9713f5f0","updated":"2022-03-04 05:09:43.000000000","message":"Has fixed.","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"374a44cf075e7690c6e18517d6394ea2839d405e","unresolved":true,"context_lines":[{"line_number":3043,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":3044,"context_line":"        callback_uri \u003d \u0027https://localhost/callback\u0027"},{"line_number":3045,"context_line":""},{"line_number":3046,"context_line":"        vnf_lcm_subscription \u003d objects. \\"},{"line_number":3047,"context_line":"            LccnSubscriptionRequest(context\u003dself.context)"},{"line_number":3048,"context_line":"        vnf_lcm_subscription.id \u003d uuidsentinel.lcm_subscription_id"},{"line_number":3049,"context_line":"        vnf_lcm_subscription.callback_uri \u003d callback_uri"}],"source_content_type":"text/x-python","patch_set":5,"id":"3dbb41dd_5ce0687e","line":3046,"range":{"start_line":3046,"start_character":40,"end_line":3046,"end_character":41},"updated":"2022-03-04 13:06:41.000000000","message":"How about to refactor it so that it doesn\u0027t end with a backslash?","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b1b7db838d8b3258f806fc4135853e524e409e13","unresolved":true,"context_lines":[{"line_number":3043,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":3044,"context_line":"        callback_uri \u003d \u0027https://localhost/callback\u0027"},{"line_number":3045,"context_line":""},{"line_number":3046,"context_line":"        vnf_lcm_subscription \u003d objects. \\"},{"line_number":3047,"context_line":"            LccnSubscriptionRequest(context\u003dself.context)"},{"line_number":3048,"context_line":"        vnf_lcm_subscription.id \u003d uuidsentinel.lcm_subscription_id"},{"line_number":3049,"context_line":"        vnf_lcm_subscription.callback_uri \u003d callback_uri"}],"source_content_type":"text/x-python","patch_set":5,"id":"6afdd391_7b642d59","line":3046,"range":{"start_line":3046,"start_character":40,"end_line":3046,"end_character":41},"in_reply_to":"3dbb41dd_5ce0687e","updated":"2022-03-07 01:06:52.000000000","message":"Has fixed.","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0a33a245640cb7aeac5f0c860db81d12cb2c8e6","unresolved":false,"context_lines":[{"line_number":3043,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":3044,"context_line":"        callback_uri \u003d \u0027https://localhost/callback\u0027"},{"line_number":3045,"context_line":""},{"line_number":3046,"context_line":"        vnf_lcm_subscription \u003d objects. \\"},{"line_number":3047,"context_line":"            LccnSubscriptionRequest(context\u003dself.context)"},{"line_number":3048,"context_line":"        vnf_lcm_subscription.id \u003d uuidsentinel.lcm_subscription_id"},{"line_number":3049,"context_line":"        vnf_lcm_subscription.callback_uri \u003d callback_uri"}],"source_content_type":"text/x-python","patch_set":5,"id":"4973022a_083ad369","line":3046,"range":{"start_line":3046,"start_character":40,"end_line":3046,"end_character":41},"in_reply_to":"6afdd391_7b642d59","updated":"2022-03-08 12:25:37.000000000","message":"I\u0027ve confirmed.","commit_id":"07b73625c5383f124c1161194502ecd8aca92746"}],"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b3f9ba64c25418515ad52d8dc0a30530a7836327","unresolved":true,"context_lines":[{"line_number":4240,"context_line":"        body \u003d {"},{"line_number":4241,"context_line":"            \u0027callbackUri\u0027: \u0027http://sample_callback_uri\u0027,"},{"line_number":4242,"context_line":"            \"authentication\": {"},{"line_number":4243,"context_line":"                \"authType\": \"OAUTH2_CLIENT_CREDENTIALS\","},{"line_number":4244,"context_line":"                \"paramsOauth2ClientCredentials\": {"},{"line_number":4245,"context_line":"                    \"clientId\": auth_user_name,"},{"line_number":4246,"context_line":"                    \"clientPassword\": auth_password,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7b560171_9c514423","line":4243,"updated":"2022-03-03 10:41:07.000000000","message":"According to the cardinality of this field in SOL013 it should be list [1].\n\n[1] https://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/013/03.03.01_60/gs_NFV-SOL013v030301p.pdf#page\u003d32","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"80f10fb04b644759b3a0f587cea133fcf669ae77","unresolved":false,"context_lines":[{"line_number":4240,"context_line":"        body \u003d {"},{"line_number":4241,"context_line":"            \u0027callbackUri\u0027: \u0027http://sample_callback_uri\u0027,"},{"line_number":4242,"context_line":"            \"authentication\": {"},{"line_number":4243,"context_line":"                \"authType\": \"OAUTH2_CLIENT_CREDENTIALS\","},{"line_number":4244,"context_line":"                \"paramsOauth2ClientCredentials\": {"},{"line_number":4245,"context_line":"                    \"clientId\": auth_user_name,"},{"line_number":4246,"context_line":"                    \"clientPassword\": auth_password,"}],"source_content_type":"text/x-python","patch_set":4,"id":"eb8d1562_ff308d25","line":4243,"in_reply_to":"39ebedab_e3a10abf","updated":"2022-03-07 01:28:16.000000000","message":"Ack","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f2c37059eab2878187b059354cae14e3658a4543","unresolved":true,"context_lines":[{"line_number":4240,"context_line":"        body \u003d {"},{"line_number":4241,"context_line":"            \u0027callbackUri\u0027: \u0027http://sample_callback_uri\u0027,"},{"line_number":4242,"context_line":"            \"authentication\": {"},{"line_number":4243,"context_line":"                \"authType\": \"OAUTH2_CLIENT_CREDENTIALS\","},{"line_number":4244,"context_line":"                \"paramsOauth2ClientCredentials\": {"},{"line_number":4245,"context_line":"                    \"clientId\": auth_user_name,"},{"line_number":4246,"context_line":"                    \"clientPassword\": auth_password,"}],"source_content_type":"text/x-python","patch_set":4,"id":"39ebedab_e3a10abf","line":4243,"in_reply_to":"7b560171_9c514423","updated":"2022-03-04 05:09:43.000000000","message":"Has been modified to list.","commit_id":"c7e6721eda634fe2b5d2f3201e27e8f571cc1228"}]}