)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8833377c3644514e8e9cf71fedfd7aceb0d58060","unresolved":true,"context_lines":[{"line_number":12,"context_line":"As a result, no more operation of the vnf instance can\u0027t be processed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes this situation. When the conductor (re) starts up,"},{"line_number":15,"context_line":"if VnfLcmOpOccwith its operaionState is STARTING, PROCCESING or"},{"line_number":16,"context_line":"ROLLING_BACK exists, it is changed to ROLLED_BACK or FAILED_TEMP."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint support-nfv-solv3-error-handling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"44bb4801_657d6fef","line":15,"range":{"start_line":15,"start_character":3,"end_line":15,"end_character":18},"updated":"2022-03-01 00:51:45.000000000","message":"Typo: \"VnfLcmOpOcc with\"","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"633d6b9ea80f15618efe0978314e3ec9db4c1593","unresolved":false,"context_lines":[{"line_number":12,"context_line":"As a result, no more operation of the vnf instance can\u0027t be processed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes this situation. When the conductor (re) starts up,"},{"line_number":15,"context_line":"if VnfLcmOpOccwith its operaionState is STARTING, PROCCESING or"},{"line_number":16,"context_line":"ROLLING_BACK exists, it is changed to ROLLED_BACK or FAILED_TEMP."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint support-nfv-solv3-error-handling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"61e8415b_ef5c9094","line":15,"range":{"start_line":15,"start_character":3,"end_line":15,"end_character":18},"in_reply_to":"0df9bdbf_0a70e9b2","updated":"2022-03-01 10:22:59.000000000","message":"Done","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"0672028dc87e614e022527b64f7b519707c08802","unresolved":true,"context_lines":[{"line_number":12,"context_line":"As a result, no more operation of the vnf instance can\u0027t be processed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes this situation. When the conductor (re) starts up,"},{"line_number":15,"context_line":"if VnfLcmOpOccwith its operaionState is STARTING, PROCCESING or"},{"line_number":16,"context_line":"ROLLING_BACK exists, it is changed to ROLLED_BACK or FAILED_TEMP."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint support-nfv-solv3-error-handling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0df9bdbf_0a70e9b2","line":15,"range":{"start_line":15,"start_character":3,"end_line":15,"end_character":18},"in_reply_to":"44bb4801_657d6fef","updated":"2022-03-01 02:25:09.000000000","message":"I will fix.","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"cee1ce727547f0dcb99bf5eb187c895b79ed6d43","unresolved":true,"context_lines":[{"line_number":12,"context_line":"As a result, no more operation of the vnf instance can\u0027t be processed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes this situation. When the conductor (re) starts up,"},{"line_number":15,"context_line":"if VnfLcmOpOcc with its operaionState is STARTING, PROCCESING or"},{"line_number":16,"context_line":"ROLLING_BACK exists, it is changed to ROLLED_BACK or FAILED_TEMP."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint support-nfv-solv3-error-handling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"6e7af0e7_b8eb1939","line":15,"range":{"start_line":15,"start_character":24,"end_line":15,"end_character":37},"updated":"2022-03-04 01:32:02.000000000","message":"typo: operaionState -\u003e operationState","commit_id":"fed7e7356aa05da9941249d1d867076488831afa"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"c7cc618bf3a57b8ab0c1dbe235f23469164b3ccb","unresolved":true,"context_lines":[{"line_number":12,"context_line":"As a result, no more operation of the vnf instance can\u0027t be processed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes this situation. When the conductor (re) starts up,"},{"line_number":15,"context_line":"if VnfLcmOpOcc with its operaionState is STARTING, PROCCESING or"},{"line_number":16,"context_line":"ROLLING_BACK exists, it is changed to ROLLED_BACK or FAILED_TEMP."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint support-nfv-solv3-error-handling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8e1f84ac_b8ea75ba","line":15,"range":{"start_line":15,"start_character":24,"end_line":15,"end_character":37},"in_reply_to":"6e7af0e7_b8eb1939","updated":"2022-03-04 02:01:35.000000000","message":"I see. I will fix.","commit_id":"fed7e7356aa05da9941249d1d867076488831afa"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"653f680aadf83cf0e13218f74358365772e5eee1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"As a result, no more operation of the vnf instance can\u0027t be processed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes this situation. When the conductor (re) starts up,"},{"line_number":15,"context_line":"if VnfLcmOpOcc with its operaionState is STARTING, PROCCESING or"},{"line_number":16,"context_line":"ROLLING_BACK exists, it is changed to ROLLED_BACK or FAILED_TEMP."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint support-nfv-solv3-error-handling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"09e983e8_e61d0c8f","line":15,"range":{"start_line":15,"start_character":24,"end_line":15,"end_character":37},"in_reply_to":"8e1f84ac_b8ea75ba","updated":"2022-03-04 05:16:47.000000000","message":"Done","commit_id":"fed7e7356aa05da9941249d1d867076488831afa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"0672028dc87e614e022527b64f7b519707c08802","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eed60122_fe166a6c","updated":"2022-03-01 02:25:09.000000000","message":"Thank you for the review.","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"cada0e589f9dcd67a56a727788d1b1f4dc830dc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a2d04423_27e81b5d","updated":"2022-03-01 23:53:30.000000000","message":"Thank you for the review.","commit_id":"552a8d8d4f152f483541a40b5ac2e38dbbc3e854"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dd5f4806e1d4af269c0bb8b83520ffa1833edec5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4a467f50_4e9915c3","updated":"2022-03-03 05:13:00.000000000","message":"LGTM","commit_id":"7ced8f83e337031e75e55f1249e77d4d00b25945"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"31af4cb09462add335bc6c772ebfcdb4f679ae10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"88d75e31_f6abe78e","updated":"2022-03-03 03:27:55.000000000","message":"Thank you for the comment","commit_id":"7ced8f83e337031e75e55f1249e77d4d00b25945"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"c7cc618bf3a57b8ab0c1dbe235f23469164b3ccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d14deba9_b95dabca","updated":"2022-03-04 02:01:35.000000000","message":"Thank you for the review.","commit_id":"fed7e7356aa05da9941249d1d867076488831afa"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"653f680aadf83cf0e13218f74358365772e5eee1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"12d8a974_5f80e1ee","updated":"2022-03-04 05:16:47.000000000","message":"LGTM","commit_id":"bd3096bde8bdaf6dc8130149ecdb45aee49245f0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"511eaa8146f153a1f72a3d11b5d54b8322342ba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7b1deb60_d27154bd","updated":"2022-03-04 09:53:56.000000000","message":"LGTM.","commit_id":"bd3096bde8bdaf6dc8130149ecdb45aee49245f0"}],"tacker/sol_refactored/common/exceptions.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8833377c3644514e8e9cf71fedfd7aceb0d58060","unresolved":true,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class ConductorProcessingError(SolHttpError422):"},{"line_number":246,"context_line":"    message \u003d _(\"Failure due to Conductor processing error.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"4c77be26_9592ff05","line":246,"range":{"start_line":246,"start_character":32,"end_line":246,"end_character":41},"updated":"2022-03-01 00:51:45.000000000","message":"\"conductor\" may be better.","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"0672028dc87e614e022527b64f7b519707c08802","unresolved":true,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class ConductorProcessingError(SolHttpError422):"},{"line_number":246,"context_line":"    message \u003d _(\"Failure due to Conductor processing error.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"f64b120d_47645819","line":246,"range":{"start_line":246,"start_character":32,"end_line":246,"end_character":41},"in_reply_to":"4c77be26_9592ff05","updated":"2022-03-01 02:25:09.000000000","message":"I will fix.","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"633d6b9ea80f15618efe0978314e3ec9db4c1593","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class ConductorProcessingError(SolHttpError422):"},{"line_number":246,"context_line":"    message \u003d _(\"Failure due to Conductor processing error.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"d1f1f09a_578c3bab","line":246,"range":{"start_line":246,"start_character":32,"end_line":246,"end_character":41},"in_reply_to":"f64b120d_47645819","updated":"2022-03-01 10:22:59.000000000","message":"Done","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"633d6b9ea80f15618efe0978314e3ec9db4c1593","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                \"VduScalingAspectDeltas.\")"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class ConductorProcessingError(SolHttpError422):"},{"line_number":246,"context_line":"    message \u003d _(\"Failure due to conductor processing error.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"2e1b17a2_42866e29","line":245,"range":{"start_line":245,"start_character":31,"end_line":245,"end_character":46},"updated":"2022-03-01 10:22:59.000000000","message":"I wondered if \"SolException\" would be more appropriate.\nIMO, the case where the tacker-conductor goes down matches \"500 Internal Server Error\" rather than \"422 Unprocessable Entity\" in the definition of SOL013.\nWhat do you think?","commit_id":"552a8d8d4f152f483541a40b5ac2e38dbbc3e854"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"cada0e589f9dcd67a56a727788d1b1f4dc830dc8","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                \"VduScalingAspectDeltas.\")"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class ConductorProcessingError(SolHttpError422):"},{"line_number":246,"context_line":"    message \u003d _(\"Failure due to conductor processing error.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"dbbcaac4_d7d21b7b","line":245,"range":{"start_line":245,"start_character":31,"end_line":245,"end_character":46},"in_reply_to":"2e1b17a2_42866e29","updated":"2022-03-01 23:53:30.000000000","message":"Thak you for pointing this out.\nI checked the SOL013. I think that is more appropriate, too.\nI will fix.","commit_id":"552a8d8d4f152f483541a40b5ac2e38dbbc3e854"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dd5f4806e1d4af269c0bb8b83520ffa1833edec5","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                \"VduScalingAspectDeltas.\")"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class ConductorProcessingError(SolHttpError422):"},{"line_number":246,"context_line":"    message \u003d _(\"Failure due to conductor processing error.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"8dd286a3_a5cb63d1","line":245,"range":{"start_line":245,"start_character":31,"end_line":245,"end_character":46},"in_reply_to":"43167e72_7d561fa1","updated":"2022-03-03 05:13:00.000000000","message":"Okay, I see.\nAs you say, I also think this patch should not fix it either.","commit_id":"552a8d8d4f152f483541a40b5ac2e38dbbc3e854"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"31af4cb09462add335bc6c772ebfcdb4f679ae10","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                \"VduScalingAspectDeltas.\")"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class ConductorProcessingError(SolHttpError422):"},{"line_number":246,"context_line":"    message \u003d _(\"Failure due to conductor processing error.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"43167e72_7d561fa1","line":245,"range":{"start_line":245,"start_character":31,"end_line":245,"end_character":46},"in_reply_to":"924256f3_2c92f4d5","updated":"2022-03-03 03:27:55.000000000","message":"Thank you for your comment.\nI confirmed \"SolException\" \"title\" and \"message\".\nI think that \"title\" is reverse to \"detail\", too, but when I change it, affects some exiting code. As I think it not to fix it this patch, how about?","commit_id":"552a8d8d4f152f483541a40b5ac2e38dbbc3e854"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"00892b0240bec02f7d0174d142e578a033723c10","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                \"VduScalingAspectDeltas.\")"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"class ConductorProcessingError(SolHttpError422):"},{"line_number":246,"context_line":"    message \u003d _(\"Failure due to conductor processing error.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"924256f3_2c92f4d5","line":245,"range":{"start_line":245,"start_character":31,"end_line":245,"end_character":46},"in_reply_to":"dbbcaac4_d7d21b7b","updated":"2022-03-02 06:48:07.000000000","message":"Thanks for the fix, but I have an additional comment.\nIsn\u0027t it better to set \"title\" to \"SolException\" instead of here?\nThe \"title\" and \"message\" settings are probably reversed in \"SolException\".\nPlease check it.\n```\nclass SolException(Exception):\n...snip...\n    status \u003d 500\n    title \u003d \u0027Internal Server Error\u0027\n    message \u003d None\n```","commit_id":"552a8d8d4f152f483541a40b5ac2e38dbbc3e854"}],"tacker/sol_refactored/objects/base.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8833377c3644514e8e9cf71fedfd7aceb0d58060","unresolved":true,"context_lines":[{"line_number":346,"context_line":"                context.session.add(inst)"},{"line_number":347,"context_line":"            context.session.flush()"},{"line_number":348,"context_line":"        # \u0027flush\u0027 must have succeeded because we are here."},{"line_number":349,"context_line":"        if self._db_obj is None:"},{"line_number":350,"context_line":"            self._db_obj \u003d inst"},{"line_number":351,"context_line":"        self.obj_reset_changes()"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"93fd41f1_85d6ed10","line":349,"updated":"2022-03-01 00:51:45.000000000","message":"Just a question.\nWhy do you need this fix?","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"0672028dc87e614e022527b64f7b519707c08802","unresolved":true,"context_lines":[{"line_number":346,"context_line":"                context.session.add(inst)"},{"line_number":347,"context_line":"            context.session.flush()"},{"line_number":348,"context_line":"        # \u0027flush\u0027 must have succeeded because we are here."},{"line_number":349,"context_line":"        if self._db_obj is None:"},{"line_number":350,"context_line":"            self._db_obj \u003d inst"},{"line_number":351,"context_line":"        self.obj_reset_changes()"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"af7c29c1_f6339ae7","line":349,"in_reply_to":"93fd41f1_85d6ed10","updated":"2022-03-01 02:25:09.000000000","message":"There was a problem that DB record of a object which is just created (not retrieve from DB) can not be deleted. This part fixes this. Note that this situation did not occur previously. _start_lcm_op() meets this situation now. (ex. see conductor_v2.py L.126 and L.152)","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"633d6b9ea80f15618efe0978314e3ec9db4c1593","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                context.session.add(inst)"},{"line_number":347,"context_line":"            context.session.flush()"},{"line_number":348,"context_line":"        # \u0027flush\u0027 must have succeeded because we are here."},{"line_number":349,"context_line":"        if self._db_obj is None:"},{"line_number":350,"context_line":"            self._db_obj \u003d inst"},{"line_number":351,"context_line":"        self.obj_reset_changes()"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"f401226b_1c4e52c0","line":349,"in_reply_to":"af7c29c1_f6339ae7","updated":"2022-03-01 10:22:59.000000000","message":"Thank you for the answer, I see.","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"}],"tacker/tests/unit/sol_refactored/conductor/test_conductor_v2.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8833377c3644514e8e9cf71fedfd7aceb0d58060","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        lcmocc \u003d lcmocc_utils.get_lcmocc(self.context, lcmocc.id)"},{"line_number":161,"context_line":"        expected \u003d ex.make_problem_details()"},{"line_number":162,"context_line":"        self.assertEqual(expected, lcmocc.error.to_dict())"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @mock.patch.object(nfvo_client.NfvoClient, \u0027send_lcmocc_notification\u0027)"},{"line_number":165,"context_line":"    @mock.patch.object(nfvo_client.NfvoClient, \u0027get_vnfd\u0027)"},{"line_number":166,"context_line":"    @mock.patch.object(vnflcm_driver_v2.VnfLcmDriverV2, \u0027grant\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c51b4503_49521787","line":163,"updated":"2022-03-01 00:51:45.000000000","message":"How about adding the following assertion for test consistency?\n```\n        # check grant_req and grant have not been created\n        self.assertRaises(sol_ex.GrantRequestOrGrantNotFound,\n            lcmocc_utils.get_grant_req_and_grant, self.context, lcmocc)\n```","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"fdbc3461c5b9051c672aea5615d21ea954037683","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        lcmocc \u003d lcmocc_utils.get_lcmocc(self.context, lcmocc.id)"},{"line_number":161,"context_line":"        expected \u003d ex.make_problem_details()"},{"line_number":162,"context_line":"        self.assertEqual(expected, lcmocc.error.to_dict())"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @mock.patch.object(nfvo_client.NfvoClient, \u0027send_lcmocc_notification\u0027)"},{"line_number":165,"context_line":"    @mock.patch.object(nfvo_client.NfvoClient, \u0027get_vnfd\u0027)"},{"line_number":166,"context_line":"    @mock.patch.object(vnflcm_driver_v2.VnfLcmDriverV2, \u0027grant\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"759c675a_f64c31c5","line":163,"in_reply_to":"4ce34337_019af911","updated":"2022-03-01 07:36:57.000000000","message":"Sorry, I was wrong.\nAs I don\u0027t set \"grant(grantId)\" with this case, I think that I can\u0027t check the grant_req and grant. I think that it is not necessary to fix it, how about?","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"633d6b9ea80f15618efe0978314e3ec9db4c1593","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        lcmocc \u003d lcmocc_utils.get_lcmocc(self.context, lcmocc.id)"},{"line_number":161,"context_line":"        expected \u003d ex.make_problem_details()"},{"line_number":162,"context_line":"        self.assertEqual(expected, lcmocc.error.to_dict())"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @mock.patch.object(nfvo_client.NfvoClient, \u0027send_lcmocc_notification\u0027)"},{"line_number":165,"context_line":"    @mock.patch.object(nfvo_client.NfvoClient, \u0027get_vnfd\u0027)"},{"line_number":166,"context_line":"    @mock.patch.object(vnflcm_driver_v2.VnfLcmDriverV2, \u0027grant\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2a47cccf_2b2d986c","line":163,"in_reply_to":"759c675a_f64c31c5","updated":"2022-03-01 10:22:59.000000000","message":"Thank you for the answer, I see.\nYou don\u0027t have to fix anything.","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"0672028dc87e614e022527b64f7b519707c08802","unresolved":true,"context_lines":[{"line_number":160,"context_line":"        lcmocc \u003d lcmocc_utils.get_lcmocc(self.context, lcmocc.id)"},{"line_number":161,"context_line":"        expected \u003d ex.make_problem_details()"},{"line_number":162,"context_line":"        self.assertEqual(expected, lcmocc.error.to_dict())"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @mock.patch.object(nfvo_client.NfvoClient, \u0027send_lcmocc_notification\u0027)"},{"line_number":165,"context_line":"    @mock.patch.object(nfvo_client.NfvoClient, \u0027get_vnfd\u0027)"},{"line_number":166,"context_line":"    @mock.patch.object(vnflcm_driver_v2.VnfLcmDriverV2, \u0027grant\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ce34337_019af911","line":163,"in_reply_to":"c51b4503_49521787","updated":"2022-03-01 02:25:09.000000000","message":"I see. As I did not delete grant_req and grant here, I did not check it, but I think that I should add it.\nI will fix.","commit_id":"7bfea9a28b823492295bbe65b5b9a68a6bfa8c6c"}]}