)]}'
{".zuul.yaml":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"006da82c1201ef3e5dacc2506f78b7d8183b6797","unresolved":true,"context_lines":[{"line_number":588,"context_line":"        - tacker-functional-devstack-multinode-libs-master"},{"line_number":589,"context_line":"        - tacker-functional-devstack-multinode-sol-v2"},{"line_number":590,"context_line":"        - tacker-functional-devstack-multinode-sol-kubernetes-v2"},{"line_number":591,"context_line":"        - tacker-functional-devstack-multinode-sol-separated-nfvo-v2"},{"line_number":592,"context_line":"        - tacker-functional-devstack-multinode-sol-multi-tenant"},{"line_number":593,"context_line":"        - tacker-functional-devstack-multinode-sol-kubernetes-multi-tenant"},{"line_number":594,"context_line":"        - tacker-compliance-devstack-multinode-sol"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ad2224e9_4c407632","line":591,"updated":"2022-04-07 02:40:35.000000000","message":"Nit: It’s better to define it one line above according to the order of V1 jobs.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":false,"context_lines":[{"line_number":588,"context_line":"        - tacker-functional-devstack-multinode-libs-master"},{"line_number":589,"context_line":"        - tacker-functional-devstack-multinode-sol-v2"},{"line_number":590,"context_line":"        - tacker-functional-devstack-multinode-sol-kubernetes-v2"},{"line_number":591,"context_line":"        - tacker-functional-devstack-multinode-sol-separated-nfvo-v2"},{"line_number":592,"context_line":"        - tacker-functional-devstack-multinode-sol-multi-tenant"},{"line_number":593,"context_line":"        - tacker-functional-devstack-multinode-sol-kubernetes-multi-tenant"},{"line_number":594,"context_line":"        - tacker-compliance-devstack-multinode-sol"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"de9e601c_77baed80","line":591,"in_reply_to":"62b7a476_863aaa93","updated":"2022-04-21 04:08:01.000000000","message":"Done","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9a0be36fcdf6053d68d9920113a2b8409ea2a4fd","unresolved":true,"context_lines":[{"line_number":588,"context_line":"        - tacker-functional-devstack-multinode-libs-master"},{"line_number":589,"context_line":"        - tacker-functional-devstack-multinode-sol-v2"},{"line_number":590,"context_line":"        - tacker-functional-devstack-multinode-sol-kubernetes-v2"},{"line_number":591,"context_line":"        - tacker-functional-devstack-multinode-sol-separated-nfvo-v2"},{"line_number":592,"context_line":"        - tacker-functional-devstack-multinode-sol-multi-tenant"},{"line_number":593,"context_line":"        - tacker-functional-devstack-multinode-sol-kubernetes-multi-tenant"},{"line_number":594,"context_line":"        - tacker-compliance-devstack-multinode-sol"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"62b7a476_863aaa93","line":591,"in_reply_to":"ad2224e9_4c407632","updated":"2022-04-18 05:45:56.000000000","message":"I fixed it in PS7.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"}],"/COMMIT_MSG":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"006da82c1201ef3e5dacc2506f78b7d8183b6797","unresolved":true,"context_lines":[{"line_number":15,"context_line":"2. This patch will merge the fake_grant_server.py of v1 as a common"},{"line_number":16,"context_line":"   fake_grant_server for users to test manually."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"At the same time, fix v2 code bug when using external nfvo."},{"line_number":19,"context_line":"  1. The name of `VimComputeResourceFlavour` in grant.py is"},{"line_number":20,"context_line":"  referenced incorrectly."},{"line_number":21,"context_line":"  2. The name of `grant.vimConnectioninfo` in vnflcm_driver_v2.py"},{"line_number":22,"context_line":"  is referenced incorrectly."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1961359"},{"line_number":25,"context_line":"Change-Id: Ic67295d425b19fc6de6f5c49dc02478068c17224"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"4142533c_d8f93966","line":24,"range":{"start_line":18,"start_character":0,"end_line":24,"end_character":20},"updated":"2022-04-07 02:40:35.000000000","message":"These bugs are fixed in the below patch.\nhttps://review.opendev.org/c/openstack/tacker/+/835784\nSo, you don\u0027t have to fix these in this patch.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":false,"context_lines":[{"line_number":15,"context_line":"2. This patch will merge the fake_grant_server.py of v1 as a common"},{"line_number":16,"context_line":"   fake_grant_server for users to test manually."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"At the same time, fix v2 code bug when using external nfvo."},{"line_number":19,"context_line":"  1. The name of `VimComputeResourceFlavour` in grant.py is"},{"line_number":20,"context_line":"  referenced incorrectly."},{"line_number":21,"context_line":"  2. The name of `grant.vimConnectioninfo` in vnflcm_driver_v2.py"},{"line_number":22,"context_line":"  is referenced incorrectly."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1961359"},{"line_number":25,"context_line":"Change-Id: Ic67295d425b19fc6de6f5c49dc02478068c17224"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"25598b70_65c886fe","line":24,"range":{"start_line":18,"start_character":0,"end_line":24,"end_character":20},"in_reply_to":"1ed76c1a_fc68c8c7","updated":"2022-04-21 04:08:01.000000000","message":"Done","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9a0be36fcdf6053d68d9920113a2b8409ea2a4fd","unresolved":true,"context_lines":[{"line_number":15,"context_line":"2. This patch will merge the fake_grant_server.py of v1 as a common"},{"line_number":16,"context_line":"   fake_grant_server for users to test manually."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"At the same time, fix v2 code bug when using external nfvo."},{"line_number":19,"context_line":"  1. The name of `VimComputeResourceFlavour` in grant.py is"},{"line_number":20,"context_line":"  referenced incorrectly."},{"line_number":21,"context_line":"  2. The name of `grant.vimConnectioninfo` in vnflcm_driver_v2.py"},{"line_number":22,"context_line":"  is referenced incorrectly."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1961359"},{"line_number":25,"context_line":"Change-Id: Ic67295d425b19fc6de6f5c49dc02478068c17224"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ed76c1a_fc68c8c7","line":24,"range":{"start_line":18,"start_character":0,"end_line":24,"end_character":20},"in_reply_to":"4142533c_d8f93966","updated":"2022-04-18 05:45:56.000000000","message":"I deleted this change and added a dependency for my patch.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yi Feng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-27 13:55:01 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Seperated NFVO FT for V2 API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only test cases using local NFVO are included in the FT of the"},{"line_number":10,"context_line":"current v2 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"94b430d8_8722e30c","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":13},"updated":"2022-05-16 08:23:19.000000000","message":"typo: Separated","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yi Feng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-27 13:55:01 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Seperated NFVO FT for V2 API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only test cases using local NFVO are included in the FT of the"},{"line_number":10,"context_line":"current v2 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"ba442a98_3f42428a","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":13},"in_reply_to":"94b430d8_8722e30c","updated":"2022-05-17 01:55:40.000000000","message":"I fixed it in PS13.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yi Feng \u003cfengyi@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-27 13:55:01 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Seperated NFVO FT for V2 API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only test cases using local NFVO are included in the FT of the"},{"line_number":10,"context_line":"current v2 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5d7d4ec9_1abff8ef","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":13},"in_reply_to":"ba442a98_3f42428a","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only test cases using local NFVO are included in the FT of the"},{"line_number":10,"context_line":"current v2 API."},{"line_number":11,"context_line":"This patch provides a new FT job for the v2 API to test seperated"},{"line_number":12,"context_line":"NFVO scenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. The split NFVO in this patch is to be simulated using code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"8a33266f_dce51117","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":65},"updated":"2022-05-16 08:23:19.000000000","message":"typo: separated","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only test cases using local NFVO are included in the FT of the"},{"line_number":10,"context_line":"current v2 API."},{"line_number":11,"context_line":"This patch provides a new FT job for the v2 API to test seperated"},{"line_number":12,"context_line":"NFVO scenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. The split NFVO in this patch is to be simulated using code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"2901bcdf_b895ee15","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":65},"in_reply_to":"5708bc85_43c1cd93","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only test cases using local NFVO are included in the FT of the"},{"line_number":10,"context_line":"current v2 API."},{"line_number":11,"context_line":"This patch provides a new FT job for the v2 API to test seperated"},{"line_number":12,"context_line":"NFVO scenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. The split NFVO in this patch is to be simulated using code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5708bc85_43c1cd93","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":65},"in_reply_to":"8a33266f_dce51117","updated":"2022-05-17 01:55:40.000000000","message":"I fixed it in PS13.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"This patch provides a new FT job for the v2 API to test seperated"},{"line_number":12,"context_line":"NFVO scenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. The split NFVO in this patch is to be simulated using code."},{"line_number":15,"context_line":"2. This patch will merge the fake_grant_server.py of v1 as a common"},{"line_number":16,"context_line":"   fake_grant_server for users to test manually."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"6dc2cefe_31ee0e2a","line":14,"range":{"start_line":14,"start_character":7,"end_line":14,"end_character":12},"updated":"2022-05-16 08:23:19.000000000","message":"Just a question.\nOther than that, you use \"separated\", but why is it only \"split\" here?","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":11,"context_line":"This patch provides a new FT job for the v2 API to test seperated"},{"line_number":12,"context_line":"NFVO scenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. The split NFVO in this patch is to be simulated using code."},{"line_number":15,"context_line":"2. This patch will merge the fake_grant_server.py of v1 as a common"},{"line_number":16,"context_line":"   fake_grant_server for users to test manually."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"d9670fe3_160ae56e","line":14,"range":{"start_line":14,"start_character":7,"end_line":14,"end_character":12},"in_reply_to":"6dc2cefe_31ee0e2a","updated":"2022-05-17 01:55:40.000000000","message":"I fixed it in PS13.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This patch provides a new FT job for the v2 API to test seperated"},{"line_number":12,"context_line":"NFVO scenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. The split NFVO in this patch is to be simulated using code."},{"line_number":15,"context_line":"2. This patch will merge the fake_grant_server.py of v1 as a common"},{"line_number":16,"context_line":"   fake_grant_server for users to test manually."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"b70a9155_76942377","line":14,"range":{"start_line":14,"start_character":7,"end_line":14,"end_character":12},"in_reply_to":"d9670fe3_160ae56e","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9a0be36fcdf6053d68d9920113a2b8409ea2a4fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"96fb2fd4_e9cfea69","updated":"2022-04-18 05:45:56.000000000","message":"To Hiroo Kitamura:\nThank you for your comments. I fixed them in PS7.\nPlease kindly check them again.","commit_id":"f5160a967fdf24e1d57c8006f8707b74364ebc5b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"312cd2aa7bc6a6d39cefcf70f6c21c08c4f2e723","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ec901f3a_7016d2a3","updated":"2022-04-25 06:46:49.000000000","message":"To Hiroo Kitamura:\nThank you for your comments. I fixed them in PS11.\nPlease kindly check them again.","commit_id":"bae6fbc91fedf14ad27f98ee72c718a6f7d5cefd"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"8fccd9e29836dd4a64ead74038e8cd5c1a34eb52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0d5b9ccf_f7465753","updated":"2022-04-25 04:37:38.000000000","message":"recheck","commit_id":"bae6fbc91fedf14ad27f98ee72c718a6f7d5cefd"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"52f271454f3751512604387ff5403a2787daab0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c18d0bc0_f8f541ee","updated":"2022-04-27 00:45:15.000000000","message":"recheck","commit_id":"bae6fbc91fedf14ad27f98ee72c718a6f7d5cefd"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"406cd111_5e8c6408","updated":"2022-05-16 08:23:19.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"da0ab9f8_57232a2b","updated":"2022-05-17 01:55:40.000000000","message":"To Ayumu Ueha:\nThank you for your comments. I fixed them in PS13.\nPlease kindly check them again.","commit_id":"e9ea3e6475837534806b64e5336ba2022bfa4a9b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"380334fa89d9307ad57e6dcd54f7d0192f95638e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"11e503b1_9f7c348a","updated":"2022-05-19 01:39:46.000000000","message":"To Ai Hamano:\nThank you for your comments. I fixed them in PS15.\nPlease kindly check them again.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"dd16c83b706179cbc44057148117ad256155fa67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"778c6fc4_1756ef71","updated":"2022-05-17 13:04:24.000000000","message":"recheck","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"9aa25693_bf4dbec0","updated":"2022-05-23 04:35:39.000000000","message":"Thanks for your rework, LGTM.","commit_id":"0e24a0fdf5e39ce1e04f156a1947213490ccc230"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"86f694a426747d2f2df982023a2cba18589209c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"939170fb_c18b2e0f","updated":"2022-05-19 05:49:06.000000000","message":"recheck","commit_id":"0e24a0fdf5e39ce1e04f156a1947213490ccc230"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"99e8ed7d3d15061365ca0135c754f058c9f1c2d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"45a3128f_0f3f8b42","updated":"2022-05-24 02:54:41.000000000","message":"To Ai Hamano:\nThank you for your new comment. I fixed it in PS16.\nPlease kindly check it again.","commit_id":"67f8a46cdb2da7cdd0a9c1cca96b07749a852252"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"4c91559799a1d53c62a3de4f4d31b3b23743261c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"9246517b_6adbf3af","updated":"2022-05-25 00:24:48.000000000","message":"recheck","commit_id":"cb09f04288fd118b8f7d5c5bc2e29bba630fb664"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8897643dfc14a8ff56a07fe26ddc4f8b40c67226","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"033a589e_c812d18f","updated":"2022-05-30 01:48:51.000000000","message":"LGTM","commit_id":"be72fd1a83f3163fe5061bdea7c8ec560ee5373d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"38a43717670eaac84e6a57710021c2f74fb4901c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"8cfea4ca_826e3707","updated":"2022-05-30 00:57:38.000000000","message":"To Ai Hamano:\nThank you for your comment. I answered this comment. \nThis is my personal understanding and corresponding plan. If you have a better idea, please suggest it, I will adopt it and modify the code in the next patch.","commit_id":"be72fd1a83f3163fe5061bdea7c8ec560ee5373d"}],"tacker/tests/functional/common/fake_grant_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"006da82c1201ef3e5dacc2506f78b7d8183b6797","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a65358d_c2e7d91c","line":1,"updated":"2022-04-07 02:40:35.000000000","message":"It seems that the Copyright notation is missing.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9a0be36fcdf6053d68d9920113a2b8409ea2a4fd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff618792_d5f27ecd","line":1,"in_reply_to":"9a65358d_c2e7d91c","updated":"2022-04-18 05:45:56.000000000","message":"I fixed it in PS7.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"4d8d516c_74d353be","line":1,"in_reply_to":"ff618792_d5f27ecd","updated":"2022-04-21 04:08:01.000000000","message":"Done","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"54783987_3ca8a039","line":1,"in_reply_to":"ff618792_d5f27ecd","updated":"2022-04-21 04:08:01.000000000","message":"Done","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            zone \u003d self.nova_client.services.list()"},{"line_number":130,"context_line":"        except nova_client.exceptions.ClientException:"},{"line_number":131,"context_line":"            print(\"availability zone does not exists.\", flush\u003dTrue)"},{"line_number":132,"context_line":"            return []"},{"line_number":133,"context_line":"        return zone"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"0ead43f1_c298dea1","line":131,"range":{"start_line":131,"start_character":46,"end_line":131,"end_character":52},"updated":"2022-05-16 08:23:19.000000000","message":"nit: exist","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            zone \u003d self.nova_client.services.list()"},{"line_number":130,"context_line":"        except nova_client.exceptions.ClientException:"},{"line_number":131,"context_line":"            print(\"availability zone does not exists.\", flush\u003dTrue)"},{"line_number":132,"context_line":"            return []"},{"line_number":133,"context_line":"        return zone"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7d10e499_9a189404","line":131,"range":{"start_line":131,"start_character":46,"end_line":131,"end_character":52},"in_reply_to":"0ead43f1_c298dea1","updated":"2022-05-17 01:55:40.000000000","message":"I fixed it in PS13.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        try:"},{"line_number":129,"context_line":"            zone \u003d self.nova_client.services.list()"},{"line_number":130,"context_line":"        except nova_client.exceptions.ClientException:"},{"line_number":131,"context_line":"            print(\"availability zone does not exists.\", flush\u003dTrue)"},{"line_number":132,"context_line":"            return []"},{"line_number":133,"context_line":"        return zone"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5e0c8c13_266b318e","line":131,"range":{"start_line":131,"start_character":46,"end_line":131,"end_character":52},"in_reply_to":"7d10e499_9a189404","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        vim_list \u003d self.client.list_vims()"},{"line_number":137,"context_line":"        vim \u003d self.get_vim_specified(vim_list, \u0027openstack-admin-vim\u0027)"},{"line_number":138,"context_line":"        if not vim:"},{"line_number":139,"context_line":"            assert False, \"vim_list is Empty: Default VIM is missing\""},{"line_number":140,"context_line":"        return vim"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def get_vim_specified(self, vim_list, vim_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"d7078b74_91df0616","line":139,"range":{"start_line":139,"start_character":46,"end_line":139,"end_character":68},"updated":"2022-05-16 08:23:19.000000000","message":"I think \"specified VIM is missing\" is better.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        vim_list \u003d self.client.list_vims()"},{"line_number":137,"context_line":"        vim \u003d self.get_vim_specified(vim_list, \u0027openstack-admin-vim\u0027)"},{"line_number":138,"context_line":"        if not vim:"},{"line_number":139,"context_line":"            assert False, \"vim_list is Empty: Default VIM is missing\""},{"line_number":140,"context_line":"        return vim"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def get_vim_specified(self, vim_list, vim_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"71b2b237_a31b875e","line":139,"range":{"start_line":139,"start_character":27,"end_line":139,"end_character":44},"updated":"2022-05-16 08:23:19.000000000","message":"This route should also pass if `vim_list` is not empty, so \"vim_list is Empty\" is not suitable.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        vim_list \u003d self.client.list_vims()"},{"line_number":137,"context_line":"        vim \u003d self.get_vim_specified(vim_list, \u0027openstack-admin-vim\u0027)"},{"line_number":138,"context_line":"        if not vim:"},{"line_number":139,"context_line":"            assert False, \"vim_list is Empty: Default VIM is missing\""},{"line_number":140,"context_line":"        return vim"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def get_vim_specified(self, vim_list, vim_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"e55128c8_018b67d5","line":139,"range":{"start_line":139,"start_character":27,"end_line":139,"end_character":44},"in_reply_to":"71b2b237_a31b875e","updated":"2022-05-17 01:55:40.000000000","message":"I fixed it in PS13.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        vim_list \u003d self.client.list_vims()"},{"line_number":137,"context_line":"        vim \u003d self.get_vim_specified(vim_list, \u0027openstack-admin-vim\u0027)"},{"line_number":138,"context_line":"        if not vim:"},{"line_number":139,"context_line":"            assert False, \"vim_list is Empty: Default VIM is missing\""},{"line_number":140,"context_line":"        return vim"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def get_vim_specified(self, vim_list, vim_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ed0bc26d_2453c195","line":139,"range":{"start_line":139,"start_character":46,"end_line":139,"end_character":68},"in_reply_to":"d7078b74_91df0616","updated":"2022-05-17 01:55:40.000000000","message":"I fixed it in PS13.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        vim_list \u003d self.client.list_vims()"},{"line_number":137,"context_line":"        vim \u003d self.get_vim_specified(vim_list, \u0027openstack-admin-vim\u0027)"},{"line_number":138,"context_line":"        if not vim:"},{"line_number":139,"context_line":"            assert False, \"vim_list is Empty: Default VIM is missing\""},{"line_number":140,"context_line":"        return vim"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def get_vim_specified(self, vim_list, vim_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9e275be4_65346378","line":139,"range":{"start_line":139,"start_character":27,"end_line":139,"end_character":44},"in_reply_to":"e55128c8_018b67d5","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        vim_list \u003d self.client.list_vims()"},{"line_number":137,"context_line":"        vim \u003d self.get_vim_specified(vim_list, \u0027openstack-admin-vim\u0027)"},{"line_number":138,"context_line":"        if not vim:"},{"line_number":139,"context_line":"            assert False, \"vim_list is Empty: Default VIM is missing\""},{"line_number":140,"context_line":"        return vim"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    def get_vim_specified(self, vim_list, vim_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"83c09529_e0c1678a","line":139,"range":{"start_line":139,"start_character":46,"end_line":139,"end_character":68},"in_reply_to":"ed0bc26d_2453c195","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"def _update_res_name(data):"},{"line_number":290,"context_line":"    old_name \u003d data[\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":291,"context_line":"    data[\u0027metadata\u0027][\u0027name\u0027] \u003d data[\u0027metadata\u0027]["},{"line_number":292,"context_line":"        \u0027name\u0027] + \u0027-\u0027 + _get_random_string()"},{"line_number":293,"context_line":"    return old_name, data[\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"e58187ee_cb45541a","line":292,"range":{"start_line":291,"start_character":31,"end_line":292,"end_character":44},"updated":"2022-05-16 08:23:19.000000000","message":"How about using f-string instead of \"+\"?","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"def _update_res_name(data):"},{"line_number":290,"context_line":"    old_name \u003d data[\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":291,"context_line":"    data[\u0027metadata\u0027][\u0027name\u0027] \u003d data[\u0027metadata\u0027]["},{"line_number":292,"context_line":"        \u0027name\u0027] + \u0027-\u0027 + _get_random_string()"},{"line_number":293,"context_line":"    return old_name, data[\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"4c7e2162_b1ba2f9a","line":292,"range":{"start_line":291,"start_character":31,"end_line":292,"end_character":44},"in_reply_to":"0b364a66_2f834b1c","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"def _update_res_name(data):"},{"line_number":290,"context_line":"    old_name \u003d data[\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":291,"context_line":"    data[\u0027metadata\u0027][\u0027name\u0027] \u003d data[\u0027metadata\u0027]["},{"line_number":292,"context_line":"        \u0027name\u0027] + \u0027-\u0027 + _get_random_string()"},{"line_number":293,"context_line":"    return old_name, data[\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"0b364a66_2f834b1c","line":292,"range":{"start_line":291,"start_character":31,"end_line":292,"end_character":44},"in_reply_to":"e58187ee_cb45541a","updated":"2022-05-17 01:55:40.000000000","message":"I fixed it in PS13.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"def get_common_resp_info(request_body):"},{"line_number":311,"context_line":"    csar_path, vnfd_path \u003d get_package_path("},{"line_number":312,"context_line":"        request_body[\u0027vnfdId\u0027])"},{"line_number":313,"context_line":"    glance_image \u003d fake_grant_v2.GrantV2.get_sw_image(csar_path, vnfd_path)"},{"line_number":314,"context_line":"    flavour_vdu_dict \u003d fake_grant_v2.GrantV2.get_compute_flavor("},{"line_number":315,"context_line":"        csar_path, vnfd_path)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dc9facb1_79a311ab","line":312,"range":{"start_line":311,"start_character":4,"end_line":312,"end_character":31},"updated":"2022-05-16 08:23:19.000000000","message":"nit: I think it is less than 80 characters without line break.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"def get_common_resp_info(request_body):"},{"line_number":311,"context_line":"    csar_path, vnfd_path \u003d get_package_path("},{"line_number":312,"context_line":"        request_body[\u0027vnfdId\u0027])"},{"line_number":313,"context_line":"    glance_image \u003d fake_grant_v2.GrantV2.get_sw_image(csar_path, vnfd_path)"},{"line_number":314,"context_line":"    flavour_vdu_dict \u003d fake_grant_v2.GrantV2.get_compute_flavor("},{"line_number":315,"context_line":"        csar_path, vnfd_path)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df8e7773_36efcc53","line":312,"range":{"start_line":311,"start_character":4,"end_line":312,"end_character":31},"in_reply_to":"dc9facb1_79a311ab","updated":"2022-05-17 01:55:40.000000000","message":"I fixed it in PS13.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"def get_common_resp_info(request_body):"},{"line_number":311,"context_line":"    csar_path, vnfd_path \u003d get_package_path("},{"line_number":312,"context_line":"        request_body[\u0027vnfdId\u0027])"},{"line_number":313,"context_line":"    glance_image \u003d fake_grant_v2.GrantV2.get_sw_image(csar_path, vnfd_path)"},{"line_number":314,"context_line":"    flavour_vdu_dict \u003d fake_grant_v2.GrantV2.get_compute_flavor("},{"line_number":315,"context_line":"        csar_path, vnfd_path)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ec0ba45a_f594a02c","line":312,"range":{"start_line":311,"start_character":4,"end_line":312,"end_character":31},"in_reply_to":"df8e7773_36efcc53","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":479,"context_line":"                       methods\u003d[\u0027GET\u0027])"},{"line_number":480,"context_line":"def get_vnf_package(vnfdid):"},{"line_number":481,"context_line":"    resp_body \u003d ("},{"line_number":482,"context_line":"        fake_vnfpkgm_v2.VnfPackage.make_get_vnf_pkg_info_resp("},{"line_number":483,"context_line":"            vnfdid))"},{"line_number":484,"context_line":"    resp \u003d (resp_body, \u0027200\u0027, {\u0027Content-Type\u0027: \u0027application/json\u0027})"},{"line_number":485,"context_line":"    return resp"},{"line_number":486,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"95ec2e6a_d5e6c6df","line":483,"range":{"start_line":482,"start_character":0,"end_line":483,"end_character":20},"updated":"2022-05-16 08:23:19.000000000","message":"ditto.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                       methods\u003d[\u0027GET\u0027])"},{"line_number":480,"context_line":"def get_vnf_package(vnfdid):"},{"line_number":481,"context_line":"    resp_body \u003d ("},{"line_number":482,"context_line":"        fake_vnfpkgm_v2.VnfPackage.make_get_vnf_pkg_info_resp("},{"line_number":483,"context_line":"            vnfdid))"},{"line_number":484,"context_line":"    resp \u003d (resp_body, \u0027200\u0027, {\u0027Content-Type\u0027: \u0027application/json\u0027})"},{"line_number":485,"context_line":"    return resp"},{"line_number":486,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"d80ae845_6db2dfb4","line":483,"range":{"start_line":482,"start_character":0,"end_line":483,"end_character":20},"in_reply_to":"01ecfcf7_a97bf9f0","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":479,"context_line":"                       methods\u003d[\u0027GET\u0027])"},{"line_number":480,"context_line":"def get_vnf_package(vnfdid):"},{"line_number":481,"context_line":"    resp_body \u003d ("},{"line_number":482,"context_line":"        fake_vnfpkgm_v2.VnfPackage.make_get_vnf_pkg_info_resp("},{"line_number":483,"context_line":"            vnfdid))"},{"line_number":484,"context_line":"    resp \u003d (resp_body, \u0027200\u0027, {\u0027Content-Type\u0027: \u0027application/json\u0027})"},{"line_number":485,"context_line":"    return resp"},{"line_number":486,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"01ecfcf7_a97bf9f0","line":483,"range":{"start_line":482,"start_character":0,"end_line":483,"end_character":20},"in_reply_to":"95ec2e6a_d5e6c6df","updated":"2022-05-17 01:55:40.000000000","message":"I fixed it in PS13.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c6f4edcd83e1a7d1b74bbe22088db43c2ced2965","unresolved":true,"context_lines":[{"line_number":319,"context_line":"    return glance_image, flavour_vdu_dict, zone_name_list"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"@GrantServer.app.route(\u0027v1/grant/v1/grants\u0027, methods\u003d[\u0027POST\u0027])"},{"line_number":323,"context_line":"def grant():"},{"line_number":324,"context_line":"    body \u003d request.json"},{"line_number":325,"context_line":"    request_body \u003d Grant.convert_body_to_dict(body)"}],"source_content_type":"text/x-python","patch_set":18,"id":"87a20e55_fe774045","line":322,"updated":"2022-05-27 02:54:32.000000000","message":"Is it not necessary to change the URL used in v1 FT as well?\nhttps://review.opendev.org/c/openstack/tacker/+/830932/18/.zuul.yaml#304\n\"http://127.0.0.1:9990/grant/v1/grants\"\n-\u003e \"http://127.0.0.1:9990/v1/grant/v1/grants\"\n\nBoth v1 API and v2 API of Tacker use Grant v1, but what is the reason for separating grant definitions for v1 API and v2 API?\n(Currently, using grant_v2, both FT for v1 API and FT for v2 API seem to pass the test.)","commit_id":"be72fd1a83f3163fe5061bdea7c8ec560ee5373d"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"38a43717670eaac84e6a57710021c2f74fb4901c","unresolved":true,"context_lines":[{"line_number":319,"context_line":"    return glance_image, flavour_vdu_dict, zone_name_list"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"@GrantServer.app.route(\u0027v1/grant/v1/grants\u0027, methods\u003d[\u0027POST\u0027])"},{"line_number":323,"context_line":"def grant():"},{"line_number":324,"context_line":"    body \u003d request.json"},{"line_number":325,"context_line":"    request_body \u003d Grant.convert_body_to_dict(body)"}],"source_content_type":"text/x-python","patch_set":18,"id":"a353d6d2_a05718f6","line":322,"in_reply_to":"87a20e55_fe774045","updated":"2022-05-30 00:57:38.000000000","message":"This file is used for manual testing of separated NFVO to simulate the return value on the NFVO side. It has nothing to do with the return value of FT.\n\nIf v1 and v2 use the same URL, when tacker sends grant requests to NFVO, it goes to the same API and returns the same content.\n\nHowever, v1 and v2 are not exactly the same. According to the current implementation code, the key of the vim-related return value in v1 is \u0027vimConnections\u0027, and the key of the vim-related return value in v2 is \u0027vimConnectionInfo\u0027. So grant requests for v1 and v2 can only be processed separately with different urls.\n\nSince the Grant URL of V1 is a complete URL and can be customized by users, the URL of V1 is modified so that the case where v1 and V2 both use separated NFVO can return the correct value separately.","commit_id":"be72fd1a83f3163fe5061bdea7c8ec560ee5373d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8897643dfc14a8ff56a07fe26ddc4f8b40c67226","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    return glance_image, flavour_vdu_dict, zone_name_list"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"@GrantServer.app.route(\u0027v1/grant/v1/grants\u0027, methods\u003d[\u0027POST\u0027])"},{"line_number":323,"context_line":"def grant():"},{"line_number":324,"context_line":"    body \u003d request.json"},{"line_number":325,"context_line":"    request_body \u003d Grant.convert_body_to_dict(body)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5ccaace0_89f9eabc","line":322,"in_reply_to":"a353d6d2_a05718f6","updated":"2022-05-30 01:48:51.000000000","message":"Thank you for your polite explanation.\nI was able to understand that this file has nothing to do with FT.\nI also confirmed the difference between SOL003 v2.6.1 and v3.3.1 in the Grant definition.\n\nI\u0027m not sure if this is the best method, but I think it\u0027s okay if at least manual testing is the target.\nI agree with your policy.\nThank you for your time.","commit_id":"be72fd1a83f3163fe5061bdea7c8ec560ee5373d"}],"tacker/tests/functional/common/fake_nfvo_config.yaml":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"006da82c1201ef3e5dacc2506f78b7d8183b6797","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# sample_vnf_package\u0027s abs path v1"},{"line_number":2,"context_line":"v1_vnf_package_path: \u0027sample_v1.zip\u0027 # zip file\u0027s path"},{"line_number":3,"context_line":"v1_vnfd_file_name: \u0027Definitions/helloworld3_df_simple.yaml\u0027"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d17ca125_d7476c05","line":1,"updated":"2022-04-07 02:40:35.000000000","message":"Why manage this information in a yaml file?\nUnless you have a specific reason, you can define it directly in \"tacker/tests/functional/common/fake_grant_server.py\".","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# sample_vnf_package\u0027s abs path v1"},{"line_number":2,"context_line":"v1_vnf_package_path: \u0027sample_v1.zip\u0027 # zip file\u0027s path"},{"line_number":3,"context_line":"v1_vnfd_file_name: \u0027Definitions/helloworld3_df_simple.yaml\u0027"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"02817c08_c5a65090","line":1,"in_reply_to":"4ed37f15_923fa3b4","updated":"2022-04-21 04:08:01.000000000","message":"Done","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9a0be36fcdf6053d68d9920113a2b8409ea2a4fd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# sample_vnf_package\u0027s abs path v1"},{"line_number":2,"context_line":"v1_vnf_package_path: \u0027sample_v1.zip\u0027 # zip file\u0027s path"},{"line_number":3,"context_line":"v1_vnfd_file_name: \u0027Definitions/helloworld3_df_simple.yaml\u0027"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4ed37f15_923fa3b4","line":1,"in_reply_to":"d17ca125_d7476c05","updated":"2022-04-18 05:45:56.000000000","message":"I deleted this file in PS7.\nWhen we use sperated NFVO in local, we should know which vnf package we should return to tacker. so I set this config file.\nI have moved this parameter to fake_grant_server.py","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"}],"tacker/tests/functional/sol_separated_nfvo_v2/fake_grant_v2.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"006da82c1201ef3e5dacc2506f78b7d8183b6797","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"ed2a16d5_f4a8b6b2","line":1,"updated":"2022-04-07 02:40:35.000000000","message":"It seems that the Copyright notation is missing.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"a54f725d_cb71c357","line":1,"in_reply_to":"d30d9d07_f503e300","updated":"2022-04-21 04:08:01.000000000","message":"Done","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9a0be36fcdf6053d68d9920113a2b8409ea2a4fd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"d30d9d07_f503e300","line":1,"in_reply_to":"ed2a16d5_f4a8b6b2","updated":"2022-04-18 05:45:56.000000000","message":"I fixed it in PS7.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":253,"context_line":"            flavour_id_dict, zone_name_list):"},{"line_number":254,"context_line":"        request_body \u003d GrantV2.convert_body_to_dict(request_body)"},{"line_number":255,"context_line":"        res \u003d GrantV2._make_response_template(request_body)"},{"line_number":256,"context_line":"        res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":257,"context_line":"        res[\"zones\"] \u003d GrantV2._make_zones(zone_name_list)"},{"line_number":258,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":259,"context_line":"            res[\"addResources\"] \u003d GrantV2._make_add_resources("}],"source_content_type":"text/x-python","patch_set":12,"id":"0525cad9_cb7ad9d3","line":256,"range":{"start_line":256,"start_character":13,"end_line":256,"end_character":27},"updated":"2022-05-16 08:23:19.000000000","message":"If it is v3.3.1, I think `vimConnectionInfo` is correct.\n\nSOL003 v3.3.1 \"9.5.2.3 Type: Grant\"\nhttps://www.etsi.org/deliver/etsi_gs/NFV-SOL/001_099/003/03.03.01_60/gs_nfv-sol003v030301p.pdf","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":253,"context_line":"            flavour_id_dict, zone_name_list):"},{"line_number":254,"context_line":"        request_body \u003d GrantV2.convert_body_to_dict(request_body)"},{"line_number":255,"context_line":"        res \u003d GrantV2._make_response_template(request_body)"},{"line_number":256,"context_line":"        res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":257,"context_line":"        res[\"zones\"] \u003d GrantV2._make_zones(zone_name_list)"},{"line_number":258,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":259,"context_line":"            res[\"addResources\"] \u003d GrantV2._make_add_resources("}],"source_content_type":"text/x-python","patch_set":12,"id":"34a5b009_43185cce","line":256,"range":{"start_line":256,"start_character":13,"end_line":256,"end_character":27},"in_reply_to":"0525cad9_cb7ad9d3","updated":"2022-05-17 01:55:40.000000000","message":"I fixed it in PS13.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            flavour_id_dict, zone_name_list):"},{"line_number":254,"context_line":"        request_body \u003d GrantV2.convert_body_to_dict(request_body)"},{"line_number":255,"context_line":"        res \u003d GrantV2._make_response_template(request_body)"},{"line_number":256,"context_line":"        res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":257,"context_line":"        res[\"zones\"] \u003d GrantV2._make_zones(zone_name_list)"},{"line_number":258,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":259,"context_line":"            res[\"addResources\"] \u003d GrantV2._make_add_resources("}],"source_content_type":"text/x-python","patch_set":12,"id":"d0c094ac_6a6e100c","line":256,"range":{"start_line":256,"start_character":13,"end_line":256,"end_character":27},"in_reply_to":"34a5b009_43185cce","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":272,"context_line":"                                flavour_id_dict, zone_name_list):"},{"line_number":273,"context_line":"        request_body \u003d GrantV2.convert_body_to_dict(request_body)"},{"line_number":274,"context_line":"        res \u003d GrantV2._make_response_template(request_body)"},{"line_number":275,"context_line":"        res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":276,"context_line":"        res[\"zones\"] \u003d GrantV2._make_zones(zone_name_list)"},{"line_number":277,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":278,"context_line":"            res[\"addResources\"] \u003d GrantV2._make_add_resources("}],"source_content_type":"text/x-python","patch_set":12,"id":"c8e5d2c6_c10d1d8a","line":275,"range":{"start_line":275,"start_character":13,"end_line":275,"end_character":27},"updated":"2022-05-16 08:23:19.000000000","message":"ditto.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                                flavour_id_dict, zone_name_list):"},{"line_number":273,"context_line":"        request_body \u003d GrantV2.convert_body_to_dict(request_body)"},{"line_number":274,"context_line":"        res \u003d GrantV2._make_response_template(request_body)"},{"line_number":275,"context_line":"        res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":276,"context_line":"        res[\"zones\"] \u003d GrantV2._make_zones(zone_name_list)"},{"line_number":277,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":278,"context_line":"            res[\"addResources\"] \u003d GrantV2._make_add_resources("}],"source_content_type":"text/x-python","patch_set":12,"id":"a2598cff_d60e1571","line":275,"range":{"start_line":275,"start_character":13,"end_line":275,"end_character":27},"in_reply_to":"4a52e361_aceed80a","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":272,"context_line":"                                flavour_id_dict, zone_name_list):"},{"line_number":273,"context_line":"        request_body \u003d GrantV2.convert_body_to_dict(request_body)"},{"line_number":274,"context_line":"        res \u003d GrantV2._make_response_template(request_body)"},{"line_number":275,"context_line":"        res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":276,"context_line":"        res[\"zones\"] \u003d GrantV2._make_zones(zone_name_list)"},{"line_number":277,"context_line":"        if \u0027addResources\u0027 in request_body.keys():"},{"line_number":278,"context_line":"            res[\"addResources\"] \u003d GrantV2._make_add_resources("}],"source_content_type":"text/x-python","patch_set":12,"id":"4a52e361_aceed80a","line":275,"range":{"start_line":275,"start_character":13,"end_line":275,"end_character":27},"in_reply_to":"c8e5d2c6_c10d1d8a","updated":"2022-05-17 01:55:40.000000000","message":"ditto","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":306,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":307,"context_line":"                image_id_dict,"},{"line_number":308,"context_line":"                flavour_id_dict)"},{"line_number":309,"context_line":"            res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":310,"context_line":"        if \u0027removeResources\u0027 in request_body.keys():"},{"line_number":311,"context_line":"            res[\"removeResources\"] \u003d GrantV2._make_remove_resources("},{"line_number":312,"context_line":"                request_body[\u0027removeResources\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba08a23b_e54dcf31","line":309,"range":{"start_line":309,"start_character":17,"end_line":309,"end_character":31},"updated":"2022-05-16 08:23:19.000000000","message":"ditto.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":307,"context_line":"                image_id_dict,"},{"line_number":308,"context_line":"                flavour_id_dict)"},{"line_number":309,"context_line":"            res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":310,"context_line":"        if \u0027removeResources\u0027 in request_body.keys():"},{"line_number":311,"context_line":"            res[\"removeResources\"] \u003d GrantV2._make_remove_resources("},{"line_number":312,"context_line":"                request_body[\u0027removeResources\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"af922ba6_64859d2c","line":309,"range":{"start_line":309,"start_character":17,"end_line":309,"end_character":31},"in_reply_to":"1b2b39f5_9312abe9","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":306,"context_line":"                request_body[\u0027addResources\u0027],"},{"line_number":307,"context_line":"                image_id_dict,"},{"line_number":308,"context_line":"                flavour_id_dict)"},{"line_number":309,"context_line":"            res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":310,"context_line":"        if \u0027removeResources\u0027 in request_body.keys():"},{"line_number":311,"context_line":"            res[\"removeResources\"] \u003d GrantV2._make_remove_resources("},{"line_number":312,"context_line":"                request_body[\u0027removeResources\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"1b2b39f5_9312abe9","line":309,"range":{"start_line":309,"start_character":17,"end_line":309,"end_character":31},"in_reply_to":"ba08a23b_e54dcf31","updated":"2022-05-17 01:55:40.000000000","message":"ditto","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"269c68dcc4f4222a1dd13c4137fc0325229ec8f2","unresolved":true,"context_lines":[{"line_number":328,"context_line":"            request_body, zone_name_list):"},{"line_number":329,"context_line":"        request_body \u003d GrantV2.convert_body_to_dict(request_body)"},{"line_number":330,"context_line":"        res \u003d GrantV2._make_response_template(request_body)"},{"line_number":331,"context_line":"        res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":332,"context_line":"        res[\"zones\"] \u003d GrantV2._make_zones(zone_name_list)"},{"line_number":333,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":334,"context_line":"            res[\"updateResources\"] \u003d GrantV2._make_update_resources("}],"source_content_type":"text/x-python","patch_set":12,"id":"f2de07c9_6a9fc460","line":331,"range":{"start_line":331,"start_character":13,"end_line":331,"end_character":27},"updated":"2022-05-16 08:23:19.000000000","message":"ditto.","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0e8a5ad2d43157945d02ab5ed6c942b6686c1ccd","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            request_body, zone_name_list):"},{"line_number":329,"context_line":"        request_body \u003d GrantV2.convert_body_to_dict(request_body)"},{"line_number":330,"context_line":"        res \u003d GrantV2._make_response_template(request_body)"},{"line_number":331,"context_line":"        res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":332,"context_line":"        res[\"zones\"] \u003d GrantV2._make_zones(zone_name_list)"},{"line_number":333,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":334,"context_line":"            res[\"updateResources\"] \u003d GrantV2._make_update_resources("}],"source_content_type":"text/x-python","patch_set":12,"id":"93392cde_3d7fed7e","line":331,"range":{"start_line":331,"start_character":13,"end_line":331,"end_character":27},"in_reply_to":"3c02aecb_27566c6a","updated":"2022-05-23 04:35:39.000000000","message":"Ack","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bf1dd6ef43d54a98191f3720f6de55f3e9e4b20e","unresolved":true,"context_lines":[{"line_number":328,"context_line":"            request_body, zone_name_list):"},{"line_number":329,"context_line":"        request_body \u003d GrantV2.convert_body_to_dict(request_body)"},{"line_number":330,"context_line":"        res \u003d GrantV2._make_response_template(request_body)"},{"line_number":331,"context_line":"        res[\"vimConnections\"] \u003d GrantV2._make_vim_connection_info()"},{"line_number":332,"context_line":"        res[\"zones\"] \u003d GrantV2._make_zones(zone_name_list)"},{"line_number":333,"context_line":"        if \u0027updateResources\u0027 in request_body.keys():"},{"line_number":334,"context_line":"            res[\"updateResources\"] \u003d GrantV2._make_update_resources("}],"source_content_type":"text/x-python","patch_set":12,"id":"3c02aecb_27566c6a","line":331,"range":{"start_line":331,"start_character":13,"end_line":331,"end_character":27},"in_reply_to":"f2de07c9_6a9fc460","updated":"2022-05-17 01:55:40.000000000","message":"ditto","commit_id":"032661cf9785dcaa4260dec2c08c4b9ab0ad055e"}],"tacker/tests/functional/sol_separated_nfvo_v2/fake_vnfpkgm_v2.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"006da82c1201ef3e5dacc2506f78b7d8183b6797","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"787604d7_2dd57672","line":1,"updated":"2022-04-07 02:40:35.000000000","message":"It seems that the Copyright notation is missing.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"d9521b4d_37fe5b85","line":1,"in_reply_to":"5d82b350_6a9c4a4c","updated":"2022-04-21 04:08:01.000000000","message":"Done","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9a0be36fcdf6053d68d9920113a2b8409ea2a4fd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"5d82b350_6a9c4a4c","line":1,"in_reply_to":"787604d7_2dd57672","updated":"2022-04-18 05:45:56.000000000","message":"I fixed it in PS7.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"}],"tacker/tests/functional/sol_separated_nfvo_v2/test_nfvo_separate_v2.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"006da82c1201ef3e5dacc2506f78b7d8183b6797","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"804c895a_da6bad49","line":1,"updated":"2022-04-07 02:40:35.000000000","message":"It seems that the Copyright notation is missing.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9a0be36fcdf6053d68d9920113a2b8409ea2a4fd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"cf7f7699_013c95db","line":1,"in_reply_to":"804c895a_da6bad49","updated":"2022-04-18 05:45:56.000000000","message":"I fixed it in PS7.","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"# a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"a27fc38c_ca2dff25","line":1,"in_reply_to":"cf7f7699_013c95db","updated":"2022-04-21 04:08:01.000000000","message":"Done","commit_id":"1489b2d91882ca44d446b5270ace3c094f22f770"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"231f81b52e292db946081a23e42ac03daed73f85","unresolved":true,"context_lines":[{"line_number":19,"context_line":"class VnfLcmWithNfvoSeparator(test_vnflcm_basic_common.CommonVnfLcmTest):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_basic_lcms_max(self):"},{"line_number":22,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        * About attributes:"},{"line_number":25,"context_line":"          All of the following cardinality attributes are set."},{"line_number":26,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":27,"context_line":"          - 0..1 (1)"},{"line_number":28,"context_line":"          - 0..N (2 or more)"},{"line_number":29,"context_line":"          - 1"},{"line_number":30,"context_line":"          - 1..N (2 or more)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        * About LCM operations:"},{"line_number":33,"context_line":"          This test includes the following operations."},{"line_number":34,"context_line":"          - 0. Pre-setting"},{"line_number":35,"context_line":"          - 1. Create subscription"},{"line_number":36,"context_line":"          - 2. Test notification"},{"line_number":37,"context_line":"          - 3. Show subscription"},{"line_number":38,"context_line":"          - 4. Create VNF instance"},{"line_number":39,"context_line":"          - 5. Instantiate VNF"},{"line_number":40,"context_line":"          - 6. Show VNF instance"},{"line_number":41,"context_line":"          - 7. Show VNF LCM operation occurrence"},{"line_number":42,"context_line":"          - 8. Heal VNF(all with omit all parameter)"},{"line_number":43,"context_line":"          - 9. Heal VNF(all with all\u003dTrue parameter)"},{"line_number":44,"context_line":"          - 10. Scale out operation"},{"line_number":45,"context_line":"          - 11. Show VNF instance"},{"line_number":46,"context_line":"          - 12. Scale in operation"},{"line_number":47,"context_line":"          - 13. Show VNF instance"},{"line_number":48,"context_line":"          - 14. Heal VNF(vnfc)"},{"line_number":49,"context_line":"          - 15. Change external connectivity"},{"line_number":50,"context_line":"          - 16. Show VNF LCM operation occurrence"},{"line_number":51,"context_line":"          - 17. Heal VNF(vnfc with omit all parameter)"},{"line_number":52,"context_line":"          - 18. Heal VNF(vnfc with all\u003dfalse parameter)"},{"line_number":53,"context_line":"          - 19. Heal VNF(vnfc with all\u003dtrue parameter)"},{"line_number":54,"context_line":"          - 20. Update VNF"},{"line_number":55,"context_line":"          - 21. Show VNF instance"},{"line_number":56,"context_line":"          - 22. Terminate VNF"},{"line_number":57,"context_line":"          - 23. Delete VNF instance"},{"line_number":58,"context_line":"          - 24. Delete subscription"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        self.basic_lcms_max_common_test(True)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_basic_lcms_min(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f26db3d_9e370eed","line":59,"range":{"start_line":22,"start_character":0,"end_line":59,"end_character":11},"updated":"2022-05-18 07:01:33.000000000","message":"I think it\u0027s better to delete the comment as well as test_vnflcm_basic.py.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"380334fa89d9307ad57e6dcd54f7d0192f95638e","unresolved":true,"context_lines":[{"line_number":19,"context_line":"class VnfLcmWithNfvoSeparator(test_vnflcm_basic_common.CommonVnfLcmTest):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_basic_lcms_max(self):"},{"line_number":22,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        * About attributes:"},{"line_number":25,"context_line":"          All of the following cardinality attributes are set."},{"line_number":26,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":27,"context_line":"          - 0..1 (1)"},{"line_number":28,"context_line":"          - 0..N (2 or more)"},{"line_number":29,"context_line":"          - 1"},{"line_number":30,"context_line":"          - 1..N (2 or more)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        * About LCM operations:"},{"line_number":33,"context_line":"          This test includes the following operations."},{"line_number":34,"context_line":"          - 0. Pre-setting"},{"line_number":35,"context_line":"          - 1. Create subscription"},{"line_number":36,"context_line":"          - 2. Test notification"},{"line_number":37,"context_line":"          - 3. Show subscription"},{"line_number":38,"context_line":"          - 4. Create VNF instance"},{"line_number":39,"context_line":"          - 5. Instantiate VNF"},{"line_number":40,"context_line":"          - 6. Show VNF instance"},{"line_number":41,"context_line":"          - 7. Show VNF LCM operation occurrence"},{"line_number":42,"context_line":"          - 8. Heal VNF(all with omit all parameter)"},{"line_number":43,"context_line":"          - 9. Heal VNF(all with all\u003dTrue parameter)"},{"line_number":44,"context_line":"          - 10. Scale out operation"},{"line_number":45,"context_line":"          - 11. Show VNF instance"},{"line_number":46,"context_line":"          - 12. Scale in operation"},{"line_number":47,"context_line":"          - 13. Show VNF instance"},{"line_number":48,"context_line":"          - 14. Heal VNF(vnfc)"},{"line_number":49,"context_line":"          - 15. Change external connectivity"},{"line_number":50,"context_line":"          - 16. Show VNF LCM operation occurrence"},{"line_number":51,"context_line":"          - 17. Heal VNF(vnfc with omit all parameter)"},{"line_number":52,"context_line":"          - 18. Heal VNF(vnfc with all\u003dfalse parameter)"},{"line_number":53,"context_line":"          - 19. Heal VNF(vnfc with all\u003dtrue parameter)"},{"line_number":54,"context_line":"          - 20. Update VNF"},{"line_number":55,"context_line":"          - 21. Show VNF instance"},{"line_number":56,"context_line":"          - 22. Terminate VNF"},{"line_number":57,"context_line":"          - 23. Delete VNF instance"},{"line_number":58,"context_line":"          - 24. Delete subscription"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        self.basic_lcms_max_common_test(True)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_basic_lcms_min(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"e299e73b_50af6058","line":59,"range":{"start_line":22,"start_character":0,"end_line":59,"end_character":11},"in_reply_to":"5f26db3d_9e370eed","updated":"2022-05-19 01:39:46.000000000","message":"I deleted these comments in PS15.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9c97eb55880d8fdd079f513f600aecc40af55da5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class VnfLcmWithNfvoSeparator(test_vnflcm_basic_common.CommonVnfLcmTest):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_basic_lcms_max(self):"},{"line_number":22,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        * About attributes:"},{"line_number":25,"context_line":"          All of the following cardinality attributes are set."},{"line_number":26,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":27,"context_line":"          - 0..1 (1)"},{"line_number":28,"context_line":"          - 0..N (2 or more)"},{"line_number":29,"context_line":"          - 1"},{"line_number":30,"context_line":"          - 1..N (2 or more)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        * About LCM operations:"},{"line_number":33,"context_line":"          This test includes the following operations."},{"line_number":34,"context_line":"          - 0. Pre-setting"},{"line_number":35,"context_line":"          - 1. Create subscription"},{"line_number":36,"context_line":"          - 2. Test notification"},{"line_number":37,"context_line":"          - 3. Show subscription"},{"line_number":38,"context_line":"          - 4. Create VNF instance"},{"line_number":39,"context_line":"          - 5. Instantiate VNF"},{"line_number":40,"context_line":"          - 6. Show VNF instance"},{"line_number":41,"context_line":"          - 7. Show VNF LCM operation occurrence"},{"line_number":42,"context_line":"          - 8. Heal VNF(all with omit all parameter)"},{"line_number":43,"context_line":"          - 9. Heal VNF(all with all\u003dTrue parameter)"},{"line_number":44,"context_line":"          - 10. Scale out operation"},{"line_number":45,"context_line":"          - 11. Show VNF instance"},{"line_number":46,"context_line":"          - 12. Scale in operation"},{"line_number":47,"context_line":"          - 13. Show VNF instance"},{"line_number":48,"context_line":"          - 14. Heal VNF(vnfc)"},{"line_number":49,"context_line":"          - 15. Change external connectivity"},{"line_number":50,"context_line":"          - 16. Show VNF LCM operation occurrence"},{"line_number":51,"context_line":"          - 17. Heal VNF(vnfc with omit all parameter)"},{"line_number":52,"context_line":"          - 18. Heal VNF(vnfc with all\u003dfalse parameter)"},{"line_number":53,"context_line":"          - 19. Heal VNF(vnfc with all\u003dtrue parameter)"},{"line_number":54,"context_line":"          - 20. Update VNF"},{"line_number":55,"context_line":"          - 21. Show VNF instance"},{"line_number":56,"context_line":"          - 22. Terminate VNF"},{"line_number":57,"context_line":"          - 23. Delete VNF instance"},{"line_number":58,"context_line":"          - 24. Delete subscription"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        self.basic_lcms_max_common_test(True)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_basic_lcms_min(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"b9911cab_20b97e33","line":59,"range":{"start_line":22,"start_character":0,"end_line":59,"end_character":11},"in_reply_to":"e299e73b_50af6058","updated":"2022-05-23 05:02:51.000000000","message":"Done","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"231f81b52e292db946081a23e42ac03daed73f85","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        self.basic_lcms_max_common_test(True)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_basic_lcms_min(self):"},{"line_number":63,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        The change_ext_conn can\u0027t be tested here because VNF package 2 don\u0027t"},{"line_number":66,"context_line":"        have external connectivity. So moved it to the test_scale_other_lcm()."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        * About attributes:"},{"line_number":69,"context_line":"          Omit except for required attributes."},{"line_number":70,"context_line":"          Only the following cardinality attributes are set."},{"line_number":71,"context_line":"          - 1"},{"line_number":72,"context_line":"          - 1..N (1)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        * About LCM operations:"},{"line_number":75,"context_line":"          This test includes the following operations."},{"line_number":76,"context_line":"          - 1. Create subscription"},{"line_number":77,"context_line":"          - 2. Test notification"},{"line_number":78,"context_line":"          - 3. Create VNF instance"},{"line_number":79,"context_line":"          - 4. Instantiate VNF"},{"line_number":80,"context_line":"          - 5. Show VNF instance"},{"line_number":81,"context_line":"          - 6. Heal VNF(all with omit all parameter)"},{"line_number":82,"context_line":"          - 7. Show VNF instance"},{"line_number":83,"context_line":"          - 8. Update VNF"},{"line_number":84,"context_line":"          - 9. Heal VNF(vnfc)"},{"line_number":85,"context_line":"          - 10. Show VNF instance"},{"line_number":86,"context_line":"          - 11. Scale out operation"},{"line_number":87,"context_line":"          - 12. Show VNF instance"},{"line_number":88,"context_line":"          - 13. Scale in operation"},{"line_number":89,"context_line":"          - 14. Terminate VNF"},{"line_number":90,"context_line":"          - 15. Delete VNF instance"},{"line_number":91,"context_line":"          - 16. Delete subscription"},{"line_number":92,"context_line":"          - 17. Show subscription"},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        self.basic_lcms_min_common_test(True)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_change_vnfpkg(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"3bbd7d7d_4c6a16ac","line":93,"range":{"start_line":63,"start_character":0,"end_line":93,"end_character":11},"updated":"2022-05-18 07:01:33.000000000","message":"ditto","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"380334fa89d9307ad57e6dcd54f7d0192f95638e","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        self.basic_lcms_max_common_test(True)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_basic_lcms_min(self):"},{"line_number":63,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        The change_ext_conn can\u0027t be tested here because VNF package 2 don\u0027t"},{"line_number":66,"context_line":"        have external connectivity. So moved it to the test_scale_other_lcm()."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        * About attributes:"},{"line_number":69,"context_line":"          Omit except for required attributes."},{"line_number":70,"context_line":"          Only the following cardinality attributes are set."},{"line_number":71,"context_line":"          - 1"},{"line_number":72,"context_line":"          - 1..N (1)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        * About LCM operations:"},{"line_number":75,"context_line":"          This test includes the following operations."},{"line_number":76,"context_line":"          - 1. Create subscription"},{"line_number":77,"context_line":"          - 2. Test notification"},{"line_number":78,"context_line":"          - 3. Create VNF instance"},{"line_number":79,"context_line":"          - 4. Instantiate VNF"},{"line_number":80,"context_line":"          - 5. Show VNF instance"},{"line_number":81,"context_line":"          - 6. Heal VNF(all with omit all parameter)"},{"line_number":82,"context_line":"          - 7. Show VNF instance"},{"line_number":83,"context_line":"          - 8. Update VNF"},{"line_number":84,"context_line":"          - 9. Heal VNF(vnfc)"},{"line_number":85,"context_line":"          - 10. Show VNF instance"},{"line_number":86,"context_line":"          - 11. Scale out operation"},{"line_number":87,"context_line":"          - 12. Show VNF instance"},{"line_number":88,"context_line":"          - 13. Scale in operation"},{"line_number":89,"context_line":"          - 14. Terminate VNF"},{"line_number":90,"context_line":"          - 15. Delete VNF instance"},{"line_number":91,"context_line":"          - 16. Delete subscription"},{"line_number":92,"context_line":"          - 17. Show subscription"},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        self.basic_lcms_min_common_test(True)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_change_vnfpkg(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"bb579a43_cc2f6ffb","line":93,"range":{"start_line":63,"start_character":0,"end_line":93,"end_character":11},"in_reply_to":"3bbd7d7d_4c6a16ac","updated":"2022-05-19 01:39:46.000000000","message":"ditto","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9c97eb55880d8fdd079f513f600aecc40af55da5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.basic_lcms_max_common_test(True)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_basic_lcms_min(self):"},{"line_number":63,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        The change_ext_conn can\u0027t be tested here because VNF package 2 don\u0027t"},{"line_number":66,"context_line":"        have external connectivity. So moved it to the test_scale_other_lcm()."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        * About attributes:"},{"line_number":69,"context_line":"          Omit except for required attributes."},{"line_number":70,"context_line":"          Only the following cardinality attributes are set."},{"line_number":71,"context_line":"          - 1"},{"line_number":72,"context_line":"          - 1..N (1)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        * About LCM operations:"},{"line_number":75,"context_line":"          This test includes the following operations."},{"line_number":76,"context_line":"          - 1. Create subscription"},{"line_number":77,"context_line":"          - 2. Test notification"},{"line_number":78,"context_line":"          - 3. Create VNF instance"},{"line_number":79,"context_line":"          - 4. Instantiate VNF"},{"line_number":80,"context_line":"          - 5. Show VNF instance"},{"line_number":81,"context_line":"          - 6. Heal VNF(all with omit all parameter)"},{"line_number":82,"context_line":"          - 7. Show VNF instance"},{"line_number":83,"context_line":"          - 8. Update VNF"},{"line_number":84,"context_line":"          - 9. Heal VNF(vnfc)"},{"line_number":85,"context_line":"          - 10. Show VNF instance"},{"line_number":86,"context_line":"          - 11. Scale out operation"},{"line_number":87,"context_line":"          - 12. Show VNF instance"},{"line_number":88,"context_line":"          - 13. Scale in operation"},{"line_number":89,"context_line":"          - 14. Terminate VNF"},{"line_number":90,"context_line":"          - 15. Delete VNF instance"},{"line_number":91,"context_line":"          - 16. Delete subscription"},{"line_number":92,"context_line":"          - 17. Show subscription"},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        self.basic_lcms_min_common_test(True)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_change_vnfpkg(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"25dea4a4_09bc9ba6","line":93,"range":{"start_line":63,"start_character":0,"end_line":93,"end_character":11},"in_reply_to":"bb579a43_cc2f6ffb","updated":"2022-05-23 05:02:51.000000000","message":"Done","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"231f81b52e292db946081a23e42ac03daed73f85","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        self.basic_lcms_min_common_test(True)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_change_vnfpkg(self):"},{"line_number":97,"context_line":"        \"\"\"Test basic life cycle operations with sample VNFD with UserData."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        In this test case, we do following steps."},{"line_number":100,"context_line":"            - Create subscription."},{"line_number":101,"context_line":"            - Create VNF instance."},{"line_number":102,"context_line":"            - Instantiate VNF."},{"line_number":103,"context_line":"            - Show VNF instance."},{"line_number":104,"context_line":"            - Change VNF Package."},{"line_number":105,"context_line":"            - Show VNF instance."},{"line_number":106,"context_line":"            - Terminate VNF."},{"line_number":107,"context_line":"            - Delete VNF."},{"line_number":108,"context_line":"            - Delete subscription."},{"line_number":109,"context_line":"            - Show subscription."},{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        self.change_vnfpkg_from_image_to_volume_common_test(True)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_retry_rollback_scale_out(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"4dc1fc55_2b1e27c1","line":110,"range":{"start_line":97,"start_character":0,"end_line":110,"end_character":11},"updated":"2022-05-18 07:01:33.000000000","message":"ditto","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"380334fa89d9307ad57e6dcd54f7d0192f95638e","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        self.basic_lcms_min_common_test(True)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_change_vnfpkg(self):"},{"line_number":97,"context_line":"        \"\"\"Test basic life cycle operations with sample VNFD with UserData."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        In this test case, we do following steps."},{"line_number":100,"context_line":"            - Create subscription."},{"line_number":101,"context_line":"            - Create VNF instance."},{"line_number":102,"context_line":"            - Instantiate VNF."},{"line_number":103,"context_line":"            - Show VNF instance."},{"line_number":104,"context_line":"            - Change VNF Package."},{"line_number":105,"context_line":"            - Show VNF instance."},{"line_number":106,"context_line":"            - Terminate VNF."},{"line_number":107,"context_line":"            - Delete VNF."},{"line_number":108,"context_line":"            - Delete subscription."},{"line_number":109,"context_line":"            - Show subscription."},{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        self.change_vnfpkg_from_image_to_volume_common_test(True)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_retry_rollback_scale_out(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5212ac7d_d9ee664e","line":110,"range":{"start_line":97,"start_character":0,"end_line":110,"end_character":11},"in_reply_to":"4dc1fc55_2b1e27c1","updated":"2022-05-19 01:39:46.000000000","message":"ditto","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9c97eb55880d8fdd079f513f600aecc40af55da5","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.basic_lcms_min_common_test(True)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_change_vnfpkg(self):"},{"line_number":97,"context_line":"        \"\"\"Test basic life cycle operations with sample VNFD with UserData."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        In this test case, we do following steps."},{"line_number":100,"context_line":"            - Create subscription."},{"line_number":101,"context_line":"            - Create VNF instance."},{"line_number":102,"context_line":"            - Instantiate VNF."},{"line_number":103,"context_line":"            - Show VNF instance."},{"line_number":104,"context_line":"            - Change VNF Package."},{"line_number":105,"context_line":"            - Show VNF instance."},{"line_number":106,"context_line":"            - Terminate VNF."},{"line_number":107,"context_line":"            - Delete VNF."},{"line_number":108,"context_line":"            - Delete subscription."},{"line_number":109,"context_line":"            - Show subscription."},{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        self.change_vnfpkg_from_image_to_volume_common_test(True)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_retry_rollback_scale_out(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"a9dafe25_f8035e68","line":110,"range":{"start_line":97,"start_character":0,"end_line":110,"end_character":11},"in_reply_to":"5212ac7d_d9ee664e","updated":"2022-05-23 05:02:51.000000000","message":"Done","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"231f81b52e292db946081a23e42ac03daed73f85","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        self.change_vnfpkg_from_image_to_volume_common_test(True)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":114,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        * About attributes:"},{"line_number":117,"context_line":"          All of the following cardinality attributes are set."},{"line_number":118,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":119,"context_line":"          - 0..1 (1)"},{"line_number":120,"context_line":"          - 0..N (2 or more)"},{"line_number":121,"context_line":"          - 1"},{"line_number":122,"context_line":"          - 1..N (2 or more)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        * About LCM operations:"},{"line_number":125,"context_line":"          This test includes the following operations."},{"line_number":126,"context_line":"          - 0. Pre-setting"},{"line_number":127,"context_line":"          - 1. Create subscription"},{"line_number":128,"context_line":"          - 2. Test notification"},{"line_number":129,"context_line":"          - 3. Create VNF instance"},{"line_number":130,"context_line":"          - 4. Instantiate VNF"},{"line_number":131,"context_line":"          - 5. Show VNF instance"},{"line_number":132,"context_line":"          - 6. Scale out operation(will fail)"},{"line_number":133,"context_line":"          - 7. Show VNF instance"},{"line_number":134,"context_line":"          - 8. Retry operation"},{"line_number":135,"context_line":"          - 9. Rollback scale out operation"},{"line_number":136,"context_line":"          - 10. Show VNF LCM operation occurrence"},{"line_number":137,"context_line":"          - 11. List VNF LCM operation occurrence"},{"line_number":138,"context_line":"          - 12. Terminate VNF"},{"line_number":139,"context_line":"          - 13. Delete VNF instance"},{"line_number":140,"context_line":"          - 14. Delete subscription"},{"line_number":141,"context_line":"          - 15. Show subscription"},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        self.retry_rollback_scale_out_common_test(True)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_fail_instantiate(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5ca1314d_a92d72b9","line":142,"range":{"start_line":114,"start_character":0,"end_line":142,"end_character":11},"updated":"2022-05-18 07:01:33.000000000","message":"ditto","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"380334fa89d9307ad57e6dcd54f7d0192f95638e","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        self.change_vnfpkg_from_image_to_volume_common_test(True)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":114,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        * About attributes:"},{"line_number":117,"context_line":"          All of the following cardinality attributes are set."},{"line_number":118,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":119,"context_line":"          - 0..1 (1)"},{"line_number":120,"context_line":"          - 0..N (2 or more)"},{"line_number":121,"context_line":"          - 1"},{"line_number":122,"context_line":"          - 1..N (2 or more)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        * About LCM operations:"},{"line_number":125,"context_line":"          This test includes the following operations."},{"line_number":126,"context_line":"          - 0. Pre-setting"},{"line_number":127,"context_line":"          - 1. Create subscription"},{"line_number":128,"context_line":"          - 2. Test notification"},{"line_number":129,"context_line":"          - 3. Create VNF instance"},{"line_number":130,"context_line":"          - 4. Instantiate VNF"},{"line_number":131,"context_line":"          - 5. Show VNF instance"},{"line_number":132,"context_line":"          - 6. Scale out operation(will fail)"},{"line_number":133,"context_line":"          - 7. Show VNF instance"},{"line_number":134,"context_line":"          - 8. Retry operation"},{"line_number":135,"context_line":"          - 9. Rollback scale out operation"},{"line_number":136,"context_line":"          - 10. Show VNF LCM operation occurrence"},{"line_number":137,"context_line":"          - 11. List VNF LCM operation occurrence"},{"line_number":138,"context_line":"          - 12. Terminate VNF"},{"line_number":139,"context_line":"          - 13. Delete VNF instance"},{"line_number":140,"context_line":"          - 14. Delete subscription"},{"line_number":141,"context_line":"          - 15. Show subscription"},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        self.retry_rollback_scale_out_common_test(True)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_fail_instantiate(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"68d483bf_13885d52","line":142,"range":{"start_line":114,"start_character":0,"end_line":142,"end_character":11},"in_reply_to":"5ca1314d_a92d72b9","updated":"2022-05-19 01:39:46.000000000","message":"ditto","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9c97eb55880d8fdd079f513f600aecc40af55da5","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.change_vnfpkg_from_image_to_volume_common_test(True)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":114,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        * About attributes:"},{"line_number":117,"context_line":"          All of the following cardinality attributes are set."},{"line_number":118,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":119,"context_line":"          - 0..1 (1)"},{"line_number":120,"context_line":"          - 0..N (2 or more)"},{"line_number":121,"context_line":"          - 1"},{"line_number":122,"context_line":"          - 1..N (2 or more)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        * About LCM operations:"},{"line_number":125,"context_line":"          This test includes the following operations."},{"line_number":126,"context_line":"          - 0. Pre-setting"},{"line_number":127,"context_line":"          - 1. Create subscription"},{"line_number":128,"context_line":"          - 2. Test notification"},{"line_number":129,"context_line":"          - 3. Create VNF instance"},{"line_number":130,"context_line":"          - 4. Instantiate VNF"},{"line_number":131,"context_line":"          - 5. Show VNF instance"},{"line_number":132,"context_line":"          - 6. Scale out operation(will fail)"},{"line_number":133,"context_line":"          - 7. Show VNF instance"},{"line_number":134,"context_line":"          - 8. Retry operation"},{"line_number":135,"context_line":"          - 9. Rollback scale out operation"},{"line_number":136,"context_line":"          - 10. Show VNF LCM operation occurrence"},{"line_number":137,"context_line":"          - 11. List VNF LCM operation occurrence"},{"line_number":138,"context_line":"          - 12. Terminate VNF"},{"line_number":139,"context_line":"          - 13. Delete VNF instance"},{"line_number":140,"context_line":"          - 14. Delete subscription"},{"line_number":141,"context_line":"          - 15. Show subscription"},{"line_number":142,"context_line":"        \"\"\""},{"line_number":143,"context_line":"        self.retry_rollback_scale_out_common_test(True)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_fail_instantiate(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"c1ff4963_8a3c617d","line":142,"range":{"start_line":114,"start_character":0,"end_line":142,"end_character":11},"in_reply_to":"68d483bf_13885d52","updated":"2022-05-23 05:02:51.000000000","message":"Done","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"231f81b52e292db946081a23e42ac03daed73f85","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        self.retry_rollback_scale_out_common_test(True)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_fail_instantiate(self):"},{"line_number":146,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        * About attributes:"},{"line_number":149,"context_line":"          Omit except for required attributes."},{"line_number":150,"context_line":"          Only the following cardinality attributes are set."},{"line_number":151,"context_line":"          - 1"},{"line_number":152,"context_line":"          - 1..N (1)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        * About LCM operations:"},{"line_number":155,"context_line":"          This test includes the following operations."},{"line_number":156,"context_line":"          - 1. Create subscription"},{"line_number":157,"context_line":"          - 2. Test notification"},{"line_number":158,"context_line":"          - 3. Create VNF instance"},{"line_number":159,"context_line":"          - 4. Instantiate VNF(will fail)"},{"line_number":160,"context_line":"          - 5. Show VNF instance"},{"line_number":161,"context_line":"          - 6. Fail instantiation operation"},{"line_number":162,"context_line":"          - 7. Show VNF LCM operation occurrence"},{"line_number":163,"context_line":"          - 8. List VNF LCM operation occurrence"},{"line_number":164,"context_line":"          - 9. Delete VNF instance"},{"line_number":165,"context_line":"          - 10. Delete subscription"},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        self.fail_instantiate_common_test(True)"}],"source_content_type":"text/x-python","patch_set":14,"id":"53e992de_70d49440","line":166,"range":{"start_line":146,"start_character":0,"end_line":166,"end_character":11},"updated":"2022-05-18 07:01:33.000000000","message":"ditto","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"380334fa89d9307ad57e6dcd54f7d0192f95638e","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        self.retry_rollback_scale_out_common_test(True)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_fail_instantiate(self):"},{"line_number":146,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        * About attributes:"},{"line_number":149,"context_line":"          Omit except for required attributes."},{"line_number":150,"context_line":"          Only the following cardinality attributes are set."},{"line_number":151,"context_line":"          - 1"},{"line_number":152,"context_line":"          - 1..N (1)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        * About LCM operations:"},{"line_number":155,"context_line":"          This test includes the following operations."},{"line_number":156,"context_line":"          - 1. Create subscription"},{"line_number":157,"context_line":"          - 2. Test notification"},{"line_number":158,"context_line":"          - 3. Create VNF instance"},{"line_number":159,"context_line":"          - 4. Instantiate VNF(will fail)"},{"line_number":160,"context_line":"          - 5. Show VNF instance"},{"line_number":161,"context_line":"          - 6. Fail instantiation operation"},{"line_number":162,"context_line":"          - 7. Show VNF LCM operation occurrence"},{"line_number":163,"context_line":"          - 8. List VNF LCM operation occurrence"},{"line_number":164,"context_line":"          - 9. Delete VNF instance"},{"line_number":165,"context_line":"          - 10. Delete subscription"},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        self.fail_instantiate_common_test(True)"}],"source_content_type":"text/x-python","patch_set":14,"id":"e9ee3612_a1c3a396","line":166,"range":{"start_line":146,"start_character":0,"end_line":166,"end_character":11},"in_reply_to":"53e992de_70d49440","updated":"2022-05-19 01:39:46.000000000","message":"ditto","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9c97eb55880d8fdd079f513f600aecc40af55da5","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self.retry_rollback_scale_out_common_test(True)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_fail_instantiate(self):"},{"line_number":146,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        * About attributes:"},{"line_number":149,"context_line":"          Omit except for required attributes."},{"line_number":150,"context_line":"          Only the following cardinality attributes are set."},{"line_number":151,"context_line":"          - 1"},{"line_number":152,"context_line":"          - 1..N (1)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        * About LCM operations:"},{"line_number":155,"context_line":"          This test includes the following operations."},{"line_number":156,"context_line":"          - 1. Create subscription"},{"line_number":157,"context_line":"          - 2. Test notification"},{"line_number":158,"context_line":"          - 3. Create VNF instance"},{"line_number":159,"context_line":"          - 4. Instantiate VNF(will fail)"},{"line_number":160,"context_line":"          - 5. Show VNF instance"},{"line_number":161,"context_line":"          - 6. Fail instantiation operation"},{"line_number":162,"context_line":"          - 7. Show VNF LCM operation occurrence"},{"line_number":163,"context_line":"          - 8. List VNF LCM operation occurrence"},{"line_number":164,"context_line":"          - 9. Delete VNF instance"},{"line_number":165,"context_line":"          - 10. Delete subscription"},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        self.fail_instantiate_common_test(True)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5918417c_ed25cb6a","line":166,"range":{"start_line":146,"start_character":0,"end_line":166,"end_character":11},"in_reply_to":"e9ee3612_a1c3a396","updated":"2022-05-23 05:02:51.000000000","message":"Done","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"}],"tacker/tests/functional/sol_v2/test_vnflcm_basic.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":true,"context_lines":[{"line_number":172,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_basic_lcms_max(self):"},{"line_number":175,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            * About attributes:"},{"line_number":178,"context_line":"              All of the following cardinality attributes are set."},{"line_number":179,"context_line":"              In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":180,"context_line":"              0..1 is set to 1."},{"line_number":181,"context_line":"              - 0..1 (1)"},{"line_number":182,"context_line":"              - 0..N (2 or more)"},{"line_number":183,"context_line":"              - 1..N (2 or more)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            * About LCM operations:"},{"line_number":186,"context_line":"              This test includes the following operations."},{"line_number":187,"context_line":"              - 0. Pre-setting"},{"line_number":188,"context_line":"              - 1. Create subscription"},{"line_number":189,"context_line":"              - 2. Test notification"},{"line_number":190,"context_line":"              - 3. Show subscription"},{"line_number":191,"context_line":"              - 4. List subscriptions with attribute-based filtering"},{"line_number":192,"context_line":"              - 5. Create VNF instance"},{"line_number":193,"context_line":"              - 6. Instantiate VNF"},{"line_number":194,"context_line":"              - 7. Show VNF instance"},{"line_number":195,"context_line":"              - 8. List VNF instance with attribute-based filtering"},{"line_number":196,"context_line":"              - 9. Show VNF LCM operation occurrence"},{"line_number":197,"context_line":"              - 10. List VNF LCM operation occurrence with attribute-based"},{"line_number":198,"context_line":"                    filtering"},{"line_number":199,"context_line":"              - 11. Heal VNF(all with omit all parameter)"},{"line_number":200,"context_line":"              - 12. Heal VNF(all with all\u003dTrue parameter)"},{"line_number":201,"context_line":"              - 13. Scale out operation"},{"line_number":202,"context_line":"              - 14. Show VNF instance"},{"line_number":203,"context_line":"              - 15. Scale in operation"},{"line_number":204,"context_line":"              - 16. Show VNF instance"},{"line_number":205,"context_line":"              - 17. Heal VNF(vnfc)"},{"line_number":206,"context_line":"              - 18. Change external connectivity"},{"line_number":207,"context_line":"              - 19. Show VNF LCM operation occurrence"},{"line_number":208,"context_line":"              - 20. Heal VNF(vnfc with omit all parameter)"},{"line_number":209,"context_line":"              - 21. Heal VNF(vnfc with all\u003dFalse parameter)"},{"line_number":210,"context_line":"              - 22. Heal VNF(vnfc with all\u003dTrue parameter)"},{"line_number":211,"context_line":"              - 23. Update VNF"},{"line_number":212,"context_line":"              - 24. Show VNF instance"},{"line_number":213,"context_line":"              - 25. Terminate VNF"},{"line_number":214,"context_line":"              - 26. Delete VNF instance"},{"line_number":215,"context_line":"              - 27. Show VNF instance"},{"line_number":216,"context_line":"              - 28. Delete subscription"},{"line_number":217,"context_line":"              - 29. Show subscription"},{"line_number":218,"context_line":"            \"\"\""},{"line_number":219,"context_line":"        self.basic_lcms_max_common_test(False)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_basic_lcms_min(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"05a60879_e4e52275","line":218,"range":{"start_line":175,"start_character":8,"end_line":218,"end_character":15},"updated":"2022-04-21 04:08:01.000000000","message":"I think it is better to delete this description and describe it in \"test_vnflcm_basic_common.py\".","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"312cd2aa7bc6a6d39cefcf70f6c21c08c4f2e723","unresolved":true,"context_lines":[{"line_number":172,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_basic_lcms_max(self):"},{"line_number":175,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            * About attributes:"},{"line_number":178,"context_line":"              All of the following cardinality attributes are set."},{"line_number":179,"context_line":"              In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":180,"context_line":"              0..1 is set to 1."},{"line_number":181,"context_line":"              - 0..1 (1)"},{"line_number":182,"context_line":"              - 0..N (2 or more)"},{"line_number":183,"context_line":"              - 1..N (2 or more)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            * About LCM operations:"},{"line_number":186,"context_line":"              This test includes the following operations."},{"line_number":187,"context_line":"              - 0. Pre-setting"},{"line_number":188,"context_line":"              - 1. Create subscription"},{"line_number":189,"context_line":"              - 2. Test notification"},{"line_number":190,"context_line":"              - 3. Show subscription"},{"line_number":191,"context_line":"              - 4. List subscriptions with attribute-based filtering"},{"line_number":192,"context_line":"              - 5. Create VNF instance"},{"line_number":193,"context_line":"              - 6. Instantiate VNF"},{"line_number":194,"context_line":"              - 7. Show VNF instance"},{"line_number":195,"context_line":"              - 8. List VNF instance with attribute-based filtering"},{"line_number":196,"context_line":"              - 9. Show VNF LCM operation occurrence"},{"line_number":197,"context_line":"              - 10. List VNF LCM operation occurrence with attribute-based"},{"line_number":198,"context_line":"                    filtering"},{"line_number":199,"context_line":"              - 11. Heal VNF(all with omit all parameter)"},{"line_number":200,"context_line":"              - 12. Heal VNF(all with all\u003dTrue parameter)"},{"line_number":201,"context_line":"              - 13. Scale out operation"},{"line_number":202,"context_line":"              - 14. Show VNF instance"},{"line_number":203,"context_line":"              - 15. Scale in operation"},{"line_number":204,"context_line":"              - 16. Show VNF instance"},{"line_number":205,"context_line":"              - 17. Heal VNF(vnfc)"},{"line_number":206,"context_line":"              - 18. Change external connectivity"},{"line_number":207,"context_line":"              - 19. Show VNF LCM operation occurrence"},{"line_number":208,"context_line":"              - 20. Heal VNF(vnfc with omit all parameter)"},{"line_number":209,"context_line":"              - 21. Heal VNF(vnfc with all\u003dFalse parameter)"},{"line_number":210,"context_line":"              - 22. Heal VNF(vnfc with all\u003dTrue parameter)"},{"line_number":211,"context_line":"              - 23. Update VNF"},{"line_number":212,"context_line":"              - 24. Show VNF instance"},{"line_number":213,"context_line":"              - 25. Terminate VNF"},{"line_number":214,"context_line":"              - 26. Delete VNF instance"},{"line_number":215,"context_line":"              - 27. Show VNF instance"},{"line_number":216,"context_line":"              - 28. Delete subscription"},{"line_number":217,"context_line":"              - 29. Show subscription"},{"line_number":218,"context_line":"            \"\"\""},{"line_number":219,"context_line":"        self.basic_lcms_max_common_test(False)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_basic_lcms_min(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bca3972c_e575a5d5","line":218,"range":{"start_line":175,"start_character":8,"end_line":218,"end_character":15},"in_reply_to":"05a60879_e4e52275","updated":"2022-04-25 06:46:49.000000000","message":"I fixed it in PS11.","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e994024907f0b56a6e09f812526faa60f4e1e40","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_basic_lcms_max(self):"},{"line_number":175,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            * About attributes:"},{"line_number":178,"context_line":"              All of the following cardinality attributes are set."},{"line_number":179,"context_line":"              In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":180,"context_line":"              0..1 is set to 1."},{"line_number":181,"context_line":"              - 0..1 (1)"},{"line_number":182,"context_line":"              - 0..N (2 or more)"},{"line_number":183,"context_line":"              - 1..N (2 or more)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            * About LCM operations:"},{"line_number":186,"context_line":"              This test includes the following operations."},{"line_number":187,"context_line":"              - 0. Pre-setting"},{"line_number":188,"context_line":"              - 1. Create subscription"},{"line_number":189,"context_line":"              - 2. Test notification"},{"line_number":190,"context_line":"              - 3. Show subscription"},{"line_number":191,"context_line":"              - 4. List subscriptions with attribute-based filtering"},{"line_number":192,"context_line":"              - 5. Create VNF instance"},{"line_number":193,"context_line":"              - 6. Instantiate VNF"},{"line_number":194,"context_line":"              - 7. Show VNF instance"},{"line_number":195,"context_line":"              - 8. List VNF instance with attribute-based filtering"},{"line_number":196,"context_line":"              - 9. Show VNF LCM operation occurrence"},{"line_number":197,"context_line":"              - 10. List VNF LCM operation occurrence with attribute-based"},{"line_number":198,"context_line":"                    filtering"},{"line_number":199,"context_line":"              - 11. Heal VNF(all with omit all parameter)"},{"line_number":200,"context_line":"              - 12. Heal VNF(all with all\u003dTrue parameter)"},{"line_number":201,"context_line":"              - 13. Scale out operation"},{"line_number":202,"context_line":"              - 14. Show VNF instance"},{"line_number":203,"context_line":"              - 15. Scale in operation"},{"line_number":204,"context_line":"              - 16. Show VNF instance"},{"line_number":205,"context_line":"              - 17. Heal VNF(vnfc)"},{"line_number":206,"context_line":"              - 18. Change external connectivity"},{"line_number":207,"context_line":"              - 19. Show VNF LCM operation occurrence"},{"line_number":208,"context_line":"              - 20. Heal VNF(vnfc with omit all parameter)"},{"line_number":209,"context_line":"              - 21. Heal VNF(vnfc with all\u003dFalse parameter)"},{"line_number":210,"context_line":"              - 22. Heal VNF(vnfc with all\u003dTrue parameter)"},{"line_number":211,"context_line":"              - 23. Update VNF"},{"line_number":212,"context_line":"              - 24. Show VNF instance"},{"line_number":213,"context_line":"              - 25. Terminate VNF"},{"line_number":214,"context_line":"              - 26. Delete VNF instance"},{"line_number":215,"context_line":"              - 27. Show VNF instance"},{"line_number":216,"context_line":"              - 28. Delete subscription"},{"line_number":217,"context_line":"              - 29. Show subscription"},{"line_number":218,"context_line":"            \"\"\""},{"line_number":219,"context_line":"        self.basic_lcms_max_common_test(False)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_basic_lcms_min(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"783e177d_43a8439c","line":218,"range":{"start_line":175,"start_character":8,"end_line":218,"end_character":15},"in_reply_to":"bca3972c_e575a5d5","updated":"2022-04-27 00:29:43.000000000","message":"Done","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":true,"context_lines":[{"line_number":219,"context_line":"        self.basic_lcms_max_common_test(False)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_basic_lcms_min(self):"},{"line_number":222,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        The change_ext_conn can\u0027t be tested here because VNF package 2 don\u0027t"},{"line_number":225,"context_line":"        have external connectivity. So moved it to the test_scale_other_lcm()."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        * About attributes:"},{"line_number":228,"context_line":"          Omit except for required attributes."},{"line_number":229,"context_line":"          Only the following cardinality attributes are set."},{"line_number":230,"context_line":"          - 1"},{"line_number":231,"context_line":"          - 1..N (1)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        * About LCM operations:"},{"line_number":234,"context_line":"          This test includes the following operations."},{"line_number":235,"context_line":"          - 1. Create subscription"},{"line_number":236,"context_line":"          - 2. Test notification"},{"line_number":237,"context_line":"          - 3. Create VNF instance"},{"line_number":238,"context_line":"          - 4. Instantiate VNF"},{"line_number":239,"context_line":"          - 5. Show VNF instance"},{"line_number":240,"context_line":"          - 6. Heal VNF(all with omit all parameter)"},{"line_number":241,"context_line":"          - 7. Show VNF instance"},{"line_number":242,"context_line":"          - 8. Update VNF"},{"line_number":243,"context_line":"          - 9. Heal VNF(vnfc)"},{"line_number":244,"context_line":"          - 10. Show VNF instance"},{"line_number":245,"context_line":"          - 11. Scale out operation"},{"line_number":246,"context_line":"          - 12. Show VNF instance"},{"line_number":247,"context_line":"          - 13. Scale in operation"},{"line_number":248,"context_line":"          - 14. Terminate VNF"},{"line_number":249,"context_line":"          - 15. Delete VNF instance"},{"line_number":250,"context_line":"          - 16. Delete subscription"},{"line_number":251,"context_line":"          - 17. Show subscription"},{"line_number":252,"context_line":"        \"\"\""},{"line_number":253,"context_line":"        self.basic_lcms_min_common_test(False)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_update_scale_lcm(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"66258914_b3bc7d6a","line":252,"range":{"start_line":222,"start_character":8,"end_line":252,"end_character":11},"updated":"2022-04-21 04:08:01.000000000","message":"ditto","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e994024907f0b56a6e09f812526faa60f4e1e40","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        self.basic_lcms_max_common_test(False)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_basic_lcms_min(self):"},{"line_number":222,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        The change_ext_conn can\u0027t be tested here because VNF package 2 don\u0027t"},{"line_number":225,"context_line":"        have external connectivity. So moved it to the test_scale_other_lcm()."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        * About attributes:"},{"line_number":228,"context_line":"          Omit except for required attributes."},{"line_number":229,"context_line":"          Only the following cardinality attributes are set."},{"line_number":230,"context_line":"          - 1"},{"line_number":231,"context_line":"          - 1..N (1)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        * About LCM operations:"},{"line_number":234,"context_line":"          This test includes the following operations."},{"line_number":235,"context_line":"          - 1. Create subscription"},{"line_number":236,"context_line":"          - 2. Test notification"},{"line_number":237,"context_line":"          - 3. Create VNF instance"},{"line_number":238,"context_line":"          - 4. Instantiate VNF"},{"line_number":239,"context_line":"          - 5. Show VNF instance"},{"line_number":240,"context_line":"          - 6. Heal VNF(all with omit all parameter)"},{"line_number":241,"context_line":"          - 7. Show VNF instance"},{"line_number":242,"context_line":"          - 8. Update VNF"},{"line_number":243,"context_line":"          - 9. Heal VNF(vnfc)"},{"line_number":244,"context_line":"          - 10. Show VNF instance"},{"line_number":245,"context_line":"          - 11. Scale out operation"},{"line_number":246,"context_line":"          - 12. Show VNF instance"},{"line_number":247,"context_line":"          - 13. Scale in operation"},{"line_number":248,"context_line":"          - 14. Terminate VNF"},{"line_number":249,"context_line":"          - 15. Delete VNF instance"},{"line_number":250,"context_line":"          - 16. Delete subscription"},{"line_number":251,"context_line":"          - 17. Show subscription"},{"line_number":252,"context_line":"        \"\"\""},{"line_number":253,"context_line":"        self.basic_lcms_min_common_test(False)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_update_scale_lcm(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"434da248_d26f1753","line":252,"range":{"start_line":222,"start_character":8,"end_line":252,"end_character":11},"in_reply_to":"6525b19a_231f889a","updated":"2022-04-27 00:29:43.000000000","message":"Done","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"312cd2aa7bc6a6d39cefcf70f6c21c08c4f2e723","unresolved":true,"context_lines":[{"line_number":219,"context_line":"        self.basic_lcms_max_common_test(False)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_basic_lcms_min(self):"},{"line_number":222,"context_line":"        \"\"\"Test LCM operations with omitting except for required attributes"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        The change_ext_conn can\u0027t be tested here because VNF package 2 don\u0027t"},{"line_number":225,"context_line":"        have external connectivity. So moved it to the test_scale_other_lcm()."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        * About attributes:"},{"line_number":228,"context_line":"          Omit except for required attributes."},{"line_number":229,"context_line":"          Only the following cardinality attributes are set."},{"line_number":230,"context_line":"          - 1"},{"line_number":231,"context_line":"          - 1..N (1)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        * About LCM operations:"},{"line_number":234,"context_line":"          This test includes the following operations."},{"line_number":235,"context_line":"          - 1. Create subscription"},{"line_number":236,"context_line":"          - 2. Test notification"},{"line_number":237,"context_line":"          - 3. Create VNF instance"},{"line_number":238,"context_line":"          - 4. Instantiate VNF"},{"line_number":239,"context_line":"          - 5. Show VNF instance"},{"line_number":240,"context_line":"          - 6. Heal VNF(all with omit all parameter)"},{"line_number":241,"context_line":"          - 7. Show VNF instance"},{"line_number":242,"context_line":"          - 8. Update VNF"},{"line_number":243,"context_line":"          - 9. Heal VNF(vnfc)"},{"line_number":244,"context_line":"          - 10. Show VNF instance"},{"line_number":245,"context_line":"          - 11. Scale out operation"},{"line_number":246,"context_line":"          - 12. Show VNF instance"},{"line_number":247,"context_line":"          - 13. Scale in operation"},{"line_number":248,"context_line":"          - 14. Terminate VNF"},{"line_number":249,"context_line":"          - 15. Delete VNF instance"},{"line_number":250,"context_line":"          - 16. Delete subscription"},{"line_number":251,"context_line":"          - 17. Show subscription"},{"line_number":252,"context_line":"        \"\"\""},{"line_number":253,"context_line":"        self.basic_lcms_min_common_test(False)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_update_scale_lcm(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"6525b19a_231f889a","line":252,"range":{"start_line":222,"start_character":8,"end_line":252,"end_character":11},"in_reply_to":"66258914_b3bc7d6a","updated":"2022-04-25 06:46:49.000000000","message":"ditto","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"}],"tacker/tests/functional/sol_v2/test_vnflcm_error_handling.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        super().setUp()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":74,"context_line":"        \"\"\"Test retry and rollback scale out operations"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        * About attributes:"},{"line_number":77,"context_line":"          All of the following cardinality attributes are set."},{"line_number":78,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":79,"context_line":"          0..1 is set to 1."},{"line_number":80,"context_line":"          - 0..1 (1)"},{"line_number":81,"context_line":"          - 0..N (2 or more)"},{"line_number":82,"context_line":"          - 1..N (2 or more)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        * About LCM operations:"},{"line_number":85,"context_line":"          This test includes the following operations."},{"line_number":86,"context_line":"          - 0. Pre-setting"},{"line_number":87,"context_line":"          - 1. Create subscription"},{"line_number":88,"context_line":"          - 2. Test notification"},{"line_number":89,"context_line":"          - 3. Create VNF instance"},{"line_number":90,"context_line":"          - 4. Instantiate VNF"},{"line_number":91,"context_line":"          - 5. Show VNF instance"},{"line_number":92,"context_line":"          - 6. Scale out operation(will fail)"},{"line_number":93,"context_line":"          - 7. Show VNF instance"},{"line_number":94,"context_line":"          - 8. Retry operation"},{"line_number":95,"context_line":"          - 9. Rollback scale out operation"},{"line_number":96,"context_line":"          - 10. Show VNF LCM operation occurrence"},{"line_number":97,"context_line":"          - 11. List VNF LCM operation occurrence"},{"line_number":98,"context_line":"          - 12. Terminate VNF"},{"line_number":99,"context_line":"          - 13. Delete VNF instance"},{"line_number":100,"context_line":"          - 14. Delete subscription"},{"line_number":101,"context_line":"          - 15. Show subscription"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        self.retry_rollback_scale_out_common_test(False)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_rollback_instantiate(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"0a7faeec_0d7de416","line":102,"range":{"start_line":74,"start_character":8,"end_line":102,"end_character":11},"updated":"2022-04-21 04:08:01.000000000","message":"I think it is better to delete this description and describe it in \"test_vnflcm_basic_common.py\".","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"312cd2aa7bc6a6d39cefcf70f6c21c08c4f2e723","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        super().setUp()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":74,"context_line":"        \"\"\"Test retry and rollback scale out operations"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        * About attributes:"},{"line_number":77,"context_line":"          All of the following cardinality attributes are set."},{"line_number":78,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":79,"context_line":"          0..1 is set to 1."},{"line_number":80,"context_line":"          - 0..1 (1)"},{"line_number":81,"context_line":"          - 0..N (2 or more)"},{"line_number":82,"context_line":"          - 1..N (2 or more)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        * About LCM operations:"},{"line_number":85,"context_line":"          This test includes the following operations."},{"line_number":86,"context_line":"          - 0. Pre-setting"},{"line_number":87,"context_line":"          - 1. Create subscription"},{"line_number":88,"context_line":"          - 2. Test notification"},{"line_number":89,"context_line":"          - 3. Create VNF instance"},{"line_number":90,"context_line":"          - 4. Instantiate VNF"},{"line_number":91,"context_line":"          - 5. Show VNF instance"},{"line_number":92,"context_line":"          - 6. Scale out operation(will fail)"},{"line_number":93,"context_line":"          - 7. Show VNF instance"},{"line_number":94,"context_line":"          - 8. Retry operation"},{"line_number":95,"context_line":"          - 9. Rollback scale out operation"},{"line_number":96,"context_line":"          - 10. Show VNF LCM operation occurrence"},{"line_number":97,"context_line":"          - 11. List VNF LCM operation occurrence"},{"line_number":98,"context_line":"          - 12. Terminate VNF"},{"line_number":99,"context_line":"          - 13. Delete VNF instance"},{"line_number":100,"context_line":"          - 14. Delete subscription"},{"line_number":101,"context_line":"          - 15. Show subscription"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        self.retry_rollback_scale_out_common_test(False)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_rollback_instantiate(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"fbbc0dd3_cb65a6d4","line":102,"range":{"start_line":74,"start_character":8,"end_line":102,"end_character":11},"in_reply_to":"0a7faeec_0d7de416","updated":"2022-04-25 06:46:49.000000000","message":"ditto","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e994024907f0b56a6e09f812526faa60f4e1e40","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        super().setUp()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_retry_rollback_scale_out(self):"},{"line_number":74,"context_line":"        \"\"\"Test retry and rollback scale out operations"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        * About attributes:"},{"line_number":77,"context_line":"          All of the following cardinality attributes are set."},{"line_number":78,"context_line":"          In addition, 0..N or 1..N attributes are set to 2 or more."},{"line_number":79,"context_line":"          0..1 is set to 1."},{"line_number":80,"context_line":"          - 0..1 (1)"},{"line_number":81,"context_line":"          - 0..N (2 or more)"},{"line_number":82,"context_line":"          - 1..N (2 or more)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        * About LCM operations:"},{"line_number":85,"context_line":"          This test includes the following operations."},{"line_number":86,"context_line":"          - 0. Pre-setting"},{"line_number":87,"context_line":"          - 1. Create subscription"},{"line_number":88,"context_line":"          - 2. Test notification"},{"line_number":89,"context_line":"          - 3. Create VNF instance"},{"line_number":90,"context_line":"          - 4. Instantiate VNF"},{"line_number":91,"context_line":"          - 5. Show VNF instance"},{"line_number":92,"context_line":"          - 6. Scale out operation(will fail)"},{"line_number":93,"context_line":"          - 7. Show VNF instance"},{"line_number":94,"context_line":"          - 8. Retry operation"},{"line_number":95,"context_line":"          - 9. Rollback scale out operation"},{"line_number":96,"context_line":"          - 10. Show VNF LCM operation occurrence"},{"line_number":97,"context_line":"          - 11. List VNF LCM operation occurrence"},{"line_number":98,"context_line":"          - 12. Terminate VNF"},{"line_number":99,"context_line":"          - 13. Delete VNF instance"},{"line_number":100,"context_line":"          - 14. Delete subscription"},{"line_number":101,"context_line":"          - 15. Show subscription"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        self.retry_rollback_scale_out_common_test(False)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_rollback_instantiate(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"8a2c8167_8441df9b","line":102,"range":{"start_line":74,"start_character":8,"end_line":102,"end_character":11},"in_reply_to":"fbbc0dd3_cb65a6d4","updated":"2022-04-27 00:29:43.000000000","message":"Done","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":true,"context_lines":[{"line_number":278,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def test_fail_instantiate(self):"},{"line_number":281,"context_line":"        \"\"\"Test fail instantiate operation"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        * About attributes:"},{"line_number":284,"context_line":"          Omit except for required attributes."},{"line_number":285,"context_line":"          Only the following cardinality attributes are set."},{"line_number":286,"context_line":"          - 1"},{"line_number":287,"context_line":"          - 1..N (1)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        * About LCM operations:"},{"line_number":290,"context_line":"          This test includes the following operations."},{"line_number":291,"context_line":"          - 1. Create subscription"},{"line_number":292,"context_line":"          - 2. Test notification"},{"line_number":293,"context_line":"          - 3. Create VNF instance"},{"line_number":294,"context_line":"          - 4. Instantiate VNF(will fail)"},{"line_number":295,"context_line":"          - 5. Show VNF instance"},{"line_number":296,"context_line":"          - 6. Fail instantiation operation"},{"line_number":297,"context_line":"          - 7. Show VNF LCM operation occurrence"},{"line_number":298,"context_line":"          - 8. List VNF LCM operation occurrence"},{"line_number":299,"context_line":"          - 9. Delete VNF instance"},{"line_number":300,"context_line":"          - 10. Delete subscription"},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":"        self.fail_instantiate_common_test(False)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def test_rollback_update(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f616720_a02c6193","line":301,"range":{"start_line":281,"start_character":8,"end_line":301,"end_character":11},"updated":"2022-04-21 04:08:01.000000000","message":"ditto","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"312cd2aa7bc6a6d39cefcf70f6c21c08c4f2e723","unresolved":true,"context_lines":[{"line_number":278,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def test_fail_instantiate(self):"},{"line_number":281,"context_line":"        \"\"\"Test fail instantiate operation"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        * About attributes:"},{"line_number":284,"context_line":"          Omit except for required attributes."},{"line_number":285,"context_line":"          Only the following cardinality attributes are set."},{"line_number":286,"context_line":"          - 1"},{"line_number":287,"context_line":"          - 1..N (1)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        * About LCM operations:"},{"line_number":290,"context_line":"          This test includes the following operations."},{"line_number":291,"context_line":"          - 1. Create subscription"},{"line_number":292,"context_line":"          - 2. Test notification"},{"line_number":293,"context_line":"          - 3. Create VNF instance"},{"line_number":294,"context_line":"          - 4. Instantiate VNF(will fail)"},{"line_number":295,"context_line":"          - 5. Show VNF instance"},{"line_number":296,"context_line":"          - 6. Fail instantiation operation"},{"line_number":297,"context_line":"          - 7. Show VNF LCM operation occurrence"},{"line_number":298,"context_line":"          - 8. List VNF LCM operation occurrence"},{"line_number":299,"context_line":"          - 9. Delete VNF instance"},{"line_number":300,"context_line":"          - 10. Delete subscription"},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":"        self.fail_instantiate_common_test(False)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def test_rollback_update(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"a86df338_54e8b82b","line":301,"range":{"start_line":281,"start_character":8,"end_line":301,"end_character":11},"in_reply_to":"3f616720_a02c6193","updated":"2022-04-25 06:46:49.000000000","message":"ditto","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e994024907f0b56a6e09f812526faa60f4e1e40","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        self.check_resp_headers_in_delete(resp)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def test_fail_instantiate(self):"},{"line_number":281,"context_line":"        \"\"\"Test fail instantiate operation"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        * About attributes:"},{"line_number":284,"context_line":"          Omit except for required attributes."},{"line_number":285,"context_line":"          Only the following cardinality attributes are set."},{"line_number":286,"context_line":"          - 1"},{"line_number":287,"context_line":"          - 1..N (1)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        * About LCM operations:"},{"line_number":290,"context_line":"          This test includes the following operations."},{"line_number":291,"context_line":"          - 1. Create subscription"},{"line_number":292,"context_line":"          - 2. Test notification"},{"line_number":293,"context_line":"          - 3. Create VNF instance"},{"line_number":294,"context_line":"          - 4. Instantiate VNF(will fail)"},{"line_number":295,"context_line":"          - 5. Show VNF instance"},{"line_number":296,"context_line":"          - 6. Fail instantiation operation"},{"line_number":297,"context_line":"          - 7. Show VNF LCM operation occurrence"},{"line_number":298,"context_line":"          - 8. List VNF LCM operation occurrence"},{"line_number":299,"context_line":"          - 9. Delete VNF instance"},{"line_number":300,"context_line":"          - 10. Delete subscription"},{"line_number":301,"context_line":"        \"\"\""},{"line_number":302,"context_line":"        self.fail_instantiate_common_test(False)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def test_rollback_update(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"a512e4a1_90b451a0","line":301,"range":{"start_line":281,"start_character":8,"end_line":301,"end_character":11},"in_reply_to":"a86df338_54e8b82b","updated":"2022-04-27 00:29:43.000000000","message":"Done","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"}],"tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            content\u003dpackage_path"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def basic_lcms_max_common_test(self, is_nfvo):"},{"line_number":90,"context_line":"        # 0. Pre-setting"},{"line_number":91,"context_line":"        # nfvo-pre"},{"line_number":92,"context_line":"        if is_nfvo:"}],"source_content_type":"text/x-python","patch_set":9,"id":"77fd1244_dbca4f99","line":89,"updated":"2022-04-21 04:08:01.000000000","message":"How about setting the default argument \"is_nfvo\u003dFalse\"?\nThen you can omit the argument in the test under \"sol_v2\".","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e994024907f0b56a6e09f812526faa60f4e1e40","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            content\u003dpackage_path"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def basic_lcms_max_common_test(self, is_nfvo):"},{"line_number":90,"context_line":"        # 0. Pre-setting"},{"line_number":91,"context_line":"        # nfvo-pre"},{"line_number":92,"context_line":"        if is_nfvo:"}],"source_content_type":"text/x-python","patch_set":9,"id":"74786614_99c15fd3","line":89,"in_reply_to":"33c5d567_4b1e1710","updated":"2022-04-27 00:29:43.000000000","message":"Done","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"312cd2aa7bc6a6d39cefcf70f6c21c08c4f2e723","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            content\u003dpackage_path"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def basic_lcms_max_common_test(self, is_nfvo):"},{"line_number":90,"context_line":"        # 0. Pre-setting"},{"line_number":91,"context_line":"        # nfvo-pre"},{"line_number":92,"context_line":"        if is_nfvo:"}],"source_content_type":"text/x-python","patch_set":9,"id":"33c5d567_4b1e1710","line":89,"in_reply_to":"77fd1244_dbca4f99","updated":"2022-04-25 06:46:49.000000000","message":"I fixed it in PS11.","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":true,"context_lines":[{"line_number":325,"context_line":"        # because they are commented out in etsi_nfv_sol001."},{"line_number":326,"context_line":"        # * all_fields"},{"line_number":327,"context_line":"        #   -\u003e check the attribute omitted in \"exclude_default\" is set."},{"line_number":328,"context_line":"        if not is_nfvo:"},{"line_number":329,"context_line":"            filter_expr \u003d {\u0027filter\u0027: f\u0027(eq,id,{inst_id})\u0027, \u0027all_fields\u0027: \u0027\u0027}"},{"line_number":330,"context_line":"            resp, body \u003d self.list_vnf_instance(filter_expr)"},{"line_number":331,"context_line":"            self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":9,"id":"24248035_d52b12aa","line":328,"updated":"2022-04-21 04:08:01.000000000","message":"It branches according to the value of \"is_nfvo\", but unlike other places, I don\u0027t think it is a necessary branch.\nIf \"is_nfvo\u003dTrue\", there is no special confirmation point of view compared to \"is_nfvo\u003dFalse\", so it is omitted.\nI think the execution time of this process is short, so it\u0027s better to delete this branch for the purpose of simplification of the test.\nWhat do you think?","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"312cd2aa7bc6a6d39cefcf70f6c21c08c4f2e723","unresolved":true,"context_lines":[{"line_number":325,"context_line":"        # because they are commented out in etsi_nfv_sol001."},{"line_number":326,"context_line":"        # * all_fields"},{"line_number":327,"context_line":"        #   -\u003e check the attribute omitted in \"exclude_default\" is set."},{"line_number":328,"context_line":"        if not is_nfvo:"},{"line_number":329,"context_line":"            filter_expr \u003d {\u0027filter\u0027: f\u0027(eq,id,{inst_id})\u0027, \u0027all_fields\u0027: \u0027\u0027}"},{"line_number":330,"context_line":"            resp, body \u003d self.list_vnf_instance(filter_expr)"},{"line_number":331,"context_line":"            self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":9,"id":"325006dd_96a22a67","line":328,"in_reply_to":"24248035_d52b12aa","updated":"2022-04-25 06:46:49.000000000","message":"I fixed it in PS11.","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e994024907f0b56a6e09f812526faa60f4e1e40","unresolved":false,"context_lines":[{"line_number":325,"context_line":"        # because they are commented out in etsi_nfv_sol001."},{"line_number":326,"context_line":"        # * all_fields"},{"line_number":327,"context_line":"        #   -\u003e check the attribute omitted in \"exclude_default\" is set."},{"line_number":328,"context_line":"        if not is_nfvo:"},{"line_number":329,"context_line":"            filter_expr \u003d {\u0027filter\u0027: f\u0027(eq,id,{inst_id})\u0027, \u0027all_fields\u0027: \u0027\u0027}"},{"line_number":330,"context_line":"            resp, body \u003d self.list_vnf_instance(filter_expr)"},{"line_number":331,"context_line":"            self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":9,"id":"92b932c2_12ac3c18","line":328,"in_reply_to":"325006dd_96a22a67","updated":"2022-04-27 00:29:43.000000000","message":"Done","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":true,"context_lines":[{"line_number":410,"context_line":"        # because these values are not supported at that time"},{"line_number":411,"context_line":"        # * all_fields"},{"line_number":412,"context_line":"        #   -\u003e check the attribute omitted in \"exclude_default\" is set."},{"line_number":413,"context_line":"        if not is_nfvo:"},{"line_number":414,"context_line":"            filter_expr \u003d {\u0027filter\u0027: f\u0027(eq,id,{lcmocc_id})\u0027, \u0027all_fields\u0027: \u0027\u0027}"},{"line_number":415,"context_line":"            resp, body \u003d self.list_lcmocc(filter_expr)"},{"line_number":416,"context_line":"            self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":9,"id":"a1aa34b8_807b295e","line":413,"updated":"2022-04-21 04:08:01.000000000","message":"ditto","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"312cd2aa7bc6a6d39cefcf70f6c21c08c4f2e723","unresolved":true,"context_lines":[{"line_number":410,"context_line":"        # because these values are not supported at that time"},{"line_number":411,"context_line":"        # * all_fields"},{"line_number":412,"context_line":"        #   -\u003e check the attribute omitted in \"exclude_default\" is set."},{"line_number":413,"context_line":"        if not is_nfvo:"},{"line_number":414,"context_line":"            filter_expr \u003d {\u0027filter\u0027: f\u0027(eq,id,{lcmocc_id})\u0027, \u0027all_fields\u0027: \u0027\u0027}"},{"line_number":415,"context_line":"            resp, body \u003d self.list_lcmocc(filter_expr)"},{"line_number":416,"context_line":"            self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":9,"id":"d22c9689_e2856d53","line":413,"in_reply_to":"a1aa34b8_807b295e","updated":"2022-04-25 06:46:49.000000000","message":"I fixed it in PS11.","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e994024907f0b56a6e09f812526faa60f4e1e40","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        # because these values are not supported at that time"},{"line_number":411,"context_line":"        # * all_fields"},{"line_number":412,"context_line":"        #   -\u003e check the attribute omitted in \"exclude_default\" is set."},{"line_number":413,"context_line":"        if not is_nfvo:"},{"line_number":414,"context_line":"            filter_expr \u003d {\u0027filter\u0027: f\u0027(eq,id,{lcmocc_id})\u0027, \u0027all_fields\u0027: \u0027\u0027}"},{"line_number":415,"context_line":"            resp, body \u003d self.list_lcmocc(filter_expr)"},{"line_number":416,"context_line":"            self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":9,"id":"08e0434b_ed832440","line":413,"in_reply_to":"d22c9689_e2856d53","updated":"2022-04-27 00:29:43.000000000","message":"Done","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f466c965ddbafa37f856d6e99f15f35ade33f363","unresolved":true,"context_lines":[{"line_number":1182,"context_line":"                image_ids)"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"    def basic_lcms_min_common_test(self, is_nfvo):"},{"line_number":1185,"context_line":"        # 0. Pre setting"},{"line_number":1186,"context_line":"        if is_nfvo:"},{"line_number":1187,"context_line":"            cur_dir \u003d os.path.dirname(__file__)"},{"line_number":1188,"context_line":"            # for basic lcms tests min pattern"}],"source_content_type":"text/x-python","patch_set":9,"id":"4e985288_429695ba","line":1185,"updated":"2022-04-21 04:08:01.000000000","message":"There are many if branches based on the value of \"is_nfvo\", which makes readability worse.\nIt\u0027s better to move the process to \"Pre setting\" whenever possible, as shown below.\n```\ndiff --git a/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py b/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py\nindex 2e6f2d82..106c3c60 100644\n--- a/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py\n+++ b/tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py\n@@ -1205,6 +1205,67 @@ class CommonVnfLcmTest(base_v2.BaseSolV2Test):\n                 basic_lcms_min_path, vnfd_path)\n             zone_name_list \u003d self.get_zone_list()\n\n+            # Set Fake server response for Grant-Req(Instantiate)\n+            base_v2.FAKE_SERVER_MANAGER.set_callback(\u0027POST\u0027,\n+                fake_grant_v2.GrantV2.GRANT_REQ_PATH,\n+                status_code\u003d201,\n+                response_headers\u003d{\"Content-Type\": \"application/json\"},\n+                callback\u003dlambda req_headers,\n+                req_body: fake_grant_v2.GrantV2.make_inst_response_body(\n+                    req_body, glance_image, flavour_vdu_dict, zone_name_list))\n...snip...\n+            # Set Fake server response for Grant-Req(Terminate)\n+            base_v2.FAKE_SERVER_MANAGER.set_callback(\u0027POST\u0027,\n+                fake_grant_v2.GrantV2.GRANT_REQ_PATH,\n+                status_code\u003d201,\n+                response_headers\u003d{\"Content-Type\": \"application/json\"},\n+                callback\u003dlambda req_headers,\n+                req_body: fake_grant_v2.GrantV2.make_term_response_body(\n+                    req_body))\n+\n+            # create requests\n+            create_req \u003d paramgen.create_vnf_min(vnfd_id_1)\n+            update_req \u003d paramgen.update_vnf_min_with_parameter(vnfd_id_2)\n+        else:\n+            # create requests\n+            create_req \u003d paramgen.create_vnf_min(self.vnfd_id_2)\n+            update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_3)\n+\n         # 1. Create subscription\n         callback_url \u003d os.path.join(base_v2.MOCK_NOTIFY_CALLBACK_URL,\n                                     self._testMethodName)\n```","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"312cd2aa7bc6a6d39cefcf70f6c21c08c4f2e723","unresolved":true,"context_lines":[{"line_number":1182,"context_line":"                image_ids)"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"    def basic_lcms_min_common_test(self, is_nfvo):"},{"line_number":1185,"context_line":"        # 0. Pre setting"},{"line_number":1186,"context_line":"        if is_nfvo:"},{"line_number":1187,"context_line":"            cur_dir \u003d os.path.dirname(__file__)"},{"line_number":1188,"context_line":"            # for basic lcms tests min pattern"}],"source_content_type":"text/x-python","patch_set":9,"id":"52fdf8e4_1b3d9998","line":1185,"in_reply_to":"4e985288_429695ba","updated":"2022-04-25 06:46:49.000000000","message":"I put the processing of the branches that can be put into the pre into the `pre`. For some branches, they must be processed in the middle of the lifecycle, and they are not put into the pre. In order to enhance readability, I extracted some processing out of common methods and reduced the if branch in the main function.","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5e994024907f0b56a6e09f812526faa60f4e1e40","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"                image_ids)"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"    def basic_lcms_min_common_test(self, is_nfvo):"},{"line_number":1185,"context_line":"        # 0. Pre setting"},{"line_number":1186,"context_line":"        if is_nfvo:"},{"line_number":1187,"context_line":"            cur_dir \u003d os.path.dirname(__file__)"},{"line_number":1188,"context_line":"            # for basic lcms tests min pattern"}],"source_content_type":"text/x-python","patch_set":9,"id":"4edd322d_9218edb6","line":1185,"in_reply_to":"52fdf8e4_1b3d9998","updated":"2022-04-27 00:29:43.000000000","message":"Done","commit_id":"3e7a5834c29d7a920d4dde327e65514abd618e43"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"231f81b52e292db946081a23e42ac03daed73f85","unresolved":true,"context_lines":[{"line_number":182,"context_line":"              - 10. List VNF LCM operation occurrence with attribute-based"},{"line_number":183,"context_line":"                    filtering"},{"line_number":184,"context_line":"              - 11. Heal VNF(all with omit all parameter)"},{"line_number":185,"context_line":"              - 12. Heal VNF(all with all\u003dTrue parameter)"},{"line_number":186,"context_line":"              - 13. Scale out operation"},{"line_number":187,"context_line":"              - 14. Show VNF instance"},{"line_number":188,"context_line":"              - 15. Scale in operation"}],"source_content_type":"text/x-python","patch_set":14,"id":"4f874147_981ce48a","line":185,"range":{"start_line":185,"start_character":42,"end_line":185,"end_character":46},"updated":"2022-05-18 07:01:33.000000000","message":"\"true\" is better.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9c97eb55880d8fdd079f513f600aecc40af55da5","unresolved":false,"context_lines":[{"line_number":182,"context_line":"              - 10. List VNF LCM operation occurrence with attribute-based"},{"line_number":183,"context_line":"                    filtering"},{"line_number":184,"context_line":"              - 11. Heal VNF(all with omit all parameter)"},{"line_number":185,"context_line":"              - 12. Heal VNF(all with all\u003dTrue parameter)"},{"line_number":186,"context_line":"              - 13. Scale out operation"},{"line_number":187,"context_line":"              - 14. Show VNF instance"},{"line_number":188,"context_line":"              - 15. Scale in operation"}],"source_content_type":"text/x-python","patch_set":14,"id":"5103d155_f83adde0","line":185,"range":{"start_line":185,"start_character":42,"end_line":185,"end_character":46},"in_reply_to":"39b32c42_0aff12bb","updated":"2022-05-23 05:02:51.000000000","message":"Done","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"380334fa89d9307ad57e6dcd54f7d0192f95638e","unresolved":true,"context_lines":[{"line_number":182,"context_line":"              - 10. List VNF LCM operation occurrence with attribute-based"},{"line_number":183,"context_line":"                    filtering"},{"line_number":184,"context_line":"              - 11. Heal VNF(all with omit all parameter)"},{"line_number":185,"context_line":"              - 12. Heal VNF(all with all\u003dTrue parameter)"},{"line_number":186,"context_line":"              - 13. Scale out operation"},{"line_number":187,"context_line":"              - 14. Show VNF instance"},{"line_number":188,"context_line":"              - 15. Scale in operation"}],"source_content_type":"text/x-python","patch_set":14,"id":"39b32c42_0aff12bb","line":185,"range":{"start_line":185,"start_character":42,"end_line":185,"end_character":46},"in_reply_to":"4f874147_981ce48a","updated":"2022-05-19 01:39:46.000000000","message":"I fixed it in PS15.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"231f81b52e292db946081a23e42ac03daed73f85","unresolved":true,"context_lines":[{"line_number":191,"context_line":"              - 18. Change external connectivity"},{"line_number":192,"context_line":"              - 19. Show VNF LCM operation occurrence"},{"line_number":193,"context_line":"              - 20. Heal VNF(vnfc with omit all parameter)"},{"line_number":194,"context_line":"              - 21. Heal VNF(vnfc with all\u003dFalse parameter)"},{"line_number":195,"context_line":"              - 22. Heal VNF(vnfc with all\u003dTrue parameter)"},{"line_number":196,"context_line":"              - 23. Update VNF"},{"line_number":197,"context_line":"              - 24. Show VNF instance"}],"source_content_type":"text/x-python","patch_set":14,"id":"01887502_cd3b4d4e","line":194,"range":{"start_line":194,"start_character":43,"end_line":194,"end_character":48},"updated":"2022-05-18 07:01:33.000000000","message":"\"false\" is better.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"380334fa89d9307ad57e6dcd54f7d0192f95638e","unresolved":true,"context_lines":[{"line_number":191,"context_line":"              - 18. Change external connectivity"},{"line_number":192,"context_line":"              - 19. Show VNF LCM operation occurrence"},{"line_number":193,"context_line":"              - 20. Heal VNF(vnfc with omit all parameter)"},{"line_number":194,"context_line":"              - 21. Heal VNF(vnfc with all\u003dFalse parameter)"},{"line_number":195,"context_line":"              - 22. Heal VNF(vnfc with all\u003dTrue parameter)"},{"line_number":196,"context_line":"              - 23. Update VNF"},{"line_number":197,"context_line":"              - 24. Show VNF instance"}],"source_content_type":"text/x-python","patch_set":14,"id":"6d233709_eac4efde","line":194,"range":{"start_line":194,"start_character":43,"end_line":194,"end_character":48},"in_reply_to":"01887502_cd3b4d4e","updated":"2022-05-19 01:39:46.000000000","message":"I fixed it in PS15.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9c97eb55880d8fdd079f513f600aecc40af55da5","unresolved":false,"context_lines":[{"line_number":191,"context_line":"              - 18. Change external connectivity"},{"line_number":192,"context_line":"              - 19. Show VNF LCM operation occurrence"},{"line_number":193,"context_line":"              - 20. Heal VNF(vnfc with omit all parameter)"},{"line_number":194,"context_line":"              - 21. Heal VNF(vnfc with all\u003dFalse parameter)"},{"line_number":195,"context_line":"              - 22. Heal VNF(vnfc with all\u003dTrue parameter)"},{"line_number":196,"context_line":"              - 23. Update VNF"},{"line_number":197,"context_line":"              - 24. Show VNF instance"}],"source_content_type":"text/x-python","patch_set":14,"id":"2370649a_67c4efa5","line":194,"range":{"start_line":194,"start_character":43,"end_line":194,"end_character":48},"in_reply_to":"6d233709_eac4efde","updated":"2022-05-23 05:02:51.000000000","message":"Done","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"231f81b52e292db946081a23e42ac03daed73f85","unresolved":true,"context_lines":[{"line_number":192,"context_line":"              - 19. Show VNF LCM operation occurrence"},{"line_number":193,"context_line":"              - 20. Heal VNF(vnfc with omit all parameter)"},{"line_number":194,"context_line":"              - 21. Heal VNF(vnfc with all\u003dFalse parameter)"},{"line_number":195,"context_line":"              - 22. Heal VNF(vnfc with all\u003dTrue parameter)"},{"line_number":196,"context_line":"              - 23. Update VNF"},{"line_number":197,"context_line":"              - 24. Show VNF instance"},{"line_number":198,"context_line":"              - 25. Terminate VNF"}],"source_content_type":"text/x-python","patch_set":14,"id":"1c2403d8_f000d501","line":195,"range":{"start_line":195,"start_character":43,"end_line":195,"end_character":47},"updated":"2022-05-18 07:01:33.000000000","message":"\"true\" is better.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"380334fa89d9307ad57e6dcd54f7d0192f95638e","unresolved":true,"context_lines":[{"line_number":192,"context_line":"              - 19. Show VNF LCM operation occurrence"},{"line_number":193,"context_line":"              - 20. Heal VNF(vnfc with omit all parameter)"},{"line_number":194,"context_line":"              - 21. Heal VNF(vnfc with all\u003dFalse parameter)"},{"line_number":195,"context_line":"              - 22. Heal VNF(vnfc with all\u003dTrue parameter)"},{"line_number":196,"context_line":"              - 23. Update VNF"},{"line_number":197,"context_line":"              - 24. Show VNF instance"},{"line_number":198,"context_line":"              - 25. Terminate VNF"}],"source_content_type":"text/x-python","patch_set":14,"id":"3235f024_5fab87de","line":195,"range":{"start_line":195,"start_character":43,"end_line":195,"end_character":47},"in_reply_to":"1c2403d8_f000d501","updated":"2022-05-19 01:39:46.000000000","message":"I fixed it in PS15.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9c97eb55880d8fdd079f513f600aecc40af55da5","unresolved":false,"context_lines":[{"line_number":192,"context_line":"              - 19. Show VNF LCM operation occurrence"},{"line_number":193,"context_line":"              - 20. Heal VNF(vnfc with omit all parameter)"},{"line_number":194,"context_line":"              - 21. Heal VNF(vnfc with all\u003dFalse parameter)"},{"line_number":195,"context_line":"              - 22. Heal VNF(vnfc with all\u003dTrue parameter)"},{"line_number":196,"context_line":"              - 23. Update VNF"},{"line_number":197,"context_line":"              - 24. Show VNF instance"},{"line_number":198,"context_line":"              - 25. Terminate VNF"}],"source_content_type":"text/x-python","patch_set":14,"id":"c693bad2_789ecdd0","line":195,"range":{"start_line":195,"start_character":43,"end_line":195,"end_character":47},"in_reply_to":"3235f024_5fab87de","updated":"2022-05-23 05:02:51.000000000","message":"Done","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"231f81b52e292db946081a23e42ac03daed73f85","unresolved":true,"context_lines":[{"line_number":1614,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":1615,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"    def change_vnfpkg_from_image_to_volume_common_test(self, is_nfvo\u003dFalse):"},{"line_number":1618,"context_line":"        if is_nfvo:"},{"line_number":1619,"context_line":"            cur_dir \u003d os.path.dirname(__file__)"},{"line_number":1620,"context_line":"            change_vnfpkg_from_image_to_image_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":14,"id":"68cb4197_5839051f","line":1617,"updated":"2022-05-18 07:01:33.000000000","message":"Would you please add a comment about attributes, operations, etc. like other tests?","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"99e8ed7d3d15061365ca0135c754f058c9f1c2d1","unresolved":true,"context_lines":[{"line_number":1614,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":1615,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"    def change_vnfpkg_from_image_to_volume_common_test(self, is_nfvo\u003dFalse):"},{"line_number":1618,"context_line":"        if is_nfvo:"},{"line_number":1619,"context_line":"            cur_dir \u003d os.path.dirname(__file__)"},{"line_number":1620,"context_line":"            change_vnfpkg_from_image_to_image_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":14,"id":"a0aaf8e2_a453ba67","line":1617,"in_reply_to":"2ed5367d_37a2c6cd","updated":"2022-05-24 02:54:41.000000000","message":"I fixed it in PS16.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"380334fa89d9307ad57e6dcd54f7d0192f95638e","unresolved":true,"context_lines":[{"line_number":1614,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":1615,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"    def change_vnfpkg_from_image_to_volume_common_test(self, is_nfvo\u003dFalse):"},{"line_number":1618,"context_line":"        if is_nfvo:"},{"line_number":1619,"context_line":"            cur_dir \u003d os.path.dirname(__file__)"},{"line_number":1620,"context_line":"            change_vnfpkg_from_image_to_image_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":14,"id":"a542d286_b89466b7","line":1617,"in_reply_to":"68cb4197_5839051f","updated":"2022-05-19 01:39:46.000000000","message":"I added this comments in PS15.","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"c6f4edcd83e1a7d1b74bbe22088db43c2ced2965","unresolved":false,"context_lines":[{"line_number":1614,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":1615,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"    def change_vnfpkg_from_image_to_volume_common_test(self, is_nfvo\u003dFalse):"},{"line_number":1618,"context_line":"        if is_nfvo:"},{"line_number":1619,"context_line":"            cur_dir \u003d os.path.dirname(__file__)"},{"line_number":1620,"context_line":"            change_vnfpkg_from_image_to_image_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":14,"id":"1b7070ec_6503db14","line":1617,"in_reply_to":"a0aaf8e2_a453ba67","updated":"2022-05-27 02:54:32.000000000","message":"Done","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"9c97eb55880d8fdd079f513f600aecc40af55da5","unresolved":true,"context_lines":[{"line_number":1614,"context_line":"        resp, body \u003d self.show_subscription(sub_id)"},{"line_number":1615,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"    def change_vnfpkg_from_image_to_volume_common_test(self, is_nfvo\u003dFalse):"},{"line_number":1618,"context_line":"        if is_nfvo:"},{"line_number":1619,"context_line":"            cur_dir \u003d os.path.dirname(__file__)"},{"line_number":1620,"context_line":"            change_vnfpkg_from_image_to_image_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":14,"id":"2ed5367d_37a2c6cd","line":1617,"in_reply_to":"a542d286_b89466b7","updated":"2022-05-23 05:02:51.000000000","message":"It is better to match the writing style with other comments.\n* Create a new VNF instance resource -\u003e Create VNF instance (L.177)\n* Instantiate a VNF instance -\u003e Instantiate VNF (L.178)\n* Terminate a VNF instance -\u003e Terminate VNF (L.198)\n* Delete a VNF instance -\u003e Delete VNF instance (L.199)","commit_id":"00389ac09d2f41a212fa8a6feb9c0148f896c908"}]}