)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":20,"context_line":"There are the following points to note."},{"line_number":21,"context_line":"    1. Currently only \u0027RollingUpdate\u0027 is supported for"},{"line_number":22,"context_line":"    CNF deployment update."},{"line_number":23,"context_line":"    2. \u0027Instantiate\u0027 VNF cannot rollback and retry with \u0027Kubernetes\u0027 vim."},{"line_number":24,"context_line":"    It will be supported in future."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Implements: blueprint upgrade-vnf-package"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"630eec80_61bbe00e","line":23,"updated":"2022-03-09 17:57:02.000000000","message":"Could you follow guideline of commit message?\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n```\nSubsequent lines should be wrapped at 72 characters.\n```","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":20,"context_line":"There are the following points to note."},{"line_number":21,"context_line":"    1. Currently only \u0027RollingUpdate\u0027 is supported for"},{"line_number":22,"context_line":"    CNF deployment update."},{"line_number":23,"context_line":"    2. \u0027Instantiate\u0027 VNF cannot rollback and retry with \u0027Kubernetes\u0027 vim."},{"line_number":24,"context_line":"    It will be supported in future."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Implements: blueprint upgrade-vnf-package"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"d56d5d91_baed30ef","line":23,"in_reply_to":"02279c83_acdb940b","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":20,"context_line":"There are the following points to note."},{"line_number":21,"context_line":"    1. Currently only \u0027RollingUpdate\u0027 is supported for"},{"line_number":22,"context_line":"    CNF deployment update."},{"line_number":23,"context_line":"    2. \u0027Instantiate\u0027 VNF cannot rollback and retry with \u0027Kubernetes\u0027 vim."},{"line_number":24,"context_line":"    It will be supported in future."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Implements: blueprint upgrade-vnf-package"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"02279c83_acdb940b","line":23,"in_reply_to":"630eec80_61bbe00e","updated":"2022-03-10 14:07:44.000000000","message":"I fixed it in PS9.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"8658f1bd0094564c3899ee0de9b542ec8ece4225","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6832b057_46f15039","updated":"2022-03-09 06:27:22.000000000","message":"recheck","commit_id":"98f39f8df2d4bb9573d972892f5fb20b2c88867b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"77fc326d2fdf218b39a59dfebef6626bcb3be034","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"767db39f_4b1bf176","updated":"2022-03-09 08:59:44.000000000","message":"recheck","commit_id":"98f39f8df2d4bb9573d972892f5fb20b2c88867b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e76c5413cf72f052a3b2bf56a54e9980b6508d21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b9019ded_e1490bb7","updated":"2022-03-09 04:47:46.000000000","message":"recheck","commit_id":"98f39f8df2d4bb9573d972892f5fb20b2c88867b"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"cd014d8baf24072282810611a56dfe57ae44ab45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5f7206ca_99949416","updated":"2022-03-09 23:45:31.000000000","message":"Thank you for your patch. I’m still confirming, but I\u0027ll make a low priority comment.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2d641ba0_f0451453","updated":"2022-03-09 17:57:02.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"12a45ef3_fbc52e90","updated":"2022-03-10 14:07:44.000000000","message":"To Ayumu Ueha, Naoaki Horie:\nThank you for your comments. I fixed them in PS9.\nPlease kindly check them again.","commit_id":"864b241ee49c8d6f07e17b95b9cd44118709d981"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d0a7c5f6_9e7e8c4b","updated":"2022-03-11 07:14:33.000000000","message":"Thank you for your patch. Could you check my comments?","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"b0a8d3eaac0d1a495d05935696d3149507afad3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6c6642fc_4eedb0c0","updated":"2022-03-11 08:28:05.000000000","message":"Thank you for your work.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"95cf380a_5fbfc017","updated":"2022-03-11 08:59:57.000000000","message":"To Masaki UENO, Hirofumi Noguchi:\nThank you for your comments. I fixed them in PS12 and PS13.\nPlease kindly check them again.","commit_id":"0fa0aa04271fdfd537d7251ec1e47472ad205665"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7231ae14_6607707c","updated":"2022-03-17 07:25:14.000000000","message":"Thank you for your rework! Please check my replies for further discussion.","commit_id":"c9efb243164c8ae4cacdd2c3c116d46658479ded"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5fc7cdcd60c31481ba1e591149eaefd748a3aa82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"02653765_a9006eba","updated":"2022-03-16 06:38:31.000000000","message":"recheck","commit_id":"c9efb243164c8ae4cacdd2c3c116d46658479ded"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59b294db65c71a516d34c10b0c4b656c4d89e15f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2aa400cc_7bdafaf9","updated":"2022-03-16 09:11:45.000000000","message":"recheck","commit_id":"c9efb243164c8ae4cacdd2c3c116d46658479ded"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c21b70ccdbe078555f1a767b0dc085a97cdf2d84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"983beaaa_20da0a74","updated":"2022-03-16 04:11:42.000000000","message":"recheck","commit_id":"c9efb243164c8ae4cacdd2c3c116d46658479ded"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"dc6725f948756aa95dbb94f5f8c9e5e336bae5d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"0adb7d3e_2cad8f0e","updated":"2022-03-17 10:52:22.000000000","message":"LGTM","commit_id":"df0f8fc6bd119a97a73659cb56d8f9f4bbd098db"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"2d0f21530288261517e1c2f78e3f0efa8a87c724","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"43024302_db53cbae","updated":"2022-03-17 10:48:28.000000000","message":"Thank you for your rework. LGTM!","commit_id":"df0f8fc6bd119a97a73659cb56d8f9f4bbd098db"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"2f7f9a0393127256a0e832e04f3a4597032ba41b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5a4c43fe_36a47179","updated":"2022-03-17 10:55:16.000000000","message":"Thank you for your work.","commit_id":"df0f8fc6bd119a97a73659cb56d8f9f4bbd098db"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bb20c95e3cec49b1a649e8b88f68b9b28db73a46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"afcd1476_eecb399a","updated":"2022-03-17 07:49:29.000000000","message":"To Masaki UENO:\nThank you for your comment. I fixed it in PS16.\nPlease kindly check it again.","commit_id":"df0f8fc6bd119a97a73659cb56d8f9f4bbd098db"}],"tacker/sol_refactored/common/exceptions.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":289,"context_line":"    message \u003d _(\"An error occurred when creating k8s resource.\")"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"class ReadEndpoindsFalse(SolHttpError400):"},{"line_number":293,"context_line":"    message \u003d _(\"read endpoints failed. kind:\u0027%(kind)s\u0027.\")"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"713fce30_8466d321","line":292,"range":{"start_line":292,"start_character":10,"end_line":292,"end_character":19},"updated":"2022-03-09 17:57:02.000000000","message":"typo: Endpoints","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":289,"context_line":"    message \u003d _(\"An error occurred when creating k8s resource.\")"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"class ReadEndpoindsFalse(SolHttpError400):"},{"line_number":293,"context_line":"    message \u003d _(\"read endpoints failed. kind:\u0027%(kind)s\u0027.\")"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9fd744b6_4aea18cf","line":292,"range":{"start_line":292,"start_character":10,"end_line":292,"end_character":19},"in_reply_to":"713fce30_8466d321","updated":"2022-03-10 14:07:44.000000000","message":"I fixed it in PS9.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    message \u003d _(\"An error occurred when creating k8s resource.\")"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"class ReadEndpoindsFalse(SolHttpError400):"},{"line_number":293,"context_line":"    message \u003d _(\"read endpoints failed. kind:\u0027%(kind)s\u0027.\")"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"676811bc_3029e03f","line":292,"range":{"start_line":292,"start_character":10,"end_line":292,"end_character":19},"in_reply_to":"9fd744b6_4aea18cf","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":305,"context_line":"class UnSupportedKindException(SolHttpError400):"},{"line_number":306,"context_line":"    message \u003d _(\"The update file \u0027%(new_file_path)s\u0027 does not contain\""},{"line_number":307,"context_line":"                \" \u0027Deployment\u0027 resource and other types of updates are not\""},{"line_number":308,"context_line":"                \"currently supported.\")"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"class NotFoundUpdateFileException(SolHttpError400):"}],"source_content_type":"text/x-python","patch_set":8,"id":"218be85d_8be44bcb","line":308,"range":{"start_line":308,"start_character":16,"end_line":308,"end_character":17},"updated":"2022-03-09 17:57:02.000000000","message":"do you need a white space after \"?","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":305,"context_line":"class UnSupportedKindException(SolHttpError400):"},{"line_number":306,"context_line":"    message \u003d _(\"The update file \u0027%(new_file_path)s\u0027 does not contain\""},{"line_number":307,"context_line":"                \" \u0027Deployment\u0027 resource and other types of updates are not\""},{"line_number":308,"context_line":"                \"currently supported.\")"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"class NotFoundUpdateFileException(SolHttpError400):"}],"source_content_type":"text/x-python","patch_set":8,"id":"82755272_95e83096","line":308,"range":{"start_line":308,"start_character":16,"end_line":308,"end_character":17},"in_reply_to":"218be85d_8be44bcb","updated":"2022-03-10 14:07:44.000000000","message":"I fixed it in PS9.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":305,"context_line":"class UnSupportedKindException(SolHttpError400):"},{"line_number":306,"context_line":"    message \u003d _(\"The update file \u0027%(new_file_path)s\u0027 does not contain\""},{"line_number":307,"context_line":"                \" \u0027Deployment\u0027 resource and other types of updates are not\""},{"line_number":308,"context_line":"                \"currently supported.\")"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"class NotFoundUpdateFileException(SolHttpError400):"}],"source_content_type":"text/x-python","patch_set":8,"id":"18218c70_435da56c","line":308,"range":{"start_line":308,"start_character":16,"end_line":308,"end_character":17},"in_reply_to":"82755272_95e83096","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"class MissingParameterException(SolHttpError400):"},{"line_number":317,"context_line":"    message \u003d _(\"If you set vdu_params parameter in request body,\""},{"line_number":318,"context_line":"                \"the \u0027vdu_id\u0027 is necessary.\")"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"class UpdateK8SResourceFailed(SolHttpError400):"}],"source_content_type":"text/x-python","patch_set":8,"id":"0da2e097_0e12dc42","line":318,"range":{"start_line":318,"start_character":16,"end_line":318,"end_character":17},"updated":"2022-03-09 17:57:02.000000000","message":"do you need a white space after \"?","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"class MissingParameterException(SolHttpError400):"},{"line_number":317,"context_line":"    message \u003d _(\"If you set vdu_params parameter in request body,\""},{"line_number":318,"context_line":"                \"the \u0027vdu_id\u0027 is necessary.\")"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"class UpdateK8SResourceFailed(SolHttpError400):"}],"source_content_type":"text/x-python","patch_set":8,"id":"d45b73dc_274449fd","line":318,"range":{"start_line":318,"start_character":16,"end_line":318,"end_character":17},"in_reply_to":"0da2e097_0e12dc42","updated":"2022-03-10 14:07:44.000000000","message":"I fixed it in PS9.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"class MissingParameterException(SolHttpError400):"},{"line_number":317,"context_line":"    message \u003d _(\"If you set vdu_params parameter in request body,\""},{"line_number":318,"context_line":"                \"the \u0027vdu_id\u0027 is necessary.\")"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"class UpdateK8SResourceFailed(SolHttpError400):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fc422109_39306f59","line":318,"range":{"start_line":318,"start_character":16,"end_line":318,"end_character":17},"in_reply_to":"d45b73dc_274449fd","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"}],"tacker/sol_refactored/common/vim_utils.py":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            interfaceInfo\u003dinterface_info,"},{"line_number":76,"context_line":"            accessInfo\u003daccess_info"},{"line_number":77,"context_line":"        )"},{"line_number":78,"context_line":"    elif vim[\u0027vim_type\u0027] \u003d\u003d \"kubernetes\":  # k8s"},{"line_number":79,"context_line":"        if vim_auth[\u0027username\u0027] and vim_auth[\u0027password\u0027]:"},{"line_number":80,"context_line":"            access_info \u003d {"},{"line_number":81,"context_line":"                \u0027username\u0027: vim_auth[\u0027username\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"90c9dc5a_4400aa46","line":78,"updated":"2022-03-11 07:14:33.000000000","message":"This `elif` can be replaced with `if`, because the above `if` statement has `return`.","commit_id":"8f7f154aede0cceacc1fbcdff7651d4d37a42bff"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            interfaceInfo\u003dinterface_info,"},{"line_number":76,"context_line":"            accessInfo\u003daccess_info"},{"line_number":77,"context_line":"        )"},{"line_number":78,"context_line":"    elif vim[\u0027vim_type\u0027] \u003d\u003d \"kubernetes\":  # k8s"},{"line_number":79,"context_line":"        if vim_auth[\u0027username\u0027] and vim_auth[\u0027password\u0027]:"},{"line_number":80,"context_line":"            access_info \u003d {"},{"line_number":81,"context_line":"                \u0027username\u0027: vim_auth[\u0027username\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"f404626f_e1551287","line":78,"in_reply_to":"90c9dc5a_4400aa46","updated":"2022-03-11 08:59:57.000000000","message":"I fixed it in PS12.","commit_id":"8f7f154aede0cceacc1fbcdff7651d4d37a42bff"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            interfaceInfo\u003dinterface_info,"},{"line_number":76,"context_line":"            accessInfo\u003daccess_info"},{"line_number":77,"context_line":"        )"},{"line_number":78,"context_line":"    elif vim[\u0027vim_type\u0027] \u003d\u003d \"kubernetes\":  # k8s"},{"line_number":79,"context_line":"        if vim_auth[\u0027username\u0027] and vim_auth[\u0027password\u0027]:"},{"line_number":80,"context_line":"            access_info \u003d {"},{"line_number":81,"context_line":"                \u0027username\u0027: vim_auth[\u0027username\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"44634e04_6c2278b5","line":78,"in_reply_to":"f404626f_e1551287","updated":"2022-03-17 07:25:14.000000000","message":"Done","commit_id":"8f7f154aede0cceacc1fbcdff7651d4d37a42bff"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            interfaceInfo\u003dinterface_info,"},{"line_number":99,"context_line":"            accessInfo\u003daccess_info"},{"line_number":100,"context_line":"        )"},{"line_number":101,"context_line":"    else:"},{"line_number":102,"context_line":"        raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"531d06f1_3419b91f","line":101,"updated":"2022-03-11 07:14:33.000000000","message":"With the above comment, this `else` clause can be removed.","commit_id":"8f7f154aede0cceacc1fbcdff7651d4d37a42bff"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            interfaceInfo\u003dinterface_info,"},{"line_number":99,"context_line":"            accessInfo\u003daccess_info"},{"line_number":100,"context_line":"        )"},{"line_number":101,"context_line":"    else:"},{"line_number":102,"context_line":"        raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9e871d4d_80590259","line":101,"in_reply_to":"0acee1d0_f96478e9","updated":"2022-03-17 07:25:14.000000000","message":"Done","commit_id":"8f7f154aede0cceacc1fbcdff7651d4d37a42bff"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            interfaceInfo\u003dinterface_info,"},{"line_number":99,"context_line":"            accessInfo\u003daccess_info"},{"line_number":100,"context_line":"        )"},{"line_number":101,"context_line":"    else:"},{"line_number":102,"context_line":"        raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"0acee1d0_f96478e9","line":101,"in_reply_to":"531d06f1_3419b91f","updated":"2022-03-11 08:59:57.000000000","message":"I fixed it in PS12.","commit_id":"8f7f154aede0cceacc1fbcdff7651d4d37a42bff"}],"tacker/sol_refactored/common/vnfd_utils.py":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"b0a8d3eaac0d1a495d05935696d3149507afad3c","unresolved":true,"context_lines":[{"line_number":455,"context_line":"        mani_artifact_files.extend(meta_artifacts_files)"},{"line_number":456,"context_line":"        return mani_artifact_files"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def get_update_deployment_names_and_namespace(self, req, inst):"},{"line_number":459,"context_line":"        vdu_nodes \u003d self.get_vdu_nodes("},{"line_number":460,"context_line":"            flavour_id\u003dinst.instantiatedVnfInfo.flavourId)"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"4405cf10_9b8850d5","line":458,"updated":"2022-03-11 08:28:05.000000000","message":"IMO. This function includes processing only for Kubernetes, I think VNFD class should include only vim-independent processing.\nAlso, the function in VNFD class should be only for reading VNFD. However, this function deals with request and vnfinstance.\nHow about moving this function to the file under infra_driver/kubernets.\nWould you please share your opinion?","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"40a15f519243fee0a0b17156e32ee03ed5af55d8","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        mani_artifact_files.extend(meta_artifacts_files)"},{"line_number":456,"context_line":"        return mani_artifact_files"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def get_update_deployment_names_and_namespace(self, req, inst):"},{"line_number":459,"context_line":"        vdu_nodes \u003d self.get_vdu_nodes("},{"line_number":460,"context_line":"            flavour_id\u003dinst.instantiatedVnfInfo.flavourId)"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"b267027b_5a1574a1","line":458,"in_reply_to":"426c6bbe_318d6621","updated":"2022-03-14 09:41:22.000000000","message":"Thank you for fixing it.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":455,"context_line":"        mani_artifact_files.extend(meta_artifacts_files)"},{"line_number":456,"context_line":"        return mani_artifact_files"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def get_update_deployment_names_and_namespace(self, req, inst):"},{"line_number":459,"context_line":"        vdu_nodes \u003d self.get_vdu_nodes("},{"line_number":460,"context_line":"            flavour_id\u003dinst.instantiatedVnfInfo.flavourId)"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"426c6bbe_318d6621","line":458,"in_reply_to":"4405cf10_9b8850d5","updated":"2022-03-11 08:59:57.000000000","message":"I think you\u0027re right. I fixed it in PS13.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"}],"tacker/sol_refactored/conductor/conductor_v2.py":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"cd014d8baf24072282810611a56dfe57ae44ab45","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            lcmocc.update(context)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        # send notification COMPLETED or FAILED_TEMP"},{"line_number":166,"context_line":"        self.nfvo_client.send_lcmocc_notification(context, lcmocc, inst,"},{"line_number":167,"context_line":"                                                  self.endpoint)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @log.log"},{"line_number":170,"context_line":"    def retry_lcm_op(self, context, lcmocc_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"c8fadbbb_6421d7ae","line":167,"range":{"start_line":166,"start_character":8,"end_line":167,"end_character":64},"updated":"2022-03-09 23:45:31.000000000","message":"When terminate VNF operation, for kubernetes vim, the following ERROR message appears in the Tacker log because the glance image does not exist in the VNF instance.\n```\nGet glance images for vnfInstance a1bf7ed9-2526-44c0-8e18-fff101625a9d failed.\n```\nRefer to [1] or [2].\n\nIt would be preferable if the ERROR message did not appear, however I think this comment is of low priority.\n\n[1] https://github.com/openstack/tacker/blob/master/tacker/sol_refactored/nfvo/local_nfvo.py#L315\n[2] https://github.com/openstack/tacker/blob/master/tacker/sol_refactored/nfvo/local_nfvo.py#L281-L296","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"2f7f9a0393127256a0e832e04f3a4597032ba41b","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            lcmocc.update(context)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        # send notification COMPLETED or FAILED_TEMP"},{"line_number":166,"context_line":"        self.nfvo_client.send_lcmocc_notification(context, lcmocc, inst,"},{"line_number":167,"context_line":"                                                  self.endpoint)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @log.log"},{"line_number":170,"context_line":"    def retry_lcm_op(self, context, lcmocc_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"b800a6ee_e0632fe4","line":167,"range":{"start_line":166,"start_character":8,"end_line":167,"end_character":64},"in_reply_to":"27d273d2_2e4b0e36","updated":"2022-03-17 10:55:16.000000000","message":"I have confirmed with PatchSet 16 that ERROR message is not output in the Tracker log.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            lcmocc.update(context)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        # send notification COMPLETED or FAILED_TEMP"},{"line_number":166,"context_line":"        self.nfvo_client.send_lcmocc_notification(context, lcmocc, inst,"},{"line_number":167,"context_line":"                                                  self.endpoint)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @log.log"},{"line_number":170,"context_line":"    def retry_lcm_op(self, context, lcmocc_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"27d273d2_2e4b0e36","line":167,"range":{"start_line":166,"start_character":8,"end_line":167,"end_character":64},"in_reply_to":"c8fadbbb_6421d7ae","updated":"2022-03-10 14:07:44.000000000","message":"I fixed it in PS9.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"}],"tacker/sol_refactored/conductor/vnflcm_driver_v2.py":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            driver.instantiate(req, inst, grant_req, grant, vnfd)"},{"line_number":415,"context_line":"        else:"},{"line_number":416,"context_line":"            # should not occur"},{"line_number":417,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        inst.instantiationState \u003d \u0027INSTANTIATED\u0027"},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"a204100e_f5e4bb54","line":417,"updated":"2022-03-11 07:14:33.000000000","message":"nits: (sol_detail\u003d\u0027not supported vim type\u0027)","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            driver.instantiate(req, inst, grant_req, grant, vnfd)"},{"line_number":415,"context_line":"        else:"},{"line_number":416,"context_line":"            # should not occur"},{"line_number":417,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        inst.instantiationState \u003d \u0027INSTANTIATED\u0027"},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"d6161aaa_82b17f67","line":417,"in_reply_to":"a204100e_f5e4bb54","updated":"2022-03-11 08:59:57.000000000","message":"The current existing codes are all like this, and I have not modified the message. Therefore, in order to be consistent with other codes, I will not fix it.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            driver.instantiate(req, inst, grant_req, grant, vnfd)"},{"line_number":415,"context_line":"        else:"},{"line_number":416,"context_line":"            # should not occur"},{"line_number":417,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        inst.instantiationState \u003d \u0027INSTANTIATED\u0027"},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"2e072d03_577a1e0c","line":417,"in_reply_to":"d6161aaa_82b17f67","updated":"2022-03-17 07:25:14.000000000","message":"I see. That\u0027s OK.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":true,"context_lines":[{"line_number":569,"context_line":"            driver.terminate(req, inst, grant_req, grant, vnfd)"},{"line_number":570,"context_line":"        else:"},{"line_number":571,"context_line":"            # should not occur"},{"line_number":572,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        inst.instantiationState \u003d \u0027NOT_INSTANTIATED\u0027"},{"line_number":575,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"6e709948_956b8f4f","line":572,"updated":"2022-03-11 07:14:33.000000000","message":"ditto","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":false,"context_lines":[{"line_number":569,"context_line":"            driver.terminate(req, inst, grant_req, grant, vnfd)"},{"line_number":570,"context_line":"        else:"},{"line_number":571,"context_line":"            # should not occur"},{"line_number":572,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        inst.instantiationState \u003d \u0027NOT_INSTANTIATED\u0027"},{"line_number":575,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"d6adbc34_3c2d391a","line":572,"in_reply_to":"03e60441_0ae85001","updated":"2022-03-17 07:25:14.000000000","message":"ditto","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":569,"context_line":"            driver.terminate(req, inst, grant_req, grant, vnfd)"},{"line_number":570,"context_line":"        else:"},{"line_number":571,"context_line":"            # should not occur"},{"line_number":572,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        inst.instantiationState \u003d \u0027NOT_INSTANTIATED\u0027"},{"line_number":575,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"03e60441_0ae85001","line":572,"in_reply_to":"6e709948_956b8f4f","updated":"2022-03-11 08:59:57.000000000","message":"ditto","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes.py":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        if not lcmocc.obj_attr_is_set(\u0027resourceChanges\u0027):"},{"line_number":157,"context_line":"            return"},{"line_number":158,"context_line":"        if req.additionalParams.get(\u0027upgrade_type\u0027) \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":159,"context_line":"            deployment_names \u003d list(set(["},{"line_number":160,"context_line":"                affected_vnfc.metadata[\u0027Deployment\u0027][\u0027name\u0027] for affected_vnfc"},{"line_number":161,"context_line":"                in lcmocc.resourceChanges.affectedVnfcs if"},{"line_number":162,"context_line":"                affected_vnfc.changeType \u003d\u003d \u0027ADDED\u0027]))"},{"line_number":163,"context_line":"            namespace \u003d inst.metadata.get(\u0027namespace\u0027)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            old_deploy_reses \u003d kubernetes_utils.get_new_deployment_body("}],"source_content_type":"text/x-python","patch_set":11,"id":"af82851b_d8ba5873","line":162,"range":{"start_line":159,"start_character":36,"end_line":162,"end_character":53},"updated":"2022-03-11 07:14:33.000000000","message":"`set()` can be replaced with set comprehension:\n\n```\n            deployment_names \u003d list({\n                affected_vnfc.metadata[\u0027Deployment\u0027][\u0027name\u0027] for affected_vnfc\n                in lcmocc.resourceChanges.affectedVnfcs if\n                affected_vnfc.changeType \u003d\u003d \u0027ADDED\u0027})\n```","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        if not lcmocc.obj_attr_is_set(\u0027resourceChanges\u0027):"},{"line_number":157,"context_line":"            return"},{"line_number":158,"context_line":"        if req.additionalParams.get(\u0027upgrade_type\u0027) \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":159,"context_line":"            deployment_names \u003d list(set(["},{"line_number":160,"context_line":"                affected_vnfc.metadata[\u0027Deployment\u0027][\u0027name\u0027] for affected_vnfc"},{"line_number":161,"context_line":"                in lcmocc.resourceChanges.affectedVnfcs if"},{"line_number":162,"context_line":"                affected_vnfc.changeType \u003d\u003d \u0027ADDED\u0027]))"},{"line_number":163,"context_line":"            namespace \u003d inst.metadata.get(\u0027namespace\u0027)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            old_deploy_reses \u003d kubernetes_utils.get_new_deployment_body("}],"source_content_type":"text/x-python","patch_set":11,"id":"bf734215_f8be3b8f","line":162,"range":{"start_line":159,"start_character":36,"end_line":162,"end_character":53},"in_reply_to":"af82851b_d8ba5873","updated":"2022-03-11 08:59:57.000000000","message":"I fixed it in PS12.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        if not lcmocc.obj_attr_is_set(\u0027resourceChanges\u0027):"},{"line_number":157,"context_line":"            return"},{"line_number":158,"context_line":"        if req.additionalParams.get(\u0027upgrade_type\u0027) \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":159,"context_line":"            deployment_names \u003d list(set(["},{"line_number":160,"context_line":"                affected_vnfc.metadata[\u0027Deployment\u0027][\u0027name\u0027] for affected_vnfc"},{"line_number":161,"context_line":"                in lcmocc.resourceChanges.affectedVnfcs if"},{"line_number":162,"context_line":"                affected_vnfc.changeType \u003d\u003d \u0027ADDED\u0027]))"},{"line_number":163,"context_line":"            namespace \u003d inst.metadata.get(\u0027namespace\u0027)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            old_deploy_reses \u003d kubernetes_utils.get_new_deployment_body("}],"source_content_type":"text/x-python","patch_set":11,"id":"124615e6_b6bd5f86","line":162,"range":{"start_line":159,"start_character":36,"end_line":162,"end_character":53},"in_reply_to":"bf734215_f8be3b8f","updated":"2022-03-17 07:25:14.000000000","message":"Done","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":true,"context_lines":[{"line_number":288,"context_line":"                }"},{"line_number":289,"context_line":"            }"},{"line_number":290,"context_line":"            script_path \u003d os.path.join(tmp_csar_dir, coordinate_vnf)"},{"line_number":291,"context_line":"            out \u003d subprocess.run([\"python3\", script_path],"},{"line_number":292,"context_line":"                input\u003dpickle.dumps(script_dict),"},{"line_number":293,"context_line":"                stdout\u003dsubprocess.PIPE, stderr\u003dsubprocess.PIPE)"},{"line_number":294,"context_line":"            if out.returncode !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf859009_ad0e29c6","line":291,"updated":"2022-03-11 07:14:33.000000000","message":"I recommend to explicitly specify `check\u003d` parameter for `subprocess.run`.\nIn this context, it will be `check\u003dFalse`, which means the executed subprocess will not raise exceptions even if the result code is other than 0.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":288,"context_line":"                }"},{"line_number":289,"context_line":"            }"},{"line_number":290,"context_line":"            script_path \u003d os.path.join(tmp_csar_dir, coordinate_vnf)"},{"line_number":291,"context_line":"            out \u003d subprocess.run([\"python3\", script_path],"},{"line_number":292,"context_line":"                input\u003dpickle.dumps(script_dict),"},{"line_number":293,"context_line":"                stdout\u003dsubprocess.PIPE, stderr\u003dsubprocess.PIPE)"},{"line_number":294,"context_line":"            if out.returncode !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":11,"id":"c3326e9f_0dcc507f","line":291,"in_reply_to":"bf859009_ad0e29c6","updated":"2022-03-11 08:59:57.000000000","message":"I know the `check\u003dFalse` content is the default parameter, so it doesn\u0027t need to be set. In addition, this part refers to the existing code, in order to ensure consistency, it will not be modified here.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                }"},{"line_number":289,"context_line":"            }"},{"line_number":290,"context_line":"            script_path \u003d os.path.join(tmp_csar_dir, coordinate_vnf)"},{"line_number":291,"context_line":"            out \u003d subprocess.run([\"python3\", script_path],"},{"line_number":292,"context_line":"                input\u003dpickle.dumps(script_dict),"},{"line_number":293,"context_line":"                stdout\u003dsubprocess.PIPE, stderr\u003dsubprocess.PIPE)"},{"line_number":294,"context_line":"            if out.returncode !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":11,"id":"d3a29c7a_0fa1c768","line":291,"in_reply_to":"c3326e9f_0dcc507f","updated":"2022-03-17 07:25:14.000000000","message":"OK, that\u0027s good.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_utils.py":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":true,"context_lines":[{"line_number":205,"context_line":"            except Exception:"},{"line_number":206,"context_line":"                LOG.error(f\u0027update resource failed. kind: {kind},\u0027"},{"line_number":207,"context_line":"                          f\u0027 name: {name}\u0027)"},{"line_number":208,"context_line":"                raise sol_ex.UpdateK8SResourceFailed"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def list_namespaced_pods(self, namespace):"},{"line_number":211,"context_line":"        if namespace is None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"02324918_7e16b87f","line":208,"updated":"2022-03-11 07:14:33.000000000","message":"`raise ... from ...` would improve stack trace for debugging.\n\n```\n            except Exception as e:\n                LOG.error(f\u0027update resource failed. kind: {kind},\u0027\n                          f\u0027 name: {name}\u0027)\n                raise sol_ex.UpdateK8SResourceFailed from e\n```","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":205,"context_line":"            except Exception:"},{"line_number":206,"context_line":"                LOG.error(f\u0027update resource failed. kind: {kind},\u0027"},{"line_number":207,"context_line":"                          f\u0027 name: {name}\u0027)"},{"line_number":208,"context_line":"                raise sol_ex.UpdateK8SResourceFailed"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def list_namespaced_pods(self, namespace):"},{"line_number":211,"context_line":"        if namespace is None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"db7937b2_b1dac96f","line":208,"in_reply_to":"02324918_7e16b87f","updated":"2022-03-11 08:59:57.000000000","message":"I fixed it in PS12.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            except Exception:"},{"line_number":206,"context_line":"                LOG.error(f\u0027update resource failed. kind: {kind},\u0027"},{"line_number":207,"context_line":"                          f\u0027 name: {name}\u0027)"},{"line_number":208,"context_line":"                raise sol_ex.UpdateK8SResourceFailed"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def list_namespaced_pods(self, namespace):"},{"line_number":211,"context_line":"        if namespace is None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"84114852_475ac65e","line":208,"in_reply_to":"db7937b2_b1dac96f","updated":"2022-03-17 07:25:14.000000000","message":"Done","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":true,"context_lines":[{"line_number":397,"context_line":"                if endpoint:"},{"line_number":398,"context_line":"                    status_flag \u003d True"},{"line_number":399,"context_line":"            except Exception:"},{"line_number":400,"context_line":"                raise sol_ex.ReadEndpointsFalse("},{"line_number":401,"context_line":"                    kind\u003dk8s_res.get(\u0027kind\u0027))"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if status_flag:"}],"source_content_type":"text/x-python","patch_set":11,"id":"e588a194_2a5e1d97","line":400,"updated":"2022-03-11 07:14:33.000000000","message":"ditto","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                if endpoint:"},{"line_number":398,"context_line":"                    status_flag \u003d True"},{"line_number":399,"context_line":"            except Exception:"},{"line_number":400,"context_line":"                raise sol_ex.ReadEndpointsFalse("},{"line_number":401,"context_line":"                    kind\u003dk8s_res.get(\u0027kind\u0027))"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if status_flag:"}],"source_content_type":"text/x-python","patch_set":11,"id":"ada25068_e7903a6f","line":400,"in_reply_to":"1a41f820_5c1aac4b","updated":"2022-03-17 07:25:14.000000000","message":"Done","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":397,"context_line":"                if endpoint:"},{"line_number":398,"context_line":"                    status_flag \u003d True"},{"line_number":399,"context_line":"            except Exception:"},{"line_number":400,"context_line":"                raise sol_ex.ReadEndpointsFalse("},{"line_number":401,"context_line":"                    kind\u003dk8s_res.get(\u0027kind\u0027))"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if status_flag:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a41f820_5c1aac4b","line":400,"in_reply_to":"e588a194_2a5e1d97","updated":"2022-03-11 08:59:57.000000000","message":"ditto","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":true,"context_lines":[{"line_number":636,"context_line":"def get_k8s_json_file(req, inst, target_k8s_files, vnfd, operation):"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _update_k8s_resources(namespace):"},{"line_number":639,"context_line":"        [k8s_res.update(metadata\u003d{}) for k8s_res in"},{"line_number":640,"context_line":"         k8s_resources if k8s_res.get(\u0027kind\u0027, \u0027\u0027) in SUPPORTED_NAMESPACE_KINDS"},{"line_number":641,"context_line":"         and k8s_res.get(\u0027metadata\u0027) is None]"},{"line_number":642,"context_line":"        [k8s_res[\u0027metadata\u0027].update(namespace\u003dnamespace)"},{"line_number":643,"context_line":"         for k8s_res in k8s_resources if k8s_res.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":644,"context_line":"         in SUPPORTED_NAMESPACE_KINDS]"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    k8s_resources \u003d []"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"c9ea4b51_fcf8fb71","line":644,"range":{"start_line":639,"start_character":0,"end_line":644,"end_character":38},"updated":"2022-03-11 07:14:33.000000000","message":"Those comprehensions are not assigned to variables, could you explain the mean of them?","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bb20c95e3cec49b1a649e8b88f68b9b28db73a46","unresolved":true,"context_lines":[{"line_number":636,"context_line":"def get_k8s_json_file(req, inst, target_k8s_files, vnfd, operation):"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _update_k8s_resources(namespace):"},{"line_number":639,"context_line":"        [k8s_res.update(metadata\u003d{}) for k8s_res in"},{"line_number":640,"context_line":"         k8s_resources if k8s_res.get(\u0027kind\u0027, \u0027\u0027) in SUPPORTED_NAMESPACE_KINDS"},{"line_number":641,"context_line":"         and k8s_res.get(\u0027metadata\u0027) is None]"},{"line_number":642,"context_line":"        [k8s_res[\u0027metadata\u0027].update(namespace\u003dnamespace)"},{"line_number":643,"context_line":"         for k8s_res in k8s_resources if k8s_res.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":644,"context_line":"         in SUPPORTED_NAMESPACE_KINDS]"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    k8s_resources \u003d []"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5044a888_2230e489","line":644,"range":{"start_line":639,"start_character":0,"end_line":644,"end_character":38},"in_reply_to":"3b07c5d7_a3bdca4d","updated":"2022-03-17 07:49:29.000000000","message":"I fixed it in PS16.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":true,"context_lines":[{"line_number":636,"context_line":"def get_k8s_json_file(req, inst, target_k8s_files, vnfd, operation):"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _update_k8s_resources(namespace):"},{"line_number":639,"context_line":"        [k8s_res.update(metadata\u003d{}) for k8s_res in"},{"line_number":640,"context_line":"         k8s_resources if k8s_res.get(\u0027kind\u0027, \u0027\u0027) in SUPPORTED_NAMESPACE_KINDS"},{"line_number":641,"context_line":"         and k8s_res.get(\u0027metadata\u0027) is None]"},{"line_number":642,"context_line":"        [k8s_res[\u0027metadata\u0027].update(namespace\u003dnamespace)"},{"line_number":643,"context_line":"         for k8s_res in k8s_resources if k8s_res.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":644,"context_line":"         in SUPPORTED_NAMESPACE_KINDS]"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    k8s_resources \u003d []"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3b07c5d7_a3bdca4d","line":644,"range":{"start_line":639,"start_character":0,"end_line":644,"end_character":38},"in_reply_to":"42a6840c_f519b0c7","updated":"2022-03-17 07:25:14.000000000","message":"Thanks. So in this context, I think the below will be equivalent, and strongly recommend not to use unassigned comprehension for preventing confusion:\n\n```\n        for k8s_res in k8s_resources:\n            if (k8s_res.get(\u0027kind\u0027, \u0027\u0027) in SUPPORTED_NAMESPACE_KINDS and\n                k8s_res.get(\u0027metadata\u0027) is None):\n                k8s_res.update(metadata\u003d{})\n            if k8s_res.get(\u0027kind\u0027, \u0027\u0027) in SUPPORTED_NAMESPACE_KINDS:\n                k8s_res[\u0027metadata\u0027].update(namespace\u003dnamespace)\n```","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"2d0f21530288261517e1c2f78e3f0efa8a87c724","unresolved":false,"context_lines":[{"line_number":636,"context_line":"def get_k8s_json_file(req, inst, target_k8s_files, vnfd, operation):"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _update_k8s_resources(namespace):"},{"line_number":639,"context_line":"        [k8s_res.update(metadata\u003d{}) for k8s_res in"},{"line_number":640,"context_line":"         k8s_resources if k8s_res.get(\u0027kind\u0027, \u0027\u0027) in SUPPORTED_NAMESPACE_KINDS"},{"line_number":641,"context_line":"         and k8s_res.get(\u0027metadata\u0027) is None]"},{"line_number":642,"context_line":"        [k8s_res[\u0027metadata\u0027].update(namespace\u003dnamespace)"},{"line_number":643,"context_line":"         for k8s_res in k8s_resources if k8s_res.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":644,"context_line":"         in SUPPORTED_NAMESPACE_KINDS]"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    k8s_resources \u003d []"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"398b951d_aa0265d8","line":644,"range":{"start_line":639,"start_character":0,"end_line":644,"end_character":38},"in_reply_to":"5044a888_2230e489","updated":"2022-03-17 10:48:28.000000000","message":"Done","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":636,"context_line":"def get_k8s_json_file(req, inst, target_k8s_files, vnfd, operation):"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"    def _update_k8s_resources(namespace):"},{"line_number":639,"context_line":"        [k8s_res.update(metadata\u003d{}) for k8s_res in"},{"line_number":640,"context_line":"         k8s_resources if k8s_res.get(\u0027kind\u0027, \u0027\u0027) in SUPPORTED_NAMESPACE_KINDS"},{"line_number":641,"context_line":"         and k8s_res.get(\u0027metadata\u0027) is None]"},{"line_number":642,"context_line":"        [k8s_res[\u0027metadata\u0027].update(namespace\u003dnamespace)"},{"line_number":643,"context_line":"         for k8s_res in k8s_resources if k8s_res.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":644,"context_line":"         in SUPPORTED_NAMESPACE_KINDS]"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"    k8s_resources \u003d []"},{"line_number":647,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"42a6840c_f519b0c7","line":644,"range":{"start_line":639,"start_character":0,"end_line":644,"end_character":38},"in_reply_to":"c9ea4b51_fcf8fb71","updated":"2022-03-11 08:59:57.000000000","message":"I have made a test. So I\u0027m sure these codes will update k8s_resources\u0027s metadata information.\nFor example:\nif k8s_resources \u003d [{\"kind\": \"Deployment\"}],\nAfter the first block statement is executed, it will become\nk8s_resources \u003d [{\"kind\": \"Deployment\", \"metadata\": {}}]\nand if we set namespace\u003d\u0027curry\u0027,\nafter the seconde block statement is executed, it will become\nk8s_resources \u003d [{\"kind\": \"Deployment\", \"metadata\": {\"namespace\": \"curry\"}}]\n\nThen I set the namespace to the k8s_resource.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"}],"tacker/sol_refactored/nfvo/local_nfvo.py":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ad19c4ce1ceed7927c47289be64765a5be0bd4b9","unresolved":true,"context_lines":[{"line_number":352,"context_line":"                if vim_info is None:"},{"line_number":353,"context_line":"                    # never happen. just for code consistency."},{"line_number":354,"context_line":"                    return"},{"line_number":355,"context_line":"                if vim_info.vimType !\u003d \u0027kubernetes\u0027:"},{"line_number":356,"context_line":"                    self._glance_delete_images(vim_info, inst.id)"},{"line_number":357,"context_line":"        elif lcmocc.operation \u003d\u003d v2_fields.LcmOperationType.MODIFY_INFO or ("},{"line_number":358,"context_line":"                lcmocc.operation \u003d\u003d v2_fields.LcmOperationType.CHANGE_VNFPKG):"}],"source_content_type":"text/x-python","patch_set":11,"id":"83159eb6_7e84cec4","line":355,"updated":"2022-03-11 07:14:33.000000000","message":"I think the condition expression should be positive, because you would like to execute `_glance_delete_images` when the vimType is \u0027openstack\u0027.\n\n```\n                if vim_info.vimType !\u003d \u0027openstack\u0027:\n```","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"1342e3d402568e6c6c4ddcdff4f47d3a3551e798","unresolved":true,"context_lines":[{"line_number":352,"context_line":"                if vim_info is None:"},{"line_number":353,"context_line":"                    # never happen. just for code consistency."},{"line_number":354,"context_line":"                    return"},{"line_number":355,"context_line":"                if vim_info.vimType !\u003d \u0027kubernetes\u0027:"},{"line_number":356,"context_line":"                    self._glance_delete_images(vim_info, inst.id)"},{"line_number":357,"context_line":"        elif lcmocc.operation \u003d\u003d v2_fields.LcmOperationType.MODIFY_INFO or ("},{"line_number":358,"context_line":"                lcmocc.operation \u003d\u003d v2_fields.LcmOperationType.CHANGE_VNFPKG):"}],"source_content_type":"text/x-python","patch_set":11,"id":"b3885a58_07befe8d","line":355,"in_reply_to":"54cb1f36_86bd89ca","updated":"2022-03-17 07:25:14.000000000","message":"Ah, sorry for my mistake. `if vim_info.vimType \u003d\u003d \u0027ETSINFV.OPENSTACK_KEYSTONE.V_3\u0027` is correct.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"2d0f21530288261517e1c2f78e3f0efa8a87c724","unresolved":false,"context_lines":[{"line_number":352,"context_line":"                if vim_info is None:"},{"line_number":353,"context_line":"                    # never happen. just for code consistency."},{"line_number":354,"context_line":"                    return"},{"line_number":355,"context_line":"                if vim_info.vimType !\u003d \u0027kubernetes\u0027:"},{"line_number":356,"context_line":"                    self._glance_delete_images(vim_info, inst.id)"},{"line_number":357,"context_line":"        elif lcmocc.operation \u003d\u003d v2_fields.LcmOperationType.MODIFY_INFO or ("},{"line_number":358,"context_line":"                lcmocc.operation \u003d\u003d v2_fields.LcmOperationType.CHANGE_VNFPKG):"}],"source_content_type":"text/x-python","patch_set":11,"id":"0b47def2_ec47a43c","line":355,"in_reply_to":"630ab096_02dc7509","updated":"2022-03-17 10:48:28.000000000","message":"Done","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5db4962ff1d65792d02575fee04bfe7a241f67e1","unresolved":true,"context_lines":[{"line_number":352,"context_line":"                if vim_info is None:"},{"line_number":353,"context_line":"                    # never happen. just for code consistency."},{"line_number":354,"context_line":"                    return"},{"line_number":355,"context_line":"                if vim_info.vimType !\u003d \u0027kubernetes\u0027:"},{"line_number":356,"context_line":"                    self._glance_delete_images(vim_info, inst.id)"},{"line_number":357,"context_line":"        elif lcmocc.operation \u003d\u003d v2_fields.LcmOperationType.MODIFY_INFO or ("},{"line_number":358,"context_line":"                lcmocc.operation \u003d\u003d v2_fields.LcmOperationType.CHANGE_VNFPKG):"}],"source_content_type":"text/x-python","patch_set":11,"id":"54cb1f36_86bd89ca","line":355,"in_reply_to":"83159eb6_7e84cec4","updated":"2022-03-11 08:59:57.000000000","message":"I think you mean if vim_info.vimType \u003d\u003d \u0027openstack\u0027?\nI think we should use `ETSINFV.OPENSTACK_KEYSTONE.V_3`, not \u0027openstack\u0027.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bb20c95e3cec49b1a649e8b88f68b9b28db73a46","unresolved":true,"context_lines":[{"line_number":352,"context_line":"                if vim_info is None:"},{"line_number":353,"context_line":"                    # never happen. just for code consistency."},{"line_number":354,"context_line":"                    return"},{"line_number":355,"context_line":"                if vim_info.vimType !\u003d \u0027kubernetes\u0027:"},{"line_number":356,"context_line":"                    self._glance_delete_images(vim_info, inst.id)"},{"line_number":357,"context_line":"        elif lcmocc.operation \u003d\u003d v2_fields.LcmOperationType.MODIFY_INFO or ("},{"line_number":358,"context_line":"                lcmocc.operation \u003d\u003d v2_fields.LcmOperationType.CHANGE_VNFPKG):"}],"source_content_type":"text/x-python","patch_set":11,"id":"630ab096_02dc7509","line":355,"in_reply_to":"b3885a58_07befe8d","updated":"2022-03-17 07:49:29.000000000","message":"I have fixed it in PS15.","commit_id":"889811b95c21517cf472a78063d5f56b56f38d77"}],"tacker/tests/functional/sol_kubernetes_v2/test_change_vnfpkg.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        super(VnfLcmKubernetesChangeVnfpkgTest, self).setUp()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_change_vnfpkg_for_deployment_res_with_all_params(self):"},{"line_number":54,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        * About attributes:"},{"line_number":57,"context_line":"          All of the following cardinality attributes are set."}],"source_content_type":"text/x-python","patch_set":8,"id":"21ea0cb1_ac80337e","line":54,"range":{"start_line":54,"start_character":11,"end_line":54,"end_character":54},"updated":"2022-03-09 17:57:02.000000000","message":"Could you change the docstring to match the purpose of the test?","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        super(VnfLcmKubernetesChangeVnfpkgTest, self).setUp()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_change_vnfpkg_for_deployment_res_with_all_params(self):"},{"line_number":54,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        * About attributes:"},{"line_number":57,"context_line":"          All of the following cardinality attributes are set."}],"source_content_type":"text/x-python","patch_set":8,"id":"667e812a_aaac4e36","line":54,"range":{"start_line":54,"start_character":11,"end_line":54,"end_character":54},"in_reply_to":"21ea0cb1_ac80337e","updated":"2022-03-10 14:07:44.000000000","message":"I fixed it in PS9.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(VnfLcmKubernetesChangeVnfpkgTest, self).setUp()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_change_vnfpkg_for_deployment_res_with_all_params(self):"},{"line_number":54,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        * About attributes:"},{"line_number":57,"context_line":"          All of the following cardinality attributes are set."}],"source_content_type":"text/x-python","patch_set":8,"id":"ad26f731_7e918198","line":54,"range":{"start_line":54,"start_character":11,"end_line":54,"end_character":54},"in_reply_to":"667e812a_aaac4e36","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_change_vnfpkg_for_deployment_res_with_no_op_params(self):"},{"line_number":185,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        * About attributes:"},{"line_number":188,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":8,"id":"60c1f8f4_21d95738","line":185,"range":{"start_line":185,"start_character":11,"end_line":185,"end_character":54},"updated":"2022-03-09 17:57:02.000000000","message":"Could you change the docstring to match the purpose of the test?","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":182,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_change_vnfpkg_for_deployment_res_with_no_op_params(self):"},{"line_number":185,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        * About attributes:"},{"line_number":188,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":8,"id":"a01d9cd9_904beb55","line":185,"range":{"start_line":185,"start_character":11,"end_line":185,"end_character":54},"in_reply_to":"60c1f8f4_21d95738","updated":"2022-03-10 14:07:44.000000000","message":"I fixed it in PS9.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_change_vnfpkg_for_deployment_res_with_no_op_params(self):"},{"line_number":185,"context_line":"        \"\"\"Test LCM operations with all attributes set"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        * About attributes:"},{"line_number":188,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":8,"id":"bb1d7124_c35d340f","line":185,"range":{"start_line":185,"start_character":11,"end_line":185,"end_character":54},"in_reply_to":"a01d9cd9_904beb55","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"}],"tacker/tests/functional/sol_kubernetes_v2/test_vnflcm_error_handing.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":364,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        # check vnfc_resource_info"},{"line_number":367,"context_line":"        # TODO()"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        # 3. Show VNF instance"},{"line_number":370,"context_line":"        additional_inst_attrs \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"f06ae119_2855983b","line":367,"range":{"start_line":367,"start_character":8,"end_line":367,"end_character":16},"updated":"2022-03-09 17:57:02.000000000","message":"Are you writing this TODO?","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        # check vnfc_resource_info"},{"line_number":367,"context_line":"        # TODO()"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        # 3. Show VNF instance"},{"line_number":370,"context_line":"        additional_inst_attrs \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"8a2840b2_a0e3f402","line":367,"range":{"start_line":367,"start_character":8,"end_line":367,"end_character":16},"in_reply_to":"c4fe7369_1b219dee","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":364,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        # check vnfc_resource_info"},{"line_number":367,"context_line":"        # TODO()"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        # 3. Show VNF instance"},{"line_number":370,"context_line":"        additional_inst_attrs \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"c4fe7369_1b219dee","line":367,"range":{"start_line":367,"start_character":8,"end_line":367,"end_character":16},"in_reply_to":"f06ae119_2855983b","updated":"2022-03-10 14:07:44.000000000","message":"I have check this, I forgot to add it.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"}],"tacker/tests/unit/sol_refactored/infra_drivers/kubernetes/fakes.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 FUJITSU"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"b8dd0aff_97e07769","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"updated":"2022-03-09 17:57:02.000000000","message":"2022","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 FUJITSU"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"72e17747_cf984724","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"in_reply_to":"613e6b7d_1d8d5683","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 FUJITSU"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"613e6b7d_1d8d5683","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"in_reply_to":"b8dd0aff_97e07769","updated":"2022-03-10 14:07:44.000000000","message":"I fixed it in PS9.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"}],"tacker/tests/unit/sol_refactored/infra_drivers/kubernetes/test_kubernetes.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"31b214e9_bb05441f","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"updated":"2022-03-09 17:57:02.000000000","message":"Please check is this correct.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"a17236d4_b6c0905a","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"31b214e9_bb05441f","updated":"2022-03-10 14:07:44.000000000","message":"I fixed it in PS9","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"5482b95e_35d6e451","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"a17236d4_b6c0905a","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"}],"tacker/tests/unit/sol_refactored/samples/change_vnfpkg_sample/Scripts/coordinate_new_vnf.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"7cedf401_9cb2cedd","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"updated":"2022-03-09 17:57:02.000000000","message":"2022","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"d69c61a5_d2c1dc20","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"updated":"2022-03-09 17:57:02.000000000","message":"Please check is this correct.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"daef3e1a_87556132","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"in_reply_to":"7cedf401_9cb2cedd","updated":"2022-03-10 14:07:44.000000000","message":"I fixed it in PS9.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"e82e0344_ae53562f","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"d69c61a5_d2c1dc20","updated":"2022-03-10 14:07:44.000000000","message":"ditto","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"4020a23f_4def260e","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"in_reply_to":"daef3e1a_87556132","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"a0b080a0_0f1e53b2","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"e82e0344_ae53562f","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"}],"tacker/tests/unit/sol_refactored/samples/sample2/Scripts/coordinate_old_vnf.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"8d3adacd_fde8b5af","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-03-09 17:57:02.000000000","message":"2022","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c28b5a16663162b7c0ffa5e248a77a406ec371af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"7dac1e96_3cff64a3","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"updated":"2022-03-09 17:57:02.000000000","message":"Please check is this correct.","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"978e50bd_dbdcfbd1","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"7dac1e96_3cff64a3","updated":"2022-03-10 14:07:44.000000000","message":"ditto","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b2e51c2519093e04af34bbac2a53aba8cc1d72bb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"e6a4d1de_4f75a9f3","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"8d3adacd_fde8b5af","updated":"2022-03-10 14:07:44.000000000","message":"ditto","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"53cc8ef7_a4cf773c","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":63},"in_reply_to":"978e50bd_dbdcfbd1","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6af3ef59d810501be0e81e45583acbb07299ec75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"4aeaa88c_f177abd3","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"e6a4d1de_4f75a9f3","updated":"2022-03-14 23:51:16.000000000","message":"Ack","commit_id":"69daa55cab1060710f1f9581727376fe4d516fef"}]}