)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In this Sample Ansible Driver, the following key LCMs"},{"line_number":13,"context_line":"are supported:"},{"line_number":14,"context_line":"    - instantiation_end"},{"line_number":15,"context_line":"    - scale_start"},{"line_number":16,"context_line":"    - scale_end"},{"line_number":17,"context_line":"    - heal_end"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c3067157_1fa1f776","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":23},"updated":"2022-03-15 05:38:35.000000000","message":"I think `instantiate_end` is correct.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In this Sample Ansible Driver, the following key LCMs"},{"line_number":13,"context_line":"are supported:"},{"line_number":14,"context_line":"    - instantiation_end"},{"line_number":15,"context_line":"    - scale_start"},{"line_number":16,"context_line":"    - scale_end"},{"line_number":17,"context_line":"    - heal_end"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"306e3088_acba8f71","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":23},"in_reply_to":"841dc9e1_aa19a7a0","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"In this Sample Ansible Driver, the following key LCMs"},{"line_number":13,"context_line":"are supported:"},{"line_number":14,"context_line":"    - instantiation_end"},{"line_number":15,"context_line":"    - scale_start"},{"line_number":16,"context_line":"    - scale_end"},{"line_number":17,"context_line":"    - heal_end"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"841dc9e1_aa19a7a0","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":23},"in_reply_to":"c3067157_1fa1f776","updated":"2022-03-15 12:07:52.000000000","message":"\u003e I think `instantiate_end` is correct.\n\nIt is updated.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    - scale_start"},{"line_number":16,"context_line":"    - scale_end"},{"line_number":17,"context_line":"    - heal_end"},{"line_number":18,"context_line":"    - termination_start"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Implements: blueprint add-ansible-mgmt-driver-sample"},{"line_number":21,"context_line":"Spec: https://review.opendev.org/c/openstack/tacker-specs/+/814689"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1edf7a85_ec07933b","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":23},"updated":"2022-03-15 05:38:35.000000000","message":"I think `terminate_end` is correct.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    - scale_start"},{"line_number":16,"context_line":"    - scale_end"},{"line_number":17,"context_line":"    - heal_end"},{"line_number":18,"context_line":"    - termination_start"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Implements: blueprint add-ansible-mgmt-driver-sample"},{"line_number":21,"context_line":"Spec: https://review.opendev.org/c/openstack/tacker-specs/+/814689"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"24cfc179_ea4fbc1f","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":23},"in_reply_to":"0ea75b9a_632fce6b","updated":"2022-03-15 12:28:30.000000000","message":"Sorry, `terminate_start` is right. I\u0027ve confirmed.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    - scale_start"},{"line_number":16,"context_line":"    - scale_end"},{"line_number":17,"context_line":"    - heal_end"},{"line_number":18,"context_line":"    - termination_start"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Implements: blueprint add-ansible-mgmt-driver-sample"},{"line_number":21,"context_line":"Spec: https://review.opendev.org/c/openstack/tacker-specs/+/814689"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"0ea75b9a_632fce6b","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":23},"in_reply_to":"1edf7a85_ec07933b","updated":"2022-03-15 12:07:52.000000000","message":"\u003e I think `terminate_end` is correct.\n\nYou mean `terminate_start`, right? Anyway, I have updated it.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5ce41c9e7b5083342d3a70156aff54ad33d102af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9633f409_e91547da","updated":"2022-03-11 00:31:36.000000000","message":"Thank you for the comment. An answer is provided.","commit_id":"2e10d8231a4502e45e2230257c324eec3f035b96"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b00de6ae_941df335","updated":"2022-03-15 05:38:35.000000000","message":"Sorry for the late comment, please kindly find my comments.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"991ba21e03fba16d8ab43b5846be5d7dbb4810d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0ea21829_4ca59faa","updated":"2022-03-11 09:27:11.000000000","message":"recheck","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"10deae42c364f5ab165261beb24304939174f7f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a92e5f9_b612efbe","updated":"2022-03-14 00:21:58.000000000","message":"recheck","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"46cf7816913d73110521b9d5631d661c06a64a45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8120f5d4_7b207690","updated":"2022-03-11 05:32:33.000000000","message":"recheck","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"462bcef1_1021abd5","updated":"2022-03-15 12:07:52.000000000","message":"Thank you for your comments. Please refer to the latest patch.\n1 comment remains un-answered. It will be provided in the next patch.","commit_id":"23c421d4e93ca087b7614961812b51984fde49bb"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a61c28ca500dded78ca2e8cca4d0414e1bfd0800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ac87ee7b_9b7dccd6","updated":"2022-03-15 12:17:55.000000000","message":"I answered the remaining comment. Please refer to the latest patch for the changes.","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ed4f687af39496bc2ced8c1064f7a320a57eaede","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e910a07b_bff00b99","updated":"2022-03-15 12:51:12.000000000","message":"Sorry for the additional comments, please kindly check it.","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2f1e4899de5129d943cc9cb3d60936142840f87f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"257bf971_414870fe","updated":"2022-03-16 07:26:07.000000000","message":"In PS9, releasenotes build error occurred.\n```\nbuild-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6674473c6f2540c79d2dfa84a6e0ce3b : FAILURE in 5m 59s\n```\nCould you resolve it?","commit_id":"24fdc055baa25e825cc5af49f4783ad5a9531d28"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9a1a484c759d7f83f033730c45b8560eaf589def","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b2cf8c3b_e39a1759","updated":"2022-03-15 12:54:12.000000000","message":"Thanks for the comments. Please refer to my answers and the latest patch.","commit_id":"24fdc055baa25e825cc5af49f4783ad5a9531d28"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c7784f7b13db035af1fac7da14ea4d1fade027d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5e3c1971_b4b8a143","updated":"2022-03-16 10:36:36.000000000","message":"Thank you for your comments. Please refer to the latest patch and my answers to your comments.","commit_id":"611b8b1043ddc2116e3f3f0de1875936936c25e2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6afa9b80c25c3864984dfa304184f3cc09e906d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a0765a84_e4ca85c8","updated":"2022-03-17 05:05:32.000000000","message":"Thanks for your rework, LGTM.","commit_id":"611b8b1043ddc2116e3f3f0de1875936936c25e2"}],"releasenotes/notes/add-sample-ansible-driver-f204be6350c8a546.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    A Sample VNF package which contains sample usage of Ansible is provided."},{"line_number":13,"context_line":"    User manual is also provided to explain the steps in preparing the"},{"line_number":14,"context_line":"    environment to use Ansible Driver."},{"line_number":15,"context_line":"issues:"},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Deployment flavors share only one config.yaml due to the limitation of"},{"line_number":18,"context_line":"    Management Driver."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"19aec9ff_51dc9931","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"updated":"2022-03-15 12:28:30.000000000","message":"For release note, features and other items (issue in this case) appear separately in docs.\n\nfor example (xena release\u0027s release note):\nhttps://docs.openstack.org/releasenotes/tacker/xena.html\n\nCould you clearly state to that this is an issue for sample Ansible Driver?\n\nOr is this issue about Management Driver in general?","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c7784f7b13db035af1fac7da14ea4d1fade027d5","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    A Sample VNF package which contains sample usage of Ansible is provided."},{"line_number":13,"context_line":"    User manual is also provided to explain the steps in preparing the"},{"line_number":14,"context_line":"    environment to use Ansible Driver."},{"line_number":15,"context_line":"issues:"},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Deployment flavors share only one config.yaml due to the limitation of"},{"line_number":18,"context_line":"    Management Driver."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bedc4c70_13979f45","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"in_reply_to":"19aec9ff_51dc9931","updated":"2022-03-16 10:36:36.000000000","message":"\u003e For release note, features and other items (issue in this case) appear separately in docs.\n\u003e \n\u003e for example (xena release\u0027s release note):\n\u003e https://docs.openstack.org/releasenotes/tacker/xena.html\n\u003e \n\u003e Could you clearly state to that this is an issue for sample Ansible Driver?\n\u003e \n\u003e Or is this issue about Management Driver in general?\n\nI updated the statement to clearly specify about the issue for Sample Ansible Driver.","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6afa9b80c25c3864984dfa304184f3cc09e906d4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    A Sample VNF package which contains sample usage of Ansible is provided."},{"line_number":13,"context_line":"    User manual is also provided to explain the steps in preparing the"},{"line_number":14,"context_line":"    environment to use Ansible Driver."},{"line_number":15,"context_line":"issues:"},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    Deployment flavors share only one config.yaml due to the limitation of"},{"line_number":18,"context_line":"    Management Driver."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ab5c61ee_37c9b553","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":7},"in_reply_to":"bedc4c70_13979f45","updated":"2022-03-17 05:05:32.000000000","message":"Ack","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2f1e4899de5129d943cc9cb3d60936142840f87f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Add a Sample Ansible Driver as an option for users who want to use ansible"},{"line_number":5,"context_line":"    for configuration of VNFs."},{"line_number":6,"context_line":"    This Ansible Driver supports the following key LCMs"},{"line_number":7,"context_line":"        - instantiation_end"},{"line_number":8,"context_line":"        - scale_start"},{"line_number":9,"context_line":"        - scale_end"},{"line_number":10,"context_line":"        - heal_end"},{"line_number":11,"context_line":"        - termination_start"},{"line_number":12,"context_line":"    A Sample VNF package which contains sample usage of Ansible is provided."},{"line_number":13,"context_line":"    User manual is also provided to explain the steps in preparing the"},{"line_number":14,"context_line":"    environment to use Ansible Driver."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"66417c70_6b13104e","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":27},"updated":"2022-03-16 07:26:07.000000000","message":"In PS9, building releasenotes job was failed.\nIn my investigation, you can resolve this by removing the indentation and adding a blank line before and after as the following:\n\n```\n    This Ansible Driver supports the following key LCMs\n\n    - instantiation_end\n    - scale_start\n    - scale_end\n    - heal_end\n    - termination_start\n\n    A Sample VNF package which contains sample usage of Ansible is provided.\n```","commit_id":"24fdc055baa25e825cc5af49f4783ad5a9531d28"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c7784f7b13db035af1fac7da14ea4d1fade027d5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Add a Sample Ansible Driver as an option for users who want to use ansible"},{"line_number":5,"context_line":"    for configuration of VNFs."},{"line_number":6,"context_line":"    This Ansible Driver supports the following key LCMs"},{"line_number":7,"context_line":"        - instantiation_end"},{"line_number":8,"context_line":"        - scale_start"},{"line_number":9,"context_line":"        - scale_end"},{"line_number":10,"context_line":"        - heal_end"},{"line_number":11,"context_line":"        - termination_start"},{"line_number":12,"context_line":"    A Sample VNF package which contains sample usage of Ansible is provided."},{"line_number":13,"context_line":"    User manual is also provided to explain the steps in preparing the"},{"line_number":14,"context_line":"    environment to use Ansible Driver."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a4a1a1b0_f3a0c403","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":27},"in_reply_to":"66417c70_6b13104e","updated":"2022-03-16 10:36:36.000000000","message":"\u003e In PS9, building releasenotes job was failed.\n\u003e In my investigation, you can resolve this by removing the indentation and adding a blank line before and after as the following:\n\u003e \n\u003e ```\n\u003e     This Ansible Driver supports the following key LCMs\n\u003e \n\u003e     - instantiation_end\n\u003e     - scale_start\n\u003e     - scale_end\n\u003e     - heal_end\n\u003e     - termination_start\n\u003e \n\u003e     A Sample VNF package which contains sample usage of Ansible is provided.\n\u003e ```\n\nSorry, but it seems strange to do it that way (without indentation), so I totally changed the image to make it into a paragraph format instead of an enumerated/outlined one. I hope the new image will be okay with you.","commit_id":"24fdc055baa25e825cc5af49f4783ad5a9531d28"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6afa9b80c25c3864984dfa304184f3cc09e906d4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add a Sample Ansible Driver as an option for users who want to use ansible"},{"line_number":5,"context_line":"    for configuration of VNFs."},{"line_number":6,"context_line":"    This Ansible Driver supports the following key LCMs"},{"line_number":7,"context_line":"        - instantiation_end"},{"line_number":8,"context_line":"        - scale_start"},{"line_number":9,"context_line":"        - scale_end"},{"line_number":10,"context_line":"        - heal_end"},{"line_number":11,"context_line":"        - termination_start"},{"line_number":12,"context_line":"    A Sample VNF package which contains sample usage of Ansible is provided."},{"line_number":13,"context_line":"    User manual is also provided to explain the steps in preparing the"},{"line_number":14,"context_line":"    environment to use Ansible Driver."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fbc83dc1_933f1176","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":27},"in_reply_to":"a4a1a1b0_f3a0c403","updated":"2022-03-17 05:05:32.000000000","message":"Ack","commit_id":"24fdc055baa25e825cc5af49f4783ad5a9531d28"}],"samples/mgmt_driver/ansible/ansible_cmd_executer.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class AnsibleCommandExecutor(object):"},{"line_number":24,"context_line":"    \"\"\"Class to execute a command on remote location\"\"\""},{"line_number":25,"context_line":"    def __init__(self, **kwargs):"},{"line_number":26,"context_line":"        self.__host \u003d kwargs[\"host\"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"286f1686_c76f8062","line":23,"updated":"2022-03-15 05:38:35.000000000","message":"Is this class called/used anywhere?\nAre you using `subprocess.Popen()` instead of this executor?","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a61c28ca500dded78ca2e8cca4d0414e1bfd0800","unresolved":true,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class AnsibleCommandExecutor(object):"},{"line_number":24,"context_line":"    \"\"\"Class to execute a command on remote location\"\"\""},{"line_number":25,"context_line":"    def __init__(self, **kwargs):"},{"line_number":26,"context_line":"        self.__host \u003d kwargs[\"host\"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3cacc116_4149b520","line":23,"in_reply_to":"286f1686_c76f8062","updated":"2022-03-15 12:17:55.000000000","message":"\u003e Is this class called/used anywhere?\nIt is not used, so we removed it.\n\n\u003e Are you using `subprocess.Popen()` instead of this executor?\nYes","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class AnsibleCommandExecutor(object):"},{"line_number":24,"context_line":"    \"\"\"Class to execute a command on remote location\"\"\""},{"line_number":25,"context_line":"    def __init__(self, **kwargs):"},{"line_number":26,"context_line":"        self.__host \u003d kwargs[\"host\"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"d71b492e_3bcaebad","line":23,"in_reply_to":"3cacc116_4149b520","updated":"2022-03-15 12:28:30.000000000","message":"Thanks for your answer, I got it.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"}],"samples/mgmt_driver/ansible/ansible_config_parser.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            access_info \u003d plugin.get_vim(context, vnf)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            # get vim details"},{"line_number":69,"context_line":"            self._auth_url \u003d access_info[\"vim_auth\"][\"auth_url\"]"},{"line_number":70,"context_line":"            self._username \u003d access_info[\"vim_auth\"][\"username\"]"},{"line_number":71,"context_line":"            self._password \u003d access_info[\"vim_auth\"][\"password\"]"},{"line_number":72,"context_line":"            self._project_name \u003d access_info[\"vim_auth\"][\"project_name\"]"},{"line_number":73,"context_line":"            self._project_domain_name \u003d \\"},{"line_number":74,"context_line":"                access_info[\"vim_auth\"][\"project_domain_name\"]"},{"line_number":75,"context_line":"            self._user_domain_name \u003d \\"},{"line_number":76,"context_line":"                access_info[\"vim_auth\"][\"user_domain_name\"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            # changed password type bytes -\u003e string"},{"line_number":79,"context_line":"            if isinstance(self._password, bytes):"}],"source_content_type":"text/x-python","patch_set":6,"id":"c810f1c0_0ec4c718","line":76,"range":{"start_line":69,"start_character":0,"end_line":76,"end_character":59},"updated":"2022-03-15 05:38:35.000000000","message":"I think it is easier to see if you change it as follow:\n```\n            vim_auth \u003d access_info[\"vim_auth\"]\n            self._auth_url \u003d vim_auth[\"auth_url\"]\n            self._username \u003d vim_auth[\"username\"]\n            self._password \u003d vim_auth[\"password\"]\n            self._project_name \u003d vim_auth[\"project_name\"]\n            self._project_domain_name \u003d vim_auth[\"project_domain_name\"]\n            self._user_domain_name \u003d vim_auth[\"user_domain_name\"]\n```","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            access_info \u003d plugin.get_vim(context, vnf)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            # get vim details"},{"line_number":69,"context_line":"            self._auth_url \u003d access_info[\"vim_auth\"][\"auth_url\"]"},{"line_number":70,"context_line":"            self._username \u003d access_info[\"vim_auth\"][\"username\"]"},{"line_number":71,"context_line":"            self._password \u003d access_info[\"vim_auth\"][\"password\"]"},{"line_number":72,"context_line":"            self._project_name \u003d access_info[\"vim_auth\"][\"project_name\"]"},{"line_number":73,"context_line":"            self._project_domain_name \u003d \\"},{"line_number":74,"context_line":"                access_info[\"vim_auth\"][\"project_domain_name\"]"},{"line_number":75,"context_line":"            self._user_domain_name \u003d \\"},{"line_number":76,"context_line":"                access_info[\"vim_auth\"][\"user_domain_name\"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            # changed password type bytes -\u003e string"},{"line_number":79,"context_line":"            if isinstance(self._password, bytes):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f3619de_31da0276","line":76,"range":{"start_line":69,"start_character":0,"end_line":76,"end_character":59},"in_reply_to":"2272358b_de445bb1","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            access_info \u003d plugin.get_vim(context, vnf)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            # get vim details"},{"line_number":69,"context_line":"            self._auth_url \u003d access_info[\"vim_auth\"][\"auth_url\"]"},{"line_number":70,"context_line":"            self._username \u003d access_info[\"vim_auth\"][\"username\"]"},{"line_number":71,"context_line":"            self._password \u003d access_info[\"vim_auth\"][\"password\"]"},{"line_number":72,"context_line":"            self._project_name \u003d access_info[\"vim_auth\"][\"project_name\"]"},{"line_number":73,"context_line":"            self._project_domain_name \u003d \\"},{"line_number":74,"context_line":"                access_info[\"vim_auth\"][\"project_domain_name\"]"},{"line_number":75,"context_line":"            self._user_domain_name \u003d \\"},{"line_number":76,"context_line":"                access_info[\"vim_auth\"][\"user_domain_name\"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            # changed password type bytes -\u003e string"},{"line_number":79,"context_line":"            if isinstance(self._password, bytes):"}],"source_content_type":"text/x-python","patch_set":6,"id":"2272358b_de445bb1","line":76,"range":{"start_line":69,"start_character":0,"end_line":76,"end_character":59},"in_reply_to":"c810f1c0_0ec4c718","updated":"2022-03-15 12:07:52.000000000","message":"\u003e I think it is easier to see if you change it as follow:\n\u003e ```\n\u003e             vim_auth \u003d access_info[\"vim_auth\"]\n\u003e             self._auth_url \u003d vim_auth[\"auth_url\"]\n\u003e             self._username \u003d vim_auth[\"username\"]\n\u003e             self._password \u003d vim_auth[\"password\"]\n\u003e             self._project_name \u003d vim_auth[\"project_name\"]\n\u003e             self._project_domain_name \u003d vim_auth[\"project_domain_name\"]\n\u003e             self._user_domain_name \u003d vim_auth[\"user_domain_name\"]\n\u003e ```\n\nWe modified based on your suggestion.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"}],"samples/mgmt_driver/ansible/ansible_driver.py":[{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"03907b2aae718d58e1d7872f27cf787f3ca2771e","unresolved":true,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        script_ansible_config \u003d None"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # load ScritpANSIBLE/config.yaml"},{"line_number":261,"context_line":"        if os.path.exists(script_ansible_path):"},{"line_number":262,"context_line":"            for file in os.listdir(script_ansible_path):"},{"line_number":263,"context_line":"                if file.endswith(\u0027yaml\u0027) and file.startswith(\u0027config\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"4cb715f6_10ab36ac","line":260,"updated":"2022-03-03 09:38:02.000000000","message":"This implementation looks like deployment flavours in same package must share config.yaml.\nI think each deployment flavours shoud have its own config.","commit_id":"62046c82b1989ae227960779755ea0ebe4be46b1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5ce41c9e7b5083342d3a70156aff54ad33d102af","unresolved":true,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        script_ansible_config \u003d None"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # load ScritpANSIBLE/config.yaml"},{"line_number":261,"context_line":"        if os.path.exists(script_ansible_path):"},{"line_number":262,"context_line":"            for file in os.listdir(script_ansible_path):"},{"line_number":263,"context_line":"                if file.endswith(\u0027yaml\u0027) and file.startswith(\u0027config\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"52f04a6e_7596cc9f","line":260,"in_reply_to":"4cb715f6_10ab36ac","updated":"2022-03-11 00:31:36.000000000","message":"\u003e This implementation looks like deployment flavours in same package must share config.yaml.\n\u003e I think each deployment flavours shoud have its own config.\n\nCurrently, providing different config.yaml files for different flavors is a limitation due to the Management Driver\u0027s limitation. Support for this feature will be provided in the future.","commit_id":"62046c82b1989ae227960779755ea0ebe4be46b1"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"3b9641b134a4ab93507fb1460c8bb8d514cba83b","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        script_ansible_config \u003d None"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # load ScritpANSIBLE/config.yaml"},{"line_number":261,"context_line":"        if os.path.exists(script_ansible_path):"},{"line_number":262,"context_line":"            for file in os.listdir(script_ansible_path):"},{"line_number":263,"context_line":"                if file.endswith(\u0027yaml\u0027) and file.startswith(\u0027config\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a2e34d51_12a4e49e","line":260,"in_reply_to":"52f04a6e_7596cc9f","updated":"2022-03-11 11:51:52.000000000","message":"I understood. Thank you.","commit_id":"62046c82b1989ae227960779755ea0ebe4be46b1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # get the mgmt_url"},{"line_number":104,"context_line":"        vnf_mgmt_ip_address \u003d self._vnf.get(\"mgmt_ip_address\", None)"},{"line_number":105,"context_line":"        # vnf_mgmt_ip_address \u003d self._get_mgmt_ip_address()"},{"line_number":106,"context_line":"        if vnf_mgmt_ip_address is not None:"},{"line_number":107,"context_line":"            mgmt_url \u003d jsonutils.loads(vnf_mgmt_ip_address)"},{"line_number":108,"context_line":"            LOG.debug(\"mgmt_url %s\", mgmt_url)"}],"source_content_type":"text/x-python","patch_set":6,"id":"cbdb8166_a22f5544","line":105,"updated":"2022-03-15 05:38:35.000000000","message":"What is this comment line? Could you delete it if there is no problem.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # get the mgmt_url"},{"line_number":104,"context_line":"        vnf_mgmt_ip_address \u003d self._vnf.get(\"mgmt_ip_address\", None)"},{"line_number":105,"context_line":"        # vnf_mgmt_ip_address \u003d self._get_mgmt_ip_address()"},{"line_number":106,"context_line":"        if vnf_mgmt_ip_address is not None:"},{"line_number":107,"context_line":"            mgmt_url \u003d jsonutils.loads(vnf_mgmt_ip_address)"},{"line_number":108,"context_line":"            LOG.debug(\"mgmt_url %s\", mgmt_url)"}],"source_content_type":"text/x-python","patch_set":6,"id":"f16596ba_cb979500","line":105,"in_reply_to":"cbdb8166_a22f5544","updated":"2022-03-15 12:07:52.000000000","message":"\u003e What is this comment line? Could you delete it if there is no problem.\n\nIt is removed.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # get the mgmt_url"},{"line_number":104,"context_line":"        vnf_mgmt_ip_address \u003d self._vnf.get(\"mgmt_ip_address\", None)"},{"line_number":105,"context_line":"        # vnf_mgmt_ip_address \u003d self._get_mgmt_ip_address()"},{"line_number":106,"context_line":"        if vnf_mgmt_ip_address is not None:"},{"line_number":107,"context_line":"            mgmt_url \u003d jsonutils.loads(vnf_mgmt_ip_address)"},{"line_number":108,"context_line":"            LOG.debug(\"mgmt_url %s\", mgmt_url)"}],"source_content_type":"text/x-python","patch_set":6,"id":"4ec7ca62_eaf45dfc","line":105,"in_reply_to":"f16596ba_cb979500","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        except ValueError:"},{"line_number":176,"context_line":"            raise exceptions.InvalidValueError(vdu\u003dvdu, key\u003d\"order\")"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        config_info \u003d {}"},{"line_number":179,"context_line":"        config_info[\"vdu\"] \u003d vdu"},{"line_number":180,"context_line":"        config_info[\"config\"] \u003d config"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if order in self._config_queue:"},{"line_number":183,"context_line":"            self._config_queue[order].append(config_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"18c7e073_0efd4398","line":180,"range":{"start_line":178,"start_character":0,"end_line":180,"end_character":38},"updated":"2022-03-15 05:38:35.000000000","message":"I think it is easier to see if you change it as follow:\n```\n        config_info \u003d {\n            \"vdu\": vdu,\n            \"config\": config\n        }\n```","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        except ValueError:"},{"line_number":176,"context_line":"            raise exceptions.InvalidValueError(vdu\u003dvdu, key\u003d\"order\")"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        config_info \u003d {}"},{"line_number":179,"context_line":"        config_info[\"vdu\"] \u003d vdu"},{"line_number":180,"context_line":"        config_info[\"config\"] \u003d config"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if order in self._config_queue:"},{"line_number":183,"context_line":"            self._config_queue[order].append(config_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"cba1251f_2ffd86df","line":180,"range":{"start_line":178,"start_character":0,"end_line":180,"end_character":38},"in_reply_to":"18c7e073_0efd4398","updated":"2022-03-15 12:07:52.000000000","message":"\u003e I think it is easier to see if you change it as follow:\n\u003e ```\n\u003e         config_info \u003d {\n\u003e             \"vdu\": vdu,\n\u003e             \"config\": config\n\u003e         }\n\u003e ```\n\nWe modified based on your suggestion.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        except ValueError:"},{"line_number":176,"context_line":"            raise exceptions.InvalidValueError(vdu\u003dvdu, key\u003d\"order\")"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        config_info \u003d {}"},{"line_number":179,"context_line":"        config_info[\"vdu\"] \u003d vdu"},{"line_number":180,"context_line":"        config_info[\"config\"] \u003d config"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if order in self._config_queue:"},{"line_number":183,"context_line":"            self._config_queue[order].append(config_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"de364a74_76adf9dc","line":180,"range":{"start_line":178,"start_character":0,"end_line":180,"end_character":38},"in_reply_to":"cba1251f_2ffd86df","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        script_ansible_config \u003d None"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # load ScritpANSIBLE/config.yaml"},{"line_number":261,"context_line":"        if os.path.exists(script_ansible_path):"},{"line_number":262,"context_line":"            for file in os.listdir(script_ansible_path):"},{"line_number":263,"context_line":"                if file.endswith(\u0027yaml\u0027) and file.startswith(\u0027config\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"f599130d_3ac05d90","line":260,"range":{"start_line":260,"start_character":15,"end_line":260,"end_character":21},"updated":"2022-03-15 05:38:35.000000000","message":"typo: Script","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        script_ansible_config \u003d None"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # load ScritpANSIBLE/config.yaml"},{"line_number":261,"context_line":"        if os.path.exists(script_ansible_path):"},{"line_number":262,"context_line":"            for file in os.listdir(script_ansible_path):"},{"line_number":263,"context_line":"                if file.endswith(\u0027yaml\u0027) and file.startswith(\u0027config\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"f7bf0a74_0c098429","line":260,"range":{"start_line":260,"start_character":15,"end_line":260,"end_character":21},"in_reply_to":"f599130d_3ac05d90","updated":"2022-03-15 12:07:52.000000000","message":"\u003e typo: Script\n\nCorrected the typo.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        script_ansible_config \u003d None"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # load ScritpANSIBLE/config.yaml"},{"line_number":261,"context_line":"        if os.path.exists(script_ansible_path):"},{"line_number":262,"context_line":"            for file in os.listdir(script_ansible_path):"},{"line_number":263,"context_line":"                if file.endswith(\u0027yaml\u0027) and file.startswith(\u0027config\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"f9465a88_72597a7c","line":260,"range":{"start_line":260,"start_character":15,"end_line":260,"end_character":21},"in_reply_to":"f7bf0a74_0c098429","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ed4f687af39496bc2ced8c1064f7a320a57eaede","unresolved":true,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        script_ansible_config \u003d None"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # load ScriptAnsible/config.yaml"},{"line_number":267,"context_line":"        if os.path.exists(script_ansible_path):"},{"line_number":268,"context_line":"            for file in os.listdir(script_ansible_path):"},{"line_number":269,"context_line":"                if file.endswith(\u0027yaml\u0027) and file.startswith(\u0027config\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"11669498_e8056533","line":266,"range":{"start_line":266,"start_character":15,"end_line":266,"end_character":28},"updated":"2022-03-15 12:51:12.000000000","message":"In response to the comments below, I think you should rename the folder to \"ScriptANSIBLE\" in this comment.\n\nhttps://review.opendev.org/c/openstack/tacker/+/830948/13#message-17b23023ab5461757080eb6212d803eddc917bef","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9a1a484c759d7f83f033730c45b8560eaf589def","unresolved":true,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        script_ansible_config \u003d None"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # load ScriptAnsible/config.yaml"},{"line_number":267,"context_line":"        if os.path.exists(script_ansible_path):"},{"line_number":268,"context_line":"            for file in os.listdir(script_ansible_path):"},{"line_number":269,"context_line":"                if file.endswith(\u0027yaml\u0027) and file.startswith(\u0027config\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"80bd91d5_4fc72e7d","line":266,"range":{"start_line":266,"start_character":15,"end_line":266,"end_character":28},"in_reply_to":"11669498_e8056533","updated":"2022-03-15 12:54:12.000000000","message":"\u003e In response to the comments below, I think you should rename the folder to \"ScriptANSIBLE\" in this comment.\n\u003e \n\u003e https://review.opendev.org/c/openstack/tacker/+/830948/13#message-17b23023ab5461757080eb6212d803eddc917bef\n\nYes, this has been updated already in the latest patch.","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2f1e4899de5129d943cc9cb3d60936142840f87f","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        script_ansible_config \u003d None"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        # load ScriptAnsible/config.yaml"},{"line_number":267,"context_line":"        if os.path.exists(script_ansible_path):"},{"line_number":268,"context_line":"            for file in os.listdir(script_ansible_path):"},{"line_number":269,"context_line":"                if file.endswith(\u0027yaml\u0027) and file.startswith(\u0027config\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"8c484491_9ccf7954","line":266,"range":{"start_line":266,"start_character":15,"end_line":266,"end_character":28},"in_reply_to":"80bd91d5_4fc72e7d","updated":"2022-03-16 07:26:07.000000000","message":"Ack","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"}],"samples/mgmt_driver/ansible/config_actions/vm_app_config/ansible_playbook_exec.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        target_user \u003d conf_value.get(\"username\", \"\")"},{"line_number":38,"context_line":"        target_password \u003d conf_value.get(\"password\", \"\")"},{"line_number":39,"context_line":"        target_private_key_file \u003d conf_value.get(\"priv_key_file\", \"\")"},{"line_number":40,"context_line":"        target_host \u003d {}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        target_host[\"target_user\"] \u003d target_user"},{"line_number":43,"context_line":"        target_host[\"target_password\"] \u003d target_password"},{"line_number":44,"context_line":"        target_host[\"target_private_key_file\"] \u003d target_private_key_file"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        return target_host"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"78581fbc_f6190a17","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":72},"updated":"2022-03-15 05:38:35.000000000","message":"I think it is easier to see if you change it as follow:\n```\n        target_host \u003d {\n            \"target_user\": target_user,\n            \"target_password\": target_password,\n            \"target_private_key_file\": target_private_key_file\n        }\n```","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        target_user \u003d conf_value.get(\"username\", \"\")"},{"line_number":38,"context_line":"        target_password \u003d conf_value.get(\"password\", \"\")"},{"line_number":39,"context_line":"        target_private_key_file \u003d conf_value.get(\"priv_key_file\", \"\")"},{"line_number":40,"context_line":"        target_host \u003d {}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        target_host[\"target_user\"] \u003d target_user"},{"line_number":43,"context_line":"        target_host[\"target_password\"] \u003d target_password"},{"line_number":44,"context_line":"        target_host[\"target_private_key_file\"] \u003d target_private_key_file"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        return target_host"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ffc415e6_0182271a","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":72},"in_reply_to":"78581fbc_f6190a17","updated":"2022-03-15 12:07:52.000000000","message":"\u003e I think it is easier to see if you change it as follow:\n\u003e ```\n\u003e         target_host \u003d {\n\u003e             \"target_user\": target_user,\n\u003e             \"target_password\": target_password,\n\u003e             \"target_private_key_file\": target_private_key_file\n\u003e         }\n\u003e ```\n\nWe modified based on your suggestion.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        target_user \u003d conf_value.get(\"username\", \"\")"},{"line_number":38,"context_line":"        target_password \u003d conf_value.get(\"password\", \"\")"},{"line_number":39,"context_line":"        target_private_key_file \u003d conf_value.get(\"priv_key_file\", \"\")"},{"line_number":40,"context_line":"        target_host \u003d {}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        target_host[\"target_user\"] \u003d target_user"},{"line_number":43,"context_line":"        target_host[\"target_password\"] \u003d target_password"},{"line_number":44,"context_line":"        target_host[\"target_private_key_file\"] \u003d target_private_key_file"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        return target_host"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dc086285_0c37fe48","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":72},"in_reply_to":"ffc415e6_0182271a","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        )"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # substitute passed VNF parameter to its corresponding value"},{"line_number":153,"context_line":"        inline_param \u003d {}"},{"line_number":154,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":155,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":156,"context_line":"        return self._cfg_parser.substitute(cmd_raw, **inline_param)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _is_execution_error(self, res_code):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b29e7015_0570ec9b","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":39},"updated":"2022-03-15 05:38:35.000000000","message":"I think it is easier to see if you change it as follow:\n```\n        inline_param \u003d {\n            \u0027mgmt_ip_address\u0027: self._mgmt_ip_address,\n            \u0027vdu\u0027: self._vdu\n        }\n```","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        )"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # substitute passed VNF parameter to its corresponding value"},{"line_number":153,"context_line":"        inline_param \u003d {}"},{"line_number":154,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":155,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":156,"context_line":"        return self._cfg_parser.substitute(cmd_raw, **inline_param)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _is_execution_error(self, res_code):"}],"source_content_type":"text/x-python","patch_set":6,"id":"6d189d40_2226da74","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":39},"in_reply_to":"0e3ac4b7_8bebc7c2","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        )"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # substitute passed VNF parameter to its corresponding value"},{"line_number":153,"context_line":"        inline_param \u003d {}"},{"line_number":154,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":155,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":156,"context_line":"        return self._cfg_parser.substitute(cmd_raw, **inline_param)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _is_execution_error(self, res_code):"}],"source_content_type":"text/x-python","patch_set":6,"id":"0e3ac4b7_8bebc7c2","line":155,"range":{"start_line":153,"start_character":0,"end_line":155,"end_character":39},"in_reply_to":"b29e7015_0570ec9b","updated":"2022-03-15 12:07:52.000000000","message":"\u003e I think it is easier to see if you change it as follow:\n\u003e ```\n\u003e         inline_param \u003d {\n\u003e             \u0027mgmt_ip_address\u0027: self._mgmt_ip_address,\n\u003e             \u0027vdu\u0027: self._vdu\n\u003e         }\n\u003e ```\n\nWe modified based on your suggestion.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"}],"samples/mgmt_driver/ansible/config_actions/vm_app_config/config_walker.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":35,"context_line":"            )"},{"line_number":36,"context_line":"        LOG.debug(\"vdu_dict: {}\".format(vdu_dict))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        creds \u003d {}"},{"line_number":39,"context_line":"        creds[\"username\"] \u003d vdu_dict.get(\"username\", \"\")"},{"line_number":40,"context_line":"        creds[\"password\"] \u003d vdu_dict.get(\"password\", \"\")"},{"line_number":41,"context_line":"        creds[\"priv_key_file\"] \u003d vdu_dict.get(\"priv_key_file\", \"\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        LOG.debug(\"creds: {}\".format(creds))"},{"line_number":44,"context_line":"        return creds"}],"source_content_type":"text/x-python","patch_set":6,"id":"7d1ce32a_f5efe98f","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":66},"updated":"2022-03-15 05:38:35.000000000","message":"I think it is easier to see if you change it as follow:\n```\n        creds \u003d {\n            \"username\": vdu_dict.get(\"username\", \"\"),\n            \"password\": vdu_dict.get(\"password\", \"\"),\n            \"priv_key_file\": vdu_dict.get(\"priv_key_file\", \"\")\n        }\n```","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":35,"context_line":"            )"},{"line_number":36,"context_line":"        LOG.debug(\"vdu_dict: {}\".format(vdu_dict))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        creds \u003d {}"},{"line_number":39,"context_line":"        creds[\"username\"] \u003d vdu_dict.get(\"username\", \"\")"},{"line_number":40,"context_line":"        creds[\"password\"] \u003d vdu_dict.get(\"password\", \"\")"},{"line_number":41,"context_line":"        creds[\"priv_key_file\"] \u003d vdu_dict.get(\"priv_key_file\", \"\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        LOG.debug(\"creds: {}\".format(creds))"},{"line_number":44,"context_line":"        return creds"}],"source_content_type":"text/x-python","patch_set":6,"id":"90424e76_87c526cf","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":66},"in_reply_to":"7d1ce32a_f5efe98f","updated":"2022-03-15 12:07:52.000000000","message":"\u003e I think it is easier to see if you change it as follow:\n\u003e ```\n\u003e         creds \u003d {\n\u003e             \"username\": vdu_dict.get(\"username\", \"\"),\n\u003e             \"password\": vdu_dict.get(\"password\", \"\"),\n\u003e             \"priv_key_file\": vdu_dict.get(\"priv_key_file\", \"\")\n\u003e         }\n\u003e ```\n\nWe modified based on your suggestion.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            )"},{"line_number":36,"context_line":"        LOG.debug(\"vdu_dict: {}\".format(vdu_dict))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        creds \u003d {}"},{"line_number":39,"context_line":"        creds[\"username\"] \u003d vdu_dict.get(\"username\", \"\")"},{"line_number":40,"context_line":"        creds[\"password\"] \u003d vdu_dict.get(\"password\", \"\")"},{"line_number":41,"context_line":"        creds[\"priv_key_file\"] \u003d vdu_dict.get(\"priv_key_file\", \"\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        LOG.debug(\"creds: {}\".format(creds))"},{"line_number":44,"context_line":"        return creds"}],"source_content_type":"text/x-python","patch_set":6,"id":"15c0995c_ba290e02","line":41,"range":{"start_line":38,"start_character":0,"end_line":41,"end_character":66},"in_reply_to":"90424e76_87c526cf","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"}],"samples/mgmt_driver/ansible/config_actions/vm_app_config/executor.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            LOG.debug(\"Skip execution for VDU: {}\".format(self._vdu))"},{"line_number":87,"context_line":"            return"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self._conf_opts[\"user\"] \u003d cfg.CONF.ansible.user"},{"line_number":90,"context_line":"        self._conf_opts[\"password\"] \u003d cfg.CONF.ansible.password"},{"line_number":91,"context_line":"        self._conf_opts[\"host\"] \u003d cfg.CONF.ansible.host"},{"line_number":92,"context_line":"        self._conf_opts[\"private_key_file\"] \u003d \\"},{"line_number":93,"context_line":"            cfg.CONF.ansible.private_key_file"},{"line_number":94,"context_line":"        retry_count \u003d self._conf_value.get(\"retry_count\","},{"line_number":95,"context_line":"            cfg.CONF.ansible.retry_count)"},{"line_number":96,"context_line":"        retry_interval \u003d self._conf_value.get(\"retry_interval\","}],"source_content_type":"text/x-python","patch_set":6,"id":"cfb9ff61_21f46077","line":93,"range":{"start_line":89,"start_character":0,"end_line":93,"end_character":45},"updated":"2022-03-15 05:38:35.000000000","message":"I think it is easier to see if you change it as follow:\n```\n        self._conf_opts \u003d {\n            \"user\": cfg.CONF.ansible.user,\n            \"password\": cfg.CONF.ansible.password,\n            \"host\": cfg.CONF.ansible.host,\n            \"private_key_file\": cfg.CONF.ansible.private_key_file\n        }\n```","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            LOG.debug(\"Skip execution for VDU: {}\".format(self._vdu))"},{"line_number":87,"context_line":"            return"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self._conf_opts[\"user\"] \u003d cfg.CONF.ansible.user"},{"line_number":90,"context_line":"        self._conf_opts[\"password\"] \u003d cfg.CONF.ansible.password"},{"line_number":91,"context_line":"        self._conf_opts[\"host\"] \u003d cfg.CONF.ansible.host"},{"line_number":92,"context_line":"        self._conf_opts[\"private_key_file\"] \u003d \\"},{"line_number":93,"context_line":"            cfg.CONF.ansible.private_key_file"},{"line_number":94,"context_line":"        retry_count \u003d self._conf_value.get(\"retry_count\","},{"line_number":95,"context_line":"            cfg.CONF.ansible.retry_count)"},{"line_number":96,"context_line":"        retry_interval \u003d self._conf_value.get(\"retry_interval\","}],"source_content_type":"text/x-python","patch_set":6,"id":"65ba7f6a_b70758d0","line":93,"range":{"start_line":89,"start_character":0,"end_line":93,"end_character":45},"in_reply_to":"a596b1ec_b7196d32","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            LOG.debug(\"Skip execution for VDU: {}\".format(self._vdu))"},{"line_number":87,"context_line":"            return"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self._conf_opts[\"user\"] \u003d cfg.CONF.ansible.user"},{"line_number":90,"context_line":"        self._conf_opts[\"password\"] \u003d cfg.CONF.ansible.password"},{"line_number":91,"context_line":"        self._conf_opts[\"host\"] \u003d cfg.CONF.ansible.host"},{"line_number":92,"context_line":"        self._conf_opts[\"private_key_file\"] \u003d \\"},{"line_number":93,"context_line":"            cfg.CONF.ansible.private_key_file"},{"line_number":94,"context_line":"        retry_count \u003d self._conf_value.get(\"retry_count\","},{"line_number":95,"context_line":"            cfg.CONF.ansible.retry_count)"},{"line_number":96,"context_line":"        retry_interval \u003d self._conf_value.get(\"retry_interval\","}],"source_content_type":"text/x-python","patch_set":6,"id":"a596b1ec_b7196d32","line":93,"range":{"start_line":89,"start_character":0,"end_line":93,"end_character":45},"in_reply_to":"cfb9ff61_21f46077","updated":"2022-03-15 12:07:52.000000000","message":"\u003e I think it is easier to see if you change it as follow:\n\u003e ```\n\u003e         self._conf_opts \u003d {\n\u003e             \"user\": cfg.CONF.ansible.user,\n\u003e             \"password\": cfg.CONF.ansible.password,\n\u003e             \"host\": cfg.CONF.ansible.host,\n\u003e             \"private_key_file\": cfg.CONF.ansible.private_key_file\n\u003e         }\n\u003e ```\n\nWe modified based on your suggestion.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            self._mgmt_url)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # translate some params"},{"line_number":113,"context_line":"        inline_param \u003d {}"},{"line_number":114,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":115,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        retry_count \u003d self._cfg_parser.substitute(retry_count, **inline_param)"},{"line_number":118,"context_line":"        retry_interval \u003d self._cfg_parser.substitute(retry_interval,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2ce39d5f_b640a751","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":39},"updated":"2022-03-15 05:38:35.000000000","message":"I think it is easier to see if you change it as follow:\n```\n        inline_param \u003d {\n            \u0027mgmt_ip_address\u0027: self._mgmt_ip_address,\n            \u0027vdu\u0027: self._vdu\n        }\n```","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            self._mgmt_url)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # translate some params"},{"line_number":113,"context_line":"        inline_param \u003d {}"},{"line_number":114,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":115,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        retry_count \u003d self._cfg_parser.substitute(retry_count, **inline_param)"},{"line_number":118,"context_line":"        retry_interval \u003d self._cfg_parser.substitute(retry_interval,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d058bd7f_e350af89","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":39},"in_reply_to":"2ce39d5f_b640a751","updated":"2022-03-15 12:07:52.000000000","message":"\u003e I think it is easier to see if you change it as follow:\n\u003e ```\n\u003e         inline_param \u003d {\n\u003e             \u0027mgmt_ip_address\u0027: self._mgmt_ip_address,\n\u003e             \u0027vdu\u0027: self._vdu\n\u003e         }\n\u003e ```\n\nWe modified based on your suggestion.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            self._mgmt_url)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # translate some params"},{"line_number":113,"context_line":"        inline_param \u003d {}"},{"line_number":114,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":115,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        retry_count \u003d self._cfg_parser.substitute(retry_count, **inline_param)"},{"line_number":118,"context_line":"        retry_interval \u003d self._cfg_parser.substitute(retry_interval,"}],"source_content_type":"text/x-python","patch_set":6,"id":"872c6176_9066b795","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":39},"in_reply_to":"d058bd7f_e350af89","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":214,"context_line":"    def _execute_cmd(self, cmd, retry_count, retry_interval,"},{"line_number":215,"context_line":"            connection_wait_timeout, command_execution_wait_timeout):"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        if self._local_execute_host:"},{"line_number":218,"context_line":"            user \u003d self._local_execute_host[\"user\"]"},{"line_number":219,"context_line":"            host \u003d self._local_execute_host[\"host\"]"},{"line_number":220,"context_line":"            password \u003d self._local_execute_host[\"password\"]"},{"line_number":221,"context_line":"            host_private_key_file \u003d \\"},{"line_number":222,"context_line":"                self._local_execute_host[\"host_private_key_file\"]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        else:"},{"line_number":225,"context_line":"            user \u003d self._execute_host[\"user\"]"},{"line_number":226,"context_line":"            host \u003d self._execute_host[\"host\"]"},{"line_number":227,"context_line":"            password \u003d self._execute_host[\"password\"]"},{"line_number":228,"context_line":"            host_private_key_file \u003d \\"},{"line_number":229,"context_line":"                self._execute_host[\"host_private_key_file\"]"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        LOG.debug(\"Executing command: {} for VDU {}, host: {}, \""},{"line_number":232,"context_line":"            \"username: {}, password: {}, private_key_file {}\".format("},{"line_number":233,"context_line":"                cmd, self._vdu, host, user, password, host_private_key_file))"}],"source_content_type":"text/x-python","patch_set":6,"id":"21abfbdf_3a4b361a","line":230,"range":{"start_line":217,"start_character":0,"end_line":230,"end_character":0},"updated":"2022-03-15 05:38:35.000000000","message":"Do you get these parameters just for logging?","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":214,"context_line":"    def _execute_cmd(self, cmd, retry_count, retry_interval,"},{"line_number":215,"context_line":"            connection_wait_timeout, command_execution_wait_timeout):"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        if self._local_execute_host:"},{"line_number":218,"context_line":"            user \u003d self._local_execute_host[\"user\"]"},{"line_number":219,"context_line":"            host \u003d self._local_execute_host[\"host\"]"},{"line_number":220,"context_line":"            password \u003d self._local_execute_host[\"password\"]"},{"line_number":221,"context_line":"            host_private_key_file \u003d \\"},{"line_number":222,"context_line":"                self._local_execute_host[\"host_private_key_file\"]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        else:"},{"line_number":225,"context_line":"            user \u003d self._execute_host[\"user\"]"},{"line_number":226,"context_line":"            host \u003d self._execute_host[\"host\"]"},{"line_number":227,"context_line":"            password \u003d self._execute_host[\"password\"]"},{"line_number":228,"context_line":"            host_private_key_file \u003d \\"},{"line_number":229,"context_line":"                self._execute_host[\"host_private_key_file\"]"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        LOG.debug(\"Executing command: {} for VDU {}, host: {}, \""},{"line_number":232,"context_line":"            \"username: {}, password: {}, private_key_file {}\".format("},{"line_number":233,"context_line":"                cmd, self._vdu, host, user, password, host_private_key_file))"}],"source_content_type":"text/x-python","patch_set":6,"id":"36af03c2_82bb6742","line":230,"range":{"start_line":217,"start_character":0,"end_line":230,"end_character":0},"in_reply_to":"21abfbdf_3a4b361a","updated":"2022-03-15 12:07:52.000000000","message":"\u003e Do you get these parameters just for logging?\n\nYes, it is only for logging.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    def _execute_cmd(self, cmd, retry_count, retry_interval,"},{"line_number":215,"context_line":"            connection_wait_timeout, command_execution_wait_timeout):"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        if self._local_execute_host:"},{"line_number":218,"context_line":"            user \u003d self._local_execute_host[\"user\"]"},{"line_number":219,"context_line":"            host \u003d self._local_execute_host[\"host\"]"},{"line_number":220,"context_line":"            password \u003d self._local_execute_host[\"password\"]"},{"line_number":221,"context_line":"            host_private_key_file \u003d \\"},{"line_number":222,"context_line":"                self._local_execute_host[\"host_private_key_file\"]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        else:"},{"line_number":225,"context_line":"            user \u003d self._execute_host[\"user\"]"},{"line_number":226,"context_line":"            host \u003d self._execute_host[\"host\"]"},{"line_number":227,"context_line":"            password \u003d self._execute_host[\"password\"]"},{"line_number":228,"context_line":"            host_private_key_file \u003d \\"},{"line_number":229,"context_line":"                self._execute_host[\"host_private_key_file\"]"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        LOG.debug(\"Executing command: {} for VDU {}, host: {}, \""},{"line_number":232,"context_line":"            \"username: {}, password: {}, private_key_file {}\".format("},{"line_number":233,"context_line":"                cmd, self._vdu, host, user, password, host_private_key_file))"}],"source_content_type":"text/x-python","patch_set":6,"id":"6cb072ad_eb4ff93a","line":230,"range":{"start_line":217,"start_character":0,"end_line":230,"end_character":0},"in_reply_to":"36af03c2_82bb6742","updated":"2022-03-15 12:28:30.000000000","message":"Thanks for your answer, I got it.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _get_execute_host(self, execute_host, conf_value\u003dNone,"},{"line_number":269,"context_line":"            use_default\u003dTrue):"},{"line_number":270,"context_line":"        # some inline varaibles for parameter translation"},{"line_number":271,"context_line":"        inline_param \u003d {}"},{"line_number":272,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":273,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"}],"source_content_type":"text/x-python","patch_set":6,"id":"ee92185f_5a9bbee3","line":270,"range":{"start_line":270,"start_character":22,"end_line":270,"end_character":31},"updated":"2022-03-15 05:38:35.000000000","message":"typo: variables","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _get_execute_host(self, execute_host, conf_value\u003dNone,"},{"line_number":269,"context_line":"            use_default\u003dTrue):"},{"line_number":270,"context_line":"        # some inline varaibles for parameter translation"},{"line_number":271,"context_line":"        inline_param \u003d {}"},{"line_number":272,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":273,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a646f23_1c2c65b0","line":270,"range":{"start_line":270,"start_character":22,"end_line":270,"end_character":31},"in_reply_to":"c4518b03_cc40a537","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    def _get_execute_host(self, execute_host, conf_value\u003dNone,"},{"line_number":269,"context_line":"            use_default\u003dTrue):"},{"line_number":270,"context_line":"        # some inline varaibles for parameter translation"},{"line_number":271,"context_line":"        inline_param \u003d {}"},{"line_number":272,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":273,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"}],"source_content_type":"text/x-python","patch_set":6,"id":"c4518b03_cc40a537","line":270,"range":{"start_line":270,"start_character":22,"end_line":270,"end_character":31},"in_reply_to":"ee92185f_5a9bbee3","updated":"2022-03-15 12:07:52.000000000","message":"\u003e typo: variables\n\nCorrected the typo.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":268,"context_line":"    def _get_execute_host(self, execute_host, conf_value\u003dNone,"},{"line_number":269,"context_line":"            use_default\u003dTrue):"},{"line_number":270,"context_line":"        # some inline varaibles for parameter translation"},{"line_number":271,"context_line":"        inline_param \u003d {}"},{"line_number":272,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":273,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if not execute_host:"},{"line_number":276,"context_line":"            if use_default:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1daf8759_4e7b1a95","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":39},"updated":"2022-03-15 05:38:35.000000000","message":"I think it is easier to see if you change it as follow:\n```\n        inline_param \u003d {\n            \u0027mgmt_ip_address\u0027: self._mgmt_ip_address,\n            \u0027vdu\u0027: self._vdu\n        }\n```","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9a1a484c759d7f83f033730c45b8560eaf589def","unresolved":true,"context_lines":[{"line_number":268,"context_line":"    def _get_execute_host(self, execute_host, conf_value\u003dNone,"},{"line_number":269,"context_line":"            use_default\u003dTrue):"},{"line_number":270,"context_line":"        # some inline varaibles for parameter translation"},{"line_number":271,"context_line":"        inline_param \u003d {}"},{"line_number":272,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":273,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if not execute_host:"},{"line_number":276,"context_line":"            if use_default:"}],"source_content_type":"text/x-python","patch_set":6,"id":"e771f48d_77910c33","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":39},"in_reply_to":"1d912139_2890d8e1","updated":"2022-03-15 12:54:12.000000000","message":"\u003e Here have not be modified.\n\nWe have updated it in the latest patch.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b458ee448aeb8364add7f2e3f86bb9b118f07ab1","unresolved":true,"context_lines":[{"line_number":268,"context_line":"    def _get_execute_host(self, execute_host, conf_value\u003dNone,"},{"line_number":269,"context_line":"            use_default\u003dTrue):"},{"line_number":270,"context_line":"        # some inline varaibles for parameter translation"},{"line_number":271,"context_line":"        inline_param \u003d {}"},{"line_number":272,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":273,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if not execute_host:"},{"line_number":276,"context_line":"            if use_default:"}],"source_content_type":"text/x-python","patch_set":6,"id":"62d1784c_dca45833","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":39},"in_reply_to":"1daf8759_4e7b1a95","updated":"2022-03-15 12:07:52.000000000","message":"\u003e I think it is easier to see if you change it as follow:\n\u003e ```\n\u003e         inline_param \u003d {\n\u003e             \u0027mgmt_ip_address\u0027: self._mgmt_ip_address,\n\u003e             \u0027vdu\u0027: self._vdu\n\u003e         }\n\u003e ```\n\nWe modified based on your suggestion.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":true,"context_lines":[{"line_number":268,"context_line":"    def _get_execute_host(self, execute_host, conf_value\u003dNone,"},{"line_number":269,"context_line":"            use_default\u003dTrue):"},{"line_number":270,"context_line":"        # some inline varaibles for parameter translation"},{"line_number":271,"context_line":"        inline_param \u003d {}"},{"line_number":272,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":273,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if not execute_host:"},{"line_number":276,"context_line":"            if use_default:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1d912139_2890d8e1","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":39},"in_reply_to":"62d1784c_dca45833","updated":"2022-03-15 12:28:30.000000000","message":"Here have not be modified.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2f1e4899de5129d943cc9cb3d60936142840f87f","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    def _get_execute_host(self, execute_host, conf_value\u003dNone,"},{"line_number":269,"context_line":"            use_default\u003dTrue):"},{"line_number":270,"context_line":"        # some inline varaibles for parameter translation"},{"line_number":271,"context_line":"        inline_param \u003d {}"},{"line_number":272,"context_line":"        inline_param[\u0027mgmt_ip_address\u0027] \u003d self._mgmt_ip_address"},{"line_number":273,"context_line":"        inline_param[\u0027vdu\u0027] \u003d self._vdu"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        if not execute_host:"},{"line_number":276,"context_line":"            if use_default:"}],"source_content_type":"text/x-python","patch_set":6,"id":"470a9b51_3d0f09f7","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":39},"in_reply_to":"e771f48d_77910c33","updated":"2022-03-16 07:26:07.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                return None"},{"line_number":281,"context_line":"        else:"},{"line_number":282,"context_line":"            vdu_creds \u003d {}"},{"line_number":283,"context_line":"            host_name \u003d execute_host.get(\"host\", \"\")"},{"line_number":284,"context_line":"            # process host"},{"line_number":285,"context_line":"            if host_name in self._mgmt_url:"}],"source_content_type":"text/x-python","patch_set":6,"id":"95357d82_1b3a0b04","line":282,"range":{"start_line":282,"start_character":12,"end_line":282,"end_character":26},"updated":"2022-03-15 05:38:35.000000000","message":"Do you need to initialize this variable?","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9a1a484c759d7f83f033730c45b8560eaf589def","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                return None"},{"line_number":281,"context_line":"        else:"},{"line_number":282,"context_line":"            vdu_creds \u003d {}"},{"line_number":283,"context_line":"            host_name \u003d execute_host.get(\"host\", \"\")"},{"line_number":284,"context_line":"            # process host"},{"line_number":285,"context_line":"            if host_name in self._mgmt_url:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ae8be11a_7f78512a","line":282,"range":{"start_line":282,"start_character":12,"end_line":282,"end_character":26},"in_reply_to":"5ee4f78b_8451a787","updated":"2022-03-15 12:54:12.000000000","message":"\u003e any answer?\n\nIt is not necessary so it is removed.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9a1a484c759d7f83f033730c45b8560eaf589def","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                return None"},{"line_number":281,"context_line":"        else:"},{"line_number":282,"context_line":"            vdu_creds \u003d {}"},{"line_number":283,"context_line":"            host_name \u003d execute_host.get(\"host\", \"\")"},{"line_number":284,"context_line":"            # process host"},{"line_number":285,"context_line":"            if host_name in self._mgmt_url:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5bc6b0de_6b57b22c","line":282,"range":{"start_line":282,"start_character":12,"end_line":282,"end_character":26},"in_reply_to":"5ee4f78b_8451a787","updated":"2022-03-15 12:54:12.000000000","message":"\u003e any answer?\n\nIt is not needed, so it is removed.","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                return None"},{"line_number":281,"context_line":"        else:"},{"line_number":282,"context_line":"            vdu_creds \u003d {}"},{"line_number":283,"context_line":"            host_name \u003d execute_host.get(\"host\", \"\")"},{"line_number":284,"context_line":"            # process host"},{"line_number":285,"context_line":"            if host_name in self._mgmt_url:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ee4f78b_8451a787","line":282,"range":{"start_line":282,"start_character":12,"end_line":282,"end_character":26},"in_reply_to":"95357d82_1b3a0b04","updated":"2022-03-15 12:28:30.000000000","message":"any answer?","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2f1e4899de5129d943cc9cb3d60936142840f87f","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                return None"},{"line_number":281,"context_line":"        else:"},{"line_number":282,"context_line":"            vdu_creds \u003d {}"},{"line_number":283,"context_line":"            host_name \u003d execute_host.get(\"host\", \"\")"},{"line_number":284,"context_line":"            # process host"},{"line_number":285,"context_line":"            if host_name in self._mgmt_url:"}],"source_content_type":"text/x-python","patch_set":6,"id":"d2463617_776b8772","line":282,"range":{"start_line":282,"start_character":12,"end_line":282,"end_character":26},"in_reply_to":"ae8be11a_7f78512a","updated":"2022-03-16 07:26:07.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":322,"context_line":"        host_private_key_file \u003d self._cfg_parser.substitute("},{"line_number":323,"context_line":"            host_private_key_file, **inline_param)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        execute_host \u003d {}"},{"line_number":326,"context_line":"        execute_host[\"user\"] \u003d user"},{"line_number":327,"context_line":"        execute_host[\"password\"] \u003d password"},{"line_number":328,"context_line":"        execute_host[\"host\"] \u003d host"},{"line_number":329,"context_line":"        execute_host[\"host_private_key_file\"] \u003d host_private_key_file"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        LOG.debug(\"execute-host-\u003euser: {}\".format(user))"},{"line_number":332,"context_line":"        LOG.debug(\"execute-host-\u003epassword: {}\".format(password))"}],"source_content_type":"text/x-python","patch_set":6,"id":"adc31ef2_9abdee42","line":329,"range":{"start_line":325,"start_character":0,"end_line":329,"end_character":69},"updated":"2022-03-15 05:38:35.000000000","message":"I think it is easier to see if you change it as follow:\n```\n        execute_host \u003d {\n            \"user: user,\n            \"password: password,\n            \"host\": host,\n            \"host_private_key_file\": host_private_key_file\n        }\n```","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        host_private_key_file \u003d self._cfg_parser.substitute("},{"line_number":323,"context_line":"            host_private_key_file, **inline_param)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        execute_host \u003d {}"},{"line_number":326,"context_line":"        execute_host[\"user\"] \u003d user"},{"line_number":327,"context_line":"        execute_host[\"password\"] \u003d password"},{"line_number":328,"context_line":"        execute_host[\"host\"] \u003d host"},{"line_number":329,"context_line":"        execute_host[\"host_private_key_file\"] \u003d host_private_key_file"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        LOG.debug(\"execute-host-\u003euser: {}\".format(user))"},{"line_number":332,"context_line":"        LOG.debug(\"execute-host-\u003epassword: {}\".format(password))"}],"source_content_type":"text/x-python","patch_set":6,"id":"06d88af4_07cc796a","line":329,"range":{"start_line":325,"start_character":0,"end_line":329,"end_character":69},"in_reply_to":"adc31ef2_9abdee42","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"}],"samples/mgmt_driver/ansible/heat_client.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"96afec4de31e3792df247736f2ee6ef4475092b4","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    def __init__(self, context, plugin, vnf):"},{"line_number":23,"context_line":"        access_info \u003d plugin.get_vim(context, vnf)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        auth_attr \u003d {}"},{"line_number":26,"context_line":"        auth_attr[\"username\"] \u003d access_info[\"vim_auth\"][\"username\"]"},{"line_number":27,"context_line":"        auth_attr[\"password\"] \u003d access_info[\"vim_auth\"][\"password\"]"},{"line_number":28,"context_line":"        auth_attr[\"project_name\"] \u003d access_info[\"vim_auth\"][\"project_name\"]"},{"line_number":29,"context_line":"        auth_attr[\"cert_verify\"] \u003d access_info[\"vim_auth\"][\"cert_verify\"]"},{"line_number":30,"context_line":"        auth_attr[\"user_domain_name\"] \u003d \\"},{"line_number":31,"context_line":"            access_info[\"vim_auth\"][\"user_domain_name\"]"},{"line_number":32,"context_line":"        auth_attr[\"auth_url\"] \u003d access_info[\"vim_auth\"][\"auth_url\"]"},{"line_number":33,"context_line":"        auth_attr[\"project_id\"] \u003d access_info[\"vim_auth\"][\"project_id\"]"},{"line_number":34,"context_line":"        auth_attr[\"project_domain_name\"] \u003d \\"},{"line_number":35,"context_line":"            access_info[\"vim_auth\"][\"project_domain_name\"]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        region_name \u003d vnf.get(\u0027placement_attr\u0027, {}).get(\u0027region_name\u0027, None)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"e61365bc_68fbcef2","line":35,"range":{"start_line":25,"start_character":0,"end_line":35,"end_character":58},"updated":"2022-03-15 05:38:35.000000000","message":"I think it is easier to see if you change it as follow:\n```\n        vim_auth \u003d access_info[\"vim_auth\"]\n        auth_attr \u003d {\n            \"username\": vim_auth[\"username\"],\n            \"password\": vim_auth[\"password\"],\n            \"project_name\": vim_auth[\"project_name\"],\n            \"cert_verify\": vim_auth[\"cert_verify\"],\n            \"user_domain_name\": vim_auth[\"user_domain_name\"],\n            \"auth_url\": vim_auth[\"auth_url\"],\n            \"project_id\": vim_auth[\"project_id\"],\n            \"project_domain_name\": vim_auth[\"project_domain_name\"]\n        }\n```","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"aaf53a0ac254d9c2b5c8f00a21c5b1c91a57f83c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def __init__(self, context, plugin, vnf):"},{"line_number":23,"context_line":"        access_info \u003d plugin.get_vim(context, vnf)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        auth_attr \u003d {}"},{"line_number":26,"context_line":"        auth_attr[\"username\"] \u003d access_info[\"vim_auth\"][\"username\"]"},{"line_number":27,"context_line":"        auth_attr[\"password\"] \u003d access_info[\"vim_auth\"][\"password\"]"},{"line_number":28,"context_line":"        auth_attr[\"project_name\"] \u003d access_info[\"vim_auth\"][\"project_name\"]"},{"line_number":29,"context_line":"        auth_attr[\"cert_verify\"] \u003d access_info[\"vim_auth\"][\"cert_verify\"]"},{"line_number":30,"context_line":"        auth_attr[\"user_domain_name\"] \u003d \\"},{"line_number":31,"context_line":"            access_info[\"vim_auth\"][\"user_domain_name\"]"},{"line_number":32,"context_line":"        auth_attr[\"auth_url\"] \u003d access_info[\"vim_auth\"][\"auth_url\"]"},{"line_number":33,"context_line":"        auth_attr[\"project_id\"] \u003d access_info[\"vim_auth\"][\"project_id\"]"},{"line_number":34,"context_line":"        auth_attr[\"project_domain_name\"] \u003d \\"},{"line_number":35,"context_line":"            access_info[\"vim_auth\"][\"project_domain_name\"]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        region_name \u003d vnf.get(\u0027placement_attr\u0027, {}).get(\u0027region_name\u0027, None)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"08ff380d_6a1ab1e4","line":35,"range":{"start_line":25,"start_character":0,"end_line":35,"end_character":58},"in_reply_to":"e61365bc_68fbcef2","updated":"2022-03-15 12:28:30.000000000","message":"Ack","commit_id":"b08e9ecf2eb58ca54dc05e6b15a8d02a67ad9225"}],"samples/mgmt_driver/ansible/utils.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ed4f687af39496bc2ced8c1064f7a320a57eaede","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from tacker.plugins.common import constants as plg_constants"},{"line_number":14,"context_line":"from tacker.vnfm.mgmt_drivers import constants as mgmt_constants"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"CONFIG_FOLDER \u003d \"ScriptAnsible\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def get_event_by_action(action, failed_vdu_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7d11813f_3fd36666","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":30},"updated":"2022-03-15 12:51:12.000000000","message":"In response to the comments below, I think you should change value of CONFIG_FOLDER to \"ScriptANSIBLE\".\n\nhttps://review.opendev.org/c/openstack/tacker/+/830948/13#message-17b23023ab5461757080eb6212d803eddc917bef","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9a1a484c759d7f83f033730c45b8560eaf589def","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from tacker.plugins.common import constants as plg_constants"},{"line_number":14,"context_line":"from tacker.vnfm.mgmt_drivers import constants as mgmt_constants"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"CONFIG_FOLDER \u003d \"ScriptAnsible\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def get_event_by_action(action, failed_vdu_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"e4d9eb40_7c1d5ee7","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":30},"in_reply_to":"7d11813f_3fd36666","updated":"2022-03-15 12:54:12.000000000","message":"\u003e In response to the comments below, I think you should change value of CONFIG_FOLDER to \"ScriptANSIBLE\".\n\u003e \n\u003e https://review.opendev.org/c/openstack/tacker/+/830948/13#message-17b23023ab5461757080eb6212d803eddc917bef\n\nYes, this has been updated already in the latest patch.","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2f1e4899de5129d943cc9cb3d60936142840f87f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from tacker.plugins.common import constants as plg_constants"},{"line_number":14,"context_line":"from tacker.vnfm.mgmt_drivers import constants as mgmt_constants"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"CONFIG_FOLDER \u003d \"ScriptAnsible\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def get_event_by_action(action, failed_vdu_name):"}],"source_content_type":"text/x-python","patch_set":8,"id":"00a7d2f7_b4327a45","line":16,"range":{"start_line":16,"start_character":17,"end_line":16,"end_character":30},"in_reply_to":"e4d9eb40_7c1d5ee7","updated":"2022-03-16 07:26:07.000000000","message":"Ack","commit_id":"39da2411edf4a5587019805442810a98896fe4f1"}]}