)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support CNF update with MgmtDriver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch supports MgmtDriver in the operation"},{"line_number":10,"context_line":"of modifying VNF."},{"line_number":11,"context_line":"It provides a sample script MgmtDriver, when"},{"line_number":12,"context_line":"modifying CNF, If the ConfigMap and Secret"},{"line_number":13,"context_line":"are updated, the Pod and Deployment will also"},{"line_number":14,"context_line":"be updated (image only)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint container-update"},{"line_number":17,"context_line":"Change-Id: I1e7a1b03fef13f4c7a83488f6d2fdd7efc2e454b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"a94e4bb8_4d66a63c","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":0},"updated":"2022-03-04 14:13:16.000000000","message":"You can reduce line breaks a little more as below.\n\n```\nThis patch supports MgmtDriver in the operation of modifying VNF.\nIt provides a sample script MgmtDriver, when modifying CNF,\nIf the ConfigMap and Secret are updated, the Pod and Deployment will\nalso be updated (image only).\n```","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support CNF update with MgmtDriver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch supports MgmtDriver in the operation"},{"line_number":10,"context_line":"of modifying VNF."},{"line_number":11,"context_line":"It provides a sample script MgmtDriver, when"},{"line_number":12,"context_line":"modifying CNF, If the ConfigMap and Secret"},{"line_number":13,"context_line":"are updated, the Pod and Deployment will also"},{"line_number":14,"context_line":"be updated (image only)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint container-update"},{"line_number":17,"context_line":"Change-Id: I1e7a1b03fef13f4c7a83488f6d2fdd7efc2e454b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"c2833ea8_b1b7a414","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":0},"in_reply_to":"a94e4bb8_4d66a63c","updated":"2022-03-08 01:19:13.000000000","message":"I removed the extra newlines.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d3e84d616025e648648d41a51162989b76552394","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support CNF update with MgmtDriver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch supports MgmtDriver in the operation"},{"line_number":10,"context_line":"of modifying VNF."},{"line_number":11,"context_line":"It provides a sample script MgmtDriver, when"},{"line_number":12,"context_line":"modifying CNF, If the ConfigMap and Secret"},{"line_number":13,"context_line":"are updated, the Pod and Deployment will also"},{"line_number":14,"context_line":"be updated (image only)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint container-update"},{"line_number":17,"context_line":"Change-Id: I1e7a1b03fef13f4c7a83488f6d2fdd7efc2e454b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7636fb4e_b75e0b20","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":0},"in_reply_to":"c2833ea8_b1b7a414","updated":"2022-03-09 16:16:35.000000000","message":"I\u0027ve confirmed.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1da10f0306e32277f946640541ba312072396109","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"592a138c_ce0c04b8","updated":"2022-03-01 10:08:24.000000000","message":"recheck","commit_id":"95b5aef3867b97d26dd1a0e916a4f546c9400b01"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"9f8b245c25dd2732deebe4a57b0952fa090c26f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9d7283ca_13c877bd","updated":"2022-03-03 08:24:20.000000000","message":"Thank you for your work. Would you please check my comments.","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"01edad48_94beca0c","updated":"2022-03-04 14:13:16.000000000","message":"Thanks for your patch, please find my comments.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e1c99355_b197a973","updated":"2022-03-07 12:29:49.000000000","message":"Thank you for the patch\n\nPlease kindly find my comments.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"dc9f305c_587a2501","updated":"2022-03-08 09:54:59.000000000","message":"recheck","commit_id":"6419d4e5830245cb7a5966a56366e2f9e39b445b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"01290dcd_a53025c3","updated":"2022-03-09 05:15:29.000000000","message":"Thank you for re-work.\nAlmost LGTM.\n\nPlease quickly check one remaining issue :) ","commit_id":"22488ab096458a5b0cc1c2b604a77129d53895be"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b24a5237612ab6baf1c5a1370c0f58aeb1cd53fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e476b628_4290a0e4","updated":"2022-03-10 08:07:43.000000000","message":"Please find comment for test-setup-mgmt.sh. I\u0027m curious about there are several python files the order of importing is incorrect, but I\u0027d ignore them for now. Thanks.","commit_id":"885f06be0e6044a1431063c74c8526d66636a8d9"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"1c46c84533078e89de4b619f12a77ebe380430c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"25cd80ea_3b5b4739","updated":"2022-03-09 11:12:59.000000000","message":"Thank you for re-work!\n\nI confirmed all issues have been resolved.","commit_id":"885f06be0e6044a1431063c74c8526d66636a8d9"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"552257545b254c31f6987700c57697a2a6aa8311","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"fb5d668e_8de88654","updated":"2022-03-09 11:17:04.000000000","message":"Thank you for the fix. LGTM.","commit_id":"885f06be0e6044a1431063c74c8526d66636a8d9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d3e84d616025e648648d41a51162989b76552394","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9b7d6c4b_d70584db","updated":"2022-03-09 16:16:35.000000000","message":"Thanks for your rework, LGTM.","commit_id":"885f06be0e6044a1431063c74c8526d66636a8d9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3f277cef941e79c6f93fb986e6aef5a0fb0826ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"885de5ad_9013e75e","updated":"2022-03-10 09:47:18.000000000","message":"recheck","commit_id":"20d11052107b337883b4152409c4be861670fcb5"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1d694faa127a6af941ad30f49fd29cb54b3c1a50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"57718c82_7642ed3a","updated":"2022-03-10 19:16:06.000000000","message":"LGTM, thanks!","commit_id":"d219c49e11392b1537d6ccd2ad22a46a0c510f2c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"47dc64335e33850de2f1dcc5d342bbb9f5ea6bac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"fd862c4e_a6893b64","updated":"2022-03-10 12:43:13.000000000","message":"recheck","commit_id":"d219c49e11392b1537d6ccd2ad22a46a0c510f2c"}],"samples/mgmt_driver/kubernetes/container_update/container_update_mgmt.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            manifest_file \u003d os.path.join(vnf_package_path, file)"},{"line_number":68,"context_line":"            with open(manifest_file, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":69,"context_line":"                file_content \u003d f.read()"},{"line_number":70,"context_line":"        file_content_dict_list \u003d yaml.safe_load_all(file_content)"},{"line_number":71,"context_line":"        for file_content_dict in file_content_dict_list:"},{"line_number":72,"context_line":"            kind \u003d file_content_dict.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":73,"context_line":"            name \u003d file_content_dict.get(\u0027metadata\u0027, {}).get(\u0027name\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"b308fcfb_8ceb4fb4","line":70,"updated":"2022-03-07 12:29:49.000000000","message":"nits.\n\nPlease rename it to ``contents`` or ``objs``. Hungarian notation like _list, _dict is basically not necessary for Python. Even without that, using common words like content and obj inside a method will not cause any problems as the scope is limited.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            manifest_file \u003d os.path.join(vnf_package_path, file)"},{"line_number":68,"context_line":"            with open(manifest_file, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":69,"context_line":"                file_content \u003d f.read()"},{"line_number":70,"context_line":"        file_content_dict_list \u003d yaml.safe_load_all(file_content)"},{"line_number":71,"context_line":"        for file_content_dict in file_content_dict_list:"},{"line_number":72,"context_line":"            kind \u003d file_content_dict.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":73,"context_line":"            name \u003d file_content_dict.get(\u0027metadata\u0027, {}).get(\u0027name\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"f9d12c65_c2c13bfe","line":70,"in_reply_to":"564c4c40_b35ee181","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            manifest_file \u003d os.path.join(vnf_package_path, file)"},{"line_number":68,"context_line":"            with open(manifest_file, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":69,"context_line":"                file_content \u003d f.read()"},{"line_number":70,"context_line":"        file_content_dict_list \u003d yaml.safe_load_all(file_content)"},{"line_number":71,"context_line":"        for file_content_dict in file_content_dict_list:"},{"line_number":72,"context_line":"            kind \u003d file_content_dict.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":73,"context_line":"            name \u003d file_content_dict.get(\u0027metadata\u0027, {}).get(\u0027name\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"564c4c40_b35ee181","line":70,"in_reply_to":"b308fcfb_8ceb4fb4","updated":"2022-03-08 09:54:59.000000000","message":"I changed all the parameter names involving ``_list, _dict``.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            with open(manifest_file, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":69,"context_line":"                file_content \u003d f.read()"},{"line_number":70,"context_line":"        file_content_dict_list \u003d yaml.safe_load_all(file_content)"},{"line_number":71,"context_line":"        for file_content_dict in file_content_dict_list:"},{"line_number":72,"context_line":"            kind \u003d file_content_dict.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":73,"context_line":"            name \u003d file_content_dict.get(\u0027metadata\u0027, {}).get(\u0027name\u0027, \u0027\u0027)"},{"line_number":74,"context_line":"            kind_and_name_list.append({\u0027kind\u0027: kind, \u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":12,"id":"b5e760e1_cade81f4","line":71,"updated":"2022-03-07 12:29:49.000000000","message":"If you agree with the above comment. please rewrite this line in an appropriate way.\n\ne.g.,\n```\nfor obj in objs:\n```\nor\n```\nfor content in contents:\n```","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            with open(manifest_file, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":69,"context_line":"                file_content \u003d f.read()"},{"line_number":70,"context_line":"        file_content_dict_list \u003d yaml.safe_load_all(file_content)"},{"line_number":71,"context_line":"        for file_content_dict in file_content_dict_list:"},{"line_number":72,"context_line":"            kind \u003d file_content_dict.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":73,"context_line":"            name \u003d file_content_dict.get(\u0027metadata\u0027, {}).get(\u0027name\u0027, \u0027\u0027)"},{"line_number":74,"context_line":"            kind_and_name_list.append({\u0027kind\u0027: kind, \u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":12,"id":"26d01b6d_ca59b6ad","line":71,"in_reply_to":"a9f56f0c_86d5496b","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            with open(manifest_file, \u0027r\u0027, encoding\u003d\u0027utf-8\u0027) as f:"},{"line_number":69,"context_line":"                file_content \u003d f.read()"},{"line_number":70,"context_line":"        file_content_dict_list \u003d yaml.safe_load_all(file_content)"},{"line_number":71,"context_line":"        for file_content_dict in file_content_dict_list:"},{"line_number":72,"context_line":"            kind \u003d file_content_dict.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":73,"context_line":"            name \u003d file_content_dict.get(\u0027metadata\u0027, {}).get(\u0027name\u0027, \u0027\u0027)"},{"line_number":74,"context_line":"            kind_and_name_list.append({\u0027kind\u0027: kind, \u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":12,"id":"a9f56f0c_86d5496b","line":71,"in_reply_to":"b5e760e1_cade81f4","updated":"2022-03-08 09:54:59.000000000","message":"I changed this line to ``for file_content in file_contents:``.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            kind \u003d file_content_dict.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":73,"context_line":"            name \u003d file_content_dict.get(\u0027metadata\u0027, {}).get(\u0027name\u0027, \u0027\u0027)"},{"line_number":74,"context_line":"            kind_and_name_list.append({\u0027kind\u0027: kind, \u0027name\u0027: name})"},{"line_number":75,"context_line":"        return kind_and_name_list"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _initialize_k8s_client(self, auth_cred):"},{"line_number":78,"context_line":"        k8s_client_dict \u003d (kubernetes_utils.KubernetesHTTPAPI()."}],"source_content_type":"text/x-python","patch_set":12,"id":"b467bc8d_6f45ed19","line":75,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            kind \u003d file_content_dict.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":73,"context_line":"            name \u003d file_content_dict.get(\u0027metadata\u0027, {}).get(\u0027name\u0027, \u0027\u0027)"},{"line_number":74,"context_line":"            kind_and_name_list.append({\u0027kind\u0027: kind, \u0027name\u0027: name})"},{"line_number":75,"context_line":"        return kind_and_name_list"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _initialize_k8s_client(self, auth_cred):"},{"line_number":78,"context_line":"        k8s_client_dict \u003d (kubernetes_utils.KubernetesHTTPAPI()."}],"source_content_type":"text/x-python","patch_set":12,"id":"39f953aa_d74130d3","line":75,"in_reply_to":"6ef85591_9a9c59bb","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            kind \u003d file_content_dict.get(\u0027kind\u0027, \u0027\u0027)"},{"line_number":73,"context_line":"            name \u003d file_content_dict.get(\u0027metadata\u0027, {}).get(\u0027name\u0027, \u0027\u0027)"},{"line_number":74,"context_line":"            kind_and_name_list.append({\u0027kind\u0027: kind, \u0027name\u0027: name})"},{"line_number":75,"context_line":"        return kind_and_name_list"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _initialize_k8s_client(self, auth_cred):"},{"line_number":78,"context_line":"        k8s_client_dict \u003d (kubernetes_utils.KubernetesHTTPAPI()."}],"source_content_type":"text/x-python","patch_set":12,"id":"6ef85591_9a9c59bb","line":75,"in_reply_to":"b467bc8d_6f45ed19","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        k8s_config_objs \u003d []"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        for old_k8s_obj in old_k8s_objs:"},{"line_number":250,"context_line":"            old_k8s_obj_kind \u003d old_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":251,"context_line":"            old_k8s_obj_name \u003d old_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":252,"context_line":"            if old_k8s_obj_kind in [\u0027Pod\u0027, \u0027Deployment\u0027]:"},{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"}],"source_content_type":"text/x-python","patch_set":12,"id":"86313f6e_8721942f","line":250,"updated":"2022-03-07 12:29:49.000000000","message":"Is it necessary to use ``get``? If ``\u0027object\u0027`` is absent, an error will be raised even if the ``get`` is used.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        k8s_config_objs \u003d []"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        for old_k8s_obj in old_k8s_objs:"},{"line_number":250,"context_line":"            old_k8s_obj_kind \u003d old_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":251,"context_line":"            old_k8s_obj_name \u003d old_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":252,"context_line":"            if old_k8s_obj_kind in [\u0027Pod\u0027, \u0027Deployment\u0027]:"},{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"}],"source_content_type":"text/x-python","patch_set":12,"id":"b9d1210b_58c1d4fb","line":250,"in_reply_to":"571446e6_aeca6fbc","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        k8s_config_objs \u003d []"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        for old_k8s_obj in old_k8s_objs:"},{"line_number":250,"context_line":"            old_k8s_obj_kind \u003d old_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":251,"context_line":"            old_k8s_obj_name \u003d old_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":252,"context_line":"            if old_k8s_obj_kind in [\u0027Pod\u0027, \u0027Deployment\u0027]:"},{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"}],"source_content_type":"text/x-python","patch_set":12,"id":"571446e6_aeca6fbc","line":250,"in_reply_to":"86313f6e_8721942f","updated":"2022-03-08 09:54:59.000000000","message":"I changed ``.get(\u0027object\u0027)`` to ``[\u0027object\u0027]``.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        for old_k8s_obj in old_k8s_objs:"},{"line_number":250,"context_line":"            old_k8s_obj_kind \u003d old_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":251,"context_line":"            old_k8s_obj_name \u003d old_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":252,"context_line":"            if old_k8s_obj_kind in [\u0027Pod\u0027, \u0027Deployment\u0027]:"},{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":254,"context_line":"                    # If the old and new k8s_obj have the same kind and name"}],"source_content_type":"text/x-python","patch_set":12,"id":"f34e5f43_a4ad4e8b","line":251,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        for old_k8s_obj in old_k8s_objs:"},{"line_number":250,"context_line":"            old_k8s_obj_kind \u003d old_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":251,"context_line":"            old_k8s_obj_name \u003d old_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":252,"context_line":"            if old_k8s_obj_kind in [\u0027Pod\u0027, \u0027Deployment\u0027]:"},{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":254,"context_line":"                    # If the old and new k8s_obj have the same kind and name"}],"source_content_type":"text/x-python","patch_set":12,"id":"db4d4281_0bfdb2d4","line":251,"in_reply_to":"cb4b746a_c5ff474f","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        for old_k8s_obj in old_k8s_objs:"},{"line_number":250,"context_line":"            old_k8s_obj_kind \u003d old_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":251,"context_line":"            old_k8s_obj_name \u003d old_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":252,"context_line":"            if old_k8s_obj_kind in [\u0027Pod\u0027, \u0027Deployment\u0027]:"},{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":254,"context_line":"                    # If the old and new k8s_obj have the same kind and name"}],"source_content_type":"text/x-python","patch_set":12,"id":"cb4b746a_c5ff474f","line":251,"in_reply_to":"f34e5f43_a4ad4e8b","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":252,"context_line":"            if old_k8s_obj_kind in [\u0027Pod\u0027, \u0027Deployment\u0027]:"},{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":254,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":255,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":256,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":257,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":258,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"7bb02369_cb2ce7f4","line":255,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":252,"context_line":"            if old_k8s_obj_kind in [\u0027Pod\u0027, \u0027Deployment\u0027]:"},{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":254,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":255,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":256,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":257,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":258,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"db35319c_436149b6","line":255,"in_reply_to":"7bb02369_cb2ce7f4","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            if old_k8s_obj_kind in [\u0027Pod\u0027, \u0027Deployment\u0027]:"},{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":254,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":255,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":256,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":257,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":258,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"2ab42c90_a654be08","line":255,"in_reply_to":"db35319c_436149b6","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":254,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":255,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":256,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":257,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":258,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"},{"line_number":259,"context_line":"                        # Call the read API"}],"source_content_type":"text/x-python","patch_set":12,"id":"df1b8ee4_5b031b4a","line":256,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":254,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":255,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":256,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":257,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":258,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"},{"line_number":259,"context_line":"                        # Call the read API"}],"source_content_type":"text/x-python","patch_set":12,"id":"c19ba675_c1ee850f","line":256,"in_reply_to":"67bba28d_4913074c","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":253,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":254,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":255,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":256,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":257,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":258,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"},{"line_number":259,"context_line":"                        # Call the read API"}],"source_content_type":"text/x-python","patch_set":12,"id":"67bba28d_4913074c","line":256,"in_reply_to":"df1b8ee4_5b031b4a","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":269,"context_line":"                        old_k8s_obj[\u0027object\u0027] \u003d old_k8s_resource_info"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"                        if old_k8s_obj_kind \u003d\u003d \u0027Deployment\u0027:"},{"line_number":272,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":273,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":274,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":275,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"}],"source_content_type":"text/x-python","patch_set":12,"id":"14eb8d0a_94c6f776","line":272,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":269,"context_line":"                        old_k8s_obj[\u0027object\u0027] \u003d old_k8s_resource_info"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"                        if old_k8s_obj_kind \u003d\u003d \u0027Deployment\u0027:"},{"line_number":272,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":273,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":274,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":275,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"}],"source_content_type":"text/x-python","patch_set":12,"id":"d82d32ea_172393a6","line":272,"in_reply_to":"14eb8d0a_94c6f776","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                        old_k8s_obj[\u0027object\u0027] \u003d old_k8s_resource_info"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"                        if old_k8s_obj_kind \u003d\u003d \u0027Deployment\u0027:"},{"line_number":272,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":273,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":274,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":275,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"}],"source_content_type":"text/x-python","patch_set":12,"id":"2c9c90c4_66c5fce9","line":272,"in_reply_to":"d82d32ea_172393a6","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":271,"context_line":"                        if old_k8s_obj_kind \u003d\u003d \u0027Deployment\u0027:"},{"line_number":272,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":273,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":274,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":275,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":276,"context_line":"                        elif old_k8s_obj_kind \u003d\u003d \u0027Pod\u0027:"},{"line_number":277,"context_line":"                            old_containers \u003d old_k8s_obj.get("}],"source_content_type":"text/x-python","patch_set":12,"id":"f383bf2e_b9fe1dd9","line":274,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                        if old_k8s_obj_kind \u003d\u003d \u0027Deployment\u0027:"},{"line_number":272,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":273,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":274,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":275,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":276,"context_line":"                        elif old_k8s_obj_kind \u003d\u003d \u0027Pod\u0027:"},{"line_number":277,"context_line":"                            old_containers \u003d old_k8s_obj.get("}],"source_content_type":"text/x-python","patch_set":12,"id":"dce38809_55243ca3","line":274,"in_reply_to":"452368f4_50e37707","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":271,"context_line":"                        if old_k8s_obj_kind \u003d\u003d \u0027Deployment\u0027:"},{"line_number":272,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":273,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":274,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":275,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":276,"context_line":"                        elif old_k8s_obj_kind \u003d\u003d \u0027Pod\u0027:"},{"line_number":277,"context_line":"                            old_containers \u003d old_k8s_obj.get("}],"source_content_type":"text/x-python","patch_set":12,"id":"452368f4_50e37707","line":274,"in_reply_to":"f383bf2e_b9fe1dd9","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":274,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":275,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":276,"context_line":"                        elif old_k8s_obj_kind \u003d\u003d \u0027Pod\u0027:"},{"line_number":277,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":278,"context_line":"                                \u0027object\u0027).spec.containers"},{"line_number":279,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":280,"context_line":"                                \u0027object\u0027).spec.containers"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a7c3130_5e97a26d","line":277,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":275,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":276,"context_line":"                        elif old_k8s_obj_kind \u003d\u003d \u0027Pod\u0027:"},{"line_number":277,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":278,"context_line":"                                \u0027object\u0027).spec.containers"},{"line_number":279,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":280,"context_line":"                                \u0027object\u0027).spec.containers"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf299f98_533904ec","line":277,"in_reply_to":"092b0ee8_df04241f","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":274,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":275,"context_line":"                                \u0027object\u0027).spec.template.spec.containers"},{"line_number":276,"context_line":"                        elif old_k8s_obj_kind \u003d\u003d \u0027Pod\u0027:"},{"line_number":277,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":278,"context_line":"                                \u0027object\u0027).spec.containers"},{"line_number":279,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":280,"context_line":"                                \u0027object\u0027).spec.containers"}],"source_content_type":"text/x-python","patch_set":12,"id":"092b0ee8_df04241f","line":277,"in_reply_to":"9a7c3130_5e97a26d","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":276,"context_line":"                        elif old_k8s_obj_kind \u003d\u003d \u0027Pod\u0027:"},{"line_number":277,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":278,"context_line":"                                \u0027object\u0027).spec.containers"},{"line_number":279,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":280,"context_line":"                                \u0027object\u0027).spec.containers"},{"line_number":281,"context_line":"                        # Replace the old image with the new image"},{"line_number":282,"context_line":"                        self._modify_container_img(old_containers,"}],"source_content_type":"text/x-python","patch_set":12,"id":"06eee653_0ccd308d","line":279,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":276,"context_line":"                        elif old_k8s_obj_kind \u003d\u003d \u0027Pod\u0027:"},{"line_number":277,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":278,"context_line":"                                \u0027object\u0027).spec.containers"},{"line_number":279,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":280,"context_line":"                                \u0027object\u0027).spec.containers"},{"line_number":281,"context_line":"                        # Replace the old image with the new image"},{"line_number":282,"context_line":"                        self._modify_container_img(old_containers,"}],"source_content_type":"text/x-python","patch_set":12,"id":"b0991b7a_34d78041","line":279,"in_reply_to":"06eee653_0ccd308d","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                        elif old_k8s_obj_kind \u003d\u003d \u0027Pod\u0027:"},{"line_number":277,"context_line":"                            old_containers \u003d old_k8s_obj.get("},{"line_number":278,"context_line":"                                \u0027object\u0027).spec.containers"},{"line_number":279,"context_line":"                            new_containers \u003d new_k8s_obj.get("},{"line_number":280,"context_line":"                                \u0027object\u0027).spec.containers"},{"line_number":281,"context_line":"                        # Replace the old image with the new image"},{"line_number":282,"context_line":"                        self._modify_container_img(old_containers,"}],"source_content_type":"text/x-python","patch_set":12,"id":"d549203b_3d238591","line":279,"in_reply_to":"b0991b7a_34d78041","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":288,"context_line":"            elif old_k8s_obj_kind in [\u0027ConfigMap\u0027, \u0027Secret\u0027]:"},{"line_number":289,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":290,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":291,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":292,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":293,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":294,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"e80b5503_daba3681","line":291,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":288,"context_line":"            elif old_k8s_obj_kind in [\u0027ConfigMap\u0027, \u0027Secret\u0027]:"},{"line_number":289,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":290,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":291,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":292,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":293,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":294,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ed184db9_40b31b2c","line":291,"in_reply_to":"e80b5503_daba3681","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            elif old_k8s_obj_kind in [\u0027ConfigMap\u0027, \u0027Secret\u0027]:"},{"line_number":289,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":290,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":291,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":292,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":293,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":294,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"aadf760f_843dd0cf","line":291,"in_reply_to":"ed184db9_40b31b2c","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":289,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":290,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":291,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":292,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":293,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":294,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"},{"line_number":295,"context_line":"                        # Append old_k8s_obj to k8s_pod_objs"}],"source_content_type":"text/x-python","patch_set":12,"id":"fddaaac0_f2772e4d","line":292,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":290,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":291,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":292,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":293,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":294,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"},{"line_number":295,"context_line":"                        # Append old_k8s_obj to k8s_pod_objs"}],"source_content_type":"text/x-python","patch_set":12,"id":"12476155_93fa2aa1","line":292,"in_reply_to":"9b5fd796_8c6a6540","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":289,"context_line":"                for new_k8s_obj in new_k8s_objs:"},{"line_number":290,"context_line":"                    # If the old and new k8s_obj have the same kind and name"},{"line_number":291,"context_line":"                    new_k8s_obj_kind \u003d new_k8s_obj.get(\u0027object\u0027).kind"},{"line_number":292,"context_line":"                    new_k8s_obj_name \u003d new_k8s_obj.get(\u0027object\u0027).metadata.name"},{"line_number":293,"context_line":"                    if old_k8s_obj_kind \u003d\u003d new_k8s_obj_kind and ("},{"line_number":294,"context_line":"                            old_k8s_obj_name \u003d\u003d new_k8s_obj_name):"},{"line_number":295,"context_line":"                        # Append old_k8s_obj to k8s_pod_objs"}],"source_content_type":"text/x-python","patch_set":12,"id":"9b5fd796_8c6a6540","line":292,"in_reply_to":"fddaaac0_f2772e4d","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":2307,"context_line":"        now \u003d timeutils.utcnow()"},{"line_number":2308,"context_line":"        lcm_op_obj.id \u003d vnf_lcm_opoccs.get(\u0027id\u0027)"},{"line_number":2309,"context_line":"        lcm_op_obj.operation_state \u003d fields.LcmOccsOperationState.COMPLETED"},{"line_number":2310,"context_line":"        lcm_op_obj.state_entered_time \u003d result"},{"line_number":2311,"context_line":"        lcm_op_obj.updated_at \u003d now"},{"line_number":2312,"context_line":"        lcm_op_obj.changed_info \u003d changed_info"},{"line_number":2313,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"c551bc5c_6974b8e8","line":2310,"updated":"2022-03-07 12:29:49.000000000","message":"This is an existing part, but related to the return value of ``self.vnflcm_driver.modify_vnf``. Assigning the variable named ``result`` to ``state_entered_time`` doesn\u0027t make sense. According to the definition [1] of ``state_entered_time``, this value can be the current time as ``updated_at`` is. If so, ``self.vnflcm_driver.modify_vnf`` don\u0027t have to return any values.\n\nIf you agree, please assign ``now`` instead of ``result``. If there\u0027s a specific reason for using the return value of ``self.vnflcm_driver.modify_vnf``, please rename it from ``result`` to ``state_entered_time``.\n\n\n[1] https://github.com/openstack/tacker/blob/master/api-ref/source/v1/parameters_vnflcm.yaml#L974","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":2307,"context_line":"        now \u003d timeutils.utcnow()"},{"line_number":2308,"context_line":"        lcm_op_obj.id \u003d vnf_lcm_opoccs.get(\u0027id\u0027)"},{"line_number":2309,"context_line":"        lcm_op_obj.operation_state \u003d fields.LcmOccsOperationState.COMPLETED"},{"line_number":2310,"context_line":"        lcm_op_obj.state_entered_time \u003d result"},{"line_number":2311,"context_line":"        lcm_op_obj.updated_at \u003d now"},{"line_number":2312,"context_line":"        lcm_op_obj.changed_info \u003d changed_info"},{"line_number":2313,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dfe5a8d5_124869b8","line":2310,"in_reply_to":"c551bc5c_6974b8e8","updated":"2022-03-08 09:54:59.000000000","message":"Since this is an implementation of existing code, I did not modify it.\nSince I don\u0027t know if modifying the time here will affect other places, I think it would be better to modify the parameter name.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":2307,"context_line":"        now \u003d timeutils.utcnow()"},{"line_number":2308,"context_line":"        lcm_op_obj.id \u003d vnf_lcm_opoccs.get(\u0027id\u0027)"},{"line_number":2309,"context_line":"        lcm_op_obj.operation_state \u003d fields.LcmOccsOperationState.COMPLETED"},{"line_number":2310,"context_line":"        lcm_op_obj.state_entered_time \u003d result"},{"line_number":2311,"context_line":"        lcm_op_obj.updated_at \u003d now"},{"line_number":2312,"context_line":"        lcm_op_obj.changed_info \u003d changed_info"},{"line_number":2313,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"8dffb7b2_89dced6d","line":2310,"in_reply_to":"dfe5a8d5_124869b8","updated":"2022-03-09 05:15:29.000000000","message":"I agree.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"}],"tacker/tests/etc/samples/etsi/nfv/test_cnf_container_update_after/Definitions/sample_df_simple.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        vdu_profile:"},{"line_number":61,"context_line":"          min_number_of_instances: 1"},{"line_number":62,"context_line":"          max_number_of_instances: 3"},{"line_number":63,"context_line":"          "},{"line_number":64,"context_line":"    VDU2:"},{"line_number":65,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":66,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"94d0c87d_0f522270","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":10},"updated":"2022-03-04 14:13:16.000000000","message":"unnecessary whitespaces","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d3e84d616025e648648d41a51162989b76552394","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        vdu_profile:"},{"line_number":61,"context_line":"          min_number_of_instances: 1"},{"line_number":62,"context_line":"          max_number_of_instances: 3"},{"line_number":63,"context_line":"          "},{"line_number":64,"context_line":"    VDU2:"},{"line_number":65,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":66,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7d0f25e0_3986a067","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":10},"in_reply_to":"8515bf19_8ca08dcb","updated":"2022-03-09 16:16:35.000000000","message":"I\u0027ve confirmed.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        vdu_profile:"},{"line_number":61,"context_line":"          min_number_of_instances: 1"},{"line_number":62,"context_line":"          max_number_of_instances: 3"},{"line_number":63,"context_line":"          "},{"line_number":64,"context_line":"    VDU2:"},{"line_number":65,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":66,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"8515bf19_8ca08dcb","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":10},"in_reply_to":"94d0c87d_0f522270","updated":"2022-03-08 01:19:13.000000000","message":"I removed the unnecessary whitespace.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        vdu_profile:"},{"line_number":79,"context_line":"          min_number_of_instances: 1"},{"line_number":80,"context_line":"          max_number_of_instances: 1"},{"line_number":81,"context_line":"          "},{"line_number":82,"context_line":"    VDU4:"},{"line_number":83,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":84,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c2038f47_674e0fcf","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":10},"updated":"2022-03-04 14:13:16.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        vdu_profile:"},{"line_number":79,"context_line":"          min_number_of_instances: 1"},{"line_number":80,"context_line":"          max_number_of_instances: 1"},{"line_number":81,"context_line":"          "},{"line_number":82,"context_line":"    VDU4:"},{"line_number":83,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":84,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fccd53d7_11a7351e","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":10},"in_reply_to":"c2038f47_674e0fcf","updated":"2022-03-08 01:19:13.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d3e84d616025e648648d41a51162989b76552394","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        vdu_profile:"},{"line_number":79,"context_line":"          min_number_of_instances: 1"},{"line_number":80,"context_line":"          max_number_of_instances: 1"},{"line_number":81,"context_line":"          "},{"line_number":82,"context_line":"    VDU4:"},{"line_number":83,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":84,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6cdd970c_0b51cf0e","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":10},"in_reply_to":"fccd53d7_11a7351e","updated":"2022-03-09 16:16:35.000000000","message":"I\u0027ve confirmed.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":104,"context_line":"              max_scale_level: 2"},{"line_number":105,"context_line":"              step_deltas:"},{"line_number":106,"context_line":"                - delta_1"},{"line_number":107,"context_line":"                "},{"line_number":108,"context_line":"    - instantiation_levels:"},{"line_number":109,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"},{"line_number":110,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"15784ce8_2bab4acf","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":16},"updated":"2022-03-04 14:13:16.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":104,"context_line":"              max_scale_level: 2"},{"line_number":105,"context_line":"              step_deltas:"},{"line_number":106,"context_line":"                - delta_1"},{"line_number":107,"context_line":"                "},{"line_number":108,"context_line":"    - instantiation_levels:"},{"line_number":109,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"},{"line_number":110,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"eac91c5e_e73cfea3","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":16},"in_reply_to":"15784ce8_2bab4acf","updated":"2022-03-08 01:19:13.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d3e84d616025e648648d41a51162989b76552394","unresolved":false,"context_lines":[{"line_number":104,"context_line":"              max_scale_level: 2"},{"line_number":105,"context_line":"              step_deltas:"},{"line_number":106,"context_line":"                - delta_1"},{"line_number":107,"context_line":"                "},{"line_number":108,"context_line":"    - instantiation_levels:"},{"line_number":109,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"},{"line_number":110,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"8f5a32ab_12f86f4e","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":16},"in_reply_to":"eac91c5e_e73cfea3","updated":"2022-03-09 16:16:35.000000000","message":"I\u0027ve confirmed.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                vdu2_aspect:"},{"line_number":125,"context_line":"                  scale_level: 2"},{"line_number":126,"context_line":"          default_level: instantiation_level_1"},{"line_number":127,"context_line":"          "},{"line_number":128,"context_line":"    - vdu1_initial_delta:"},{"line_number":129,"context_line":"        type: tosca.policies.nfv.VduInitialDelta"},{"line_number":130,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bd445ed3_c2870b1d","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":10},"updated":"2022-03-04 14:13:16.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d3e84d616025e648648d41a51162989b76552394","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                vdu2_aspect:"},{"line_number":125,"context_line":"                  scale_level: 2"},{"line_number":126,"context_line":"          default_level: instantiation_level_1"},{"line_number":127,"context_line":"          "},{"line_number":128,"context_line":"    - vdu1_initial_delta:"},{"line_number":129,"context_line":"        type: tosca.policies.nfv.VduInitialDelta"},{"line_number":130,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"4987345e_645b50b7","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":10},"in_reply_to":"6db96418_de232fd1","updated":"2022-03-09 16:16:35.000000000","message":"I\u0027ve confirmed.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                vdu2_aspect:"},{"line_number":125,"context_line":"                  scale_level: 2"},{"line_number":126,"context_line":"          default_level: instantiation_level_1"},{"line_number":127,"context_line":"          "},{"line_number":128,"context_line":"    - vdu1_initial_delta:"},{"line_number":129,"context_line":"        type: tosca.policies.nfv.VduInitialDelta"},{"line_number":130,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6db96418_de232fd1","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":10},"in_reply_to":"bd445ed3_c2870b1d","updated":"2022-03-08 01:19:13.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"}],"tacker/tests/etc/samples/etsi/nfv/test_cnf_container_update_before/Definitions/sample_df_simple.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        vdu_profile:"},{"line_number":61,"context_line":"          min_number_of_instances: 1"},{"line_number":62,"context_line":"          max_number_of_instances: 3"},{"line_number":63,"context_line":"          "},{"line_number":64,"context_line":"    VDU2:"},{"line_number":65,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":66,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f7cd7c6d_0466b132","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":10},"updated":"2022-03-04 14:13:16.000000000","message":"unnecessary whitespaces","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d3e84d616025e648648d41a51162989b76552394","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        vdu_profile:"},{"line_number":61,"context_line":"          min_number_of_instances: 1"},{"line_number":62,"context_line":"          max_number_of_instances: 3"},{"line_number":63,"context_line":"          "},{"line_number":64,"context_line":"    VDU2:"},{"line_number":65,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":66,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ee30ec58_41aadfa5","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":10},"in_reply_to":"cc324ba0_bdf8ec83","updated":"2022-03-09 16:16:35.000000000","message":"I\u0027ve confirmed.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        vdu_profile:"},{"line_number":61,"context_line":"          min_number_of_instances: 1"},{"line_number":62,"context_line":"          max_number_of_instances: 3"},{"line_number":63,"context_line":"          "},{"line_number":64,"context_line":"    VDU2:"},{"line_number":65,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":66,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cc324ba0_bdf8ec83","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":10},"in_reply_to":"f7cd7c6d_0466b132","updated":"2022-03-08 01:19:13.000000000","message":"I removed the unnecessary whitespace.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        vdu_profile:"},{"line_number":79,"context_line":"          min_number_of_instances: 1"},{"line_number":80,"context_line":"          max_number_of_instances: 1"},{"line_number":81,"context_line":"          "},{"line_number":82,"context_line":"    VDU4:"},{"line_number":83,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":84,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"c7dad03d_db636e34","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":10},"updated":"2022-03-04 14:13:16.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d3e84d616025e648648d41a51162989b76552394","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        vdu_profile:"},{"line_number":79,"context_line":"          min_number_of_instances: 1"},{"line_number":80,"context_line":"          max_number_of_instances: 1"},{"line_number":81,"context_line":"          "},{"line_number":82,"context_line":"    VDU4:"},{"line_number":83,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":84,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f2eff215_893da7c9","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":10},"in_reply_to":"62c89bc4_f40ade07","updated":"2022-03-09 16:16:35.000000000","message":"I\u0027ve confirmed.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        vdu_profile:"},{"line_number":79,"context_line":"          min_number_of_instances: 1"},{"line_number":80,"context_line":"          max_number_of_instances: 1"},{"line_number":81,"context_line":"          "},{"line_number":82,"context_line":"    VDU4:"},{"line_number":83,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"},{"line_number":84,"context_line":"      properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"62c89bc4_f40ade07","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":10},"in_reply_to":"c7dad03d_db636e34","updated":"2022-03-08 01:19:13.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":104,"context_line":"              max_scale_level: 2"},{"line_number":105,"context_line":"              step_deltas:"},{"line_number":106,"context_line":"                - delta_1"},{"line_number":107,"context_line":"                "},{"line_number":108,"context_line":"    - instantiation_levels:"},{"line_number":109,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"},{"line_number":110,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"893ea0f5_7211e5bc","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":16},"updated":"2022-03-04 14:13:16.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":104,"context_line":"              max_scale_level: 2"},{"line_number":105,"context_line":"              step_deltas:"},{"line_number":106,"context_line":"                - delta_1"},{"line_number":107,"context_line":"                "},{"line_number":108,"context_line":"    - instantiation_levels:"},{"line_number":109,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"},{"line_number":110,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"e6b689df_09506c7a","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":16},"in_reply_to":"893ea0f5_7211e5bc","updated":"2022-03-08 01:19:13.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d3e84d616025e648648d41a51162989b76552394","unresolved":false,"context_lines":[{"line_number":104,"context_line":"              max_scale_level: 2"},{"line_number":105,"context_line":"              step_deltas:"},{"line_number":106,"context_line":"                - delta_1"},{"line_number":107,"context_line":"                "},{"line_number":108,"context_line":"    - instantiation_levels:"},{"line_number":109,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"},{"line_number":110,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"50a3f6fc_11f82178","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":16},"in_reply_to":"e6b689df_09506c7a","updated":"2022-03-09 16:16:35.000000000","message":"I\u0027ve confirmed.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                vdu2_aspect:"},{"line_number":125,"context_line":"                  scale_level: 2"},{"line_number":126,"context_line":"          default_level: instantiation_level_1"},{"line_number":127,"context_line":"          "},{"line_number":128,"context_line":"    - vdu1_initial_delta:"},{"line_number":129,"context_line":"        type: tosca.policies.nfv.VduInitialDelta"},{"line_number":130,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fad5c790_1e88e020","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":10},"updated":"2022-03-04 14:13:16.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d3e84d616025e648648d41a51162989b76552394","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                vdu2_aspect:"},{"line_number":125,"context_line":"                  scale_level: 2"},{"line_number":126,"context_line":"          default_level: instantiation_level_1"},{"line_number":127,"context_line":"          "},{"line_number":128,"context_line":"    - vdu1_initial_delta:"},{"line_number":129,"context_line":"        type: tosca.policies.nfv.VduInitialDelta"},{"line_number":130,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"47d88576_beab1fd3","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":10},"in_reply_to":"5abd020d_f7e7ef66","updated":"2022-03-09 16:16:35.000000000","message":"I\u0027ve confirmed.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                vdu2_aspect:"},{"line_number":125,"context_line":"                  scale_level: 2"},{"line_number":126,"context_line":"          default_level: instantiation_level_1"},{"line_number":127,"context_line":"          "},{"line_number":128,"context_line":"    - vdu1_initial_delta:"},{"line_number":129,"context_line":"        type: tosca.policies.nfv.VduInitialDelta"},{"line_number":130,"context_line":"        properties:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5abd020d_f7e7ef66","line":127,"range":{"start_line":127,"start_character":0,"end_line":127,"end_character":10},"in_reply_to":"fad5c790_1e88e020","updated":"2022-03-08 01:19:13.000000000","message":"ditto.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"}],"tacker/tests/functional/sol_kubernetes/vnflcm/base.py":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"9f8b245c25dd2732deebe4a57b0952fa090c26f6","unresolved":true,"context_lines":[{"line_number":105,"context_line":"                         f\"../../../etc/samples/etsi/nfv/\""},{"line_number":106,"context_line":"                         f\"{csar_package_name}/Scripts/\"))"},{"line_number":107,"context_line":"        os.mkdir(mgmt_package_abs_path)"},{"line_number":108,"context_line":"        shutil.copy(mgmt_abs_path, mgmt_package_abs_path)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # upload vnf package"},{"line_number":111,"context_line":"        csar_package_path \u003d (\"../../../etc/samples/etsi/nfv/\""}],"source_content_type":"text/x-python","patch_set":9,"id":"db3213a0_eb46ba74","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":57},"updated":"2022-03-03 08:24:20.000000000","message":"The following files copied here seem to remain after the functional test is run.\n- tacker/tests/etc/samples/etsi/nfv/test_cnf_container_update_after/Scripts/container_update_mgmt.py\n- tacker/tests/etc/samples/etsi/nfv/test_cnf_container_update_before/Scripts/container_update_mgmt.py\n\nWouldn\u0027t it be better to delete it?","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"552257545b254c31f6987700c57697a2a6aa8311","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                         f\"../../../etc/samples/etsi/nfv/\""},{"line_number":106,"context_line":"                         f\"{csar_package_name}/Scripts/\"))"},{"line_number":107,"context_line":"        os.mkdir(mgmt_package_abs_path)"},{"line_number":108,"context_line":"        shutil.copy(mgmt_abs_path, mgmt_package_abs_path)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # upload vnf package"},{"line_number":111,"context_line":"        csar_package_path \u003d (\"../../../etc/samples/etsi/nfv/\""}],"source_content_type":"text/x-python","patch_set":9,"id":"951e5290_5f261378","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":57},"in_reply_to":"00207deb_96832740","updated":"2022-03-09 11:17:04.000000000","message":"I have confirmed it.","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"79bc412480a9dff1c8c604b1305d2fa690753578","unresolved":true,"context_lines":[{"line_number":105,"context_line":"                         f\"../../../etc/samples/etsi/nfv/\""},{"line_number":106,"context_line":"                         f\"{csar_package_name}/Scripts/\"))"},{"line_number":107,"context_line":"        os.mkdir(mgmt_package_abs_path)"},{"line_number":108,"context_line":"        shutil.copy(mgmt_abs_path, mgmt_package_abs_path)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # upload vnf package"},{"line_number":111,"context_line":"        csar_package_path \u003d (\"../../../etc/samples/etsi/nfv/\""}],"source_content_type":"text/x-python","patch_set":9,"id":"00207deb_96832740","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":57},"in_reply_to":"db3213a0_eb46ba74","updated":"2022-03-04 09:42:59.000000000","message":"I append the delete operation at the end of the function.","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":32,"context_line":"from tacker.vnfm.infra_drivers.kubernetes.kubernetes_driver import CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"VNF_PACKAGE_UPLOAD_TIMEOUT \u003d 300"},{"line_number":35,"context_line":"VNF_INSTANTIATE_TIMEOUT \u003d 600"},{"line_number":36,"context_line":"VNF_TERMINATE_TIMEOUT \u003d 600"},{"line_number":37,"context_line":"VNF_HEAL_SOL002_TIMEOUT \u003d 600"},{"line_number":38,"context_line":"VNF_HEAL_SOL003_TIMEOUT \u003d 1200"},{"line_number":39,"context_line":"VNF_SCALE_TIMEOUT \u003d 600"},{"line_number":40,"context_line":"VNF_MODIFY_TIMEOUT \u003d 600"},{"line_number":41,"context_line":"RETRY_WAIT_TIME \u003d 5"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"WAIT_TIMEOUT_ERR_MSG \u003d (\"Failed to %(action)s, process could not be completed\""}],"source_content_type":"text/x-python","patch_set":11,"id":"b8f76d93_de7b4576","line":40,"range":{"start_line":35,"start_character":0,"end_line":40,"end_character":24},"updated":"2022-03-04 14:13:16.000000000","message":"The following patch modifies timeout to according to the values of `stack_retries` and `stack_retry_wait`.\nhttps://review.opendev.org/c/openstack/tacker/+/825705/12/tacker/tests/functional/sol_kubernetes/vnflcm/base.py#52\n\nCould you change it in the same way?","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":32,"context_line":"from tacker.vnfm.infra_drivers.kubernetes.kubernetes_driver import CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"VNF_PACKAGE_UPLOAD_TIMEOUT \u003d 300"},{"line_number":35,"context_line":"VNF_INSTANTIATE_TIMEOUT \u003d 600"},{"line_number":36,"context_line":"VNF_TERMINATE_TIMEOUT \u003d 600"},{"line_number":37,"context_line":"VNF_HEAL_SOL002_TIMEOUT \u003d 600"},{"line_number":38,"context_line":"VNF_HEAL_SOL003_TIMEOUT \u003d 1200"},{"line_number":39,"context_line":"VNF_SCALE_TIMEOUT \u003d 600"},{"line_number":40,"context_line":"VNF_MODIFY_TIMEOUT \u003d 600"},{"line_number":41,"context_line":"RETRY_WAIT_TIME \u003d 5"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"WAIT_TIMEOUT_ERR_MSG \u003d (\"Failed to %(action)s, process could not be completed\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bba1b2b0_e5245fc3","line":40,"range":{"start_line":35,"start_character":0,"end_line":40,"end_character":24},"in_reply_to":"b8f76d93_de7b4576","updated":"2022-03-08 01:19:13.000000000","message":"I modified it according to the above patch.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"}],"tacker/tests/unit/vnfm/mgmt_drivers/test_container_update_mgmt.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b24a5237612ab6baf1c5a1370c0f58aeb1cd53fb","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from kubernetes import client"},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":"from unittest import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from samples.mgmt_driver.kubernetes.container_update import ("}],"source_content_type":"text/x-python","patch_set":18,"id":"7f9deea7_899f3a60","line":17,"updated":"2022-03-10 08:07:43.000000000","message":"Is the order correct?","commit_id":"885f06be0e6044a1431063c74c8526d66636a8d9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"61cfe5f0cd06c158a43395a6b723e550aa13d988","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from kubernetes import client"},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":"from unittest import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from samples.mgmt_driver.kubernetes.container_update import ("}],"source_content_type":"text/x-python","patch_set":18,"id":"382b4e37_baa2d6d3","line":17,"in_reply_to":"7f9deea7_899f3a60","updated":"2022-03-10 09:17:05.000000000","message":"I reordered them again.","commit_id":"885f06be0e6044a1431063c74c8526d66636a8d9"}],"tacker/vnflcm/utils.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":35,"context_line":"CONF \u003d cfg.CONF"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def get_vim(context, vim_connection_info):"},{"line_number":39,"context_line":"    return _get_vim(context, vim_connection_info)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"e3510ec5_21094406","line":38,"updated":"2022-03-07 12:29:49.000000000","message":"Please add TODO comment:\n\n```\nTODO: change _get_vim to a public method and then delete this method.\n```","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"CONF \u003d cfg.CONF"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def get_vim(context, vim_connection_info):"},{"line_number":39,"context_line":"    return _get_vim(context, vim_connection_info)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"11f716ac_db5d6535","line":38,"in_reply_to":"2aba767d_e7debe01","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":35,"context_line":"CONF \u003d cfg.CONF"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def get_vim(context, vim_connection_info):"},{"line_number":39,"context_line":"    return _get_vim(context, vim_connection_info)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"2aba767d_e7debe01","line":38,"in_reply_to":"e3510ec5_21094406","updated":"2022-03-08 09:54:59.000000000","message":"The TODO comment has been added.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":1167,"context_line":"    return desired_capacity"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"def get_vnf_package_path(context, vnfd_id):"},{"line_number":1171,"context_line":"    return _get_vnf_package_path(context, vnfd_id)"},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"33e1ebf0_7c67b42b","line":1170,"updated":"2022-03-07 12:29:49.000000000","message":"Please add TODO comment:\n```\nTODO: change _get_vnf_package_path to a public method and then delete this method.\n```","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":1167,"context_line":"    return desired_capacity"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"def get_vnf_package_path(context, vnfd_id):"},{"line_number":1171,"context_line":"    return _get_vnf_package_path(context, vnfd_id)"},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"73267302_62df933a","line":1170,"in_reply_to":"33e1ebf0_7c67b42b","updated":"2022-03-08 09:54:59.000000000","message":"The TODO comment has been added.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":1167,"context_line":"    return desired_capacity"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"def get_vnf_package_path(context, vnfd_id):"},{"line_number":1171,"context_line":"    return _get_vnf_package_path(context, vnfd_id)"},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da989f9e_3fb45441","line":1170,"in_reply_to":"73267302_62df933a","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"9f8b245c25dd2732deebe4a57b0952fa090c26f6","unresolved":true,"context_lines":[{"line_number":516,"context_line":"            self._load_vnf_interface("},{"line_number":517,"context_line":"                context, \u0027modify_information_start\u0027, vnf_instance, vnfd_dict),"},{"line_number":518,"context_line":"            \u0027modify_information_start\u0027, context\u003dcontext,"},{"line_number":519,"context_line":"            modify_vnf_request\u003dNone,"},{"line_number":520,"context_line":"            vnf_instance\u003dvnf_instance)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        # Get the old vnf package path according to vnfd_id"},{"line_number":523,"context_line":"        old_vnf_package_path \u003d vnflcm_utils.get_vnf_package_path("}],"source_content_type":"text/x-python","patch_set":9,"id":"f22de013_cd1df788","line":520,"range":{"start_line":519,"start_character":12,"end_line":520,"end_character":38},"updated":"2022-03-03 08:24:20.000000000","message":"I think it is better to reduce the number of argument lines as much as possible.\n\n```\ne.g.\n            modify_vnf_request\u003dNone, vnf_instance\u003dvnf_instance)\n```","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"552257545b254c31f6987700c57697a2a6aa8311","unresolved":false,"context_lines":[{"line_number":516,"context_line":"            self._load_vnf_interface("},{"line_number":517,"context_line":"                context, \u0027modify_information_start\u0027, vnf_instance, vnfd_dict),"},{"line_number":518,"context_line":"            \u0027modify_information_start\u0027, context\u003dcontext,"},{"line_number":519,"context_line":"            modify_vnf_request\u003dNone,"},{"line_number":520,"context_line":"            vnf_instance\u003dvnf_instance)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        # Get the old vnf package path according to vnfd_id"},{"line_number":523,"context_line":"        old_vnf_package_path \u003d vnflcm_utils.get_vnf_package_path("}],"source_content_type":"text/x-python","patch_set":9,"id":"e5ff4ea9_ba5a8eb4","line":520,"range":{"start_line":519,"start_character":12,"end_line":520,"end_character":38},"in_reply_to":"e361243a_38bf59ef","updated":"2022-03-09 11:17:04.000000000","message":"I have confirmed it.","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"79bc412480a9dff1c8c604b1305d2fa690753578","unresolved":true,"context_lines":[{"line_number":516,"context_line":"            self._load_vnf_interface("},{"line_number":517,"context_line":"                context, \u0027modify_information_start\u0027, vnf_instance, vnfd_dict),"},{"line_number":518,"context_line":"            \u0027modify_information_start\u0027, context\u003dcontext,"},{"line_number":519,"context_line":"            modify_vnf_request\u003dNone,"},{"line_number":520,"context_line":"            vnf_instance\u003dvnf_instance)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        # Get the old vnf package path according to vnfd_id"},{"line_number":523,"context_line":"        old_vnf_package_path \u003d vnflcm_utils.get_vnf_package_path("}],"source_content_type":"text/x-python","patch_set":9,"id":"e361243a_38bf59ef","line":520,"range":{"start_line":519,"start_character":12,"end_line":520,"end_character":38},"in_reply_to":"f22de013_cd1df788","updated":"2022-03-04 09:42:59.000000000","message":"I fixed it in patchset 10.","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"9f8b245c25dd2732deebe4a57b0952fa090c26f6","unresolved":true,"context_lines":[{"line_number":526,"context_line":"        # Update vnf_instance"},{"line_number":527,"context_line":"        try:"},{"line_number":528,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":529,"context_line":"            result \u003d ins_obj.update("},{"line_number":530,"context_line":"                context,"},{"line_number":531,"context_line":"                vnf_lcm_opoccs,"},{"line_number":532,"context_line":"                body_data,"},{"line_number":533,"context_line":"                vnfd_pkg_data,"},{"line_number":534,"context_line":"                vnfd_id)"},{"line_number":535,"context_line":"        except Exception as msg:"},{"line_number":536,"context_line":"            raise Exception(str(msg))"},{"line_number":537,"context_line":"        vnf_instance \u003d objects.VnfInstance.get_by_id(context, vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"530b746a_1721fff9","line":534,"range":{"start_line":529,"start_character":12,"end_line":534,"end_character":24},"updated":"2022-03-03 08:24:20.000000000","message":"I think it is better to reduce the number of argument lines as much as possible.\n\n```\ne.g.\n            result \u003d ins_obj.update(context, vnf_lcm_opoccs, body_data,\n                                    vnfd_pkg_data, vnfd_id)\n```","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"79bc412480a9dff1c8c604b1305d2fa690753578","unresolved":true,"context_lines":[{"line_number":526,"context_line":"        # Update vnf_instance"},{"line_number":527,"context_line":"        try:"},{"line_number":528,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":529,"context_line":"            result \u003d ins_obj.update("},{"line_number":530,"context_line":"                context,"},{"line_number":531,"context_line":"                vnf_lcm_opoccs,"},{"line_number":532,"context_line":"                body_data,"},{"line_number":533,"context_line":"                vnfd_pkg_data,"},{"line_number":534,"context_line":"                vnfd_id)"},{"line_number":535,"context_line":"        except Exception as msg:"},{"line_number":536,"context_line":"            raise Exception(str(msg))"},{"line_number":537,"context_line":"        vnf_instance \u003d objects.VnfInstance.get_by_id(context, vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"e8852c29_ee6c3e52","line":534,"range":{"start_line":529,"start_character":12,"end_line":534,"end_character":24},"in_reply_to":"530b746a_1721fff9","updated":"2022-03-04 09:42:59.000000000","message":"I fixed it in patchset 10.","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"552257545b254c31f6987700c57697a2a6aa8311","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        # Update vnf_instance"},{"line_number":527,"context_line":"        try:"},{"line_number":528,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":529,"context_line":"            result \u003d ins_obj.update("},{"line_number":530,"context_line":"                context,"},{"line_number":531,"context_line":"                vnf_lcm_opoccs,"},{"line_number":532,"context_line":"                body_data,"},{"line_number":533,"context_line":"                vnfd_pkg_data,"},{"line_number":534,"context_line":"                vnfd_id)"},{"line_number":535,"context_line":"        except Exception as msg:"},{"line_number":536,"context_line":"            raise Exception(str(msg))"},{"line_number":537,"context_line":"        vnf_instance \u003d objects.VnfInstance.get_by_id(context, vnf_instance_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"cbc8d2ac_6818cab7","line":534,"range":{"start_line":529,"start_character":12,"end_line":534,"end_character":24},"in_reply_to":"e8852c29_ee6c3e52","updated":"2022-03-09 11:17:04.000000000","message":"I have confirmed it.","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Update vnf_instance"},{"line_number":526,"context_line":"        try:"},{"line_number":527,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":528,"context_line":"            result \u003d ins_obj.update(context, vnf_lcm_opoccs, body_data,"},{"line_number":529,"context_line":"                                    vnfd_pkg_data, vnfd_id)"},{"line_number":530,"context_line":"        except Exception as msg:"}],"source_content_type":"text/x-python","patch_set":12,"id":"cd8aadd4_2967e0d8","line":527,"updated":"2022-03-07 12:29:49.000000000","message":"If you remove ``vnf_instance``, does this line work?\n\n```\n_vnf_instance \u003d objects.VnfInstance(context\u003dcontext)\n```\n\nI\u0027d like to confirm that you make a VnfInstance instance just to use its update method, is this guess correct?","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Update vnf_instance"},{"line_number":526,"context_line":"        try:"},{"line_number":527,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":528,"context_line":"            result \u003d ins_obj.update(context, vnf_lcm_opoccs, body_data,"},{"line_number":529,"context_line":"                                    vnfd_pkg_data, vnfd_id)"},{"line_number":530,"context_line":"        except Exception as msg:"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ece1882_f0d8da45","line":527,"in_reply_to":"461fbdca_f1a5eb56","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Update vnf_instance"},{"line_number":526,"context_line":"        try:"},{"line_number":527,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":528,"context_line":"            result \u003d ins_obj.update(context, vnf_lcm_opoccs, body_data,"},{"line_number":529,"context_line":"                                    vnfd_pkg_data, vnfd_id)"},{"line_number":530,"context_line":"        except Exception as msg:"}],"source_content_type":"text/x-python","patch_set":12,"id":"461fbdca_f1a5eb56","line":527,"in_reply_to":"cd8aadd4_2967e0d8","updated":"2022-03-08 09:54:59.000000000","message":"I removed ``vnf_instance``.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":525,"context_line":"        # Update vnf_instance"},{"line_number":526,"context_line":"        try:"},{"line_number":527,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":528,"context_line":"            result \u003d ins_obj.update(context, vnf_lcm_opoccs, body_data,"},{"line_number":529,"context_line":"                                    vnfd_pkg_data, vnfd_id)"},{"line_number":530,"context_line":"        except Exception as msg:"},{"line_number":531,"context_line":"            raise Exception(str(msg))"}],"source_content_type":"text/x-python","patch_set":12,"id":"893f172a_931b6997","line":528,"updated":"2022-03-07 12:29:49.000000000","message":"This is datetime. The name ``result`` is misleading. Please change to appropriate name like updated_time/updated_at? BTW, I wonder if this is really an appropriate value to update op_occ at conductor_server [1] or not. Please also see the comment in [1].\n[1] https://review.opendev.org/c/openstack/tacker/+/830963/12/tacker/conductor/conductor_server.py#2310","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":true,"context_lines":[{"line_number":525,"context_line":"        # Update vnf_instance"},{"line_number":526,"context_line":"        try:"},{"line_number":527,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":528,"context_line":"            result \u003d ins_obj.update(context, vnf_lcm_opoccs, body_data,"},{"line_number":529,"context_line":"                                    vnfd_pkg_data, vnfd_id)"},{"line_number":530,"context_line":"        except Exception as msg:"},{"line_number":531,"context_line":"            raise Exception(str(msg))"}],"source_content_type":"text/x-python","patch_set":12,"id":"61234836_b2c9dce7","line":528,"in_reply_to":"522ecf10_dfea2da9","updated":"2022-03-09 05:15:29.000000000","message":"Could you please quickly check it again? Looks like there\u0027s no changes","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a896b51b10ea4bcb2988085667ee7266ad9d79dd","unresolved":true,"context_lines":[{"line_number":525,"context_line":"        # Update vnf_instance"},{"line_number":526,"context_line":"        try:"},{"line_number":527,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":528,"context_line":"            result \u003d ins_obj.update(context, vnf_lcm_opoccs, body_data,"},{"line_number":529,"context_line":"                                    vnfd_pkg_data, vnfd_id)"},{"line_number":530,"context_line":"        except Exception as msg:"},{"line_number":531,"context_line":"            raise Exception(str(msg))"}],"source_content_type":"text/x-python","patch_set":12,"id":"6b5c2e5b_4aaccbf3","line":528,"in_reply_to":"61234836_b2c9dce7","updated":"2022-03-09 05:47:04.000000000","message":"Sorry, this part was missed, I fixed it in patchset 18.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"1c46c84533078e89de4b619f12a77ebe380430c1","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        # Update vnf_instance"},{"line_number":526,"context_line":"        try:"},{"line_number":527,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":528,"context_line":"            result \u003d ins_obj.update(context, vnf_lcm_opoccs, body_data,"},{"line_number":529,"context_line":"                                    vnfd_pkg_data, vnfd_id)"},{"line_number":530,"context_line":"        except Exception as msg:"},{"line_number":531,"context_line":"            raise Exception(str(msg))"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf8fdfef_5fa30aa8","line":528,"in_reply_to":"6b5c2e5b_4aaccbf3","updated":"2022-03-09 11:12:59.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":525,"context_line":"        # Update vnf_instance"},{"line_number":526,"context_line":"        try:"},{"line_number":527,"context_line":"            ins_obj \u003d objects.vnf_instance.VnfInstance(context\u003dcontext)"},{"line_number":528,"context_line":"            result \u003d ins_obj.update(context, vnf_lcm_opoccs, body_data,"},{"line_number":529,"context_line":"                                    vnfd_pkg_data, vnfd_id)"},{"line_number":530,"context_line":"        except Exception as msg:"},{"line_number":531,"context_line":"            raise Exception(str(msg))"}],"source_content_type":"text/x-python","patch_set":12,"id":"522ecf10_dfea2da9","line":528,"in_reply_to":"893f172a_931b6997","updated":"2022-03-08 09:54:59.000000000","message":"I changed its name to ``state_entered_time``.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":545,"context_line":"            operation_params \u003d vnf_lcm_opoccs.get(\u0027operationParams\u0027)"},{"line_number":546,"context_line":"            if operation_params:"},{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"}],"source_content_type":"text/x-python","patch_set":12,"id":"e298102c_a3a6b01b","line":548,"updated":"2022-03-07 12:29:49.000000000","message":"The ``eval`` incurs the code injection vulnerability, please use ``json.loads`` instead if the operation params is json.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":545,"context_line":"            operation_params \u003d vnf_lcm_opoccs.get(\u0027operationParams\u0027)"},{"line_number":546,"context_line":"            if operation_params:"},{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"}],"source_content_type":"text/x-python","patch_set":12,"id":"e1faa57c_b8cafc9f","line":548,"in_reply_to":"86f6f18b_6f3cd0f8","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a896b51b10ea4bcb2988085667ee7266ad9d79dd","unresolved":true,"context_lines":[{"line_number":545,"context_line":"            operation_params \u003d vnf_lcm_opoccs.get(\u0027operationParams\u0027)"},{"line_number":546,"context_line":"            if operation_params:"},{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"}],"source_content_type":"text/x-python","patch_set":12,"id":"96e496d9_52baaf00","line":548,"in_reply_to":"86f6f18b_6f3cd0f8","updated":"2022-03-09 05:47:04.000000000","message":"Since the str extracted from the dict is in this form \"{\u0027a\u0027: \u0027b\u0027}\", it will fail when using ``json.loads`` for conversion. \n``json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)``\nSo I modified it to ``ast.literal_eval`` instead.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"1c46c84533078e89de4b619f12a77ebe380430c1","unresolved":false,"context_lines":[{"line_number":545,"context_line":"            operation_params \u003d vnf_lcm_opoccs.get(\u0027operationParams\u0027)"},{"line_number":546,"context_line":"            if operation_params:"},{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"}],"source_content_type":"text/x-python","patch_set":12,"id":"94dde586_c0b32b08","line":548,"in_reply_to":"96e496d9_52baaf00","updated":"2022-03-09 11:12:59.000000000","message":"I got it.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":545,"context_line":"            operation_params \u003d vnf_lcm_opoccs.get(\u0027operationParams\u0027)"},{"line_number":546,"context_line":"            if operation_params:"},{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"}],"source_content_type":"text/x-python","patch_set":12,"id":"86f6f18b_6f3cd0f8","line":548,"in_reply_to":"e298102c_a3a6b01b","updated":"2022-03-08 09:54:59.000000000","message":"I will fix it in patchset 13.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"},{"line_number":552,"context_line":"            metadata \u003d None"},{"line_number":553,"context_line":"            if operation_params:"}],"source_content_type":"text/x-python","patch_set":12,"id":"16fbfb91_ae91d2c0","line":550,"updated":"2022-03-07 12:29:49.000000000","message":"I think it\u0027s a matter of format. If it\u0027s correct, please change error message to this.\n\n```\nf\u0027Invalid format operationParams\u0027\n```","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"},{"line_number":552,"context_line":"            metadata \u003d None"},{"line_number":553,"context_line":"            if operation_params:"}],"source_content_type":"text/x-python","patch_set":12,"id":"95c74490_7b8740bd","line":550,"in_reply_to":"16fbfb91_ae91d2c0","updated":"2022-03-08 09:54:59.000000000","message":"I will fix it in patchset 13.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"},{"line_number":552,"context_line":"            metadata \u003d None"},{"line_number":553,"context_line":"            if operation_params:"}],"source_content_type":"text/x-python","patch_set":12,"id":"dc7d21c5_cfcee722","line":550,"in_reply_to":"95c74490_7b8740bd","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":538,"context_line":"            vim_info, context)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        kwargs \u003d {}"},{"line_number":541,"context_line":"        if vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":542,"context_line":"            # If the file path of ConfigMap/Secret is changed"},{"line_number":543,"context_line":"            configmap_secret_paths \u003d []"},{"line_number":544,"context_line":"            # Get the metadata from vnf_lcm_opoccs"},{"line_number":545,"context_line":"            operation_params \u003d vnf_lcm_opoccs.get(\u0027operationParams\u0027)"},{"line_number":546,"context_line":"            if operation_params:"},{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"},{"line_number":552,"context_line":"            metadata \u003d None"},{"line_number":553,"context_line":"            if operation_params:"},{"line_number":554,"context_line":"                metadata \u003d operation_params.get(\u0027metadata\u0027, {})"},{"line_number":555,"context_line":"            if metadata:"},{"line_number":556,"context_line":"                configmap_secret_paths \u003d metadata.get("},{"line_number":557,"context_line":"                    \u0027configmap_secret_paths\u0027, [])"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"            kwargs \u003d {\"old_vnf_package_path\": old_vnf_package_path,"},{"line_number":560,"context_line":"                      \"configmap_secret_paths\": configmap_secret_paths}"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        self._mgmt_manager.invoke("},{"line_number":563,"context_line":"            self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":12,"id":"feddcb46_884240f2","line":560,"range":{"start_line":541,"start_character":0,"end_line":560,"end_character":71},"updated":"2022-03-07 12:29:49.000000000","message":"Please consider to brush up this block like this:\n```\n        kwargs \u003d {}\n        if vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:\n            # If the file path of ConfigMap/Secret is changed\n            cm_secret_paths \u003d []\n            # Get the metadata from vnf_lcm_opoccs\n            operation_params \u003d vnf_lcm_opoccs.get(\u0027operationParams\u0027)\n            if operation_params:\n                try:\n                    cm_secret_paths \u003d (json.loads(operation_params)\n                                       .get(\u0027metadata\u0027, {})\n                                       .get(\u0027configmap_secret_paths\u0027, []))\n                except Exception as e:\n                    LOG.error(\"The request parameters is incorrect.\")\n                    raise exceptions.InvalidInput(str(e))\n            kwargs \u003d {\"old_vnf_package_path\": old_vnf_package_path,\n                      \"configmap_secret_paths\": cm_secret_paths}\n```\n\nIn my understanding, the role of this block is just to obtain ``configmap_secret_paths``, am I correct? If so, I think the above example will work :)","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":538,"context_line":"            vim_info, context)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        kwargs \u003d {}"},{"line_number":541,"context_line":"        if vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":542,"context_line":"            # If the file path of ConfigMap/Secret is changed"},{"line_number":543,"context_line":"            configmap_secret_paths \u003d []"},{"line_number":544,"context_line":"            # Get the metadata from vnf_lcm_opoccs"},{"line_number":545,"context_line":"            operation_params \u003d vnf_lcm_opoccs.get(\u0027operationParams\u0027)"},{"line_number":546,"context_line":"            if operation_params:"},{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"},{"line_number":552,"context_line":"            metadata \u003d None"},{"line_number":553,"context_line":"            if operation_params:"},{"line_number":554,"context_line":"                metadata \u003d operation_params.get(\u0027metadata\u0027, {})"},{"line_number":555,"context_line":"            if metadata:"},{"line_number":556,"context_line":"                configmap_secret_paths \u003d metadata.get("},{"line_number":557,"context_line":"                    \u0027configmap_secret_paths\u0027, [])"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"            kwargs \u003d {\"old_vnf_package_path\": old_vnf_package_path,"},{"line_number":560,"context_line":"                      \"configmap_secret_paths\": configmap_secret_paths}"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        self._mgmt_manager.invoke("},{"line_number":563,"context_line":"            self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":12,"id":"e6aa644a_707842ec","line":560,"range":{"start_line":541,"start_character":0,"end_line":560,"end_character":71},"in_reply_to":"a49d4ec3_15cf8134","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":538,"context_line":"            vim_info, context)"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        kwargs \u003d {}"},{"line_number":541,"context_line":"        if vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":542,"context_line":"            # If the file path of ConfigMap/Secret is changed"},{"line_number":543,"context_line":"            configmap_secret_paths \u003d []"},{"line_number":544,"context_line":"            # Get the metadata from vnf_lcm_opoccs"},{"line_number":545,"context_line":"            operation_params \u003d vnf_lcm_opoccs.get(\u0027operationParams\u0027)"},{"line_number":546,"context_line":"            if operation_params:"},{"line_number":547,"context_line":"                try:"},{"line_number":548,"context_line":"                    operation_params \u003d eval(operation_params)"},{"line_number":549,"context_line":"                except Exception as e:"},{"line_number":550,"context_line":"                    LOG.error(\"The request parameters is incorrect.\")"},{"line_number":551,"context_line":"                    raise exceptions.InvalidInput(str(e))"},{"line_number":552,"context_line":"            metadata \u003d None"},{"line_number":553,"context_line":"            if operation_params:"},{"line_number":554,"context_line":"                metadata \u003d operation_params.get(\u0027metadata\u0027, {})"},{"line_number":555,"context_line":"            if metadata:"},{"line_number":556,"context_line":"                configmap_secret_paths \u003d metadata.get("},{"line_number":557,"context_line":"                    \u0027configmap_secret_paths\u0027, [])"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"            kwargs \u003d {\"old_vnf_package_path\": old_vnf_package_path,"},{"line_number":560,"context_line":"                      \"configmap_secret_paths\": configmap_secret_paths}"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"        self._mgmt_manager.invoke("},{"line_number":563,"context_line":"            self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":12,"id":"a49d4ec3_15cf8134","line":560,"range":{"start_line":541,"start_character":0,"end_line":560,"end_character":71},"in_reply_to":"feddcb46_884240f2","updated":"2022-03-08 09:54:59.000000000","message":"I replaced the original content with this code block.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"}],"tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":553,"context_line":"                    pods_information.append(item)"},{"line_number":554,"context_line":"        return pods_information"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def get_pod_status(self, pods_information):"},{"line_number":557,"context_line":"        return self._get_pod_status(pods_information)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    def _get_pod_status(self, pods_information):"}],"source_content_type":"text/x-python","patch_set":12,"id":"78244bd3_f4e99042","line":556,"updated":"2022-03-07 12:29:49.000000000","message":"I think it\u0027s fine to make it a public method, e.g., renaming ``_get_pod_status`` to ``get_pod_status``.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":553,"context_line":"                    pods_information.append(item)"},{"line_number":554,"context_line":"        return pods_information"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def get_pod_status(self, pods_information):"},{"line_number":557,"context_line":"        return self._get_pod_status(pods_information)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    def _get_pod_status(self, pods_information):"}],"source_content_type":"text/x-python","patch_set":12,"id":"2cc5e440_6aff049c","line":556,"in_reply_to":"3948ef9f_d2ba3c84","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":553,"context_line":"                    pods_information.append(item)"},{"line_number":554,"context_line":"        return pods_information"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def get_pod_status(self, pods_information):"},{"line_number":557,"context_line":"        return self._get_pod_status(pods_information)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    def _get_pod_status(self, pods_information):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3948ef9f_d2ba3c84","line":556,"in_reply_to":"78244bd3_f4e99042","updated":"2022-03-08 09:54:59.000000000","message":"I renamed the private method to public method.","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":980,"context_line":"            LOG.error(\u0027Deleting wait VNF got an error due to %s\u0027, e)"},{"line_number":981,"context_line":"            raise"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"    def select_k8s_obj_read_api(self, k8s_client_dict, namespace,"},{"line_number":984,"context_line":"                                name, kind, api_version):"},{"line_number":985,"context_line":"        return self._select_k8s_obj_read_api(k8s_client_dict, namespace, name,"},{"line_number":986,"context_line":"                                             kind, api_version)"}],"source_content_type":"text/x-python","patch_set":12,"id":"81b476c0_4991f573","line":983,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":980,"context_line":"            LOG.error(\u0027Deleting wait VNF got an error due to %s\u0027, e)"},{"line_number":981,"context_line":"            raise"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"    def select_k8s_obj_read_api(self, k8s_client_dict, namespace,"},{"line_number":984,"context_line":"                                name, kind, api_version):"},{"line_number":985,"context_line":"        return self._select_k8s_obj_read_api(k8s_client_dict, namespace, name,"},{"line_number":986,"context_line":"                                             kind, api_version)"}],"source_content_type":"text/x-python","patch_set":12,"id":"33d59e99_7a2c1a0b","line":983,"in_reply_to":"57281737_5f1d0ece","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":980,"context_line":"            LOG.error(\u0027Deleting wait VNF got an error due to %s\u0027, e)"},{"line_number":981,"context_line":"            raise"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"    def select_k8s_obj_read_api(self, k8s_client_dict, namespace,"},{"line_number":984,"context_line":"                                name, kind, api_version):"},{"line_number":985,"context_line":"        return self._select_k8s_obj_read_api(k8s_client_dict, namespace, name,"},{"line_number":986,"context_line":"                                             kind, api_version)"}],"source_content_type":"text/x-python","patch_set":12,"id":"57281737_5f1d0ece","line":983,"in_reply_to":"81b476c0_4991f573","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":1398,"context_line":"        elif stack_retries !\u003d 0 and status !\u003d \u0027Running\u0027:"},{"line_number":1399,"context_line":"            raise vnfm.VNFCreateWaitFailed(reason\u003derror_reason)"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"    def is_match_pod_naming_rule(self, rsc_kind, rsc_name, pod_name):"},{"line_number":1402,"context_line":"        return self._is_match_pod_naming_rule(rsc_kind, rsc_name, pod_name)"},{"line_number":1403,"context_line":""},{"line_number":1404,"context_line":"    def _is_match_pod_naming_rule(self, rsc_kind, rsc_name, pod_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"8e7c0994_23d63531","line":1401,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"        elif stack_retries !\u003d 0 and status !\u003d \u0027Running\u0027:"},{"line_number":1399,"context_line":"            raise vnfm.VNFCreateWaitFailed(reason\u003derror_reason)"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"    def is_match_pod_naming_rule(self, rsc_kind, rsc_name, pod_name):"},{"line_number":1402,"context_line":"        return self._is_match_pod_naming_rule(rsc_kind, rsc_name, pod_name)"},{"line_number":1403,"context_line":""},{"line_number":1404,"context_line":"    def _is_match_pod_naming_rule(self, rsc_kind, rsc_name, pod_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"39daa009_44f8673b","line":1401,"in_reply_to":"0b64a071_213cb232","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":1398,"context_line":"        elif stack_retries !\u003d 0 and status !\u003d \u0027Running\u0027:"},{"line_number":1399,"context_line":"            raise vnfm.VNFCreateWaitFailed(reason\u003derror_reason)"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"    def is_match_pod_naming_rule(self, rsc_kind, rsc_name, pod_name):"},{"line_number":1402,"context_line":"        return self._is_match_pod_naming_rule(rsc_kind, rsc_name, pod_name)"},{"line_number":1403,"context_line":""},{"line_number":1404,"context_line":"    def _is_match_pod_naming_rule(self, rsc_kind, rsc_name, pod_name):"}],"source_content_type":"text/x-python","patch_set":12,"id":"0b64a071_213cb232","line":1401,"in_reply_to":"8e7c0994_23d63531","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"17b73875f4ddf261500010a5c55b9d9c2641b492","unresolved":true,"context_lines":[{"line_number":1534,"context_line":"        # TODO(phuoc): will update it for other components"},{"line_number":1535,"context_line":"        pass"},{"line_number":1536,"context_line":""},{"line_number":1537,"context_line":"    def get_auth_creds(self, auth_cred):"},{"line_number":1538,"context_line":"        return self._get_auth_creds(auth_cred)"},{"line_number":1539,"context_line":""},{"line_number":1540,"context_line":"    def _get_auth_creds(self, auth_cred):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3e183ef0_0b50a8b2","line":1537,"updated":"2022-03-07 12:29:49.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c0194679cfaaf4f1a4dbfeb73992466abf8d7738","unresolved":true,"context_lines":[{"line_number":1534,"context_line":"        # TODO(phuoc): will update it for other components"},{"line_number":1535,"context_line":"        pass"},{"line_number":1536,"context_line":""},{"line_number":1537,"context_line":"    def get_auth_creds(self, auth_cred):"},{"line_number":1538,"context_line":"        return self._get_auth_creds(auth_cred)"},{"line_number":1539,"context_line":""},{"line_number":1540,"context_line":"    def _get_auth_creds(self, auth_cred):"}],"source_content_type":"text/x-python","patch_set":12,"id":"4cf2e4c2_1703f7fc","line":1537,"in_reply_to":"3e183ef0_0b50a8b2","updated":"2022-03-08 09:54:59.000000000","message":"ditto","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2096fe94df7969bf18bcd1b8fa73b5b84dff882f","unresolved":false,"context_lines":[{"line_number":1534,"context_line":"        # TODO(phuoc): will update it for other components"},{"line_number":1535,"context_line":"        pass"},{"line_number":1536,"context_line":""},{"line_number":1537,"context_line":"    def get_auth_creds(self, auth_cred):"},{"line_number":1538,"context_line":"        return self._get_auth_creds(auth_cred)"},{"line_number":1539,"context_line":""},{"line_number":1540,"context_line":"    def _get_auth_creds(self, auth_cred):"}],"source_content_type":"text/x-python","patch_set":12,"id":"26bf66a5_6327518a","line":1537,"in_reply_to":"4cf2e4c2_1703f7fc","updated":"2022-03-09 05:15:29.000000000","message":"Ack","commit_id":"25e08a58b921da78146d6c371802377c8a39e92b"}],"tools/test-setup-k8s-vim.sh":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"9f8b245c25dd2732deebe4a57b0952fa090c26f6","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    --config-file /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim.yaml \\"},{"line_number":27,"context_line":"    vim-kubernetes"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# add MgmtDriver for container_update"},{"line_number":30,"context_line":"sudo cp /opt/stack/tacker/samples/mgmt_driver/kubernetes/container_update/container_update_mgmt.py /opt/stack/tacker/tacker/vnfm/mgmt_drivers/"},{"line_number":31,"context_line":"sudo chown stack:stack /opt/stack/tacker/tacker/vnfm/mgmt_drivers/container_update_mgmt.py"},{"line_number":32,"context_line":"sudo sed -i \u0027/VnflcmMgmtNoop/a \\ \\ \\ \\ mgmt-container-update \u003d tacker.vnfm.mgmt_drivers.container_update_mgmt:ContainerUpdateMgmtDriver\u0027 /opt/stack/tacker/setup.cfg"},{"line_number":33,"context_line":"sudo sed -i \u0027/vnflcm_mgmt_driver \u003d vnflcm_noop/a vnflcm_mgmt_driver \u003d vnflcm_noop,mgmt-container-update\u0027 /etc/tacker/tacker.conf"},{"line_number":34,"context_line":"# reload configuration file with MgmtDriver appended"},{"line_number":35,"context_line":"cd /opt/stack/tacker/"},{"line_number":36,"context_line":"sudo python3 setup.py build"},{"line_number":37,"context_line":"sudo chown -R stack:stack /opt/stack/tacker/"},{"line_number":38,"context_line":"# restart the service to take effect"},{"line_number":39,"context_line":"sudo systemctl restart devstack@tacker-conductor"},{"line_number":40,"context_line":"sleep 10s"}],"source_content_type":"text/x-sh","patch_set":9,"id":"93ce87c7_eb72be63","line":40,"range":{"start_line":29,"start_character":0,"end_line":40,"end_character":9},"updated":"2022-03-03 08:24:20.000000000","message":"Wouldn\u0027t it be better to set it up with Ansible? Or I guess another way would be to make it a separate script file because the script name does not match the content.","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"552257545b254c31f6987700c57697a2a6aa8311","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    --config-file /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim.yaml \\"},{"line_number":27,"context_line":"    vim-kubernetes"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# add MgmtDriver for container_update"},{"line_number":30,"context_line":"sudo cp /opt/stack/tacker/samples/mgmt_driver/kubernetes/container_update/container_update_mgmt.py /opt/stack/tacker/tacker/vnfm/mgmt_drivers/"},{"line_number":31,"context_line":"sudo chown stack:stack /opt/stack/tacker/tacker/vnfm/mgmt_drivers/container_update_mgmt.py"},{"line_number":32,"context_line":"sudo sed -i \u0027/VnflcmMgmtNoop/a \\ \\ \\ \\ mgmt-container-update \u003d tacker.vnfm.mgmt_drivers.container_update_mgmt:ContainerUpdateMgmtDriver\u0027 /opt/stack/tacker/setup.cfg"},{"line_number":33,"context_line":"sudo sed -i \u0027/vnflcm_mgmt_driver \u003d vnflcm_noop/a vnflcm_mgmt_driver \u003d vnflcm_noop,mgmt-container-update\u0027 /etc/tacker/tacker.conf"},{"line_number":34,"context_line":"# reload configuration file with MgmtDriver appended"},{"line_number":35,"context_line":"cd /opt/stack/tacker/"},{"line_number":36,"context_line":"sudo python3 setup.py build"},{"line_number":37,"context_line":"sudo chown -R stack:stack /opt/stack/tacker/"},{"line_number":38,"context_line":"# restart the service to take effect"},{"line_number":39,"context_line":"sudo systemctl restart devstack@tacker-conductor"},{"line_number":40,"context_line":"sleep 10s"}],"source_content_type":"text/x-sh","patch_set":9,"id":"bd1c7970_3759187a","line":40,"range":{"start_line":29,"start_character":0,"end_line":40,"end_character":9},"in_reply_to":"6d52fc60_2bcf3c20","updated":"2022-03-09 11:17:04.000000000","message":"I have confirmed it.","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"79bc412480a9dff1c8c604b1305d2fa690753578","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    --config-file /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim.yaml \\"},{"line_number":27,"context_line":"    vim-kubernetes"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# add MgmtDriver for container_update"},{"line_number":30,"context_line":"sudo cp /opt/stack/tacker/samples/mgmt_driver/kubernetes/container_update/container_update_mgmt.py /opt/stack/tacker/tacker/vnfm/mgmt_drivers/"},{"line_number":31,"context_line":"sudo chown stack:stack /opt/stack/tacker/tacker/vnfm/mgmt_drivers/container_update_mgmt.py"},{"line_number":32,"context_line":"sudo sed -i \u0027/VnflcmMgmtNoop/a \\ \\ \\ \\ mgmt-container-update \u003d tacker.vnfm.mgmt_drivers.container_update_mgmt:ContainerUpdateMgmtDriver\u0027 /opt/stack/tacker/setup.cfg"},{"line_number":33,"context_line":"sudo sed -i \u0027/vnflcm_mgmt_driver \u003d vnflcm_noop/a vnflcm_mgmt_driver \u003d vnflcm_noop,mgmt-container-update\u0027 /etc/tacker/tacker.conf"},{"line_number":34,"context_line":"# reload configuration file with MgmtDriver appended"},{"line_number":35,"context_line":"cd /opt/stack/tacker/"},{"line_number":36,"context_line":"sudo python3 setup.py build"},{"line_number":37,"context_line":"sudo chown -R stack:stack /opt/stack/tacker/"},{"line_number":38,"context_line":"# restart the service to take effect"},{"line_number":39,"context_line":"sudo systemctl restart devstack@tacker-conductor"},{"line_number":40,"context_line":"sleep 10s"}],"source_content_type":"text/x-sh","patch_set":9,"id":"6d52fc60_2bcf3c20","line":40,"range":{"start_line":29,"start_character":0,"end_line":40,"end_character":9},"in_reply_to":"93ce87c7_eb72be63","updated":"2022-03-04 09:42:59.000000000","message":"I append a new script to execute.","commit_id":"bf89ee1c869da4788c0265f434762bc3a24c4177"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cd5daff7eb8c48a046cc95591e7e103c6f77609d","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    --description \"Kubernetes VIM\" \\"},{"line_number":26,"context_line":"    --config-file /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim.yaml \\"},{"line_number":27,"context_line":"    vim-kubernetes"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"ba666c49_f03577b9","line":28,"updated":"2022-03-04 14:13:16.000000000","message":"Could you delete this empty line?","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0d50fffe951d4f317c2fd061c78358399ef7ea16","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    --description \"Kubernetes VIM\" \\"},{"line_number":26,"context_line":"    --config-file /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim.yaml \\"},{"line_number":27,"context_line":"    vim-kubernetes"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"fe5416e1_05768569","line":28,"in_reply_to":"ba666c49_f03577b9","updated":"2022-03-08 01:19:13.000000000","message":"I deleted this empty line.","commit_id":"290dd544110b90f7f49dc409d86b1d5c157137e0"}],"tools/test-setup-mgmt.sh":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b24a5237612ab6baf1c5a1370c0f58aeb1cd53fb","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# the sample folder to the tacker code"},{"line_number":6,"context_line":"# and run it."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# add MgmtDriver for container_update"},{"line_number":9,"context_line":"sudo cp /opt/stack/tacker/samples/mgmt_driver/kubernetes/container_update/container_update_mgmt.py /opt/stack/tacker/tacker/vnfm/mgmt_drivers/"},{"line_number":10,"context_line":"sudo chown stack:stack /opt/stack/tacker/tacker/vnfm/mgmt_drivers/container_update_mgmt.py"},{"line_number":11,"context_line":"sudo sed -i \u0027/VnflcmMgmtNoop/a \\ \\ \\ \\ mgmt-container-update \u003d tacker.vnfm.mgmt_drivers.container_update_mgmt:ContainerUpdateMgmtDriver\u0027 /opt/stack/tacker/setup.cfg"},{"line_number":12,"context_line":"sudo sed -i \u0027/vnflcm_mgmt_driver \u003d vnflcm_noop/a vnflcm_mgmt_driver \u003d vnflcm_noop,mgmt-container-update\u0027 /etc/tacker/tacker.conf"},{"line_number":13,"context_line":"# reload configuration file with MgmtDriver appended"},{"line_number":14,"context_line":"cd /opt/stack/tacker/"},{"line_number":15,"context_line":"sudo python3 setup.py build"},{"line_number":16,"context_line":"sudo chown -R stack:stack /opt/stack/tacker/"},{"line_number":17,"context_line":"# restart the service to take effect"},{"line_number":18,"context_line":"sudo systemctl restart devstack@tacker-conductor"},{"line_number":19,"context_line":"sleep 10s"}],"source_content_type":"text/x-sh","patch_set":18,"id":"c2e9a5f7_f4031453","line":19,"range":{"start_line":8,"start_character":0,"end_line":19,"end_character":9},"updated":"2022-03-10 08:07:43.000000000","message":"As you may know, scripts in tools/ have been chaotic and planned to be clean. If you believe it should be in the directory, please refactor the codes for\n* Fix too long lines (max 79 chars is reasonable).\n* Separate codes into blocks based on its meaning, or make it structured.","commit_id":"885f06be0e6044a1431063c74c8526d66636a8d9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"61cfe5f0cd06c158a43395a6b723e550aa13d988","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# the sample folder to the tacker code"},{"line_number":6,"context_line":"# and run it."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# add MgmtDriver for container_update"},{"line_number":9,"context_line":"sudo cp /opt/stack/tacker/samples/mgmt_driver/kubernetes/container_update/container_update_mgmt.py /opt/stack/tacker/tacker/vnfm/mgmt_drivers/"},{"line_number":10,"context_line":"sudo chown stack:stack /opt/stack/tacker/tacker/vnfm/mgmt_drivers/container_update_mgmt.py"},{"line_number":11,"context_line":"sudo sed -i \u0027/VnflcmMgmtNoop/a \\ \\ \\ \\ mgmt-container-update \u003d tacker.vnfm.mgmt_drivers.container_update_mgmt:ContainerUpdateMgmtDriver\u0027 /opt/stack/tacker/setup.cfg"},{"line_number":12,"context_line":"sudo sed -i \u0027/vnflcm_mgmt_driver \u003d vnflcm_noop/a vnflcm_mgmt_driver \u003d vnflcm_noop,mgmt-container-update\u0027 /etc/tacker/tacker.conf"},{"line_number":13,"context_line":"# reload configuration file with MgmtDriver appended"},{"line_number":14,"context_line":"cd /opt/stack/tacker/"},{"line_number":15,"context_line":"sudo python3 setup.py build"},{"line_number":16,"context_line":"sudo chown -R stack:stack /opt/stack/tacker/"},{"line_number":17,"context_line":"# restart the service to take effect"},{"line_number":18,"context_line":"sudo systemctl restart devstack@tacker-conductor"},{"line_number":19,"context_line":"sleep 10s"}],"source_content_type":"text/x-sh","patch_set":18,"id":"85a0efa5_494ecf80","line":19,"range":{"start_line":8,"start_character":0,"end_line":19,"end_character":9},"in_reply_to":"c2e9a5f7_f4031453","updated":"2022-03-10 09:17:05.000000000","message":"I did some line wrapping to the script.","commit_id":"885f06be0e6044a1431063c74c8526d66636a8d9"}]}