)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d56d30d557b36e5f6e026b4af6f967f6de5021d8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2d9b39fe_14b0e180","line":11,"range":{"start_line":11,"start_character":48,"end_line":11,"end_character":54},"updated":"2022-04-04 09:19:48.000000000","message":"According to the above sentence, \"clients\" is better than \"client\".","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d56d30d557b36e5f6e026b4af6f967f6de5021d8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ca86e258_91581218","line":11,"updated":"2022-04-04 09:19:48.000000000","message":"I think it is better not to omit \"if\".\nBut a server -\u003e But if a server","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d56d30d557b36e5f6e026b4af6f967f6de5021d8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0a2e2b81_e29377a3","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":25},"updated":"2022-04-04 09:19:48.000000000","message":"typo: serivce -\u003e service","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f3a913a7dfde1f4dab04c310bf9592abf57ff9c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"996d939e_851cdc79","line":11,"range":{"start_line":11,"start_character":48,"end_line":11,"end_character":54},"in_reply_to":"055b73bf_ef331726","updated":"2022-04-04 23:47:38.000000000","message":"Done","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"bcdedc9ca1e94726b4cdd6d63aca49c365817c80","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7e690191_e26e44ea","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":25},"in_reply_to":"0a2e2b81_e29377a3","updated":"2022-04-04 22:41:15.000000000","message":"I will fix.","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9c8ec02eccabb269ce8de5e6054bd7ab6e6bae0e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"59b78c61_38b31293","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":25},"in_reply_to":"25f85896_3db6079c","updated":"2022-04-05 00:25:24.000000000","message":"oops. I will fix.","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"bcdedc9ca1e94726b4cdd6d63aca49c365817c80","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"055b73bf_ef331726","line":11,"range":{"start_line":11,"start_character":48,"end_line":11,"end_character":54},"in_reply_to":"2d9b39fe_14b0e180","updated":"2022-04-04 22:41:15.000000000","message":"I will fix.","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"16f650f5e46875c0aaa8495387e356806c015e0f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2820d6f9_f1351526","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":25},"in_reply_to":"59b78c61_38b31293","updated":"2022-04-07 04:17:03.000000000","message":"Done","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f3a913a7dfde1f4dab04c310bf9592abf57ff9c8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"25f85896_3db6079c","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":25},"in_reply_to":"7e690191_e26e44ea","updated":"2022-04-04 23:47:38.000000000","message":"typo: seivice -\u003e service","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f3a913a7dfde1f4dab04c310bf9592abf57ff9c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e830411f_12641afa","line":11,"in_reply_to":"c7db76b5_e1dae75e","updated":"2022-04-04 23:47:38.000000000","message":"Done","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"bcdedc9ca1e94726b4cdd6d63aca49c365817c80","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Common http utilities used by v2 API use keystoneauth1 module."},{"line_number":10,"context_line":"If a server is a service in OpenStack, clients can omit endpoint."},{"line_number":11,"context_line":"But a server is a serivce outside of OpenStack, client can\u0027t omit"},{"line_number":12,"context_line":"endpoint."},{"line_number":13,"context_line":"This patch fixes to add endpoint to URL in case that a server is"},{"line_number":14,"context_line":"an external NFVO."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c7db76b5_e1dae75e","line":11,"in_reply_to":"ca86e258_91581218","updated":"2022-04-04 22:41:15.000000000","message":"I will fix.","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"79b51f36d0e1351e4a2e37974f3493eabdf01519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"099244b6_1eff4f83","updated":"2022-04-04 02:33:36.000000000","message":"LGTM","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4391830672687f951e89bdffeaadae0501c0e732","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e431fb71_608d1a61","updated":"2022-03-31 15:02:38.000000000","message":"LGTM, thanks!","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"bcdedc9ca1e94726b4cdd6d63aca49c365817c80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"338521c4_e1efa7db","updated":"2022-04-04 22:41:15.000000000","message":"Thank you for the review.","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9c8ec02eccabb269ce8de5e6054bd7ab6e6bae0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd121c92_99c51a56","updated":"2022-04-05 00:25:24.000000000","message":"Thank you for the review.","commit_id":"e07246203830b8bfe6391bb1fef95f7153a26260"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"21fb8a0e63d5bb98ca38f60cd7b7a39d934f8fbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a702c7ee_0a096572","updated":"2022-05-09 07:36:57.000000000","message":"Sorry for the late review, LGTM.","commit_id":"6873da0ba79e6306b83606ccfeb8eb403df6aae7"}],"tacker/sol_refactored/nfvo/nfvo_client.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"d56d30d557b36e5f6e026b4af6f967f6de5021d8","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            resp, body \u003d self.client.do_request("},{"line_number":97,"context_line":"                url, \"POST\", expected_status\u003d[201], body\u003dgrant_req,"},{"line_number":98,"context_line":"                version\u003dself.grant_api_version)"},{"line_number":99,"context_line":"            grant_res \u003d objects.GrantV1.from_dict(body)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        LOG.debug(\"grant response: %s\", grant_res.to_dict())"},{"line_number":102,"context_line":"        return grant_res"}],"source_content_type":"text/x-python","patch_set":1,"id":"148986a0_bf7b4125","line":99,"updated":"2022-04-04 09:19:48.000000000","message":"Is it intentional to set the v2 grant to GrantV1?","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"bcdedc9ca1e94726b4cdd6d63aca49c365817c80","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            resp, body \u003d self.client.do_request("},{"line_number":97,"context_line":"                url, \"POST\", expected_status\u003d[201], body\u003dgrant_req,"},{"line_number":98,"context_line":"                version\u003dself.grant_api_version)"},{"line_number":99,"context_line":"            grant_res \u003d objects.GrantV1.from_dict(body)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        LOG.debug(\"grant response: %s\", grant_res.to_dict())"},{"line_number":102,"context_line":"        return grant_res"}],"source_content_type":"text/x-python","patch_set":1,"id":"323cc110_65079ca5","line":99,"in_reply_to":"148986a0_bf7b4125","updated":"2022-04-04 22:41:15.000000000","message":"yes. grant API version corresponding to vnflcm v2 is v1 (1.4.0).","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"f3a913a7dfde1f4dab04c310bf9592abf57ff9c8","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            resp, body \u003d self.client.do_request("},{"line_number":97,"context_line":"                url, \"POST\", expected_status\u003d[201], body\u003dgrant_req,"},{"line_number":98,"context_line":"                version\u003dself.grant_api_version)"},{"line_number":99,"context_line":"            grant_res \u003d objects.GrantV1.from_dict(body)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        LOG.debug(\"grant response: %s\", grant_res.to_dict())"},{"line_number":102,"context_line":"        return grant_res"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9d2f27d_dbced03b","line":99,"in_reply_to":"323cc110_65079ca5","updated":"2022-04-04 23:47:38.000000000","message":"Thank you for explaining.\nWhen using API version 1.4.0, is it okay if the URL does not have to be \"grant/v1/grants\"?\nSOL003 v3.3.1 has the following description.\n-----\n9.1a  API version \nFor the VNF lifecycle operation granting interface as specified in the present document, the MAJOR version field shall be 1, the MINOR version field shall be 4 and the PATCH version field shall be 0 (see clause 9.1 of ETSI GS NFV-SOL 013 [8] ] for a definition of the version fields). Therefore, the {apiMajorVersion} URI variable shall be set to \"v1\".\n-----","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"16f650f5e46875c0aaa8495387e356806c015e0f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            resp, body \u003d self.client.do_request("},{"line_number":97,"context_line":"                url, \"POST\", expected_status\u003d[201], body\u003dgrant_req,"},{"line_number":98,"context_line":"                version\u003dself.grant_api_version)"},{"line_number":99,"context_line":"            grant_res \u003d objects.GrantV1.from_dict(body)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        LOG.debug(\"grant response: %s\", grant_res.to_dict())"},{"line_number":102,"context_line":"        return grant_res"}],"source_content_type":"text/x-python","patch_set":1,"id":"f9c9dbec_d110ddec","line":99,"in_reply_to":"7ed70138_9ae0ea16","updated":"2022-04-07 04:17:03.000000000","message":"Done","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9c8ec02eccabb269ce8de5e6054bd7ab6e6bae0e","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            resp, body \u003d self.client.do_request("},{"line_number":97,"context_line":"                url, \"POST\", expected_status\u003d[201], body\u003dgrant_req,"},{"line_number":98,"context_line":"                version\u003dself.grant_api_version)"},{"line_number":99,"context_line":"            grant_res \u003d objects.GrantV1.from_dict(body)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        LOG.debug(\"grant response: %s\", grant_res.to_dict())"},{"line_number":102,"context_line":"        return grant_res"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ed70138_9ae0ea16","line":99,"in_reply_to":"c9d2f27d_dbced03b","updated":"2022-04-05 00:25:24.000000000","message":"you are right. it should be \u0027v1\u0027. I will fix.","commit_id":"033309d11f96377fab0d669aa09b8b85ccf0df5b"}]}