)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31668},"change_message_id":"a848bc74865674de1f75f613879122e9842db80f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d5000bb3_a13e9308","updated":"2022-04-08 05:11:55.000000000","message":"Could you add the following blueprint to the \"Topic\" and \"Commit message\"?\n[paging-query-result]\nhttps://blueprints.launchpad.net/tacker/+spec/paging-query-result","commit_id":"67a54094dd8b15d964bdd11af625034064e57219"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"4cde77cbf12f8801d2843a4d7746d4764e92dff5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5abb7c90_541016c5","updated":"2022-04-08 07:43:33.000000000","message":"Thank you for the review.","commit_id":"67a54094dd8b15d964bdd11af625034064e57219"},{"author":{"_account_id":31668},"change_message_id":"dc057541e6d99baa3f7b0bcfedcecca16e127d06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9507cea1_feaa4720","in_reply_to":"09c9034f_ae250988","updated":"2022-05-16 01:07:28.000000000","message":"Done","commit_id":"67a54094dd8b15d964bdd11af625034064e57219"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"4cde77cbf12f8801d2843a4d7746d4764e92dff5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09c9034f_ae250988","in_reply_to":"d5000bb3_a13e9308","updated":"2022-04-08 07:43:33.000000000","message":"I will fix.","commit_id":"67a54094dd8b15d964bdd11af625034064e57219"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"c76a3ffac35d97b08c87152a95c898d7b722d388","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"061a67b8_47b2766b","updated":"2022-04-11 08:43:33.000000000","message":"Thank you for the review.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d44b17cf197adbd405bd3b6939cb9fce079a460a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"774b8dd1_29a52f1c","updated":"2022-04-11 08:42:51.000000000","message":"Thank you for the review.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1224bc445772cae16ba4ace08b82b5ec55d73b24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f0b65673_ffb6d6ea","updated":"2022-04-12 05:39:35.000000000","message":"Thank you for the review.","commit_id":"29ac2dd5d4a7b6bc0483cb50b03d48a157dc969b"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"ff1e513fad9d73d00a413335f5b0af107d839f29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1a6123c0_b6be3757","updated":"2022-05-10 00:25:57.000000000","message":"LGTM","commit_id":"e474c5e29245fd7b5b56ddc8fbefccd4a7c48710"},{"author":{"_account_id":31668},"change_message_id":"dc057541e6d99baa3f7b0bcfedcecca16e127d06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5ea371a0_4f639532","updated":"2022-05-16 01:07:28.000000000","message":"LGTM","commit_id":"e474c5e29245fd7b5b56ddc8fbefccd4a7c48710"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"de5c6f6a6a279930e85e5c3f433496f2dfbaa39d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d6e94c99_268096a1","updated":"2022-05-02 06:14:34.000000000","message":"recheck","commit_id":"e474c5e29245fd7b5b56ddc8fbefccd4a7c48710"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"aac8ed56f16c26fd1bcdac44c5896f6b940837c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e1bac121_87bfcacd","updated":"2022-04-27 22:07:23.000000000","message":"recheck","commit_id":"e474c5e29245fd7b5b56ddc8fbefccd4a7c48710"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c0fc119e61d46084861bb217254a02064cc6f121","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2d874682_13572678","updated":"2022-05-19 05:29:10.000000000","message":"Thanks for your patch, LGTM.","commit_id":"e0e7b538eec2552b152725554f2fa460e9b50de2"}],"tacker/sol_refactored/api/wsgi.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"af79ca645b37671dfcb8feb76f8b2b19e87dcc9a","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        self.body \u003d body"},{"line_number":43,"context_line":"        self.headers \u003d {}"},{"line_number":44,"context_line":"        for hdr in self.allowed_headers:"},{"line_number":45,"context_line":"            if kwargs.get(hdr):"},{"line_number":46,"context_line":"                self.headers[hdr] \u003d kwargs[hdr]"},{"line_number":47,"context_line":"        self.headers.setdefault(\u0027version\u0027, api_version.CURRENT_VERSION)"},{"line_number":48,"context_line":"        self.headers.setdefault(\u0027accept-ranges\u0027, \u0027none\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e70508ff_b969002a","line":45,"updated":"2022-04-11 05:11:50.000000000","message":"Do you need this fix?","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3c9f5a972e22844bffd2aa39623188fe7cb85b12","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.body \u003d body"},{"line_number":43,"context_line":"        self.headers \u003d {}"},{"line_number":44,"context_line":"        for hdr in self.allowed_headers:"},{"line_number":45,"context_line":"            if kwargs.get(hdr):"},{"line_number":46,"context_line":"                self.headers[hdr] \u003d kwargs[hdr]"},{"line_number":47,"context_line":"        self.headers.setdefault(\u0027version\u0027, api_version.CURRENT_VERSION)"},{"line_number":48,"context_line":"        self.headers.setdefault(\u0027accept-ranges\u0027, \u0027none\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7e74628_69ae99a3","line":45,"in_reply_to":"9b99ef4f_b87b96ed","updated":"2022-04-12 00:52:29.000000000","message":"I see.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d44b17cf197adbd405bd3b6939cb9fce079a460a","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        self.body \u003d body"},{"line_number":43,"context_line":"        self.headers \u003d {}"},{"line_number":44,"context_line":"        for hdr in self.allowed_headers:"},{"line_number":45,"context_line":"            if kwargs.get(hdr):"},{"line_number":46,"context_line":"                self.headers[hdr] \u003d kwargs[hdr]"},{"line_number":47,"context_line":"        self.headers.setdefault(\u0027version\u0027, api_version.CURRENT_VERSION)"},{"line_number":48,"context_line":"        self.headers.setdefault(\u0027accept-ranges\u0027, \u0027none\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b99ef4f_b87b96ed","line":45,"in_reply_to":"e70508ff_b969002a","updated":"2022-04-11 08:42:51.000000000","message":"Fixed to not respond with an empty Link header(\"Link: None\"), if Link is \"None\".","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"}],"tacker/sol_refactored/controller/vnflcm_view.py":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"4ff75c134e105350b2bfcfd50ec5208162e69d8e","unresolved":true,"context_lines":[{"line_number":321,"context_line":"                sol_detail\u003d(\u0027nextpage_opaque_marker and all_records are not \u0027"},{"line_number":322,"context_line":"                            \u0027set at the same time\u0027))"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        if all_records \u003d\u003d \"yes\":"},{"line_number":325,"context_line":"            page_size \u003d 0"},{"line_number":326,"context_line":"        elif all_records is not None:"},{"line_number":327,"context_line":"            # only available value is \"yes\""}],"source_content_type":"text/x-python","patch_set":2,"id":"0506ea19_3b28223c","line":324,"updated":"2022-04-11 07:20:15.000000000","message":"IMO. This option causes heavy database access when a large number of records are in database. Such a processing should not be possible in API request. I recommend removing this option.\nIf user need to obtain all records, it can be performed by setting page_size in configuration file.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"c76a3ffac35d97b08c87152a95c898d7b722d388","unresolved":true,"context_lines":[{"line_number":321,"context_line":"                sol_detail\u003d(\u0027nextpage_opaque_marker and all_records are not \u0027"},{"line_number":322,"context_line":"                            \u0027set at the same time\u0027))"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        if all_records \u003d\u003d \"yes\":"},{"line_number":325,"context_line":"            page_size \u003d 0"},{"line_number":326,"context_line":"        elif all_records is not None:"},{"line_number":327,"context_line":"            # only available value is \"yes\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ebbfe648_3ed61431","line":324,"in_reply_to":"0506ea19_3b28223c","updated":"2022-04-11 08:43:33.000000000","message":"I understand. I will not include the \"all_records\" parameter.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"ff1e513fad9d73d00a413335f5b0af107d839f29","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                sol_detail\u003d(\u0027nextpage_opaque_marker and all_records are not \u0027"},{"line_number":322,"context_line":"                            \u0027set at the same time\u0027))"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        if all_records \u003d\u003d \"yes\":"},{"line_number":325,"context_line":"            page_size \u003d 0"},{"line_number":326,"context_line":"        elif all_records is not None:"},{"line_number":327,"context_line":"            # only available value is \"yes\""}],"source_content_type":"text/x-python","patch_set":2,"id":"0fdf45e8_6125128f","line":324,"in_reply_to":"ebbfe648_3ed61431","updated":"2022-05-10 00:25:57.000000000","message":"Thank you for the revision.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"af79ca645b37671dfcb8feb76f8b2b19e87dcc9a","unresolved":true,"context_lines":[{"line_number":455,"context_line":"        self.next_marker \u003d None"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _marker_string(self, marker):"},{"line_number":458,"context_line":"        return \u0027nextpage_opaque_marker\u003d{}\u0027.format(marker)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _link_value(self, url):"},{"line_number":461,"context_line":"        return \u0027\u003c{}\u003e;rel\u003d\"next\"\u0027.format(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fadba7ae_035a9f50","line":458,"updated":"2022-04-11 05:11:50.000000000","message":"You can use f-string format like below which is fancier output formatting.\n```\nreturn f\u0027nextpage_opaque_marker\u003d{marker}\u0027       \n```","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c263bb2eb3615c9db61bc522ff20eaa6e4473c9f","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        self.next_marker \u003d None"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _marker_string(self, marker):"},{"line_number":458,"context_line":"        return \u0027nextpage_opaque_marker\u003d{}\u0027.format(marker)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _link_value(self, url):"},{"line_number":461,"context_line":"        return \u0027\u003c{}\u003e;rel\u003d\"next\"\u0027.format(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"067d911d_3d3c26d9","line":458,"in_reply_to":"c722a1e4_e306222a","updated":"2022-04-12 02:59:39.000000000","message":"Done","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d44b17cf197adbd405bd3b6939cb9fce079a460a","unresolved":true,"context_lines":[{"line_number":455,"context_line":"        self.next_marker \u003d None"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _marker_string(self, marker):"},{"line_number":458,"context_line":"        return \u0027nextpage_opaque_marker\u003d{}\u0027.format(marker)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _link_value(self, url):"},{"line_number":461,"context_line":"        return \u0027\u003c{}\u003e;rel\u003d\"next\"\u0027.format(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c722a1e4_e306222a","line":458,"in_reply_to":"fadba7ae_035a9f50","updated":"2022-04-11 08:42:51.000000000","message":"I will fix.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"af79ca645b37671dfcb8feb76f8b2b19e87dcc9a","unresolved":true,"context_lines":[{"line_number":458,"context_line":"        return \u0027nextpage_opaque_marker\u003d{}\u0027.format(marker)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _link_value(self, url):"},{"line_number":461,"context_line":"        return \u0027\u003c{}\u003e;rel\u003d\"next\"\u0027.format(url)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    def get_link(self):"},{"line_number":464,"context_line":"        if self.next_marker is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"40508c70_18f39243","line":461,"updated":"2022-04-11 05:11:50.000000000","message":"ditto","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d44b17cf197adbd405bd3b6939cb9fce079a460a","unresolved":true,"context_lines":[{"line_number":458,"context_line":"        return \u0027nextpage_opaque_marker\u003d{}\u0027.format(marker)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _link_value(self, url):"},{"line_number":461,"context_line":"        return \u0027\u003c{}\u003e;rel\u003d\"next\"\u0027.format(url)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    def get_link(self):"},{"line_number":464,"context_line":"        if self.next_marker is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"74d1a1fb_a84cc7e9","line":461,"in_reply_to":"40508c70_18f39243","updated":"2022-04-11 08:42:51.000000000","message":"I will fix.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c263bb2eb3615c9db61bc522ff20eaa6e4473c9f","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        return \u0027nextpage_opaque_marker\u003d{}\u0027.format(marker)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _link_value(self, url):"},{"line_number":461,"context_line":"        return \u0027\u003c{}\u003e;rel\u003d\"next\"\u0027.format(url)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    def get_link(self):"},{"line_number":464,"context_line":"        if self.next_marker is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"10940f7b_0e083ebd","line":461,"in_reply_to":"74d1a1fb_a84cc7e9","updated":"2022-04-12 02:59:39.000000000","message":"Done","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"af79ca645b37671dfcb8feb76f8b2b19e87dcc9a","unresolved":true,"context_lines":[{"line_number":469,"context_line":"            url \u003d self.req_url.replace(self._marker_string(self.marker),"},{"line_number":470,"context_line":"                                       self._marker_string(self.next_marker))"},{"line_number":471,"context_line":"        elif \u0027?\u0027 in self.req_url:"},{"line_number":472,"context_line":"            url \u003d \u0027{}\u0026{}\u0027.format(self.req_url,"},{"line_number":473,"context_line":"                                 self._marker_string(self.next_marker))"},{"line_number":474,"context_line":"        else:"},{"line_number":475,"context_line":"            url \u003d \u0027{}?{}\u0027.format(self.req_url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df56c4fd_9512610d","line":472,"updated":"2022-04-11 05:11:50.000000000","message":"ditto","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c263bb2eb3615c9db61bc522ff20eaa6e4473c9f","unresolved":false,"context_lines":[{"line_number":469,"context_line":"            url \u003d self.req_url.replace(self._marker_string(self.marker),"},{"line_number":470,"context_line":"                                       self._marker_string(self.next_marker))"},{"line_number":471,"context_line":"        elif \u0027?\u0027 in self.req_url:"},{"line_number":472,"context_line":"            url \u003d \u0027{}\u0026{}\u0027.format(self.req_url,"},{"line_number":473,"context_line":"                                 self._marker_string(self.next_marker))"},{"line_number":474,"context_line":"        else:"},{"line_number":475,"context_line":"            url \u003d \u0027{}?{}\u0027.format(self.req_url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"cba4a086_b966b395","line":472,"in_reply_to":"b52ea0f2_aed31b56","updated":"2022-04-12 02:59:39.000000000","message":"Done","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d44b17cf197adbd405bd3b6939cb9fce079a460a","unresolved":true,"context_lines":[{"line_number":469,"context_line":"            url \u003d self.req_url.replace(self._marker_string(self.marker),"},{"line_number":470,"context_line":"                                       self._marker_string(self.next_marker))"},{"line_number":471,"context_line":"        elif \u0027?\u0027 in self.req_url:"},{"line_number":472,"context_line":"            url \u003d \u0027{}\u0026{}\u0027.format(self.req_url,"},{"line_number":473,"context_line":"                                 self._marker_string(self.next_marker))"},{"line_number":474,"context_line":"        else:"},{"line_number":475,"context_line":"            url \u003d \u0027{}?{}\u0027.format(self.req_url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b52ea0f2_aed31b56","line":472,"in_reply_to":"df56c4fd_9512610d","updated":"2022-04-11 08:42:51.000000000","message":"I will fix.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"af79ca645b37671dfcb8feb76f8b2b19e87dcc9a","unresolved":true,"context_lines":[{"line_number":472,"context_line":"            url \u003d \u0027{}\u0026{}\u0027.format(self.req_url,"},{"line_number":473,"context_line":"                                 self._marker_string(self.next_marker))"},{"line_number":474,"context_line":"        else:"},{"line_number":475,"context_line":"            url \u003d \u0027{}?{}\u0027.format(self.req_url,"},{"line_number":476,"context_line":"                                 self._marker_string(self.next_marker))"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        return self._link_value(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"72a7601b_bd70005e","line":475,"updated":"2022-04-11 05:11:50.000000000","message":"ditto","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d44b17cf197adbd405bd3b6939cb9fce079a460a","unresolved":true,"context_lines":[{"line_number":472,"context_line":"            url \u003d \u0027{}\u0026{}\u0027.format(self.req_url,"},{"line_number":473,"context_line":"                                 self._marker_string(self.next_marker))"},{"line_number":474,"context_line":"        else:"},{"line_number":475,"context_line":"            url \u003d \u0027{}?{}\u0027.format(self.req_url,"},{"line_number":476,"context_line":"                                 self._marker_string(self.next_marker))"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        return self._link_value(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a7dc69bd_df2ae7ab","line":475,"in_reply_to":"72a7601b_bd70005e","updated":"2022-04-11 08:42:51.000000000","message":"I will fix.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c263bb2eb3615c9db61bc522ff20eaa6e4473c9f","unresolved":false,"context_lines":[{"line_number":472,"context_line":"            url \u003d \u0027{}\u0026{}\u0027.format(self.req_url,"},{"line_number":473,"context_line":"                                 self._marker_string(self.next_marker))"},{"line_number":474,"context_line":"        else:"},{"line_number":475,"context_line":"            url \u003d \u0027{}?{}\u0027.format(self.req_url,"},{"line_number":476,"context_line":"                                 self._marker_string(self.next_marker))"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        return self._link_value(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"edf615d5_5c7cbc0c","line":475,"in_reply_to":"a7dc69bd_df2ae7ab","updated":"2022-04-12 02:59:39.000000000","message":"Done","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c263bb2eb3615c9db61bc522ff20eaa6e4473c9f","unresolved":true,"context_lines":[{"line_number":455,"context_line":"            # req_url includes marker string"},{"line_number":456,"context_line":"            url \u003d self.req_url.replace(self._marker_string(self.marker),"},{"line_number":457,"context_line":"                                       self._marker_string(self.next_marker))"},{"line_number":458,"context_line":"        elif \u0027?\u0027 in self.req_url:"},{"line_number":459,"context_line":"            url \u003d f\u0027{self.req_url}\u0026{self._marker_string(self.next_marker)}\u0027"},{"line_number":460,"context_line":"        else:"},{"line_number":461,"context_line":"            url \u003d f\u0027{self.req_url}?{self._marker_string(self.next_marker)}\u0027"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        return self._link_value(url)"}],"source_content_type":"text/x-python","patch_set":3,"id":"247da8fb_c03d7794","line":461,"range":{"start_line":458,"start_character":8,"end_line":461,"end_character":75},"updated":"2022-04-12 02:59:39.000000000","message":"Nit: I think the order of \"single-query case\" -\u003e \"multi-query case\" is better as shown below.\n```\n        elif \u0027?\u0027 not in self.req_url:\n            url \u003d f\u0027{self.req_url}?{self._marker_string(self.next_marker)}\u0027\n        else:\n            url \u003d f\u0027{self.req_url}\u0026{self._marker_string(self.next_marker)}\u0027\n```","commit_id":"29ac2dd5d4a7b6bc0483cb50b03d48a157dc969b"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1224bc445772cae16ba4ace08b82b5ec55d73b24","unresolved":true,"context_lines":[{"line_number":455,"context_line":"            # req_url includes marker string"},{"line_number":456,"context_line":"            url \u003d self.req_url.replace(self._marker_string(self.marker),"},{"line_number":457,"context_line":"                                       self._marker_string(self.next_marker))"},{"line_number":458,"context_line":"        elif \u0027?\u0027 in self.req_url:"},{"line_number":459,"context_line":"            url \u003d f\u0027{self.req_url}\u0026{self._marker_string(self.next_marker)}\u0027"},{"line_number":460,"context_line":"        else:"},{"line_number":461,"context_line":"            url \u003d f\u0027{self.req_url}?{self._marker_string(self.next_marker)}\u0027"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        return self._link_value(url)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c7f3d3f1_679b4cdb","line":461,"range":{"start_line":458,"start_character":8,"end_line":461,"end_character":75},"in_reply_to":"247da8fb_c03d7794","updated":"2022-04-12 05:39:35.000000000","message":"Thank you for your comment. I will fix.","commit_id":"29ac2dd5d4a7b6bc0483cb50b03d48a157dc969b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9547540396ce612447e85188371699f333460596","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            # req_url includes marker string"},{"line_number":456,"context_line":"            url \u003d self.req_url.replace(self._marker_string(self.marker),"},{"line_number":457,"context_line":"                                       self._marker_string(self.next_marker))"},{"line_number":458,"context_line":"        elif \u0027?\u0027 in self.req_url:"},{"line_number":459,"context_line":"            url \u003d f\u0027{self.req_url}\u0026{self._marker_string(self.next_marker)}\u0027"},{"line_number":460,"context_line":"        else:"},{"line_number":461,"context_line":"            url \u003d f\u0027{self.req_url}?{self._marker_string(self.next_marker)}\u0027"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        return self._link_value(url)"}],"source_content_type":"text/x-python","patch_set":3,"id":"acabb159_f1486a35","line":461,"range":{"start_line":458,"start_character":8,"end_line":461,"end_character":75},"in_reply_to":"c7f3d3f1_679b4cdb","updated":"2022-04-13 23:14:47.000000000","message":"Done","commit_id":"29ac2dd5d4a7b6bc0483cb50b03d48a157dc969b"}],"tacker/tests/unit/sol_refactored/controller/test_vnflcm_view.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"af79ca645b37671dfcb8feb76f8b2b19e87dcc9a","unresolved":true,"context_lines":[{"line_number":213,"context_line":"@ddt.ddt"},{"line_number":214,"context_line":"class TestPager(base.BaseTestCase):"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    @ddt.data("},{"line_number":217,"context_line":"        {\u0027marker\u0027: \u00275a72eeef-d912-419a-b0e2-23dd3cbbc688\u0027,"},{"line_number":218,"context_line":"         \u0027req_url\u0027: (\u0027http://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":219,"context_line":"                     \u0027?nextpage_opaque_marker\u003d\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"c84402af_2e7e0e87","line":216,"updated":"2022-04-11 05:11:50.000000000","message":"Is it possible to test patterns where \u0027expect_link\u0027 is not set to \u0027nextpage_opaque_marker\u0027 by adding \u0027page_size\u0027 to ddt.data?","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3c9f5a972e22844bffd2aa39623188fe7cb85b12","unresolved":false,"context_lines":[{"line_number":213,"context_line":"@ddt.ddt"},{"line_number":214,"context_line":"class TestPager(base.BaseTestCase):"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    @ddt.data("},{"line_number":217,"context_line":"        {\u0027marker\u0027: \u00275a72eeef-d912-419a-b0e2-23dd3cbbc688\u0027,"},{"line_number":218,"context_line":"         \u0027req_url\u0027: (\u0027http://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":219,"context_line":"                     \u0027?nextpage_opaque_marker\u003d\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fb036c87_edbf76ca","line":216,"in_reply_to":"37e21079_62b09cbc","updated":"2022-04-12 00:52:29.000000000","message":"Thank you for the answer.\nI understood that the value of \u0027page_size\u0027 has no effect on the behavior of the Pager class, and existing tests are sufficient.\nYou don\u0027t have add \u0027page_size\u0027.","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d44b17cf197adbd405bd3b6939cb9fce079a460a","unresolved":true,"context_lines":[{"line_number":213,"context_line":"@ddt.ddt"},{"line_number":214,"context_line":"class TestPager(base.BaseTestCase):"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    @ddt.data("},{"line_number":217,"context_line":"        {\u0027marker\u0027: \u00275a72eeef-d912-419a-b0e2-23dd3cbbc688\u0027,"},{"line_number":218,"context_line":"         \u0027req_url\u0027: (\u0027http://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":219,"context_line":"                     \u0027?nextpage_opaque_marker\u003d\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"37e21079_62b09cbc","line":216,"in_reply_to":"c84402af_2e7e0e87","updated":"2022-04-11 08:42:51.000000000","message":"I add next_opaque_marker(by the definition \"next_marker\") to the @ddt.data and add the pattern where link is not create(next_opaque_marker is None), how about?","commit_id":"62eba21e8c19ca57197703adb167c39c7bba06d8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c263bb2eb3615c9db61bc522ff20eaa6e4473c9f","unresolved":true,"context_lines":[{"line_number":205,"context_line":"         \u0027expect_link\u0027: (\u0027\u003chttp://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":206,"context_line":"                         \u0027?nextpage_opaque_marker\u003d\u0027"},{"line_number":207,"context_line":"                         \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u003e;rel\u003d\"next\"\u0027)},"},{"line_number":208,"context_line":"        {\u0027marker\u0027: None,"},{"line_number":209,"context_line":"         \u0027req_url\u0027: (\u0027http://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":210,"context_line":"                     \u0027?all_fields\u003d1\u0027),"},{"line_number":211,"context_line":"         \u0027next_marker\u0027: \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u0027,"},{"line_number":212,"context_line":"         \u0027expect_link\u0027: (\u0027\u003chttp://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":213,"context_line":"                         \u0027?all_fields\u003d1\u0026nextpage_opaque_marker\u003d\u0027"},{"line_number":214,"context_line":"                         \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u003e;rel\u003d\"next\"\u0027)},"},{"line_number":215,"context_line":"        {\u0027marker\u0027: None,"},{"line_number":216,"context_line":"         \u0027req_url\u0027: \u0027http://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027,"},{"line_number":217,"context_line":"         \u0027next_marker\u0027: \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"967f4a41_093caab3","line":214,"range":{"start_line":208,"start_character":7,"end_line":214,"end_character":78},"updated":"2022-04-12 02:59:39.000000000","message":"\u0027all_fields\u0027 still remains in this test, so could delete these?","commit_id":"29ac2dd5d4a7b6bc0483cb50b03d48a157dc969b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4f82813dd18af5d0045f6268bfeb36ba2e7e9028","unresolved":false,"context_lines":[{"line_number":205,"context_line":"         \u0027expect_link\u0027: (\u0027\u003chttp://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":206,"context_line":"                         \u0027?nextpage_opaque_marker\u003d\u0027"},{"line_number":207,"context_line":"                         \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u003e;rel\u003d\"next\"\u0027)},"},{"line_number":208,"context_line":"        {\u0027marker\u0027: None,"},{"line_number":209,"context_line":"         \u0027req_url\u0027: (\u0027http://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":210,"context_line":"                     \u0027?all_fields\u003d1\u0027),"},{"line_number":211,"context_line":"         \u0027next_marker\u0027: \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u0027,"},{"line_number":212,"context_line":"         \u0027expect_link\u0027: (\u0027\u003chttp://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":213,"context_line":"                         \u0027?all_fields\u003d1\u0026nextpage_opaque_marker\u003d\u0027"},{"line_number":214,"context_line":"                         \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u003e;rel\u003d\"next\"\u0027)},"},{"line_number":215,"context_line":"        {\u0027marker\u0027: None,"},{"line_number":216,"context_line":"         \u0027req_url\u0027: \u0027http://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027,"},{"line_number":217,"context_line":"         \u0027next_marker\u0027: \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"56d9d84b_1d52bbbe","line":214,"range":{"start_line":208,"start_character":7,"end_line":214,"end_character":78},"in_reply_to":"8f2d739f_0bf874f3","updated":"2022-04-12 06:03:30.000000000","message":"Oops I\u0027m sorry, I saw wrong. I got it.","commit_id":"29ac2dd5d4a7b6bc0483cb50b03d48a157dc969b"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"1224bc445772cae16ba4ace08b82b5ec55d73b24","unresolved":true,"context_lines":[{"line_number":205,"context_line":"         \u0027expect_link\u0027: (\u0027\u003chttp://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":206,"context_line":"                         \u0027?nextpage_opaque_marker\u003d\u0027"},{"line_number":207,"context_line":"                         \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u003e;rel\u003d\"next\"\u0027)},"},{"line_number":208,"context_line":"        {\u0027marker\u0027: None,"},{"line_number":209,"context_line":"         \u0027req_url\u0027: (\u0027http://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":210,"context_line":"                     \u0027?all_fields\u003d1\u0027),"},{"line_number":211,"context_line":"         \u0027next_marker\u0027: \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u0027,"},{"line_number":212,"context_line":"         \u0027expect_link\u0027: (\u0027\u003chttp://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027"},{"line_number":213,"context_line":"                         \u0027?all_fields\u003d1\u0026nextpage_opaque_marker\u003d\u0027"},{"line_number":214,"context_line":"                         \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u003e;rel\u003d\"next\"\u0027)},"},{"line_number":215,"context_line":"        {\u0027marker\u0027: None,"},{"line_number":216,"context_line":"         \u0027req_url\u0027: \u0027http://127.0.0.1:9890/vnflcm/v2/vnf_instances\u0027,"},{"line_number":217,"context_line":"         \u0027next_marker\u0027: \u00275a72eeef-d912-419a-b0e2-23dd3cbbc700\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"8f2d739f_0bf874f3","line":214,"range":{"start_line":208,"start_character":7,"end_line":214,"end_character":78},"in_reply_to":"967f4a41_093caab3","updated":"2022-04-12 05:39:35.000000000","message":"I use a \"all_fields\" parameter which is not page query parameter.\nI think it is \"all_records\" to delete.","commit_id":"29ac2dd5d4a7b6bc0483cb50b03d48a157dc969b"}]}