)]}'
{".zuul.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"910b7640a9d96c231ea5db8e1ebb8d53dcbf47d5","unresolved":true,"context_lines":[{"line_number":439,"context_line":"          KURYR_K8S_API_URL: \"https://{{ hostvars[\u0027controller-k8s\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:${KURYR_K8S_API_PORT}\""},{"line_number":440,"context_line":"          KURYR_K8S_CONTAINERIZED_DEPLOYMENT: false"},{"line_number":441,"context_line":"          KURYR_NEUTRON_DEFAULT_SUBNETPOOL_ID: shared-default-subnetpool-v4"},{"line_number":442,"context_line":"          KURYR_KUBERNETES_VERSION: 1.23.3"},{"line_number":443,"context_line":"          MYSQL_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":444,"context_line":"          OCTAVIA_AMP_IMAGE_FILE: \"/tmp/test-only-amphora-x64-haproxy-ubuntu-bionic.qcow2\""},{"line_number":445,"context_line":"          OCTAVIA_AMP_IMAGE_NAME: \"test-only-amphora-x64-haproxy-ubuntu-bionic\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c6321a48_cd9c129d","line":442,"range":{"start_line":442,"start_character":10,"end_line":442,"end_character":42},"updated":"2022-04-14 00:54:04.000000000","message":"What is the reason for specifying this version?\nIf this is a workaround and you need to delete it later, how about adding a TODO comment?","commit_id":"0d3a9ba33f229f9ddf9557c24f79462edeb013b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bd3392acb9f71a97361a4d94bbf1cd4587fd493d","unresolved":true,"context_lines":[{"line_number":439,"context_line":"          KURYR_K8S_API_URL: \"https://{{ hostvars[\u0027controller-k8s\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:${KURYR_K8S_API_PORT}\""},{"line_number":440,"context_line":"          KURYR_K8S_CONTAINERIZED_DEPLOYMENT: false"},{"line_number":441,"context_line":"          KURYR_NEUTRON_DEFAULT_SUBNETPOOL_ID: shared-default-subnetpool-v4"},{"line_number":442,"context_line":"          KURYR_KUBERNETES_VERSION: 1.23.3"},{"line_number":443,"context_line":"          MYSQL_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":444,"context_line":"          OCTAVIA_AMP_IMAGE_FILE: \"/tmp/test-only-amphora-x64-haproxy-ubuntu-bionic.qcow2\""},{"line_number":445,"context_line":"          OCTAVIA_AMP_IMAGE_NAME: \"test-only-amphora-x64-haproxy-ubuntu-bionic\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f54c3de2_b99ac8af","line":442,"range":{"start_line":442,"start_character":10,"end_line":442,"end_character":42},"in_reply_to":"c6321a48_cd9c129d","updated":"2022-04-18 06:18:06.000000000","message":"I added todo in PS6.","commit_id":"0d3a9ba33f229f9ddf9557c24f79462edeb013b9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0644389a1a9bdd8b768af65a7c272c71fcb3944","unresolved":false,"context_lines":[{"line_number":439,"context_line":"          KURYR_K8S_API_URL: \"https://{{ hostvars[\u0027controller-k8s\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:${KURYR_K8S_API_PORT}\""},{"line_number":440,"context_line":"          KURYR_K8S_CONTAINERIZED_DEPLOYMENT: false"},{"line_number":441,"context_line":"          KURYR_NEUTRON_DEFAULT_SUBNETPOOL_ID: shared-default-subnetpool-v4"},{"line_number":442,"context_line":"          KURYR_KUBERNETES_VERSION: 1.23.3"},{"line_number":443,"context_line":"          MYSQL_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""},{"line_number":444,"context_line":"          OCTAVIA_AMP_IMAGE_FILE: \"/tmp/test-only-amphora-x64-haproxy-ubuntu-bionic.qcow2\""},{"line_number":445,"context_line":"          OCTAVIA_AMP_IMAGE_NAME: \"test-only-amphora-x64-haproxy-ubuntu-bionic\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3bb5bf0c_f91ce2bc","line":442,"range":{"start_line":442,"start_character":10,"end_line":442,"end_character":42},"in_reply_to":"f54c3de2_b99ac8af","updated":"2022-04-18 08:58:53.000000000","message":"Ack","commit_id":"0d3a9ba33f229f9ddf9557c24f79462edeb013b9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0644389a1a9bdd8b768af65a7c272c71fcb3944","unresolved":true,"context_lines":[{"line_number":439,"context_line":"          KURYR_K8S_API_URL: \"https://{{ hostvars[\u0027controller-k8s\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:${KURYR_K8S_API_PORT}\""},{"line_number":440,"context_line":"          KURYR_K8S_CONTAINERIZED_DEPLOYMENT: false"},{"line_number":441,"context_line":"          KURYR_NEUTRON_DEFAULT_SUBNETPOOL_ID: shared-default-subnetpool-v4"},{"line_number":442,"context_line":"          # TODO(YiFeng): At present, the version of kubernetes should be 1.23.3, and the returned response can"},{"line_number":443,"context_line":"          # pass the verification of kubernetes-client (1.23.3). This configuration will be removed after"},{"line_number":444,"context_line":"          # kuryr-kubernetes fixes the following bug."},{"line_number":445,"context_line":"          # https://bugs.launchpad.net/kuryr-kubernetes/+bug/1968960"},{"line_number":446,"context_line":"          KURYR_KUBERNETES_VERSION: 1.23.3"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"298e622f_209c3caf","line":443,"range":{"start_line":442,"start_character":0,"end_line":443,"end_character":105},"updated":"2022-04-18 08:58:53.000000000","message":"Could you wrap lines with 80 characters?","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a2898584ff0089cae3cf639c4d9a998c73a1869c","unresolved":true,"context_lines":[{"line_number":439,"context_line":"          KURYR_K8S_API_URL: \"https://{{ hostvars[\u0027controller-k8s\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:${KURYR_K8S_API_PORT}\""},{"line_number":440,"context_line":"          KURYR_K8S_CONTAINERIZED_DEPLOYMENT: false"},{"line_number":441,"context_line":"          KURYR_NEUTRON_DEFAULT_SUBNETPOOL_ID: shared-default-subnetpool-v4"},{"line_number":442,"context_line":"          # TODO(YiFeng): At present, the version of kubernetes should be 1.23.3, and the returned response can"},{"line_number":443,"context_line":"          # pass the verification of kubernetes-client (1.23.3). This configuration will be removed after"},{"line_number":444,"context_line":"          # kuryr-kubernetes fixes the following bug."},{"line_number":445,"context_line":"          # https://bugs.launchpad.net/kuryr-kubernetes/+bug/1968960"},{"line_number":446,"context_line":"          KURYR_KUBERNETES_VERSION: 1.23.3"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"708b3ca2_d4487b2a","line":443,"range":{"start_line":442,"start_character":0,"end_line":443,"end_character":105},"in_reply_to":"298e622f_209c3caf","updated":"2022-04-20 07:25:02.000000000","message":"I fixed it in PS7.","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"013bde38208e3551db1e1fec02419db69f868f26","unresolved":false,"context_lines":[{"line_number":439,"context_line":"          KURYR_K8S_API_URL: \"https://{{ hostvars[\u0027controller-k8s\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:${KURYR_K8S_API_PORT}\""},{"line_number":440,"context_line":"          KURYR_K8S_CONTAINERIZED_DEPLOYMENT: false"},{"line_number":441,"context_line":"          KURYR_NEUTRON_DEFAULT_SUBNETPOOL_ID: shared-default-subnetpool-v4"},{"line_number":442,"context_line":"          # TODO(YiFeng): At present, the version of kubernetes should be 1.23.3, and the returned response can"},{"line_number":443,"context_line":"          # pass the verification of kubernetes-client (1.23.3). This configuration will be removed after"},{"line_number":444,"context_line":"          # kuryr-kubernetes fixes the following bug."},{"line_number":445,"context_line":"          # https://bugs.launchpad.net/kuryr-kubernetes/+bug/1968960"},{"line_number":446,"context_line":"          KURYR_KUBERNETES_VERSION: 1.23.3"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"81c24dc4_3715edba","line":443,"range":{"start_line":442,"start_character":0,"end_line":443,"end_character":105},"in_reply_to":"708b3ca2_d4487b2a","updated":"2022-04-22 02:48:50.000000000","message":"Ack","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"}],"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"910b7640a9d96c231ea5db8e1ebb8d53dcbf47d5","unresolved":true,"context_lines":[{"line_number":27,"context_line":"and high maintenance costs, so it is no longer used."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In kubernetes v23.3.0, \u0027available_replicas\u0027 must be set into status"},{"line_number":30,"context_line":"of `StatefulSet`, so this patch added this attribute into statefulset"},{"line_number":31,"context_line":"yaml used in FT."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Closes-Bug: #1968103"},{"line_number":34,"context_line":"Change-Id: I9495ce0f0893e5f9a1d6c52b98c3db3928bd95a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9c7d16b2_1e7431a0","line":31,"range":{"start_line":30,"start_character":18,"end_line":31,"end_character":16},"updated":"2022-04-14 00:54:04.000000000","message":"this attribute is not added in the latest patch set.","commit_id":"0d3a9ba33f229f9ddf9557c24f79462edeb013b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bd3392acb9f71a97361a4d94bbf1cd4587fd493d","unresolved":true,"context_lines":[{"line_number":27,"context_line":"and high maintenance costs, so it is no longer used."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In kubernetes v23.3.0, \u0027available_replicas\u0027 must be set into status"},{"line_number":30,"context_line":"of `StatefulSet`, so this patch added this attribute into statefulset"},{"line_number":31,"context_line":"yaml used in FT."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Closes-Bug: #1968103"},{"line_number":34,"context_line":"Change-Id: I9495ce0f0893e5f9a1d6c52b98c3db3928bd95a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f80c5591_7a43df8c","line":31,"range":{"start_line":30,"start_character":18,"end_line":31,"end_character":16},"in_reply_to":"9c7d16b2_1e7431a0","updated":"2022-04-18 06:18:06.000000000","message":"I modified this expression in PS6.","commit_id":"0d3a9ba33f229f9ddf9557c24f79462edeb013b9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0644389a1a9bdd8b768af65a7c272c71fcb3944","unresolved":false,"context_lines":[{"line_number":27,"context_line":"and high maintenance costs, so it is no longer used."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In kubernetes v23.3.0, \u0027available_replicas\u0027 must be set into status"},{"line_number":30,"context_line":"of `StatefulSet`, so this patch added this attribute into statefulset"},{"line_number":31,"context_line":"yaml used in FT."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Closes-Bug: #1968103"},{"line_number":34,"context_line":"Change-Id: I9495ce0f0893e5f9a1d6c52b98c3db3928bd95a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a0a2356c_d6518442","line":31,"range":{"start_line":30,"start_character":18,"end_line":31,"end_character":16},"in_reply_to":"f80c5591_7a43df8c","updated":"2022-04-18 08:58:53.000000000","message":"Ack","commit_id":"0d3a9ba33f229f9ddf9557c24f79462edeb013b9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2d4179763509257db16cd0844d54845c9cc86f7d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix validate error when k8s resource init"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the k8s version has been upgraded from v22.6.0 to v23.3.0,"},{"line_number":10,"context_line":"the initial value of some fields must be the specified string,"},{"line_number":11,"context_line":"which causes the initialization of the current k8s resource to fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes the issue and skips the validation of k8s object"},{"line_number":14,"context_line":"initialization by setting the `client_side_validation` parameter."},{"line_number":15,"context_line":"In order to pass the validation, the must_param variable was added"},{"line_number":16,"context_line":"to set the initialized value. This modification skips the"},{"line_number":17,"context_line":"validation and no longer uses the variable, so the related processing"},{"line_number":18,"context_line":"of the variable is deleted. At the same time, even if the"},{"line_number":19,"context_line":"initialization validation is skipped, the fields in the yaml file"},{"line_number":20,"context_line":"will still be verified when the create method is called, and an"},{"line_number":21,"context_line":"exception will be thrown and output to the log if the fields are"},{"line_number":22,"context_line":"missing."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"At the same time, due to the rapid iteration of the k8s version,"},{"line_number":25,"context_line":"the must_param variable needs to be repaired in each iteration to"},{"line_number":26,"context_line":"adapt to the new validation, which requires repeated maintenance"},{"line_number":27,"context_line":"and high maintenance costs, so it is no longer used."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In kubernetes v23.3.0, \u0027available_replicas\u0027 must be set into status"},{"line_number":30,"context_line":"of `StatefulSet`, so this patch add a kuryr-kubernetes versioned"},{"line_number":31,"context_line":"parameter temporarily to .zuul.yaml to make the response returned"},{"line_number":32,"context_line":"by kubernetes correct."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Closes-Bug: #1968103"},{"line_number":35,"context_line":"Change-Id: I9495ce0f0893e5f9a1d6c52b98c3db3928bd95a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"e5a3af88_b5910774","line":32,"range":{"start_line":9,"start_character":0,"end_line":32,"end_character":22},"updated":"2022-04-18 11:06:58.000000000","message":"Thanks for explaining the issue and your solution. However, it might be a little bit long for commit message :) I believe you can make it shorter appropriately.","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a2898584ff0089cae3cf639c4d9a998c73a1869c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix validate error when k8s resource init"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the k8s version has been upgraded from v22.6.0 to v23.3.0,"},{"line_number":10,"context_line":"the initial value of some fields must be the specified string,"},{"line_number":11,"context_line":"which causes the initialization of the current k8s resource to fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes the issue and skips the validation of k8s object"},{"line_number":14,"context_line":"initialization by setting the `client_side_validation` parameter."},{"line_number":15,"context_line":"In order to pass the validation, the must_param variable was added"},{"line_number":16,"context_line":"to set the initialized value. This modification skips the"},{"line_number":17,"context_line":"validation and no longer uses the variable, so the related processing"},{"line_number":18,"context_line":"of the variable is deleted. At the same time, even if the"},{"line_number":19,"context_line":"initialization validation is skipped, the fields in the yaml file"},{"line_number":20,"context_line":"will still be verified when the create method is called, and an"},{"line_number":21,"context_line":"exception will be thrown and output to the log if the fields are"},{"line_number":22,"context_line":"missing."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"At the same time, due to the rapid iteration of the k8s version,"},{"line_number":25,"context_line":"the must_param variable needs to be repaired in each iteration to"},{"line_number":26,"context_line":"adapt to the new validation, which requires repeated maintenance"},{"line_number":27,"context_line":"and high maintenance costs, so it is no longer used."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"In kubernetes v23.3.0, \u0027available_replicas\u0027 must be set into status"},{"line_number":30,"context_line":"of `StatefulSet`, so this patch add a kuryr-kubernetes versioned"},{"line_number":31,"context_line":"parameter temporarily to .zuul.yaml to make the response returned"},{"line_number":32,"context_line":"by kubernetes correct."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Closes-Bug: #1968103"},{"line_number":35,"context_line":"Change-Id: I9495ce0f0893e5f9a1d6c52b98c3db3928bd95a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ad29a6e_73aa48a1","line":32,"range":{"start_line":9,"start_character":0,"end_line":32,"end_character":22},"in_reply_to":"e5a3af88_b5910774","updated":"2022-04-20 07:25:02.000000000","message":"I made it shorter in PS7.","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"910b7640a9d96c231ea5db8e1ebb8d53dcbf47d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6398eab7_4baa9734","updated":"2022-04-14 00:54:04.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"0d3a9ba33f229f9ddf9557c24f79462edeb013b9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0644389a1a9bdd8b768af65a7c272c71fcb3944","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e1b4b22d_f6a42b47","updated":"2022-04-18 08:58:53.000000000","message":"Thanks for your patch, please kindly confirm additional comment.","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bd3392acb9f71a97361a4d94bbf1cd4587fd493d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"82d38171_5302058d","updated":"2022-04-18 06:18:06.000000000","message":"To Ayumu Ueha:\nThank you for your comments. I fixed them in PS6.\nPlease kindly check them again.","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a2898584ff0089cae3cf639c4d9a998c73a1869c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9d4dc9a1_8f42144d","updated":"2022-04-20 07:25:02.000000000","message":"To Ayumu Ueha, Yasufumi Ogawa:\nThank you for your comments. I fixed them in PS7.\nPlease kindly check them again.","commit_id":"6a0ba25f122ad3944c4a07f28f7893b85070c6be"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"013bde38208e3551db1e1fec02419db69f868f26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"692a3247_b5040679","updated":"2022-04-22 02:48:50.000000000","message":"Thanks for your rework, LGTM.","commit_id":"ee16eca0c3c113ae49fb28e200371df20d167480"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b9dea143055eb3464067c8e270d1bc4f25a93be1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3abd3925_be1f8e75","updated":"2022-04-22 01:31:52.000000000","message":"To Yasufumi Ogawa:\nThank you for your new comments. I fixed them in PS8.\nPlease kindly check them again.","commit_id":"ee16eca0c3c113ae49fb28e200371df20d167480"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"c5bdee6685e5dfa442cd909500f49455d32e695e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"027cf1c4_c7acce2b","updated":"2022-04-25 09:13:59.000000000","message":"Thank you for the update, but still unclear a little about your docstring. Please confirm my comments. Thanks!","commit_id":"d3f9e025980fbccca8f9ff26e91aacf58b7a1c45"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"044b0485c0c978c9ffa54249e1bace368fb775b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c2853075_29a754df","updated":"2022-04-25 07:36:34.000000000","message":"To Yasufumi Ogawa:\nThank you for your new comments. I fixed some of them in PS9, and answered some of them.\nPlease kindly check them again.","commit_id":"d3f9e025980fbccca8f9ff26e91aacf58b7a1c45"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"e39fe3cfea120f03de6b35845913d83565a29f9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e613619a_561afc33","updated":"2022-04-26 05:19:11.000000000","message":"Thanks! LGTM","commit_id":"e2db1c7a4032d316e5b655b858b023ace8435cd8"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"8bf6cc3ba2356fe3af872803730bec3095b43f25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"016a92bd_48a3df59","updated":"2022-04-26 04:59:39.000000000","message":"Thanks.","commit_id":"e2db1c7a4032d316e5b655b858b023ace8435cd8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9ce027b5ef419af9bdb12391c47daf4ac3fd784c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"740a3924_9bedc72f","updated":"2022-04-26 01:39:40.000000000","message":"To Yasufumi Ogawa:\nThank you for your new comments. I fixed them in PS10.\nPlease kindly check them again.","commit_id":"e2db1c7a4032d316e5b655b858b023ace8435cd8"}],"tacker/vnfm/infra_drivers/kubernetes/k8s/translate_outputs.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2d4179763509257db16cd0844d54845c9cc86f7d","unresolved":true,"context_lines":[{"line_number":163,"context_line":"    def _create_k8s_object(self, kind, file_content_dict):"},{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        k8s_obj \u003d eval("},{"line_number":167,"context_line":"            \u0027client.V1\u0027 + kind + \u0027(local_vars_configuration\u003dclient_config)\u0027)"},{"line_number":168,"context_line":"        self._init_k8s_obj(k8s_obj, file_content_dict)"},{"line_number":169,"context_line":"        return k8s_obj"}],"source_content_type":"text/x-python","patch_set":6,"id":"a3b4a8e6_738e0242","line":166,"updated":"2022-04-18 11:06:58.000000000","message":"Hmm, we should take care while using `eval()` actually. It makes something hard to find the cause when an error happened. So, you\u0027d better to introduce a \"try ... except\" clause to help us for such a case. It\u0027s more preferable to introduce a dedicated function for the purpose. It might be helpful for us[1]. What do you think?\n\n[1] https://stackoverflow.com/questions/2140614/python-eval-error-suppression","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a2898584ff0089cae3cf639c4d9a998c73a1869c","unresolved":true,"context_lines":[{"line_number":163,"context_line":"    def _create_k8s_object(self, kind, file_content_dict):"},{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        k8s_obj \u003d eval("},{"line_number":167,"context_line":"            \u0027client.V1\u0027 + kind + \u0027(local_vars_configuration\u003dclient_config)\u0027)"},{"line_number":168,"context_line":"        self._init_k8s_obj(k8s_obj, file_content_dict)"},{"line_number":169,"context_line":"        return k8s_obj"}],"source_content_type":"text/x-python","patch_set":6,"id":"8f9ab91a_371a06e1","line":166,"in_reply_to":"a3b4a8e6_738e0242","updated":"2022-04-20 07:25:02.000000000","message":"I fixed it in PS7.","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2d4179763509257db16cd0844d54845c9cc86f7d","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        k8s_obj \u003d eval("},{"line_number":167,"context_line":"            \u0027client.V1\u0027 + kind + \u0027(local_vars_configuration\u003dclient_config)\u0027)"},{"line_number":168,"context_line":"        self._init_k8s_obj(k8s_obj, file_content_dict)"},{"line_number":169,"context_line":"        return k8s_obj"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"73964e2c_d032e426","line":167,"range":{"start_line":167,"start_character":33,"end_line":167,"end_character":75},"updated":"2022-04-18 11:06:58.000000000","message":"Why don\u0027t you make it as a variable?","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a2898584ff0089cae3cf639c4d9a998c73a1869c","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        k8s_obj \u003d eval("},{"line_number":167,"context_line":"            \u0027client.V1\u0027 + kind + \u0027(local_vars_configuration\u003dclient_config)\u0027)"},{"line_number":168,"context_line":"        self._init_k8s_obj(k8s_obj, file_content_dict)"},{"line_number":169,"context_line":"        return k8s_obj"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"559fc8ae_fa718138","line":167,"range":{"start_line":167,"start_character":33,"end_line":167,"end_character":75},"in_reply_to":"73964e2c_d032e426","updated":"2022-04-20 07:25:02.000000000","message":"I make a variable to store it.","commit_id":"c52343a974b05fe880bd01977bd82641cc0f2a8c"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"41e6638e5c8dbbeff1fc76aeddae67cc9f36048c","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return kubernetes_objects"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _trans_to_k8s_object(self, obj_name):"},{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        config \u003d \u0027(local_vars_configuration\u003dclient_config)\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"6baf8135_4b8d598c","line":163,"range":{"start_line":163,"start_character":35,"end_line":163,"end_character":43},"updated":"2022-04-22 06:23:42.000000000","message":"Is there no need to consider a case of getting `client_config` as an argument? Although I think it can be happened, what do you think?","commit_id":"6a0ba25f122ad3944c4a07f28f7893b85070c6be"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fb937b51f7d4378d64af1a8935c8d3e96699da84","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return kubernetes_objects"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _trans_to_k8s_object(self, obj_name):"},{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        config \u003d \u0027(local_vars_configuration\u003dclient_config)\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"d827b111_c1311f6e","line":163,"range":{"start_line":163,"start_character":35,"end_line":163,"end_character":43},"updated":"2022-04-21 09:06:23.000000000","message":"Just a question. What\u0027s happened if `obj_name` is empty or invalid value?","commit_id":"6a0ba25f122ad3944c4a07f28f7893b85070c6be"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"044b0485c0c978c9ffa54249e1bace368fb775b5","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return kubernetes_objects"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _trans_to_k8s_object(self, obj_name):"},{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        config \u003d \u0027(local_vars_configuration\u003dclient_config)\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"95e261cb_e2e52aaa","line":163,"range":{"start_line":163,"start_character":35,"end_line":163,"end_character":43},"in_reply_to":"6baf8135_4b8d598c","updated":"2022-04-25 07:36:34.000000000","message":"I don\u0027t think it\u0027s necessary at the moment. Since only k8S initialization needs to call this method, and we need to pass all the checks, it doesn\u0027t matter if they are all set to the same. You can modify it later if necessary. What do you think?","commit_id":"6a0ba25f122ad3944c4a07f28f7893b85070c6be"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"c5bdee6685e5dfa442cd909500f49455d32e695e","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return kubernetes_objects"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _trans_to_k8s_object(self, obj_name):"},{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        config \u003d \u0027(local_vars_configuration\u003dclient_config)\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"a4ea4c09_9ec2409b","line":163,"range":{"start_line":163,"start_character":35,"end_line":163,"end_character":43},"in_reply_to":"95e261cb_e2e52aaa","updated":"2022-04-25 09:13:59.000000000","message":"agree","commit_id":"6a0ba25f122ad3944c4a07f28f7893b85070c6be"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b9dea143055eb3464067c8e270d1bc4f25a93be1","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return kubernetes_objects"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _trans_to_k8s_object(self, obj_name):"},{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        config \u003d \u0027(local_vars_configuration\u003dclient_config)\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5c2a4161_f51a8ea3","line":163,"range":{"start_line":163,"start_character":35,"end_line":163,"end_character":43},"in_reply_to":"d827b111_c1311f6e","updated":"2022-04-22 01:31:52.000000000","message":"I made a test, if obj_name is empty, it will raise SyntaxError; if obj_name is invalid value, it will raise AttributeError.","commit_id":"6a0ba25f122ad3944c4a07f28f7893b85070c6be"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fb937b51f7d4378d64af1a8935c8d3e96699da84","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        config \u003d \u0027(local_vars_configuration\u003dclient_config)\u0027"},{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            k8s_obj \u003d eval("},{"line_number":169,"context_line":"                \u0027client.\u0027 + obj_name + config)"},{"line_number":170,"context_line":"            return k8s_obj"},{"line_number":171,"context_line":"        except ValueError as e:"},{"line_number":172,"context_line":"            msg \u003d \u0027{kind} create failure. Reason\u003d{reason}\u0027.format("},{"line_number":173,"context_line":"                kind\u003dobj_name, reason\u003de)"}],"source_content_type":"text/x-python","patch_set":7,"id":"4af4fe88_25bd30ff","line":170,"range":{"start_line":168,"start_character":0,"end_line":170,"end_character":0},"updated":"2022-04-21 09:06:23.000000000","message":"nit:\n* why don\u0027t you use `format()` instead of `+`?\n* no need to separate into two lines.","commit_id":"6a0ba25f122ad3944c4a07f28f7893b85070c6be"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b9dea143055eb3464067c8e270d1bc4f25a93be1","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        config \u003d \u0027(local_vars_configuration\u003dclient_config)\u0027"},{"line_number":167,"context_line":"        try:"},{"line_number":168,"context_line":"            k8s_obj \u003d eval("},{"line_number":169,"context_line":"                \u0027client.\u0027 + obj_name + config)"},{"line_number":170,"context_line":"            return k8s_obj"},{"line_number":171,"context_line":"        except ValueError as e:"},{"line_number":172,"context_line":"            msg \u003d \u0027{kind} create failure. Reason\u003d{reason}\u0027.format("},{"line_number":173,"context_line":"                kind\u003dobj_name, reason\u003de)"}],"source_content_type":"text/x-python","patch_set":7,"id":"a3f1c772_f01af622","line":170,"range":{"start_line":168,"start_character":0,"end_line":170,"end_character":0},"in_reply_to":"4af4fe88_25bd30ff","updated":"2022-04-22 01:31:52.000000000","message":"I fixed it in PS8","commit_id":"6a0ba25f122ad3944c4a07f28f7893b85070c6be"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"fb937b51f7d4378d64af1a8935c8d3e96699da84","unresolved":true,"context_lines":[{"line_number":168,"context_line":"            k8s_obj \u003d eval("},{"line_number":169,"context_line":"                \u0027client.\u0027 + obj_name + config)"},{"line_number":170,"context_line":"            return k8s_obj"},{"line_number":171,"context_line":"        except ValueError as e:"},{"line_number":172,"context_line":"            msg \u003d \u0027{kind} create failure. Reason\u003d{reason}\u0027.format("},{"line_number":173,"context_line":"                kind\u003dobj_name, reason\u003de)"},{"line_number":174,"context_line":"            raise exceptions.InitApiFalse(error\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"54014500_a8713818","line":171,"range":{"start_line":171,"start_character":15,"end_line":171,"end_character":25},"updated":"2022-04-21 09:06:23.000000000","message":"This except clause　isn\u0027t enough for the purpose because it cannot catch other exceptions which usually happened in `eval()` unexpectedly, such as SyntaxError or AttributeError. No message doesn\u0027t appear in such a case.","commit_id":"6a0ba25f122ad3944c4a07f28f7893b85070c6be"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b9dea143055eb3464067c8e270d1bc4f25a93be1","unresolved":true,"context_lines":[{"line_number":168,"context_line":"            k8s_obj \u003d eval("},{"line_number":169,"context_line":"                \u0027client.\u0027 + obj_name + config)"},{"line_number":170,"context_line":"            return k8s_obj"},{"line_number":171,"context_line":"        except ValueError as e:"},{"line_number":172,"context_line":"            msg \u003d \u0027{kind} create failure. Reason\u003d{reason}\u0027.format("},{"line_number":173,"context_line":"                kind\u003dobj_name, reason\u003de)"},{"line_number":174,"context_line":"            raise exceptions.InitApiFalse(error\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ec0e9f2f_4c560cf0","line":171,"range":{"start_line":171,"start_character":15,"end_line":171,"end_character":25},"in_reply_to":"54014500_a8713818","updated":"2022-04-22 01:31:52.000000000","message":"yes, you\u0027re right. I only checked the error information of k8s, and the valueError was thrown, without considering other situations. Thank you for your remind.","commit_id":"6a0ba25f122ad3944c4a07f28f7893b85070c6be"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"41e6638e5c8dbbeff1fc76aeddae67cc9f36048c","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return kubernetes_objects"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _trans_to_k8s_object(self, obj_name):"},{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        config \u003d \u0027(local_vars_configuration\u003dclient_config)\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"cfc8f0b2_9dbee0b3","line":163,"range":{"start_line":163,"start_character":8,"end_line":163,"end_character":28},"updated":"2022-04-22 06:23:42.000000000","message":"You\u0027d better to add a description for the purpose of the function and the behavior calling `client.*` of k8s client because the name of function is confusing with others, `_create_k8s_obj` and `_init_k8s_obj`. Or, it\u0027s OK to change the name to more appropriate one.","commit_id":"ee16eca0c3c113ae49fb28e200371df20d167480"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"044b0485c0c978c9ffa54249e1bace368fb775b5","unresolved":true,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        return kubernetes_objects"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _trans_to_k8s_object(self, obj_name):"},{"line_number":164,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":165,"context_line":"        client_config.client_side_validation \u003d False"},{"line_number":166,"context_line":"        config \u003d \u0027(local_vars_configuration\u003dclient_config)\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"24026f94_61e221c5","line":163,"range":{"start_line":163,"start_character":8,"end_line":163,"end_character":28},"in_reply_to":"cfc8f0b2_9dbee0b3","updated":"2022-04-25 07:36:34.000000000","message":"I added a description in PS9.","commit_id":"ee16eca0c3c113ae49fb28e200371df20d167480"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"c5bdee6685e5dfa442cd909500f49455d32e695e","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        return kubernetes_objects"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _trans_to_k8s_object(self, obj_name):"},{"line_number":164,"context_line":"        \"\"\"Generate k8S object"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        The function converts the name passed in to the corresponding"},{"line_number":167,"context_line":"        kubernetes object and returns it. To skip the validation of kubernetes"}],"source_content_type":"text/x-python","patch_set":9,"id":"3b39192b_d0c48e56","line":164,"range":{"start_line":164,"start_character":11,"end_line":164,"end_character":30},"updated":"2022-04-25 09:13:59.000000000","message":"* It looks different from the name of function and ambiguous. Why don\u0027t you change the name to `gen_k8s_obj_from_name()` or so instead for easy-to-understand? \n* Why it\u0027s capitalized \u0027S\u0027 in \u0027k8S\u0027?","commit_id":"d3f9e025980fbccca8f9ff26e91aacf58b7a1c45"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9ce027b5ef419af9bdb12391c47daf4ac3fd784c","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        return kubernetes_objects"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _trans_to_k8s_object(self, obj_name):"},{"line_number":164,"context_line":"        \"\"\"Generate k8S object"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        The function converts the name passed in to the corresponding"},{"line_number":167,"context_line":"        kubernetes object and returns it. To skip the validation of kubernetes"}],"source_content_type":"text/x-python","patch_set":9,"id":"61276980_dce366e2","line":164,"range":{"start_line":164,"start_character":11,"end_line":164,"end_character":30},"in_reply_to":"3b39192b_d0c48e56","updated":"2022-04-26 01:39:40.000000000","message":"* I changed the function name in PS10.\n* I fixed it.","commit_id":"d3f9e025980fbccca8f9ff26e91aacf58b7a1c45"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"c5bdee6685e5dfa442cd909500f49455d32e695e","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        \"\"\"Generate k8S object"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        The function converts the name passed in to the corresponding"},{"line_number":167,"context_line":"        kubernetes object and returns it. To skip the validation of kubernetes"},{"line_number":168,"context_line":"        object initialization parameters, set the local_vars_configuration"},{"line_number":169,"context_line":"        parameter to skip the validation of the client."},{"line_number":170,"context_line":"        \"\"\""},{"line_number":171,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":172,"context_line":"        client_config.client_side_validation \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"da387848_a146b982","line":169,"range":{"start_line":167,"start_character":41,"end_line":169,"end_character":55},"updated":"2022-04-25 09:13:59.000000000","message":"Could I confirm the purpose of `local_vars_configuration` is skip such a validation? I understand the reason why `local_vars_configuration` is introduced is just to use default config instance of Configuration and it\u0027s not related to skip a validation. If so, this docstring is incorrect.","commit_id":"d3f9e025980fbccca8f9ff26e91aacf58b7a1c45"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"9ce027b5ef419af9bdb12391c47daf4ac3fd784c","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        \"\"\"Generate k8S object"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        The function converts the name passed in to the corresponding"},{"line_number":167,"context_line":"        kubernetes object and returns it. To skip the validation of kubernetes"},{"line_number":168,"context_line":"        object initialization parameters, set the local_vars_configuration"},{"line_number":169,"context_line":"        parameter to skip the validation of the client."},{"line_number":170,"context_line":"        \"\"\""},{"line_number":171,"context_line":"        client_config \u003d client.Configuration.get_default_copy()"},{"line_number":172,"context_line":"        client_config.client_side_validation \u003d False"}],"source_content_type":"text/x-python","patch_set":9,"id":"7e14e5aa_7eced8b2","line":169,"range":{"start_line":167,"start_character":41,"end_line":169,"end_character":55},"in_reply_to":"da387848_a146b982","updated":"2022-04-26 01:39:40.000000000","message":"By default, client_side_validation in the client\u0027s configuration file is True. The purpose of setting this parameter is to pass the configuration of client_side_validation\u003dFalse to the generated object through the `local_vars_configuration` parameter, so that the client-side validation can be skipped when the object is generated.\nRefer to https://github.com/kubernetes-client/python/issues/1662\nSorry, maybe my previous statement wasn\u0027t clear enough.\nI modified my description in PS10.","commit_id":"d3f9e025980fbccca8f9ff26e91aacf58b7a1c45"}]}