)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a08b23637987c6e4d6039a5268f1a1063b8684f7","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-05-27 07:00:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Additional support of handling large query results"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch provides additional support of handling large query"},{"line_number":10,"context_line":"results to a GET request of the following API."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"317c5e38_a3351570","line":8,"updated":"2022-06-27 17:20:44.000000000","message":"Why don\u0027t you add a description about deleting with `_delete_expired_nextpages()` in the commit message?","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"c854afedc0f145834a3bcbcc36edf4276b624322","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-05-27 07:00:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Additional support of handling large query results"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch provides additional support of handling large query"},{"line_number":10,"context_line":"results to a GET request of the following API."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dfbf0c60_bad7199d","line":8,"in_reply_to":"317c5e38_a3351570","updated":"2022-08-04 06:48:05.000000000","message":"The description is added into the feature list in the commit message.","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"f0cf3e9e6c99dfcaefdeb6a10d1c22712ed856a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"88bd4f03_6ae74f63","updated":"2022-04-28 09:02:55.000000000","message":"recheck","commit_id":"b599121e16b22239e23e846554ce2c50d6b1a7b2"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"0e32bc4573807db0738a189459dd0ef38db45bd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b544f31d_36ed7b7c","updated":"2022-05-25 16:58:24.000000000","message":"recheck","commit_id":"b599121e16b22239e23e846554ce2c50d6b1a7b2"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"e6f3738f85c84b8fbae01397823d57b0d1167f0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c738e81a_97f516b7","updated":"2022-05-13 01:07:51.000000000","message":"recheck","commit_id":"b599121e16b22239e23e846554ce2c50d6b1a7b2"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"5ee0e6d021cb2dc5451cee814f546e2dfa8b20c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f371043c_f0844de3","updated":"2022-05-23 08:59:52.000000000","message":"recheck","commit_id":"b599121e16b22239e23e846554ce2c50d6b1a7b2"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"48ff9dd0d1e1a460323b983833d0b29e2c824ab6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9586a53e_20cad131","updated":"2022-05-29 18:00:42.000000000","message":"recheck","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"c25f5ef4e8cdf2acd694cda48d46c04d52b26cd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"40bc1966_86d4529f","updated":"2022-08-15 02:39:10.000000000","message":"recheck","commit_id":"b1c1fd2e797bd75d715cd865aecbdb2f262d0a3f"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"8a6f6c398e7ce75cf83f953ee3a2c3fdef1dcf43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c9e3eb45_70b90d03","updated":"2022-08-19 07:45:20.000000000","message":"recheck","commit_id":"b1c1fd2e797bd75d715cd865aecbdb2f262d0a3f"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"0f322956b01cd289bf0fe7cd72a160b3adfa9457","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"27a00a89_ff430a11","updated":"2022-08-31 09:22:49.000000000","message":"In patch set 6, the subject of the patch is changed so that we can easily understand that this change is for vnf packages API.","commit_id":"48724b09bc84b536d4df572621e081f06fde9d1c"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"e3f8bd48bc50a2dd1a7aaa9d07292998a968bd01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1d568cb8_ca79a844","updated":"2022-09-01 02:25:04.000000000","message":"Existing failure in unit test is solved by patch set 7.","commit_id":"c5d4b335f3173b34339fb7c6b1b9a7771cfb59ca"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"9720b3949ef8abe61a78c0bb40f5d8f897e855ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"facb3f9c_0b471229","updated":"2022-09-06 05:06:20.000000000","message":"LGTM","commit_id":"c5d4b335f3173b34339fb7c6b1b9a7771cfb59ca"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"bd7421c368ca03588d1b656fea3e921e86a3b472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d25bb335_7767f835","updated":"2022-09-06 13:32:14.000000000","message":"LGTM.","commit_id":"c5d4b335f3173b34339fb7c6b1b9a7771cfb59ca"}],"tacker/api/vnfpkgm/v1/controller.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a08b23637987c6e4d6039a5268f1a1063b8684f7","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        super(VnfPkgmController, self).__init__()"},{"line_number":60,"context_line":"        self.rpc_api \u003d vnf_pkgm_rpc.VNFPackageRPCAPI()"},{"line_number":61,"context_line":"        glance_store.initialize_glance_store()"},{"line_number":62,"context_line":"        self._nextpages_vnf_packages \u003d {}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _get_vnf_package(self, id, request):"},{"line_number":65,"context_line":"        # check if id is of type uuid format"}],"source_content_type":"text/x-python","patch_set":4,"id":"05903365_3e304f1c","line":62,"range":{"start_line":62,"start_character":13,"end_line":62,"end_character":36},"updated":"2022-06-27 17:20:44.000000000","message":"This name is a little bit confusing for me. Is it not enough `self_nextpages`?","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"c854afedc0f145834a3bcbcc36edf4276b624322","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        super(VnfPkgmController, self).__init__()"},{"line_number":60,"context_line":"        self.rpc_api \u003d vnf_pkgm_rpc.VNFPackageRPCAPI()"},{"line_number":61,"context_line":"        glance_store.initialize_glance_store()"},{"line_number":62,"context_line":"        self._nextpages_vnf_packages \u003d {}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _get_vnf_package(self, id, request):"},{"line_number":65,"context_line":"        # check if id is of type uuid format"}],"source_content_type":"text/x-python","patch_set":4,"id":"66d6fbda_99aad441","line":62,"range":{"start_line":62,"start_character":13,"end_line":62,"end_character":36},"in_reply_to":"05903365_3e304f1c","updated":"2022-08-04 06:48:05.000000000","message":"Exactly, \"_vnf_packages\" is no need. Changed the name as you suggested.","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"710b1987ab2a51a9062394917050c9b555265612","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        return vnf_package"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _delete_expired_nextpages(self, nextpages):"},{"line_number":79,"context_line":"        for k, v in list(nextpages.items()):"},{"line_number":80,"context_line":"            if timeutils.is_older_than(v[\u0027created_time\u0027],"},{"line_number":81,"context_line":"                    CONF.vnf_package.nextpage_expiration_time):"},{"line_number":82,"context_line":"                LOG.debug(\u0027Old nextpages are deleted. id: %s\u0027 % k)"}],"source_content_type":"text/x-python","patch_set":4,"id":"79a901f2_d90dfdc8","line":79,"updated":"2022-08-24 04:18:40.000000000","message":"This can be \n```\nfor k, v in nextpages.items():\n```\n\nisn\u0027t it?","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"0f322956b01cd289bf0fe7cd72a160b3adfa9457","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        return vnf_package"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _delete_expired_nextpages(self, nextpages):"},{"line_number":79,"context_line":"        for k, v in list(nextpages.items()):"},{"line_number":80,"context_line":"            if timeutils.is_older_than(v[\u0027created_time\u0027],"},{"line_number":81,"context_line":"                    CONF.vnf_package.nextpage_expiration_time):"},{"line_number":82,"context_line":"                LOG.debug(\u0027Old nextpages are deleted. id: %s\u0027 % k)"}],"source_content_type":"text/x-python","patch_set":4,"id":"99d025e6_d30c5070","line":79,"in_reply_to":"79a901f2_d90dfdc8","updated":"2022-08-31 09:22:49.000000000","message":"Fixed as you pointed out.","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"9720b3949ef8abe61a78c0bb40f5d8f897e855ea","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return vnf_package"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _delete_expired_nextpages(self, nextpages):"},{"line_number":79,"context_line":"        for k, v in list(nextpages.items()):"},{"line_number":80,"context_line":"            if timeutils.is_older_than(v[\u0027created_time\u0027],"},{"line_number":81,"context_line":"                    CONF.vnf_package.nextpage_expiration_time):"},{"line_number":82,"context_line":"                LOG.debug(\u0027Old nextpages are deleted. id: %s\u0027 % k)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ee20d410_a971d85b","line":79,"in_reply_to":"99d025e6_d30c5070","updated":"2022-09-06 05:06:20.000000000","message":"Done","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"710b1987ab2a51a9062394917050c9b555265612","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        filters \u003d self._view_builder.validate_filter(filters)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        result \u003d []"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if allrecords !\u003d \u0027yes\u0027 and nextpage:"},{"line_number":167,"context_line":"            self._delete_expired_nextpages(self._nextpages_vnf_packages)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2efbadc7_fec6f140","line":164,"updated":"2022-08-24 04:18:40.000000000","message":"nits.\nPlease use plural for the collection, i.e., results, so that other developers can understand it\u0027s iterable intuitively.","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"0f322956b01cd289bf0fe7cd72a160b3adfa9457","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        filters \u003d self._view_builder.validate_filter(filters)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        result \u003d []"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if allrecords !\u003d \u0027yes\u0027 and nextpage:"},{"line_number":167,"context_line":"            self._delete_expired_nextpages(self._nextpages_vnf_packages)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4f8bb3c8_3775f05c","line":164,"in_reply_to":"2efbadc7_fec6f140","updated":"2022-08-31 09:22:49.000000000","message":"Done","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"9720b3949ef8abe61a78c0bb40f5d8f897e855ea","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        filters \u003d self._view_builder.validate_filter(filters)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        result \u003d []"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if allrecords !\u003d \u0027yes\u0027 and nextpage:"},{"line_number":167,"context_line":"            self._delete_expired_nextpages(self._nextpages_vnf_packages)"}],"source_content_type":"text/x-python","patch_set":4,"id":"cd6c9b61_37ba5581","line":164,"in_reply_to":"4f8bb3c8_3775f05c","updated":"2022-09-06 05:06:20.000000000","message":"Done","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"}],"tacker/tests/unit/vnfpkgm/fakes.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a08b23637987c6e4d6039a5268f1a1063b8684f7","unresolved":true,"context_lines":[{"line_number":247,"context_line":"    return [vnf_package]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def return_vnf_package(vnfd_updates\u003dNone):"},{"line_number":251,"context_line":"    vnf_package \u003d return_vnfpkg_obj(vnfd_updates\u003dvnfd_updates)"},{"line_number":252,"context_line":"    return vnf_package"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"class InjectContext(wsgi.Middleware):"}],"source_content_type":"text/x-python","patch_set":4,"id":"93d6fcd7_f910f1ff","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":22},"updated":"2022-06-27 17:20:44.000000000","message":"Is this function really required here just calling `return_vnfpkg_obj()`? It\u0027s used only in a test function.","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"c854afedc0f145834a3bcbcc36edf4276b624322","unresolved":true,"context_lines":[{"line_number":247,"context_line":"    return [vnf_package]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def return_vnf_package(vnfd_updates\u003dNone):"},{"line_number":251,"context_line":"    vnf_package \u003d return_vnfpkg_obj(vnfd_updates\u003dvnfd_updates)"},{"line_number":252,"context_line":"    return vnf_package"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"class InjectContext(wsgi.Middleware):"}],"source_content_type":"text/x-python","patch_set":4,"id":"10e7b81f_4c69b365","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":22},"in_reply_to":"93d6fcd7_f910f1ff","updated":"2022-08-04 06:48:05.000000000","message":"Your understanding is correct. \"return_vnfpkg_obj()\" can be used instead of new function. Modified as it is.","commit_id":"eeda89657fa1e5370767ce3d384c58c572944d0d"}]}