)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"99c38fd0bd104c4f287a71ac430ed5866b00f514","unresolved":true,"context_lines":[{"line_number":7,"context_line":"affectedVirtualStorages should not be set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"affectedVirtualStorages should be absent in"},{"line_number":10,"context_line":"notification when vnfd does not contain virtual"},{"line_number":11,"context_line":"storage"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implemented a check during populating"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b4fe86f8_990a15ae","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":22},"updated":"2022-06-08 07:09:41.000000000","message":"Please convert case as per convention \"VNFD\".","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"10e83bcc929b99d9e95d8077e7d9dea68849a5e6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"affectedVirtualStorages should not be set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"affectedVirtualStorages should be absent in"},{"line_number":10,"context_line":"notification when vnfd does not contain virtual"},{"line_number":11,"context_line":"storage"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implemented a check during populating"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"88538531_ce16197d","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":22},"in_reply_to":"b4fe86f8_990a15ae","updated":"2022-06-08 17:36:24.000000000","message":"Done","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"5468759aded42c14e55effa2d91ef3a09e7f4a88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b7c70169_3647d8af","updated":"2022-05-17 11:08:10.000000000","message":"recheck","commit_id":"1e0c430ca430621c56e9b72d23c3bafb50ffd36c"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"99c38fd0bd104c4f287a71ac430ed5866b00f514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dd978415_edde6ade","updated":"2022-06-08 07:09:41.000000000","message":"Thank you for your patch. Please find few comments.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"8d71e1080e4db1875e2e410d569391e093c05885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"642228cf_d16e9182","updated":"2022-06-13 02:47:20.000000000","message":"Thanks for rework. LGTM!! I have verified the changes.","commit_id":"e3d648e8d4428b95ad05d7d99f0341ddf2769d46"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"009e9a01ceb81c5ae9396fdc9c3877af131dc9c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8e87c4e0_e17dc741","updated":"2022-06-15 07:39:43.000000000","message":"Thanks for your patch, please kindly check my comments.","commit_id":"8db976f2efd9a0f0037356a6398cf6f67753d445"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"49481bfddc03951e2d10ff787e6862c179c2e1b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"41f6a97c_4dfb31b3","updated":"2022-06-14 10:29:25.000000000","message":"recheck","commit_id":"8db976f2efd9a0f0037356a6398cf6f67753d445"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"40f7788fd27f8a9887cb13257d10691c19d59086","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f3da3250_f92c09ce","updated":"2022-06-21 00:43:03.000000000","message":"Thanks for your rework, LGTM.","commit_id":"0984f29fb139f52d7ffa8f41e3c03f1d5c72b110"}],"tacker/tests/etc/samples/etsi/nfv/user_data_sample_virtual_storage_missing/Definitions/etsi_nfv_sol001_common_types.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"009e9a01ceb81c5ae9396fdc9c3877af131dc9c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8e0064aa_95c38322","updated":"2022-06-15 07:39:43.000000000","message":"I don\u0027t think you need to put this file in.\nIt is copied from the file under \"../common\" during the \"vnflcm_base._create_csar_with_unique_vnfd_id\" method.","commit_id":"8db976f2efd9a0f0037356a6398cf6f67753d445"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"40f7788fd27f8a9887cb13257d10691c19d59086","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8d2b2c22_28c3414c","in_reply_to":"06d88e17_d22908f1","updated":"2022-06-21 00:43:03.000000000","message":"ACK","commit_id":"8db976f2efd9a0f0037356a6398cf6f67753d445"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"2e750fc5be20142f09bb7887a33ee70d1a87c318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"06d88e17_d22908f1","in_reply_to":"8e0064aa_95c38322","updated":"2022-06-15 12:21:45.000000000","message":"Deleted file.","commit_id":"8db976f2efd9a0f0037356a6398cf6f67753d445"}],"tacker/tests/etc/samples/etsi/nfv/user_data_sample_virtual_storage_missing/Definitions/etsi_nfv_sol001_vnfd_types.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"009e9a01ceb81c5ae9396fdc9c3877af131dc9c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0209fa8f_fad0570a","updated":"2022-06-15 07:39:43.000000000","message":"same comment as etsi_nfv_sol001_common_types.yaml","commit_id":"8db976f2efd9a0f0037356a6398cf6f67753d445"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"2e750fc5be20142f09bb7887a33ee70d1a87c318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"656cc8c6_9b8c713f","in_reply_to":"0209fa8f_fad0570a","updated":"2022-06-15 12:21:45.000000000","message":"Deleted file.","commit_id":"8db976f2efd9a0f0037356a6398cf6f67753d445"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"40f7788fd27f8a9887cb13257d10691c19d59086","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"44e9449b_792d10f1","in_reply_to":"656cc8c6_9b8c713f","updated":"2022-06-21 00:43:03.000000000","message":"ACK","commit_id":"8db976f2efd9a0f0037356a6398cf6f67753d445"}],"tacker/tests/etc/samples/etsi/nfv/user_data_sample_virtual_storage_missing/Definitions/helloworld3_types.yaml":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"99c38fd0bd104c4f287a71ac430ed5866b00f514","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        default: simple"},{"line_number":43,"context_line":"      flavour_description:"},{"line_number":44,"context_line":"        type: string"},{"line_number":45,"context_line":"        default: \"falvour\""},{"line_number":46,"context_line":"    requirements:"},{"line_number":47,"context_line":"      - virtual_link_external1:"},{"line_number":48,"context_line":"          capability: tosca.capabilities.nfv.VirtualLinkable"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c0cdfcdc_7ba63979","line":45,"range":{"start_line":45,"start_character":18,"end_line":45,"end_character":25},"updated":"2022-06-08 07:09:41.000000000","message":"Misspell, \u0027flavour\u0027.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"10e83bcc929b99d9e95d8077e7d9dea68849a5e6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        default: simple"},{"line_number":43,"context_line":"      flavour_description:"},{"line_number":44,"context_line":"        type: string"},{"line_number":45,"context_line":"        default: \"falvour\""},{"line_number":46,"context_line":"    requirements:"},{"line_number":47,"context_line":"      - virtual_link_external1:"},{"line_number":48,"context_line":"          capability: tosca.capabilities.nfv.VirtualLinkable"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3b0678ea_759ebbf7","line":45,"range":{"start_line":45,"start_character":18,"end_line":45,"end_character":25},"in_reply_to":"c0cdfcdc_7ba63979","updated":"2022-06-08 17:36:24.000000000","message":"changed.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"}],"tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"948cf1327595835aea1deb1f6638db0c956165a9","unresolved":true,"context_lines":[{"line_number":220,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def test_notification_no_virtual_storage(self):"},{"line_number":223,"context_line":"        \"\"\"Test affectedVirtualStorages is absent from"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"           notification data when Virtual Storage does"},{"line_number":226,"context_line":"           not exist in VNFD."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        In this test case, we do following steps."},{"line_number":229,"context_line":"            - Create subscription."},{"line_number":230,"context_line":"            - Create VNF package."}],"source_content_type":"text/x-python","patch_set":4,"id":"8522d0f8_c1e28133","line":227,"range":{"start_line":223,"start_character":0,"end_line":227,"end_character":0},"updated":"2022-06-14 02:06:04.000000000","message":"nit: Pls revise this docstring. Title should be one line and shouldn\u0027t be separated with useless blank line.","commit_id":"e3d648e8d4428b95ad05d7d99f0341ddf2769d46"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"99099a588f29431165512b7cfba914be351b1117","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def test_notification_no_virtual_storage(self):"},{"line_number":223,"context_line":"        \"\"\"Test affectedVirtualStorages is absent from"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"           notification data when Virtual Storage does"},{"line_number":226,"context_line":"           not exist in VNFD."},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        In this test case, we do following steps."},{"line_number":229,"context_line":"            - Create subscription."},{"line_number":230,"context_line":"            - Create VNF package."}],"source_content_type":"text/x-python","patch_set":4,"id":"c636efc8_3ff4eb60","line":227,"range":{"start_line":223,"start_character":0,"end_line":227,"end_character":0},"in_reply_to":"8522d0f8_c1e28133","updated":"2022-06-15 03:54:01.000000000","message":"Revised the docstring as suggested.","commit_id":"e3d648e8d4428b95ad05d7d99f0341ddf2769d46"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"9bccb820b2b8bd9b4043bbc8e615d51c051a2473","unresolved":true,"context_lines":[{"line_number":841,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.LOG\u0027)"},{"line_number":842,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":843,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._get_affected_resources\u0027)"},{"line_number":844,"context_line":"    def test_instantiate_vnf_instance_failed_with_exception("},{"line_number":845,"context_line":"            self, mock_res, mock_vnf_by_id, mock_log,"},{"line_number":846,"context_line":"            mock_des, mock_vnfd_dict,"},{"line_number":847,"context_line":"            mock_vnf_lcm_subscriptions_get,"}],"source_content_type":"text/x-python","patch_set":2,"id":"085af08c_175c5ecf","line":844,"updated":"2022-05-19 10:13:26.000000000","message":"The test is only for the Fail case in this patch.\nIs it necessary to check with the normal case that one of the affectedResources hasn\u0027t data?","commit_id":"1e0c430ca430621c56e9b72d23c3bafb50ffd36c"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"37fe8dea6f9302cea1c872aae14a42e0476a2839","unresolved":false,"context_lines":[{"line_number":841,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.LOG\u0027)"},{"line_number":842,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":843,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._get_affected_resources\u0027)"},{"line_number":844,"context_line":"    def test_instantiate_vnf_instance_failed_with_exception("},{"line_number":845,"context_line":"            self, mock_res, mock_vnf_by_id, mock_log,"},{"line_number":846,"context_line":"            mock_des, mock_vnfd_dict,"},{"line_number":847,"context_line":"            mock_vnf_lcm_subscriptions_get,"}],"source_content_type":"text/x-python","patch_set":2,"id":"06e0ee4e_20b27cdb","line":844,"in_reply_to":"085af08c_175c5ecf","updated":"2022-06-03 18:56:27.000000000","message":"Added test for normal case.","commit_id":"1e0c430ca430621c56e9b72d23c3bafb50ffd36c"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"99c38fd0bd104c4f287a71ac430ed5866b00f514","unresolved":true,"context_lines":[{"line_number":419,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._get_vnfd_dict\u0027)"},{"line_number":420,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._convert_desired_capacity\u0027)"},{"line_number":421,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":422,"context_line":"    def test_instantiate_vnf_instance_no_virtual_storage(self, mock_vnf_by_id,"},{"line_number":423,"context_line":"            mock_des, mock_vnfd_dict,"},{"line_number":424,"context_line":"            mock_get_lock, mock_save,"},{"line_number":425,"context_line":"            mock_build_info, mock_change_vnf_status,"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d9368ae_b757517d","line":422,"range":{"start_line":422,"start_character":8,"end_line":422,"end_character":56},"updated":"2022-06-08 07:09:41.000000000","message":"Please rename as \"test_instantiate_vnf_instance_with_no_virtual_storage\" or \"test_instantiate_vnf_instance_without_virtual_storage\" , proposed looks ambiguous.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"10e83bcc929b99d9e95d8077e7d9dea68849a5e6","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._get_vnfd_dict\u0027)"},{"line_number":420,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._convert_desired_capacity\u0027)"},{"line_number":421,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":422,"context_line":"    def test_instantiate_vnf_instance_no_virtual_storage(self, mock_vnf_by_id,"},{"line_number":423,"context_line":"            mock_des, mock_vnfd_dict,"},{"line_number":424,"context_line":"            mock_get_lock, mock_save,"},{"line_number":425,"context_line":"            mock_build_info, mock_change_vnf_status,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ea0d725b_06fab2f7","line":422,"range":{"start_line":422,"start_character":8,"end_line":422,"end_character":56},"in_reply_to":"6d9368ae_b757517d","updated":"2022-06-08 17:36:24.000000000","message":"changed the function name as suggested.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"99c38fd0bd104c4f287a71ac430ed5866b00f514","unresolved":true,"context_lines":[{"line_number":456,"context_line":"                                    mock.ANY, \u0027PENDING_CREATE\u0027)"},{"line_number":457,"context_line":"        mock_update_vnf_attributes.assert_called_once()"},{"line_number":458,"context_line":"        self.assertNotIn(\"affectedVnfcs\","},{"line_number":459,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":460,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":461,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":462,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","}],"source_content_type":"text/x-python","patch_set":3,"id":"621681c0_f6f6b2c2","line":459,"range":{"start_line":459,"start_character":16,"end_line":459,"end_character":58},"updated":"2022-06-08 07:09:41.000000000","message":"Rather using str method if possible could we use \"get\" method to find and validate whether mock_send_notification contains \"affectedVnfcs\". Please share your thoughts.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"10e83bcc929b99d9e95d8077e7d9dea68849a5e6","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                                    mock.ANY, \u0027PENDING_CREATE\u0027)"},{"line_number":457,"context_line":"        mock_update_vnf_attributes.assert_called_once()"},{"line_number":458,"context_line":"        self.assertNotIn(\"affectedVnfcs\","},{"line_number":459,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":460,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":461,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":462,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","}],"source_content_type":"text/x-python","patch_set":3,"id":"450b19cb_e5ac3af1","line":459,"range":{"start_line":459,"start_character":16,"end_line":459,"end_character":58},"in_reply_to":"621681c0_f6f6b2c2","updated":"2022-06-08 17:36:24.000000000","message":"used get method as suggested.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"99c38fd0bd104c4f287a71ac430ed5866b00f514","unresolved":true,"context_lines":[{"line_number":458,"context_line":"        self.assertNotIn(\"affectedVnfcs\","},{"line_number":459,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":460,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":461,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":462,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","},{"line_number":463,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"6a100c3d_42a10119","line":461,"range":{"start_line":461,"start_character":15,"end_line":461,"end_character":60},"updated":"2022-06-08 07:09:41.000000000","message":"ditto","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"10e83bcc929b99d9e95d8077e7d9dea68849a5e6","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        self.assertNotIn(\"affectedVnfcs\","},{"line_number":459,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":460,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":461,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":462,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","},{"line_number":463,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1de16da6_0f9542d3","line":461,"range":{"start_line":461,"start_character":15,"end_line":461,"end_character":60},"in_reply_to":"6a100c3d_42a10119","updated":"2022-06-08 17:36:24.000000000","message":"used get method as suggested.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"99c38fd0bd104c4f287a71ac430ed5866b00f514","unresolved":true,"context_lines":[{"line_number":460,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":461,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":462,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","},{"line_number":463,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":466,"context_line":"                \u0027.send_notification\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"47cf6377_9505da50","line":463,"range":{"start_line":463,"start_character":16,"end_line":463,"end_character":59},"updated":"2022-06-08 07:09:41.000000000","message":"ditto","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"10e83bcc929b99d9e95d8077e7d9dea68849a5e6","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":461,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":462,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","},{"line_number":463,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    @mock.patch(\u0027tacker.conductor.conductor_server.Conductor\u0027"},{"line_number":466,"context_line":"                \u0027.send_notification\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1cf4e4db_a68d01d0","line":463,"range":{"start_line":463,"start_character":16,"end_line":463,"end_character":59},"in_reply_to":"47cf6377_9505da50","updated":"2022-06-08 17:36:24.000000000","message":"used get method as suggested.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"}],"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"99c38fd0bd104c4f287a71ac430ed5866b00f514","unresolved":true,"context_lines":[{"line_number":3453,"context_line":"        res_dict \u003d self.controller.fail(req, constants.UUID)"},{"line_number":3454,"context_line":"        self.assertEqual(\u0027FAILED\u0027, res_dict[\u0027operationState\u0027])"},{"line_number":3455,"context_line":"        self.assertNotIn(\"affectedVnfcs\","},{"line_number":3456,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3457,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":3458,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3459,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9896d165_17f56ecb","line":3456,"range":{"start_line":3456,"start_character":16,"end_line":3456,"end_character":59},"updated":"2022-06-08 07:09:41.000000000","message":"Rather using str method if possible could we use \"get\" method to find and validate whether mock_send_notification contains \"affectedVnfcs\". Please share your thoughts.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"10e83bcc929b99d9e95d8077e7d9dea68849a5e6","unresolved":false,"context_lines":[{"line_number":3453,"context_line":"        res_dict \u003d self.controller.fail(req, constants.UUID)"},{"line_number":3454,"context_line":"        self.assertEqual(\u0027FAILED\u0027, res_dict[\u0027operationState\u0027])"},{"line_number":3455,"context_line":"        self.assertNotIn(\"affectedVnfcs\","},{"line_number":3456,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3457,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":3458,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3459,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","}],"source_content_type":"text/x-python","patch_set":3,"id":"8785ba54_5babad91","line":3456,"range":{"start_line":3456,"start_character":16,"end_line":3456,"end_character":59},"in_reply_to":"9896d165_17f56ecb","updated":"2022-06-08 17:36:24.000000000","message":"used get method as suggested.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"99c38fd0bd104c4f287a71ac430ed5866b00f514","unresolved":true,"context_lines":[{"line_number":3455,"context_line":"        self.assertNotIn(\"affectedVnfcs\","},{"line_number":3456,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3457,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":3458,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3459,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","},{"line_number":3460,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3461,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a23f15ff_b0832a17","line":3458,"range":{"start_line":3458,"start_character":16,"end_line":3458,"end_character":59},"updated":"2022-06-08 07:09:41.000000000","message":"ditto","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"10e83bcc929b99d9e95d8077e7d9dea68849a5e6","unresolved":false,"context_lines":[{"line_number":3455,"context_line":"        self.assertNotIn(\"affectedVnfcs\","},{"line_number":3456,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3457,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":3458,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3459,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","},{"line_number":3460,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3461,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"36e51e9d_7a2db99e","line":3458,"range":{"start_line":3458,"start_character":16,"end_line":3458,"end_character":59},"in_reply_to":"a23f15ff_b0832a17","updated":"2022-06-08 17:36:24.000000000","message":"used get method as suggested.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"99c38fd0bd104c4f287a71ac430ed5866b00f514","unresolved":true,"context_lines":[{"line_number":3457,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":3458,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3459,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","},{"line_number":3460,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3461,"context_line":""},{"line_number":3462,"context_line":"    @mock.patch.object(objects.VnfInstance, \"get_by_id\")"},{"line_number":3463,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"f7f2c936_030a7082","line":3460,"range":{"start_line":3460,"start_character":16,"end_line":3460,"end_character":59},"updated":"2022-06-08 07:09:41.000000000","message":"ditto","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"10e83bcc929b99d9e95d8077e7d9dea68849a5e6","unresolved":false,"context_lines":[{"line_number":3457,"context_line":"        self.assertNotIn(\"affectedVirtualLinks\","},{"line_number":3458,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3459,"context_line":"        self.assertNotIn(\"affectedVirtualStorages\","},{"line_number":3460,"context_line":"                str(mock_send_notification.call_args[0][1]))"},{"line_number":3461,"context_line":""},{"line_number":3462,"context_line":"    @mock.patch.object(objects.VnfInstance, \"get_by_id\")"},{"line_number":3463,"context_line":"    @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"56691881_ebb7c1f3","line":3460,"range":{"start_line":3460,"start_character":16,"end_line":3460,"end_character":59},"in_reply_to":"f7f2c936_030a7082","updated":"2022-06-08 17:36:24.000000000","message":"used get method as suggested.","commit_id":"c642d7436b71798737e3c11ad961040140d377e9"}]}