)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e94f27d0_ef126b4d","updated":"2022-09-02 09:54:30.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"21d07bf859bb15822bb54ab6260459b7dcff3f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"dc8a24fa_1dc90a05","updated":"2022-09-13 05:01:36.000000000","message":"Thank you for the patch.\nPlease kindly find my comments.","commit_id":"cb4dcd36afba74dda80759b25a0c75c294d73cd2"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"3d44916f99352cd970a84a58c5e73affbeab8543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ede65d10_ff8eb1a3","updated":"2022-09-16 10:09:01.000000000","message":"Hi Core Reviewers,\n\nZuul seems to be unstable. Could you please guide us what shall we do in this case. Thanks.","commit_id":"02d947e3dbfe900e6cb816a04cb1d28ee09c690a"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2aac91b1_c7cfc914","updated":"2022-09-14 08:03:49.000000000","message":"recheck","commit_id":"02d947e3dbfe900e6cb816a04cb1d28ee09c690a"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"c464db6acd969d74a4412a8616c4544ddb70bbbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"cd28914e_9d539427","updated":"2022-09-16 10:05:54.000000000","message":"recheck","commit_id":"02d947e3dbfe900e6cb816a04cb1d28ee09c690a"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"9def33d73caccc533e461c7a76d013eb0889cec1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"df963677_c5f91c2d","updated":"2022-09-16 06:14:48.000000000","message":"recheck","commit_id":"02d947e3dbfe900e6cb816a04cb1d28ee09c690a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"74ef61579ffc92e4a89f14908d6d5103ec5f29ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"76c120f7_8a1003ca","in_reply_to":"ede65d10_ff8eb1a3","updated":"2022-09-16 10:31:13.000000000","message":"Please see my comment on https://review.opendev.org/c/openstack/tacker/+/842533.","commit_id":"02d947e3dbfe900e6cb816a04cb1d28ee09c690a"}],"tacker/tests/etc/samples/etsi/nfv/multi_flavour_deployment/Definitions/helloworld3_df_simple.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            implementation:"},{"line_number":54,"context_line":"              primary: vnflcm_noop"},{"line_number":55,"context_line":"              dependencies:"},{"line_number":56,"context_line":"                 - mgmt_drivers-ansible-sample-end"},{"line_number":57,"context_line":"          terminate: []"},{"line_number":58,"context_line":"          terminate_start: []"},{"line_number":59,"context_line":"          terminate_end: []"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a1b1674c_5eb55dd8","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":24},"updated":"2022-09-02 09:54:30.000000000","message":"typo: `-`?","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            implementation:"},{"line_number":54,"context_line":"              primary: vnflcm_noop"},{"line_number":55,"context_line":"              dependencies:"},{"line_number":56,"context_line":"                 - mgmt_drivers-ansible-sample-end"},{"line_number":57,"context_line":"          terminate: []"},{"line_number":58,"context_line":"          terminate_start: []"},{"line_number":59,"context_line":"          terminate_end: []"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa2fc869_e10fed6a","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":24},"in_reply_to":"a1b1674c_5eb55dd8","updated":"2022-09-14 08:03:49.000000000","message":"Corrected","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"941e21cfd9dfb1fae43e0f167bd6298a4c731daa","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            implementation:"},{"line_number":54,"context_line":"              primary: vnflcm_noop"},{"line_number":55,"context_line":"              dependencies:"},{"line_number":56,"context_line":"                 - mgmt_drivers-ansible-sample-end"},{"line_number":57,"context_line":"          terminate: []"},{"line_number":58,"context_line":"          terminate_start: []"},{"line_number":59,"context_line":"          terminate_end: []"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0fab665c_8f79aa66","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":24},"in_reply_to":"fa2fc869_e10fed6a","updated":"2022-09-15 13:41:37.000000000","message":"Ack","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        mgmt-drivers-ansible-sample-end:"},{"line_number":67,"context_line":"          description: Management driver sample"},{"line_number":68,"context_line":"          type: tosca.artifacts.Implementation.nfv.Mistral"},{"line_number":69,"context_line":"          file: ScriptANSIBLE/config_complex_end.yaml"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    VDU1:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b3dc8b04_f81bf008","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":58},"updated":"2022-09-02 09:54:30.000000000","message":"Is `tosca.artifacts.Implementation.Yaml` correct?\n\nPlease refer to spec: https://specs.openstack.org/openstack/tacker-specs/specs/zed/support_multi_artifact_of_ansible_driver.html#proposed-change","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"941e21cfd9dfb1fae43e0f167bd6298a4c731daa","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        mgmt-drivers-ansible-sample-end:"},{"line_number":67,"context_line":"          description: Management driver sample"},{"line_number":68,"context_line":"          type: tosca.artifacts.Implementation.nfv.Mistral"},{"line_number":69,"context_line":"          file: ScriptANSIBLE/config_complex_end.yaml"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    VDU1:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7fa5d5aa_0b85d1ab","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":58},"in_reply_to":"3a14b416_ce2d94f9","updated":"2022-09-15 13:41:37.000000000","message":"Ack","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        mgmt-drivers-ansible-sample-end:"},{"line_number":67,"context_line":"          description: Management driver sample"},{"line_number":68,"context_line":"          type: tosca.artifacts.Implementation.nfv.Mistral"},{"line_number":69,"context_line":"          file: ScriptANSIBLE/config_complex_end.yaml"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    VDU1:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a14b416_ce2d94f9","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":58},"in_reply_to":"b3dc8b04_f81bf008","updated":"2022-09-14 08:03:49.000000000","message":"Corrected","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"}],"tacker/tests/etc/samples/etsi/nfv/multi_flavour_deployment/Drivers/vnflcm_noop.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ee791b2b84e0c9f88a7c7bc7b26093297d868db8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 FUJITSU"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"30aeea94_f64e3ac0","line":1,"updated":"2022-09-05 19:07:04.000000000","message":"nit: Is that correct? NEC?","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 FUJITSU"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"e125f1ab_a9d85816","line":1,"in_reply_to":"30aeea94_f64e3ac0","updated":"2022-09-14 08:03:49.000000000","message":"Corrected","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"}],"tacker/tests/etc/samples/etsi/nfv/multi_flavour_deployment/Scripts/complex/instantiation_end.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# This playbook prints a simple debug message"},{"line_number":2,"context_line":"- name: Echo "},{"line_number":3,"context_line":"  hosts: 127.0.0.1"},{"line_number":4,"context_line":"  connection: local"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c1e82627_8645bbdb","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":13},"updated":"2022-09-02 09:54:30.000000000","message":"nit: Could remove a unnecessary space character?","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# This playbook prints a simple debug message"},{"line_number":2,"context_line":"- name: Echo "},{"line_number":3,"context_line":"  hosts: 127.0.0.1"},{"line_number":4,"context_line":"  connection: local"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c67df595_4307596f","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":13},"in_reply_to":"c1e82627_8645bbdb","updated":"2022-09-14 08:03:49.000000000","message":"Removed","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"941e21cfd9dfb1fae43e0f167bd6298a4c731daa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This playbook prints a simple debug message"},{"line_number":2,"context_line":"- name: Echo "},{"line_number":3,"context_line":"  hosts: 127.0.0.1"},{"line_number":4,"context_line":"  connection: local"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1b61f99a_25d7d756","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":13},"in_reply_to":"c67df595_4307596f","updated":"2022-09-15 13:41:37.000000000","message":"Ack","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"}],"tacker/tests/etc/samples/etsi/nfv/multi_flavour_deployment_invalid/Definitions/helloworld3_df_simple.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            implementation:"},{"line_number":54,"context_line":"              primary: ansible_driver"},{"line_number":55,"context_line":"              dependencies:"},{"line_number":56,"context_line":"                 - mgmt_drivers-ansible-sample-end"},{"line_number":57,"context_line":"          terminate: []"},{"line_number":58,"context_line":"          terminate_start: []"},{"line_number":59,"context_line":"          terminate_end: []"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"805957fd_a9fcc521","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":24},"updated":"2022-09-02 09:54:30.000000000","message":"typo: `-`?","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"941e21cfd9dfb1fae43e0f167bd6298a4c731daa","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            implementation:"},{"line_number":54,"context_line":"              primary: ansible_driver"},{"line_number":55,"context_line":"              dependencies:"},{"line_number":56,"context_line":"                 - mgmt_drivers-ansible-sample-end"},{"line_number":57,"context_line":"          terminate: []"},{"line_number":58,"context_line":"          terminate_start: []"},{"line_number":59,"context_line":"          terminate_end: []"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e59128cf_d1a5056f","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":24},"in_reply_to":"58c11d0a_d861fa08","updated":"2022-09-15 13:41:37.000000000","message":"Ack","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":53,"context_line":"            implementation:"},{"line_number":54,"context_line":"              primary: ansible_driver"},{"line_number":55,"context_line":"              dependencies:"},{"line_number":56,"context_line":"                 - mgmt_drivers-ansible-sample-end"},{"line_number":57,"context_line":"          terminate: []"},{"line_number":58,"context_line":"          terminate_start: []"},{"line_number":59,"context_line":"          terminate_end: []"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"58c11d0a_d861fa08","line":56,"range":{"start_line":56,"start_character":23,"end_line":56,"end_character":24},"in_reply_to":"805957fd_a9fcc521","updated":"2022-09-14 08:03:49.000000000","message":"Corrected","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        mgmt-drivers-ansible-sample-end:"},{"line_number":67,"context_line":"          description: Management driver sample"},{"line_number":68,"context_line":"          type: tosca.artifacts.Implementation.nfv.Mistral"},{"line_number":69,"context_line":"          file: ScriptANSIBLE/config_complex_end.yaml"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    VDU1:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cdd56818_9870cfdc","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":58},"updated":"2022-09-02 09:54:30.000000000","message":"Is `tosca.artifacts.Implementation.Yaml` correct?\n\nPlease refer to spec: https://specs.openstack.org/openstack/tacker-specs/specs/zed/support_multi_artifact_of_ansible_driver.html#proposed-change","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"941e21cfd9dfb1fae43e0f167bd6298a4c731daa","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        mgmt-drivers-ansible-sample-end:"},{"line_number":67,"context_line":"          description: Management driver sample"},{"line_number":68,"context_line":"          type: tosca.artifacts.Implementation.nfv.Mistral"},{"line_number":69,"context_line":"          file: ScriptANSIBLE/config_complex_end.yaml"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    VDU1:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c21284f9_64946eb7","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":58},"in_reply_to":"92cf5274_d2ba71a9","updated":"2022-09-15 13:41:37.000000000","message":"Ack","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        mgmt-drivers-ansible-sample-end:"},{"line_number":67,"context_line":"          description: Management driver sample"},{"line_number":68,"context_line":"          type: tosca.artifacts.Implementation.nfv.Mistral"},{"line_number":69,"context_line":"          file: ScriptANSIBLE/config_complex_end.yaml"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    VDU1:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"92cf5274_d2ba71a9","line":68,"range":{"start_line":68,"start_character":16,"end_line":68,"end_character":58},"in_reply_to":"cdd56818_9870cfdc","updated":"2022-09-14 08:03:49.000000000","message":"Corrected","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"}],"tacker/tests/etc/samples/etsi/nfv/multi_flavour_deployment_invalid/Scripts/complex/instantiation_end.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# This playbook prints a simple debug message"},{"line_number":2,"context_line":"- name: Echo "},{"line_number":3,"context_line":"  hosts: 127.0.0.1"},{"line_number":4,"context_line":"  connection: local"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"be7b9d84_3a92d7ce","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":13},"updated":"2022-09-02 09:54:30.000000000","message":"nit: Could remove a unnecessary space character?","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"941e21cfd9dfb1fae43e0f167bd6298a4c731daa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This playbook prints a simple debug message"},{"line_number":2,"context_line":"- name: Echo "},{"line_number":3,"context_line":"  hosts: 127.0.0.1"},{"line_number":4,"context_line":"  connection: local"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cffc893d_a3cb4b60","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":13},"in_reply_to":"b14cb3cf_da342764","updated":"2022-09-15 13:41:37.000000000","message":"Ack","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# This playbook prints a simple debug message"},{"line_number":2,"context_line":"- name: Echo "},{"line_number":3,"context_line":"  hosts: 127.0.0.1"},{"line_number":4,"context_line":"  connection: local"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b14cb3cf_da342764","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":13},"in_reply_to":"be7b9d84_3a92d7ce","updated":"2022-09-14 08:03:49.000000000","message":"Removed","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"}],"tacker/tests/unit/vnflcm/test_load_vnf_interfaces.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":true,"context_lines":[{"line_number":279,"context_line":"        vnf_package_id \u003d vnf_package_vnfd.package_uuid"},{"line_number":280,"context_line":"        mock_vnf_package_vnfd.return_value \u003d vnf_package_vnfd"},{"line_number":281,"context_line":"        instantiate_vnf_req_dict \u003d fakes.get_dummy_instantiate_vnf_request()"},{"line_number":282,"context_line":"        instantiate_vnf_req_obj \u003d \\"},{"line_number":283,"context_line":"            objects.InstantiateVnfRequest.obj_from_primitive("},{"line_number":284,"context_line":"                instantiate_vnf_req_dict, self.context)"},{"line_number":285,"context_line":"        vnf_instance_obj \u003d fakes.return_vnf_instance()"}],"source_content_type":"text/x-python","patch_set":5,"id":"d75a103d_c4eb0c4d","line":282,"range":{"start_line":282,"start_character":34,"end_line":282,"end_character":35},"updated":"2022-09-02 09:54:30.000000000","message":"Could you change to not use backslash as line break?","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8549d2fc647f77841c854e1bc42757b9246f8605","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        vnf_package_id \u003d vnf_package_vnfd.package_uuid"},{"line_number":280,"context_line":"        mock_vnf_package_vnfd.return_value \u003d vnf_package_vnfd"},{"line_number":281,"context_line":"        instantiate_vnf_req_dict \u003d fakes.get_dummy_instantiate_vnf_request()"},{"line_number":282,"context_line":"        instantiate_vnf_req_obj \u003d \\"},{"line_number":283,"context_line":"            objects.InstantiateVnfRequest.obj_from_primitive("},{"line_number":284,"context_line":"                instantiate_vnf_req_dict, self.context)"},{"line_number":285,"context_line":"        vnf_instance_obj \u003d fakes.return_vnf_instance()"}],"source_content_type":"text/x-python","patch_set":5,"id":"2ffdf274_e2d22c4a","line":282,"range":{"start_line":282,"start_character":34,"end_line":282,"end_character":35},"in_reply_to":"b0839539_654c270a","updated":"2022-09-06 12:38:08.000000000","message":"It also becomes no consistency with existing methods, so it may be better not to change them.\nAs you said, I withdraws the comment. Thanks yasufum-san.","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ee791b2b84e0c9f88a7c7bc7b26093297d868db8","unresolved":true,"context_lines":[{"line_number":279,"context_line":"        vnf_package_id \u003d vnf_package_vnfd.package_uuid"},{"line_number":280,"context_line":"        mock_vnf_package_vnfd.return_value \u003d vnf_package_vnfd"},{"line_number":281,"context_line":"        instantiate_vnf_req_dict \u003d fakes.get_dummy_instantiate_vnf_request()"},{"line_number":282,"context_line":"        instantiate_vnf_req_obj \u003d \\"},{"line_number":283,"context_line":"            objects.InstantiateVnfRequest.obj_from_primitive("},{"line_number":284,"context_line":"                instantiate_vnf_req_dict, self.context)"},{"line_number":285,"context_line":"        vnf_instance_obj \u003d fakes.return_vnf_instance()"}],"source_content_type":"text/x-python","patch_set":5,"id":"b0839539_654c270a","line":282,"range":{"start_line":282,"start_character":34,"end_line":282,"end_character":35},"in_reply_to":"d75a103d_c4eb0c4d","updated":"2022-09-05 19:07:04.000000000","message":"ueha: I think we\u0027d better to accept the backslash in this case because it can be more worse without using the backslash. We should make it use shorter name of methods, or accept such a case although I don\u0027t like such a backslash actually...","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":true,"context_lines":[{"line_number":321,"context_line":"        vnf_package_id \u003d vnf_package_vnfd.package_uuid"},{"line_number":322,"context_line":"        mock_vnf_package_vnfd.return_value \u003d vnf_package_vnfd"},{"line_number":323,"context_line":"        instantiate_vnf_req_dict \u003d fakes.get_dummy_instantiate_vnf_request()"},{"line_number":324,"context_line":"        instantiate_vnf_req_obj \u003d \\"},{"line_number":325,"context_line":"            objects.InstantiateVnfRequest.obj_from_primitive("},{"line_number":326,"context_line":"                instantiate_vnf_req_dict, self.context)"},{"line_number":327,"context_line":"        vnf_instance_obj \u003d fakes.return_vnf_instance()"}],"source_content_type":"text/x-python","patch_set":5,"id":"6059edd1_3d4c55e0","line":324,"range":{"start_line":324,"start_character":34,"end_line":324,"end_character":35},"updated":"2022-09-02 09:54:30.000000000","message":"ditto.","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":321,"context_line":"        vnf_package_id \u003d vnf_package_vnfd.package_uuid"},{"line_number":322,"context_line":"        mock_vnf_package_vnfd.return_value \u003d vnf_package_vnfd"},{"line_number":323,"context_line":"        instantiate_vnf_req_dict \u003d fakes.get_dummy_instantiate_vnf_request()"},{"line_number":324,"context_line":"        instantiate_vnf_req_obj \u003d \\"},{"line_number":325,"context_line":"            objects.InstantiateVnfRequest.obj_from_primitive("},{"line_number":326,"context_line":"                instantiate_vnf_req_dict, self.context)"},{"line_number":327,"context_line":"        vnf_instance_obj \u003d fakes.return_vnf_instance()"}],"source_content_type":"text/x-python","patch_set":5,"id":"779e6c45_decb8b1b","line":324,"range":{"start_line":324,"start_character":34,"end_line":324,"end_character":35},"in_reply_to":"6059edd1_3d4c55e0","updated":"2022-09-14 08:03:49.000000000","message":"As previous comment was withdrawn, so it seems that this comment also need no rework. Please confirm.","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"941e21cfd9dfb1fae43e0f167bd6298a4c731daa","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        vnf_package_id \u003d vnf_package_vnfd.package_uuid"},{"line_number":322,"context_line":"        mock_vnf_package_vnfd.return_value \u003d vnf_package_vnfd"},{"line_number":323,"context_line":"        instantiate_vnf_req_dict \u003d fakes.get_dummy_instantiate_vnf_request()"},{"line_number":324,"context_line":"        instantiate_vnf_req_obj \u003d \\"},{"line_number":325,"context_line":"            objects.InstantiateVnfRequest.obj_from_primitive("},{"line_number":326,"context_line":"                instantiate_vnf_req_dict, self.context)"},{"line_number":327,"context_line":"        vnf_instance_obj \u003d fakes.return_vnf_instance()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ccf55919_ccc497a2","line":324,"range":{"start_line":324,"start_character":34,"end_line":324,"end_character":35},"in_reply_to":"779e6c45_decb8b1b","updated":"2022-09-15 13:41:37.000000000","message":"Ack","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ee791b2b84e0c9f88a7c7bc7b26093297d868db8","unresolved":true,"context_lines":[{"line_number":342,"context_line":"                          driver.instantiate_vnf, self.context,"},{"line_number":343,"context_line":"                          vnf_instance_obj, vnf_dict,"},{"line_number":344,"context_line":"                          instantiate_vnf_req_obj)"},{"line_number":345,"context_line":"        shutil.rmtree(fake_csar)"}],"source_content_type":"text/x-python","patch_set":5,"id":"112b7a31_1484120e","line":345,"updated":"2022-09-05 19:07:04.000000000","message":"It seems better to use `finally` to ensure this `rm` operation. What do you think?","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":342,"context_line":"                          driver.instantiate_vnf, self.context,"},{"line_number":343,"context_line":"                          vnf_instance_obj, vnf_dict,"},{"line_number":344,"context_line":"                          instantiate_vnf_req_obj)"},{"line_number":345,"context_line":"        shutil.rmtree(fake_csar)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da255766_74e9f46a","line":345,"in_reply_to":"112b7a31_1484120e","updated":"2022-09-14 08:03:49.000000000","message":"As there is no try block in this function then for adding this in finally try/finally need to be implemented here. Please let me know if you want try/finally block to be included here.","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":true,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _check_mgmt_driver(self, artifact_mgmt_driver, artifacts_value,"},{"line_number":461,"context_line":"                           vnf_package_path,"},{"line_number":462,"context_line":"                           artifact_mgmt_driver_dependencies\u003dNone):"},{"line_number":463,"context_line":"        # check implementation and artifacts exist in cfg.CONF.tacker"},{"line_number":464,"context_line":"        if artifact_mgmt_driver not in self._mgmt_driver_hash:"},{"line_number":465,"context_line":"            LOG.error(\u0027The {} specified in the VNFD \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"73c89635_b3e6c9bb","line":462,"range":{"start_line":462,"start_character":48,"end_line":462,"end_character":60},"updated":"2022-09-02 09:54:30.000000000","message":"nit: Is \"dependency\" more appropriate?","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8549d2fc647f77841c854e1bc42757b9246f8605","unresolved":true,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _check_mgmt_driver(self, artifact_mgmt_driver, artifacts_value,"},{"line_number":461,"context_line":"                           vnf_package_path,"},{"line_number":462,"context_line":"                           artifact_mgmt_driver_dependencies\u003dNone):"},{"line_number":463,"context_line":"        # check implementation and artifacts exist in cfg.CONF.tacker"},{"line_number":464,"context_line":"        if artifact_mgmt_driver not in self._mgmt_driver_hash:"},{"line_number":465,"context_line":"            LOG.error(\u0027The {} specified in the VNFD \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"50eb3e21_ad1cb8fa","line":462,"range":{"start_line":462,"start_character":48,"end_line":462,"end_character":60},"in_reply_to":"1272a8b2_0ec3c33a","updated":"2022-09-06 12:38:08.000000000","message":"Looking at the processing of L. 515 -535, I commented that the singular `dependency` might be more appropriate than the plural `dependencies` because it seemed that the singular `dependency` was passed as a parameter in all routes.\n\n1. [L515] `type\u003ddict`: Get dependencies by getting type \u003d dict:\n  a. [L521]`type\u003dlist`:\n    looped so that the element in list is parameter (\u003d singular `dependency`)\n    ***example definition***\n    ```\n          instantiate_end:\n            implementation:\n              primary: ansible_driver\n              dependencies:\n                 - mgmt-drivers-ansible-sample-end\n    ```\n  b. [L527]`type!\u003dlist`: singular `dependency`\n    ***example definition***\n    ```\n          instantiate_end:\n            implementation:\n              primary: ansible_driver\n              dependencies: mgmt-drivers-ansible-sample-end\n    ```\n\n2. [L532] type! \u003d dict: singular `dependency`\n    ***example definition***\n    ```\n          instantiate_end:\n            implementation: mgmt-drivers-ansible-sample-end\n    ```","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6ab379b3c407f377f9403e54fc9bc1bd2b5e8fa3","unresolved":true,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _check_mgmt_driver(self, artifact_mgmt_driver, artifacts_value,"},{"line_number":461,"context_line":"                           vnf_package_path,"},{"line_number":462,"context_line":"                           artifact_mgmt_driver_dependencies\u003dNone):"},{"line_number":463,"context_line":"        # check implementation and artifacts exist in cfg.CONF.tacker"},{"line_number":464,"context_line":"        if artifact_mgmt_driver not in self._mgmt_driver_hash:"},{"line_number":465,"context_line":"            LOG.error(\u0027The {} specified in the VNFD \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"88152871_12614ba8","line":462,"range":{"start_line":462,"start_character":48,"end_line":462,"end_character":60},"in_reply_to":"50eb3e21_ad1cb8fa","updated":"2022-09-06 12:40:57.000000000","message":"sorry, I sent wrong comment.\nx: 1. [L515] `type\u003ddict`: Get dependencies by getting type \u003d dict:\no: 1. [L515] `type\u003ddict`: Get implementation:","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"941e21cfd9dfb1fae43e0f167bd6298a4c731daa","unresolved":false,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _check_mgmt_driver(self, artifact_mgmt_driver, artifacts_value,"},{"line_number":461,"context_line":"                           vnf_package_path,"},{"line_number":462,"context_line":"                           artifact_mgmt_driver_dependencies\u003dNone):"},{"line_number":463,"context_line":"        # check implementation and artifacts exist in cfg.CONF.tacker"},{"line_number":464,"context_line":"        if artifact_mgmt_driver not in self._mgmt_driver_hash:"},{"line_number":465,"context_line":"            LOG.error(\u0027The {} specified in the VNFD \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"99dc7a8d_35878082","line":462,"range":{"start_line":462,"start_character":48,"end_line":462,"end_character":60},"in_reply_to":"51e6cd77_5373b174","updated":"2022-09-15 13:41:37.000000000","message":"Ack","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ee791b2b84e0c9f88a7c7bc7b26093297d868db8","unresolved":true,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _check_mgmt_driver(self, artifact_mgmt_driver, artifacts_value,"},{"line_number":461,"context_line":"                           vnf_package_path,"},{"line_number":462,"context_line":"                           artifact_mgmt_driver_dependencies\u003dNone):"},{"line_number":463,"context_line":"        # check implementation and artifacts exist in cfg.CONF.tacker"},{"line_number":464,"context_line":"        if artifact_mgmt_driver not in self._mgmt_driver_hash:"},{"line_number":465,"context_line":"            LOG.error(\u0027The {} specified in the VNFD \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1272a8b2_0ec3c33a","line":462,"range":{"start_line":462,"start_character":48,"end_line":462,"end_character":60},"in_reply_to":"73c89635_b3e6c9bb","updated":"2022-09-05 19:07:04.000000000","message":"ueha: Could you make your point clear because it must be a list from the comment at L.510 and it looks OK as plural form for this variable. Or, is there any misunderstanding of me?","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def _check_mgmt_driver(self, artifact_mgmt_driver, artifacts_value,"},{"line_number":461,"context_line":"                           vnf_package_path,"},{"line_number":462,"context_line":"                           artifact_mgmt_driver_dependencies\u003dNone):"},{"line_number":463,"context_line":"        # check implementation and artifacts exist in cfg.CONF.tacker"},{"line_number":464,"context_line":"        if artifact_mgmt_driver not in self._mgmt_driver_hash:"},{"line_number":465,"context_line":"            LOG.error(\u0027The {} specified in the VNFD \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"51e6cd77_5373b174","line":462,"range":{"start_line":462,"start_character":48,"end_line":462,"end_character":60},"in_reply_to":"88152871_12614ba8","updated":"2022-09-14 08:03:49.000000000","message":"renamed dependencies with dependency","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ee791b2b84e0c9f88a7c7bc7b26093297d868db8","unresolved":true,"context_lines":[{"line_number":461,"context_line":"                           vnf_package_path,"},{"line_number":462,"context_line":"                           artifact_mgmt_driver_dependencies\u003dNone):"},{"line_number":463,"context_line":"        # check implementation and artifacts exist in cfg.CONF.tacker"},{"line_number":464,"context_line":"        if artifact_mgmt_driver not in self._mgmt_driver_hash:"},{"line_number":465,"context_line":"            LOG.error(\u0027The {} specified in the VNFD \u0027"},{"line_number":466,"context_line":"                      \u0027is inconsistent with the MgmtDriver in \u0027"},{"line_number":467,"context_line":"                      \u0027the configuration file.\u0027.format(artifact_mgmt_driver))"},{"line_number":468,"context_line":"            raise exceptions.MgmtDriverInconsistent("},{"line_number":469,"context_line":"                MgmtDriver\u003dartifact_mgmt_driver)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if artifact_mgmt_driver_dependencies is not None:"},{"line_number":472,"context_line":"            if artifact_mgmt_driver_dependencies in self._mgmt_driver_hash:"},{"line_number":473,"context_line":"                LOG.error(\u0027The {} specified in the VNFD \u0027"},{"line_number":474,"context_line":"                        \u0027is inconsistent with the MgmtDriver in \u0027"},{"line_number":475,"context_line":"                        \u0027the configuration file.\u0027"},{"line_number":476,"context_line":"                        .format(artifact_mgmt_driver_dependencies))"},{"line_number":477,"context_line":"                raise exceptions.MgmtDriverInconsistent("},{"line_number":478,"context_line":"                    MgmtDriver\u003dartifact_mgmt_driver_dependencies)"},{"line_number":479,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df139e1e_6be9c35a","line":476,"range":{"start_line":464,"start_character":8,"end_line":476,"end_character":67},"updated":"2022-09-05 19:07:04.000000000","message":"These two error logs are indirect for users because it must be hard to find which VNFD and configuration file you mention. So, could you make it easier to fix the cause of the errors by revising the messages?","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":461,"context_line":"                           vnf_package_path,"},{"line_number":462,"context_line":"                           artifact_mgmt_driver_dependencies\u003dNone):"},{"line_number":463,"context_line":"        # check implementation and artifacts exist in cfg.CONF.tacker"},{"line_number":464,"context_line":"        if artifact_mgmt_driver not in self._mgmt_driver_hash:"},{"line_number":465,"context_line":"            LOG.error(\u0027The {} specified in the VNFD \u0027"},{"line_number":466,"context_line":"                      \u0027is inconsistent with the MgmtDriver in \u0027"},{"line_number":467,"context_line":"                      \u0027the configuration file.\u0027.format(artifact_mgmt_driver))"},{"line_number":468,"context_line":"            raise exceptions.MgmtDriverInconsistent("},{"line_number":469,"context_line":"                MgmtDriver\u003dartifact_mgmt_driver)"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if artifact_mgmt_driver_dependencies is not None:"},{"line_number":472,"context_line":"            if artifact_mgmt_driver_dependencies in self._mgmt_driver_hash:"},{"line_number":473,"context_line":"                LOG.error(\u0027The {} specified in the VNFD \u0027"},{"line_number":474,"context_line":"                        \u0027is inconsistent with the MgmtDriver in \u0027"},{"line_number":475,"context_line":"                        \u0027the configuration file.\u0027"},{"line_number":476,"context_line":"                        .format(artifact_mgmt_driver_dependencies))"},{"line_number":477,"context_line":"                raise exceptions.MgmtDriverInconsistent("},{"line_number":478,"context_line":"                    MgmtDriver\u003dartifact_mgmt_driver_dependencies)"},{"line_number":479,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d43f1eea_dac6aa11","line":476,"range":{"start_line":464,"start_character":8,"end_line":476,"end_character":67},"in_reply_to":"df139e1e_6be9c35a","updated":"2022-09-14 08:03:49.000000000","message":"Modified the error logs message","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c6761e9537a5fb24493494beff422092b2bc829d","unresolved":true,"context_lines":[{"line_number":519,"context_line":"                        artifact_mgmt_driver.get(\u0027dependencies\u0027))"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"                    if isinstance(artifact_mgmt_driver_dependencies, list):"},{"line_number":522,"context_line":"                        for dependencies in artifact_mgmt_driver_dependencies:"},{"line_number":523,"context_line":"                            tacker_mgmt_driver \u003d self._check_mgmt_driver("},{"line_number":524,"context_line":"                                artifact_mgmt_driver_primary,"},{"line_number":525,"context_line":"                                artifacts_value, vnf_package_path,"}],"source_content_type":"text/x-python","patch_set":5,"id":"99adf62a_e5107886","line":522,"range":{"start_line":522,"start_character":28,"end_line":522,"end_character":40},"updated":"2022-09-02 09:54:30.000000000","message":"ditto.","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"30fdbc0a23a2f2cee8f23a85f45e56b401c9f2cf","unresolved":true,"context_lines":[{"line_number":519,"context_line":"                        artifact_mgmt_driver.get(\u0027dependencies\u0027))"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"                    if isinstance(artifact_mgmt_driver_dependencies, list):"},{"line_number":522,"context_line":"                        for dependencies in artifact_mgmt_driver_dependencies:"},{"line_number":523,"context_line":"                            tacker_mgmt_driver \u003d self._check_mgmt_driver("},{"line_number":524,"context_line":"                                artifact_mgmt_driver_primary,"},{"line_number":525,"context_line":"                                artifacts_value, vnf_package_path,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bcad6280_9f1eb6c4","line":522,"range":{"start_line":522,"start_character":28,"end_line":522,"end_character":40},"in_reply_to":"99adf62a_e5107886","updated":"2022-09-14 08:03:49.000000000","message":"renamed dependencies with dependency","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"941e21cfd9dfb1fae43e0f167bd6298a4c731daa","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                        artifact_mgmt_driver.get(\u0027dependencies\u0027))"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"                    if isinstance(artifact_mgmt_driver_dependencies, list):"},{"line_number":522,"context_line":"                        for dependencies in artifact_mgmt_driver_dependencies:"},{"line_number":523,"context_line":"                            tacker_mgmt_driver \u003d self._check_mgmt_driver("},{"line_number":524,"context_line":"                                artifact_mgmt_driver_primary,"},{"line_number":525,"context_line":"                                artifacts_value, vnf_package_path,"}],"source_content_type":"text/x-python","patch_set":5,"id":"facc2536_87373789","line":522,"range":{"start_line":522,"start_character":28,"end_line":522,"end_character":40},"in_reply_to":"bcad6280_9f1eb6c4","updated":"2022-09-15 13:41:37.000000000","message":"Ack","commit_id":"7115bc1fa7716db7420e7e92573498cdc2d378a7"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"21d07bf859bb15822bb54ab6260459b7dcff3f18","unresolved":true,"context_lines":[{"line_number":516,"context_line":"                # If necessary, we need to implement the ability to load"},{"line_number":517,"context_line":"                # multiple definitions."},{"line_number":518,"context_line":"                if isinstance(artifact_mgmt_driver, dict):"},{"line_number":519,"context_line":"                    artifact_mgmt_driver_primary \u003d ("},{"line_number":520,"context_line":"                        artifact_mgmt_driver.get(\u0027primary\u0027))"},{"line_number":521,"context_line":"                    artifact_mgmt_driver_dependencies \u003d ("},{"line_number":522,"context_line":"                        artifact_mgmt_driver.get(\u0027dependencies\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"65b7687a_18d9d205","line":519,"range":{"start_line":519,"start_character":20,"end_line":519,"end_character":48},"updated":"2022-09-13 05:01:36.000000000","message":"Cloud you shorten this? for example, `artifact_mgmt_driver`. As it will not be used after this block, you can overwrite this variable name.","commit_id":"cb4dcd36afba74dda80759b25a0c75c294d73cd2"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"3acb889e78dc190cbee02c462b6fdb3f64004f70","unresolved":false,"context_lines":[{"line_number":516,"context_line":"                # If necessary, we need to implement the ability to load"},{"line_number":517,"context_line":"                # multiple definitions."},{"line_number":518,"context_line":"                if isinstance(artifact_mgmt_driver, dict):"},{"line_number":519,"context_line":"                    artifact_mgmt_driver_primary \u003d ("},{"line_number":520,"context_line":"                        artifact_mgmt_driver.get(\u0027primary\u0027))"},{"line_number":521,"context_line":"                    artifact_mgmt_driver_dependencies \u003d ("},{"line_number":522,"context_line":"                        artifact_mgmt_driver.get(\u0027dependencies\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3c564b6b_555982ca","line":519,"range":{"start_line":519,"start_character":20,"end_line":519,"end_character":48},"in_reply_to":"65b7687a_18d9d205","updated":"2022-09-16 05:14:15.000000000","message":"Done","commit_id":"cb4dcd36afba74dda80759b25a0c75c294d73cd2"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"21d07bf859bb15822bb54ab6260459b7dcff3f18","unresolved":true,"context_lines":[{"line_number":518,"context_line":"                if isinstance(artifact_mgmt_driver, dict):"},{"line_number":519,"context_line":"                    artifact_mgmt_driver_primary \u003d ("},{"line_number":520,"context_line":"                        artifact_mgmt_driver.get(\u0027primary\u0027))"},{"line_number":521,"context_line":"                    artifact_mgmt_driver_dependencies \u003d ("},{"line_number":522,"context_line":"                        artifact_mgmt_driver.get(\u0027dependencies\u0027))"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"                    if isinstance(artifact_mgmt_driver_dependencies, list):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9d74eebb_5927f79c","line":521,"range":{"start_line":521,"start_character":20,"end_line":521,"end_character":53},"updated":"2022-09-13 05:01:36.000000000","message":"ditto. may be `dependencies` is enough as there\u0027s no other similar variables in this function.","commit_id":"cb4dcd36afba74dda80759b25a0c75c294d73cd2"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"3acb889e78dc190cbee02c462b6fdb3f64004f70","unresolved":false,"context_lines":[{"line_number":518,"context_line":"                if isinstance(artifact_mgmt_driver, dict):"},{"line_number":519,"context_line":"                    artifact_mgmt_driver_primary \u003d ("},{"line_number":520,"context_line":"                        artifact_mgmt_driver.get(\u0027primary\u0027))"},{"line_number":521,"context_line":"                    artifact_mgmt_driver_dependencies \u003d ("},{"line_number":522,"context_line":"                        artifact_mgmt_driver.get(\u0027dependencies\u0027))"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"                    if isinstance(artifact_mgmt_driver_dependencies, list):"}],"source_content_type":"text/x-python","patch_set":10,"id":"6588c9cf_2494073b","line":521,"range":{"start_line":521,"start_character":20,"end_line":521,"end_character":53},"in_reply_to":"9d74eebb_5927f79c","updated":"2022-09-16 05:14:15.000000000","message":"Done","commit_id":"cb4dcd36afba74dda80759b25a0c75c294d73cd2"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"21d07bf859bb15822bb54ab6260459b7dcff3f18","unresolved":true,"context_lines":[{"line_number":521,"context_line":"                    artifact_mgmt_driver_dependencies \u003d ("},{"line_number":522,"context_line":"                        artifact_mgmt_driver.get(\u0027dependencies\u0027))"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"                    if isinstance(artifact_mgmt_driver_dependencies, list):"},{"line_number":525,"context_line":"                        for dependency in artifact_mgmt_driver_dependencies:"},{"line_number":526,"context_line":"                            tacker_mgmt_driver \u003d self._check_mgmt_driver("},{"line_number":527,"context_line":"                                artifact_mgmt_driver_primary,"}],"source_content_type":"text/x-python","patch_set":10,"id":"c1228927_5a14b8c9","line":524,"updated":"2022-09-13 05:01:36.000000000","message":"nits.\n\nThis will reduce the nesting and codes. The above TODO says dependencies are defined List, you can simply remove the first if statement after fix the implementation.\n```\nif not isinstance(artifact_mgmt_driver_dependencies, list):\n    artifact_mgmt_driver_dependencies \u003d [artifact_mgmt_driver_dependencies]\nfor dependency in artifact_mgmt_driver_dependencies:\n... \n```","commit_id":"cb4dcd36afba74dda80759b25a0c75c294d73cd2"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"3acb889e78dc190cbee02c462b6fdb3f64004f70","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                    artifact_mgmt_driver_dependencies \u003d ("},{"line_number":522,"context_line":"                        artifact_mgmt_driver.get(\u0027dependencies\u0027))"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"                    if isinstance(artifact_mgmt_driver_dependencies, list):"},{"line_number":525,"context_line":"                        for dependency in artifact_mgmt_driver_dependencies:"},{"line_number":526,"context_line":"                            tacker_mgmt_driver \u003d self._check_mgmt_driver("},{"line_number":527,"context_line":"                                artifact_mgmt_driver_primary,"}],"source_content_type":"text/x-python","patch_set":10,"id":"09a0c7b9_8f131018","line":524,"in_reply_to":"c1228927_5a14b8c9","updated":"2022-09-16 05:14:15.000000000","message":"Done","commit_id":"cb4dcd36afba74dda80759b25a0c75c294d73cd2"}]}