)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"e68cf10696fcbe01b3bd16c122398eaacfa751ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7cd26dc1_b2c5d5b4","updated":"2022-05-28 16:43:32.000000000","message":"recheck","commit_id":"252958ff43072c6d7f848f8cf4d5fb408c567e85"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"1ed194fd0bfd783e53720754bbeb99817820b955","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"acfdf4ea_b0a45cba","updated":"2022-06-03 01:48:18.000000000","message":"Thank you for your comments.\nPlease kindly review it again.","commit_id":"79f8cc0c79ec575d500b5b55ea6e645294ca84e1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"425734eda4db89d0cf288150339926473ae1b158","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b4b675a6_3c90b15a","updated":"2022-06-01 03:01:27.000000000","message":"Thanks for your patch. Warning are removed in UT logs. LGTM!! but could you please address my query.","commit_id":"79f8cc0c79ec575d500b5b55ea6e645294ca84e1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b365ff86d72db772ef0a72f10ac6741d53b8ce1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d876c820_b43ea2f8","updated":"2022-06-03 10:15:12.000000000","message":"Thanks for rework. LGTM!","commit_id":"39925d1141be6e58a318256c2e5cd42cc417c8f4"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"d735cbd99ad0486b26005f529495e2878de1c8de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0cd05140_8b5b4914","updated":"2022-06-03 06:49:49.000000000","message":"recheck","commit_id":"39925d1141be6e58a318256c2e5cd42cc417c8f4"}],"tacker/api/v1/base.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"425734eda4db89d0cf288150339926473ae1b158","unresolved":true,"context_lines":[{"line_number":595,"context_line":"        # NOTE: The `project_id` is not included in attr_info, but it is used"},{"line_number":596,"context_line":"        # as an alternative of `tenant_id` which is already deprecated in"},{"line_number":597,"context_line":"        # oslo.context. Excluding `project_id` from the verification is a"},{"line_number":598,"context_line":"        # workaround to avoid directly modifying attr_info which has a strong"},{"line_number":599,"context_line":"        # influence on the existing code."},{"line_number":600,"context_line":"        excluded \u003d {\u0027project_id\u0027}"},{"line_number":601,"context_line":"        extra_keys \u003d set(res_dict.keys()) - set(attr_info.keys()) - excluded"}],"source_content_type":"text/x-python","patch_set":10,"id":"0ecfc9c0_758a1dcc","line":598,"range":{"start_line":598,"start_character":10,"end_line":598,"end_character":20},"updated":"2022-06-01 03:01:27.000000000","message":"Suggestion, please add your name next to \"NOTE\" as its good practise.\n\nSecond, I understand the reason for the workaround, but just a naive query or moreover a doubt that shall this be added as \"NOTE\" in comment or \"TODO\" as in near future we need to fix it somehow. \nPlease correct me if my understanding is wrong.\nThanks 😊","commit_id":"79f8cc0c79ec575d500b5b55ea6e645294ca84e1"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"1ed194fd0bfd783e53720754bbeb99817820b955","unresolved":true,"context_lines":[{"line_number":595,"context_line":"        # NOTE: The `project_id` is not included in attr_info, but it is used"},{"line_number":596,"context_line":"        # as an alternative of `tenant_id` which is already deprecated in"},{"line_number":597,"context_line":"        # oslo.context. Excluding `project_id` from the verification is a"},{"line_number":598,"context_line":"        # workaround to avoid directly modifying attr_info which has a strong"},{"line_number":599,"context_line":"        # influence on the existing code."},{"line_number":600,"context_line":"        excluded \u003d {\u0027project_id\u0027}"},{"line_number":601,"context_line":"        extra_keys \u003d set(res_dict.keys()) - set(attr_info.keys()) - excluded"}],"source_content_type":"text/x-python","patch_set":10,"id":"11e63879_3fff4759","line":598,"range":{"start_line":598,"start_character":10,"end_line":598,"end_character":20},"in_reply_to":"0ecfc9c0_758a1dcc","updated":"2022-06-03 01:48:18.000000000","message":"Thank you for your comments.\n\nI agree with that, but I\u0027d like to discuss a little bit.\n\nFirst comment:\nI removed my name intentionally because I wondered if we should continue this habit or not. This is not listed in OpenStack coding style guide [1], and we can see who wrote a Note by `git blame` easily. This is trivial matter, but better to be consistent rule. What do you think?\n\nSecond comment:\nI thought about it again and decided to use TODO as the other developers can decide whether to implement TODO or not.\nI tried to change to project_id without a workaround, but it resulted in a lot of modification [2]. Then, I though we don\u0027t need to make such a huge impact on the existing code just for changing policy file format, but another developer can find the way to do this safely and effectively in the future.\n\n[1] https://docs.openstack.org/hacking/latest/user/hacking.html\n[2] https://review.opendev.org/c/openstack/tacker/+/842903/6","commit_id":"79f8cc0c79ec575d500b5b55ea6e645294ca84e1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b365ff86d72db772ef0a72f10ac6741d53b8ce1a","unresolved":false,"context_lines":[{"line_number":595,"context_line":"        # NOTE: The `project_id` is not included in attr_info, but it is used"},{"line_number":596,"context_line":"        # as an alternative of `tenant_id` which is already deprecated in"},{"line_number":597,"context_line":"        # oslo.context. Excluding `project_id` from the verification is a"},{"line_number":598,"context_line":"        # workaround to avoid directly modifying attr_info which has a strong"},{"line_number":599,"context_line":"        # influence on the existing code."},{"line_number":600,"context_line":"        excluded \u003d {\u0027project_id\u0027}"},{"line_number":601,"context_line":"        extra_keys \u003d set(res_dict.keys()) - set(attr_info.keys()) - excluded"}],"source_content_type":"text/x-python","patch_set":10,"id":"bd3541ad_0d84d464","line":598,"range":{"start_line":598,"start_character":10,"end_line":598,"end_character":20},"in_reply_to":"11e63879_3fff4759","updated":"2022-06-03 10:15:12.000000000","message":"Thank you for quick rework. I have verified the same.\n\nThanks for sharing your insight.\nAgree with your suggestion to use \u0027git blame\u0027 to find out author of \u0027Note\u0027. But yes I don\u0027t find any harm in appending name to \u0027Note\u0027, as its help in quick review. But again both the methods looks fine to me 😊","commit_id":"79f8cc0c79ec575d500b5b55ea6e645294ca84e1"}]}