)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"4ac3b667348c5cc1cebc6bce0c10ebe950b38863","unresolved":true,"context_lines":[{"line_number":20,"context_line":"   the startup phase."},{"line_number":21,"context_line":"3. Added the type of exceptions caught by the"},{"line_number":22,"context_line":"   _init_commander_and_send_install_scripts function."},{"line_number":23,"context_line":"4. Change the scale_stack_id to scale_out_id_list uniformly."},{"line_number":24,"context_line":"5. Add modify_information_start and modify_information_end to"},{"line_number":25,"context_line":"   Mgmt Driver."},{"line_number":26,"context_line":"6. When using the Mgmt Driver to modify the content of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e92a42b7_3e05f31d","line":23,"updated":"2022-07-04 08:47:32.000000000","message":"Could you elaborate on this a little bit more?\n\nIf my comment at tacker/vnflcm/vnflcm_driver.py l.987 is correct, it\u0027s better to mention that \"you change the scale_stack_id to scale_out_id_list uniformly to solve the parameter mismatch between the input values for mgmt_drvier in vnflcm_driver and mgmt_driver.\"","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"5dcfbec6ad1ad008ff2ae78aec5a8b05af968373","unresolved":false,"context_lines":[{"line_number":20,"context_line":"   the startup phase."},{"line_number":21,"context_line":"3. Added the type of exceptions caught by the"},{"line_number":22,"context_line":"   _init_commander_and_send_install_scripts function."},{"line_number":23,"context_line":"4. Change the scale_stack_id to scale_out_id_list uniformly."},{"line_number":24,"context_line":"5. Add modify_information_start and modify_information_end to"},{"line_number":25,"context_line":"   Mgmt Driver."},{"line_number":26,"context_line":"6. When using the Mgmt Driver to modify the content of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"15fb869c_53271a51","line":23,"in_reply_to":"01ff3c4b_32f3346a","updated":"2022-08-29 09:54:32.000000000","message":"Done","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3e076b9a4ecc7b5542e99b464a1012c74be99f51","unresolved":true,"context_lines":[{"line_number":20,"context_line":"   the startup phase."},{"line_number":21,"context_line":"3. Added the type of exceptions caught by the"},{"line_number":22,"context_line":"   _init_commander_and_send_install_scripts function."},{"line_number":23,"context_line":"4. Change the scale_stack_id to scale_out_id_list uniformly."},{"line_number":24,"context_line":"5. Add modify_information_start and modify_information_end to"},{"line_number":25,"context_line":"   Mgmt Driver."},{"line_number":26,"context_line":"6. When using the Mgmt Driver to modify the content of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"01ff3c4b_32f3346a","line":23,"in_reply_to":"e92a42b7_3e05f31d","updated":"2022-07-27 07:09:36.000000000","message":"I append this part of the description.","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b7b7f2e22599ab1c0f961b871f542fac1a0f5e8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c64631ce_af82bd02","updated":"2022-06-06 09:34:17.000000000","message":"Thanks for your patch, please kindly check my comment.","commit_id":"51f5f8f411f8517a16040a22865af8c178a4bc9c"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"4ac3b667348c5cc1cebc6bce0c10ebe950b38863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ffdf40e_c731d1d3","updated":"2022-07-04 08:47:32.000000000","message":"Thank you for the patch.\n\nPlease kindly find my comments.","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5a84e8946a4b9feb4361513e1b0c567e722c24d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58934924_b4756273","updated":"2022-06-10 06:56:35.000000000","message":"Thanks for your rework, please kindly check additional comment.","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"8081f8ac2cf071d3513a6ac629c4378fe878f516","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6f751f37_9d8456dc","updated":"2022-07-28 00:42:20.000000000","message":"recheck","commit_id":"cc37de1a976b8f7da6d8a0b2d300fae173a561e4"},{"author":{"_account_id":35252,"name":"Branko Vukmirovic","display_name":"Branko Vukmirovic bRANe","email":"vukmirovicbrane@gmail.com","username":"rastabrane","status":"IT"},"change_message_id":"0a82bdf692550733ec662e3552efd2e8682e67b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"849064f9_a303e824","updated":"2022-09-05 15:10:25.000000000","message":"❤️","commit_id":"9d5a84c2fdd47cf7324569275b96395ae367a1f4"}],"samples/mgmt_driver/kubernetes/kubespray/cnf_nodeport_setting/cnf_nodeport_mgmt.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b7b7f2e22599ab1c0f961b871f542fac1a0f5e8a","unresolved":true,"context_lines":[{"line_number":362,"context_line":"            grant_request, **kwargs):"},{"line_number":363,"context_line":"        pass"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @log.log"},{"line_number":366,"context_line":"    def modify_information_start(self, context, vnf_instance,"},{"line_number":367,"context_line":"                                 modify_vnf_request, **kwargs):"},{"line_number":368,"context_line":"        pass"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @log.log"},{"line_number":371,"context_line":"    def modify_information_end(self, context, vnf_instance,"},{"line_number":372,"context_line":"                               modify_vnf_request, **kwargs):"},{"line_number":373,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"bdb5a8f7_bf187c8e","line":373,"range":{"start_line":365,"start_character":0,"end_line":373,"end_character":12},"updated":"2022-06-06 09:34:17.000000000","message":"Do you need to add these missing functions to other mgmtDriver samples too?\nFor example, mgmtDriver used in free5gc sample.\nhttps://opendev.org/openstack/tacker/src/branch/master/samples/free5gc","commit_id":"51f5f8f411f8517a16040a22865af8c178a4bc9c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c34e73c861e59cc5a1ef70c229ba3fc0db768698","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            grant_request, **kwargs):"},{"line_number":363,"context_line":"        pass"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @log.log"},{"line_number":366,"context_line":"    def modify_information_start(self, context, vnf_instance,"},{"line_number":367,"context_line":"                                 modify_vnf_request, **kwargs):"},{"line_number":368,"context_line":"        pass"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @log.log"},{"line_number":371,"context_line":"    def modify_information_end(self, context, vnf_instance,"},{"line_number":372,"context_line":"                               modify_vnf_request, **kwargs):"},{"line_number":373,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"ab80061b_fe189844","line":373,"range":{"start_line":365,"start_character":0,"end_line":373,"end_character":12},"in_reply_to":"464a0b63_d525fa93","updated":"2022-06-13 04:11:05.000000000","message":"Thanks for your answer, I missed it.","commit_id":"51f5f8f411f8517a16040a22865af8c178a4bc9c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5a84e8946a4b9feb4361513e1b0c567e722c24d8","unresolved":true,"context_lines":[{"line_number":362,"context_line":"            grant_request, **kwargs):"},{"line_number":363,"context_line":"        pass"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @log.log"},{"line_number":366,"context_line":"    def modify_information_start(self, context, vnf_instance,"},{"line_number":367,"context_line":"                                 modify_vnf_request, **kwargs):"},{"line_number":368,"context_line":"        pass"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @log.log"},{"line_number":371,"context_line":"    def modify_information_end(self, context, vnf_instance,"},{"line_number":372,"context_line":"                               modify_vnf_request, **kwargs):"},{"line_number":373,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"d55de648_af25d73b","line":373,"range":{"start_line":365,"start_character":0,"end_line":373,"end_character":12},"in_reply_to":"5f7b76d8_4bc4675b","updated":"2022-06-10 06:56:35.000000000","message":"It doesn\u0027t seem to be in the following file too, could you add it?\n\n* https://opendev.org/openstack/tacker/src/branch/master/samples/mgmt_driver/kubernetes/container_update/container_update_mgmt.py#L400","commit_id":"51f5f8f411f8517a16040a22865af8c178a4bc9c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"88735db22425209a1fd4f1c5e131aa47c3389425","unresolved":true,"context_lines":[{"line_number":362,"context_line":"            grant_request, **kwargs):"},{"line_number":363,"context_line":"        pass"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @log.log"},{"line_number":366,"context_line":"    def modify_information_start(self, context, vnf_instance,"},{"line_number":367,"context_line":"                                 modify_vnf_request, **kwargs):"},{"line_number":368,"context_line":"        pass"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @log.log"},{"line_number":371,"context_line":"    def modify_information_end(self, context, vnf_instance,"},{"line_number":372,"context_line":"                               modify_vnf_request, **kwargs):"},{"line_number":373,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7b76d8_4bc4675b","line":373,"range":{"start_line":365,"start_character":0,"end_line":373,"end_character":12},"in_reply_to":"bdb5a8f7_bf187c8e","updated":"2022-06-07 02:14:36.000000000","message":"I added ``modify_information_start`` and ``modify_information_end`` to the Mgmt Drivers in this directory.","commit_id":"51f5f8f411f8517a16040a22865af8c178a4bc9c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c3ae7fc05aa47a9364c798f1bba30d793ecff3e8","unresolved":true,"context_lines":[{"line_number":362,"context_line":"            grant_request, **kwargs):"},{"line_number":363,"context_line":"        pass"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @log.log"},{"line_number":366,"context_line":"    def modify_information_start(self, context, vnf_instance,"},{"line_number":367,"context_line":"                                 modify_vnf_request, **kwargs):"},{"line_number":368,"context_line":"        pass"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @log.log"},{"line_number":371,"context_line":"    def modify_information_end(self, context, vnf_instance,"},{"line_number":372,"context_line":"                               modify_vnf_request, **kwargs):"},{"line_number":373,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"464a0b63_d525fa93","line":373,"range":{"start_line":365,"start_character":0,"end_line":373,"end_character":12},"in_reply_to":"d55de648_af25d73b","updated":"2022-06-13 03:00:55.000000000","message":"This file already exists these 2 functions.\n\n* https://opendev.org/openstack/tacker/src/branch/master/samples/mgmt_driver/kubernetes/container_update/container_update_mgmt.py#L54\n\n* https://opendev.org/openstack/tacker/src/branch/master/samples/mgmt_driver/kubernetes/container_update/container_update_mgmt.py#L177","commit_id":"51f5f8f411f8517a16040a22865af8c178a4bc9c"}],"samples/mgmt_driver/kubernetes/kubespray/cnf_nodeport_setting/configure_lb.sh":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"501fd667a628aaebcdd7f3d060eb98b7e1222f68","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    done"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"function delete_haproxy_conf {"},{"line_number":97,"context_line":"    for(( i\u003d0;i\u003c${#NODEPORTS[@]};i++)); do"},{"line_number":98,"context_line":"        split_node_port\u003d(${NODEPORTS[i]//,/ })"},{"line_number":99,"context_line":"        start_str\u003d${split_node_port[0]}_${split_node_port[1]}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"22fdbe23_20577329","line":96,"updated":"2022-07-01 07:32:15.000000000","message":"Could you add a short note what is done in this function? It\u0027s hard to understand what was wrong and what should be fixed in this patch for me, and also users of the example possibly.","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3e076b9a4ecc7b5542e99b464a1012c74be99f51","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    done"},{"line_number":94,"context_line":"}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"function delete_haproxy_conf {"},{"line_number":97,"context_line":"    for(( i\u003d0;i\u003c${#NODEPORTS[@]};i++)); do"},{"line_number":98,"context_line":"        split_node_port\u003d(${NODEPORTS[i]//,/ })"},{"line_number":99,"context_line":"        start_str\u003d${split_node_port[0]}_${split_node_port[1]}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bb2be6a0_88e4424c","line":96,"in_reply_to":"22fdbe23_20577329","updated":"2022-07-27 07:09:36.000000000","message":"I append a comment above the function.","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b7b7f2e22599ab1c0f961b871f542fac1a0f5e8a","unresolved":true,"context_lines":[{"line_number":1052,"context_line":"                # This part will be updated in next release."},{"line_number":1053,"context_line":"                if len(id_list) !\u003d 0 or \\"},{"line_number":1054,"context_line":"                        vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":1055,"context_line":"                    kwargs \u003d {\u0027scale_out_id_list\u0027: id_list,"},{"line_number":1056,"context_line":"                              \u0027scale_stack_id\u0027: id_list,"},{"line_number":1057,"context_line":"                              \u0027vnf\u0027: copy.deepcopy(vnf_info)}"},{"line_number":1058,"context_line":"                    self._mgmt_manager.invoke("},{"line_number":1059,"context_line":"                        self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":1,"id":"e7b07f0b_308daa94","line":1056,"range":{"start_line":1055,"start_character":30,"end_line":1056,"end_character":56},"updated":"2022-06-06 09:34:17.000000000","message":"Why don\u0027t you unify to only one of them because the both are same value `id_list`?\n\nNote that if you want to unify to `scale_out_id_list`, you may also need to modify:\n* `scale_stack_id` used in _scale_vnf_pre() method [1]\n* `scale_stack_id` used in sample ansible driver [2]\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/vnflcm/vnflcm_driver.py#L987\n[2] https://opendev.org/openstack/tacker/src/branch/master/samples/mgmt_driver/ansible/ansible_driver.py#L199","commit_id":"51f5f8f411f8517a16040a22865af8c178a4bc9c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5a84e8946a4b9feb4361513e1b0c567e722c24d8","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"                # This part will be updated in next release."},{"line_number":1053,"context_line":"                if len(id_list) !\u003d 0 or \\"},{"line_number":1054,"context_line":"                        vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":1055,"context_line":"                    kwargs \u003d {\u0027scale_out_id_list\u0027: id_list,"},{"line_number":1056,"context_line":"                              \u0027scale_stack_id\u0027: id_list,"},{"line_number":1057,"context_line":"                              \u0027vnf\u0027: copy.deepcopy(vnf_info)}"},{"line_number":1058,"context_line":"                    self._mgmt_manager.invoke("},{"line_number":1059,"context_line":"                        self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":1,"id":"1dcb1368_dc438e12","line":1056,"range":{"start_line":1055,"start_character":30,"end_line":1056,"end_character":56},"in_reply_to":"2c35bc3d_dad40fc3","updated":"2022-06-10 06:56:35.000000000","message":"Ack","commit_id":"51f5f8f411f8517a16040a22865af8c178a4bc9c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"88735db22425209a1fd4f1c5e131aa47c3389425","unresolved":true,"context_lines":[{"line_number":1052,"context_line":"                # This part will be updated in next release."},{"line_number":1053,"context_line":"                if len(id_list) !\u003d 0 or \\"},{"line_number":1054,"context_line":"                        vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":1055,"context_line":"                    kwargs \u003d {\u0027scale_out_id_list\u0027: id_list,"},{"line_number":1056,"context_line":"                              \u0027scale_stack_id\u0027: id_list,"},{"line_number":1057,"context_line":"                              \u0027vnf\u0027: copy.deepcopy(vnf_info)}"},{"line_number":1058,"context_line":"                    self._mgmt_manager.invoke("},{"line_number":1059,"context_line":"                        self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":1,"id":"2c35bc3d_dad40fc3","line":1056,"range":{"start_line":1055,"start_character":30,"end_line":1056,"end_character":56},"in_reply_to":"e7b07f0b_308daa94","updated":"2022-06-07 02:14:36.000000000","message":"I changed ``scale_stack_id`` to ``scale_out_id_list`` uniformly.","commit_id":"51f5f8f411f8517a16040a22865af8c178a4bc9c"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"4ac3b667348c5cc1cebc6bce0c10ebe950b38863","unresolved":true,"context_lines":[{"line_number":984,"context_line":"                if len(scale_id_list) !\u003d 0 or \\"},{"line_number":985,"context_line":"                        vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":986,"context_line":"                    kwargs \u003d {\u0027scale_name_list\u0027: scale_name_list,"},{"line_number":987,"context_line":"                              \u0027scale_out_id_list\u0027: scale_id_list,"},{"line_number":988,"context_line":"                              \u0027vnf\u0027: copy.deepcopy(vnf_info)}"},{"line_number":989,"context_line":"                    self._mgmt_manager.invoke("},{"line_number":990,"context_line":"                        self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":2,"id":"29ebe6e5_46609781","line":987,"updated":"2022-07-04 08:47:32.000000000","message":"Looks like this kwargs has the dependency between vnflcm_driver and mgmt_drvier(s). If so, I think it\u0027s better to add a helper method to generate the ``kwargs``, at least a note is needed to make other developers aware of this dependency.\nIf my understanding is wrong, please ignore the above.","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3e076b9a4ecc7b5542e99b464a1012c74be99f51","unresolved":true,"context_lines":[{"line_number":984,"context_line":"                if len(scale_id_list) !\u003d 0 or \\"},{"line_number":985,"context_line":"                        vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":986,"context_line":"                    kwargs \u003d {\u0027scale_name_list\u0027: scale_name_list,"},{"line_number":987,"context_line":"                              \u0027scale_out_id_list\u0027: scale_id_list,"},{"line_number":988,"context_line":"                              \u0027vnf\u0027: copy.deepcopy(vnf_info)}"},{"line_number":989,"context_line":"                    self._mgmt_manager.invoke("},{"line_number":990,"context_line":"                        self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":2,"id":"469879d4_065a42a0","line":987,"in_reply_to":"29ebe6e5_46609781","updated":"2022-07-27 07:09:36.000000000","message":"I have commented before the code that creates the kwargs.","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6483cd74fb89b8ab29569b75d435dc71b0bba2bd","unresolved":true,"context_lines":[{"line_number":984,"context_line":"                if len(scale_id_list) !\u003d 0 or \\"},{"line_number":985,"context_line":"                        vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":986,"context_line":"                    kwargs \u003d {\u0027scale_name_list\u0027: scale_name_list,"},{"line_number":987,"context_line":"                              \u0027scale_out_id_list\u0027: scale_id_list,"},{"line_number":988,"context_line":"                              \u0027vnf\u0027: copy.deepcopy(vnf_info)}"},{"line_number":989,"context_line":"                    self._mgmt_manager.invoke("},{"line_number":990,"context_line":"                        self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":2,"id":"7c138f98_563029f7","line":987,"in_reply_to":"469879d4_065a42a0","updated":"2022-08-29 02:58:18.000000000","message":"How about you add `NOTE` to comment you added?\n\u003e # NOTE(xxx):","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"5dcfbec6ad1ad008ff2ae78aec5a8b05af968373","unresolved":true,"context_lines":[{"line_number":984,"context_line":"                if len(scale_id_list) !\u003d 0 or \\"},{"line_number":985,"context_line":"                        vim_connection_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":986,"context_line":"                    kwargs \u003d {\u0027scale_name_list\u0027: scale_name_list,"},{"line_number":987,"context_line":"                              \u0027scale_out_id_list\u0027: scale_id_list,"},{"line_number":988,"context_line":"                              \u0027vnf\u0027: copy.deepcopy(vnf_info)}"},{"line_number":989,"context_line":"                    self._mgmt_manager.invoke("},{"line_number":990,"context_line":"                        self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":2,"id":"fc9804de_2b3eca81","line":987,"in_reply_to":"7c138f98_563029f7","updated":"2022-08-29 09:54:32.000000000","message":"agree with Ueha-san\u0027s comment","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"}],"tacker/vnfm/mgmt_drivers/constants.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"4ac3b667348c5cc1cebc6bce0c10ebe950b38863","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# key"},{"line_number":18,"context_line":"KEY_ACTION \u003d \u0027action\u0027"},{"line_number":19,"context_line":"KEY_KWARGS \u003d \u0027kwargs\u0027"},{"line_number":20,"context_line":"KEY_SCALE \u003d \u0027scale_out_id_list\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# ACTION type"},{"line_number":23,"context_line":"ACTION_CREATE_VNF \u003d \u0027create_vnf\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"a310057c_e3851403","line":20,"updated":"2022-07-04 08:47:32.000000000","message":"just a question. Where is this constant used?","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"5dcfbec6ad1ad008ff2ae78aec5a8b05af968373","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# key"},{"line_number":18,"context_line":"KEY_ACTION \u003d \u0027action\u0027"},{"line_number":19,"context_line":"KEY_KWARGS \u003d \u0027kwargs\u0027"},{"line_number":20,"context_line":"KEY_SCALE \u003d \u0027scale_out_id_list\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# ACTION type"},{"line_number":23,"context_line":"ACTION_CREATE_VNF \u003d \u0027create_vnf\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"71462517_457f0a0b","line":20,"in_reply_to":"14ad19f6_5172221a","updated":"2022-08-29 09:54:32.000000000","message":"Done","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3e076b9a4ecc7b5542e99b464a1012c74be99f51","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# key"},{"line_number":18,"context_line":"KEY_ACTION \u003d \u0027action\u0027"},{"line_number":19,"context_line":"KEY_KWARGS \u003d \u0027kwargs\u0027"},{"line_number":20,"context_line":"KEY_SCALE \u003d \u0027scale_out_id_list\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# ACTION type"},{"line_number":23,"context_line":"ACTION_CREATE_VNF \u003d \u0027create_vnf\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"14ad19f6_5172221a","line":20,"in_reply_to":"a310057c_e3851403","updated":"2022-07-27 07:09:36.000000000","message":"The code here is not used by others.\nBecause there is also ``scale_stack_id`` here, so I modified it together.","commit_id":"5c4f832f0b49bf350f5d912cb47e857dc7ade907"}]}
