)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"72f0a2a9d7415fb0a3951480fa9583710f00b757","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e79d325f_ced31934","updated":"2022-06-27 21:21:39.000000000","message":"I agree with Manpreet that we \u0027d better to have some more improvement for the fix.","commit_id":"2e6f0f0412d5be0ce5cb60f9d894caa94f03a693"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"4f84002120ecdedc7b4adb8a7d699d1e8e595c70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c1bd7f6_8485f2f9","updated":"2022-06-16 05:20:16.000000000","message":"Thanks for your patch, if possible could you please add test case for the same. In case its difficult or not possible please share your opinion.","commit_id":"2e6f0f0412d5be0ce5cb60f9d894caa94f03a693"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"72f0a2a9d7415fb0a3951480fa9583710f00b757","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e24a806_fd2674a6","in_reply_to":"2da2f265_1eac9755","updated":"2022-06-27 21:21:39.000000000","message":"Hmm... As an our basic strategy, we don\u0027t take care for such a script local function with a test as we agreed while discussing UT coverage before. In addition for the fix, I don\u0027t have any idea how we test.\n\nIMO, the reason why we made the mistake is we didn\u0027t notice there are some params require underscore in k8s manifest. So, what do you think to introduce a list as a const to become obvious for maintainers? I think it might be enough without introducing a test and helpful for possible future update for the params.","commit_id":"2e6f0f0412d5be0ce5cb60f9d894caa94f03a693"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"5302eace2cdb7cd9348ef6be287f6b70895aa570","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6371a551_2f930100","in_reply_to":"3e24a806_fd2674a6","updated":"2022-07-04 06:51:24.000000000","message":"Thank you for your comments. I agree with Yasufumi Ogawa. We have tested this modification in the local environment, and the problem can be fixed. But for this small point, and then add automatic test items, I think there is no substantial effect. And if there is an update in the later K8S version, the test items need to be maintained again. So I modified the implementation, put these parameters in constants, and the constant is explained to facilitate the maintenance of developers later.","commit_id":"2e6f0f0412d5be0ce5cb60f9d894caa94f03a693"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"351db0889319070798132f1aa56c9cedb13b0d66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2da2f265_1eac9755","in_reply_to":"5b829c56_1b22d254","updated":"2022-06-17 09:40:08.000000000","message":"Either way, it helps in test coverage. If UT/FT is not possible, IMO, then a test scenario tested in local env with logs could be added for reference.","commit_id":"2e6f0f0412d5be0ce5cb60f9d894caa94f03a693"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9a59e85f7c3fe0246559ae7be10ad56ef022f2d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b829c56_1b22d254","in_reply_to":"7c1bd7f6_8485f2f9","updated":"2022-06-17 08:57:06.000000000","message":"manpreet: Do you mean add a dedicated test for the private function, or test it in any other way?","commit_id":"2e6f0f0412d5be0ce5cb60f9d894caa94f03a693"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a85350f93e19cadcfda4da11e319423d00eea17e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"39fe4f1e_b4abc5af","updated":"2022-07-07 02:33:19.000000000","message":"LGTM, thanks!","commit_id":"6441914c5fa46c12b16e5545956f5a0494f07874"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b11580ec2deb7f8a0a7b38750f3d6b7706a73347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4027364_8e0c00f0","updated":"2022-07-04 07:15:32.000000000","message":"Thanks for rework. LGTM!\nThank you, Ogawa san for sharing the insight and suggestion. \nShuwen Cai your proposal looks good to me, the constant list will be helpful in code maintenance.","commit_id":"6441914c5fa46c12b16e5545956f5a0494f07874"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d247a749a8a948d0ac852cfd3fb51e1e144b7430","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f28010f2_c231185c","updated":"2022-07-04 12:37:13.000000000","message":"Thanks for your patch, LGTM.","commit_id":"6441914c5fa46c12b16e5545956f5a0494f07874"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"5302eace2cdb7cd9348ef6be287f6b70895aa570","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd15a72a_d64f0f27","updated":"2022-07-04 06:51:24.000000000","message":"To Manpreet Kaur and Yasufumi Ogawa:\nThank you for your comments. I fixed them in PS2.\nplease kindly check it again.","commit_id":"6441914c5fa46c12b16e5545956f5a0494f07874"}]}