)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"cb8e5675217c38654e523d63064c5bae9212dedc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Error log generated after instantiation fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Error logs were not generated when an error"},{"line_number":10,"context_line":"occurred in the status update process of"},{"line_number":11,"context_line":"Instantiation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implemented logging in exception block of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6552ff99_d20aa27f","line":10,"range":{"start_line":9,"start_character":30,"end_line":10,"end_character":37},"updated":"2022-08-04 04:46:38.000000000","message":"What is the difference from the Exeption issued in following patch?\n\nhttps://review.opendev.org/c/openstack/tacker/+/851508","commit_id":"6e71d37210c75ee3d3bae8e11c28ba6a36544fd0"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"95cff651302d82ef2a9c28407a513bdf98bf8d3b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Error log generated after instantiation fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Error logs were not generated when an error"},{"line_number":10,"context_line":"occurred in the status update process of"},{"line_number":11,"context_line":"Instantiation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implemented logging in exception block of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0ca52d84_84391685","line":10,"range":{"start_line":9,"start_character":30,"end_line":10,"end_character":37},"in_reply_to":"16e01464_5450869b","updated":"2022-08-08 08:15:13.000000000","message":"Updated the commit message","commit_id":"6e71d37210c75ee3d3bae8e11c28ba6a36544fd0"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"61274ba786c6922573bbafc322fb1dea99674cfd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Error log generated after instantiation fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Error logs were not generated when an error"},{"line_number":10,"context_line":"occurred in the status update process of"},{"line_number":11,"context_line":"Instantiation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implemented logging in exception block of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"16e01464_5450869b","line":10,"range":{"start_line":9,"start_character":30,"end_line":10,"end_character":37},"in_reply_to":"2c3f8dc8_cf47361f","updated":"2022-08-08 06:22:06.000000000","message":"I understood it, but I think wrong commit message at highlight.\nIs `status update process` necessary?\n\n```\nError logs were not generated when an error occurred in the process of Instantiation.\n```","commit_id":"6e71d37210c75ee3d3bae8e11c28ba6a36544fd0"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"3e8a5e8ef52b00385a990e783ea3459ad4a233d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Error log generated after instantiation fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Error logs were not generated when an error"},{"line_number":10,"context_line":"occurred in the status update process of"},{"line_number":11,"context_line":"Instantiation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implemented logging in exception block of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2c3f8dc8_cf47361f","line":10,"range":{"start_line":9,"start_character":30,"end_line":10,"end_character":37},"in_reply_to":"6552ff99_d20aa27f","updated":"2022-08-04 10:48:40.000000000","message":"In this patch debug error logs are added when exception occurs in instantiation operation. Currently when exception is generated during instantiation process then no logs are printed in tacker conductor logs. \n\nHowever, in patch https://review.opendev.org/c/openstack/tacker/+/851508 exception handling is done when exception occurs in exception block.","commit_id":"6e71d37210c75ee3d3bae8e11c28ba6a36544fd0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"6ac2bcd9ba874f916f83b587a91073faa072f2a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4cb1e6f3_dafedcd9","updated":"2022-08-09 08:12:31.000000000","message":"recheck","commit_id":"d0eed05b251b0afe8054a4bd93ce8eae3de07647"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b69d4f7f876d1a341802ee9ebf6baea2038f28cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"01ad028b_91cdf3bf","updated":"2022-08-24 05:44:45.000000000","message":"Thanks for your patch. Please find comment.","commit_id":"8acf756e54634fdd21f04f478ff3dd789d9d3999"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0b67abe29894b1bf23b19b1c92a4d62cf33615a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5b2fb1ff_7365645f","updated":"2022-09-02 00:10:23.000000000","message":"LGTM","commit_id":"d4ff8e02ae99bde3a199fca269c54018d8d2424b"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"8a947ad11b29fee9868468386388ebf76e7ffeee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4aada267_a5c825f8","updated":"2022-08-30 01:52:21.000000000","message":"LGTM!","commit_id":"d4ff8e02ae99bde3a199fca269c54018d8d2424b"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b69d4f7f876d1a341802ee9ebf6baea2038f28cc","unresolved":true,"context_lines":[{"line_number":2003,"context_line":"            LOG.debug(\"Exception occured in instantiation because of {}\"."},{"line_number":2004,"context_line":"                format(encodeutils.exception_to_unicode(ex)))"},{"line_number":2005,"context_line":"            exc_type, exc_value, exc_traceback \u003d sys.exc_info()"},{"line_number":2006,"context_line":"            LOG.debug(str(traceback.format_exception(exc_type, exc_value,"},{"line_number":2007,"context_line":"                exc_traceback)))"},{"line_number":2008,"context_line":"            self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2009,"context_line":"                                    constants.ALL_STATUSES, \u0027ERROR\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"55ff958b_b7b2c094","line":2006,"range":{"start_line":2006,"start_character":27,"end_line":2006,"end_character":52},"updated":"2022-08-24 05:44:45.000000000","message":"As the patch adds debug messages for exception, so the test coverage might not be feasible (I might be wrong here). But would like to know how to validate or ensure that such functions used in \"traceback.format_exception\" debug message are printing correct message in logs.","commit_id":"8acf756e54634fdd21f04f478ff3dd789d9d3999"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e8a6c9b8efa8eb33f1e27bb84537ed20b8ec1815","unresolved":true,"context_lines":[{"line_number":2003,"context_line":"            LOG.warning(traceback.format_exc())"},{"line_number":2004,"context_line":"            LOG.warning(\"Exception occured in instantiation for vnf \""},{"line_number":2005,"context_line":"                        \"instance %(id)s. Error: %(error)s\","},{"line_number":2006,"context_line":"                        {\"id\": vnf_instance.id, \"error\": ex})"},{"line_number":2007,"context_line":"            self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2008,"context_line":"                                    constants.ALL_STATUSES, \u0027ERROR\u0027)"},{"line_number":2009,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fb97d272_a0c6a860","line":2006,"updated":"2022-09-01 10:10:49.000000000","message":"Just a confirmation,\nI think you have modified other LCMs\u0027s the similar part of patch [1].\n\nDo you need to add the error log to other LCMs as well in the same way?\n(According to the bug report [2], it is a problem when vimConnectionInfo is not specified in Instantiate, so is it unnecessary?\n\n[1] https://review.opendev.org/c/openstack/tacker/+/851508\n[2] https://bugs.launchpad.net/tacker/+bug/1981183","commit_id":"d4ff8e02ae99bde3a199fca269c54018d8d2424b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0b67abe29894b1bf23b19b1c92a4d62cf33615a5","unresolved":false,"context_lines":[{"line_number":2003,"context_line":"            LOG.warning(traceback.format_exc())"},{"line_number":2004,"context_line":"            LOG.warning(\"Exception occured in instantiation for vnf \""},{"line_number":2005,"context_line":"                        \"instance %(id)s. Error: %(error)s\","},{"line_number":2006,"context_line":"                        {\"id\": vnf_instance.id, \"error\": ex})"},{"line_number":2007,"context_line":"            self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2008,"context_line":"                                    constants.ALL_STATUSES, \u0027ERROR\u0027)"},{"line_number":2009,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"99b57760_e290175d","line":2006,"in_reply_to":"cd63ed2d_c6bbe043","updated":"2022-09-02 00:10:23.000000000","message":"Thanks for your answer, I understand.","commit_id":"d4ff8e02ae99bde3a199fca269c54018d8d2424b"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"2ddee6f167a97aff97bf4545946983e1ed61c2e5","unresolved":false,"context_lines":[{"line_number":2003,"context_line":"            LOG.warning(traceback.format_exc())"},{"line_number":2004,"context_line":"            LOG.warning(\"Exception occured in instantiation for vnf \""},{"line_number":2005,"context_line":"                        \"instance %(id)s. Error: %(error)s\","},{"line_number":2006,"context_line":"                        {\"id\": vnf_instance.id, \"error\": ex})"},{"line_number":2007,"context_line":"            self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2008,"context_line":"                                    constants.ALL_STATUSES, \u0027ERROR\u0027)"},{"line_number":2009,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"cd63ed2d_c6bbe043","line":2006,"in_reply_to":"fb97d272_a0c6a860","updated":"2022-09-01 17:58:19.000000000","message":"This issue occurred only when vimConnectionInfo is not specified in instantiation json.","commit_id":"d4ff8e02ae99bde3a199fca269c54018d8d2424b"}]}