)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"9c139c6ae884078e0737e0f0a00f612e3ee1ef3c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"When exception occurs in exception block during the instantiation"},{"line_number":10,"context_line":"process then notification was not sent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implemented exception handling in exception block of instantiation process."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1983096"},{"line_number":15,"context_line":"Change-Id: I645e342167d22ac3764cdb20ef1a0f77f801fb95"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f9fb6cea_9e9f1138","line":12,"updated":"2022-08-02 10:46:47.000000000","message":"Please keep it within 72 chars.","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"453f33f39c08ba3ef78cd56874a9cd50f4f989dd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When exception occurs in exception block during the instantiation"},{"line_number":10,"context_line":"process then notification was not sent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implemented exception handling in exception block of instantiation process."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1983096"},{"line_number":15,"context_line":"Change-Id: I645e342167d22ac3764cdb20ef1a0f77f801fb95"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"037ac932_98b7bb79","line":12,"in_reply_to":"f9fb6cea_9e9f1138","updated":"2022-08-09 15:58:24.000000000","message":"Done","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"9c139c6ae884078e0737e0f0a00f612e3ee1ef3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"63ee54ee_26e137a0","updated":"2022-08-02 10:46:47.000000000","message":"Thank you for your works.","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"33b2467bfca77badb4c3c8b2ca85dee55aa3f569","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e7d417c6_87845c49","updated":"2022-09-01 05:02:38.000000000","message":"Thanks for your patch. LGTM!","commit_id":"3500bfd1738a2e68bfab23f9afaffe2800643c5c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85e6aa9c73f3ee731f5619fe78e6bb067cf7699b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"71ebe934_30427cc9","updated":"2022-09-01 09:53:05.000000000","message":"Thanks for your rework, LGTM.","commit_id":"3500bfd1738a2e68bfab23f9afaffe2800643c5c"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"673edc6eed622cda5303319f69c65fbc57422bc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3e8db394_afa5b715","updated":"2022-09-05 07:29:01.000000000","message":"Fixed merge conflict","commit_id":"3bdb71c8123b8400c62406d168d852b586f0544b"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"9c139c6ae884078e0737e0f0a00f612e3ee1ef3c","unresolved":true,"context_lines":[{"line_number":1744,"context_line":"                        or operation_state \u003d\u003d \\"},{"line_number":1745,"context_line":"                        fields.LcmOccsOperationState.FAILED:"},{"line_number":1746,"context_line":"                    notification_data[\u0027error\u0027] \u003d error"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"        except Exception as ex:"},{"line_number":1749,"context_line":"            LOG.error(\"Error in getting resources for op id - {}.\\"},{"line_number":1750,"context_line":"                    Details: {}\".format(vnf_lcm_op_occs_id, str(ex)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b3d1b80_53280bb8","line":1747,"updated":"2022-08-02 10:46:47.000000000","message":"Delete this line.","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"453f33f39c08ba3ef78cd56874a9cd50f4f989dd","unresolved":false,"context_lines":[{"line_number":1744,"context_line":"                        or operation_state \u003d\u003d \\"},{"line_number":1745,"context_line":"                        fields.LcmOccsOperationState.FAILED:"},{"line_number":1746,"context_line":"                    notification_data[\u0027error\u0027] \u003d error"},{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"        except Exception as ex:"},{"line_number":1749,"context_line":"            LOG.error(\"Error in getting resources for op id - {}.\\"},{"line_number":1750,"context_line":"                    Details: {}\".format(vnf_lcm_op_occs_id, str(ex)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ae19b400_d862a822","line":1747,"in_reply_to":"8b3d1b80_53280bb8","updated":"2022-08-09 15:58:24.000000000","message":"Done","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"9c139c6ae884078e0737e0f0a00f612e3ee1ef3c","unresolved":true,"context_lines":[{"line_number":1748,"context_line":"        except Exception as ex:"},{"line_number":1749,"context_line":"            LOG.error(\"Error in getting resources for op id - {}.\\"},{"line_number":1750,"context_line":"                    Details: {}\".format(vnf_lcm_op_occs_id, str(ex)))"},{"line_number":1751,"context_line":"        try:"},{"line_number":1752,"context_line":"            # send notification"},{"line_number":1753,"context_line":"            self.send_notification(context, notification_data)"},{"line_number":1754,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ab5014ab_147e7906","line":1751,"updated":"2022-08-02 10:46:47.000000000","message":"Add blank line.","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"453f33f39c08ba3ef78cd56874a9cd50f4f989dd","unresolved":false,"context_lines":[{"line_number":1748,"context_line":"        except Exception as ex:"},{"line_number":1749,"context_line":"            LOG.error(\"Error in getting resources for op id - {}.\\"},{"line_number":1750,"context_line":"                    Details: {}\".format(vnf_lcm_op_occs_id, str(ex)))"},{"line_number":1751,"context_line":"        try:"},{"line_number":1752,"context_line":"            # send notification"},{"line_number":1753,"context_line":"            self.send_notification(context, notification_data)"},{"line_number":1754,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":2,"id":"d0bf1907_d7ceb810","line":1751,"in_reply_to":"ab5014ab_147e7906","updated":"2022-08-09 15:58:24.000000000","message":"Done","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"9c139c6ae884078e0737e0f0a00f612e3ee1ef3c","unresolved":true,"context_lines":[{"line_number":2007,"context_line":"            try:"},{"line_number":2008,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2009,"context_line":"                                    constants.ALL_STATUSES, \u0027ERROR\u0027)"},{"line_number":2010,"context_line":"                self._build_instantiated_vnf_info(context, vnf_instance,"},{"line_number":2011,"context_line":"                    instantiate_vnf)"},{"line_number":2012,"context_line":"                self.vnflcm_driver._vnf_instance_update(context, vnf_instance,"},{"line_number":2013,"context_line":"                        task_state\u003dNone)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ee3868b_9b023ac4","line":2010,"updated":"2022-08-02 10:46:47.000000000","message":"Is this code the cause of this Issue?\nIf the other two are also the cause, I think it occurs in other LCMs as well.\n```\nself._change_vnf_status(context, vnf_instance.id, constants.ALL_STATUSES, \u0027ERROR\u0027)\nself.vnflcm_driver._vnf_instance_update(context, vnf_instance,\n```\n\nWhat do you think?","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"31403e6c8fa5a89a774ae270888623ca70d43bb2","unresolved":false,"context_lines":[{"line_number":2007,"context_line":"            try:"},{"line_number":2008,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2009,"context_line":"                                    constants.ALL_STATUSES, \u0027ERROR\u0027)"},{"line_number":2010,"context_line":"                self._build_instantiated_vnf_info(context, vnf_instance,"},{"line_number":2011,"context_line":"                    instantiate_vnf)"},{"line_number":2012,"context_line":"                self.vnflcm_driver._vnf_instance_update(context, vnf_instance,"},{"line_number":2013,"context_line":"                        task_state\u003dNone)"}],"source_content_type":"text/x-python","patch_set":2,"id":"77d4caf6_06a00c79","line":2010,"in_reply_to":"1f9442c4_50cfef5d","updated":"2022-08-30 16:03:00.000000000","message":"I have added the fix for heal, terminate and change external connectivity operations as well.","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"af542ec30ac468742b62369d3ed01a3ad56ad714","unresolved":true,"context_lines":[{"line_number":2007,"context_line":"            try:"},{"line_number":2008,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2009,"context_line":"                                    constants.ALL_STATUSES, \u0027ERROR\u0027)"},{"line_number":2010,"context_line":"                self._build_instantiated_vnf_info(context, vnf_instance,"},{"line_number":2011,"context_line":"                    instantiate_vnf)"},{"line_number":2012,"context_line":"                self.vnflcm_driver._vnf_instance_update(context, vnf_instance,"},{"line_number":2013,"context_line":"                        task_state\u003dNone)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f9442c4_50cfef5d","line":2010,"in_reply_to":"308a5e53_45c23a84","updated":"2022-08-29 05:53:53.000000000","message":"Do you need to do the same fixes for other LCMs that may have this issue?\nWhat do you think?","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85e6aa9c73f3ee731f5619fe78e6bb067cf7699b","unresolved":false,"context_lines":[{"line_number":2007,"context_line":"            try:"},{"line_number":2008,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2009,"context_line":"                                    constants.ALL_STATUSES, \u0027ERROR\u0027)"},{"line_number":2010,"context_line":"                self._build_instantiated_vnf_info(context, vnf_instance,"},{"line_number":2011,"context_line":"                    instantiate_vnf)"},{"line_number":2012,"context_line":"                self.vnflcm_driver._vnf_instance_update(context, vnf_instance,"},{"line_number":2013,"context_line":"                        task_state\u003dNone)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f080abbd_6e48741f","line":2010,"in_reply_to":"77d4caf6_06a00c79","updated":"2022-09-01 09:53:05.000000000","message":"I\u0027ve confirmed.","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"453f33f39c08ba3ef78cd56874a9cd50f4f989dd","unresolved":false,"context_lines":[{"line_number":2007,"context_line":"            try:"},{"line_number":2008,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2009,"context_line":"                                    constants.ALL_STATUSES, \u0027ERROR\u0027)"},{"line_number":2010,"context_line":"                self._build_instantiated_vnf_info(context, vnf_instance,"},{"line_number":2011,"context_line":"                    instantiate_vnf)"},{"line_number":2012,"context_line":"                self.vnflcm_driver._vnf_instance_update(context, vnf_instance,"},{"line_number":2013,"context_line":"                        task_state\u003dNone)"}],"source_content_type":"text/x-python","patch_set":2,"id":"308a5e53_45c23a84","line":2010,"in_reply_to":"7ee3868b_9b023ac4","updated":"2022-08-09 15:58:24.000000000","message":"The exception can occur in any of the three methods. Yes, this issue can occur in heal, terminate and change_ext_conn operations as well.","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"9c139c6ae884078e0737e0f0a00f612e3ee1ef3c","unresolved":true,"context_lines":[{"line_number":990,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":991,"context_line":"                                       flavour\u003dinstantiate_vnf_req.flavour_id)"},{"line_number":992,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":993,"context_line":"        m_vnf_lcm_subscriptions \u003d \\"},{"line_number":994,"context_line":"            [mock.MagicMock(**fakes.get_vnf_lcm_subscriptions())]"},{"line_number":995,"context_line":"        vnfd_key \u003d \u0027vnfd_\u0027 + instantiate_vnf_req.flavour_id"},{"line_number":996,"context_line":"        vnfd_yaml \u003d vnf_dict[\u0027vnfd\u0027][\u0027attributes\u0027].get(vnfd_key, \u0027\u0027)"},{"line_number":997,"context_line":"        mock_vnfd_dict.return_value \u003d yaml.safe_load(vnfd_yaml)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c341f800_2c2aa212","line":994,"range":{"start_line":993,"start_character":0,"end_line":994,"end_character":65},"updated":"2022-08-02 10:46:47.000000000","message":"Is this code nessesary?\nFor example, is the following merge with Line 999 problem?\n\n```\nmock_vnf_lcm_subscriptions_get.return_value \u003d \\\n    [mock.MagicMock(**fakes.get_vnf_lcm_subscriptions())]\n```","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"},{"author":{"_account_id":34346,"name":"Pooja Singla","email":"pooja.singla@india.nec.com","username":"psingla"},"change_message_id":"453f33f39c08ba3ef78cd56874a9cd50f4f989dd","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":991,"context_line":"                                       flavour\u003dinstantiate_vnf_req.flavour_id)"},{"line_number":992,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":993,"context_line":"        m_vnf_lcm_subscriptions \u003d \\"},{"line_number":994,"context_line":"            [mock.MagicMock(**fakes.get_vnf_lcm_subscriptions())]"},{"line_number":995,"context_line":"        vnfd_key \u003d \u0027vnfd_\u0027 + instantiate_vnf_req.flavour_id"},{"line_number":996,"context_line":"        vnfd_yaml \u003d vnf_dict[\u0027vnfd\u0027][\u0027attributes\u0027].get(vnfd_key, \u0027\u0027)"},{"line_number":997,"context_line":"        mock_vnfd_dict.return_value \u003d yaml.safe_load(vnfd_yaml)"}],"source_content_type":"text/x-python","patch_set":2,"id":"182cb634_857aa1b2","line":994,"range":{"start_line":993,"start_character":0,"end_line":994,"end_character":65},"in_reply_to":"c341f800_2c2aa212","updated":"2022-08-09 15:58:24.000000000","message":"merged.","commit_id":"3e56a635fedfaaec5ce54cf4e6079d2f80889a67"}]}