)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"9d9f549e27309875efdeca61f1c732878788d0b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"21379d58_ff7b5218","updated":"2022-08-10 10:51:07.000000000","message":"recheck","commit_id":"5797e9569c0f437cf6a01d953ce64e13afa8d0f3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"139b0c3c_2e5b9abb","updated":"2022-09-01 14:10:38.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"51432bad_c26ed2fd","updated":"2022-09-06 01:13:29.000000000","message":"Thanks for your kind comment.\nI modified then in PS5.\nPlease check again.","commit_id":"48dff884abdfa6d49eae46b1ab815eb0252622a9"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"53afcbeb7df23931f0e330d1599edcfce1bf4aaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"3a268d12_f1c4839f","updated":"2022-09-07 06:11:45.000000000","message":"recheck","commit_id":"7f3b3221a6e1498b97170c8748d310ff8ea79ecc"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"b89eaf75d23accd6985b754e76485195671f2d91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ec9467b0_b858a2d7","updated":"2022-09-08 00:31:44.000000000","message":"Thanks for your kind comment.\nI modified them in PS18.\nPlease check again.","commit_id":"cb17cffbdbea798194bb1b0bb623e2f96f2d7646"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"2bffcc7a9e968a80217b004eb31bf06886e82631","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"9835db82_6c4080e2","updated":"2022-09-09 06:11:55.000000000","message":"recheck","commit_id":"cc0de9cceb9026414c84d767b317fce445439e07"}],"doc/source/reference/kubernetes_openid_token_auth_usage_guide.rst":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e0373a16a2aea8108785b0b99763406af4122c68","unresolved":true,"context_lines":[{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"--------"},{"line_number":7,"context_line":"Kubernetes has multiple authentication strategies. This document describes"},{"line_number":8,"context_line":"how Tacker use `openid token`_ to authenticate with Kubernetes."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The openid token authentication of Kubernetes relies on an external openid"},{"line_number":11,"context_line":"provider, and `Keycloak`_ acts as the openid provider in this document."}],"source_content_type":"text/x-rst","patch_set":18,"id":"e4a73643_097456b4","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":22},"updated":"2022-09-08 18:41:07.000000000","message":"nit: It seems the term OpenID is more appropriate here and following for the context, correct?","commit_id":"cb17cffbdbea798194bb1b0bb623e2f96f2d7646"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"2bffcc7a9e968a80217b004eb31bf06886e82631","unresolved":true,"context_lines":[{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"--------"},{"line_number":7,"context_line":"Kubernetes has multiple authentication strategies. This document describes"},{"line_number":8,"context_line":"how Tacker use `openid token`_ to authenticate with Kubernetes."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"The openid token authentication of Kubernetes relies on an external openid"},{"line_number":11,"context_line":"provider, and `Keycloak`_ acts as the openid provider in this document."}],"source_content_type":"text/x-rst","patch_set":18,"id":"e001af37_3ba3db96","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":22},"in_reply_to":"e4a73643_097456b4","updated":"2022-09-09 06:11:55.000000000","message":"Yes, I have unified to OpenID.","commit_id":"cb17cffbdbea798194bb1b0bb623e2f96f2d7646"}],"doc/source/reference/vim_config.rst":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e0373a16a2aea8108785b0b99763406af4122c68","unresolved":true,"context_lines":[{"line_number":166,"context_line":"Kubernetes"},{"line_number":167,"context_line":"----------"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"You configure Kubernetes VIM with parameters retrieved from ``kubectl`` command"},{"line_number":170,"context_line":"as described in"},{"line_number":171,"context_line":":doc:`/install/kubernetes_vim_installation`."},{"line_number":172,"context_line":"Here is an example of Kubernetes VIM configuration."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":".. code-block:: yaml"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"3f346877_4118494e","side":"PARENT","line":172,"range":{"start_line":169,"start_character":0,"end_line":172,"end_character":51},"updated":"2022-09-08 18:41:07.000000000","message":"I don\u0027t know why you\u0027ve changed this section without it\u0027s added  \"1.\".  Why don\u0027t you to add \"1.\" before the line \"Here is an example ...\" ? Is that not enough?","commit_id":"693dce5f5dfc8516b7860c907f1b24f33477b5d3"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"2bffcc7a9e968a80217b004eb31bf06886e82631","unresolved":true,"context_lines":[{"line_number":166,"context_line":"Kubernetes"},{"line_number":167,"context_line":"----------"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"You configure Kubernetes VIM with parameters retrieved from ``kubectl`` command"},{"line_number":170,"context_line":"as described in"},{"line_number":171,"context_line":":doc:`/install/kubernetes_vim_installation`."},{"line_number":172,"context_line":"Here is an example of Kubernetes VIM configuration."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":".. code-block:: yaml"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"95d21a52_ea58835f","side":"PARENT","line":172,"range":{"start_line":169,"start_character":0,"end_line":172,"end_character":51},"in_reply_to":"3f346877_4118494e","updated":"2022-09-09 06:11:55.000000000","message":"Yes, I have changed it.","commit_id":"693dce5f5dfc8516b7860c907f1b24f33477b5d3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e0373a16a2aea8108785b0b99763406af4122c68","unresolved":true,"context_lines":[{"line_number":195,"context_line":"  -----END CERTIFICATE-----\""},{"line_number":196,"context_line":"  type: \"kubernetes\""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"2. Here is an example of Kubernetes VIM configuration with"},{"line_number":199,"context_line":"OpenID Connect Token. You configure Kubernetes VIM with parameters as described"},{"line_number":200,"context_line":"in :doc:`kubernetes_openid_token_auth_usage_guide`."},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"803b3c28_e0ce5bb6","line":198,"range":{"start_line":198,"start_character":3,"end_line":198,"end_character":13},"updated":"2022-09-08 18:41:07.000000000","message":"another","commit_id":"cb17cffbdbea798194bb1b0bb623e2f96f2d7646"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"2bffcc7a9e968a80217b004eb31bf06886e82631","unresolved":true,"context_lines":[{"line_number":195,"context_line":"  -----END CERTIFICATE-----\""},{"line_number":196,"context_line":"  type: \"kubernetes\""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"2. Here is an example of Kubernetes VIM configuration with"},{"line_number":199,"context_line":"OpenID Connect Token. You configure Kubernetes VIM with parameters as described"},{"line_number":200,"context_line":"in :doc:`kubernetes_openid_token_auth_usage_guide`."},{"line_number":201,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"3eedbed1_35cd4f4a","line":198,"range":{"start_line":198,"start_character":3,"end_line":198,"end_character":13},"in_reply_to":"803b3c28_e0ce5bb6","updated":"2022-09-09 06:11:55.000000000","message":"I have changed it.","commit_id":"cb17cffbdbea798194bb1b0bb623e2f96f2d7646"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e0373a16a2aea8108785b0b99763406af4122c68","unresolved":true,"context_lines":[{"line_number":264,"context_line":"~~~~~~~~~~~~~~~"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"The value of SSL CA Cert for X.509 client authentication. It can be ``None``."},{"line_number":267,"context_line":"The SSL certificates of Kubernetes and openid provider should be concatenated"},{"line_number":268,"context_line":"with a newline if both are needed."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Type"}],"source_content_type":"text/x-rst","patch_set":18,"id":"b3ed8a73_ba8e74dd","line":267,"range":{"start_line":267,"start_character":39,"end_line":267,"end_character":45},"updated":"2022-09-08 18:41:07.000000000","message":"Please revise the usage of terminology, OpenID and openid. Is it correct here and all?","commit_id":"cb17cffbdbea798194bb1b0bb623e2f96f2d7646"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"2bffcc7a9e968a80217b004eb31bf06886e82631","unresolved":true,"context_lines":[{"line_number":264,"context_line":"~~~~~~~~~~~~~~~"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"The value of SSL CA Cert for X.509 client authentication. It can be ``None``."},{"line_number":267,"context_line":"The SSL certificates of Kubernetes and openid provider should be concatenated"},{"line_number":268,"context_line":"with a newline if both are needed."},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Type"}],"source_content_type":"text/x-rst","patch_set":18,"id":"401e7694_c7d0d141","line":267,"range":{"start_line":267,"start_character":39,"end_line":267,"end_character":45},"in_reply_to":"b3ed8a73_ba8e74dd","updated":"2022-09-09 06:11:55.000000000","message":"Yes, I have rechecked the OpenID Spec and revised the terms as below:\n - openid provider -\u003e OpenID provider\n - openid client -\u003e Relying Party(client)\n - openid user -\u003e End-user","commit_id":"cb17cffbdbea798194bb1b0bb623e2f96f2d7646"}],"roles/setup-default-vim/tasks/main.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":111,"context_line":"       dest: \"/tmp/\""},{"line_number":112,"context_line":"       flat: true"},{"line_number":113,"context_line":"    when:"},{"line_number":114,"context_line":"      - keycloak_host is defined"},{"line_number":115,"context_line":"  when:"},{"line_number":116,"context_line":"    - inventory_hostname \u003d\u003d \u0027controller-k8s\u0027"},{"line_number":117,"context_line":"    - kuryr_k8s_api_url is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ea42d541_be85c57f","line":114,"updated":"2022-09-01 14:10:38.000000000","message":"nit: Could you add a blank line here?","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"       dest: \"/tmp/\""},{"line_number":112,"context_line":"       flat: true"},{"line_number":113,"context_line":"    when:"},{"line_number":114,"context_line":"      - keycloak_host is defined"},{"line_number":115,"context_line":"  when:"},{"line_number":116,"context_line":"    - inventory_hostname \u003d\u003d \u0027controller-k8s\u0027"},{"line_number":117,"context_line":"    - kuryr_k8s_api_url is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"8508367d_6bd82eea","line":114,"in_reply_to":"78ffc66d_1915405b","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":111,"context_line":"       dest: \"/tmp/\""},{"line_number":112,"context_line":"       flat: true"},{"line_number":113,"context_line":"    when:"},{"line_number":114,"context_line":"      - keycloak_host is defined"},{"line_number":115,"context_line":"  when:"},{"line_number":116,"context_line":"    - inventory_hostname \u003d\u003d \u0027controller-k8s\u0027"},{"line_number":117,"context_line":"    - kuryr_k8s_api_url is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"78ffc66d_1915405b","line":114,"in_reply_to":"ea42d541_be85c57f","updated":"2022-09-06 01:13:29.000000000","message":"I have add a blank line. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":248,"context_line":"    shell: test -f /tmp/agg.crt \u0026\u0026 cat /tmp/agg.crt"},{"line_number":249,"context_line":"    register: ssl_ca_cert"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"  - name: Replace ssl_ca_cert in local-k8s-vim.yaml  local-k8s-vim-oidc.yaml"},{"line_number":252,"context_line":"    replace:"},{"line_number":253,"context_line":"       path: \"{{ item }}\""},{"line_number":254,"context_line":"       regexp: \"ssl_ca_cert: .*$\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"48ab4e48_17defc25","line":251,"range":{"start_line":251,"start_character":52,"end_line":251,"end_character":53},"updated":"2022-09-01 14:10:38.000000000","message":"Could you insert `and`?","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":248,"context_line":"    shell: test -f /tmp/agg.crt \u0026\u0026 cat /tmp/agg.crt"},{"line_number":249,"context_line":"    register: ssl_ca_cert"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"  - name: Replace ssl_ca_cert in local-k8s-vim.yaml  local-k8s-vim-oidc.yaml"},{"line_number":252,"context_line":"    replace:"},{"line_number":253,"context_line":"       path: \"{{ item }}\""},{"line_number":254,"context_line":"       regexp: \"ssl_ca_cert: .*$\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5210c4e0_3e60a7bb","line":251,"range":{"start_line":251,"start_character":52,"end_line":251,"end_character":53},"in_reply_to":"48ab4e48_17defc25","updated":"2022-09-06 01:13:29.000000000","message":"Yes, I have inserted `and`. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    shell: test -f /tmp/agg.crt \u0026\u0026 cat /tmp/agg.crt"},{"line_number":249,"context_line":"    register: ssl_ca_cert"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"  - name: Replace ssl_ca_cert in local-k8s-vim.yaml  local-k8s-vim-oidc.yaml"},{"line_number":252,"context_line":"    replace:"},{"line_number":253,"context_line":"       path: \"{{ item }}\""},{"line_number":254,"context_line":"       regexp: \"ssl_ca_cert: .*$\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2d60f053_d9e4dda2","line":251,"range":{"start_line":251,"start_character":52,"end_line":251,"end_character":53},"in_reply_to":"5210c4e0_3e60a7bb","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"}],"roles/setup-k8s-oidc/files/oidc_realm.json":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a81d684c_05c70c86","updated":"2022-09-01 14:10:38.000000000","message":"Just a question,\nIs this exported file that keycloak configuration set by usage guide\u0027s `Setup Keycloak` phase?\n\nhttps://review.opendev.org/c/openstack/tacker/+/851701/14/doc/source/reference/kubernetes_openid_token_auth_usage_guide.rst#93 ~\n\nPlease check this file whether if data that is not required for testing is existing.\nI think the smaller size is better.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"b89eaf75d23accd6985b754e76485195671f2d91","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2ec9f56e_5a872c82","in_reply_to":"10d1d5d3_b1e6e8be","updated":"2022-09-08 00:31:44.000000000","message":"I exported the latest file after doing `Setup Keycloak` phase on a clean Keycloak server. Please check in PS18.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8e2c935426d76dedd88cbecd3600d77f0a645c09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"183a780b_0c45f868","in_reply_to":"2ec9f56e_5a872c82","updated":"2022-09-08 04:26:23.000000000","message":"Thanks for your confirmation and rework! I understand.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"10d1d5d3_b1e6e8be","in_reply_to":"a81d684c_05c70c86","updated":"2022-09-06 01:13:29.000000000","message":"Yes, this is a exported file that keycloak configuration set by usage guide\u0027s `Setup Keycloak` phase.\nI don\u0027t know which parts are not needed. I can investigate if necessary. But I don\u0027t know if it\u0027s risky to delete some parts.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"}],"roles/setup-k8s-oidc/tasks/main.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":55,"context_line":"      timeout: 300"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  - name: Install jq command"},{"line_number":58,"context_line":"    command: apt-get install jq -y"},{"line_number":59,"context_line":"    become: yes"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  - name: Replace keycloak host:port to import_oidc_realm.sh"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"859dd164_bc1d566d","line":58,"updated":"2022-09-01 14:10:38.000000000","message":"How about you use package module so that it doesn\u0027t depend on os?\n\nhttps://docs.ansible.com/ansible/latest/collections/ansible/builtin/package_module.html","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      timeout: 300"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  - name: Install jq command"},{"line_number":58,"context_line":"    command: apt-get install jq -y"},{"line_number":59,"context_line":"    become: yes"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  - name: Replace keycloak host:port to import_oidc_realm.sh"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a87b46b2_d48a3f51","line":58,"in_reply_to":"1917a919_a2bb7385","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":55,"context_line":"      timeout: 300"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  - name: Install jq command"},{"line_number":58,"context_line":"    command: apt-get install jq -y"},{"line_number":59,"context_line":"    become: yes"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  - name: Replace keycloak host:port to import_oidc_realm.sh"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1917a919_a2bb7385","line":58,"in_reply_to":"859dd164_bc1d566d","updated":"2022-09-06 01:13:29.000000000","message":"Yes, I have changed it to use package module for install `jq`. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"}],"tacker/tests/functional/sol_kubernetes_oidc_auth/test_vim.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                         vim_auth_res[\u0027client_secret\u0027])"},{"line_number":87,"context_line":"        self.assertNotIn(unexpected_attrs, vim_auth_res)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def assert_vim_auth_token(self, vim_auth_req, vim_auth_res):"},{"line_number":90,"context_line":"        unexpected_attrs \u003d {\u0027oidc_token_url\u0027, \u0027username\u0027, \u0027password\u0027,"},{"line_number":91,"context_line":"                            \u0027client_id\u0027, \u0027client_secret\u0027}"},{"line_number":92,"context_line":"        # check only specified attributes exist"}],"source_content_type":"text/x-python","patch_set":14,"id":"b2463f8e_18712845","line":89,"range":{"start_line":89,"start_character":36,"end_line":89,"end_character":48},"updated":"2022-09-01 14:10:38.000000000","message":"This argument seems to be unused. Could you delete it or add assertion?","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                         vim_auth_res[\u0027client_secret\u0027])"},{"line_number":87,"context_line":"        self.assertNotIn(unexpected_attrs, vim_auth_res)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def assert_vim_auth_token(self, vim_auth_req, vim_auth_res):"},{"line_number":90,"context_line":"        unexpected_attrs \u003d {\u0027oidc_token_url\u0027, \u0027username\u0027, \u0027password\u0027,"},{"line_number":91,"context_line":"                            \u0027client_id\u0027, \u0027client_secret\u0027}"},{"line_number":92,"context_line":"        # check only specified attributes exist"}],"source_content_type":"text/x-python","patch_set":14,"id":"31ef241a_84da6a6a","line":89,"range":{"start_line":89,"start_character":36,"end_line":89,"end_character":48},"in_reply_to":"a88b069b_9744a5ff","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                         vim_auth_res[\u0027client_secret\u0027])"},{"line_number":87,"context_line":"        self.assertNotIn(unexpected_attrs, vim_auth_res)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def assert_vim_auth_token(self, vim_auth_req, vim_auth_res):"},{"line_number":90,"context_line":"        unexpected_attrs \u003d {\u0027oidc_token_url\u0027, \u0027username\u0027, \u0027password\u0027,"},{"line_number":91,"context_line":"                            \u0027client_id\u0027, \u0027client_secret\u0027}"},{"line_number":92,"context_line":"        # check only specified attributes exist"}],"source_content_type":"text/x-python","patch_set":14,"id":"a88b069b_9744a5ff","line":89,"range":{"start_line":89,"start_character":36,"end_line":89,"end_character":48},"in_reply_to":"b2463f8e_18712845","updated":"2022-09-06 01:13:29.000000000","message":"Yes, I have deleted it. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"}],"tacker/tests/functional/sol_kubernetes_oidc_auth/vnflcm_v1/base.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e1550c5d_278c0d6b","updated":"2022-09-01 14:10:38.000000000","message":"This file content seems to be same as `tacker/tests/functional/sol_kubernetes/vnflcm/base.py`.\nIs it possible to remove this file and import base from `tacker.tests.functional.sol_kubernetes.vnflcm`?","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"eafedecb_62180269","in_reply_to":"a05845ff_473d860e","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a05845ff_473d860e","in_reply_to":"e1550c5d_278c0d6b","updated":"2022-09-06 01:13:29.000000000","message":"Yes, I have deleted  this file and import base from `tacker.tests.functional.sol_kubernetes.vnflcm`. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"}],"tacker/tests/functional/sol_kubernetes_oidc_auth/vnflcm_v1/test_kubernetes_oidc_auth.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tacker.tests.functional.sol_kubernetes_oidc_auth.vnflcm_v1 import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class VnfLcmKubernetesOidcTest(base.BaseVnfLcmKubernetesTest):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ade50daa_b13f0b09","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":75},"updated":"2022-09-01 14:10:38.000000000","message":"Is it possible to import base from `tacker.tests.functional.sol_kubernetes.vnflcm`?","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tacker.tests.functional.sol_kubernetes_oidc_auth.vnflcm_v1 import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class VnfLcmKubernetesOidcTest(base.BaseVnfLcmKubernetesTest):"}],"source_content_type":"text/x-python","patch_set":14,"id":"e8c30e02_0131ef0f","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":75},"in_reply_to":"ade50daa_b13f0b09","updated":"2022-09-06 01:13:29.000000000","message":"Yes, I have modified the import. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tacker.tests.functional.sol_kubernetes_oidc_auth.vnflcm_v1 import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class VnfLcmKubernetesOidcTest(base.BaseVnfLcmKubernetesTest):"}],"source_content_type":"text/x-python","patch_set":14,"id":"6af4504f_a266758a","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":75},"in_reply_to":"e8c30e02_0131ef0f","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"}],"tacker/tests/functional/sol_kubernetes_oidc_auth/vnflcm_v2/base_v2.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9ae7c747_dd6b0cca","updated":"2022-09-01 14:10:38.000000000","message":"This file content looks much like `tacker/tests/functional/sol_kubernetes_v2/base_v2.py`.\nIs it possible to inherit `BaseVnfLcmKubernetesV2Test` and change specific function that have different. \n(get_k8s_vim_info, get_k8s_vim_id)","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1cead029_c32a04d5","in_reply_to":"88b7e486_ea653d57","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"88b7e486_ea653d57","in_reply_to":"9ae7c747_dd6b0cca","updated":"2022-09-06 01:13:29.000000000","message":"Yes, I have modified the `tacker/tests/functional/sol_kubernetes_oidc_auth/vnflcm_v2/base_v2.py`. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"}],"tacker/tests/functional/sol_kubernetes_oidc_auth/vnflcm_v2/samples/test_basic_lcmsv2_resources/contents/Definitions/sample_cnf_df_simple.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":103,"context_line":"            vdu2_aspect:"},{"line_number":104,"context_line":"              name: vdu2_aspect"},{"line_number":105,"context_line":"              description: vdu2 scaling aspect"},{"line_number":106,"context_line":"              max_scale_level: 2"},{"line_number":107,"context_line":"              step_deltas:"},{"line_number":108,"context_line":"                - delta_1"},{"line_number":109,"context_line":"            vdu3_aspect:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"8e8b2fe6_f3516bf5","line":106,"range":{"start_line":106,"start_character":31,"end_line":106,"end_character":32},"updated":"2022-09-01 14:10:38.000000000","message":"1?\n\n```\n    VDU2:\n      type: tosca.nodes.nfv.Vdu.Compute\n      properties:\n        name: vdu2\n        description: VDU2 compute node\n        vdu_profile:\n          min_number_of_instances: 2   \u003c- scale_level \u003d 0\n          max_number_of_instances: 3   \u003c- scale_level \u003d 1\n```","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":103,"context_line":"            vdu2_aspect:"},{"line_number":104,"context_line":"              name: vdu2_aspect"},{"line_number":105,"context_line":"              description: vdu2 scaling aspect"},{"line_number":106,"context_line":"              max_scale_level: 2"},{"line_number":107,"context_line":"              step_deltas:"},{"line_number":108,"context_line":"                - delta_1"},{"line_number":109,"context_line":"            vdu3_aspect:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"fa341733_7f218bd9","line":106,"range":{"start_line":106,"start_character":31,"end_line":106,"end_character":32},"in_reply_to":"8e8b2fe6_f3516bf5","updated":"2022-09-06 01:13:29.000000000","message":"Because `tacker/tests/functional/sol_kubernetes_oidc_auth/vnflcm_v2/samples` is a copy of `tacker/tests/functional/sol_kubernetes_v2/samples`. I removed the former and used the latter instead. I have modified 2 to 1 in `tacker/tests/functional/sol_kubernetes_v2/samples/test_basic_lcmsv2_resources/contents/Definitions/sample_cnf_df_simple.yaml`. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            vdu2_aspect:"},{"line_number":104,"context_line":"              name: vdu2_aspect"},{"line_number":105,"context_line":"              description: vdu2 scaling aspect"},{"line_number":106,"context_line":"              max_scale_level: 2"},{"line_number":107,"context_line":"              step_deltas:"},{"line_number":108,"context_line":"                - delta_1"},{"line_number":109,"context_line":"            vdu3_aspect:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"487f9680_a90b90df","line":106,"range":{"start_line":106,"start_character":31,"end_line":106,"end_character":32},"in_reply_to":"fa341733_7f218bd9","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":223,"context_line":"                vdu3_aspect:"},{"line_number":224,"context_line":"                  scale_level: 0"},{"line_number":225,"context_line":"                vdu4_aspect:"},{"line_number":226,"context_line":"                  scale_level: 2"},{"line_number":227,"context_line":"                vdu5_aspect:"},{"line_number":228,"context_line":"                  scale_level: 2"},{"line_number":229,"context_line":"                vdu6_aspect:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9dfd253c_7c9e2e2c","line":226,"range":{"start_line":226,"start_character":31,"end_line":226,"end_character":32},"updated":"2022-09-01 14:10:38.000000000","message":"0?","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                vdu3_aspect:"},{"line_number":224,"context_line":"                  scale_level: 0"},{"line_number":225,"context_line":"                vdu4_aspect:"},{"line_number":226,"context_line":"                  scale_level: 2"},{"line_number":227,"context_line":"                vdu5_aspect:"},{"line_number":228,"context_line":"                  scale_level: 2"},{"line_number":229,"context_line":"                vdu6_aspect:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7921b2e3_5c6114a0","line":226,"range":{"start_line":226,"start_character":31,"end_line":226,"end_character":32},"in_reply_to":"7b37ffd8_0debf2fd","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":223,"context_line":"                vdu3_aspect:"},{"line_number":224,"context_line":"                  scale_level: 0"},{"line_number":225,"context_line":"                vdu4_aspect:"},{"line_number":226,"context_line":"                  scale_level: 2"},{"line_number":227,"context_line":"                vdu5_aspect:"},{"line_number":228,"context_line":"                  scale_level: 2"},{"line_number":229,"context_line":"                vdu6_aspect:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7b37ffd8_0debf2fd","line":226,"range":{"start_line":226,"start_character":31,"end_line":226,"end_character":32},"in_reply_to":"9dfd253c_7c9e2e2c","updated":"2022-09-06 01:13:29.000000000","message":"I have modified 2 to 0. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":225,"context_line":"                vdu4_aspect:"},{"line_number":226,"context_line":"                  scale_level: 2"},{"line_number":227,"context_line":"                vdu5_aspect:"},{"line_number":228,"context_line":"                  scale_level: 2"},{"line_number":229,"context_line":"                vdu6_aspect:"},{"line_number":230,"context_line":"                  scale_level: 2"},{"line_number":231,"context_line":"            instantiation_level_2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"809a0bfb_cc59bd20","line":228,"range":{"start_line":228,"start_character":31,"end_line":228,"end_character":32},"updated":"2022-09-01 14:10:38.000000000","message":"ditto.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":225,"context_line":"                vdu4_aspect:"},{"line_number":226,"context_line":"                  scale_level: 2"},{"line_number":227,"context_line":"                vdu5_aspect:"},{"line_number":228,"context_line":"                  scale_level: 2"},{"line_number":229,"context_line":"                vdu6_aspect:"},{"line_number":230,"context_line":"                  scale_level: 2"},{"line_number":231,"context_line":"            instantiation_level_2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"e0132eda_04590000","line":228,"range":{"start_line":228,"start_character":31,"end_line":228,"end_character":32},"in_reply_to":"809a0bfb_cc59bd20","updated":"2022-09-06 01:13:29.000000000","message":"I have modified 2 to 0. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                vdu4_aspect:"},{"line_number":226,"context_line":"                  scale_level: 2"},{"line_number":227,"context_line":"                vdu5_aspect:"},{"line_number":228,"context_line":"                  scale_level: 2"},{"line_number":229,"context_line":"                vdu6_aspect:"},{"line_number":230,"context_line":"                  scale_level: 2"},{"line_number":231,"context_line":"            instantiation_level_2:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"549dd668_2795066d","line":228,"range":{"start_line":228,"start_character":31,"end_line":228,"end_character":32},"in_reply_to":"e0132eda_04590000","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                vdu5_aspect:"},{"line_number":228,"context_line":"                  scale_level: 2"},{"line_number":229,"context_line":"                vdu6_aspect:"},{"line_number":230,"context_line":"                  scale_level: 2"},{"line_number":231,"context_line":"            instantiation_level_2:"},{"line_number":232,"context_line":"              description: Largest size"},{"line_number":233,"context_line":"              scale_info:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"440f2b93_6c7e2a27","line":230,"range":{"start_line":230,"start_character":31,"end_line":230,"end_character":32},"updated":"2022-09-01 14:10:38.000000000","message":"ditto.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":227,"context_line":"                vdu5_aspect:"},{"line_number":228,"context_line":"                  scale_level: 2"},{"line_number":229,"context_line":"                vdu6_aspect:"},{"line_number":230,"context_line":"                  scale_level: 2"},{"line_number":231,"context_line":"            instantiation_level_2:"},{"line_number":232,"context_line":"              description: Largest size"},{"line_number":233,"context_line":"              scale_info:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"63ba3507_76d9e0b8","line":230,"range":{"start_line":230,"start_character":31,"end_line":230,"end_character":32},"in_reply_to":"440f2b93_6c7e2a27","updated":"2022-09-06 01:13:29.000000000","message":"I have modified 2 to 0. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                vdu5_aspect:"},{"line_number":228,"context_line":"                  scale_level: 2"},{"line_number":229,"context_line":"                vdu6_aspect:"},{"line_number":230,"context_line":"                  scale_level: 2"},{"line_number":231,"context_line":"            instantiation_level_2:"},{"line_number":232,"context_line":"              description: Largest size"},{"line_number":233,"context_line":"              scale_info:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"2bb9fc5b_1bf696b0","line":230,"range":{"start_line":230,"start_character":31,"end_line":230,"end_character":32},"in_reply_to":"63ba3507_76d9e0b8","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":232,"context_line":"              description: Largest size"},{"line_number":233,"context_line":"              scale_info:"},{"line_number":234,"context_line":"                vdu2_aspect:"},{"line_number":235,"context_line":"                  scale_level: 2"},{"line_number":236,"context_line":"                vdu3_aspect:"},{"line_number":237,"context_line":"                  scale_level: 2"},{"line_number":238,"context_line":"                vdu4_aspect:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9779c179_7841fa24","line":235,"range":{"start_line":235,"start_character":31,"end_line":235,"end_character":32},"updated":"2022-09-01 14:10:38.000000000","message":"1?","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":232,"context_line":"              description: Largest size"},{"line_number":233,"context_line":"              scale_info:"},{"line_number":234,"context_line":"                vdu2_aspect:"},{"line_number":235,"context_line":"                  scale_level: 2"},{"line_number":236,"context_line":"                vdu3_aspect:"},{"line_number":237,"context_line":"                  scale_level: 2"},{"line_number":238,"context_line":"                vdu4_aspect:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d2b8074a_be7434ae","line":235,"range":{"start_line":235,"start_character":31,"end_line":235,"end_character":32},"in_reply_to":"9779c179_7841fa24","updated":"2022-09-06 01:13:29.000000000","message":"I have modified 2 to 1. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":232,"context_line":"              description: Largest size"},{"line_number":233,"context_line":"              scale_info:"},{"line_number":234,"context_line":"                vdu2_aspect:"},{"line_number":235,"context_line":"                  scale_level: 2"},{"line_number":236,"context_line":"                vdu3_aspect:"},{"line_number":237,"context_line":"                  scale_level: 2"},{"line_number":238,"context_line":"                vdu4_aspect:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0cc015b3_bae47ea9","line":235,"range":{"start_line":235,"start_character":31,"end_line":235,"end_character":32},"in_reply_to":"d2b8074a_be7434ae","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"}],"tacker/tests/functional/sol_kubernetes_oidc_auth/vnflcm_v2/test_kubernetes_oidc_auth.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_instantiationV2_with_bad_oidc_auth_info(self):"},{"line_number":151,"context_line":"        \"\"\"Test CNF LCM v2 with OIDC auth"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        * About attributes:"},{"line_number":154,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":14,"id":"773ffdde_b3e730b4","line":151,"range":{"start_line":151,"start_character":27,"end_line":151,"end_character":41},"updated":"2022-09-01 14:10:38.000000000","message":"with bad OIDC auth?","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_instantiationV2_with_bad_oidc_auth_info(self):"},{"line_number":151,"context_line":"        \"\"\"Test CNF LCM v2 with OIDC auth"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        * About attributes:"},{"line_number":154,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":14,"id":"52cb4da7_ce9d0590","line":151,"range":{"start_line":151,"start_character":27,"end_line":151,"end_character":41},"in_reply_to":"6c7d7e31_ad37d1f1","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        self.assertEqual(\u0027NOT_IN_USE\u0027, usage_state)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_instantiationV2_with_bad_oidc_auth_info(self):"},{"line_number":151,"context_line":"        \"\"\"Test CNF LCM v2 with OIDC auth"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        * About attributes:"},{"line_number":154,"context_line":"          Omit except for required attributes."}],"source_content_type":"text/x-python","patch_set":14,"id":"6c7d7e31_ad37d1f1","line":151,"range":{"start_line":151,"start_character":27,"end_line":151,"end_character":41},"in_reply_to":"773ffdde_b3e730b4","updated":"2022-09-06 01:13:29.000000000","message":"Yes, I have modified to `with bad OIDC auth`. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":218,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":219,"context_line":"        self.assertEqual(\u0027NOT_INSTANTIATED\u0027, body[\u0027instantiationState\u0027])"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # 3. Fail instantiate operation"},{"line_number":222,"context_line":"        expected_inst_attrs_fail \u003d ["},{"line_number":223,"context_line":"            \u0027id\u0027,"},{"line_number":224,"context_line":"            \u0027operationState\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"f5a27470_19d2aa47","line":221,"range":{"start_line":221,"start_character":10,"end_line":221,"end_character":12},"updated":"2022-09-01 14:10:38.000000000","message":"typo: 4.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":219,"context_line":"        self.assertEqual(\u0027NOT_INSTANTIATED\u0027, body[\u0027instantiationState\u0027])"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # 3. Fail instantiate operation"},{"line_number":222,"context_line":"        expected_inst_attrs_fail \u003d ["},{"line_number":223,"context_line":"            \u0027id\u0027,"},{"line_number":224,"context_line":"            \u0027operationState\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"60affbd3_f92ad58c","line":221,"range":{"start_line":221,"start_character":10,"end_line":221,"end_character":12},"in_reply_to":"8d4949ae_d088c1a1","updated":"2022-09-06 12:54:32.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":218,"context_line":"        self.check_resp_headers_in_get(resp)"},{"line_number":219,"context_line":"        self.assertEqual(\u0027NOT_INSTANTIATED\u0027, body[\u0027instantiationState\u0027])"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # 3. Fail instantiate operation"},{"line_number":222,"context_line":"        expected_inst_attrs_fail \u003d ["},{"line_number":223,"context_line":"            \u0027id\u0027,"},{"line_number":224,"context_line":"            \u0027operationState\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"8d4949ae_d088c1a1","line":221,"range":{"start_line":221,"start_character":10,"end_line":221,"end_character":12},"in_reply_to":"f5a27470_19d2aa47","updated":"2022-09-06 01:13:29.000000000","message":"Yes, I have modified it. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"}],"tacker/tests/unit/common/container/test_kubernetes_utils.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9a86a881d283ce0c056a06e3e37f9d32160a222e","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    # NOTE(Yao Qibin): This unit test will be executed after __init__.py"},{"line_number":30,"context_line":"    # is added. And this unit test fails because the beta1 api is old"},{"line_number":31,"context_line":"    # and deprecated. To avoid errors, comment out the following test code."},{"line_number":32,"context_line":"#     def test_get_extension_api_client(self):"},{"line_number":33,"context_line":"#         auth \u003d {\"auth_url\": \"auth\", \u0027bearer_token\u0027: \u0027token\u0027}"},{"line_number":34,"context_line":"#         extensions_v1_beta1_api \u003d \\"},{"line_number":35,"context_line":"#             self.kubernetes_http_api.get_extension_api_client(auth)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f6ac231_5c5783ce","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":1},"updated":"2022-09-01 14:10:38.000000000","message":"Could you use `@unittest.skip` instead of comment out to skip this test?","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8e2c935426d76dedd88cbecd3600d77f0a645c09","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # NOTE(Yao Qibin): This unit test will be executed after __init__.py"},{"line_number":30,"context_line":"    # is added. And this unit test fails because the beta1 api is old"},{"line_number":31,"context_line":"    # and deprecated. To avoid errors, comment out the following test code."},{"line_number":32,"context_line":"#     def test_get_extension_api_client(self):"},{"line_number":33,"context_line":"#         auth \u003d {\"auth_url\": \"auth\", \u0027bearer_token\u0027: \u0027token\u0027}"},{"line_number":34,"context_line":"#         extensions_v1_beta1_api \u003d \\"},{"line_number":35,"context_line":"#             self.kubernetes_http_api.get_extension_api_client(auth)"}],"source_content_type":"text/x-python","patch_set":14,"id":"8b4f36fa_1e88732b","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":1},"in_reply_to":"2b65748e_ca10b98f","updated":"2022-09-08 04:26:23.000000000","message":"Ack","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"a7a006d25ad1d585dd1a6014292ee67dc9f4cd19","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    # NOTE(Yao Qibin): This unit test will be executed after __init__.py"},{"line_number":30,"context_line":"    # is added. And this unit test fails because the beta1 api is old"},{"line_number":31,"context_line":"    # and deprecated. To avoid errors, comment out the following test code."},{"line_number":32,"context_line":"#     def test_get_extension_api_client(self):"},{"line_number":33,"context_line":"#         auth \u003d {\"auth_url\": \"auth\", \u0027bearer_token\u0027: \u0027token\u0027}"},{"line_number":34,"context_line":"#         extensions_v1_beta1_api \u003d \\"},{"line_number":35,"context_line":"#             self.kubernetes_http_api.get_extension_api_client(auth)"}],"source_content_type":"text/x-python","patch_set":14,"id":"b0dc78f3_670e98cf","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":1},"in_reply_to":"5f6ac231_5c5783ce","updated":"2022-09-06 01:13:29.000000000","message":"Yes, I have modified it. Please check in PS15.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"b89eaf75d23accd6985b754e76485195671f2d91","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    # NOTE(Yao Qibin): This unit test will be executed after __init__.py"},{"line_number":30,"context_line":"    # is added. And this unit test fails because the beta1 api is old"},{"line_number":31,"context_line":"    # and deprecated. To avoid errors, comment out the following test code."},{"line_number":32,"context_line":"#     def test_get_extension_api_client(self):"},{"line_number":33,"context_line":"#         auth \u003d {\"auth_url\": \"auth\", \u0027bearer_token\u0027: \u0027token\u0027}"},{"line_number":34,"context_line":"#         extensions_v1_beta1_api \u003d \\"},{"line_number":35,"context_line":"#             self.kubernetes_http_api.get_extension_api_client(auth)"}],"source_content_type":"text/x-python","patch_set":14,"id":"2b65748e_ca10b98f","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":1},"in_reply_to":"9693c0cb_5bdc60a5","updated":"2022-09-08 00:31:44.000000000","message":"I have added skip reason. Please check in PS18.","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8d9c5e3491e2733ee5b692aca40445567e2b71a","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    # NOTE(Yao Qibin): This unit test will be executed after __init__.py"},{"line_number":30,"context_line":"    # is added. And this unit test fails because the beta1 api is old"},{"line_number":31,"context_line":"    # and deprecated. To avoid errors, comment out the following test code."},{"line_number":32,"context_line":"#     def test_get_extension_api_client(self):"},{"line_number":33,"context_line":"#         auth \u003d {\"auth_url\": \"auth\", \u0027bearer_token\u0027: \u0027token\u0027}"},{"line_number":34,"context_line":"#         extensions_v1_beta1_api \u003d \\"},{"line_number":35,"context_line":"#             self.kubernetes_http_api.get_extension_api_client(auth)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9693c0cb_5bdc60a5","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":1},"in_reply_to":"b0dc78f3_670e98cf","updated":"2022-09-06 12:54:32.000000000","message":"Could you write the reason for skipping the test briefly?\n```\n@ skip (\"skip the reason\")\n```","commit_id":"9441deb4b777a183e869ffc1f3fdcedd183eb1ac"}],"tools/test-setup-k8s-vim.sh":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e0373a16a2aea8108785b0b99763406af4122c68","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#  --os-auth-url"},{"line_number":16,"context_line":"#  --config-file"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"openstack vim register \\"},{"line_number":19,"context_line":"    --os-username nfv_user \\"},{"line_number":20,"context_line":"    --os-project-name nfv \\"},{"line_number":21,"context_line":"    --os-password devstack \\"},{"line_number":22,"context_line":"    --os-auth-url http://127.0.0.1/identity \\"},{"line_number":23,"context_line":"    --os-project-domain-name Default \\"},{"line_number":24,"context_line":"    --os-user-domain-name Default \\"},{"line_number":25,"context_line":"    --description \"Kubernetes VIM\" \\"},{"line_number":26,"context_line":"    --config-file /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim.yaml \\"},{"line_number":27,"context_line":"    vim-kubernetes"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if [ -f /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim-oidc.yaml ]"},{"line_number":30,"context_line":"then"},{"line_number":31,"context_line":"    openstack vim register \\"},{"line_number":32,"context_line":"        --os-username nfv_user \\"},{"line_number":33,"context_line":"        --os-project-name nfv \\"},{"line_number":34,"context_line":"        --os-password devstack \\"},{"line_number":35,"context_line":"        --os-auth-url http://127.0.0.1/identity \\"},{"line_number":36,"context_line":"        --os-project-domain-name Default \\"},{"line_number":37,"context_line":"        --os-user-domain-name Default \\"},{"line_number":38,"context_line":"        --description \"Kubernetes VIM\" \\"},{"line_number":39,"context_line":"        --config-file /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim-oidc.yaml \\"},{"line_number":40,"context_line":"        vim-kubernetes-oidc"},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":18,"id":"d9be060f_f9fb7b74","line":41,"range":{"start_line":18,"start_character":0,"end_line":41,"end_character":2},"updated":"2022-09-08 18:41:07.000000000","message":"It looks both are almost the same. So, could you run the configurations smarter way using `for` clause or so?","commit_id":"cb17cffbdbea798194bb1b0bb623e2f96f2d7646"},{"author":{"_account_id":34997,"name":"Qibin Yao","email":"yaoqibin@fujitsu.com","username":"yaoqb"},"change_message_id":"2bffcc7a9e968a80217b004eb31bf06886e82631","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#  --os-auth-url"},{"line_number":16,"context_line":"#  --config-file"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"openstack vim register \\"},{"line_number":19,"context_line":"    --os-username nfv_user \\"},{"line_number":20,"context_line":"    --os-project-name nfv \\"},{"line_number":21,"context_line":"    --os-password devstack \\"},{"line_number":22,"context_line":"    --os-auth-url http://127.0.0.1/identity \\"},{"line_number":23,"context_line":"    --os-project-domain-name Default \\"},{"line_number":24,"context_line":"    --os-user-domain-name Default \\"},{"line_number":25,"context_line":"    --description \"Kubernetes VIM\" \\"},{"line_number":26,"context_line":"    --config-file /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim.yaml \\"},{"line_number":27,"context_line":"    vim-kubernetes"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"if [ -f /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim-oidc.yaml ]"},{"line_number":30,"context_line":"then"},{"line_number":31,"context_line":"    openstack vim register \\"},{"line_number":32,"context_line":"        --os-username nfv_user \\"},{"line_number":33,"context_line":"        --os-project-name nfv \\"},{"line_number":34,"context_line":"        --os-password devstack \\"},{"line_number":35,"context_line":"        --os-auth-url http://127.0.0.1/identity \\"},{"line_number":36,"context_line":"        --os-project-domain-name Default \\"},{"line_number":37,"context_line":"        --os-user-domain-name Default \\"},{"line_number":38,"context_line":"        --description \"Kubernetes VIM\" \\"},{"line_number":39,"context_line":"        --config-file /opt/stack/tacker/tacker/tests/etc/samples/local-k8s-vim-oidc.yaml \\"},{"line_number":40,"context_line":"        vim-kubernetes-oidc"},{"line_number":41,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":18,"id":"518249d9_910009e5","line":41,"range":{"start_line":18,"start_character":0,"end_line":41,"end_character":2},"in_reply_to":"d9be060f_f9fb7b74","updated":"2022-09-09 06:11:55.000000000","message":"I have added a common function for the same part.","commit_id":"cb17cffbdbea798194bb1b0bb623e2f96f2d7646"}]}