)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Most modifications are closed in userdata class but some fixes"},{"line_number":17,"context_line":"are done in the main route which are originally necessary."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Blueprint: individual-vnfc-management"},{"line_number":20,"context_line":"Change-Id: Ib14bcf0c00021f26878fc1960f48cb9f6aeaef43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7d4fff96_a5857c14","line":19,"updated":"2022-08-10 07:47:17.000000000","message":"I think the following is better.\nImplements: blueprint individual-vnfc-management","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Most modifications are closed in userdata class but some fixes"},{"line_number":17,"context_line":"are done in the main route which are originally necessary."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Blueprint: individual-vnfc-management"},{"line_number":20,"context_line":"Change-Id: Ib14bcf0c00021f26878fc1960f48cb9f6aeaef43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c43d2b27_d7acf878","line":19,"in_reply_to":"7d4fff96_a5857c14","updated":"2022-08-11 22:57:56.000000000","message":"You are right. I will fix. (It seems there are a lot of wrong commit message...)","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Most modifications are closed in userdata class but some fixes"},{"line_number":17,"context_line":"are done in the main route which are originally necessary."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Blueprint: individual-vnfc-management"},{"line_number":20,"context_line":"Change-Id: Ib14bcf0c00021f26878fc1960f48cb9f6aeaef43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"82b87563_6fc1426f","line":19,"in_reply_to":"c43d2b27_d7acf878","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d93b30a94d667febe55acb220127e7195b1b4a7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a9f47ae_9f52ca10","updated":"2022-08-04 23:08:25.000000000","message":"Thank you for the review.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"26effae29a38a0607c30eaef9a6784513f786c53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a12d7672_fe523799","updated":"2022-08-04 05:32:42.000000000","message":"Thank you for the review.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"363691a16e3ad8bb42d5b0bc5c74201c277f2f42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f921926d_d0eb22cb","updated":"2022-08-07 22:57:04.000000000","message":"Thank you for the review.","commit_id":"15c2b4caf5d5068e6c2343c267872693411965cb"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7666fe5151dd3b90a75e776c8df579e6e2b91a82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57a949d4_4f101ce2","updated":"2022-08-08 05:35:00.000000000","message":"Thank you for the review.","commit_id":"81e175f336bdbe92477ec3d726ba8787dc3af044"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9e5bb4c6_ffa97272","updated":"2022-08-11 22:57:56.000000000","message":"Thank you for the review.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8522fc7ddae2cc518f28d020d9ef821df91fa074","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d8926746_2783f9b2","updated":"2022-08-25 00:20:06.000000000","message":"LGTM","commit_id":"f2a70d3f684003df98238a0ae85205b7b1619cc7"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b4d0641c55247f9016d68c8d2073704f7b45ee71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ceb5de57_aec49770","updated":"2022-08-15 21:52:45.000000000","message":"recheck","commit_id":"f2a70d3f684003df98238a0ae85205b7b1619cc7"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59efa5c132973ef54446a6ff75d2939ffde150b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"36eff33e_fd9de2d7","updated":"2022-09-02 08:44:49.000000000","message":"Sorry for the late review, please kindly find my comments.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"22b3ffe0_85696796","updated":"2022-09-05 00:54:14.000000000","message":"Thank you for the review.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"047dbcdf9e2be28d579c4e48252f1441db730274","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5a00f24d_3628bb43","updated":"2022-09-04 23:31:17.000000000","message":"Thank you for the review.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"fe881df92d5cf0fdf789c87821dbc268ce97d93b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0c85da5c_11b5a28d","updated":"2022-08-29 06:03:40.000000000","message":"recheck","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"eaaae02ff43ea20aec6d08f5359bd747a7fca33e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"28ed7046_80b14590","updated":"2022-09-05 08:42:11.000000000","message":"I found a typo while checking other patches...\nPlease confirm it.","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c7eec54e_d6a8a19d","updated":"2022-09-05 01:09:48.000000000","message":"LGTM","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e71c4ed118d853cdd33d465f6e70a6b74b6e37a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3ab785f2_7fbae826","updated":"2022-09-05 22:22:13.000000000","message":"Thank you for the review.","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3be1fdccc4a35f658f387f2e2c0b1d9133c8d4a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"caf6e946_2e6c15bb","updated":"2022-09-05 08:36:32.000000000","message":"Thanks for your rework, LGTM","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1a5963df655c1d7ef632a574e4e0ca69d0a81f1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"72c658c8_f0c02271","updated":"2022-09-06 01:43:40.000000000","message":"Thanks for your rework!","commit_id":"0403aa5839e4ae4822c06cb9068f733dd9ca8a75"}],"tacker/sol_refactored/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6ee10c80793b540c7e0a35dc9f911f532fe9fb19","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        heat_client.delete_stack(stack_name)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _update_fields(self, heat_client, stack_name, fields):"},{"line_number":130,"context_line":"        parameters \u003d heat_client.get_parameters(stack_name)"},{"line_number":131,"context_line":"        LOG.debug(\"ORIG parameters: %s\", parameters)"},{"line_number":132,"context_line":"        # NOTE: parameters[\u0027nfv\u0027] is string"},{"line_number":133,"context_line":"        orig_nfv_dict \u003d json.loads(parameters.get(\u0027nfv\u0027, \u0027{}\u0027))"},{"line_number":134,"context_line":"        if \u0027nfv\u0027 in fields[\u0027parameters\u0027]:"},{"line_number":135,"context_line":"            fields[\u0027parameters\u0027][\u0027nfv\u0027] \u003d inst_utils.json_merge_patch("},{"line_number":136,"context_line":"                orig_nfv_dict, fields[\u0027parameters\u0027][\u0027nfv\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e4e5e7c_964b4d2e","line":133,"range":{"start_line":130,"start_character":8,"end_line":133,"end_character":63},"updated":"2022-08-03 08:19:21.000000000","message":"What about moving L130-133 into the if branch of L134?\nAdditionally, how about logging \u0027filelds\u0027 before update here?\nThen, you can omit the logging in each method(e.g. L186).\n---\nLOG.debug(\"ORIG fields: %s\", fields)","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"26effae29a38a0607c30eaef9a6784513f786c53","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        heat_client.delete_stack(stack_name)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _update_fields(self, heat_client, stack_name, fields):"},{"line_number":130,"context_line":"        parameters \u003d heat_client.get_parameters(stack_name)"},{"line_number":131,"context_line":"        LOG.debug(\"ORIG parameters: %s\", parameters)"},{"line_number":132,"context_line":"        # NOTE: parameters[\u0027nfv\u0027] is string"},{"line_number":133,"context_line":"        orig_nfv_dict \u003d json.loads(parameters.get(\u0027nfv\u0027, \u0027{}\u0027))"},{"line_number":134,"context_line":"        if \u0027nfv\u0027 in fields[\u0027parameters\u0027]:"},{"line_number":135,"context_line":"            fields[\u0027parameters\u0027][\u0027nfv\u0027] \u003d inst_utils.json_merge_patch("},{"line_number":136,"context_line":"                orig_nfv_dict, fields[\u0027parameters\u0027][\u0027nfv\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ab523278_aa882edf","line":133,"range":{"start_line":130,"start_character":8,"end_line":133,"end_character":63},"in_reply_to":"1e4e5e7c_964b4d2e","updated":"2022-08-04 05:32:42.000000000","message":"\u003e What about moving L130-133 into the if branch of L134?\nI think it is good since consistency with L.138 block. I will fix.\n\n\u003e Additionally, how about logging \u0027filelds\u0027 before update here?\n\u0027fields\u0027 parameter here is not ORIGINAL but _make_hot() output. this log is current heat parameters actually.\n\n\u003e Then, you can omit the logging in each method(e.g. L186).\nI found it is better that this log is output in _make_hot(). I will fix.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        heat_client.delete_stack(stack_name)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _update_fields(self, heat_client, stack_name, fields):"},{"line_number":130,"context_line":"        parameters \u003d heat_client.get_parameters(stack_name)"},{"line_number":131,"context_line":"        LOG.debug(\"ORIG parameters: %s\", parameters)"},{"line_number":132,"context_line":"        # NOTE: parameters[\u0027nfv\u0027] is string"},{"line_number":133,"context_line":"        orig_nfv_dict \u003d json.loads(parameters.get(\u0027nfv\u0027, \u0027{}\u0027))"},{"line_number":134,"context_line":"        if \u0027nfv\u0027 in fields[\u0027parameters\u0027]:"},{"line_number":135,"context_line":"            fields[\u0027parameters\u0027][\u0027nfv\u0027] \u003d inst_utils.json_merge_patch("},{"line_number":136,"context_line":"                orig_nfv_dict, fields[\u0027parameters\u0027][\u0027nfv\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"56320808_48e1eb62","line":133,"range":{"start_line":130,"start_character":8,"end_line":133,"end_character":63},"in_reply_to":"ab523278_aa882edf","updated":"2022-08-05 02:59:05.000000000","message":"Done","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6ee10c80793b540c7e0a35dc9f911f532fe9fb19","unresolved":true,"context_lines":[{"line_number":950,"context_line":"                    if k.startswith(\u0027image-\u0027):"},{"line_number":951,"context_line":"                        metadata[k] \u003d v"},{"line_number":952,"context_line":"            else:"},{"line_number":953,"context_line":"                vdu_idx \u003d metadata.get(\u0027vdu_idx\u0027)"},{"line_number":954,"context_line":"                vdu_name \u003d _vdu_with_idx(vnfc_res_info.vduId, vdu_idx)"},{"line_number":955,"context_line":"                properties \u003d nfv_dict[\u0027VDU\u0027][vdu_name]"},{"line_number":956,"context_line":"                metadata[\u0027flavor\u0027] \u003d properties[\u0027computeFlavourId\u0027]"},{"line_number":957,"context_line":"                vdu_names \u003d [vdu_name]"},{"line_number":958,"context_line":"                if vnfc_res_info.obj_attr_is_set(\u0027storageResourceIds\u0027):"},{"line_number":959,"context_line":"                    vdu_names +\u003d ["},{"line_number":960,"context_line":"                        _vdu_with_idx(storage_info.virtualStorageDescId,"},{"line_number":961,"context_line":"                                      vdu_idx)"},{"line_number":962,"context_line":"                        for storage_info in storage_infos"},{"line_number":963,"context_line":"                        if storage_info.id in vnfc_res_info.storageResourceIds"},{"line_number":964,"context_line":"                    ]"},{"line_number":965,"context_line":"                for vdu_name in vdu_names:"},{"line_number":966,"context_line":"                    image \u003d nfv_dict[\u0027VDU\u0027].get(vdu_name, {}).get(\u0027vcImageId\u0027)"},{"line_number":967,"context_line":"                    if image:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d7ce7a8_8d2321cb","line":964,"range":{"start_line":953,"start_character":16,"end_line":964,"end_character":21},"updated":"2022-08-03 08:19:21.000000000","message":"The processing of L953-964 seems to have some similarities with the processing of L381-397.\nCan you commonize these processing?","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6e61ecdb6444134c075c3fdeb097774d480477db","unresolved":false,"context_lines":[{"line_number":950,"context_line":"                    if k.startswith(\u0027image-\u0027):"},{"line_number":951,"context_line":"                        metadata[k] \u003d v"},{"line_number":952,"context_line":"            else:"},{"line_number":953,"context_line":"                vdu_idx \u003d metadata.get(\u0027vdu_idx\u0027)"},{"line_number":954,"context_line":"                vdu_name \u003d _vdu_with_idx(vnfc_res_info.vduId, vdu_idx)"},{"line_number":955,"context_line":"                properties \u003d nfv_dict[\u0027VDU\u0027][vdu_name]"},{"line_number":956,"context_line":"                metadata[\u0027flavor\u0027] \u003d properties[\u0027computeFlavourId\u0027]"},{"line_number":957,"context_line":"                vdu_names \u003d [vdu_name]"},{"line_number":958,"context_line":"                if vnfc_res_info.obj_attr_is_set(\u0027storageResourceIds\u0027):"},{"line_number":959,"context_line":"                    vdu_names +\u003d ["},{"line_number":960,"context_line":"                        _vdu_with_idx(storage_info.virtualStorageDescId,"},{"line_number":961,"context_line":"                                      vdu_idx)"},{"line_number":962,"context_line":"                        for storage_info in storage_infos"},{"line_number":963,"context_line":"                        if storage_info.id in vnfc_res_info.storageResourceIds"},{"line_number":964,"context_line":"                    ]"},{"line_number":965,"context_line":"                for vdu_name in vdu_names:"},{"line_number":966,"context_line":"                    image \u003d nfv_dict[\u0027VDU\u0027].get(vdu_name, {}).get(\u0027vcImageId\u0027)"},{"line_number":967,"context_line":"                    if image:"}],"source_content_type":"text/x-python","patch_set":1,"id":"235190d6_5b19c91b","line":964,"range":{"start_line":953,"start_character":16,"end_line":964,"end_character":21},"in_reply_to":"10c4f89b_1cca813d","updated":"2022-08-09 00:51:26.000000000","message":"Done","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"26effae29a38a0607c30eaef9a6784513f786c53","unresolved":true,"context_lines":[{"line_number":950,"context_line":"                    if k.startswith(\u0027image-\u0027):"},{"line_number":951,"context_line":"                        metadata[k] \u003d v"},{"line_number":952,"context_line":"            else:"},{"line_number":953,"context_line":"                vdu_idx \u003d metadata.get(\u0027vdu_idx\u0027)"},{"line_number":954,"context_line":"                vdu_name \u003d _vdu_with_idx(vnfc_res_info.vduId, vdu_idx)"},{"line_number":955,"context_line":"                properties \u003d nfv_dict[\u0027VDU\u0027][vdu_name]"},{"line_number":956,"context_line":"                metadata[\u0027flavor\u0027] \u003d properties[\u0027computeFlavourId\u0027]"},{"line_number":957,"context_line":"                vdu_names \u003d [vdu_name]"},{"line_number":958,"context_line":"                if vnfc_res_info.obj_attr_is_set(\u0027storageResourceIds\u0027):"},{"line_number":959,"context_line":"                    vdu_names +\u003d ["},{"line_number":960,"context_line":"                        _vdu_with_idx(storage_info.virtualStorageDescId,"},{"line_number":961,"context_line":"                                      vdu_idx)"},{"line_number":962,"context_line":"                        for storage_info in storage_infos"},{"line_number":963,"context_line":"                        if storage_info.id in vnfc_res_info.storageResourceIds"},{"line_number":964,"context_line":"                    ]"},{"line_number":965,"context_line":"                for vdu_name in vdu_names:"},{"line_number":966,"context_line":"                    image \u003d nfv_dict[\u0027VDU\u0027].get(vdu_name, {}).get(\u0027vcImageId\u0027)"},{"line_number":967,"context_line":"                    if image:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d26064dc_6e61eb0a","line":964,"range":{"start_line":953,"start_character":16,"end_line":964,"end_character":21},"in_reply_to":"6d7ce7a8_8d2321cb","updated":"2022-08-04 05:32:42.000000000","message":"OK, I will consider.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"363691a16e3ad8bb42d5b0bc5c74201c277f2f42","unresolved":true,"context_lines":[{"line_number":950,"context_line":"                    if k.startswith(\u0027image-\u0027):"},{"line_number":951,"context_line":"                        metadata[k] \u003d v"},{"line_number":952,"context_line":"            else:"},{"line_number":953,"context_line":"                vdu_idx \u003d metadata.get(\u0027vdu_idx\u0027)"},{"line_number":954,"context_line":"                vdu_name \u003d _vdu_with_idx(vnfc_res_info.vduId, vdu_idx)"},{"line_number":955,"context_line":"                properties \u003d nfv_dict[\u0027VDU\u0027][vdu_name]"},{"line_number":956,"context_line":"                metadata[\u0027flavor\u0027] \u003d properties[\u0027computeFlavourId\u0027]"},{"line_number":957,"context_line":"                vdu_names \u003d [vdu_name]"},{"line_number":958,"context_line":"                if vnfc_res_info.obj_attr_is_set(\u0027storageResourceIds\u0027):"},{"line_number":959,"context_line":"                    vdu_names +\u003d ["},{"line_number":960,"context_line":"                        _vdu_with_idx(storage_info.virtualStorageDescId,"},{"line_number":961,"context_line":"                                      vdu_idx)"},{"line_number":962,"context_line":"                        for storage_info in storage_infos"},{"line_number":963,"context_line":"                        if storage_info.id in vnfc_res_info.storageResourceIds"},{"line_number":964,"context_line":"                    ]"},{"line_number":965,"context_line":"                for vdu_name in vdu_names:"},{"line_number":966,"context_line":"                    image \u003d nfv_dict[\u0027VDU\u0027].get(vdu_name, {}).get(\u0027vcImageId\u0027)"},{"line_number":967,"context_line":"                    if image:"}],"source_content_type":"text/x-python","patch_set":1,"id":"10c4f89b_1cca813d","line":964,"range":{"start_line":953,"start_character":16,"end_line":964,"end_character":21},"in_reply_to":"8b75aea9_738ffa15","updated":"2022-08-07 22:57:04.000000000","message":"L.337 use vdu_idx later. I think it is not effective enough. I will remove vdu_idx instead.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":true,"context_lines":[{"line_number":950,"context_line":"                    if k.startswith(\u0027image-\u0027):"},{"line_number":951,"context_line":"                        metadata[k] \u003d v"},{"line_number":952,"context_line":"            else:"},{"line_number":953,"context_line":"                vdu_idx \u003d metadata.get(\u0027vdu_idx\u0027)"},{"line_number":954,"context_line":"                vdu_name \u003d _vdu_with_idx(vnfc_res_info.vduId, vdu_idx)"},{"line_number":955,"context_line":"                properties \u003d nfv_dict[\u0027VDU\u0027][vdu_name]"},{"line_number":956,"context_line":"                metadata[\u0027flavor\u0027] \u003d properties[\u0027computeFlavourId\u0027]"},{"line_number":957,"context_line":"                vdu_names \u003d [vdu_name]"},{"line_number":958,"context_line":"                if vnfc_res_info.obj_attr_is_set(\u0027storageResourceIds\u0027):"},{"line_number":959,"context_line":"                    vdu_names +\u003d ["},{"line_number":960,"context_line":"                        _vdu_with_idx(storage_info.virtualStorageDescId,"},{"line_number":961,"context_line":"                                      vdu_idx)"},{"line_number":962,"context_line":"                        for storage_info in storage_infos"},{"line_number":963,"context_line":"                        if storage_info.id in vnfc_res_info.storageResourceIds"},{"line_number":964,"context_line":"                    ]"},{"line_number":965,"context_line":"                for vdu_name in vdu_names:"},{"line_number":966,"context_line":"                    image \u003d nfv_dict[\u0027VDU\u0027].get(vdu_name, {}).get(\u0027vcImageId\u0027)"},{"line_number":967,"context_line":"                    if image:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8b75aea9_738ffa15","line":964,"range":{"start_line":953,"start_character":16,"end_line":964,"end_character":21},"in_reply_to":"d26064dc_6e61eb0a","updated":"2022-08-05 02:59:05.000000000","message":"Thanks for your fix.\nSince the process to get \u0027vdu_name\u0027 is executed in multiple places (L331, 337, 398), can these be commonized as follows?\n---\ndef _get_vdu_name_from_vnfc(self, vnfc):\n        vdu_idx \u003d vnfc.metadata.get(\u0027vdu_idx\u0027)\n        retrun _vdu_with_idx(vnfc.vduId, vdu_idx)","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59efa5c132973ef54446a6ff75d2939ffde150b9","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    part \u003d vdu_with_idx.rpartition(\u0027-\u0027)"},{"line_number":71,"context_line":"    if part[1] \u003d\u003d \u0027\u0027:"},{"line_number":72,"context_line":"        return None"},{"line_number":73,"context_line":"    else:"},{"line_number":74,"context_line":"        return int(part[2])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"8436d020_6f23ebf0","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":9},"updated":"2022-09-02 08:44:49.000000000","message":"This is unnecessary `else` after return, could you remove it?","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"047dbcdf9e2be28d579c4e48252f1441db730274","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    part \u003d vdu_with_idx.rpartition(\u0027-\u0027)"},{"line_number":71,"context_line":"    if part[1] \u003d\u003d \u0027\u0027:"},{"line_number":72,"context_line":"        return None"},{"line_number":73,"context_line":"    else:"},{"line_number":74,"context_line":"        return int(part[2])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ee2fe779_94561f3c","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":9},"in_reply_to":"8436d020_6f23ebf0","updated":"2022-09-04 23:31:17.000000000","message":"right. I will fix.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3be1fdccc4a35f658f387f2e2c0b1d9133c8d4a6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    part \u003d vdu_with_idx.rpartition(\u0027-\u0027)"},{"line_number":71,"context_line":"    if part[1] \u003d\u003d \u0027\u0027:"},{"line_number":72,"context_line":"        return None"},{"line_number":73,"context_line":"    else:"},{"line_number":74,"context_line":"        return int(part[2])"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"f658efb4_56f35bf3","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":9},"in_reply_to":"ee2fe779_94561f3c","updated":"2022-09-05 08:36:32.000000000","message":"Ack","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"}],"tacker/sol_refactored/infra_drivers/openstack/userdata_main.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6ee10c80793b540c7e0a35dc9f911f532fe9fb19","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    klass \u003d getattr(module, userdata_class)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    operation \u003d grant_req[\u0027operation\u0027].lower()"},{"line_number":43,"context_line":"    if script_dict.get(\u0027is_rollback\u0027, False):"},{"line_number":44,"context_line":"        operation \u003d operation + \u0027_rollback\u0027"},{"line_number":45,"context_line":"    method \u003d getattr(klass, operation)"},{"line_number":46,"context_line":"    stack_dict \u003d method(req, inst, grant_req, grant, tmp_csar_dir)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4804f643_b8b420c9","line":43,"range":{"start_line":43,"start_character":36,"end_line":43,"end_character":43},"updated":"2022-08-03 08:19:21.000000000","message":"Is it possible that \u0027is_rollback\u0027 is omitted?","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"26effae29a38a0607c30eaef9a6784513f786c53","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    klass \u003d getattr(module, userdata_class)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    operation \u003d grant_req[\u0027operation\u0027].lower()"},{"line_number":43,"context_line":"    if script_dict.get(\u0027is_rollback\u0027, False):"},{"line_number":44,"context_line":"        operation \u003d operation + \u0027_rollback\u0027"},{"line_number":45,"context_line":"    method \u003d getattr(klass, operation)"},{"line_number":46,"context_line":"    stack_dict \u003d method(req, inst, grant_req, grant, tmp_csar_dir)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ad4917e0_39ac4537","line":43,"range":{"start_line":43,"start_character":36,"end_line":43,"end_character":43},"in_reply_to":"4804f643_b8b420c9","updated":"2022-08-04 05:32:42.000000000","message":"\u0027is_rollback\u0027 exists allways. I will fix.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    klass \u003d getattr(module, userdata_class)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    operation \u003d grant_req[\u0027operation\u0027].lower()"},{"line_number":43,"context_line":"    if script_dict.get(\u0027is_rollback\u0027, False):"},{"line_number":44,"context_line":"        operation \u003d operation + \u0027_rollback\u0027"},{"line_number":45,"context_line":"    method \u003d getattr(klass, operation)"},{"line_number":46,"context_line":"    stack_dict \u003d method(req, inst, grant_req, grant, tmp_csar_dir)"}],"source_content_type":"text/x-python","patch_set":1,"id":"68fe5053_37ba328b","line":43,"range":{"start_line":43,"start_character":36,"end_line":43,"end_character":43},"in_reply_to":"ad4917e0_39ac4537","updated":"2022-08-05 02:59:05.000000000","message":"Done","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"}],"tacker/sol_refactored/infra_drivers/openstack/userdata_standard.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"184ccaf6d5938cde4dde850fad54b654ca82368f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"c7e899e0_f5632144","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-08-04 05:44:10.000000000","message":"\u00272022\u0027 is correct.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"10b46594_c4cc01de","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"19064281_f185f825","updated":"2022-08-05 02:59:05.000000000","message":"Done","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d93b30a94d667febe55acb220127e7195b1b4a7b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"19064281_f185f825","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"c7e899e0_f5632144","updated":"2022-08-04 23:08:25.000000000","message":"I will fix.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59efa5c132973ef54446a6ff75d2939ffde150b9","unresolved":true,"context_lines":[{"line_number":60,"context_line":"                if (get_param is not None and"},{"line_number":61,"context_line":"                        isinstance(get_param, list) and"},{"line_number":62,"context_line":"                        len(get_param) \u003e\u003d 4):"},{"line_number":63,"context_line":"                    get_param[2] \u003d add_idx(get_param[2], vdu_idx)"},{"line_number":64,"context_line":"            top_hot[\u0027resources\u0027][add_idx(vdu_name, vdu_idx)] \u003d res"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        nfv_dict \u003d common_script_utils.init_nfv_dict(top_hot)"}],"source_content_type":"text/x-python","patch_set":13,"id":"d5f57475_9cbfe154","line":63,"range":{"start_line":63,"start_character":43,"end_line":63,"end_character":55},"updated":"2022-09-02 08:44:49.000000000","message":"The fixed position is specified, but it is little difficult to understand for me. I think it would be better to explain a little in the comments.\n\n```\n  VDU1:\n    type: VDU1.yaml\n    properties:\n      flavor: { get_param: [ nfv, VDU, **VDU1**, computeFlavourId ] }\n      image-VDU1: { get_param: [ nfv, VDU, **VDU1**, vcImageId ] }\n      net1: { get_param: [ nfv, CP, **VDU1_CP1**, network ] }\n      net2: { get_resource: internalVL1 }\n      net3: { get_resource: internalVL2 }\n      affinity: { get_resource: nfvi_node_affinity }\n```\nIn the example above, I think it is the parameter surrounded by **, right?","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"047dbcdf9e2be28d579c4e48252f1441db730274","unresolved":true,"context_lines":[{"line_number":60,"context_line":"                if (get_param is not None and"},{"line_number":61,"context_line":"                        isinstance(get_param, list) and"},{"line_number":62,"context_line":"                        len(get_param) \u003e\u003d 4):"},{"line_number":63,"context_line":"                    get_param[2] \u003d add_idx(get_param[2], vdu_idx)"},{"line_number":64,"context_line":"            top_hot[\u0027resources\u0027][add_idx(vdu_name, vdu_idx)] \u003d res"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        nfv_dict \u003d common_script_utils.init_nfv_dict(top_hot)"}],"source_content_type":"text/x-python","patch_set":13,"id":"f26290c4_f129eea8","line":63,"range":{"start_line":63,"start_character":43,"end_line":63,"end_character":55},"in_reply_to":"d5f57475_9cbfe154","updated":"2022-09-04 23:31:17.000000000","message":"right. Ok, I will add a comment.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3be1fdccc4a35f658f387f2e2c0b1d9133c8d4a6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                if (get_param is not None and"},{"line_number":61,"context_line":"                        isinstance(get_param, list) and"},{"line_number":62,"context_line":"                        len(get_param) \u003e\u003d 4):"},{"line_number":63,"context_line":"                    get_param[2] \u003d add_idx(get_param[2], vdu_idx)"},{"line_number":64,"context_line":"            top_hot[\u0027resources\u0027][add_idx(vdu_name, vdu_idx)] \u003d res"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        nfv_dict \u003d common_script_utils.init_nfv_dict(top_hot)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ddc8e37_29a3824b","line":63,"range":{"start_line":63,"start_character":43,"end_line":63,"end_character":55},"in_reply_to":"f26290c4_f129eea8","updated":"2022-09-05 08:36:32.000000000","message":"Ack","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59efa5c132973ef54446a6ff75d2939ffde150b9","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                continue"},{"line_number":55,"context_line":"            vdu_idx \u003d vdu_idxes[vdu_name]"},{"line_number":56,"context_line":"            vdu_idxes[vdu_name] +\u003d 1"},{"line_number":57,"context_line":"            res \u003d copy.deepcopy(poped_vdu[vdu_name])"},{"line_number":58,"context_line":"            for prop_value in res.get(\u0027properties\u0027, {}).values():"},{"line_number":59,"context_line":"                get_param \u003d prop_value.get(\u0027get_param\u0027)"},{"line_number":60,"context_line":"                if (get_param is not None and"},{"line_number":61,"context_line":"                        isinstance(get_param, list) and"},{"line_number":62,"context_line":"                        len(get_param) \u003e\u003d 4):"},{"line_number":63,"context_line":"                    get_param[2] \u003d add_idx(get_param[2], vdu_idx)"},{"line_number":64,"context_line":"            top_hot[\u0027resources\u0027][add_idx(vdu_name, vdu_idx)] \u003d res"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        nfv_dict \u003d common_script_utils.init_nfv_dict(top_hot)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"38eaa170_660f1359","line":64,"range":{"start_line":57,"start_character":0,"end_line":64,"end_character":66},"updated":"2022-09-02 08:44:49.000000000","message":"the same code is found in other functions. Can\u0027t it be defined as a common function?","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3be1fdccc4a35f658f387f2e2c0b1d9133c8d4a6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                continue"},{"line_number":55,"context_line":"            vdu_idx \u003d vdu_idxes[vdu_name]"},{"line_number":56,"context_line":"            vdu_idxes[vdu_name] +\u003d 1"},{"line_number":57,"context_line":"            res \u003d copy.deepcopy(poped_vdu[vdu_name])"},{"line_number":58,"context_line":"            for prop_value in res.get(\u0027properties\u0027, {}).values():"},{"line_number":59,"context_line":"                get_param \u003d prop_value.get(\u0027get_param\u0027)"},{"line_number":60,"context_line":"                if (get_param is not None and"},{"line_number":61,"context_line":"                        isinstance(get_param, list) and"},{"line_number":62,"context_line":"                        len(get_param) \u003e\u003d 4):"},{"line_number":63,"context_line":"                    get_param[2] \u003d add_idx(get_param[2], vdu_idx)"},{"line_number":64,"context_line":"            top_hot[\u0027resources\u0027][add_idx(vdu_name, vdu_idx)] \u003d res"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        nfv_dict \u003d common_script_utils.init_nfv_dict(top_hot)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3bf22177_f16a0452","line":64,"range":{"start_line":57,"start_character":0,"end_line":64,"end_character":66},"in_reply_to":"111fcfd0_bab63e3a","updated":"2022-09-05 08:36:32.000000000","message":"Ack","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"047dbcdf9e2be28d579c4e48252f1441db730274","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                continue"},{"line_number":55,"context_line":"            vdu_idx \u003d vdu_idxes[vdu_name]"},{"line_number":56,"context_line":"            vdu_idxes[vdu_name] +\u003d 1"},{"line_number":57,"context_line":"            res \u003d copy.deepcopy(poped_vdu[vdu_name])"},{"line_number":58,"context_line":"            for prop_value in res.get(\u0027properties\u0027, {}).values():"},{"line_number":59,"context_line":"                get_param \u003d prop_value.get(\u0027get_param\u0027)"},{"line_number":60,"context_line":"                if (get_param is not None and"},{"line_number":61,"context_line":"                        isinstance(get_param, list) and"},{"line_number":62,"context_line":"                        len(get_param) \u003e\u003d 4):"},{"line_number":63,"context_line":"                    get_param[2] \u003d add_idx(get_param[2], vdu_idx)"},{"line_number":64,"context_line":"            top_hot[\u0027resources\u0027][add_idx(vdu_name, vdu_idx)] \u003d res"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        nfv_dict \u003d common_script_utils.init_nfv_dict(top_hot)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"111fcfd0_bab63e3a","line":64,"range":{"start_line":57,"start_character":0,"end_line":64,"end_character":66},"in_reply_to":"38eaa170_660f1359","updated":"2022-09-04 23:31:17.000000000","message":"certainly. It is used six times. I will make a method about this.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"}],"tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":true,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # check vnfd changed"},{"line_number":275,"context_line":"        self.assertEqual(self.vnfd_id_2, inst_6[\u0027vnfdId\u0027])"},{"line_number":276,"context_line":"        # check images are changed"},{"line_number":277,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU1\u0027, 0),"},{"line_number":278,"context_line":"                            self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":279,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU1\u0027, 1),"}],"source_content_type":"text/x-python","patch_set":2,"id":"2741837c_db693341","line":276,"range":{"start_line":276,"start_character":10,"end_line":276,"end_character":34},"updated":"2022-08-05 02:59:05.000000000","message":"By not changing the image of VDU2 included in sample4, how about confirming that VDU1 is changed and VDU2 is not changed?","commit_id":"15c2b4caf5d5068e6c2343c267872693411965cb"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"363691a16e3ad8bb42d5b0bc5c74201c277f2f42","unresolved":true,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # check vnfd changed"},{"line_number":275,"context_line":"        self.assertEqual(self.vnfd_id_2, inst_6[\u0027vnfdId\u0027])"},{"line_number":276,"context_line":"        # check images are changed"},{"line_number":277,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU1\u0027, 0),"},{"line_number":278,"context_line":"                            self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":279,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU1\u0027, 1),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3383520f_33892090","line":276,"range":{"start_line":276,"start_character":10,"end_line":276,"end_character":34},"in_reply_to":"2741837c_db693341","updated":"2022-08-07 22:57:04.000000000","message":"This test is intended that VDU1 is for image-\u003eimage, VDU2 is for volume-\u003evolume.","commit_id":"15c2b4caf5d5068e6c2343c267872693411965cb"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6e61ecdb6444134c075c3fdeb097774d480477db","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # check vnfd changed"},{"line_number":275,"context_line":"        self.assertEqual(self.vnfd_id_2, inst_6[\u0027vnfdId\u0027])"},{"line_number":276,"context_line":"        # check images are changed"},{"line_number":277,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU1\u0027, 0),"},{"line_number":278,"context_line":"                            self._get_vnfc_image(inst_6, \u0027VDU1\u0027, 0))"},{"line_number":279,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU1\u0027, 1),"}],"source_content_type":"text/x-python","patch_set":2,"id":"6b2bd1c3_6ae4f02b","line":276,"range":{"start_line":276,"start_character":10,"end_line":276,"end_character":34},"in_reply_to":"3383520f_33892090","updated":"2022-08-09 00:51:26.000000000","message":"I\u0027m sorry, I misunderstood. I got it.","commit_id":"15c2b4caf5d5068e6c2343c267872693411965cb"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                            self._get_vnfc_image(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        # Terminate a VNF instance"},{"line_number":285,"context_line":"        terminate_req \u003d paramgen.sample3_terminate()"},{"line_number":286,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":287,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b49e16b2_4f5609fa","line":285,"range":{"start_line":285,"start_character":33,"end_line":285,"end_character":50},"updated":"2022-08-05 02:59:05.000000000","message":"Essentially nothing changes, but \u0027sample4_terminate()\u0027 seems better because the vnf-package has changed to sample4.","commit_id":"15c2b4caf5d5068e6c2343c267872693411965cb"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6e61ecdb6444134c075c3fdeb097774d480477db","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                            self._get_vnfc_image(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        # Terminate a VNF instance"},{"line_number":285,"context_line":"        terminate_req \u003d paramgen.sample3_terminate()"},{"line_number":286,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":287,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5dec2eef_59314a49","line":285,"range":{"start_line":285,"start_character":33,"end_line":285,"end_character":50},"in_reply_to":"9550b70d_483c3223","updated":"2022-08-09 00:51:26.000000000","message":"Done","commit_id":"15c2b4caf5d5068e6c2343c267872693411965cb"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"363691a16e3ad8bb42d5b0bc5c74201c277f2f42","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                            self._get_vnfc_image(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        # Terminate a VNF instance"},{"line_number":285,"context_line":"        terminate_req \u003d paramgen.sample3_terminate()"},{"line_number":286,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":287,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9550b70d_483c3223","line":285,"range":{"start_line":285,"start_character":33,"end_line":285,"end_character":50},"in_reply_to":"b49e16b2_4f5609fa","updated":"2022-08-07 22:57:04.000000000","message":"I see. I will fix.","commit_id":"15c2b4caf5d5068e6c2343c267872693411965cb"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":true,"context_lines":[{"line_number":359,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        # check number of vnfc and its id are not changed."},{"line_number":362,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_0, \u0027VDU1\u0027))"},{"line_number":363,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_0, \u0027VDU2\u0027))"},{"line_number":364,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_1, \u0027VDU1\u0027))"},{"line_number":365,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_1, \u0027VDU2\u0027))"},{"line_number":366,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_0, \u0027VDU1\u0027, 0),"},{"line_number":367,"context_line":"                         self._get_vnfc_id(inst_1, \u0027VDU1\u0027, 0))"},{"line_number":368,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_0, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":2,"id":"a64e284c_0d3e85bf","line":365,"range":{"start_line":362,"start_character":8,"end_line":365,"end_character":68},"updated":"2022-08-05 02:59:05.000000000","message":"Are these assertions enough below?\n---\n         self.assertEqual(self._get_vdu_indexes(inst_0, \u0027VDU1\u0027)),\n                          self._get_vdu_indexes(inst_1, \u0027VDU1\u0027))\n         self.assertEqual(self._get_vdu_indexes(inst_0, \u0027VDU2\u0027)),\n                          self._get_vdu_indexes(inst_1, \u0027VDU2\u0027))","commit_id":"15c2b4caf5d5068e6c2343c267872693411965cb"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6e61ecdb6444134c075c3fdeb097774d480477db","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        # check number of vnfc and its id are not changed."},{"line_number":362,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_0, \u0027VDU1\u0027))"},{"line_number":363,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_0, \u0027VDU2\u0027))"},{"line_number":364,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_1, \u0027VDU1\u0027))"},{"line_number":365,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_1, \u0027VDU2\u0027))"},{"line_number":366,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_0, \u0027VDU1\u0027, 0),"},{"line_number":367,"context_line":"                         self._get_vnfc_id(inst_1, \u0027VDU1\u0027, 0))"},{"line_number":368,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_0, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":2,"id":"99832558_5788e5dd","line":365,"range":{"start_line":362,"start_character":8,"end_line":365,"end_character":68},"in_reply_to":"559799ea_95b0b8ad","updated":"2022-08-09 00:51:26.000000000","message":"Done","commit_id":"15c2b4caf5d5068e6c2343c267872693411965cb"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"363691a16e3ad8bb42d5b0bc5c74201c277f2f42","unresolved":true,"context_lines":[{"line_number":359,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        # check number of vnfc and its id are not changed."},{"line_number":362,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_0, \u0027VDU1\u0027))"},{"line_number":363,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_0, \u0027VDU2\u0027))"},{"line_number":364,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_1, \u0027VDU1\u0027))"},{"line_number":365,"context_line":"        self.assertEqual({0}, self._get_vdu_indexes(inst_1, \u0027VDU2\u0027))"},{"line_number":366,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_0, \u0027VDU1\u0027, 0),"},{"line_number":367,"context_line":"                         self._get_vnfc_id(inst_1, \u0027VDU1\u0027, 0))"},{"line_number":368,"context_line":"        self.assertEqual(self._get_vnfc_id(inst_0, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":2,"id":"559799ea_95b0b8ad","line":365,"range":{"start_line":362,"start_character":8,"end_line":365,"end_character":68},"in_reply_to":"a64e284c_0d3e85bf","updated":"2022-08-07 22:57:04.000000000","message":"I see. I will fix.","commit_id":"15c2b4caf5d5068e6c2343c267872693411965cb"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"f25a92ca11d80b0941d9960e047e89a32d2a2953","unresolved":true,"context_lines":[{"line_number":271,"context_line":"        resp, inst_6 \u003d self.show_vnf_instance(inst_id)"},{"line_number":272,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # check vnfd changed"},{"line_number":275,"context_line":"        self.assertEqual(self.vnfd_id_2, inst_6[\u0027vnfdId\u0027])"},{"line_number":276,"context_line":"        # check images are changed"},{"line_number":277,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":3,"id":"0451e41a_ac4d934b","line":274,"updated":"2022-08-08 04:00:49.000000000","message":"NITS.\nIt would be good to unify the term and grammar of the sentence with the #L415.","commit_id":"81e175f336bdbe92477ec3d726ba8787dc3af044"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7666fe5151dd3b90a75e776c8df579e6e2b91a82","unresolved":true,"context_lines":[{"line_number":271,"context_line":"        resp, inst_6 \u003d self.show_vnf_instance(inst_id)"},{"line_number":272,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # check vnfd changed"},{"line_number":275,"context_line":"        self.assertEqual(self.vnfd_id_2, inst_6[\u0027vnfdId\u0027])"},{"line_number":276,"context_line":"        # check images are changed"},{"line_number":277,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":3,"id":"718fe894_0cce3d4d","line":274,"in_reply_to":"0451e41a_ac4d934b","updated":"2022-08-08 05:35:00.000000000","message":"I will fix.","commit_id":"81e175f336bdbe92477ec3d726ba8787dc3af044"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"84f141c50b3c90bd0d736f272b333fb949642de7","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        resp, inst_6 \u003d self.show_vnf_instance(inst_id)"},{"line_number":272,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        # check vnfd changed"},{"line_number":275,"context_line":"        self.assertEqual(self.vnfd_id_2, inst_6[\u0027vnfdId\u0027])"},{"line_number":276,"context_line":"        # check images are changed"},{"line_number":277,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU1\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9c0d1d21_77db8587","line":274,"in_reply_to":"718fe894_0cce3d4d","updated":"2022-08-23 05:05:11.000000000","message":"Done","commit_id":"81e175f336bdbe92477ec3d726ba8787dc3af044"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"f25a92ca11d80b0941d9960e047e89a32d2a2953","unresolved":true,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        # check vnfdId is not changed"},{"line_number":416,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_3[\u0027vnfdId\u0027])"},{"line_number":417,"context_line":"        # check images are changed"},{"line_number":418,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":419,"context_line":"                         self._get_vnfc_image(inst_3, \u0027VDU1\u0027, 0))"},{"line_number":420,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5d0e1da2_6a18a40d","line":417,"updated":"2022-08-08 04:00:49.000000000","message":"It seems typo.\nIs \"check images are \"not\" changed\" right?","commit_id":"81e175f336bdbe92477ec3d726ba8787dc3af044"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7666fe5151dd3b90a75e776c8df579e6e2b91a82","unresolved":true,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        # check vnfdId is not changed"},{"line_number":416,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_3[\u0027vnfdId\u0027])"},{"line_number":417,"context_line":"        # check images are changed"},{"line_number":418,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":419,"context_line":"                         self._get_vnfc_image(inst_3, \u0027VDU1\u0027, 0))"},{"line_number":420,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":3,"id":"f188b8c8_2daf4e1a","line":417,"in_reply_to":"5d0e1da2_6a18a40d","updated":"2022-08-08 05:35:00.000000000","message":"\"not changed\" is correct. I will fix.","commit_id":"81e175f336bdbe92477ec3d726ba8787dc3af044"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"84f141c50b3c90bd0d736f272b333fb949642de7","unresolved":false,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        # check vnfdId is not changed"},{"line_number":416,"context_line":"        self.assertEqual(self.vnfd_id_1, inst_3[\u0027vnfdId\u0027])"},{"line_number":417,"context_line":"        # check images are changed"},{"line_number":418,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU1\u0027, 0),"},{"line_number":419,"context_line":"                         self._get_vnfc_image(inst_3, \u0027VDU1\u0027, 0))"},{"line_number":420,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa355b79_192e7b8b","line":417,"in_reply_to":"f188b8c8_2daf4e1a","updated":"2022-08-23 05:05:11.000000000","message":"Done","commit_id":"81e175f336bdbe92477ec3d726ba8787dc3af044"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":119,"context_line":"                break"},{"line_number":120,"context_line":"        self.assertTrue(False)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_basic_opeations(self):"},{"line_number":123,"context_line":"        \"\"\"Test basic operations using StandardUserData"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        * Note:"}],"source_content_type":"text/x-python","patch_set":8,"id":"305ef079_7c30f154","line":122,"updated":"2022-08-10 07:47:17.000000000","message":"typo: opeations -\u003e operations","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":119,"context_line":"                break"},{"line_number":120,"context_line":"        self.assertTrue(False)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_basic_opeations(self):"},{"line_number":123,"context_line":"        \"\"\"Test basic operations using StandardUserData"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        * Note:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf7dd755_8416620d","line":122,"in_reply_to":"305ef079_7c30f154","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                break"},{"line_number":120,"context_line":"        self.assertTrue(False)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_basic_opeations(self):"},{"line_number":123,"context_line":"        \"\"\"Test basic operations using StandardUserData"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        * Note:"}],"source_content_type":"text/x-python","patch_set":8,"id":"52ee82d7_8cec4052","line":122,"in_reply_to":"bf7dd755_8416620d","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        # Delete a VNF instance"},{"line_number":294,"context_line":"        self._delete_instance(inst_id)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def test_rollback_opeations(self):"},{"line_number":297,"context_line":"        \"\"\"Test rollback operations using StandardUserData"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        * Note:"}],"source_content_type":"text/x-python","patch_set":8,"id":"33d1e499_1294cfc0","line":296,"updated":"2022-08-10 07:47:17.000000000","message":"typo: opeations -\u003e operations","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        # Delete a VNF instance"},{"line_number":294,"context_line":"        self._delete_instance(inst_id)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def test_rollback_opeations(self):"},{"line_number":297,"context_line":"        \"\"\"Test rollback operations using StandardUserData"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        * Note:"}],"source_content_type":"text/x-python","patch_set":8,"id":"f1fab053_30a910ad","line":296,"in_reply_to":"1eb250cc_700c1143","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        # Delete a VNF instance"},{"line_number":294,"context_line":"        self._delete_instance(inst_id)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def test_rollback_opeations(self):"},{"line_number":297,"context_line":"        \"\"\"Test rollback operations using StandardUserData"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        * Note:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1eb250cc_700c1143","line":296,"in_reply_to":"33d1e499_1294cfc0","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    def setUpClass(cls):"},{"line_number":27,"context_line":"        super(IndividualVnfcMgmtTest, cls).setUpClass()"},{"line_number":28,"context_line":"        cur_dir \u003d os.path.dirname(__file__)"},{"line_number":29,"context_line":"        # tacker/tests/etc..."},{"line_number":30,"context_line":"        #             /functional/sol_v2"},{"line_number":31,"context_line":"        image_dir \u003d os.path.join("},{"line_number":32,"context_line":"            cur_dir, \"../../etc/samples/etsi/nfv/common/Files/images\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"682b3706_d2de1baf","line":29,"updated":"2022-09-04 23:41:40.000000000","message":"Is \"etc...\" needed?","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    def setUpClass(cls):"},{"line_number":27,"context_line":"        super(IndividualVnfcMgmtTest, cls).setUpClass()"},{"line_number":28,"context_line":"        cur_dir \u003d os.path.dirname(__file__)"},{"line_number":29,"context_line":"        # tacker/tests/etc..."},{"line_number":30,"context_line":"        #             /functional/sol_v2"},{"line_number":31,"context_line":"        image_dir \u003d os.path.join("},{"line_number":32,"context_line":"            cur_dir, \"../../etc/samples/etsi/nfv/common/Files/images\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"a4c5312b_89803980","line":29,"in_reply_to":"682b3706_d2de1baf","updated":"2022-09-05 00:54:14.000000000","message":"I think position relation is easy to understand with it. but I will change this comment a bit.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def setUpClass(cls):"},{"line_number":27,"context_line":"        super(IndividualVnfcMgmtTest, cls).setUpClass()"},{"line_number":28,"context_line":"        cur_dir \u003d os.path.dirname(__file__)"},{"line_number":29,"context_line":"        # tacker/tests/etc..."},{"line_number":30,"context_line":"        #             /functional/sol_v2"},{"line_number":31,"context_line":"        image_dir \u003d os.path.join("},{"line_number":32,"context_line":"            cur_dir, \"../../etc/samples/etsi/nfv/common/Files/images\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"0df53493_a85bcb83","line":29,"in_reply_to":"a4c5312b_89803980","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        image_path \u003d os.path.abspath(os.path.join(image_dir, image_file))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # tacker/sol_refactored/infra_drivers/openstack/userdata_standard.py"},{"line_number":37,"context_line":"        #       /tests/functional/sol_v2"},{"line_number":38,"context_line":"        userdata_dir \u003d os.path.join("},{"line_number":39,"context_line":"            cur_dir, \"../../../sol_refactored/infra_drivers/openstack\")"},{"line_number":40,"context_line":"        userdata_file \u003d \"userdata_standard.py\""}],"source_content_type":"text/x-python","patch_set":13,"id":"db795fa9_0a8fc3a0","line":37,"updated":"2022-09-04 23:41:40.000000000","message":"Is this line needed?","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        image_path \u003d os.path.abspath(os.path.join(image_dir, image_file))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # tacker/sol_refactored/infra_drivers/openstack/userdata_standard.py"},{"line_number":37,"context_line":"        #       /tests/functional/sol_v2"},{"line_number":38,"context_line":"        userdata_dir \u003d os.path.join("},{"line_number":39,"context_line":"            cur_dir, \"../../../sol_refactored/infra_drivers/openstack\")"},{"line_number":40,"context_line":"        userdata_file \u003d \"userdata_standard.py\""}],"source_content_type":"text/x-python","patch_set":13,"id":"d1bc9bad_3e3494e1","line":37,"in_reply_to":"c3069bcb_d982e39e","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        image_path \u003d os.path.abspath(os.path.join(image_dir, image_file))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # tacker/sol_refactored/infra_drivers/openstack/userdata_standard.py"},{"line_number":37,"context_line":"        #       /tests/functional/sol_v2"},{"line_number":38,"context_line":"        userdata_dir \u003d os.path.join("},{"line_number":39,"context_line":"            cur_dir, \"../../../sol_refactored/infra_drivers/openstack\")"},{"line_number":40,"context_line":"        userdata_file \u003d \"userdata_standard.py\""}],"source_content_type":"text/x-python","patch_set":13,"id":"c3069bcb_d982e39e","line":37,"in_reply_to":"db795fa9_0a8fc3a0","updated":"2022-09-05 00:54:14.000000000","message":"I think yes. but I will change this comment a bit.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                return"},{"line_number":114,"context_line":"            elif resp.status_code \u003d\u003d 409:"},{"line_number":115,"context_line":"                # may happen. there is a bit time between lcmocc become"},{"line_number":116,"context_line":"                # COMPLETE and lock of terminate is freed."},{"line_number":117,"context_line":"                time.sleep(3)"},{"line_number":118,"context_line":"            else:"},{"line_number":119,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":13,"id":"29c81c96_3f8fc585","line":116,"updated":"2022-09-04 23:41:40.000000000","message":"The correct value is \"COMPLETED\".","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                return"},{"line_number":114,"context_line":"            elif resp.status_code \u003d\u003d 409:"},{"line_number":115,"context_line":"                # may happen. there is a bit time between lcmocc become"},{"line_number":116,"context_line":"                # COMPLETE and lock of terminate is freed."},{"line_number":117,"context_line":"                time.sleep(3)"},{"line_number":118,"context_line":"            else:"},{"line_number":119,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":13,"id":"b660b5ba_7327ba7c","line":116,"in_reply_to":"29c81c96_3f8fc585","updated":"2022-09-05 00:54:14.000000000","message":"I will fix.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                return"},{"line_number":114,"context_line":"            elif resp.status_code \u003d\u003d 409:"},{"line_number":115,"context_line":"                # may happen. there is a bit time between lcmocc become"},{"line_number":116,"context_line":"                # COMPLETE and lock of terminate is freed."},{"line_number":117,"context_line":"                time.sleep(3)"},{"line_number":118,"context_line":"            else:"},{"line_number":119,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":13,"id":"0aa5c4c7_182c1426","line":116,"in_reply_to":"b660b5ba_7327ba7c","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        * About LCM operations:"},{"line_number":130,"context_line":"          This test includes the following operations."},{"line_number":131,"context_line":"          -    Create VNF instance"},{"line_number":132,"context_line":"          - 1. Instantiate VNF"},{"line_number":133,"context_line":"          -    Show VNF instance / check"},{"line_number":134,"context_line":"          - 2. Scale out operation"},{"line_number":135,"context_line":"          -    Show VNF instance / check"}],"source_content_type":"text/x-python","patch_set":13,"id":"8a348481_efffa33d","line":132,"updated":"2022-09-04 23:41:40.000000000","message":"It is better to add \"instance\" as in L.157.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        * About LCM operations:"},{"line_number":130,"context_line":"          This test includes the following operations."},{"line_number":131,"context_line":"          -    Create VNF instance"},{"line_number":132,"context_line":"          - 1. Instantiate VNF"},{"line_number":133,"context_line":"          -    Show VNF instance / check"},{"line_number":134,"context_line":"          - 2. Scale out operation"},{"line_number":135,"context_line":"          -    Show VNF instance / check"}],"source_content_type":"text/x-python","patch_set":13,"id":"da184e62_3b8fbd29","line":132,"in_reply_to":"8a348481_efffa33d","updated":"2022-09-05 00:54:14.000000000","message":"I will fix.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        * About LCM operations:"},{"line_number":130,"context_line":"          This test includes the following operations."},{"line_number":131,"context_line":"          -    Create VNF instance"},{"line_number":132,"context_line":"          - 1. Instantiate VNF"},{"line_number":133,"context_line":"          -    Show VNF instance / check"},{"line_number":134,"context_line":"          - 2. Scale out operation"},{"line_number":135,"context_line":"          -    Show VNF instance / check"}],"source_content_type":"text/x-python","patch_set":13,"id":"9030d86a_3afd4a0f","line":132,"in_reply_to":"da184e62_3b8fbd29","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":141,"context_line":"          -    Show VNF instance / check"},{"line_number":142,"context_line":"          - 6. Change_vnfpkg operation"},{"line_number":143,"context_line":"          -    Show VNF instance / check"},{"line_number":144,"context_line":"          -    Terminate VNF"},{"line_number":145,"context_line":"          -    Delete VNF instance"},{"line_number":146,"context_line":"        \"\"\""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"32f591e6_faae61fb","line":144,"updated":"2022-09-04 23:41:40.000000000","message":"It is better to add \"instance\" as in L.285.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":141,"context_line":"          -    Show VNF instance / check"},{"line_number":142,"context_line":"          - 6. Change_vnfpkg operation"},{"line_number":143,"context_line":"          -    Show VNF instance / check"},{"line_number":144,"context_line":"          -    Terminate VNF"},{"line_number":145,"context_line":"          -    Delete VNF instance"},{"line_number":146,"context_line":"        \"\"\""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a7f2dd2_886beb23","line":144,"in_reply_to":"32f591e6_faae61fb","updated":"2022-09-05 00:54:14.000000000","message":"I will fix.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":141,"context_line":"          -    Show VNF instance / check"},{"line_number":142,"context_line":"          - 6. Change_vnfpkg operation"},{"line_number":143,"context_line":"          -    Show VNF instance / check"},{"line_number":144,"context_line":"          -    Terminate VNF"},{"line_number":145,"context_line":"          -    Delete VNF instance"},{"line_number":146,"context_line":"        \"\"\""},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"f1813053_f4178419","line":144,"in_reply_to":"9a7f2dd2_886beb23","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU2\u0027, 0),"},{"line_number":283,"context_line":"                            self._get_vnfc_image(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        # Terminate a VNF instance"},{"line_number":286,"context_line":"        terminate_req \u003d paramgen.sample4_terminate()"},{"line_number":287,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":288,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":13,"id":"18fee73c_d045fa5a","line":285,"updated":"2022-09-04 23:41:40.000000000","message":"As in L.144, it is better to remove \"a\".","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU2\u0027, 0),"},{"line_number":283,"context_line":"                            self._get_vnfc_image(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        # Terminate a VNF instance"},{"line_number":286,"context_line":"        terminate_req \u003d paramgen.sample4_terminate()"},{"line_number":287,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":288,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7d9a9d74_06e83e83","line":285,"in_reply_to":"18fee73c_d045fa5a","updated":"2022-09-05 00:54:14.000000000","message":"I will fix.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        self.assertNotEqual(self._get_vnfc_image(inst_5, \u0027VDU2\u0027, 0),"},{"line_number":283,"context_line":"                            self._get_vnfc_image(inst_6, \u0027VDU2\u0027, 0))"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        # Terminate a VNF instance"},{"line_number":286,"context_line":"        terminate_req \u003d paramgen.sample4_terminate()"},{"line_number":287,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":288,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bb8d923d_0de68016","line":285,"in_reply_to":"7d9a9d74_06e83e83","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":290,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":291,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        # Delete a VNF instance"},{"line_number":294,"context_line":"        self._delete_instance(inst_id)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def test_rollback_operations(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"56ebaa69_8e6dc84a","line":293,"updated":"2022-09-04 23:41:40.000000000","message":"As in L.145, it is better to remove \"a\".","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":291,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        # Delete a VNF instance"},{"line_number":294,"context_line":"        self._delete_instance(inst_id)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def test_rollback_operations(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"a1c2a06a_baa16a99","line":293,"in_reply_to":"56cf49b6_d1fc9588","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":290,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":291,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        # Delete a VNF instance"},{"line_number":294,"context_line":"        self._delete_instance(inst_id)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def test_rollback_operations(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"56cf49b6_d1fc9588","line":293,"in_reply_to":"56ebaa69_8e6dc84a","updated":"2022-09-05 00:54:14.000000000","message":"I will fix.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":303,"context_line":"        * About LCM operations:"},{"line_number":304,"context_line":"          This test includes the following operations."},{"line_number":305,"context_line":"          -    Create VNF instance"},{"line_number":306,"context_line":"          -    Instantiate VNF"},{"line_number":307,"context_line":"          -    Show VNF instance"},{"line_number":308,"context_line":"          - 1. Scale out operation \u003d\u003e FAILED_TEMP"},{"line_number":309,"context_line":"          -    Rollback"}],"source_content_type":"text/x-python","patch_set":13,"id":"c55046ce_5e3ca814","line":306,"updated":"2022-09-04 23:41:40.000000000","message":"It is better to add \"instance\" as in L.330.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        * About LCM operations:"},{"line_number":304,"context_line":"          This test includes the following operations."},{"line_number":305,"context_line":"          -    Create VNF instance"},{"line_number":306,"context_line":"          -    Instantiate VNF"},{"line_number":307,"context_line":"          -    Show VNF instance"},{"line_number":308,"context_line":"          - 1. Scale out operation \u003d\u003e FAILED_TEMP"},{"line_number":309,"context_line":"          -    Rollback"}],"source_content_type":"text/x-python","patch_set":13,"id":"d591ef9e_449c60e5","line":306,"in_reply_to":"b98430de_d9085f00","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":303,"context_line":"        * About LCM operations:"},{"line_number":304,"context_line":"          This test includes the following operations."},{"line_number":305,"context_line":"          -    Create VNF instance"},{"line_number":306,"context_line":"          -    Instantiate VNF"},{"line_number":307,"context_line":"          -    Show VNF instance"},{"line_number":308,"context_line":"          - 1. Scale out operation \u003d\u003e FAILED_TEMP"},{"line_number":309,"context_line":"          -    Rollback"}],"source_content_type":"text/x-python","patch_set":13,"id":"b98430de_d9085f00","line":306,"in_reply_to":"c55046ce_5e3ca814","updated":"2022-09-05 00:54:14.000000000","message":"I will fix.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":314,"context_line":"          - 3. Change_vnfpkg operation \u003d\u003e FAILED_TEMP"},{"line_number":315,"context_line":"          -    Rollback"},{"line_number":316,"context_line":"          -    Show VNF instance / check"},{"line_number":317,"context_line":"          -    Terminate VNF"},{"line_number":318,"context_line":"          -    Delete VNF instance"},{"line_number":319,"context_line":"        \"\"\""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"0226b36a_405d3ef7","line":317,"updated":"2022-09-04 23:41:40.000000000","message":"It is better to add \"instance\" as in L.424.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":314,"context_line":"          - 3. Change_vnfpkg operation \u003d\u003e FAILED_TEMP"},{"line_number":315,"context_line":"          -    Rollback"},{"line_number":316,"context_line":"          -    Show VNF instance / check"},{"line_number":317,"context_line":"          -    Terminate VNF"},{"line_number":318,"context_line":"          -    Delete VNF instance"},{"line_number":319,"context_line":"        \"\"\""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5d8fec3c_05be6af7","line":317,"in_reply_to":"0226b36a_405d3ef7","updated":"2022-09-05 00:54:14.000000000","message":"I will fix.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":314,"context_line":"          - 3. Change_vnfpkg operation \u003d\u003e FAILED_TEMP"},{"line_number":315,"context_line":"          -    Rollback"},{"line_number":316,"context_line":"          -    Show VNF instance / check"},{"line_number":317,"context_line":"          -    Terminate VNF"},{"line_number":318,"context_line":"          -    Delete VNF instance"},{"line_number":319,"context_line":"        \"\"\""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"b47c8237_e7c16c9e","line":317,"in_reply_to":"5d8fec3c_05be6af7","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":421,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":422,"context_line":"                         self._get_vnfc_image(inst_3, \u0027VDU2\u0027, 0))"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        # Terminate a VNF instance"},{"line_number":425,"context_line":"        terminate_req \u003d paramgen.sample3_terminate()"},{"line_number":426,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":427,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bd1b7f75_75d0a3b6","line":424,"updated":"2022-09-04 23:41:40.000000000","message":"As in L.317, it is better to remove \"a\".","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":421,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":422,"context_line":"                         self._get_vnfc_image(inst_3, \u0027VDU2\u0027, 0))"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        # Terminate a VNF instance"},{"line_number":425,"context_line":"        terminate_req \u003d paramgen.sample3_terminate()"},{"line_number":426,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":427,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":13,"id":"f961184b_1de29ba3","line":424,"in_reply_to":"bd1b7f75_75d0a3b6","updated":"2022-09-05 00:54:14.000000000","message":"I will fix.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        self.assertEqual(self._get_vnfc_image(inst_2, \u0027VDU2\u0027, 0),"},{"line_number":422,"context_line":"                         self._get_vnfc_image(inst_3, \u0027VDU2\u0027, 0))"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        # Terminate a VNF instance"},{"line_number":425,"context_line":"        terminate_req \u003d paramgen.sample3_terminate()"},{"line_number":426,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":427,"context_line":"        self.assertEqual(202, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":13,"id":"be7f27ba_5e7934fe","line":424,"in_reply_to":"f961184b_1de29ba3","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"2e46304f67619e2cef57ae6bf02490d828fcb8bf","unresolved":true,"context_lines":[{"line_number":429,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":430,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        # Delete a VNF instance"},{"line_number":433,"context_line":"        self._delete_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7fb751d7_29b7f2b4","line":432,"updated":"2022-09-04 23:41:40.000000000","message":"As in L.318, it is better to remove \"a\".","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"6419d9f4408fb1927e0d40bee477aeb63c5270fe","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":430,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        # Delete a VNF instance"},{"line_number":433,"context_line":"        self._delete_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"426bce4e_d8dca9bc","line":432,"in_reply_to":"1a9aecb4_d17b4e93","updated":"2022-09-05 01:09:48.000000000","message":"Done","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"747bba11218c070a8716cf1258a360751922d094","unresolved":true,"context_lines":[{"line_number":429,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":430,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        # Delete a VNF instance"},{"line_number":433,"context_line":"        self._delete_instance(inst_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a9aecb4_d17b4e93","line":432,"in_reply_to":"7fb751d7_29b7f2b4","updated":"2022-09-05 00:54:14.000000000","message":"I will fix.","commit_id":"d28f5eebe5845d4873faacd38046305f785b571d"}],"tacker/tests/functional/sol_v2/test_userdata_standard.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"184ccaf6d5938cde4dde850fad54b654ca82368f","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from tacker.tests.functional.sol_v2_common import test_vnflcm_basic_common"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class StandardUserDataTest(test_vnflcm_basic_common.CommonVnfLcmTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setUpClass(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b44a0443_16ea0a71","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":26},"updated":"2022-08-04 05:44:10.000000000","message":"This file name and class name looks like unittest.\nHow about changing these like below?\n---\ntacker/tests/functional/sol_v2/test_individual_vnfc_mgmt.py\nIndividualVnfcMgmtTest","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tacker.tests.functional.sol_v2_common import test_vnflcm_basic_common"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class StandardUserDataTest(test_vnflcm_basic_common.CommonVnfLcmTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setUpClass(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ad862f9_86da292a","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":26},"in_reply_to":"46686521_7a9fbb1b","updated":"2022-08-05 02:59:05.000000000","message":"Done","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d93b30a94d667febe55acb220127e7195b1b4a7b","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from tacker.tests.functional.sol_v2_common import test_vnflcm_basic_common"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class StandardUserDataTest(test_vnflcm_basic_common.CommonVnfLcmTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setUpClass(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"46686521_7a9fbb1b","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":26},"in_reply_to":"b44a0443_16ea0a71","updated":"2022-08-04 23:08:25.000000000","message":"OK, I will fix.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"}],"tacker/tests/functional/sol_v2_common/paramgen.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"eaaae02ff43ea20aec6d08f5359bd747a7fca33e","unresolved":true,"context_lines":[{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"def sample3_heal():"},{"line_number":1045,"context_line":"    return {"},{"line_number":1046,"context_line":"        \"vnfcInstanceId\": [],  # sholud be filled"},{"line_number":1047,"context_line":"        \"additionalParams\": {"},{"line_number":1048,"context_line":"            \"lcm-operation-user-data\": \"./UserData/userdata_standard.py\","},{"line_number":1049,"context_line":"            \"lcm-operation-user-data-class\": \"StandardUserData\""}],"source_content_type":"text/x-python","patch_set":14,"id":"ce56faf5_ab65381c","line":1046,"updated":"2022-09-05 08:42:11.000000000","message":"typo: sholud -\u003e should","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e71c4ed118d853cdd33d465f6e70a6b74b6e37a1","unresolved":true,"context_lines":[{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"def sample3_heal():"},{"line_number":1045,"context_line":"    return {"},{"line_number":1046,"context_line":"        \"vnfcInstanceId\": [],  # sholud be filled"},{"line_number":1047,"context_line":"        \"additionalParams\": {"},{"line_number":1048,"context_line":"            \"lcm-operation-user-data\": \"./UserData/userdata_standard.py\","},{"line_number":1049,"context_line":"            \"lcm-operation-user-data-class\": \"StandardUserData\""}],"source_content_type":"text/x-python","patch_set":14,"id":"ed9ff4bc_1863a4d3","line":1046,"in_reply_to":"ce56faf5_ab65381c","updated":"2022-09-05 22:22:13.000000000","message":"I will fix.","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1a5963df655c1d7ef632a574e4e0ca69d0a81f1b","unresolved":false,"context_lines":[{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"def sample3_heal():"},{"line_number":1045,"context_line":"    return {"},{"line_number":1046,"context_line":"        \"vnfcInstanceId\": [],  # sholud be filled"},{"line_number":1047,"context_line":"        \"additionalParams\": {"},{"line_number":1048,"context_line":"            \"lcm-operation-user-data\": \"./UserData/userdata_standard.py\","},{"line_number":1049,"context_line":"            \"lcm-operation-user-data-class\": \"StandardUserData\""}],"source_content_type":"text/x-python","patch_set":14,"id":"fe0cf8d4_5823f604","line":1046,"in_reply_to":"ed9ff4bc_1863a4d3","updated":"2022-09-06 01:43:40.000000000","message":"Done","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard/contents/BaseHOT/simple/nested/VDU1.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":29,"context_line":"      - port:"},{"line_number":30,"context_line":"          get_resource: VDU1_CP2"},{"line_number":31,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f76b70c_7a688172","line":28,"updated":"2022-08-10 07:47:17.000000000","message":"One line too long.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":29,"context_line":"      - port:"},{"line_number":30,"context_line":"          get_resource: VDU1_CP2"},{"line_number":31,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"942fa49d_69dca570","line":28,"in_reply_to":"3f76b70c_7a688172","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":29,"context_line":"      - port:"},{"line_number":30,"context_line":"          get_resource: VDU1_CP2"},{"line_number":31,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"717fba67_6d1372ca","line":28,"in_reply_to":"942fa49d_69dca570","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":43,"context_line":"  VDU1_CP2:"},{"line_number":44,"context_line":"    type: OS::Neutron::Port"},{"line_number":45,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7e63fdf9_1755e668","line":42,"updated":"2022-08-10 07:47:17.000000000","message":"typo: extmangaedVLs -\u003e extmanagedVLs","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":43,"context_line":"  VDU1_CP2:"},{"line_number":44,"context_line":"    type: OS::Neutron::Port"},{"line_number":45,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba1cf125_5c5b2ce6","line":42,"in_reply_to":"7e63fdf9_1755e668","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":43,"context_line":"  VDU1_CP2:"},{"line_number":44,"context_line":"    type: OS::Neutron::Port"},{"line_number":45,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d9c70788_3bae127f","line":42,"in_reply_to":"ba1cf125_5c5b2ce6","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard/contents/BaseHOT/simple/nested/VDU2.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"      - port:"},{"line_number":32,"context_line":"          get_resource: VDU2_CP2"},{"line_number":33,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3be00256_4b2fc6bc","line":30,"updated":"2022-08-10 07:47:17.000000000","message":"One line too long.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"      - port:"},{"line_number":32,"context_line":"          get_resource: VDU2_CP2"},{"line_number":33,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7615ba7a_3ec72981","line":30,"in_reply_to":"3be00256_4b2fc6bc","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"      - port:"},{"line_number":32,"context_line":"          get_resource: VDU2_CP2"},{"line_number":33,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"502ef816_34a32dfa","line":30,"in_reply_to":"7615ba7a_3ec72981","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":55,"context_line":"      fixed_ips:"},{"line_number":56,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":59,"context_line":"  VDU2_CP2:"},{"line_number":60,"context_line":"    type: OS::Neutron::Port"},{"line_number":61,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"cb8fd303_843847c4","line":58,"updated":"2022-08-10 07:47:17.000000000","message":"typo: extmangaedVLs -\u003e extmanagedVLs","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      fixed_ips:"},{"line_number":56,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":59,"context_line":"  VDU2_CP2:"},{"line_number":60,"context_line":"    type: OS::Neutron::Port"},{"line_number":61,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fb2d35e1_877f5838","line":58,"in_reply_to":"6d11617c_85ca84b9","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":55,"context_line":"      fixed_ips:"},{"line_number":56,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":59,"context_line":"  VDU2_CP2:"},{"line_number":60,"context_line":"    type: OS::Neutron::Port"},{"line_number":61,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6d11617c_85ca84b9","line":58,"in_reply_to":"cb8fd303_843847c4","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard/contents/Scripts/sample_script.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"184ccaf6d5938cde4dde850fad54b654ca82368f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"dcd3e6b0_6c7af87e","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-08-04 05:44:10.000000000","message":"\u00272022\u0027 is correct.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"de44b924_e21e0493","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"22663e86_b3d58efa","updated":"2022-08-05 02:59:05.000000000","message":"Done","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d93b30a94d667febe55acb220127e7195b1b4a7b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"22663e86_b3d58efa","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"dcd3e6b0_6c7af87e","updated":"2022-08-04 23:08:25.000000000","message":"I will fix.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def instantiate_start(self):"},{"line_number":28,"context_line":"        if os.path.exists(\u0027/tmp/instantiate_start\u0027)"},{"line_number":29,"context_line":"            raise Execption(\u0027test instantiate_start error\u0027)"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, req, inst, grant_req, grant, csar_dir):"}],"source_content_type":"text/x-python","patch_set":8,"id":"4f2b81b7_e9d5f674","line":29,"updated":"2022-08-10 07:47:17.000000000","message":"typo: Execption -\u003e Exception","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def instantiate_start(self):"},{"line_number":28,"context_line":"        if os.path.exists(\u0027/tmp/instantiate_start\u0027)"},{"line_number":29,"context_line":"            raise Execption(\u0027test instantiate_start error\u0027)"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, req, inst, grant_req, grant, csar_dir):"}],"source_content_type":"text/x-python","patch_set":8,"id":"a9eab9ed_ed1349dd","line":29,"in_reply_to":"4f2b81b7_e9d5f674","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def instantiate_start(self):"},{"line_number":28,"context_line":"        if os.path.exists(\u0027/tmp/instantiate_start\u0027)"},{"line_number":29,"context_line":"            raise Execption(\u0027test instantiate_start error\u0027)"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, req, inst, grant_req, grant, csar_dir):"}],"source_content_type":"text/x-python","patch_set":8,"id":"de921f40_b51ccc38","line":29,"in_reply_to":"a9eab9ed_ed1349dd","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard/pkggen.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"184ccaf6d5938cde4dde850fad54b654ca82368f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"7122a87a_d7c7086d","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-08-04 05:44:10.000000000","message":"\u00272022\u0027 is correct.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d93b30a94d667febe55acb220127e7195b1b4a7b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"b5e09d5a_8e006243","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"7122a87a_d7c7086d","updated":"2022-08-04 23:08:25.000000000","message":"I will fix.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"e91352dc_799894b2","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"b5e09d5a_8e006243","updated":"2022-08-05 02:59:05.000000000","message":"Done","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg/contents/BaseHOT/simple/nested/VDU1.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":29,"context_line":"      - port:"},{"line_number":30,"context_line":"          get_resource: VDU1_CP2"},{"line_number":31,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"02dc548f_4374e1bc","line":28,"updated":"2022-08-10 07:47:17.000000000","message":"One line too long.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":29,"context_line":"      - port:"},{"line_number":30,"context_line":"          get_resource: VDU1_CP2"},{"line_number":31,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"15cade0e_09be32e6","line":28,"in_reply_to":"02dc548f_4374e1bc","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":29,"context_line":"      - port:"},{"line_number":30,"context_line":"          get_resource: VDU1_CP2"},{"line_number":31,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"da1994da_fd88398b","line":28,"in_reply_to":"15cade0e_09be32e6","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":43,"context_line":"  VDU1_CP2:"},{"line_number":44,"context_line":"    type: OS::Neutron::Port"},{"line_number":45,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"91ba1d73_bf4a6d78","line":42,"updated":"2022-08-10 07:47:17.000000000","message":"typo: extmangaedVLs -\u003e extmanagedVLs","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":43,"context_line":"  VDU1_CP2:"},{"line_number":44,"context_line":"    type: OS::Neutron::Port"},{"line_number":45,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"eb017d91_fec5dbb3","line":42,"in_reply_to":"63db94fb_b6450d9f","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":43,"context_line":"  VDU1_CP2:"},{"line_number":44,"context_line":"    type: OS::Neutron::Port"},{"line_number":45,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"63db94fb_b6450d9f","line":42,"in_reply_to":"91ba1d73_bf4a6d78","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg/contents/BaseHOT/simple/nested/VDU2.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"      - port:"},{"line_number":32,"context_line":"          get_resource: VDU2_CP2"},{"line_number":33,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1d1812fe_e47afb92","line":30,"updated":"2022-08-10 07:47:17.000000000","message":"One line too long.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"      - port:"},{"line_number":32,"context_line":"          get_resource: VDU2_CP2"},{"line_number":33,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f8fa6a06_ca59794a","line":30,"in_reply_to":"1d1812fe_e47afb92","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"      - port:"},{"line_number":32,"context_line":"          get_resource: VDU2_CP2"},{"line_number":33,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8ffe632c_96a04897","line":30,"in_reply_to":"f8fa6a06_ca59794a","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":55,"context_line":"      fixed_ips:"},{"line_number":56,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":59,"context_line":"  VDU2_CP2:"},{"line_number":60,"context_line":"    type: OS::Neutron::Port"},{"line_number":61,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"83a77ba5_bfc49ac9","line":58,"updated":"2022-08-10 07:47:17.000000000","message":"typo: extmangaedVLs -\u003e extmanagedVLs","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      fixed_ips:"},{"line_number":56,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":59,"context_line":"  VDU2_CP2:"},{"line_number":60,"context_line":"    type: OS::Neutron::Port"},{"line_number":61,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1e91d866_272da101","line":58,"in_reply_to":"4f2190ff_949ec8c9","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":55,"context_line":"      fixed_ips:"},{"line_number":56,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# CPs of internal VLs are deleted when extmangaedVLs and port are specified in instantiatevnfrequest"},{"line_number":59,"context_line":"  VDU2_CP2:"},{"line_number":60,"context_line":"    type: OS::Neutron::Port"},{"line_number":61,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4f2190ff_949ec8c9","line":58,"in_reply_to":"83a77ba5_bfc49ac9","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg/contents/Scripts/sample_script.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"184ccaf6d5938cde4dde850fad54b654ca82368f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd3287d1_5619fe4b","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-08-04 05:44:10.000000000","message":"\u00272022\u0027 is correct.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07ce95ff238ca65d003f6684ce5e9ec0e53d6110","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"0b789b5b_b10c3b1f","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"a5890da3_936e363a","updated":"2022-08-05 02:59:05.000000000","message":"Done","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d93b30a94d667febe55acb220127e7195b1b4a7b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2021 Nippon Telegraph and Telephone Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"a5890da3_936e363a","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"cd3287d1_5619fe4b","updated":"2022-08-04 23:08:25.000000000","message":"I will fix.","commit_id":"c1e3dd1f8407b6ec1ed4cba5e822ed49c85f311d"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"7239a01e93a19286baf379d85f9a930572c79e62","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def instantiate_start(self):"},{"line_number":28,"context_line":"        if os.path.exists(\u0027/tmp/instantiate_start\u0027)"},{"line_number":29,"context_line":"            raise Execption(\u0027test instantiate_start error\u0027)"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, req, inst, grant_req, grant, csar_dir):"}],"source_content_type":"text/x-python","patch_set":8,"id":"de065e02_6de0bf82","line":29,"updated":"2022-08-10 07:47:17.000000000","message":"typo: Execption -\u003e Exception","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"21c63ccd61eef0df63bd2438ffa85936ce63464e","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def instantiate_start(self):"},{"line_number":28,"context_line":"        if os.path.exists(\u0027/tmp/instantiate_start\u0027)"},{"line_number":29,"context_line":"            raise Execption(\u0027test instantiate_start error\u0027)"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, req, inst, grant_req, grant, csar_dir):"}],"source_content_type":"text/x-python","patch_set":8,"id":"d0b7e731_7ff798c1","line":29,"in_reply_to":"89165761_956b7300","updated":"2022-08-12 02:22:58.000000000","message":"Done","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"152235759efd1845a782187ae817f08796cfc8cc","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def instantiate_start(self):"},{"line_number":28,"context_line":"        if os.path.exists(\u0027/tmp/instantiate_start\u0027)"},{"line_number":29,"context_line":"            raise Execption(\u0027test instantiate_start error\u0027)"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def __init__(self, req, inst, grant_req, grant, csar_dir):"}],"source_content_type":"text/x-python","patch_set":8,"id":"89165761_956b7300","line":29,"in_reply_to":"de065e02_6de0bf82","updated":"2022-08-11 22:57:56.000000000","message":"I will fix.","commit_id":"f2ff699eecafd6d9f6dea1830f551d5377deb0c3"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg/pkggen.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"eaaae02ff43ea20aec6d08f5359bd747a7fca33e","unresolved":true,"context_lines":[{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2_common/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f56d14c_74e41596","line":32,"updated":"2022-09-05 08:42:11.000000000","message":"typo: smapleX -\u003e sampleX","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1a5963df655c1d7ef632a574e4e0ca69d0a81f1b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2_common/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":14,"id":"deb2e10d_c993f7ca","line":32,"in_reply_to":"12fa12a0_a73506a6","updated":"2022-09-06 01:43:40.000000000","message":"Done","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e71c4ed118d853cdd33d465f6e70a6b74b6e37a1","unresolved":true,"context_lines":[{"line_number":29,"context_line":"vnfd_id \u003d uuidutils.generate_uuid()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# tacker/tests/etc..."},{"line_number":32,"context_line":"#             /functional/sol_v2_common/samples/smapleX"},{"line_number":33,"context_line":"image_dir \u003d \"../../../../etc/samples/etsi/nfv/common/Files/images/\""},{"line_number":34,"context_line":"image_file \u003d \"cirros-0.5.2-x86_64-disk.img\""},{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"}],"source_content_type":"text/x-python","patch_set":14,"id":"12fa12a0_a73506a6","line":32,"in_reply_to":"1f56d14c_74e41596","updated":"2022-09-05 22:22:13.000000000","message":"I will fix.","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"eaaae02ff43ea20aec6d08f5359bd747a7fca33e","unresolved":true,"context_lines":[{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# tacker/sol_refactored/infra_drivers/openstack/userdata_standard.py"},{"line_number":38,"context_line":"#       /tests/functional/sol_v2_common/samples/smapleX"},{"line_number":39,"context_line":"userdata_dir \u003d \"../../../../../sol_refactored/infra_drivers/openstack/\""},{"line_number":40,"context_line":"userdata_file \u003d \"userdata_standard.py\""},{"line_number":41,"context_line":"userdata_path \u003d os.path.abspath(userdata_dir + userdata_file)"}],"source_content_type":"text/x-python","patch_set":14,"id":"2c858317_fae3a243","line":38,"updated":"2022-09-05 08:42:11.000000000","message":"typo: smapleX -\u003e sampleX","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e71c4ed118d853cdd33d465f6e70a6b74b6e37a1","unresolved":true,"context_lines":[{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# tacker/sol_refactored/infra_drivers/openstack/userdata_standard.py"},{"line_number":38,"context_line":"#       /tests/functional/sol_v2_common/samples/smapleX"},{"line_number":39,"context_line":"userdata_dir \u003d \"../../../../../sol_refactored/infra_drivers/openstack/\""},{"line_number":40,"context_line":"userdata_file \u003d \"userdata_standard.py\""},{"line_number":41,"context_line":"userdata_path \u003d os.path.abspath(userdata_dir + userdata_file)"}],"source_content_type":"text/x-python","patch_set":14,"id":"973d5bf4_f798637e","line":38,"in_reply_to":"2c858317_fae3a243","updated":"2022-09-05 22:22:13.000000000","message":"I will fix.","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"1a5963df655c1d7ef632a574e4e0ca69d0a81f1b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"image_path \u003d os.path.abspath(image_dir + image_file)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# tacker/sol_refactored/infra_drivers/openstack/userdata_standard.py"},{"line_number":38,"context_line":"#       /tests/functional/sol_v2_common/samples/smapleX"},{"line_number":39,"context_line":"userdata_dir \u003d \"../../../../../sol_refactored/infra_drivers/openstack/\""},{"line_number":40,"context_line":"userdata_file \u003d \"userdata_standard.py\""},{"line_number":41,"context_line":"userdata_path \u003d os.path.abspath(userdata_dir + userdata_file)"}],"source_content_type":"text/x-python","patch_set":14,"id":"df876fc2_e80913b3","line":38,"in_reply_to":"973d5bf4_f798637e","updated":"2022-09-06 01:43:40.000000000","message":"Done","commit_id":"c3095f32da180cc9fa3321317320fd63da5c5b03"}]}
