)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"6948b780648dbe258075a7618d1be8d8033ccb97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c18f5b1f_21374d91","updated":"2022-08-09 13:32:31.000000000","message":"recheck","commit_id":"982bd3aeb8bf0bcc35da8343e0598483c9a42ad4"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5653735a165f943ce8d0da65e88e89f792f3f4e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba5099ab_cb4307ee","updated":"2022-09-02 10:02:22.000000000","message":"Thanks for your patch, almost LGTM, but I have some tiny comments.\nPlease kindly check my comments.","commit_id":"7e372645d293f19ff9cd3c65df60323dabf2fc45"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"97abf642d4a1881cb1ec3a9bd72f677aac2ae113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7738b0b3_7ad21080","updated":"2022-09-03 15:33:40.000000000","message":"Thanks Ueha san for review. Incorporate the review comments in Patchset 5.","commit_id":"92f52690175ccee30c635c3387a1fd416bf16bee"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f60d5acec8a713bf4ebda932d90e888bbe456f41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"950e6e13_e931635a","updated":"2022-09-05 08:30:05.000000000","message":"Thanks for your rework, LGTM","commit_id":"92f52690175ccee30c635c3387a1fd416bf16bee"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"9aacb5b78c97c5452c4f56e2a5b55f70eb6bee10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7454fca6_c058890f","updated":"2022-09-03 09:37:14.000000000","message":"recheck","commit_id":"92f52690175ccee30c635c3387a1fd416bf16bee"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"573d78a16950633995efde3287675cb12668282e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7d7fd932_eaddea2f","updated":"2022-09-07 14:47:46.000000000","message":"LGTM, thanks!","commit_id":"d5a97c5ffbf114fbc38bb3047a1c616099e37e99"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b2bc913c1f24e454d14ac0c9ee5182db1bf87a98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"77147437_e427bb15","updated":"2022-09-07 13:59:59.000000000","message":"Thanks Ogawa san for the review. Please find changes in Patchset 6.","commit_id":"d5a97c5ffbf114fbc38bb3047a1c616099e37e99"}],"tacker/objects/vnf_lcm_subscriptions.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5653735a165f943ce8d0da65e88e89f792f3f4e7","unresolved":true,"context_lines":[{"line_number":211,"context_line":"             \"from vnf_lcm_subscriptions \""},{"line_number":212,"context_line":"             \"where id \u003d :subsc_id \""},{"line_number":213,"context_line":"             \"and deleted \u003d 0 \""},{"line_number":214,"context_line":"             \"and tenant_id \u003d :tnt_id\")"},{"line_number":215,"context_line":"    result_line \u003d \"\""},{"line_number":216,"context_line":"    try:"},{"line_number":217,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionsId,"}],"source_content_type":"text/x-python","patch_set":3,"id":"778e9e67_3e69d5b3","line":214,"range":{"start_line":214,"start_character":31,"end_line":214,"end_character":37},"updated":"2022-09-02 10:02:22.000000000","message":"nit: Why is this not \"tenant_id\" like L.172?","commit_id":"4c4b53b82dc8598eda25be382445c3168edfc0c1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f60d5acec8a713bf4ebda932d90e888bbe456f41","unresolved":false,"context_lines":[{"line_number":211,"context_line":"             \"from vnf_lcm_subscriptions \""},{"line_number":212,"context_line":"             \"where id \u003d :subsc_id \""},{"line_number":213,"context_line":"             \"and deleted \u003d 0 \""},{"line_number":214,"context_line":"             \"and tenant_id \u003d :tnt_id\")"},{"line_number":215,"context_line":"    result_line \u003d \"\""},{"line_number":216,"context_line":"    try:"},{"line_number":217,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionsId,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c6908d0a_ce32f419","line":214,"range":{"start_line":214,"start_character":31,"end_line":214,"end_character":37},"in_reply_to":"370397ab_2cfcae1b","updated":"2022-09-05 08:30:05.000000000","message":"ACK","commit_id":"4c4b53b82dc8598eda25be382445c3168edfc0c1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"97abf642d4a1881cb1ec3a9bd72f677aac2ae113","unresolved":false,"context_lines":[{"line_number":211,"context_line":"             \"from vnf_lcm_subscriptions \""},{"line_number":212,"context_line":"             \"where id \u003d :subsc_id \""},{"line_number":213,"context_line":"             \"and deleted \u003d 0 \""},{"line_number":214,"context_line":"             \"and tenant_id \u003d :tnt_id\")"},{"line_number":215,"context_line":"    result_line \u003d \"\""},{"line_number":216,"context_line":"    try:"},{"line_number":217,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionsId,"}],"source_content_type":"text/x-python","patch_set":3,"id":"370397ab_2cfcae1b","line":214,"range":{"start_line":214,"start_character":31,"end_line":214,"end_character":37},"in_reply_to":"778e9e67_3e69d5b3","updated":"2022-09-03 15:33:40.000000000","message":"Done","commit_id":"4c4b53b82dc8598eda25be382445c3168edfc0c1"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d6b04f2d9609df835c7fbcb9de490f35eab93d54","unresolved":true,"context_lines":[{"line_number":161,"context_line":"@db_api.context_manager.reader"},{"line_number":162,"context_line":"def _vnf_lcm_subscriptions_show(context, subscriptionId):"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    sql \u003d text("},{"line_number":165,"context_line":"        \"select \""},{"line_number":166,"context_line":"        \"t1.id,t1.callback_uri,t1.tenant_id,t2.filter \""},{"line_number":167,"context_line":"        \"from vnf_lcm_subscriptions t1, \""},{"line_number":168,"context_line":"        \"(select distinct subscription_uuid,filter from vnf_lcm_filters) t2 \""},{"line_number":169,"context_line":"        \"where t1.id \u003d t2.subscription_uuid \""},{"line_number":170,"context_line":"        \"and deleted \u003d 0 \""},{"line_number":171,"context_line":"        \"and t1.id \u003d :subsc_id \""},{"line_number":172,"context_line":"        \"and t1.tenant_id \u003d :tenant_id\")"},{"line_number":173,"context_line":"    result_line \u003d \"\""},{"line_number":174,"context_line":"    try:"},{"line_number":175,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionId,"}],"source_content_type":"text/x-python","patch_set":5,"id":"a2614ccb_82ef4fb4","line":172,"range":{"start_line":164,"start_character":0,"end_line":172,"end_character":40},"updated":"2022-09-05 19:15:04.000000000","message":"I think you\u0027ll agree that it has been more complicated than we designed. So, It\u0027s better to add a trick for helping understanding of users such as comment for the purpose of the SQL or so. What do you think?","commit_id":"92f52690175ccee30c635c3387a1fd416bf16bee"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b2bc913c1f24e454d14ac0c9ee5182db1bf87a98","unresolved":false,"context_lines":[{"line_number":161,"context_line":"@db_api.context_manager.reader"},{"line_number":162,"context_line":"def _vnf_lcm_subscriptions_show(context, subscriptionId):"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    sql \u003d text("},{"line_number":165,"context_line":"        \"select \""},{"line_number":166,"context_line":"        \"t1.id,t1.callback_uri,t1.tenant_id,t2.filter \""},{"line_number":167,"context_line":"        \"from vnf_lcm_subscriptions t1, \""},{"line_number":168,"context_line":"        \"(select distinct subscription_uuid,filter from vnf_lcm_filters) t2 \""},{"line_number":169,"context_line":"        \"where t1.id \u003d t2.subscription_uuid \""},{"line_number":170,"context_line":"        \"and deleted \u003d 0 \""},{"line_number":171,"context_line":"        \"and t1.id \u003d :subsc_id \""},{"line_number":172,"context_line":"        \"and t1.tenant_id \u003d :tenant_id\")"},{"line_number":173,"context_line":"    result_line \u003d \"\""},{"line_number":174,"context_line":"    try:"},{"line_number":175,"context_line":"        result \u003d context.session.execute(sql, {\u0027subsc_id\u0027: subscriptionId,"}],"source_content_type":"text/x-python","patch_set":5,"id":"69e59a65_a8f22a6a","line":172,"range":{"start_line":164,"start_character":0,"end_line":172,"end_character":40},"in_reply_to":"a2614ccb_82ef4fb4","updated":"2022-09-07 13:59:59.000000000","message":"Done!!\nYes I agree, and added a comment to explain SQL query.","commit_id":"92f52690175ccee30c635c3387a1fd416bf16bee"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d6b04f2d9609df835c7fbcb9de490f35eab93d54","unresolved":true,"context_lines":[{"line_number":176,"context_line":"            \u0027tenant_id\u0027: context.project_id})"},{"line_number":177,"context_line":"        for line in result:"},{"line_number":178,"context_line":"            result_line \u003d line"},{"line_number":179,"context_line":"    except exceptions.NotFound:"},{"line_number":180,"context_line":"        return None"},{"line_number":181,"context_line":"    except Exception as e:"},{"line_number":182,"context_line":"        raise e"}],"source_content_type":"text/x-python","patch_set":5,"id":"1cd71d8b_6da74249","line":179,"updated":"2022-09-05 19:15:04.000000000","message":"No need to output some logs for the case?","commit_id":"92f52690175ccee30c635c3387a1fd416bf16bee"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b2bc913c1f24e454d14ac0c9ee5182db1bf87a98","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            \u0027tenant_id\u0027: context.project_id})"},{"line_number":177,"context_line":"        for line in result:"},{"line_number":178,"context_line":"            result_line \u003d line"},{"line_number":179,"context_line":"    except exceptions.NotFound:"},{"line_number":180,"context_line":"        return None"},{"line_number":181,"context_line":"    except Exception as e:"},{"line_number":182,"context_line":"        raise e"}],"source_content_type":"text/x-python","patch_set":5,"id":"94d79b3c_74dee3f0","line":179,"in_reply_to":"1cd71d8b_6da74249","updated":"2022-09-07 13:59:59.000000000","message":"Done, added error log.","commit_id":"92f52690175ccee30c635c3387a1fd416bf16bee"}],"tacker/tests/unit/objects/test_vnf_lcm_subscriptions.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5653735a165f943ce8d0da65e88e89f792f3f4e7","unresolved":true,"context_lines":[{"line_number":209,"context_line":"    def test_show_for_invalid_tenant_id(self, mock_vnf_lcm_subscriptions_show):"},{"line_number":210,"context_line":"        mock_vnf_lcm_subscriptions_show.return_value \u003d None"},{"line_number":211,"context_line":"        self.context.tenant_id \u003d 12345"},{"line_number":212,"context_line":"        subscription_obj \u003d \\"},{"line_number":213,"context_line":"            objects.vnf_lcm_subscriptions.LccnSubscriptionRequest("},{"line_number":214,"context_line":"                context\u003dself.context)"},{"line_number":215,"context_line":"        result \u003d subscription_obj.vnf_lcm_subscriptions_show("}],"source_content_type":"text/x-python","patch_set":3,"id":"a6fd2948_95059ac5","line":212,"range":{"start_line":212,"start_character":27,"end_line":212,"end_character":28},"updated":"2022-09-02 10:02:22.000000000","message":"Could you change to not use backslash as line break?","commit_id":"4c4b53b82dc8598eda25be382445c3168edfc0c1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f60d5acec8a713bf4ebda932d90e888bbe456f41","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    def test_show_for_invalid_tenant_id(self, mock_vnf_lcm_subscriptions_show):"},{"line_number":210,"context_line":"        mock_vnf_lcm_subscriptions_show.return_value \u003d None"},{"line_number":211,"context_line":"        self.context.tenant_id \u003d 12345"},{"line_number":212,"context_line":"        subscription_obj \u003d \\"},{"line_number":213,"context_line":"            objects.vnf_lcm_subscriptions.LccnSubscriptionRequest("},{"line_number":214,"context_line":"                context\u003dself.context)"},{"line_number":215,"context_line":"        result \u003d subscription_obj.vnf_lcm_subscriptions_show("}],"source_content_type":"text/x-python","patch_set":3,"id":"1ba9daa6_c2f702e8","line":212,"range":{"start_line":212,"start_character":27,"end_line":212,"end_character":28},"in_reply_to":"21abe106_8a2ceb54","updated":"2022-09-05 08:30:05.000000000","message":"ACK","commit_id":"4c4b53b82dc8598eda25be382445c3168edfc0c1"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"97abf642d4a1881cb1ec3a9bd72f677aac2ae113","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    def test_show_for_invalid_tenant_id(self, mock_vnf_lcm_subscriptions_show):"},{"line_number":210,"context_line":"        mock_vnf_lcm_subscriptions_show.return_value \u003d None"},{"line_number":211,"context_line":"        self.context.tenant_id \u003d 12345"},{"line_number":212,"context_line":"        subscription_obj \u003d \\"},{"line_number":213,"context_line":"            objects.vnf_lcm_subscriptions.LccnSubscriptionRequest("},{"line_number":214,"context_line":"                context\u003dself.context)"},{"line_number":215,"context_line":"        result \u003d subscription_obj.vnf_lcm_subscriptions_show("}],"source_content_type":"text/x-python","patch_set":3,"id":"21abe106_8a2ceb54","line":212,"range":{"start_line":212,"start_character":27,"end_line":212,"end_character":28},"in_reply_to":"a6fd2948_95059ac5","updated":"2022-09-03 15:33:40.000000000","message":"Done","commit_id":"4c4b53b82dc8598eda25be382445c3168edfc0c1"}]}
