)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"2367a6b0f4ed83aa6e0678d5797d188af496da49","unresolved":true,"context_lines":[{"line_number":11,"context_line":"If there are differences in the Pod information,"},{"line_number":12,"context_line":"it will synchronize the TackerDB information with the"},{"line_number":13,"context_line":"Kubernetes information."},{"line_number":14,"context_line":"This process is performed periodically."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint database-synchronization"},{"line_number":17,"context_line":"Change-Id: I7bb00d9cc0a6f110a68cdb4ecc2bc10665dcdacc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1adc2896_d3a0e6c8","line":14,"updated":"2022-09-15 07:52:50.000000000","message":"I think the interval of synchronization is configurable, so please add the description.\n\n```\nThis process is performed periodically, and its interval is configurable. \n```","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":11,"context_line":"If there are differences in the Pod information,"},{"line_number":12,"context_line":"it will synchronize the TackerDB information with the"},{"line_number":13,"context_line":"Kubernetes information."},{"line_number":14,"context_line":"This process is performed periodically."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint database-synchronization"},{"line_number":17,"context_line":"Change-Id: I7bb00d9cc0a6f110a68cdb4ecc2bc10665dcdacc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5e1227f5_a6f7d1ee","line":14,"in_reply_to":"1adc2896_d3a0e6c8","updated":"2022-09-15 10:00:03.000000000","message":"I fixed it in patchset 13.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7ed8c487a5cbafbe71f300468beedd084982c24d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"If there are differences in the Pod information,"},{"line_number":12,"context_line":"it will synchronize the TackerDB information with the"},{"line_number":13,"context_line":"Kubernetes information."},{"line_number":14,"context_line":"This process is performed periodically."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Implements: blueprint database-synchronization"},{"line_number":17,"context_line":"Change-Id: I7bb00d9cc0a6f110a68cdb4ecc2bc10665dcdacc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"deb656f1_c801046e","line":14,"in_reply_to":"5e1227f5_a6f7d1ee","updated":"2022-09-16 04:30:09.000000000","message":"Done","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"6e6499346620ecfa1825e6d81d10c2ad5a13dffb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"44194f0d_2016cfa1","updated":"2022-09-15 05:53:18.000000000","message":"Thank you for posting this patch. I have made some comments, please check them.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"2367a6b0f4ed83aa6e0678d5797d188af496da49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aeada816_5c100cd6","updated":"2022-09-15 07:52:50.000000000","message":"Thank you for your patch. Please check my comments.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"82a5e92560af534b17dd3e3799ab6a19913ebf57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"618e3914_6bbb3f07","updated":"2022-09-14 14:03:48.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"a9626de19e906ff010e2e506a79fbda41fcacd99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0cf63f9f_94dc0ebd","updated":"2022-09-15 22:24:28.000000000","message":"Thank you for your work.","commit_id":"198fb4cfa7df5fbdb98b76489bbf8fb64f22f6a2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e1965f7f78db2ec3d09f3c41a3b8684dc4750e48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d22824a4_e563409f","updated":"2022-09-15 13:56:12.000000000","message":"Thanks for your rework, I will put CR+2 after Zuul+1 and other reviewers checked fixes.","commit_id":"198fb4cfa7df5fbdb98b76489bbf8fb64f22f6a2"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"1fb597976872669783e67af81a91f2b7f4a7dfa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"9480e596_a74c3c2e","updated":"2022-09-16 04:09:02.000000000","message":"Thank you for your patch.\nLGTM","commit_id":"a0ef0cbef6f8ea03a03ed715da96e7ee7f740790"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3cf1aa6219cec778e609daeb528dcaa11dca9fa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b4914d3f_4b492516","updated":"2022-09-16 05:09:26.000000000","message":"recheck","commit_id":"a0ef0cbef6f8ea03a03ed715da96e7ee7f740790"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a08170e3b762f831177d8d9c5864c1f8aaec6808","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"86e6b50f_db021cae","updated":"2022-09-16 11:06:10.000000000","message":"recheck","commit_id":"0e2434d9c25adcd9642c57ba96651917440522a9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"bdc959a0936e6eab5a1b5fe9d1afeaa847e4a851","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d82c12c9_e566df71","updated":"2022-09-16 13:09:03.000000000","message":"recheck","commit_id":"0e2434d9c25adcd9642c57ba96651917440522a9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d80f862d0d53210944725298012cb386a796d4b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8391a80b_fa269233","updated":"2022-09-16 09:10:18.000000000","message":"recheck\n\nIt seems that gate will not be re-executed when WF+1 is re-set...\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\u003e A patchset has to be approved to run tests in the gate pipeline. If the patchset has failed in the gate pipeline (it will have been approved to get into the gate pipeline) a recheck will first run the check jobs and if those pass, it will again run the gate jobs. There is no way to only run the gate jobs, the check jobs will first be run again.\n","commit_id":"0e2434d9c25adcd9642c57ba96651917440522a9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7dd67461c66f0a023ef2a6294a4136c31915af57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b073032b_153ec44b","updated":"2022-09-16 09:04:26.000000000","message":"try it again!","commit_id":"0e2434d9c25adcd9642c57ba96651917440522a9"}],"releasenotes/notes/database_synchronaization-ed47b552227892cf.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1c7c03b7ad94d742228a6fa5527b7ad04c535207","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    There is no interface on the K8s to notify Tacker when the auto-scale or"},{"line_number":5,"context_line":"    auto-heal of a pod is running and the pod information is updated."},{"line_number":6,"context_line":"    This can lead to inconsistencies between the Pod information in Tacker"},{"line_number":7,"context_line":"    database and the Pod information running on the actual K8s."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"30ef61d3_56e5767e","line":4,"updated":"2022-09-14 18:15:18.000000000","message":"Could you describe what is introduced in the release first as a new feature for releasenotes?","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    There is no interface on the K8s to notify Tacker when the auto-scale or"},{"line_number":5,"context_line":"    auto-heal of a pod is running and the pod information is updated."},{"line_number":6,"context_line":"    This can lead to inconsistencies between the Pod information in Tacker"},{"line_number":7,"context_line":"    database and the Pod information running on the actual K8s."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"b1acdefa_c41bf277","line":4,"in_reply_to":"30ef61d3_56e5767e","updated":"2022-09-15 10:00:03.000000000","message":"I have added a description.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1c7c03b7ad94d742228a6fa5527b7ad04c535207","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    database and the Pod information running on the actual K8s."},{"line_number":8,"context_line":"    This function periodically checks the pod information in the Tacker"},{"line_number":9,"context_line":"    database and the pod information in the K8s, and updates the information"},{"line_number":10,"context_line":"    in the Tacker database according to the K8s side if there is "},{"line_number":11,"context_line":"    any inconsistency."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"254644c6_580d9b5b","line":10,"range":{"start_line":10,"start_character":64,"end_line":10,"end_character":65},"updated":"2022-09-14 18:15:18.000000000","message":"nit: no need trailing blank","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    database and the Pod information running on the actual K8s."},{"line_number":8,"context_line":"    This function periodically checks the pod information in the Tacker"},{"line_number":9,"context_line":"    database and the pod information in the K8s, and updates the information"},{"line_number":10,"context_line":"    in the Tacker database according to the K8s side if there is "},{"line_number":11,"context_line":"    any inconsistency."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"0578f5a1_c15dcb96","line":10,"range":{"start_line":10,"start_character":64,"end_line":10,"end_character":65},"in_reply_to":"254644c6_580d9b5b","updated":"2022-09-15 10:00:03.000000000","message":"I fixed it in patchset 13.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"82a5e92560af534b17dd3e3799ab6a19913ebf57","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    database and the Pod information running on the actual K8s."},{"line_number":8,"context_line":"    This function periodically checks the pod information in the Tacker"},{"line_number":9,"context_line":"    database and the pod information in the K8s, and updates the information"},{"line_number":10,"context_line":"    in the Tacker database according to the K8s side if there is "},{"line_number":11,"context_line":"    any inconsistency."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"09506ded_38ba7bed","line":10,"range":{"start_line":10,"start_character":64,"end_line":10,"end_character":65},"updated":"2022-09-14 14:03:48.000000000","message":"Could you remove trailing space character?","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    database and the Pod information running on the actual K8s."},{"line_number":8,"context_line":"    This function periodically checks the pod information in the Tacker"},{"line_number":9,"context_line":"    database and the pod information in the K8s, and updates the information"},{"line_number":10,"context_line":"    in the Tacker database according to the K8s side if there is "},{"line_number":11,"context_line":"    any inconsistency."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7e22ea6b_422a2e42","line":10,"range":{"start_line":10,"start_character":64,"end_line":10,"end_character":65},"in_reply_to":"09506ded_38ba7bed","updated":"2022-09-15 10:00:03.000000000","message":"I fixed it in patchset 13.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e1965f7f78db2ec3d09f3c41a3b8684dc4750e48","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    database and the Pod information running on the actual K8s."},{"line_number":8,"context_line":"    This function periodically checks the pod information in the Tacker"},{"line_number":9,"context_line":"    database and the pod information in the K8s, and updates the information"},{"line_number":10,"context_line":"    in the Tacker database according to the K8s side if there is "},{"line_number":11,"context_line":"    any inconsistency."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"54affac8_540f405a","line":10,"range":{"start_line":10,"start_character":64,"end_line":10,"end_character":65},"in_reply_to":"7e22ea6b_422a2e42","updated":"2022-09-15 13:56:12.000000000","message":"Ack","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1c7c03b7ad94d742228a6fa5527b7ad04c535207","unresolved":true,"context_lines":[{"line_number":77,"context_line":"from tacker.vnfm import plugin"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"CONF \u003d tacker.conf.CONF"},{"line_number":80,"context_line":"DB_SYNC_INITIAL_DELAY \u003d 60"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# NOTE(tpatil): keystone_authtoken opts registered explicitly as conductor"},{"line_number":83,"context_line":"# service doesn\u0027t use the keystonemiddleware.authtoken middleware as it\u0027s"}],"source_content_type":"text/x-python","patch_set":11,"id":"110d1c1c_70deea24","line":80,"updated":"2022-09-14 18:15:18.000000000","message":"Could you add a short note for explaining the purpose of this value why the DELAY is required?","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":77,"context_line":"from tacker.vnfm import plugin"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"CONF \u003d tacker.conf.CONF"},{"line_number":80,"context_line":"DB_SYNC_INITIAL_DELAY \u003d 60"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# NOTE(tpatil): keystone_authtoken opts registered explicitly as conductor"},{"line_number":83,"context_line":"# service doesn\u0027t use the keystonemiddleware.authtoken middleware as it\u0027s"}],"source_content_type":"text/x-python","patch_set":11,"id":"beff39f4_a67e63b8","line":80,"in_reply_to":"110d1c1c_70deea24","updated":"2022-09-15 10:00:03.000000000","message":"I have added a note.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1c7c03b7ad94d742228a6fa5527b7ad04c535207","unresolved":true,"context_lines":[{"line_number":2492,"context_line":""},{"line_number":2493,"context_line":"    def _database_synchronization(self):"},{"line_number":2494,"context_line":"        \"\"\"Periodic database update invocation method\"\"\""},{"line_number":2495,"context_line":"        LOG.debug(\"Starting database_synchronization v1\")"},{"line_number":2496,"context_line":"        context \u003d t_context.get_admin_context()"},{"line_number":2497,"context_line":"        self.vnflcm_driver.database_synchronization(context)"},{"line_number":2498,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"49e555b8_dcb1c226","line":2495,"updated":"2022-09-14 18:15:18.000000000","message":"* Is \"v1\" required actually?\n* \"_database_synchronization\" correctly?","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":2492,"context_line":""},{"line_number":2493,"context_line":"    def _database_synchronization(self):"},{"line_number":2494,"context_line":"        \"\"\"Periodic database update invocation method\"\"\""},{"line_number":2495,"context_line":"        LOG.debug(\"Starting database_synchronization v1\")"},{"line_number":2496,"context_line":"        context \u003d t_context.get_admin_context()"},{"line_number":2497,"context_line":"        self.vnflcm_driver.database_synchronization(context)"},{"line_number":2498,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"cb1acb27_a9de8676","line":2495,"in_reply_to":"49e555b8_dcb1c226","updated":"2022-09-15 10:00:03.000000000","message":"* It was originally intended to distinguish between `v1` and `v2`, now `v1` and `v2` have been deleted from the log.\n* I changed `database_synchronization` to `_sync_db`.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"}],"tacker/conf/conductor.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1c7c03b7ad94d742228a6fa5527b7ad04c535207","unresolved":true,"context_lines":[{"line_number":25,"context_line":"                      \u0027to cleanup residues of deleted vnf packages\u0027)),"},{"line_number":26,"context_line":"    cfg.IntOpt(\u0027db_synchronization_interval\u0027,"},{"line_number":27,"context_line":"               default\u003d300,"},{"line_number":28,"context_line":"               help\u003d_(\u0027Seconds between running periodic tasks \u0027"},{"line_number":29,"context_line":"                      \u0027to database synchronization between tacker \u0027"},{"line_number":30,"context_line":"                      \u0027db and kubernetes\u0027)),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"aeaadc9a_079ab1bc","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":44},"updated":"2022-09-14 18:15:18.000000000","message":"Just a little bit long for. How about this one instead?\n\"Interval time in sec for DB sync between Tacker and Kubernetes VIMs\"","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":25,"context_line":"                      \u0027to cleanup residues of deleted vnf packages\u0027)),"},{"line_number":26,"context_line":"    cfg.IntOpt(\u0027db_synchronization_interval\u0027,"},{"line_number":27,"context_line":"               default\u003d300,"},{"line_number":28,"context_line":"               help\u003d_(\u0027Seconds between running periodic tasks \u0027"},{"line_number":29,"context_line":"                      \u0027to database synchronization between tacker \u0027"},{"line_number":30,"context_line":"                      \u0027db and kubernetes\u0027)),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"4cdf2b2e_4335718c","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":44},"in_reply_to":"aeaadc9a_079ab1bc","updated":"2022-09-15 10:00:03.000000000","message":"I fixed it in patchset 13.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"}],"tacker/sol_refactored/conductor/conductor_v2.py":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"6e6499346620ecfa1825e6d81d10c2ad5a13dffb","unresolved":true,"context_lines":[{"line_number":363,"context_line":"    @coordinate.lock_vnf_instance(\u0027{inst.id}\u0027)"},{"line_number":364,"context_line":"    def _sync_inst(self, context, inst, vim_info):"},{"line_number":365,"context_line":"        vnf_inst \u003d inst_utils.get_inst(context, inst.id)"},{"line_number":366,"context_line":"        LOG.debug(\"Before DB sync, the vnf_instance is: \""},{"line_number":367,"context_line":"                  f\"{vnf_inst.to_dict()}\")"},{"line_number":368,"context_line":"        self.vnflcm_driver.database_synchronization("},{"line_number":369,"context_line":"            context, vnf_inst, vim_info)"},{"line_number":370,"context_line":"        vnf_inst.update(context)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a6c996d_4e77286c","line":367,"range":{"start_line":366,"start_character":8,"end_line":367,"end_character":42},"updated":"2022-09-15 05:53:18.000000000","message":"Why is this log in v2 but not in v1? And If this log is output by each VNF instance, output log is assumed that there will be a lot of it. So, I don\u0027t think it is need to output the log here, what do you think?","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"a9626de19e906ff010e2e506a79fbda41fcacd99","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    @coordinate.lock_vnf_instance(\u0027{inst.id}\u0027)"},{"line_number":364,"context_line":"    def _sync_inst(self, context, inst, vim_info):"},{"line_number":365,"context_line":"        vnf_inst \u003d inst_utils.get_inst(context, inst.id)"},{"line_number":366,"context_line":"        LOG.debug(\"Before DB sync, the vnf_instance is: \""},{"line_number":367,"context_line":"                  f\"{vnf_inst.to_dict()}\")"},{"line_number":368,"context_line":"        self.vnflcm_driver.database_synchronization("},{"line_number":369,"context_line":"            context, vnf_inst, vim_info)"},{"line_number":370,"context_line":"        vnf_inst.update(context)"}],"source_content_type":"text/x-python","patch_set":12,"id":"0e3acb74_8f59046b","line":367,"range":{"start_line":366,"start_character":8,"end_line":367,"end_character":42},"in_reply_to":"42d46878_6b81bace","updated":"2022-09-15 22:24:28.000000000","message":"I have confirmed it.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":363,"context_line":"    @coordinate.lock_vnf_instance(\u0027{inst.id}\u0027)"},{"line_number":364,"context_line":"    def _sync_inst(self, context, inst, vim_info):"},{"line_number":365,"context_line":"        vnf_inst \u003d inst_utils.get_inst(context, inst.id)"},{"line_number":366,"context_line":"        LOG.debug(\"Before DB sync, the vnf_instance is: \""},{"line_number":367,"context_line":"                  f\"{vnf_inst.to_dict()}\")"},{"line_number":368,"context_line":"        self.vnflcm_driver.database_synchronization("},{"line_number":369,"context_line":"            context, vnf_inst, vim_info)"},{"line_number":370,"context_line":"        vnf_inst.update(context)"}],"source_content_type":"text/x-python","patch_set":12,"id":"42d46878_6b81bace","line":367,"range":{"start_line":366,"start_character":8,"end_line":367,"end_character":42},"in_reply_to":"5a6c996d_4e77286c","updated":"2022-09-15 10:00:03.000000000","message":"I see, I deleted the log here.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"6e6499346620ecfa1825e6d81d10c2ad5a13dffb","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        self.vnflcm_driver.database_synchronization("},{"line_number":369,"context_line":"            context, vnf_inst, vim_info)"},{"line_number":370,"context_line":"        vnf_inst.update(context)"},{"line_number":371,"context_line":"        LOG.debug(\"After DB sync, the vnf_instance is: \""},{"line_number":372,"context_line":"                  f\"{vnf_inst.to_dict()}\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"e1ef9c66_446de237","line":372,"range":{"start_line":371,"start_character":8,"end_line":372,"end_character":42},"updated":"2022-09-15 05:53:18.000000000","message":"ditto","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":368,"context_line":"        self.vnflcm_driver.database_synchronization("},{"line_number":369,"context_line":"            context, vnf_inst, vim_info)"},{"line_number":370,"context_line":"        vnf_inst.update(context)"},{"line_number":371,"context_line":"        LOG.debug(\"After DB sync, the vnf_instance is: \""},{"line_number":372,"context_line":"                  f\"{vnf_inst.to_dict()}\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"ee4f8841_2639d46c","line":372,"range":{"start_line":371,"start_character":8,"end_line":372,"end_character":42},"in_reply_to":"e1ef9c66_446de237","updated":"2022-09-15 10:00:03.000000000","message":"I see, I deleted the log here.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"a9626de19e906ff010e2e506a79fbda41fcacd99","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        self.vnflcm_driver.database_synchronization("},{"line_number":369,"context_line":"            context, vnf_inst, vim_info)"},{"line_number":370,"context_line":"        vnf_inst.update(context)"},{"line_number":371,"context_line":"        LOG.debug(\"After DB sync, the vnf_instance is: \""},{"line_number":372,"context_line":"                  f\"{vnf_inst.to_dict()}\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff71bf9f_1d1b128e","line":372,"range":{"start_line":371,"start_character":8,"end_line":372,"end_character":42},"in_reply_to":"ee4f8841_2639d46c","updated":"2022-09-15 22:24:28.000000000","message":"I have confirmed it.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"}],"tacker/sol_refactored/conductor/vnflcm_driver_v2.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1c7c03b7ad94d742228a6fa5527b7ad04c535207","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"            # should not occur"},{"line_number":1131,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    def database_synchronization(self, context):"},{"line_number":1134,"context_line":"        vnf_instance \u003d objects.VnfInstanceV2.get_by_filter(context,"},{"line_number":1135,"context_line":"            instantiationState\u003d\u0027INSTANTIATED\u0027)"},{"line_number":1136,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3b3e60e7_3460d656","line":1133,"range":{"start_line":1133,"start_character":8,"end_line":1133,"end_character":32},"updated":"2022-09-14 18:15:18.000000000","message":"For the name of function, starting from a verb with simple form, such as \"sync_db\", should be better especially for a member of a class.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":1130,"context_line":"            # should not occur"},{"line_number":1131,"context_line":"            raise sol_ex.SolException(sol_detail\u003d\u0027not support vim type\u0027)"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    def database_synchronization(self, context):"},{"line_number":1134,"context_line":"        vnf_instance \u003d objects.VnfInstanceV2.get_by_filter(context,"},{"line_number":1135,"context_line":"            instantiationState\u003d\u0027INSTANTIATED\u0027)"},{"line_number":1136,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9696eca2_3cdcd5bc","line":1133,"range":{"start_line":1133,"start_character":8,"end_line":1133,"end_character":32},"in_reply_to":"3b3e60e7_3460d656","updated":"2022-09-15 10:00:03.000000000","message":"I modified the function name.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1c7c03b7ad94d742228a6fa5527b7ad04c535207","unresolved":true,"context_lines":[{"line_number":1146,"context_line":"                                                    vim_info)"},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":"            except sol_ex.OtherOperationInProgress:"},{"line_number":1149,"context_line":"                LOG.info(f\"Database synchronization skipped {vnf_inst.id}\""},{"line_number":1150,"context_line":"                         \" resources.\")"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"            except Exception as e:"},{"line_number":1153,"context_line":"                LOG.error(\"Failed to synchronaization database \""}],"source_content_type":"text/x-python","patch_set":11,"id":"56cd38ab_49e4ceaa","line":1150,"range":{"start_line":1149,"start_character":27,"end_line":1150,"end_character":37},"updated":"2022-09-14 18:15:18.000000000","message":"Please revise this message because it cannot be understood for OtherOperationInProgress. It doesn\u0027t tell anything why it skipped.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":1146,"context_line":"                                                    vim_info)"},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":"            except sol_ex.OtherOperationInProgress:"},{"line_number":1149,"context_line":"                LOG.info(f\"Database synchronization skipped {vnf_inst.id}\""},{"line_number":1150,"context_line":"                         \" resources.\")"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"            except Exception as e:"},{"line_number":1153,"context_line":"                LOG.error(\"Failed to synchronaization database \""}],"source_content_type":"text/x-python","patch_set":11,"id":"040ca6ed_4c5270ce","line":1150,"range":{"start_line":1149,"start_character":27,"end_line":1150,"end_character":37},"in_reply_to":"56cd38ab_49e4ceaa","updated":"2022-09-15 10:00:03.000000000","message":"I modified the message here, and also need to update the user guide document.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1c7c03b7ad94d742228a6fa5527b7ad04c535207","unresolved":true,"context_lines":[{"line_number":1150,"context_line":"                         \" resources.\")"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"            except Exception as e:"},{"line_number":1153,"context_line":"                LOG.error(\"Failed to synchronaization database \""},{"line_number":1154,"context_line":"                          f\"vnf:{vnf_inst.id} Error: \""},{"line_number":1155,"context_line":"                          f\"{encodeutils.exception_to_unicode(e)}\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"72622496_d85d36c9","line":1153,"range":{"start_line":1153,"start_character":34,"end_line":1153,"end_character":53},"updated":"2022-09-14 18:15:18.000000000","message":"nit: \"to synchronize\"","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":1150,"context_line":"                         \" resources.\")"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"            except Exception as e:"},{"line_number":1153,"context_line":"                LOG.error(\"Failed to synchronaization database \""},{"line_number":1154,"context_line":"                          f\"vnf:{vnf_inst.id} Error: \""},{"line_number":1155,"context_line":"                          f\"{encodeutils.exception_to_unicode(e)}\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"aa07c3a5_8e805153","line":1153,"range":{"start_line":1153,"start_character":34,"end_line":1153,"end_character":53},"in_reply_to":"72622496_d85d36c9","updated":"2022-09-15 10:00:03.000000000","message":"I fixed it in patchset 13.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"2367a6b0f4ed83aa6e0678d5797d188af496da49","unresolved":true,"context_lines":[{"line_number":1143,"context_line":"        else:"},{"line_number":1144,"context_line":"            # Only support CNF"},{"line_number":1145,"context_line":"            raise sol_ex.DbSyncNoDiff("},{"line_number":1146,"context_line":"                \"Vnfc Resources are no different.\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"df34daaa_6b858f12","line":1146,"range":{"start_line":1146,"start_character":17,"end_line":1146,"end_character":49},"updated":"2022-09-15 07:52:50.000000000","message":"The below seems to be better:\n\n```\nThere are no differences in Vnfc resources.\n```","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7ed8c487a5cbafbe71f300468beedd084982c24d","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"        else:"},{"line_number":1144,"context_line":"            # Only support CNF"},{"line_number":1145,"context_line":"            raise sol_ex.DbSyncNoDiff("},{"line_number":1146,"context_line":"                \"Vnfc Resources are no different.\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"e4bd0530_2dfb0b57","line":1146,"range":{"start_line":1146,"start_character":17,"end_line":1146,"end_character":49},"in_reply_to":"8aa46e3e_4b462967","updated":"2022-09-16 04:30:09.000000000","message":"Done","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":1143,"context_line":"        else:"},{"line_number":1144,"context_line":"            # Only support CNF"},{"line_number":1145,"context_line":"            raise sol_ex.DbSyncNoDiff("},{"line_number":1146,"context_line":"                \"Vnfc Resources are no different.\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"8aa46e3e_4b462967","line":1146,"range":{"start_line":1146,"start_character":17,"end_line":1146,"end_character":49},"in_reply_to":"df34daaa_6b858f12","updated":"2022-09-15 10:00:03.000000000","message":"I fixed it in patchset 13.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1c7c03b7ad94d742228a6fa5527b7ad04c535207","unresolved":true,"context_lines":[{"line_number":351,"context_line":"        if error_resource:"},{"line_number":352,"context_line":"            inst.instantiatedVnfInfo.vnfcResourceInfo.append(error_resource)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def database_synchronization(self, context, vnf_instance, vim_info):"},{"line_number":355,"context_line":"        \"\"\"method for database synchronization\"\"\""},{"line_number":356,"context_line":"        # get vdu id"},{"line_number":357,"context_line":"        vdu_id_list \u003d self._get_vdu_list(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ca108a8d_98168f6f","line":354,"range":{"start_line":354,"start_character":8,"end_line":354,"end_character":32},"updated":"2022-09-14 18:15:18.000000000","message":"The name of function should be started with a verb for the convention.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":351,"context_line":"        if error_resource:"},{"line_number":352,"context_line":"            inst.instantiatedVnfInfo.vnfcResourceInfo.append(error_resource)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def database_synchronization(self, context, vnf_instance, vim_info):"},{"line_number":355,"context_line":"        \"\"\"method for database synchronization\"\"\""},{"line_number":356,"context_line":"        # get vdu id"},{"line_number":357,"context_line":"        vdu_id_list \u003d self._get_vdu_list(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":11,"id":"b013def2_a44c866e","line":354,"range":{"start_line":354,"start_character":8,"end_line":354,"end_character":32},"in_reply_to":"ca108a8d_98168f6f","updated":"2022-09-15 10:00:03.000000000","message":"I changed `database_synchronization` to `sync_db`.","commit_id":"219092ba60513fa5765e004a29632ade5462f85e"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_common.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"82a5e92560af534b17dd3e3799ab6a19913ebf57","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":104,"context_line":"        vdu_ids \u003d {value.get(\u0027properties\u0027).get(\u0027name\u0027): key"},{"line_number":105,"context_line":"                   for key, value in vdu_nodes.items()}"},{"line_number":106,"context_line":"        # res.name is properties.name itself or"},{"line_number":107,"context_line":"        # {properties.name}-{some string}. later is helm case."},{"line_number":108,"context_line":"        return {vdu_ids[res.name.split(\"-\")[0]]: res"},{"line_number":109,"context_line":"                for res in k8s_reses"},{"line_number":110,"context_line":"                if (res.kind in TARGET_KIND"}],"source_content_type":"text/x-python","patch_set":12,"id":"f2543a7b_e2528955","side":"PARENT","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":62},"updated":"2022-09-14 14:03:48.000000000","message":"Why did you delete this comment from original?","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e1965f7f78db2ec3d09f3c41a3b8684dc4750e48","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":104,"context_line":"        vdu_ids \u003d {value.get(\u0027properties\u0027).get(\u0027name\u0027): key"},{"line_number":105,"context_line":"                   for key, value in vdu_nodes.items()}"},{"line_number":106,"context_line":"        # res.name is properties.name itself or"},{"line_number":107,"context_line":"        # {properties.name}-{some string}. later is helm case."},{"line_number":108,"context_line":"        return {vdu_ids[res.name.split(\"-\")[0]]: res"},{"line_number":109,"context_line":"                for res in k8s_reses"},{"line_number":110,"context_line":"                if (res.kind in TARGET_KIND"}],"source_content_type":"text/x-python","patch_set":12,"id":"1b45a03d_2ab0c490","side":"PARENT","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":62},"in_reply_to":"e66195cd_06f81987","updated":"2022-09-15 13:56:12.000000000","message":"Ack","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":104,"context_line":"        vdu_ids \u003d {value.get(\u0027properties\u0027).get(\u0027name\u0027): key"},{"line_number":105,"context_line":"                   for key, value in vdu_nodes.items()}"},{"line_number":106,"context_line":"        # res.name is properties.name itself or"},{"line_number":107,"context_line":"        # {properties.name}-{some string}. later is helm case."},{"line_number":108,"context_line":"        return {vdu_ids[res.name.split(\"-\")[0]]: res"},{"line_number":109,"context_line":"                for res in k8s_reses"},{"line_number":110,"context_line":"                if (res.kind in TARGET_KIND"}],"source_content_type":"text/x-python","patch_set":12,"id":"e66195cd_06f81987","side":"PARENT","line":107,"range":{"start_line":106,"start_character":0,"end_line":107,"end_character":62},"in_reply_to":"f2543a7b_e2528955","updated":"2022-09-15 10:00:03.000000000","message":"Sorry, this was my mistake. I fixed it in patchset 13.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"82a5e92560af534b17dd3e3799ab6a19913ebf57","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"84a5cb9f_d64fe6f3","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":28},"updated":"2022-09-14 14:03:48.000000000","message":"Why did you overwrite company name?","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"f7c6426e_2ea0f06f","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":28},"in_reply_to":"84a5cb9f_d64fe6f3","updated":"2022-09-15 10:00:03.000000000","message":"Sorry, this was my mistake. I fixed it in patchset 13.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e1965f7f78db2ec3d09f3c41a3b8684dc4750e48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":12,"id":"a1911e72_1c7a5066","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":28},"in_reply_to":"f7c6426e_2ea0f06f","updated":"2022-09-15 13:56:12.000000000","message":"Ack","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"82a5e92560af534b17dd3e3799ab6a19913ebf57","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _wait_k8s_reses_updated(self, k8s_reses, k8s_api_client, namespace,"},{"line_number":200,"context_line":"            old_pods_names):"},{"line_number":201,"context_line":"        def _check_update(check_reses, k8s_api_client, namespace,"},{"line_number":202,"context_line":"                old_pods_names):"},{"line_number":203,"context_line":"            ok_reses \u003d set()"},{"line_number":204,"context_line":"            all_pods \u003d kubernetes_utils.list_namespaced_pods("}],"source_content_type":"text/x-python","patch_set":12,"id":"dbf77310_f854c57b","line":201,"range":{"start_line":201,"start_character":12,"end_line":201,"end_character":25},"updated":"2022-09-14 14:03:48.000000000","message":"Here seems to be reverted from original patch, could you check and fix it?","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e1965f7f78db2ec3d09f3c41a3b8684dc4750e48","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _wait_k8s_reses_updated(self, k8s_reses, k8s_api_client, namespace,"},{"line_number":200,"context_line":"            old_pods_names):"},{"line_number":201,"context_line":"        def _check_update(check_reses, k8s_api_client, namespace,"},{"line_number":202,"context_line":"                old_pods_names):"},{"line_number":203,"context_line":"            ok_reses \u003d set()"},{"line_number":204,"context_line":"            all_pods \u003d kubernetes_utils.list_namespaced_pods("}],"source_content_type":"text/x-python","patch_set":12,"id":"8abb58a7_a19e7ac8","line":201,"range":{"start_line":201,"start_character":12,"end_line":201,"end_character":25},"in_reply_to":"609a76a7_63b5423b","updated":"2022-09-15 13:56:12.000000000","message":"Ack","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _wait_k8s_reses_updated(self, k8s_reses, k8s_api_client, namespace,"},{"line_number":200,"context_line":"            old_pods_names):"},{"line_number":201,"context_line":"        def _check_update(check_reses, k8s_api_client, namespace,"},{"line_number":202,"context_line":"                old_pods_names):"},{"line_number":203,"context_line":"            ok_reses \u003d set()"},{"line_number":204,"context_line":"            all_pods \u003d kubernetes_utils.list_namespaced_pods("}],"source_content_type":"text/x-python","patch_set":12,"id":"609a76a7_63b5423b","line":201,"range":{"start_line":201,"start_character":12,"end_line":201,"end_character":25},"in_reply_to":"dbf77310_f854c57b","updated":"2022-09-15 10:00:03.000000000","message":"Sorry, this was my mistake. I fixed it in patchset 13.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"82a5e92560af534b17dd3e3799ab6a19913ebf57","unresolved":true,"context_lines":[{"line_number":214,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        check_reses \u003d set(k8s_reses)"},{"line_number":217,"context_line":"        self._check_status(_check_update, check_reses, k8s_api_client,"},{"line_number":218,"context_line":"                           namespace, old_pods_names)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def diff_check_inst(self, inst, vim_info):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9b834752_4eb70f1f","line":217,"range":{"start_line":217,"start_character":27,"end_line":217,"end_character":40},"updated":"2022-09-14 14:03:48.000000000","message":"ditto.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e1965f7f78db2ec3d09f3c41a3b8684dc4750e48","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        check_reses \u003d set(k8s_reses)"},{"line_number":217,"context_line":"        self._check_status(_check_update, check_reses, k8s_api_client,"},{"line_number":218,"context_line":"                           namespace, old_pods_names)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def diff_check_inst(self, inst, vim_info):"}],"source_content_type":"text/x-python","patch_set":12,"id":"b23870f6_f9a89726","line":217,"range":{"start_line":217,"start_character":27,"end_line":217,"end_character":40},"in_reply_to":"96d748db_5c5bb5f5","updated":"2022-09-15 13:56:12.000000000","message":"Ack","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":214,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        check_reses \u003d set(k8s_reses)"},{"line_number":217,"context_line":"        self._check_status(_check_update, check_reses, k8s_api_client,"},{"line_number":218,"context_line":"                           namespace, old_pods_names)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def diff_check_inst(self, inst, vim_info):"}],"source_content_type":"text/x-python","patch_set":12,"id":"96d748db_5c5bb5f5","line":217,"range":{"start_line":217,"start_character":27,"end_line":217,"end_character":40},"in_reply_to":"9b834752_4eb70f1f","updated":"2022-09-15 10:00:03.000000000","message":"Sorry, this was my mistake. I fixed it in patchset 13.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"2367a6b0f4ed83aa6e0678d5797d188af496da49","unresolved":true,"context_lines":[{"line_number":336,"context_line":"        resource_pods \u003d {}"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        for pod in all_pods:"},{"line_number":339,"context_line":"            if self._is_match_pod_naming_rule(resource_type,"},{"line_number":340,"context_line":"                  resource_name, pod.metadata.name):"},{"line_number":341,"context_line":"                resource_pods[pod.metadata.name] \u003d pod.metadata.to_dict()"},{"line_number":342,"context_line":"        return resource_pods"}],"source_content_type":"text/x-python","patch_set":12,"id":"d010d9fe_08d23cbd","line":339,"updated":"2022-09-15 07:52:50.000000000","message":"KubernetesCommon class has no method `_is_match_pod_naming_rule`, could you check the usage of this method reference?\n(helm.py contains the method, so I guess that it\u0027s due to the previous refactoring.)","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":336,"context_line":"        resource_pods \u003d {}"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        for pod in all_pods:"},{"line_number":339,"context_line":"            if self._is_match_pod_naming_rule(resource_type,"},{"line_number":340,"context_line":"                  resource_name, pod.metadata.name):"},{"line_number":341,"context_line":"                resource_pods[pod.metadata.name] \u003d pod.metadata.to_dict()"},{"line_number":342,"context_line":"        return resource_pods"}],"source_content_type":"text/x-python","patch_set":12,"id":"fbc20490_4cead0d4","line":339,"in_reply_to":"d010d9fe_08d23cbd","updated":"2022-09-15 10:00:03.000000000","message":"Because when the class is instantiated, `kubernetes.Kubernetes()` is used.\n* https://review.opendev.org/c/openstack/tacker/+/852729/12/tacker/sol_refactored/conductor/vnflcm_driver_v2.py#1126\n\nSo the `_is_match_pod_naming_rule` function exists in `self` here.\n* https://review.opendev.org/c/openstack/tacker/+/852729/12/tacker/sol_refactored/infra_drivers/kubernetes/kubernetes.py#307\n\nSince this function is also called in `helm.py`, I created a new function in `kubernetes_common.py` to be called.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"6e6499346620ecfa1825e6d81d10c2ad5a13dffb","unresolved":true,"context_lines":[{"line_number":357,"context_line":"            name_list \u003d resource_id.split(\"-\")"},{"line_number":358,"context_line":"            if resource_type \u003d\u003d \u0027Deployment\u0027:"},{"line_number":359,"context_line":"                del name_list[-2:]"},{"line_number":360,"context_line":"            elif resource_type in (\u0027ReplicaSet\u0027,"},{"line_number":361,"context_line":"                                   \u0027DaemonSet\u0027,"},{"line_number":362,"context_line":"                                   \u0027StatefulSet\u0027):"},{"line_number":363,"context_line":"                del name_list[-1]"},{"line_number":364,"context_line":"            resource_name \u003d \u0027-\u0027.join(name_list)"}],"source_content_type":"text/x-python","patch_set":12,"id":"320c8e16_4286ee30","line":361,"range":{"start_line":360,"start_character":48,"end_line":361,"end_character":46},"updated":"2022-09-15 05:53:18.000000000","message":"I think there should be no line breaks.\ne.g.\n(\u0027ReplicaSet\u0027, \u0027DaemonSet\u0027,\n \u0027StatefulSet\u0027):","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":357,"context_line":"            name_list \u003d resource_id.split(\"-\")"},{"line_number":358,"context_line":"            if resource_type \u003d\u003d \u0027Deployment\u0027:"},{"line_number":359,"context_line":"                del name_list[-2:]"},{"line_number":360,"context_line":"            elif resource_type in (\u0027ReplicaSet\u0027,"},{"line_number":361,"context_line":"                                   \u0027DaemonSet\u0027,"},{"line_number":362,"context_line":"                                   \u0027StatefulSet\u0027):"},{"line_number":363,"context_line":"                del name_list[-1]"},{"line_number":364,"context_line":"            resource_name \u003d \u0027-\u0027.join(name_list)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7bd60450_a2f1b27d","line":361,"range":{"start_line":360,"start_character":48,"end_line":361,"end_character":46},"in_reply_to":"320c8e16_4286ee30","updated":"2022-09-15 10:00:03.000000000","message":"I removed line breaks.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"a9626de19e906ff010e2e506a79fbda41fcacd99","unresolved":false,"context_lines":[{"line_number":357,"context_line":"            name_list \u003d resource_id.split(\"-\")"},{"line_number":358,"context_line":"            if resource_type \u003d\u003d \u0027Deployment\u0027:"},{"line_number":359,"context_line":"                del name_list[-2:]"},{"line_number":360,"context_line":"            elif resource_type in (\u0027ReplicaSet\u0027,"},{"line_number":361,"context_line":"                                   \u0027DaemonSet\u0027,"},{"line_number":362,"context_line":"                                   \u0027StatefulSet\u0027):"},{"line_number":363,"context_line":"                del name_list[-1]"},{"line_number":364,"context_line":"            resource_name \u003d \u0027-\u0027.join(name_list)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5dbe3881_d960c8de","line":361,"range":{"start_line":360,"start_character":48,"end_line":361,"end_character":46},"in_reply_to":"7bd60450_a2f1b27d","updated":"2022-09-15 22:24:28.000000000","message":"I have confirmed it.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"}],"tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"6e6499346620ecfa1825e6d81d10c2ad5a13dffb","unresolved":true,"context_lines":[{"line_number":3061,"context_line":"            name_list \u003d resource_id.split(\"-\")"},{"line_number":3062,"context_line":"            if resource_type \u003d\u003d \u0027Deployment\u0027:"},{"line_number":3063,"context_line":"                del name_list[-2:]"},{"line_number":3064,"context_line":"            elif resource_type in (\u0027ReplicaSet\u0027,"},{"line_number":3065,"context_line":"                                   \u0027DaemonSet\u0027,"},{"line_number":3066,"context_line":"                                   \u0027StatefulSet\u0027):"},{"line_number":3067,"context_line":"                del name_list[-1]"},{"line_number":3068,"context_line":"            resource_name \u003d \u0027-\u0027.join(name_list)"}],"source_content_type":"text/x-python","patch_set":12,"id":"6abece0c_17157792","line":3065,"range":{"start_line":3064,"start_character":48,"end_line":3065,"end_character":47},"updated":"2022-09-15 05:53:18.000000000","message":"I think there should be no line breaks.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"a9626de19e906ff010e2e506a79fbda41fcacd99","unresolved":false,"context_lines":[{"line_number":3061,"context_line":"            name_list \u003d resource_id.split(\"-\")"},{"line_number":3062,"context_line":"            if resource_type \u003d\u003d \u0027Deployment\u0027:"},{"line_number":3063,"context_line":"                del name_list[-2:]"},{"line_number":3064,"context_line":"            elif resource_type in (\u0027ReplicaSet\u0027,"},{"line_number":3065,"context_line":"                                   \u0027DaemonSet\u0027,"},{"line_number":3066,"context_line":"                                   \u0027StatefulSet\u0027):"},{"line_number":3067,"context_line":"                del name_list[-1]"},{"line_number":3068,"context_line":"            resource_name \u003d \u0027-\u0027.join(name_list)"}],"source_content_type":"text/x-python","patch_set":12,"id":"c5602c6b_b76f9820","line":3065,"range":{"start_line":3064,"start_character":48,"end_line":3065,"end_character":47},"in_reply_to":"48d888a1_32e0f51d","updated":"2022-09-15 22:24:28.000000000","message":"I have confirmed it.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"45481ecf85783a60723ccc67465398d79ddf4f0d","unresolved":true,"context_lines":[{"line_number":3061,"context_line":"            name_list \u003d resource_id.split(\"-\")"},{"line_number":3062,"context_line":"            if resource_type \u003d\u003d \u0027Deployment\u0027:"},{"line_number":3063,"context_line":"                del name_list[-2:]"},{"line_number":3064,"context_line":"            elif resource_type in (\u0027ReplicaSet\u0027,"},{"line_number":3065,"context_line":"                                   \u0027DaemonSet\u0027,"},{"line_number":3066,"context_line":"                                   \u0027StatefulSet\u0027):"},{"line_number":3067,"context_line":"                del name_list[-1]"},{"line_number":3068,"context_line":"            resource_name \u003d \u0027-\u0027.join(name_list)"}],"source_content_type":"text/x-python","patch_set":12,"id":"48d888a1_32e0f51d","line":3065,"range":{"start_line":3064,"start_character":48,"end_line":3065,"end_character":47},"in_reply_to":"6abece0c_17157792","updated":"2022-09-15 10:00:03.000000000","message":"I removed line breaks.","commit_id":"2039fcb57d49d40e73bf2b08aeca554366a59746"}]}