)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"47fb323d4e16445b9c8e19a5283ef73c4d1ba899","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54a9e6fb_fe8e7a94","updated":"2022-08-28 22:16:28.000000000","message":"Thank you for the review.","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"2c0d120904def0091c17da13ecb04ef6e0e30c3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c7204877_6e805394","updated":"2022-09-05 00:34:42.000000000","message":"Thank you for the review.","commit_id":"f2bacc979b17c64da1ab3474b4edb06728c2d87e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"cb4c083f93fc10d172e70770cca5c86e5856c5c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7fbc7504_b5d8fc7f","updated":"2022-09-06 06:53:36.000000000","message":"LGTM","commit_id":"2e6fc8abefb078bcfea3fd442d4d4118ff21059b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7caf74d14ce4d41fbcebae409a6619f5cd2276ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d71eb5c9_fa289c2b","updated":"2022-09-08 05:40:25.000000000","message":"Thank you for the review.","commit_id":"2e6fc8abefb078bcfea3fd442d4d4118ff21059b"},{"author":{"_account_id":31668},"change_message_id":"0b27b9157f46b24cb1a8e511611636ee240842c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"264f21e0_5c4b474c","updated":"2022-09-08 05:22:03.000000000","message":"The comments below should be deleted.\n---\n        # NOTE: \u0027extVirtualLinks\u0027 is not supported.\n        # It can be specified but make no effect at all.\n---\nhttps://opendev.org/openstack/tacker/src/branch/stable/yoga/tacker/sol_refactored/objects/v2/change_current_vnf_pkg_request.py#L31-L32","commit_id":"2e6fc8abefb078bcfea3fd442d4d4118ff21059b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c73c1ebff2c61027b743133db7574f36ec0bd820","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c38686b2_f0afd09c","in_reply_to":"0202ad65_adf21022","updated":"2022-09-09 00:30:51.000000000","message":"I removed this comment because I just noticed vimConnectionInfo is already supported in the code (VnfLcmDriverV2::change_vnfpkg_process()).\nBut I don\u0027t add a test of this because this is not intention of this patch.","commit_id":"2e6fc8abefb078bcfea3fd442d4d4118ff21059b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7caf74d14ce4d41fbcebae409a6619f5cd2276ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f59975aa_6cde8e0e","in_reply_to":"264f21e0_5c4b474c","updated":"2022-09-08 05:40:25.000000000","message":"I will fix.","commit_id":"2e6fc8abefb078bcfea3fd442d4d4118ff21059b"},{"author":{"_account_id":31668},"change_message_id":"31a7d8a8a169b34a52fdd0c9d8555f4e613ca479","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"92931825_72e11c71","in_reply_to":"c38686b2_f0afd09c","updated":"2022-09-09 05:36:00.000000000","message":"I see.\nWe will consider adding FT in other patches in the future.","commit_id":"2e6fc8abefb078bcfea3fd442d4d4118ff21059b"},{"author":{"_account_id":31668},"change_message_id":"6587f5deddb5bbed97c9f3233b533c972bf8e6d8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0202ad65_adf21022","in_reply_to":"f59975aa_6cde8e0e","updated":"2022-09-08 09:29:34.000000000","message":"There seems to be no \"vimConnectionInfo\" in the FT request.\nIs there no problem if the following is also deleted?\n-----\n        # NOTE: \u0027vimConnectionInfo\u0027 is not supported.\n        # It can be specified but make no effect at all.\n-----","commit_id":"2e6fc8abefb078bcfea3fd442d4d4118ff21059b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c73c1ebff2c61027b743133db7574f36ec0bd820","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"52c56786_99fb8160","updated":"2022-09-09 00:30:51.000000000","message":"Thank you for the review.","commit_id":"a6e1643bb094ac3e25ac2db99782564c5e10ee83"},{"author":{"_account_id":31668},"change_message_id":"12da7ce27a51283c410e6bb2a9888316436bc728","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"01bbda30_fe688eee","updated":"2022-09-13 06:11:21.000000000","message":"LGTM","commit_id":"4a162a3ffc14027b80135f242aa79b86108fce5c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4838b9f63237ef742d06a0aa5b46294d9ce13d23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"21d2a2f6_2db47031","updated":"2022-09-13 07:07:29.000000000","message":"LGTM, thanks for your patch!","commit_id":"4a162a3ffc14027b80135f242aa79b86108fce5c"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"86ded0c6a23b4460c2bb8d1ba480373d1c6f9dfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a3d8df02_9d611bb2","updated":"2022-09-13 01:50:38.000000000","message":"recheck","commit_id":"4a162a3ffc14027b80135f242aa79b86108fce5c"}],"tacker/sol_refactored/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"780a2c427c5485786515d534697efdb0eecda3ed","unresolved":true,"context_lines":[{"line_number":415,"context_line":"                    inst.instantiatedVnfInfo.flavourId, vnfc.vduId)"},{"line_number":416,"context_line":"                new_cps \u003d {}"},{"line_number":417,"context_line":"                for cp_name in cp_names:"},{"line_number":418,"context_line":"                    cp_name \u003d _vdu_with_idx(cp_name, vdu_idx)"},{"line_number":419,"context_line":"                    if cp_name in cp_dict:"},{"line_number":420,"context_line":"                        new_cps[cp_name] \u003d cp_dict[cp_name]"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"09bf28d4_23a62924","line":418,"range":{"start_line":418,"start_character":30,"end_line":418,"end_character":43},"updated":"2022-08-26 06:07:10.000000000","message":"This function is used not only for vdu (including storage), but also for cp resources, so it may be better to rename it as follows.\n---\ndef _rsc_with_idx(rsc, idx):","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"47fb323d4e16445b9c8e19a5283ef73c4d1ba899","unresolved":true,"context_lines":[{"line_number":415,"context_line":"                    inst.instantiatedVnfInfo.flavourId, vnfc.vduId)"},{"line_number":416,"context_line":"                new_cps \u003d {}"},{"line_number":417,"context_line":"                for cp_name in cp_names:"},{"line_number":418,"context_line":"                    cp_name \u003d _vdu_with_idx(cp_name, vdu_idx)"},{"line_number":419,"context_line":"                    if cp_name in cp_dict:"},{"line_number":420,"context_line":"                        new_cps[cp_name] \u003d cp_dict[cp_name]"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"85747a26_f07e7e3b","line":418,"range":{"start_line":418,"start_character":30,"end_line":418,"end_character":43},"in_reply_to":"09bf28d4_23a62924","updated":"2022-08-28 22:16:28.000000000","message":"I see. I will fix.","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07d98d9b8cb999fc5acdb7ad632b396573e84807","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                    inst.instantiatedVnfInfo.flavourId, vnfc.vduId)"},{"line_number":416,"context_line":"                new_cps \u003d {}"},{"line_number":417,"context_line":"                for cp_name in cp_names:"},{"line_number":418,"context_line":"                    cp_name \u003d _vdu_with_idx(cp_name, vdu_idx)"},{"line_number":419,"context_line":"                    if cp_name in cp_dict:"},{"line_number":420,"context_line":"                        new_cps[cp_name] \u003d cp_dict[cp_name]"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ebe9544_44be6062","line":418,"range":{"start_line":418,"start_character":30,"end_line":418,"end_character":43},"in_reply_to":"85747a26_f07e7e3b","updated":"2022-08-29 08:04:36.000000000","message":"Done","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"780a2c427c5485786515d534697efdb0eecda3ed","unresolved":true,"context_lines":[{"line_number":727,"context_line":"            req_ext_vls \u003d grant.extVirtualLinks"},{"line_number":728,"context_line":"        elif req.obj_attr_is_set(\u0027extVirtualLinks\u0027):"},{"line_number":729,"context_line":"            req_ext_vls \u003d req.extVirtualLinks"},{"line_number":730,"context_line":"        if not req_ext_vls:"},{"line_number":731,"context_line":"            # may happen in case of change_vnfpkg"},{"line_number":732,"context_line":"            return self._make_ext_vl_info_from_inst(old_inst_info,"},{"line_number":733,"context_line":"                                                    ext_cp_infos)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5981d797_1a68129b","line":730,"range":{"start_line":730,"start_character":8,"end_line":730,"end_character":27},"updated":"2022-08-26 06:07:10.000000000","message":"Can you use \"else:\" here?","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"47fb323d4e16445b9c8e19a5283ef73c4d1ba899","unresolved":true,"context_lines":[{"line_number":727,"context_line":"            req_ext_vls \u003d grant.extVirtualLinks"},{"line_number":728,"context_line":"        elif req.obj_attr_is_set(\u0027extVirtualLinks\u0027):"},{"line_number":729,"context_line":"            req_ext_vls \u003d req.extVirtualLinks"},{"line_number":730,"context_line":"        if not req_ext_vls:"},{"line_number":731,"context_line":"            # may happen in case of change_vnfpkg"},{"line_number":732,"context_line":"            return self._make_ext_vl_info_from_inst(old_inst_info,"},{"line_number":733,"context_line":"                                                    ext_cp_infos)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e87e7089_f5ae8d67","line":730,"range":{"start_line":730,"start_character":8,"end_line":730,"end_character":27},"in_reply_to":"5981d797_1a68129b","updated":"2022-08-28 22:16:28.000000000","message":"right. I will fix.","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07d98d9b8cb999fc5acdb7ad632b396573e84807","unresolved":false,"context_lines":[{"line_number":727,"context_line":"            req_ext_vls \u003d grant.extVirtualLinks"},{"line_number":728,"context_line":"        elif req.obj_attr_is_set(\u0027extVirtualLinks\u0027):"},{"line_number":729,"context_line":"            req_ext_vls \u003d req.extVirtualLinks"},{"line_number":730,"context_line":"        if not req_ext_vls:"},{"line_number":731,"context_line":"            # may happen in case of change_vnfpkg"},{"line_number":732,"context_line":"            return self._make_ext_vl_info_from_inst(old_inst_info,"},{"line_number":733,"context_line":"                                                    ext_cp_infos)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6dd8c434_40c6ea65","line":730,"range":{"start_line":730,"start_character":8,"end_line":730,"end_character":27},"in_reply_to":"e87e7089_f5ae8d67","updated":"2022-08-29 08:04:36.000000000","message":"Done","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"129c4b594b0d3657c8410b64f7ba7810d1cd8c26","unresolved":true,"context_lines":[{"line_number":392,"context_line":"                    \"template\": template"},{"line_number":393,"context_line":"                }"},{"line_number":394,"context_line":"                LOG.debug(\"stack fields: %s\", vdu_fields)"},{"line_number":395,"context_line":"                heat_client.update_stack(parent_stack_id, vdu_fields)"},{"line_number":396,"context_line":"            else:"},{"line_number":397,"context_line":"                # pickup \u0027vcImageId\u0027 and \u0027computeFlavourId\u0027 from vdu_dict"},{"line_number":398,"context_line":"                vdu_idx \u003d vnfc.metadata.get(\u0027vdu_idx\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c9e36bc4_77b4f9f4","line":395,"updated":"2022-09-02 07:14:10.000000000","message":"Unlike else branch of L396, for VMs with AutoScalingGroups, rolling-update does not update CPs one by one, so could you add that in the NOTE?","commit_id":"f2bacc979b17c64da1ab3474b4edb06728c2d87e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"cb4c083f93fc10d172e70770cca5c86e5856c5c2","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                    \"template\": template"},{"line_number":393,"context_line":"                }"},{"line_number":394,"context_line":"                LOG.debug(\"stack fields: %s\", vdu_fields)"},{"line_number":395,"context_line":"                heat_client.update_stack(parent_stack_id, vdu_fields)"},{"line_number":396,"context_line":"            else:"},{"line_number":397,"context_line":"                # pickup \u0027vcImageId\u0027 and \u0027computeFlavourId\u0027 from vdu_dict"},{"line_number":398,"context_line":"                vdu_idx \u003d vnfc.metadata.get(\u0027vdu_idx\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"304cfe99_9c6e4471","line":395,"in_reply_to":"8382f46f_a126055b","updated":"2022-09-06 06:53:36.000000000","message":"Done","commit_id":"f2bacc979b17c64da1ab3474b4edb06728c2d87e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"2c0d120904def0091c17da13ecb04ef6e0e30c3d","unresolved":true,"context_lines":[{"line_number":392,"context_line":"                    \"template\": template"},{"line_number":393,"context_line":"                }"},{"line_number":394,"context_line":"                LOG.debug(\"stack fields: %s\", vdu_fields)"},{"line_number":395,"context_line":"                heat_client.update_stack(parent_stack_id, vdu_fields)"},{"line_number":396,"context_line":"            else:"},{"line_number":397,"context_line":"                # pickup \u0027vcImageId\u0027 and \u0027computeFlavourId\u0027 from vdu_dict"},{"line_number":398,"context_line":"                vdu_idx \u003d vnfc.metadata.get(\u0027vdu_idx\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"8382f46f_a126055b","line":395,"in_reply_to":"c9e36bc4_77b4f9f4","updated":"2022-09-05 00:34:42.000000000","message":"OK, I will add a comment.","commit_id":"f2bacc979b17c64da1ab3474b4edb06728c2d87e"}],"tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"780a2c427c5485786515d534697efdb0eecda3ed","unresolved":true,"context_lines":[{"line_number":291,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":292,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU1\u0027, 0, \u0027VDU1_CP1\u0027))"},{"line_number":293,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":294,"context_line":"            self._get_vnfc_cp_net_id(inst_5, \u0027VDU1\u0027, 1, \u0027VDU1_CP1\u0027))"},{"line_number":295,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":296,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU2\u0027, 0, \u0027VDU2_CP1\u0027))"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e76fa17b_69ecc778","line":294,"range":{"start_line":294,"start_character":37,"end_line":294,"end_character":43},"updated":"2022-08-26 06:07:10.000000000","message":"Is this typo with \"inst_6\"?","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07d98d9b8cb999fc5acdb7ad632b396573e84807","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":292,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU1\u0027, 0, \u0027VDU1_CP1\u0027))"},{"line_number":293,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":294,"context_line":"            self._get_vnfc_cp_net_id(inst_5, \u0027VDU1\u0027, 1, \u0027VDU1_CP1\u0027))"},{"line_number":295,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":296,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU2\u0027, 0, \u0027VDU2_CP1\u0027))"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"262a2cbb_5a1f34d5","line":294,"range":{"start_line":294,"start_character":37,"end_line":294,"end_character":43},"in_reply_to":"06bdf225_1e1bd696","updated":"2022-08-29 08:04:36.000000000","message":"Done","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"47fb323d4e16445b9c8e19a5283ef73c4d1ba899","unresolved":true,"context_lines":[{"line_number":291,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":292,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU1\u0027, 0, \u0027VDU1_CP1\u0027))"},{"line_number":293,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":294,"context_line":"            self._get_vnfc_cp_net_id(inst_5, \u0027VDU1\u0027, 1, \u0027VDU1_CP1\u0027))"},{"line_number":295,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":296,"context_line":"            self._get_vnfc_cp_net_id(inst_6, \u0027VDU2\u0027, 0, \u0027VDU2_CP1\u0027))"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"06bdf225_1e1bd696","line":294,"range":{"start_line":294,"start_character":37,"end_line":294,"end_character":43},"in_reply_to":"e76fa17b_69ecc778","updated":"2022-08-28 22:16:28.000000000","message":"oops. I will fix.","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"}],"tacker/tests/functional/sol_v2_common/paramgen.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"780a2c427c5485786515d534697efdb0eecda3ed","unresolved":true,"context_lines":[{"line_number":971,"context_line":"            {"},{"line_number":972,"context_line":"                \"cpdId\": \"VDU2_CP1\","},{"line_number":973,"context_line":"                \"cpConfig\": {"},{"line_number":974,"context_line":"                    \"VDU2_CP2_1\": {"},{"line_number":975,"context_line":"                        \"cpProtocolData\": [{"},{"line_number":976,"context_line":"                            \"layerProtocol\": \"IP_OVER_ETHERNET\","},{"line_number":977,"context_line":"                            \"ipOverEthernet\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3333e92d_9525617b","line":974,"range":{"start_line":974,"start_character":21,"end_line":974,"end_character":31},"updated":"2022-08-26 06:07:10.000000000","message":"I think it should be fixed to \"VDU2_CP1_1\" like L962.","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"47fb323d4e16445b9c8e19a5283ef73c4d1ba899","unresolved":true,"context_lines":[{"line_number":971,"context_line":"            {"},{"line_number":972,"context_line":"                \"cpdId\": \"VDU2_CP1\","},{"line_number":973,"context_line":"                \"cpConfig\": {"},{"line_number":974,"context_line":"                    \"VDU2_CP2_1\": {"},{"line_number":975,"context_line":"                        \"cpProtocolData\": [{"},{"line_number":976,"context_line":"                            \"layerProtocol\": \"IP_OVER_ETHERNET\","},{"line_number":977,"context_line":"                            \"ipOverEthernet\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"f2eee79e_50b30e66","line":974,"range":{"start_line":974,"start_character":21,"end_line":974,"end_character":31},"in_reply_to":"3333e92d_9525617b","updated":"2022-08-28 22:16:28.000000000","message":"I will fix.","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07d98d9b8cb999fc5acdb7ad632b396573e84807","unresolved":false,"context_lines":[{"line_number":971,"context_line":"            {"},{"line_number":972,"context_line":"                \"cpdId\": \"VDU2_CP1\","},{"line_number":973,"context_line":"                \"cpConfig\": {"},{"line_number":974,"context_line":"                    \"VDU2_CP2_1\": {"},{"line_number":975,"context_line":"                        \"cpProtocolData\": [{"},{"line_number":976,"context_line":"                            \"layerProtocol\": \"IP_OVER_ETHERNET\","},{"line_number":977,"context_line":"                            \"ipOverEthernet\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ebbbee62_41325083","line":974,"range":{"start_line":974,"start_character":21,"end_line":974,"end_character":31},"in_reply_to":"f2eee79e_50b30e66","updated":"2022-08-29 08:04:36.000000000","message":"Done","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"780a2c427c5485786515d534697efdb0eecda3ed","unresolved":true,"context_lines":[{"line_number":1093,"context_line":"                    {"},{"line_number":1094,"context_line":"                        \"cpdId\": \"VDU2_CP1\","},{"line_number":1095,"context_line":"                        \"cpConfig\": {"},{"line_number":1096,"context_line":"                            \"VDU2_CP2_1\": {"},{"line_number":1097,"context_line":"                                \"cpProtocolData\": [{"},{"line_number":1098,"context_line":"                                    \"layerProtocol\": \"IP_OVER_ETHERNET\","},{"line_number":1099,"context_line":"                                    \"ipOverEthernet\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"140610d7_5ebcae98","line":1096,"range":{"start_line":1096,"start_character":29,"end_line":1096,"end_character":39},"updated":"2022-08-26 06:07:10.000000000","message":"Typo: \"VDU2_CP1_1\"","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"47fb323d4e16445b9c8e19a5283ef73c4d1ba899","unresolved":true,"context_lines":[{"line_number":1093,"context_line":"                    {"},{"line_number":1094,"context_line":"                        \"cpdId\": \"VDU2_CP1\","},{"line_number":1095,"context_line":"                        \"cpConfig\": {"},{"line_number":1096,"context_line":"                            \"VDU2_CP2_1\": {"},{"line_number":1097,"context_line":"                                \"cpProtocolData\": [{"},{"line_number":1098,"context_line":"                                    \"layerProtocol\": \"IP_OVER_ETHERNET\","},{"line_number":1099,"context_line":"                                    \"ipOverEthernet\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"cf7d23ae_95a39324","line":1096,"range":{"start_line":1096,"start_character":29,"end_line":1096,"end_character":39},"in_reply_to":"140610d7_5ebcae98","updated":"2022-08-28 22:16:28.000000000","message":"I will fix.","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07d98d9b8cb999fc5acdb7ad632b396573e84807","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"                    {"},{"line_number":1094,"context_line":"                        \"cpdId\": \"VDU2_CP1\","},{"line_number":1095,"context_line":"                        \"cpConfig\": {"},{"line_number":1096,"context_line":"                            \"VDU2_CP2_1\": {"},{"line_number":1097,"context_line":"                                \"cpProtocolData\": [{"},{"line_number":1098,"context_line":"                                    \"layerProtocol\": \"IP_OVER_ETHERNET\","},{"line_number":1099,"context_line":"                                    \"ipOverEthernet\": {"}],"source_content_type":"text/x-python","patch_set":1,"id":"91556b00_3bfba32a","line":1096,"range":{"start_line":1096,"start_character":29,"end_line":1096,"end_character":39},"in_reply_to":"cf7d23ae_95a39324","updated":"2022-08-29 08:04:36.000000000","message":"Done","commit_id":"80fac0bb0a372b7b94e6971cfca17c902a37e1ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"07d98d9b8cb999fc5acdb7ad632b396573e84807","unresolved":true,"context_lines":[{"line_number":897,"context_line":"    }"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"def change_vnfpkg(vnfd_id):"},{"line_number":901,"context_line":"    return {"},{"line_number":902,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":903,"context_line":"        \"additionalParams\": {"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff74a167_b8dfdb5d","line":900,"range":{"start_line":900,"start_character":4,"end_line":900,"end_character":17},"updated":"2022-08-29 08:04:36.000000000","message":"In the case of BaseHOT including AutoScalingGroup, although the CP is not changed by rolling-update for each Vnfc, I think that the specification is such that the CP is changed collectively at the end.\nIs it possible to add extVirtualLinks in this point and add assertions in the test-case to confirm it?","commit_id":"f2bacc979b17c64da1ab3474b4edb06728c2d87e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"cb4c083f93fc10d172e70770cca5c86e5856c5c2","unresolved":false,"context_lines":[{"line_number":897,"context_line":"    }"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"def change_vnfpkg(vnfd_id):"},{"line_number":901,"context_line":"    return {"},{"line_number":902,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":903,"context_line":"        \"additionalParams\": {"}],"source_content_type":"text/x-python","patch_set":3,"id":"51a3941e_0d11765b","line":900,"range":{"start_line":900,"start_character":4,"end_line":900,"end_character":17},"in_reply_to":"ad68b04a_ae3e5b84","updated":"2022-09-06 06:53:36.000000000","message":"Done","commit_id":"f2bacc979b17c64da1ab3474b4edb06728c2d87e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"2c0d120904def0091c17da13ecb04ef6e0e30c3d","unresolved":true,"context_lines":[{"line_number":897,"context_line":"    }"},{"line_number":898,"context_line":""},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"def change_vnfpkg(vnfd_id):"},{"line_number":901,"context_line":"    return {"},{"line_number":902,"context_line":"        \"vnfdId\": vnfd_id,"},{"line_number":903,"context_line":"        \"additionalParams\": {"}],"source_content_type":"text/x-python","patch_set":3,"id":"ad68b04a_ae3e5b84","line":900,"range":{"start_line":900,"start_character":4,"end_line":900,"end_character":17},"in_reply_to":"ff74a167_b8dfdb5d","updated":"2022-09-05 00:34:42.000000000","message":"OK. but change_vnfpkg is used many place. I will add extVL change to common test only.","commit_id":"f2bacc979b17c64da1ab3474b4edb06728c2d87e"},{"author":{"_account_id":31668},"change_message_id":"6587f5deddb5bbed97c9f3233b533c972bf8e6d8","unresolved":true,"context_lines":[{"line_number":935,"context_line":"    }"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"def change_vnfpkg_with_ext_vl(vnfd_id, net_ids):"},{"line_number":939,"context_line":"    ext_vl_1 \u003d {"},{"line_number":940,"context_line":"        \"id\": uuidutils.generate_uuid(),"},{"line_number":941,"context_line":"        \"resourceId\": net_ids[\u0027net1\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"86a2b1ac_97cf4786","line":938,"updated":"2022-09-08 09:29:34.000000000","message":"Could you also reflect the addition of extVirtualLinks to pkggen.py?\n* https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/samples/test_change_vnf_pkg_with_new_image/pkggen.py#L41\n* https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/samples/test_change_vnf_pkg_with_new_volume/pkggen.py#L46","commit_id":"a64d1d3cf759e8e043b50d6d7fc41758b15467ef"},{"author":{"_account_id":31668},"change_message_id":"31a7d8a8a169b34a52fdd0c9d8555f4e613ca479","unresolved":false,"context_lines":[{"line_number":935,"context_line":"    }"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"def change_vnfpkg_with_ext_vl(vnfd_id, net_ids):"},{"line_number":939,"context_line":"    ext_vl_1 \u003d {"},{"line_number":940,"context_line":"        \"id\": uuidutils.generate_uuid(),"},{"line_number":941,"context_line":"        \"resourceId\": net_ids[\u0027net1\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"9c2e55ce_cefea71e","line":938,"in_reply_to":"3dd0e7d7_6e773f93","updated":"2022-09-09 05:36:00.000000000","message":"Done","commit_id":"a64d1d3cf759e8e043b50d6d7fc41758b15467ef"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c73c1ebff2c61027b743133db7574f36ec0bd820","unresolved":true,"context_lines":[{"line_number":935,"context_line":"    }"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"def change_vnfpkg_with_ext_vl(vnfd_id, net_ids):"},{"line_number":939,"context_line":"    ext_vl_1 \u003d {"},{"line_number":940,"context_line":"        \"id\": uuidutils.generate_uuid(),"},{"line_number":941,"context_line":"        \"resourceId\": net_ids[\u0027net1\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"3dd0e7d7_6e773f93","line":938,"in_reply_to":"86a2b1ac_97cf4786","updated":"2022-09-09 00:30:51.000000000","message":"I see. I will add.","commit_id":"a64d1d3cf759e8e043b50d6d7fc41758b15467ef"}]}
