)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9e70ceec81dfcab4af40b1fea66471b2e7c7c683","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"13431c77_4cb6d302","updated":"2022-09-01 22:52:39.000000000","message":"Thank you for the review.","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"703df20f3fc3e1adf68b07176af42c585e052a2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"878d635e_71826037","updated":"2022-09-01 22:33:48.000000000","message":"Thank you for the review.","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d9fb0c7e9565904082cc4d3abdcf0b651eb1be43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"48dcbaee_d6da0d39","updated":"2022-09-01 07:55:38.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6989550e2b4d370443fc0c5fc6e01f414ce475ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"527a3b62_167a9126","updated":"2022-09-06 03:55:40.000000000","message":"Thank you for the review.","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b2946e72ea288db28dcb24b489f66bbc56867a08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d9b84c9a_18f81b31","updated":"2022-09-06 02:53:36.000000000","message":"Thanks for your rework, please kindly check additional comments.","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"923dac0b70cf839c30c9c760a434716cabd0aae4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2360c795_8fd2507c","updated":"2022-09-07 00:29:28.000000000","message":"Thanks for your rework, LGTM.","commit_id":"736b457dfee0aa709ce55e3ee40bded7b508415f"}],"releasenotes/notes/support-cnf-heal-scale-rollback-in-v2-lcm-api-25051324608e2dd3.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b2946e72ea288db28dcb24b489f66bbc56867a08","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support CNF Heal/Scale/Rollback operation in v2 LCM API."},{"line_number":5,"context_line":"    This feature provides the following CNF operations in"},{"line_number":6,"context_line":"    v2 LCM API based on ETSI NFV specifications and "},{"line_number":7,"context_line":"    instantiatiationLevel parameter to determine"},{"line_number":8,"context_line":"    the initial number of Pods."},{"line_number":9,"context_line":"    * Scale VNF task"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"b885fba9_72e049bd","line":6,"range":{"start_line":6,"start_character":51,"end_line":6,"end_character":52},"updated":"2022-09-06 02:53:36.000000000","message":"nit: Could you remove unnecessary space character?","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"923dac0b70cf839c30c9c760a434716cabd0aae4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support CNF Heal/Scale/Rollback operation in v2 LCM API."},{"line_number":5,"context_line":"    This feature provides the following CNF operations in"},{"line_number":6,"context_line":"    v2 LCM API based on ETSI NFV specifications and "},{"line_number":7,"context_line":"    instantiatiationLevel parameter to determine"},{"line_number":8,"context_line":"    the initial number of Pods."},{"line_number":9,"context_line":"    * Scale VNF task"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"190fefe2_b332236e","line":6,"range":{"start_line":6,"start_character":51,"end_line":6,"end_character":52},"in_reply_to":"87506bf8_c7e1e05b","updated":"2022-09-07 00:29:28.000000000","message":"Ack","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6989550e2b4d370443fc0c5fc6e01f414ce475ab","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support CNF Heal/Scale/Rollback operation in v2 LCM API."},{"line_number":5,"context_line":"    This feature provides the following CNF operations in"},{"line_number":6,"context_line":"    v2 LCM API based on ETSI NFV specifications and "},{"line_number":7,"context_line":"    instantiatiationLevel parameter to determine"},{"line_number":8,"context_line":"    the initial number of Pods."},{"line_number":9,"context_line":"    * Scale VNF task"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"87506bf8_c7e1e05b","line":6,"range":{"start_line":6,"start_character":51,"end_line":6,"end_character":52},"in_reply_to":"b885fba9_72e049bd","updated":"2022-09-06 03:55:40.000000000","message":"I will fix.","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3ef68bf643042a78f0a99cc9cad329da4a0cf1a0","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        vim_info \u003d inst_utils.select_vim_info(inst.vimConnectionInfo)"},{"line_number":45,"context_line":"        k8s_api_client \u003d kubernetes_utils.init_k8s_api_client(vim_info)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        k8s_reses, namespace \u003d self._create_k8s_reses("},{"line_number":48,"context_line":"            vnfd, target_k8s_files, k8s_api_client,"},{"line_number":49,"context_line":"            req.additionalParams.get(\u0027namespace\u0027))"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e5cd527c_aaa38f59","line":47,"range":{"start_line":47,"start_character":36,"end_line":47,"end_character":53},"updated":"2022-09-01 02:35:54.000000000","message":"This process is preparation, and creating the k8s resource is L67, so \"_setup_k8s_reses\" seems better.","commit_id":"e3dccfc07791fcb39ed5f894e1cafddb73477fbc"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"442cbf3637c83249be0d7afbb62f1c81c87100db","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        vim_info \u003d inst_utils.select_vim_info(inst.vimConnectionInfo)"},{"line_number":45,"context_line":"        k8s_api_client \u003d kubernetes_utils.init_k8s_api_client(vim_info)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        k8s_reses, namespace \u003d self._create_k8s_reses("},{"line_number":48,"context_line":"            vnfd, target_k8s_files, k8s_api_client,"},{"line_number":49,"context_line":"            req.additionalParams.get(\u0027namespace\u0027))"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d9cb8994_237f0d2a","line":47,"range":{"start_line":47,"start_character":36,"end_line":47,"end_character":53},"in_reply_to":"9eafecd0_bb11ae48","updated":"2022-09-05 05:21:13.000000000","message":"Done","commit_id":"e3dccfc07791fcb39ed5f894e1cafddb73477fbc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"703df20f3fc3e1adf68b07176af42c585e052a2a","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        vim_info \u003d inst_utils.select_vim_info(inst.vimConnectionInfo)"},{"line_number":45,"context_line":"        k8s_api_client \u003d kubernetes_utils.init_k8s_api_client(vim_info)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        k8s_reses, namespace \u003d self._create_k8s_reses("},{"line_number":48,"context_line":"            vnfd, target_k8s_files, k8s_api_client,"},{"line_number":49,"context_line":"            req.additionalParams.get(\u0027namespace\u0027))"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9eafecd0_bb11ae48","line":47,"range":{"start_line":47,"start_character":36,"end_line":47,"end_character":53},"in_reply_to":"e5cd527c_aaa38f59","updated":"2022-09-01 22:33:48.000000000","message":"I see. I will fix.","commit_id":"e3dccfc07791fcb39ed5f894e1cafddb73477fbc"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3ef68bf643042a78f0a99cc9cad329da4a0cf1a0","unresolved":true,"context_lines":[{"line_number":61,"context_line":"            if vdu_res.kind in SCALABLE_KIND:"},{"line_number":62,"context_line":"                vdu_res.body[\u0027spec\u0027][\u0027replicas\u0027] \u003d vdus_num[vdu_name]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # deploy k8s resources"},{"line_number":65,"context_line":"        for k8s_res in k8s_reses:"},{"line_number":66,"context_line":"            if not k8s_res.is_exists():"},{"line_number":67,"context_line":"                k8s_res.create()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # wait k8s resource create complete"},{"line_number":70,"context_line":"        self._wait_k8s_reses_ready(k8s_reses)"}],"source_content_type":"text/x-python","patch_set":4,"id":"02a4e862_62d620d6","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":32},"updated":"2022-09-01 02:35:54.000000000","message":"How about defining a method called \"_create_k8s_resource\", similar to \"_delete_k8s_resource\"?","commit_id":"e3dccfc07791fcb39ed5f894e1cafddb73477fbc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"703df20f3fc3e1adf68b07176af42c585e052a2a","unresolved":true,"context_lines":[{"line_number":61,"context_line":"            if vdu_res.kind in SCALABLE_KIND:"},{"line_number":62,"context_line":"                vdu_res.body[\u0027spec\u0027][\u0027replicas\u0027] \u003d vdus_num[vdu_name]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # deploy k8s resources"},{"line_number":65,"context_line":"        for k8s_res in k8s_reses:"},{"line_number":66,"context_line":"            if not k8s_res.is_exists():"},{"line_number":67,"context_line":"                k8s_res.create()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # wait k8s resource create complete"},{"line_number":70,"context_line":"        self._wait_k8s_reses_ready(k8s_reses)"}],"source_content_type":"text/x-python","patch_set":4,"id":"869ef425_d6bcb1ac","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":32},"in_reply_to":"02a4e862_62d620d6","updated":"2022-09-01 22:33:48.000000000","message":"_delete_k8s_resource is called from multiple points. And it is reason that it becomes method. The code of L.65-67 is used only here. When it is used in multiple places I will make a method.","commit_id":"e3dccfc07791fcb39ed5f894e1cafddb73477fbc"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"442cbf3637c83249be0d7afbb62f1c81c87100db","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            if vdu_res.kind in SCALABLE_KIND:"},{"line_number":62,"context_line":"                vdu_res.body[\u0027spec\u0027][\u0027replicas\u0027] \u003d vdus_num[vdu_name]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # deploy k8s resources"},{"line_number":65,"context_line":"        for k8s_res in k8s_reses:"},{"line_number":66,"context_line":"            if not k8s_res.is_exists():"},{"line_number":67,"context_line":"                k8s_res.create()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # wait k8s resource create complete"},{"line_number":70,"context_line":"        self._wait_k8s_reses_ready(k8s_reses)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3782f839_1b2e3df2","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":32},"in_reply_to":"869ef425_d6bcb1ac","updated":"2022-09-05 05:21:13.000000000","message":"Done","commit_id":"e3dccfc07791fcb39ed5f894e1cafddb73477fbc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d9fb0c7e9565904082cc4d3abdcf0b651eb1be43","unresolved":true,"context_lines":[{"line_number":174,"context_line":"            target_vdus \u003d {res_def.resourceTemplateId"},{"line_number":175,"context_line":"                           for res_def in grant_req.addResources"},{"line_number":176,"context_line":"                           if res_def.type \u003d\u003d \u0027COMPUTE\u0027}"},{"line_number":177,"context_line":"            old_pods_names \u003d [vnfc.computeResource.resourceId"},{"line_number":178,"context_line":"                for vnfc in inst.instantiatedVnfInfo.vnfcResourceInfo"},{"line_number":179,"context_line":"                if vnfc.vduId in target_vdus]"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"cbdcf681_88601771","line":177,"range":{"start_line":177,"start_character":29,"end_line":177,"end_character":30},"updated":"2022-09-01 07:55:38.000000000","message":"Could you change the type of `old_pods_names` from `list` to `set` if possible?\nIt doesn\u0027t seem to have to be `list` from the usage.\n(`old_pods_names` of the other functions in this file are as well.)","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b2946e72ea288db28dcb24b489f66bbc56867a08","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            target_vdus \u003d {res_def.resourceTemplateId"},{"line_number":175,"context_line":"                           for res_def in grant_req.addResources"},{"line_number":176,"context_line":"                           if res_def.type \u003d\u003d \u0027COMPUTE\u0027}"},{"line_number":177,"context_line":"            old_pods_names \u003d [vnfc.computeResource.resourceId"},{"line_number":178,"context_line":"                for vnfc in inst.instantiatedVnfInfo.vnfcResourceInfo"},{"line_number":179,"context_line":"                if vnfc.vduId in target_vdus]"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"399dc2a8_8af5b6b0","line":177,"range":{"start_line":177,"start_character":29,"end_line":177,"end_character":30},"in_reply_to":"b7f13fe8_f94f6b21","updated":"2022-09-06 02:53:36.000000000","message":"Ack","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9e70ceec81dfcab4af40b1fea66471b2e7c7c683","unresolved":true,"context_lines":[{"line_number":174,"context_line":"            target_vdus \u003d {res_def.resourceTemplateId"},{"line_number":175,"context_line":"                           for res_def in grant_req.addResources"},{"line_number":176,"context_line":"                           if res_def.type \u003d\u003d \u0027COMPUTE\u0027}"},{"line_number":177,"context_line":"            old_pods_names \u003d [vnfc.computeResource.resourceId"},{"line_number":178,"context_line":"                for vnfc in inst.instantiatedVnfInfo.vnfcResourceInfo"},{"line_number":179,"context_line":"                if vnfc.vduId in target_vdus]"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b7f13fe8_f94f6b21","line":177,"range":{"start_line":177,"start_character":29,"end_line":177,"end_character":30},"in_reply_to":"cbdcf681_88601771","updated":"2022-09-01 22:52:39.000000000","message":"right. I will fix.","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d9fb0c7e9565904082cc4d3abdcf0b651eb1be43","unresolved":true,"context_lines":[{"line_number":234,"context_line":"        # check running Pod"},{"line_number":235,"context_line":"        all_pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":236,"context_line":"            k8s_api_client, namespace)"},{"line_number":237,"context_line":"        current_pods_name \u003d [pod.metadata.name for pod in all_pods]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        old_pods_names \u003d []"},{"line_number":240,"context_line":"        vdu_reses \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"34411370_f8ba088a","line":237,"range":{"start_line":237,"start_character":28,"end_line":237,"end_character":29},"updated":"2022-09-01 07:55:38.000000000","message":"Could you change type to `set` same as L.210?","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9e70ceec81dfcab4af40b1fea66471b2e7c7c683","unresolved":true,"context_lines":[{"line_number":234,"context_line":"        # check running Pod"},{"line_number":235,"context_line":"        all_pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":236,"context_line":"            k8s_api_client, namespace)"},{"line_number":237,"context_line":"        current_pods_name \u003d [pod.metadata.name for pod in all_pods]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        old_pods_names \u003d []"},{"line_number":240,"context_line":"        vdu_reses \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"aa9e1c00_d0ab049d","line":237,"range":{"start_line":237,"start_character":28,"end_line":237,"end_character":29},"in_reply_to":"34411370_f8ba088a","updated":"2022-09-01 22:52:39.000000000","message":"I will fix.","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b2946e72ea288db28dcb24b489f66bbc56867a08","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        # check running Pod"},{"line_number":235,"context_line":"        all_pods \u003d kubernetes_utils.list_namespaced_pods("},{"line_number":236,"context_line":"            k8s_api_client, namespace)"},{"line_number":237,"context_line":"        current_pods_name \u003d [pod.metadata.name for pod in all_pods]"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        old_pods_names \u003d []"},{"line_number":240,"context_line":"        vdu_reses \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"4bd68669_f51522bd","line":237,"range":{"start_line":237,"start_character":28,"end_line":237,"end_character":29},"in_reply_to":"aa9e1c00_d0ab049d","updated":"2022-09-06 02:53:36.000000000","message":"Ack","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d9fb0c7e9565904082cc4d3abdcf0b651eb1be43","unresolved":true,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        vdus_num \u003d self._get_vdus_num_from_grant_req_res_defs("},{"line_number":305,"context_line":"            grant_req.addResources)"},{"line_number":306,"context_line":"        for vdu_name, vdu_num in vdus_num.items():"},{"line_number":307,"context_line":"            vdus_num[vdu_name] \u003d self._get_current_vdu_num(inst, vdu_name)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        self._scale_k8s_resource(inst, vdus_num)"}],"source_content_type":"text/x-python","patch_set":5,"id":"491b2f1d_6c577e23","line":306,"range":{"start_line":306,"start_character":22,"end_line":306,"end_character":29},"updated":"2022-09-01 07:55:38.000000000","message":"`vdu_num` is unused variable, could you replace to `_` or use `vdus_num.keys()`","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9e70ceec81dfcab4af40b1fea66471b2e7c7c683","unresolved":true,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        vdus_num \u003d self._get_vdus_num_from_grant_req_res_defs("},{"line_number":305,"context_line":"            grant_req.addResources)"},{"line_number":306,"context_line":"        for vdu_name, vdu_num in vdus_num.items():"},{"line_number":307,"context_line":"            vdus_num[vdu_name] \u003d self._get_current_vdu_num(inst, vdu_name)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        self._scale_k8s_resource(inst, vdus_num)"}],"source_content_type":"text/x-python","patch_set":5,"id":"d1e0fcac_1fe87b9b","line":306,"range":{"start_line":306,"start_character":22,"end_line":306,"end_character":29},"in_reply_to":"491b2f1d_6c577e23","updated":"2022-09-01 22:52:39.000000000","message":"I will fix.","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b2946e72ea288db28dcb24b489f66bbc56867a08","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        vdus_num \u003d self._get_vdus_num_from_grant_req_res_defs("},{"line_number":305,"context_line":"            grant_req.addResources)"},{"line_number":306,"context_line":"        for vdu_name, vdu_num in vdus_num.items():"},{"line_number":307,"context_line":"            vdus_num[vdu_name] \u003d self._get_current_vdu_num(inst, vdu_name)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        self._scale_k8s_resource(inst, vdus_num)"}],"source_content_type":"text/x-python","patch_set":5,"id":"4e8bd4fb_9bfc4335","line":306,"range":{"start_line":306,"start_character":22,"end_line":306,"end_character":29},"in_reply_to":"d1e0fcac_1fe87b9b","updated":"2022-09-06 02:53:36.000000000","message":"Ack","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b2946e72ea288db28dcb24b489f66bbc56867a08","unresolved":true,"context_lines":[{"line_number":30,"context_line":"CONF \u003d config.CONF"},{"line_number":31,"context_line":"CHECK_INTERVAL \u003d 10"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"TARGET_KIND \u003d [\"Pod\", \"Deployment\", \"DaemonSet\", \"StatefulSet\", \"ReplicaSet\"]"},{"line_number":34,"context_line":"SCALABLE_KIND \u003d [\"Deployment\", \"ReplicaSet\", \"StatefulSet\"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"21ef066b_f3e84d06","line":33,"range":{"start_line":33,"start_character":14,"end_line":33,"end_character":15},"updated":"2022-09-06 02:53:36.000000000","message":"Could you change type to `set` instead of `list`?","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6989550e2b4d370443fc0c5fc6e01f414ce475ab","unresolved":true,"context_lines":[{"line_number":30,"context_line":"CONF \u003d config.CONF"},{"line_number":31,"context_line":"CHECK_INTERVAL \u003d 10"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"TARGET_KIND \u003d [\"Pod\", \"Deployment\", \"DaemonSet\", \"StatefulSet\", \"ReplicaSet\"]"},{"line_number":34,"context_line":"SCALABLE_KIND \u003d [\"Deployment\", \"ReplicaSet\", \"StatefulSet\"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"b1766eb7_d1c53e83","line":33,"range":{"start_line":33,"start_character":14,"end_line":33,"end_character":15},"in_reply_to":"21ef066b_f3e84d06","updated":"2022-09-06 03:55:40.000000000","message":"I will fix.","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"923dac0b70cf839c30c9c760a434716cabd0aae4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"CONF \u003d config.CONF"},{"line_number":31,"context_line":"CHECK_INTERVAL \u003d 10"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"TARGET_KIND \u003d [\"Pod\", \"Deployment\", \"DaemonSet\", \"StatefulSet\", \"ReplicaSet\"]"},{"line_number":34,"context_line":"SCALABLE_KIND \u003d [\"Deployment\", \"ReplicaSet\", \"StatefulSet\"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"2247baea_c9bc82a6","line":33,"range":{"start_line":33,"start_character":14,"end_line":33,"end_character":15},"in_reply_to":"b1766eb7_d1c53e83","updated":"2022-09-07 00:29:28.000000000","message":"Ack","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b2946e72ea288db28dcb24b489f66bbc56867a08","unresolved":true,"context_lines":[{"line_number":31,"context_line":"CHECK_INTERVAL \u003d 10"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"TARGET_KIND \u003d [\"Pod\", \"Deployment\", \"DaemonSet\", \"StatefulSet\", \"ReplicaSet\"]"},{"line_number":34,"context_line":"SCALABLE_KIND \u003d [\"Deployment\", \"ReplicaSet\", \"StatefulSet\"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class Kubernetes(object):"}],"source_content_type":"text/x-python","patch_set":9,"id":"2c351428_be610b17","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":17},"updated":"2022-09-06 02:53:36.000000000","message":"ditto.","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6989550e2b4d370443fc0c5fc6e01f414ce475ab","unresolved":true,"context_lines":[{"line_number":31,"context_line":"CHECK_INTERVAL \u003d 10"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"TARGET_KIND \u003d [\"Pod\", \"Deployment\", \"DaemonSet\", \"StatefulSet\", \"ReplicaSet\"]"},{"line_number":34,"context_line":"SCALABLE_KIND \u003d [\"Deployment\", \"ReplicaSet\", \"StatefulSet\"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class Kubernetes(object):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ef35f99c_2fa6641b","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":17},"in_reply_to":"2c351428_be610b17","updated":"2022-09-06 03:55:40.000000000","message":"I will fix.","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"923dac0b70cf839c30c9c760a434716cabd0aae4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"CHECK_INTERVAL \u003d 10"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"TARGET_KIND \u003d [\"Pod\", \"Deployment\", \"DaemonSet\", \"StatefulSet\", \"ReplicaSet\"]"},{"line_number":34,"context_line":"SCALABLE_KIND \u003d [\"Deployment\", \"ReplicaSet\", \"StatefulSet\"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class Kubernetes(object):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1d949369_12e1ecd2","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":17},"in_reply_to":"ef35f99c_2fa6641b","updated":"2022-09-07 00:29:28.000000000","message":"Ack","commit_id":"4b3feda9a13bc2651b39026fe88e611b60be6e9b"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_resource.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d9fb0c7e9565904082cc4d3abdcf0b651eb1be43","unresolved":true,"context_lines":[{"line_number":413,"context_line":"    api_class \u003d client.AppsV1Api"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def delete(self, body):"},{"line_number":416,"context_line":"        def _get_pvcs_for_delete(sfs_name, namespace):"},{"line_number":417,"context_line":"            pvcs_for_delete \u003d []"},{"line_number":418,"context_line":"            try:"},{"line_number":419,"context_line":"                resp_read_sfs \u003d self.read()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dbd811ef_b28470e8","line":416,"range":{"start_line":416,"start_character":43,"end_line":416,"end_character":52},"updated":"2022-09-01 07:55:38.000000000","message":"This argument seems not to be used.\nCould you replace to namespace instead of `self.namespace` at L.426 or delete argument.","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b2946e72ea288db28dcb24b489f66bbc56867a08","unresolved":false,"context_lines":[{"line_number":413,"context_line":"    api_class \u003d client.AppsV1Api"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def delete(self, body):"},{"line_number":416,"context_line":"        def _get_pvcs_for_delete(sfs_name, namespace):"},{"line_number":417,"context_line":"            pvcs_for_delete \u003d []"},{"line_number":418,"context_line":"            try:"},{"line_number":419,"context_line":"                resp_read_sfs \u003d self.read()"}],"source_content_type":"text/x-python","patch_set":5,"id":"a01ff3de_53de7716","line":416,"range":{"start_line":416,"start_character":43,"end_line":416,"end_character":52},"in_reply_to":"d610cc3d_3b351298","updated":"2022-09-06 02:53:36.000000000","message":"Ack","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9e70ceec81dfcab4af40b1fea66471b2e7c7c683","unresolved":true,"context_lines":[{"line_number":413,"context_line":"    api_class \u003d client.AppsV1Api"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def delete(self, body):"},{"line_number":416,"context_line":"        def _get_pvcs_for_delete(sfs_name, namespace):"},{"line_number":417,"context_line":"            pvcs_for_delete \u003d []"},{"line_number":418,"context_line":"            try:"},{"line_number":419,"context_line":"                resp_read_sfs \u003d self.read()"}],"source_content_type":"text/x-python","patch_set":5,"id":"d610cc3d_3b351298","line":416,"range":{"start_line":416,"start_character":43,"end_line":416,"end_character":52},"in_reply_to":"dbd811ef_b28470e8","updated":"2022-09-01 22:52:39.000000000","message":"it seems _get_pvcs_for_delete is not necessary as method. I will remove the method and write codes in it directory.","commit_id":"814b7a3950791c828308ade1d4c6bf5f951b1f52"}],"tacker/sol_refactored/objects/v2/vnf_instance.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3ef68bf643042a78f0a99cc9cad329da4a0cf1a0","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            \u0027VnfVirtualLinkResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":83,"context_line":"        \u0027virtualStorageResourceInfo\u0027: fields.ListOfObjectsField("},{"line_number":84,"context_line":"            \u0027VirtualStorageResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":86,"context_line":"        # NOTE: vnfcInfo exists in SOL002 only."},{"line_number":87,"context_line":"        \u0027vnfcInfo\u0027: fields.ListOfObjectsField(\u0027VnfcInfoV2\u0027, nullable\u003dTrue),"},{"line_number":88,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"f88b8010_65bc0dc7","line":85,"range":{"start_line":85,"start_character":9,"end_line":85,"end_character":17},"updated":"2022-09-01 02:35:54.000000000","message":"It\u0027s better to add NOTE that this attribute is Tacker\u0027s original definition that does not define in SOL.","commit_id":"e3dccfc07791fcb39ed5f894e1cafddb73477fbc"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"442cbf3637c83249be0d7afbb62f1c81c87100db","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027VnfVirtualLinkResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":83,"context_line":"        \u0027virtualStorageResourceInfo\u0027: fields.ListOfObjectsField("},{"line_number":84,"context_line":"            \u0027VirtualStorageResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":86,"context_line":"        # NOTE: vnfcInfo exists in SOL002 only."},{"line_number":87,"context_line":"        \u0027vnfcInfo\u0027: fields.ListOfObjectsField(\u0027VnfcInfoV2\u0027, nullable\u003dTrue),"},{"line_number":88,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"c0353951_6f6934dd","line":85,"range":{"start_line":85,"start_character":9,"end_line":85,"end_character":17},"in_reply_to":"6bdf7637_2acee50e","updated":"2022-09-05 05:21:13.000000000","message":"Done","commit_id":"e3dccfc07791fcb39ed5f894e1cafddb73477fbc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"703df20f3fc3e1adf68b07176af42c585e052a2a","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            \u0027VnfVirtualLinkResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":83,"context_line":"        \u0027virtualStorageResourceInfo\u0027: fields.ListOfObjectsField("},{"line_number":84,"context_line":"            \u0027VirtualStorageResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":86,"context_line":"        # NOTE: vnfcInfo exists in SOL002 only."},{"line_number":87,"context_line":"        \u0027vnfcInfo\u0027: fields.ListOfObjectsField(\u0027VnfcInfoV2\u0027, nullable\u003dTrue),"},{"line_number":88,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"6bdf7637_2acee50e","line":85,"range":{"start_line":85,"start_character":9,"end_line":85,"end_character":17},"in_reply_to":"f88b8010_65bc0dc7","updated":"2022-09-01 22:33:48.000000000","message":"right. I will add a comment.","commit_id":"e3dccfc07791fcb39ed5f894e1cafddb73477fbc"}]}