)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8c5085d632eddcd389fd66a6ad31d265d7137de4","unresolved":true,"context_lines":[{"line_number":14,"context_line":"   (for Tacker v2 API)"},{"line_number":15,"context_line":"2. Support subscription filter of vnfdId (for Tacker v1 API)"},{"line_number":16,"context_line":"3. Refactor the Tacker Output Logs (for Tacker v1/v2 API)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I8879a690e455fb196c2e28a251bf46cea7376b56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e6efd142_12d75ec4","line":17,"updated":"2022-09-05 05:56:56.000000000","message":"You need to add information about the blueprint.\n---\nImplement: blueprint system-performance-management","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"   (for Tacker v2 API)"},{"line_number":15,"context_line":"2. Support subscription filter of vnfdId (for Tacker v1 API)"},{"line_number":16,"context_line":"3. Refactor the Tacker Output Logs (for Tacker v1/v2 API)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I8879a690e455fb196c2e28a251bf46cea7376b56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"46d4c4d9_0306c1d4","line":17,"in_reply_to":"30b8a356_43588edb","updated":"2022-09-06 08:13:36.000000000","message":"Done","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":true,"context_lines":[{"line_number":14,"context_line":"   (for Tacker v2 API)"},{"line_number":15,"context_line":"2. Support subscription filter of vnfdId (for Tacker v1 API)"},{"line_number":16,"context_line":"3. Refactor the Tacker Output Logs (for Tacker v1/v2 API)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I8879a690e455fb196c2e28a251bf46cea7376b56"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"30b8a356_43588edb","line":17,"in_reply_to":"e6efd142_12d75ec4","updated":"2022-09-06 05:51:49.000000000","message":"I fixed it in PS4.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"1907be2ebe5b10b6d9dd4be0fdfd245e0db20558","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"11384ff8_bc6a3993","updated":"2022-09-02 03:21:00.000000000","message":"recheck","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"858ef8008654a2547e0a50c6187148cf3bf84e6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9449e0c4_2e54ffdb","updated":"2022-09-02 07:09:59.000000000","message":"recheck","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"f3b05de053610f3bc43927ebc6ba2f724f73bc19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7521380_a6c43048","updated":"2022-09-05 00:28:01.000000000","message":"recheck","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"955f5a4d757281b3227b7037f3a14883956672a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d5eba1d4_5673d565","updated":"2022-09-06 06:33:37.000000000","message":"Thanks for patch, please find few comments.","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"29523464_3b2e288f","updated":"2022-09-06 05:51:49.000000000","message":"To Hiroo Kitamura:\nThank you for your comments.\nI fixed them in PS4.\nPlease kindly check them again.","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"98924e6c651fbde0101a269f2df3a60646286b0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"009eb204_e0d63dad","updated":"2022-09-11 17:20:29.000000000","message":"Please confirm my tiny comments, thanks!","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"ced3be59c78eab26cde22f568a88e132d7d80ff4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0b8b7cb1_149533d3","updated":"2022-09-08 08:19:20.000000000","message":"Thank you for the patch.\nPlease kindly find my comment.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2a7165550131dde7030436b3d4b9834251172070","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"19e6dda4_a2160d73","updated":"2022-09-08 12:07:11.000000000","message":"recheck","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"8034c368080616812834e717f4e0d6141844a4f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2a39e00b_23f85a17","updated":"2022-09-08 06:19:22.000000000","message":"recheck","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f9011ca7_4b83dd7d","updated":"2022-09-14 00:18:27.000000000","message":"Thank you for your comments.\nI fixed them in PS12.\nPlease kindly check them again.","commit_id":"e4d4e25ca221a50501e6d0aae2ebc003082abb9b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"415fcbe037393f0a3bd6710a73596fa2589999b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8f78dc53_a94b92c5","updated":"2022-09-13 12:13:31.000000000","message":"recheck","commit_id":"e4d4e25ca221a50501e6d0aae2ebc003082abb9b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bbc7d4c85a220ad8314d291b53a2a6211f9e9e3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"01ebef9c_3616b1a3","updated":"2022-09-15 03:00:27.000000000","message":"LGTM","commit_id":"0c69e122b2562fb7c07a872f32c399052e4a8429"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"62e612aaf2361a6b18b19e3371a623f6f3f3bc99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9d7e80d3_b10cb9d0","updated":"2022-09-15 01:47:00.000000000","message":"Thanks for rework. LGTM!","commit_id":"0c69e122b2562fb7c07a872f32c399052e4a8429"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"7e18b13dd7eac1234d7a5d42030e5b934f2c3c02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e1bd20fc_95bf4650","updated":"2022-09-14 08:28:19.000000000","message":"To Yasufumi Ogawa:\nThank you for your suggestion.\nI fixed it in PS13.\nPlease kindly check it again.","commit_id":"0c69e122b2562fb7c07a872f32c399052e4a8429"}],"releasenotes/notes/refactor-for-performance-improvement-fc176d9abfec6c76.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"98924e6c651fbde0101a269f2df3a60646286b0b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This update mainly refactors some code to improve the performance"},{"line_number":5,"context_line":"    of Tacker, and corrects the output level of log. At the same time,"},{"line_number":6,"context_line":"    the redirection when V2 calls HEAT\u0027s API is removed instead of"},{"line_number":7,"context_line":"    direct call, and the subcription filter when sends notification"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c8adac67_a42b5c1b","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":32},"updated":"2022-09-11 17:20:29.000000000","message":"\"This update\" cannot be found on the releasenotes because there is no clue or link for. You\u0027d better to explain what was changed explicitly, and more if you add a link to documentation or so.\n\nI suggest to describe simply how you improve the performance like below.\n\n```\n\"Improve performance of Tacker by ...\n```","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This update mainly refactors some code to improve the performance"},{"line_number":5,"context_line":"    of Tacker, and corrects the output level of log. At the same time,"},{"line_number":6,"context_line":"    the redirection when V2 calls HEAT\u0027s API is removed instead of"},{"line_number":7,"context_line":"    direct call, and the subcription filter when sends notification"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"841030a6_6ddf0ff7","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":32},"in_reply_to":"c8adac67_a42b5c1b","updated":"2022-09-14 00:18:27.000000000","message":"I fixed it in PS12.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"98924e6c651fbde0101a269f2df3a60646286b0b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This update mainly refactors some code to improve the performance"},{"line_number":5,"context_line":"    of Tacker, and corrects the output level of log. At the same time,"},{"line_number":6,"context_line":"    the redirection when V2 calls HEAT\u0027s API is removed instead of"},{"line_number":7,"context_line":"    direct call, and the subcription filter when sends notification"},{"line_number":8,"context_line":"    is improved in V1 code."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ec7668a6_54913003","line":8,"range":{"start_line":5,"start_character":53,"end_line":8,"end_character":27},"updated":"2022-09-11 17:20:29.000000000","message":"It looks better to move to next as second item to apart this sentence from improvement.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This update mainly refactors some code to improve the performance"},{"line_number":5,"context_line":"    of Tacker, and corrects the output level of log. At the same time,"},{"line_number":6,"context_line":"    the redirection when V2 calls HEAT\u0027s API is removed instead of"},{"line_number":7,"context_line":"    direct call, and the subcription filter when sends notification"},{"line_number":8,"context_line":"    is improved in V1 code."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"8615da20_8ef751f8","line":8,"range":{"start_line":5,"start_character":53,"end_line":8,"end_character":27},"in_reply_to":"ec7668a6_54913003","updated":"2022-09-14 00:18:27.000000000","message":"I modified this part in PS12.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"}],"tacker/api/api_common.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"98924e6c651fbde0101a269f2df3a60646286b0b","unresolved":true,"context_lines":[{"line_number":129,"context_line":"                raise ValueError()"},{"line_number":130,"context_line":"        except ValueError:"},{"line_number":131,"context_line":"            LOG.error(\"Invalid value for pagination_max_limit: %s. It \""},{"line_number":132,"context_line":"                      \"should be an integer greater to 0\","},{"line_number":133,"context_line":"                      cfg.CONF.pagination_max_limit)"},{"line_number":134,"context_line":"    return max_limit"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ce9ba100_623295d3","line":132,"range":{"start_line":132,"start_character":23,"end_line":132,"end_character":43},"updated":"2022-09-11 17:20:29.000000000","message":"Do we need to explain it as an error if the type is not int? I wonder it cannot be happened if the type is float or string. Why don\u0027t you notify it simply like as below? I think it\u0027s enough to tell if the type is not int as warning at least.\n\n```\n\"pagination_max_limit: %s must be greater than 0\"\n```","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"98924e6c651fbde0101a269f2df3a60646286b0b","unresolved":true,"context_lines":[{"line_number":129,"context_line":"                raise ValueError()"},{"line_number":130,"context_line":"        except ValueError:"},{"line_number":131,"context_line":"            LOG.error(\"Invalid value for pagination_max_limit: %s. It \""},{"line_number":132,"context_line":"                      \"should be an integer greater to 0\","},{"line_number":133,"context_line":"                      cfg.CONF.pagination_max_limit)"},{"line_number":134,"context_line":"    return max_limit"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7d7e6b42_21602a53","line":132,"range":{"start_line":132,"start_character":52,"end_line":132,"end_character":54},"updated":"2022-09-11 17:20:29.000000000","message":"nit: than?","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":129,"context_line":"                raise ValueError()"},{"line_number":130,"context_line":"        except ValueError:"},{"line_number":131,"context_line":"            LOG.error(\"Invalid value for pagination_max_limit: %s. It \""},{"line_number":132,"context_line":"                      \"should be an integer greater to 0\","},{"line_number":133,"context_line":"                      cfg.CONF.pagination_max_limit)"},{"line_number":134,"context_line":"    return max_limit"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"653d6876_f18d0ad3","line":132,"range":{"start_line":132,"start_character":52,"end_line":132,"end_character":54},"in_reply_to":"7d7e6b42_21602a53","updated":"2022-09-14 00:18:27.000000000","message":"I fixed it in PS12.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":129,"context_line":"                raise ValueError()"},{"line_number":130,"context_line":"        except ValueError:"},{"line_number":131,"context_line":"            LOG.error(\"Invalid value for pagination_max_limit: %s. It \""},{"line_number":132,"context_line":"                      \"should be an integer greater to 0\","},{"line_number":133,"context_line":"                      cfg.CONF.pagination_max_limit)"},{"line_number":134,"context_line":"    return max_limit"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9945dc95_e7d7999a","line":132,"range":{"start_line":132,"start_character":23,"end_line":132,"end_character":43},"in_reply_to":"ce9ba100_623295d3","updated":"2022-09-14 00:18:27.000000000","message":"I fixed it in PS12.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"}],"tacker/api/extensions.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"98924e6c651fbde0101a269f2df3a60646286b0b","unresolved":true,"context_lines":[{"line_number":562,"context_line":"            return"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        alias \u003d ext.get_alias()"},{"line_number":565,"context_line":"        LOG.debug(\u0027Loaded extension: %s\u0027, alias)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        if alias in self.extensions:"},{"line_number":568,"context_line":"            raise exceptions.DuplicatedExtension(alias\u003dalias)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3194066c_3a7cb5ff","line":565,"updated":"2022-09-11 17:20:29.000000000","message":"Is this log useful even though debug()? Anyway, it looks too simple to understand what is the meaning...","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":562,"context_line":"            return"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        alias \u003d ext.get_alias()"},{"line_number":565,"context_line":"        LOG.debug(\u0027Loaded extension: %s\u0027, alias)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        if alias in self.extensions:"},{"line_number":568,"context_line":"            raise exceptions.DuplicatedExtension(alias\u003dalias)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ed3da484_7643f3f3","line":565,"in_reply_to":"3194066c_3a7cb5ff","updated":"2022-09-14 00:18:27.000000000","message":"This log is only output when tacker-server is started.\nFor example the following.\n```\nLoaded extension: Commonservices add_extension /opt/stack/tacker/tacker/api/extensions.py:565\nLoaded extension: NFVO add_extension /opt/stack/tacker/tacker/api/extensions.py:565\nLoaded extension: VNFM add_extension /opt/stack/tacker/tacker/api/extensions.py:565\n```\nThis kind of information is useless for the user. For the developer, you can look at the loaded extension.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"7e18b13dd7eac1234d7a5d42030e5b934f2c3c02","unresolved":true,"context_lines":[{"line_number":562,"context_line":"            return"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        alias \u003d ext.get_alias()"},{"line_number":565,"context_line":"        LOG.debug(\u0027Loaded extension: %s\u0027, alias)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        if alias in self.extensions:"},{"line_number":568,"context_line":"            raise exceptions.DuplicatedExtension(alias\u003dalias)"}],"source_content_type":"text/x-python","patch_set":10,"id":"691b3295_9681ef25","line":565,"in_reply_to":"b12e6df6_38625699","updated":"2022-09-14 08:28:19.000000000","message":"It doesn\u0027t look like this log does anything special.\nSo I deleted it.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a41f261b7c1cbc6c21d3e090014ae94a10980698","unresolved":true,"context_lines":[{"line_number":562,"context_line":"            return"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        alias \u003d ext.get_alias()"},{"line_number":565,"context_line":"        LOG.debug(\u0027Loaded extension: %s\u0027, alias)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        if alias in self.extensions:"},{"line_number":568,"context_line":"            raise exceptions.DuplicatedExtension(alias\u003dalias)"}],"source_content_type":"text/x-python","patch_set":10,"id":"b12e6df6_38625699","line":565,"in_reply_to":"ed3da484_7643f3f3","updated":"2022-09-14 03:02:58.000000000","message":"It looks one of them if it\u0027s just telling an usual event in each component and no need to do so. Or, It might be better to clear the purpose explicitly.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"}],"tacker/api/v1/resource.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8c5085d632eddcd389fd66a6ad31d265d7137de4","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                                                                  language)"},{"line_number":81,"context_line":"            if hasattr(mapped_exc, \u0027code\u0027) and 400 \u003c\u003d mapped_exc.code \u003c 500:"},{"line_number":82,"context_line":"                LOG.error(\u0027%(action)s failed (client error): %(exc)s\u0027,"},{"line_number":83,"context_line":"                         {\u0027action\u0027: action, \u0027exc\u0027: mapped_exc})"},{"line_number":84,"context_line":"            else:"},{"line_number":85,"context_line":"                LOG.exception(\u0027%(action)s failed: %(details)s\u0027,"},{"line_number":86,"context_line":"                              {\u0027action\u0027: action,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2c3dcc0d_1bef52d0","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":26},"updated":"2022-09-05 05:56:56.000000000","message":"You need to add one space.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                                                                  language)"},{"line_number":81,"context_line":"            if hasattr(mapped_exc, \u0027code\u0027) and 400 \u003c\u003d mapped_exc.code \u003c 500:"},{"line_number":82,"context_line":"                LOG.error(\u0027%(action)s failed (client error): %(exc)s\u0027,"},{"line_number":83,"context_line":"                         {\u0027action\u0027: action, \u0027exc\u0027: mapped_exc})"},{"line_number":84,"context_line":"            else:"},{"line_number":85,"context_line":"                LOG.exception(\u0027%(action)s failed: %(details)s\u0027,"},{"line_number":86,"context_line":"                              {\u0027action\u0027: action,"}],"source_content_type":"text/x-python","patch_set":3,"id":"34f89a25_686c40dd","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":26},"in_reply_to":"2c3dcc0d_1bef52d0","updated":"2022-09-06 05:51:49.000000000","message":"I fixed it in PS4.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                                                  language)"},{"line_number":81,"context_line":"            if hasattr(mapped_exc, \u0027code\u0027) and 400 \u003c\u003d mapped_exc.code \u003c 500:"},{"line_number":82,"context_line":"                LOG.error(\u0027%(action)s failed (client error): %(exc)s\u0027,"},{"line_number":83,"context_line":"                         {\u0027action\u0027: action, \u0027exc\u0027: mapped_exc})"},{"line_number":84,"context_line":"            else:"},{"line_number":85,"context_line":"                LOG.exception(\u0027%(action)s failed: %(details)s\u0027,"},{"line_number":86,"context_line":"                              {\u0027action\u0027: action,"}],"source_content_type":"text/x-python","patch_set":3,"id":"8d4f5c18_d1320d97","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":26},"in_reply_to":"34f89a25_686c40dd","updated":"2022-09-06 08:13:36.000000000","message":"Done","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"}],"tacker/auth.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8c5085d632eddcd389fd66a6ad31d265d7137de4","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        LOG.info("},{"line_number":105,"context_line":"            \"Get Access Token, Connecting to \u003cGET:{}\u003e\".format("},{"line_number":106,"context_line":"                self.token_endpoint))"},{"line_number":107,"context_line":"        LOG.debug(\"Request Headers\u003d{}\".format(kwargs.get(\u0027headers\u0027)))"},{"line_number":108,"context_line":"        LOG.debug(\"Request Body\u003d{}\".format(kwargs.get(\u0027data\u0027)))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        response \u003d basic_auth_request.post("},{"line_number":111,"context_line":"            self.token_endpoint,"},{"line_number":112,"context_line":"            verify\u003dcfg.CONF.authentication.verify_oauth2_ssl,"}],"source_content_type":"text/x-python","patch_set":3,"id":"90fe0a5c_d22f7d2e","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":0},"updated":"2022-09-05 05:56:56.000000000","message":"Although it is different from the original purpose of this patch, you can modify it according to L117 and 118 as follows.\n---\n        LOG.debug(\"[REQ] Headers\u003d{}\".format(kwargs.get(\u0027headers\u0027)))\n        LOG.debug(\"[REQ] Body\u003d{}\".format(kwargs.get(\u0027data\u0027)))","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":true,"context_lines":[{"line_number":104,"context_line":"        LOG.info("},{"line_number":105,"context_line":"            \"Get Access Token, Connecting to \u003cGET:{}\u003e\".format("},{"line_number":106,"context_line":"                self.token_endpoint))"},{"line_number":107,"context_line":"        LOG.debug(\"Request Headers\u003d{}\".format(kwargs.get(\u0027headers\u0027)))"},{"line_number":108,"context_line":"        LOG.debug(\"Request Body\u003d{}\".format(kwargs.get(\u0027data\u0027)))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        response \u003d basic_auth_request.post("},{"line_number":111,"context_line":"            self.token_endpoint,"},{"line_number":112,"context_line":"            verify\u003dcfg.CONF.authentication.verify_oauth2_ssl,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a35aa93d_2a02c2b5","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":0},"in_reply_to":"90fe0a5c_d22f7d2e","updated":"2022-09-06 05:51:49.000000000","message":"I fixed it in PS4.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        LOG.info("},{"line_number":105,"context_line":"            \"Get Access Token, Connecting to \u003cGET:{}\u003e\".format("},{"line_number":106,"context_line":"                self.token_endpoint))"},{"line_number":107,"context_line":"        LOG.debug(\"Request Headers\u003d{}\".format(kwargs.get(\u0027headers\u0027)))"},{"line_number":108,"context_line":"        LOG.debug(\"Request Body\u003d{}\".format(kwargs.get(\u0027data\u0027)))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        response \u003d basic_auth_request.post("},{"line_number":111,"context_line":"            self.token_endpoint,"},{"line_number":112,"context_line":"            verify\u003dcfg.CONF.authentication.verify_oauth2_ssl,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ee344a23_9b0ea069","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":0},"in_reply_to":"a35aa93d_2a02c2b5","updated":"2022-09-06 08:13:36.000000000","message":"Done","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"}],"tacker/common/cmd_executer.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"98924e6c651fbde0101a269f2df3a60646286b0b","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def close_session(self):"},{"line_number":77,"context_line":"        self.__ssh.close()"},{"line_number":78,"context_line":"        LOG.info(\"Connection close\")"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def execute_command(self, cmd, input_data\u003dNone):"},{"line_number":81,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"a87900f3_4ff557c7","line":78,"updated":"2022-09-11 17:20:29.000000000","message":"What the connection?","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def close_session(self):"},{"line_number":77,"context_line":"        self.__ssh.close()"},{"line_number":78,"context_line":"        LOG.info(\"Connection close\")"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def execute_command(self, cmd, input_data\u003dNone):"},{"line_number":81,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"8c5ed9a0_d0f2e046","line":78,"in_reply_to":"a87900f3_4ff557c7","updated":"2022-09-14 00:18:27.000000000","message":"A connection to a remote server.\nAfter using the paramiko module to establish an ssh connection with a remote server, manual close is required to close the connection.\nI modified the log to make it better in PS12.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"}],"tacker/common/driver_manager.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8c5085d632eddcd389fd66a6ad31d265d7137de4","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        self._drivers \u003d dict((type_, ext.obj)"},{"line_number":47,"context_line":"                             for (type_, ext) in drivers.items())"},{"line_number":48,"context_line":"        LOG.debug(\"Registered drivers from %(namespace)s: %(keys)s\","},{"line_number":49,"context_line":"                 {\u0027namespace\u0027: namespace, \u0027keys\u0027: self._drivers.keys()})"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _driver_name(driver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"806bc0f0_9d4a12e7","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":18},"updated":"2022-09-05 05:56:56.000000000","message":"You need to add one space.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self._drivers \u003d dict((type_, ext.obj)"},{"line_number":47,"context_line":"                             for (type_, ext) in drivers.items())"},{"line_number":48,"context_line":"        LOG.debug(\"Registered drivers from %(namespace)s: %(keys)s\","},{"line_number":49,"context_line":"                 {\u0027namespace\u0027: namespace, \u0027keys\u0027: self._drivers.keys()})"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _driver_name(driver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"4b52e2cd_d63815ed","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":18},"in_reply_to":"66a24b8f_e4d858a5","updated":"2022-09-06 08:13:36.000000000","message":"Done","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        self._drivers \u003d dict((type_, ext.obj)"},{"line_number":47,"context_line":"                             for (type_, ext) in drivers.items())"},{"line_number":48,"context_line":"        LOG.debug(\"Registered drivers from %(namespace)s: %(keys)s\","},{"line_number":49,"context_line":"                 {\u0027namespace\u0027: namespace, \u0027keys\u0027: self._drivers.keys()})"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _driver_name(driver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"66a24b8f_e4d858a5","line":49,"range":{"start_line":49,"start_character":17,"end_line":49,"end_character":18},"in_reply_to":"806bc0f0_9d4a12e7","updated":"2022-09-06 05:51:49.000000000","message":"ditto","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"}],"tacker/common/utils.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8c5085d632eddcd389fd66a6ad31d265d7137de4","unresolved":true,"context_lines":[{"line_number":623,"context_line":"        else:"},{"line_number":624,"context_line":"            unit \u003d MemoryUnit.UNIT_SIZE_DEFAULT"},{"line_number":625,"context_line":"            LOG.debug(_(\u0027A memory unit is not provided for size; using the \u0027"},{"line_number":626,"context_line":"                       \u0027default unit %(default)s.\u0027) % {\u0027default\u0027: \u0027B\u0027})"},{"line_number":627,"context_line":"        result \u003d re.sub(r\u0027\\s+\u0027, \u0027 \u0027, size).split(\u0027 \u0027)"},{"line_number":628,"context_line":"        if len(result) \u003d\u003d 2:"},{"line_number":629,"context_line":"            if result[1]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5547058c_089d55a0","line":626,"range":{"start_line":626,"start_character":23,"end_line":626,"end_character":24},"updated":"2022-09-05 05:56:56.000000000","message":"You need to add one space.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        else:"},{"line_number":624,"context_line":"            unit \u003d MemoryUnit.UNIT_SIZE_DEFAULT"},{"line_number":625,"context_line":"            LOG.debug(_(\u0027A memory unit is not provided for size; using the \u0027"},{"line_number":626,"context_line":"                       \u0027default unit %(default)s.\u0027) % {\u0027default\u0027: \u0027B\u0027})"},{"line_number":627,"context_line":"        result \u003d re.sub(r\u0027\\s+\u0027, \u0027 \u0027, size).split(\u0027 \u0027)"},{"line_number":628,"context_line":"        if len(result) \u003d\u003d 2:"},{"line_number":629,"context_line":"            if result[1]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"b559960e_3599b531","line":626,"range":{"start_line":626,"start_character":23,"end_line":626,"end_character":24},"in_reply_to":"4e035745_84950b21","updated":"2022-09-06 08:13:36.000000000","message":"Done","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":true,"context_lines":[{"line_number":623,"context_line":"        else:"},{"line_number":624,"context_line":"            unit \u003d MemoryUnit.UNIT_SIZE_DEFAULT"},{"line_number":625,"context_line":"            LOG.debug(_(\u0027A memory unit is not provided for size; using the \u0027"},{"line_number":626,"context_line":"                       \u0027default unit %(default)s.\u0027) % {\u0027default\u0027: \u0027B\u0027})"},{"line_number":627,"context_line":"        result \u003d re.sub(r\u0027\\s+\u0027, \u0027 \u0027, size).split(\u0027 \u0027)"},{"line_number":628,"context_line":"        if len(result) \u003d\u003d 2:"},{"line_number":629,"context_line":"            if result[1]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"4e035745_84950b21","line":626,"range":{"start_line":626,"start_character":23,"end_line":626,"end_character":24},"in_reply_to":"5547058c_089d55a0","updated":"2022-09-06 05:51:49.000000000","message":"ditto","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8c5085d632eddcd389fd66a6ad31d265d7137de4","unresolved":true,"context_lines":[{"line_number":633,"context_line":"                                math.pow(MemoryUnit.UNIT_SIZE_DICT"},{"line_number":634,"context_line":"                                         [unit], -1))"},{"line_number":635,"context_line":"                LOG.debug(_(\u0027Given size %(size)s is converted to %(num)s \u0027"},{"line_number":636,"context_line":"                           \u0027%(unit)s.\u0027) % {\u0027size\u0027: size,"},{"line_number":637,"context_line":"                         \u0027num\u0027: converted, \u0027unit\u0027: unit})"},{"line_number":638,"context_line":"            else:"},{"line_number":639,"context_line":"                msg \u003d _(\u0027Size is not given for software image data.\u0027)"},{"line_number":640,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9c676d04_f9e7335a","line":637,"range":{"start_line":636,"start_character":27,"end_line":637,"end_character":57},"updated":"2022-09-05 05:56:56.000000000","message":"You need to add some spaces.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                                math.pow(MemoryUnit.UNIT_SIZE_DICT"},{"line_number":634,"context_line":"                                         [unit], -1))"},{"line_number":635,"context_line":"                LOG.debug(_(\u0027Given size %(size)s is converted to %(num)s \u0027"},{"line_number":636,"context_line":"                           \u0027%(unit)s.\u0027) % {\u0027size\u0027: size,"},{"line_number":637,"context_line":"                         \u0027num\u0027: converted, \u0027unit\u0027: unit})"},{"line_number":638,"context_line":"            else:"},{"line_number":639,"context_line":"                msg \u003d _(\u0027Size is not given for software image data.\u0027)"},{"line_number":640,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"6a5d0c0b_abdc138c","line":637,"range":{"start_line":636,"start_character":27,"end_line":637,"end_character":57},"in_reply_to":"84555286_a66e4e76","updated":"2022-09-06 08:13:36.000000000","message":"Done","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":true,"context_lines":[{"line_number":633,"context_line":"                                math.pow(MemoryUnit.UNIT_SIZE_DICT"},{"line_number":634,"context_line":"                                         [unit], -1))"},{"line_number":635,"context_line":"                LOG.debug(_(\u0027Given size %(size)s is converted to %(num)s \u0027"},{"line_number":636,"context_line":"                           \u0027%(unit)s.\u0027) % {\u0027size\u0027: size,"},{"line_number":637,"context_line":"                         \u0027num\u0027: converted, \u0027unit\u0027: unit})"},{"line_number":638,"context_line":"            else:"},{"line_number":639,"context_line":"                msg \u003d _(\u0027Size is not given for software image data.\u0027)"},{"line_number":640,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"84555286_a66e4e76","line":637,"range":{"start_line":636,"start_character":27,"end_line":637,"end_character":57},"in_reply_to":"9c676d04_f9e7335a","updated":"2022-09-06 05:51:49.000000000","message":"ditto","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"}],"tacker/db/db_base.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8c5085d632eddcd389fd66a6ad31d265d7137de4","unresolved":true,"context_lines":[{"line_number":214,"context_line":"            return query.filter(model.name \u003d\u003d name).one()"},{"line_number":215,"context_line":"        except orm_exc.NoResultFound:"},{"line_number":216,"context_line":"            LOG.error(\"No result found for %(name)s in %(model)s table\","},{"line_number":217,"context_line":"                     {\u0027name\u0027: name, \u0027model\u0027: model})"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def get_by_name(self, context, model, name):"},{"line_number":220,"context_line":"        return self._get_by_name(context, model, name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"72325374_d7d5293d","line":217,"range":{"start_line":217,"start_character":21,"end_line":217,"end_character":22},"updated":"2022-09-05 05:56:56.000000000","message":"You need to add one space.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            return query.filter(model.name \u003d\u003d name).one()"},{"line_number":215,"context_line":"        except orm_exc.NoResultFound:"},{"line_number":216,"context_line":"            LOG.error(\"No result found for %(name)s in %(model)s table\","},{"line_number":217,"context_line":"                     {\u0027name\u0027: name, \u0027model\u0027: model})"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def get_by_name(self, context, model, name):"},{"line_number":220,"context_line":"        return self._get_by_name(context, model, name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"116ed8cc_06cbe308","line":217,"range":{"start_line":217,"start_character":21,"end_line":217,"end_character":22},"in_reply_to":"1a686531_5c8bc15c","updated":"2022-09-06 08:13:36.000000000","message":"Done","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":true,"context_lines":[{"line_number":214,"context_line":"            return query.filter(model.name \u003d\u003d name).one()"},{"line_number":215,"context_line":"        except orm_exc.NoResultFound:"},{"line_number":216,"context_line":"            LOG.error(\"No result found for %(name)s in %(model)s table\","},{"line_number":217,"context_line":"                     {\u0027name\u0027: name, \u0027model\u0027: model})"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def get_by_name(self, context, model, name):"},{"line_number":220,"context_line":"        return self._get_by_name(context, model, name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a686531_5c8bc15c","line":217,"range":{"start_line":217,"start_character":21,"end_line":217,"end_character":22},"in_reply_to":"72325374_d7d5293d","updated":"2022-09-06 05:51:49.000000000","message":"ditto","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"}],"tacker/objects/vnfd.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"955f5a4d757281b3227b7037f3a14883956672a7","unresolved":true,"context_lines":[{"line_number":77,"context_line":"            filter_by(id\u003did).\\"},{"line_number":78,"context_line":"            update(updated_values, synchronize_session\u003dFalse)"},{"line_number":79,"context_line":"    except Exception:"},{"line_number":80,"context_line":"        LOG.warning(\"destroy vnfdfailed\")"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"@base.TackerObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":4,"id":"d5258bab_f1020120","line":80,"updated":"2022-09-06 06:33:37.000000000","message":"Please add the missing space.","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"62e612aaf2361a6b18b19e3371a623f6f3f3bc99","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            filter_by(id\u003did).\\"},{"line_number":78,"context_line":"            update(updated_values, synchronize_session\u003dFalse)"},{"line_number":79,"context_line":"    except Exception:"},{"line_number":80,"context_line":"        LOG.warning(\"destroy vnfdfailed\")"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"@base.TackerObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":4,"id":"091b0a42_b1ce92b9","line":80,"in_reply_to":"1caff3bc_73473332","updated":"2022-09-15 01:47:00.000000000","message":"Ack","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":77,"context_line":"            filter_by(id\u003did).\\"},{"line_number":78,"context_line":"            update(updated_values, synchronize_session\u003dFalse)"},{"line_number":79,"context_line":"    except Exception:"},{"line_number":80,"context_line":"        LOG.warning(\"destroy vnfdfailed\")"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"@base.TackerObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":4,"id":"1caff3bc_73473332","line":80,"in_reply_to":"d5258bab_f1020120","updated":"2022-09-14 00:18:27.000000000","message":"I fixed it in PS12.","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"}],"tacker/sol_refactored/infra_drivers/openstack/heat_utils.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"cfb82100c950a9234138e3edc256d188f4524672","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    def create_stack(self, fields, wait\u003dTrue):"},{"line_number":44,"context_line":"        path \u003d \"stacks\""},{"line_number":45,"context_line":"        resp, body \u003d self.client.do_request(path, \"POST\","},{"line_number":46,"context_line":"                expected_status\u003d[201, 409], body\u003dfields)"},{"line_number":47,"context_line":"        # NOTE: When performing some operations(ex. heal_all), if check"},{"line_number":48,"context_line":"        # whether the stack was deleted successfully, it only can check the"},{"line_number":49,"context_line":"        # status as \u0027DELETE_COMPLETE\u0027 when using the API that obtains the"},{"line_number":50,"context_line":"        # stack status directly. However, when the stack is in this state,"},{"line_number":51,"context_line":"        # the stack may not be completely deleted, resulting in a 409 error"},{"line_number":52,"context_line":"        # when the stack creation operation is performed. Therefore, when"},{"line_number":53,"context_line":"        # performing some operations(ex. heal_all), do a retry operation on"},{"line_number":54,"context_line":"        # create_stack."},{"line_number":55,"context_line":"        if resp.status_code \u003d\u003d 409:"},{"line_number":56,"context_line":"            while True:"},{"line_number":57,"context_line":"                status, _ \u003d self.get_status(fields[\u0027stack_name\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"                if status is None:"},{"line_number":60,"context_line":"                    break"},{"line_number":61,"context_line":"            resp, body \u003d self.client.do_request(path, \"POST\","},{"line_number":62,"context_line":"                    expected_status\u003d[201, 409], body\u003dfields)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        if wait:"},{"line_number":65,"context_line":"            self.wait_stack_create("},{"line_number":66,"context_line":"                f\u0027{fields[\"stack_name\"]}/{body[\"stack\"][\"id\"]}\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"df25c114_05d89f86","line":63,"range":{"start_line":46,"start_character":0,"end_line":63,"end_character":0},"updated":"2022-09-09 02:08:31.000000000","message":"I understand that this is a fix that improves performance for CHECK_INTERVAL by starting \"create_stack\" after confirming DELETE_COMPLETE with \"wait_stack_delete\".\nHowever, the maximum possible reduction with this fix is the 5 seconds set in CHECK_INTERVAL, which I think is insignificant.\nIn addition, this fix will cause POST to be repeated in a busy-loop, so there is a concern that the load on the Heat side will increase.\nSo I thought this fix was unnecessary, what do you think?","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bbc7d4c85a220ad8314d291b53a2a6211f9e9e3a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def create_stack(self, fields, wait\u003dTrue):"},{"line_number":44,"context_line":"        path \u003d \"stacks\""},{"line_number":45,"context_line":"        resp, body \u003d self.client.do_request(path, \"POST\","},{"line_number":46,"context_line":"                expected_status\u003d[201, 409], body\u003dfields)"},{"line_number":47,"context_line":"        # NOTE: When performing some operations(ex. heal_all), if check"},{"line_number":48,"context_line":"        # whether the stack was deleted successfully, it only can check the"},{"line_number":49,"context_line":"        # status as \u0027DELETE_COMPLETE\u0027 when using the API that obtains the"},{"line_number":50,"context_line":"        # stack status directly. However, when the stack is in this state,"},{"line_number":51,"context_line":"        # the stack may not be completely deleted, resulting in a 409 error"},{"line_number":52,"context_line":"        # when the stack creation operation is performed. Therefore, when"},{"line_number":53,"context_line":"        # performing some operations(ex. heal_all), do a retry operation on"},{"line_number":54,"context_line":"        # create_stack."},{"line_number":55,"context_line":"        if resp.status_code \u003d\u003d 409:"},{"line_number":56,"context_line":"            while True:"},{"line_number":57,"context_line":"                status, _ \u003d self.get_status(fields[\u0027stack_name\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"                if status is None:"},{"line_number":60,"context_line":"                    break"},{"line_number":61,"context_line":"            resp, body \u003d self.client.do_request(path, \"POST\","},{"line_number":62,"context_line":"                    expected_status\u003d[201, 409], body\u003dfields)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        if wait:"},{"line_number":65,"context_line":"            self.wait_stack_create("},{"line_number":66,"context_line":"                f\u0027{fields[\"stack_name\"]}/{body[\"stack\"][\"id\"]}\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9dfd17_ebaff52b","line":63,"range":{"start_line":46,"start_character":0,"end_line":63,"end_character":0},"in_reply_to":"dd0c73da_9ce27742","updated":"2022-09-15 03:00:27.000000000","message":"Done","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    def create_stack(self, fields, wait\u003dTrue):"},{"line_number":44,"context_line":"        path \u003d \"stacks\""},{"line_number":45,"context_line":"        resp, body \u003d self.client.do_request(path, \"POST\","},{"line_number":46,"context_line":"                expected_status\u003d[201, 409], body\u003dfields)"},{"line_number":47,"context_line":"        # NOTE: When performing some operations(ex. heal_all), if check"},{"line_number":48,"context_line":"        # whether the stack was deleted successfully, it only can check the"},{"line_number":49,"context_line":"        # status as \u0027DELETE_COMPLETE\u0027 when using the API that obtains the"},{"line_number":50,"context_line":"        # stack status directly. However, when the stack is in this state,"},{"line_number":51,"context_line":"        # the stack may not be completely deleted, resulting in a 409 error"},{"line_number":52,"context_line":"        # when the stack creation operation is performed. Therefore, when"},{"line_number":53,"context_line":"        # performing some operations(ex. heal_all), do a retry operation on"},{"line_number":54,"context_line":"        # create_stack."},{"line_number":55,"context_line":"        if resp.status_code \u003d\u003d 409:"},{"line_number":56,"context_line":"            while True:"},{"line_number":57,"context_line":"                status, _ \u003d self.get_status(fields[\u0027stack_name\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"                if status is None:"},{"line_number":60,"context_line":"                    break"},{"line_number":61,"context_line":"            resp, body \u003d self.client.do_request(path, \"POST\","},{"line_number":62,"context_line":"                    expected_status\u003d[201, 409], body\u003dfields)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        if wait:"},{"line_number":65,"context_line":"            self.wait_stack_create("},{"line_number":66,"context_line":"                f\u0027{fields[\"stack_name\"]}/{body[\"stack\"][\"id\"]}\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"dd0c73da_9ce27742","line":63,"range":{"start_line":46,"start_character":0,"end_line":63,"end_character":0},"in_reply_to":"df25c114_05d89f86","updated":"2022-09-14 00:18:27.000000000","message":"I deleted this fix in PS12.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"ced3be59c78eab26cde22f568a88e132d7d80ff4","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    def get_stack_id(self, stack_name):"},{"line_number":98,"context_line":"        path \u003d f\"stacks/{stack_name}\""},{"line_number":99,"context_line":"        resp, body \u003d self.client.do_request(path, \"GET\","},{"line_number":100,"context_line":"                                            expected_status\u003d[200, 404])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if resp.status_code \u003d\u003d 404:"},{"line_number":103,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":10,"id":"f9f814e9_a768fa19","line":100,"updated":"2022-09-08 08:19:20.000000000","message":"According to the following Heat API reference,\nis \"expected_status \u003d [302, 404]\"?\n\nhttps://docs.openstack.org/api-ref/orchestration/v1/index.html?expanded\u003dfind-stack-detail#find-stack","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"cbf26e3c77664d0d58cfcd20ebb529d2907e6351","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    def get_stack_id(self, stack_name):"},{"line_number":98,"context_line":"        path \u003d f\"stacks/{stack_name}\""},{"line_number":99,"context_line":"        resp, body \u003d self.client.do_request(path, \"GET\","},{"line_number":100,"context_line":"                                            expected_status\u003d[200, 404])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if resp.status_code \u003d\u003d 404:"},{"line_number":103,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":10,"id":"60f2257e_d2f75961","line":100,"in_reply_to":"ab5f1a1a_56070301","updated":"2022-09-14 12:24:12.000000000","message":"Thank you for your answer. I understand.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    def get_stack_id(self, stack_name):"},{"line_number":98,"context_line":"        path \u003d f\"stacks/{stack_name}\""},{"line_number":99,"context_line":"        resp, body \u003d self.client.do_request(path, \"GET\","},{"line_number":100,"context_line":"                                            expected_status\u003d[200, 404])"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if resp.status_code \u003d\u003d 404:"},{"line_number":103,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":10,"id":"ab5f1a1a_56070301","line":100,"in_reply_to":"f9f814e9_a768fa19","updated":"2022-09-14 00:18:27.000000000","message":"Instead of being picked up by the tacker, the 302 will be picked up directly by Heat itself and redirected to the stack path, returning 200.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"cfb82100c950a9234138e3edc256d188f4524672","unresolved":true,"context_lines":[{"line_number":153,"context_line":"        # It is expected that it takes short time after \"DELETE_COMPLETE\"."},{"line_number":154,"context_line":"        # So timeout after \"DELETE_COMPLETE\" is not specified."},{"line_number":155,"context_line":"        self._wait_completion(stack_name, \"Stack delete\","},{"line_number":156,"context_line":"            [\u0027DELETE_COMPLETE\u0027], [\"DELETE_IN_PROGRESS\"], [\"DELETE_FAILED\"])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def get_resource_info(self, stack_id, resource_name):"},{"line_number":159,"context_line":"        path \u003d f\"stacks/{stack_id}/resources/{resource_name}\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5bb0af2f_a48372cd","line":156,"updated":"2022-09-09 02:08:31.000000000","message":"Similar to the comment about \"create_stack\", I think this fix is unnecessary.\nIf you think this fix is necessary, there is a bug in the current fix, so you need to add the following fix.\nThis is because, as described in the original comment of \"wait_stack_delete\", DELETE_COMPLETE transitions in a short time, so there may be cases where the transition ends during CHECK_INTERVAL.\n---\n[None, \u0027DELETE_COMPLETE\u0027], [\"DELETE_IN_PROGRESS\"], [\"DELETE_FAILED\"])","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bbc7d4c85a220ad8314d291b53a2a6211f9e9e3a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        # It is expected that it takes short time after \"DELETE_COMPLETE\"."},{"line_number":154,"context_line":"        # So timeout after \"DELETE_COMPLETE\" is not specified."},{"line_number":155,"context_line":"        self._wait_completion(stack_name, \"Stack delete\","},{"line_number":156,"context_line":"            [\u0027DELETE_COMPLETE\u0027], [\"DELETE_IN_PROGRESS\"], [\"DELETE_FAILED\"])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def get_resource_info(self, stack_id, resource_name):"},{"line_number":159,"context_line":"        path \u003d f\"stacks/{stack_id}/resources/{resource_name}\""}],"source_content_type":"text/x-python","patch_set":10,"id":"51f5e411_60fe6e44","line":156,"in_reply_to":"10f51b54_2303aa2d","updated":"2022-09-15 03:00:27.000000000","message":"Done","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":153,"context_line":"        # It is expected that it takes short time after \"DELETE_COMPLETE\"."},{"line_number":154,"context_line":"        # So timeout after \"DELETE_COMPLETE\" is not specified."},{"line_number":155,"context_line":"        self._wait_completion(stack_name, \"Stack delete\","},{"line_number":156,"context_line":"            [\u0027DELETE_COMPLETE\u0027], [\"DELETE_IN_PROGRESS\"], [\"DELETE_FAILED\"])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def get_resource_info(self, stack_id, resource_name):"},{"line_number":159,"context_line":"        path \u003d f\"stacks/{stack_id}/resources/{resource_name}\""}],"source_content_type":"text/x-python","patch_set":10,"id":"10f51b54_2303aa2d","line":156,"in_reply_to":"5bb0af2f_a48372cd","updated":"2022-09-14 00:18:27.000000000","message":"I deleted this fix in PS12.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"cfb82100c950a9234138e3edc256d188f4524672","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"def get_stack_name(inst, stack_id\u003dNone):"},{"line_number":218,"context_line":"    if inst.obj_attr_is_set(\u0027instantiatedVnfInfo\u0027) and not stack_id:"},{"line_number":219,"context_line":"        return f\"vnf-{inst.id}/{inst.instantiatedVnfInfo.metadata[\u0027stack_id\u0027]}\""},{"line_number":220,"context_line":"    if stack_id:"},{"line_number":221,"context_line":"        return f\"vnf-{inst.id}/{stack_id}\""},{"line_number":222,"context_line":"    return \"vnf-\" + inst.id"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"def get_resource_stack_id(heat_res):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a615cf6_1d6bd8b9","line":222,"range":{"start_line":218,"start_character":0,"end_line":222,"end_character":27},"updated":"2022-09-09 02:08:31.000000000","message":"I think the below code is better.\n---\n    stack_name \u003d f\"vnf-{inst.id}\"\n    if inst.obj_attr_is_set(\u0027instantiatedVnfInfo\u0027) and not stack_id:\n        return f\"{stack_name}/{inst.instantiatedVnfInfo.metadata[\u0027stack_id\u0027]}\"\n    if stack_id:\n        return f\"{stack_name}/{stack_id}\"\n    return stack_name","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"def get_stack_name(inst, stack_id\u003dNone):"},{"line_number":218,"context_line":"    if inst.obj_attr_is_set(\u0027instantiatedVnfInfo\u0027) and not stack_id:"},{"line_number":219,"context_line":"        return f\"vnf-{inst.id}/{inst.instantiatedVnfInfo.metadata[\u0027stack_id\u0027]}\""},{"line_number":220,"context_line":"    if stack_id:"},{"line_number":221,"context_line":"        return f\"vnf-{inst.id}/{stack_id}\""},{"line_number":222,"context_line":"    return \"vnf-\" + inst.id"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"def get_resource_stack_id(heat_res):"}],"source_content_type":"text/x-python","patch_set":10,"id":"beae89dc_b773b8ad","line":222,"range":{"start_line":218,"start_character":0,"end_line":222,"end_character":27},"in_reply_to":"1a615cf6_1d6bd8b9","updated":"2022-09-14 00:18:27.000000000","message":"I fixed these codes in PS12.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bbc7d4c85a220ad8314d291b53a2a6211f9e9e3a","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"def get_stack_name(inst, stack_id\u003dNone):"},{"line_number":218,"context_line":"    if inst.obj_attr_is_set(\u0027instantiatedVnfInfo\u0027) and not stack_id:"},{"line_number":219,"context_line":"        return f\"vnf-{inst.id}/{inst.instantiatedVnfInfo.metadata[\u0027stack_id\u0027]}\""},{"line_number":220,"context_line":"    if stack_id:"},{"line_number":221,"context_line":"        return f\"vnf-{inst.id}/{stack_id}\""},{"line_number":222,"context_line":"    return \"vnf-\" + inst.id"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"def get_resource_stack_id(heat_res):"}],"source_content_type":"text/x-python","patch_set":10,"id":"4f57760d_46f0e172","line":222,"range":{"start_line":218,"start_character":0,"end_line":222,"end_character":27},"in_reply_to":"beae89dc_b773b8ad","updated":"2022-09-15 03:00:27.000000000","message":"Done","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"}],"tacker/sol_refactored/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":true,"context_lines":[{"line_number":919,"context_line":"                    if image:"},{"line_number":920,"context_line":"                        metadata[f\u0027image-{vdu_name}\u0027] \u003d image"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"    def _make_instantiated_vnf_info(self, req, inst, grant_req, grant, vnfd,"},{"line_number":923,"context_line":"            heat_client, stack_id):"},{"line_number":924,"context_line":"        # get heat resources"},{"line_number":925,"context_line":"        stack_name \u003d heat_utils.get_stack_name(inst, stack_id)"},{"line_number":926,"context_line":"        heat_reses \u003d heat_client.get_resources(stack_name)"},{"line_number":927,"context_line":"        nfv_dict \u003d json.loads(heat_client.get_parameters(stack_name)[\u0027nfv\u0027])"},{"line_number":928,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"31f4c4a3_3b5ed195","line":925,"range":{"start_line":922,"start_character":0,"end_line":925,"end_character":62},"updated":"2022-09-06 08:13:36.000000000","message":"Could you fix it like below?\nIf you can fix it, you can omit the \"stack_id\" argument except for \"instantiate\".\n---\n    def _make_instantiated_vnf_info(self, req, inst, grant_req, grant, vnfd,\n            heat_client, stack_id\u003dNone):\n        # get heat resources\n        stack_id \u003d stack_id if stack_id else inst.instantiatedVnfInfo.metadata[\u0027stack_id\u0027]\n        stack_name \u003d heat_utils.get_stack_name(inst, stack_id)","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":919,"context_line":"                    if image:"},{"line_number":920,"context_line":"                        metadata[f\u0027image-{vdu_name}\u0027] \u003d image"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"    def _make_instantiated_vnf_info(self, req, inst, grant_req, grant, vnfd,"},{"line_number":923,"context_line":"            heat_client, stack_id):"},{"line_number":924,"context_line":"        # get heat resources"},{"line_number":925,"context_line":"        stack_name \u003d heat_utils.get_stack_name(inst, stack_id)"},{"line_number":926,"context_line":"        heat_reses \u003d heat_client.get_resources(stack_name)"},{"line_number":927,"context_line":"        nfv_dict \u003d json.loads(heat_client.get_parameters(stack_name)[\u0027nfv\u0027])"},{"line_number":928,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fe895bf7_015ae410","line":925,"range":{"start_line":922,"start_character":0,"end_line":925,"end_character":62},"in_reply_to":"31f4c4a3_3b5ed195","updated":"2022-09-14 00:18:27.000000000","message":"I fixed it in PS12.","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bbc7d4c85a220ad8314d291b53a2a6211f9e9e3a","unresolved":false,"context_lines":[{"line_number":919,"context_line":"                    if image:"},{"line_number":920,"context_line":"                        metadata[f\u0027image-{vdu_name}\u0027] \u003d image"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"    def _make_instantiated_vnf_info(self, req, inst, grant_req, grant, vnfd,"},{"line_number":923,"context_line":"            heat_client, stack_id):"},{"line_number":924,"context_line":"        # get heat resources"},{"line_number":925,"context_line":"        stack_name \u003d heat_utils.get_stack_name(inst, stack_id)"},{"line_number":926,"context_line":"        heat_reses \u003d heat_client.get_resources(stack_name)"},{"line_number":927,"context_line":"        nfv_dict \u003d json.loads(heat_client.get_parameters(stack_name)[\u0027nfv\u0027])"},{"line_number":928,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b40e5597_33125666","line":925,"range":{"start_line":922,"start_character":0,"end_line":925,"end_character":62},"in_reply_to":"fe895bf7_015ae410","updated":"2022-09-15 03:00:27.000000000","message":"Done","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"}],"tacker/sol_refactored/objects/v2/vnf_instance.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8c5085d632eddcd389fd66a6ad31d265d7137de4","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            \u0027VnfVirtualLinkResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":83,"context_line":"        \u0027virtualStorageResourceInfo\u0027: fields.ListOfObjectsField("},{"line_number":84,"context_line":"            \u0027VirtualStorageResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":86,"context_line":"        # NOTE: vnfcInfo exists in SOL002 only."},{"line_number":87,"context_line":"        \u0027vnfcInfo\u0027: fields.ListOfObjectsField(\u0027VnfcInfoV2\u0027, nullable\u003dTrue),"},{"line_number":88,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c5093f7_eacc963f","line":85,"updated":"2022-09-05 05:56:56.000000000","message":"Please note that it conflicts with the fix in the patch below.\n---\nhttps://review.opendev.org/c/openstack/tacker/+/855117/4..7/tacker/sol_refactored/objects/v2/vnf_instance.py#89","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            \u0027VnfVirtualLinkResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":83,"context_line":"        \u0027virtualStorageResourceInfo\u0027: fields.ListOfObjectsField("},{"line_number":84,"context_line":"            \u0027VirtualStorageResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":86,"context_line":"        # NOTE: vnfcInfo exists in SOL002 only."},{"line_number":87,"context_line":"        \u0027vnfcInfo\u0027: fields.ListOfObjectsField(\u0027VnfcInfoV2\u0027, nullable\u003dTrue),"},{"line_number":88,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"ed839381_59bb4984","line":85,"in_reply_to":"5c5093f7_eacc963f","updated":"2022-09-06 05:51:49.000000000","message":"I know this patch, there will be a conflict later here. Wait until the patch is merged into master before resolving conflicts.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027VnfVirtualLinkResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":83,"context_line":"        \u0027virtualStorageResourceInfo\u0027: fields.ListOfObjectsField("},{"line_number":84,"context_line":"            \u0027VirtualStorageResourceInfoV2\u0027, nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":86,"context_line":"        # NOTE: vnfcInfo exists in SOL002 only."},{"line_number":87,"context_line":"        \u0027vnfcInfo\u0027: fields.ListOfObjectsField(\u0027VnfcInfoV2\u0027, nullable\u003dTrue),"},{"line_number":88,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"a70b7322_1844de8c","line":85,"in_reply_to":"ed839381_59bb4984","updated":"2022-09-06 08:13:36.000000000","message":"Done","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"}],"tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"955f5a4d757281b3227b7037f3a14883956672a7","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                         \"no_filter\"))"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        # Instantiate vnf instance"},{"line_number":403,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances. \\"},{"line_number":404,"context_line":"            make_inst_request_body_include_num_dynamic("},{"line_number":405,"context_line":"                self.vim[\u0027tenant_id\u0027], self.ext_networks,"},{"line_number":406,"context_line":"                self.ext_mngd_networks, self.ext_link_ports, self.ext_subnets)"},{"line_number":407,"context_line":"        resp, _ \u003d self._instantiate_vnf_instance(vnf_instance_id, request_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a899dbf_70243ba4","line":404,"range":{"start_line":403,"start_character":8,"end_line":404,"end_character":55},"updated":"2022-09-06 06:33:37.000000000","message":"Could you please change to avoid using a backslash as a line break?","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"62e612aaf2361a6b18b19e3371a623f6f3f3bc99","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                         \"no_filter\"))"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        # Instantiate vnf instance"},{"line_number":403,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances. \\"},{"line_number":404,"context_line":"            make_inst_request_body_include_num_dynamic("},{"line_number":405,"context_line":"                self.vim[\u0027tenant_id\u0027], self.ext_networks,"},{"line_number":406,"context_line":"                self.ext_mngd_networks, self.ext_link_ports, self.ext_subnets)"},{"line_number":407,"context_line":"        resp, _ \u003d self._instantiate_vnf_instance(vnf_instance_id, request_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"d0913cd4_edecda3d","line":404,"range":{"start_line":403,"start_character":8,"end_line":404,"end_character":55},"in_reply_to":"30494a2e_628d291f","updated":"2022-09-15 01:47:00.000000000","message":"Ack","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":400,"context_line":"                         \"no_filter\"))"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        # Instantiate vnf instance"},{"line_number":403,"context_line":"        request_body \u003d fake_vnflcm.VnfInstances. \\"},{"line_number":404,"context_line":"            make_inst_request_body_include_num_dynamic("},{"line_number":405,"context_line":"                self.vim[\u0027tenant_id\u0027], self.ext_networks,"},{"line_number":406,"context_line":"                self.ext_mngd_networks, self.ext_link_ports, self.ext_subnets)"},{"line_number":407,"context_line":"        resp, _ \u003d self._instantiate_vnf_instance(vnf_instance_id, request_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"30494a2e_628d291f","line":404,"range":{"start_line":403,"start_character":8,"end_line":404,"end_character":55},"in_reply_to":"7a899dbf_70243ba4","updated":"2022-09-14 00:18:27.000000000","message":"I fixed it in PS12.","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"cfb82100c950a9234138e3edc256d188f4524672","unresolved":true,"context_lines":[{"line_number":443,"context_line":"        self.assert_delete_vnf(resp, vnf_instance_id, vnf_package_id)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        # Subscription delete"},{"line_number":446,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id)"},{"line_number":447,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        resp, _ \u003d self._show_subscription(sub_id)"},{"line_number":450,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id_1)"},{"line_number":453,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        resp, _ \u003d self._show_subscription(sub_id_1)"},{"line_number":456,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id_2)"},{"line_number":459,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        resp, _ \u003d self._show_subscription(sub_id_2)"},{"line_number":462,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id_3)"},{"line_number":465,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        resp, _ \u003d self._show_subscription(sub_id_3)"},{"line_number":468,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def test_stack_update_in_scaling(self):"},{"line_number":471,"context_line":"        \"\"\"Test basic life cycle operations with sample VNFD."}],"source_content_type":"text/x-python","patch_set":10,"id":"4c8d971a_5f6d547d","line":468,"range":{"start_line":446,"start_character":0,"end_line":468,"end_character":47},"updated":"2022-09-09 02:08:31.000000000","message":"Since there are same logic, could you make it a function as below?\n---\ndef _assert_subscription_deletion(self, sub_id):\n         resp, _ \u003d self._delete_subscription(sub_id)\n         self.assertEqual(204, resp.status_code)\n\n         resp, _ \u003d self._show_subscription(sub_id)\n         self.assertEqual(404, resp.status_code)","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":443,"context_line":"        self.assert_delete_vnf(resp, vnf_instance_id, vnf_package_id)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        # Subscription delete"},{"line_number":446,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id)"},{"line_number":447,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        resp, _ \u003d self._show_subscription(sub_id)"},{"line_number":450,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id_1)"},{"line_number":453,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        resp, _ \u003d self._show_subscription(sub_id_1)"},{"line_number":456,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id_2)"},{"line_number":459,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        resp, _ \u003d self._show_subscription(sub_id_2)"},{"line_number":462,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id_3)"},{"line_number":465,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        resp, _ \u003d self._show_subscription(sub_id_3)"},{"line_number":468,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def test_stack_update_in_scaling(self):"},{"line_number":471,"context_line":"        \"\"\"Test basic life cycle operations with sample VNFD."}],"source_content_type":"text/x-python","patch_set":10,"id":"70324631_f66bab24","line":468,"range":{"start_line":446,"start_character":0,"end_line":468,"end_character":47},"in_reply_to":"4c8d971a_5f6d547d","updated":"2022-09-14 00:18:27.000000000","message":"I added a common function in PS12.","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bbc7d4c85a220ad8314d291b53a2a6211f9e9e3a","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        self.assert_delete_vnf(resp, vnf_instance_id, vnf_package_id)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        # Subscription delete"},{"line_number":446,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id)"},{"line_number":447,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        resp, _ \u003d self._show_subscription(sub_id)"},{"line_number":450,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id_1)"},{"line_number":453,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        resp, _ \u003d self._show_subscription(sub_id_1)"},{"line_number":456,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id_2)"},{"line_number":459,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        resp, _ \u003d self._show_subscription(sub_id_2)"},{"line_number":462,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        resp, _ \u003d self._delete_subscription(sub_id_3)"},{"line_number":465,"context_line":"        self.assertEqual(204, resp.status_code)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"        resp, _ \u003d self._show_subscription(sub_id_3)"},{"line_number":468,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def test_stack_update_in_scaling(self):"},{"line_number":471,"context_line":"        \"\"\"Test basic life cycle operations with sample VNFD."}],"source_content_type":"text/x-python","patch_set":10,"id":"d8b31734_0a37c6e8","line":468,"range":{"start_line":446,"start_character":0,"end_line":468,"end_character":47},"in_reply_to":"70324631_f66bab24","updated":"2022-09-15 03:00:27.000000000","message":"Done","commit_id":"b3340973589da2ef1876cca53d037dc5a8da51b2"}],"tacker/tosca/utils.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8c5085d632eddcd389fd66a6ad31d265d7137de4","unresolved":true,"context_lines":[{"line_number":725,"context_line":"                                  heat_dict)"},{"line_number":726,"context_line":"    else:"},{"line_number":727,"context_line":"        LOG.debug(\u0027Because instLevelId is not defined and \u0027"},{"line_number":728,"context_line":"                 \u0027there is no default level in TOSCA, \u0027"},{"line_number":729,"context_line":"                 \u0027the conversion of desired_capacity is skipped.\u0027)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"@log.log"}],"source_content_type":"text/x-python","patch_set":3,"id":"f323e61a_6cf18634","line":729,"range":{"start_line":728,"start_character":17,"end_line":729,"end_character":66},"updated":"2022-09-05 05:56:56.000000000","message":"You need to add some spaces.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":false,"context_lines":[{"line_number":725,"context_line":"                                  heat_dict)"},{"line_number":726,"context_line":"    else:"},{"line_number":727,"context_line":"        LOG.debug(\u0027Because instLevelId is not defined and \u0027"},{"line_number":728,"context_line":"                 \u0027there is no default level in TOSCA, \u0027"},{"line_number":729,"context_line":"                 \u0027the conversion of desired_capacity is skipped.\u0027)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"@log.log"}],"source_content_type":"text/x-python","patch_set":3,"id":"a2d4b6b1_e53f22cb","line":729,"range":{"start_line":728,"start_character":17,"end_line":729,"end_character":66},"in_reply_to":"a5ce4407_08ec694b","updated":"2022-09-06 08:13:36.000000000","message":"Done","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":true,"context_lines":[{"line_number":725,"context_line":"                                  heat_dict)"},{"line_number":726,"context_line":"    else:"},{"line_number":727,"context_line":"        LOG.debug(\u0027Because instLevelId is not defined and \u0027"},{"line_number":728,"context_line":"                 \u0027there is no default level in TOSCA, \u0027"},{"line_number":729,"context_line":"                 \u0027the conversion of desired_capacity is skipped.\u0027)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"@log.log"}],"source_content_type":"text/x-python","patch_set":3,"id":"a5ce4407_08ec694b","line":729,"range":{"start_line":728,"start_character":17,"end_line":729,"end_character":66},"in_reply_to":"f323e61a_6cf18634","updated":"2022-09-06 05:51:49.000000000","message":"ditto","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"}],"tacker/vnfm/infra_drivers/noop.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"955f5a4d757281b3227b7037f3a14883956672a7","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    @log.log"},{"line_number":56,"context_line":"    def update(self, plugin, context, vnf_id, vnf_dict, vnf):"},{"line_number":57,"context_line":"        if vnf_id not in self._instances:"},{"line_number":58,"context_line":"            LOG.error(\u0027not found\u0027)"},{"line_number":59,"context_line":"            raise ValueError(\u0027No instance %s\u0027 % vnf_id)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @log.log"}],"source_content_type":"text/x-python","patch_set":4,"id":"d40161d1_2e7f636a","line":58,"updated":"2022-09-06 06:33:37.000000000","message":"nit:Could you change first letter to upper case.","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"62e612aaf2361a6b18b19e3371a623f6f3f3bc99","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    @log.log"},{"line_number":56,"context_line":"    def update(self, plugin, context, vnf_id, vnf_dict, vnf):"},{"line_number":57,"context_line":"        if vnf_id not in self._instances:"},{"line_number":58,"context_line":"            LOG.error(\u0027not found\u0027)"},{"line_number":59,"context_line":"            raise ValueError(\u0027No instance %s\u0027 % vnf_id)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @log.log"}],"source_content_type":"text/x-python","patch_set":4,"id":"930ca315_41e91786","line":58,"in_reply_to":"886d7023_a2e73a2c","updated":"2022-09-15 01:47:00.000000000","message":"Ack","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"973739913c77893caedbac9e3b7c6870994d8205","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    @log.log"},{"line_number":56,"context_line":"    def update(self, plugin, context, vnf_id, vnf_dict, vnf):"},{"line_number":57,"context_line":"        if vnf_id not in self._instances:"},{"line_number":58,"context_line":"            LOG.error(\u0027not found\u0027)"},{"line_number":59,"context_line":"            raise ValueError(\u0027No instance %s\u0027 % vnf_id)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @log.log"}],"source_content_type":"text/x-python","patch_set":4,"id":"886d7023_a2e73a2c","line":58,"in_reply_to":"d40161d1_2e7f636a","updated":"2022-09-14 00:18:27.000000000","message":"I fixed it in PS12.","commit_id":"78299cacf27f9324e02957dbd7b144cf1dce6214"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8c5085d632eddcd389fd66a6ad31d265d7137de4","unresolved":true,"context_lines":[{"line_number":1121,"context_line":"                 \"id\": vnf_instance.id})"},{"line_number":1122,"context_line":"        except Exception:"},{"line_number":1123,"context_line":"            LOG.debug(\"Failed to delete resource \u0027%(name)s\u0027 of type\""},{"line_number":1124,"context_line":"                    \" %(type)s\u0027 for vnf %(id)s\","},{"line_number":1125,"context_line":"                    {\"type\": vnf_resource.resource_type,"},{"line_number":1126,"context_line":"                     \"name\": vnf_resource.resource_name,"},{"line_number":1127,"context_line":"                     \"id\": vnf_instance.id})"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":"    def instantiate_vnf(self, context, vnf_instance, vnfd_dict,"},{"line_number":1130,"context_line":"                        vim_connection_info, instantiate_vnf_req,"}],"source_content_type":"text/x-python","patch_set":3,"id":"983d77a5_1d08d2ba","line":1127,"range":{"start_line":1124,"start_character":19,"end_line":1127,"end_character":44},"updated":"2022-09-05 05:56:56.000000000","message":"You need to add some spaces.","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7da022569a170ad44641e013cce6470c2099bc2d","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"                 \"id\": vnf_instance.id})"},{"line_number":1122,"context_line":"        except Exception:"},{"line_number":1123,"context_line":"            LOG.debug(\"Failed to delete resource \u0027%(name)s\u0027 of type\""},{"line_number":1124,"context_line":"                    \" %(type)s\u0027 for vnf %(id)s\","},{"line_number":1125,"context_line":"                    {\"type\": vnf_resource.resource_type,"},{"line_number":1126,"context_line":"                     \"name\": vnf_resource.resource_name,"},{"line_number":1127,"context_line":"                     \"id\": vnf_instance.id})"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":"    def instantiate_vnf(self, context, vnf_instance, vnfd_dict,"},{"line_number":1130,"context_line":"                        vim_connection_info, instantiate_vnf_req,"}],"source_content_type":"text/x-python","patch_set":3,"id":"81fc3421_2fd5769e","line":1127,"range":{"start_line":1124,"start_character":19,"end_line":1127,"end_character":44},"in_reply_to":"79b12bfe_9f043186","updated":"2022-09-06 08:13:36.000000000","message":"Done","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"99f12eb346b5c195fba58277ce88aaeb92cb891b","unresolved":true,"context_lines":[{"line_number":1121,"context_line":"                 \"id\": vnf_instance.id})"},{"line_number":1122,"context_line":"        except Exception:"},{"line_number":1123,"context_line":"            LOG.debug(\"Failed to delete resource \u0027%(name)s\u0027 of type\""},{"line_number":1124,"context_line":"                    \" %(type)s\u0027 for vnf %(id)s\","},{"line_number":1125,"context_line":"                    {\"type\": vnf_resource.resource_type,"},{"line_number":1126,"context_line":"                     \"name\": vnf_resource.resource_name,"},{"line_number":1127,"context_line":"                     \"id\": vnf_instance.id})"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":"    def instantiate_vnf(self, context, vnf_instance, vnfd_dict,"},{"line_number":1130,"context_line":"                        vim_connection_info, instantiate_vnf_req,"}],"source_content_type":"text/x-python","patch_set":3,"id":"79b12bfe_9f043186","line":1127,"range":{"start_line":1124,"start_character":19,"end_line":1127,"end_character":44},"in_reply_to":"983d77a5_1d08d2ba","updated":"2022-09-06 05:51:49.000000000","message":"ditto","commit_id":"92d19416de8ecd6e4ccb376ff7273b094b23e1b7"}]}
