)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f4f906cc_6de89446","updated":"2022-09-08 02:46:03.000000000","message":"Thanks for your patch.\nI know it is in WIP state, but I have a comment after a prior review. Please kindly find my comments.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2d8f4a08_9f53a2b2","updated":"2022-09-08 05:32:47.000000000","message":"Thank you for the review.\n\nI submitted ps7 before I saw this review. Some of comments is fixed in ps7.","commit_id":"59d58ab5e0d6fc0e0ae44b05abd7ae0fce14878e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"724612e709dfa228493ea436dff01e3ccca40440","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5150218c_d37f7d36","updated":"2022-09-08 06:48:38.000000000","message":"Thank you for the review.","commit_id":"d4fee54da66d1845c9c9d9d8a3e05ecda1f22df3"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4ab1d6cbfbda43e89782d7f53e286c758fa92ec5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6c572c5b_13a1ec86","updated":"2022-09-12 23:14:40.000000000","message":"Thank you for the review.","commit_id":"bb0a694981d7ea4b157c05b3b154aaf4d01aecbd"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d6c3c87e97570ea715dfd696f59859f44d426b95","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e5a076d4_7a69b565","updated":"2022-09-14 01:25:43.000000000","message":"Thank you for the review.","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"758fcfe72fad86da75dbe7c1170e16cc4b8a578c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8b67b0d4_1db0d1fc","updated":"2022-09-13 06:57:41.000000000","message":"Thanks for your rework! LGTM.","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"73ff4cbf341a73fb6622bc514018903f71b4504c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"c728198a_e6faa8b0","updated":"2022-09-14 08:28:22.000000000","message":"Thank you for the review.","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"6b101839_1ce6c340","updated":"2022-09-15 00:46:00.000000000","message":"Thank you for the review.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"}],"releasenotes/notes/support-cnf-v2-operations-using-helm-chart-c540f96720e7269f.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Support LCM operations using Helm chart"},{"line_number":5,"context_line":"    for v2 LCM API. This feature enables"},{"line_number":6,"context_line":"    v2 LCM operations with Helm chart,"},{"line_number":7,"context_line":"    instantiatiationLevel parameter to"},{"line_number":8,"context_line":"    determine the initial number of Pods,"},{"line_number":9,"context_line":"    and vimConnectionInfo.extra field."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2c274e08_da19444a","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":20},"updated":"2022-09-08 02:46:03.000000000","message":"typo: instantiation","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Support LCM operations using Helm chart"},{"line_number":5,"context_line":"    for v2 LCM API. This feature enables"},{"line_number":6,"context_line":"    v2 LCM operations with Helm chart,"},{"line_number":7,"context_line":"    instantiatiationLevel parameter to"},{"line_number":8,"context_line":"    determine the initial number of Pods,"},{"line_number":9,"context_line":"    and vimConnectionInfo.extra field."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"848092d2_ab3ded9a","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":20},"in_reply_to":"2c274e08_da19444a","updated":"2022-09-08 05:32:47.000000000","message":"I will fix.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Support LCM operations using Helm chart"},{"line_number":5,"context_line":"    for v2 LCM API. This feature enables"},{"line_number":6,"context_line":"    v2 LCM operations with Helm chart,"},{"line_number":7,"context_line":"    instantiatiationLevel parameter to"},{"line_number":8,"context_line":"    determine the initial number of Pods,"},{"line_number":9,"context_line":"    and vimConnectionInfo.extra field."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2210e21f_69e0bba7","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":20},"in_reply_to":"848092d2_ab3ded9a","updated":"2022-09-08 06:27:28.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"}],"tacker/sol_refactored/common/exceptions.py":[{"author":{"_account_id":31668},"change_message_id":"ea523e0bc5e8477bfbce0f5d66d5696f7ba30f4d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SolException(Exception):"},{"line_number":18,"context_line":"    \"\"\"Exception for SOL ProblemDetails"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"8e9aef6f_49033f7e","line":16,"updated":"2022-09-14 09:07:05.000000000","message":"Please import i18n to activate `_()`.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"ea523e0bc5e8477bfbce0f5d66d5696f7ba30f4d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SolException(Exception):"},{"line_number":18,"context_line":"    \"\"\"Exception for SOL ProblemDetails"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"c3ed249c_fcc5301c","line":16,"updated":"2022-09-14 09:07:05.000000000","message":"Please import i18n to activate `_()`.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SolException(Exception):"},{"line_number":18,"context_line":"    \"\"\"Exception for SOL ProblemDetails"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"dcef102d_f17e67e5","line":16,"in_reply_to":"8e9aef6f_49033f7e","updated":"2022-09-15 00:46:00.000000000","message":"I see. I will add it.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SolException(Exception):"},{"line_number":18,"context_line":"    \"\"\"Exception for SOL ProblemDetails"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"7a913e4f_4f8f53c6","line":16,"in_reply_to":"c3ed249c_fcc5301c","updated":"2022-09-14 09:54:25.000000000","message":"duplicate comment","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SolException(Exception):"},{"line_number":18,"context_line":"    \"\"\"Exception for SOL ProblemDetails"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"06296dde_a4cc29ca","line":16,"in_reply_to":"dcef102d_f17e67e5","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"}],"tacker/sol_refactored/conductor/vnflcm_driver_v2.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bf074e7fdd17b1c7974711342aed95973a755218","unresolved":true,"context_lines":[{"line_number":405,"context_line":"                    raise sol_ex.SolValidationError("},{"line_number":406,"context_line":"                        detail\u003d\"\u0027lcm-kubernetes-def-files\u0027 must be specified\")"},{"line_number":407,"context_line":"            elif vim_info.vimType \u003d\u003d \"ETSINFV.HELM.V_3\":"},{"line_number":408,"context_line":"                if (\u0027endpoint\u0027 not in vim_info.interfaceInfo or"},{"line_number":409,"context_line":"                        \u0027ssl_ca_cert\u0027 not in vim_info.interfaceInfo or"},{"line_number":410,"context_line":"                        \u0027bearer_token\u0027 not in vim_info.accessInfo):"},{"line_number":411,"context_line":"                    detail \u003d \"Required attribute missing in vimConnectionInfo\""}],"source_content_type":"text/x-python","patch_set":14,"id":"de4b0def_c71edc8d","line":408,"range":{"start_line":408,"start_character":1,"end_line":408,"end_character":63},"updated":"2022-09-12 09:22:18.000000000","message":"Isn\u0027t interfaceInfo.endpoint mandatory even if vimType is \"kubernetes\", same with \"ETSINFV.HELM.V_3\"?","commit_id":"bb0a694981d7ea4b157c05b3b154aaf4d01aecbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a85849913731a3b4f7c17316b732e0980273ff6c","unresolved":false,"context_lines":[{"line_number":405,"context_line":"                    raise sol_ex.SolValidationError("},{"line_number":406,"context_line":"                        detail\u003d\"\u0027lcm-kubernetes-def-files\u0027 must be specified\")"},{"line_number":407,"context_line":"            elif vim_info.vimType \u003d\u003d \"ETSINFV.HELM.V_3\":"},{"line_number":408,"context_line":"                if (\u0027endpoint\u0027 not in vim_info.interfaceInfo or"},{"line_number":409,"context_line":"                        \u0027ssl_ca_cert\u0027 not in vim_info.interfaceInfo or"},{"line_number":410,"context_line":"                        \u0027bearer_token\u0027 not in vim_info.accessInfo):"},{"line_number":411,"context_line":"                    detail \u003d \"Required attribute missing in vimConnectionInfo\""}],"source_content_type":"text/x-python","patch_set":14,"id":"14439218_ac0ca71f","line":408,"range":{"start_line":408,"start_character":1,"end_line":408,"end_character":63},"in_reply_to":"22e45f54_27de1a23","updated":"2022-09-13 09:30:21.000000000","message":"Done","commit_id":"bb0a694981d7ea4b157c05b3b154aaf4d01aecbd"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4ab1d6cbfbda43e89782d7f53e286c758fa92ec5","unresolved":true,"context_lines":[{"line_number":405,"context_line":"                    raise sol_ex.SolValidationError("},{"line_number":406,"context_line":"                        detail\u003d\"\u0027lcm-kubernetes-def-files\u0027 must be specified\")"},{"line_number":407,"context_line":"            elif vim_info.vimType \u003d\u003d \"ETSINFV.HELM.V_3\":"},{"line_number":408,"context_line":"                if (\u0027endpoint\u0027 not in vim_info.interfaceInfo or"},{"line_number":409,"context_line":"                        \u0027ssl_ca_cert\u0027 not in vim_info.interfaceInfo or"},{"line_number":410,"context_line":"                        \u0027bearer_token\u0027 not in vim_info.accessInfo):"},{"line_number":411,"context_line":"                    detail \u003d \"Required attribute missing in vimConnectionInfo\""}],"source_content_type":"text/x-python","patch_set":14,"id":"22e45f54_27de1a23","line":408,"range":{"start_line":408,"start_character":1,"end_line":408,"end_character":63},"in_reply_to":"de4b0def_c71edc8d","updated":"2022-09-12 23:14:40.000000000","message":"I see. I will add a check.","commit_id":"bb0a694981d7ea4b157c05b3b154aaf4d01aecbd"}],"tacker/sol_refactored/infra_drivers/kubernetes/helm.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":24,"context_line":"from tacker.sol_refactored.infra_drivers.kubernetes import kubernetes_resource"},{"line_number":25,"context_line":"from tacker.sol_refactored.infra_drivers.kubernetes import kubernetes_utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_NAMESPACE_KINDS \u003d ["},{"line_number":28,"context_line":"    \"Pod\","},{"line_number":29,"context_line":"    \"Binding\","},{"line_number":30,"context_line":"    \"ConfigMap\","}],"source_content_type":"text/x-python","patch_set":6,"id":"4e6a1a75_97b0e17b","line":27,"range":{"start_line":27,"start_character":28,"end_line":27,"end_character":29},"updated":"2022-09-08 02:46:03.000000000","message":"Could you change type to `set` instead of `list`?","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c9249a50181978219104a6413fe7083fb1483e0a","unresolved":true,"context_lines":[{"line_number":24,"context_line":"from tacker.sol_refactored.infra_drivers.kubernetes import kubernetes_resource"},{"line_number":25,"context_line":"from tacker.sol_refactored.infra_drivers.kubernetes import kubernetes_utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_NAMESPACE_KINDS \u003d ["},{"line_number":28,"context_line":"    \"Pod\","},{"line_number":29,"context_line":"    \"Binding\","},{"line_number":30,"context_line":"    \"ConfigMap\","}],"source_content_type":"text/x-python","patch_set":6,"id":"fc39d98f_71f61792","line":27,"range":{"start_line":27,"start_character":28,"end_line":27,"end_character":29},"in_reply_to":"0dc501b7_392b6ccf","updated":"2022-09-08 05:54:34.000000000","message":"\u003e and kubernetes_utils.SUPPORTED_NAMESPACE_KINDS is changed to set from list. (ps7)\nit is not correct. I will fix.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":24,"context_line":"from tacker.sol_refactored.infra_drivers.kubernetes import kubernetes_resource"},{"line_number":25,"context_line":"from tacker.sol_refactored.infra_drivers.kubernetes import kubernetes_utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_NAMESPACE_KINDS \u003d ["},{"line_number":28,"context_line":"    \"Pod\","},{"line_number":29,"context_line":"    \"Binding\","},{"line_number":30,"context_line":"    \"ConfigMap\","}],"source_content_type":"text/x-python","patch_set":6,"id":"0dc501b7_392b6ccf","line":27,"range":{"start_line":27,"start_character":28,"end_line":27,"end_character":29},"in_reply_to":"4e6a1a75_97b0e17b","updated":"2022-09-08 05:32:47.000000000","message":"changed to use kubernetes_utils.SUPPORTED_NAMESPACE_KINDS. and kubernetes_utils.SUPPORTED_NAMESPACE_KINDS is changed to set from list. (ps7)","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"758fcfe72fad86da75dbe7c1170e16cc4b8a578c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from tacker.sol_refactored.infra_drivers.kubernetes import kubernetes_resource"},{"line_number":25,"context_line":"from tacker.sol_refactored.infra_drivers.kubernetes import kubernetes_utils"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"SUPPORTED_NAMESPACE_KINDS \u003d ["},{"line_number":28,"context_line":"    \"Pod\","},{"line_number":29,"context_line":"    \"Binding\","},{"line_number":30,"context_line":"    \"ConfigMap\","}],"source_content_type":"text/x-python","patch_set":6,"id":"862c7efb_5fcf5e20","line":27,"range":{"start_line":27,"start_character":28,"end_line":27,"end_character":29},"in_reply_to":"fc39d98f_71f61792","updated":"2022-09-13 06:57:41.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        namespace \u003d req.additionalParams.get(\u0027namespace\u0027, \u0027default\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Check helm install parameter"},{"line_number":74,"context_line":"        helm_chart_path \u003d req.additionalParams.get(\u0027helm_chart_path\u0027)"},{"line_number":75,"context_line":"        install_chart_name \u003d os.path.join(vnfd.csar_dir, helm_chart_path)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        release_name \u003d self._get_release_name(inst, helm_chart_path)"}],"source_content_type":"text/x-python","patch_set":6,"id":"db2e3384_9fdcca01","line":74,"range":{"start_line":74,"start_character":26,"end_line":74,"end_character":69},"updated":"2022-09-08 02:46:03.000000000","message":"Is it correct to understand that the method to register and install external repository from V1 has been deleted?","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        namespace \u003d req.additionalParams.get(\u0027namespace\u0027, \u0027default\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Check helm install parameter"},{"line_number":74,"context_line":"        helm_chart_path \u003d req.additionalParams.get(\u0027helm_chart_path\u0027)"},{"line_number":75,"context_line":"        install_chart_name \u003d os.path.join(vnfd.csar_dir, helm_chart_path)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        release_name \u003d self._get_release_name(inst, helm_chart_path)"}],"source_content_type":"text/x-python","patch_set":6,"id":"2dd7a8e8_3d605ac7","line":74,"range":{"start_line":74,"start_character":26,"end_line":74,"end_character":69},"in_reply_to":"01be8980_b7a4d7d9","updated":"2022-09-08 06:27:28.000000000","message":"I understand. Thank you.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        namespace \u003d req.additionalParams.get(\u0027namespace\u0027, \u0027default\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        # Check helm install parameter"},{"line_number":74,"context_line":"        helm_chart_path \u003d req.additionalParams.get(\u0027helm_chart_path\u0027)"},{"line_number":75,"context_line":"        install_chart_name \u003d os.path.join(vnfd.csar_dir, helm_chart_path)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        release_name \u003d self._get_release_name(inst, helm_chart_path)"}],"source_content_type":"text/x-python","patch_set":6,"id":"01be8980_b7a4d7d9","line":74,"range":{"start_line":74,"start_character":26,"end_line":74,"end_character":69},"in_reply_to":"db2e3384_9fdcca01","updated":"2022-09-08 05:32:47.000000000","message":"yes, only support local chart. chart must be in vnf package.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":97,"context_line":"            revision \u003d helm_client.install(release_name, install_chart_name,"},{"line_number":98,"context_line":"                                           namespace, parameters)"},{"line_number":99,"context_line":"        else:"},{"line_number":100,"context_line":"            # helm upgrade"},{"line_number":101,"context_line":"            revision \u003d helm_client.upgrade(release_name, install_chart_name,"},{"line_number":102,"context_line":"                                           namespace, parameters)"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"19efd717_d97880fc","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":26},"updated":"2022-09-08 02:46:03.000000000","message":"I think this case is the route for instantiation retry, right?\nI think it would be good to have a comment for easy understanding.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":97,"context_line":"            revision \u003d helm_client.install(release_name, install_chart_name,"},{"line_number":98,"context_line":"                                           namespace, parameters)"},{"line_number":99,"context_line":"        else:"},{"line_number":100,"context_line":"            # helm upgrade"},{"line_number":101,"context_line":"            revision \u003d helm_client.upgrade(release_name, install_chart_name,"},{"line_number":102,"context_line":"                                           namespace, parameters)"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"f28b88a3_f99a1e30","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":26},"in_reply_to":"19efd717_d97880fc","updated":"2022-09-08 05:32:47.000000000","message":"right. I will add a comment.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            revision \u003d helm_client.install(release_name, install_chart_name,"},{"line_number":98,"context_line":"                                           namespace, parameters)"},{"line_number":99,"context_line":"        else:"},{"line_number":100,"context_line":"            # helm upgrade"},{"line_number":101,"context_line":"            revision \u003d helm_client.upgrade(release_name, install_chart_name,"},{"line_number":102,"context_line":"                                           namespace, parameters)"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"0a9ba4e5_f3c6241d","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":26},"in_reply_to":"f28b88a3_f99a1e30","updated":"2022-09-08 06:27:28.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        helm_chart_path \u003d req.additionalParams.get(\u0027helm_chart_path\u0027)"},{"line_number":138,"context_line":"        release_name \u003d self._get_release_name(inst, helm_chart_path)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self._delete_resource(release_name, namespace,"},{"line_number":141,"context_line":"                              k8s_api_client, helm_client)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def terminate(self, req, inst, grant_req, grant, vnfd):"}],"source_content_type":"text/x-python","patch_set":6,"id":"a3c99337_96463922","line":140,"range":{"start_line":140,"start_character":13,"end_line":140,"end_character":29},"updated":"2022-09-08 02:46:03.000000000","message":"Just a confirmation,\nWhen instantiate, release was upgraded if it already existed (in L.101).\nIs there no problem with the uniform uninstall in rollback?\n\nAs I commented above, if upgrade works when instantiation retry, I think there is no problem.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":137,"context_line":"        helm_chart_path \u003d req.additionalParams.get(\u0027helm_chart_path\u0027)"},{"line_number":138,"context_line":"        release_name \u003d self._get_release_name(inst, helm_chart_path)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self._delete_resource(release_name, namespace,"},{"line_number":141,"context_line":"                              k8s_api_client, helm_client)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def terminate(self, req, inst, grant_req, grant, vnfd):"}],"source_content_type":"text/x-python","patch_set":6,"id":"f79511e7_6a8ff223","line":140,"range":{"start_line":140,"start_character":13,"end_line":140,"end_character":29},"in_reply_to":"a3c99337_96463922","updated":"2022-09-08 05:32:47.000000000","message":"uninstall is correct because rollback of instantiate must move back before instantiate (NOT_INSTANTIATE) and no resources is left.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        helm_chart_path \u003d req.additionalParams.get(\u0027helm_chart_path\u0027)"},{"line_number":138,"context_line":"        release_name \u003d self._get_release_name(inst, helm_chart_path)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        self._delete_resource(release_name, namespace,"},{"line_number":141,"context_line":"                              k8s_api_client, helm_client)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def terminate(self, req, inst, grant_req, grant, vnfd):"}],"source_content_type":"text/x-python","patch_set":6,"id":"37be1858_f01f54ec","line":140,"range":{"start_line":140,"start_character":13,"end_line":140,"end_character":29},"in_reply_to":"f79511e7_6a8ff223","updated":"2022-09-08 06:27:28.000000000","message":"Thanks for your answer, I understand.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":350,"context_line":"            k8s_api_client, helm_client):"},{"line_number":351,"context_line":"        if req.additionalParams[\u0027upgrade_type\u0027] \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":352,"context_line":"            self._change_vnfpkg_rollback_rolling_update("},{"line_number":353,"context_line":"                req, inst, grant_req, grant, vnfd)"},{"line_number":354,"context_line":"        else:"},{"line_number":355,"context_line":"            # not reach here"},{"line_number":356,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"a25237f6_dc4c4d04","line":353,"range":{"start_line":353,"start_character":49,"end_line":353,"end_character":50},"updated":"2022-09-08 02:46:03.000000000","message":"Don\u0027t you need k8s_api_client and helm_client here?","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":350,"context_line":"            k8s_api_client, helm_client):"},{"line_number":351,"context_line":"        if req.additionalParams[\u0027upgrade_type\u0027] \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":352,"context_line":"            self._change_vnfpkg_rollback_rolling_update("},{"line_number":353,"context_line":"                req, inst, grant_req, grant, vnfd)"},{"line_number":354,"context_line":"        else:"},{"line_number":355,"context_line":"            # not reach here"},{"line_number":356,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"f530df59_bb629e45","line":353,"range":{"start_line":353,"start_character":49,"end_line":353,"end_character":50},"in_reply_to":"a25237f6_dc4c4d04","updated":"2022-09-08 05:32:47.000000000","message":"yes. fixed in ps7.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            k8s_api_client, helm_client):"},{"line_number":351,"context_line":"        if req.additionalParams[\u0027upgrade_type\u0027] \u003d\u003d \u0027RollingUpdate\u0027:"},{"line_number":352,"context_line":"            self._change_vnfpkg_rollback_rolling_update("},{"line_number":353,"context_line":"                req, inst, grant_req, grant, vnfd)"},{"line_number":354,"context_line":"        else:"},{"line_number":355,"context_line":"            # not reach here"},{"line_number":356,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":6,"id":"42837ad4_ff3fad66","line":353,"range":{"start_line":353,"start_character":49,"end_line":353,"end_character":50},"in_reply_to":"f530df59_bb629e45","updated":"2022-09-08 06:27:28.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        k8s_reses \u003d []"},{"line_number":395,"context_line":"        for k8s_res in k8s_resources:"},{"line_number":396,"context_line":"            kind \u003d k8s_res.get(\u0027kind\u0027)"},{"line_number":397,"context_line":"            cls \u003d getattr(kubernetes_resource, kind)"},{"line_number":398,"context_line":"            k8s_reses.append(cls(k8s_api_client, k8s_res))"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return k8s_reses"}],"source_content_type":"text/x-python","patch_set":6,"id":"8e153494_1d5cfc02","line":397,"range":{"start_line":397,"start_character":12,"end_line":397,"end_character":52},"updated":"2022-09-08 02:46:03.000000000","message":"What happens if the manifest includes a kind that is not defined on the kubernetes_resource.py?\nIn the case of Helm, deploys the resources by `helm install` command, so I think it might be had unexpected kind.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        k8s_reses \u003d []"},{"line_number":395,"context_line":"        for k8s_res in k8s_resources:"},{"line_number":396,"context_line":"            kind \u003d k8s_res.get(\u0027kind\u0027)"},{"line_number":397,"context_line":"            cls \u003d getattr(kubernetes_resource, kind)"},{"line_number":398,"context_line":"            k8s_reses.append(cls(k8s_api_client, k8s_res))"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return k8s_reses"}],"source_content_type":"text/x-python","patch_set":6,"id":"921c1782_6f91f9e6","line":397,"range":{"start_line":397,"start_character":12,"end_line":397,"end_character":52},"in_reply_to":"26b96afb_40493906","updated":"2022-09-08 06:27:28.000000000","message":"Thanks for your answer, but I\u0027m afraid if unexpected kind may cause AttributeError at `getattr(kubernetes_resource, kind)` and stop processing.\nDoes it happen?","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        k8s_reses \u003d []"},{"line_number":395,"context_line":"        for k8s_res in k8s_resources:"},{"line_number":396,"context_line":"            kind \u003d k8s_res.get(\u0027kind\u0027)"},{"line_number":397,"context_line":"            cls \u003d getattr(kubernetes_resource, kind)"},{"line_number":398,"context_line":"            k8s_reses.append(cls(k8s_api_client, k8s_res))"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return k8s_reses"}],"source_content_type":"text/x-python","patch_set":6,"id":"26b96afb_40493906","line":397,"range":{"start_line":397,"start_character":12,"end_line":397,"end_character":52},"in_reply_to":"8e153494_1d5cfc02","updated":"2022-09-08 05:32:47.000000000","message":"resources ohter than VDUs are used for only check of instantiate/terminate completion. It\u0027s not such a big issue if such resources exists. (though it is expected that there are only supported resources in the chart.)","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"724612e709dfa228493ea436dff01e3ccca40440","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        k8s_reses \u003d []"},{"line_number":395,"context_line":"        for k8s_res in k8s_resources:"},{"line_number":396,"context_line":"            kind \u003d k8s_res.get(\u0027kind\u0027)"},{"line_number":397,"context_line":"            cls \u003d getattr(kubernetes_resource, kind)"},{"line_number":398,"context_line":"            k8s_reses.append(cls(k8s_api_client, k8s_res))"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return k8s_reses"}],"source_content_type":"text/x-python","patch_set":6,"id":"b6f15369_c704e0f7","line":397,"range":{"start_line":397,"start_character":12,"end_line":397,"end_character":52},"in_reply_to":"921c1782_6f91f9e6","updated":"2022-09-08 06:48:38.000000000","message":"I misunderstand something. I will fix.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"758fcfe72fad86da75dbe7c1170e16cc4b8a578c","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        k8s_reses \u003d []"},{"line_number":395,"context_line":"        for k8s_res in k8s_resources:"},{"line_number":396,"context_line":"            kind \u003d k8s_res.get(\u0027kind\u0027)"},{"line_number":397,"context_line":"            cls \u003d getattr(kubernetes_resource, kind)"},{"line_number":398,"context_line":"            k8s_reses.append(cls(k8s_api_client, k8s_res))"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        return k8s_reses"}],"source_content_type":"text/x-python","patch_set":6,"id":"5840dda2_c839884e","line":397,"range":{"start_line":397,"start_character":12,"end_line":397,"end_character":52},"in_reply_to":"b6f15369_c704e0f7","updated":"2022-09-13 06:57:41.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def _get_release_name(self, inst, helm_chart_path):"},{"line_number":403,"context_line":"        helm_chart_name \u003d os.path.basename(helm_chart_path)"},{"line_number":404,"context_line":"        release_name \u003d inst.id + \"-\" + helm_chart_name.split(\".\")[0]"},{"line_number":405,"context_line":"        return release_name"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def _init_instantiated_vnf_info(self, inst, flavour_id, req, vdu_reses,"}],"source_content_type":"text/x-python","patch_set":6,"id":"4f2988c6_676074b0","line":404,"range":{"start_line":404,"start_character":31,"end_line":404,"end_character":38},"updated":"2022-09-08 02:46:03.000000000","message":"Could you use f-string or format to concatenate string?","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def _get_release_name(self, inst, helm_chart_path):"},{"line_number":403,"context_line":"        helm_chart_name \u003d os.path.basename(helm_chart_path)"},{"line_number":404,"context_line":"        release_name \u003d inst.id + \"-\" + helm_chart_name.split(\".\")[0]"},{"line_number":405,"context_line":"        return release_name"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def _init_instantiated_vnf_info(self, inst, flavour_id, req, vdu_reses,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f8cda701_c7501cbf","line":404,"range":{"start_line":404,"start_character":39,"end_line":404,"end_character":68},"updated":"2022-09-08 02:46:03.000000000","message":"If chart file name is `sample-0.1.0.tgz`, release_name become `\u003cinst.id\u003e-sample-0`. \n(The chart version is added to chart name by helm package command)\nIs there any particular problem with this name?","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def _get_release_name(self, inst, helm_chart_path):"},{"line_number":403,"context_line":"        helm_chart_name \u003d os.path.basename(helm_chart_path)"},{"line_number":404,"context_line":"        release_name \u003d inst.id + \"-\" + helm_chart_name.split(\".\")[0]"},{"line_number":405,"context_line":"        return release_name"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def _init_instantiated_vnf_info(self, inst, flavour_id, req, vdu_reses,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f43258a3_c865a7e9","line":404,"range":{"start_line":404,"start_character":31,"end_line":404,"end_character":38},"in_reply_to":"4f2988c6_676074b0","updated":"2022-09-08 05:32:47.000000000","message":"I see. (note: chart_name is not included in release_name in ps7. and will include \u0027vnf-\u0027 later ps)","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def _get_release_name(self, inst, helm_chart_path):"},{"line_number":403,"context_line":"        helm_chart_name \u003d os.path.basename(helm_chart_path)"},{"line_number":404,"context_line":"        release_name \u003d inst.id + \"-\" + helm_chart_name.split(\".\")[0]"},{"line_number":405,"context_line":"        return release_name"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def _init_instantiated_vnf_info(self, inst, flavour_id, req, vdu_reses,"}],"source_content_type":"text/x-python","patch_set":6,"id":"e41a4c1c_122f19cd","line":404,"range":{"start_line":404,"start_character":39,"end_line":404,"end_character":68},"in_reply_to":"50526f18_be441f74","updated":"2022-09-08 06:27:28.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def _get_release_name(self, inst, helm_chart_path):"},{"line_number":403,"context_line":"        helm_chart_name \u003d os.path.basename(helm_chart_path)"},{"line_number":404,"context_line":"        release_name \u003d inst.id + \"-\" + helm_chart_name.split(\".\")[0]"},{"line_number":405,"context_line":"        return release_name"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def _init_instantiated_vnf_info(self, inst, flavour_id, req, vdu_reses,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ce3842c1_9ce2e3c4","line":404,"range":{"start_line":404,"start_character":31,"end_line":404,"end_character":38},"in_reply_to":"f43258a3_c865a7e9","updated":"2022-09-08 06:27:28.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def _get_release_name(self, inst, helm_chart_path):"},{"line_number":403,"context_line":"        helm_chart_name \u003d os.path.basename(helm_chart_path)"},{"line_number":404,"context_line":"        release_name \u003d inst.id + \"-\" + helm_chart_name.split(\".\")[0]"},{"line_number":405,"context_line":"        return release_name"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def _init_instantiated_vnf_info(self, inst, flavour_id, req, vdu_reses,"}],"source_content_type":"text/x-python","patch_set":6,"id":"50526f18_be441f74","line":404,"range":{"start_line":404,"start_character":39,"end_line":404,"end_character":68},"in_reply_to":"f8cda701_c7501cbf","updated":"2022-09-08 05:32:47.000000000","message":"chart_name is not included. (ps7)","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a85849913731a3b4f7c17316b732e0980273ff6c","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    def _delete_resource(self, release_name, namespace, k8s_api_client,"},{"line_number":109,"context_line":"            helm_client):"},{"line_number":110,"context_line":"        if not helm_client.is_release_exist(release_name, namespace):"},{"line_number":111,"context_line":"            LOG.debug(f\u0027HELM release {release_name} is not exist.\u0027)"},{"line_number":112,"context_line":"            return"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # get k8s manifest from helm chart"}],"source_content_type":"text/x-python","patch_set":16,"id":"38ef511d_fed8219c","line":111,"range":{"start_line":111,"start_character":16,"end_line":111,"end_character":21},"updated":"2022-09-13 09:30:21.000000000","message":"I think \"info\" is better.\nBecause in most cases when you try to delete, the release exists.","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d6c3c87e97570ea715dfd696f59859f44d426b95","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    def _delete_resource(self, release_name, namespace, k8s_api_client,"},{"line_number":109,"context_line":"            helm_client):"},{"line_number":110,"context_line":"        if not helm_client.is_release_exist(release_name, namespace):"},{"line_number":111,"context_line":"            LOG.debug(f\u0027HELM release {release_name} is not exist.\u0027)"},{"line_number":112,"context_line":"            return"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # get k8s manifest from helm chart"}],"source_content_type":"text/x-python","patch_set":16,"id":"bc69193a_4e75f165","line":111,"range":{"start_line":111,"start_character":16,"end_line":111,"end_character":21},"in_reply_to":"38ef511d_fed8219c","updated":"2022-09-14 01:25:43.000000000","message":"I see. I will fix.","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"116d64f32b79b8306307e542a5b0bddee42a7e5c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def _delete_resource(self, release_name, namespace, k8s_api_client,"},{"line_number":109,"context_line":"            helm_client):"},{"line_number":110,"context_line":"        if not helm_client.is_release_exist(release_name, namespace):"},{"line_number":111,"context_line":"            LOG.debug(f\u0027HELM release {release_name} is not exist.\u0027)"},{"line_number":112,"context_line":"            return"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        # get k8s manifest from helm chart"}],"source_content_type":"text/x-python","patch_set":16,"id":"a3f5e8fc_1757c442","line":111,"range":{"start_line":111,"start_character":16,"end_line":111,"end_character":21},"in_reply_to":"bc69193a_4e75f165","updated":"2022-09-14 06:49:11.000000000","message":"Done","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a85849913731a3b4f7c17316b732e0980273ff6c","unresolved":true,"context_lines":[{"line_number":272,"context_line":"                # not reach here"},{"line_number":273,"context_line":"                pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def _change_vnfpkg_rollback_rolling_update(self, req, inst, grant_req,"},{"line_number":276,"context_line":"            grant, vnfd, k8s_api_client, helm_client):"},{"line_number":277,"context_line":"        metadata \u003d inst.instantiatedVnfInfo.metadata"},{"line_number":278,"context_line":"        namespace \u003d metadata[\u0027namespace\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"28e21097_ad0b0009","line":275,"range":{"start_line":275,"start_character":8,"end_line":275,"end_character":46},"updated":"2022-09-13 09:30:21.000000000","message":"\"_change_vnfpkg_rolling_update_rollback\" may be better.","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d6c3c87e97570ea715dfd696f59859f44d426b95","unresolved":true,"context_lines":[{"line_number":272,"context_line":"                # not reach here"},{"line_number":273,"context_line":"                pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def _change_vnfpkg_rollback_rolling_update(self, req, inst, grant_req,"},{"line_number":276,"context_line":"            grant, vnfd, k8s_api_client, helm_client):"},{"line_number":277,"context_line":"        metadata \u003d inst.instantiatedVnfInfo.metadata"},{"line_number":278,"context_line":"        namespace \u003d metadata[\u0027namespace\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"c3b93864_361385ac","line":275,"range":{"start_line":275,"start_character":8,"end_line":275,"end_character":46},"in_reply_to":"28e21097_ad0b0009","updated":"2022-09-14 01:25:43.000000000","message":"I see. I will fix.","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"116d64f32b79b8306307e542a5b0bddee42a7e5c","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                # not reach here"},{"line_number":273,"context_line":"                pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def _change_vnfpkg_rollback_rolling_update(self, req, inst, grant_req,"},{"line_number":276,"context_line":"            grant, vnfd, k8s_api_client, helm_client):"},{"line_number":277,"context_line":"        metadata \u003d inst.instantiatedVnfInfo.metadata"},{"line_number":278,"context_line":"        namespace \u003d metadata[\u0027namespace\u0027]"}],"source_content_type":"text/x-python","patch_set":16,"id":"e4f10f78_06470c90","line":275,"range":{"start_line":275,"start_character":8,"end_line":275,"end_character":46},"in_reply_to":"c3b93864_361385ac","updated":"2022-09-14 06:49:11.000000000","message":"Done","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # make instantiated info"},{"line_number":77,"context_line":"        self._init_instantiated_vnf_info("},{"line_number":78,"context_line":"            inst, req.flavourId, req, vdu_reses, namespace)"},{"line_number":79,"context_line":"        self._update_vnfc_info(inst, k8s_api_client)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _setup_k8s_reses(self, vnfd, target_k8s_files, k8s_api_client,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a5ea96f5_54fba3c9","line":78,"range":{"start_line":78,"start_character":18,"end_line":78,"end_character":31},"updated":"2022-09-08 02:46:03.000000000","message":"`req.flavourId` is not necessary due to change argument of _init_instantiated_vnf_info().","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # make instantiated info"},{"line_number":77,"context_line":"        self._init_instantiated_vnf_info("},{"line_number":78,"context_line":"            inst, req.flavourId, req, vdu_reses, namespace)"},{"line_number":79,"context_line":"        self._update_vnfc_info(inst, k8s_api_client)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _setup_k8s_reses(self, vnfd, target_k8s_files, k8s_api_client,"}],"source_content_type":"text/x-python","patch_set":6,"id":"828bcefb_74405943","line":78,"range":{"start_line":78,"start_character":18,"end_line":78,"end_character":31},"in_reply_to":"811ed4f7_506d9cac","updated":"2022-09-08 06:27:28.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # make instantiated info"},{"line_number":77,"context_line":"        self._init_instantiated_vnf_info("},{"line_number":78,"context_line":"            inst, req.flavourId, req, vdu_reses, namespace)"},{"line_number":79,"context_line":"        self._update_vnfc_info(inst, k8s_api_client)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _setup_k8s_reses(self, vnfd, target_k8s_files, k8s_api_client,"}],"source_content_type":"text/x-python","patch_set":6,"id":"811ed4f7_506d9cac","line":78,"range":{"start_line":78,"start_character":18,"end_line":78,"end_character":31},"in_reply_to":"a5ea96f5_54fba3c9","updated":"2022-09-08 05:32:47.000000000","message":"_init_instantiated_vnf_info is changed in ps7.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":206,"context_line":"                vnfd, inst.instantiatedVnfInfo.flavourId, k8s_reses)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"            self._init_instantiated_vnf_info("},{"line_number":209,"context_line":"                inst, inst.instantiatedVnfInfo.flavourId, req,"},{"line_number":210,"context_line":"                vdu_reses, namespace)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            self._change_vnfpkg_rolling_update("}],"source_content_type":"text/x-python","patch_set":6,"id":"7b242fee_a2fa791c","line":209,"range":{"start_line":209,"start_character":22,"end_line":209,"end_character":56},"updated":"2022-09-08 02:46:03.000000000","message":"ditto.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                vnfd, inst.instantiatedVnfInfo.flavourId, k8s_reses)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"            self._init_instantiated_vnf_info("},{"line_number":209,"context_line":"                inst, inst.instantiatedVnfInfo.flavourId, req,"},{"line_number":210,"context_line":"                vdu_reses, namespace)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            self._change_vnfpkg_rolling_update("}],"source_content_type":"text/x-python","patch_set":6,"id":"5b1649aa_d575da54","line":209,"range":{"start_line":209,"start_character":22,"end_line":209,"end_character":56},"in_reply_to":"18b7c831_4ec1aeb7","updated":"2022-09-08 06:27:28.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":206,"context_line":"                vnfd, inst.instantiatedVnfInfo.flavourId, k8s_reses)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"            self._init_instantiated_vnf_info("},{"line_number":209,"context_line":"                inst, inst.instantiatedVnfInfo.flavourId, req,"},{"line_number":210,"context_line":"                vdu_reses, namespace)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            self._change_vnfpkg_rolling_update("}],"source_content_type":"text/x-python","patch_set":6,"id":"18b7c831_4ec1aeb7","line":209,"range":{"start_line":209,"start_character":22,"end_line":209,"end_character":56},"in_reply_to":"7b242fee_a2fa791c","updated":"2022-09-08 05:32:47.000000000","message":"ditto.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_common.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _select_vdu_reses(self, vnfd, flavour_id, k8s_reses):"},{"line_number":103,"context_line":"        vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":104,"context_line":"        vdu_ids \u003d {value.get(\u0027properties\u0027).get(\u0027name\u0027): key"},{"line_number":105,"context_line":"                   for key, value in vdu_nodes.items()}"},{"line_number":106,"context_line":"        return {vdu_ids[res.name.split(\"-\")[0]]: res"},{"line_number":107,"context_line":"                for res in k8s_reses"}],"source_content_type":"text/x-python","patch_set":6,"id":"4a4ed19d_f95527a9","line":104,"range":{"start_line":104,"start_character":19,"end_line":104,"end_character":54},"updated":"2022-09-08 02:46:03.000000000","message":"In case of Helm, is there no problem to get from `properties.name` of VDU definition?\nI\u0027m concerned that it will prevent multiple VNFs from being created from a single VNF package with using Helm.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _select_vdu_reses(self, vnfd, flavour_id, k8s_reses):"},{"line_number":103,"context_line":"        vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":104,"context_line":"        vdu_ids \u003d {value.get(\u0027properties\u0027).get(\u0027name\u0027): key"},{"line_number":105,"context_line":"                   for key, value in vdu_nodes.items()}"},{"line_number":106,"context_line":"        return {vdu_ids[res.name.split(\"-\")[0]]: res"},{"line_number":107,"context_line":"                for res in k8s_reses"}],"source_content_type":"text/x-python","patch_set":6,"id":"fda73786_d918b8fb","line":104,"range":{"start_line":104,"start_character":19,"end_line":104,"end_character":54},"in_reply_to":"4a4ed19d_f95527a9","updated":"2022-09-08 05:32:47.000000000","message":"There is an assumption (will be mentioned in document) that definition of metadata.name must be {vdu name}-{unique between releases}.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _select_vdu_reses(self, vnfd, flavour_id, k8s_reses):"},{"line_number":103,"context_line":"        vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":104,"context_line":"        vdu_ids \u003d {value.get(\u0027properties\u0027).get(\u0027name\u0027): key"},{"line_number":105,"context_line":"                   for key, value in vdu_nodes.items()}"},{"line_number":106,"context_line":"        return {vdu_ids[res.name.split(\"-\")[0]]: res"},{"line_number":107,"context_line":"                for res in k8s_reses"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a50daf3_b728f6a7","line":104,"range":{"start_line":104,"start_character":19,"end_line":104,"end_character":54},"in_reply_to":"fda73786_d918b8fb","updated":"2022-09-08 06:27:28.000000000","message":"I understand that there is a new assumption.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":104,"context_line":"        vdu_ids \u003d {value.get(\u0027properties\u0027).get(\u0027name\u0027): key"},{"line_number":105,"context_line":"                   for key, value in vdu_nodes.items()}"},{"line_number":106,"context_line":"        return {vdu_ids[res.name.split(\"-\")[0]]: res"},{"line_number":107,"context_line":"                for res in k8s_reses"},{"line_number":108,"context_line":"                if (res.kind in TARGET_KIND"},{"line_number":109,"context_line":"                    and res.name.split(\"-\")[0] in vdu_ids)}"}],"source_content_type":"text/x-python","patch_set":6,"id":"d1b6f62d_12ebe019","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":46},"updated":"2022-09-08 02:46:03.000000000","message":"Why do you add `.split(\"-\")[0]` to original _select_vdu_reses().\nI think it is easier to understand If there is description what parameters are inputted and returned as `vdu_reses` in comment.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":104,"context_line":"        vdu_ids \u003d {value.get(\u0027properties\u0027).get(\u0027name\u0027): key"},{"line_number":105,"context_line":"                   for key, value in vdu_nodes.items()}"},{"line_number":106,"context_line":"        return {vdu_ids[res.name.split(\"-\")[0]]: res"},{"line_number":107,"context_line":"                for res in k8s_reses"},{"line_number":108,"context_line":"                if (res.kind in TARGET_KIND"},{"line_number":109,"context_line":"                    and res.name.split(\"-\")[0] in vdu_ids)}"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fce4280_fe62298c","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":46},"in_reply_to":"b2247e44_4bf1bc9b","updated":"2022-09-08 06:27:28.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":103,"context_line":"        vdu_nodes \u003d vnfd.get_vdu_nodes(flavour_id)"},{"line_number":104,"context_line":"        vdu_ids \u003d {value.get(\u0027properties\u0027).get(\u0027name\u0027): key"},{"line_number":105,"context_line":"                   for key, value in vdu_nodes.items()}"},{"line_number":106,"context_line":"        return {vdu_ids[res.name.split(\"-\")[0]]: res"},{"line_number":107,"context_line":"                for res in k8s_reses"},{"line_number":108,"context_line":"                if (res.kind in TARGET_KIND"},{"line_number":109,"context_line":"                    and res.name.split(\"-\")[0] in vdu_ids)}"}],"source_content_type":"text/x-python","patch_set":6,"id":"b2247e44_4bf1bc9b","line":106,"range":{"start_line":106,"start_character":32,"end_line":106,"end_character":46},"in_reply_to":"d1b6f62d_12ebe019","updated":"2022-09-08 05:32:47.000000000","message":"see above. I will add a comment.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31668},"change_message_id":"d69dc0427118b1b613bb474a932d0047ff4a1e4f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":16,"id":"c06cbd79_3b584aec","line":1,"updated":"2022-09-14 00:40:37.000000000","message":"Is there no problem if it is not described as below?\n# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d6c3c87e97570ea715dfd696f59859f44d426b95","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":16,"id":"f62ab6d2_f8f0dc57","line":1,"in_reply_to":"c06cbd79_3b584aec","updated":"2022-09-14 01:25:43.000000000","message":"I will fix it.","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":31668},"change_message_id":"ea523e0bc5e8477bfbce0f5d66d5696f7ba30f4d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":16,"id":"11ea47c2_38e72add","line":1,"in_reply_to":"f62ab6d2_f8f0dc57","updated":"2022-09-14 09:07:05.000000000","message":"Done","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"116d64f32b79b8306307e542a5b0bddee42a7e5c","unresolved":true,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def _wait_k8s_reses_updated(self, k8s_reses, k8s_api_client, namespace,"},{"line_number":198,"context_line":"            old_pods_names):"},{"line_number":199,"context_line":"        def _check_update(check_reses, k8s_api_client, namespace,"},{"line_number":200,"context_line":"                old_pods_names):"},{"line_number":201,"context_line":"            ok_reses \u003d set()"},{"line_number":202,"context_line":"            all_pods \u003d kubernetes_utils.list_namespaced_pods("}],"source_content_type":"text/x-python","patch_set":17,"id":"d4241f8b_a48a597e","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":25},"updated":"2022-09-14 06:49:11.000000000","message":"Nit: _check_updated","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8909643eb8ddfff23f1706424f4c570eccb00b38","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def _wait_k8s_reses_updated(self, k8s_reses, k8s_api_client, namespace,"},{"line_number":198,"context_line":"            old_pods_names):"},{"line_number":199,"context_line":"        def _check_update(check_reses, k8s_api_client, namespace,"},{"line_number":200,"context_line":"                old_pods_names):"},{"line_number":201,"context_line":"            ok_reses \u003d set()"},{"line_number":202,"context_line":"            all_pods \u003d kubernetes_utils.list_namespaced_pods("}],"source_content_type":"text/x-python","patch_set":17,"id":"b93717fb_983107d8","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":25},"in_reply_to":"4af779ac_31059f4a","updated":"2022-09-15 02:13:18.000000000","message":"Done","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"73ff4cbf341a73fb6622bc514018903f71b4504c","unresolved":true,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def _wait_k8s_reses_updated(self, k8s_reses, k8s_api_client, namespace,"},{"line_number":198,"context_line":"            old_pods_names):"},{"line_number":199,"context_line":"        def _check_update(check_reses, k8s_api_client, namespace,"},{"line_number":200,"context_line":"                old_pods_names):"},{"line_number":201,"context_line":"            ok_reses \u003d set()"},{"line_number":202,"context_line":"            all_pods \u003d kubernetes_utils.list_namespaced_pods("}],"source_content_type":"text/x-python","patch_set":17,"id":"4af779ac_31059f4a","line":199,"range":{"start_line":199,"start_character":12,"end_line":199,"end_character":25},"in_reply_to":"d4241f8b_a48a597e","updated":"2022-09-14 08:28:22.000000000","message":"I see. I will fix.","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"}],"tacker/sol_refactored/infra_drivers/kubernetes/kubernetes_utils.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a85849913731a3b4f7c17316b732e0980273ff6c","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SUPPORTED_NAMESPACE_KINDS \u003d {"},{"line_number":35,"context_line":"    \"Pod\","},{"line_number":36,"context_line":"    \"Binding\","},{"line_number":37,"context_line":"    \"ConfigMap\","}],"source_content_type":"text/x-python","patch_set":16,"id":"ee5accd9_ce406b4f","line":34,"updated":"2022-09-13 09:30:21.000000000","message":"I think the order of kinds has not any special meaning, so how about changing it to alphabetical order?","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"116d64f32b79b8306307e542a5b0bddee42a7e5c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SUPPORTED_NAMESPACE_KINDS \u003d {"},{"line_number":35,"context_line":"    \"Pod\","},{"line_number":36,"context_line":"    \"Binding\","},{"line_number":37,"context_line":"    \"ConfigMap\","}],"source_content_type":"text/x-python","patch_set":16,"id":"a87e541c_4501ba7b","line":34,"in_reply_to":"4c7586f3_63dfd688","updated":"2022-09-14 06:49:11.000000000","message":"Done","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d6c3c87e97570ea715dfd696f59859f44d426b95","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SUPPORTED_NAMESPACE_KINDS \u003d {"},{"line_number":35,"context_line":"    \"Pod\","},{"line_number":36,"context_line":"    \"Binding\","},{"line_number":37,"context_line":"    \"ConfigMap\","}],"source_content_type":"text/x-python","patch_set":16,"id":"4c7586f3_63dfd688","line":34,"in_reply_to":"ee5accd9_ce406b4f","updated":"2022-09-14 01:25:43.000000000","message":"As there is not the special meaning, I change it in alphabetical order.","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"116d64f32b79b8306307e542a5b0bddee42a7e5c","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        return helm_auth_params"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def get_helm_client(self):"},{"line_number":189,"context_line":"        return helm_utils.HelmClient(self._get_helm_auth_params())"}],"source_content_type":"text/x-python","patch_set":17,"id":"d1d9bc82_d0affbbb","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":23},"updated":"2022-09-14 06:49:11.000000000","message":"\"init_helm_client\" is better to match \"init_k8s_api_client\".","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8909643eb8ddfff23f1706424f4c570eccb00b38","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        return helm_auth_params"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def get_helm_client(self):"},{"line_number":189,"context_line":"        return helm_utils.HelmClient(self._get_helm_auth_params())"}],"source_content_type":"text/x-python","patch_set":17,"id":"81fc7900_420ebb84","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":23},"in_reply_to":"a74455d5_044eb424","updated":"2022-09-15 02:13:18.000000000","message":"Done","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"73ff4cbf341a73fb6622bc514018903f71b4504c","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        return helm_auth_params"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def get_helm_client(self):"},{"line_number":189,"context_line":"        return helm_utils.HelmClient(self._get_helm_auth_params())"}],"source_content_type":"text/x-python","patch_set":17,"id":"a74455d5_044eb424","line":188,"range":{"start_line":188,"start_character":8,"end_line":188,"end_character":23},"in_reply_to":"d1d9bc82_d0affbbb","updated":"2022-09-14 08:28:22.000000000","message":"I see. I will fix.","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"}],"tacker/tests/functional/sol_kubernetes_v2/paramgen.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a85849913731a3b4f7c17316b732e0980273ff6c","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        },"},{"line_number":334,"context_line":"        \"accessInfo\": {"},{"line_number":335,"context_line":"            \"bearer_token\": bearer_token,"},{"line_number":336,"context_line":"            \"region\": \"RegionOne\","},{"line_number":337,"context_line":"        },"},{"line_number":338,"context_line":"    }"},{"line_number":339,"context_line":"    return {"}],"source_content_type":"text/x-python","patch_set":16,"id":"c0509aff_ef08c228","line":336,"range":{"start_line":336,"start_character":13,"end_line":336,"end_character":19},"updated":"2022-09-13 09:30:21.000000000","message":"Isn\u0027t this parameter unnecessary in helm?\nSame with kubernetes(e.g. L66).","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"116d64f32b79b8306307e542a5b0bddee42a7e5c","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        },"},{"line_number":334,"context_line":"        \"accessInfo\": {"},{"line_number":335,"context_line":"            \"bearer_token\": bearer_token,"},{"line_number":336,"context_line":"            \"region\": \"RegionOne\","},{"line_number":337,"context_line":"        },"},{"line_number":338,"context_line":"    }"},{"line_number":339,"context_line":"    return {"}],"source_content_type":"text/x-python","patch_set":16,"id":"fe1c8e26_f6dfd70f","line":336,"range":{"start_line":336,"start_character":13,"end_line":336,"end_character":19},"in_reply_to":"ab9b7627_1b45b1f1","updated":"2022-09-14 06:49:11.000000000","message":"Done","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"d6c3c87e97570ea715dfd696f59859f44d426b95","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        },"},{"line_number":334,"context_line":"        \"accessInfo\": {"},{"line_number":335,"context_line":"            \"bearer_token\": bearer_token,"},{"line_number":336,"context_line":"            \"region\": \"RegionOne\","},{"line_number":337,"context_line":"        },"},{"line_number":338,"context_line":"    }"},{"line_number":339,"context_line":"    return {"}],"source_content_type":"text/x-python","patch_set":16,"id":"ab9b7627_1b45b1f1","line":336,"range":{"start_line":336,"start_character":13,"end_line":336,"end_character":19},"in_reply_to":"c0509aff_ef08c228","updated":"2022-09-14 01:25:43.000000000","message":"I see. I will delete region. I also delete kubernets as well.","commit_id":"62bfd43defe17ceda034654fb286af0090a376f0"}],"tacker/tests/functional/sol_kubernetes_v2/samples/test_helm_change_vnf_pkg/contents/Files/kubernetes/test-chart-0.1.1.tgz":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bf074e7fdd17b1c7974711342aed95973a755218","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"87185659_15485c4e","updated":"2022-09-12 09:22:18.000000000","message":"Compressed with tgz, there are the following problems.\n* Cannot be reviewed on Gerrit\n* If the content of the file changes, it will be difficult to track the changes in the future\nSo, same with the VNF Package, can it be modified to be compressed when packaged?","commit_id":"bb0a694981d7ea4b157c05b3b154aaf4d01aecbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a85849913731a3b4f7c17316b732e0980273ff6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"efb2fd09_f6b890b9","in_reply_to":"1dec4718_45f880de","updated":"2022-09-13 09:30:21.000000000","message":"Done","commit_id":"bb0a694981d7ea4b157c05b3b154aaf4d01aecbd"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4ab1d6cbfbda43e89782d7f53e286c758fa92ec5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1dec4718_45f880de","in_reply_to":"87185659_15485c4e","updated":"2022-09-12 23:14:40.000000000","message":"I understand. I will add contents of tgz to make review and customize easy.\nBut let me keep tgz and not dynamically creating by the following reasons.\n- this is created by \"helm package\" command.\n- It is necessary to calculate hash and write to TOSCA.meta.","commit_id":"bb0a694981d7ea4b157c05b3b154aaf4d01aecbd"}],"tacker/tests/functional/sol_kubernetes_v2/samples/test_helm_change_vnf_pkg/contents/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccd9b323df7f37ff17b0f51786162f55e50e3cca","unresolved":true,"context_lines":[{"line_number":6,"context_line":"Name: Files/kubernetes/test-localhelm.tgz"},{"line_number":7,"context_line":"Content-Type: test-data"},{"line_number":8,"context_line":"Algorithm: SHA-256"},{"line_number":9,"context_line":"Hash: d5bf1e92f3dc9ce9e342b10e53b586e2d88d2f10bc6b27e2990431b0ffe1c597 "}],"source_content_type":"application/octet-stream","patch_set":6,"id":"296ad947_3b3b6da6","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":71},"updated":"2022-09-08 02:46:03.000000000","message":"Could you delete a unnecessary space character?","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ca476c91875754593c23f5e85e9096bd7d2752a3","unresolved":true,"context_lines":[{"line_number":6,"context_line":"Name: Files/kubernetes/test-localhelm.tgz"},{"line_number":7,"context_line":"Content-Type: test-data"},{"line_number":8,"context_line":"Algorithm: SHA-256"},{"line_number":9,"context_line":"Hash: d5bf1e92f3dc9ce9e342b10e53b586e2d88d2f10bc6b27e2990431b0ffe1c597 "}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ddf53f16_c2ce3a14","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":71},"in_reply_to":"296ad947_3b3b6da6","updated":"2022-09-08 05:32:47.000000000","message":"I will fix. but later. under tests/functional will be changed.","commit_id":"d5de2687be6870205092f1257d4474877a336b62"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"263ac5afb228bcfd3d3fc124f0f4591d2ab13317","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Name: Files/kubernetes/test-localhelm.tgz"},{"line_number":7,"context_line":"Content-Type: test-data"},{"line_number":8,"context_line":"Algorithm: SHA-256"},{"line_number":9,"context_line":"Hash: d5bf1e92f3dc9ce9e342b10e53b586e2d88d2f10bc6b27e2990431b0ffe1c597 "}],"source_content_type":"application/octet-stream","patch_set":6,"id":"c3704cb4_7a4b70b6","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":71},"in_reply_to":"ddf53f16_c2ce3a14","updated":"2022-09-08 06:27:28.000000000","message":"Ack","commit_id":"d5de2687be6870205092f1257d4474877a336b62"}],"tacker/tests/functional/sol_kubernetes_v2/samples/test_helm_change_vnf_pkg/pkggen.py":[{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":18,"id":"9662167a_ef163547","line":1,"updated":"2022-09-14 09:54:25.000000000","message":"Is there no problem if it is not described as below?\n# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":18,"id":"ff9904a4_b43342eb","line":1,"in_reply_to":"9662167a_ef163547","updated":"2022-09-15 00:46:00.000000000","message":"I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":18,"id":"0f316269_4f401e3c","line":1,"in_reply_to":"ff9904a4_b43342eb","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"}],"tacker/tests/functional/sol_kubernetes_v2/samples/test_helm_instantiate/contents/Definitions/sample_cnf_df_simple.yaml":[{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c8e03c95_fe6ff664","line":179,"updated":"2022-09-14 09:54:25.000000000","message":"unnecessary line","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e4c59415_caaa7735","line":179,"in_reply_to":"340acb91_4e40dc69","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"340acb91_4e40dc69","line":179,"in_reply_to":"c8e03c95_fe6ff664","updated":"2022-09-15 00:46:00.000000000","message":"I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"}],"tacker/tests/functional/sol_kubernetes_v2/samples/test_helm_instantiate/pkggen.py":[{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":18,"id":"687c635a_97069c15","line":1,"updated":"2022-09-14 09:54:25.000000000","message":"Is there no problem if it is not described as below?\n# Copyright (C) 2022 Nippon Telegraph and Telephone Corporation","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":18,"id":"bbaf0b90_2d78b8eb","line":1,"in_reply_to":"687c635a_97069c15","updated":"2022-09-15 00:46:00.000000000","message":"I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2022 Fujitsu"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":18,"id":"e8222c70_21cbdd86","line":1,"in_reply_to":"bbaf0b90_2d78b8eb","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"}],"tacker/tests/functional/sol_kubernetes_v2/test_helm.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"116d64f32b79b8306307e542a5b0bddee42a7e5c","unresolved":true,"context_lines":[{"line_number":336,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback"},{"line_number":340,"context_line":"          - 5. Show VNF instance"},{"line_number":341,"context_line":"          - 6. Terminate a VNF instance"},{"line_number":342,"context_line":"          - 7. Delete a VNF instance"}],"source_content_type":"text/x-python","patch_set":17,"id":"49bd5cac_c88a711f","line":339,"updated":"2022-09-14 06:49:11.000000000","message":"\"Rollback scale out\"","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"73ff4cbf341a73fb6622bc514018903f71b4504c","unresolved":true,"context_lines":[{"line_number":336,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback"},{"line_number":340,"context_line":"          - 5. Show VNF instance"},{"line_number":341,"context_line":"          - 6. Terminate a VNF instance"},{"line_number":342,"context_line":"          - 7. Delete a VNF instance"}],"source_content_type":"text/x-python","patch_set":17,"id":"7dc57720_5d1dec2e","line":339,"in_reply_to":"49bd5cac_c88a711f","updated":"2022-09-14 08:28:22.000000000","message":"I will fix.","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8909643eb8ddfff23f1706424f4c570eccb00b38","unresolved":false,"context_lines":[{"line_number":336,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback"},{"line_number":340,"context_line":"          - 5. Show VNF instance"},{"line_number":341,"context_line":"          - 6. Terminate a VNF instance"},{"line_number":342,"context_line":"          - 7. Delete a VNF instance"}],"source_content_type":"text/x-python","patch_set":17,"id":"07e98c90_b0c8e034","line":339,"in_reply_to":"7dc57720_5d1dec2e","updated":"2022-09-15 02:13:18.000000000","message":"Done","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"116d64f32b79b8306307e542a5b0bddee42a7e5c","unresolved":true,"context_lines":[{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback"},{"line_number":340,"context_line":"          - 5. Show VNF instance"},{"line_number":341,"context_line":"          - 6. Terminate a VNF instance"},{"line_number":342,"context_line":"          - 7. Delete a VNF instance"},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # 1. Create a new VNF instance resource"}],"source_content_type":"text/x-python","patch_set":17,"id":"805b9fb2_9b8d0a2e","line":342,"range":{"start_line":340,"start_character":0,"end_line":342,"end_character":36},"updated":"2022-09-14 06:49:11.000000000","message":"Index is wrong.","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"73ff4cbf341a73fb6622bc514018903f71b4504c","unresolved":true,"context_lines":[{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback"},{"line_number":340,"context_line":"          - 5. Show VNF instance"},{"line_number":341,"context_line":"          - 6. Terminate a VNF instance"},{"line_number":342,"context_line":"          - 7. Delete a VNF instance"},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # 1. Create a new VNF instance resource"}],"source_content_type":"text/x-python","patch_set":17,"id":"d5d23282_f0279ea4","line":342,"range":{"start_line":340,"start_character":0,"end_line":342,"end_character":36},"in_reply_to":"805b9fb2_9b8d0a2e","updated":"2022-09-14 08:28:22.000000000","message":"I was wrong. I will fix.","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8909643eb8ddfff23f1706424f4c570eccb00b38","unresolved":false,"context_lines":[{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback"},{"line_number":340,"context_line":"          - 5. Show VNF instance"},{"line_number":341,"context_line":"          - 6. Terminate a VNF instance"},{"line_number":342,"context_line":"          - 7. Delete a VNF instance"},{"line_number":343,"context_line":"        \"\"\""},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # 1. Create a new VNF instance resource"}],"source_content_type":"text/x-python","patch_set":17,"id":"cdf3515e_b58d9512","line":342,"range":{"start_line":340,"start_character":0,"end_line":342,"end_character":36},"in_reply_to":"d5d23282_f0279ea4","updated":"2022-09-15 02:13:18.000000000","message":"Done","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"116d64f32b79b8306307e542a5b0bddee42a7e5c","unresolved":true,"context_lines":[{"line_number":422,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":423,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":424,"context_line":"          - 3. Show VNF instance"},{"line_number":425,"context_line":"          - 4. Change Current VNF Package"},{"line_number":426,"context_line":"          - 5. Rollback Change Current VNF Package"},{"line_number":427,"context_line":"          - 6. Show VNF instance"},{"line_number":428,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":17,"id":"636a16d3_96cdd0ec","line":425,"updated":"2022-09-14 06:49:11.000000000","message":"\"\u003d\u003d\u003e FAILED_TEMP\" is missing.","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8909643eb8ddfff23f1706424f4c570eccb00b38","unresolved":false,"context_lines":[{"line_number":422,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":423,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":424,"context_line":"          - 3. Show VNF instance"},{"line_number":425,"context_line":"          - 4. Change Current VNF Package"},{"line_number":426,"context_line":"          - 5. Rollback Change Current VNF Package"},{"line_number":427,"context_line":"          - 6. Show VNF instance"},{"line_number":428,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":17,"id":"2f95bdf1_e6a3692c","line":425,"in_reply_to":"5e30c1ad_3d59b5f7","updated":"2022-09-15 02:13:18.000000000","message":"Done","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"73ff4cbf341a73fb6622bc514018903f71b4504c","unresolved":true,"context_lines":[{"line_number":422,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":423,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":424,"context_line":"          - 3. Show VNF instance"},{"line_number":425,"context_line":"          - 4. Change Current VNF Package"},{"line_number":426,"context_line":"          - 5. Rollback Change Current VNF Package"},{"line_number":427,"context_line":"          - 6. Show VNF instance"},{"line_number":428,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":17,"id":"5e30c1ad_3d59b5f7","line":425,"in_reply_to":"636a16d3_96cdd0ec","updated":"2022-09-14 08:28:22.000000000","message":"I will fix.","commit_id":"23d69f82638e897d9d9637d0eb552cba4bc333f5"},{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        self.check_resp_headers_in_create(resp)"},{"line_number":294,"context_line":"        inst_id \u003d body[\u0027id\u0027]"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # 2. Instantiate a VNF instance"},{"line_number":297,"context_line":"        self._put_fail_file(\u0027instantiate_end\u0027)"},{"line_number":298,"context_line":"        instantiate_req \u003d paramgen.helm_instantiate("},{"line_number":299,"context_line":"            self.auth_url, self.bearer_token, self.ssl_ca_cert)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9653fed6_abc6d268","line":296,"updated":"2022-09-14 09:54:25.000000000","message":"It is better to add \"\u003d\u003e FAILED_TEMP\" according to L.281.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        self.check_resp_headers_in_create(resp)"},{"line_number":294,"context_line":"        inst_id \u003d body[\u0027id\u0027]"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # 2. Instantiate a VNF instance"},{"line_number":297,"context_line":"        self._put_fail_file(\u0027instantiate_end\u0027)"},{"line_number":298,"context_line":"        instantiate_req \u003d paramgen.helm_instantiate("},{"line_number":299,"context_line":"            self.auth_url, self.bearer_token, self.ssl_ca_cert)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9c1fec5a_6d836629","line":296,"in_reply_to":"819c618d_73a70baf","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        self.check_resp_headers_in_create(resp)"},{"line_number":294,"context_line":"        inst_id \u003d body[\u0027id\u0027]"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # 2. Instantiate a VNF instance"},{"line_number":297,"context_line":"        self._put_fail_file(\u0027instantiate_end\u0027)"},{"line_number":298,"context_line":"        instantiate_req \u003d paramgen.helm_instantiate("},{"line_number":299,"context_line":"            self.auth_url, self.bearer_token, self.ssl_ca_cert)"}],"source_content_type":"text/x-python","patch_set":18,"id":"819c618d_73a70baf","line":296,"in_reply_to":"9653fed6_abc6d268","updated":"2022-09-15 00:46:00.000000000","message":"I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[{"line_number":335,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":336,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback scale out"},{"line_number":340,"context_line":"          - 6. Show VNF instance"},{"line_number":341,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":18,"id":"b06ab237_06bc2ddd","line":338,"updated":"2022-09-14 09:54:25.000000000","message":"It is better to add \"a VNF instance\" according to L.59.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[{"line_number":335,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":336,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback scale out"},{"line_number":340,"context_line":"          - 6. Show VNF instance"},{"line_number":341,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a816d38_604f4c4c","line":338,"updated":"2022-09-14 09:54:25.000000000","message":"It is better to use \"\u003d\u003e\" instead of \"\u003d\u003d\u003e\" according to L.281.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":335,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":336,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback scale out"},{"line_number":340,"context_line":"          - 6. Show VNF instance"},{"line_number":341,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":18,"id":"8ee8b957_120c7cd4","line":338,"in_reply_to":"1a816d38_604f4c4c","updated":"2022-09-15 00:46:00.000000000","message":"I see. I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":335,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":336,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback scale out"},{"line_number":340,"context_line":"          - 6. Show VNF instance"},{"line_number":341,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":18,"id":"ec6718fd_e13ecfba","line":338,"in_reply_to":"8ee8b957_120c7cd4","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":335,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":336,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback scale out"},{"line_number":340,"context_line":"          - 6. Show VNF instance"},{"line_number":341,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":18,"id":"e765dd89_520aecea","line":338,"in_reply_to":"b06ab237_06bc2ddd","updated":"2022-09-15 00:46:00.000000000","message":"I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":335,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":336,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":337,"context_line":"          - 3. Show VNF instance"},{"line_number":338,"context_line":"          - 4. Scale out \u003d\u003d\u003e FAILED_TEMP"},{"line_number":339,"context_line":"          - 5. Rollback scale out"},{"line_number":340,"context_line":"          - 6. Show VNF instance"},{"line_number":341,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":18,"id":"3dc16d40_08ddf871","line":338,"in_reply_to":"e765dd89_520aecea","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[{"line_number":370,"context_line":"                      if vnfc_info[\u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027}"},{"line_number":371,"context_line":"        self.assertEqual(1, len(vdu2_ids_0))"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        # 4. Scale out a VNF instance"},{"line_number":374,"context_line":"        self._put_fail_file(\u0027scale_end\u0027)"},{"line_number":375,"context_line":"        scale_out_req \u003d paramgen.helm_scale_out()"},{"line_number":376,"context_line":"        resp, body \u003d self.scale_vnf_instance(inst_id, scale_out_req)"}],"source_content_type":"text/x-python","patch_set":18,"id":"951e56c0_c94eee09","line":373,"updated":"2022-09-14 09:54:25.000000000","message":"It is better to add \"\u003d\u003e FAILED_TEMP\" according to L.338.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                      if vnfc_info[\u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027}"},{"line_number":371,"context_line":"        self.assertEqual(1, len(vdu2_ids_0))"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        # 4. Scale out a VNF instance"},{"line_number":374,"context_line":"        self._put_fail_file(\u0027scale_end\u0027)"},{"line_number":375,"context_line":"        scale_out_req \u003d paramgen.helm_scale_out()"},{"line_number":376,"context_line":"        resp, body \u003d self.scale_vnf_instance(inst_id, scale_out_req)"}],"source_content_type":"text/x-python","patch_set":18,"id":"dd965e09_8b057db2","line":373,"in_reply_to":"07710055_cb427c39","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":370,"context_line":"                      if vnfc_info[\u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027}"},{"line_number":371,"context_line":"        self.assertEqual(1, len(vdu2_ids_0))"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        # 4. Scale out a VNF instance"},{"line_number":374,"context_line":"        self._put_fail_file(\u0027scale_end\u0027)"},{"line_number":375,"context_line":"        scale_out_req \u003d paramgen.helm_scale_out()"},{"line_number":376,"context_line":"        resp, body \u003d self.scale_vnf_instance(inst_id, scale_out_req)"}],"source_content_type":"text/x-python","patch_set":18,"id":"07710055_cb427c39","line":373,"in_reply_to":"951e56c0_c94eee09","updated":"2022-09-15 00:46:00.000000000","message":"I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[{"line_number":381,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":382,"context_line":"        self._rm_fail_file(\u0027scale_end\u0027)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # 5. Rollback instantiate"},{"line_number":385,"context_line":"        resp, body \u003d self.rollback_lcmocc(lcmocc_id)"},{"line_number":386,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":387,"context_line":"        self.wait_lcmocc_rolled_back(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"a536cb23_643dff88","line":384,"updated":"2022-09-14 09:54:25.000000000","message":"This is \"scale out\" not \"instantiate\".","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":382,"context_line":"        self._rm_fail_file(\u0027scale_end\u0027)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # 5. Rollback instantiate"},{"line_number":385,"context_line":"        resp, body \u003d self.rollback_lcmocc(lcmocc_id)"},{"line_number":386,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":387,"context_line":"        self.wait_lcmocc_rolled_back(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"548465d3_fb1a2e22","line":384,"in_reply_to":"209629da_c115d672","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":381,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":382,"context_line":"        self._rm_fail_file(\u0027scale_end\u0027)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # 5. Rollback instantiate"},{"line_number":385,"context_line":"        resp, body \u003d self.rollback_lcmocc(lcmocc_id)"},{"line_number":386,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":387,"context_line":"        self.wait_lcmocc_rolled_back(lcmocc_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"209629da_c115d672","line":384,"in_reply_to":"a536cb23_643dff88","updated":"2022-09-15 00:46:00.000000000","message":"I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[{"line_number":422,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":423,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":424,"context_line":"          - 3. Show VNF instance"},{"line_number":425,"context_line":"          - 4. Change Current VNF Package \u003d\u003d\u003e FAILED_TEMP"},{"line_number":426,"context_line":"          - 5. Rollback Change Current VNF Package"},{"line_number":427,"context_line":"          - 6. Show VNF instance"},{"line_number":428,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa5d929c_22826e5c","line":425,"updated":"2022-09-14 09:54:25.000000000","message":"It is better to use \"\u003d\u003e\" instead of \"\u003d\u003d\u003e\" according to L.281.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":422,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":423,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":424,"context_line":"          - 3. Show VNF instance"},{"line_number":425,"context_line":"          - 4. Change Current VNF Package \u003d\u003d\u003e FAILED_TEMP"},{"line_number":426,"context_line":"          - 5. Rollback Change Current VNF Package"},{"line_number":427,"context_line":"          - 6. Show VNF instance"},{"line_number":428,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":18,"id":"e4d73564_e0ed8d4b","line":425,"in_reply_to":"5020df18_b05955a2","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":422,"context_line":"          - 1. Create a new VNF instance resource"},{"line_number":423,"context_line":"          - 2. Instantiate a VNF instance"},{"line_number":424,"context_line":"          - 3. Show VNF instance"},{"line_number":425,"context_line":"          - 4. Change Current VNF Package \u003d\u003d\u003e FAILED_TEMP"},{"line_number":426,"context_line":"          - 5. Rollback Change Current VNF Package"},{"line_number":427,"context_line":"          - 6. Show VNF instance"},{"line_number":428,"context_line":"          - 7. Terminate a VNF instance"}],"source_content_type":"text/x-python","patch_set":18,"id":"5020df18_b05955a2","line":425,"in_reply_to":"fa5d929c_22826e5c","updated":"2022-09-15 00:46:00.000000000","message":"I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[{"line_number":486,"context_line":"        before_vdu2_ids \u003d [vnfc_info[\u0027id\u0027] for vnfc_info in vnfc_resource_infos"},{"line_number":487,"context_line":"                           if vnfc_info[\u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027]"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        # 4. Change Current VNF Package (will fail)"},{"line_number":490,"context_line":"        change_vnfpkg_req \u003d paramgen.helm_error_handling_change_vnfpkg("},{"line_number":491,"context_line":"            self.vnfd_id_2)"},{"line_number":492,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnfpkg_req)"}],"source_content_type":"text/x-python","patch_set":18,"id":"876e1d11_0565cc24","line":489,"updated":"2022-09-14 09:54:25.000000000","message":"It is better to use \"\u003d\u003e FAILED_TEMP\" instead of \"(will fail)\" according to L.425.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":486,"context_line":"        before_vdu2_ids \u003d [vnfc_info[\u0027id\u0027] for vnfc_info in vnfc_resource_infos"},{"line_number":487,"context_line":"                           if vnfc_info[\u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027]"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        # 4. Change Current VNF Package (will fail)"},{"line_number":490,"context_line":"        change_vnfpkg_req \u003d paramgen.helm_error_handling_change_vnfpkg("},{"line_number":491,"context_line":"            self.vnfd_id_2)"},{"line_number":492,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnfpkg_req)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9e855eed_12c9ed62","line":489,"in_reply_to":"876e1d11_0565cc24","updated":"2022-09-15 00:46:00.000000000","message":"I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        before_vdu2_ids \u003d [vnfc_info[\u0027id\u0027] for vnfc_info in vnfc_resource_infos"},{"line_number":487,"context_line":"                           if vnfc_info[\u0027vduId\u0027] \u003d\u003d \u0027VDU2\u0027]"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        # 4. Change Current VNF Package (will fail)"},{"line_number":490,"context_line":"        change_vnfpkg_req \u003d paramgen.helm_error_handling_change_vnfpkg("},{"line_number":491,"context_line":"            self.vnfd_id_2)"},{"line_number":492,"context_line":"        resp, body \u003d self.change_vnfpkg(inst_id, change_vnfpkg_req)"}],"source_content_type":"text/x-python","patch_set":18,"id":"62f1bbad_402a7d21","line":489,"in_reply_to":"9e855eed_12c9ed62","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"c5c3d4924345afcb4ece384dfb5a8b8ab6adb0ba","unresolved":true,"context_lines":[{"line_number":496,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":497,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # 5. Rollback Change Current VNF Package operation"},{"line_number":500,"context_line":"        resp, body \u003d self.rollback_lcmocc(lcmocc_id)"},{"line_number":501,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":502,"context_line":"        self.check_resp_headers_in_delete(resp)"}],"source_content_type":"text/x-python","patch_set":18,"id":"f81c3642_5b09275d","line":499,"updated":"2022-09-14 09:54:25.000000000","message":"It is better to delete \"operation\" according to L.426.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":31668},"change_message_id":"7f0957298279a7863fb7cd2822d07c5c87f2dcc0","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":497,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # 5. Rollback Change Current VNF Package operation"},{"line_number":500,"context_line":"        resp, body \u003d self.rollback_lcmocc(lcmocc_id)"},{"line_number":501,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":502,"context_line":"        self.check_resp_headers_in_delete(resp)"}],"source_content_type":"text/x-python","patch_set":18,"id":"ec7b8a19_318b7041","line":499,"in_reply_to":"ef62015e_3f18c5bc","updated":"2022-09-15 02:19:55.000000000","message":"Done","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"},{"author":{"_account_id":34226,"name":"Ken Fujimoto","email":"fujimoto@valinux.co.jp","username":"k-fujimoto"},"change_message_id":"69621f63728cbea72eae57c3dc983aa666ed68d0","unresolved":true,"context_lines":[{"line_number":496,"context_line":"        lcmocc_id \u003d os.path.basename(resp.headers[\u0027Location\u0027])"},{"line_number":497,"context_line":"        self.wait_lcmocc_failed_temp(lcmocc_id)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        # 5. Rollback Change Current VNF Package operation"},{"line_number":500,"context_line":"        resp, body \u003d self.rollback_lcmocc(lcmocc_id)"},{"line_number":501,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":502,"context_line":"        self.check_resp_headers_in_delete(resp)"}],"source_content_type":"text/x-python","patch_set":18,"id":"ef62015e_3f18c5bc","line":499,"in_reply_to":"f81c3642_5b09275d","updated":"2022-09-15 00:46:00.000000000","message":"I will fix.","commit_id":"5569ec5381d935ce4b500fa53f2416d542e3f116"}]}