)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a0776ad1b617fad4af5ea27cad790ff0dca39fe7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 06:52:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A DB migration tool for API version update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the DB migration tool which enables DB migration from v1"},{"line_number":10,"context_line":"to v2 API without service outage of the VNF."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"369d5978_598498ec","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"updated":"2022-09-16 08:27:46.000000000","message":"Just a confirmation,\nWill you add the usage of this tool to user document or README [1] with another patch?\n\nThe work item of this specification [2] states \"Add user document\".\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/db/migration/README\n[2] https://specs.openstack.org/openstack/tacker-specs/specs/zed/db-migration-tool.html#work-items","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"780ef0dd8e72e80c2d8b567d3c6fc2227f7ae7e0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 06:52:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A DB migration tool for API version update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the DB migration tool which enables DB migration from v1"},{"line_number":10,"context_line":"to v2 API without service outage of the VNF."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"8c5cf640_f8dbc8d8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"222b075a_aa7ecbb4","updated":"2022-09-22 06:43:19.000000000","message":"I added release note in patchset 9.","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b59f6028b1f73f2c2ce4b4014794a73dcebf56f3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 06:52:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A DB migration tool for API version update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the DB migration tool which enables DB migration from v1"},{"line_number":10,"context_line":"to v2 API without service outage of the VNF."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c4d3cc48_c10954d5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"369d5978_598498ec","updated":"2022-09-16 09:55:49.000000000","message":"Yes, a user document is definitely needed.\nIs it ok to add the document with another patch later?","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"01528728f63cd96a9abde05c6f6d512dc2d9b1ff","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 06:52:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A DB migration tool for API version update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the DB migration tool which enables DB migration from v1"},{"line_number":10,"context_line":"to v2 API without service outage of the VNF."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"72335850_f8eb1c74","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"66709dbc_e251a41b","updated":"2022-09-21 10:27:26.000000000","message":"I have added the user docs to doc/source/user/db_migration_tool_usage_guide.rst.","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"8c8cdce4e4c3301eaa2f3e8b213a28e0364929aa","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 06:52:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A DB migration tool for API version update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the DB migration tool which enables DB migration from v1"},{"line_number":10,"context_line":"to v2 API without service outage of the VNF."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9b725434_acd214f5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"71abcf08_6b037b3e","updated":"2022-09-22 04:36:06.000000000","message":"I want to do so if it is ok.","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7741671dc772df7ca1b75d28caeefc961fac2b8d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 06:52:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A DB migration tool for API version update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the DB migration tool which enables DB migration from v1"},{"line_number":10,"context_line":"to v2 API without service outage of the VNF."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"71abcf08_6b037b3e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"72335850_f8eb1c74","updated":"2022-09-21 12:56:27.000000000","message":"Thanks for your update!\nBTW, do you need to add releasenote about this tool?","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c55d84742f82804922a225bd6f7e55e1e467aa2b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 06:52:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A DB migration tool for API version update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the DB migration tool which enables DB migration from v1"},{"line_number":10,"context_line":"to v2 API without service outage of the VNF."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"222b075a_aa7ecbb4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"9b725434_acd214f5","updated":"2022-09-22 05:01:04.000000000","message":"Could you add with next patch set?","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"133588b414ef5a311360dcf440535aa06c389d4a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 06:52:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A DB migration tool for API version update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the DB migration tool which enables DB migration from v1"},{"line_number":10,"context_line":"to v2 API without service outage of the VNF."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f0d80998_c83d8736","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"c4d3cc48_c10954d5","updated":"2022-09-16 10:07:49.000000000","message":"We don\u0027t recommend to separate docs from the codes, but acceptable. However, it\u0027s not included in zed release.","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"4cc9568306692ce8b83c88b7c82e267d4857c07f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Masaki Oyama \u003cma-ooyama@kddi.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-09-16 06:52:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"A DB migration tool for API version update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is the DB migration tool which enables DB migration from v1"},{"line_number":10,"context_line":"to v2 API without service outage of the VNF."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"66709dbc_e251a41b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"f0d80998_c83d8736","updated":"2022-09-16 10:28:49.000000000","message":"Thanks.\nI understand it is not recommended way, but I want to separate the code and docs in another patch.","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4f396d9_a220b854","updated":"2022-09-13 16:36:27.000000000","message":"Thanks for the patch. Please find few comments. Although I am still reviewing will update ASAP.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed8e1581_903000bd","updated":"2022-09-14 07:58:48.000000000","message":"Thanks for your patch, I haven\u0027t seen the details yet, but I have commented on what I noticed at this point.\nPlease kindly find my comments.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e059d4bf5ffb027afe62eab55bc508ba03e490a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8944eaf6_a9164307","updated":"2022-09-15 03:07:39.000000000","message":"I\u0027ve just commented for discussion for opts and will give other comments later. Please ignore if it\u0027s not feasible. Thanks.","commit_id":"a6c6f6f782d739e30efef8fad6c4814e6389c346"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6ca18614_549fb96d","updated":"2022-09-14 10:51:08.000000000","message":"Thank you for your comments.","commit_id":"a6c6f6f782d739e30efef8fad6c4814e6389c346"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a93ceddd_625745d1","updated":"2022-09-14 11:17:58.000000000","message":"Thank you for your comments.","commit_id":"a6c6f6f782d739e30efef8fad6c4814e6389c346"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"20b4dcd313648b2c2da0fca60d51a584b79c18eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e4a20d04_944b16d5","updated":"2022-09-16 04:10:30.000000000","message":"Please revise variable names too long to maintain and drop no need backslashes overall the codes. It makes hard to review and maintain. Thanks!","commit_id":"562c7f46c73a5977e6a40530f42ae45b2fc9abce"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"bba2923a42d77efb71c42870f21d4ea064fc5fb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f300dbd2_331670c4","updated":"2022-09-16 07:24:12.000000000","message":"Thank you for your comments.","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9a655d82be1439af0adc4b8dbf4f5be9b5b135fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b2776c43_7b2d9526","updated":"2022-09-16 16:56:43.000000000","message":"Although the deadline of RC1 is over, I\u0027d suggest to you to include this update to stable/zed as a backport. It\u0027s because the reason of missing the deadline is mainly for unexpected zuul failures. So, I\u0027d also suggest to add docs for which we\u0027ve agreed to introduce as another patch. We can have some more time to do so and it\u0027s better for users. I\u0027d appreciate if you agree with my suggestion. Thanks.","commit_id":"e84163b9a60b8c435f9e65906d627031fb383bfb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"47ccaf1ecfc4070a122376966b223de47e16bb86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a4af54d1_3ac37a10","updated":"2022-09-21 09:13:34.000000000","message":"Any update?","commit_id":"e84163b9a60b8c435f9e65906d627031fb383bfb"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"01528728f63cd96a9abde05c6f6d512dc2d9b1ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0d2b5636_f78d86a2","in_reply_to":"a4af54d1_3ac37a10","updated":"2022-09-21 10:27:26.000000000","message":"Sorry for the late update. I have just added the user docs.","commit_id":"e84163b9a60b8c435f9e65906d627031fb383bfb"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7741671dc772df7ca1b75d28caeefc961fac2b8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8dcf5e61_7c5dc69b","updated":"2022-09-21 12:56:27.000000000","message":"Thanks for your update! Please kindly find my comments.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"8c8cdce4e4c3301eaa2f3e8b213a28e0364929aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e891eebf_07253ef8","updated":"2022-09-22 04:36:06.000000000","message":"Thank you for your quick review.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c55d84742f82804922a225bd6f7e55e1e467aa2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"161878ae_f7c5fade","updated":"2022-09-22 05:01:04.000000000","message":"Thanks for your quick fixes! I have additional tiny comments. Please kindly find it.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"556a4a7971a0c42fefd78c7a58707eb2b790b3b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4c849e2b_8e07dd94","updated":"2022-09-22 13:58:47.000000000","message":"Thanks for your rework! LGTM.","commit_id":"190e69cb7eafcc8ba0e5c11cf258191725cc9f20"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"732e1013ed74f929c6cb5a4fcb419c201b337e3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"dbb2d89c_fc902569","updated":"2022-09-22 10:44:13.000000000","message":"recheck","commit_id":"190e69cb7eafcc8ba0e5c11cf258191725cc9f20"}],"doc/source/user/db_migration_tool_usage_guide.rst":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"70c296b4dd089def86283e2e37e5b3fb32161270","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"How to use the db migration tool that upgrades VNF version from v1 to v2"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"}],"source_content_type":"text/x-rst","patch_set":7,"id":"e30939e3_1483aadf","line":2,"updated":"2022-09-21 17:41:33.000000000","message":"Why don\u0027t you make the title a little bit shorter?\n* Title should be short in general.\n* No need to say \"How to use\".\n* The term \"the db migration tool\" is not appropriate here because it must be \"tacker-db-manage\".","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"8c8cdce4e4c3301eaa2f3e8b213a28e0364929aa","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"How to use the db migration tool that upgrades VNF version from v1 to v2"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"}],"source_content_type":"text/x-rst","patch_set":7,"id":"0cbd2d3c_b9262ccc","line":2,"in_reply_to":"e30939e3_1483aadf","updated":"2022-09-22 04:36:06.000000000","message":"I fixed it to be short.\nAlso fixed the all term of \"the db migration tool\" to \"tacker-db-manage\" in this document.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"70c296b4dd089def86283e2e37e5b3fb32161270","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"--------"},{"line_number":7,"context_line":"Tacker supports multi-version APIs: v1 API based on SOL 003 v2.6.11"},{"line_number":8,"context_line":"and v2 API based on v3.3.12."},{"line_number":9,"context_line":"Because of the lack of compatibility between those versions,"},{"line_number":10,"context_line":"version upgrading usually requires re-instantiation of the VNFs."}],"source_content_type":"text/x-rst","patch_set":7,"id":"e7a3ff03_5ec29a38","line":7,"updated":"2022-09-21 17:41:33.000000000","message":"You should add references for ETSI specification docs. Please refer to other Tacker\u0027s docs as examples.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"8c8cdce4e4c3301eaa2f3e8b213a28e0364929aa","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"--------"},{"line_number":7,"context_line":"Tacker supports multi-version APIs: v1 API based on SOL 003 v2.6.11"},{"line_number":8,"context_line":"and v2 API based on v3.3.12."},{"line_number":9,"context_line":"Because of the lack of compatibility between those versions,"},{"line_number":10,"context_line":"version upgrading usually requires re-instantiation of the VNFs."}],"source_content_type":"text/x-rst","patch_set":7,"id":"218b0611_fc48d6d0","line":7,"in_reply_to":"e7a3ff03_5ec29a38","updated":"2022-09-22 04:36:06.000000000","message":"I fixed it.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"70c296b4dd089def86283e2e37e5b3fb32161270","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Because of the lack of compatibility between those versions,"},{"line_number":10,"context_line":"version upgrading usually requires re-instantiation of the VNFs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"However, by using the DB migration tool, the information on the"},{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"26744a8f_d111c680","line":12,"range":{"start_line":12,"start_character":18,"end_line":12,"end_character":39},"updated":"2022-09-21 17:41:33.000000000","message":"tacker-db-manage, here and below.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"8c8cdce4e4c3301eaa2f3e8b213a28e0364929aa","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Because of the lack of compatibility between those versions,"},{"line_number":10,"context_line":"version upgrading usually requires re-instantiation of the VNFs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"However, by using the DB migration tool, the information on the"},{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"0fb8eb86_27fa9003","line":12,"range":{"start_line":12,"start_character":18,"end_line":12,"end_character":39},"in_reply_to":"26744a8f_d111c680","updated":"2022-09-22 04:36:06.000000000","message":"I fixed it.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7741671dc772df7ca1b75d28caeefc961fac2b8d","unresolved":true,"context_lines":[{"line_number":54,"context_line":"----------------------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"To upgrade from v1 to v2 for a specified VNF"},{"line_number":57,"context_line":"(leaving no records on the existing v1 table):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. code-block:: console"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"969c7f4b_c01171e0","line":57,"updated":"2022-09-21 12:56:27.000000000","message":"How about you write the following note written on Spec?\n\nhttps://specs.openstack.org/openstack/tacker-specs/specs/zed/db-migration-tool.html#tool-execution-method\n\u003e Then records can be deleted completely by executing the ``tacker-db-manage`` command with subcommand of ``purge_deleted``.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c55d84742f82804922a225bd6f7e55e1e467aa2b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"----------------------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"To upgrade from v1 to v2 for a specified VNF"},{"line_number":57,"context_line":"(leaving no records on the existing v1 table):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. code-block:: console"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"0755c476_12937b5d","line":57,"in_reply_to":"48584ea8_b37a7c7f","updated":"2022-09-22 05:01:04.000000000","message":"Ack","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"8c8cdce4e4c3301eaa2f3e8b213a28e0364929aa","unresolved":true,"context_lines":[{"line_number":54,"context_line":"----------------------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"To upgrade from v1 to v2 for a specified VNF"},{"line_number":57,"context_line":"(leaving no records on the existing v1 table):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. code-block:: console"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"48584ea8_b37a7c7f","line":57,"in_reply_to":"969c7f4b_c01171e0","updated":"2022-09-22 04:36:06.000000000","message":"I added those note after the explanation of \"--mark-delete\" option.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7741671dc772df7ca1b75d28caeefc961fac2b8d","unresolved":true,"context_lines":[{"line_number":67,"context_line":".. code-block:: console"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        $ tacker-db-manage --config-file /path/to/tacker.conf \\"},{"line_number":70,"context_line":"        --config-file /path/to/plugin/config.ini migrate-to-v2 --vnf-id \u003cuuid_of_target_vnf\u003e --keep-orig"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"To upgrade from v1 to v2 for all VNFs"},{"line_number":73,"context_line":"(leaving no records on the existing v1 table):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"cf1d251b_305791fc","line":70,"range":{"start_line":70,"start_character":93,"end_line":70,"end_character":104},"updated":"2022-09-21 12:56:27.000000000","message":"I think it is better to describe clearly that user need to run this command with ``--mark-delete`` option after running with ``--keep-orig``.\nWhat do you think?","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c55d84742f82804922a225bd6f7e55e1e467aa2b","unresolved":false,"context_lines":[{"line_number":67,"context_line":".. code-block:: console"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        $ tacker-db-manage --config-file /path/to/tacker.conf \\"},{"line_number":70,"context_line":"        --config-file /path/to/plugin/config.ini migrate-to-v2 --vnf-id \u003cuuid_of_target_vnf\u003e --keep-orig"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"To upgrade from v1 to v2 for all VNFs"},{"line_number":73,"context_line":"(leaving no records on the existing v1 table):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"f93bd789_99ffb1fc","line":70,"range":{"start_line":70,"start_character":93,"end_line":70,"end_character":104},"in_reply_to":"1ba3d2cd_515209ff","updated":"2022-09-22 05:01:04.000000000","message":"Ack","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"8c8cdce4e4c3301eaa2f3e8b213a28e0364929aa","unresolved":true,"context_lines":[{"line_number":67,"context_line":".. code-block:: console"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        $ tacker-db-manage --config-file /path/to/tacker.conf \\"},{"line_number":70,"context_line":"        --config-file /path/to/plugin/config.ini migrate-to-v2 --vnf-id \u003cuuid_of_target_vnf\u003e --keep-orig"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"To upgrade from v1 to v2 for all VNFs"},{"line_number":73,"context_line":"(leaving no records on the existing v1 table):"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1ba3d2cd_515209ff","line":70,"range":{"start_line":70,"start_character":93,"end_line":70,"end_character":104},"in_reply_to":"cf1d251b_305791fc","updated":"2022-09-22 04:36:06.000000000","message":"I wrote that \"--mark-delete\" option is needed to complete/rollback the migration after executing command with \"--keep-orig\" option.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7741671dc772df7ca1b75d28caeefc961fac2b8d","unresolved":true,"context_lines":[{"line_number":141,"context_line":".. code-block:: console"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        $ openstack vnflcm list"},{"line_number":144,"context_line":"        "},{"line_number":145,"context_line":"        $"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":".. note::"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5ccae229_24e320e9","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":9},"updated":"2022-09-21 12:56:27.000000000","message":"I think this is unnecessary, and there is unwanted spaces.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c55d84742f82804922a225bd6f7e55e1e467aa2b","unresolved":false,"context_lines":[{"line_number":141,"context_line":".. code-block:: console"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        $ openstack vnflcm list"},{"line_number":144,"context_line":"        "},{"line_number":145,"context_line":"        $"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":".. note::"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"82cae42b_af5fb931","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":9},"in_reply_to":"16f49f3c_c65eb65b","updated":"2022-09-22 05:01:04.000000000","message":"Ack","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"70c296b4dd089def86283e2e37e5b3fb32161270","unresolved":true,"context_lines":[{"line_number":141,"context_line":".. code-block:: console"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        $ openstack vnflcm list"},{"line_number":144,"context_line":"        "},{"line_number":145,"context_line":"        $"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":".. note::"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"8f1db4c8_1663448a","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":9},"in_reply_to":"5ccae229_24e320e9","updated":"2022-09-21 17:41:33.000000000","message":"It must be corrected because it cause the error of zuul -1.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"8c8cdce4e4c3301eaa2f3e8b213a28e0364929aa","unresolved":true,"context_lines":[{"line_number":141,"context_line":".. code-block:: console"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        $ openstack vnflcm list"},{"line_number":144,"context_line":"        "},{"line_number":145,"context_line":"        $"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":".. note::"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"16f49f3c_c65eb65b","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":9},"in_reply_to":"8f1db4c8_1663448a","updated":"2022-09-22 04:36:06.000000000","message":"I deleted unnecessary \"$\" and the space.","commit_id":"2e17c4ee924cace6857e529c3a34326a74e605dc"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c55d84742f82804922a225bd6f7e55e1e467aa2b","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Because of the lack of compatibility between those versions,"},{"line_number":10,"context_line":"version upgrading usually requires re-instantiation of the VNFs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"However, by using the tacker-db-manage command, the information on the"},{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"d363b120_f62fcd7e","line":12,"range":{"start_line":12,"start_character":22,"end_line":12,"end_character":38},"updated":"2022-09-22 05:01:04.000000000","message":"Could you change to the following?\n```\n:command:`tacker-db-manage`\n```\n\n\u003e https://docs.openstack.org/doc-contrib-guide/rst-conv/inline-markups.html#command","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"c7e536b5045fc7f57a24d83d4471d3779271cf81","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Because of the lack of compatibility between those versions,"},{"line_number":10,"context_line":"version upgrading usually requires re-instantiation of the VNFs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"However, by using the tacker-db-manage command, the information on the"},{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7c50b645_55f8bf2d","line":12,"range":{"start_line":12,"start_character":22,"end_line":12,"end_character":38},"in_reply_to":"54df4305_a4cb0e28","updated":"2022-09-22 07:15:47.000000000","message":"Sorry. I fixed it.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"732e1013ed74f929c6cb5a4fcb419c201b337e3b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Because of the lack of compatibility between those versions,"},{"line_number":10,"context_line":"version upgrading usually requires re-instantiation of the VNFs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"However, by using the tacker-db-manage command, the information on the"},{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"98c7f9b2_4d71ce03","line":12,"range":{"start_line":12,"start_character":22,"end_line":12,"end_character":38},"in_reply_to":"7c50b645_55f8bf2d","updated":"2022-09-22 10:44:13.000000000","message":"Ack","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9561565b3c4248a8291388d4e3769b55795bfdb0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Because of the lack of compatibility between those versions,"},{"line_number":10,"context_line":"version upgrading usually requires re-instantiation of the VNFs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"However, by using the tacker-db-manage command, the information on the"},{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"54df4305_a4cb0e28","line":12,"range":{"start_line":12,"start_character":22,"end_line":12,"end_character":38},"in_reply_to":"9de68502_256ddb4e","updated":"2022-09-22 06:57:14.000000000","message":"Thanks for your updating, but :command: is missing. Could you add it?","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"780ef0dd8e72e80c2d8b567d3c6fc2227f7ae7e0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Because of the lack of compatibility between those versions,"},{"line_number":10,"context_line":"version upgrading usually requires re-instantiation of the VNFs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"However, by using the tacker-db-manage command, the information on the"},{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9de68502_256ddb4e","line":12,"range":{"start_line":12,"start_character":22,"end_line":12,"end_character":38},"in_reply_to":"d363b120_f62fcd7e","updated":"2022-09-22 06:43:19.000000000","message":"I fixed it.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c55d84742f82804922a225bd6f7e55e1e467aa2b","unresolved":true,"context_lines":[{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This document describes how to upgrade VNF using the tacker-db-manage command."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Target tables of migration"},{"line_number":19,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"65b268bd_0e4a87d3","line":16,"range":{"start_line":16,"start_character":53,"end_line":16,"end_character":69},"updated":"2022-09-22 05:01:04.000000000","message":"ditto.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"780ef0dd8e72e80c2d8b567d3c6fc2227f7ae7e0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This document describes how to upgrade VNF using the tacker-db-manage command."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Target tables of migration"},{"line_number":19,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"c6cddfac_a99485d7","line":16,"range":{"start_line":16,"start_character":53,"end_line":16,"end_character":69},"in_reply_to":"65b268bd_0e4a87d3","updated":"2022-09-22 06:43:19.000000000","message":"I fixed it.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"c7e536b5045fc7f57a24d83d4471d3779271cf81","unresolved":true,"context_lines":[{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This document describes how to upgrade VNF using the tacker-db-manage command."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Target tables of migration"},{"line_number":19,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"a0bde3ec_46e5a8af","line":16,"range":{"start_line":16,"start_character":53,"end_line":16,"end_character":69},"in_reply_to":"7bb572f3_054e544f","updated":"2022-09-22 07:15:47.000000000","message":"Sorry. I fixed it.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"732e1013ed74f929c6cb5a4fcb419c201b337e3b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This document describes how to upgrade VNF using the tacker-db-manage command."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Target tables of migration"},{"line_number":19,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b05bbc92_a28cba93","line":16,"range":{"start_line":16,"start_character":53,"end_line":16,"end_character":69},"in_reply_to":"a0bde3ec_46e5a8af","updated":"2022-09-22 10:44:13.000000000","message":"Ack","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9561565b3c4248a8291388d4e3769b55795bfdb0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"v1 API table can be migrated to the v2 API table,"},{"line_number":14,"context_line":"which allows VNF version upgrades without re-instantiation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This document describes how to upgrade VNF using the tacker-db-manage command."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Target tables of migration"},{"line_number":19,"context_line":"--------------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7bb572f3_054e544f","line":16,"range":{"start_line":16,"start_character":53,"end_line":16,"end_character":69},"in_reply_to":"c6cddfac_a99485d7","updated":"2022-09-22 06:57:14.000000000","message":"ditto.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c55d84742f82804922a225bd6f7e55e1e467aa2b","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        --config-file /path/to/plugin/config.ini migrate-to-v2 --all --keep-orig"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"To complete the migration after using the --keep-orig option,"},{"line_number":90,"context_line":"the following command can be used."},{"line_number":91,"context_line":"This command deletes the records for a specified VNF"},{"line_number":92,"context_line":"left on the existing v1 table."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9aaa6c30_e69f6182","line":89,"range":{"start_line":89,"start_character":42,"end_line":89,"end_character":53},"updated":"2022-09-22 05:01:04.000000000","message":"Could you change to the following?\n```\n``--keep-orig``\n```\n\n\u003e https://docs.openstack.org/doc-contrib-guide/rst-conv/inline-markups.html#option","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"780ef0dd8e72e80c2d8b567d3c6fc2227f7ae7e0","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        --config-file /path/to/plugin/config.ini migrate-to-v2 --all --keep-orig"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"To complete the migration after using the --keep-orig option,"},{"line_number":90,"context_line":"the following command can be used."},{"line_number":91,"context_line":"This command deletes the records for a specified VNF"},{"line_number":92,"context_line":"left on the existing v1 table."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ade561ad_a9d3e830","line":89,"range":{"start_line":89,"start_character":42,"end_line":89,"end_character":53},"in_reply_to":"9aaa6c30_e69f6182","updated":"2022-09-22 06:43:19.000000000","message":"I fixed it.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9561565b3c4248a8291388d4e3769b55795bfdb0","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        --config-file /path/to/plugin/config.ini migrate-to-v2 --all --keep-orig"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"To complete the migration after using the --keep-orig option,"},{"line_number":90,"context_line":"the following command can be used."},{"line_number":91,"context_line":"This command deletes the records for a specified VNF"},{"line_number":92,"context_line":"left on the existing v1 table."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9c49b65b_9ff632ba","line":89,"range":{"start_line":89,"start_character":42,"end_line":89,"end_character":53},"in_reply_to":"ade561ad_a9d3e830","updated":"2022-09-22 06:57:14.000000000","message":"Ack","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c55d84742f82804922a225bd6f7e55e1e467aa2b","unresolved":true,"context_lines":[{"line_number":101,"context_line":".. note::"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"       This command just updates the value of the \"deleted\" field to 1."},{"line_number":104,"context_line":"       You can delete records completely by executing the tacker-db-manage"},{"line_number":105,"context_line":"       command with subcommand of purge_deleted."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"To rollback the migration after using the --keep-orig option,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"53b0c6ee_6ec22319","line":104,"range":{"start_line":104,"start_character":58,"end_line":104,"end_character":74},"updated":"2022-09-22 05:01:04.000000000","message":"Could you change to the following?\n```\n:command:`tacker-db-manage`\n```\n\n\u003e https://docs.openstack.org/doc-contrib-guide/rst-conv/inline-markups.html#command","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"c7e536b5045fc7f57a24d83d4471d3779271cf81","unresolved":true,"context_lines":[{"line_number":101,"context_line":".. note::"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"       This command just updates the value of the \"deleted\" field to 1."},{"line_number":104,"context_line":"       You can delete records completely by executing the tacker-db-manage"},{"line_number":105,"context_line":"       command with subcommand of purge_deleted."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"To rollback the migration after using the --keep-orig option,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3dd84cda_2173e42a","line":104,"range":{"start_line":104,"start_character":58,"end_line":104,"end_character":74},"in_reply_to":"1a185477_b403d57e","updated":"2022-09-22 07:15:47.000000000","message":"Sorry. I fixed it.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"732e1013ed74f929c6cb5a4fcb419c201b337e3b","unresolved":false,"context_lines":[{"line_number":101,"context_line":".. note::"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"       This command just updates the value of the \"deleted\" field to 1."},{"line_number":104,"context_line":"       You can delete records completely by executing the tacker-db-manage"},{"line_number":105,"context_line":"       command with subcommand of purge_deleted."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"To rollback the migration after using the --keep-orig option,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"51462572_15c42311","line":104,"range":{"start_line":104,"start_character":58,"end_line":104,"end_character":74},"in_reply_to":"3dd84cda_2173e42a","updated":"2022-09-22 10:44:13.000000000","message":"Ack","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"780ef0dd8e72e80c2d8b567d3c6fc2227f7ae7e0","unresolved":true,"context_lines":[{"line_number":101,"context_line":".. note::"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"       This command just updates the value of the \"deleted\" field to 1."},{"line_number":104,"context_line":"       You can delete records completely by executing the tacker-db-manage"},{"line_number":105,"context_line":"       command with subcommand of purge_deleted."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"To rollback the migration after using the --keep-orig option,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fc27bb5a_3f172d48","line":104,"range":{"start_line":104,"start_character":58,"end_line":104,"end_character":74},"in_reply_to":"53b0c6ee_6ec22319","updated":"2022-09-22 06:43:19.000000000","message":"I fixed it.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9561565b3c4248a8291388d4e3769b55795bfdb0","unresolved":true,"context_lines":[{"line_number":101,"context_line":".. note::"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"       This command just updates the value of the \"deleted\" field to 1."},{"line_number":104,"context_line":"       You can delete records completely by executing the tacker-db-manage"},{"line_number":105,"context_line":"       command with subcommand of purge_deleted."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"To rollback the migration after using the --keep-orig option,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a185477_b403d57e","line":104,"range":{"start_line":104,"start_character":58,"end_line":104,"end_character":74},"in_reply_to":"fc27bb5a_3f172d48","updated":"2022-09-22 06:57:14.000000000","message":"ditto.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c55d84742f82804922a225bd6f7e55e1e467aa2b","unresolved":true,"context_lines":[{"line_number":104,"context_line":"       You can delete records completely by executing the tacker-db-manage"},{"line_number":105,"context_line":"       command with subcommand of purge_deleted."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"To rollback the migration after using the --keep-orig option,"},{"line_number":108,"context_line":"the following command can be used."},{"line_number":109,"context_line":"This command deletes the records for a specified VNF on the v2 table."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"4a230a56_916070c4","line":107,"range":{"start_line":107,"start_character":42,"end_line":107,"end_character":53},"updated":"2022-09-22 05:01:04.000000000","message":"Could you change to the following?\n``--keep-orig``\nhttps://docs.openstack.org/doc-contrib-guide/rst-conv/inline-markups.html#option","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"780ef0dd8e72e80c2d8b567d3c6fc2227f7ae7e0","unresolved":true,"context_lines":[{"line_number":104,"context_line":"       You can delete records completely by executing the tacker-db-manage"},{"line_number":105,"context_line":"       command with subcommand of purge_deleted."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"To rollback the migration after using the --keep-orig option,"},{"line_number":108,"context_line":"the following command can be used."},{"line_number":109,"context_line":"This command deletes the records for a specified VNF on the v2 table."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"d3358940_4d5c9220","line":107,"range":{"start_line":107,"start_character":42,"end_line":107,"end_character":53},"in_reply_to":"4a230a56_916070c4","updated":"2022-09-22 06:43:19.000000000","message":"I fixed it.","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9561565b3c4248a8291388d4e3769b55795bfdb0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"       You can delete records completely by executing the tacker-db-manage"},{"line_number":105,"context_line":"       command with subcommand of purge_deleted."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"To rollback the migration after using the --keep-orig option,"},{"line_number":108,"context_line":"the following command can be used."},{"line_number":109,"context_line":"This command deletes the records for a specified VNF on the v2 table."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"d6df0a37_764034aa","line":107,"range":{"start_line":107,"start_character":42,"end_line":107,"end_character":53},"in_reply_to":"d3358940_4d5c9220","updated":"2022-09-22 06:57:14.000000000","message":"Ack","commit_id":"dee652bbece201d719c8c871ea020a958a99ed52"}],"tacker/db/migration/cli.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":68,"context_line":"CONF.register_cli_opts(_db_opts, \u0027database\u0027)"},{"line_number":69,"context_line":"CONF.register_cli_opts(OPTS, \u0027keystone_authtoken\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def do_alembic_command(config, cmd, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5ffe4c_26c927e5","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":50},"updated":"2022-09-14 07:58:48.000000000","message":"I tried using the tacker-db-manage command and found that it had new options.\n```\nkeystone_authtoken options:\n  --keystone_authtoken-auth_url KEYSTONE_AUTHTOKEN_AUTH_URL\n                        Keystone endpoint\n  --keystone_authtoken-password KEYSTONE_AUTHTOKEN_PASSWORD\n                        User Password\n  --keystone_authtoken-project_domain_id KEYSTONE_AUTHTOKEN_PROJECT_DOMAIN_ID\n                        Project Domain Id\n  --keystone_authtoken-project_domain_name KEYSTONE_AUTHTOKEN_PROJECT_DOMAIN_NAME\n                        Project Domain Name\n  --keystone_authtoken-project_name KEYSTONE_AUTHTOKEN_PROJECT_NAME\n                        Project Name\n  --keystone_authtoken-user_domain_id KEYSTONE_AUTHTOKEN_USER_DOMAIN_ID\n                        User Domain Id\n  --keystone_authtoken-user_domain_name KEYSTONE_AUTHTOKEN_USER_DOMAIN_NAME\n                        Use Domain Name\n  --keystone_authtoken-username KEYSTONE_AUTHTOKEN_USERNAME\n                        User Name\n```\nIs it correct keystone_authtoken to `cli opts`?\nShould this config be gotten from `--config-file /path/to/tacker.conf` like other tacker-db-manage command?","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a0776ad1b617fad4af5ea27cad790ff0dca39fe7","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":68,"context_line":"CONF.register_cli_opts(_db_opts, \u0027database\u0027)"},{"line_number":69,"context_line":"CONF.register_cli_opts(OPTS, \u0027keystone_authtoken\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def do_alembic_command(config, cmd, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f5085ed_963082b4","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":50},"in_reply_to":"2861683d_44590e3d","updated":"2022-09-16 08:27:46.000000000","message":"I\u0027m not familiar with this tool, so I don\u0027t know the ideal shape..\nbut if the user knows how to use it, I think there should be no problem.\n\nWill you add usage guide with another patch?","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"20b4dcd313648b2c2da0fca60d51a584b79c18eb","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":68,"context_line":"CONF.register_cli_opts(_db_opts, \u0027database\u0027)"},{"line_number":69,"context_line":"CONF.register_cli_opts(OPTS, \u0027keystone_authtoken\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def do_alembic_command(config, cmd, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c937fd68_23228dd2","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":50},"in_reply_to":"4117fecf_3cbf77d7","updated":"2022-09-16 04:10:30.000000000","message":"Any update for the suggestion?","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"c52a351267f49fa5930d66cbd40c0b0d459e19f9","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":68,"context_line":"CONF.register_cli_opts(_db_opts, \u0027database\u0027)"},{"line_number":69,"context_line":"CONF.register_cli_opts(OPTS, \u0027keystone_authtoken\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def do_alembic_command(config, cmd, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"8182e965_ce0eec1a","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":50},"in_reply_to":"4117fecf_3cbf77d7","updated":"2022-09-16 03:08:04.000000000","message":"Sorry, I understood that `keystone_authtoken` doesn\u0027t need to be passed from cli option.\nSo I changed it to get from env variables and register it using `register_opts` function.\n\nAnd `keystone_authtoken` is used in migrate_to_v2.py, so move this code from cli.py to migrate_to_v2.py.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e059d4bf5ffb027afe62eab55bc508ba03e490a3","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":68,"context_line":"CONF.register_cli_opts(_db_opts, \u0027database\u0027)"},{"line_number":69,"context_line":"CONF.register_cli_opts(OPTS, \u0027keystone_authtoken\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def do_alembic_command(config, cmd, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"71c7f29f_cb160de3","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":50},"in_reply_to":"55a70d8c_83666dec","updated":"2022-09-15 03:07:39.000000000","message":"Why don\u0027t you to use env variables as similar to `openstack` command? Anyway, I don\u0027t agree to use such a long names mixed with `-` and `_`.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b158607106fd04c709de08cbf89a436008787148","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":68,"context_line":"CONF.register_cli_opts(_db_opts, \u0027database\u0027)"},{"line_number":69,"context_line":"CONF.register_cli_opts(OPTS, \u0027keystone_authtoken\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def do_alembic_command(config, cmd, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4117fecf_3cbf77d7","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":50},"in_reply_to":"71c7f29f_cb160de3","updated":"2022-09-16 02:59:47.000000000","message":"\u003e Yes. The keystone_authtoken information is passed from `--config-file /path/to/tacker.conf` like other tacker-db-manage command.\n\nUmm.. If other commands are the same, I don\u0027t think you need to newly add keystone_authtoken option..","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b59f6028b1f73f2c2ce4b4014794a73dcebf56f3","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":68,"context_line":"CONF.register_cli_opts(_db_opts, \u0027database\u0027)"},{"line_number":69,"context_line":"CONF.register_cli_opts(OPTS, \u0027keystone_authtoken\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def do_alembic_command(config, cmd, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f074ad1_06a73fe0","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":50},"in_reply_to":"7f5085ed_963082b4","updated":"2022-09-16 09:55:49.000000000","message":"Yes.\nIf it is ok, I will add the document with another patch.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":68,"context_line":"CONF.register_cli_opts(_db_opts, \u0027database\u0027)"},{"line_number":69,"context_line":"CONF.register_cli_opts(OPTS, \u0027keystone_authtoken\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def do_alembic_command(config, cmd, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"55a70d8c_83666dec","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":50},"in_reply_to":"ba5ffe4c_26c927e5","updated":"2022-09-14 11:17:58.000000000","message":"Yes. The keystone_authtoken information is passed from `--config-file /path/to/tacker.conf` like other tacker-db-manage command.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"bba2923a42d77efb71c42870f21d4ea064fc5fb4","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":68,"context_line":"CONF.register_cli_opts(_db_opts, \u0027database\u0027)"},{"line_number":69,"context_line":"CONF.register_cli_opts(OPTS, \u0027keystone_authtoken\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def do_alembic_command(config, cmd, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2861683d_44590e3d","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":50},"in_reply_to":"c937fd68_23228dd2","updated":"2022-09-16 07:24:12.000000000","message":"As I wrote above, I fixed the code to get \u0027keystone_authtoken\u0027 information from env variables.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"}],"tacker/db/migration/migrate_to_v2.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"c4703a25_8af23248","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":38},"updated":"2022-09-14 07:58:48.000000000","message":"Could you change to \"2022 \u003cyour company name\u003e\"?","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"f859f06a_1fa32cd9","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":38},"in_reply_to":"c4703a25_8af23248","updated":"2022-09-14 11:17:58.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b158607106fd04c709de08cbf89a436008787148","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"00d656ae_236768fb","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":38},"in_reply_to":"f859f06a_1fa32cd9","updated":"2022-09-16 02:59:47.000000000","message":"Ack","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":true,"context_lines":[{"line_number":38,"context_line":"from tacker.vnfm import vim_client"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"core_opts \u003d ["},{"line_number":42,"context_line":"    cfg.ListOpt(\u0027service_plugins\u0027, default\u003d[\u0027nfvo\u0027, \u0027vnfm\u0027],"},{"line_number":43,"context_line":"                help\u003d_(\"The service plugins Tacker will use\"))]"},{"line_number":44,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":45,"context_line":"CONF \u003d cfg.CONF"},{"line_number":46,"context_line":"CONF.register_opts(core_opts)"},{"line_number":47,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7984c5f6_b3ffc4c8","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":29},"updated":"2022-09-14 07:58:48.000000000","message":"Why do you list service_plugins in core_opts and register core_opts?\n\nSame opt seems to have been already registered in following file:\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/common/config.py#L44-L45","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":true,"context_lines":[{"line_number":38,"context_line":"from tacker.vnfm import vim_client"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"core_opts \u003d ["},{"line_number":42,"context_line":"    cfg.ListOpt(\u0027service_plugins\u0027, default\u003d[\u0027nfvo\u0027, \u0027vnfm\u0027],"},{"line_number":43,"context_line":"                help\u003d_(\"The service plugins Tacker will use\"))]"},{"line_number":44,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":45,"context_line":"CONF \u003d cfg.CONF"},{"line_number":46,"context_line":"CONF.register_opts(core_opts)"},{"line_number":47,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b5bd1e81_2977d626","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":29},"in_reply_to":"7984c5f6_b3ffc4c8","updated":"2022-09-14 11:17:58.000000000","message":"As you said, the service_plugins seems to have been already registered.\nI deleted it.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b158607106fd04c709de08cbf89a436008787148","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from tacker.vnfm import vim_client"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"core_opts \u003d ["},{"line_number":42,"context_line":"    cfg.ListOpt(\u0027service_plugins\u0027, default\u003d[\u0027nfvo\u0027, \u0027vnfm\u0027],"},{"line_number":43,"context_line":"                help\u003d_(\"The service plugins Tacker will use\"))]"},{"line_number":44,"context_line":"CONF \u003d cfg.ConfigOpts()"},{"line_number":45,"context_line":"CONF \u003d cfg.CONF"},{"line_number":46,"context_line":"CONF.register_opts(core_opts)"},{"line_number":47,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"65e86326_e744d516","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":29},"in_reply_to":"b5bd1e81_2977d626","updated":"2022-09-16 02:59:47.000000000","message":"Ack","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        if not mark_delete:"},{"line_number":63,"context_line":"            msg \u003d _(\"--api-ver must be used with --mark-delete\")"},{"line_number":64,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":65,"context_line":"        if api_ver not in [\"v1\", \"v2\"]:"},{"line_number":66,"context_line":"            msg \u003d _(\"v1 or v2 must be specified for --api-ver\")"},{"line_number":67,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9e8f424d_92523766","line":65,"range":{"start_line":65,"start_character":26,"end_line":65,"end_character":27},"updated":"2022-09-14 07:58:48.000000000","message":"Could you change type to `set` instead of `list`?","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":true,"context_lines":[{"line_number":62,"context_line":"        if not mark_delete:"},{"line_number":63,"context_line":"            msg \u003d _(\"--api-ver must be used with --mark-delete\")"},{"line_number":64,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":65,"context_line":"        if api_ver not in [\"v1\", \"v2\"]:"},{"line_number":66,"context_line":"            msg \u003d _(\"v1 or v2 must be specified for --api-ver\")"},{"line_number":67,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c5ed1cb6_a8b70b44","line":65,"range":{"start_line":65,"start_character":26,"end_line":65,"end_character":27},"in_reply_to":"9e8f424d_92523766","updated":"2022-09-14 11:17:58.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b158607106fd04c709de08cbf89a436008787148","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        if not mark_delete:"},{"line_number":63,"context_line":"            msg \u003d _(\"--api-ver must be used with --mark-delete\")"},{"line_number":64,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":65,"context_line":"        if api_ver not in [\"v1\", \"v2\"]:"},{"line_number":66,"context_line":"            msg \u003d _(\"v1 or v2 must be specified for --api-ver\")"},{"line_number":67,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2bbfab96_90c24d20","line":65,"range":{"start_line":65,"start_character":26,"end_line":65,"end_character":27},"in_reply_to":"c5ed1cb6_a8b70b44","updated":"2022-09-16 02:59:47.000000000","message":"Ack","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":true,"context_lines":[{"line_number":82,"context_line":"    objects.register_all()"},{"line_number":83,"context_line":"    objects_v2.register_all()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    CONF.database \u003d tacker_config.database"},{"line_number":86,"context_line":"    CONF.keystone_authtoken \u003d tacker_config.keystone_authtoken"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if mark_delete:"},{"line_number":89,"context_line":"        if api_ver \u003d\u003d \"v1\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"78be7ba2_5115c580","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":62},"updated":"2022-09-14 07:58:48.000000000","message":"Just a question, how does this config assignment work?\nShouldn\u0027t this also be taken from tacker.conf like I commented above about keystone_authtoken opt register?","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"c52a351267f49fa5930d66cbd40c0b0d459e19f9","unresolved":true,"context_lines":[{"line_number":82,"context_line":"    objects.register_all()"},{"line_number":83,"context_line":"    objects_v2.register_all()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    CONF.database \u003d tacker_config.database"},{"line_number":86,"context_line":"    CONF.keystone_authtoken \u003d tacker_config.keystone_authtoken"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if mark_delete:"},{"line_number":89,"context_line":"        if api_ver \u003d\u003d \"v1\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"cca0e81e_5cfb7823","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":62},"in_reply_to":"4265d0fe_10500c4e","updated":"2022-09-16 03:08:04.000000000","message":"I deleted the code `CONF.keystone_authtoken \u003d tacker_config.keystone_authtoken\n` because this information can be passed from env variables above.\n\nBut CONF.database is needed, because the information of database connection created in cli.py need to be used in migrate_to_v2.py.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":true,"context_lines":[{"line_number":82,"context_line":"    objects.register_all()"},{"line_number":83,"context_line":"    objects_v2.register_all()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    CONF.database \u003d tacker_config.database"},{"line_number":86,"context_line":"    CONF.keystone_authtoken \u003d tacker_config.keystone_authtoken"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if mark_delete:"},{"line_number":89,"context_line":"        if api_ver \u003d\u003d \"v1\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"fe4feb44_2a563bbb","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":62},"in_reply_to":"78be7ba2_5115c580","updated":"2022-09-14 11:17:58.000000000","message":"The `database` and `keystone_authtoken` are registered in tacker/db/migration/cli.py, and those configs need to be passed from there.\nSorry, I don\u0027t know match about how to write a code around config process. If there is better way to write it, I would like you to tell me that.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a0776ad1b617fad4af5ea27cad790ff0dca39fe7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    objects.register_all()"},{"line_number":83,"context_line":"    objects_v2.register_all()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    CONF.database \u003d tacker_config.database"},{"line_number":86,"context_line":"    CONF.keystone_authtoken \u003d tacker_config.keystone_authtoken"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if mark_delete:"},{"line_number":89,"context_line":"        if api_ver \u003d\u003d \"v1\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"0b9b56b0_aafc45f6","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":62},"in_reply_to":"cca0e81e_5cfb7823","updated":"2022-09-16 08:27:46.000000000","message":"I understand, thank you.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b158607106fd04c709de08cbf89a436008787148","unresolved":true,"context_lines":[{"line_number":82,"context_line":"    objects.register_all()"},{"line_number":83,"context_line":"    objects_v2.register_all()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    CONF.database \u003d tacker_config.database"},{"line_number":86,"context_line":"    CONF.keystone_authtoken \u003d tacker_config.keystone_authtoken"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    if mark_delete:"},{"line_number":89,"context_line":"        if api_ver \u003d\u003d \"v1\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"4265d0fe_10500c4e","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":62},"in_reply_to":"fe4feb44_2a563bbb","updated":"2022-09-16 02:59:47.000000000","message":"Sorry, I\u0027m not familiar with it either, but it seems that other db-migration commands don\u0027t at least do things like `CONF.database`.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"def _to_scale_status_v2(scale_status_list):"},{"line_number":232,"context_line":"    scale_status_v2_list \u003d list()"},{"line_number":233,"context_line":"    for scale_status in scale_status_list:"},{"line_number":234,"context_line":"        _scale_status \u003d scale_status[\"tacker_object.data\"]"},{"line_number":235,"context_line":"        fields \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"f3c23786_fb281b8b","line":232,"updated":"2022-09-13 16:36:27.000000000","message":"We can use list literal [] as its a bit faster than \"list\" which does require a namespace lookup.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"def _to_scale_status_v2(scale_status_list):"},{"line_number":232,"context_line":"    scale_status_v2_list \u003d list()"},{"line_number":233,"context_line":"    for scale_status in scale_status_list:"},{"line_number":234,"context_line":"        _scale_status \u003d scale_status[\"tacker_object.data\"]"},{"line_number":235,"context_line":"        fields \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"09c19f04_7495aee5","line":232,"in_reply_to":"f3c23786_fb281b8b","updated":"2022-09-14 10:51:08.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":true,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def _to_max_scale_levels(vnf_attributes):"},{"line_number":244,"context_line":"    # NOTE: maxScaleLebels is not defined in SOL003 v2.6.1."},{"line_number":245,"context_line":"    # Related information can be got from vnf_attributes table."},{"line_number":246,"context_line":"    scale_infos_v2 \u003d list()"},{"line_number":247,"context_line":"    for attr in vnf_attributes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9ca3658_e65c2c5c","line":244,"range":{"start_line":244,"start_character":20,"end_line":244,"end_character":26},"updated":"2022-09-14 07:58:48.000000000","message":"typo: Levels","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b158607106fd04c709de08cbf89a436008787148","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def _to_max_scale_levels(vnf_attributes):"},{"line_number":244,"context_line":"    # NOTE: maxScaleLebels is not defined in SOL003 v2.6.1."},{"line_number":245,"context_line":"    # Related information can be got from vnf_attributes table."},{"line_number":246,"context_line":"    scale_infos_v2 \u003d list()"},{"line_number":247,"context_line":"    for attr in vnf_attributes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"61c408e7_aa2cdf77","line":244,"range":{"start_line":244,"start_character":20,"end_line":244,"end_character":26},"in_reply_to":"4724af15_a4648a51","updated":"2022-09-16 02:59:47.000000000","message":"Ack","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":true,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"def _to_max_scale_levels(vnf_attributes):"},{"line_number":244,"context_line":"    # NOTE: maxScaleLebels is not defined in SOL003 v2.6.1."},{"line_number":245,"context_line":"    # Related information can be got from vnf_attributes table."},{"line_number":246,"context_line":"    scale_infos_v2 \u003d list()"},{"line_number":247,"context_line":"    for attr in vnf_attributes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"4724af15_a4648a51","line":244,"range":{"start_line":244,"start_character":20,"end_line":244,"end_character":26},"in_reply_to":"a9ca3658_e65c2c5c","updated":"2022-09-14 11:17:58.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":true,"context_lines":[{"line_number":243,"context_line":"def _to_max_scale_levels(vnf_attributes):"},{"line_number":244,"context_line":"    # NOTE: maxScaleLebels is not defined in SOL003 v2.6.1."},{"line_number":245,"context_line":"    # Related information can be got from vnf_attributes table."},{"line_number":246,"context_line":"    scale_infos_v2 \u003d list()"},{"line_number":247,"context_line":"    for attr in vnf_attributes:"},{"line_number":248,"context_line":"        if attr.key \u003d\u003d \u0027scale_group\u0027:"},{"line_number":249,"context_line":"            val \u003d ast.literal_eval(attr.value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"17207226_f9e92ae4","line":246,"updated":"2022-09-13 16:36:27.000000000","message":"ditto","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":true,"context_lines":[{"line_number":243,"context_line":"def _to_max_scale_levels(vnf_attributes):"},{"line_number":244,"context_line":"    # NOTE: maxScaleLebels is not defined in SOL003 v2.6.1."},{"line_number":245,"context_line":"    # Related information can be got from vnf_attributes table."},{"line_number":246,"context_line":"    scale_infos_v2 \u003d list()"},{"line_number":247,"context_line":"    for attr in vnf_attributes:"},{"line_number":248,"context_line":"        if attr.key \u003d\u003d \u0027scale_group\u0027:"},{"line_number":249,"context_line":"            val \u003d ast.literal_eval(attr.value)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b93cbe5b_272068e2","line":246,"in_reply_to":"17207226_f9e92ae4","updated":"2022-09-14 10:51:08.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":true,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"def _to_ext_cp_info_v2(ext_cp_infos):"},{"line_number":261,"context_line":"    ext_cp_infos_v2 \u003d list()"},{"line_number":262,"context_line":"    for ext_cp_info in ext_cp_infos:"},{"line_number":263,"context_line":"        _ext_cp_info \u003d ext_cp_info[\"tacker_object.data\"]"},{"line_number":264,"context_line":"        # NOTE: Since cpConfigId is not defined in SOL003 v2.6.1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"95e42b39_c5e82f80","line":261,"updated":"2022-09-13 16:36:27.000000000","message":"ditto","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":true,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"def _to_ext_cp_info_v2(ext_cp_infos):"},{"line_number":261,"context_line":"    ext_cp_infos_v2 \u003d list()"},{"line_number":262,"context_line":"    for ext_cp_info in ext_cp_infos:"},{"line_number":263,"context_line":"        _ext_cp_info \u003d ext_cp_info[\"tacker_object.data\"]"},{"line_number":264,"context_line":"        # NOTE: Since cpConfigId is not defined in SOL003 v2.6.1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dcd220b9_910f1cc7","line":261,"in_reply_to":"95e42b39_c5e82f80","updated":"2022-09-14 10:51:08.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":true,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"def _to_cp_protocol_info_v2(cp_protocol_infos):"},{"line_number":282,"context_line":"    cp_protocol_infos_v2 \u003d list()"},{"line_number":283,"context_line":"    for cp_protocol_info in cp_protocol_infos:"},{"line_number":284,"context_line":"        _cp_protocol_info \u003d cp_protocol_info.get(\"tacker_object.data\")"},{"line_number":285,"context_line":"        _ip_over_ethernet \u003d _cp_protocol_info.get(\"ip_over_ethernet\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2a62f7d_b931e06e","line":282,"updated":"2022-09-13 16:36:27.000000000","message":"ditto","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":true,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"def _to_cp_protocol_info_v2(cp_protocol_infos):"},{"line_number":282,"context_line":"    cp_protocol_infos_v2 \u003d list()"},{"line_number":283,"context_line":"    for cp_protocol_info in cp_protocol_infos:"},{"line_number":284,"context_line":"        _cp_protocol_info \u003d cp_protocol_info.get(\"tacker_object.data\")"},{"line_number":285,"context_line":"        _ip_over_ethernet \u003d _cp_protocol_info.get(\"ip_over_ethernet\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"10771c73_69c1a315","line":282,"in_reply_to":"a2a62f7d_b931e06e","updated":"2022-09-14 10:51:08.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":true,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def _to_ip_over_ethernet_address_info_v2_ip_addresses(ip_addresses):"},{"line_number":307,"context_line":"    ip_over_ethernet_address_info_v2_ip_addresses \u003d list()"},{"line_number":308,"context_line":"    for ip_address in ip_addresses:"},{"line_number":309,"context_line":"        _ip_address \u003d ip_address.get(\"tacker_object.data\")"},{"line_number":310,"context_line":"        fields \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"8bbe0d16_a3500d48","line":307,"updated":"2022-09-13 16:36:27.000000000","message":"ditto","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":true,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def _to_ip_over_ethernet_address_info_v2_ip_addresses(ip_addresses):"},{"line_number":307,"context_line":"    ip_over_ethernet_address_info_v2_ip_addresses \u003d list()"},{"line_number":308,"context_line":"    for ip_address in ip_addresses:"},{"line_number":309,"context_line":"        _ip_address \u003d ip_address.get(\"tacker_object.data\")"},{"line_number":310,"context_line":"        fields \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"00c03f77_8110e7a2","line":307,"in_reply_to":"8bbe0d16_a3500d48","updated":"2022-09-14 10:51:08.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":true,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"def _to_ext_virtual_link_info_v2(ext_virtual_link_infos,"},{"line_number":323,"context_line":"                                 vnf_virtual_link_resource_infos, op_occs):"},{"line_number":324,"context_line":"    ext_virtual_link_infos_v2 \u003d list()"},{"line_number":325,"context_line":"    for ext_virtual_link_info in ext_virtual_link_infos:"},{"line_number":326,"context_line":"        _ext_virtual_link_info \u003d \\"},{"line_number":327,"context_line":"            ext_virtual_link_info.get(\"tacker_object.data\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"4fda3e12_7d782b3b","line":324,"updated":"2022-09-13 16:36:27.000000000","message":"ditto","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":true,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"def _to_ext_virtual_link_info_v2(ext_virtual_link_infos,"},{"line_number":323,"context_line":"                                 vnf_virtual_link_resource_infos, op_occs):"},{"line_number":324,"context_line":"    ext_virtual_link_infos_v2 \u003d list()"},{"line_number":325,"context_line":"    for ext_virtual_link_info in ext_virtual_link_infos:"},{"line_number":326,"context_line":"        _ext_virtual_link_info \u003d \\"},{"line_number":327,"context_line":"            ext_virtual_link_info.get(\"tacker_object.data\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"8c6f2dc6_e9b4c71d","line":324,"in_reply_to":"4fda3e12_7d782b3b","updated":"2022-09-14 10:51:08.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":true,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"def _to_ext_link_port_info_v2(ext_vl_id, vnf_vl_res_infos):"},{"line_number":357,"context_line":"    ext_link_port_infos_v2 \u003d list()"},{"line_number":358,"context_line":"    for vnf_vl_res_info in vnf_vl_res_infos:"},{"line_number":359,"context_line":"        _vnf_vl_res_info \u003d vnf_vl_res_info.get(\"tacker_object.data\")"},{"line_number":360,"context_line":"        if _vnf_vl_res_info.get(\"vnf_virtual_link_desc_id\") \u003d\u003d ext_vl_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"12fdc38b_271c09da","line":357,"updated":"2022-09-13 16:36:27.000000000","message":"ditto","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":true,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"def _to_ext_link_port_info_v2(ext_vl_id, vnf_vl_res_infos):"},{"line_number":357,"context_line":"    ext_link_port_infos_v2 \u003d list()"},{"line_number":358,"context_line":"    for vnf_vl_res_info in vnf_vl_res_infos:"},{"line_number":359,"context_line":"        _vnf_vl_res_info \u003d vnf_vl_res_info.get(\"tacker_object.data\")"},{"line_number":360,"context_line":"        if _vnf_vl_res_info.get(\"vnf_virtual_link_desc_id\") \u003d\u003d ext_vl_id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b364d22a_3ca36c81","line":357,"in_reply_to":"12fdc38b_271c09da","updated":"2022-09-14 10:51:08.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":true,"context_lines":[{"line_number":382,"context_line":"    # and the data is passed from InstantiateVnfRequest"},{"line_number":383,"context_line":"    # or ChangeExtVnfConnectivityRequest."},{"line_number":384,"context_line":"    # Therefore this field is created from VnfLcmOpOccs objects"},{"line_number":385,"context_line":"    # whose operaiton is INSTANTIATE or CHANGE_EXT_CONN."},{"line_number":386,"context_line":"    current_vnf_ext_cp_data \u003d list()"},{"line_number":387,"context_line":"    ext_cps \u003d dict()"},{"line_number":388,"context_line":"    _vnf_op_occs \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"b4c33db6_d3aff016","line":385,"range":{"start_line":385,"start_character":12,"end_line":385,"end_character":21},"updated":"2022-09-14 07:58:48.000000000","message":"typo: operation","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":true,"context_lines":[{"line_number":382,"context_line":"    # and the data is passed from InstantiateVnfRequest"},{"line_number":383,"context_line":"    # or ChangeExtVnfConnectivityRequest."},{"line_number":384,"context_line":"    # Therefore this field is created from VnfLcmOpOccs objects"},{"line_number":385,"context_line":"    # whose operaiton is INSTANTIATE or CHANGE_EXT_CONN."},{"line_number":386,"context_line":"    current_vnf_ext_cp_data \u003d list()"},{"line_number":387,"context_line":"    ext_cps \u003d dict()"},{"line_number":388,"context_line":"    _vnf_op_occs \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea55dde5_d77ad8a6","line":385,"range":{"start_line":385,"start_character":12,"end_line":385,"end_character":21},"in_reply_to":"b4c33db6_d3aff016","updated":"2022-09-14 11:17:58.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b158607106fd04c709de08cbf89a436008787148","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    # and the data is passed from InstantiateVnfRequest"},{"line_number":383,"context_line":"    # or ChangeExtVnfConnectivityRequest."},{"line_number":384,"context_line":"    # Therefore this field is created from VnfLcmOpOccs objects"},{"line_number":385,"context_line":"    # whose operaiton is INSTANTIATE or CHANGE_EXT_CONN."},{"line_number":386,"context_line":"    current_vnf_ext_cp_data \u003d list()"},{"line_number":387,"context_line":"    ext_cps \u003d dict()"},{"line_number":388,"context_line":"    _vnf_op_occs \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a61852c_dd728870","line":385,"range":{"start_line":385,"start_character":12,"end_line":385,"end_character":21},"in_reply_to":"ea55dde5_d77ad8a6","updated":"2022-09-16 02:59:47.000000000","message":"Ack","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":true,"context_lines":[{"line_number":383,"context_line":"    # or ChangeExtVnfConnectivityRequest."},{"line_number":384,"context_line":"    # Therefore this field is created from VnfLcmOpOccs objects"},{"line_number":385,"context_line":"    # whose operaiton is INSTANTIATE or CHANGE_EXT_CONN."},{"line_number":386,"context_line":"    current_vnf_ext_cp_data \u003d list()"},{"line_number":387,"context_line":"    ext_cps \u003d dict()"},{"line_number":388,"context_line":"    _vnf_op_occs \u003d \\"},{"line_number":389,"context_line":"        vnf_op_occs.filter(models.VnfLcmOpOccs.operation_state \u003d\u003d \"COMPLETED\","}],"source_content_type":"text/x-python","patch_set":2,"id":"69d958e6_b457ab98","line":386,"updated":"2022-09-13 16:36:27.000000000","message":"ditto","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":true,"context_lines":[{"line_number":383,"context_line":"    # or ChangeExtVnfConnectivityRequest."},{"line_number":384,"context_line":"    # Therefore this field is created from VnfLcmOpOccs objects"},{"line_number":385,"context_line":"    # whose operaiton is INSTANTIATE or CHANGE_EXT_CONN."},{"line_number":386,"context_line":"    current_vnf_ext_cp_data \u003d list()"},{"line_number":387,"context_line":"    ext_cps \u003d dict()"},{"line_number":388,"context_line":"    _vnf_op_occs \u003d \\"},{"line_number":389,"context_line":"        vnf_op_occs.filter(models.VnfLcmOpOccs.operation_state \u003d\u003d \"COMPLETED\","}],"source_content_type":"text/x-python","patch_set":2,"id":"97c9eb7c_2c01bd59","line":386,"in_reply_to":"69d958e6_b457ab98","updated":"2022-09-14 10:51:08.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":true,"context_lines":[{"line_number":384,"context_line":"    # Therefore this field is created from VnfLcmOpOccs objects"},{"line_number":385,"context_line":"    # whose operaiton is INSTANTIATE or CHANGE_EXT_CONN."},{"line_number":386,"context_line":"    current_vnf_ext_cp_data \u003d list()"},{"line_number":387,"context_line":"    ext_cps \u003d dict()"},{"line_number":388,"context_line":"    _vnf_op_occs \u003d \\"},{"line_number":389,"context_line":"        vnf_op_occs.filter(models.VnfLcmOpOccs.operation_state \u003d\u003d \"COMPLETED\","},{"line_number":390,"context_line":"                           models.VnfLcmOpOccs.operation.in_([\"INSTANTIATE\","}],"source_content_type":"text/x-python","patch_set":2,"id":"4bdc61e6_776fc8d7","line":387,"updated":"2022-09-13 16:36:27.000000000","message":"We can use dict literal to declare an empty dictionary.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":true,"context_lines":[{"line_number":384,"context_line":"    # Therefore this field is created from VnfLcmOpOccs objects"},{"line_number":385,"context_line":"    # whose operaiton is INSTANTIATE or CHANGE_EXT_CONN."},{"line_number":386,"context_line":"    current_vnf_ext_cp_data \u003d list()"},{"line_number":387,"context_line":"    ext_cps \u003d dict()"},{"line_number":388,"context_line":"    _vnf_op_occs \u003d \\"},{"line_number":389,"context_line":"        vnf_op_occs.filter(models.VnfLcmOpOccs.operation_state \u003d\u003d \"COMPLETED\","},{"line_number":390,"context_line":"                           models.VnfLcmOpOccs.operation.in_([\"INSTANTIATE\","}],"source_content_type":"text/x-python","patch_set":2,"id":"45a99138_8dfe4f5e","line":387,"in_reply_to":"4bdc61e6_776fc8d7","updated":"2022-09-14 10:51:08.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f564230fe23c2f2d2f8951b91c83c8e37f6ef206","unresolved":true,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"def _to_cp_protocol_data(cp_protocol_data_list):"},{"line_number":422,"context_line":"    _cp_protocol_data_list \u003d list()"},{"line_number":423,"context_line":"    for cp_protocol_data in cp_protocol_data_list:"},{"line_number":424,"context_line":"        fields \u003d {"},{"line_number":425,"context_line":"            \"layerProtocol\": cp_protocol_data.get(\"layerProtocol\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"d7785bb5_f42d964c","line":422,"updated":"2022-09-13 16:36:27.000000000","message":"ditto","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d029d688bf481a91a8db57d01a7cf2e254b35f34","unresolved":true,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"def _to_cp_protocol_data(cp_protocol_data_list):"},{"line_number":422,"context_line":"    _cp_protocol_data_list \u003d list()"},{"line_number":423,"context_line":"    for cp_protocol_data in cp_protocol_data_list:"},{"line_number":424,"context_line":"        fields \u003d {"},{"line_number":425,"context_line":"            \"layerProtocol\": cp_protocol_data.get(\"layerProtocol\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"184e3a3b_27683a7d","line":422,"in_reply_to":"d7785bb5_f42d964c","updated":"2022-09-14 10:51:08.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":true,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"def _to_localization_language(vnf_attributes):"},{"line_number":602,"context_line":"    # NOTE: localizationLanguageis not defined in the v1 InstantiatedVnfInfo."},{"line_number":603,"context_line":"    # Related information can be got from vnf_attributes table."},{"line_number":604,"context_line":"    for attr in vnf_attributes:"},{"line_number":605,"context_line":"        if attr.key \u003d\u003d \u0027param_values\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ab53a4dd_ea218077","line":602,"range":{"start_line":602,"start_character":24,"end_line":602,"end_character":34},"updated":"2022-09-14 07:58:48.000000000","message":"typo: Languages","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b158607106fd04c709de08cbf89a436008787148","unresolved":false,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"def _to_localization_language(vnf_attributes):"},{"line_number":602,"context_line":"    # NOTE: localizationLanguageis not defined in the v1 InstantiatedVnfInfo."},{"line_number":603,"context_line":"    # Related information can be got from vnf_attributes table."},{"line_number":604,"context_line":"    for attr in vnf_attributes:"},{"line_number":605,"context_line":"        if attr.key \u003d\u003d \u0027param_values\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"66430b44_8cddc6ef","line":602,"range":{"start_line":602,"start_character":24,"end_line":602,"end_character":34},"in_reply_to":"634c5aaf_8f888a7b","updated":"2022-09-16 02:59:47.000000000","message":"Ack","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":true,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"def _to_localization_language(vnf_attributes):"},{"line_number":602,"context_line":"    # NOTE: localizationLanguageis not defined in the v1 InstantiatedVnfInfo."},{"line_number":603,"context_line":"    # Related information can be got from vnf_attributes table."},{"line_number":604,"context_line":"    for attr in vnf_attributes:"},{"line_number":605,"context_line":"        if attr.key \u003d\u003d \u0027param_values\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"634c5aaf_8f888a7b","line":602,"range":{"start_line":602,"start_character":24,"end_line":602,"end_character":34},"in_reply_to":"ab53a4dd_ea218077","updated":"2022-09-14 11:17:58.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":true,"context_lines":[{"line_number":1081,"context_line":"            models.VnfLcmOpOccs,"},{"line_number":1082,"context_line":"            read_deleted\u003d\"no\","},{"line_number":1083,"context_line":"            project_only\u003dTrue"},{"line_number":1084,"context_line":"        ). filter(models.VnfLcmOpOccs.vnf_instance_id \u003d\u003d vnf_id)\\"},{"line_number":1085,"context_line":"        .order_by(models.VnfLcmOpOccs.start_time).all()"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"    for _vnf_lcm_op_occ_v1 in _list_vnf_lcm_op_occs_v1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"f429c50d_42098809","line":1084,"range":{"start_line":1084,"start_character":10,"end_line":1084,"end_character":11},"updated":"2022-09-14 07:58:48.000000000","message":"unnecessary space","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b158607106fd04c709de08cbf89a436008787148","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            models.VnfLcmOpOccs,"},{"line_number":1082,"context_line":"            read_deleted\u003d\"no\","},{"line_number":1083,"context_line":"            project_only\u003dTrue"},{"line_number":1084,"context_line":"        ). filter(models.VnfLcmOpOccs.vnf_instance_id \u003d\u003d vnf_id)\\"},{"line_number":1085,"context_line":"        .order_by(models.VnfLcmOpOccs.start_time).all()"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"    for _vnf_lcm_op_occ_v1 in _list_vnf_lcm_op_occs_v1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6d207601_c08fd150","line":1084,"range":{"start_line":1084,"start_character":10,"end_line":1084,"end_character":11},"in_reply_to":"7e8232db_7610454b","updated":"2022-09-16 02:59:47.000000000","message":"Ack","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":true,"context_lines":[{"line_number":1081,"context_line":"            models.VnfLcmOpOccs,"},{"line_number":1082,"context_line":"            read_deleted\u003d\"no\","},{"line_number":1083,"context_line":"            project_only\u003dTrue"},{"line_number":1084,"context_line":"        ). filter(models.VnfLcmOpOccs.vnf_instance_id \u003d\u003d vnf_id)\\"},{"line_number":1085,"context_line":"        .order_by(models.VnfLcmOpOccs.start_time).all()"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"    for _vnf_lcm_op_occ_v1 in _list_vnf_lcm_op_occs_v1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7e8232db_7610454b","line":1084,"range":{"start_line":1084,"start_character":10,"end_line":1084,"end_character":11},"in_reply_to":"f429c50d_42098809","updated":"2022-09-14 11:17:58.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"20b4dcd313648b2c2da0fca60d51a584b79c18eb","unresolved":true,"context_lines":[{"line_number":227,"context_line":"            _to_virtual_storage_resource_info_v2("},{"line_number":228,"context_line":"                inst_info.virtual_storage_resource_info),"},{"line_number":229,"context_line":"        \"vnfcInfo\": _to_vnfc_info_v2(inst_info.vnfc_resource_info)}"},{"line_number":230,"context_line":"    vnf_instance_v2_instantiated_vnf_info \u003d \\"},{"line_number":231,"context_line":"        objects_v2.VnfInstanceV2_InstantiatedVnfInfo(**fields)"},{"line_number":232,"context_line":"    return vnf_instance_v2_instantiated_vnf_info"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"cdbdb733_0b3c9b70","line":230,"range":{"start_line":230,"start_character":4,"end_line":230,"end_character":41},"updated":"2022-09-16 04:10:30.000000000","message":"Is it enough to return `objects_v2.VnfInstanceV2_InstantiatedVnfInfo(**fields)` without using such a long-named variable here?","commit_id":"562c7f46c73a5977e6a40530f42ae45b2fc9abce"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"bba2923a42d77efb71c42870f21d4ea064fc5fb4","unresolved":true,"context_lines":[{"line_number":227,"context_line":"            _to_virtual_storage_resource_info_v2("},{"line_number":228,"context_line":"                inst_info.virtual_storage_resource_info),"},{"line_number":229,"context_line":"        \"vnfcInfo\": _to_vnfc_info_v2(inst_info.vnfc_resource_info)}"},{"line_number":230,"context_line":"    vnf_instance_v2_instantiated_vnf_info \u003d \\"},{"line_number":231,"context_line":"        objects_v2.VnfInstanceV2_InstantiatedVnfInfo(**fields)"},{"line_number":232,"context_line":"    return vnf_instance_v2_instantiated_vnf_info"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"be39fd30_e5d7d93b","line":230,"range":{"start_line":230,"start_character":4,"end_line":230,"end_character":41},"in_reply_to":"cdbdb733_0b3c9b70","updated":"2022-09-16 07:24:12.000000000","message":"I fixed it in patchset5.\nOther similar codes also have been fixed.","commit_id":"562c7f46c73a5977e6a40530f42ae45b2fc9abce"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"20b4dcd313648b2c2da0fca60d51a584b79c18eb","unresolved":true,"context_lines":[{"line_number":357,"context_line":"def _to_ext_virtual_link_info_v2(ext_virtual_link_infos,"},{"line_number":358,"context_line":"                                 vnf_virtual_link_resource_infos, op_occs):"},{"line_number":359,"context_line":"    ext_virtual_link_infos_v2 \u003d []"},{"line_number":360,"context_line":"    for ext_virtual_link_info in ext_virtual_link_infos:"},{"line_number":361,"context_line":"        _ext_virtual_link_info \u003d \\"},{"line_number":362,"context_line":"            ext_virtual_link_info.get(\"tacker_object.data\")"},{"line_number":363,"context_line":"        resource_handle_data \u003d \\"},{"line_number":364,"context_line":"            _ext_virtual_link_info.get(\"resource_handle\").\\"},{"line_number":365,"context_line":"            get(\"tacker_object.data\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5e193a54_87424137","line":362,"range":{"start_line":360,"start_character":0,"end_line":362,"end_character":59},"updated":"2022-09-16 04:10:30.000000000","message":"There are many backslashes because of using long-named variables, but no need to be so long for such a short scope. For example, `ext_virtual_link_info` is enough as `ext_vlink` or so.","commit_id":"562c7f46c73a5977e6a40530f42ae45b2fc9abce"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"bba2923a42d77efb71c42870f21d4ea064fc5fb4","unresolved":true,"context_lines":[{"line_number":357,"context_line":"def _to_ext_virtual_link_info_v2(ext_virtual_link_infos,"},{"line_number":358,"context_line":"                                 vnf_virtual_link_resource_infos, op_occs):"},{"line_number":359,"context_line":"    ext_virtual_link_infos_v2 \u003d []"},{"line_number":360,"context_line":"    for ext_virtual_link_info in ext_virtual_link_infos:"},{"line_number":361,"context_line":"        _ext_virtual_link_info \u003d \\"},{"line_number":362,"context_line":"            ext_virtual_link_info.get(\"tacker_object.data\")"},{"line_number":363,"context_line":"        resource_handle_data \u003d \\"},{"line_number":364,"context_line":"            _ext_virtual_link_info.get(\"resource_handle\").\\"},{"line_number":365,"context_line":"            get(\"tacker_object.data\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5d3601e0_1a4b6442","line":362,"range":{"start_line":360,"start_character":0,"end_line":362,"end_character":59},"in_reply_to":"5e193a54_87424137","updated":"2022-09-16 07:24:12.000000000","message":"I fixed this long-named variables to be short and reduce backslashes.\nOther similar codes also have been fixed.","commit_id":"562c7f46c73a5977e6a40530f42ae45b2fc9abce"}],"tacker/tests/unit/db/test_db_migration_to_v2.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8ca74e561827df0748cb0e00d8e431d1e207ea0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NTT DATA"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"cb481318_4b905b3e","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":29},"updated":"2022-09-14 07:58:48.000000000","message":"Could you change to \"2022 \u003cyour company name\u003e\"?","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b158607106fd04c709de08cbf89a436008787148","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NTT DATA"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"3b17c785_5a53ff53","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":29},"in_reply_to":"0293a687_3cb30590","updated":"2022-09-16 02:59:47.000000000","message":"Ack","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b526128349e132c15b78b5fe581db128285ec8a8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NTT DATA"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"0293a687_3cb30590","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":29},"in_reply_to":"cb481318_4b905b3e","updated":"2022-09-14 11:17:58.000000000","message":"I have fixed it in patchset 3.","commit_id":"cbc5dbecfeeb5740cb76c81aa793c23972a7e519"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"8387c3650d44d463cef2d937466d5ef90dfc7dca","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        vnf_instance_id \u003d self.vnf_instance.id"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        for i in range(record_num):"},{"line_number":247,"context_line":"            id \u003d str(uuid.uuid4())"},{"line_number":248,"context_line":"            tenant_id \u003d str(uuid.uuid4())"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"            vnf_lcm_op_occ_data \u003d fakes_vnflcm.fake_vnf_lcm_op_occs()"}],"source_content_type":"text/x-python","patch_set":3,"id":"329dfbfb_d2b2e01f","line":247,"range":{"start_line":247,"start_character":22,"end_line":247,"end_character":30},"updated":"2022-09-14 14:36:16.000000000","message":"Is there any specific reason for using the uuid package instead of class uuidsentinel [1]?\n\n[1]https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/uuidsentinel.py","commit_id":"a6c6f6f782d739e30efef8fad6c4814e6389c346"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d00ad5f7d0dccd3e15afd1d31fb6381b657608f7","unresolved":true,"context_lines":[{"line_number":244,"context_line":"        vnf_instance_id \u003d self.vnf_instance.id"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        for i in range(record_num):"},{"line_number":247,"context_line":"            id \u003d str(uuid.uuid4())"},{"line_number":248,"context_line":"            tenant_id \u003d str(uuid.uuid4())"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"            vnf_lcm_op_occ_data \u003d fakes_vnflcm.fake_vnf_lcm_op_occs()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ca8744c5_f93acc83","line":247,"range":{"start_line":247,"start_character":22,"end_line":247,"end_character":30},"in_reply_to":"329dfbfb_d2b2e01f","updated":"2022-09-16 02:57:06.000000000","message":"I thought using the uuid package is simple, because generating unique uuid per this point in for loop by using uuidsentinel is a little complicated.\nBut I understood using uuidsentinel is recommended way, so fixed it in patchset 4.","commit_id":"a6c6f6f782d739e30efef8fad6c4814e6389c346"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"8387c3650d44d463cef2d937466d5ef90dfc7dca","unresolved":true,"context_lines":[{"line_number":439,"context_line":"        return vnf_package"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def _create_vnf_instance(self):"},{"line_number":442,"context_line":"        vnf_instance_data \u003d {"},{"line_number":443,"context_line":"            \"vnf_software_version\": \"1.0\","},{"line_number":444,"context_line":"            \"vnf_product_name\": \"test_vnf\","},{"line_number":445,"context_line":"            \"vnf_instance_name\": \u0027test_vnf\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d496cd65_1d0311c5","line":442,"updated":"2022-09-14 14:36:16.000000000","message":"Suggestion, rather defining vnf_instance_data, fakes.py method _get_vnf_instance_data define at [1] can be use. \n\nSecond, would like to know here \"instantiation_state\" is \"INSTANTIATED\", shouldn\u0027t this be \"NOT INSTANTIATED?\n \n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/unit/objects/fakes.py#L218","commit_id":"a6c6f6f782d739e30efef8fad6c4814e6389c346"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"d00ad5f7d0dccd3e15afd1d31fb6381b657608f7","unresolved":true,"context_lines":[{"line_number":439,"context_line":"        return vnf_package"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def _create_vnf_instance(self):"},{"line_number":442,"context_line":"        vnf_instance_data \u003d {"},{"line_number":443,"context_line":"            \"vnf_software_version\": \"1.0\","},{"line_number":444,"context_line":"            \"vnf_product_name\": \"test_vnf\","},{"line_number":445,"context_line":"            \"vnf_instance_name\": \u0027test_vnf\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5edd83e9_59ab9dcc","line":442,"in_reply_to":"d496cd65_1d0311c5","updated":"2022-09-16 02:57:06.000000000","message":"I fixed both points in patchset 4.","commit_id":"a6c6f6f782d739e30efef8fad6c4814e6389c346"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"20b4dcd313648b2c2da0fca60d51a584b79c18eb","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            self._main_test_helper, argv)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_all_option(self):"},{"line_number":66,"context_line":"        argv \u003d [\u0027prog\u0027,"},{"line_number":67,"context_line":"                \u0027migrate-to-v2\u0027,"},{"line_number":68,"context_line":"                \u0027--all\u0027,"},{"line_number":69,"context_line":"                \u0027--vnf-id\u0027,"},{"line_number":70,"context_line":"                \u0027foo\u0027]"},{"line_number":71,"context_line":"        self.assertRaises(exceptions.InvalidInput,"},{"line_number":72,"context_line":"            self._main_test_helper, argv)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        argv \u003d [\u0027prog\u0027,"},{"line_number":75,"context_line":"                \u0027migrate-to-v2\u0027,"},{"line_number":76,"context_line":"                \u0027--all\u0027,"},{"line_number":77,"context_line":"                \u0027--api-ver\u0027,"},{"line_number":78,"context_line":"                \u0027foo\u0027]"},{"line_number":79,"context_line":"        self.assertRaises(exceptions.InvalidInput,"},{"line_number":80,"context_line":"            self._main_test_helper, argv)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        argv \u003d [\u0027prog\u0027,"},{"line_number":83,"context_line":"                \u0027migrate-to-v2\u0027,"},{"line_number":84,"context_line":"                \u0027--all\u0027,"},{"line_number":85,"context_line":"                \u0027--mark-delete\u0027]"},{"line_number":86,"context_line":"        self.assertRaises(exceptions.InvalidInput,"},{"line_number":87,"context_line":"            self._main_test_helper, argv)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        argv \u003d [\u0027prog\u0027,"},{"line_number":90,"context_line":"                \u0027migrate-to-v2\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"679793fa_a0c11fc4","line":87,"range":{"start_line":66,"start_character":0,"end_line":87,"end_character":41},"updated":"2022-09-16 04:10:30.000000000","message":"There are many similar lists and it increases the num of lines unnecessarily here and below. Why don\u0027t you divide into common and extra ones?\n\n```\nargv \u003d [\u0027prog\u0027, \u0027migrate-to-v2\u0027, \u0027--all\u0027]  # common cmd and opts\nself.assertRaises(exceptions.InvalidInput,\n    self._main_test_helper, argv)\nself.assertRaises(exceptions.InvalidInput,\n    self._main_test_helper, argv+[\u0027--api-ver\u0027,\u0027foo\u0027])\nself.assertRaises(exceptions.InvalidInput,\n    self._main_test_helper, argv+[\u0027--mark-delete\u0027])\n...\n```","commit_id":"562c7f46c73a5977e6a40530f42ae45b2fc9abce"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"bba2923a42d77efb71c42870f21d4ea064fc5fb4","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            self._main_test_helper, argv)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_all_option(self):"},{"line_number":66,"context_line":"        argv \u003d [\u0027prog\u0027,"},{"line_number":67,"context_line":"                \u0027migrate-to-v2\u0027,"},{"line_number":68,"context_line":"                \u0027--all\u0027,"},{"line_number":69,"context_line":"                \u0027--vnf-id\u0027,"},{"line_number":70,"context_line":"                \u0027foo\u0027]"},{"line_number":71,"context_line":"        self.assertRaises(exceptions.InvalidInput,"},{"line_number":72,"context_line":"            self._main_test_helper, argv)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        argv \u003d [\u0027prog\u0027,"},{"line_number":75,"context_line":"                \u0027migrate-to-v2\u0027,"},{"line_number":76,"context_line":"                \u0027--all\u0027,"},{"line_number":77,"context_line":"                \u0027--api-ver\u0027,"},{"line_number":78,"context_line":"                \u0027foo\u0027]"},{"line_number":79,"context_line":"        self.assertRaises(exceptions.InvalidInput,"},{"line_number":80,"context_line":"            self._main_test_helper, argv)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        argv \u003d [\u0027prog\u0027,"},{"line_number":83,"context_line":"                \u0027migrate-to-v2\u0027,"},{"line_number":84,"context_line":"                \u0027--all\u0027,"},{"line_number":85,"context_line":"                \u0027--mark-delete\u0027]"},{"line_number":86,"context_line":"        self.assertRaises(exceptions.InvalidInput,"},{"line_number":87,"context_line":"            self._main_test_helper, argv)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        argv \u003d [\u0027prog\u0027,"},{"line_number":90,"context_line":"                \u0027migrate-to-v2\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"abff32b0_b2d1f008","line":87,"range":{"start_line":66,"start_character":0,"end_line":87,"end_character":41},"in_reply_to":"679793fa_a0c11fc4","updated":"2022-09-16 07:24:12.000000000","message":"I defined a common variable, and reuse it to reduce redundant codes.","commit_id":"562c7f46c73a5977e6a40530f42ae45b2fc9abce"}],"tox.ini":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a0776ad1b617fad4af5ea27cad790ff0dca39fe7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"#envlist \u003d py39,py38,py36,pep8,docs"},{"line_number":3,"context_line":"envlist \u003d py38,docs"},{"line_number":4,"context_line":"minversion \u003d 3.18.0"},{"line_number":5,"context_line":"skipsdist \u003d True"},{"line_number":6,"context_line":"ignore_basepython_conflict \u003d True"}],"source_content_type":"text/x-properties","patch_set":5,"id":"44da1fb9_bb203b3a","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":19},"updated":"2022-09-16 08:27:46.000000000","message":"Why did you change here?","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"},{"author":{"_account_id":34107,"name":"Masaki Oyama","email":"ma-ooyama@kddi.com","username":"oyamamasaki"},"change_message_id":"b59f6028b1f73f2c2ce4b4014794a73dcebf56f3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"#envlist \u003d py39,py38,py36,pep8,docs"},{"line_number":3,"context_line":"envlist \u003d py38,docs"},{"line_number":4,"context_line":"minversion \u003d 3.18.0"},{"line_number":5,"context_line":"skipsdist \u003d True"},{"line_number":6,"context_line":"ignore_basepython_conflict \u003d True"}],"source_content_type":"text/x-properties","patch_set":5,"id":"011c4923_97e66383","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":19},"in_reply_to":"44da1fb9_bb203b3a","updated":"2022-09-16 09:55:49.000000000","message":"Sorry, this is just a mistake. I fixed it.","commit_id":"4831db2bef82495abad09098ecbfbca37eefb05a"}]}