)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"98fdb4ca8cba7530d3aa5ce0abb88d2caca6effb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e5bee6fc_b9652c3c","updated":"2022-10-25 00:28:06.000000000","message":"Thank you for your work. Please check my comments.","commit_id":"de170eb5bd11000b828c30c3160eb9e9d7954073"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"b9da10e592e3ef6d14bc89d87462030237d70fd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"53de6ce7_6c6bf10f","updated":"2022-10-11 05:02:47.000000000","message":"recheck - infra failure","commit_id":"de170eb5bd11000b828c30c3160eb9e9d7954073"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"f1396d2b2fccf81a367da9e700ac5446b6aaac18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"822e39ab_7834007b","updated":"2022-10-11 08:11:04.000000000","message":"recheck - infra failure","commit_id":"de170eb5bd11000b828c30c3160eb9e9d7954073"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"3d89c2179d503fd0f39cdb8f988283b92b50a1cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bce125bd_668ae525","updated":"2022-10-25 07:33:50.000000000","message":"Thank you for your comments.\nI fixed them in PS4.\nPlease kindly check them again.","commit_id":"7934e6413a8ac15f042688bbe6b3bc568c152bcc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"38df5a4115d7ab6b6bb5b7c62fb11c11528ca65f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f4d95a2b_9c47dbc7","updated":"2022-10-31 04:31:58.000000000","message":"Hi, is there any possibility other than \"infra failure\" for the reason?","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"be1b8adbd3dc402827b38cdc33191311ffbfbd78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5819a0f3_7f778b84","updated":"2022-11-07 06:38:17.000000000","message":"LGTM","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"39c2b8e9de70a7369e3417865dd0160808d99e72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b7cf32c_c39205a8","updated":"2022-11-04 01:47:27.000000000","message":"Thank you for your re-work. LGTM!","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aa84651da3dea5bf3643afc4eb9a29882e309a17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"002b9c19_deb06641","updated":"2022-10-31 00:23:16.000000000","message":"recheck - infra failure","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"29338de3ef6450d6ecbd35e0a38cb804c09b4f60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5c59a528_ed7d892c","updated":"2022-10-27 04:44:16.000000000","message":"recheck - infra failure","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"da80369abb5bd55b68522fe6d31698d46bd7ff29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"624f21b6_e164395d","updated":"2022-10-26 04:32:39.000000000","message":"recheck - infra failure","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"c26934f3bc075080e741af9c74c8dd823f6a83e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fa065e5_411ee49d","updated":"2022-10-27 00:39:28.000000000","message":"recheck - infra failure","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"e1a299fee45201afcfe4dd88d0a26e91ee542689","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b6a16acf_80e3df3d","updated":"2022-10-31 04:32:13.000000000","message":"recheck - infra failure","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"d7263a982b6adbd3762dd63ff51095ecaa89db24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c2226079_8f42ff4c","updated":"2022-10-27 08:00:19.000000000","message":"recheck - infra failure","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"911a9a0628b9f94e47808923a507fc8635cadec2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a52b6e01_944b6f57","in_reply_to":"f4d95a2b_9c47dbc7","updated":"2022-10-31 04:39:03.000000000","message":"It seems not. It\u0027s not the same FT project that fails every time.","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"214da9605d30efe7d930a3468e7be7b3fed877b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d0181cc1_5da71f18","updated":"2022-11-15 18:24:48.000000000","message":"LGTM, thanks!","commit_id":"97bbbd629cc48d3ce92a7456f97bb7aecb138103"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"67633a470136f2b7db39d10abd758304db90c71e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cda8ef32_891e85e6","updated":"2022-11-15 04:39:38.000000000","message":"To Yasufumi Ogawa:\nThank you for your comments. I fixed them in PS6.\nPlease kindly check them again.","commit_id":"97bbbd629cc48d3ce92a7456f97bb7aecb138103"}],"tacker/sol_refactored/infra_drivers/openstack/heat_utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ef3cf5628d2ae98f3c626af32673dc19105f33ce","unresolved":true,"context_lines":[{"line_number":199,"context_line":"    return get_reses_by_types(heat_reses, [\u0027OS::Neutron::Port\u0027])"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def get_stack_name(inst, stack_id\u003dNone):"},{"line_number":203,"context_line":"    stack_name \u003d f\"vnf-{inst.id}\""},{"line_number":204,"context_line":"    if stack_id:"},{"line_number":205,"context_line":"        return f\"{stack_name}/{stack_id}\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff4558a4_7530af87","line":202,"updated":"2022-11-14 01:27:42.000000000","message":"Why don\u0027t you add a description for the behavior of this function? It has been getting complex and we cannot find which kind of stack name is returned for each case without reading the code itself.","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"67633a470136f2b7db39d10abd758304db90c71e","unresolved":true,"context_lines":[{"line_number":199,"context_line":"    return get_reses_by_types(heat_reses, [\u0027OS::Neutron::Port\u0027])"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def get_stack_name(inst, stack_id\u003dNone):"},{"line_number":203,"context_line":"    stack_name \u003d f\"vnf-{inst.id}\""},{"line_number":204,"context_line":"    if stack_id:"},{"line_number":205,"context_line":"        return f\"{stack_name}/{stack_id}\""}],"source_content_type":"text/x-python","patch_set":5,"id":"0f781f4f_d1073c6a","line":202,"in_reply_to":"ff4558a4_7530af87","updated":"2022-11-15 04:39:38.000000000","message":"I added a description for the behavior of this function in PS6.","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ef3cf5628d2ae98f3c626af32673dc19105f33ce","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    if (inst.obj_attr_is_set(\u0027instantiatedVnfInfo\u0027) and"},{"line_number":207,"context_line":"            inst.instantiatedVnfInfo.obj_attr_is_set(\u0027metadata\u0027) and"},{"line_number":208,"context_line":"            inst.instantiatedVnfInfo.metadata.get(\u0027stack_id\u0027)):"},{"line_number":209,"context_line":"        # If instantiate is executed again after terminate,"},{"line_number":210,"context_line":"        # instantiatedVnfInfo exists, but metadata does not exist, so it needs"},{"line_number":211,"context_line":"        # to check whether metadata exists."},{"line_number":212,"context_line":"        return f\"{stack_name}/{inst.instantiatedVnfInfo.metadata[\u0027stack_id\u0027]}\""},{"line_number":213,"context_line":"    return stack_name"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a43277f9_ecc8ccae","line":211,"range":{"start_line":209,"start_character":8,"end_line":211,"end_character":43},"updated":"2022-11-14 01:27:42.000000000","message":"nit: this comment should be before the condition, and better to be more simple.","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"67633a470136f2b7db39d10abd758304db90c71e","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    if (inst.obj_attr_is_set(\u0027instantiatedVnfInfo\u0027) and"},{"line_number":207,"context_line":"            inst.instantiatedVnfInfo.obj_attr_is_set(\u0027metadata\u0027) and"},{"line_number":208,"context_line":"            inst.instantiatedVnfInfo.metadata.get(\u0027stack_id\u0027)):"},{"line_number":209,"context_line":"        # If instantiate is executed again after terminate,"},{"line_number":210,"context_line":"        # instantiatedVnfInfo exists, but metadata does not exist, so it needs"},{"line_number":211,"context_line":"        # to check whether metadata exists."},{"line_number":212,"context_line":"        return f\"{stack_name}/{inst.instantiatedVnfInfo.metadata[\u0027stack_id\u0027]}\""},{"line_number":213,"context_line":"    return stack_name"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"60bbaff9_dfbe2b20","line":211,"range":{"start_line":209,"start_character":8,"end_line":211,"end_character":43},"in_reply_to":"a43277f9_ecc8ccae","updated":"2022-11-15 04:39:38.000000000","message":"I moved it to the front of the condition and make it simple in PS6.","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ef3cf5628d2ae98f3c626af32673dc19105f33ce","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def get_stack_name(inst, stack_id\u003dNone):"},{"line_number":203,"context_line":"    stack_name \u003d f\"vnf-{inst.id}\""},{"line_number":204,"context_line":"    if stack_id:"},{"line_number":205,"context_line":"        return f\"{stack_name}/{stack_id}\""},{"line_number":206,"context_line":"    if (inst.obj_attr_is_set(\u0027instantiatedVnfInfo\u0027) and"},{"line_number":207,"context_line":"            inst.instantiatedVnfInfo.obj_attr_is_set(\u0027metadata\u0027) and"},{"line_number":208,"context_line":"            inst.instantiatedVnfInfo.metadata.get(\u0027stack_id\u0027)):"},{"line_number":209,"context_line":"        # If instantiate is executed again after terminate,"},{"line_number":210,"context_line":"        # instantiatedVnfInfo exists, but metadata does not exist, so it needs"},{"line_number":211,"context_line":"        # to check whether metadata exists."},{"line_number":212,"context_line":"        return f\"{stack_name}/{inst.instantiatedVnfInfo.metadata[\u0027stack_id\u0027]}\""},{"line_number":213,"context_line":"    return stack_name"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"def get_resource_stack_id(heat_res):"}],"source_content_type":"text/x-python","patch_set":5,"id":"a253d753_ba36102a","line":213,"range":{"start_line":204,"start_character":4,"end_line":213,"end_character":21},"updated":"2022-11-14 01:27:42.000000000","message":"nit: it\u0027s better to use `if elif else` clause for such a case generally.","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"67633a470136f2b7db39d10abd758304db90c71e","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def get_stack_name(inst, stack_id\u003dNone):"},{"line_number":203,"context_line":"    stack_name \u003d f\"vnf-{inst.id}\""},{"line_number":204,"context_line":"    if stack_id:"},{"line_number":205,"context_line":"        return f\"{stack_name}/{stack_id}\""},{"line_number":206,"context_line":"    if (inst.obj_attr_is_set(\u0027instantiatedVnfInfo\u0027) and"},{"line_number":207,"context_line":"            inst.instantiatedVnfInfo.obj_attr_is_set(\u0027metadata\u0027) and"},{"line_number":208,"context_line":"            inst.instantiatedVnfInfo.metadata.get(\u0027stack_id\u0027)):"},{"line_number":209,"context_line":"        # If instantiate is executed again after terminate,"},{"line_number":210,"context_line":"        # instantiatedVnfInfo exists, but metadata does not exist, so it needs"},{"line_number":211,"context_line":"        # to check whether metadata exists."},{"line_number":212,"context_line":"        return f\"{stack_name}/{inst.instantiatedVnfInfo.metadata[\u0027stack_id\u0027]}\""},{"line_number":213,"context_line":"    return stack_name"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"def get_resource_stack_id(heat_res):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9699063d_906cea98","line":213,"range":{"start_line":204,"start_character":4,"end_line":213,"end_character":21},"in_reply_to":"a253d753_ba36102a","updated":"2022-11-15 04:39:38.000000000","message":"I fixed it in PS6.","commit_id":"d8521e2e9d6ff743a5d2516cac0bdffdc0127675"}],"tacker/tests/functional/sol_v2_common/test_vnflcm_basic_common.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"98fdb4ca8cba7530d3aa5ce0abb88d2caca6effb","unresolved":true,"context_lines":[{"line_number":1181,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        # 27. Instantiate VNF again"},{"line_number":1184,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":1185,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":1186,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":1187,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f2929caa_697998a1","line":1184,"updated":"2022-10-25 00:28:06.000000000","message":"IMO, I think it would be better if you write comments why it runs Instantiate VNF again.\n\"# Confirm Re-Instantiation of a VNF that has been terminated.\"","commit_id":"de170eb5bd11000b828c30c3160eb9e9d7954073"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"39c2b8e9de70a7369e3417865dd0160808d99e72","unresolved":false,"context_lines":[{"line_number":1181,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        # 27. Instantiate VNF again"},{"line_number":1184,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":1185,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":1186,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":1187,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d167ad18_87401d0b","line":1184,"in_reply_to":"bafb2335_af11b993","updated":"2022-11-04 01:47:27.000000000","message":"Ack","commit_id":"de170eb5bd11000b828c30c3160eb9e9d7954073"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"3d89c2179d503fd0f39cdb8f988283b92b50a1cb","unresolved":true,"context_lines":[{"line_number":1181,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        # 27. Instantiate VNF again"},{"line_number":1184,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":1185,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":1186,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":1187,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bafb2335_af11b993","line":1184,"in_reply_to":"f2929caa_697998a1","updated":"2022-10-25 07:33:50.000000000","message":"I added this comment in PS4.","commit_id":"de170eb5bd11000b828c30c3160eb9e9d7954073"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"98fdb4ca8cba7530d3aa5ce0abb88d2caca6effb","unresolved":true,"context_lines":[{"line_number":1638,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":1639,"context_line":""},{"line_number":1640,"context_line":"        # 16. Instantiate VNF again"},{"line_number":1641,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":1642,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":1643,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":1644,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"287768e0_a5a7b132","line":1641,"updated":"2022-10-25 00:28:06.000000000","message":"ditto.","commit_id":"de170eb5bd11000b828c30c3160eb9e9d7954073"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"3d89c2179d503fd0f39cdb8f988283b92b50a1cb","unresolved":true,"context_lines":[{"line_number":1638,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":1639,"context_line":""},{"line_number":1640,"context_line":"        # 16. Instantiate VNF again"},{"line_number":1641,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":1642,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":1643,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":1644,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b09adcc6_307dcf8f","line":1641,"in_reply_to":"287768e0_a5a7b132","updated":"2022-10-25 07:33:50.000000000","message":"ditto","commit_id":"de170eb5bd11000b828c30c3160eb9e9d7954073"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"39c2b8e9de70a7369e3417865dd0160808d99e72","unresolved":false,"context_lines":[{"line_number":1638,"context_line":"        self.wait_lcmocc_complete(lcmocc_id)"},{"line_number":1639,"context_line":""},{"line_number":1640,"context_line":"        # 16. Instantiate VNF again"},{"line_number":1641,"context_line":"        resp, body \u003d self.instantiate_vnf_instance(inst_id, instantiate_req)"},{"line_number":1642,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":1643,"context_line":"        self.check_resp_headers_in_operation_task(resp)"},{"line_number":1644,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"e95c89fc_720cc10a","line":1641,"in_reply_to":"b09adcc6_307dcf8f","updated":"2022-11-04 01:47:27.000000000","message":"Ack","commit_id":"de170eb5bd11000b828c30c3160eb9e9d7954073"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d8641a8b4cf615782229d49ea261792fc1473453","unresolved":true,"context_lines":[{"line_number":1168,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":1169,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        # 26. Update vnf"},{"line_number":1172,"context_line":"        if not is_nfvo:"},{"line_number":1173,"context_line":"            update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":1174,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"86eb87c3_a5130d01","line":1171,"updated":"2022-10-25 07:53:20.000000000","message":"Is there a reason you are executing \"update VNF\" after re-instantiating?\nDid you choose this as an API for validating the VNF after re-instantiating?\nIf so, I will recommend scale or heal, which involve stack-update.","commit_id":"7934e6413a8ac15f042688bbe6b3bc568c152bcc"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"be1b8adbd3dc402827b38cdc33191311ffbfbd78","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":1169,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        # 26. Update vnf"},{"line_number":1172,"context_line":"        if not is_nfvo:"},{"line_number":1173,"context_line":"            update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":1174,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff9a3c79_e5908432","line":1171,"in_reply_to":"2c9a5d2f_dd5204c7","updated":"2022-11-07 06:38:17.000000000","message":"Done","commit_id":"7934e6413a8ac15f042688bbe6b3bc568c152bcc"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f2c3e98f7f8914344a567fedc604c2706528b54d","unresolved":true,"context_lines":[{"line_number":1168,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":1169,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        # 26. Update vnf"},{"line_number":1172,"context_line":"        if not is_nfvo:"},{"line_number":1173,"context_line":"            update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":1174,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f036c8c_46d1a878","line":1171,"in_reply_to":"2ca3f84b_ef4701a8","updated":"2022-10-26 00:24:20.000000000","message":"Thank you for the answer, I see.\nBut could you add that in a comment?","commit_id":"7934e6413a8ac15f042688bbe6b3bc568c152bcc"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"977be933ac1a8cb828632452ea02e3f0d887861e","unresolved":true,"context_lines":[{"line_number":1168,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":1169,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        # 26. Update vnf"},{"line_number":1172,"context_line":"        if not is_nfvo:"},{"line_number":1173,"context_line":"            update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":1174,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"2ca3f84b_ef4701a8","line":1171,"in_reply_to":"86eb87c3_a5130d01","updated":"2022-10-25 08:12:27.000000000","message":"Not really. \nFirst, \"update VNF\" happens after terminate and before re-instantiate.\nThe reason why this operation is performed is because in the previous operation, an \"update VNF\" is performed, so that the vnfd_id has changed. When the instantiate is performed again, the new vnfd_id will be used. But instantiation with new package and original request_body fails. So execute \"update VNF\" again to update vnfd_id to the original vnfd_id.","commit_id":"7934e6413a8ac15f042688bbe6b3bc568c152bcc"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"375b8c500355aa435d56eff6efbaecf0f88f9bd6","unresolved":true,"context_lines":[{"line_number":1168,"context_line":"        self.assertEqual(fields.VnfInstanceState.NOT_INSTANTIATED,"},{"line_number":1169,"context_line":"                         body[\u0027instantiationState\u0027])"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        # 26. Update vnf"},{"line_number":1172,"context_line":"        if not is_nfvo:"},{"line_number":1173,"context_line":"            update_req \u003d paramgen.update_vnf_min_with_parameter(self.vnfd_id_1)"},{"line_number":1174,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"2c9a5d2f_dd5204c7","line":1171,"in_reply_to":"9f036c8c_46d1a878","updated":"2022-11-02 01:00:11.000000000","message":"Thank you. I added comment in PS5.","commit_id":"7934e6413a8ac15f042688bbe6b3bc568c152bcc"}]}
