)]}'
{".zuul.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5fbf774fc21f8524f3964f052c6c8bdc4c757d6d","unresolved":true,"context_lines":[{"line_number":455,"context_line":"          KURYR_K8S_API_URL: \"https://{{ hostvars[\u0027controller-k8s\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:${KURYR_K8S_API_PORT}\""},{"line_number":456,"context_line":"          KURYR_K8S_CONTAINERIZED_DEPLOYMENT: false"},{"line_number":457,"context_line":"          KURYR_NEUTRON_DEFAULT_SUBNETPOOL_ID: shared-default-subnetpool-v4"},{"line_number":458,"context_line":"          # NOTES:"},{"line_number":459,"context_line":"          # - In Atelope cycle, Kubernetes version is updated to 1.25."},{"line_number":460,"context_line":"          #   https://blueprints.launchpad.net/tacker/+spec/update-k8s-helm-prometheus"},{"line_number":461,"context_line":"          KURYR_KUBERNETES_VERSION: 1.25.2"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"cfe3e4d9_bb74c59d","line":458,"updated":"2022-11-15 18:23:54.000000000","message":"I\u0027d confirm it\u0027s not a TODO anymore because this bug is not still closed.","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"4157a8cd36ffc36efe159d4783a2368e0f2c3a02","unresolved":true,"context_lines":[{"line_number":455,"context_line":"          KURYR_K8S_API_URL: \"https://{{ hostvars[\u0027controller-k8s\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:${KURYR_K8S_API_PORT}\""},{"line_number":456,"context_line":"          KURYR_K8S_CONTAINERIZED_DEPLOYMENT: false"},{"line_number":457,"context_line":"          KURYR_NEUTRON_DEFAULT_SUBNETPOOL_ID: shared-default-subnetpool-v4"},{"line_number":458,"context_line":"          # NOTES:"},{"line_number":459,"context_line":"          # - In Atelope cycle, Kubernetes version is updated to 1.25."},{"line_number":460,"context_line":"          #   https://blueprints.launchpad.net/tacker/+spec/update-k8s-helm-prometheus"},{"line_number":461,"context_line":"          KURYR_KUBERNETES_VERSION: 1.25.2"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"3e72e82f_80712d91","line":458,"in_reply_to":"9e4c8e67_71d321a6","updated":"2022-11-16 04:36:57.000000000","message":"As a supplement, if Tacker entrusts k8s version management to kuryr-kubernetes, setting KURYR_KUBERNETES_VERSION is unnecessary.","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8b7d2e51df4ef4c2c0cfef4a8219b95ba1c04e52","unresolved":true,"context_lines":[{"line_number":455,"context_line":"          KURYR_K8S_API_URL: \"https://{{ hostvars[\u0027controller-k8s\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:${KURYR_K8S_API_PORT}\""},{"line_number":456,"context_line":"          KURYR_K8S_CONTAINERIZED_DEPLOYMENT: false"},{"line_number":457,"context_line":"          KURYR_NEUTRON_DEFAULT_SUBNETPOOL_ID: shared-default-subnetpool-v4"},{"line_number":458,"context_line":"          # NOTES:"},{"line_number":459,"context_line":"          # - In Atelope cycle, Kubernetes version is updated to 1.25."},{"line_number":460,"context_line":"          #   https://blueprints.launchpad.net/tacker/+spec/update-k8s-helm-prometheus"},{"line_number":461,"context_line":"          KURYR_KUBERNETES_VERSION: 1.25.2"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"9e4c8e67_71d321a6","line":458,"in_reply_to":"cfe3e4d9_bb74c59d","updated":"2022-11-16 01:06:57.000000000","message":"The bug report below has not been updated.\nhttps://bugs.launchpad.net/kuryr-kubernetes/+bug/1968960\n\nBut the patch below fixes the issue.\nCurrently the default k8s version used by kuryr-kubernetes is 1.25.3.\nhttps://review.opendev.org/c/openstack/kuryr-kubernetes/+/861943/2/devstack/settings\n\nTacker team have decided to use k8s 1.25.3 in Antelope, so I added this comment.","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"}],"/COMMIT_MSG":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7ddcfe5196b384df31719bb2e29d345fd698154a","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates the k8s version to 1.25.2 and helm version to 3.10.1."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The following changes have been made in kubernetes 1.24, so this patch"},{"line_number":12,"context_line":"supports them."},{"line_number":13,"context_line":"  - Dockershim Removed from kubelet"},{"line_number":14,"context_line":"  - Service account tokens are no longer auto-generated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"f409b7d7_b2135b56","line":11,"updated":"2022-11-14 04:41:49.000000000","message":"Do you have any plans to update user documents or not?\nIMO, Supported versions and token generations are important for users.","commit_id":"7eeb53d8ba55a68219ea7963dea695d1070891c8"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"fdb88f75c9afdda92a9316a7189c438e75c39de8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates the k8s version to 1.25.2 and helm version to 3.10.1."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The following changes have been made in kubernetes 1.24, so this patch"},{"line_number":12,"context_line":"supports them."},{"line_number":13,"context_line":"  - Dockershim Removed from kubelet"},{"line_number":14,"context_line":"  - Service account tokens are no longer auto-generated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"11ca5e0c_058378aa","line":11,"in_reply_to":"317c3638_a7a75976","updated":"2022-11-14 08:22:03.000000000","message":"Ack","commit_id":"7eeb53d8ba55a68219ea7963dea695d1070891c8"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b357e2435b24b0c9c5e388be5b32f07cb673a7a4","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch updates the k8s version to 1.25.2 and helm version to 3.10.1."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The following changes have been made in kubernetes 1.24, so this patch"},{"line_number":12,"context_line":"supports them."},{"line_number":13,"context_line":"  - Dockershim Removed from kubelet"},{"line_number":14,"context_line":"  - Service account tokens are no longer auto-generated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"317c3638_a7a75976","line":11,"in_reply_to":"f409b7d7_b2135b56","updated":"2022-11-14 05:35:47.000000000","message":"Yes. The document will be updated in another patch.","commit_id":"7eeb53d8ba55a68219ea7963dea695d1070891c8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b357e2435b24b0c9c5e388be5b32f07cb673a7a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"9b37489f_c82f2b53","updated":"2022-11-14 05:35:47.000000000","message":"Thank you for the review.","commit_id":"7eeb53d8ba55a68219ea7963dea695d1070891c8"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7ddcfe5196b384df31719bb2e29d345fd698154a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"c20f403a_61dd52d8","updated":"2022-11-14 04:41:49.000000000","message":"Thank you for your work. Please kindly check my comments.","commit_id":"7eeb53d8ba55a68219ea7963dea695d1070891c8"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"fdb88f75c9afdda92a9316a7189c438e75c39de8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"677d7fb6_88987a1d","updated":"2022-11-14 08:22:03.000000000","message":"Thank you for your re-work! LGTM.","commit_id":"0d741f926dcc06bd8b10dfe56b10128e042cc67b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"8b7d2e51df4ef4c2c0cfef4a8219b95ba1c04e52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"af303271_bc7d2c99","updated":"2022-11-16 01:06:57.000000000","message":"Thank you for the review.","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"10b7a95902a7079b720d3345d51da9312e2997d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"80138a10_cef41f41","updated":"2022-11-18 07:43:58.000000000","message":"Thanks for your patch, LTGM!","commit_id":"3a1ccca97d421c4b5d6d1a14478a72fa4dffc5b3"}],"devstack/local.conf.kubernetes":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5fbf774fc21f8524f3964f052c6c8bdc4c757d6d","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Enable kuryr-kubernetes, crio, octavia"},{"line_number":64,"context_line":"KUBERNETES_VIM\u003dTrue"},{"line_number":65,"context_line":"KURYR_KUBERNETES_VERSION\u003d\"1.25.2\""},{"line_number":66,"context_line":"CONTAINER_ENGINE\u003d\"crio\""},{"line_number":67,"context_line":"CRIO_VERSION\u003d\"1.25\""},{"line_number":68,"context_line":"enable_plugin kuryr-kubernetes https://opendev.org/openstack/kuryr-kubernetes master"}],"source_content_type":"application/octet-stream","patch_set":36,"id":"440e02d8_147e4241","line":65,"updated":"2022-11-15 18:23:54.000000000","message":"Why don\u0027t you add a reason why this version should be 1.25.2, and CRIO_VERSION is 1.25 because it\u0027s helpful for a future update of the values?","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"4157a8cd36ffc36efe159d4783a2368e0f2c3a02","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Enable kuryr-kubernetes, crio, octavia"},{"line_number":64,"context_line":"KUBERNETES_VIM\u003dTrue"},{"line_number":65,"context_line":"KURYR_KUBERNETES_VERSION\u003d\"1.25.2\""},{"line_number":66,"context_line":"CONTAINER_ENGINE\u003d\"crio\""},{"line_number":67,"context_line":"CRIO_VERSION\u003d\"1.25\""},{"line_number":68,"context_line":"enable_plugin kuryr-kubernetes https://opendev.org/openstack/kuryr-kubernetes master"}],"source_content_type":"application/octet-stream","patch_set":36,"id":"7d83fb9f_f87e2387","line":65,"in_reply_to":"440e02d8_147e4241","updated":"2022-11-16 04:36:57.000000000","message":"I will add coments in PS37.","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"}],"roles/setup-k8s-nodes/tasks/main.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5fbf774fc21f8524f3964f052c6c8bdc4c757d6d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"      - overlay"},{"line_number":8,"context_line":"      - br_netfilter"},{"line_number":9,"context_line":"    become: yes"},{"line_number":10,"context_line":"  - name: configure kernel parameter"},{"line_number":11,"context_line":"    sysctl:"},{"line_number":12,"context_line":"      name: \"{{ item }}\""},{"line_number":13,"context_line":"      value: \u00271\u0027"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"6563624e_9315c7bf","line":10,"updated":"2022-11-15 18:23:54.000000000","message":"nit: It\u0027s better to explain what kind of kernel param is configured exactly.","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"4157a8cd36ffc36efe159d4783a2368e0f2c3a02","unresolved":true,"context_lines":[{"line_number":7,"context_line":"      - overlay"},{"line_number":8,"context_line":"      - br_netfilter"},{"line_number":9,"context_line":"    become: yes"},{"line_number":10,"context_line":"  - name: configure kernel parameter"},{"line_number":11,"context_line":"    sysctl:"},{"line_number":12,"context_line":"      name: \"{{ item }}\""},{"line_number":13,"context_line":"      value: \u00271\u0027"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"2e43380f_08c10bb7","line":10,"in_reply_to":"6563624e_9315c7bf","updated":"2022-11-16 04:36:57.000000000","message":"I will fix it in PS37.","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"}],"roles/setup-k8s-oidc/files/create_keycloak.sh":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5fbf774fc21f8524f3964f052c6c8bdc4c757d6d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"podman run -d \\"},{"line_number":4,"context_line":"--net\u003dhost \\"},{"line_number":5,"context_line":"-e KEYCLOAK_ADMIN\u003dadmin -e KEYCLOAK_ADMIN_PASSWORD\u003dadmin \\"},{"line_number":6,"context_line":"-e KC_HTTP_PORT\u003d8080 -e KC_HTTPS_PORT\u003d8443 \\"}],"source_content_type":"text/x-sh","patch_set":36,"id":"74e63297_706a0f31","line":3,"updated":"2022-11-15 18:23:54.000000000","message":"Could you add a reason why it should be replaced in above or commit message? Is it switchable?","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"4157a8cd36ffc36efe159d4783a2368e0f2c3a02","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"podman run -d \\"},{"line_number":4,"context_line":"--net\u003dhost \\"},{"line_number":5,"context_line":"-e KEYCLOAK_ADMIN\u003dadmin -e KEYCLOAK_ADMIN_PASSWORD\u003dadmin \\"},{"line_number":6,"context_line":"-e KC_HTTP_PORT\u003d8080 -e KC_HTTPS_PORT\u003d8443 \\"}],"source_content_type":"text/x-sh","patch_set":36,"id":"70e2eebd_68e01988","line":3,"in_reply_to":"74e63297_706a0f31","updated":"2022-11-16 04:36:57.000000000","message":"This is due to the following change.\n  - Dockershim Removed from kubelet\n\nDockershim has been replaced with CRIO, so \"podman\" is used instead of \"docker\".\nI will fix the commit message in PS37.","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"}],"tools/default-token.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5fbf774fc21f8524f3964f052c6c8bdc4c757d6d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"apiVersion: v1"},{"line_number":2,"context_line":"kind: Secret"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: default-token-k8svim"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"ae617250_98b1535c","line":1,"updated":"2022-11-15 18:23:54.000000000","message":"IMO, it\u0027s better to avoid to put a file other than tool under `tools` directory. Is it feasible to define the contents in `tools/gen_vim_config.sh` directly or not?","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"4157a8cd36ffc36efe159d4783a2368e0f2c3a02","unresolved":true,"context_lines":[{"line_number":1,"context_line":"apiVersion: v1"},{"line_number":2,"context_line":"kind: Secret"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: default-token-k8svim"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"1d2b572d_5b34aa98","line":1,"in_reply_to":"ae617250_98b1535c","updated":"2022-11-16 04:36:57.000000000","message":"I will fix it in PS37.","commit_id":"7db1f1aadf995a3dd2d3966efb7a743aa1839451"}],"tools/gen_vim_config.sh":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"7ddcfe5196b384df31719bb2e29d345fd698154a","unresolved":true,"context_lines":[{"line_number":30,"context_line":"#   Secret token retrieved from kubectl."},{"line_number":31,"context_line":"#######################################"},{"line_number":32,"context_line":"function k8s_token() {"},{"line_number":33,"context_line":"    kubectl create -f default-token.yaml \u0026\u003e/dev/null"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    local _secret\u003d$(kubectl get secret -o jsonpath\u003d\"{.items[0].metadata.name}\")"},{"line_number":36,"context_line":"    echo $(kubectl get secret ${_secret} -o jsonpath\u003d\"{.data.token}\" |"}],"source_content_type":"text/x-sh","patch_set":33,"id":"0b180b06_72223a59","line":33,"updated":"2022-11-14 04:41:49.000000000","message":"Could you add comments to manually register Service account tokens from k8s v1.24?","commit_id":"7eeb53d8ba55a68219ea7963dea695d1070891c8"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"fdb88f75c9afdda92a9316a7189c438e75c39de8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"#   Secret token retrieved from kubectl."},{"line_number":31,"context_line":"#######################################"},{"line_number":32,"context_line":"function k8s_token() {"},{"line_number":33,"context_line":"    kubectl create -f default-token.yaml \u0026\u003e/dev/null"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    local _secret\u003d$(kubectl get secret -o jsonpath\u003d\"{.items[0].metadata.name}\")"},{"line_number":36,"context_line":"    echo $(kubectl get secret ${_secret} -o jsonpath\u003d\"{.data.token}\" |"}],"source_content_type":"text/x-sh","patch_set":33,"id":"8ad7bb59_403346d4","line":33,"in_reply_to":"06fe41ba_d872a674","updated":"2022-11-14 08:22:03.000000000","message":"Ack","commit_id":"7eeb53d8ba55a68219ea7963dea695d1070891c8"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b357e2435b24b0c9c5e388be5b32f07cb673a7a4","unresolved":true,"context_lines":[{"line_number":30,"context_line":"#   Secret token retrieved from kubectl."},{"line_number":31,"context_line":"#######################################"},{"line_number":32,"context_line":"function k8s_token() {"},{"line_number":33,"context_line":"    kubectl create -f default-token.yaml \u0026\u003e/dev/null"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    local _secret\u003d$(kubectl get secret -o jsonpath\u003d\"{.items[0].metadata.name}\")"},{"line_number":36,"context_line":"    echo $(kubectl get secret ${_secret} -o jsonpath\u003d\"{.data.token}\" |"}],"source_content_type":"text/x-sh","patch_set":33,"id":"06fe41ba_d872a674","line":33,"in_reply_to":"0b180b06_72223a59","updated":"2022-11-14 05:35:47.000000000","message":"I\u0027ll add a comment in PS34.","commit_id":"7eeb53d8ba55a68219ea7963dea695d1070891c8"}]}