)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0d021c76be71076c02c41b2636236669276d9db7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Koji Shimizu \u003cshimizu.koji@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-01 15:02:31 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prometheus disk usage monitoring."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring was failed when vnf"},{"line_number":10,"context_line":"package has multiple container. This patch"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba585238_444ed98f","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":37},"updated":"2022-11-07 07:32:23.000000000","message":"Could you delete trailing period following the guideline of git commit message?\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\u003e The first line should be limited to 50 characters and should not end with a period.","commit_id":"52e424e61534024a63b8b71a5202444589909865"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"304fbdc965d94a91a5d02151f9f7bbbebc17fbe9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Koji Shimizu \u003cshimizu.koji@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-01 15:02:31 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prometheus disk usage monitoring."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring was failed when vnf"},{"line_number":10,"context_line":"package has multiple container. This patch"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2c4d92ea_2a3254cd","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":37},"in_reply_to":"ba585238_444ed98f","updated":"2022-11-08 00:08:51.000000000","message":"fixed at patchset 4.","commit_id":"52e424e61534024a63b8b71a5202444589909865"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0d021c76be71076c02c41b2636236669276d9db7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prometheus disk usage monitoring."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring was failed when vnf"},{"line_number":10,"context_line":"package has multiple container. This patch"},{"line_number":11,"context_line":"fixes the PromQL statements created by"},{"line_number":12,"context_line":"prometheus plugin."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1995242"},{"line_number":15,"context_line":"Change-Id: Ifc35b955fbd98b99b3e59722fc97d4632b6d95bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b24af156_af3014c7","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":18},"updated":"2022-11-07 07:32:23.000000000","message":"nit: You can increase the number of characters per line a little more.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\u003e Subsequent lines should be wrapped at 72 characters.","commit_id":"52e424e61534024a63b8b71a5202444589909865"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"304fbdc965d94a91a5d02151f9f7bbbebc17fbe9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prometheus disk usage monitoring."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring was failed when vnf"},{"line_number":10,"context_line":"package has multiple container. This patch"},{"line_number":11,"context_line":"fixes the PromQL statements created by"},{"line_number":12,"context_line":"prometheus plugin."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1995242"},{"line_number":15,"context_line":"Change-Id: Ifc35b955fbd98b99b3e59722fc97d4632b6d95bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9922a5b6_1d705e91","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":18},"in_reply_to":"b24af156_af3014c7","updated":"2022-11-08 00:08:51.000000000","message":"fixed.","commit_id":"52e424e61534024a63b8b71a5202444589909865"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"84b1458d1b8782cf9029e4d4a4ff736c8820dc02","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prometheus disk usage monitoring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring was failed when vnf package has multiple"},{"line_number":10,"context_line":"container. This patch fixes the PromQL statements created by"},{"line_number":11,"context_line":"prometheus plugin."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"68573189_ec841f6c","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":25},"updated":"2022-11-17 11:00:54.000000000","message":"is","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"d950f8c02869ebba0db8bae71d974885ac30b719","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix prometheus disk usage monitoring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring was failed when vnf package has multiple"},{"line_number":10,"context_line":"container. This patch fixes the PromQL statements created by"},{"line_number":11,"context_line":"prometheus plugin."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"00a2f0b8_3421e43c","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":25},"in_reply_to":"68573189_ec841f6c","updated":"2022-11-21 07:20:46.000000000","message":"fixed in PS5","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"84b1458d1b8782cf9029e4d4a4ff736c8820dc02","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix prometheus disk usage monitoring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring was failed when vnf package has multiple"},{"line_number":10,"context_line":"container. This patch fixes the PromQL statements created by"},{"line_number":11,"context_line":"prometheus plugin."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1995242"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b8c1081d_759b60b3","line":11,"range":{"start_line":10,"start_character":11,"end_line":11,"end_character":18},"updated":"2022-11-17 11:00:54.000000000","message":"Could you explain about the fix more exactly? How you fix it?","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"d950f8c02869ebba0db8bae71d974885ac30b719","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix prometheus disk usage monitoring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring was failed when vnf package has multiple"},{"line_number":10,"context_line":"container. This patch fixes the PromQL statements created by"},{"line_number":11,"context_line":"prometheus plugin."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1995242"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0b7c0ca0_0ab6fa71","line":11,"range":{"start_line":10,"start_character":11,"end_line":11,"end_character":18},"in_reply_to":"b8c1081d_759b60b3","updated":"2022-11-21 07:20:46.000000000","message":"fixed in PS5","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25db62864223aed13dde7ccc9a3ff53591e72cde","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix prometheus disk usage monitoring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring is failed when vnf package has multiple"},{"line_number":10,"context_line":"container. Container names are not always obtained in tacker."},{"line_number":11,"context_line":"However, some PromQL statements have dependency on container name."},{"line_number":12,"context_line":"This patch removes the dependency."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"eeacd133_24dfe563","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":41},"updated":"2022-11-25 05:37:38.000000000","message":"nits. Is it correct to say always?\nI suppose the Tacker basically can\u0027t obtain container name directly.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"5d39808efb1ba57b0b2cb58bf5caa539304cf755","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix prometheus disk usage monitoring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring is failed when vnf package has multiple"},{"line_number":10,"context_line":"container. Container names are not always obtained in tacker."},{"line_number":11,"context_line":"However, some PromQL statements have dependency on container name."},{"line_number":12,"context_line":"This patch removes the dependency."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"a3f3db8c_dd06c175","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":41},"in_reply_to":"199dd14e_4fec3adc","updated":"2022-11-30 01:51:06.000000000","message":"Done","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"0debd91e79c3b9292a3f7d0cb6774a02ff570e9d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix prometheus disk usage monitoring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disk usage monitoring is failed when vnf package has multiple"},{"line_number":10,"context_line":"container. Container names are not always obtained in tacker."},{"line_number":11,"context_line":"However, some PromQL statements have dependency on container name."},{"line_number":12,"context_line":"This patch removes the dependency."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"199dd14e_4fec3adc","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":41},"in_reply_to":"eeacd133_24dfe563","updated":"2022-11-28 10:09:36.000000000","message":"Wording changed.\n\"Container names are not always obtained in tacker.\" -\u003e \"Container names can not be obtained in tacker.\"","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"22e12efb3d10510e6bb5317ec580012ffc12b236","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2959a3bd_2f0a6fa1","updated":"2022-11-02 10:50:16.000000000","message":"Please kindly review this patch.","commit_id":"52e424e61534024a63b8b71a5202444589909865"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"5c2b157c69452282de6c661c691b612269290c0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"67837726_d39282fe","updated":"2022-11-07 05:23:01.000000000","message":"Thank you for your great work. LGTM!","commit_id":"52e424e61534024a63b8b71a5202444589909865"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0d021c76be71076c02c41b2636236669276d9db7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc6c7e95_e67b321b","updated":"2022-11-07 07:32:23.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"52e424e61534024a63b8b71a5202444589909865"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"3c1d1ad40674d3a409dfc686eca4f5ad689f5d35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"08890b09_38295348","updated":"2022-11-01 23:50:09.000000000","message":"recheck due to infra down","commit_id":"52e424e61534024a63b8b71a5202444589909865"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"304fbdc965d94a91a5d02151f9f7bbbebc17fbe9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bb5ee9e8_4aa93949","updated":"2022-11-08 00:08:51.000000000","message":"Thank you for your review.","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"457ff3434ac8bb396487b43bf31aecd15c2cf23d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63366a3e_d37d318c","updated":"2022-11-08 07:18:10.000000000","message":"Thanks for your rework, LGTM.","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"d950f8c02869ebba0db8bae71d974885ac30b719","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"35679eb1_3f8e4b3e","updated":"2022-11-21 07:20:46.000000000","message":"Thank you very much for your review.","commit_id":"93b5484cf58edefa735c0dfa6180c50b0a48976d"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"5ba064aa934e9147c06fdee3b023496ca9a74c82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d0ea3e8d_f565fbd3","updated":"2022-11-21 10:32:43.000000000","message":"recheck\nNov 21 07:34:06.488534 ubuntu-focal-rax-iad-0032146107 tacker-conductor[51393]: 2022-11-21 07:34:06.488 WARNING tacker.objects.vnfd [req-27a7facd-a148-4f06-8d5d-7d459368b80c nfv_user nfv] delete vnfd failed: oslo_db.exception.DBReferenceError: (pymysql.err.IntegrityError) (1451, \u0027Cannot delete or update a parent row: a foreign key constraint fails (`tacker`.`vnf`, CONSTRAINT `vnf_ibfk_1` FOREIGN KEY (`vnfd_id`) REFERENCES `vnfd` (`id`))\u0027)\n","commit_id":"93b5484cf58edefa735c0dfa6180c50b0a48976d"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"5a47e6b1bd55c9e7e9d1d4d3febf842b3fdd242f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"09d5ed3b_554a112f","updated":"2022-11-21 14:24:48.000000000","message":"recheck tacker.tests.functional.sol_kubernetes_v2.test_vnflcm_basic.VnfLcmKubernetesTest.test_scale_out_rollback","commit_id":"93b5484cf58edefa735c0dfa6180c50b0a48976d"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"55a723dd49785687a05bc2556319c01326698d12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f204dedc_b6ff1357","updated":"2022-11-24 01:48:48.000000000","message":"I set the topic bug/1995242.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":31668},"change_message_id":"f18d6b554a7e6916c27d42fa19f4d35d41694adf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"62e5b1c8_6b8caf5d","updated":"2022-11-24 02:47:17.000000000","message":"LGTM","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":31668},"change_message_id":"894eb7a4c6e546f5bfbf8132a3a941903817aca0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"714e7132_2f172f7e","updated":"2022-11-24 00:31:38.000000000","message":"Please describe the following in the Topic.\nbug/1995242","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"c35ea389cace23e24fde2886add03ae2e6bcc667","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"927b0363_3e6cc849","updated":"2022-11-25 05:33:24.000000000","message":"Thank you for the patch\nPlease kindly find my comments.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25db62864223aed13dde7ccc9a3ff53591e72cde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"44fca47f_72757bf6","updated":"2022-11-25 05:37:38.000000000","message":"Thank you for the patch. Please kindly find my comments.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"5fd608caf748618e6647a5ab0c026c93425c57a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"06cc617f_3d169c05","updated":"2022-11-22 08:30:37.000000000","message":"Thank you very much for the review.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"fc7aee31540335ea59a6f3a6e7854618f4c48461","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"273fbdb5_f377e691","updated":"2022-11-25 07:23:05.000000000","message":"Thank you very much for your comment.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":31668},"change_message_id":"f18d6b554a7e6916c27d42fa19f4d35d41694adf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"19d8b5f0_4658a15c","in_reply_to":"64e62a68_2f79f8cc","updated":"2022-11-24 02:47:17.000000000","message":"Done","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"55a723dd49785687a05bc2556319c01326698d12","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"64e62a68_2f79f8cc","in_reply_to":"714e7132_2f172f7e","updated":"2022-11-24 01:48:48.000000000","message":"the topic is set.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"6bd5a457bd5d4a43541debef52efaf57a9f61fde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"87db792f_be29cb63","updated":"2022-11-30 07:23:24.000000000","message":"LGTM","commit_id":"c0ac36434fd21e9811994520fe7d8347b1a6763c"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"5d39808efb1ba57b0b2cb58bf5caa539304cf755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"907317b3_4ec47de1","updated":"2022-11-30 01:51:06.000000000","message":"LGTM","commit_id":"c0ac36434fd21e9811994520fe7d8347b1a6763c"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"0debd91e79c3b9292a3f7d0cb6774a02ff570e9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"00164ed2_73e1b945","updated":"2022-11-28 10:09:36.000000000","message":"Thank you very much for your review.","commit_id":"c0ac36434fd21e9811994520fe7d8347b1a6763c"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"00998bc0e73ba8f3c20ed07151d6e876b7479004","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"30335a15_bfe7e767","updated":"2022-12-07 00:21:57.000000000","message":"recheck _heal_sol_003_vnf_instance timed out.","commit_id":"290e23971e233dbc2a018b7d998b2a332fa9bf38"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"434d774e91def733d72ce49347d2194b4122b7be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2d9e074f_1993c8dd","updated":"2022-12-05 11:46:34.000000000","message":"recheck https://forge.etsi.org/ is temporally down.","commit_id":"290e23971e233dbc2a018b7d998b2a332fa9bf38"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"672faa4b8dbe96fb2f00902c65638114896e5400","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"281ecf5a_1a6563e3","updated":"2022-12-11 03:31:13.000000000","message":"recheck AssertionError: \u0027vdu1-update-5b9d95d894-grh44\u0027 \u003d\u003d \u0027vdu1-update-5b9d95d894-grh44\u0027","commit_id":"e491c60e161099a966ecffc60980d5784b72b42b"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"6454bdf9e657a24932b90df7f1bb5bbec47b8c4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4d5714f6_4c45090e","updated":"2022-12-10 07:15:56.000000000","message":"recheck AssertionError: LCM incomplete timeout, aa8cfdf3-fcb9-45b7-b9b8-fae3c1da523a is FAILED_TEMP,expected status should be COMPLETED","commit_id":"e491c60e161099a966ecffc60980d5784b72b42b"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"7f85f527e4249726a34ad51c5247cbace6849bf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"75af51ff_dc9f3725","updated":"2022-12-11 00:23:13.000000000","message":"recheck AssertionError: LCM incomplete timeout, f0815a6e-f78e-40fe-ab98-533a235587bf is FAILED_TEMP,expected status should be COMPLETED","commit_id":"e491c60e161099a966ecffc60980d5784b72b42b"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"0151efe1c23bf1e2b371e95b59ce5b4dc391d6c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f3810196_f3d94f89","updated":"2022-12-10 14:34:58.000000000","message":"recheck Exception: Failed to wait vnf instance, process could not be completed within 720 seconds","commit_id":"e491c60e161099a966ecffc60980d5784b72b42b"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"2438039017f2ba45a1040ef84afb6c20d6f84d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"037972be_79bcae3d","updated":"2022-12-09 00:24:10.000000000","message":"recheck configparser.DuplicateOptionError: While reading from \u0027\u003cstring\u003e\u0027 [line 41]: option \u0027root\u0027 in section \u0027testenv:dsvm-functional-legacy\u0027 already exists","commit_id":"e491c60e161099a966ecffc60980d5784b72b42b"}],"doc/source/user/prometheus_plugin_use_case_guide.rst":[{"author":{"_account_id":31668},"change_message_id":"380f5424cc022a00e9ca2a52ecef68beafcfed7e","unresolved":true,"context_lines":[{"line_number":263,"context_line":"            \"performanceMetric\": ["},{"line_number":264,"context_line":"                \"VCpuUsageMeanVnf.507280d8-bfc5-4b88-904b-9280ba6bc3ea\"],"},{"line_number":265,"context_line":"            \"collectionPeriod\": 30,"},{"line_number":266,"context_line":"            \"reportingPeriod\": 90,"},{"line_number":267,"context_line":"            \"reportingBoundary\": \"2099-08-05T02:24:46Z\""},{"line_number":268,"context_line":"        },"},{"line_number":269,"context_line":"        \"callbackUri\": \"\u003cclient_callback_uri\u003e\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"3cedf8f7_3ff84066","line":266,"updated":"2022-11-17 05:36:30.000000000","message":"What made you fix it to 90?\nThe default seems to be 60 as per L.302 of prometheus_plugin.py. \nHave you considered whether it is better to modify the default to 90 as well?\n(If you\u0027ve already considered and modified the sample, there\u0027s no problem.)","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":31668},"change_message_id":"c032dd2f99c87f01a5a543446aec345c0285e1ad","unresolved":true,"context_lines":[{"line_number":263,"context_line":"            \"performanceMetric\": ["},{"line_number":264,"context_line":"                \"VCpuUsageMeanVnf.507280d8-bfc5-4b88-904b-9280ba6bc3ea\"],"},{"line_number":265,"context_line":"            \"collectionPeriod\": 30,"},{"line_number":266,"context_line":"            \"reportingPeriod\": 90,"},{"line_number":267,"context_line":"            \"reportingBoundary\": \"2099-08-05T02:24:46Z\""},{"line_number":268,"context_line":"        },"},{"line_number":269,"context_line":"        \"callbackUri\": \"\u003cclient_callback_uri\u003e\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"52742e17_89e7d3f5","line":266,"in_reply_to":"3cedf8f7_3ff84066","updated":"2022-11-22 06:24:56.000000000","message":"Have you checked the comment above?","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"5fd608caf748618e6647a5ab0c026c93425c57a9","unresolved":true,"context_lines":[{"line_number":263,"context_line":"            \"performanceMetric\": ["},{"line_number":264,"context_line":"                \"VCpuUsageMeanVnf.507280d8-bfc5-4b88-904b-9280ba6bc3ea\"],"},{"line_number":265,"context_line":"            \"collectionPeriod\": 30,"},{"line_number":266,"context_line":"            \"reportingPeriod\": 90,"},{"line_number":267,"context_line":"            \"reportingBoundary\": \"2099-08-05T02:24:46Z\""},{"line_number":268,"context_line":"        },"},{"line_number":269,"context_line":"        \"callbackUri\": \"\u003cclient_callback_uri\u003e\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"72c10701_48382ac9","line":266,"in_reply_to":"52742e17_89e7d3f5","updated":"2022-11-22 08:30:37.000000000","message":"I\u0027m sorry I didnt noticed.\nI think 60 is too short for the default value, because some promQL statements uses range-vector (i.e. https://prometheus.io/docs/prometheus/latest/querying/functions/#rate).\nThat means, To calcurate rate(), prometheus needs multiple samples for a single metrics. That needs longer period of time.","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":31668},"change_message_id":"e7475681048bc6a3f3a13aa8d63c58375a9ce2db","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            \"performanceMetric\": ["},{"line_number":264,"context_line":"                \"VCpuUsageMeanVnf.507280d8-bfc5-4b88-904b-9280ba6bc3ea\"],"},{"line_number":265,"context_line":"            \"collectionPeriod\": 30,"},{"line_number":266,"context_line":"            \"reportingPeriod\": 90,"},{"line_number":267,"context_line":"            \"reportingBoundary\": \"2099-08-05T02:24:46Z\""},{"line_number":268,"context_line":"        },"},{"line_number":269,"context_line":"        \"callbackUri\": \"\u003cclient_callback_uri\u003e\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"a669a9a1_3bb779f8","line":266,"in_reply_to":"72c10701_48382ac9","updated":"2022-11-22 08:56:51.000000000","message":"Done","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"84b1458d1b8782cf9029e4d4a4ff736c8820dc02","unresolved":true,"context_lines":[{"line_number":293,"context_line":"    With the parameter, pod name can be specified but container name can not."},{"line_number":294,"context_line":"    And some prometheus metrics need container name. Therefore, ``max``"},{"line_number":295,"context_line":"    statement of PromQL is alternatively used in some measurements to"},{"line_number":296,"context_line":"    measure without container name. For example:"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    ``avg(max(container_fs_usage_bytes{pod\u003d~\"pod name\"} /"},{"line_number":299,"context_line":"    container_fs_limit_bytes{pod\u003d~\"pod name\"}))``"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"ETSI NFV-SOL 002/003 based Fault Management"},{"line_number":302,"context_line":"-------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"8314fc6c_1f804893","line":299,"range":{"start_line":296,"start_character":37,"end_line":299,"end_character":49},"updated":"2022-11-17 11:00:54.000000000","message":"Is it necessary to show this example here?","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"d950f8c02869ebba0db8bae71d974885ac30b719","unresolved":true,"context_lines":[{"line_number":293,"context_line":"    With the parameter, pod name can be specified but container name can not."},{"line_number":294,"context_line":"    And some prometheus metrics need container name. Therefore, ``max``"},{"line_number":295,"context_line":"    statement of PromQL is alternatively used in some measurements to"},{"line_number":296,"context_line":"    measure without container name. For example:"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    ``avg(max(container_fs_usage_bytes{pod\u003d~\"pod name\"} /"},{"line_number":299,"context_line":"    container_fs_limit_bytes{pod\u003d~\"pod name\"}))``"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"ETSI NFV-SOL 002/003 based Fault Management"},{"line_number":302,"context_line":"-------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"04ea2d19_12e7335c","line":299,"range":{"start_line":296,"start_character":37,"end_line":299,"end_character":49},"in_reply_to":"8314fc6c_1f804893","updated":"2022-11-21 07:20:46.000000000","message":"This explains how PM-job request creates PromQL statement.\nI beleve it helps user\u0027s understanding.","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25db62864223aed13dde7ccc9a3ff53591e72cde","unresolved":true,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    route:"},{"line_number":201,"context_line":"      group_by:"},{"line_number":202,"context_line":"        - \"kubestatemetrics\""},{"line_number":203,"context_line":"        - \"k8smetricsresourceworker1\""},{"line_number":204,"context_line":"        - \"k8smetricscadvisorworker1\""},{"line_number":205,"context_line":"        - \"k8smetricsresourceworker2\""}],"source_content_type":"text/x-rst","patch_set":6,"id":"78107cf2_92d4ef39","line":202,"updated":"2022-11-25 05:37:38.000000000","message":"What is the reason for adding this line?","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"5d39808efb1ba57b0b2cb58bf5caa539304cf755","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    route:"},{"line_number":201,"context_line":"      group_by:"},{"line_number":202,"context_line":"        - \"kubestatemetrics\""},{"line_number":203,"context_line":"        - \"k8smetricsresourceworker1\""},{"line_number":204,"context_line":"        - \"k8smetricscadvisorworker1\""},{"line_number":205,"context_line":"        - \"k8smetricsresourceworker2\""}],"source_content_type":"text/x-rst","patch_set":6,"id":"76cde46a_63388377","line":202,"in_reply_to":"70867451_c8ccbcb5","updated":"2022-11-30 01:51:06.000000000","message":"Done","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"0debd91e79c3b9292a3f7d0cb6774a02ff570e9d","unresolved":true,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    route:"},{"line_number":201,"context_line":"      group_by:"},{"line_number":202,"context_line":"        - \"kubestatemetrics\""},{"line_number":203,"context_line":"        - \"k8smetricsresourceworker1\""},{"line_number":204,"context_line":"        - \"k8smetricscadvisorworker1\""},{"line_number":205,"context_line":"        - \"k8smetricsresourceworker2\""}],"source_content_type":"text/x-rst","patch_set":6,"id":"70867451_c8ccbcb5","line":202,"in_reply_to":"78107cf2_92d4ef39","updated":"2022-11-28 10:09:36.000000000","message":"This needs to point the value of L.170. But it was missing.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25db62864223aed13dde7ccc9a3ff53591e72cde","unresolved":true,"context_lines":[{"line_number":263,"context_line":"            \"performanceMetric\": ["},{"line_number":264,"context_line":"                \"VCpuUsageMeanVnf.507280d8-bfc5-4b88-904b-9280ba6bc3ea\"],"},{"line_number":265,"context_line":"            \"collectionPeriod\": 30,"},{"line_number":266,"context_line":"            \"reportingPeriod\": 90,"},{"line_number":267,"context_line":"            \"reportingBoundary\": \"2099-08-05T02:24:46Z\""},{"line_number":268,"context_line":"        },"},{"line_number":269,"context_line":"        \"callbackUri\": \"\u003cclient_callback_uri\u003e\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"80c7fadb_fa0d9f5c","line":266,"updated":"2022-11-25 05:37:38.000000000","message":"ditto.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"0debd91e79c3b9292a3f7d0cb6774a02ff570e9d","unresolved":true,"context_lines":[{"line_number":263,"context_line":"            \"performanceMetric\": ["},{"line_number":264,"context_line":"                \"VCpuUsageMeanVnf.507280d8-bfc5-4b88-904b-9280ba6bc3ea\"],"},{"line_number":265,"context_line":"            \"collectionPeriod\": 30,"},{"line_number":266,"context_line":"            \"reportingPeriod\": 90,"},{"line_number":267,"context_line":"            \"reportingBoundary\": \"2099-08-05T02:24:46Z\""},{"line_number":268,"context_line":"        },"},{"line_number":269,"context_line":"        \"callbackUri\": \"\u003cclient_callback_uri\u003e\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"ef5f11e7_60749e0f","line":266,"in_reply_to":"80c7fadb_fa0d9f5c","updated":"2022-11-28 10:09:36.000000000","message":"I think 60 is too short for the default value, because some promQL statements uses range-vector (i.e. https://prometheus.io/docs/prometheus/latest/querying/functions/#rate).\nThat means, To calcurate rate(), prometheus needs multiple samples for a single metrics. That needs longer period of time.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"5d39808efb1ba57b0b2cb58bf5caa539304cf755","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            \"performanceMetric\": ["},{"line_number":264,"context_line":"                \"VCpuUsageMeanVnf.507280d8-bfc5-4b88-904b-9280ba6bc3ea\"],"},{"line_number":265,"context_line":"            \"collectionPeriod\": 30,"},{"line_number":266,"context_line":"            \"reportingPeriod\": 90,"},{"line_number":267,"context_line":"            \"reportingBoundary\": \"2099-08-05T02:24:46Z\""},{"line_number":268,"context_line":"        },"},{"line_number":269,"context_line":"        \"callbackUri\": \"\u003cclient_callback_uri\u003e\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"f25eb7ba_479b8a12","line":266,"in_reply_to":"ef5f11e7_60749e0f","updated":"2022-11-30 01:51:06.000000000","message":"Done","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25db62864223aed13dde7ccc9a3ff53591e72cde","unresolved":true,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":".. note::"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    With the parameter, pod name can be specified but container name can not."},{"line_number":294,"context_line":"    And some prometheus metrics need container name. Therefore, ``max``"},{"line_number":295,"context_line":"    statement of PromQL is alternatively used in some measurements to"},{"line_number":296,"context_line":"    measure without container name. For example:"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    ``avg(max(container_fs_usage_bytes{pod\u003d~\"pod name\"} /"},{"line_number":299,"context_line":"    container_fs_limit_bytes{pod\u003d~\"pod name\"}))``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"4066d9fd_c8fe5467","line":296,"range":{"start_line":293,"start_character":4,"end_line":296,"end_character":35},"updated":"2022-11-25 05:37:38.000000000","message":"Could you add a reason why ``max`` is enough to use instead of container name?","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"0debd91e79c3b9292a3f7d0cb6774a02ff570e9d","unresolved":true,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":".. note::"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    With the parameter, pod name can be specified but container name can not."},{"line_number":294,"context_line":"    And some prometheus metrics need container name. Therefore, ``max``"},{"line_number":295,"context_line":"    statement of PromQL is alternatively used in some measurements to"},{"line_number":296,"context_line":"    measure without container name. For example:"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    ``avg(max(container_fs_usage_bytes{pod\u003d~\"pod name\"} /"},{"line_number":299,"context_line":"    container_fs_limit_bytes{pod\u003d~\"pod name\"}))``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"b052f915_bcb8fcbd","line":296,"range":{"start_line":293,"start_character":4,"end_line":296,"end_character":35},"in_reply_to":"4066d9fd_c8fe5467","updated":"2022-11-28 10:09:36.000000000","message":"Wording added.\n\"That means it provids only most impacted value among the containers.\"","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"5d39808efb1ba57b0b2cb58bf5caa539304cf755","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":".. note::"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    With the parameter, pod name can be specified but container name can not."},{"line_number":294,"context_line":"    And some prometheus metrics need container name. Therefore, ``max``"},{"line_number":295,"context_line":"    statement of PromQL is alternatively used in some measurements to"},{"line_number":296,"context_line":"    measure without container name. For example:"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    ``avg(max(container_fs_usage_bytes{pod\u003d~\"pod name\"} /"},{"line_number":299,"context_line":"    container_fs_limit_bytes{pod\u003d~\"pod name\"}))``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ed099765_5fa6691b","line":296,"range":{"start_line":293,"start_character":4,"end_line":296,"end_character":35},"in_reply_to":"b052f915_bcb8fcbd","updated":"2022-11-30 01:51:06.000000000","message":"Done","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"}],"tacker/sol_refactored/common/prometheus_plugin.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"84b1458d1b8782cf9029e4d4a4ff736c8820dc02","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        self.reporting_period_margin \u003d ("},{"line_number":77,"context_line":"            CONF.prometheus_plugin.reporting_period_margin)"},{"line_number":78,"context_line":"        self.notification_callback \u003d self.default_callback"},{"line_number":79,"context_line":"        self.sol_exp_map \u003d {"},{"line_number":80,"context_line":"            \u0027VCpuUsageMeanVnf\u0027:"},{"line_number":81,"context_line":"                \u0027avg(sum(rate(pod_cpu_usage_seconds_total\u0027"},{"line_number":82,"context_line":"                \u0027{{pod\u003d~\"{pod}\"}}[{reporting_period}s])))\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"a1b48c30_2fda44d8","line":79,"updated":"2022-11-17 11:00:54.000000000","message":"- Why don\u0027t add a comment before the line to explain that container name is not supported here?\n- It\u0027s better to define the name \"sol_exp_man\" as \"sol_expr_dict\", or \"sol_exprs\" simply because it can be thought as \"example\" or so. It\u0027s misunderstandalbe.","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"d950f8c02869ebba0db8bae71d974885ac30b719","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        self.reporting_period_margin \u003d ("},{"line_number":77,"context_line":"            CONF.prometheus_plugin.reporting_period_margin)"},{"line_number":78,"context_line":"        self.notification_callback \u003d self.default_callback"},{"line_number":79,"context_line":"        self.sol_exp_map \u003d {"},{"line_number":80,"context_line":"            \u0027VCpuUsageMeanVnf\u0027:"},{"line_number":81,"context_line":"                \u0027avg(sum(rate(pod_cpu_usage_seconds_total\u0027"},{"line_number":82,"context_line":"                \u0027{{pod\u003d~\"{pod}\"}}[{reporting_period}s])))\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9836d017_a74f4a2c","line":79,"in_reply_to":"a1b48c30_2fda44d8","updated":"2022-11-21 07:20:46.000000000","message":"fixed in PS5","commit_id":"133e3b90cf74bcea550043a751719bbf4a819823"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25db62864223aed13dde7ccc9a3ff53591e72cde","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        self.reporting_period_margin \u003d ("},{"line_number":77,"context_line":"            CONF.prometheus_plugin.reporting_period_margin)"},{"line_number":78,"context_line":"        self.notification_callback \u003d self.default_callback"},{"line_number":79,"context_line":"        # Pod name can be specified but container name can not."},{"line_number":80,"context_line":"        # And some prometheus metrics need container name. Therefore, max"},{"line_number":81,"context_line":"        # statement of PromQL is alternatively used in some measurements to"},{"line_number":82,"context_line":"        # measure without container name."},{"line_number":83,"context_line":"        self.sol_exprs \u003d {"},{"line_number":84,"context_line":"            \u0027VCpuUsageMeanVnf\u0027:"},{"line_number":85,"context_line":"                \u0027avg(sum(rate(pod_cpu_usage_seconds_total\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"21dcf6a2_e5b4a470","line":82,"range":{"start_line":79,"start_character":9,"end_line":82,"end_character":41},"updated":"2022-11-25 05:37:38.000000000","message":"ditto.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"0debd91e79c3b9292a3f7d0cb6774a02ff570e9d","unresolved":true,"context_lines":[{"line_number":76,"context_line":"        self.reporting_period_margin \u003d ("},{"line_number":77,"context_line":"            CONF.prometheus_plugin.reporting_period_margin)"},{"line_number":78,"context_line":"        self.notification_callback \u003d self.default_callback"},{"line_number":79,"context_line":"        # Pod name can be specified but container name can not."},{"line_number":80,"context_line":"        # And some prometheus metrics need container name. Therefore, max"},{"line_number":81,"context_line":"        # statement of PromQL is alternatively used in some measurements to"},{"line_number":82,"context_line":"        # measure without container name."},{"line_number":83,"context_line":"        self.sol_exprs \u003d {"},{"line_number":84,"context_line":"            \u0027VCpuUsageMeanVnf\u0027:"},{"line_number":85,"context_line":"                \u0027avg(sum(rate(pod_cpu_usage_seconds_total\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"40f73fd3_7383d5b5","line":82,"range":{"start_line":79,"start_character":9,"end_line":82,"end_character":41},"in_reply_to":"21dcf6a2_e5b4a470","updated":"2022-11-28 10:09:36.000000000","message":"Wording added.\n\"That means it provids only most impacted value among the containers.\"","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"5d39808efb1ba57b0b2cb58bf5caa539304cf755","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.reporting_period_margin \u003d ("},{"line_number":77,"context_line":"            CONF.prometheus_plugin.reporting_period_margin)"},{"line_number":78,"context_line":"        self.notification_callback \u003d self.default_callback"},{"line_number":79,"context_line":"        # Pod name can be specified but container name can not."},{"line_number":80,"context_line":"        # And some prometheus metrics need container name. Therefore, max"},{"line_number":81,"context_line":"        # statement of PromQL is alternatively used in some measurements to"},{"line_number":82,"context_line":"        # measure without container name."},{"line_number":83,"context_line":"        self.sol_exprs \u003d {"},{"line_number":84,"context_line":"            \u0027VCpuUsageMeanVnf\u0027:"},{"line_number":85,"context_line":"                \u0027avg(sum(rate(pod_cpu_usage_seconds_total\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"bfe83a94_ba6a4da6","line":82,"range":{"start_line":79,"start_character":9,"end_line":82,"end_character":41},"in_reply_to":"40f73fd3_7383d5b5","updated":"2022-11-30 01:51:06.000000000","message":"Done","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"25db62864223aed13dde7ccc9a3ff53591e72cde","unresolved":true,"context_lines":[{"line_number":302,"context_line":"            )"},{"line_number":303,"context_line":"        return metrics"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def make_prom_ql(self, target, pod, collection_period\u003d30,"},{"line_number":306,"context_line":"                     reporting_period\u003d90, sub_object_instance_id\u003d\u0027*\u0027):"},{"line_number":307,"context_line":"        reporting_period \u003d max(reporting_period, 30)"},{"line_number":308,"context_line":"        expr \u003d self.sol_exprs[target].format("}],"source_content_type":"text/x-python","patch_set":6,"id":"95b7566f_125c197e","line":305,"updated":"2022-11-25 05:37:38.000000000","message":"Why don\u0027t you add test cases for this method?","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"0debd91e79c3b9292a3f7d0cb6774a02ff570e9d","unresolved":true,"context_lines":[{"line_number":302,"context_line":"            )"},{"line_number":303,"context_line":"        return metrics"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def make_prom_ql(self, target, pod, collection_period\u003d30,"},{"line_number":306,"context_line":"                     reporting_period\u003d90, sub_object_instance_id\u003d\u0027*\u0027):"},{"line_number":307,"context_line":"        reporting_period \u003d max(reporting_period, 30)"},{"line_number":308,"context_line":"        expr \u003d self.sol_exprs[target].format("}],"source_content_type":"text/x-python","patch_set":6,"id":"a62bbb6c_9cb6d48a","line":305,"in_reply_to":"95b7566f_125c197e","updated":"2022-11-28 10:09:36.000000000","message":"It is covered with the UT that is already exists.\ntacker/tests/unit/sol_refactored/common/test_prometheus_plugin.py: test_create_job() -\u003e tacker/sol_refactored/common/prometheus_plugin.py: create_job() -\u003e make_rules() -\u003e _make_rules() -\u003e _make_rules_for_each_obj() -\u003e make_prom_ql()","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"5d39808efb1ba57b0b2cb58bf5caa539304cf755","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            )"},{"line_number":303,"context_line":"        return metrics"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def make_prom_ql(self, target, pod, collection_period\u003d30,"},{"line_number":306,"context_line":"                     reporting_period\u003d90, sub_object_instance_id\u003d\u0027*\u0027):"},{"line_number":307,"context_line":"        reporting_period \u003d max(reporting_period, 30)"},{"line_number":308,"context_line":"        expr \u003d self.sol_exprs[target].format("}],"source_content_type":"text/x-python","patch_set":6,"id":"aacc0acc_bc803d46","line":305,"in_reply_to":"a62bbb6c_9cb6d48a","updated":"2022-11-30 01:51:06.000000000","message":"Done","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"c35ea389cace23e24fde2886add03ae2e6bcc667","unresolved":true,"context_lines":[{"line_number":597,"context_line":"        target_list, reload_list \u003d self.get_access_info(pm_job)"},{"line_number":598,"context_line":"        metrics \u003d self.decompose_metrics(pm_job)"},{"line_number":599,"context_line":"        inst_map \u003d self.get_vnf_instances(context, pm_job)"},{"line_number":600,"context_line":"        rules \u003d sum([self._make_rules(context, pm_job, metric, inst_map)"},{"line_number":601,"context_line":"                     for metric in metrics], [])"},{"line_number":602,"context_line":"        if len(rules) \u003d\u003d 0:"},{"line_number":603,"context_line":"            raise sol_ex.PrometheusPluginError("}],"source_content_type":"text/x-python","patch_set":6,"id":"c171fd5e_d5e34e46","line":600,"updated":"2022-11-25 05:33:24.000000000","message":"This is unrelated to this patch, but in my understanding, the second arg of ``sum`` is ``start`` [1].\nWhy do you use ``[]`` for the second arg?\n\n[1] https://docs.python.org//3/library/functions.html?highlight\u003dsum","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"51458ff254ca0ea7804ae67464723fe506a14957","unresolved":false,"context_lines":[{"line_number":597,"context_line":"        target_list, reload_list \u003d self.get_access_info(pm_job)"},{"line_number":598,"context_line":"        metrics \u003d self.decompose_metrics(pm_job)"},{"line_number":599,"context_line":"        inst_map \u003d self.get_vnf_instances(context, pm_job)"},{"line_number":600,"context_line":"        rules \u003d sum([self._make_rules(context, pm_job, metric, inst_map)"},{"line_number":601,"context_line":"                     for metric in metrics], [])"},{"line_number":602,"context_line":"        if len(rules) \u003d\u003d 0:"},{"line_number":603,"context_line":"            raise sol_ex.PrometheusPluginError("}],"source_content_type":"text/x-python","patch_set":6,"id":"32cf5499_c9006b3c","line":600,"in_reply_to":"aad0eeb5_29cf4eef","updated":"2022-11-30 06:27:20.000000000","message":"I understand. thanks.\n\nDone","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"fc7aee31540335ea59a6f3a6e7854618f4c48461","unresolved":true,"context_lines":[{"line_number":597,"context_line":"        target_list, reload_list \u003d self.get_access_info(pm_job)"},{"line_number":598,"context_line":"        metrics \u003d self.decompose_metrics(pm_job)"},{"line_number":599,"context_line":"        inst_map \u003d self.get_vnf_instances(context, pm_job)"},{"line_number":600,"context_line":"        rules \u003d sum([self._make_rules(context, pm_job, metric, inst_map)"},{"line_number":601,"context_line":"                     for metric in metrics], [])"},{"line_number":602,"context_line":"        if len(rules) \u003d\u003d 0:"},{"line_number":603,"context_line":"            raise sol_ex.PrometheusPluginError("}],"source_content_type":"text/x-python","patch_set":6,"id":"aad0eeb5_29cf4eef","line":600,"in_reply_to":"c0f67601_87eff286","updated":"2022-11-25 07:23:05.000000000","message":"This statement expands the list of lists.\n\u0027\u0027\u0027\n\u003e\u003e\u003e sum([[1,2,3],[4,5,6]],[])\n[1, 2, 3, 4, 5, 6]\n\u0027\u0027\u0027\nThis second parameter is initial value of the sum. At first [] + [1,2,3] \u003d [1,2,3] is computed and second, [1,2,3] + [4,5,6] \u003d [1,2,3,4,5,6] is done. If using default value for second parameter, then 0 + [1,2,3] \u003d error.","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"7c7ebee6b12638225d0a2bef7d0d9451cd22ce4c","unresolved":true,"context_lines":[{"line_number":597,"context_line":"        target_list, reload_list \u003d self.get_access_info(pm_job)"},{"line_number":598,"context_line":"        metrics \u003d self.decompose_metrics(pm_job)"},{"line_number":599,"context_line":"        inst_map \u003d self.get_vnf_instances(context, pm_job)"},{"line_number":600,"context_line":"        rules \u003d sum([self._make_rules(context, pm_job, metric, inst_map)"},{"line_number":601,"context_line":"                     for metric in metrics], [])"},{"line_number":602,"context_line":"        if len(rules) \u003d\u003d 0:"},{"line_number":603,"context_line":"            raise sol_ex.PrometheusPluginError("}],"source_content_type":"text/x-python","patch_set":6,"id":"c0f67601_87eff286","line":600,"in_reply_to":"c171fd5e_d5e34e46","updated":"2022-11-25 05:47:20.000000000","message":"Please note that I said it\u0027s unrelated, but I think this part is related to the condition to raise an error caught by the removed test case [1].\n\n[1] tacker/tests/unit/sol_refactored/common/test_prometheus_plugin.py","commit_id":"eee15a833f56ea97aeebcfac626adedfbbc2995e"}]}