)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Itsuro Oda \u003coda@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-13 23:15:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"change_vnfpkg v2 API enhance to enale network change"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhances about network update of change_vnfpkg"},{"line_number":10,"context_line":"v2 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9daf0cfe_67024839","line":7,"updated":"2022-12-14 09:49:13.000000000","message":"typo: enale -\u003e enable","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Itsuro Oda \u003coda@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-13 23:15:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"change_vnfpkg v2 API enhance to enale network change"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhances about network update of change_vnfpkg"},{"line_number":10,"context_line":"v2 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6e38cad5_69e1f3d0","line":7,"in_reply_to":"8cf98697_5e919180","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Itsuro Oda \u003coda@valinux.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-13 23:15:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"change_vnfpkg v2 API enhance to enale network change"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enhances about network update of change_vnfpkg"},{"line_number":10,"context_line":"v2 API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"8cf98697_5e919180","line":7,"in_reply_to":"9daf0cfe_67024839","updated":"2022-12-19 00:20:26.000000000","message":"I will fix. I will shorten the message than 50 characters too.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fa125640cdc036699d03e35b9b79fab5f4656f70","unresolved":true,"context_lines":[{"line_number":10,"context_line":"v2 API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* support adding/removing external CPs."},{"line_number":13,"context_line":"* support extManagedVirtualLinks attribute of"},{"line_number":14,"context_line":"  ChangeCurrentVnfPkgRequest and support to change external"},{"line_number":15,"context_line":"  management networks."},{"line_number":16,"context_line":"* support to change internal networks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"90a4e75a_5059e64f","line":13,"updated":"2022-12-15 02:59:41.000000000","message":"The following comments should be deleted.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/sol_refactored/objects/v2/change_current_vnf_pkg_request.py#L33-L34","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"5b450157a8aa803ff00967c19d4ab69c8671dc5b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"v2 API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* support adding/removing external CPs."},{"line_number":13,"context_line":"* support extManagedVirtualLinks attribute of"},{"line_number":14,"context_line":"  ChangeCurrentVnfPkgRequest and support to change external"},{"line_number":15,"context_line":"  management networks."},{"line_number":16,"context_line":"* support to change internal networks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a9c6b993_06871ffc","line":13,"in_reply_to":"90a4e75a_5059e64f","updated":"2022-12-19 00:26:58.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":10,"context_line":"v2 API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* support adding/removing external CPs."},{"line_number":13,"context_line":"* support extManagedVirtualLinks attribute of"},{"line_number":14,"context_line":"  ChangeCurrentVnfPkgRequest and support to change external"},{"line_number":15,"context_line":"  management networks."},{"line_number":16,"context_line":"* support to change internal networks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"98495c13_8e2e3f2d","line":13,"in_reply_to":"a9c6b993_06871ffc","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":24,"context_line":"change_vnfpkg."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Functional test of changing (nova) flavor is added too."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Icdca7d81bd8081fddd7cc2e24ba0ca8b6b456a41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"86ca4554_90f6bf2b","line":27,"updated":"2022-12-14 09:49:13.000000000","message":"Please add the following.\nImplements: blueprint enhance-change-package","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":24,"context_line":"change_vnfpkg."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Functional test of changing (nova) flavor is added too."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Icdca7d81bd8081fddd7cc2e24ba0ca8b6b456a41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f6e63ab4_b64cc961","line":27,"in_reply_to":"86ca4554_90f6bf2b","updated":"2022-12-19 00:20:26.000000000","message":"I will add.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":24,"context_line":"change_vnfpkg."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Functional test of changing (nova) flavor is added too."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Icdca7d81bd8081fddd7cc2e24ba0ca8b6b456a41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"442e6819_ab6fd0e2","line":27,"in_reply_to":"f6e63ab4_b64cc961","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d39e8331f54a1546c1e384b71e6053683c911c16","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This patch enhances about network update of change_vnfpkg"},{"line_number":10,"context_line":"v2 API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* support adding/removing external CPs."},{"line_number":13,"context_line":"* support extManagedVirtualLinks attribute of"},{"line_number":14,"context_line":"  ChangeCurrentVnfPkgRequest and support to change external"},{"line_number":15,"context_line":"  management networks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"74cbfe1c_8431b3de","line":12,"updated":"2023-02-14 00:22:29.000000000","message":"nits: `support to add/remove external CPs.`","commit_id":"9ce9fea2cf4093e150a977687c06d3e1444f6663"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"0889f64323992e1b0947943ef847f7304bd96457","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This patch enhances about network update of change_vnfpkg"},{"line_number":10,"context_line":"v2 API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* support adding/removing external CPs."},{"line_number":13,"context_line":"* support extManagedVirtualLinks attribute of"},{"line_number":14,"context_line":"  ChangeCurrentVnfPkgRequest and support to change external"},{"line_number":15,"context_line":"  management networks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"8e0c8f6b_5a30d1de","line":12,"in_reply_to":"74cbfe1c_8431b3de","updated":"2023-02-14 00:53:23.000000000","message":"I will fix.","commit_id":"9ce9fea2cf4093e150a977687c06d3e1444f6663"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"cc65be221d0b2c92f4ce4290cec9fd0830a42e34","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch enhances about network update of change_vnfpkg"},{"line_number":10,"context_line":"v2 API."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* support adding/removing external CPs."},{"line_number":13,"context_line":"* support extManagedVirtualLinks attribute of"},{"line_number":14,"context_line":"  ChangeCurrentVnfPkgRequest and support to change external"},{"line_number":15,"context_line":"  management networks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"e7a6c0eb_a48ef809","line":12,"in_reply_to":"8e0c8f6b_5a30d1de","updated":"2023-02-16 00:02:50.000000000","message":"Done","commit_id":"9ce9fea2cf4093e150a977687c06d3e1444f6663"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"986256b2_7b1761e1","updated":"2022-12-14 09:49:13.000000000","message":"Please change the Topic to the following.\nbp/enhance-change-package","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"00b02cba_e03b0a36","updated":"2022-12-19 00:20:26.000000000","message":"Thank you for the review.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"5b450157a8aa803ff00967c19d4ab69c8671dc5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6b4d4cce_2f3b5312","updated":"2022-12-19 00:26:58.000000000","message":"Thank you for the review.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e1d7e0c2_c6e738b2","in_reply_to":"404c75db_523f6a66","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"404c75db_523f6a66","in_reply_to":"986256b2_7b1761e1","updated":"2022-12-19 00:20:26.000000000","message":"Ok. I will change the topic.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b2ad91a56c9c0082b8315c3913e44457e631a50b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"04c9177a_5adc2fa3","updated":"2022-12-19 22:23:34.000000000","message":"Thank you for the comment.","commit_id":"c910edb9482ac21798828a6d5fdd440d0d4ddebc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"cc66732fe83e17bd97b709050415d51ed11f0f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6c2ace6c_f46d5bb6","updated":"2022-12-20 04:11:55.000000000","message":"Thank you for the comment.","commit_id":"c910edb9482ac21798828a6d5fdd440d0d4ddebc"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0c603f4805331b04f1348bf7aa8a1fd1b2f1ad86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"124c278f_bb4dc84f","updated":"2023-01-23 09:49:38.000000000","message":"Thank you for the patch.\nPlease kindly find my comments.","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9f328059f9d8f3eb099208d144e64ec0079f482e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"eb33bd56_f1b8de13","updated":"2023-01-24 04:21:51.000000000","message":"Thank you for the review.","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b4561e1dd37861802cd3f0f4724ae231e7002fc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1c499b43_cc393c48","updated":"2023-01-24 07:23:21.000000000","message":"Thank you for rework.\nLGTM.","commit_id":"30eedb75eb1b9fa9d54c91e93a9123ed5cf850d9"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"e07c6c3ebe8bd7a7dca8eea3a654be3c3a4733b4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fd83a393_e3281a84","updated":"2023-02-02 05:30:51.000000000","message":"Could you please correct the Topic?\t\nbp/individual-vnfc-management -\u003e bp/enhance-change-package","commit_id":"3d2ae84e176c297752eb743f45b5338fbe98fec0"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"cc65be221d0b2c92f4ce4290cec9fd0830a42e34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"888d62dd_3c83a19b","in_reply_to":"fd83a393_e3281a84","updated":"2023-02-16 00:02:50.000000000","message":"Done","commit_id":"3d2ae84e176c297752eb743f45b5338fbe98fec0"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"240c5ca8b50a334846ca2a9bcf18292693d06299","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dfac4daa_45e24c48","in_reply_to":"fd83a393_e3281a84","updated":"2023-02-15 23:28:12.000000000","message":"Done","commit_id":"3d2ae84e176c297752eb743f45b5338fbe98fec0"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d1c4f1ff67fc867c5ab681fb5b087f6aaf5a818a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b8ce2f4d_0bc78d0e","updated":"2023-02-05 23:26:33.000000000","message":"PS15: add release note","commit_id":"b760ff662a0cc2df9e5bf03edb72c8d92463cc56"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"1e528f9e100ae032c787ee49028c025af4d2ba4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8ad8b72f_4db40d18","updated":"2023-02-09 23:42:29.000000000","message":"Thank you for the review.","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c7171fc7fa73afe941ee3788dcacfc4d643370dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e7fcc70b_ebb9d615","updated":"2023-02-09 06:17:47.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"cbe5da004707112b815bb035d3fdc4ad75c1ff85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d9fc16a3_ef143d8f","updated":"2023-02-10 02:57:50.000000000","message":"Thank you for the review.","commit_id":"96ef86221989278eb50b3ee7a2d435353772d8b1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b7efd46023633c5385c4606d6e603878561d1ca8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"17e02da1_caa59af9","updated":"2023-02-12 22:28:48.000000000","message":"Thank you for the review.","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d39e8331f54a1546c1e384b71e6053683c911c16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"1fa75cdc_710128bc","updated":"2023-02-14 00:22:29.000000000","message":"Thank you for the patch. Almost LGTM, but please kindly check my nits comment.","commit_id":"9ce9fea2cf4093e150a977687c06d3e1444f6663"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"0889f64323992e1b0947943ef847f7304bd96457","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"9eb0ab90_7be56420","updated":"2023-02-14 00:53:23.000000000","message":"Thank you for the review.","commit_id":"9ce9fea2cf4093e150a977687c06d3e1444f6663"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"240c5ca8b50a334846ca2a9bcf18292693d06299","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"d3e06b1e_df9237f7","updated":"2023-02-15 23:28:12.000000000","message":"LGTM","commit_id":"5acf25a7cc6f1de26a727e7744a0c70e0d3a0b9d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"cc65be221d0b2c92f4ce4290cec9fd0830a42e34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"d2143c50_83f390d6","updated":"2023-02-16 00:02:50.000000000","message":"Thanks for your great work! LGTM","commit_id":"5acf25a7cc6f1de26a727e7744a0c70e0d3a0b9d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9a4fb5c972fc69bb8e83c59d9a82150b42a92618","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"da26864c_435afbb9","updated":"2023-02-14 13:04:53.000000000","message":"Thanks for your re-work! LGTM (Waiting for zuul results.)","commit_id":"5acf25a7cc6f1de26a727e7744a0c70e0d3a0b9d"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4cbdd1441e211d882277850b2e3ff12371333b6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"834628d3_e81c1009","updated":"2023-02-14 13:06:29.000000000","message":"recheck - infra failure in sol-v2-ubuntu-focal.","commit_id":"5acf25a7cc6f1de26a727e7744a0c70e0d3a0b9d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7952cd577c60389069a764626bef7b2306807dba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"bac54b76_164526f9","updated":"2023-02-14 22:16:36.000000000","message":"recheck - infra failure in sol-v2-ubuntu-focal.","commit_id":"5acf25a7cc6f1de26a727e7744a0c70e0d3a0b9d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dffd81d9a02f89e7a61adcc4c3edefd6a056d0b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"4802afc2_a9a738c4","updated":"2023-02-15 04:27:37.000000000","message":"recheck - infra failure in tox-cover.","commit_id":"5acf25a7cc6f1de26a727e7744a0c70e0d3a0b9d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7675fd3095eb9a090ab51837206da3064b19fd88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"e015e5aa_797f30af","updated":"2023-02-15 01:01:26.000000000","message":"recheck - infra failure in tox-cover.","commit_id":"5acf25a7cc6f1de26a727e7744a0c70e0d3a0b9d"}],"releasenotes/notes/support-ext-nw-change-in-changevnf-23a2adfd82c30f9c.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c7171fc7fa73afe941ee3788dcacfc4d643370dd","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    external management networks."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Support only when StandardUserData is used"},{"line_number":11,"context_line":"    as the UserData class."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"98d8fcd5_e65948b8","line":11,"range":{"start_line":10,"start_character":4,"end_line":11,"end_character":26},"updated":"2023-02-09 06:17:47.000000000","message":"The text in these release notes is output away from the text in `features` above.\n\nIt is better to make it clear that this feature (change_vnfpkg enhance to enable network change) is only supported in that state.\nOr it is better to be written in `features` section together.\n\nWhat do you think?","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5fa0ea97f5e368275f5130d5232d39ff7da30299","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    external management networks."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Support only when StandardUserData is used"},{"line_number":11,"context_line":"    as the UserData class."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"42f992b8_83c0ad03","line":11,"range":{"start_line":10,"start_character":4,"end_line":11,"end_character":26},"in_reply_to":"04a0108b_e8eb9247","updated":"2023-02-10 06:19:43.000000000","message":"Ack","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"1e528f9e100ae032c787ee49028c025af4d2ba4b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    external management networks."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Support only when StandardUserData is used"},{"line_number":11,"context_line":"    as the UserData class."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"04a0108b_e8eb9247","line":11,"range":{"start_line":10,"start_character":4,"end_line":11,"end_character":26},"in_reply_to":"98d8fcd5_e65948b8","updated":"2023-02-09 23:42:29.000000000","message":"I think so. I will fix.","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b05f740858366069e49808246224363c13b18453","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"3e642da7_8da082f7","line":11,"updated":"2023-02-10 02:41:46.000000000","message":"Unnecessary line.","commit_id":"96ef86221989278eb50b3ee7a2d435353772d8b1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"cbe5da004707112b815bb035d3fdc4ad75c1ff85","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e2f62185_3c64d269","line":11,"in_reply_to":"3e642da7_8da082f7","updated":"2023-02-10 02:57:50.000000000","message":"I will remove.","commit_id":"96ef86221989278eb50b3ee7a2d435353772d8b1"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"0ecc7cf2bc9eaf6e987ef6fa97c37358d9caa4c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"2b5a88f6_cfd89f1f","line":11,"in_reply_to":"e2f62185_3c64d269","updated":"2023-02-10 03:00:02.000000000","message":"Done","commit_id":"96ef86221989278eb50b3ee7a2d435353772d8b1"}],"tacker/sol_refactored/infra_drivers/openstack/heat_utils.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0c603f4805331b04f1348bf7aa8a1fd1b2f1ad86","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def update_stack(self, stack_name, fields, wait\u003dTrue):"},{"line_number":55,"context_line":"        path \u003d f\"stacks/{stack_name}\""},{"line_number":56,"context_line":"        # PATCH is default in the openstack infra_driver. if \u0027existing\u0027 is"},{"line_number":57,"context_line":"        # specified and it is False, PUT is used."},{"line_number":58,"context_line":"        method \u003d \"PATCH\" if fields.pop(\u0027existing\u0027, True) else \"PUT\""},{"line_number":59,"context_line":"        resp, body \u003d self.client.do_request(path, method,"}],"source_content_type":"text/x-python","patch_set":9,"id":"72268fbe_776daf07","line":56,"updated":"2023-01-23 09:49:38.000000000","message":"nits.\n\nIt might be better to note that the `existing` comes from Heat, if it does.\nIMO, this name isn\u0027t intuitive, but is the right name if we intend to control API requests for Heat with this value.\n\n[1] https://docs.openstack.org/api-ref/orchestration/v1/index.html","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b4561e1dd37861802cd3f0f4724ae231e7002fc6","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def update_stack(self, stack_name, fields, wait\u003dTrue):"},{"line_number":55,"context_line":"        path \u003d f\"stacks/{stack_name}\""},{"line_number":56,"context_line":"        # PATCH is default in the openstack infra_driver. if \u0027existing\u0027 is"},{"line_number":57,"context_line":"        # specified and it is False, PUT is used."},{"line_number":58,"context_line":"        method \u003d \"PATCH\" if fields.pop(\u0027existing\u0027, True) else \"PUT\""},{"line_number":59,"context_line":"        resp, body \u003d self.client.do_request(path, method,"}],"source_content_type":"text/x-python","patch_set":9,"id":"587fe005_3efac30b","line":56,"in_reply_to":"6ac206e2_30e4e134","updated":"2023-01-24 07:23:21.000000000","message":"Done","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9f328059f9d8f3eb099208d144e64ec0079f482e","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def update_stack(self, stack_name, fields, wait\u003dTrue):"},{"line_number":55,"context_line":"        path \u003d f\"stacks/{stack_name}\""},{"line_number":56,"context_line":"        # PATCH is default in the openstack infra_driver. if \u0027existing\u0027 is"},{"line_number":57,"context_line":"        # specified and it is False, PUT is used."},{"line_number":58,"context_line":"        method \u003d \"PATCH\" if fields.pop(\u0027existing\u0027, True) else \"PUT\""},{"line_number":59,"context_line":"        resp, body \u003d self.client.do_request(path, method,"}],"source_content_type":"text/x-python","patch_set":9,"id":"6ac206e2_30e4e134","line":56,"in_reply_to":"72268fbe_776daf07","updated":"2023-01-24 04:21:51.000000000","message":"\u0027fields\u0027 is a parameter to just pass to the heat originally. It was assumed that PATCH is used and therefore \u0027fields\u0027 contains only update parts and \u0027existing\u0027 is not used. Now full replacing \u0027fields\u0027 is supported and it is indicated by \u0027existing\u0027 is False.\n\nI do comment in detail a little more.","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"}],"tacker/sol_refactored/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        def _get_param_third_keys(res):"},{"line_number":480,"context_line":"            \"\"\"Get third parameter keys"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"            examle:"},{"line_number":483,"context_line":"            ---"},{"line_number":484,"context_line":"            VDU1-1:"},{"line_number":485,"context_line":"              type: VDU1.yaml"}],"source_content_type":"text/x-python","patch_set":5,"id":"fe2f58c5_bab35237","line":482,"updated":"2022-12-14 09:49:13.000000000","message":"typo: examle -\u003e example","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        def _get_param_third_keys(res):"},{"line_number":480,"context_line":"            \"\"\"Get third parameter keys"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"            examle:"},{"line_number":483,"context_line":"            ---"},{"line_number":484,"context_line":"            VDU1-1:"},{"line_number":485,"context_line":"              type: VDU1.yaml"}],"source_content_type":"text/x-python","patch_set":5,"id":"1457051f_f0e2d1fc","line":482,"in_reply_to":"8d97e0d3_6795f071","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        def _get_param_third_keys(res):"},{"line_number":480,"context_line":"            \"\"\"Get third parameter keys"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"            examle:"},{"line_number":483,"context_line":"            ---"},{"line_number":484,"context_line":"            VDU1-1:"},{"line_number":485,"context_line":"              type: VDU1.yaml"}],"source_content_type":"text/x-python","patch_set":5,"id":"8d97e0d3_6795f071","line":482,"in_reply_to":"fe2f58c5_bab35237","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0c603f4805331b04f1348bf7aa8a1fd1b2f1ad86","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        heat_client.delete_stack(stack_name)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _update_fields(self, heat_client, stack_name, fields):"},{"line_number":130,"context_line":"        if not fields.get(\u0027existing\u0027, True):"},{"line_number":131,"context_line":"            # full fields"},{"line_number":132,"context_line":"            # used by change_vnfpkg(, rollback) only at the moment."},{"line_number":133,"context_line":"            return fields"}],"source_content_type":"text/x-python","patch_set":9,"id":"a0d5026b_07ea861a","line":130,"updated":"2023-01-23 09:49:38.000000000","message":"nits.\n\nWhy don\u0027t you define a method to retrieve the \u0027existing\u0027.\nI can find this`fields.get(\u0027existing\u0027, True)` in several places, and as for now, the policy that using `True` as a default value is not clear for other developers.\n\ne.g., l.376, tacker/sol_refactored/infra_drivers/openstack/heat_utils.py:l58","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b4561e1dd37861802cd3f0f4724ae231e7002fc6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        heat_client.delete_stack(stack_name)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _update_fields(self, heat_client, stack_name, fields):"},{"line_number":130,"context_line":"        if not fields.get(\u0027existing\u0027, True):"},{"line_number":131,"context_line":"            # full fields"},{"line_number":132,"context_line":"            # used by change_vnfpkg(, rollback) only at the moment."},{"line_number":133,"context_line":"            return fields"}],"source_content_type":"text/x-python","patch_set":9,"id":"30605520_7b9d4e67","line":130,"in_reply_to":"3bf2597b_dc80afc4","updated":"2023-01-24 07:23:21.000000000","message":"Done","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9f328059f9d8f3eb099208d144e64ec0079f482e","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        heat_client.delete_stack(stack_name)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _update_fields(self, heat_client, stack_name, fields):"},{"line_number":130,"context_line":"        if not fields.get(\u0027existing\u0027, True):"},{"line_number":131,"context_line":"            # full fields"},{"line_number":132,"context_line":"            # used by change_vnfpkg(, rollback) only at the moment."},{"line_number":133,"context_line":"            return fields"}],"source_content_type":"text/x-python","patch_set":9,"id":"3bf2597b_dc80afc4","line":130,"in_reply_to":"a0d5026b_07ea861a","updated":"2023-01-24 04:21:51.000000000","message":"OK, I will add a method and add a comment in more detail.","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0c603f4805331b04f1348bf7aa8a1fd1b2f1ad86","unresolved":true,"context_lines":[{"line_number":373,"context_line":"                 for vnfc in inst.instantiatedVnfInfo.vnfcResourceInfo"},{"line_number":374,"context_line":"                 if vnfc.computeResource.resourceId in vnfc_res_ids]"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        if not fields.get(\u0027existing\u0027, True):"},{"line_number":377,"context_line":"            # NOTE: since \u0027existing: False\u0027 is used by StandardUserData only"},{"line_number":378,"context_line":"            # at the moment, use it to check the fields is constructed by"},{"line_number":379,"context_line":"            # StandardUserData or not."}],"source_content_type":"text/x-python","patch_set":9,"id":"f92988b7_6d02386d","line":376,"updated":"2023-01-23 09:49:38.000000000","message":"Let me confirm, is this a temporal solution? If it is and the `UserData` will be deprecated and consequently `_change_vnfpkg_rolling_update_legacy` will be removed, I think a `TODO` comment is necessary.\n\nIf the method `_legacy` will be used continuously, the names should be something like `_change_vnfpkg_rolling_update_user_data` and `_change_vnfpkg_rolling_update_user_data_standard`.\n\nCould you tell me your plan?","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b4561e1dd37861802cd3f0f4724ae231e7002fc6","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                 for vnfc in inst.instantiatedVnfInfo.vnfcResourceInfo"},{"line_number":374,"context_line":"                 if vnfc.computeResource.resourceId in vnfc_res_ids]"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        if not fields.get(\u0027existing\u0027, True):"},{"line_number":377,"context_line":"            # NOTE: since \u0027existing: False\u0027 is used by StandardUserData only"},{"line_number":378,"context_line":"            # at the moment, use it to check the fields is constructed by"},{"line_number":379,"context_line":"            # StandardUserData or not."}],"source_content_type":"text/x-python","patch_set":9,"id":"8f5275a5_e0006000","line":376,"in_reply_to":"6d1c60e6_9c4cdc23","updated":"2023-01-24 07:23:21.000000000","message":"Done","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9f328059f9d8f3eb099208d144e64ec0079f482e","unresolved":true,"context_lines":[{"line_number":373,"context_line":"                 for vnfc in inst.instantiatedVnfInfo.vnfcResourceInfo"},{"line_number":374,"context_line":"                 if vnfc.computeResource.resourceId in vnfc_res_ids]"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        if not fields.get(\u0027existing\u0027, True):"},{"line_number":377,"context_line":"            # NOTE: since \u0027existing: False\u0027 is used by StandardUserData only"},{"line_number":378,"context_line":"            # at the moment, use it to check the fields is constructed by"},{"line_number":379,"context_line":"            # StandardUserData or not."}],"source_content_type":"text/x-python","patch_set":9,"id":"6d1c60e6_9c4cdc23","line":376,"in_reply_to":"f92988b7_6d02386d","updated":"2023-01-24 04:21:51.000000000","message":"Using StandardUserData is desirable since there are some features assuming use of StandardUserData. However, the support for DefaultUserData remains.\n\nI will rename ...user_data_default and ...user_data_standard.","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0c603f4805331b04f1348bf7aa8a1fd1b2f1ad86","unresolved":true,"context_lines":[{"line_number":472,"context_line":"        base_files.update(fields[\u0027files\u0027])"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        base_parameters \u003d heat_client.get_parameters(stack_name)"},{"line_number":475,"context_line":"        # NOTE: parameters[\u0027nfv\u0027] is string"},{"line_number":476,"context_line":"        base_nfv_dict \u003d json.loads(base_parameters.get(\u0027nfv\u0027, \u0027{}\u0027))"},{"line_number":477,"context_line":"        new_nfv_dict \u003d fields[\u0027parameters\u0027][\u0027nfv\u0027]"},{"line_number":478,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"0323827c_d713b6de","line":475,"updated":"2023-01-23 09:49:38.000000000","message":"I couldn\u0027t get it for the fist time.\nDo you mean `base_parameters[\u0027nfv\u0027]` is a string and that\u0027s why we have to use `json.loads`?\n\nIf so, I think it\u0027s better to start this note with `Using json.loads because...`","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9f328059f9d8f3eb099208d144e64ec0079f482e","unresolved":true,"context_lines":[{"line_number":472,"context_line":"        base_files.update(fields[\u0027files\u0027])"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        base_parameters \u003d heat_client.get_parameters(stack_name)"},{"line_number":475,"context_line":"        # NOTE: parameters[\u0027nfv\u0027] is string"},{"line_number":476,"context_line":"        base_nfv_dict \u003d json.loads(base_parameters.get(\u0027nfv\u0027, \u0027{}\u0027))"},{"line_number":477,"context_line":"        new_nfv_dict \u003d fields[\u0027parameters\u0027][\u0027nfv\u0027]"},{"line_number":478,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"32abd4ee_765b5b30","line":475,"in_reply_to":"0323827c_d713b6de","updated":"2023-01-24 04:21:51.000000000","message":"yes. I will add.","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b4561e1dd37861802cd3f0f4724ae231e7002fc6","unresolved":false,"context_lines":[{"line_number":472,"context_line":"        base_files.update(fields[\u0027files\u0027])"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        base_parameters \u003d heat_client.get_parameters(stack_name)"},{"line_number":475,"context_line":"        # NOTE: parameters[\u0027nfv\u0027] is string"},{"line_number":476,"context_line":"        base_nfv_dict \u003d json.loads(base_parameters.get(\u0027nfv\u0027, \u0027{}\u0027))"},{"line_number":477,"context_line":"        new_nfv_dict \u003d fields[\u0027parameters\u0027][\u0027nfv\u0027]"},{"line_number":478,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"23b6a88e_4cfa95ee","line":475,"in_reply_to":"32abd4ee_765b5b30","updated":"2023-01-24 07:23:21.000000000","message":"Done","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d39e8331f54a1546c1e384b71e6053683c911c16","unresolved":true,"context_lines":[{"line_number":385,"context_line":"            # StandardUserData (and its inheritance) or not."},{"line_number":386,"context_line":"            method \u003d self._change_vnfpkg_rolling_update_user_data_standard"},{"line_number":387,"context_line":"        else:"},{"line_number":388,"context_line":"            # method for DefaultUserDate (and its inheritance)"},{"line_number":389,"context_line":"            method \u003d self._change_vnfpkg_rolling_update_user_data_default"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        method(req, inst, grant_req, grant, vnfd, fields, heat_client,"}],"source_content_type":"text/x-python","patch_set":18,"id":"2a0a2532_dc4336c0","line":388,"updated":"2023-02-14 00:22:29.000000000","message":"typo: DefaultUserDate -\u003e DefaultUserData","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"0889f64323992e1b0947943ef847f7304bd96457","unresolved":true,"context_lines":[{"line_number":385,"context_line":"            # StandardUserData (and its inheritance) or not."},{"line_number":386,"context_line":"            method \u003d self._change_vnfpkg_rolling_update_user_data_standard"},{"line_number":387,"context_line":"        else:"},{"line_number":388,"context_line":"            # method for DefaultUserDate (and its inheritance)"},{"line_number":389,"context_line":"            method \u003d self._change_vnfpkg_rolling_update_user_data_default"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        method(req, inst, grant_req, grant, vnfd, fields, heat_client,"}],"source_content_type":"text/x-python","patch_set":18,"id":"49dea68d_d690ced0","line":388,"in_reply_to":"2a0a2532_dc4336c0","updated":"2023-02-14 00:53:23.000000000","message":"I will fix.","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9a4fb5c972fc69bb8e83c59d9a82150b42a92618","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            # StandardUserData (and its inheritance) or not."},{"line_number":386,"context_line":"            method \u003d self._change_vnfpkg_rolling_update_user_data_standard"},{"line_number":387,"context_line":"        else:"},{"line_number":388,"context_line":"            # method for DefaultUserDate (and its inheritance)"},{"line_number":389,"context_line":"            method \u003d self._change_vnfpkg_rolling_update_user_data_default"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        method(req, inst, grant_req, grant, vnfd, fields, heat_client,"}],"source_content_type":"text/x-python","patch_set":18,"id":"70609b00_d261b4a1","line":388,"in_reply_to":"49dea68d_d690ced0","updated":"2023-02-14 13:04:53.000000000","message":"Done","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"}],"tacker/sol_refactored/infra_drivers/openstack/userdata_standard.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":517,"context_line":"        for inst_vnfc in inst[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]:"},{"line_number":518,"context_line":"            vdu_idx \u003d inst_vnfc[\u0027metadata\u0027].get(\u0027vdu_idx\u0027)"},{"line_number":519,"context_line":"            if vdu_idx is None:"},{"line_number":520,"context_line":"                # should not be None. just check for consitency."},{"line_number":521,"context_line":"                continue"},{"line_number":522,"context_line":"            vdu_name \u003d inst_vnfc[\u0027vduId\u0027]"},{"line_number":523,"context_line":"            vdu_name_idx \u003d add_idx(vdu_name, vdu_idx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"d2e45222_188b13d7","line":520,"updated":"2022-12-14 09:49:13.000000000","message":"typo: consitency -\u003e consistency","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        for inst_vnfc in inst[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]:"},{"line_number":518,"context_line":"            vdu_idx \u003d inst_vnfc[\u0027metadata\u0027].get(\u0027vdu_idx\u0027)"},{"line_number":519,"context_line":"            if vdu_idx is None:"},{"line_number":520,"context_line":"                # should not be None. just check for consitency."},{"line_number":521,"context_line":"                continue"},{"line_number":522,"context_line":"            vdu_name \u003d inst_vnfc[\u0027vduId\u0027]"},{"line_number":523,"context_line":"            vdu_name_idx \u003d add_idx(vdu_name, vdu_idx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"d0cbff33_e0baeff1","line":520,"in_reply_to":"82004c95_adfccf7f","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":517,"context_line":"        for inst_vnfc in inst[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]:"},{"line_number":518,"context_line":"            vdu_idx \u003d inst_vnfc[\u0027metadata\u0027].get(\u0027vdu_idx\u0027)"},{"line_number":519,"context_line":"            if vdu_idx is None:"},{"line_number":520,"context_line":"                # should not be None. just check for consitency."},{"line_number":521,"context_line":"                continue"},{"line_number":522,"context_line":"            vdu_name \u003d inst_vnfc[\u0027vduId\u0027]"},{"line_number":523,"context_line":"            vdu_name_idx \u003d add_idx(vdu_name, vdu_idx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"82004c95_adfccf7f","line":520,"in_reply_to":"d2e45222_188b13d7","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":617,"context_line":"        for inst_vnfc in inst[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]:"},{"line_number":618,"context_line":"            vdu_idx \u003d inst_vnfc[\u0027metadata\u0027].get(\u0027vdu_idx\u0027)"},{"line_number":619,"context_line":"            if vdu_idx is None:"},{"line_number":620,"context_line":"                # should not be None. just check for consitency."},{"line_number":621,"context_line":"                continue"},{"line_number":622,"context_line":"            vdu_name \u003d inst_vnfc[\u0027vduId\u0027]"},{"line_number":623,"context_line":"            vdu_name_idx \u003d add_idx(vdu_name, vdu_idx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"4f9996c1_9c270e48","line":620,"updated":"2022-12-14 09:49:13.000000000","message":"ditto","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        for inst_vnfc in inst[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]:"},{"line_number":618,"context_line":"            vdu_idx \u003d inst_vnfc[\u0027metadata\u0027].get(\u0027vdu_idx\u0027)"},{"line_number":619,"context_line":"            if vdu_idx is None:"},{"line_number":620,"context_line":"                # should not be None. just check for consitency."},{"line_number":621,"context_line":"                continue"},{"line_number":622,"context_line":"            vdu_name \u003d inst_vnfc[\u0027vduId\u0027]"},{"line_number":623,"context_line":"            vdu_name_idx \u003d add_idx(vdu_name, vdu_idx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"2cb1e2f4_4bb74f91","line":620,"in_reply_to":"1eb33d55_6fb21792","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":617,"context_line":"        for inst_vnfc in inst[\u0027instantiatedVnfInfo\u0027][\u0027vnfcResourceInfo\u0027]:"},{"line_number":618,"context_line":"            vdu_idx \u003d inst_vnfc[\u0027metadata\u0027].get(\u0027vdu_idx\u0027)"},{"line_number":619,"context_line":"            if vdu_idx is None:"},{"line_number":620,"context_line":"                # should not be None. just check for consitency."},{"line_number":621,"context_line":"                continue"},{"line_number":622,"context_line":"            vdu_name \u003d inst_vnfc[\u0027vduId\u0027]"},{"line_number":623,"context_line":"            vdu_name_idx \u003d add_idx(vdu_name, vdu_idx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1eb33d55_6fb21792","line":620,"in_reply_to":"4f9996c1_9c270e48","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0c603f4805331b04f1348bf7aa8a1fd1b2f1ad86","unresolved":true,"context_lines":[{"line_number":542,"context_line":"                    images[image_vdu] \u003d value"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # NOTE: for \u0027VDU\u0027 unlike \u0027CP\u0027, ..."},{"line_number":545,"context_line":"        # TODO(oda): complete this comment"},{"line_number":546,"context_line":"        cur_nfv_dict \u003d common_script_utils.init_nfv_dict("},{"line_number":547,"context_line":"            {\u0027resources\u0027: cur_hot_reses})"},{"line_number":548,"context_line":"        new_nfv_dict \u003d common_script_utils.init_nfv_dict("}],"source_content_type":"text/x-python","patch_set":9,"id":"9db47cbf_6c043ee3","line":545,"updated":"2023-01-23 09:49:38.000000000","message":"Do you leave this TODO intentionally?","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b4561e1dd37861802cd3f0f4724ae231e7002fc6","unresolved":false,"context_lines":[{"line_number":542,"context_line":"                    images[image_vdu] \u003d value"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # NOTE: for \u0027VDU\u0027 unlike \u0027CP\u0027, ..."},{"line_number":545,"context_line":"        # TODO(oda): complete this comment"},{"line_number":546,"context_line":"        cur_nfv_dict \u003d common_script_utils.init_nfv_dict("},{"line_number":547,"context_line":"            {\u0027resources\u0027: cur_hot_reses})"},{"line_number":548,"context_line":"        new_nfv_dict \u003d common_script_utils.init_nfv_dict("}],"source_content_type":"text/x-python","patch_set":9,"id":"278ca8f2_0a8dd7e9","line":545,"in_reply_to":"904705c4_137743d5","updated":"2023-01-24 07:23:21.000000000","message":"Done","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9f328059f9d8f3eb099208d144e64ec0079f482e","unresolved":true,"context_lines":[{"line_number":542,"context_line":"                    images[image_vdu] \u003d value"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # NOTE: for \u0027VDU\u0027 unlike \u0027CP\u0027, ..."},{"line_number":545,"context_line":"        # TODO(oda): complete this comment"},{"line_number":546,"context_line":"        cur_nfv_dict \u003d common_script_utils.init_nfv_dict("},{"line_number":547,"context_line":"            {\u0027resources\u0027: cur_hot_reses})"},{"line_number":548,"context_line":"        new_nfv_dict \u003d common_script_utils.init_nfv_dict("}],"source_content_type":"text/x-python","patch_set":9,"id":"904705c4_137743d5","line":545,"in_reply_to":"9db47cbf_6c043ee3","updated":"2023-01-24 04:21:51.000000000","message":"I do not remember what I was going to comment on at all. I will remove this comment.","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0c603f4805331b04f1348bf7aa8a1fd1b2f1ad86","unresolved":true,"context_lines":[{"line_number":607,"context_line":"        top_hot \u003d hot_dict[\u0027template\u0027]"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        # first modify VDU resources"},{"line_number":610,"context_line":"        poped_vdu \u003d {}"},{"line_number":611,"context_line":"        for vdu_name in vnfd.get_vdu_nodes(flavour_id).keys():"},{"line_number":612,"context_line":"            poped_vdu[vdu_name] \u003d top_hot.get(\u0027resources\u0027, {}).pop(vdu_name)"},{"line_number":613,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"8c7dcd83_52ead530","line":610,"updated":"2023-01-23 09:49:38.000000000","message":"popped? grammatically","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b4561e1dd37861802cd3f0f4724ae231e7002fc6","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        top_hot \u003d hot_dict[\u0027template\u0027]"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        # first modify VDU resources"},{"line_number":610,"context_line":"        poped_vdu \u003d {}"},{"line_number":611,"context_line":"        for vdu_name in vnfd.get_vdu_nodes(flavour_id).keys():"},{"line_number":612,"context_line":"            poped_vdu[vdu_name] \u003d top_hot.get(\u0027resources\u0027, {}).pop(vdu_name)"},{"line_number":613,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"f77bc28f_0d5b18fc","line":610,"in_reply_to":"154aabed_cc72c4d5","updated":"2023-01-24 07:23:21.000000000","message":"Done","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9f328059f9d8f3eb099208d144e64ec0079f482e","unresolved":true,"context_lines":[{"line_number":607,"context_line":"        top_hot \u003d hot_dict[\u0027template\u0027]"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        # first modify VDU resources"},{"line_number":610,"context_line":"        poped_vdu \u003d {}"},{"line_number":611,"context_line":"        for vdu_name in vnfd.get_vdu_nodes(flavour_id).keys():"},{"line_number":612,"context_line":"            poped_vdu[vdu_name] \u003d top_hot.get(\u0027resources\u0027, {}).pop(vdu_name)"},{"line_number":613,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"154aabed_cc72c4d5","line":610,"in_reply_to":"8c7dcd83_52ead530","updated":"2023-01-24 04:21:51.000000000","message":"I will fix.","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"}],"tacker/tests/functional/sol_v2/test_individual_vnfc_mgmt.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fa125640cdc036699d03e35b9b79fab5f4656f70","unresolved":true,"context_lines":[{"line_number":675,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU1\u0027, 1, \u0027VDU1_CP4\u0027))"},{"line_number":676,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":677,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU2\u0027, 0, \u0027VDU2_CP4\u0027))"},{"line_number":678,"context_line":"        # check internal CPs, VDU1_CP3 and VDU_CP3 are changed"},{"line_number":679,"context_line":"        self.assertEqual(\"internalVL2\","},{"line_number":680,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"},{"line_number":681,"context_line":"        self.assertEqual(\"internalVL2\","}],"source_content_type":"text/x-python","patch_set":5,"id":"013596af_94fa6fbd","line":678,"updated":"2022-12-15 02:59:41.000000000","message":"VDU_CP3 -\u003e VDU2_CP3","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"5b450157a8aa803ff00967c19d4ab69c8671dc5b","unresolved":true,"context_lines":[{"line_number":675,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU1\u0027, 1, \u0027VDU1_CP4\u0027))"},{"line_number":676,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":677,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU2\u0027, 0, \u0027VDU2_CP4\u0027))"},{"line_number":678,"context_line":"        # check internal CPs, VDU1_CP3 and VDU_CP3 are changed"},{"line_number":679,"context_line":"        self.assertEqual(\"internalVL2\","},{"line_number":680,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"},{"line_number":681,"context_line":"        self.assertEqual(\"internalVL2\","}],"source_content_type":"text/x-python","patch_set":5,"id":"f92ebe22_1120c341","line":678,"in_reply_to":"013596af_94fa6fbd","updated":"2022-12-19 00:26:58.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":675,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU1\u0027, 1, \u0027VDU1_CP4\u0027))"},{"line_number":676,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":677,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU2\u0027, 0, \u0027VDU2_CP4\u0027))"},{"line_number":678,"context_line":"        # check internal CPs, VDU1_CP3 and VDU_CP3 are changed"},{"line_number":679,"context_line":"        self.assertEqual(\"internalVL2\","},{"line_number":680,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"},{"line_number":681,"context_line":"        self.assertEqual(\"internalVL2\","}],"source_content_type":"text/x-python","patch_set":5,"id":"95cf133f_f59a437a","line":678,"in_reply_to":"f92ebe22_1120c341","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fa125640cdc036699d03e35b9b79fab5f4656f70","unresolved":true,"context_lines":[{"line_number":785,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":786,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 1))"},{"line_number":787,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":788,"context_line":"        # check internal CPs, VDU1_CP3 and VDU_CP3 are not changed"},{"line_number":789,"context_line":"        self.assertEqual("},{"line_number":790,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027),"},{"line_number":791,"context_line":"            self._get_vnfc_cp_net_name(inst_2, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"ccbf8169_64c5a853","line":788,"updated":"2022-12-15 02:59:41.000000000","message":"VDU_CP3 -\u003e VDU2_CP3","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":785,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":786,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 1))"},{"line_number":787,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":788,"context_line":"        # check internal CPs, VDU1_CP3 and VDU_CP3 are not changed"},{"line_number":789,"context_line":"        self.assertEqual("},{"line_number":790,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027),"},{"line_number":791,"context_line":"            self._get_vnfc_cp_net_name(inst_2, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"e25607bb_c44962cc","line":788,"in_reply_to":"6af80624_c131c730","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"5b450157a8aa803ff00967c19d4ab69c8671dc5b","unresolved":true,"context_lines":[{"line_number":785,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":786,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 1))"},{"line_number":787,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":788,"context_line":"        # check internal CPs, VDU1_CP3 and VDU_CP3 are not changed"},{"line_number":789,"context_line":"        self.assertEqual("},{"line_number":790,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027),"},{"line_number":791,"context_line":"            self._get_vnfc_cp_net_name(inst_2, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"6af80624_c131c730","line":788,"in_reply_to":"ccbf8169_64c5a853","updated":"2022-12-19 00:26:58.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fa125640cdc036699d03e35b9b79fab5f4656f70","unresolved":true,"context_lines":[{"line_number":797,"context_line":"            self._get_vnfc_cp_net_name(inst_2, \u0027VDU2\u0027, 0, \u0027VDU2_CP3\u0027))"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        # Terminate VNF instance"},{"line_number":800,"context_line":"        terminate_req \u003d paramgen.sample5_terminate()"},{"line_number":801,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":802,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":803,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e5ebd15a_04aeef37","line":800,"updated":"2022-12-15 02:59:41.000000000","message":"The content is the same, but since it has already been rolled back, isn\u0027t it better to use sample3\u0027s terminate?","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":797,"context_line":"            self._get_vnfc_cp_net_name(inst_2, \u0027VDU2\u0027, 0, \u0027VDU2_CP3\u0027))"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        # Terminate VNF instance"},{"line_number":800,"context_line":"        terminate_req \u003d paramgen.sample5_terminate()"},{"line_number":801,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":802,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":803,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"73a91d26_0f9dae91","line":800,"in_reply_to":"c7c9a15f_eeda6ff4","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"5b450157a8aa803ff00967c19d4ab69c8671dc5b","unresolved":true,"context_lines":[{"line_number":797,"context_line":"            self._get_vnfc_cp_net_name(inst_2, \u0027VDU2\u0027, 0, \u0027VDU2_CP3\u0027))"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        # Terminate VNF instance"},{"line_number":800,"context_line":"        terminate_req \u003d paramgen.sample5_terminate()"},{"line_number":801,"context_line":"        resp, body \u003d self.terminate_vnf_instance(inst_id, terminate_req)"},{"line_number":802,"context_line":"        self.assertEqual(202, resp.status_code)"},{"line_number":803,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c7c9a15f_eeda6ff4","line":800,"in_reply_to":"e5ebd15a_04aeef37","updated":"2022-12-19 00:26:58.000000000","message":"I see. I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d39e8331f54a1546c1e384b71e6053683c911c16","unresolved":true,"context_lines":[{"line_number":663,"context_line":"        # check flavor is changed (VDU2 only)"},{"line_number":664,"context_line":"        self.assertNotEqual(self._get_vnfc_flavor(inst_1, \u0027VDU2\u0027, 0),"},{"line_number":665,"context_line":"                            self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":666,"context_line":"        # check external CPs, VDU1_CP4 and VDU2_CP4 are added"},{"line_number":667,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_1, \u0027VDU1\u0027, 0))"},{"line_number":668,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_1, \u0027VDU1\u0027, 1))"},{"line_number":669,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_1, \u0027VDU2\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a7279db_833bc627","line":666,"range":{"start_line":666,"start_character":28,"end_line":666,"end_character":29},"updated":"2023-02-14 00:22:29.000000000","message":"external CPs and VDU1_CP4 could be mistaken for parallel, so `;` (semicolon) is better.\n`ex. # check external CPs; VDU1_CP4 and VDU2_CP4 are added`","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"0889f64323992e1b0947943ef847f7304bd96457","unresolved":true,"context_lines":[{"line_number":663,"context_line":"        # check flavor is changed (VDU2 only)"},{"line_number":664,"context_line":"        self.assertNotEqual(self._get_vnfc_flavor(inst_1, \u0027VDU2\u0027, 0),"},{"line_number":665,"context_line":"                            self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":666,"context_line":"        # check external CPs, VDU1_CP4 and VDU2_CP4 are added"},{"line_number":667,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_1, \u0027VDU1\u0027, 0))"},{"line_number":668,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_1, \u0027VDU1\u0027, 1))"},{"line_number":669,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_1, \u0027VDU2\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":18,"id":"b6918793_c9fdc15f","line":666,"range":{"start_line":666,"start_character":28,"end_line":666,"end_character":29},"in_reply_to":"9a7279db_833bc627","updated":"2023-02-14 00:53:23.000000000","message":"I will fix.","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9a4fb5c972fc69bb8e83c59d9a82150b42a92618","unresolved":false,"context_lines":[{"line_number":663,"context_line":"        # check flavor is changed (VDU2 only)"},{"line_number":664,"context_line":"        self.assertNotEqual(self._get_vnfc_flavor(inst_1, \u0027VDU2\u0027, 0),"},{"line_number":665,"context_line":"                            self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":666,"context_line":"        # check external CPs, VDU1_CP4 and VDU2_CP4 are added"},{"line_number":667,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_1, \u0027VDU1\u0027, 0))"},{"line_number":668,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_1, \u0027VDU1\u0027, 1))"},{"line_number":669,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_1, \u0027VDU2\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":18,"id":"9f192f49_39227808","line":666,"range":{"start_line":666,"start_character":28,"end_line":666,"end_character":29},"in_reply_to":"b6918793_c9fdc15f","updated":"2023-02-14 13:04:53.000000000","message":"Done","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d39e8331f54a1546c1e384b71e6053683c911c16","unresolved":true,"context_lines":[{"line_number":676,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU1\u0027, 1, \u0027VDU1_CP4\u0027))"},{"line_number":677,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":678,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU2\u0027, 0, \u0027VDU2_CP4\u0027))"},{"line_number":679,"context_line":"        # check internal CPs, VDU1_CP3 and VDU2_CP3 are changed"},{"line_number":680,"context_line":"        self.assertEqual(\"internalVL2\","},{"line_number":681,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"},{"line_number":682,"context_line":"        self.assertEqual(\"internalVL2\","}],"source_content_type":"text/x-python","patch_set":18,"id":"03acbc28_014cdec4","line":679,"range":{"start_line":679,"start_character":28,"end_line":679,"end_character":29},"updated":"2023-02-14 00:22:29.000000000","message":"ditto. (,-\u003e;)","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"0889f64323992e1b0947943ef847f7304bd96457","unresolved":true,"context_lines":[{"line_number":676,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU1\u0027, 1, \u0027VDU1_CP4\u0027))"},{"line_number":677,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":678,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU2\u0027, 0, \u0027VDU2_CP4\u0027))"},{"line_number":679,"context_line":"        # check internal CPs, VDU1_CP3 and VDU2_CP3 are changed"},{"line_number":680,"context_line":"        self.assertEqual(\"internalVL2\","},{"line_number":681,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"},{"line_number":682,"context_line":"        self.assertEqual(\"internalVL2\","}],"source_content_type":"text/x-python","patch_set":18,"id":"2ddb80dd_eb8ec5f3","line":679,"range":{"start_line":679,"start_character":28,"end_line":679,"end_character":29},"in_reply_to":"03acbc28_014cdec4","updated":"2023-02-14 00:53:23.000000000","message":"I will fix.","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9a4fb5c972fc69bb8e83c59d9a82150b42a92618","unresolved":false,"context_lines":[{"line_number":676,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU1\u0027, 1, \u0027VDU1_CP4\u0027))"},{"line_number":677,"context_line":"        self.assertEqual(net_ids[\u0027net0\u0027],"},{"line_number":678,"context_line":"            self._get_vnfc_cp_net_id(inst_2, \u0027VDU2\u0027, 0, \u0027VDU2_CP4\u0027))"},{"line_number":679,"context_line":"        # check internal CPs, VDU1_CP3 and VDU2_CP3 are changed"},{"line_number":680,"context_line":"        self.assertEqual(\"internalVL2\","},{"line_number":681,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"},{"line_number":682,"context_line":"        self.assertEqual(\"internalVL2\","}],"source_content_type":"text/x-python","patch_set":18,"id":"a87c6b7f_43c0f7b8","line":679,"range":{"start_line":679,"start_character":28,"end_line":679,"end_character":29},"in_reply_to":"2ddb80dd_eb8ec5f3","updated":"2023-02-14 13:04:53.000000000","message":"Done","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d39e8331f54a1546c1e384b71e6053683c911c16","unresolved":true,"context_lines":[{"line_number":782,"context_line":"        # check flavor is not changed (VDU2 only)"},{"line_number":783,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_1, \u0027VDU2\u0027, 0),"},{"line_number":784,"context_line":"                         self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":785,"context_line":"        # check external CPs, VDU1_CP4 and VDU2_CP4 are not added"},{"line_number":786,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":787,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 1))"},{"line_number":788,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":18,"id":"64f7849e_8a268a0a","line":785,"range":{"start_line":785,"start_character":28,"end_line":785,"end_character":29},"updated":"2023-02-14 00:22:29.000000000","message":"ditto. (,-\u003e;)","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"0889f64323992e1b0947943ef847f7304bd96457","unresolved":true,"context_lines":[{"line_number":782,"context_line":"        # check flavor is not changed (VDU2 only)"},{"line_number":783,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_1, \u0027VDU2\u0027, 0),"},{"line_number":784,"context_line":"                         self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":785,"context_line":"        # check external CPs, VDU1_CP4 and VDU2_CP4 are not added"},{"line_number":786,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":787,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 1))"},{"line_number":788,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":18,"id":"e6ecfe28_16123ed9","line":785,"range":{"start_line":785,"start_character":28,"end_line":785,"end_character":29},"in_reply_to":"64f7849e_8a268a0a","updated":"2023-02-14 00:53:23.000000000","message":"I will fix.","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9a4fb5c972fc69bb8e83c59d9a82150b42a92618","unresolved":false,"context_lines":[{"line_number":782,"context_line":"        # check flavor is not changed (VDU2 only)"},{"line_number":783,"context_line":"        self.assertEqual(self._get_vnfc_flavor(inst_1, \u0027VDU2\u0027, 0),"},{"line_number":784,"context_line":"                         self._get_vnfc_flavor(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":785,"context_line":"        # check external CPs, VDU1_CP4 and VDU2_CP4 are not added"},{"line_number":786,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":787,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 1))"},{"line_number":788,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"}],"source_content_type":"text/x-python","patch_set":18,"id":"e83c08bb_387561b4","line":785,"range":{"start_line":785,"start_character":28,"end_line":785,"end_character":29},"in_reply_to":"e6ecfe28_16123ed9","updated":"2023-02-14 13:04:53.000000000","message":"Done","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d39e8331f54a1546c1e384b71e6053683c911c16","unresolved":true,"context_lines":[{"line_number":786,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":787,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 1))"},{"line_number":788,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":789,"context_line":"        # check internal CPs, VDU1_CP3 and VDU2_CP3 are not changed"},{"line_number":790,"context_line":"        self.assertEqual("},{"line_number":791,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027),"},{"line_number":792,"context_line":"            self._get_vnfc_cp_net_name(inst_2, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"}],"source_content_type":"text/x-python","patch_set":18,"id":"f3b1c4bd_ef7e4dad","line":789,"range":{"start_line":789,"start_character":28,"end_line":789,"end_character":29},"updated":"2023-02-14 00:22:29.000000000","message":"ditto. (,-\u003e;)","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9a4fb5c972fc69bb8e83c59d9a82150b42a92618","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":787,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 1))"},{"line_number":788,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":789,"context_line":"        # check internal CPs, VDU1_CP3 and VDU2_CP3 are not changed"},{"line_number":790,"context_line":"        self.assertEqual("},{"line_number":791,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027),"},{"line_number":792,"context_line":"            self._get_vnfc_cp_net_name(inst_2, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"}],"source_content_type":"text/x-python","patch_set":18,"id":"47d3665c_970d1036","line":789,"range":{"start_line":789,"start_character":28,"end_line":789,"end_character":29},"in_reply_to":"281a1304_14a88478","updated":"2023-02-14 13:04:53.000000000","message":"Done","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"0889f64323992e1b0947943ef847f7304bd96457","unresolved":true,"context_lines":[{"line_number":786,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 0))"},{"line_number":787,"context_line":"        self.assertFalse(\u0027VDU1_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU1\u0027, 1))"},{"line_number":788,"context_line":"        self.assertFalse(\u0027VDU2_CP4\u0027 in self._get_vnfc_cps(inst_2, \u0027VDU2\u0027, 0))"},{"line_number":789,"context_line":"        # check internal CPs, VDU1_CP3 and VDU2_CP3 are not changed"},{"line_number":790,"context_line":"        self.assertEqual("},{"line_number":791,"context_line":"            self._get_vnfc_cp_net_name(inst_1, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027),"},{"line_number":792,"context_line":"            self._get_vnfc_cp_net_name(inst_2, \u0027VDU1\u0027, 0, \u0027VDU1_CP3\u0027))"}],"source_content_type":"text/x-python","patch_set":18,"id":"281a1304_14a88478","line":789,"range":{"start_line":789,"start_character":28,"end_line":789,"end_character":29},"in_reply_to":"f3b1c4bd_ef7e4dad","updated":"2023-02-14 00:53:23.000000000","message":"I will fix.","commit_id":"44c2d1f4e245f091542b94e89d0e94b5ac78b3a4"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d39e8331f54a1546c1e384b71e6053683c911c16","unresolved":true,"context_lines":[{"line_number":594,"context_line":"    def test_change_vnfpkg_nw(self):"},{"line_number":595,"context_line":"        \"\"\"Test change_vnfpkg with additional functions"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        * Note:"},{"line_number":598,"context_line":"          This test focuses change_vnfpkg with the following changes."},{"line_number":599,"context_line":"          - adding external CP"},{"line_number":600,"context_line":"          - change internal network"}],"source_content_type":"text/x-python","patch_set":19,"id":"f6ddb47d_f3638210","line":597,"updated":"2023-02-14 00:22:29.000000000","message":"This is a general question, do these FTs cover all patterns for the network change features?\nIf you have any TODOs, please leave them as comments.","commit_id":"9ce9fea2cf4093e150a977687c06d3e1444f6663"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9a4fb5c972fc69bb8e83c59d9a82150b42a92618","unresolved":false,"context_lines":[{"line_number":594,"context_line":"    def test_change_vnfpkg_nw(self):"},{"line_number":595,"context_line":"        \"\"\"Test change_vnfpkg with additional functions"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        * Note:"},{"line_number":598,"context_line":"          This test focuses change_vnfpkg with the following changes."},{"line_number":599,"context_line":"          - adding external CP"},{"line_number":600,"context_line":"          - change internal network"}],"source_content_type":"text/x-python","patch_set":19,"id":"bd887824_44afd6a0","line":597,"in_reply_to":"b57dcad6_ec45827a","updated":"2023-02-14 13:04:53.000000000","message":"Thanks for adding TODO. Done.","commit_id":"9ce9fea2cf4093e150a977687c06d3e1444f6663"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"0889f64323992e1b0947943ef847f7304bd96457","unresolved":true,"context_lines":[{"line_number":594,"context_line":"    def test_change_vnfpkg_nw(self):"},{"line_number":595,"context_line":"        \"\"\"Test change_vnfpkg with additional functions"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"        * Note:"},{"line_number":598,"context_line":"          This test focuses change_vnfpkg with the following changes."},{"line_number":599,"context_line":"          - adding external CP"},{"line_number":600,"context_line":"          - change internal network"}],"source_content_type":"text/x-python","patch_set":19,"id":"b57dcad6_ec45827a","line":597,"in_reply_to":"f6ddb47d_f3638210","updated":"2023-02-14 00:53:23.000000000","message":"\u003e This is a general question, do these FTs cover all patterns for the network change features?\nNo.\nOK, I will add a comment.","commit_id":"9ce9fea2cf4093e150a977687c06d3e1444f6663"}],"tacker/tests/functional/sol_v2_common/paramgen.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c7171fc7fa73afe941ee3788dcacfc4d643370dd","unresolved":true,"context_lines":[{"line_number":1206,"context_line":"    }"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"# sample5 is for change_vnfpkg test of StandardUserData"},{"line_number":1210,"context_line":"#"},{"line_number":1211,"context_line":"def sample5_change_vnfpkg(vnfd_id, net_ids, subnet_ids):"},{"line_number":1212,"context_line":"    ext_vl_4 \u003d {"}],"source_content_type":"text/x-python","patch_set":16,"id":"c34289a0_c9762e32","line":1209,"range":{"start_line":1209,"start_character":0,"end_line":1209,"end_character":55},"updated":"2023-02-09 06:17:47.000000000","message":"This comment is same as for `sample4` [1].\nCould you describe the differences in the comments for other developers?\n\n[1] https://review.opendev.org/c/openstack/tacker/+/866544/16/tacker/tests/functional/sol_v2_common/paramgen.py#1117","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5fa0ea97f5e368275f5130d5232d39ff7da30299","unresolved":false,"context_lines":[{"line_number":1206,"context_line":"    }"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"# sample5 is for change_vnfpkg test of StandardUserData"},{"line_number":1210,"context_line":"#"},{"line_number":1211,"context_line":"def sample5_change_vnfpkg(vnfd_id, net_ids, subnet_ids):"},{"line_number":1212,"context_line":"    ext_vl_4 \u003d {"}],"source_content_type":"text/x-python","patch_set":16,"id":"e76be985_5e8015ae","line":1209,"range":{"start_line":1209,"start_character":0,"end_line":1209,"end_character":55},"in_reply_to":"66baf8ad_614d88e0","updated":"2023-02-10 06:19:43.000000000","message":"Ack","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"1e528f9e100ae032c787ee49028c025af4d2ba4b","unresolved":true,"context_lines":[{"line_number":1206,"context_line":"    }"},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"# sample5 is for change_vnfpkg test of StandardUserData"},{"line_number":1210,"context_line":"#"},{"line_number":1211,"context_line":"def sample5_change_vnfpkg(vnfd_id, net_ids, subnet_ids):"},{"line_number":1212,"context_line":"    ext_vl_4 \u003d {"}],"source_content_type":"text/x-python","patch_set":16,"id":"66baf8ad_614d88e0","line":1209,"range":{"start_line":1209,"start_character":0,"end_line":1209,"end_character":55},"in_reply_to":"c34289a0_c9762e32","updated":"2023-02-09 23:42:29.000000000","message":"I see. I fill fix.","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard/contents/BaseHOT/simple/nested/VDU2.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  multi:"},{"line_number":46,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":47,"context_line":"    properties:"},{"line_number":48,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":49,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d342c94d_150c9e2d","line":48,"updated":"2022-12-14 09:49:13.000000000","message":"I don\u0027t think VolumeType is necessary for each Volume.\nCould you please modify it to create a VolumeType for each VDU like basic_lcms_max?\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max/contents/BaseHOT/simple/sample1.yaml#L33-L37\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max/contents/BaseHOT/simple/nested/VDU1.yaml#L54","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fbf89b68cb462fdcb380216dbe9d281d168b4fe8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  multi:"},{"line_number":46,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":47,"context_line":"    properties:"},{"line_number":48,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":49,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4e23c2a7_2fcd7418","line":48,"in_reply_to":"6e51a1df_1a4a6107","updated":"2023-01-24 05:10:46.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  multi:"},{"line_number":46,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":47,"context_line":"    properties:"},{"line_number":48,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":49,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6e51a1df_1a4a6107","line":48,"in_reply_to":"d342c94d_150c9e2d","updated":"2022-12-19 00:20:26.000000000","message":"same as above.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg/contents/BaseHOT/simple/nested/VDU1.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b9a3c740_7c8dc297","line":28,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d79ea85e_280a5a6a","line":28,"in_reply_to":"b9a3c740_7c8dc297","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f14b61cd_3ae0b221","line":28,"in_reply_to":"d79ea85e_280a5a6a","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"},{"line_number":32,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"be765f4b_c1c73726","line":29,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"},{"line_number":32,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f51099a_cd35508a","line":29,"in_reply_to":"6c89b757_943935e0","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"},{"line_number":32,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6c89b757_943935e0","line":29,"in_reply_to":"be765f4b_c1c73726","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"435af5bc_f200ce63","line":42,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4bb80b38_eafc89a1","line":42,"in_reply_to":"435af5bc_f200ce63","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"928e75bf_3f471f55","line":42,"in_reply_to":"4bb80b38_eafc89a1","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"},{"line_number":46,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c9c25ced_0d11ce10","line":43,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"},{"line_number":46,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"eaace24f_f0005769","line":43,"in_reply_to":"5fc43df9_0065ea44","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"},{"line_number":46,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5fc43df9_0065ea44","line":43,"in_reply_to":"c9c25ced_0d11ce10","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg/contents/BaseHOT/simple/nested/VDU2.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"64513bba_9d878b89","line":30,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"72f3fc78_084af7be","line":30,"in_reply_to":"64513bba_9d878b89","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e855b1ef_7d00cb9a","line":30,"in_reply_to":"72f3fc78_084af7be","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"},{"line_number":34,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a07b604_7fa3b957","line":31,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"},{"line_number":34,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"421a974c_a63858cf","line":31,"in_reply_to":"1a07b604_7fa3b957","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"},{"line_number":34,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0cea1a60_8844dd34","line":31,"in_reply_to":"421a974c_a63858cf","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  multi:"},{"line_number":46,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":47,"context_line":"    properties:"},{"line_number":48,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":49,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a8c5a81f_9f26fd19","line":48,"updated":"2022-12-14 09:49:13.000000000","message":"I don\u0027t think VolumeType is necessary for each Volume.\nCould you please modify it to create a VolumeType for each VDU like basic_lcms_max?\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max/contents/BaseHOT/simple/sample1.yaml#L33-L37\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max/contents/BaseHOT/simple/nested/VDU1.yaml#L54","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fbf89b68cb462fdcb380216dbe9d281d168b4fe8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  multi:"},{"line_number":46,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":47,"context_line":"    properties:"},{"line_number":48,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":49,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"78ab2ac7_118e36f7","line":48,"in_reply_to":"6cb1b427_c998a168","updated":"2023-01-24 05:10:46.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":45,"context_line":"  multi:"},{"line_number":46,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":47,"context_line":"    properties:"},{"line_number":48,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":49,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6cb1b427_c998a168","line":48,"in_reply_to":"a8c5a81f_9f26fd19","updated":"2022-12-19 00:20:26.000000000","message":"same as above.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":56,"context_line":"      fixed_ips:"},{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1ef5f0a5_10ea527d","line":59,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":56,"context_line":"      fixed_ips:"},{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c4869964_85f4edc6","line":59,"in_reply_to":"1ef5f0a5_10ea527d","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      fixed_ips:"},{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e383a32a_57873d93","line":59,"in_reply_to":"c4869964_85f4edc6","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"},{"line_number":63,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"97f6639b_09002938","line":60,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"},{"line_number":63,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d4ea0292_ed413999","line":60,"in_reply_to":"97f6639b_09002938","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"},{"line_number":63,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f0661f4_0ce6edd1","line":60,"in_reply_to":"d4ea0292_ed413999","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg/contents/BaseHOT/simple/sample4.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      net3: { get_resource: internalVL2 }"},{"line_number":28,"context_line":"      affinity: { get_resource: nfvi_node_affinity }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"  internalVL1:"},{"line_number":32,"context_line":"    type: OS::Neutron::Net"},{"line_number":33,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4510a7b4_4d6f5df6","line":30,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs\n\nThe following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      net3: { get_resource: internalVL2 }"},{"line_number":28,"context_line":"      affinity: { get_resource: nfvi_node_affinity }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"  internalVL1:"},{"line_number":32,"context_line":"    type: OS::Neutron::Net"},{"line_number":33,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"148774ed_e5b87c89","line":30,"in_reply_to":"40aabe8c_4945722c","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      net3: { get_resource: internalVL2 }"},{"line_number":28,"context_line":"      affinity: { get_resource: nfvi_node_affinity }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"  internalVL1:"},{"line_number":32,"context_line":"    type: OS::Neutron::Net"},{"line_number":33,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"40aabe8c_4945722c","line":30,"in_reply_to":"4510a7b4_4d6f5df6","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg_nw/contents/BaseHOT/simple/nested/VDU1-ver2.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU1_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU1_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4e906953_da85eb07","line":30,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU1_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU1_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9ec12a1f_946c7abb","line":30,"in_reply_to":"26f330f6_6933fd0e","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU1_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU1_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"26f330f6_6933fd0e","line":30,"in_reply_to":"4e906953_da85eb07","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU1_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU1_CP2"},{"line_number":34,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"be84d679_37f98907","line":31,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU1_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU1_CP2"},{"line_number":34,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"14f4edbf_d7899daa","line":31,"in_reply_to":"aab9c939_1cc35b79","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU1_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU1_CP2"},{"line_number":34,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"aab9c939_1cc35b79","line":31,"in_reply_to":"be84d679_37f98907","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: net4 }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":52,"context_line":"# specified in instantiatevnfrequest"},{"line_number":53,"context_line":"  VDU1_CP2:"},{"line_number":54,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"216350da_6c48f2b2","line":51,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: net4 }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":52,"context_line":"# specified in instantiatevnfrequest"},{"line_number":53,"context_line":"  VDU1_CP2:"},{"line_number":54,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a7c37a4_93fa292f","line":51,"in_reply_to":"216350da_6c48f2b2","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    properties:"},{"line_number":49,"context_line":"      network: { get_param: net4 }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":52,"context_line":"# specified in instantiatevnfrequest"},{"line_number":53,"context_line":"  VDU1_CP2:"},{"line_number":54,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"86e940f0_e5ec6a1a","line":51,"in_reply_to":"3a7c37a4_93fa292f","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":49,"context_line":"      network: { get_param: net4 }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":52,"context_line":"# specified in instantiatevnfrequest"},{"line_number":53,"context_line":"  VDU1_CP2:"},{"line_number":54,"context_line":"    type: OS::Neutron::Port"},{"line_number":55,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8ba812be_89afd759","line":52,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":49,"context_line":"      network: { get_param: net4 }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":52,"context_line":"# specified in instantiatevnfrequest"},{"line_number":53,"context_line":"  VDU1_CP2:"},{"line_number":54,"context_line":"    type: OS::Neutron::Port"},{"line_number":55,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c004ddce_0eaf3189","line":52,"in_reply_to":"8ba812be_89afd759","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      network: { get_param: net4 }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":52,"context_line":"# specified in instantiatevnfrequest"},{"line_number":53,"context_line":"  VDU1_CP2:"},{"line_number":54,"context_line":"    type: OS::Neutron::Port"},{"line_number":55,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"51a72277_cedbf639","line":52,"in_reply_to":"c004ddce_0eaf3189","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg_nw/contents/BaseHOT/simple/nested/VDU2-ver2.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":29,"context_line":"      networks:"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU2_CP1"},{"line_number":32,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":33,"context_line":"# specified in instantiatevnfrequest"},{"line_number":34,"context_line":"      - port:"},{"line_number":35,"context_line":"          get_resource: VDU2_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"721f2db9_272df467","line":32,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      networks:"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU2_CP1"},{"line_number":32,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":33,"context_line":"# specified in instantiatevnfrequest"},{"line_number":34,"context_line":"      - port:"},{"line_number":35,"context_line":"          get_resource: VDU2_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a13e6718_b4c15b6a","line":32,"in_reply_to":"34839dd8_1362945c","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":29,"context_line":"      networks:"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU2_CP1"},{"line_number":32,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":33,"context_line":"# specified in instantiatevnfrequest"},{"line_number":34,"context_line":"      - port:"},{"line_number":35,"context_line":"          get_resource: VDU2_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"34839dd8_1362945c","line":32,"in_reply_to":"721f2db9_272df467","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU2_CP1"},{"line_number":32,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":33,"context_line":"# specified in instantiatevnfrequest"},{"line_number":34,"context_line":"      - port:"},{"line_number":35,"context_line":"          get_resource: VDU2_CP2"},{"line_number":36,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1ebc4758_b4ed69db","line":33,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU2_CP1"},{"line_number":32,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":33,"context_line":"# specified in instantiatevnfrequest"},{"line_number":34,"context_line":"      - port:"},{"line_number":35,"context_line":"          get_resource: VDU2_CP2"},{"line_number":36,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"53ad5e9e_eb6bb98e","line":33,"in_reply_to":"1ebc4758_b4ed69db","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU2_CP1"},{"line_number":32,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":33,"context_line":"# specified in instantiatevnfrequest"},{"line_number":34,"context_line":"      - port:"},{"line_number":35,"context_line":"          get_resource: VDU2_CP2"},{"line_number":36,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a4d70cd_1891fe46","line":33,"in_reply_to":"53ad5e9e_eb6bb98e","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  multi:"},{"line_number":50,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":51,"context_line":"    properties:"},{"line_number":52,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":53,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ab84a0c8_80cb9b67","line":52,"updated":"2022-12-14 09:49:13.000000000","message":"I don\u0027t think VolumeType is necessary for each Volume.\nCould you please modify it to create a VolumeType for each VDU like basic_lcms_max?\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max/contents/BaseHOT/simple/sample1.yaml#L33-L37\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_v2_common/samples/basic_lcms_max/contents/BaseHOT/simple/nested/VDU1.yaml#L54","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b2ad91a56c9c0082b8315c3913e44457e631a50b","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  multi:"},{"line_number":50,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":51,"context_line":"    properties:"},{"line_number":52,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":53,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d176aae3_6d9b0c3a","line":52,"in_reply_to":"36c2fd8b_2672d807","updated":"2022-12-19 22:23:34.000000000","message":"\u003e (Is there a problem if the name is \"VDU2-multi\"?)\n\nIs it OK if other vnf package using VolmeType \"VDU2-multi\" or other vnf instance using same vnf package exist ?","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"74e903860ac68c9f7644d40feb89cc909bf741ce","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  multi:"},{"line_number":50,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":51,"context_line":"    properties:"},{"line_number":52,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":53,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"36c2fd8b_2672d807","line":52,"in_reply_to":"4b5f420b_deab65ab","updated":"2022-12-19 09:45:34.000000000","message":"As mentioned above, basic_lcms_max uses one Volume Type(VDU1-multi) for multiple Volumes(VDU1-VirtualStorage).\nI think we can do the same with the StandardUserData class by modifying it as follows.\n```\n$ diff -u ../userdata_standard/contents/BaseHOT/simple/sample3.yaml contents/BaseHOT/simple/sample3.yaml\n--- ../userdata_standard/contents/BaseHOT/simple/sample3.yaml\t2022-12-19 04:30:10.629795933 +0000\n+++ contents/BaseHOT/simple/sample3.yaml\t2022-12-19 09:20:00.297016973 +0000\n@@ -26,6 +26,7 @@\n       net2: { get_resource: internalVL1 }\n       net3: { get_resource: internalVL2 }\n       affinity: { get_resource: nfvi_node_affinity }\n+      volume_type: { get_resource: VDU2-VolumeType }\n\n # delete the following lines when extmanagedVLs are specified in instantiatevnfrequest\n   internalVL1:\n@@ -54,4 +55,10 @@\n       name: nfvi_node_affinity\n       policies: [ \u0027affinity\u0027 ]\n\n+  VDU2-VolumeType:\n+    type: OS::Cinder::VolumeType\n+    properties:\n+      name: VDU2-multi\n+      metadata: { multiattach: \"\u003cis\u003e True\" }\n+\n outputs: {}\n\n$ diff -u ../userdata_standard/contents/BaseHOT/simple/nested/VDU2.yaml contents/BaseHOT/simple/nested/VDU2.yaml\n--- ../userdata_standard/contents/BaseHOT/simple/nested/VDU2.yaml\t2022-12-19 07:49:40.585730214 +0000\n+++ contents/BaseHOT/simple/nested/VDU2.yaml\t2022-12-19 09:21:53.785022385 +0000\n@@ -16,6 +16,8 @@\n     type: string\n   affinity:\n     type: string\n+  volume_type:\n+    type: string\n\n resources:\n   VDU2:\n@@ -41,12 +43,7 @@\n     properties:\n       image: { get_param: image-VDU2-VirtualStorage }\n       size: 1\n-      volume_type: { get_resource: multi }\n-  multi:\n-    type: OS::Cinder::VolumeType\n-    properties:\n-      name: { get_resource: VDU2_CP1 }  # just intend making unique name\n-      metadata: { multiattach: \"\u003cis\u003e True\" }\n+      volume_type: { get_param: volume_type }\n\n # extVL with numDynamicAddresses and subnet\n   VDU2_CP1:\n```\n\nBy the way, \"max_number_of_instances\" of VDU2 is \"1\".\nWhat is the purpose of this modification?\n(Is there a problem if the name is \"VDU2-multi\"?)","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"fbf89b68cb462fdcb380216dbe9d281d168b4fe8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  multi:"},{"line_number":50,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":51,"context_line":"    properties:"},{"line_number":52,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":53,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"473982b0_d73f50b6","line":52,"in_reply_to":"76874b5e_3b03c20f","updated":"2023-01-24 05:10:46.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  multi:"},{"line_number":50,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":51,"context_line":"    properties:"},{"line_number":52,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":53,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4b5f420b_deab65ab","line":52,"in_reply_to":"ab84a0c8_80cb9b67","updated":"2022-12-19 00:20:26.000000000","message":"I think it is better to define VolumeType in the base HOT too. But it is not able to instantiate multiple instances using the example you mentioned because the name of VolumeType is not unique. Please let me know if you have a good idea.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"af219e11286681ee601d0e45b3899a67880083e4","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  multi:"},{"line_number":50,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":51,"context_line":"    properties:"},{"line_number":52,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":53,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f27e8b79_4ee0ab72","line":52,"in_reply_to":"d176aae3_6d9b0c3a","updated":"2022-12-20 02:57:00.000000000","message":"Thank you for your reply.\nHow about using the stack name instead of the CP resource id to make it a unique name?\n-----\nname: { list_join: [\u0027-\u0027, [get_param: OS::stack_name, \u0027VDU2-multi\u0027]] }\n-----\n```\n$ openstack volume type list\n+--------------------------------------+-------------------------------------------------------------------------+-----------+\n| ID                                   | Name                                                                    | Is Public |\n+--------------------------------------+-------------------------------------------------------------------------+-----------+\n| 7bfd75a6-2e06-42a6-8b7b-b4a9457d6f1b | vnf-cbceb65a-ac01-4e14-a042-9d9b94041cb3-VDU2-0-h5ez3lwcwbpk-VDU2-multi | True      |\n| 3f7438c6-1403-4d34-bd36-381d4da90ecc | lvmdriver-1                                                             | True      |\n| 8ca7a921-0e8d-48bf-812a-62f4bde49388 | __DEFAULT__                                                             | True      |\n+--------------------------------------+-------------------------------------------------------------------------+-----------+\n```","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"cc66732fe83e17bd97b709050415d51ed11f0f1d","unresolved":true,"context_lines":[{"line_number":49,"context_line":"  multi:"},{"line_number":50,"context_line":"    type: OS::Cinder::VolumeType"},{"line_number":51,"context_line":"    properties:"},{"line_number":52,"context_line":"      name: { get_resource: VDU2_CP1 }  # just intend making unique name"},{"line_number":53,"context_line":"      metadata: { multiattach: \"\u003cis\u003e True\" }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# extVL with numDynamicAddresses and subnet"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"76874b5e_3b03c20f","line":52,"in_reply_to":"f27e8b79_4ee0ab72","updated":"2022-12-20 04:11:55.000000000","message":"I think it is a good idea. I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    properties:"},{"line_number":66,"context_line":"      network: { get_param: net4 }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":69,"context_line":"# specified in instantiatevnfrequest"},{"line_number":70,"context_line":"  VDU2_CP2:"},{"line_number":71,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2b8ca9e2_d3584a31","line":68,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    properties:"},{"line_number":66,"context_line":"      network: { get_param: net4 }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":69,"context_line":"# specified in instantiatevnfrequest"},{"line_number":70,"context_line":"  VDU2_CP2:"},{"line_number":71,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fafbb839_044efcf4","line":68,"in_reply_to":"2b8ca9e2_d3584a31","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    properties:"},{"line_number":66,"context_line":"      network: { get_param: net4 }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":69,"context_line":"# specified in instantiatevnfrequest"},{"line_number":70,"context_line":"  VDU2_CP2:"},{"line_number":71,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"eea6f95f_92092517","line":68,"in_reply_to":"fafbb839_044efcf4","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":66,"context_line":"      network: { get_param: net4 }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":69,"context_line":"# specified in instantiatevnfrequest"},{"line_number":70,"context_line":"  VDU2_CP2:"},{"line_number":71,"context_line":"    type: OS::Neutron::Port"},{"line_number":72,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"916a3cd7_3226c52b","line":69,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      network: { get_param: net4 }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":69,"context_line":"# specified in instantiatevnfrequest"},{"line_number":70,"context_line":"  VDU2_CP2:"},{"line_number":71,"context_line":"    type: OS::Neutron::Port"},{"line_number":72,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a8d2687_26395f45","line":69,"in_reply_to":"6acf06cb_9f2030f0","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":66,"context_line":"      network: { get_param: net4 }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":69,"context_line":"# specified in instantiatevnfrequest"},{"line_number":70,"context_line":"  VDU2_CP2:"},{"line_number":71,"context_line":"    type: OS::Neutron::Port"},{"line_number":72,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6acf06cb_9f2030f0","line":69,"in_reply_to":"916a3cd7_3226c52b","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"}],"tacker/tests/functional/sol_v2_common/samples/userdata_standard_change_vnfpkg_nw/contents/BaseHOT/simple/sample5.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":29,"context_line":"      net4: { get_param: [ nfv, CP, VDU2_CP4, network ] }"},{"line_number":30,"context_line":"      affinity: { get_resource: nfvi_node_affinity }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":33,"context_line":"  internalVL1:"},{"line_number":34,"context_line":"    type: OS::Neutron::Net"},{"line_number":35,"context_line":"  internalVL3:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3661123a_68036975","line":32,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs\n\nThe following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      net4: { get_param: [ nfv, CP, VDU2_CP4, network ] }"},{"line_number":30,"context_line":"      affinity: { get_resource: nfvi_node_affinity }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":33,"context_line":"  internalVL1:"},{"line_number":34,"context_line":"    type: OS::Neutron::Net"},{"line_number":35,"context_line":"  internalVL3:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a47abaaa_73f67ee6","line":32,"in_reply_to":"3546666b_a60f09d5","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":29,"context_line":"      net4: { get_param: [ nfv, CP, VDU2_CP4, network ] }"},{"line_number":30,"context_line":"      affinity: { get_resource: nfvi_node_affinity }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":33,"context_line":"  internalVL1:"},{"line_number":34,"context_line":"    type: OS::Neutron::Net"},{"line_number":35,"context_line":"  internalVL3:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3546666b_a60f09d5","line":32,"in_reply_to":"3661123a_68036975","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c7171fc7fa73afe941ee3788dcacfc4d643370dd","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"resources:"},{"line_number":9,"context_line":"  VDU1:"},{"line_number":10,"context_line":"    type: VDU1-ver2.yaml"},{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      flavor: { get_param: [ nfv, VDU, VDU1, computeFlavourId ] }"},{"line_number":13,"context_line":"      image-VDU1: { get_param: [ nfv, VDU, VDU1, vcImageId ] }"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"b1123340_2531ee22","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":19},"updated":"2023-02-09 06:17:47.000000000","message":"Just a question, what does this `ver2` mean and is it necessary?\n\nIf it is needed to add a string after it, it may better to change it to a string that shows the purpose.","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"dbc08db307a7aa7ecdb3ac40da8127bb3b6bc55f","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"resources:"},{"line_number":9,"context_line":"  VDU1:"},{"line_number":10,"context_line":"    type: VDU1-ver2.yaml"},{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      flavor: { get_param: [ nfv, VDU, VDU1, computeFlavourId ] }"},{"line_number":13,"context_line":"      image-VDU1: { get_param: [ nfv, VDU, VDU1, vcImageId ] }"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"4e391f80_db31adfe","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":19},"in_reply_to":"37aa4410_8fe99e31","updated":"2023-02-16 02:45:15.000000000","message":"Thank you, I understood.","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5fa0ea97f5e368275f5130d5232d39ff7da30299","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"resources:"},{"line_number":9,"context_line":"  VDU1:"},{"line_number":10,"context_line":"    type: VDU1-ver2.yaml"},{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      flavor: { get_param: [ nfv, VDU, VDU1, computeFlavourId ] }"},{"line_number":13,"context_line":"      image-VDU1: { get_param: [ nfv, VDU, VDU1, vcImageId ] }"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"feffe30c_643afb99","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":19},"in_reply_to":"93ebda34_87f9782a","updated":"2023-02-10 06:19:43.000000000","message":"Thanks for your answer.\nIn my understand the followings, is it correct?\n* The BaseHot used at instantiation is \"ver1 (unmarked)\", whereas this file is \"ver2\".\n* In order to change the BaseHot in the test, the file name has been changed (add -ver2) to make it easier to see that it is a different BaseHot.","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"1e528f9e100ae032c787ee49028c025af4d2ba4b","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"resources:"},{"line_number":9,"context_line":"  VDU1:"},{"line_number":10,"context_line":"    type: VDU1-ver2.yaml"},{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      flavor: { get_param: [ nfv, VDU, VDU1, computeFlavourId ] }"},{"line_number":13,"context_line":"      image-VDU1: { get_param: [ nfv, VDU, VDU1, vcImageId ] }"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"93ebda34_87f9782a","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":19},"in_reply_to":"b1123340_2531ee22","updated":"2023-02-09 23:42:29.000000000","message":"It is necessary because it is identified that nested HOT is changed by this name.","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"b7efd46023633c5385c4606d6e603878561d1ca8","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"resources:"},{"line_number":9,"context_line":"  VDU1:"},{"line_number":10,"context_line":"    type: VDU1-ver2.yaml"},{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      flavor: { get_param: [ nfv, VDU, VDU1, computeFlavourId ] }"},{"line_number":13,"context_line":"      image-VDU1: { get_param: [ nfv, VDU, VDU1, vcImageId ] }"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"37aa4410_8fe99e31","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":19},"in_reply_to":"feffe30c_643afb99","updated":"2023-02-12 22:28:48.000000000","message":"yes, correct.\nI think the BaseHot used at instantiation is \"original\". \"VDU1-ver2\" is better than \"VDU1-changed\" because it may be necessary to change it in the future (then it will be \"VDU1-ver3\").","commit_id":"5c3ab4672b582a854060d3b28e37bc8d0da233ff"}],"tacker/tests/unit/sol_refactored/infra_drivers/openstack/test_openstack.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":156,"context_line":"    }"},{"line_number":157,"context_line":"}"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# example for test of StandardUserdata"},{"line_number":160,"context_line":"_instantiate_req_example_S \u003d {"},{"line_number":161,"context_line":"    \"flavourId\": SAMPLE_FLAVOUR_ID,"},{"line_number":162,"context_line":"    \"extVirtualLinks\": ["}],"source_content_type":"text/x-python","patch_set":5,"id":"e3698ac9_3df040e7","line":159,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the actual class name.\nStandardUserdata -\u003e StandardUserData","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    }"},{"line_number":157,"context_line":"}"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# example for test of StandardUserdata"},{"line_number":160,"context_line":"_instantiate_req_example_S \u003d {"},{"line_number":161,"context_line":"    \"flavourId\": SAMPLE_FLAVOUR_ID,"},{"line_number":162,"context_line":"    \"extVirtualLinks\": ["}],"source_content_type":"text/x-python","patch_set":5,"id":"bf0ca152_4348b987","line":159,"in_reply_to":"10abbbca_43c2d2f6","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":156,"context_line":"    }"},{"line_number":157,"context_line":"}"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# example for test of StandardUserdata"},{"line_number":160,"context_line":"_instantiate_req_example_S \u003d {"},{"line_number":161,"context_line":"    \"flavourId\": SAMPLE_FLAVOUR_ID,"},{"line_number":162,"context_line":"    \"extVirtualLinks\": ["}],"source_content_type":"text/x-python","patch_set":5,"id":"10abbbca_43c2d2f6","line":159,"in_reply_to":"e3698ac9_3df040e7","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":912,"context_line":"_heat_reses_example_change_ext_conn \u003d ("},{"line_number":913,"context_line":"    _heat_reses_example_base + _heat_reses_example_cps_after)"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"# heat resources example for test of StandardUserdata"},{"line_number":916,"context_line":"_stack_id_VDU1_0_S \u003d ("},{"line_number":917,"context_line":"    \"vnf-881718c6-830b-4232-9e83-4b0cd7678713-VDU1-0-ntteaet43n2s/\""},{"line_number":918,"context_line":"    \"46c6328e-db32-4da0-8dee-c69079644982\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"e41417b9_303c691c","line":915,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the actual class name.\nStandardUserdata -\u003e StandardUserData","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":912,"context_line":"_heat_reses_example_change_ext_conn \u003d ("},{"line_number":913,"context_line":"    _heat_reses_example_base + _heat_reses_example_cps_after)"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"# heat resources example for test of StandardUserdata"},{"line_number":916,"context_line":"_stack_id_VDU1_0_S \u003d ("},{"line_number":917,"context_line":"    \"vnf-881718c6-830b-4232-9e83-4b0cd7678713-VDU1-0-ntteaet43n2s/\""},{"line_number":918,"context_line":"    \"46c6328e-db32-4da0-8dee-c69079644982\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"8bf65300_0efc9453","line":915,"in_reply_to":"b654515a_d8013657","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":912,"context_line":"_heat_reses_example_change_ext_conn \u003d ("},{"line_number":913,"context_line":"    _heat_reses_example_base + _heat_reses_example_cps_after)"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"# heat resources example for test of StandardUserdata"},{"line_number":916,"context_line":"_stack_id_VDU1_0_S \u003d ("},{"line_number":917,"context_line":"    \"vnf-881718c6-830b-4232-9e83-4b0cd7678713-VDU1-0-ntteaet43n2s/\""},{"line_number":918,"context_line":"    \"46c6328e-db32-4da0-8dee-c69079644982\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"b654515a_d8013657","line":915,"in_reply_to":"e41417b9_303c691c","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":1246,"context_line":"    \u0027nfv\u0027: json.dumps(_nfv_dict)"},{"line_number":1247,"context_line":"}"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"# heat get_parameters example for test of StandardUserdata"},{"line_number":1250,"context_line":"_nfv_dict_S \u003d {"},{"line_number":1251,"context_line":"    \"VDU\": {"},{"line_number":1252,"context_line":"        \"VDU1-0\": {\"vcImageId\": \"image-VDU1\", \"computeFlavourId\": \"m1.tiny\","}],"source_content_type":"text/x-python","patch_set":5,"id":"e21a3b7c_101a4899","line":1249,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the actual class name.\nStandardUserdata -\u003e StandardUserData","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"    \u0027nfv\u0027: json.dumps(_nfv_dict)"},{"line_number":1247,"context_line":"}"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"# heat get_parameters example for test of StandardUserdata"},{"line_number":1250,"context_line":"_nfv_dict_S \u003d {"},{"line_number":1251,"context_line":"    \"VDU\": {"},{"line_number":1252,"context_line":"        \"VDU1-0\": {\"vcImageId\": \"image-VDU1\", \"computeFlavourId\": \"m1.tiny\","}],"source_content_type":"text/x-python","patch_set":5,"id":"21f44c44_c28033ad","line":1249,"in_reply_to":"16c06055_996874d8","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":1246,"context_line":"    \u0027nfv\u0027: json.dumps(_nfv_dict)"},{"line_number":1247,"context_line":"}"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"# heat get_parameters example for test of StandardUserdata"},{"line_number":1250,"context_line":"_nfv_dict_S \u003d {"},{"line_number":1251,"context_line":"    \"VDU\": {"},{"line_number":1252,"context_line":"        \"VDU1-0\": {\"vcImageId\": \"image-VDU1\", \"computeFlavourId\": \"m1.tiny\","}],"source_content_type":"text/x-python","patch_set":5,"id":"16c06055_996874d8","line":1249,"in_reply_to":"e21a3b7c_101a4899","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":2667,"context_line":"    }"},{"line_number":2668,"context_line":"}"},{"line_number":2669,"context_line":""},{"line_number":2670,"context_line":"# expected results for test of StandardUserdata"},{"line_number":2671,"context_line":"_expected_inst_info_S \u003d {"},{"line_number":2672,"context_line":"    \"flavourId\": \"simple\","},{"line_number":2673,"context_line":"    \"vnfState\": \"STARTED\","}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1c598c_711a01d4","line":2670,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the actual class name.\nStandardUserdata -\u003e StandardUserData","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":2667,"context_line":"    }"},{"line_number":2668,"context_line":"}"},{"line_number":2669,"context_line":""},{"line_number":2670,"context_line":"# expected results for test of StandardUserdata"},{"line_number":2671,"context_line":"_expected_inst_info_S \u003d {"},{"line_number":2672,"context_line":"    \"flavourId\": \"simple\","},{"line_number":2673,"context_line":"    \"vnfState\": \"STARTED\","}],"source_content_type":"text/x-python","patch_set":5,"id":"7fb2cb15_6595bd41","line":2670,"in_reply_to":"6382a213_9554bfc2","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":2667,"context_line":"    }"},{"line_number":2668,"context_line":"}"},{"line_number":2669,"context_line":""},{"line_number":2670,"context_line":"# expected results for test of StandardUserdata"},{"line_number":2671,"context_line":"_expected_inst_info_S \u003d {"},{"line_number":2672,"context_line":"    \"flavourId\": \"simple\","},{"line_number":2673,"context_line":"    \"vnfState\": \"STARTED\","}],"source_content_type":"text/x-python","patch_set":5,"id":"6382a213_9554bfc2","line":2670,"in_reply_to":"9a1c598c_711a01d4","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":3702,"context_line":"        self._check_inst_info(_expected_inst_info_change_ext_conn, result)"},{"line_number":3703,"context_line":""},{"line_number":3704,"context_line":"    def test_make_instantiated_vnf_info_standard(self):"},{"line_number":3705,"context_line":"        # test of _make_instantiated_vnf_info when StandardUserdata is used."},{"line_number":3706,"context_line":"        # NOTE: main difference between DefaultUserdata is making metadata"},{"line_number":3707,"context_line":"        # of VnfcResourceInfo."},{"line_number":3708,"context_line":"        # prepare"}],"source_content_type":"text/x-python","patch_set":5,"id":"9d33f8dc_f8b8628b","line":3705,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the actual class name.\nStandardUserdata -\u003e StandardUserData","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":3702,"context_line":"        self._check_inst_info(_expected_inst_info_change_ext_conn, result)"},{"line_number":3703,"context_line":""},{"line_number":3704,"context_line":"    def test_make_instantiated_vnf_info_standard(self):"},{"line_number":3705,"context_line":"        # test of _make_instantiated_vnf_info when StandardUserdata is used."},{"line_number":3706,"context_line":"        # NOTE: main difference between DefaultUserdata is making metadata"},{"line_number":3707,"context_line":"        # of VnfcResourceInfo."},{"line_number":3708,"context_line":"        # prepare"}],"source_content_type":"text/x-python","patch_set":5,"id":"cc8838d4_d46e488f","line":3705,"in_reply_to":"9d33f8dc_f8b8628b","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":3702,"context_line":"        self._check_inst_info(_expected_inst_info_change_ext_conn, result)"},{"line_number":3703,"context_line":""},{"line_number":3704,"context_line":"    def test_make_instantiated_vnf_info_standard(self):"},{"line_number":3705,"context_line":"        # test of _make_instantiated_vnf_info when StandardUserdata is used."},{"line_number":3706,"context_line":"        # NOTE: main difference between DefaultUserdata is making metadata"},{"line_number":3707,"context_line":"        # of VnfcResourceInfo."},{"line_number":3708,"context_line":"        # prepare"}],"source_content_type":"text/x-python","patch_set":5,"id":"d459dadf_ac2de07e","line":3705,"in_reply_to":"cc8838d4_d46e488f","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":3703,"context_line":""},{"line_number":3704,"context_line":"    def test_make_instantiated_vnf_info_standard(self):"},{"line_number":3705,"context_line":"        # test of _make_instantiated_vnf_info when StandardUserdata is used."},{"line_number":3706,"context_line":"        # NOTE: main difference between DefaultUserdata is making metadata"},{"line_number":3707,"context_line":"        # of VnfcResourceInfo."},{"line_number":3708,"context_line":"        # prepare"},{"line_number":3709,"context_line":"        req \u003d objects.InstantiateVnfRequest.from_dict("}],"source_content_type":"text/x-python","patch_set":5,"id":"43d6ad90_4884be9d","line":3706,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the actual class name.\nDefaultUserdata -\u003e DefaultUserData","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":3703,"context_line":""},{"line_number":3704,"context_line":"    def test_make_instantiated_vnf_info_standard(self):"},{"line_number":3705,"context_line":"        # test of _make_instantiated_vnf_info when StandardUserdata is used."},{"line_number":3706,"context_line":"        # NOTE: main difference between DefaultUserdata is making metadata"},{"line_number":3707,"context_line":"        # of VnfcResourceInfo."},{"line_number":3708,"context_line":"        # prepare"},{"line_number":3709,"context_line":"        req \u003d objects.InstantiateVnfRequest.from_dict("}],"source_content_type":"text/x-python","patch_set":5,"id":"7e0673c7_d2c3e9da","line":3706,"in_reply_to":"43d6ad90_4884be9d","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":3703,"context_line":""},{"line_number":3704,"context_line":"    def test_make_instantiated_vnf_info_standard(self):"},{"line_number":3705,"context_line":"        # test of _make_instantiated_vnf_info when StandardUserdata is used."},{"line_number":3706,"context_line":"        # NOTE: main difference between DefaultUserdata is making metadata"},{"line_number":3707,"context_line":"        # of VnfcResourceInfo."},{"line_number":3708,"context_line":"        # prepare"},{"line_number":3709,"context_line":"        req \u003d objects.InstantiateVnfRequest.from_dict("}],"source_content_type":"text/x-python","patch_set":5,"id":"20d52330_f5149a6b","line":3706,"in_reply_to":"7e0673c7_d2c3e9da","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0c603f4805331b04f1348bf7aa8a1fd1b2f1ad86","unresolved":true,"context_lines":[{"line_number":157,"context_line":"}"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# example for test of StandardUserData"},{"line_number":160,"context_line":"_instantiate_req_example_S \u003d {"},{"line_number":161,"context_line":"    \"flavourId\": SAMPLE_FLAVOUR_ID,"},{"line_number":162,"context_line":"    \"extVirtualLinks\": ["},{"line_number":163,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":9,"id":"35d1ff68_d023d5de","line":160,"updated":"2023-01-23 09:49:38.000000000","message":"It depends on your answer for the comment at https://review.opendev.org/c/openstack/tacker/+/866544/9/tacker/sol_refactored/infra_drivers/openstack/openstack.py#376.\nI think we should express our thoughts clearly.\n\nIf both `standard` and `legacy` will be supported, it\u0027s better to add suffix \u0027_L\u0027 or \u0027_legacy\u0027 to the existing examples as well. If we will remove `legacy` in the future, add the suffix to the legacy examples `_instantiate_req_example_L` or `_legacy`, and examples for test of StandardUserData can be just `_instantiate_req_example`","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9f328059f9d8f3eb099208d144e64ec0079f482e","unresolved":true,"context_lines":[{"line_number":157,"context_line":"}"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# example for test of StandardUserData"},{"line_number":160,"context_line":"_instantiate_req_example_S \u003d {"},{"line_number":161,"context_line":"    \"flavourId\": SAMPLE_FLAVOUR_ID,"},{"line_number":162,"context_line":"    \"extVirtualLinks\": ["},{"line_number":163,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":9,"id":"d141c034_53854e62","line":160,"in_reply_to":"35d1ff68_d023d5de","updated":"2023-01-24 04:21:51.000000000","message":"_insntantiate_req_example_S is added to check different parts as before at the time of use of StandardUserdata. _instantiate_req_example is used for the confirmation of the part which does not depend on UserData　class.","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b4561e1dd37861802cd3f0f4724ae231e7002fc6","unresolved":false,"context_lines":[{"line_number":157,"context_line":"}"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"# example for test of StandardUserData"},{"line_number":160,"context_line":"_instantiate_req_example_S \u003d {"},{"line_number":161,"context_line":"    \"flavourId\": SAMPLE_FLAVOUR_ID,"},{"line_number":162,"context_line":"    \"extVirtualLinks\": ["},{"line_number":163,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":9,"id":"2a2ff369_c81c1736","line":160,"in_reply_to":"d141c034_53854e62","updated":"2023-01-24 07:23:21.000000000","message":"It\u0027s clear now. I withdraw my comment the above.\n\nI just tried to express our thoughts by the naming style. As you mentioned we\u0027ll maintain both the StandardUserData and UserData, `_instantiate_req_example_S` is an appropriate name.","commit_id":"a25b37ee5d61332c44c0878cb337617c59554726"}],"tacker/tests/unit/sol_refactored/samples/standard_sample/BaseHOT/simple/nested/VDU1.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fe31d3ec_ef8bb740","line":28,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"46fbb20d_6a9a61e3","line":28,"in_reply_to":"d1b21e76_7891db8c","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":25,"context_line":"      networks:"},{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d1b21e76_7891db8c","line":28,"in_reply_to":"fe31d3ec_ef8bb740","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"},{"line_number":32,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7b8c7417_6a588123","line":29,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"},{"line_number":32,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"93d970c4_1eba33c4","line":29,"in_reply_to":"7b8c7417_6a588123","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      - port:"},{"line_number":27,"context_line":"          get_resource: VDU1_CP1"},{"line_number":28,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":29,"context_line":"# specified in instantiatevnfrequest"},{"line_number":30,"context_line":"      - port:"},{"line_number":31,"context_line":"          get_resource: VDU1_CP2"},{"line_number":32,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"71394701_28f98afe","line":29,"in_reply_to":"93d970c4_1eba33c4","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1c67702a_9fae3c8b","line":42,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"560992c7_0d1111fc","line":42,"in_reply_to":"0482faa0_5fdff849","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    properties:"},{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0482faa0_5fdff849","line":42,"in_reply_to":"1c67702a_9fae3c8b","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"},{"line_number":46,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e48eb105_a9f3e172","line":43,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"},{"line_number":46,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a6d61492_618671a9","line":43,"in_reply_to":"e424fbd5_d46556d9","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":40,"context_line":"      network: { get_param: net1 }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":43,"context_line":"# specified in instantiatevnfrequest"},{"line_number":44,"context_line":"  VDU1_CP2:"},{"line_number":45,"context_line":"    type: OS::Neutron::Port"},{"line_number":46,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e424fbd5_d46556d9","line":43,"in_reply_to":"e48eb105_a9f3e172","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"}],"tacker/tests/unit/sol_refactored/samples/standard_sample/BaseHOT/simple/nested/VDU2.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba14c663_29f6b50e","line":30,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"76f0d945_87ca92ef","line":30,"in_reply_to":"a2bc09c7_b57b42fe","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      networks:"},{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a2bc09c7_b57b42fe","line":30,"in_reply_to":"ba14c663_29f6b50e","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"},{"line_number":34,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2b714194_6f0276cb","line":31,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"},{"line_number":34,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dbbae58f_772e4c55","line":31,"in_reply_to":"2b714194_6f0276cb","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      - port:"},{"line_number":29,"context_line":"          get_resource: VDU2_CP1"},{"line_number":30,"context_line":"# replace the following line to Port ID when extmanagedVLs\u0027 Ports are"},{"line_number":31,"context_line":"# specified in instantiatevnfrequest"},{"line_number":32,"context_line":"      - port:"},{"line_number":33,"context_line":"          get_resource: VDU2_CP2"},{"line_number":34,"context_line":"      - port:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"23949ce7_415cda28","line":31,"in_reply_to":"dbbae58f_772e4c55","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":56,"context_line":"      fixed_ips:"},{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0721f641_d8d8484c","line":59,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":56,"context_line":"      fixed_ips:"},{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da027f17_dee97607","line":59,"in_reply_to":"0721f641_d8d8484c","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      fixed_ips:"},{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0d6e84ce_8594225c","line":59,"in_reply_to":"da027f17_dee97607","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"},{"line_number":63,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7be870a8_b0af35e1","line":60,"updated":"2022-12-14 09:49:13.000000000","message":"The following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"},{"line_number":63,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a940b30f_6595f8f9","line":60,"in_reply_to":"7be870a8_b0af35e1","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      - subnet: { get_param: subnet1 }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# CPs of internal VLs are deleted when extmanagedVLs and port are"},{"line_number":60,"context_line":"# specified in instantiatevnfrequest"},{"line_number":61,"context_line":"  VDU2_CP2:"},{"line_number":62,"context_line":"    type: OS::Neutron::Port"},{"line_number":63,"context_line":"    properties:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a4e65040_327e0582","line":60,"in_reply_to":"a940b30f_6595f8f9","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"}],"tacker/tests/unit/sol_refactored/samples/standard_sample/BaseHOT/simple/sample3.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"23cb5b06209852bd253f5582141711ca516fd4fb","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      net3: { get_resource: internalVL2 }"},{"line_number":28,"context_line":"      affinity: { get_resource: nfvi_node_affinity }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"  internalVL1:"},{"line_number":32,"context_line":"    type: OS::Neutron::Net"},{"line_number":33,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a422d1d6_d46d0270","line":30,"updated":"2022-12-14 09:49:13.000000000","message":"I think the following is easier to read.\nextmanagedVLs -\u003e extManagedVLs\n\nThe following is better according to the description of SOL.\ninstantiatievnfrequest -\u003e InstantiateVnfRequest","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"dbca9fc27484ca919c0cde682061e1c22b8aa4e1","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      net3: { get_resource: internalVL2 }"},{"line_number":28,"context_line":"      affinity: { get_resource: nfvi_node_affinity }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"  internalVL1:"},{"line_number":32,"context_line":"    type: OS::Neutron::Net"},{"line_number":33,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffeb583c_370c153f","line":30,"in_reply_to":"a422d1d6_d46d0270","updated":"2022-12-19 00:20:26.000000000","message":"I will fix.","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"76d19cb0410c735d4923e73b0f73352d05904e29","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      net3: { get_resource: internalVL2 }"},{"line_number":28,"context_line":"      affinity: { get_resource: nfvi_node_affinity }"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# delete the following lines when extmanagedVLs are specified in instantiatevnfrequest"},{"line_number":31,"context_line":"  internalVL1:"},{"line_number":32,"context_line":"    type: OS::Neutron::Net"},{"line_number":33,"context_line":"  internalVL2:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cc9976c2_a9889563","line":30,"in_reply_to":"ffeb583c_370c153f","updated":"2022-12-19 08:47:04.000000000","message":"Done","commit_id":"1c1b3907bfa0eae0d0bb73fac2d00464f533e44b"}]}