)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"302435346a0f794067380fc40f1a6af5a09496dd","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before DB synchronization, the OperationState of Opocc"},{"line_number":10,"context_line":"needs to be checked. When the OperationState is FAILED_TEMP,"},{"line_number":11,"context_line":"the VNF skips this DB synchronization."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1999632"},{"line_number":14,"context_line":"Change-Id: Ie47b5a9092a938db9834c68fe5375cc1bf42c791"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4ed07daa_ac4fe86d","line":11,"updated":"2023-01-12 08:32:02.000000000","message":"I think Tacker (VNFM) will operate this DB sync.\nTherefore, \"Tacker skips this DB synchronization for the VNF.\" is better.","commit_id":"837db40ca8631b7946f6dbd5484cd28c01e63538"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"448fbf31b6e1b5f4bebeec4531b0be58f51683ab","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before DB synchronization, the OperationState of Opocc"},{"line_number":10,"context_line":"needs to be checked. When the OperationState is FAILED_TEMP,"},{"line_number":11,"context_line":"the VNF skips this DB synchronization."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1999632"},{"line_number":14,"context_line":"Change-Id: Ie47b5a9092a938db9834c68fe5375cc1bf42c791"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b4260c19_83b1d557","line":11,"in_reply_to":"4ed07daa_ac4fe86d","updated":"2023-01-20 03:56:33.000000000","message":"I fixed it in patchset 4.","commit_id":"837db40ca8631b7946f6dbd5484cd28c01e63538"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dfb3ae5ccf590947bf1ca5444e48064e2c82b1f4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before DB synchronization, the OperationState of Opocc"},{"line_number":10,"context_line":"needs to be checked. When the OperationState is FAILED_TEMP,"},{"line_number":11,"context_line":"the VNF skips this DB synchronization."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1999632"},{"line_number":14,"context_line":"Change-Id: Ie47b5a9092a938db9834c68fe5375cc1bf42c791"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"14697c13_50072b76","line":11,"in_reply_to":"b4260c19_83b1d557","updated":"2023-02-02 04:44:51.000000000","message":"Done","commit_id":"837db40ca8631b7946f6dbd5484cd28c01e63538"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dfb3ae5ccf590947bf1ca5444e48064e2c82b1f4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayumu Ueha \u003cueha.ayumu@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 07:54:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix rollback error caused by DB sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before DB synchronization, the OperationState of Opocc"},{"line_number":10,"context_line":"needs to be checked. When the OperationState is FAILED_TEMP,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fd6e9f0e_324ce5f2","line":7,"updated":"2023-02-02 04:44:51.000000000","message":"I think the documentation of Database synchronization error-handling  [1] also needs to be changed.\nWill it be posted as another patch?\n\n[1] https://docs.openstack.org/tacker/latest/user/db_sync_error_handling.html","commit_id":"ffe3e8c20b4966043d3f54894ff05ca24dbe6ee1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"a015f85083bf20a12266b2e7523c8f245062ac5e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayumu Ueha \u003cueha.ayumu@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 07:54:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix rollback error caused by DB sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before DB synchronization, the OperationState of Opocc"},{"line_number":10,"context_line":"needs to be checked. When the OperationState is FAILED_TEMP,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a15d78a3_c3f55487","line":7,"in_reply_to":"aa88a336_b5b3c90f","updated":"2023-02-09 06:28:19.000000000","message":"Done","commit_id":"ffe3e8c20b4966043d3f54894ff05ca24dbe6ee1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5eb7719ace96bb3d72b78e1b786ffb383966e8b3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayumu Ueha \u003cueha.ayumu@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-01-20 07:54:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix rollback error caused by DB sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before DB synchronization, the OperationState of Opocc"},{"line_number":10,"context_line":"needs to be checked. When the OperationState is FAILED_TEMP,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"aa88a336_b5b3c90f","line":7,"in_reply_to":"fd6e9f0e_324ce5f2","updated":"2023-02-03 10:18:52.000000000","message":"Documentation fixed in patchset 6.","commit_id":"ffe3e8c20b4966043d3f54894ff05ca24dbe6ee1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dfb3ae5ccf590947bf1ca5444e48064e2c82b1f4","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix rollback error caused by DB sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before DB synchronization, the OperationState of Opocc"},{"line_number":10,"context_line":"needs to be checked. When the OperationState is FAILED_TEMP,"},{"line_number":11,"context_line":"Tacker skips this DB synchronization for the VNF."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1999632"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b88e7ed7_950444d4","line":10,"updated":"2023-02-02 04:44:51.000000000","message":"Refer to Fail VNF LCM Operation [2], `FAILED` OperationState is the same situation of `FAILED_TEMP` because Tacker simply changes LCM operation state from `FAILED_TEMP` to `FAILED` on Tacker-DB.\nTherefore, `FAILED` OperationState also needs to skip the DB synchronization.\nCould you add the above fix?\n\n[2] https://docs.openstack.org/tacker/latest/user/etsi_vnf_error_handling.html","commit_id":"ffe3e8c20b4966043d3f54894ff05ca24dbe6ee1"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"a015f85083bf20a12266b2e7523c8f245062ac5e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix rollback error caused by DB sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before DB synchronization, the OperationState of Opocc"},{"line_number":10,"context_line":"needs to be checked. When the OperationState is FAILED_TEMP,"},{"line_number":11,"context_line":"Tacker skips this DB synchronization for the VNF."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1999632"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"4b781f7d_ab87a7c3","line":10,"in_reply_to":"7646f6d6_e3eeadb4","updated":"2023-02-09 06:28:19.000000000","message":"Done","commit_id":"ffe3e8c20b4966043d3f54894ff05ca24dbe6ee1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"5eb7719ace96bb3d72b78e1b786ffb383966e8b3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix rollback error caused by DB sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before DB synchronization, the OperationState of Opocc"},{"line_number":10,"context_line":"needs to be checked. When the OperationState is FAILED_TEMP,"},{"line_number":11,"context_line":"Tacker skips this DB synchronization for the VNF."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1999632"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7646f6d6_e3eeadb4","line":10,"in_reply_to":"b88e7ed7_950444d4","updated":"2023-02-03 10:18:52.000000000","message":"I fixed it in patch 6.","commit_id":"ffe3e8c20b4966043d3f54894ff05ca24dbe6ee1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f13f9d76534743f88a1a7ac011e56621bb2c8053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fee926ab_f57987c3","updated":"2022-12-17 03:47:03.000000000","message":"Thanks for your patch, LGTM!! but could you address below comment.","commit_id":"c139316c73128b3baff46b59a9eef8d606d2d7ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"191fa1d48f1f98e51f588183607d1aad79edbfdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b079382_ba2ffe32","updated":"2022-12-16 04:39:18.000000000","message":"recheck - infra failure","commit_id":"c139316c73128b3baff46b59a9eef8d606d2d7ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f2d470dfcc6c9ce6c469f8afc5323754c4100f50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a9f89046_d7e36df2","updated":"2022-12-16 01:23:52.000000000","message":"recheck - infra failure","commit_id":"c139316c73128b3baff46b59a9eef8d606d2d7ae"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"302435346a0f794067380fc40f1a6af5a09496dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e6ef9499_520c2c83","updated":"2023-01-12 08:32:02.000000000","message":"Thank you for your work. Please kindly check my comments.","commit_id":"837db40ca8631b7946f6dbd5484cd28c01e63538"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dfb3ae5ccf590947bf1ca5444e48064e2c82b1f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"495ff9dd_13cec727","updated":"2023-02-02 04:44:51.000000000","message":"Thank you for your re-work! I added some new comments, so please kindly check them.","commit_id":"ffe3e8c20b4966043d3f54894ff05ca24dbe6ee1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c8e9815d5fa8cf52b0e52aacdac6c8acd3c675f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"00999793_ae29fd64","updated":"2023-01-23 00:46:29.000000000","message":"recheck - infra failure in sol and libs-master.","commit_id":"ffe3e8c20b4966043d3f54894ff05ca24dbe6ee1"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"531cf2d908dfc399c738e109517f0a0924ef66df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e18f423e_a5d4a173","updated":"2023-02-06 16:49:39.000000000","message":"Thanks for your patch, please kindly find my comment.","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"27dba848aa9aa0135ed8aea2bbd93f7ae84cb8d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f09aff68_bc685d2c","updated":"2023-02-08 05:32:58.000000000","message":"recheck, infra failure in nfvo-v2 job","commit_id":"20d8cb0b026501975c4fc3c39a9ec5ab0869ed3a"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"a015f85083bf20a12266b2e7523c8f245062ac5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5bc48947_93ad6f8e","updated":"2023-02-09 06:28:19.000000000","message":"Thank you for re-work!","commit_id":"5574c68fb901fbddb31910823c0429657a3aab78"},{"author":{"_account_id":31668},"change_message_id":"3bcb734e8f9dc430e3ce6f9612e9000d945e5c9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3c0b2e4d_31d69066","updated":"2023-02-09 02:07:56.000000000","message":"Thank you for your re-work! I have no further comments.","commit_id":"5574c68fb901fbddb31910823c0429657a3aab78"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0e2366f409156ded6fdbb3e9faf1603ee0b7c6cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2667be95_e5cc7530","updated":"2023-02-09 04:36:55.000000000","message":"recheck, infra failure in sol-v2 job","commit_id":"5574c68fb901fbddb31910823c0429657a3aab78"},{"author":{"_account_id":31668},"change_message_id":"340291a6b61bbabbf242d4bb4bfc666ffaf05338","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a0dea71b_3507bec4","updated":"2023-02-14 00:51:44.000000000","message":"LGTM","commit_id":"c5b0806c5eee11d2dff439623e9fb0a775e8c617"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"d6e1b9d94f662d04fdef6d6299f30e97d86f5b89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"29d57bb0_64a78940","updated":"2023-02-14 00:49:30.000000000","message":"Thank you for re-work! LGTM","commit_id":"c5b0806c5eee11d2dff439623e9fb0a775e8c617"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b7cad5d6ed76ff2cf201b0a7180f80e67f68e571","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"25147405_709c182b","updated":"2023-02-14 00:45:48.000000000","message":"Thanks for your update, LGTM.","commit_id":"c5b0806c5eee11d2dff439623e9fb0a775e8c617"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"8cca4a07c7059cafdb4f901e7a66854e13ccfc0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fa103a68_ab85449c","updated":"2023-02-13 10:56:52.000000000","message":"recheck, infra failure in sol and sol-v2 job","commit_id":"c5b0806c5eee11d2dff439623e9fb0a775e8c617"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"656edb4368e99f78146544686ea02da86f53b990","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f8f0ec23_aa618dd6","updated":"2023-02-13 07:21:49.000000000","message":"recheck, infra failure in sol-v2-ubuntu-focal job","commit_id":"c5b0806c5eee11d2dff439623e9fb0a775e8c617"}],"doc/source/user/db_sync_error_handling.rst":[{"author":{"_account_id":31668},"change_message_id":"f18c2c6cd796ef6a00d2d711b7db551d58c3de18","unresolved":true,"context_lines":[{"line_number":338,"context_line":"-------------"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"Conflict with LCM operation"},{"line_number":341,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"There are two kinds of conflicts:"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa7c6df6_b371f882","line":341,"range":{"start_line":341,"start_character":27,"end_line":341,"end_character":31},"updated":"2023-02-06 10:28:51.000000000","message":"Unnecessary","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"9196921bf30c5563764ddd7a467cbdd94b9361f8","unresolved":false,"context_lines":[{"line_number":338,"context_line":"-------------"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"Conflict with LCM operation"},{"line_number":341,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"There are two kinds of conflicts:"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"68b9635b_54509d96","line":341,"range":{"start_line":341,"start_character":27,"end_line":341,"end_character":31},"in_reply_to":"4b054d4d_fe094d55","updated":"2023-02-08 05:38:24.000000000","message":"Done","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ca571474c5ef904cb6ed3e7d4d4d160cbf416e39","unresolved":true,"context_lines":[{"line_number":338,"context_line":"-------------"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"Conflict with LCM operation"},{"line_number":341,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"There are two kinds of conflicts:"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"4b054d4d_fe094d55","line":341,"range":{"start_line":341,"start_character":27,"end_line":341,"end_character":31},"in_reply_to":"fa7c6df6_b371f882","updated":"2023-02-08 02:17:43.000000000","message":"I fixed it in patchset 8.","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"f18c2c6cd796ef6a00d2d711b7db551d58c3de18","unresolved":true,"context_lines":[{"line_number":390,"context_line":"Abnormal LCM operation status"},{"line_number":391,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"During synchronization, Tacker checks the operation state of VNFLCM"},{"line_number":394,"context_line":"Operation Occurrence. If the operation state is `FAILED_TEMP` or `FAILED`,"},{"line_number":395,"context_line":"Tacker will output an error log and do not update database."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":".. note:: If you don\u0027t have tacker-conductor.log,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"e744aa4e_dbe6e74a","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":74},"updated":"2023-02-06 10:28:51.000000000","message":"According to SOL, it is better to:\n* operation state -\u003e operationState\n* VNFLCM Operation Occurrence -\u003e VnfLcmOpOcc","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ca571474c5ef904cb6ed3e7d4d4d160cbf416e39","unresolved":true,"context_lines":[{"line_number":390,"context_line":"Abnormal LCM operation status"},{"line_number":391,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"During synchronization, Tacker checks the operation state of VNFLCM"},{"line_number":394,"context_line":"Operation Occurrence. If the operation state is `FAILED_TEMP` or `FAILED`,"},{"line_number":395,"context_line":"Tacker will output an error log and do not update database."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":".. note:: If you don\u0027t have tacker-conductor.log,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"f6cd45a1_e32bbdcc","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":74},"in_reply_to":"e744aa4e_dbe6e74a","updated":"2023-02-08 02:17:43.000000000","message":"I fixed it in patchset 8.","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"9196921bf30c5563764ddd7a467cbdd94b9361f8","unresolved":false,"context_lines":[{"line_number":390,"context_line":"Abnormal LCM operation status"},{"line_number":391,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"During synchronization, Tacker checks the operation state of VNFLCM"},{"line_number":394,"context_line":"Operation Occurrence. If the operation state is `FAILED_TEMP` or `FAILED`,"},{"line_number":395,"context_line":"Tacker will output an error log and do not update database."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":".. note:: If you don\u0027t have tacker-conductor.log,"}],"source_content_type":"text/x-rst","patch_set":7,"id":"41ec8ba4_9d1965df","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":74},"in_reply_to":"f6cd45a1_e32bbdcc","updated":"2023-02-08 05:38:24.000000000","message":"Done","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"f18c2c6cd796ef6a00d2d711b7db551d58c3de18","unresolved":true,"context_lines":[{"line_number":395,"context_line":"Tacker will output an error log and do not update database."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":".. note:: If you don\u0027t have tacker-conductor.log,"},{"line_number":398,"context_line":"          you can execute the following CLI command to create tacker-conductor.log."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":".. code-block:: console"},{"line_number":401,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"a49b2702_50d96a28","line":398,"updated":"2023-02-06 10:28:51.000000000","message":"I think \"show\" is better than \"create\".\nWhat do you think?(Same for L.365.)","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ca571474c5ef904cb6ed3e7d4d4d160cbf416e39","unresolved":true,"context_lines":[{"line_number":395,"context_line":"Tacker will output an error log and do not update database."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":".. note:: If you don\u0027t have tacker-conductor.log,"},{"line_number":398,"context_line":"          you can execute the following CLI command to create tacker-conductor.log."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":".. code-block:: console"},{"line_number":401,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ec9e440c_97c26f60","line":398,"in_reply_to":"a49b2702_50d96a28","updated":"2023-02-08 02:17:43.000000000","message":"I fixed it in patchset 8.","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"9196921bf30c5563764ddd7a467cbdd94b9361f8","unresolved":false,"context_lines":[{"line_number":395,"context_line":"Tacker will output an error log and do not update database."},{"line_number":396,"context_line":""},{"line_number":397,"context_line":".. note:: If you don\u0027t have tacker-conductor.log,"},{"line_number":398,"context_line":"          you can execute the following CLI command to create tacker-conductor.log."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":".. code-block:: console"},{"line_number":401,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"52f1b40a_2c6397b5","line":398,"in_reply_to":"ec9e440c_97c26f60","updated":"2023-02-08 05:38:24.000000000","message":"Done","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"f18c2c6cd796ef6a00d2d711b7db551d58c3de18","unresolved":true,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":".. code-block:: console"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    There is an LCM operation in progress, so skip this DB synchronization. vnf:81c4be9d-25ad-4726-8640-f2c4c326de2e"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"Error-handling operations:"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"d1c95009_9777af40","line":408,"updated":"2023-02-06 10:28:51.000000000","message":"This is an error output in \"Abnormal LCM operation status\".\nI feel that \"LCM operation in progress\" is not suitable.","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"9196921bf30c5563764ddd7a467cbdd94b9361f8","unresolved":false,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":".. code-block:: console"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    There is an LCM operation in progress, so skip this DB synchronization. vnf:81c4be9d-25ad-4726-8640-f2c4c326de2e"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"Error-handling operations:"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"4a10cb8d_eca1a148","line":408,"in_reply_to":"52eae9b0_724dc392","updated":"2023-02-08 05:38:24.000000000","message":"Done","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ca571474c5ef904cb6ed3e7d4d4d160cbf416e39","unresolved":true,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":".. code-block:: console"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    There is an LCM operation in progress, so skip this DB synchronization. vnf:81c4be9d-25ad-4726-8640-f2c4c326de2e"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"Error-handling operations:"},{"line_number":411,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"52eae9b0_724dc392","line":408,"in_reply_to":"d1c95009_9777af40","updated":"2023-02-08 02:17:43.000000000","message":"I modified the message in patchset 8..","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"f18c2c6cd796ef6a00d2d711b7db551d58c3de18","unresolved":true,"context_lines":[{"line_number":412,"context_line":"To solve this error, you can get with the following ways."},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"* For the operation state of `FAILED_TEMP`, please refer to"},{"line_number":415,"context_line":"  VNFLCM.`VNF LCM error-handling`_"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"* For the operation state of `FAILED`, there is currently no way but to"},{"line_number":418,"context_line":"  terminate and delete the vnf, and then create and instantiate again."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3da61837_9c6669f3","line":415,"updated":"2023-02-06 10:28:51.000000000","message":"References are not displayed correctly.\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_95b/867787/7/check/openstack-tox-docs/95b94b8/docs/user/db_sync_error_handling.html","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"9196921bf30c5563764ddd7a467cbdd94b9361f8","unresolved":false,"context_lines":[{"line_number":412,"context_line":"To solve this error, you can get with the following ways."},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"* For the operation state of `FAILED_TEMP`, please refer to"},{"line_number":415,"context_line":"  VNFLCM.`VNF LCM error-handling`_"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"* For the operation state of `FAILED`, there is currently no way but to"},{"line_number":418,"context_line":"  terminate and delete the vnf, and then create and instantiate again."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7ab786bf_5f1d10e7","line":415,"in_reply_to":"2ae5159e_a970f6d5","updated":"2023-02-08 05:38:24.000000000","message":"Done","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ca571474c5ef904cb6ed3e7d4d4d160cbf416e39","unresolved":true,"context_lines":[{"line_number":412,"context_line":"To solve this error, you can get with the following ways."},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"* For the operation state of `FAILED_TEMP`, please refer to"},{"line_number":415,"context_line":"  VNFLCM.`VNF LCM error-handling`_"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"* For the operation state of `FAILED`, there is currently no way but to"},{"line_number":418,"context_line":"  terminate and delete the vnf, and then create and instantiate again."}],"source_content_type":"text/x-rst","patch_set":7,"id":"2ae5159e_a970f6d5","line":415,"in_reply_to":"3da61837_9c6669f3","updated":"2023-02-08 02:17:43.000000000","message":"I fixed it in patchset 8.","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"}],"tacker/sol_refactored/common/lcm_op_occ_utils.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"531cf2d908dfc399c738e109517f0a0924ef66df","unresolved":true,"context_lines":[{"line_number":561,"context_line":"    lcmoccs \u003d ["},{"line_number":562,"context_line":"        lcmocc for lcmocc in inst_lcmoccs"},{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8a684221_a07b0b14","line":564,"range":{"start_line":564,"start_character":37,"end_line":564,"end_character":72},"updated":"2023-02-06 16:49:39.000000000","message":"Once in the \"FAILED\" state, if the LCM operation is successful again, I think LcmOpOcc data of the vnf instance is registered like for example:\n```\n+-----------+------------------+---------------+-----------+\n| id        | operationalState | vnfInstanceId | operation |\n+-----------+------------------+---------------+-----------+\n| OpOccID_1 | FAILED           | InstID_1      | SCALE     |\n| OpOccID_2 | COMPLETED        | InstID_1      | HEAL      |\n+-----------+------------------+---------------+-----------+\n```\nIn this situation, DB sync will always be skipped.\nI\u0027m sorry if I\u0027m wrong. What do you think?","commit_id":"e5cef739d75d15f673319f1e922bbb07b80e8efa"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b7cad5d6ed76ff2cf201b0a7180f80e67f68e571","unresolved":false,"context_lines":[{"line_number":561,"context_line":"    lcmoccs \u003d ["},{"line_number":562,"context_line":"        lcmocc for lcmocc in inst_lcmoccs"},{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c14d995c_382f16ed","line":564,"range":{"start_line":564,"start_character":37,"end_line":564,"end_character":72},"in_reply_to":"444771af_a8df8b20","updated":"2023-02-14 00:45:48.000000000","message":"Ack","commit_id":"e5cef739d75d15f673319f1e922bbb07b80e8efa"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"a015f85083bf20a12266b2e7523c8f245062ac5e","unresolved":true,"context_lines":[{"line_number":561,"context_line":"    lcmoccs \u003d ["},{"line_number":562,"context_line":"        lcmocc for lcmocc in inst_lcmoccs"},{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"444771af_a8df8b20","line":564,"range":{"start_line":564,"start_character":37,"end_line":564,"end_character":72},"in_reply_to":"4835770f_d7f0c68e","updated":"2023-02-09 06:28:19.000000000","message":"Thank you for further discussion! +1","commit_id":"e5cef739d75d15f673319f1e922bbb07b80e8efa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a806788d409ee318c5240b051889328605b2fa1b","unresolved":true,"context_lines":[{"line_number":561,"context_line":"    lcmoccs \u003d ["},{"line_number":562,"context_line":"        lcmocc for lcmocc in inst_lcmoccs"},{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bf2a180a_2474b2ae","line":564,"range":{"start_line":564,"start_character":37,"end_line":564,"end_character":72},"in_reply_to":"8a684221_a07b0b14","updated":"2023-02-07 03:01:58.000000000","message":"In the following two cases, DB synchronization is not performed, is it?\n1. When there is FAILED_TEMP in operationalState of LcmOpOcc.\n2. When the latest operationalState of LcmOpOcc is FAILED.","commit_id":"e5cef739d75d15f673319f1e922bbb07b80e8efa"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ca571474c5ef904cb6ed3e7d4d4d160cbf416e39","unresolved":true,"context_lines":[{"line_number":561,"context_line":"    lcmoccs \u003d ["},{"line_number":562,"context_line":"        lcmocc for lcmocc in inst_lcmoccs"},{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"4835770f_d7f0c68e","line":564,"range":{"start_line":564,"start_character":37,"end_line":564,"end_character":72},"in_reply_to":"9a95859d_13179ccd","updated":"2023-02-08 02:17:43.000000000","message":"I fixed it in patchset 8.","commit_id":"e5cef739d75d15f673319f1e922bbb07b80e8efa"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1baaeab103cedea0ed221630dca61627e4e4d2b6","unresolved":true,"context_lines":[{"line_number":561,"context_line":"    lcmoccs \u003d ["},{"line_number":562,"context_line":"        lcmocc for lcmocc in inst_lcmoccs"},{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a95859d_13179ccd","line":564,"range":{"start_line":564,"start_character":37,"end_line":564,"end_character":72},"in_reply_to":"bf2a180a_2474b2ae","updated":"2023-02-07 04:38:18.000000000","message":"Yes, I think `FAILED` check should do only for the latest LcmOpOcc if there are multiple LcmOpOccs.","commit_id":"e5cef739d75d15f673319f1e922bbb07b80e8efa"},{"author":{"_account_id":31668},"change_message_id":"f18c2c6cd796ef6a00d2d711b7db551d58c3de18","unresolved":true,"context_lines":[{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"def check_lcmocc_in_progress(context, inst_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3d42e481_bb5f9d27","line":566,"updated":"2023-02-06 10:28:51.000000000","message":"I think it would be better to define a suitable Exception separately.","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"61549e5f80371c8f59484fd7b1a37b17dba96fe2","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"def check_lcmocc_in_progress(context, inst_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"8604902f_76ffd1cd","line":566,"in_reply_to":"191ffed2_4372f939","updated":"2023-02-08 23:42:37.000000000","message":"Thank you for your re-work.","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ca571474c5ef904cb6ed3e7d4d4d160cbf416e39","unresolved":true,"context_lines":[{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"def check_lcmocc_in_progress(context, inst_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"b37f79f4_c73dfe96","line":566,"in_reply_to":"3d42e481_bb5f9d27","updated":"2023-02-08 02:17:43.000000000","message":"I changed `OtherOperationInProgress` to `DbSyncFailed`.","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"a7a50f8d025cd5b6fa4efe2e3189884c5ce0d858","unresolved":true,"context_lines":[{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"def check_lcmocc_in_progress(context, inst_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"191ffed2_4372f939","line":566,"in_reply_to":"5195e91b_a398e0f0","updated":"2023-02-08 11:46:55.000000000","message":"I fixed it in patchset 9.","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"9196921bf30c5563764ddd7a467cbdd94b9361f8","unresolved":true,"context_lines":[{"line_number":563,"context_line":"        if lcmocc.operationState in [fields.LcmOperationStateType.FAILED_TEMP,"},{"line_number":564,"context_line":"                                     fields.LcmOperationStateType.FAILED]]"},{"line_number":565,"context_line":"    if lcmoccs:"},{"line_number":566,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"def check_lcmocc_in_progress(context, inst_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5195e91b_a398e0f0","line":566,"in_reply_to":"b37f79f4_c73dfe96","updated":"2023-02-08 05:38:24.000000000","message":"Thank you for the fix.\nHow about changing the method name to \"is_lcmocc_failure_status\" and returning true if it contains a failure status so that it can be called from other than DBsync?\nI feel that the place to raise DbSyncFailed is better in \"conductor_v2(_sync_inst)\" than in \"lcm_op_occ_utils\".\nhttps://review.opendev.org/c/openstack/tacker/+/867787/8/tacker/sol_refactored/conductor/conductor_v2.py#378","commit_id":"e46dc3c767a11094ffc7c5bc024abca895c1d610"},{"author":{"_account_id":31668},"change_message_id":"61549e5f80371c8f59484fd7b1a37b17dba96fe2","unresolved":true,"context_lines":[{"line_number":569,"context_line":"    if failed_temp_lcmoccs or (failed_lcmocc[0].operationState \u003d\u003d"},{"line_number":570,"context_line":"                               fields.LcmOperationStateType.FAILED):"},{"line_number":571,"context_line":"        return True"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":575,"context_line":"    # if the controller or conductor executes an operation for the vnf"}],"source_content_type":"text/x-python","patch_set":9,"id":"51fe32ad_3aa8480d","line":572,"updated":"2023-02-08 23:42:37.000000000","message":"I think it is better to write \"return False\" at the end of the process.\nWhat do you think?","commit_id":"8ce8030d01d6e6f533a74c75008eac8dd646a19c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c3f8bc929365c1c41e103ddedfa27b9ac4031757","unresolved":true,"context_lines":[{"line_number":569,"context_line":"    if failed_temp_lcmoccs or (failed_lcmocc[0].operationState \u003d\u003d"},{"line_number":570,"context_line":"                               fields.LcmOperationStateType.FAILED):"},{"line_number":571,"context_line":"        return True"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":575,"context_line":"    # if the controller or conductor executes an operation for the vnf"}],"source_content_type":"text/x-python","patch_set":9,"id":"5bbb348b_3b61c169","line":572,"in_reply_to":"51fe32ad_3aa8480d","updated":"2023-02-09 02:04:48.000000000","message":"Thanks for your comment, I appended `return False` in patchset 10.","commit_id":"8ce8030d01d6e6f533a74c75008eac8dd646a19c"},{"author":{"_account_id":31668},"change_message_id":"3bcb734e8f9dc430e3ce6f9612e9000d945e5c9c","unresolved":false,"context_lines":[{"line_number":569,"context_line":"    if failed_temp_lcmoccs or (failed_lcmocc[0].operationState \u003d\u003d"},{"line_number":570,"context_line":"                               fields.LcmOperationStateType.FAILED):"},{"line_number":571,"context_line":"        return True"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":575,"context_line":"    # if the controller or conductor executes an operation for the vnf"}],"source_content_type":"text/x-python","patch_set":9,"id":"6b0362ed_d926f501","line":572,"in_reply_to":"5bbb348b_3b61c169","updated":"2023-02-09 02:07:56.000000000","message":"Done","commit_id":"8ce8030d01d6e6f533a74c75008eac8dd646a19c"}],"tacker/sol_refactored/conductor/conductor_v2.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"302435346a0f794067380fc40f1a6af5a09496dd","unresolved":true,"context_lines":[{"line_number":373,"context_line":"    @coordinate.lock_vnf_instance(\u0027{inst.id}\u0027)"},{"line_number":374,"context_line":"    def _sync_inst(self, context, inst, vim_info):"},{"line_number":375,"context_line":"        # NOTE(fengyi): The operation_state in the opocc of vnf_instance"},{"line_number":376,"context_line":"        # has FAILED_TEMP, then the vnf_instance cannot perform DB sync."},{"line_number":377,"context_line":"        lcmocc_utils.check_lcmocc_in_progress(context, inst.id)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        vnf_inst \u003d inst_utils.get_inst(context, inst.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"35b67e6a_bfbd88c6","line":376,"updated":"2023-01-12 08:32:02.000000000","message":"I think Tacker (VNFM) will operate this DB sync.\nTherefore, \"then the vnf_instance cannot perform DB sync.\" -\u003e \"then Tacker cannot perform DB sync for the vnf_instance.\" is better.","commit_id":"837db40ca8631b7946f6dbd5484cd28c01e63538"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"448fbf31b6e1b5f4bebeec4531b0be58f51683ab","unresolved":true,"context_lines":[{"line_number":373,"context_line":"    @coordinate.lock_vnf_instance(\u0027{inst.id}\u0027)"},{"line_number":374,"context_line":"    def _sync_inst(self, context, inst, vim_info):"},{"line_number":375,"context_line":"        # NOTE(fengyi): The operation_state in the opocc of vnf_instance"},{"line_number":376,"context_line":"        # has FAILED_TEMP, then the vnf_instance cannot perform DB sync."},{"line_number":377,"context_line":"        lcmocc_utils.check_lcmocc_in_progress(context, inst.id)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        vnf_inst \u003d inst_utils.get_inst(context, inst.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ec7fc584_d2d5910d","line":376,"in_reply_to":"35b67e6a_bfbd88c6","updated":"2023-01-20 03:56:33.000000000","message":"I fixed it in patchset 4.","commit_id":"837db40ca8631b7946f6dbd5484cd28c01e63538"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dfb3ae5ccf590947bf1ca5444e48064e2c82b1f4","unresolved":false,"context_lines":[{"line_number":373,"context_line":"    @coordinate.lock_vnf_instance(\u0027{inst.id}\u0027)"},{"line_number":374,"context_line":"    def _sync_inst(self, context, inst, vim_info):"},{"line_number":375,"context_line":"        # NOTE(fengyi): The operation_state in the opocc of vnf_instance"},{"line_number":376,"context_line":"        # has FAILED_TEMP, then the vnf_instance cannot perform DB sync."},{"line_number":377,"context_line":"        lcmocc_utils.check_lcmocc_in_progress(context, inst.id)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        vnf_inst \u003d inst_utils.get_inst(context, inst.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"22dc4a33_6b7830e6","line":376,"in_reply_to":"ec7fc584_d2d5910d","updated":"2023-02-02 04:44:51.000000000","message":"Done","commit_id":"837db40ca8631b7946f6dbd5484cd28c01e63538"}],"tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f13f9d76534743f88a1a7ac011e56621bb2c8053","unresolved":true,"context_lines":[{"line_number":2734,"context_line":"            context, vnf_inst.id)"},{"line_number":2735,"context_line":"        if vnf_instance.instantiation_state !\u003d \u0027INSTANTIATED\u0027:"},{"line_number":2736,"context_line":"            return False"},{"line_number":2737,"context_line":""},{"line_number":2738,"context_line":"        filters \u003d {"},{"line_number":2739,"context_line":"            \u0027and\u0027: [{"},{"line_number":2740,"context_line":"                \u0027field\u0027: \u0027vnf_instance_id\u0027, \u0027model\u0027: \u0027VnfLcmOpOccs\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"90169ae7_231e28dc","line":2737,"updated":"2022-12-17 03:47:03.000000000","message":"Could you please add comment to describe validation of checking operation state.","commit_id":"c139316c73128b3baff46b59a9eef8d606d2d7ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"448fbf31b6e1b5f4bebeec4531b0be58f51683ab","unresolved":true,"context_lines":[{"line_number":2734,"context_line":"            context, vnf_inst.id)"},{"line_number":2735,"context_line":"        if vnf_instance.instantiation_state !\u003d \u0027INSTANTIATED\u0027:"},{"line_number":2736,"context_line":"            return False"},{"line_number":2737,"context_line":""},{"line_number":2738,"context_line":"        filters \u003d {"},{"line_number":2739,"context_line":"            \u0027and\u0027: [{"},{"line_number":2740,"context_line":"                \u0027field\u0027: \u0027vnf_instance_id\u0027, \u0027model\u0027: \u0027VnfLcmOpOccs\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc02e545_9942b02f","line":2737,"in_reply_to":"90169ae7_231e28dc","updated":"2023-01-20 03:56:33.000000000","message":"I appended note in patchset 2.","commit_id":"c139316c73128b3baff46b59a9eef8d606d2d7ae"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"302435346a0f794067380fc40f1a6af5a09496dd","unresolved":true,"context_lines":[{"line_number":2747,"context_line":"                \u0027op\u0027: \u0027\u003d\u003d\u0027"},{"line_number":2748,"context_line":"            }]"},{"line_number":2749,"context_line":"        }"},{"line_number":2750,"context_line":"        vnf_lcm_op_occs \u003d objects.VnfLcmOpOccList.get_by_filters("},{"line_number":2751,"context_line":"            context, read_deleted\u003d\u0027no\u0027, filters\u003dfilters)"},{"line_number":2752,"context_line":"        if vnf_lcm_op_occs:"},{"line_number":2753,"context_line":"            raise exceptions.VnfInstanceConflictState("}],"source_content_type":"text/x-python","patch_set":3,"id":"2659a12b_50b16e14","line":2750,"updated":"2023-01-12 08:32:02.000000000","message":"Why is the method to check the OperationState of Opocc implemented in both InfraDriver and Conductor?\nIf the OperationState does not change, then one of them is not needed.","commit_id":"837db40ca8631b7946f6dbd5484cd28c01e63538"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"448fbf31b6e1b5f4bebeec4531b0be58f51683ab","unresolved":true,"context_lines":[{"line_number":2747,"context_line":"                \u0027op\u0027: \u0027\u003d\u003d\u0027"},{"line_number":2748,"context_line":"            }]"},{"line_number":2749,"context_line":"        }"},{"line_number":2750,"context_line":"        vnf_lcm_op_occs \u003d objects.VnfLcmOpOccList.get_by_filters("},{"line_number":2751,"context_line":"            context, read_deleted\u003d\u0027no\u0027, filters\u003dfilters)"},{"line_number":2752,"context_line":"        if vnf_lcm_op_occs:"},{"line_number":2753,"context_line":"            raise exceptions.VnfInstanceConflictState("}],"source_content_type":"text/x-python","patch_set":3,"id":"dd571bbf_75a8ac52","line":2750,"in_reply_to":"2659a12b_50b16e14","updated":"2023-01-20 03:56:33.000000000","message":"What is modified here is the code of V1. Since the construction of V1 and V2 is a bit different, the modified places are inconsistent.","commit_id":"837db40ca8631b7946f6dbd5484cd28c01e63538"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dfb3ae5ccf590947bf1ca5444e48064e2c82b1f4","unresolved":false,"context_lines":[{"line_number":2747,"context_line":"                \u0027op\u0027: \u0027\u003d\u003d\u0027"},{"line_number":2748,"context_line":"            }]"},{"line_number":2749,"context_line":"        }"},{"line_number":2750,"context_line":"        vnf_lcm_op_occs \u003d objects.VnfLcmOpOccList.get_by_filters("},{"line_number":2751,"context_line":"            context, read_deleted\u003d\u0027no\u0027, filters\u003dfilters)"},{"line_number":2752,"context_line":"        if vnf_lcm_op_occs:"},{"line_number":2753,"context_line":"            raise exceptions.VnfInstanceConflictState("}],"source_content_type":"text/x-python","patch_set":3,"id":"8b3232a8_1a249e1b","line":2750,"in_reply_to":"dd571bbf_75a8ac52","updated":"2023-02-02 04:44:51.000000000","message":"Thank you for the comment.\nI understood that this is caused by different implementations between v1 and v2.","commit_id":"837db40ca8631b7946f6dbd5484cd28c01e63538"}],"tacker/vnfm/infra_drivers/kubernetes/utils.py":[{"author":{"_account_id":31668},"change_message_id":"61549e5f80371c8f59484fd7b1a37b17dba96fe2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d684e66d_14d3f4a1","line":105,"updated":"2023-02-08 23:42:37.000000000","message":"ditto","commit_id":"8ce8030d01d6e6f533a74c75008eac8dd646a19c"},{"author":{"_account_id":31668},"change_message_id":"3bcb734e8f9dc430e3ce6f9612e9000d945e5c9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e381425f_e878e1ee","line":105,"in_reply_to":"2331c4a1_f0dce6d5","updated":"2023-02-09 02:07:56.000000000","message":"Done","commit_id":"8ce8030d01d6e6f533a74c75008eac8dd646a19c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"c3f8bc929365c1c41e103ddedfa27b9ac4031757","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2331c4a1_f0dce6d5","line":105,"in_reply_to":"d684e66d_14d3f4a1","updated":"2023-02-09 02:04:48.000000000","message":"Thanks for your comment, I appended `return False` in patchset 10.","commit_id":"8ce8030d01d6e6f533a74c75008eac8dd646a19c"}]}