)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ada109dde6cf198d1a73592eb0c30da0273e0684","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6c31f2b7_714d22cc","updated":"2023-02-09 04:25:31.000000000","message":"recheck","commit_id":"5462285ed402520f16a16bb0bb2492f5ad58a31a"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"dd1b22c1232091209b0804d7229dd6caebccf06c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ed205302_b70990ce","updated":"2023-02-15 09:18:28.000000000","message":"At first, I thought of taking over the existing patch: https://review.opendev.org/c/openstack/tacker/+/828638. However, that patch implements a new feature and it also has a spec document, which is different direction from this patch (i.e., deprecation). Therefore, I created this patch as a different patch.","commit_id":"47c6243c17a7e6f5487da49ac8ad2823b0830622"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"945895e2b368ba2882727e5e8681ecae0f3ce7ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"814e2dbd_84534e3f","updated":"2023-02-21 13:45:39.000000000","message":"Thanks for your patch, please kindly find my comments.\n\nAnd, could you add the release note for this change?","commit_id":"312dab8799dc2fd772a45a5af843a818e2b61d8c"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"227a41ec16aff1c042d5909f9ca936df4306a34b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a25a845e_3dda2db4","updated":"2023-02-16 06:03:25.000000000","message":"recheck","commit_id":"312dab8799dc2fd772a45a5af843a818e2b61d8c"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"139b54f7d12105ff8654dad00e793daae09640db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8dfe58af_262aac32","updated":"2023-02-24 16:36:06.000000000","message":"recheck","commit_id":"d67aed3772fb0f7c738e24b2fdb7dcbe6c71e617"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"78fb6e1283a8a95bae2028003b4768c80a79e8c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"642328b1_ac03aa16","updated":"2023-03-03 01:17:53.000000000","message":"Thanks for your rework, LGTM.","commit_id":"ed0ba564be9284e67166fe5817bf085113afc191"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"5b00d26fa2d0251cdbcbd593c174e8dd5600b847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"97287000_3667fc67","updated":"2023-03-02 07:33:12.000000000","message":"recheck - The infra failure that occurred on 27th Feb has disappeared.","commit_id":"ed0ba564be9284e67166fe5817bf085113afc191"}],"tacker/db/migration/alembic_migrations/versions/de6bfa5bea46_remove_status_from_vim.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"945895e2b368ba2882727e5e8681ecae0f3ce7ac","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":34,"context_line":"    op.drop_column(\u0027vims\u0027, \u0027status\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"d194d7fc_992d0ee5","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":36},"updated":"2023-02-21 13:45:39.000000000","message":"I executed `openstack vim list` and get the following output:\n(`Status` column was blank)\n```\n$ openstack vim list\n+------------+----------------+--------------+------------+------------+--------+\n| ID         | Name           | Tenant_id    | Type       | Is Default | Status |\n+------------+----------------+--------------+------------+------------+--------+\n| 3574(omit) | vim-openstack  | 0192bd(omit) | openstack  | True       |        |\n+------------+----------------+--------------+------------+------------+--------+\n```\n\nDo you need to update some document or update python-tackerclient side?\nHowever, since the final release for client library period is over, is it better to update the document?\nWhat do you think?","commit_id":"312dab8799dc2fd772a45a5af843a818e2b61d8c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2d5a7b7b7084382a9b1056daabed21bd8e564555","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":34,"context_line":"    op.drop_column(\u0027vims\u0027, \u0027status\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e4144ae5_6eaec30f","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":36},"in_reply_to":"7c9d0148_f86eb0cc","updated":"2023-02-27 14:02:14.000000000","message":"Thanks for your update!\nI\u0027ve confirm that status is \"ACTIVE\" when I execute `openstack vim list/show` command.","commit_id":"312dab8799dc2fd772a45a5af843a818e2b61d8c"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"139b54f7d12105ff8654dad00e793daae09640db","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":34,"context_line":"    op.drop_column(\u0027vims\u0027, \u0027status\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7c9d0148_f86eb0cc","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":36},"in_reply_to":"a582f5a6_4b14bf1a","updated":"2023-02-24 16:36:06.000000000","message":"Sorry, I made a mistake.\n```\n$ openstack vim list\n+------------+----------------+--------------+------------+------------+--------+\n| ID         | Name           | Tenant_id    | Type       | Is Default | Status |\n+------------+----------------+--------------+------------+------------+--------+\n| 3574(omit) | vim-openstack  | 0192bd(omit) | openstack  | True       | ACTIVE |\n+------------+----------------+--------------+------------+------------+--------+\n```","commit_id":"312dab8799dc2fd772a45a5af843a818e2b61d8c"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"16d21a83bedf7c5262b2647ff22d916d45fbee48","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":34,"context_line":"    op.drop_column(\u0027vims\u0027, \u0027status\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"a582f5a6_4b14bf1a","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":36},"in_reply_to":"cadfd820_fa459d71","updated":"2023-02-24 12:27:43.000000000","message":"Placed dummy value at PS9. I\u0027ll submit patch that deletes Status field in tacker-pythonclient. If you cores allow backporting it, I\u0027ll submit the packport patch as well. \n\n\n```\n$ openstack vim list\n+------------+----------------+--------------+------------+------------+--------+\n| ID         | Name           | Tenant_id    | Type       | Is Default | Status |\n+------------+----------------+--------------+------------+------------+--------+\n| 3574(omit) | vim-openstack  | 0192bd(omit) | openstack  | True       |        |\n+------------+----------------+--------------+------------+------------+--------+\n```","commit_id":"312dab8799dc2fd772a45a5af843a818e2b61d8c"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"6df9d609395016735477322d9db45c15787d4dfb","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":34,"context_line":"    op.drop_column(\u0027vims\u0027, \u0027status\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"cadfd820_fa459d71","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":36},"in_reply_to":"d194d7fc_992d0ee5","updated":"2023-02-21 16:01:12.000000000","message":"Thank you for pointing it out.\nTo be honest, I couldn\u0027t deal with python-tackerclient side. Now that the dead line of python-tackerclient is over, maybe I should place a dummy value, like ACTIVE, here. It\u0027s better than just leave this field empty. I\u0027ll remove this field in the client side during the next cycle.","commit_id":"312dab8799dc2fd772a45a5af843a818e2b61d8c"}],"tacker/db/nfvo/nfvo_db_plugin.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"945895e2b368ba2882727e5e8681ecae0f3ce7ac","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"                # TODO(hiromu): Remove Event table"},{"line_number":135,"context_line":"                # NOTE(hiromu): \"REGISTERED\" in res_state is a workaround to"},{"line_number":136,"context_line":"                # delete"},{"line_number":137,"context_line":"                # the status field from the Vim table."},{"line_number":138,"context_line":"                self._cos_db_plg.create_event("},{"line_number":139,"context_line":"                    context, res_id\u003dvim_db[\u0027id\u0027],"},{"line_number":140,"context_line":"                    res_type\u003dconstants.RES_TYPE_VIM,"}],"source_content_type":"text/x-python","patch_set":8,"id":"53d37e73_f9a162ce","line":137,"range":{"start_line":136,"start_character":18,"end_line":137,"end_character":54},"updated":"2023-02-21 13:45:39.000000000","message":"nit: I think here can be written on a single line, but why do you break line?","commit_id":"312dab8799dc2fd772a45a5af843a818e2b61d8c"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"16d21a83bedf7c5262b2647ff22d916d45fbee48","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"                # TODO(hiromu): Remove Event table"},{"line_number":135,"context_line":"                # NOTE(hiromu): \"REGISTERED\" in res_state is a workaround to"},{"line_number":136,"context_line":"                # delete"},{"line_number":137,"context_line":"                # the status field from the Vim table."},{"line_number":138,"context_line":"                self._cos_db_plg.create_event("},{"line_number":139,"context_line":"                    context, res_id\u003dvim_db[\u0027id\u0027],"},{"line_number":140,"context_line":"                    res_type\u003dconstants.RES_TYPE_VIM,"}],"source_content_type":"text/x-python","patch_set":8,"id":"c7fd4047_f632a8d0","line":137,"range":{"start_line":136,"start_character":18,"end_line":137,"end_character":54},"in_reply_to":"53d37e73_f9a162ce","updated":"2023-02-24 12:27:43.000000000","message":"Fixed in PS10","commit_id":"312dab8799dc2fd772a45a5af843a818e2b61d8c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2d5a7b7b7084382a9b1056daabed21bd8e564555","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"                # TODO(hiromu): Remove Event table"},{"line_number":135,"context_line":"                # NOTE(hiromu): \"REGISTERED\" in res_state is a workaround to"},{"line_number":136,"context_line":"                # delete"},{"line_number":137,"context_line":"                # the status field from the Vim table."},{"line_number":138,"context_line":"                self._cos_db_plg.create_event("},{"line_number":139,"context_line":"                    context, res_id\u003dvim_db[\u0027id\u0027],"},{"line_number":140,"context_line":"                    res_type\u003dconstants.RES_TYPE_VIM,"}],"source_content_type":"text/x-python","patch_set":8,"id":"028d062f_2c853b63","line":137,"range":{"start_line":136,"start_character":18,"end_line":137,"end_character":54},"in_reply_to":"c7fd4047_f632a8d0","updated":"2023-02-27 14:02:14.000000000","message":"Ack","commit_id":"312dab8799dc2fd772a45a5af843a818e2b61d8c"}]}
