)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"42ff1f281b6b7f48f6022e9db2830615f6745c40","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In v2 API, when using vim with `ETSINFV.HELM.V_3` type, you must"},{"line_number":10,"context_line":"set the `ssl_ca_cert` information. Currently, when registering vim"},{"line_number":11,"context_line":"with kubernetes type and use_helm parameter, it will succeed even"},{"line_number":12,"context_line":"if you don\u0027t set `ssl_ca_cert` information. This causes v2 apis to"},{"line_number":13,"context_line":"fail when you use the vimConnectionInfo stored in the database."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch added a check in register vim to fix this issue. If the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"05e5e39d_a3cc6350","line":12,"updated":"2023-02-09 06:04:09.000000000","message":"NITS: v2 apis -\u003e v2 APIs","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aff7bb16acae814ae9bd9fa7c816b7242a15e8d3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In v2 API, when using vim with `ETSINFV.HELM.V_3` type, you must"},{"line_number":10,"context_line":"set the `ssl_ca_cert` information. Currently, when registering vim"},{"line_number":11,"context_line":"with kubernetes type and use_helm parameter, it will succeed even"},{"line_number":12,"context_line":"if you don\u0027t set `ssl_ca_cert` information. This causes v2 apis to"},{"line_number":13,"context_line":"fail when you use the vimConnectionInfo stored in the database."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch added a check in register vim to fix this issue. If the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"88e0edcd_9dfdd774","line":12,"in_reply_to":"05e5e39d_a3cc6350","updated":"2023-02-14 05:42:58.000000000","message":"I fixed it in PS8.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"12685a24cc99d5a6564950110d7cf7fb30acd136","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In v2 API, when using vim with `ETSINFV.HELM.V_3` type, you must"},{"line_number":10,"context_line":"set the `ssl_ca_cert` information. Currently, when registering vim"},{"line_number":11,"context_line":"with kubernetes type and use_helm parameter, it will succeed even"},{"line_number":12,"context_line":"if you don\u0027t set `ssl_ca_cert` information. This causes v2 apis to"},{"line_number":13,"context_line":"fail when you use the vimConnectionInfo stored in the database."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch added a check in register vim to fix this issue. If the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"190e9180_f5ae6c58","line":12,"in_reply_to":"88e0edcd_9dfdd774","updated":"2023-02-20 11:32:32.000000000","message":"Done","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b24d66b5d0378eac50cb6e8d6cf7a9cc4d82dd4c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"At the same time, FT test items have been added to verify that"},{"line_number":21,"context_line":"v2 API operations perform properly when using the `ETSINFV.HELM.V_3`"},{"line_number":22,"context_line":"type vim that exists in the database."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I629e347413b242ab9e1a5db16c52ca222adc3873"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"68ca8eb3_b6710238","line":23,"updated":"2023-02-09 06:02:48.000000000","message":"Could you add the following?\n* Implements: blueprint helmchart-k8s-vim\n\nAnd please change the Topic to the following.\n* bp/helmchart-k8s-vim","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"42ff1f281b6b7f48f6022e9db2830615f6745c40","unresolved":true,"context_lines":[{"line_number":20,"context_line":"At the same time, FT test items have been added to verify that"},{"line_number":21,"context_line":"v2 API operations perform properly when using the `ETSINFV.HELM.V_3`"},{"line_number":22,"context_line":"type vim that exists in the database."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I629e347413b242ab9e1a5db16c52ca222adc3873"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"e063508e_b2a3d800","line":23,"updated":"2023-02-09 06:04:09.000000000","message":"This patch relates to blueprint \"helmchart-k8s-vim\", so please add \"Implements blueprint helmchart-k8s-vim\" to the commit messages.\nIn addition, could you change topic \"bp/helmchart-k8s-vim\" too?\n\n(Same as hamano-san)","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"3bf559956ab6a50b79dc4d97ddf5566461c9e7a3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"At the same time, FT test items have been added to verify that"},{"line_number":21,"context_line":"v2 API operations perform properly when using the `ETSINFV.HELM.V_3`"},{"line_number":22,"context_line":"type vim that exists in the database."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I629e347413b242ab9e1a5db16c52ca222adc3873"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"2c0ae709_e03d26da","line":23,"in_reply_to":"480ead04_e5eeec8f","updated":"2023-02-15 02:11:43.000000000","message":"Done","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"12685a24cc99d5a6564950110d7cf7fb30acd136","unresolved":false,"context_lines":[{"line_number":20,"context_line":"At the same time, FT test items have been added to verify that"},{"line_number":21,"context_line":"v2 API operations perform properly when using the `ETSINFV.HELM.V_3`"},{"line_number":22,"context_line":"type vim that exists in the database."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I629e347413b242ab9e1a5db16c52ca222adc3873"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5806e7f5_598b1194","line":23,"in_reply_to":"60b7d192_e78d43d7","updated":"2023-02-20 11:32:32.000000000","message":"Done","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aff7bb16acae814ae9bd9fa7c816b7242a15e8d3","unresolved":true,"context_lines":[{"line_number":20,"context_line":"At the same time, FT test items have been added to verify that"},{"line_number":21,"context_line":"v2 API operations perform properly when using the `ETSINFV.HELM.V_3`"},{"line_number":22,"context_line":"type vim that exists in the database."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I629e347413b242ab9e1a5db16c52ca222adc3873"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"480ead04_e5eeec8f","line":23,"in_reply_to":"68ca8eb3_b6710238","updated":"2023-02-14 05:42:58.000000000","message":"I fixed them in PS8.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aff7bb16acae814ae9bd9fa7c816b7242a15e8d3","unresolved":true,"context_lines":[{"line_number":20,"context_line":"At the same time, FT test items have been added to verify that"},{"line_number":21,"context_line":"v2 API operations perform properly when using the `ETSINFV.HELM.V_3`"},{"line_number":22,"context_line":"type vim that exists in the database."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I629e347413b242ab9e1a5db16c52ca222adc3873"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"60b7d192_e78d43d7","line":23,"in_reply_to":"e063508e_b2a3d800","updated":"2023-02-14 05:42:58.000000000","message":"I fixed them in PS8.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"305d33b395e4e44b9b3ede5950084449f172b8f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ecc54eb3_410385bf","updated":"2023-01-19 11:16:19.000000000","message":"recheck - Occasional terminate failure error for k8s.","commit_id":"e5598e1abf42e3cdb2a199efe8c4caf974f2e459"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"12fe6550e8abdd80cedfcebffddf5f6a032092cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6af82ffc_924a205f","updated":"2023-01-23 09:18:22.000000000","message":"recheck - infra failure in sol and sol-v2 job","commit_id":"81b4da735b21775b77d40227db153abbca686ff3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2d735e3ec0788f7e3335249540b40da7b50f6ea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f3d6d12d_d4f3fa2e","updated":"2023-01-25 11:52:18.000000000","message":"recheck - infra failure in sol job","commit_id":"81b4da735b21775b77d40227db153abbca686ff3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1bd7b934e45c2bb65514c702e31a351931dd0ce6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3de8ec6e_4080773b","updated":"2023-01-24 04:20:21.000000000","message":"recheck - unrelated failure in VNF job","commit_id":"81b4da735b21775b77d40227db153abbca686ff3"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"2a54257bbe4deb7368ff665e6e76d62a84ebd8a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fcff1009_2ff89923","updated":"2023-02-07 07:35:27.000000000","message":"Thank you for the patch.\n\nPlease kindly find my comments.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"55d8153cd48198818bd9cdc57973ebcbb0d59383","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5672bd9e_db051ecb","updated":"2023-02-07 01:10:48.000000000","message":"Thank you for your comment.\nPlease check my answer for your comment.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"42ff1f281b6b7f48f6022e9db2830615f6745c40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9069c4de_1d23b53d","updated":"2023-02-09 06:04:09.000000000","message":"Thank you for your patch. Please kindly check my comments.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"defc1cf5cd18c80bc174689e9f0d7b8c724d4695","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"43bac342_1214036d","updated":"2023-02-06 14:30:01.000000000","message":"Thanks for your patch, almost LGTM, but I have a question.\nPlease kindly find it.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"402ddf44b23a26b0d90721c39ad87f4c7e2d6cc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c2ce5858_1ee76f6b","updated":"2023-01-29 03:15:24.000000000","message":"recheck - Occasional terminate failure error for k8s.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"916d54a1a07ff28bb602402ed08e5fbad7fe0188","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4e334f0c_a71ca99c","updated":"2023-01-28 01:39:47.000000000","message":"recheck - infra failure in sol job","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"4c8f465f93b873326070e5c0e6b6d645b7d5e08a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7cc5c410_8ec19579","updated":"2023-01-29 00:53:17.000000000","message":"recheck - infra failure in sol job","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"63ba0420aaf38b0d8bb8eefff9d47edccaf05121","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dbf48b70_8d109a3b","updated":"2023-01-28 06:13:19.000000000","message":"recheck - infra failure in sol job\n          Occasional terminate failure error for k8s","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3934d820ec3c4d6adb061416e2010091d0d94de1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f8187484_a2c8280e","updated":"2023-01-27 13:31:47.000000000","message":"recheck - infra failure in tacker.tests.functional.sol.vnflcm.test_vnf_instance.VnfLcmTest.test_inst_chgextconn_term test of sol job.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aff7bb16acae814ae9bd9fa7c816b7242a15e8d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8dea269e_63735734","updated":"2023-02-14 05:42:58.000000000","message":"To Yuta Kazato, Ai Hamano:\nThank you for your comments.\nI fixed them in PS8.\nPlease kindly check them again.","commit_id":"3547c0db103322246c719c3e8cc2ac1adf3539b3"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"87058061feea353f9f93fedb644262c0a5ed526e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2704ba82_a9c6a479","updated":"2023-02-20 10:22:38.000000000","message":"LGTM","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a907373c9ab90fe2d2a0ded9cd2f8a9de9cca797","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ae9a94f2_cceabb37","updated":"2023-02-20 06:05:55.000000000","message":"LGTM.","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"12685a24cc99d5a6564950110d7cf7fb30acd136","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a08b9f7e_91147a73","updated":"2023-02-20 11:32:32.000000000","message":"Thanks for your re-work! LGTM","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"7a8ce63c565e1bd5232465bee200e99b67d1e8d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d110bf2e_51b3e923","updated":"2023-02-16 00:34:07.000000000","message":"recheck - ubuntu-focal-job time out","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"0e18cd5e87262bc76eed30b2c25985d5b1a9a0f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6e244ab6_da305411","updated":"2023-02-27 01:26:24.000000000","message":"Could you try to rebase if Zuul failed? Thanks.","commit_id":"c91ca520a3be27ad02e528bed2ee3a1ff42a0d26"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"108549d2d1df0d405a534c81bcb79df9c4f95ac3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"be472a97_c9827bcd","updated":"2023-02-23 07:23:43.000000000","message":"recheck - infra failure","commit_id":"c91ca520a3be27ad02e528bed2ee3a1ff42a0d26"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"2f9b2939d8c2ec84607d910e2e708680c2dc4268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e731fa4e_00da827c","updated":"2023-02-23 05:01:34.000000000","message":"recheck - other project error","commit_id":"c91ca520a3be27ad02e528bed2ee3a1ff42a0d26"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"c16c2f0880bc31ef0ff4cfba17142bde5667d6f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"044669e6_ab48ff8f","updated":"2023-02-24 00:49:27.000000000","message":"recheck - sol-kubernetes failure","commit_id":"c91ca520a3be27ad02e528bed2ee3a1ff42a0d26"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"1b22db45360afb9ff55ea69589b4c7844846f682","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a53d8a22_44cddbf9","updated":"2023-02-27 00:36:57.000000000","message":"recheck - sol-kubernetes failure","commit_id":"c91ca520a3be27ad02e528bed2ee3a1ff42a0d26"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"de87ed3e339f1829ce50fa2e8a02d4fd2d487126","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2a4106cd_2606c70c","updated":"2023-02-24 07:40:24.000000000","message":"recheck - sol-v2 infra failure","commit_id":"c91ca520a3be27ad02e528bed2ee3a1ff42a0d26"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"060bd1940fd58aa467ce30f292f78d74579505e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fc58db98_bae27b4e","updated":"2023-02-24 04:52:53.000000000","message":"recheck - sol-v2 timed out","commit_id":"c91ca520a3be27ad02e528bed2ee3a1ff42a0d26"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aebf618c677192fc255ccd7b20d6674f1ba49de9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"22b87445_a70cb6f2","updated":"2023-02-28 07:41:44.000000000","message":"Thank you for your comments.\nI fixed them in PS11.\nPlease kindly check them again.","commit_id":"2cbd84c56f5273ee5dd4b0ae9808bdbd0c2a8f24"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"959f3808a3c59bc3d3d4cd11523e913b65390cb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5af13ac9_38b84aa5","updated":"2023-02-28 09:06:17.000000000","message":"Thanks for your great work! LGTM","commit_id":"2cbd84c56f5273ee5dd4b0ae9808bdbd0c2a8f24"}],"roles/setup-default-vim/tasks/main.yaml":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b24d66b5d0378eac50cb6e8d6cf7a9cc4d82dd4c","unresolved":true,"context_lines":[{"line_number":139,"context_line":"    when:"},{"line_number":140,"context_line":"      - keycloak_host is defined"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  - name: Copy test k8s vim file for helm"},{"line_number":143,"context_line":"    copy:"},{"line_number":144,"context_line":"      remote_src\u003dTrue"},{"line_number":145,"context_line":"      src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-k8s-vim-helm.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1ea524b7_8d400514","line":142,"updated":"2023-02-09 06:02:48.000000000","message":"Like L.184(Replace k8s auth uri in local-k8s-vim.yaml and local-k8s-vim-helm.yaml), how about putting together with L.128(Copy test k8s vim file)?","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"3bf559956ab6a50b79dc4d97ddf5566461c9e7a3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    when:"},{"line_number":140,"context_line":"      - keycloak_host is defined"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  - name: Copy test k8s vim file for helm"},{"line_number":143,"context_line":"    copy:"},{"line_number":144,"context_line":"      remote_src\u003dTrue"},{"line_number":145,"context_line":"      src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-k8s-vim-helm.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"88ff8303_758d1a39","line":142,"in_reply_to":"070a267e_f03197c9","updated":"2023-02-15 02:11:43.000000000","message":"Done","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aff7bb16acae814ae9bd9fa7c816b7242a15e8d3","unresolved":true,"context_lines":[{"line_number":139,"context_line":"    when:"},{"line_number":140,"context_line":"      - keycloak_host is defined"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  - name: Copy test k8s vim file for helm"},{"line_number":143,"context_line":"    copy:"},{"line_number":144,"context_line":"      remote_src\u003dTrue"},{"line_number":145,"context_line":"      src\u003d{{ devstack_base_dir }}/tacker/tacker/tests/etc/samples/local-k8s-vim-helm.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"070a267e_f03197c9","line":142,"in_reply_to":"1ea524b7_8d400514","updated":"2023-02-14 05:42:58.000000000","message":"I put them together in PS8.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"b24d66b5d0378eac50cb6e8d6cf7a9cc4d82dd4c","unresolved":true,"context_lines":[{"line_number":257,"context_line":"    shell: test -f /tmp/agg.crt \u0026\u0026 cat /tmp/agg.crt"},{"line_number":258,"context_line":"    register: ssl_ca_cert"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"  - name: Replace ssl_ca_cert in local-k8s-vim.yaml and local-k8s-vim-oidc.yaml and local-k8s-vim-helm.yaml"},{"line_number":261,"context_line":"    replace:"},{"line_number":262,"context_line":"       path: \"{{ item }}\""},{"line_number":263,"context_line":"       regexp: \"ssl_ca_cert: .*$\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"359e19b4_6db6b98f","line":260,"updated":"2023-02-09 06:02:48.000000000","message":"Since the name is long, how about changing it as follows?\n* Replace ssl_ca_cert in local-k8s-vim yaml files","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"3bf559956ab6a50b79dc4d97ddf5566461c9e7a3","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    shell: test -f /tmp/agg.crt \u0026\u0026 cat /tmp/agg.crt"},{"line_number":258,"context_line":"    register: ssl_ca_cert"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"  - name: Replace ssl_ca_cert in local-k8s-vim.yaml and local-k8s-vim-oidc.yaml and local-k8s-vim-helm.yaml"},{"line_number":261,"context_line":"    replace:"},{"line_number":262,"context_line":"       path: \"{{ item }}\""},{"line_number":263,"context_line":"       regexp: \"ssl_ca_cert: .*$\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"940dde0b_3cd809f3","line":260,"in_reply_to":"1e98ef91_0f353c2d","updated":"2023-02-15 02:11:43.000000000","message":"Done","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aff7bb16acae814ae9bd9fa7c816b7242a15e8d3","unresolved":true,"context_lines":[{"line_number":257,"context_line":"    shell: test -f /tmp/agg.crt \u0026\u0026 cat /tmp/agg.crt"},{"line_number":258,"context_line":"    register: ssl_ca_cert"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"  - name: Replace ssl_ca_cert in local-k8s-vim.yaml and local-k8s-vim-oidc.yaml and local-k8s-vim-helm.yaml"},{"line_number":261,"context_line":"    replace:"},{"line_number":262,"context_line":"       path: \"{{ item }}\""},{"line_number":263,"context_line":"       regexp: \"ssl_ca_cert: .*$\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1e98ef91_0f353c2d","line":260,"in_reply_to":"359e19b4_6db6b98f","updated":"2023-02-14 05:42:58.000000000","message":"I fixed it in PS8.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"375f18e0c409cbff772edd82fdd958ed15e2aa78","unresolved":true,"context_lines":[{"line_number":178,"context_line":"    when:"},{"line_number":179,"context_line":"      - p.stat.exists"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"  - name: Replace k8s auth uri in local-k8s-vim.yaml and local-k8s-vim-helm.yaml"},{"line_number":182,"context_line":"    replace:"},{"line_number":183,"context_line":"       path: \"{{ item }}\""},{"line_number":184,"context_line":"       regexp: \"https://127.0.0.1:6443\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9d17baeb_9a1bbd1e","line":181,"updated":"2023-02-21 07:15:18.000000000","message":"Why don\u0027t you make it clear a consistency for the name of task? Write all file names or \"XXX files\"?","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aebf618c677192fc255ccd7b20d6674f1ba49de9","unresolved":true,"context_lines":[{"line_number":178,"context_line":"    when:"},{"line_number":179,"context_line":"      - p.stat.exists"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"  - name: Replace k8s auth uri in local-k8s-vim.yaml and local-k8s-vim-helm.yaml"},{"line_number":182,"context_line":"    replace:"},{"line_number":183,"context_line":"       path: \"{{ item }}\""},{"line_number":184,"context_line":"       regexp: \"https://127.0.0.1:6443\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"e1103a53_2afcf45d","line":181,"in_reply_to":"9d17baeb_9a1bbd1e","updated":"2023-02-28 07:41:44.000000000","message":"I fixed it in PS11.","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"}],"tacker/nfvo/drivers/vim/kubernetes_driver.py":[{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"2a54257bbe4deb7368ff665e6e76d62a84ebd8a5","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        self._validate_vim(auth_cred, file_descriptor)"},{"line_number":67,"context_line":"        self.clean_authenticate_vim(auth_cred, file_descriptor)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def check_extra_field(self, vim_obj):"},{"line_number":70,"context_line":"        if vim_obj.get(\u0027extra\u0027) and vim_obj[\u0027extra\u0027].get(\u0027use_helm\u0027):"},{"line_number":71,"context_line":"            if not vim_obj[\u0027auth_cred\u0027].get(\u0027ssl_ca_cert\u0027):"},{"line_number":72,"context_line":"                error_message \u003d (\u0027If you want to register kubernetes vim with\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"a8e45d95_c3528796","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":25},"updated":"2023-02-07 07:35:27.000000000","message":"This method is only referenced within the class for validation purposes.\nCould you add \u0027_\u0027 to the method name?\n\ncheck_extra_field -\u003e _check_extra_field","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"b0dd3b2ab562170cc29cd3ca7310ba900659b2c1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self._validate_vim(auth_cred, file_descriptor)"},{"line_number":67,"context_line":"        self.clean_authenticate_vim(auth_cred, file_descriptor)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def check_extra_field(self, vim_obj):"},{"line_number":70,"context_line":"        if vim_obj.get(\u0027extra\u0027) and vim_obj[\u0027extra\u0027].get(\u0027use_helm\u0027):"},{"line_number":71,"context_line":"            if not vim_obj[\u0027auth_cred\u0027].get(\u0027ssl_ca_cert\u0027):"},{"line_number":72,"context_line":"                error_message \u003d (\u0027If you want to register kubernetes vim with\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"d742461c_c7089585","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":25},"in_reply_to":"49da4e6c_456ef72e","updated":"2023-02-15 23:54:18.000000000","message":"Done","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"3bf559956ab6a50b79dc4d97ddf5566461c9e7a3","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        self._validate_vim(auth_cred, file_descriptor)"},{"line_number":67,"context_line":"        self.clean_authenticate_vim(auth_cred, file_descriptor)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def check_extra_field(self, vim_obj):"},{"line_number":70,"context_line":"        if vim_obj.get(\u0027extra\u0027) and vim_obj[\u0027extra\u0027].get(\u0027use_helm\u0027):"},{"line_number":71,"context_line":"            if not vim_obj[\u0027auth_cred\u0027].get(\u0027ssl_ca_cert\u0027):"},{"line_number":72,"context_line":"                error_message \u003d (\u0027If you want to register kubernetes vim with\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"49da4e6c_456ef72e","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":25},"in_reply_to":"a8e45d95_c3528796","updated":"2023-02-15 02:11:43.000000000","message":"ping","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"}],"tacker/tests/functional/sol_kubernetes_v2/paramgen.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"375f18e0c409cbff772edd82fdd958ed15e2aa78","unresolved":true,"context_lines":[{"line_number":321,"context_line":"def helm_instantiate(auth_url\u003dNone, bearer_token\u003dNone, ssl_ca_cert\u003dNone,"},{"line_number":322,"context_line":"                     vim_id\u003dNone):"},{"line_number":323,"context_line":"    if not vim_id:"},{"line_number":324,"context_line":"        vim_id_1 \u003d uuidutils.generate_uuid()"},{"line_number":325,"context_line":"        vim_1 \u003d {"},{"line_number":326,"context_line":"            \"vimId\": vim_id_1,"},{"line_number":327,"context_line":"            \"vimType\": \"ETSINFV.HELM.V_3\","}],"source_content_type":"text/x-python","patch_set":9,"id":"fabfe17c_9003f61b","line":324,"updated":"2023-02-21 07:15:18.000000000","message":"I think it\u0027s no need to assign it, but put the value as below.\n\n```\n\"vimId\": uuidutils.generate_uuid()\n```","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aebf618c677192fc255ccd7b20d6674f1ba49de9","unresolved":true,"context_lines":[{"line_number":321,"context_line":"def helm_instantiate(auth_url\u003dNone, bearer_token\u003dNone, ssl_ca_cert\u003dNone,"},{"line_number":322,"context_line":"                     vim_id\u003dNone):"},{"line_number":323,"context_line":"    if not vim_id:"},{"line_number":324,"context_line":"        vim_id_1 \u003d uuidutils.generate_uuid()"},{"line_number":325,"context_line":"        vim_1 \u003d {"},{"line_number":326,"context_line":"            \"vimId\": vim_id_1,"},{"line_number":327,"context_line":"            \"vimType\": \"ETSINFV.HELM.V_3\","}],"source_content_type":"text/x-python","patch_set":9,"id":"f44aa4c1_533e4e84","line":324,"in_reply_to":"b14fba29_018ac6d6","updated":"2023-02-28 07:41:44.000000000","message":"I fixed it in PS11.","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"108549d2d1df0d405a534c81bcb79df9c4f95ac3","unresolved":true,"context_lines":[{"line_number":321,"context_line":"def helm_instantiate(auth_url\u003dNone, bearer_token\u003dNone, ssl_ca_cert\u003dNone,"},{"line_number":322,"context_line":"                     vim_id\u003dNone):"},{"line_number":323,"context_line":"    if not vim_id:"},{"line_number":324,"context_line":"        vim_id_1 \u003d uuidutils.generate_uuid()"},{"line_number":325,"context_line":"        vim_1 \u003d {"},{"line_number":326,"context_line":"            \"vimId\": vim_id_1,"},{"line_number":327,"context_line":"            \"vimType\": \"ETSINFV.HELM.V_3\","}],"source_content_type":"text/x-python","patch_set":9,"id":"b14fba29_018ac6d6","line":324,"in_reply_to":"fabfe17c_9003f61b","updated":"2023-02-23 07:23:43.000000000","message":"I fixed it in PS10.","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"375f18e0c409cbff772edd82fdd958ed15e2aa78","unresolved":true,"context_lines":[{"line_number":334,"context_line":"            }"},{"line_number":335,"context_line":"        }"},{"line_number":336,"context_line":"    else:"},{"line_number":337,"context_line":"        vim_id_1 \u003d vim_id"},{"line_number":338,"context_line":"        vim_1 \u003d {"},{"line_number":339,"context_line":"            \"vimId\": vim_id_1,"},{"line_number":340,"context_line":"            \"vimType\": \"ETSINFV.HELM.V_3\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9fe828f0_f7d0c9d1","line":337,"updated":"2023-02-21 07:15:18.000000000","message":"ditto","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"108549d2d1df0d405a534c81bcb79df9c4f95ac3","unresolved":true,"context_lines":[{"line_number":334,"context_line":"            }"},{"line_number":335,"context_line":"        }"},{"line_number":336,"context_line":"    else:"},{"line_number":337,"context_line":"        vim_id_1 \u003d vim_id"},{"line_number":338,"context_line":"        vim_1 \u003d {"},{"line_number":339,"context_line":"            \"vimId\": vim_id_1,"},{"line_number":340,"context_line":"            \"vimType\": \"ETSINFV.HELM.V_3\","}],"source_content_type":"text/x-python","patch_set":9,"id":"e154ab96_834669b2","line":337,"in_reply_to":"9fe828f0_f7d0c9d1","updated":"2023-02-23 07:23:43.000000000","message":"ditto","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aebf618c677192fc255ccd7b20d6674f1ba49de9","unresolved":true,"context_lines":[{"line_number":334,"context_line":"            }"},{"line_number":335,"context_line":"        }"},{"line_number":336,"context_line":"    else:"},{"line_number":337,"context_line":"        vim_id_1 \u003d vim_id"},{"line_number":338,"context_line":"        vim_1 \u003d {"},{"line_number":339,"context_line":"            \"vimId\": vim_id_1,"},{"line_number":340,"context_line":"            \"vimType\": \"ETSINFV.HELM.V_3\","}],"source_content_type":"text/x-python","patch_set":9,"id":"b9352bc9_a46df85e","line":337,"in_reply_to":"e154ab96_834669b2","updated":"2023-02-28 07:41:44.000000000","message":"ditto","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"}],"tacker/tests/unit/nfvo/drivers/vim/test_kubernetes_driver.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"375f18e0c409cbff772edd82fdd958ed15e2aa78","unresolved":true,"context_lines":[{"line_number":182,"context_line":"                         \u0027fake-secret-uuid\u0027)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_register_vim_with_use_helm_parameter(self):"},{"line_number":185,"context_line":"        dict \u003d {\u0027name\u0027: \u0027default\u0027}"},{"line_number":186,"context_line":"        name \u003d namedtuple(\"name\", dict.keys())(*dict.values())"},{"line_number":187,"context_line":"        dict \u003d {\u0027metadata\u0027: name}"},{"line_number":188,"context_line":"        metadata \u003d namedtuple(\"metadata\", dict.keys())(*dict.values())"}],"source_content_type":"text/x-python","patch_set":9,"id":"d8c4e323_f3a075b8","line":185,"range":{"start_line":185,"start_character":8,"end_line":185,"end_character":12},"updated":"2023-02-21 07:15:18.000000000","message":"Please don\u0027t use such a reserved name as a variable here and all.","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aebf618c677192fc255ccd7b20d6674f1ba49de9","unresolved":true,"context_lines":[{"line_number":182,"context_line":"                         \u0027fake-secret-uuid\u0027)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_register_vim_with_use_helm_parameter(self):"},{"line_number":185,"context_line":"        dict \u003d {\u0027name\u0027: \u0027default\u0027}"},{"line_number":186,"context_line":"        name \u003d namedtuple(\"name\", dict.keys())(*dict.values())"},{"line_number":187,"context_line":"        dict \u003d {\u0027metadata\u0027: name}"},{"line_number":188,"context_line":"        metadata \u003d namedtuple(\"metadata\", dict.keys())(*dict.values())"}],"source_content_type":"text/x-python","patch_set":9,"id":"db5944fb_7f0ac8be","line":185,"range":{"start_line":185,"start_character":8,"end_line":185,"end_character":12},"in_reply_to":"d8c4e323_f3a075b8","updated":"2023-02-28 07:41:44.000000000","message":"I fixed it in PS11.","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"375f18e0c409cbff772edd82fdd958ed15e2aa78","unresolved":true,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def test_register_vim_with_use_helm_parameter_error(self):"},{"line_number":209,"context_line":"        self.vim_obj[\u0027extra\u0027] \u003d {\u0027use_helm\u0027: True}"},{"line_number":210,"context_line":"        del self.vim_obj[\u0027auth_cred\u0027][\u0027ssl_ca_cert\u0027]"},{"line_number":211,"context_line":"        self.assertRaises(nfvo.VimUnauthorizedException,"},{"line_number":212,"context_line":"                          self.kubernetes_driver.register_vim, self.vim_obj)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba259579_f722a6f2","line":210,"updated":"2023-02-21 07:15:18.000000000","message":"Could you make it clear the reason why you del the attribute explicitly, or consider rename the name of function more specifically?","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"aebf618c677192fc255ccd7b20d6674f1ba49de9","unresolved":true,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def test_register_vim_with_use_helm_parameter_error(self):"},{"line_number":209,"context_line":"        self.vim_obj[\u0027extra\u0027] \u003d {\u0027use_helm\u0027: True}"},{"line_number":210,"context_line":"        del self.vim_obj[\u0027auth_cred\u0027][\u0027ssl_ca_cert\u0027]"},{"line_number":211,"context_line":"        self.assertRaises(nfvo.VimUnauthorizedException,"},{"line_number":212,"context_line":"                          self.kubernetes_driver.register_vim, self.vim_obj)"}],"source_content_type":"text/x-python","patch_set":9,"id":"e385e3be_0fe86b69","line":210,"in_reply_to":"ba259579_f722a6f2","updated":"2023-02-28 07:41:44.000000000","message":"When you use_helm and not set ssl_ca_cert, it will raise error. To test this situation, thi test was added.\nI renamed the name of function to make it clear.","commit_id":"15717adad9dc5040f879f71612338b2717cc6f81"}],"tools/test-setup-k8s-vim.sh":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"defc1cf5cd18c80bc174689e9f0d7b8c724d4695","unresolved":true,"context_lines":[{"line_number":34,"context_line":"register_vim $conf_dir/local-k8s-vim.yaml vim-kubernetes"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# register vim with OpenID Connect info"},{"line_number":37,"context_line":"if [ -f /tmp/keycloak.crt ]"},{"line_number":38,"context_line":"then"},{"line_number":39,"context_line":"    register_vim $conf_dir/local-k8s-vim-oidc.yaml vim-kubernetes-oidc"},{"line_number":40,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1cef13a2_d340eaed","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":25},"updated":"2023-02-06 14:30:01.000000000","message":"Just a question, why did you change here?\nIt doesn\u0027t seem to have relation with this change.","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":34996,"name":"Shuwen Cai","email":"caishuwen@fujitsu.com","username":"shuwencai123"},"change_message_id":"55d8153cd48198818bd9cdc57973ebcbb0d59383","unresolved":true,"context_lines":[{"line_number":34,"context_line":"register_vim $conf_dir/local-k8s-vim.yaml vim-kubernetes"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# register vim with OpenID Connect info"},{"line_number":37,"context_line":"if [ -f /tmp/keycloak.crt ]"},{"line_number":38,"context_line":"then"},{"line_number":39,"context_line":"    register_vim $conf_dir/local-k8s-vim-oidc.yaml vim-kubernetes-oidc"},{"line_number":40,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"77ea613e_3211886e","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":25},"in_reply_to":"1cef13a2_d340eaed","updated":"2023-02-07 01:10:48.000000000","message":"When I made the test in zuul, the value of conf_dir is `/home/zuul/src/opendev.org/openstack/tacker/tacker/tests/etc/samples`, in this path, the `local-k8s-vim-oidc.yaml` file always exist. So it will execute `register vim with openID connect info`, but in common test which does not install keycloak, it will fail. So I changed this check, in common test, this branch is not entered.\n\nHere is the error message:\n```\n2023-01-19 05:03:21.000615 | controller-tacker | + \u0027[\u0027 -f /home/zuul/src/opendev.org/openstack/tacker/tacker/tests/etc/samples/local-k8s-vim-oidc.yaml \u0027]\u0027\n2023-01-19 05:03:21.000705 | controller-tacker | + register_vim /home/zuul/src/opendev.org/openstack/tacker/tacker/tests/etc/samples/local-k8s-vim-oidc.yaml vim-kubernetes-oidc\n2023-01-19 05:03:21.000741 | controller-tacker | + openstack vim register --os-username nfv_user --os-project-name nfv --os-password devstack --os-auth-url http://10.209.1.164/identity --os-project-domain-name Default --os-user-domain-name Default --description \u0027Kubernetes VIM\u0027 --config-file /home/zuul/src/opendev.org/openstack/tacker/tacker/tests/etc/samples/local-k8s-vim-oidc.yaml vim-kubernetes-oidc\n2023-01-19 05:03:22.801281 | controller-tacker | OIDC authentication and authorization failed. Detail: HTTPSConnectionPool(host\u003d\u0027127.0.0.1\u0027, port\u003d8443): Max retries exceeded with url: /realms/oidc/protocol/openid-connect/token (Caused by NewConnectionError(\u0027\u003curllib3.connection.HTTPSConnection object at 0x7fb448922380\u003e: Failed to establish a new connection: [Errno 111] ECONNREFUSED\u0027))\n2023-01-19 05:03:33.463294 | controller-tacker | ERROR\n2023-01-19 05:03:33.463633 | controller-tacker | {\n2023-01-19 05:03:33.463726 | controller-tacker |   \"delta\": \"0:00:05.027808\",\n2023-01-19 05:03:33.463812 | controller-tacker |   \"end\": \"2023-01-19 05:03:22.965315\",\n2023-01-19 05:03:33.463893 | controller-tacker |   \"msg\": \"non-zero return code\",\n2023-01-19 05:03:33.463973 | controller-tacker |   \"rc\": 1,\n2023-01-19 05:03:33.464052 | controller-tacker |   \"start\": \"2023-01-19 05:03:17.937507\"\n2023-01-19 05:03:33.464154 | controller-tacker | }\n```","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a907373c9ab90fe2d2a0ded9cd2f8a9de9cca797","unresolved":false,"context_lines":[{"line_number":34,"context_line":"register_vim $conf_dir/local-k8s-vim.yaml vim-kubernetes"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# register vim with OpenID Connect info"},{"line_number":37,"context_line":"if [ -f /tmp/keycloak.crt ]"},{"line_number":38,"context_line":"then"},{"line_number":39,"context_line":"    register_vim $conf_dir/local-k8s-vim-oidc.yaml vim-kubernetes-oidc"},{"line_number":40,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"a83476b5_a3687850","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":25},"in_reply_to":"77ea613e_3211886e","updated":"2023-02-20 06:05:55.000000000","message":"In my understanding, this change moved to the following patch:\nhttps://review.opendev.org/c/openstack/tacker/+/873488","commit_id":"ecd8373fcc4e2772063781cb8f82adcec0a7d80c"}]}
