)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"690070d53b5c1e428b680fdc70c322f4fb8b92b8","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  the system filesystem resource is wasted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes these problems as follows:"},{"line_number":19,"context_line":"* VNF package content is cached at the first time of extracing"},{"line_number":20,"context_line":"  it. If cache exists, extracting from NFVO is not done at"},{"line_number":21,"context_line":"  executing LCM lifecycle management v2 APIs."},{"line_number":22,"context_line":"* A cache will be deleted when vnf instance which use it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"320e2fb0_5293352b","line":19,"range":{"start_line":19,"start_character":53,"end_line":19,"end_character":62},"updated":"2023-02-01 16:12:10.000000000","message":"typo: extracting","commit_id":"bf3723ba9baebf42a7913ad31a272ce5ec7bb8f8"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6666659865e6ba57a39ebe285cb4bb419d8132ec","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  the system filesystem resource is wasted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes these problems as follows:"},{"line_number":19,"context_line":"* VNF package content is cached at the first time of extracing"},{"line_number":20,"context_line":"  it. If cache exists, extracting from NFVO is not done at"},{"line_number":21,"context_line":"  executing LCM lifecycle management v2 APIs."},{"line_number":22,"context_line":"* A cache will be deleted when vnf instance which use it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c9548968_b87a0c1f","line":19,"range":{"start_line":19,"start_character":53,"end_line":19,"end_character":62},"in_reply_to":"320e2fb0_5293352b","updated":"2023-02-01 22:14:43.000000000","message":"I will fix.","commit_id":"bf3723ba9baebf42a7913ad31a272ce5ec7bb8f8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0d1fe69b73bdcb3d39ce355e0fc647d306908b9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  the system filesystem resource is wasted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes these problems as follows:"},{"line_number":19,"context_line":"* VNF package content is cached at the first time of extracing"},{"line_number":20,"context_line":"  it. If cache exists, extracting from NFVO is not done at"},{"line_number":21,"context_line":"  executing LCM lifecycle management v2 APIs."},{"line_number":22,"context_line":"* A cache will be deleted when vnf instance which use it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2fb429c4_5c8f02cc","line":19,"range":{"start_line":19,"start_character":53,"end_line":19,"end_character":62},"in_reply_to":"c9548968_b87a0c1f","updated":"2023-02-07 13:11:00.000000000","message":"Ack","commit_id":"bf3723ba9baebf42a7913ad31a272ce5ec7bb8f8"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"de3f8fe0a1faebc74e451753b49ebb46e9878111","unresolved":true,"context_lines":[{"line_number":12,"context_line":"* VNF package content is extracted and saved on a temporary"},{"line_number":13,"context_line":"  directory every time for executing LCM lifecycle management"},{"line_number":14,"context_line":"  v2 APIs."},{"line_number":15,"context_line":"* These temporary directories are never deleted. Therefore"},{"line_number":16,"context_line":"  the system filesystem resource is wasted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes these problems as follows:"},{"line_number":19,"context_line":"* VNF package content is cached at the first time of extracting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"184d9e37_6902d0f6","line":16,"range":{"start_line":15,"start_character":49,"end_line":16,"end_character":43},"updated":"2023-02-02 05:53:33.000000000","message":"I don\u0027t think \"system\" is necessary.\n\nTherefore the system filesystem resource is wasted.\n\u003d\u003e\nTherefore the filesystem resource is wasted.","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"819ee2de84b202092cc99872d1552e3ddbc1e653","unresolved":true,"context_lines":[{"line_number":12,"context_line":"* VNF package content is extracted and saved on a temporary"},{"line_number":13,"context_line":"  directory every time for executing LCM lifecycle management"},{"line_number":14,"context_line":"  v2 APIs."},{"line_number":15,"context_line":"* These temporary directories are never deleted. Therefore"},{"line_number":16,"context_line":"  the system filesystem resource is wasted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes these problems as follows:"},{"line_number":19,"context_line":"* VNF package content is cached at the first time of extracting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6eb8a5f1_1fe6ccca","line":16,"range":{"start_line":15,"start_character":49,"end_line":16,"end_character":43},"in_reply_to":"184d9e37_6902d0f6","updated":"2023-02-02 22:18:22.000000000","message":"I see. I will fix.","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"856919fc1014372bc59bd6548b7d54b954e2e4a4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"* VNF package content is extracted and saved on a temporary"},{"line_number":13,"context_line":"  directory every time for executing LCM lifecycle management"},{"line_number":14,"context_line":"  v2 APIs."},{"line_number":15,"context_line":"* These temporary directories are never deleted. Therefore"},{"line_number":16,"context_line":"  the system filesystem resource is wasted."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch fixes these problems as follows:"},{"line_number":19,"context_line":"* VNF package content is cached at the first time of extracting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9bc4f8b8_fc9893fd","line":16,"range":{"start_line":15,"start_character":49,"end_line":16,"end_character":43},"in_reply_to":"6eb8a5f1_1fe6ccca","updated":"2023-02-03 05:14:54.000000000","message":"Done","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dce6f80e5c30cde68afbee8b6919bb222edec1e8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add VNF package content cache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously there are some problems about extraction VNF packages"},{"line_number":10,"context_line":"when external NFVO is used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* VNF package content is extracted and saved on a temporary"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"91b9d09e_8f2c557b","line":9,"range":{"start_line":9,"start_character":41,"end_line":9,"end_character":64},"updated":"2023-02-10 01:52:11.000000000","message":"nits: extraction VNF packages -\u003e extraction of VNF packages","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"49590b919ce2d333c8bceb40692561b2411cf16b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add VNF package content cache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously there are some problems about extraction VNF packages"},{"line_number":10,"context_line":"when external NFVO is used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* VNF package content is extracted and saved on a temporary"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"6cfb797d_154153e7","line":9,"range":{"start_line":9,"start_character":41,"end_line":9,"end_character":64},"in_reply_to":"52fe5f6a_3b754663","updated":"2023-02-14 12:53:04.000000000","message":"Done","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"60bed0901c56148c6eadf191f8419135f89e020b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add VNF package content cache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previously there are some problems about extraction VNF packages"},{"line_number":10,"context_line":"when external NFVO is used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* VNF package content is extracted and saved on a temporary"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"52fe5f6a_3b754663","line":9,"range":{"start_line":9,"start_character":41,"end_line":9,"end_character":64},"in_reply_to":"91b9d09e_8f2c557b","updated":"2023-02-10 02:39:10.000000000","message":"I will fix.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dce6f80e5c30cde68afbee8b6919bb222edec1e8","unresolved":true,"context_lines":[{"line_number":19,"context_line":"* VNF package content is cached at the first time of extracting"},{"line_number":20,"context_line":"  it. If cache exists, extracting from NFVO is not done at"},{"line_number":21,"context_line":"  executing LCM lifecycle management v2 APIs."},{"line_number":22,"context_line":"* A cache will be deleted when vnf instance which use it is"},{"line_number":23,"context_line":"  deleted."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch fixes the following problem too:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"e5dbd5e8_4bd41539","line":22,"updated":"2023-02-10 01:52:11.000000000","message":"nits: use -\u003e uses","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"60bed0901c56148c6eadf191f8419135f89e020b","unresolved":true,"context_lines":[{"line_number":19,"context_line":"* VNF package content is cached at the first time of extracting"},{"line_number":20,"context_line":"  it. If cache exists, extracting from NFVO is not done at"},{"line_number":21,"context_line":"  executing LCM lifecycle management v2 APIs."},{"line_number":22,"context_line":"* A cache will be deleted when vnf instance which use it is"},{"line_number":23,"context_line":"  deleted."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch fixes the following problem too:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fe60b412_f7b74ceb","line":22,"in_reply_to":"e5dbd5e8_4bd41539","updated":"2023-02-10 02:39:10.000000000","message":"I will fix.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"49590b919ce2d333c8bceb40692561b2411cf16b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"* VNF package content is cached at the first time of extracting"},{"line_number":20,"context_line":"  it. If cache exists, extracting from NFVO is not done at"},{"line_number":21,"context_line":"  executing LCM lifecycle management v2 APIs."},{"line_number":22,"context_line":"* A cache will be deleted when vnf instance which use it is"},{"line_number":23,"context_line":"  deleted."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch fixes the following problem too:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"af9fedb2_8c8d316e","line":22,"in_reply_to":"fe60b412_f7b74ceb","updated":"2023-02-14 12:53:04.000000000","message":"Done","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6666659865e6ba57a39ebe285cb4bb419d8132ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f99189db_9a905726","updated":"2023-02-01 22:14:43.000000000","message":"Thank you for the review.","commit_id":"bf3723ba9baebf42a7913ad31a272ce5ec7bb8f8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"690070d53b5c1e428b680fdc70c322f4fb8b92b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c7db611b_d5d9803c","updated":"2023-02-01 16:12:10.000000000","message":"Thanks for your patch, almost LGTM. please kindly find my tiny comments.","commit_id":"bf3723ba9baebf42a7913ad31a272ce5ec7bb8f8"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"819ee2de84b202092cc99872d1552e3ddbc1e653","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"260dc5ec_865cd64a","updated":"2023-02-02 22:18:22.000000000","message":"Thank you for the review.","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c6f3d85786e3ccd9e27418acf615e0a457c8616d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dfbd0ee0_06a7a66f","updated":"2023-02-02 22:25:36.000000000","message":"Thank you for the review.","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"68af9d7c6ad41795a4f622f014854303aefd789d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b310646e_3f69c19a","updated":"2023-02-07 23:20:51.000000000","message":"LGTM","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dce6f80e5c30cde68afbee8b6919bb222edec1e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"669421e4_48eebc1e","updated":"2023-02-10 01:52:11.000000000","message":"Thank you for the patch. Please kindly check my comments.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"60bed0901c56148c6eadf191f8419135f89e020b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"28a406ce_cf8520e6","updated":"2023-02-10 02:39:10.000000000","message":"Thank you for the review.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0d1fe69b73bdcb3d39ce355e0fc647d306908b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"82870b4f_3abf7e78","updated":"2023-02-07 13:11:00.000000000","message":"Thanks for your updating, LGTM.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"9b094797b9b7d7b0da0ce84da5da8c59603e091a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3dd7d431_090b8885","updated":"2023-02-15 00:58:26.000000000","message":"LGTM","commit_id":"c592c0c2ccf10833cf87de0c2a82b56c5b4368cb"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"49590b919ce2d333c8bceb40692561b2411cf16b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9712ecba_a7981507","updated":"2023-02-14 12:53:04.000000000","message":"Thanks for your re-work! LGTM","commit_id":"c592c0c2ccf10833cf87de0c2a82b56c5b4368cb"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"67ba05b6720b41d0e7ba90c6d276b5d03a6778bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"61d8c79b_c9906c72","updated":"2023-02-14 12:55:12.000000000","message":"recheck - infra failure in sol-v2-ubuntu-focal.","commit_id":"c592c0c2ccf10833cf87de0c2a82b56c5b4368cb"}],"tacker/sol_refactored/common/vnfd_utils.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dce6f80e5c30cde68afbee8b6919bb222edec1e8","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        self.csar_dir \u003d csar_dir"},{"line_number":44,"context_line":"        self._init_vnfd(csar_dir)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def init_from_zip_file(self, zip_file):"},{"line_number":47,"context_line":"        # NOTE: This is used when external NFVO is used and only VNFD in"},{"line_number":48,"context_line":"        # the vnf package is extracted."},{"line_number":49,"context_line":"        csar_dir \u003d tempfile.mkdtemp()"}],"source_content_type":"text/x-python","patch_set":7,"id":"0b175013_c79fe65b","line":46,"updated":"2023-02-10 01:52:11.000000000","message":"`init_from_zip_file` might mislead users to input a file path as an argument.\nI think that `init_from_zip_data` is better. What do you think?","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"60bed0901c56148c6eadf191f8419135f89e020b","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        self.csar_dir \u003d csar_dir"},{"line_number":44,"context_line":"        self._init_vnfd(csar_dir)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def init_from_zip_file(self, zip_file):"},{"line_number":47,"context_line":"        # NOTE: This is used when external NFVO is used and only VNFD in"},{"line_number":48,"context_line":"        # the vnf package is extracted."},{"line_number":49,"context_line":"        csar_dir \u003d tempfile.mkdtemp()"}],"source_content_type":"text/x-python","patch_set":7,"id":"4bec1266_e7ef633e","line":46,"in_reply_to":"0b175013_c79fe65b","updated":"2023-02-10 02:39:10.000000000","message":"I see. I will change.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"49590b919ce2d333c8bceb40692561b2411cf16b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.csar_dir \u003d csar_dir"},{"line_number":44,"context_line":"        self._init_vnfd(csar_dir)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def init_from_zip_file(self, zip_file):"},{"line_number":47,"context_line":"        # NOTE: This is used when external NFVO is used and only VNFD in"},{"line_number":48,"context_line":"        # the vnf package is extracted."},{"line_number":49,"context_line":"        csar_dir \u003d tempfile.mkdtemp()"}],"source_content_type":"text/x-python","patch_set":7,"id":"71468c0d_8fdb1ccb","line":46,"in_reply_to":"4bec1266_e7ef633e","updated":"2023-02-14 12:53:04.000000000","message":"Done","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"}],"tacker/sol_refactored/nfvo/nfvo_client.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"690070d53b5c1e428b680fdc70c322f4fb8b92b8","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        if self.is_local:"},{"line_number":187,"context_line":"            self.nfvo.recv_inst_delete_notification(context, inst)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        if not self.is_local:"},{"line_number":190,"context_line":"            self._delete_csar_cache(context, inst.vnfdId)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def send_lcmocc_notification(self, context, lcmocc, inst, endpoint):"}],"source_content_type":"text/x-python","patch_set":3,"id":"0607d853_4a3c185b","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":29},"updated":"2023-02-01 16:12:10.000000000","message":"How about it change to just `else:`?","commit_id":"bf3723ba9baebf42a7913ad31a272ce5ec7bb8f8"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6666659865e6ba57a39ebe285cb4bb419d8132ec","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        if self.is_local:"},{"line_number":187,"context_line":"            self.nfvo.recv_inst_delete_notification(context, inst)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        if not self.is_local:"},{"line_number":190,"context_line":"            self._delete_csar_cache(context, inst.vnfdId)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def send_lcmocc_notification(self, context, lcmocc, inst, endpoint):"}],"source_content_type":"text/x-python","patch_set":3,"id":"c8e246ae_56f2861a","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":29},"in_reply_to":"0607d853_4a3c185b","updated":"2023-02-01 22:14:43.000000000","message":"I don\u0027t use \u0027else\u0027 because nfvo.recv_inst_delete_notification and _delete_csar_cache are unrelated.","commit_id":"bf3723ba9baebf42a7913ad31a272ce5ec7bb8f8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d0d1fe69b73bdcb3d39ce355e0fc647d306908b9","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        if self.is_local:"},{"line_number":187,"context_line":"            self.nfvo.recv_inst_delete_notification(context, inst)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        if not self.is_local:"},{"line_number":190,"context_line":"            self._delete_csar_cache(context, inst.vnfdId)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def send_lcmocc_notification(self, context, lcmocc, inst, endpoint):"}],"source_content_type":"text/x-python","patch_set":3,"id":"6e1239c2_2e2ead11","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":29},"in_reply_to":"c8e246ae_56f2861a","updated":"2023-02-07 13:11:00.000000000","message":"Thanks for your answer, I got it.","commit_id":"bf3723ba9baebf42a7913ad31a272ce5ec7bb8f8"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"e70d285d895e7e74baa38359cd1b0975ea312204","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        insts \u003d objects.VnfInstanceV2.get_by_filter(context,"},{"line_number":149,"context_line":"                                                    vnfdId\u003dvnfd_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # NOTE: assume this method called by delete instance"},{"line_number":152,"context_line":"        if len(insts) \u003e 0:"},{"line_number":153,"context_line":"            return"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"76c82b8e_1e4f175f","line":151,"updated":"2023-02-02 09:12:22.000000000","message":"I think the following is better, what do you think?\n```\nassume this method called after delete VnfInstance\n```","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c6f3d85786e3ccd9e27418acf615e0a457c8616d","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        insts \u003d objects.VnfInstanceV2.get_by_filter(context,"},{"line_number":149,"context_line":"                                                    vnfdId\u003dvnfd_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # NOTE: assume this method called by delete instance"},{"line_number":152,"context_line":"        if len(insts) \u003e 0:"},{"line_number":153,"context_line":"            return"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"eb8c140d_a32f1f64","line":151,"in_reply_to":"76c82b8e_1e4f175f","updated":"2023-02-02 22:25:36.000000000","message":"I see. I will fix.","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"ca3bf2e2466c0c0a2f4d88199454a39193a99af7","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        insts \u003d objects.VnfInstanceV2.get_by_filter(context,"},{"line_number":149,"context_line":"                                                    vnfdId\u003dvnfd_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # NOTE: assume this method called by delete instance"},{"line_number":152,"context_line":"        if len(insts) \u003e 0:"},{"line_number":153,"context_line":"            return"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"47150e50_e907ac72","line":151,"in_reply_to":"eb8c140d_a32f1f64","updated":"2023-02-02 23:58:27.000000000","message":"Done","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"e70d285d895e7e74baa38359cd1b0975ea312204","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        except Exception:"},{"line_number":163,"context_line":"            # NOTE: it is not failed basically since no one ought to"},{"line_number":164,"context_line":"            # access it. maybe critical system failure if failed."},{"line_number":165,"context_line":"            # it is critical for tacker since imcomplete cache may remain."},{"line_number":166,"context_line":"            # should be deleted manually."},{"line_number":167,"context_line":"            LOG.critical(\"VNF package cache \u0027%s\u0027 can not be deleted\", csar_dir)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e1d8545f_5345ebe9","line":165,"updated":"2023-02-02 09:12:22.000000000","message":"typo: imcomplete -\u003e incomplete","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"ca3bf2e2466c0c0a2f4d88199454a39193a99af7","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        except Exception:"},{"line_number":163,"context_line":"            # NOTE: it is not failed basically since no one ought to"},{"line_number":164,"context_line":"            # access it. maybe critical system failure if failed."},{"line_number":165,"context_line":"            # it is critical for tacker since imcomplete cache may remain."},{"line_number":166,"context_line":"            # should be deleted manually."},{"line_number":167,"context_line":"            LOG.critical(\"VNF package cache \u0027%s\u0027 can not be deleted\", csar_dir)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d0a62e15_4fdd7941","line":165,"in_reply_to":"cfc736da_2d0fa105","updated":"2023-02-02 23:58:27.000000000","message":"Done","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c6f3d85786e3ccd9e27418acf615e0a457c8616d","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        except Exception:"},{"line_number":163,"context_line":"            # NOTE: it is not failed basically since no one ought to"},{"line_number":164,"context_line":"            # access it. maybe critical system failure if failed."},{"line_number":165,"context_line":"            # it is critical for tacker since imcomplete cache may remain."},{"line_number":166,"context_line":"            # should be deleted manually."},{"line_number":167,"context_line":"            LOG.critical(\"VNF package cache \u0027%s\u0027 can not be deleted\", csar_dir)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"cfc736da_2d0fa105","line":165,"in_reply_to":"e1d8545f_5345ebe9","updated":"2023-02-02 22:25:36.000000000","message":"I will fix.","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dce6f80e5c30cde68afbee8b6919bb222edec1e8","unresolved":true,"context_lines":[{"line_number":120,"context_line":"        vnfd \u003d vnfd_utils.Vnfd(vnfd_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        if os.path.isdir(csar_dir):"},{"line_number":123,"context_line":"            # if cache exists, use it regardless all_contents"},{"line_number":124,"context_line":"            vnfd.init_from_csar_dir(csar_dir)"},{"line_number":125,"context_line":"        elif not all_contents:"},{"line_number":126,"context_line":"            # need VNFD only. not make cache."}],"source_content_type":"text/x-python","patch_set":7,"id":"983b0049_ee574937","line":123,"updated":"2023-02-10 01:52:11.000000000","message":"nits: regardless -\u003e regardless of","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"49590b919ce2d333c8bceb40692561b2411cf16b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        vnfd \u003d vnfd_utils.Vnfd(vnfd_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        if os.path.isdir(csar_dir):"},{"line_number":123,"context_line":"            # if cache exists, use it regardless all_contents"},{"line_number":124,"context_line":"            vnfd.init_from_csar_dir(csar_dir)"},{"line_number":125,"context_line":"        elif not all_contents:"},{"line_number":126,"context_line":"            # need VNFD only. not make cache."}],"source_content_type":"text/x-python","patch_set":7,"id":"5b5b8df2_3f33106b","line":123,"in_reply_to":"0f0ed400_00896949","updated":"2023-02-14 12:53:04.000000000","message":"Done","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"60bed0901c56148c6eadf191f8419135f89e020b","unresolved":true,"context_lines":[{"line_number":120,"context_line":"        vnfd \u003d vnfd_utils.Vnfd(vnfd_id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        if os.path.isdir(csar_dir):"},{"line_number":123,"context_line":"            # if cache exists, use it regardless all_contents"},{"line_number":124,"context_line":"            vnfd.init_from_csar_dir(csar_dir)"},{"line_number":125,"context_line":"        elif not all_contents:"},{"line_number":126,"context_line":"            # need VNFD only. not make cache."}],"source_content_type":"text/x-python","patch_set":7,"id":"0f0ed400_00896949","line":123,"in_reply_to":"983b0049_ee574937","updated":"2023-02-10 02:39:10.000000000","message":"I will fix.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dce6f80e5c30cde68afbee8b6919bb222edec1e8","unresolved":true,"context_lines":[{"line_number":126,"context_line":"            # need VNFD only. not make cache."},{"line_number":127,"context_line":"            zip_file \u003d self.onboarded_show_vnfd(context, vnfd_id)"},{"line_number":128,"context_line":"            vnfd.init_from_zip_file(zip_file)"},{"line_number":129,"context_line":"        else:  # all_contents"},{"line_number":130,"context_line":"            # get vnf package contents and make cache"},{"line_number":131,"context_line":"            zip_file \u003d self.onboarded_package_content(context, vnfd_id)"},{"line_number":132,"context_line":"            self._make_csar_cache(csar_dir, zip_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"4480ba58_169fc743","line":129,"range":{"start_line":129,"start_character":17,"end_line":129,"end_character":29},"updated":"2023-02-10 01:52:11.000000000","message":"I think it is better to write `all_contents\u003dTrue` to understand the situation.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"49590b919ce2d333c8bceb40692561b2411cf16b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            # need VNFD only. not make cache."},{"line_number":127,"context_line":"            zip_file \u003d self.onboarded_show_vnfd(context, vnfd_id)"},{"line_number":128,"context_line":"            vnfd.init_from_zip_file(zip_file)"},{"line_number":129,"context_line":"        else:  # all_contents"},{"line_number":130,"context_line":"            # get vnf package contents and make cache"},{"line_number":131,"context_line":"            zip_file \u003d self.onboarded_package_content(context, vnfd_id)"},{"line_number":132,"context_line":"            self._make_csar_cache(csar_dir, zip_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"34739bea_18361ab0","line":129,"range":{"start_line":129,"start_character":17,"end_line":129,"end_character":29},"in_reply_to":"00f02bb0_41a6285a","updated":"2023-02-14 12:53:04.000000000","message":"Done","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"60bed0901c56148c6eadf191f8419135f89e020b","unresolved":true,"context_lines":[{"line_number":126,"context_line":"            # need VNFD only. not make cache."},{"line_number":127,"context_line":"            zip_file \u003d self.onboarded_show_vnfd(context, vnfd_id)"},{"line_number":128,"context_line":"            vnfd.init_from_zip_file(zip_file)"},{"line_number":129,"context_line":"        else:  # all_contents"},{"line_number":130,"context_line":"            # get vnf package contents and make cache"},{"line_number":131,"context_line":"            zip_file \u003d self.onboarded_package_content(context, vnfd_id)"},{"line_number":132,"context_line":"            self._make_csar_cache(csar_dir, zip_file)"}],"source_content_type":"text/x-python","patch_set":7,"id":"00f02bb0_41a6285a","line":129,"range":{"start_line":129,"start_character":17,"end_line":129,"end_character":29},"in_reply_to":"4480ba58_169fc743","updated":"2023-02-10 02:39:10.000000000","message":"I will fix.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dce6f80e5c30cde68afbee8b6919bb222edec1e8","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # NOTE: assume this method called after delete VnfInstance"},{"line_number":152,"context_line":"        if len(insts) \u003e 0:"},{"line_number":153,"context_line":"            return"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        csar_dir \u003d os.path.join(self.csar_cache_dir, vnfd_id)"},{"line_number":156,"context_line":"        if os.path.exists(csar_dir):"}],"source_content_type":"text/x-python","patch_set":7,"id":"daf6b43b_fa075878","line":153,"updated":"2023-02-10 01:52:11.000000000","message":"I think that it is better to add comments `# if there are other vnfinstances using the same cache, do nothing.` to understand the situation.\nIf wrong, please tell me.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"49590b919ce2d333c8bceb40692561b2411cf16b","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # NOTE: assume this method called after delete VnfInstance"},{"line_number":152,"context_line":"        if len(insts) \u003e 0:"},{"line_number":153,"context_line":"            return"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        csar_dir \u003d os.path.join(self.csar_cache_dir, vnfd_id)"},{"line_number":156,"context_line":"        if os.path.exists(csar_dir):"}],"source_content_type":"text/x-python","patch_set":7,"id":"f8e02e4c_e986c873","line":153,"in_reply_to":"67a451ce_e9b59ec4","updated":"2023-02-14 12:53:04.000000000","message":"Done","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"60bed0901c56148c6eadf191f8419135f89e020b","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # NOTE: assume this method called after delete VnfInstance"},{"line_number":152,"context_line":"        if len(insts) \u003e 0:"},{"line_number":153,"context_line":"            return"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        csar_dir \u003d os.path.join(self.csar_cache_dir, vnfd_id)"},{"line_number":156,"context_line":"        if os.path.exists(csar_dir):"}],"source_content_type":"text/x-python","patch_set":7,"id":"67a451ce_e9b59ec4","line":153,"in_reply_to":"daf6b43b_fa075878","updated":"2023-02-10 02:39:10.000000000","message":"Ok, I will add.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dce6f80e5c30cde68afbee8b6919bb222edec1e8","unresolved":true,"context_lines":[{"line_number":164,"context_line":"            # access it. maybe critical system failure if failed."},{"line_number":165,"context_line":"            # it is critical for tacker since incomplete cache may remain."},{"line_number":166,"context_line":"            # should be deleted manually."},{"line_number":167,"context_line":"            LOG.critical(\"VNF package cache \u0027%s\u0027 can not be deleted\", csar_dir)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def send_inst_create_notification(self, context, inst, endpoint):"},{"line_number":170,"context_line":"        subscs \u003d subsc_utils.get_inst_create_subscs(context, inst)"}],"source_content_type":"text/x-python","patch_set":7,"id":"17a02623_4c1ac089","line":167,"range":{"start_line":167,"start_character":49,"end_line":167,"end_character":56},"updated":"2023-02-10 01:52:11.000000000","message":"nits: can not -\u003e could not","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"60bed0901c56148c6eadf191f8419135f89e020b","unresolved":true,"context_lines":[{"line_number":164,"context_line":"            # access it. maybe critical system failure if failed."},{"line_number":165,"context_line":"            # it is critical for tacker since incomplete cache may remain."},{"line_number":166,"context_line":"            # should be deleted manually."},{"line_number":167,"context_line":"            LOG.critical(\"VNF package cache \u0027%s\u0027 can not be deleted\", csar_dir)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def send_inst_create_notification(self, context, inst, endpoint):"},{"line_number":170,"context_line":"        subscs \u003d subsc_utils.get_inst_create_subscs(context, inst)"}],"source_content_type":"text/x-python","patch_set":7,"id":"8ed2e0b9_f0a1fa35","line":167,"range":{"start_line":167,"start_character":49,"end_line":167,"end_character":56},"in_reply_to":"17a02623_4c1ac089","updated":"2023-02-10 02:39:10.000000000","message":"I will fix.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"49590b919ce2d333c8bceb40692561b2411cf16b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            # access it. maybe critical system failure if failed."},{"line_number":165,"context_line":"            # it is critical for tacker since incomplete cache may remain."},{"line_number":166,"context_line":"            # should be deleted manually."},{"line_number":167,"context_line":"            LOG.critical(\"VNF package cache \u0027%s\u0027 can not be deleted\", csar_dir)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def send_inst_create_notification(self, context, inst, endpoint):"},{"line_number":170,"context_line":"        subscs \u003d subsc_utils.get_inst_create_subscs(context, inst)"}],"source_content_type":"text/x-python","patch_set":7,"id":"f9e0077d_1c71b2fb","line":167,"range":{"start_line":167,"start_character":49,"end_line":167,"end_character":56},"in_reply_to":"8ed2e0b9_f0a1fa35","updated":"2023-02-14 12:53:04.000000000","message":"Done","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"}],"tacker/tests/unit/sol_refactored/nfvo/test_nfvo_client.py":[{"author":{"_account_id":31668,"deleted":true},"change_message_id":"e70d285d895e7e74baa38359cd1b0975ea312204","unresolved":true,"context_lines":[{"line_number":453,"context_line":"    def test_delete_csar_dir(self):"},{"line_number":454,"context_line":"        log_name \u003d \"tacker.sol_refactored.nfvo.nfvo_client\""},{"line_number":455,"context_line":"        csar_dir \u003d \"/tmp/not_exist\""},{"line_number":456,"context_line":"        with self.assertLogs(logger\u003dlog_name, level\u003dlogging.ERROR) as cm:"},{"line_number":457,"context_line":"            self.nfvo_client._delete_csar_dir(csar_dir)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        msg \u003d (f\"CRITICAL:{log_name}:VNF package cache \u0027{csar_dir}\u0027 \""}],"source_content_type":"text/x-python","patch_set":5,"id":"a9bf41cf_968b1f46","line":456,"updated":"2023-02-02 09:12:22.000000000","message":"Isn\u0027t level `logging.CRITICAL\u0027 more appropriate for this test?","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":31668,"deleted":true},"change_message_id":"ca3bf2e2466c0c0a2f4d88199454a39193a99af7","unresolved":false,"context_lines":[{"line_number":453,"context_line":"    def test_delete_csar_dir(self):"},{"line_number":454,"context_line":"        log_name \u003d \"tacker.sol_refactored.nfvo.nfvo_client\""},{"line_number":455,"context_line":"        csar_dir \u003d \"/tmp/not_exist\""},{"line_number":456,"context_line":"        with self.assertLogs(logger\u003dlog_name, level\u003dlogging.ERROR) as cm:"},{"line_number":457,"context_line":"            self.nfvo_client._delete_csar_dir(csar_dir)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        msg \u003d (f\"CRITICAL:{log_name}:VNF package cache \u0027{csar_dir}\u0027 \""}],"source_content_type":"text/x-python","patch_set":5,"id":"e59ea2c1_b2d55731","line":456,"in_reply_to":"52a4eb30_fe8ec5c3","updated":"2023-02-02 23:58:27.000000000","message":"Done","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c6f3d85786e3ccd9e27418acf615e0a457c8616d","unresolved":true,"context_lines":[{"line_number":453,"context_line":"    def test_delete_csar_dir(self):"},{"line_number":454,"context_line":"        log_name \u003d \"tacker.sol_refactored.nfvo.nfvo_client\""},{"line_number":455,"context_line":"        csar_dir \u003d \"/tmp/not_exist\""},{"line_number":456,"context_line":"        with self.assertLogs(logger\u003dlog_name, level\u003dlogging.ERROR) as cm:"},{"line_number":457,"context_line":"            self.nfvo_client._delete_csar_dir(csar_dir)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        msg \u003d (f\"CRITICAL:{log_name}:VNF package cache \u0027{csar_dir}\u0027 \""}],"source_content_type":"text/x-python","patch_set":5,"id":"52a4eb30_fe8ec5c3","line":456,"in_reply_to":"a9bf41cf_968b1f46","updated":"2023-02-02 22:25:36.000000000","message":"right. I will fix.","commit_id":"df6eef81d2191bb00e8b63360bfca2c201912e2e"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"dce6f80e5c30cde68afbee8b6919bb222edec1e8","unresolved":true,"context_lines":[{"line_number":457,"context_line":"            self.nfvo_client._delete_csar_dir(csar_dir)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        msg \u003d (f\"CRITICAL:{log_name}:VNF package cache \u0027{csar_dir}\u0027 \""},{"line_number":460,"context_line":"               \"can not be deleted\")"},{"line_number":461,"context_line":"        self.assertIn(msg, cm.output[0])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5850ccc7_0b04ec7f","line":460,"range":{"start_line":460,"start_character":16,"end_line":460,"end_character":23},"updated":"2023-02-10 01:52:11.000000000","message":"nits: can not -\u003e could not","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"60bed0901c56148c6eadf191f8419135f89e020b","unresolved":true,"context_lines":[{"line_number":457,"context_line":"            self.nfvo_client._delete_csar_dir(csar_dir)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        msg \u003d (f\"CRITICAL:{log_name}:VNF package cache \u0027{csar_dir}\u0027 \""},{"line_number":460,"context_line":"               \"can not be deleted\")"},{"line_number":461,"context_line":"        self.assertIn(msg, cm.output[0])"}],"source_content_type":"text/x-python","patch_set":7,"id":"e17d4574_3ef0987f","line":460,"range":{"start_line":460,"start_character":16,"end_line":460,"end_character":23},"in_reply_to":"5850ccc7_0b04ec7f","updated":"2023-02-10 02:39:10.000000000","message":"I will fix.","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"49590b919ce2d333c8bceb40692561b2411cf16b","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            self.nfvo_client._delete_csar_dir(csar_dir)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        msg \u003d (f\"CRITICAL:{log_name}:VNF package cache \u0027{csar_dir}\u0027 \""},{"line_number":460,"context_line":"               \"can not be deleted\")"},{"line_number":461,"context_line":"        self.assertIn(msg, cm.output[0])"}],"source_content_type":"text/x-python","patch_set":7,"id":"be3f86cd_031e2c32","line":460,"range":{"start_line":460,"start_character":16,"end_line":460,"end_character":23},"in_reply_to":"e17d4574_3ef0987f","updated":"2023-02-14 12:53:04.000000000","message":"Done","commit_id":"26490d644fcb7f9b8a0b720f3636d84fdbc92040"}]}