)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4dd424c71adcf158eb0090fb9b17dc06e58caa42","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Koji Shimizu \u003cshimizu.koji@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-13 03:29:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support promQL config file for PrometheusPlugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The PromQL statement data for PrometheusPlugin is able to"},{"line_number":10,"context_line":"customize with external data file. The operators can use the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"4f5ed485_9c0aac04","line":7,"updated":"2023-02-20 06:13:16.000000000","message":"nits promQL -\u003e PromQL","commit_id":"1364000ff4b125f6ee6c0fdf7f7516699b41158e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"df02ec877e28ba546ee3e6626bf6fef1b0b882d1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Koji Shimizu \u003cshimizu.koji@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-13 03:29:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support promQL config file for PrometheusPlugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The PromQL statement data for PrometheusPlugin is able to"},{"line_number":10,"context_line":"customize with external data file. The operators can use the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"71cb545c_839d68d1","line":7,"in_reply_to":"4f5ed485_9c0aac04","updated":"2023-02-21 00:12:53.000000000","message":"Fixed at PS13.","commit_id":"1364000ff4b125f6ee6c0fdf7f7516699b41158e"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"16383b47eedb4dd0cc4bb809a1b6ea98e27ca0d7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Koji Shimizu \u003cshimizu.koji@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-02-13 03:29:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support promQL config file for PrometheusPlugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The PromQL statement data for PrometheusPlugin is able to"},{"line_number":10,"context_line":"customize with external data file. The operators can use the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"022e17ed_9f379002","line":7,"in_reply_to":"71cb545c_839d68d1","updated":"2023-03-01 01:12:44.000000000","message":"Thank you for rework!Done","commit_id":"1364000ff4b125f6ee6c0fdf7f7516699b41158e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"9f7a6898a7458bf6db871f3c73d0ee735fca0a5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eec6c2bc_d83d49ad","updated":"2023-01-25 11:13:29.000000000","message":"recheck, system down","commit_id":"6056fb79ca81793bfb5cda8b5efbc9a4f7e235ce"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"2ec947037324997cdd00f76fe400c434ac79aa46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1765d830_73b87f16","updated":"2023-01-26 22:45:21.000000000","message":"Please kindly review this patch.","commit_id":"343767035db7b3a3234dd05094e7a1c564ad4c34"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"d774179aa650ef6e89f7589bba67a6f218f777c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"889d7ff1_3eaff4dc","updated":"2023-01-26 06:43:48.000000000","message":"recheck, tacker-functional-devstack-multinode-sol","commit_id":"343767035db7b3a3234dd05094e7a1c564ad4c34"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"fc2cf98768c77ee3da1cc5aca7dae241c8fae6f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"536a0b3f_87bb763f","updated":"2023-01-26 10:44:19.000000000","message":"recheck, unknown failure","commit_id":"343767035db7b3a3234dd05094e7a1c564ad4c34"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"df685887bc54772cc7af2d4636e7991a1a43ff35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5a8979b9_22ca3ee1","updated":"2023-01-26 19:21:09.000000000","message":"recheck, unknown failure","commit_id":"343767035db7b3a3234dd05094e7a1c564ad4c34"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"c696c87203e6099c74bae0a58793b3b56111ce5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"304ac288_bae9bff5","updated":"2023-02-04 14:37:50.000000000","message":"recheck, Feb 04 09:00:23.234479 np0032969945 tacker-conductor[26416]: 2023-02-04 09:00:23.233 26416 ERROR tacker.sol_refactored.conductor.conductor_v2 tacker.sol_refactored.common.exceptions.K8sOperaitionTimeout: Kubernetes operation did not complete within the timeout period.","commit_id":"aa7c7d3778b19fde04740c77f0b9a2266c470c33"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"7d0b56800c04459d0f0eae6a2129c987842dd3c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ab832029_b8267a21","updated":"2023-02-05 06:26:10.000000000","message":"recheck, Feb 04 16:33:45.567258 np0032970992 tacker-conductor[26528]: 2023-02-04 16:33:45.563 ERROR tacker.sol_refactored.conductor.conductor_v2 [req-58ff959c-9d84-45b9-8d7f-1d356130c2ed nfv_user nfv] PROCESSING TERMINATE failed: tacker.sol_refactored.common.exceptions.K8sOperaitionTimeout: Kubernetes operation did not complete within the timeout period.","commit_id":"aa7c7d3778b19fde04740c77f0b9a2266c470c33"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"89edd4e7841bea866cf2f7416ca2a091c0a930b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2e72d6ab_31871b35","updated":"2023-02-06 04:11:26.000000000","message":"recheck, Feb 05 08:15:42.495013 np0032973859 tacker-conductor[24583]: 2023-02-05 08:15:42.493 24583 ERROR tacker.sol_refactored.conductor.conductor_v2 tacker.sol_refactored.common.exceptions.StackOperationFailed: Resource CREATE failed: ClientException: resources.VDU2: Unknown Error (HTTP 500)","commit_id":"aa7c7d3778b19fde04740c77f0b9a2266c470c33"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"aa103b09df4ad848b768636484fac30f3e094d06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"32435241_89fbc069","updated":"2023-02-06 07:58:37.000000000","message":"recheck, Feb 06 05:20:56.807004 np0032978529 tacker-conductor[24157]: tacker.common.exceptions.VnfInstantiationWaitFailed: Vnf instantiation wait failed for vnf 0a48460b-70aa-4654-bc61-540820c54739, error: VNF Create Resource CREATE failed: ClientException: resources.VDU1_scale.resources.xyzct6df6hbr.resources.VDU1: Unknown Error (HTTP 500)","commit_id":"aa7c7d3778b19fde04740c77f0b9a2266c470c33"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccadb5d78e11ba8ac01bb6c42443120568d6b981","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c298338d_41eed1ef","updated":"2023-02-10 14:54:19.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"4fce67911e79afead38c232115c8e677cc0bd89a"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"03e822630037b6b9e7c096205237f6dd6560d73f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6945701c_cd72444c","updated":"2023-02-17 06:03:59.000000000","message":"Thank you very much for the review.","commit_id":"1364000ff4b125f6ee6c0fdf7f7516699b41158e"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4dd424c71adcf158eb0090fb9b17dc06e58caa42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"93e1e31b_1759439d","updated":"2023-02-20 06:13:16.000000000","message":"Thank you for the patch. Please kindly my nits comments.","commit_id":"796d0a494c967ec03a81bec621e74cd7cef74761"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"df02ec877e28ba546ee3e6626bf6fef1b0b882d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"730f72b3_e1ab74f5","updated":"2023-02-21 00:12:53.000000000","message":"Thank you very much for the review.","commit_id":"828f2702983e48968758608d40e96804a055ccf9"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"16383b47eedb4dd0cc4bb809a1b6ea98e27ca0d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5928eade_c5fb445f","updated":"2023-03-01 01:12:44.000000000","message":"Sorry for my late review.. I added some comments, so please kindly check them.","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"59c06c0fbc21ce16c57003e729da0c1f20355844","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"57047c59_3455a192","updated":"2023-02-24 13:56:47.000000000","message":"Thank you very much for the review.","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cf51e90e93df96456e84fbdc67d81828f0a13800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e037e577_66338310","updated":"2023-02-27 07:53:35.000000000","message":"Thanks for your rework. LGTM.\n I will add CR+2 after the parent patch is merged.","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"366e529dcfbd7a1e0b594a11c5a791909bb3fd3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"4bc42480_9828c706","updated":"2023-03-01 04:57:04.000000000","message":"Thank you very much for the review.","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"f76f5f48cda85ad6548b7743ec26ec1648333b94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e673eca0_6618e421","updated":"2023-03-01 04:57:13.000000000","message":"recheck, 2023-03-01 03:21:37.717462 | controller-tacker |     AssertionError: LCM incomplete timeout","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"0005b285dece52a155b8f62078478517db836a9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b320576a_c7cb8689","updated":"2023-03-02 02:22:24.000000000","message":"Thank you for the patch.\nPlease check my question.","commit_id":"0dbe5defc9046bc0adcbb0fbf23c0a501fcca6e0"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"997ccf00d2f7e4f3fd30d11a3b095f008e6daf36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"442a6874_8e207123","updated":"2023-03-02 05:23:35.000000000","message":"Thank you for re-work!","commit_id":"6d2a97dd1ac631ec47dcf2fbccbd26ae127b441f"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"da12c62001325a916b62523b350612a89953ab84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"2c51382a_8a1bfcb7","updated":"2023-03-02 04:45:23.000000000","message":"Thank you very much for the review.","commit_id":"6d2a97dd1ac631ec47dcf2fbccbd26ae127b441f"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"8c7237e7d6efce49e7c0f5f40e3c358577371155","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"6b960231_cbc985bb","updated":"2023-03-02 10:23:36.000000000","message":"Thank you for submitting the patch.\n\nPlease quickly find my comments.","commit_id":"aad09ab76d3e6c015e2fdb89d08981d8c25bbb8c"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"a5443528b7fb0c6a7fbb8c9db7e7ef80bb00d69f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0dfa4f36_da8f2e73","updated":"2023-03-02 06:13:01.000000000","message":"Thank you very much for the review.","commit_id":"aad09ab76d3e6c015e2fdb89d08981d8c25bbb8c"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"0f401047b77bf76d21556a813c244294a9465a0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"069b8c97_f2be5bfb","updated":"2023-03-02 08:39:06.000000000","message":"recheck unknown failure.","commit_id":"aad09ab76d3e6c015e2fdb89d08981d8c25bbb8c"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"a38134d53355f8a85a7bb2e8f94d9156cf3c8d1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"11b54b7d_51bb3adc","updated":"2023-03-02 11:17:56.000000000","message":"Thank you very much for the review.","commit_id":"d26c69951a398cf7c056293f68684c8f8815a950"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"e4e5666b3f3a6c0832bbb66cbead63881334781f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7e9a4968_12cb5c9f","updated":"2023-03-02 13:01:39.000000000","message":"Thank you for your quick response.\nLGTM.","commit_id":"5ab59f7edb5b31e863c97017c77a0f27a0989e1e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"865ab1f477ff3fb0c5269e60248c22f53c6e609b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"15e7b436_82b344c6","updated":"2023-03-02 14:37:17.000000000","message":"recheck - infra failure in multinode-sol-v2-ubuntu-focal job\n\n```\nMar 02 12:45:28.156195 np0033332890 tacker-conductor[49883]: 2023-03-02 12:45:28.154 49883 ERROR tacker.sol_refactored.conductor.conductor_v2 tacker.sol_refactored.common.exceptions.StackOperationFailed: Resource CREATE failed: BadRequest: resources.VDU1-1.resources.VDU1: Port 2aa225cd-949d-42a0-872f-c5246de58a36 requires a FixedIP in order to be used. (HTTP 400) (Request-ID: req-9b615293-644a-4957-95c2-1409f2484128)\n```","commit_id":"5ab59f7edb5b31e863c97017c77a0f27a0989e1e"}],"doc/source/user/prometheus_plugin_use_case_guide.rst":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"4dd424c71adcf158eb0090fb9b17dc06e58caa42","unresolved":true,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":".. code-block:: yaml"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"  fVCpuUsageMeanVnf: \u003e-"},{"line_number":441,"context_line":"    avg(sum(rate(pod_cpu_usage_seconds_total"},{"line_number":442,"context_line":"    {{namespace\u003d\"{namespace}\",pod\u003d~\"{pod}\"}}[{reporting_period}s])))"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"969d1e35_f193f371","line":440,"range":{"start_line":440,"start_character":2,"end_line":440,"end_character":19},"updated":"2023-02-20 06:13:16.000000000","message":"typo?: fVCpuUsageMeanVnf -\u003e VCpuUsageMeanVnf","commit_id":"1364000ff4b125f6ee6c0fdf7f7516699b41158e"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"16383b47eedb4dd0cc4bb809a1b6ea98e27ca0d7","unresolved":false,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":".. code-block:: yaml"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"  fVCpuUsageMeanVnf: \u003e-"},{"line_number":441,"context_line":"    avg(sum(rate(pod_cpu_usage_seconds_total"},{"line_number":442,"context_line":"    {{namespace\u003d\"{namespace}\",pod\u003d~\"{pod}\"}}[{reporting_period}s])))"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"a4fd68d3_b0ebae13","line":440,"range":{"start_line":440,"start_character":2,"end_line":440,"end_character":19},"in_reply_to":"559e1275_911bf626","updated":"2023-03-01 01:12:44.000000000","message":"Done","commit_id":"1364000ff4b125f6ee6c0fdf7f7516699b41158e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"df02ec877e28ba546ee3e6626bf6fef1b0b882d1","unresolved":true,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":".. code-block:: yaml"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"  fVCpuUsageMeanVnf: \u003e-"},{"line_number":441,"context_line":"    avg(sum(rate(pod_cpu_usage_seconds_total"},{"line_number":442,"context_line":"    {{namespace\u003d\"{namespace}\",pod\u003d~\"{pod}\"}}[{reporting_period}s])))"},{"line_number":443,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"559e1275_911bf626","line":440,"range":{"start_line":440,"start_character":2,"end_line":440,"end_character":19},"in_reply_to":"969d1e35_f193f371","updated":"2023-02-21 00:12:53.000000000","message":"Fixed at PS13.","commit_id":"1364000ff4b125f6ee6c0fdf7f7516699b41158e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"8c7237e7d6efce49e7c0f5f40e3c358577371155","unresolved":true,"context_lines":[{"line_number":444,"context_line":"F-string of PromQL statement"},{"line_number":445,"context_line":"----------------------------"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"For above PromQL statement, f-string of python is used. In the f-string, below"},{"line_number":448,"context_line":"replacement field can be used. They are replaced with a SOL-API\u0027s"},{"line_number":449,"context_line":"attribute [#etsi_sol_003]_ or Tacker internal value."},{"line_number":450,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"6e4a9fe5_4ea6939a","line":447,"updated":"2023-03-02 10:23:36.000000000","message":"Please add a reference for f-string [1] \n\nhttps://docs.python.org/3.9/tutorial/inputoutput.html#fancier-output-formatting","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"a38134d53355f8a85a7bb2e8f94d9156cf3c8d1f","unresolved":true,"context_lines":[{"line_number":444,"context_line":"F-string of PromQL statement"},{"line_number":445,"context_line":"----------------------------"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"For above PromQL statement, f-string of python is used. In the f-string, below"},{"line_number":448,"context_line":"replacement field can be used. They are replaced with a SOL-API\u0027s"},{"line_number":449,"context_line":"attribute [#etsi_sol_003]_ or Tacker internal value."},{"line_number":450,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"a7d1b17a_edca592b","line":447,"in_reply_to":"6e4a9fe5_4ea6939a","updated":"2023-03-02 11:17:56.000000000","message":"fixed in PS21.","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"e4e5666b3f3a6c0832bbb66cbead63881334781f","unresolved":false,"context_lines":[{"line_number":444,"context_line":"F-string of PromQL statement"},{"line_number":445,"context_line":"----------------------------"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"For above PromQL statement, f-string of python is used. In the f-string, below"},{"line_number":448,"context_line":"replacement field can be used. They are replaced with a SOL-API\u0027s"},{"line_number":449,"context_line":"attribute [#etsi_sol_003]_ or Tacker internal value."},{"line_number":450,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"9496b44a_25e288ba","line":447,"in_reply_to":"a7d1b17a_edca592b","updated":"2023-03-02 13:01:39.000000000","message":"Done","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"}],"etc/tacker/prometheus-plugin.yaml":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"16383b47eedb4dd0cc4bb809a1b6ea98e27ca0d7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Prometheus plugin configuration file"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This describes the Prometheus plugin configuration. This is used when"},{"line_number":4,"context_line":"# Prometheus Plugin creates a alert rule. You can use your own promQL"},{"line_number":5,"context_line":"# statements. Put this file in the configuration directory (e.g:/etc/tacker)."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# The settings are key-value pairs of a performanceMetric and a PromQL"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"f5e24a71_dc352e1c","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":29},"updated":"2023-03-01 01:12:44.000000000","message":"nits: a alert -\u003e an alert","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"997ccf00d2f7e4f3fd30d11a3b095f008e6daf36","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Prometheus plugin configuration file"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This describes the Prometheus plugin configuration. This is used when"},{"line_number":4,"context_line":"# Prometheus Plugin creates a alert rule. You can use your own promQL"},{"line_number":5,"context_line":"# statements. Put this file in the configuration directory (e.g:/etc/tacker)."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# The settings are key-value pairs of a performanceMetric and a PromQL"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ba6d4a61_aca568d2","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":29},"in_reply_to":"a8aeef81_3f9e9871","updated":"2023-03-02 05:23:35.000000000","message":"Done","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"366e529dcfbd7a1e0b594a11c5a791909bb3fd3b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Prometheus plugin configuration file"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This describes the Prometheus plugin configuration. This is used when"},{"line_number":4,"context_line":"# Prometheus Plugin creates a alert rule. You can use your own promQL"},{"line_number":5,"context_line":"# statements. Put this file in the configuration directory (e.g:/etc/tacker)."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# The settings are key-value pairs of a performanceMetric and a PromQL"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"a8aeef81_3f9e9871","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":29},"in_reply_to":"f5e24a71_dc352e1c","updated":"2023-03-01 04:57:04.000000000","message":"fixed in PS17.","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"16383b47eedb4dd0cc4bb809a1b6ea98e27ca0d7","unresolved":true,"context_lines":[{"line_number":22,"context_line":"#  {reporting_period}:"},{"line_number":23,"context_line":"#    Replaced with reportingPeriod attribute of SOL-API."},{"line_number":24,"context_line":"#  {sub_object_instance_id}:"},{"line_number":25,"context_line":"#    Replaced with a element of subObjectInstanceIds of SOL-API."},{"line_number":26,"context_line":"#  {namespace}:"},{"line_number":27,"context_line":"#    Replaced with the kubernetes namespace that the vnfInstance belongs to."},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"a441cdd0_90cc037e","line":25,"range":{"start_line":25,"start_character":19,"end_line":25,"end_character":20},"updated":"2023-03-01 01:12:44.000000000","message":"nits: a element -\u003e an element","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"997ccf00d2f7e4f3fd30d11a3b095f008e6daf36","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#  {reporting_period}:"},{"line_number":23,"context_line":"#    Replaced with reportingPeriod attribute of SOL-API."},{"line_number":24,"context_line":"#  {sub_object_instance_id}:"},{"line_number":25,"context_line":"#    Replaced with a element of subObjectInstanceIds of SOL-API."},{"line_number":26,"context_line":"#  {namespace}:"},{"line_number":27,"context_line":"#    Replaced with the kubernetes namespace that the vnfInstance belongs to."},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"dc963bce_a8a1e639","line":25,"range":{"start_line":25,"start_character":19,"end_line":25,"end_character":20},"in_reply_to":"812d1935_7d353aa1","updated":"2023-03-02 05:23:35.000000000","message":"Done","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"366e529dcfbd7a1e0b594a11c5a791909bb3fd3b","unresolved":true,"context_lines":[{"line_number":22,"context_line":"#  {reporting_period}:"},{"line_number":23,"context_line":"#    Replaced with reportingPeriod attribute of SOL-API."},{"line_number":24,"context_line":"#  {sub_object_instance_id}:"},{"line_number":25,"context_line":"#    Replaced with a element of subObjectInstanceIds of SOL-API."},{"line_number":26,"context_line":"#  {namespace}:"},{"line_number":27,"context_line":"#    Replaced with the kubernetes namespace that the vnfInstance belongs to."},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"812d1935_7d353aa1","line":25,"range":{"start_line":25,"start_character":19,"end_line":25,"end_character":20},"in_reply_to":"a441cdd0_90cc037e","updated":"2023-03-01 04:57:04.000000000","message":"fixed in PS17.","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"}],"tacker/sol_refactored/common/prometheus_plugin.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"8c7237e7d6efce49e7c0f5f40e3c358577371155","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        return t if t.tzinfo else t.astimezone()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class PrometheusPluginPmBase(PrometheusPlugin):"},{"line_number":60,"context_line":"    def __init__(self):"},{"line_number":61,"context_line":"        super(PrometheusPluginPmBase, self).__init__()"},{"line_number":62,"context_line":"        auth_handle \u003d http_client.NoAuthHandle()"}],"source_content_type":"text/x-python","patch_set":17,"id":"8cb746a0_6254b2e7","line":59,"updated":"2023-03-02 10:23:36.000000000","message":"Curious, why did you split `Base` class? Seems no other child classes.","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"a38134d53355f8a85a7bb2e8f94d9156cf3c8d1f","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        return t if t.tzinfo else t.astimezone()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class PrometheusPluginPmBase(PrometheusPlugin):"},{"line_number":60,"context_line":"    def __init__(self):"},{"line_number":61,"context_line":"        super(PrometheusPluginPmBase, self).__init__()"},{"line_number":62,"context_line":"        auth_handle \u003d http_client.NoAuthHandle()"}],"source_content_type":"text/x-python","patch_set":17,"id":"df45d51a_b7d699d3","line":59,"in_reply_to":"8cb746a0_6254b2e7","updated":"2023-03-02 11:17:56.000000000","message":"This is related to another feature (in patch 872831)\nPrometheusPluginPmBase is common part of PMJob function and PMThreshold function.","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"e4e5666b3f3a6c0832bbb66cbead63881334781f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return t if t.tzinfo else t.astimezone()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class PrometheusPluginPmBase(PrometheusPlugin):"},{"line_number":60,"context_line":"    def __init__(self):"},{"line_number":61,"context_line":"        super(PrometheusPluginPmBase, self).__init__()"},{"line_number":62,"context_line":"        auth_handle \u003d http_client.NoAuthHandle()"}],"source_content_type":"text/x-python","patch_set":17,"id":"98822a3f_f90f4da2","line":59,"in_reply_to":"df45d51a_b7d699d3","updated":"2023-03-02 13:01:39.000000000","message":"I understand.","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"8c7237e7d6efce49e7c0f5f40e3c358577371155","unresolved":true,"context_lines":[{"line_number":259,"context_line":"                    target[\u0027password\u0027], target[\u0027path\u0027], pm_job_or_threshold.id)"},{"line_number":260,"context_line":"            except (sol_ex.PrometheusPluginError, ks_exc.ClientException,"},{"line_number":261,"context_line":"                    paramiko.SSHException):"},{"line_number":262,"context_line":"                # This exception is ignored. DELETE /pm_jobs/{id}"},{"line_number":263,"context_line":"                # will be success even if _delete_rule() is failed."},{"line_number":264,"context_line":"                # Because the rule file was already deleted."},{"line_number":265,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":17,"id":"d218f88a_cf579440","line":262,"updated":"2023-03-02 10:23:36.000000000","message":"```\nNOTE(yourname): This exception is ...\n```","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"e4e5666b3f3a6c0832bbb66cbead63881334781f","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                    target[\u0027password\u0027], target[\u0027path\u0027], pm_job_or_threshold.id)"},{"line_number":260,"context_line":"            except (sol_ex.PrometheusPluginError, ks_exc.ClientException,"},{"line_number":261,"context_line":"                    paramiko.SSHException):"},{"line_number":262,"context_line":"                # This exception is ignored. DELETE /pm_jobs/{id}"},{"line_number":263,"context_line":"                # will be success even if _delete_rule() is failed."},{"line_number":264,"context_line":"                # Because the rule file was already deleted."},{"line_number":265,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":17,"id":"a37ce171_39d633a9","line":262,"in_reply_to":"c4d3be4f_3b7385b0","updated":"2023-03-02 13:01:39.000000000","message":"Done","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"a38134d53355f8a85a7bb2e8f94d9156cf3c8d1f","unresolved":true,"context_lines":[{"line_number":259,"context_line":"                    target[\u0027password\u0027], target[\u0027path\u0027], pm_job_or_threshold.id)"},{"line_number":260,"context_line":"            except (sol_ex.PrometheusPluginError, ks_exc.ClientException,"},{"line_number":261,"context_line":"                    paramiko.SSHException):"},{"line_number":262,"context_line":"                # This exception is ignored. DELETE /pm_jobs/{id}"},{"line_number":263,"context_line":"                # will be success even if _delete_rule() is failed."},{"line_number":264,"context_line":"                # Because the rule file was already deleted."},{"line_number":265,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":17,"id":"c4d3be4f_3b7385b0","line":262,"in_reply_to":"d218f88a_cf579440","updated":"2023-03-02 11:17:56.000000000","message":"Fixed in PS21.","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"0005b285dece52a155b8f62078478517db836a9c","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    def make_prom_ql(self, target, pod, collection_period\u003d30,"},{"line_number":88,"context_line":"                     reporting_period\u003d90, sub_object_instance_id\u003d\u0027*\u0027,"},{"line_number":89,"context_line":"                     pm_type\u003d\u0027PMJob\u0027, namespace\u003d\u0027default\u0027):"},{"line_number":90,"context_line":"        reporting_period \u003d max(reporting_period, 30)"},{"line_number":91,"context_line":"        prom_config \u003d self.load_prom_config()"},{"line_number":92,"context_line":"        expr \u003d prom_config[pm_type][\u0027PromQL\u0027][target].format("},{"line_number":93,"context_line":"            pod\u003dpod,"}],"source_content_type":"text/x-python","patch_set":18,"id":"7761d220_9c8546a6","line":90,"updated":"2023-03-02 02:22:24.000000000","message":"If this \u002730\u0027 means minimum report period, \nI think define it as a constant or write note for this number.\nWhat do you think?","commit_id":"0dbe5defc9046bc0adcbb0fbf23c0a501fcca6e0"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"a5443528b7fb0c6a7fbb8c9db7e7ef80bb00d69f","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    def make_prom_ql(self, target, pod, collection_period\u003d30,"},{"line_number":88,"context_line":"                     reporting_period\u003d90, sub_object_instance_id\u003d\u0027*\u0027,"},{"line_number":89,"context_line":"                     pm_type\u003d\u0027PMJob\u0027, namespace\u003d\u0027default\u0027):"},{"line_number":90,"context_line":"        reporting_period \u003d max(reporting_period, 30)"},{"line_number":91,"context_line":"        prom_config \u003d self.load_prom_config()"},{"line_number":92,"context_line":"        expr \u003d prom_config[pm_type][\u0027PromQL\u0027][target].format("},{"line_number":93,"context_line":"            pod\u003dpod,"}],"source_content_type":"text/x-python","patch_set":18,"id":"38424872_aeab13f8","line":90,"in_reply_to":"34e39896_d8294033","updated":"2023-03-02 06:13:01.000000000","message":"Do you mean about the location of definition for REPORTING_PERIOD_MIN?\nI moved it to L90 in PS20.","commit_id":"0dbe5defc9046bc0adcbb0fbf23c0a501fcca6e0"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"5f99214f01b6a7721ca83a611f4c90a095b3185d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def make_prom_ql(self, target, pod, collection_period\u003d30,"},{"line_number":88,"context_line":"                     reporting_period\u003d90, sub_object_instance_id\u003d\u0027*\u0027,"},{"line_number":89,"context_line":"                     pm_type\u003d\u0027PMJob\u0027, namespace\u003d\u0027default\u0027):"},{"line_number":90,"context_line":"        reporting_period \u003d max(reporting_period, 30)"},{"line_number":91,"context_line":"        prom_config \u003d self.load_prom_config()"},{"line_number":92,"context_line":"        expr \u003d prom_config[pm_type][\u0027PromQL\u0027][target].format("},{"line_number":93,"context_line":"            pod\u003dpod,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9df6bec1_b203aad6","line":90,"in_reply_to":"38424872_aeab13f8","updated":"2023-03-02 06:17:05.000000000","message":"sorry I was looking at it wrong.\nNo problem.","commit_id":"0dbe5defc9046bc0adcbb0fbf23c0a501fcca6e0"},{"author":{"_account_id":32707,"name":"Kenta Fukaya","email":"kenta.fukaya.xv@hco.ntt.co.jp","username":"fukayan"},"change_message_id":"c565f4d0026a748c957ffaebbd8a05c4f4c54889","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    def make_prom_ql(self, target, pod, collection_period\u003d30,"},{"line_number":88,"context_line":"                     reporting_period\u003d90, sub_object_instance_id\u003d\u0027*\u0027,"},{"line_number":89,"context_line":"                     pm_type\u003d\u0027PMJob\u0027, namespace\u003d\u0027default\u0027):"},{"line_number":90,"context_line":"        reporting_period \u003d max(reporting_period, 30)"},{"line_number":91,"context_line":"        prom_config \u003d self.load_prom_config()"},{"line_number":92,"context_line":"        expr \u003d prom_config[pm_type][\u0027PromQL\u0027][target].format("},{"line_number":93,"context_line":"            pod\u003dpod,"}],"source_content_type":"text/x-python","patch_set":18,"id":"34e39896_d8294033","line":90,"in_reply_to":"41c98621_37412d32","updated":"2023-03-02 05:22:40.000000000","message":"Thanks for the correction.\nBut I would like to use \u0027REPORTING_PERIOD_MIN\u0027 in L90.\n\n\n\u003e\u003e reporting_period \u003d max(reporting_period, REPORTING_PERIOD_MIN)","commit_id":"0dbe5defc9046bc0adcbb0fbf23c0a501fcca6e0"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"da12c62001325a916b62523b350612a89953ab84","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    def make_prom_ql(self, target, pod, collection_period\u003d30,"},{"line_number":88,"context_line":"                     reporting_period\u003d90, sub_object_instance_id\u003d\u0027*\u0027,"},{"line_number":89,"context_line":"                     pm_type\u003d\u0027PMJob\u0027, namespace\u003d\u0027default\u0027):"},{"line_number":90,"context_line":"        reporting_period \u003d max(reporting_period, 30)"},{"line_number":91,"context_line":"        prom_config \u003d self.load_prom_config()"},{"line_number":92,"context_line":"        expr \u003d prom_config[pm_type][\u0027PromQL\u0027][target].format("},{"line_number":93,"context_line":"            pod\u003dpod,"}],"source_content_type":"text/x-python","patch_set":18,"id":"41c98621_37412d32","line":90,"in_reply_to":"7761d220_9c8546a6","updated":"2023-03-02 04:45:23.000000000","message":"I made it as constant value in PS19.","commit_id":"0dbe5defc9046bc0adcbb0fbf23c0a501fcca6e0"}],"tacker/tests/functional/sol_kubernetes_v2/paramgen.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"16383b47eedb4dd0cc4bb809a1b6ea98e27ca0d7","unresolved":true,"context_lines":[{"line_number":662,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfIntCp\","},{"line_number":663,"context_line":"               \"PacketOutgoingVnfIntCp\", sub_object_instance_id\u003d\"eth0\"),"},{"line_number":664,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfExtCp\","},{"line_number":665,"context_line":"               \"ByteIncomingVnfExtCp\", sub_object_instance_id\u003d\"eth0\"),"},{"line_number":666,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfExtCp\","},{"line_number":667,"context_line":"               \"PacketIncomingVnfExtCp\", sub_object_instance_id\u003d\"eth0\"),"},{"line_number":668,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfExtCp\","}],"source_content_type":"text/x-python","patch_set":16,"id":"fce55f59_b6baaaa1","line":665,"range":{"start_line":665,"start_character":63,"end_line":665,"end_character":67},"updated":"2023-03-01 01:12:44.000000000","message":"This is just a suggestion; I know these params for FT, but how about VnfIntCp is \"eth0\" and VnfExtCp is \"eth1\" for `sub_object_instance_id`?\nWhat do you think?","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"997ccf00d2f7e4f3fd30d11a3b095f008e6daf36","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfIntCp\","},{"line_number":663,"context_line":"               \"PacketOutgoingVnfIntCp\", sub_object_instance_id\u003d\"eth0\"),"},{"line_number":664,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfExtCp\","},{"line_number":665,"context_line":"               \"ByteIncomingVnfExtCp\", sub_object_instance_id\u003d\"eth0\"),"},{"line_number":666,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfExtCp\","},{"line_number":667,"context_line":"               \"PacketIncomingVnfExtCp\", sub_object_instance_id\u003d\"eth0\"),"},{"line_number":668,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfExtCp\","}],"source_content_type":"text/x-python","patch_set":16,"id":"ad0595aa_dbb149e4","line":665,"range":{"start_line":665,"start_character":63,"end_line":665,"end_character":67},"in_reply_to":"11641133_1e0320fb","updated":"2023-03-02 05:23:35.000000000","message":"Thank you for cooperation! Done.","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"366e529dcfbd7a1e0b594a11c5a791909bb3fd3b","unresolved":true,"context_lines":[{"line_number":662,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfIntCp\","},{"line_number":663,"context_line":"               \"PacketOutgoingVnfIntCp\", sub_object_instance_id\u003d\"eth0\"),"},{"line_number":664,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfExtCp\","},{"line_number":665,"context_line":"               \"ByteIncomingVnfExtCp\", sub_object_instance_id\u003d\"eth0\"),"},{"line_number":666,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfExtCp\","},{"line_number":667,"context_line":"               \"PacketIncomingVnfExtCp\", sub_object_instance_id\u003d\"eth0\"),"},{"line_number":668,"context_line":"        pm_job(callback_uri, inst_id, host_ip, \"VnfExtCp\","}],"source_content_type":"text/x-python","patch_set":16,"id":"11641133_1e0320fb","line":665,"range":{"start_line":665,"start_character":63,"end_line":665,"end_character":67},"in_reply_to":"fce55f59_b6baaaa1","updated":"2023-03-01 04:57:04.000000000","message":"I think that\u0027s a good idea. I accepted it in PS17..","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"}],"tacker/tests/functional/sol_kubernetes_v2/samples/tacker-monitoring-test/Dockerfile":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccadb5d78e11ba8ac01bb6c42443120568d6b981","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# prometheus \u0026 promtool"},{"line_number":44,"context_line":"RUN cd /tmp \u0026\u0026 \\"},{"line_number":45,"context_line":"    wget -q https://github.com/prometheus/prometheus/releases/download/v2.37.5/prometheus-2.37.5.linux-amd64.tar.gz \u0026\u0026 \\"},{"line_number":46,"context_line":"    tar zxf /tmp/prometheus-2.37.5.linux-amd64.tar.gz -C /usr/local/src/\u0026\u0026 \\"},{"line_number":47,"context_line":"    ln -s /usr/local/src/prometheus-2.37.5.linux-amd64/prometheus /usr/bin/prometheus \u0026\u0026 \\"},{"line_number":48,"context_line":"    ln -s /usr/local/src/prometheus-2.37.5.linux-amd64/promtool /usr/bin/promtool"}],"source_content_type":"text/x-dockerfile","patch_set":6,"id":"88290d6f_64c2aa42","line":45,"range":{"start_line":45,"start_character":72,"end_line":45,"end_character":78},"updated":"2023-02-10 14:54:19.000000000","message":"Is it possible to make the version number a variable so that when the version changes, only one change is needed?\n\nlike:\n```\nARG prom_version\u003d\"2.37.5\"\nRUN cd /tmp \u0026\u0026 \\\n    wget -q https://github.com/prometheus/prometheus/releases/download/v${prom_version}/prometheus-${prom_version}.linux-amd64.tar.gz \u0026\u0026 \\\n...\n```","commit_id":"e4d9e18bba470b1e70edff7352726d58d7eb6c85"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cf51e90e93df96456e84fbdc67d81828f0a13800","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# prometheus \u0026 promtool"},{"line_number":44,"context_line":"RUN cd /tmp \u0026\u0026 \\"},{"line_number":45,"context_line":"    wget -q https://github.com/prometheus/prometheus/releases/download/v2.37.5/prometheus-2.37.5.linux-amd64.tar.gz \u0026\u0026 \\"},{"line_number":46,"context_line":"    tar zxf /tmp/prometheus-2.37.5.linux-amd64.tar.gz -C /usr/local/src/\u0026\u0026 \\"},{"line_number":47,"context_line":"    ln -s /usr/local/src/prometheus-2.37.5.linux-amd64/prometheus /usr/bin/prometheus \u0026\u0026 \\"},{"line_number":48,"context_line":"    ln -s /usr/local/src/prometheus-2.37.5.linux-amd64/promtool /usr/bin/promtool"}],"source_content_type":"text/x-dockerfile","patch_set":6,"id":"5ce5a203_4961b18b","line":45,"range":{"start_line":45,"start_character":72,"end_line":45,"end_character":78},"in_reply_to":"3297ae50_1e1731e6","updated":"2023-02-27 07:53:35.000000000","message":"Ack","commit_id":"e4d9e18bba470b1e70edff7352726d58d7eb6c85"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"03e822630037b6b9e7c096205237f6dd6560d73f","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# prometheus \u0026 promtool"},{"line_number":44,"context_line":"RUN cd /tmp \u0026\u0026 \\"},{"line_number":45,"context_line":"    wget -q https://github.com/prometheus/prometheus/releases/download/v2.37.5/prometheus-2.37.5.linux-amd64.tar.gz \u0026\u0026 \\"},{"line_number":46,"context_line":"    tar zxf /tmp/prometheus-2.37.5.linux-amd64.tar.gz -C /usr/local/src/\u0026\u0026 \\"},{"line_number":47,"context_line":"    ln -s /usr/local/src/prometheus-2.37.5.linux-amd64/prometheus /usr/bin/prometheus \u0026\u0026 \\"},{"line_number":48,"context_line":"    ln -s /usr/local/src/prometheus-2.37.5.linux-amd64/promtool /usr/bin/promtool"}],"source_content_type":"text/x-dockerfile","patch_set":6,"id":"3297ae50_1e1731e6","line":45,"range":{"start_line":45,"start_character":72,"end_line":45,"end_character":78},"in_reply_to":"88290d6f_64c2aa42","updated":"2023-02-17 06:03:59.000000000","message":"fixed in PS9.","commit_id":"e4d9e18bba470b1e70edff7352726d58d7eb6c85"}],"tacker/tests/functional/sol_kubernetes_v2/samples/tacker-monitoring-test/rules/.gitkeep":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"16383b47eedb4dd0cc4bb809a1b6ea98e27ca0d7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a52f1eee_1890e45c","updated":"2023-03-01 01:12:44.000000000","message":"Why does `.gitkeep` need to include in the samples dir? Is this needed?\nFYI, `.gitkeep` files are almost non-existent in tacker repos. Only the following.\n`tacker/samples/etsi_getting_started/tosca/sample_vnf_package_csar/Files/images/.gitkeep`","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"997ccf00d2f7e4f3fd30d11a3b095f008e6daf36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5ef93bdc_dae5f0ac","in_reply_to":"60144db1_078ddea8","updated":"2023-03-02 05:23:35.000000000","message":"Thanks for your reply, I understood that it needs for this dir and `.gitkeep` file.\nDone","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"366e529dcfbd7a1e0b594a11c5a791909bb3fd3b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"60144db1_078ddea8","in_reply_to":"a52f1eee_1890e45c","updated":"2023-03-01 04:57:04.000000000","message":"This is essential because this empty dir is used for storeing rule files in FT.\nThese files are sent from tacker. To keep empty dir on git, .gitkeep is used.\n\ntacker/tests/functional/sol_kubernetes_v2/samples/tacker-monitoring-test/rules/ is binded to /etc/prometheus/rules in the pseudo-prometheus container.","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"}],"tacker/tests/functional/sol_kubernetes_v2/samples/tacker-monitoring-test/src/testserver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ccadb5d78e11ba8ac01bb6c42443120568d6b981","unresolved":true,"context_lines":[{"line_number":55,"context_line":"class PeriodicTask():"},{"line_number":56,"context_line":"    def __init__(self):"},{"line_number":57,"context_line":"        self.remote_url \u003d os.getenv(\u0027TEST_REMOTE_URI\u0027)"},{"line_number":58,"context_line":"        print(\"url: \" + str(self.remote_url))"},{"line_number":59,"context_line":"        self.schedule_next()"},{"line_number":60,"context_line":"        self.stored_alerts_fm \u003d {}"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"10b0314a_7d99b9e6","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":23},"updated":"2023-02-10 14:54:19.000000000","message":"Could you use f-string instead of string concatenation using \"+\"?\nIf you change here, please apply it to other parts of this file.","commit_id":"e4d9e18bba470b1e70edff7352726d58d7eb6c85"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"03e822630037b6b9e7c096205237f6dd6560d73f","unresolved":true,"context_lines":[{"line_number":55,"context_line":"class PeriodicTask():"},{"line_number":56,"context_line":"    def __init__(self):"},{"line_number":57,"context_line":"        self.remote_url \u003d os.getenv(\u0027TEST_REMOTE_URI\u0027)"},{"line_number":58,"context_line":"        print(\"url: \" + str(self.remote_url))"},{"line_number":59,"context_line":"        self.schedule_next()"},{"line_number":60,"context_line":"        self.stored_alerts_fm \u003d {}"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8b7c771f_5c4072d3","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":23},"in_reply_to":"10b0314a_7d99b9e6","updated":"2023-02-17 06:03:59.000000000","message":"fixed in PS9.","commit_id":"e4d9e18bba470b1e70edff7352726d58d7eb6c85"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cf51e90e93df96456e84fbdc67d81828f0a13800","unresolved":false,"context_lines":[{"line_number":55,"context_line":"class PeriodicTask():"},{"line_number":56,"context_line":"    def __init__(self):"},{"line_number":57,"context_line":"        self.remote_url \u003d os.getenv(\u0027TEST_REMOTE_URI\u0027)"},{"line_number":58,"context_line":"        print(\"url: \" + str(self.remote_url))"},{"line_number":59,"context_line":"        self.schedule_next()"},{"line_number":60,"context_line":"        self.stored_alerts_fm \u003d {}"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"0a224939_cea05930","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":23},"in_reply_to":"8b7c771f_5c4072d3","updated":"2023-02-27 07:53:35.000000000","message":"Ack","commit_id":"e4d9e18bba470b1e70edff7352726d58d7eb6c85"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"feaf0536b603c893ea970df9f83c166615b0a44f","unresolved":true,"context_lines":[{"line_number":251,"context_line":"            self.send_response(response[0], response[1])"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"peroidic_task \u003d PeriodicTask()"},{"line_number":255,"context_line":"server \u003d HTTPServer((\u00270.0.0.0\u0027, PORT), TestHttpServer)"},{"line_number":256,"context_line":"server.serve_forever()"}],"source_content_type":"text/x-python","patch_set":14,"id":"6f7710c3_ab2b0da2","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":8},"updated":"2023-02-24 07:15:43.000000000","message":"typo\nperoidic -\u003e periodic","commit_id":"10c6405f6f5d2fd66ee55850cea5d13f517644d8"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"59c06c0fbc21ce16c57003e729da0c1f20355844","unresolved":true,"context_lines":[{"line_number":251,"context_line":"            self.send_response(response[0], response[1])"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"peroidic_task \u003d PeriodicTask()"},{"line_number":255,"context_line":"server \u003d HTTPServer((\u00270.0.0.0\u0027, PORT), TestHttpServer)"},{"line_number":256,"context_line":"server.serve_forever()"}],"source_content_type":"text/x-python","patch_set":14,"id":"da08551f_45dbff1e","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":8},"in_reply_to":"6f7710c3_ab2b0da2","updated":"2023-02-24 13:56:47.000000000","message":"fixed in PS16.","commit_id":"10c6405f6f5d2fd66ee55850cea5d13f517644d8"},{"author":{"_account_id":35476,"name":"taiki kimura","email":"taiki.kimura@ntt-at.co.jp","username":"tkimura"},"change_message_id":"3d706fdaa856e17fcd19b12ef403180beccaca90","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            self.send_response(response[0], response[1])"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"peroidic_task \u003d PeriodicTask()"},{"line_number":255,"context_line":"server \u003d HTTPServer((\u00270.0.0.0\u0027, PORT), TestHttpServer)"},{"line_number":256,"context_line":"server.serve_forever()"}],"source_content_type":"text/x-python","patch_set":14,"id":"76cebb07_fe14998d","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":8},"in_reply_to":"da08551f_45dbff1e","updated":"2023-02-27 08:34:08.000000000","message":"Done","commit_id":"10c6405f6f5d2fd66ee55850cea5d13f517644d8"}],"tacker/tests/unit/sol_refactored/common/test_prometheus_plugin.py":[{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"16383b47eedb4dd0cc4bb809a1b6ea98e27ca0d7","unresolved":true,"context_lines":[{"line_number":495,"context_line":"        # error"},{"line_number":496,"context_line":"        resp.status_code \u003d 503"},{"line_number":497,"context_line":"        pp.delete_job(context\u003dself.context, pm_job\u003djob)"},{"line_number":498,"context_line":"        # paramikoerror"},{"line_number":499,"context_line":"        resp.status_code \u003d 202"},{"line_number":500,"context_line":"        mock_paramiko.return_value \u003d _ParamikoTest("},{"line_number":501,"context_line":"            exp\u003dsol_ex.PrometheusPluginError())"}],"source_content_type":"text/x-python","patch_set":16,"id":"e3a49a7d_2ead4b9d","line":498,"updated":"2023-03-01 01:12:44.000000000","message":"nits: paramikoerror -\u003e paramiko error","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":34712,"name":"Yuta Kazato","display_name":"Yuta Kazato","email":"yuta.kazato.nw@hco.ntt.co.jp","username":"kazatoy-ntt"},"change_message_id":"997ccf00d2f7e4f3fd30d11a3b095f008e6daf36","unresolved":false,"context_lines":[{"line_number":495,"context_line":"        # error"},{"line_number":496,"context_line":"        resp.status_code \u003d 503"},{"line_number":497,"context_line":"        pp.delete_job(context\u003dself.context, pm_job\u003djob)"},{"line_number":498,"context_line":"        # paramikoerror"},{"line_number":499,"context_line":"        resp.status_code \u003d 202"},{"line_number":500,"context_line":"        mock_paramiko.return_value \u003d _ParamikoTest("},{"line_number":501,"context_line":"            exp\u003dsol_ex.PrometheusPluginError())"}],"source_content_type":"text/x-python","patch_set":16,"id":"fb54c757_c6ec5285","line":498,"in_reply_to":"d5e91d5a_711fd194","updated":"2023-03-02 05:23:35.000000000","message":"Done","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"366e529dcfbd7a1e0b594a11c5a791909bb3fd3b","unresolved":true,"context_lines":[{"line_number":495,"context_line":"        # error"},{"line_number":496,"context_line":"        resp.status_code \u003d 503"},{"line_number":497,"context_line":"        pp.delete_job(context\u003dself.context, pm_job\u003djob)"},{"line_number":498,"context_line":"        # paramikoerror"},{"line_number":499,"context_line":"        resp.status_code \u003d 202"},{"line_number":500,"context_line":"        mock_paramiko.return_value \u003d _ParamikoTest("},{"line_number":501,"context_line":"            exp\u003dsol_ex.PrometheusPluginError())"}],"source_content_type":"text/x-python","patch_set":16,"id":"d5e91d5a_711fd194","line":498,"in_reply_to":"e3a49a7d_2ead4b9d","updated":"2023-03-01 04:57:04.000000000","message":"fixed in PS17.","commit_id":"a5541b916c3c5b809c7842687e1ae54b30966668"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"8c7237e7d6efce49e7c0f5f40e3c358577371155","unresolved":true,"context_lines":[{"line_number":713,"context_line":"    @mock.patch.object(paramiko.SFTPClient, \u0027from_transport\u0027)"},{"line_number":714,"context_line":"    @mock.patch.object(paramiko, \u0027Transport\u0027)"},{"line_number":715,"context_line":"    @mock.patch.object(inst_utils, \u0027get_inst\u0027)"},{"line_number":716,"context_line":"    def test_create_job_error2("},{"line_number":717,"context_line":"            self, mock_inst, mock_paramiko, mock_sftp, mock_do_request,"},{"line_number":718,"context_line":"            mock_sshclient):"},{"line_number":719,"context_line":"        mock_paramiko.return_value \u003d _ParamikoTest()"}],"source_content_type":"text/x-python","patch_set":17,"id":"f8dad6d8_897fd11c","line":716,"updated":"2023-03-02 10:23:36.000000000","message":"Better to rename to a name that explains the difference from `test_create_job_error`.","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"e4e5666b3f3a6c0832bbb66cbead63881334781f","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    @mock.patch.object(paramiko.SFTPClient, \u0027from_transport\u0027)"},{"line_number":714,"context_line":"    @mock.patch.object(paramiko, \u0027Transport\u0027)"},{"line_number":715,"context_line":"    @mock.patch.object(inst_utils, \u0027get_inst\u0027)"},{"line_number":716,"context_line":"    def test_create_job_error2("},{"line_number":717,"context_line":"            self, mock_inst, mock_paramiko, mock_sftp, mock_do_request,"},{"line_number":718,"context_line":"            mock_sshclient):"},{"line_number":719,"context_line":"        mock_paramiko.return_value \u003d _ParamikoTest()"}],"source_content_type":"text/x-python","patch_set":17,"id":"9fdd7fee_71f8ab0f","line":716,"in_reply_to":"4937f193_d6d438e4","updated":"2023-03-02 13:01:39.000000000","message":"Done","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"a38134d53355f8a85a7bb2e8f94d9156cf3c8d1f","unresolved":true,"context_lines":[{"line_number":713,"context_line":"    @mock.patch.object(paramiko.SFTPClient, \u0027from_transport\u0027)"},{"line_number":714,"context_line":"    @mock.patch.object(paramiko, \u0027Transport\u0027)"},{"line_number":715,"context_line":"    @mock.patch.object(inst_utils, \u0027get_inst\u0027)"},{"line_number":716,"context_line":"    def test_create_job_error2("},{"line_number":717,"context_line":"            self, mock_inst, mock_paramiko, mock_sftp, mock_do_request,"},{"line_number":718,"context_line":"            mock_sshclient):"},{"line_number":719,"context_line":"        mock_paramiko.return_value \u003d _ParamikoTest()"}],"source_content_type":"text/x-python","patch_set":17,"id":"4937f193_d6d438e4","line":716,"in_reply_to":"f8dad6d8_897fd11c","updated":"2023-03-02 11:17:56.000000000","message":"Renamed in PS21.","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"8c7237e7d6efce49e7c0f5f40e3c358577371155","unresolved":true,"context_lines":[{"line_number":789,"context_line":"    @mock.patch.object(paramiko.SFTPClient, \u0027from_transport\u0027)"},{"line_number":790,"context_line":"    @mock.patch.object(paramiko, \u0027Transport\u0027)"},{"line_number":791,"context_line":"    @mock.patch.object(inst_utils, \u0027get_inst\u0027)"},{"line_number":792,"context_line":"    def test_promql2("},{"line_number":793,"context_line":"            self, mock_inst, mock_paramiko, mock_sftp, mock_do_request,"},{"line_number":794,"context_line":"            mock_sshclient):"},{"line_number":795,"context_line":"        mock_paramiko.return_value \u003d _ParamikoTest()"}],"source_content_type":"text/x-python","patch_set":17,"id":"809ce75e_e6d37fbc","line":792,"updated":"2023-03-02 10:23:36.000000000","message":"Better to rename to a name that explains the difference from `test_promql`.","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":35016,"name":"Koji Shimizu","email":"shimizu.koji@fujitsu.com","username":"shimizu-koji"},"change_message_id":"a38134d53355f8a85a7bb2e8f94d9156cf3c8d1f","unresolved":true,"context_lines":[{"line_number":789,"context_line":"    @mock.patch.object(paramiko.SFTPClient, \u0027from_transport\u0027)"},{"line_number":790,"context_line":"    @mock.patch.object(paramiko, \u0027Transport\u0027)"},{"line_number":791,"context_line":"    @mock.patch.object(inst_utils, \u0027get_inst\u0027)"},{"line_number":792,"context_line":"    def test_promql2("},{"line_number":793,"context_line":"            self, mock_inst, mock_paramiko, mock_sftp, mock_do_request,"},{"line_number":794,"context_line":"            mock_sshclient):"},{"line_number":795,"context_line":"        mock_paramiko.return_value \u003d _ParamikoTest()"}],"source_content_type":"text/x-python","patch_set":17,"id":"bb2077ab_e99088e5","line":792,"in_reply_to":"809ce75e_e6d37fbc","updated":"2023-03-02 11:17:56.000000000","message":"renamed in PS21.","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"e4e5666b3f3a6c0832bbb66cbead63881334781f","unresolved":false,"context_lines":[{"line_number":789,"context_line":"    @mock.patch.object(paramiko.SFTPClient, \u0027from_transport\u0027)"},{"line_number":790,"context_line":"    @mock.patch.object(paramiko, \u0027Transport\u0027)"},{"line_number":791,"context_line":"    @mock.patch.object(inst_utils, \u0027get_inst\u0027)"},{"line_number":792,"context_line":"    def test_promql2("},{"line_number":793,"context_line":"            self, mock_inst, mock_paramiko, mock_sftp, mock_do_request,"},{"line_number":794,"context_line":"            mock_sshclient):"},{"line_number":795,"context_line":"        mock_paramiko.return_value \u003d _ParamikoTest()"}],"source_content_type":"text/x-python","patch_set":17,"id":"830283ba_5dc52f53","line":792,"in_reply_to":"bb2077ab_e99088e5","updated":"2023-03-02 13:01:39.000000000","message":"Done","commit_id":"f9175b7abd3ce395511a147cf95a2e30fa50ef2e"}]}